zandobersek@gmail.com [Wed, 27 Nov 2013 13:04:26 +0000 (13:04 +0000)]
[GTK] Programs/WebKit2APITests/TestWebKitSettings unit test is failing
https://bugs.webkit.org/show_bug.cgi?id=124924
Reviewed by Carlos Garcia Campos.
'Chrome'/'Chromium' substrings were removed from the user agent string in r159572, meaning the unit
test shouldn't check for those two substrings anymore. Instead, 'Safari' (as until now) and 'AppleWebKit'
substrings should be checked for.
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettingsUserAgent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
calvaris@igalia.com [Wed, 27 Nov 2013 10:47:56 +0000 (10:47 +0000)]
[GStreamer] Invalid command line error when visiting chessbase.com
https://bugs.webkit.org/show_bug.cgi?id=124715
Reviewed by Philippe Normand.
Source/WebCore:
We were not handling the HTTP errors in the WebKit GStreamer
source and therefore the 404 error page was being 'decoded'. As no
decoder could be found (for obvious reasons), playback failed, but
it should be failing for the source not being found instead of the
decoding problem.
Test: http/tests/media/video-error-does-not-exist.html
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::handleResponseReceived): Handle HTTP errors in
the source and raise a GStreamer error to the pipeline.
LayoutTests:
Copied and adapted for HTTP from
media/video-error-does-not-exist.html.
* http/tests/media/video-error-does-not-exist-expected.txt: Added.
* http/tests/media/video-error-does-not-exist.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
svillar@igalia.com [Wed, 27 Nov 2013 08:43:07 +0000 (08:43 +0000)]
[CSS Grid Layout] Fix positioning of grid items with margins
https://bugs.webkit.org/show_bug.cgi?id=124345
Reviewed by David Hyatt.
From Blink r157925 and r158041 by <jchaffraix@chromium.org>
Source/WebCore:
Test: fast/css-grid-layout/grid-item-margin-resolution.html
Adds margin start/before to the positions of grid items (removing
several FIXME's in the current code). This means calling
findChildLogicalPosition() after the layout in order to have the
right values for the margins.
In order to match flexbox and author's intents we're also
including the margins of grid items in the intrinsic size of the
grid. That's why flexbox's marginLogicalPositionForChild() is
moved up to RenderBlock in order to share it with RenderGrid.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::marginIntrinsicLogicalWidthForChild): Moved
from RenderFlexibleBox::marginLogicalWidthForChild().
* rendering/RenderBlock.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computePreferredTrackWidth):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::findChildLogicalPosition):
LayoutTests:
New test case for grid items margin resolution. Extended the
preferred logical widths checks with grid items with margins.
* fast/css-grid-layout/grid-item-margin-resolution-expected.txt: Added.
* fast/css-grid-layout/grid-item-margin-resolution.html: Added.
* fast/css-grid-layout/grid-preferred-logical-widths-expected.txt:
* fast/css-grid-layout/grid-preferred-logical-widths.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
svillar@igalia.com [Wed, 27 Nov 2013 08:31:14 +0000 (08:31 +0000)]
[CSS Grid Layout] Support grid-definition-{rows|columns} repeat() syntax
https://bugs.webkit.org/show_bug.cgi?id=103312
Reviewed by Andreas Kling.
PerformanceTests:
Use the repeat() syntax to build the huge grids used by the
performance tests.
* Layout/auto-grid-lots-of-data.html:
* Layout/fixed-grid-lots-of-data.html:
Source/WebCore:
Added support for the repeat() syntax inside
grid-definition-{rows|columns} by just adding the repeated values
to our list of column|row definitions.
The parsing of <track-name> was refactored in a new function as
it's used now in three different places. The <track-size> parsing
was also refactored to share it with the repeat() parsing.
Test: fast/css-grid-layout/grid-element-repeat-get-set.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTrackNames):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseGridTrackRepeatFunction):
(WebCore::CSSParser::parseGridTrackSize):
* css/CSSParser.h:
LayoutTests:
Based on Blink r153155 by <jchaffraix@chromium.org>. Some code was
refactored in a helper function to have a more compact test.
* fast/css-grid-layout/grid-element-repeat-get-set-expected.txt: Added.
* fast/css-grid-layout/grid-element-repeat-get-set.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 27 Nov 2013 06:14:46 +0000 (06:14 +0000)]
Windows rebaselines after r158547.
* platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
* platform/win/editing/selection/drag-text-delay-expected.txt: Added.
* platform/win/editing/selection/extend-selection-home-end-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
marcelo.lira@openbossa.org [Wed, 27 Nov 2013 06:05:27 +0000 (06:05 +0000)]
Nix upstreaming - Adding build files and supporting scripts
https://bugs.webkit.org/show_bug.cgi?id=118367
Reviewed by Ryosuke Niwa.
.:
* CMakeLists.txt:
* Source/CMakeLists.txt:
* Source/cmake/FindEGL.cmake:
* Source/cmake/FindOpenGLES2.cmake: Added.
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/OptionsNix.cmake: Added.
Source/Platform:
* CMakeLists.txt: Added.
* PlatformNix.cmake: Added.
Source/WebCore:
No new tests needed.
* CMakeLists.txt:
* PlatformNix.cmake: Added.
Source/WTF:
* wtf/FeatureDefines.h:
* wtf/Platform.h:
* wtf/PlatformNix.cmake: Added.
Tools:
* Scripts/build-webkit:
* Scripts/run-nix-tests: Added.
* Scripts/run-webkit-tests:
* Scripts/update-webkit-libs-jhbuild:
* Scripts/update-webkitnix-libs: Added.
* Scripts/webkitdirs.pm:
(determineArchitecture):
(argumentsForConfiguration):
(jscProductDir):
(builtDylibPathForName):
(determineIsNix):
(isNix):
(isAppleWebKit):
(launcherPath):
(launcherName):
(checkRequiredSystemConfig):
(copyInspectorFrontendFiles):
(jhbuildWrapperPrefixIfNeeded):
(buildCMakeProjectOrExit):
(cmakeBasedPortName):
* Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(EflWK2Port.build_webkit_command):
(NixPort):
(NixPort.build_webkit_command):
* Scripts/webkitpy/port/factory.py:
(platform_options):
(PortFactory):
* Scripts/webkitpy/port/nix.py: Added.
(NixPort):
(NixPort._wk2_port_name):
(NixPort.determine_full_port_name):
(NixPort.__init__):
(NixPort._port_flag_for_scripts):
(NixPort.setup_test_run):
(NixPort.setup_environ_for_server):
(NixPort.default_timeout_ms):
(NixPort.clean_up_test_run):
(NixPort._generate_all_test_configurations):
(NixPort._path_to_driver):
(NixPort._path_to_image_diff):
(NixPort._image_diff_command):
(NixPort._search_paths):
(NixPort.show_results_html_file):
(NixPort._port_specific_expectations_files):
(NixPort.default_baseline_search_path):
* Scripts/webkitpy/port/nix_unittest.py: Added.
(NixPortTest):
(NixPortTest._assert_search_path):
(NixPortTest._assert_expectations_files):
(NixPortTest.test_baseline_search_path):
(NixPortTest.test_expectations_files):
(NixPortTest.test_default_timeout_ms):
* jhbuild/jhbuild-wrapper:
(determine_platform):
* nix/common.py: Added.
(script_path):
(top_level_path):
* nix/jhbuild.modules: Added.
* nix/jhbuildrc: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 27 Nov 2013 05:33:17 +0000 (05:33 +0000)]
Record subtest values in Dromaeo tests
https://bugs.webkit.org/show_bug.cgi?id=124498
Reviewed by Andreas Kling.
PerformanceTests:
Made Dromaeo's test runner report values in DRT.progress via newly added PerfTestRunner.reportValues.
* Dromaeo/resources/dromaeorunner.js:
(.): Moved the definition out of DRT.setup.
(DRT.setup): Ditto.
(DRT.testObject): Extracted from DRT.setup. Set the subtest name and continueTesting.
continueTesting is set true for subtests; i.e. when name is specified.
(DRT.progress): Call PerfTestRunner.reportValues to report subtest results.
(DRT.teardown): Call PerfTestRunner.reportValues instead of measureValueAsync.
* resources/runner.js: Made various changes for newly added PerfTestRunner.reportValues.
(.): Moved the initialization of completedIterations, results, jsHeapResults, and mallocHeapResults into
start since they need to be initialized before running each subtest. Initialize logLines here since we
need to use the same logger for all subtests.
(.start): Initialize the variables mentioned above here. Also respect doNotLogStart used by reportValues.
(ignoreWarmUpAndLog): Added doNotLogProgress. Used by reportValues since it reports all values at once.
(finish): Compute the metric name such as FrameFrame and Runs from unit. Also don't log or notify done
when continueTesting is set on the test object.
(PerfTestRunner.reportValues): Added. Reports all values for the main/sub test.
Tools:
Supported parsing subtest results.
* Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
which contains a dictionary with its name and an ordered list of subtest's metrics.
(PerfTest.__init__): Initialize _metrics as a list.
(PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
(PerfTest._run_with_driver):
(PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
(TestPerfTest.test_parse_output): Ditto.
(TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
assertions to ensure subtest results are parsed properly.
(TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
adding new results.
* Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(TestWithSubtestsData): Added.
(TestDriver.run_test):
(MainTest.test_run_test_with_subtests): Added.
LayoutTests:
Rebaselined the test.
* fast/harness/perftests/runs-per-second-log-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 27 Nov 2013 05:13:51 +0000 (05:13 +0000)]
Enable HTML template element on Windows ports
https://bugs.webkit.org/show_bug.cgi?id=124758
Reviewed by Andreas Kling.
Tools:
* Scripts/webkitperl/FeatureList.pm:
WebKitLibraries:
Enable TEMPLATE_ELEMENT. Also removed UNDO_MANAGER since that feature has been removed
from the tree in r133326.
* win/tools/vsprops/FeatureDefines.props:
* win/tools/vsprops/FeatureDefinesCairo.props:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 27 Nov 2013 04:36:18 +0000 (04:36 +0000)]
Remove replay performance tests as it's not actively maintained
https://bugs.webkit.org/show_bug.cgi?id=124764
Reviewed by Andreas Kling.
PerformanceTests:
Removed the replay performance tests. We can add them back when time comes.
* Replay/Chinese/chinaz.com.replay: Removed.
* Replay/Chinese/www.163.com.replay: Removed.
* Replay/Chinese/www.alipay.com.replay: Removed.
* Replay/Chinese/www.baidu.com.replay: Removed.
* Replay/Chinese/www.csdn.net.replay: Removed.
* Replay/Chinese/www.douban.com.replay: Removed.
* Replay/Chinese/www.hao123.com.replay: Removed.
* Replay/Chinese/www.xinhuanet.com.replay: Removed.
* Replay/Chinese/www.xunlei.com.replay: Removed.
* Replay/Chinese/www.youku.com.replay: Removed.
* Replay/English/beatonna.livejournal.com.replay: Removed.
* Replay/English/cakewrecks.blogspot.com.replay: Removed.
* Replay/English/chemistry.about.com.replay: Removed.
* Replay/English/digg.com.replay: Removed.
* Replay/English/en.wikipedia.org-rorschach_test.replay: Removed.
* Replay/English/icanhascheezburger.com.replay: Removed.
* Replay/English/imgur.com-gallery.replay: Removed.
* Replay/English/online.wsj.com.replay: Removed.
* Replay/English/stockoverflow.com-best-comment.replay: Removed.
* Replay/English/www.alibaba.com.replay: Removed.
* Replay/English/www.amazon.com-kindle.replay: Removed.
* Replay/English/www.apple.com.replay: Removed.
* Replay/English/www.cnet.com.replay: Removed.
* Replay/English/www.dailymotion.com.replay: Removed.
* Replay/English/www.ehow.com-prevent-fire.replay: Removed.
* Replay/English/www.filestube.com-amy-adams.replay: Removed.
* Replay/English/www.foxnews.replay: Removed.
* Replay/English/www.huffingtonpost.com.replay: Removed.
* Replay/English/www.imdb.com-twilight.replay: Removed.
* Replay/English/www.mozilla.com-all-order.replay: Removed.
* Replay/English/www.php.net.replay: Removed.
* Replay/English/www.reddit.com.replay: Removed.
* Replay/English/www.telegraph.co.uk.replay: Removed.
* Replay/English/www.w3.org-htmlcss.replay: Removed.
* Replay/English/www.w3schools.com-html.replay: Removed.
* Replay/English/www.youtube.com-music.replay: Removed.
* Replay/French/www.orange.fr.replay: Removed.
* Replay/Italian/www.repubblica.it.replay: Removed.
* Replay/Japanese/2ch.net-newsplus.replay: Removed.
* Replay/Japanese/entameblog.seesaa.net.replay: Removed.
* Replay/Japanese/ja.wikipedia.org.replay: Removed.
* Replay/Japanese/www.hatena.ne.jp.replay: Removed.
* Replay/Japanese/www.livedoor.com.replay: Removed.
* Replay/Japanese/www.nicovideo.jp.replay: Removed.
* Replay/Japanese/www.rakuten.co.jp.replay: Removed.
* Replay/Japanese/www.yahoo.co.jp.replay: Removed.
* Replay/Korean/www.naver.com.replay: Removed.
* Replay/Persian/blogfa.com.replay: Removed.
* Replay/Polish/www.wp.pl.replay: Removed.
* Replay/Portuguese/www.uol.com.br.replay: Removed.
* Replay/Russian/lenta.ru.replay: Removed.
* Replay/Russian/vkontakte.ru-help.replay: Removed.
* Replay/Russian/www.ixbt.com.replay: Removed.
* Replay/Russian/www.kp.ru.replay: Removed.
* Replay/Russian/www.liveinternet.ru.replay: Removed.
* Replay/Russian/www.pravda.ru.replay: Removed.
* Replay/Russian/www.rambler.ru.replay: Removed.
* Replay/Russian/www.ucoz.ru.replay: Removed.
* Replay/Russian/www.yandex.ru.replay: Removed.
* Replay/Spanish/www.taringa.net.replay: Removed.
* Replay/Swedish/www.flashback.se.replay: Removed.
* Replay/Swedish/www.tradera.com.replay: Removed.
* Replay/www.google.com.replay: Removed.
* Replay/www.techcrunch.com.replay: Removed.
* Replay/www.youtube.com.replay: Removed.
Tools:
Removed the feature.
* Scripts/webkitpy/performance_tests/perftest.py:
(SingleProcessPerfTest.__init__):
(PerfTestFactory):
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._collect_tests):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_collect_tests_with_ignored_skipped_list):
(MainTest.test_default_args):
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_unittest2):
* Scripts/webkitpy/thirdparty/__init___unittest.py:
(ThirdpartyTest.test_imports):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 27 Nov 2013 04:32:51 +0000 (04:32 +0000)]
Import W3C tests for cloning template elements and default stylesheet for template element
https://bugs.webkit.org/show_bug.cgi?id=124882
Reviewed by Andreas Kling.
Imported tests under html-templates/additions-to-the-steps-to-clone-a-node and
html-templates/additions-to-the-css-user-agent-style-sheet at
d38dbd5b492808811bc0fe04a8cc49f28863c5cc.
Renamed and replicated css-user-agent-style-sheet-test-001-ref.html as -00*-expected.html for ref testing.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-001-expected.html: Added.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-001.html: Added.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-002-expected.html: Added.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-002.html: Added.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-003-expected.html: Added.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-003.html: Added.
* html-templates/additions-to-the-steps-to-clone-a-node/template-clone-children-expected.txt: Added.
* html-templates/additions-to-the-steps-to-clone-a-node/template-clone-children.html: Added.
* html-templates/additions-to-the-steps-to-clone-a-node/templates-copy-document-owner-expected.txt: Added.
* html-templates/additions-to-the-steps-to-clone-a-node/templates-copy-document-owner.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 27 Nov 2013 04:05:12 +0000 (04:05 +0000)]
Enable aggressive DFG validation in testing
https://bugs.webkit.org/show_bug.cgi?id=124911
Rubber stamped by Ryosuke Niwa.
This enables validation testing in non-concurrent-JIT runs.
* Scripts/run-jsc-stress-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Wed, 27 Nov 2013 03:50:06 +0000 (03:50 +0000)]
Don't parent the TileController root layer in two places
https://bugs.webkit.org/show_bug.cgi?id=124873
Reviewed by Brent Fulgham.
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
The TileController's layer is already parented by callers of
TileController::create, and in a special way. TileController
shouldn't parent itself, anyway...
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 27 Nov 2013 03:35:14 +0000 (03:35 +0000)]
ASSERT_WITH_SECURITY_IMPLICATION should crash in a distinct way.
https://bugs.webkit.org/show_bug.cgi?id=124757
Change ASSERT_WITH_SECURITY_IMPLICATION to access a different address from CRASH()
in order to help screen fuzzing bugs.
Patch by Drew Yao <ayao@apple.com> on 2013-11-26
Reviewed by Brent Fulgham.
* wtf/Assertions.cpp:
* wtf/Assertions.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 27 Nov 2013 02:47:43 +0000 (02:47 +0000)]
Restructure global variable constant inference so that it could work for any kind of symbol table variable
https://bugs.webkit.org/show_bug.cgi?id=124760
Reviewed by Oliver Hunt.
This changes the way global variable constant inference works so that it can be reused
for closure variable constant inference. Some of the premises that originally motivated
this patch are somewhat wrong, but it led to some simplifications anyway and I suspect
that we'll be able to fix those premises in the future. The main point of this patch is
to make it easy to reuse global variable constant inference for closure variable
constant inference, and this will be possible provided we can also either (a) infer
one-shot closures (easy) or (b) infer closure variables that are always assigned prior
to first use.
One of the things that this patch is meant to enable is constant inference for closure
variables that may be part of a multi-shot closure. Closure variables may be
instantiated multiple times, like:
function foo() {
var WIDTH = 45;
function bar() {
... use WIDTH ...
}
...
}
Even if foo() is called many times and WIDTH is assigned to multiple times, that
doesn't change the fact that it's a constant. The goal of closure variable constant
inference is to catch any case where a closure variable has been assigned at least once
and its value has never changed. This patch doesn't implement that, but it does change
global variable constant inference to have most of the powers needed to do that. Note
that most likely we will use this functionality only to implement constant inference
for one-shot closures, but the resulting machinery is still simpler than what we had
before.
This involves three changes:
- The watchpoint object now contains the inferred value. This involves creating a
new kind of watchpoint set, the VariableWatchpointSet. We will reuse this object
for closure variables.
- Writing to a variable that is watchpointed still involves these three states that
we proceed through monotonically (Uninitialized->Initialized->Invalidated) but
now, the Initialized->Invalidated state transition only happens if we change the
variable's value, rather than store to the variable. Repeatedly storing the same
value won't change the variable's state.
- On 64-bit systems (the only systems on which we do concurrent JIT), you no longer
need fancy fencing to get a consistent view of the watchpoint in the JIT. The
state of the VariableWatchpointSet for the purposes of constant folding is
entirely encapsulated in the VariableWatchpointSet::m_inferredValue. If that is
JSValue() then you cannot fold (either because the set is uninitialized or
because it's invalidated - doesn't matter which); on the other hand if the value
is anything other than JSValue() then you can fold, and that's the value you fold
to. Simple!
This also changes the way that DFG IR deals with variable watchpoints. It's now
oblivious to global variables. You install a watchpoint using VariableWatchpoint and
you notify write using NotifyWrite. Easy!
Note that this will requires some more tweaks because of the fact that op_enter will
store Undefined into every captured variable. Hence it won't even work for one-shot
closures. One-shot closures are easily fixed by introducing another state (so we'll
have Uninitialized->Undefined->Initialized->Invalidated). Multi-shot closures will
require static analysis. One-shot closures are clearly a higher priority.
* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/Instruction.h:
* bytecode/VariableWatchpointSet.h: Added.
(JSC::VariableWatchpointSet::VariableWatchpointSet):
(JSC::VariableWatchpointSet::~VariableWatchpointSet):
(JSC::VariableWatchpointSet::inferredValue):
(JSC::VariableWatchpointSet::notifyWrite):
(JSC::VariableWatchpointSet::invalidate):
(JSC::VariableWatchpointSet::finalizeUnconditionally):
(JSC::VariableWatchpointSet::addressOfInferredValue):
* bytecode/Watchpoint.h:
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasRegisterPointer):
(JSC::DFG::Node::hasVariableWatchpointSet):
(JSC::DFG::Node::variableWatchpointSet):
* dfg/DFGNodeType.h:
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithMod):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGWatchpointCollectionPhase.cpp:
(JSC::DFG::WatchpointCollectionPhase::handle):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNotifyWrite):
* jit/JIT.h:
* jit/JITOperations.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitNotifyWrite):
(JSC::JIT::emitPutGlobalVar):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitNotifyWrite):
(JSC::JIT::emitPutGlobalVar):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::addGlobalVar):
(JSC::JSGlobalObject::addFunction):
* runtime/JSGlobalObject.h:
* runtime/JSScope.h:
(JSC::ResolveOp::ResolveOp):
* runtime/JSSymbolTableObject.h:
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):
* runtime/SymbolTable.cpp:
(JSC::SymbolTableEntry::inferredValue):
(JSC::SymbolTableEntry::prepareToWatch):
(JSC::SymbolTableEntry::addWatchpoint):
(JSC::SymbolTableEntry::notifyWriteSlow):
(JSC::SymbolTable::visitChildren):
(JSC::SymbolTable::WatchpointCleanup::WatchpointCleanup):
(JSC::SymbolTable::WatchpointCleanup::~WatchpointCleanup):
(JSC::SymbolTable::WatchpointCleanup::finalizeUnconditionally):
* runtime/SymbolTable.h:
(JSC::SymbolTableEntry::watchpointSet):
(JSC::SymbolTableEntry::notifyWrite):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 27 Nov 2013 02:13:04 +0000 (02:13 +0000)]
[MediaStream API] HTMLMediaElement should be able to use MediaStream as source
https://bugs.webkit.org/show_bug.cgi?id=121943
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-26
Reviewed by Eric Carlson.
Source/WebCore:
Implement MediaStream direct assignment to Media Elements using the new 'srcObject'
attribute: http://www.w3.org/TR/mediacapture-streams/#direct-assignment-to-media-elements
Test: fast/mediastream/MediaStream-MediaElement-srcObject.html
* CMakeLists.txt: Added new HTMLMediaElementMediaStream.h and .cpp to cmake build.
* DerivedSources.make: Added HTMLMediaElementMediaStream.idl.
* GNUmakefile.list.am: Added new HTMLMediaElementMediaStream* to autotools build.
* WebCore.xcodeproj/project.pbxproj: Added new files.
* Modules/mediastream/HTMLMediaElementMediaStream.cpp: Added.
(WebCore::HTMLMediaElementMediaStream::srcObject): implements srcObject getter.
(WebCore::HTMLMediaElementMediaStream::setSrcObject): implements srcObject setter.
* Modules/mediastream/HTMLMediaElementMediaStream.h: Added.
* Modules/mediastream/HTMLMediaElementMediaStream.idl: Added.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setSrcObject): This is an initial implementation, and
is still incomplete, that will be addressed in a separate bug: https://webkit.org/b/124896
* html/HTMLMediaElement.h: Added m_mediaStreamSrcObject class variable
and its corresponding getter.
Source/WebKit2:
Add mediastream module and platform to cmake include directories.
* CMakeLists.txt:
LayoutTests:
Add layout tests to MediaStream direct assignment to HTMLMediaElement
using brand new srcObject attribute.
* fast/mediastream/MediaStream-MediaElement-srcObject-expected.txt: Added.
* fast/mediastream/MediaStream-MediaElement-srcObject.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 27 Nov 2013 01:27:28 +0000 (01:27 +0000)]
Moved methods which belong to Checkout into checkout.py
https://bugs.webkit.org/show_bug.cgi?id=124889
Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-26
Reviewed by Ryosuke Niwa.
* Scripts/webkitpy/common/checkout/checkout.py:
(Checkout.scripts_directory):
(Checkout):
(Checkout.script_path):
(Checkout.commit_message_for_this_commit):
(Checkout.apply_patch):
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
(test_commit_message_for_this_commit):
(CheckoutTest.test_apply_patch):
* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.absolute_path):
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(SCMTest._setup_webkittools_scripts_symlink):
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.create_patch):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 27 Nov 2013 01:22:07 +0000 (01:22 +0000)]
Create a new SymbolTable every time code is loaded so that the watchpoints don't get reused
https://bugs.webkit.org/show_bug.cgi?id=124824
Reviewed by Oliver Hunt.
This helps with one shot closure inference as well as closure variable constant
inference, since without this, if code was reloaded from the cache then we would
think that the first run was actually an Nth run. This would cause us to think that
the watchpoint(s) should all be invalidated.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::stronglyVisitStrongReferences):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::symbolTable):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::symbolTable):
* runtime/Executable.h:
* runtime/SymbolTable.cpp:
(JSC::SymbolTable::clone):
* runtime/SymbolTable.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@apple.com [Tue, 26 Nov 2013 23:55:16 +0000 (23:55 +0000)]
Use child iterator to find operators in RenderMathMLRow::layout().
<https://webkit.org/b/124108>
Replace manual children walk with childrenOfType<RenderMathMLBlock>.
Minor update to fix build.
Patch by Andreas Kling <akling@apple.com> on 2013-11-26
Reviewed by Martin Robinson.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Tue, 26 Nov 2013 23:36:00 +0000 (23:36 +0000)]
RenderObject: Inline isBody() and isHR().
<https://webkit.org/b/124901>
Together these account for ~0.3% of samples on HTML5-8266.
Almost all of it is call overhead.
Reviewed by Anders Carlsson.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
betravis@adobe.com [Tue, 26 Nov 2013 23:05:28 +0000 (23:05 +0000)]
[CSS Shapes] Layout using [<box> || <shape>] value
https://bugs.webkit.org/show_bug.cgi?id=124428
Reviewed by David Hyatt.
Source/WebCore:
When a box value is supplied, use it to size and position the shape. Otherwise,
use a default value (content-box for shape-inside, margin-box for shape-outside).
This patch extends the sizing and positioning code used for the box patch (Bug 124227)
to also apply to shapes. With this patch, we also no longer use the box-sizing
property to size and position shapes.
Tests: fast/shapes/shape-outside-floats/shape-outside-shape-boxes-001.html
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-002.html
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue): Adjust for ShapeValues storing
BasicShape::ReferenceBox as their box value, rather than a CSSValueID.
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyShape::applyValue): Ditto.
* rendering/shapes/ShapeInfo.h:
(WebCore::ShapeInfo::setShapeSize): Adjust for BasicShapes with reference boxes
as well as plain box values. Also, remove old box-sizing code.
(WebCore::ShapeInfo::logicalTopOffset): Ditto.
(WebCore::ShapeInfo::logicalLeftOffset): Ditto.
* rendering/shapes/ShapeInsideInfo.h:
* rendering/shapes/ShapeOutsideInfo.h:
* rendering/style/ShapeValue.h:
(WebCore::ShapeValue::createBoxValue): Adjust for boxes being stored as
BasicShape::ReferenceBoxes.
(WebCore::ShapeValue::box): Ditto.
(WebCore::ShapeValue::ShapeValue): Ditto.
LayoutTests:
Adding tests to make sure that shapes properly size and position themselves across box values
and writing modes. Some shape-outside tests needed to be updated to explicitly size themselves
to content-box, as they were relying on that being the default value. Some shape-inside tests
needed to be adjusted as box-sizing no longer affects the shape size and position.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001.html:
Explicitly size to content-box.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html: Ditto.
* fast/shapes/shape-inside/shape-inside-box-sizing-expected.html: Small test cleanup.
* fast/shapes/shape-inside/shape-inside-box-sizing.html: Modify shapes to provide their sizing box.
* fast/shapes/shape-inside/shape-inside-empty-expected.html: Small test cleanup.
* fast/shapes/shape-inside/shape-inside-empty.html: Modify shapes to provide their sizing box.
* fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html: Ditto.
* fast/shapes/shape-outside-floats/shape-outside-shape-boxes-001-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-shape-boxes-001.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-shape-boxes-002-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-shape-boxes-002.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003.html: Added.
* inspector-protocol/model/highlight-shape-outside.html: Modify shapes to provide their sizing box.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Nov 2013 22:58:17 +0000 (22:58 +0000)]
ImageBuffer::create should return a std::unique_ptr instead of OwnPtr.
https://bugs.webkit.org/show_bug.cgi?id=124822
Patch by Brian J. Burg <burg@cs.washington.edu> on 2013-11-26
Reviewed by Andreas Kling.
Replace all uses of OwnPtr<ImageBuffer> and PassOwnPtr<ImageBuffer> with
std::unique_ptr<ImageBuffer>. Replace calls to OwnPtr::clear() and
OwnPtr::release() with reset() and std::move(). Remove unnecessary includes.
No new tests. This is a mechanical refactoring.
* css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::image):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::setSurfaceSize):
* html/HTMLCanvasElement.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache):
(WebCore::WebGLRenderingContext::LRUImageBufferCache::imageBuffer):
* html/canvas/WebGLRenderingContext.h:
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
* page/Frame.cpp:
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::drawPattern):
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::drawPattern):
* platform/graphics/GradientImage.h:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::createCompatibleBuffer):
* platform/graphics/GraphicsContext.h:
* platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::createCompatibleBuffer):
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
* platform/graphics/ShadowBlur.cpp:
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::putByteArray):
* platform/graphics/cg/PDFDocumentImage.h:
* platform/graphics/filters/FETile.cpp:
(WebCore::FETile::platformApplySoftware):
* platform/graphics/filters/Filter.h:
(WebCore::Filter::setSourceImage):
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::clearResult):
* platform/graphics/filters/FilterEffect.h:
* platform/graphics/texmap/TextureMapper.cpp:
(WebCore::BitmapTexture::updateContents):
* platform/graphics/texmap/TextureMapperImageBuffer.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDecoration):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintProgressBar):
* rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::invalidateBufferedForeground):
* rendering/svg/RenderSVGImage.h:
* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
* rendering/svg/RenderSVGResourceClipper.h:
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):
* rendering/svg/RenderSVGResourceFilter.h:
* rendering/svg/RenderSVGResourceGradient.cpp: Remove method parameter wrapping/indentation.
(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):
(WebCore::RenderSVGResourceGradient::applyResource):
* rendering/svg/RenderSVGResourceGradient.h:
* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
* rendering/svg/RenderSVGResourceMasker.h:
* rendering/svg/RenderSVGResourcePattern.cpp: Remove method parameter wrapping/indentation.
(WebCore::RenderSVGResourcePattern::buildPattern):
(WebCore::RenderSVGResourcePattern::createTileImage):
* rendering/svg/RenderSVGResourcePattern.h: Remove method parameter wrapping/indentation.
* rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::createImageBuffer):
(WebCore::SVGRenderingContext::createImageBufferForPattern):
(WebCore::SVGRenderingContext::clipToImageBuffer):
(WebCore::SVGRenderingContext::bufferForeground):
* rendering/svg/SVGRenderingContext.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::nativeImageForCurrentFrame):
(WebCore::SVGImage::drawPatternForContainer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 26 Nov 2013 20:24:58 +0000 (20:24 +0000)]
Crash in JSC::ASTBuilder::Expression JSC::Parser<JSC::Lexer<unsigned char> >::parseUnaryExpression<JSC::ASTBuilder>(JSC::ASTBuilder&)
https://bugs.webkit.org/show_bug.cgi?id=124886
Reviewed by Sam Weinig.
Source/JavaScriptCore:
Make sure the error macros propagate an existing error before
trying to create a new error message. We need to do this as
the parser state may not be safe for any specific error message
if we are already unwinding due to an error.
* parser/Parser.cpp:
LayoutTests:
Add tests
* js/parser-syntax-check-expected.txt:
* js/script-tests/parser-syntax-check.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Tue, 26 Nov 2013 20:11:31 +0000 (20:11 +0000)]
video.currentSrc should return empty when no resource is loaded
https://bugs.webkit.org/show_bug.cgi?id=124898
Reviewed by Dan Bernstein.
Source/WebCore:
Test: media/video-currentsrc-cleared.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad): Set m_currentSrc to empty in
preparation for attempting to load a new url.
LayoutTests:
* media/video-currentsrc-cleared-expected.txt: Added.
* media/video-currentsrc-cleared.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 26 Nov 2013 20:07:48 +0000 (20:07 +0000)]
Some WebKit2 headers are not self-contained
https://bugs.webkit.org/show_bug.cgi?id=124884
Reviewed by Anders Carlsson.
* Shared/API/Cocoa/WKRemoteObjectInterface.h: Added import.
* Shared/API/Cocoa/WKRemoteObjectRegistry.h: Ditto.
* Shared/API/c/WKContextMenuItemTypes.h: Added include.
* Shared/API/c/WKFindOptions.h: Ditto.
* Shared/API/c/WKMutableArray.h: Ditto.
* Shared/API/c/WKPageLoadTypes.h: Ditto.
* Shared/API/c/WKPageVisibilityTypes.h: Ditto.
* Shared/API/c/WKPluginInformation.cpp:
(WKPluginInformationBundleIdentifierKey): Made this API function always be defined. When
the Netscape plug-in API is not enabled, it returns 0.
(WKPluginInformationBundleVersionKey): Ditto.
(WKPluginInformationBundleShortVersionKey): Ditto.
(WKPluginInformationPathKey): Ditto.
(WKPluginInformationDisplayNameKey): Ditto.
(WKPluginInformationDefaultLoadPolicyKey): Ditto.
(WKPluginInformationUpdatePastLastBlockedVersionIsKnownAvailableKey): Ditto.
(WKPluginInformationHasSandboxProfileKey): Ditto.
(WKPluginInformationFrameURLKey): Ditto.
(WKPluginInformationMIMETypeKey): Ditto.
(WKPluginInformationPageURLKey): Ditto.
(WKPluginInformationPluginspageAttributeURLKey): Ditto.
(WKPluginInformationPluginURLKey): Ditto.
(WKPlugInInformationReplacementObscuredKey): Ditto.
* Shared/API/c/WKString.h: Added include.
* UIProcess/API/C/WKCredentialTypes.h: Ditto.
* UIProcess/API/C/WKPageContextMenuClient.h: Ditto.
* UIProcess/API/C/WKPageLoaderClient.h: Added includes.
* UIProcess/API/C/WKPagePolicyClient.h: Ditto.
* UIProcess/API/C/WKPageUIClient.h: Ditto.
* UIProcess/API/C/WKPluginSiteDataManager.cpp:
(WKPluginSiteDataManagerGetTypeID): Fixed the !ENABLE(NETSCAPE_PLUGIN_API) build.
* UIProcess/API/C/mac/WKContextPrivateMac.h: Removed use of ENABLE() from this private
header.
* UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextCopyPlugInInfoForBundleIdentifier): Made this API function always be defined.
When the Netscape plug-in API is not enabled, it returns 0.
(WKContextGetInfoForInstalledPlugIns): Made this API function always be defined.
* UIProcess/API/C/mac/WKInspectorPrivateMac.h: Added imports.
* UIProcess/API/C/mac/WKPagePrivateMac.h: Added include.
* UIProcess/API/Cocoa/WKBackForwardListItem.h: Added import.
* UIProcess/API/Cocoa/WKNavigationData.h: Ditto.
* UIProcess/API/cpp/WKRetainPtr.h: Replaced use of WARN_UNUSED_RETURN in this private header
with an equivalent macro defined in the header.
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: Added include.
* WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
(WKBundleInspectorGetTypeID): Made this API function always be defined. When the Inspector
is not enabled, it returns the Null type.
(WKBundleInspectorShow): Made this API function always be defined.
(WKBundleInspectorClose): Ditto.
(WKBundleInspectorEvaluateScriptForTest): Ditto.
(WKBundleInspectorSetPageProfilingEnabled): Ditto.
* WebProcess/InjectedBundle/API/c/WKBundleInspector.h: Removed use of ENABLE() from this
private header.
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Added includes.
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added include.
* WebProcess/Plugins/Netscape/mac/WKNPAPIPlugInContainer.mm:
(-[WKNPAPIPlugInContainer openPlugInPreferencePane]): Fixed the !ENABLE(NETSCAPE_PLUGIN_API)
build.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createJavaAppletWidget): Ditto.
* WebProcess/WebPage/mac/WebInspectorMac.mm: Fixed the !ENABLE(INSPECTOR) build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hmuller@adobe.com [Tue, 26 Nov 2013 19:19:37 +0000 (19:19 +0000)]
[CSS Shapes] Support for shape-margin in BoxShape
https://bugs.webkit.org/show_bug.cgi?id=124788
Source/WebCore:
Reviewed by Andreas Kling.
Corrected BoxShape's internal shape-margin/padding bounds FloatRoundedRect
initialization. Tests for the padding bounds will be added when the rest of
shape-padding for box shapes implementation is ready.
Tests: fast/shapes/shape-outside-floats/shape-outside-margin-boxes-001.html
fast/shapes/shape-outside-floats/shape-outside-margin-boxes-002.html
* rendering/shapes/BoxShape.cpp: Use constructor shape-margin,shape-padding parameters.
(WebCore::BoxShape::BoxShape):
* rendering/shapes/BoxShape.h:
* rendering/shapes/Shape.cpp:
(WebCore::createBoxShape): Pass the shape-margin and shape-padding values along to the BoxShape constructor.
(WebCore::Shape::createShape): Ditto.
LayoutTests:
Verify that shape-margin has the expected effect on the four possible shape-outside box values
for left and right floats.
Reviewed by Andreas Kling.
* fast/shapes/shape-outside-floats/shape-outside-margin-boxes-001-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-margin-boxes-001.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-margin-boxes-002-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-margin-boxes-002.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Nov 2013 18:34:06 +0000 (18:34 +0000)]
Remove unnecessary webaudio include from MediaStreamSource header
https://bugs.webkit.org/show_bug.cgi?id=124897
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-26
Reviewed by Eric Carlson.
AudioDestinationConsumer.h is included but not used anywhere in
MediaStreamSource implementation.
* platform/mediastream/MediaStreamSource.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gns@gnome.org [Tue, 26 Nov 2013 17:47:07 +0000 (17:47 +0000)]
Updated Brazilian Portuguese translation of WebKitGTK+ - November 02, 2013
https://bugs.webkit.org/show_bug.cgi?id=123694
Patch by Enrico Nicoletto <liverig@gmail.com> on 2013-11-26
Reviewed by Gustavo Noronha.
* pt_BR.po: updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
m.pakula@samsung.com [Tue, 26 Nov 2013 17:21:08 +0000 (17:21 +0000)]
Unreviewed EFL gardening
Add test expectations for failing accessibility tests.
* platform/efl/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nrotem@apple.com [Tue, 26 Nov 2013 17:10:00 +0000 (17:10 +0000)]
Optimize away OR with zero - a common ASM.js pattern.
https://bugs.webkit.org/show_bug.cgi?id=124869
Reviewed by Filip Pizlo.
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Tue, 26 Nov 2013 16:20:16 +0000 (16:20 +0000)]
Avoid unnecessary copy-on-write in FillLayer style application.
<https://webkit.org/b/124878>
We ended up with a lot of cloned StyleBackgroundData objects on
HTML5-8266. This happened because we always forced a copy-on-write
when applying background-image:inherit / background-image:initial.
This patch adds early returns to both functions. In the "inherit"
case, we bail early if the target style already has the same fill
layer data as its parent style.
In the "initial" case, we optimize for the single-FillLayer case
and add an early return if the relevant value is either unset or
equal to the templatized initial value.
2.46 MB progression on HTML5-8266 locally.
Reviewed by Antti Koivisto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
m.pakula@samsung.com [Tue, 26 Nov 2013 14:09:15 +0000 (14:09 +0000)]
Unreviewed ATK gardening
Rebaseline accessibility tests after r159747.
* platform/efl-wk1/accessibility/table-detection-expected.txt:
* platform/efl-wk2/accessibility/table-detection-expected.txt:
* platform/gtk/accessibility/table-detection-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
graouts@apple.com [Tue, 26 Nov 2013 08:29:11 +0000 (08:29 +0000)]
Web Inspector: Allow showing a context menu on all mouse events.
https://bugs.webkit.org/show_bug.cgi?id=124747
Reviewed by Joseph Pecoraro.
Source/WebCore:
Add a new InspectorFrontendHost::dispatchEventAsContextMenuEvent(Event*) method
to let the inspector front-end dispatch a native contextmenu event that will allow
for a context menu to be shown from within a non-contextmenu event handler.
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent):
Check that we're dealing with a mouse event, get the frame for the event target
and the event's location to call ContextMenuController::showContextMenuAt()
which will handle the new contextmenu event dispatch to the original event target.
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
Source/WebInspectorUI:
Automatically dispatch a contextmenu event in case WebInspector.ContextMenu.prototype.show()
is called outside of a contextmenu event handler and would therefore not show the expected
context menu (except in the Remote Web Inspector where this already works).
* UserInterface/ContextMenu.js:
(WebInspector.ContextMenu.prototype.show):
Check whether the event is a contextmenu event, and if not, add an event listener for a manually
dispatched contextmenu event such that we may then call InspectorFrontendHost.showContextMenu()
in a contextmenu event handler.
(WebInspector.ContextMenu.prototype.handleEvent):
Call InspectorFrontendHost.showContextMenu() now that we received the manually dispatched
contextmenu event.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 26 Nov 2013 05:54:30 +0000 (05:54 +0000)]
Convert some Shape code to use references
https://bugs.webkit.org/show_bug.cgi?id=124876
Reviewed by Andreas Kling.
* inspector/InspectorOverlay.cpp:
* rendering/FloatingObjects.cpp:
* rendering/LayoutState.cpp:
* rendering/RenderBlock.cpp:
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
* rendering/RenderBox.cpp:
* rendering/RenderBox.h:
* rendering/line/BreakingContextInlineHeaders.h:
* rendering/line/LineWidth.cpp:
* rendering/shapes/ShapeInfo.cpp:
* rendering/shapes/ShapeInfo.h:
* rendering/shapes/ShapeInsideInfo.cpp:
* rendering/shapes/ShapeInsideInfo.h:
* rendering/shapes/ShapeOutsideInfo.cpp:
* rendering/shapes/ShapeOutsideInfo.h:
Replace yet more pointers with references.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@samsung.com [Tue, 26 Nov 2013 05:46:52 +0000 (05:46 +0000)]
[EFL] E_DBus should be an optional
https://bugs.webkit.org/show_bug.cgi?id=124881
Reviewed by Gyuyoung Kim.
* Source/cmake/OptionsEfl.cmake:
Checked E_DBus when only ENABLE_BATTERY_STATUS is on.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
achicu@adobe.com [Tue, 26 Nov 2013 02:21:04 +0000 (02:21 +0000)]
Web Inspector: [CSS Regions] A page with many flows should collapse the resources tree
https://bugs.webkit.org/show_bug.cgi?id=122926
Reviewed by Timothy Hatcher.
Refactored the code in FrameTreeElement._shouldGroupIntoFolders to make it easy to track
more types of resources. Added the content flows as another type of resource that would trigger the
collapsing.
* UserInterface/DOMTreeManager.js:
(WebInspector.DOMTreeManager.prototype.namedFlowRemoved): Added code to remove the content nodes from
a flow that has been removed.
* UserInterface/FrameTreeElement.js:
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushCategory):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushResourceType):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@samsung.com [Tue, 26 Nov 2013 02:16:29 +0000 (02:16 +0000)]
[EFL] Use Config mode of find_package for EFL 1.8
https://bugs.webkit.org/show_bug.cgi?id=124555
Reviewed by Gyuyoung Kim.
.:
EFL 1.8 changed VERSION macro so it's difficult to use tricky approach
which parses header files to know the version. Instead, EFL 1.8 supports
FooConfig.cmake such as EinaConfig.cmake.
This patch tries to use a config mode if it is available.
If config mode is not available with Eo, FindFoo.cmake will be used without
version requirement.
* Source/cmake/FindEo.cmake: Removed.
EoConfig.cmake is only preffered for EFL 1.8.
* Source/cmake/OptionsEfl.cmake:
Tools:
* MiniBrowser/efl/CMakeLists.txt:
Added optional config mode and made version requirement optional.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 26 Nov 2013 00:47:51 +0000 (00:47 +0000)]
[Cocoa] Use class extensions for IPI
https://bugs.webkit.org/show_bug.cgi?id=124870
Reviewed by Sam Weinig.
* UIProcess/API/mac/WKBrowsingContextController.mm: Reordered methods so that the Private
cateogry isn’t stuck between the API methods and the internal methods.
(-[WKBrowsingContextController setPaginationMode:]):
(-[WKBrowsingContextController paginationMode]):
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]):
(-[WKBrowsingContextController paginationBehavesLikeColumns]):
(-[WKBrowsingContextController setPageLength:]):
(-[WKBrowsingContextController pageLength]):
(-[WKBrowsingContextController setGapBetweenPages:]):
(-[WKBrowsingContextController gapBetweenPages]):
(-[WKBrowsingContextController pageCount]):
(-[WKBrowsingContextController handle]):
* UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Changed Internal category into
a class extension.
* UIProcess/API/mac/WKConnection.mm:
* UIProcess/API/mac/WKConnectionInternal.h: Changed Internal category into a class
extension.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Nov 2013 00:21:07 +0000 (00:21 +0000)]
[GTK] Search functionality in MiniBrowser provides feedback on search fail
https://bugs.webkit.org/show_bug.cgi?id=122681
Patch by Andres Gomez <agomez@igalia.com> on 2013-11-25
Reviewed by Mario Sanchez Prada.
When using the search functionality in MiniBrowser, if the search
fails, the entry background color gets red to report the user
about the failing condition. When the entry is cleaned or the
search is again succesful the background turns back to its
original color.
* MiniBrowser/gtk/BrowserSearchBar.c:
(setFailedStyleForEntry): Added.
(doSearch): Sets the entry's background to its original style if
there is no text to search.
(findControllerFailedToFindTextCallback): Added.
(findControllerFoundTextCallback): Added.
(browser_search_bar_init): Creates and adds a new CSS provider to
the text entry so we can change its style based on the success
condition of the search.
(browserSearchBarFinalize): Frees the new CSS provider.
(browser_search_bar_new): Connects the two new handlers to the
"failed-to-find-text" and "found-text" signals emitted by the
WebKitFindController.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 26 Nov 2013 00:20:42 +0000 (00:20 +0000)]
Fixed the iOS build.
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadDelegateInternal]):
(-[WKBrowsingContextController setLoadDelegateInternal:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.pena@samsung.com [Mon, 25 Nov 2013 23:55:45 +0000 (23:55 +0000)]
[EFL] X11Helper::createPixmap doesn't initialise out value handleId
https://bugs.webkit.org/show_bug.cgi?id=124722
Reviewed by Gyuyoung Kim.
The overloaded functions X11Helper::createPixmap don't initialise out
value handleId, and they do early returns on error situations. Since
the functions are void and they don't communicate their failure in any
way, returning an out value without initialising it could make the
error go farther unnoticed. With the variable being initialised, it can
be reliably checked for errors when the function returns.
* platform/graphics/surfaces/glx/X11Helper.cpp:
(WebCore::X11Helper::createPixmap): Initialise handleId to 0.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Nov 2013 23:50:36 +0000 (23:50 +0000)]
Mark URLRegistry's lookup() as const and its child classes as final
https://bugs.webkit.org/show_bug.cgi?id=124865
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.
No new tests needed. No behavior changes.
* Modules/mediasource/MediaSourceRegistry.cpp:
(WebCore::MediaSourceRegistry::lookup): marked as const.
* Modules/mediasource/MediaSourceRegistry.h: MediaSourceRegistry
marked as final.
* Modules/mediastream/MediaStreamRegistry.cpp:
(WebCore::MediaStreamRegistry::lookup): marked as const.
* Modules/mediastream/MediaStreamRegistry.h: MediaStreamRegistry
marked as final.
* fileapi/Blob.cpp:
* html/URLRegistry.h: lookup() marked as const.
(WebCore::URLRegistry::lookup): marked as const.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 25 Nov 2013 23:50:27 +0000 (23:50 +0000)]
[Cocoa] Remove some indirection that was only necessary for supporting the legacy Objective-C runtime
https://bugs.webkit.org/show_bug.cgi?id=123065
Reviewed by Sam Weinig.
* UIProcess/API/mac/WKBrowsingContextController.h: Removed _data ivar and
WKBrowsingContextControllerData class declaration.
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController dealloc]): Removed
WKBrowsingContextControllerData class and moved ivars directly into
WKBrowsingContextController, declaring them in the @implementation. Removed ivar and
accessors for the delegate properties, letting the compiler synthesize them.
(-[WKBrowsingContextController _pageRef]): Removed indirection via _data.
(-[WKBrowsingContextController loadRequest:userData:]): Removed indirection via -_pageRef.
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]): Ditto.
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController stopLoading]): Ditto.
(-[WKBrowsingContextController reload]): Ditto.
(-[WKBrowsingContextController reloadFromOrigin]): Ditto.
(-[WKBrowsingContextController goForward]): Ditto.
(-[WKBrowsingContextController canGoForward]): Ditto.
(-[WKBrowsingContextController goBack]): Ditto.
(-[WKBrowsingContextController canGoBack]): Ditto.
(-[WKBrowsingContextController goToBackForwardListItem:]): Ditto.
(-[WKBrowsingContextController backForwardList]): Ditto.
(-[WKBrowsingContextController activeURL]): Ditto.
(-[WKBrowsingContextController provisionalURL]): Ditto.
(-[WKBrowsingContextController committedURL]): Ditto.
(-[WKBrowsingContextController unreachableURL]): Removed idirection via _data.
(-[WKBrowsingContextController estimatedProgress]): Removed indirection via -_pageRef.
(-[WKBrowsingContextController title]): Ditto.
(-[WKBrowsingContextController textZoom]): Ditto.
(-[WKBrowsingContextController setTextZoom:]): Ditto.
(-[WKBrowsingContextController pageZoom]): Ditto.
(-[WKBrowsingContextController setPageZoom:]): Ditto.
(-[WKBrowsingContextController setPaginationMode:]): Ditto.
(-[WKBrowsingContextController paginationMode]): Ditto.
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]): Ditto.
(-[WKBrowsingContextController paginationBehavesLikeColumns]): Ditto.
(-[WKBrowsingContextController setPageLength:]): Ditto.
(-[WKBrowsingContextController pageLength]): Ditto.
(-[WKBrowsingContextController setGapBetweenPages:]): Ditto.
(-[WKBrowsingContextController gapBetweenPages]): Ditto.
(-[WKBrowsingContextController pageCount]): Ditto.
(-[WKBrowsingContextController handle]): Ditto.
(-[WKBrowsingContextController _initWithPageRef:]): Removed indirection via _data.
* UIProcess/API/mac/WKBrowsingContextGroup.h: Removed _data ivar and
WKBrowsingContextGroupData class declaration.
* UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed WKBrowsingContextGroupData class and
moved _pageGroupRef ivar directly into WKBrowsingContextGroup, declaring it in the
@implementation.
(-[WKBrowsingContextGroup initWithIdentifier:]): Removed indirection via _data.
(-[WKBrowsingContextGroup allowsJavaScript]): Removed indirection via -_pageGroupRef.
(-[WKBrowsingContextGroup setAllowsJavaScript:]): Ditto.
(-[WKBrowsingContextGroup allowsJavaScriptMarkup]): Ditto.
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]): Ditto.
(-[WKBrowsingContextGroup allowsPlugIns]): Ditto.
(-[WKBrowsingContextGroup setAllowsPlugIns:]): Ditto.
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]): Ditto.
(-[WKBrowsingContextGroup removeAllUserStyleSheets]): Ditto.
(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]): Ditto.
(-[WKBrowsingContextGroup removeAllUserScripts]): Ditto.
(-[WKBrowsingContextGroup _pageGroupRef]): Removed indirection via _data.
* UIProcess/API/mac/WKConnection.h: Removed _data ivar and WKConnectionData class declaration.
* UIProcess/API/mac/WKConnection.mm: Removed WKConnectionData class and moved _connectionRef
ivar directly into WKConnection, declaring it in the @implementation. Removed ivar and
accessors for the delegate property, letting the compiler synthesize them.
(-[WKConnection dealloc]): Removed indirection via _data.
(-[WKConnection sendMessageWithName:body:]): Ditto.
(-[WKConnection remoteObjectRegistry]): Ditto.
(didReceiveMessage): Ditto.
(-[WKConnection _initWithConnectionRef:]): Ditto.
* UIProcess/API/mac/WKProcessGroup.h: Replaced forward declaration of WKConnection with an
import. Removed _data ivar and WKProcessGroupData class declaration.
* UIProcess/API/mac/WKProcessGroup.mm: Removed WKProcessGroupData class and moved
_contextRef ivar directly into WKProcessGroup, declaring it in the @implementation. Removed
ivar and accessors for the delegate property, letting the compiler synthesize them.
(-[WKProcessGroup initWithInjectedBundleURL:]): Removed indirection via _data.
(-[WKProcessGroup dealloc]): Ditto.
(-[WKProcessGroup _contextRef]): Ditto.
(-[WKProcessGroup _geolocationProvider]): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Nov 2013 23:21:47 +0000 (23:21 +0000)]
[MediaStream] Use std::unique_ptr instead of OwnPtr/PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=124858
Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.
Another step of the OwnPtr/PassOwnPtr => std::unique_ptr conversion,
now targeting mediastream-related code.
No new tests, covered by existing ones.
* Modules/mediastream/RTCDTMFSender.cpp:
* Modules/mediastream/RTCDTMFSender.h:
* Modules/mediastream/RTCDataChannel.cpp:
* Modules/mediastream/RTCDataChannel.h:
* Modules/mediastream/RTCPeerConnection.cpp:
* Modules/mediastream/RTCPeerConnection.h:
* platform/mediastream/MediaStreamSource.cpp:
* platform/mediastream/RTCPeerConnectionHandler.cpp:
* platform/mediastream/RTCPeerConnectionHandler.h:
* platform/mediastream/RTCPeerConnectionHandlerClient.h:
* platform/mock/RTCNotifiersMock.cpp:
* platform/mock/RTCPeerConnectionHandlerMock.cpp:
* platform/mock/RTCPeerConnectionHandlerMock.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Nov 2013 23:08:46 +0000 (23:08 +0000)]
[Win] WebKit version in user agent string is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=124454
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-25
Reviewed by Brent Fulgham.
Source/WebKit:
Generate WebKitVersion.h file from mac's Version.xcconfig file.
* WebKit.vcxproj/WebKit/WebKit.vcxproj:
* WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
* WebKit.vcxproj/WebKit/WebKitVersion.cmd: Added.
Source/WebKit/win:
* WebView.cpp: Use WebKit version from WebKitVersion.h in user agent.
(webKitVersionString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Nov 2013 22:55:39 +0000 (22:55 +0000)]
MediaStreamRegistry should store MediaStreams instead of MediaStreamPrivates
https://bugs.webkit.org/show_bug.cgi?id=124860
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.
MediaStreamRegistry::lookup() should return a MediaStream instead of MediaStreamPrivate.
No new tests needed. No behavior changes.
* Modules/mediastream/MediaStreamRegistry.cpp:
(WebCore::MediaStreamRegistry::registerURL): m_privateStreams -> m_mediaStreams
(WebCore::MediaStreamRegistry::unregisterURL): Ditto.
(WebCore::MediaStreamRegistry::lookup): Override URLRegistry::lookup() instead of add a
new method MediaStream::lookupMediaStreamPrivate().
* Modules/mediastream/MediaStreamRegistry.h:
* html/HTMLMediaElement.cpp:
(HTMLMediaElement::loadResource): call lookup() instead of lookupMediaStreamPrivate()
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Nov 2013 22:08:33 +0000 (22:08 +0000)]
[WinCairo] Compile fails when GSTREAMER is not used.
https://bugs.webkit.org/show_bug.cgi?id=124853
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-25
Reviewed by Philippe Normand.
* platform/graphics/gstreamer/GStreamerUtilities.cpp: Don't include GStreamerUtilities.h when GSTREAMER is not used.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Nov 2013 22:02:32 +0000 (22:02 +0000)]
Unreviewed, rolling out r159740.
http://trac.webkit.org/changeset/159740
https://bugs.webkit.org/show_bug.cgi?id=124859
Crashing xmlhttprequest/access-control-repeated-failed-
preflight-crash.html on Mavericks and Mountain Lion -
ASSERT(m_pageGroup) WebPage.cpp:352 (Requested by dino_ on
#webkit).
* Scripts/webkit2/messages.py:
(struct_or_class):
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* Shared/mac/ObjCObjectGraphCoders.h:
* Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::ObjCObjectGraphEncoder::baseEncode):
(WebKit::WebContextObjCObjectGraphEncoderImpl::WebContextObjCObjectGraphEncoderImpl):
(WebKit::WebContextObjCObjectGraphEncoderImpl::encode):
(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode):
(WebKit::WebContextObjCObjectGraphEncoder::WebContextObjCObjectGraphEncoder):
(WebKit::WebContextObjCObjectGraphEncoder::encode):
* UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::encodeMessageBody):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveSyncMessage):
* UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):
* UIProcess/WebPageGroup.cpp:
* UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::sendToAllProcessesInGroup):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::postMessageToInjectedBundle):
(WebKit::WebPageProxy::initializeCreationParameters):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::createWebPage):
* UIProcess/WebProcessProxy.h:
* WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::webPageGroup):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Mon, 25 Nov 2013 21:53:32 +0000 (21:53 +0000)]
Deduplicate shortish Text node strings during tree construction.
<https://webkit.org/b/124855>
Let HTMLConstructionSite keep a hash set of already seen strings over
its lifetime. Use this to deduplicate the strings inside Text nodes
for any string up to 64 characters of length.
This optimization already sort-of existed for whitespace-only Texts,
but those are laundered in the AtomicString table which we definitely
don't want to pollute with every single Text. It might be a good idea
to stop using the AtomicString table for all-whitespace Text too.
3.82 MB progression on HTML5-8266 locally.
Reviewed by Anders Carlsson.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Mon, 25 Nov 2013 21:36:10 +0000 (21:36 +0000)]
RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857
Skipping these tests for now, since Ossy + Laszlo checked
in a lot of rebaselines and I didn't want to roll
everything out.
* TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Nov 2013 21:29:25 +0000 (21:29 +0000)]
Remove unnecessary MediaStreamTrackDescriptor forward declaration
https://bugs.webkit.org/show_bug.cgi?id=124854
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.
No new tests needed. No behavior changed.
* Modules/mediastream/VideoStreamTrack.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 25 Nov 2013 20:53:27 +0000 (20:53 +0000)]
Fixed a typo in the change log.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 25 Nov 2013 20:52:04 +0000 (20:52 +0000)]
[Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
https://bugs.webkit.org/show_bug.cgi?id=124850
Reviewed by Brady Eidson.
Source/WebKit2:
Guarded all Cocoa API headers and implementatiosn with WK_API_ENABLED. Left the WKView class
unguarded, but limited its API.
* Shared/API/Cocoa/WKFoundation.h: Replaced OBJ_VISIBLE with an explicit attribute.
* Shared/API/Cocoa/WKRemoteObjectCoder.mm: Moved #if WK_API_ENABLED before the rest of the
imports.
* Shared/API/Cocoa/WKRemoteObjectInterface.mm: Ditto.
* Shared/API/Cocoa/WKRemoteObjectRegistry.mm: Ditto.
* Shared/API/Cocoa/WKRemoteObjectRegistryPrivate.h: Ditto.
* UIProcess/API/mac/WKBrowsingContextController.h: Guarded all declarations with
WK_API_ENABLED, changed to use WK_API_CLASS instead of WK_EXPORT.
* UIProcess/API/mac/WKBrowsingContextController.mm: Guarded everything with WK_API_ENABLED.
(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController setPolicyDelegate:]):
(-[WKBrowsingContextController backForwardList]):
(didChangeBackForwardList):
(setUpPageLoaderClient):
(setUpPagePolicyClient):
(-[WKBrowsingContextController _initWithPageRef:]):
* UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Ditto.
* UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Ditto.
* UIProcess/API/mac/WKBrowsingContextGroup.h: Guarded all declarations with WK_API_ENABLED,
chanegd to use WK_API_CLASS instead of WK_EXPORT.
* UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed redundant import, guarded everything
with WK_API_ENABLED.
* UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Guarded with WK_API_ENABLED.
* UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Added necessary import.
* UIProcess/API/mac/WKConnection.h: Guarded all declarations with WK_API_ENABLED, chanegd to
use WK_API_CLASS instead of WK_EXPORT.
* UIProcess/API/mac/WKConnection.mm: Guarded everything with WK_API_ENABLED.
(-[WKConnection remoteObjectRegistry]):
(didReceiveMessage):
* UIProcess/API/mac/WKConnectionInternal.h: Guarded the delcarations with WK_API_ENABLED.
* UIProcess/API/mac/WKProcessGroup.h: Ditto. Also changed to use WK_API_CLASS instead of
WK_EXPORT.
* UIProcess/API/mac/WKProcessGroup.mm: Guarded everything with WK_API_ENABLED.
(-[WKProcessGroup initWithInjectedBundleURL:]):
* UIProcess/API/mac/WKProcessGroupPrivate.h: Guarded the declarations with WK_API_ENABLED.
* UIProcess/API/mac/WKTypeRefWrapper.h: Moved #if WK_API_ENABLED before the rest of the
imports, changed to use WK_API_CLASS instead of WK_EXPORT.
* UIProcess/API/mac/WKTypeRefWrapper.mm: Removed empty line after #import "config.h".
* UIProcess/API/mac/WKView.h: Added #if WK_API_ENABLED around API that uses other Cocoa API
types.
* UIProcess/API/mac/WKView.mm: Added #if WK_API_ENABLED around implementations of methods
that are only declared when the API is enabled.
* UIProcess/API/mac/WKViewInternal.h: Reordered imports.
* UIProcess/mac/WKFullScreenWindowController.mm: Added comment to #endif.
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess): Guarded use of
WKBrowsingContextController with WK_API_ENABLED.
(WebKit::WebContext::platformInitializeNetworkProcess): Ditto.
* UIProcess/mac/WebContextMenuProxyMac.mm: Removed newline between imports.
* WebProcess/InjectedBundle/API/mac/WKDOMDocument.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm: Removed newline after #import
"config.h".
* WebProcess/InjectedBundle/API/mac/WKDOMElement.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKDOMElement.mm: Removed newline after #import
"config.h".
* WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm: Ditto.
* WebProcess/InjectedBundle/API/mac/WKDOMNode.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKDOMNode.mm: Removed redundant import.
* WebProcess/InjectedBundle/API/mac/WKDOMRange.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKDOMRange.mm: Removed newline and redundant import.
* WebProcess/InjectedBundle/API/mac/WKDOMText.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h: Ditto.
* WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm: Removed newline after
#import "config.h".
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h: Moved #if WK_API_ENABLED before
the rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm: Removed newline and redundant
imports.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h: Moved #if
WK_API_ENABLED before the rest of the imports, and changed to use WK_API_CLASS instead of
WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm: Removed
newline after #import "config.h".
Tools:
Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
* TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 25 Nov 2013 19:10:18 +0000 (19:10 +0000)]
Set the svn:ignore property on the Xcode project to ignore the workspace and user data.
* WebInspectorUI.xcodeproj: Added property svn:ignore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Mon, 25 Nov 2013 18:50:36 +0000 (18:50 +0000)]
Remove code now unnecessary after r159575
https://bugs.webkit.org/show_bug.cgi?id=124809
Reviewed by Antti Koivisto.
Covered by existing tests fast/block/margin-collapse/self-collapsing-block-with-float*
* rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::skipLeadingWhitespace):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Mon, 25 Nov 2013 18:46:51 +0000 (18:46 +0000)]
Add complex line layout path version of empty-clear-blocks.html
https://bugs.webkit.org/show_bug.cgi?id=124808
Reviewed by Sam Weinig.
* fast/block/margin-collapse/empty-clear-blocks-complex-expected.html: Added.
* fast/block/margin-collapse/empty-clear-blocks-complex.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Nov 2013 18:41:13 +0000 (18:41 +0000)]
Unreviewed, rolling out r159752 and r159754.
http://trac.webkit.org/changeset/159752
http://trac.webkit.org/changeset/159754
https://bugs.webkit.org/show_bug.cgi?id=124847
Broke linux test bots. (Requested by mhahnenberg on #webkit).
* Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
* Scripts/run-javascriptcore-tests:
* Scripts/run-jsc-stress-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 25 Nov 2013 18:24:56 +0000 (18:24 +0000)]
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.
Rebaseline the rest of EFL and GTK tests.
* platform/efl/tables/mozilla/bugs/bug10296-1-expected.txt:
* platform/efl/tables/mozilla/bugs/bug26178-expected.txt:
* platform/efl/tables/mozilla/bugs/bug27038-1-expected.txt:
* platform/efl/tables/mozilla/bugs/bug278385-expected.txt:
* platform/efl/tables/mozilla/bugs/bug55789-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
* platform/efl/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
* platform/efl/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/efl/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
* platform/efl/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
* platform/efl/tables/mozilla_expected_failures/other/test4-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Mon, 25 Nov 2013 18:02:58 +0000 (18:02 +0000)]
Followup fix after r159752
* Scripts/run-jsc-stress-tests: We need to handle Release builds too.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 25 Nov 2013 17:34:35 +0000 (17:34 +0000)]
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.
Rebaseline efl tests (+mac corrections).
* platform/efl/fast/forms/input-align-expected.png:
* platform/efl/fast/forms/input-align-expected.txt:
* platform/efl/fast/forms/input-value-expected.png:
* platform/efl/fast/forms/input-value-expected.txt:
* platform/efl/fast/table/border-collapsing/004-vertical-expected.png:
* platform/efl/fast/table/border-collapsing/004-vertical-expected.txt:
* platform/efl/fast/table/floating-th-expected.png:
* platform/efl/fast/table/floating-th-expected.txt:
* platform/efl/fast/table/frame-and-rules-expected.png:
* platform/efl/fast/table/frame-and-rules-expected.txt:
* platform/efl/fast/table/multiple-captions-display-expected.png:
* platform/efl/fast/table/multiple-captions-display-expected.txt:
* platform/efl/fast/table/rowindex-expected.png:
* platform/efl/fast/table/rowindex-expected.txt:
* platform/efl/fast/table/table-display-types-expected.png:
* platform/efl/fast/table/table-display-types-expected.txt:
* platform/efl/fast/table/table-display-types-strict-expected.png:
* platform/efl/fast/table/table-display-types-strict-expected.txt:
* platform/efl/fast/table/table-display-types-vertical-expected.png:
* platform/efl/fast/table/table-display-types-vertical-expected.txt:
* platform/efl/tables/mozilla/bugs/bug119786-expected.png:
* platform/efl/tables/mozilla/bugs/bug119786-expected.txt:
* platform/efl/tables/mozilla/bugs/bug13118-expected.png:
* platform/efl/tables/mozilla/bugs/bug13118-expected.txt:
* platform/efl/tables/mozilla/bugs/bug19061-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug19061-1-expected.txt:
* platform/efl/tables/mozilla/bugs/bug19061-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug19061-2-expected.txt:
* platform/efl/tables/mozilla/bugs/bug220536-expected.png:
* platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
* platform/efl/tables/mozilla/bugs/bug27038-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug27038-2-expected.txt:
* platform/efl/tables/mozilla/bugs/bug27038-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
* platform/efl/tables/mozilla/bugs/bug30418-expected.png:
* platform/efl/tables/mozilla/bugs/bug30418-expected.txt:
* platform/efl/tables/mozilla/bugs/bug3263-expected.png:
* platform/efl/tables/mozilla/bugs/bug3263-expected.txt:
* platform/efl/tables/mozilla/bugs/bug38916-expected.png:
* platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
* platform/efl/tables/mozilla/bugs/bug46268-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug46268-3-expected.txt:
* platform/efl/tables/mozilla/bugs/bug46268-5-expected.png:
* platform/efl/tables/mozilla/bugs/bug46268-5-expected.txt:
* platform/efl/tables/mozilla/bugs/bug46268-expected.png:
* platform/efl/tables/mozilla/bugs/bug46268-expected.txt:
* platform/efl/tables/mozilla/bugs/bug46924-expected.png:
* platform/efl/tables/mozilla/bugs/bug46924-expected.txt:
* platform/efl/tables/mozilla/bugs/bug57378-expected.png:
* platform/efl/tables/mozilla/bugs/bug57378-expected.txt:
* platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.png:
* platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_position-table-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_position-table-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
* platform/efl/tables/mozilla/marvin/body_tfoot-expected.png:
* platform/efl/tables/mozilla/marvin/body_tfoot-expected.txt:
* platform/efl/tables/mozilla/marvin/body_thead-expected.png:
* platform/efl/tables/mozilla/marvin/body_thead-expected.txt:
* platform/efl/tables/mozilla/marvin/table_rules_groups-expected.png:
* platform/efl/tables/mozilla/marvin/table_rules_groups-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_char-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_char-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_char-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_char-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/thead_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/thead_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/thead_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/thead_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/thead_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_char-expected.png:
* platform/efl/tables/mozilla/marvin/thead_char-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt:
* platform/efl/tables/mozilla/marvin/x_table-expected.png:
* platform/efl/tables/mozilla/marvin/x_table-expected.txt:
* platform/efl/tables/mozilla/marvin/x_table_border-expected.png:
* platform/efl/tables/mozilla/marvin/x_table_border-expected.txt:
* platform/efl/tables/mozilla/marvin/x_table_border_none-expected.png:
* platform/efl/tables/mozilla/marvin/x_table_border_none-expected.txt:
* platform/efl/tables/mozilla/marvin/x_table_border_px-expected.png:
* platform/efl/tables/mozilla/marvin/x_table_border_px-expected.txt:
* platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.png:
* platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_class-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_class-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_id-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_id-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_style-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_style-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
* platform/mac-mountainlion/fast/forms/input-value-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt:
* platform/mac/fast/forms/input-value-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Mon, 25 Nov 2013 17:29:23 +0000 (17:29 +0000)]
run-jsc-stress-tests should be able to package its tests and move them places
https://bugs.webkit.org/show_bug.cgi?id=124549
Reviewed by Filip Pizlo.
* Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
of grep -i -q
* Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
* Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
We now also copy whatever VM was specified, along with its associated framework, into this directory.
All of the generated scripts now are completely relative within the results directory. This allows
run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
tarball of the generated results directory. Also refactored several portions of the script into
separate functions to make it easier to run them conditionally depending on which mode we're running in.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 25 Nov 2013 17:02:01 +0000 (17:02 +0000)]
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.
Rebase GTK results after r159747.
* platform/gtk/fast/forms/input-value-expected.png:
* platform/gtk/fast/forms/input-value-expected.txt:
* platform/gtk/fast/table/011-expected.txt:
* platform/gtk/fast/table/border-collapsing/004-expected.txt:
* platform/gtk/fast/table/border-collapsing/004-vertical-expected.png:
* platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
* platform/gtk/fast/table/floating-th-expected.png:
* platform/gtk/fast/table/floating-th-expected.txt:
* platform/gtk/fast/table/frame-and-rules-expected.png:
* platform/gtk/fast/table/frame-and-rules-expected.txt:
* platform/gtk/fast/table/rowindex-expected.png:
* platform/gtk/fast/table/rowindex-expected.txt:
* platform/gtk/fast/table/table-display-types-expected.png:
* platform/gtk/fast/table/table-display-types-expected.txt:
* platform/gtk/fast/table/table-display-types-strict-expected.png:
* platform/gtk/fast/table/table-display-types-strict-expected.txt:
* platform/gtk/fast/table/table-display-types-vertical-expected.png:
* platform/gtk/fast/table/table-display-types-vertical-expected.txt:
* platform/gtk/fast/table/tableInsideCaption-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug119786-expected.png:
* platform/gtk/tables/mozilla/bugs/bug119786-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug13118-expected.png:
* platform/gtk/tables/mozilla/bugs/bug13118-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug19061-1-expected.png:
* platform/gtk/tables/mozilla/bugs/bug19061-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug19061-2-expected.png:
* platform/gtk/tables/mozilla/bugs/bug19061-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug220536-expected.png:
* platform/gtk/tables/mozilla/bugs/bug220536-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug26178-expected.png:
* platform/gtk/tables/mozilla/bugs/bug26178-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug27038-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug27038-2-expected.png:
* platform/gtk/tables/mozilla/bugs/bug27038-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug27038-3-expected.png:
* platform/gtk/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug278385-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug30418-expected.png:
* platform/gtk/tables/mozilla/bugs/bug30418-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug3263-expected.png:
* platform/gtk/tables/mozilla/bugs/bug3263-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug38916-expected.png:
* platform/gtk/tables/mozilla/bugs/bug38916-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46268-3-expected.png:
* platform/gtk/tables/mozilla/bugs/bug46268-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46268-5-expected.png:
* platform/gtk/tables/mozilla/bugs/bug46268-5-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46268-expected.png:
* platform/gtk/tables/mozilla/bugs/bug46268-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46924-expected.png:
* platform/gtk/tables/mozilla/bugs/bug46924-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug55789-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug57378-expected.png:
* platform/gtk/tables/mozilla/bugs/bug57378-expected.txt:
* platform/gtk/tables/mozilla/dom/appendTbodyExpand1-expected.png:
* platform/gtk/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
* platform/gtk/tables/mozilla/marvin/body_tfoot-expected.png:
* platform/gtk/tables/mozilla/marvin/body_tfoot-expected.txt:
* platform/gtk/tables/mozilla/marvin/body_thead-expected.png:
* platform/gtk/tables/mozilla/marvin/body_thead-expected.txt:
* platform/gtk/tables/mozilla/marvin/table_rules_groups-expected.png:
* platform/gtk/tables/mozilla/marvin/table_rules_groups-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_align_center-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_align_char-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_align_justify-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_align_left-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_align_right-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_char-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_align_center-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_align_char-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_align_justify-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_align_left-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_align_right-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_char-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_align_center-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_align_char-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_align_justify-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_align_left-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_align_right-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_char-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table-expected.png:
* platform/gtk/tables/mozilla/marvin/x_table-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_border-expected.png:
* platform/gtk/tables/mozilla/marvin/x_table_border-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_border_none-expected.png:
* platform/gtk/tables/mozilla/marvin/x_table_border_none-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_border_px-expected.png:
* platform/gtk/tables/mozilla/marvin/x_table_border_px-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_frame_void-expected.png:
* platform/gtk/tables/mozilla/marvin/x_table_frame_void-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_center-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_char-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_left-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_right-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_class-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_class-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_id-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_id-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_style-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_style-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_align_center-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_align_char-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_align_left-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_align_right-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_class-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_class-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_id-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_id-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_style-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_style-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_top-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.png:
* platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.png:
* platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 25 Nov 2013 16:04:59 +0000 (16:04 +0000)]
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.
Rebase Mac results after r159747.
* platform/mac/tables/mozilla/bugs/bug119786-expected.txt:
* platform/mac/tables/mozilla/bugs/bug19061-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug220536-expected.txt: Added.
* platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
* platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
* platform/mac/tables/mozilla/bugs/bug278385-expected.txt:
* platform/mac/tables/mozilla/bugs/bug30418-expected.txt:
* platform/mac/tables/mozilla/bugs/bug38916-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46268-3-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46268-5-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46268-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46924-expected.txt:
* platform/mac/tables/mozilla/bugs/bug55789-expected.txt:
* platform/mac/tables/mozilla/bugs/bug57378-expected.txt:
* platform/mac/tables/mozilla/marvin/table_rules_groups-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_align_center-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_align_char-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_char-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_valign_top-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_align_center-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_align_char-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_char-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_align_center-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_align_char-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_char-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_valign_middle-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_valign_top-expected.txt:
* platform/mac/tables/mozilla/marvin/x_table-expected.txt:
* platform/mac/tables/mozilla/marvin/x_table_border-expected.txt:
* platform/mac/tables/mozilla/marvin/x_table_border_none-expected.txt:
* platform/mac/tables/mozilla/marvin/x_table_border_px-expected.txt:
* platform/mac/tables/mozilla/marvin/x_table_frame_void-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_class-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_id-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_style-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_align_center-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_align_char-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_class-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_id-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_style-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
* platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Nov 2013 15:48:07 +0000 (15:48 +0000)]
EWS creates 0 byte sized log files
https://bugs.webkit.org/show_bug.cgi?id=107606
Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-25
Reviewed by Ryosuke Niwa.
There was a modification in r138264, that tried to make less log,
because some of the messeges were duplicated. After this the EWS
created the log file (with the same name as the bugID) but doesn't
write anything into it, even if there were errors during the build.
From now only creates the log file only if there is some error.
* Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
there is nothing to log. Open the log file only if a ScriptError was raised to
avoid to make empty log files for bugs.
(QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
because of changes in r138264. Teeing is used for locally testing purposes and
this feature is not used anymore.
(QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
teeing anymore. It is a necessary change because of QueueEngine._open_work_log
change.
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(LoggingDelegate): The order of the callbacks was changed by this patch.
(QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
so we have to update this test.
(QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
this patch.
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
to be able to handle it in QueueEngine.run. Without this change, the existing
exception handler never run (the process_work_item method never raise ScriptError)
We can get the error message only from the ScriptError at this point.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Nov 2013 15:28:45 +0000 (15:28 +0000)]
[arm][mips] Fix crash in dfg-arrayify-elimination layout jsc test.
https://bugs.webkit.org/show_bug.cgi?id=124839
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-25
Reviewed by Michael Saboff.
In ARM EABI and MIPS, 64-bit values have to be aligned on stack too.
* jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
* jit/JITInlines.h:
(JSC::JIT::callOperation): Add missing EABI_32BIT_DUMMY_ARG.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 25 Nov 2013 14:57:38 +0000 (14:57 +0000)]
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.
Source/WebCore:
Based on Chromium fix https://chromium.googlesource.com/chromium/blink/+/
eb615069267f895c59bc576f9d65b3fa5add41e9
Rebaseline needed for table related tests (100+).
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
LayoutTests:
First tuple of rebaselined tests for mac. Rebaseline needed for table related tests (100+).
* fast/table/anonymous-table-section-removed.html:
* platform/mac/accessibility/table-detection-expected.txt:
* platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
* platform/mac/fast/forms/input-value-expected.txt:
* platform/mac/fast/table/011-expected.txt:
* platform/mac/fast/table/border-collapsing/004-expected.txt:
* platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
* platform/mac/fast/table/floating-th-expected.txt:
* platform/mac/fast/table/frame-and-rules-expected.txt:
* platform/mac/fast/table/multiple-captions-display-expected.txt:
* platform/mac/fast/table/rowindex-expected.txt:
* platform/mac/fast/table/table-display-types-expected.txt:
* platform/mac/fast/table/table-display-types-strict-expected.txt:
* platform/mac/fast/table/table-display-types-vertical-expected.txt:
* platform/mac/fast/table/tableInsideCaption-expected.txt:
* platform/mac/tables/mozilla/bugs/bug10296-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug13118-expected.txt:
* platform/mac/tables/mozilla/bugs/bug19061-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug3263-expected.txt:
* platform/mac/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_position-table-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
* platform/mac/tables/mozilla/marvin/body_tfoot-expected.txt:
* platform/mac/tables/mozilla/marvin/body_thead-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Nov 2013 14:03:25 +0000 (14:03 +0000)]
[GStreamer] Seeking fails on media content provided by servers not supporting Range requests
https://bugs.webkit.org/show_bug.cgi?id=85994
Patch by Andres Gomez <agomez@igalia.com> on 2013-11-25
Reviewed by Philippe Normand.
Source/WebCore:
Based on the patch written by Andre Moreira Magalhaes.
When the GStreamer web source was doing a "Range" request we were
expecting to receive a 206 status reply with the "Content-Range"
header and just the requested data. Supporting "Range" requests is
not mandatory so, for the servers not supporting it they will be
replying with a 200 status and the whole content of the media
element. Now, we are properly handling these replies too.
Test: http/tests/media/media-seeking-no-ranges-server.html
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::handleResponseReceived): Do not fail when
receiving 200 as response for HTTP range requests.
(StreamingClient::handleDataReceived): Manually seek on stream
when receiving the full data after a seek.
LayoutTests:
Added test to check that seeking media files on http servers not
supporting "Range" requests doesn't trigger an error.
* http/tests/media/media-seeking-no-ranges-server-expected.txt: Added.
* http/tests/media/media-seeking-no-ranges-server.html: Added.
* http/tests/media/resources/load-video.php: Added support for new
"ranges" paramenter.
* http/tests/media/resources/serve-video.php: Added support for
new "ranges" paramenter. When "ranges" is "no" we always answer
the HTTP status "200 OK" and send the whole file.
* platform/mac/TestExpectations: New test skipped in Mac port as
media playback download control is passed to AVFoundation that
doesn't like fancy PHP URLs like the one used in the test and, in
addition, they won't care about HTTP servers not supporting
"Range" requests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
stavila@adobe.com [Mon, 25 Nov 2013 12:14:52 +0000 (12:14 +0000)]
Removed obsolete FIXME after the landing of visual overflow patch (https://bugs.webkit.org/show_bug.cgi?id=118665).
https://bugs.webkit.org/show_bug.cgi?id=124833
Reviewed by Mihnea Ovidenie.
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::layoutBlock):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario.prada@samsung.com [Mon, 25 Nov 2013 11:36:11 +0000 (11:36 +0000)]
Unreviewed GTK gardening. Removed expectations for test that is no
longer failing for the GTK bots, according to the flakiness dashboard.
* platform/gtk-wk2/TestExpectations: Removed expectation.
* platform/gtk/TestExpectations: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Mon, 25 Nov 2013 11:19:36 +0000 (11:19 +0000)]
Unreviewed GTK gardening.
Managing current failures and removing redundant baselines.
* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:
* platform/gtk/fast/dom/gc-attribute-node-expected.txt: Removed.
* platform/gtk/fast/repaint/increasing-region-content-height-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Nov 2013 09:52:17 +0000 (09:52 +0000)]
[EFL] Need to update EFL TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=124825
Unreviewed, EFL gardening.
webgl/1.0.2/conformance/extensions/webgl-compressed-texture-s3tc.html
webgl/conformance/extensions/webgl-compressed-texture-s3tc.html
Above two tests are passed in Webkit2 layout test after r158798.
Patch by Jongwoo Choi <jw0330.choi@samsung.com> on 2013-11-25
* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
svillar@igalia.com [Mon, 25 Nov 2013 08:22:08 +0000 (08:22 +0000)]
[CSS Grid Layout] Cache several vectors to avoid malloc/free churn
https://bugs.webkit.org/show_bug.cgi?id=123995
Reviewed by Dean Jackson.
From Blink r158228 by <jchaffraix@chromium.org>
Laying-out the grid items means a lot of calls to
distributeSpaceToTracks() and
resolveContentBasedTrackSizingFunctionsForItems() as they're
called in a loop. This means that there is a lot of malloc/free
going on there. By moving the vectors used by these methods to a
new class which is kept during the whole layout process we save a
lot of those calls.
This obviously mean that the price we pay for a significant
perfomance improvement is that we keep the maximum allocation till
the end of each layout, but it's an amount of memory that we have
to allocate anyway. The improvement in the
auto-grid-lots-of-data.html perf test is ~24% (165 runs/s vs 207
runs/s).
No new tests required as we're just refactoring code to a new
helper class. Nevertheless the performance improvement is backed
by the perf test mentioned above.
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridSizingData::GridSizingData):
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::distributeSpaceToTracks):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::findChildLogicalPosition):
* rendering/RenderGrid.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 25 Nov 2013 03:09:03 +0000 (03:09 +0000)]
WebPageGroup's should keep track of what processes they are being used by
https://bugs.webkit.org/show_bug.cgi?id=124556
Reviewed by Dan Bernstein.
* Scripts/webkit2/messages.py:
(struct_or_class):
Mark WebPageGroupData as a struct.
* Shared/UserMessageCoders.h:
* Shared/mac/ObjCObjectGraphCoders.h:
* Shared/mac/ObjCObjectGraphCoders.mm:
* WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
* UIProcess/WebConnectionToWebProcess.cpp:
* UIProcess/WebContext.cpp:
* UIProcess/WebContextUserMessageCoders.h:
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
Pass the WebProcess/WebProcessProxy to both encode and decode.
* Shared/WebPageCreationParameters.h:
Pass the page group by ID when creating a page, as it will have had its own
creation message sent already.
* UIProcess/WebPageGroup.cpp:
* UIProcess/WebPageGroup.h:
Keep track of processes.
* UIProcess/WebProcessProxy.cpp:
* UIProcess/WebProcessProxy.h:
Keep track of the page groups used by the process.
* WebProcess/WebPage/WebPage.cpp:
Get the already create page group on creation.
* WebProcess/WebProcess.cpp:
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
Explicitly create page groups in the WebProcess.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jinwoo7.song@samsung.com [Mon, 25 Nov 2013 02:00:09 +0000 (02:00 +0000)]
Unreviewed EFL gardening. Rebaselining various tests under fast/
* platform/efl/fast/backgrounds/background-position-parsing-expected.png:
* platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
* platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
* platform/efl/fast/css/empty-pseudo-class-expected.png:
* platform/efl/fast/css/empty-pseudo-class-expected.txt:
* platform/efl/fast/css/fieldset-display-row-expected.txt:
* platform/efl/fast/css/first-child-pseudo-class-expected.png:
* platform/efl/fast/css/first-child-pseudo-class-expected.txt:
* platform/efl/fast/css/last-child-pseudo-class-expected.png:
* platform/efl/fast/css/last-child-pseudo-class-expected.txt:
* platform/efl/fast/css/only-child-pseudo-class-expected.png:
* platform/efl/fast/css/only-child-pseudo-class-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jinwoo7.song@samsung.com [Mon, 25 Nov 2013 00:10:37 +0000 (00:10 +0000)]
Unreviewed EFL gardening. Rebaselining after r159579.
* platform/efl/css1/formatting_model/vertical_formatting-expected.txt:
* platform/efl/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
* platform/efl/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sun, 24 Nov 2013 23:12:28 +0000 (23:12 +0000)]
DatabaseProcess: Add "UniqueIDBDatabase" that multiple WebProcesses can connect to
https://bugs.webkit.org/show_bug.cgi?id=124819
Reviewed by Dan Bernstein.
Source/WebCore:
* Modules/indexeddb/IDBDatabaseBackend.cpp:
(WebCore::IDBDatabaseBackend::~IDBDatabaseBackend): Unregister from the IDBFactory.
Source/WebKit2:
UniqueIDBDatabase instances are per-DatabaseProcess, so it manages the set of them.
* DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::getOrCreateUniqueIDBDatabase):
(WebKit::DatabaseProcess::removeUniqueIDBDatabase):
* DatabaseProcess/DatabaseProcess.h:
* DatabaseProcess/DatabaseToWebProcessConnection.h:
Start forwarding things along to the appropriate UniqueIDBDatabase.
* DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::~DatabaseProcessIDBConnection):
(WebKit::DatabaseProcessIDBConnection::disconnectedFromWebProcess):
(WebKit::DatabaseProcessIDBConnection::establishConnection):
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata):
* DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
A class that represents a single concrete IDB database that multiple WebProcesses can connect to.
* DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::UniqueIDBDatabase):
(WebKit::UniqueIDBDatabase::~UniqueIDBDatabase):
(WebKit::UniqueIDBDatabase::registerConnection):
(WebKit::UniqueIDBDatabase::unregisterConnection):
(WebKit::UniqueIDBDatabase::getIDBDatabaseMetadata):
* DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
(WebKit::UniqueIDBDatabase::create):
(WebKit::UniqueIDBDatabase::identifier):
A class to help uniquely identify an IDBDatabase that can be expanded as needed.
Importantly, it knows how to be used as a key in a HashMap.
* DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.cpp: Added.
(WebKit::UniqueIDBDatabaseIdentifier::UniqueIDBDatabaseIdentifier):
(WebKit::UniqueIDBDatabaseIdentifier::isHashTableDeletedValue):
(WebKit::UniqueIDBDatabaseIdentifier::hash):
(WebKit::UniqueIDBDatabaseIdentifier::isNull):
(WebKit::operator==):
* DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.h: Added.
(WebKit::UniqueIDBDatabaseIdentifier::databaseName):
(WebKit::UniqueIDBDatabaseIdentifier::openingOrigin):
(WebKit::UniqueIDBDatabaseIdentifier::mainFrameOrigin):
(WebKit::UniqueIDBDatabaseIdentifierHash::hash):
(WebKit::UniqueIDBDatabaseIdentifierHash::equal):
(WebKit::UniqueIDBDatabaseIdentifierHashTraits::isEmptyValue):
* Shared/SecurityOriginData.cpp:
(WebKit::operator==):
* Shared/SecurityOriginData.h:
* UIProcess/WebContext.cpp:
* WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::open):
(WebKit::WebIDBFactoryBackend::removeIDBDatabaseBackend):
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sun, 24 Nov 2013 21:46:43 +0000 (21:46 +0000)]
Fix more fallout from failed attempts at div/mod DFG strength reductions
https://bugs.webkit.org/show_bug.cgi?id=124813
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithMod):
LayoutTests:
* js/dfg-mod-1-int.html: Added.
* js/dfg-mod-1-int-expected.txt: Added.
* js/script-tests/dfg-mod-1-int.js: Added.
(foo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Sun, 24 Nov 2013 19:14:00 +0000 (19:14 +0000)]
Upstream USE(IOSURFACE) from the iOS port
https://bugs.webkit.org/show_bug.cgi?id=124814
Reviewed by Sam Weinig.
Some code guarded by USE(IOSURFACE) was recently upstreamed,
but not the definition of WTF_USE_IOSURFACE itself.
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 24 Nov 2013 18:20:54 +0000 (18:20 +0000)]
[WK2][GTK] Adding SpatialNavigation setting to webkit2
https://bugs.webkit.org/show_bug.cgi?id=114298
Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk>, Arunprasad Rajkumar <arurajku@cisco.com> on 2013-11-24
Reviewed by Anders Carlsson.
Adding SpatialNavigation support to WebPreferencesStore allows us
to toggle that feature on WebKitSettings.
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetSpatialNavigationEnabled):
(WKPreferencesGetSpatialNavigationEnabled):
* UIProcess/API/C/WKPreferences.h:
* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_set_enable_spatial_navigation):
(webkit_settings_get_enable_spatial_navigation):
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Sun, 24 Nov 2013 15:24:33 +0000 (15:24 +0000)]
Generate toHTMLMarquee|OListElement() to cleanup static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=124707
Reviewed by Darin Adler.
As a step to use toFoo(), we need to generate toHTMLMarquee|OListElement().
Besides this patch cleans up remaining static_cast<> usage.
No new tests, no behavior changes.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::State::initElement):
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::findSiblingForStyleSharing):
* dom/Attr.cpp:
(WebCore::Attr::style):
* dom/Element.cpp:
(WebCore::Element::removeAttribute):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::wrappingStyleForSerialization):
* editing/Editor.cpp:
(WebCore::Editor::applyEditingStyleToElement):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
* html/HTMLMarqueeElement.h:
* html/HTMLOListElement.h:
* html/HTMLTagNames.in:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
* inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForElementInfo):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
* rendering/RenderCounter.cpp:
(WebCore::planCounter):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::updateListMarkerNumbers):
* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::marqueeSpeed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Sun, 24 Nov 2013 08:34:26 +0000 (08:34 +0000)]
REGRESSION (r156291): TileController tiles don't always repaint when they resize
https://bugs.webkit.org/show_bug.cgi?id=124796
Reviewed by Simon Fraser.
In removing platformCALayerDidCreateTiles, r156291 also removed
the call to setNeedsDisplay when tiles are resized, without
putting it somewhere else.
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::setNeedsDisplay):
Use hasStaleContent when invalidating a whole tile, just
like we do for partial tile repaints.
(WebCore::TileController::setTileNeedsDisplayInRect):
Mark hasStaleContent for any unparented layers, so they'll be painted
when they are reparented.
(WebCore::TileController::ensureTilesForRect):
Invalidate the whole tile when it changes size.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sat, 23 Nov 2013 16:20:14 +0000 (16:20 +0000)]
Remove lint from expected result.
Unreviewed.
* platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
calvaris@igalia.com [Sat, 23 Nov 2013 14:35:26 +0000 (14:35 +0000)]
[GStreamer] Remove 0.10 codepath
https://bugs.webkit.org/show_bug.cgi?id=124534
Reviewed by Philippe Normand.
.:
* Source/cmake/OptionsEfl.cmake: Removed GST_API_VERSION_1
definition.
Source/WebCore:
All GStreamer ports are using 1.0 now so we remove the 0.10
codepath.
* GNUmakefile.list.am:
* PlatformEfl.cmake:
* PlatformGTK.cmake:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters: Removed
GStreamerVersioning.
* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(onGStreamerWavparsePadAddedCallback): Removed.
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
Replaced webkitGstPipelineGetBus and removed 0.10 codepath.
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
Replaced webkitGstPipelineGetBus.
* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::copyGstreamerBuffersToAudioChannel):
(WebCore::onAppsinkPullRequiredCallback): Removed 0.10 codepath.
(WebCore::AudioFileReader::~AudioFileReader): Replaced
webkitGstPipelineGetBus and removed 0.10 codepath.
(WebCore::AudioFileReader::handleSample): Left as only codepath.
(WebCore::AudioFileReader::handleBuffer): Removed.
(WebCore::AudioFileReader::handleNewDeinterleavePad): Removed 0.10
codepath.
(WebCore::AudioFileReader::plugDeinterleave): Replaced
getGstAudioCaps.
(WebCore::AudioFileReader::decodeAudioForBusCreation): Replaced
webkitGstPipelineGetBus.
(WebCore::AudioFileReader::createBus): Removed 0.10 codepath.
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(getGStreamerMonoAudioCaps):
(webKitWebAudioGStreamerChannelPosition): Removed 0.10 codepath.
(webkit_web_audio_src_class_init): Replaced
setGstElementClassMetadata.
(webkit_web_audio_src_init):
(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcFinalize):
(webKitWebAudioSrcLoop): Removed 0.10 codepath.
* platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
* platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
Removed checks for 1.0 as it is the only codepath now.
* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::GstElement):
(WTF::GstPad):
(WTF::GstPadTemplate):
(WTF::GstTask):
(WTF::GstBus):
(WTF::GstElementFactory):
(WTF::adoptGRef): Replaced gstObjectIsFloating.
(WTF::refGRef): Replaced webkitGstObjectRefSink.
(WTF::GstTagList):
(WTF::GstSample): Removed checks for 1.0 as it is the only
codepath now.
* platform/graphics/gstreamer/GRefPtrGStreamer.h: Removed checks
for 1.0 as it is the only codepath now.
* platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::webkitGstGhostPadFromStaticTemplate):
(WebCore::getVideoSizeAndFormatFromCaps):
(WebCore::createGstBuffer):
(WebCore::createGstBufferForData):
(WebCore::getGstBufferDataPointer):
(WebCore::mapGstBuffer):
(WebCore::unmapGstBuffer): Moved here from GstVersioning and added
to WebCore namespace.
* platform/graphics/gstreamer/GStreamerUtilities.h:
(WebCore::webkitGstCheckVersion): Moved here from GstVersioning
and added to WebCore namespace.
* platform/graphics/gstreamer/GStreamerVersioning.cpp: Removed.
* platform/graphics/gstreamer/GStreamerVersioning.h: Removed.
* platform/graphics/gstreamer/ImageGStreamer.h: Removed checks for
1.0 as it is the only codepath now.
* platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer): Removed 0.10 codepath.
(ImageGStreamer::~ImageGStreamer): Removed checks for 1.0 as it is
the only codepath now.
* platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:
* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
Removed checks for 1.0 as it is the only codepath now.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::setAudioStreamPropertiesCallback): Removed 0.10 codepath.
(WebCore::mediaPlayerPrivateTextChangedCallback): Removed checks
for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::isAvailable): Replaced
gPlaybinName.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Removed checks for 1.0 and replaced webkitGstPipelineGetBus.
(WebCore::MediaPlayerPrivateGStreamer::duration): Removed 0.10
codepath.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):
Removed checks for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::buffered): Replaced
gPercentMax.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Removed
0.10 codepath.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):
Removed checks for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::totalBytes): Removed 0.10
codepath.
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Replaced
gPlaybinName and webkitGstPipelineGetBus and removed checks for
1.0.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
Removed checks for 1.0 as it is the only codepath now.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::paint): Removed 0.10
codepath.
* platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
* platform/graphics/gstreamer/TextCombinerGStreamer.h:
* platform/graphics/gstreamer/TextSinkGStreamer.cpp:
* platform/graphics/gstreamer/TextSinkGStreamer.h:
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Removed
checks for 1.0 as it is the only codepath now.
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRender): Removed 0.10 codepath and added WebCore
as createGstBuffer namespace.
(webkitVideoSinkSetCaps): Removed 0.10 codepath.
(webkitVideoSinkProposeAllocation): Removed checks for 1.0 as it
is the only codepath now.
(webkitVideoSinkMarshalVoidAndMiniObject): Removed as it was 0.10.
(webkit_video_sink_class_init): Removed 0.10 codepath and replaced
setGstElementClassMetadata.
* platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
* platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
Removed checks for 1.0 as it is the only codepath now.
* platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:
(webkit_media_src_class_init): Replaced
setGstElementClassMetadata.
(webKitMediaSrcAddSrc): Added WebCore namespace to
webkitGstGhostPadFromStaticTemplate.
(MediaSourceClientGstreamer::didReceiveData): Added WebCore
namespace to createGstBufferForData.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
Removed 0.10 codepath.
(webKitWebSrcQuery): Removed as it was 0.10 only.
(void webkit_web_src_class_init): Replaced setGstElementClassMetadata.
(webkit_web_src_init): Removed haveAppSrc27 private attribute and
0.10 codepath.
(webKitWebSrcStop): Removed checks for 1.0 as it is the only
codepath now.
(webKitWebSrcSetProperty):
(webKitWebSrcUriGetType):
(webKitWebSrcGetProtocols):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri): Removed 0.10 codepath.
(StreamingClient::createReadBuffer): Removed checks for 1.0 and
replaced getGstBufferSize.
(StreamingClient::handleResponseReceived): Removed 0.10 codepath
and replaced notifyGstTagsOnPad.
(StreamingClient::handleDataReceived): Removed 0.10 codepath and
replaced setGstBufferSize and gst_buffer_get_size.
Source/WebKit:
* PlatformEfl.cmake: Removed FullscreenVideoControllerEfl.cpp.
Source/WebKit/efl:
* WebCoreSupport/FullscreenVideoControllerEfl.cpp: Removed.
Source/WTF:
* wtf/Platform.h: Removed macro for GStreamer 1.0 as it is the
only codepath now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sat, 23 Nov 2013 11:05:53 +0000 (11:05 +0000)]
Rebaseline empty-clear-blocks.html after r159575
Unreviewed, rebaselining.
* platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 23 Nov 2013 07:11:28 +0000 (07:11 +0000)]
Add DatabaseProcessCreationParameters, starting with the database path.
https://bugs.webkit.org/show_bug.cgi?id=124804
Reviewed by Dean Jackson and Benjamin Poulain.
* DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::initializeDatabaseProcess):
* DatabaseProcess/DatabaseProcess.h:
(WebKit::DatabaseProcess::indexedDatabaseDirectory):
* DatabaseProcess/DatabaseProcess.messages.in:
* Shared/Databases/DatabaseProcessCreationParameters.cpp: Added.
(WebKit::DatabaseProcessCreationParameters::DatabaseProcessCreationParameters):
(WebKit::DatabaseProcessCreationParameters::encode):
(WebKit::DatabaseProcessCreationParameters::decode):
* Shared/Databases/DatabaseProcessCreationParameters.h: Added.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureDatabaseProcess):
* WebKit2.xcodeproj/project.pbxproj:
* Scripts/webkit2/messages.py:
(struct_or_class):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@samsung.com [Sat, 23 Nov 2013 06:03:11 +0000 (06:03 +0000)]
[EFL] Build break after r159724
https://bugs.webkit.org/show_bug.cgi?id=124806
Reviewed by Tim Horton.
* Platform/CoreIPC/Connection.h: Include atomic header.
* UIProcess/CoordinatedGraphics/WebView.cpp: Rename didChangeContentsSize to didChangeContentSize.
(WebKit::WebView::didChangeContentSize):
* UIProcess/CoordinatedGraphics/WebView.h: Ditto.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h: Adjust TARGET_OS_IPHONE macro.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sat, 23 Nov 2013 04:50:45 +0000 (04:50 +0000)]
Layout Test editing/deleting/password-delete-performance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=124781
Reviewed by Alexey Proskuryakov.
PerformanceTests:
Add a new performance test to replace editing/deleting/password-delete-performance.html.
We skip this test by default since it's a micro benchmark.
* Interactive/DeletingInPasswordField.html: Added.
* Skipped:
LayoutTests:
Removed the test that has been timing out.
* TestExpectations:
* editing/deleting/password-delete-performance.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Sat, 23 Nov 2013 03:43:57 +0000 (03:43 +0000)]
Attempt build fixes for 32-bit after 159724.
There's probably a better fix, but this will work for now.
* UIProcess/API/mac/WKView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Sat, 23 Nov 2013 03:29:50 +0000 (03:29 +0000)]
Upstream iOS WebKit2 to OpenSource (part 3).
https://bugs.webkit.org/show_bug.cgi?id=124803
Reviewed by Anders Carlsson and Tim Horton.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Sat, 23 Nov 2013 02:54:31 +0000 (02:54 +0000)]
JSC Obj-C API should have real documentation
https://bugs.webkit.org/show_bug.cgi?id=124805
Reviewed by Geoffrey Garen.
Massaging the header comments into proper headerdocs.
* API/JSContext.h:
* API/JSExport.h:
* API/JSManagedValue.h:
* API/JSValue.h:
* API/JSVirtualMachine.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 23 Nov 2013 00:57:51 +0000 (00:57 +0000)]
[Mac] Can't drag full-screen video to another monitor
https://bugs.webkit.org/show_bug.cgi?id=124798
Reviewed by Geoffrey Garen.
Source/WebCore:
Make full screen windows movable by default. Previously, we wanted non-movable full screen
windows since they were in the same space and were just placed atop non-full screen windows.
Now that all our supported Mac platforms have explicit full screen support, we can remove this
non-movable restriction.
* platform/mac/WebCoreFullScreenWindow.mm:
(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):
Source/WebKit2:
Make full screen windows resizable by default. This allows the window to be resized when
moved between monitors with different resolutions.
* UIProcess/API/mac/WKView.mm:
(-[WKView createFullScreenWindow]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sat, 23 Nov 2013 00:36:55 +0000 (00:36 +0000)]
CodeBlock::m_numCalleeRegisters shouldn't also mean frame size, frame size needed for exit, or any other unrelated things
https://bugs.webkit.org/show_bug.cgi?id=124793
Reviewed by Mark Hahnenberg.
Now m_numCalleeRegisters always refers to the number of locals that the attached
bytecode uses. It never means anything else.
For frame size, we now have it lazily computed from m_numCalleeRegisters for the
baseline engines and we have it stored in DFG::CommonData for the optimizing JITs.
For frame-size-needed-at-exit, we store that in DFG::CommonData, too.
The code no longer implies that there is any arithmetic relationship between
m_numCalleeRegisters and frameSize. Previously it implied that the latter is greater
than the former.
The code no longer implies that there is any arithmetic relationship between the
frame Size and the frame-size-needed-at-exit. Previously it implied that the latter
is greater that the former.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::frameRegisterCount):
* bytecode/CodeBlock.h:
* dfg/DFGCommonData.h:
(JSC::DFG::CommonData::CommonData):
(JSC::DFG::CommonData::requiredRegisterCountForExecutionAndExit):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::frameRegisterCount):
(JSC::DFG::Graph::requiredRegisterCountForExit):
(JSC::DFG::Graph::requiredRegisterCountForExecutionAndExit):
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
* ftl/FTLLink.cpp:
(JSC::FTL::link):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
* ftl/FTLOSREntry.cpp:
(JSC::FTL::prepareOSREntry):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::frameExtentInternal):
* interpreter/JSStackInlines.h:
(JSC::JSStack::pushFrame):
* jit/JIT.h:
(JSC::JIT::frameRegisterCountFor):
* jit/JITOperations.cpp:
* llint/LLIntEntrypoint.cpp:
(JSC::LLInt::frameRegisterCountFor):
* llint/LLIntEntrypoint.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@apple.com [Sat, 23 Nov 2013 00:17:11 +0000 (00:17 +0000)]
[Win] Clean up ColorSpace handling in Windows code
https://bugs.webkit.org/show_bug.cgi?id=124795
Reviewed by Tim Horton.
Functionality covered by existing fast/css/color test suite.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::safeRGBColorSpaceRef): Handle case of Windows CG implementation not
handling sRGB correctly.
(WebCore::sRGBColorSpaceRef): Use new helper function.
* platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs): Pass correct color space to fill functions.
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::platformInit): Initialize color space to value passed
via the style to the constructor.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Sat, 23 Nov 2013 00:07:55 +0000 (00:07 +0000)]
[WK2] Another build fix for NetworkProcess on iOS
https://bugs.webkit.org/show_bug.cgi?id=124797
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-22
Reviewed by Alexey Proskuryakov.
* NetworkProcess/NetworkResourceLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Fri, 22 Nov 2013 23:47:49 +0000 (23:47 +0000)]
[WK2] Fix the build of the NetworkProcess on iOS
https://bugs.webkit.org/show_bug.cgi?id=124794
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-22
Reviewed by Alexey Proskuryakov.
* NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
(WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer):
* NetworkProcess/NetworkResourceLoader.h:
* NetworkProcess/SynchronousNetworkLoaderClient.cpp:
(WebKit::SynchronousNetworkLoaderClient::willSendRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 22 Nov 2013 23:43:54 +0000 (23:43 +0000)]
WebCrypto algorithms should check that key algorithm matches
https://bugs.webkit.org/show_bug.cgi?id=123628
Reviewed by Anders Carlsson.
No change in behavior yet, because we have one algorithm per key class.
Will be tested once more algorithms are added.
* WebCore.xcodeproj/project.pbxproj: Updated for file renames.
* bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::createRsaKeyParamsWithHash):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
* bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::createRSAKeyParametersWithHash):
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
* crypto/CryptoAlgorithmParameters.h:
(WebCore::CryptoAlgorithmParameters::ENUM_CLASS):
* crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h: Copied from Source/WebCore/crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h.
* crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h: Removed.
Renamed RsaSsaKeyParams to RsaKeyParamsWithHash, because other algorithms (like RSA-OAEP)
are in the same boat. Depending on where the spec goes, we might need to introduce
algorithm specific RSA parameter classes later, but let's reduce copy/pasted code at
least for now.
* crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Moved to the correct directory.
* crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Copied from Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign): Factored out Mac specific
code, leaving type casting to cross-platform files.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify): Ditto.
* crypto/CryptoAlgorithmRegistry.h:
(WebCore::CryptoAlgorithmRegistry::registerAlgorithm):
* crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Reduce copy/pasting in registration code.
* crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::keyAlgorithmMatches): Check key type and algorithm.
(WebCore::CryptoAlgorithmAES_CBC::encrypt): Cross platform type casting code.
Maybe we'll find a way to autogenerate or eliminate it one day.
(WebCore::CryptoAlgorithmAES_CBC::decrypt): Ditto.
* crypto/algorithms/CryptoAlgorithmAES_CBC.h:
* crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
* crypto/algorithms/CryptoAlgorithmHMAC.h:
* crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):
* crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
* crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
* crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
Same changes for all algorithms that have keys.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rego@igalia.com [Fri, 22 Nov 2013 22:57:02 +0000 (22:57 +0000)]
[GTK] Review enabled/disabled CSS features for release builds
https://bugs.webkit.org/show_bug.cgi?id=124791
Reviewed by Martin Robinson.
Enable and disable some CSS features according to what last versions of
Safari ship or not.
* Source/autotools/SetupWebKitFeatures.m4: Enable ENABLE_CSS_REGIONS and
ENABLE_CSS_STICKY_POSITION. Disable ENABLE_CSS_EXCLUSIONS and
ENABLE_CSS_SHAPES.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 22 Nov 2013 22:52:12 +0000 (22:52 +0000)]
Move the remaining page loader clients out into separate files
https://bugs.webkit.org/show_bug.cgi?id=124792
Reviewed by Dan Bernstein.
* UIProcess/API/C/WKPage.h:
* UIProcess/API/C/WKPageContextMenuClient.h: Added.
* UIProcess/API/C/WKPageFindClient.h: Added.
* UIProcess/API/C/WKPageFindMatchesClient.h: Added.
* UIProcess/API/C/WKPageFormClient.h: Added.
* UIProcess/API/C/WKPageLoaderClient.h:
* UIProcess/API/C/WKPagePolicyClient.h: Added.
* UIProcess/API/C/WKPageUIClient.h: Added.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 22 Nov 2013 22:24:26 +0000 (22:24 +0000)]
Fire "change" event on TextTrackList when a TextTrack's mode changes
https://bugs.webkit.org/show_bug.cgi?id=124789
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-22
Reviewed by Eric Carlson.
Source/WebCore:
Since AudioTrackList and VideoTrackList already have this event, the
interesting bits are in TrackListBase::scheduleChangeEvent(), and we
just need to call it for TextTrackList changes.
Test: media/track/track-change-event.html
* html/HTMLMediaElement.cpp:
(HTMLMediaElement::textTrackModeChanged): Call TrackListBase::scheduleChangeEvent().
* html/track/TextTrackList.idl: Add onchange event listener.
LayoutTests:
* media/track/track-change-event-expected.txt: Added.
* media/track/track-change-event.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 22 Nov 2013 22:03:56 +0000 (22:03 +0000)]
Combine SymbolTable and SharedSymbolTable
https://bugs.webkit.org/show_bug.cgi?id=124761
Reviewed by Geoffrey Garen.
SymbolTable was never used directly; we now always used SharedSymbolTable. So, this
gets rid of SymbolTable and renames SharedSymbolTable to SymbolTable.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::symbolTable):
* bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedFunctionExecutable::symbolTable):
(JSC::UnlinkedCodeBlock::symbolTable):
(JSC::UnlinkedCodeBlock::finishCreation):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::symbolTable):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::symbolTableFor):
* runtime/Arguments.h:
(JSC::Arguments::finishCreation):
* runtime/Executable.h:
(JSC::FunctionExecutable::symbolTable):
* runtime/JSActivation.h:
(JSC::JSActivation::create):
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::registersOffset):
(JSC::JSActivation::allocationSize):
* runtime/JSSymbolTableObject.h:
(JSC::JSSymbolTableObject::symbolTable):
(JSC::JSSymbolTableObject::JSSymbolTableObject):
(JSC::JSSymbolTableObject::finishCreation):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::JSVariableObject):
* runtime/SymbolTable.cpp:
(JSC::SymbolTable::destroy):
(JSC::SymbolTable::SymbolTable):
* runtime/SymbolTable.h:
(JSC::SymbolTable::create):
(JSC::SymbolTable::createStructure):
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 22 Nov 2013 21:59:32 +0000 (21:59 +0000)]
Move WKPageLoaderClient out into a separate header
https://bugs.webkit.org/show_bug.cgi?id=124790
Reviewed by Dan Bernstein.
* UIProcess/API/C/WKPage.h:
* UIProcess/API/C/WKPageLoaderClient.h: Added.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log