WebKit-https.git
11 years agoWebCore:
darin@apple.com [Fri, 8 May 2009 01:31:45 +0000 (01:31 +0000)]
WebCore:

2009-05-07  Darin Adler  <darin@apple.com>

        Reviewed by Simon Fraser.

        Bug 25575: Registered mutation event listener crashes HTMLMediaElement
        https://bugs.webkit.org/show_bug.cgi?id=25575

        Test: fast/media/video-controls-with-mutation-event-handler.html

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Don't call setAttribute.
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::createTimeline): Call setAttribute here.

LayoutTests:

2009-05-07  Darin Adler  <darin@apple.com>

        Reviewed by Simon Fraser.

        Bug 25575: Registered mutation event listener crashes HTMLMediaElement
        https://bugs.webkit.org/show_bug.cgi?id=25575

        * fast/media/video-controls-with-mutation-event-handler-expected.txt: Added.
        * fast/media/video-controls-with-mutation-event-handler.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 8 May 2009 01:23:32 +0000 (01:23 +0000)]
2009-05-07  Simon Fraser  <simon.fraser@apple.com>

        Rubber Stamped by Dave Hyatt

        Shuffle the data members to minimize padding.

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::RenderTableSection):
        * rendering/RenderTableSection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 8 May 2009 01:23:27 +0000 (01:23 +0000)]
2009-05-07  Simon Fraser  <simon.fraser@apple.com>

        Rubber Stamped by Dave Hyatt

        Shuffle the data members to make Events 8 bytes smaller in 64-bit.

        * dom/Event.cpp:
        (WebCore::Event::Event):
        * dom/Event.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bdakin@apple.com [Fri, 8 May 2009 00:16:35 +0000 (00:16 +0000)]
WebCore:

2009-05-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Beth Dakin.

        Fix regression caused by r41469, add test case to prevent it from
        happening again.
        https://bugs.webkit.org/show_bug.cgi?id=25252

        hasLayer() was true during removeOnlyThisLayer()/
        updateLayerPositions()
        which caused updateLayerPosition()'s walk up the render tree to
        include offsets from the layer we were about to remove.

        I'm not 100% convinced that this wasn't a bug in
        updateLayerPosition() or in RenderBoxModelObject::styleDidChange,
        because the layer in question is not the containing block for the
        block which gets laid out wrong. But this restores the previous
        behavior and adds a test.  So the next time someone is in here re-
        factoring, they will at least know if they break something.

        Test: fast/layers/remove-only-this-layer-update.html

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::destroyLayer):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::removeOnlyThisLayer):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::destroy):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::destroy):

LayoutTests:

2009-05-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Beth Dakin.

        Fix regression caused by r41469, add test case to prevent it from
        happening again.
        https://bugs.webkit.org/show_bug.cgi?id=25252

        * fast/layers/remove-only-this-layer-update.html: Added.
        * platform/mac/fast/layers/remove-only-this-layer-update-expected.checksum: Added.
        * platform/mac/fast/layers/remove-only-this-layer-update-expected.png: Added.
        * platform/mac/fast/layers/remove-only-this-layer-update-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 8 May 2009 00:02:45 +0000 (00:02 +0000)]
2009-05-07  Geoffrey Garen  <ggaren@apple.com>

        Not reviewed.

        * wtf/Platform.h: Reverted an accidental (and performance-catastrophic)
        change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 8 May 2009 00:01:19 +0000 (00:01 +0000)]
2009-05-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Fixed a minor sequencing error introduced by recent Parser speedups.

        * parser/Parser.cpp:
        (JSC::Parser::reparseInPlace): Missed a spot in my last patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 7 May 2009 23:51:12 +0000 (23:51 +0000)]
2009-05-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Fixed a minor sequencing error introduced by recent Parser speedups.

        * parser/Parser.cpp:
        (JSC::Parser::parse):
        * parser/Parser.h:
        (JSC::Parser::parse):
        (JSC::Parser::reparse): Shrink the parsedObjects vector after allocating
        the root node, to avoid leaving a stray node in the vector, since that's
        a slight memory leak, and it causes problems during JSGlobalData teardown.

        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::~JSGlobalData): ASSERT that we're not being torn
        down while we think we're still parsing, since that would cause lots of
        bad memory references during our destruction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 7 May 2009 23:33:00 +0000 (23:33 +0000)]
2009-05-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Replaced two more macros with references to the JITStackFrame structure.

        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        * jit/JITInlineMethods.h:
        (JSC::JIT::restoreArgumentReference):
        * jit/JITStubs.cpp:
        (JSC::):
        * jit/JITStubs.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Thu, 7 May 2009 23:11:37 +0000 (23:11 +0000)]
2009-05-07  Dmitry Titov  <dimich@chromium.org>

        Attempt to fix GTK build.

        * platform/graphics/GlyphPageTreeNode.h: add #include <string.h> to ensure memcpy and memset are defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImprove native call performance
oliver@apple.com [Thu, 7 May 2009 22:52:19 +0000 (22:52 +0000)]
Improve native call performance

Reviewed by Gavin Barraclough.

Fix the windows build by adding calling convention declarations everywhere,
chose fastcall as that seemed most sensible given we were having to declare
the convention explicitly.  In addition switched to fastcall on mac in the
deluded belief that documented fastcall behavior on windows would match
actual its actual behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 7 May 2009 22:26:29 +0000 (22:26 +0000)]
2009-05-07  Geoffrey Garen  <ggaren@apple.com>

        Not reviewed.

        Rolled out a portion of r43352 because it broke 64bit.

        * jit/JITStubs.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Thu, 7 May 2009 22:25:06 +0000 (22:25 +0000)]
2009-05-07  Dmitry Titov  <dimich@chromium.org>

        Attempt to fix Win build.

        * jit/JITArithmetic.cpp:
        (JSC::JIT::compileFastArithSlow_op_jnless):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix for functions reaturning ThreadIdentifier.
kevino@webkit.org [Thu, 7 May 2009 22:21:13 +0000 (22:21 +0000)]
Build fix for functions reaturning ThreadIdentifier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 7 May 2009 22:07:25 +0000 (22:07 +0000)]
2009-05-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by John Honeycutt.

        - enable optimization case im the last patch that I accidentally had disabled.

        * jit/JITArithmetic.cpp:
        (JSC::JIT::compileFastArithSlow_op_jnless):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Dave Hyatt.
zimmermann@webkit.org [Thu, 7 May 2009 21:43:11 +0000 (21:43 +0000)]
Reviewed by Dave Hyatt.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=25617

Fix memory/performance regression because of too much form control related abstraction just for WMLs sake.

Remove FormControlElement and FormControlElementWithState base classes, as the overhead is too high for the
gain. HTML has no benefit of that kind of abstraction, so we're going to move the functionality to Element directly.

The functions now living in FormControlElement(WithState) lived in Node/Element/HTMLFormControlElement before.
This patches moves all of them in a central place in Element.h, as virtual functions with an inline default implementation.
To avoid confusion like isEnabled() living on Node, before the creation of the FormControlElement abstraction layer, all
methods are renamed to clarify where they belong to. (Detailed list in ChangeLog)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
dimich@chromium.org [Thu, 7 May 2009 21:24:36 +0000 (21:24 +0000)]
JavaScriptCore:

2009-05-07  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov and Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=25348
        Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.

        * wtf/Threading.h:
        (WTF::ThreadIdentifier::ThreadIdentifier):
        (WTF::ThreadIdentifier::isValid):
        (WTF::ThreadIdentifier::invalidate):
        (WTF::ThreadIdentifier::platformId):
        ThreadIdentifier is now a class, containing a PlatformThreadIdentifier and
        methods that are used across the code on thread ids: construction, comparisons,
        check for 'valid' state etc. '0' is used as invalid id, which happens to just work
        with all platform-specific thread id implementations.

        All the following files repeatedly reflect the new ThreadIdentifier for each platform.
        We remove ThreadMap and threadMapMutex from all of them, remove the functions that
        populated/searched/cleared the map and add platform-specific comparison operators
        for ThreadIdentifier.

        * wtf/gtk/ThreadingGtk.cpp:
        (WTF::ThreadIdentifier::operator==):
        (WTF::ThreadIdentifier::operator!=):
        (WTF::initializeThreading):
        (WTF::createThreadInternal):
        (WTF::waitForThreadCompletion):
        (WTF::currentThread):

        * wtf/ThreadingNone.cpp:
        (WTF::ThreadIdentifier::operator==):
        (WTF::ThreadIdentifier::operator!=):

        * wtf/ThreadingPthreads.cpp:
        (WTF::ThreadIdentifier::operator==):
        (WTF::ThreadIdentifier::operator!=):
        (WTF::initializeThreading):
        (WTF::createThreadInternal):
        (WTF::waitForThreadCompletion):
        (WTF::detachThread):
        (WTF::currentThread):

        * wtf/qt/ThreadingQt.cpp:
        (WTF::ThreadIdentifier::operator==):
        (WTF::ThreadIdentifier::operator!=):
        (WTF::initializeThreading):
        (WTF::createThreadInternal):
        (WTF::waitForThreadCompletion):
        (WTF::currentThread):

        * wtf/ThreadingWin.cpp:
        (WTF::ThreadIdentifier::operator==):
        (WTF::ThreadIdentifier::operator!=):
        (WTF::initializeThreading):
        (WTF::createThreadInternal): All the platforms (except Windows) used a sequential
        counter as a thread ID and mapped it into platform ID. Windows was using native thread
        id and mapped it into thread handle. Since we can always obtain a thread handle
        by thread id, createThread now closes the handle.
        (WTF::waitForThreadCompletion): obtains another one using OpenThread(id) API. If can not obtain a handle,
        it means the thread already exited.
        (WTF::detachThread):
        (WTF::currentThread):
        (WTF::detachThreadDeprecated): old function, renamed (for Win Safari 4 beta which uses it for now).
        (WTF::waitForThreadCompletionDeprecated): same.
        (WTF::currentThreadDeprecated): same.
        (WTF::createThreadDeprecated): same.

        * bytecode/SamplingTool.h:
        * bytecode/SamplingTool.cpp: Use DEFINE_STATIC_LOCAL for a static ThreadIdentifier variable, to avoid static constructor.

        * JavaScriptCore.exp: export lists - updated the WTF threading functions decorated names
        since they now take a different type as a parameter.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: ditto for Windows, plus added "deprecated" functions
        that take old parameter type - turns out public beta of Safari 4 uses those, so they need to be kept along for a while.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: ditto.

WebCore:

2009-05-07  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov and Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=25348
        Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.

        Most of the change is in WTF.
        Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
        method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
        is now a class rather then an integer.
        Also, there is no need to initialize threadID in constructors to 0 now.

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id,
        since now ThreadIdentifier needs construction and we avoid having global initializers.
        (WebCore::matchFunc): use the new accessor function.
        (WebCore::openFunc): ditto.
        (WebCore::createStringParser): ditto.
        (WebCore::createMemoryParser): ditto.
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::open):
        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::SQLiteDatabase):
        (WebCore::SQLiteDatabase::close):
        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::start):
        (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
        * storage/LocalStorageThread.cpp:
        (WebCore::LocalStorageThread::start):
        (WebCore::LocalStorageThread::scheduleImport):
        (WebCore::LocalStorageThread::scheduleSync):
        (WebCore::LocalStorageThread::terminate):
        * workers/WorkerThread.cpp:
        (WebCore::WorkerThread::start):
        (WebCore::WorkerThread::WorkerThread):
        (WebCore::WorkerThread::start):

WebKit/win:

2009-05-07  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov and Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=25348
        Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.

        Most of the change is in WTF and WebCore.

        * WebKit.vcproj/WebKit.def: replaced decorated names of WTF threading functions with new ones.
        Also, aliased the old implementations so the public Safari 4 beta can load the old WTF functions
        which it uses. Next time Safari 4 builds, it will pick up new functions and the deprecated ones
        can be removed.
        * WebKit.vcproj/WebKit_debug.def: same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 7 May 2009 21:21:45 +0000 (21:21 +0000)]
2009-05-07  Simon Fraser  <simon.fraser@apple.com>

        Rubber Stamped by Dave Hyatt

        Shuffle the data members to minimize padding.

        * dom/ClassNames.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 7 May 2009 21:10:34 +0000 (21:10 +0000)]
2009-05-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/6864062> Shrink GlyphPage from 4112 to 2576 bytes in 64-bit
        https://bugs.webkit.org/show_bug.cgi?id=25605

        Shrink GlyphPage by splitting the array of GlyphData, which has lots
        of padding, into separate Glyph and SimpleFontData* arrays.

        * platform/graphics/Font.h:
        glyphDataForCharacter has to return a GlyphData by value now.

        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::glyphDataForCharacter):
        Return GlyphData by value.

        * platform/graphics/GlyphPageTreeNode.cpp:
        (WebCore::GlyphPageTreeNode::initializePage):
        Better encapsulation of GlyphPage, using the new methods.

        * platform/graphics/Font.h:
        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::glyphDataForCharacter):
        * platform/graphics/GlyphPageTreeNode.cpp:
        (WebCore::GlyphPageTreeNode::initializePage):
        * platform/graphics/GlyphPageTreeNode.h:
        (WebCore::GlyphData::GlyphData):
        (WebCore::GlyphPage::indexForCharacter):
        (WebCore::GlyphPage::glyphDataForCharacter):
        (WebCore::GlyphPage::glyphDataForIndex):
        (WebCore::GlyphPage::glyphAt):
        (WebCore::GlyphPage::fontDataForCharacter):
        (WebCore::GlyphPage::setGlyphDataForCharacter):
        (WebCore::GlyphPage::setGlyphDataForIndex):
        (WebCore::GlyphPage::copyFrom):
        (WebCore::GlyphPage::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 7 May 2009 20:42:59 +0000 (20:42 +0000)]
2009-05-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        - optimize various cases of branch-fused less

        1% speedup on SunSpider overall
        13% speedup on math-cordic

        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        op_loop_if_less: Optimize case of constant as first operand, just as case of constant as
        second operand.
        op_jnless: Factored out into compileFastArith_op_jnless.
        (JSC::JIT::privateCompileSlowCases):
        op_jnless: Factored out into compileFastArithSlow_op_jnless.
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        (JSC::JIT::compileFastArith_op_jnless): Factored out from main compile loop.
        - Generate inline code for comparison of constant immediate int as first operand to another
        immediate int, as for loop_if_less

        (JSC::JIT::compileFastArithSlow_op_jnless):
        - Generate inline code for comparing two floating point numbers.
        - Generate code for both cases of comparing a floating point number to a constant immediate
        int.
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::dump): Fix dumping of op_jnless (tangentially related bugfix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 7 May 2009 20:22:55 +0000 (20:22 +0000)]
2009-05-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Added the return address of a stub function to the JITStackFrame abstraction.

        * jit/JIT.cpp:
        * jit/JIT.h:
        * jit/JITStubs.cpp:
        (JSC::):
        (JSC::StackHack::StackHack):
        (JSC::StackHack::~StackHack):
        (JSC::returnToThrowTrampoline):
        (JSC::JITStubs::cti_op_convert_this):
        (JSC::JITStubs::cti_op_end):
        (JSC::JITStubs::cti_op_add):
        (JSC::JITStubs::cti_op_pre_inc):
        (JSC::JITStubs::cti_timeout_check):
        (JSC::JITStubs::cti_register_file_check):
        (JSC::JITStubs::cti_op_loop_if_less):
        (JSC::JITStubs::cti_op_loop_if_lesseq):
        (JSC::JITStubs::cti_op_new_object):
        (JSC::JITStubs::cti_op_put_by_id_generic):
        (JSC::JITStubs::cti_op_get_by_id_generic):
        (JSC::JITStubs::cti_op_put_by_id):
        (JSC::JITStubs::cti_op_put_by_id_second):
        (JSC::JITStubs::cti_op_put_by_id_fail):
        (JSC::JITStubs::cti_op_get_by_id):
        (JSC::JITStubs::cti_op_get_by_id_second):
        (JSC::JITStubs::cti_op_get_by_id_self_fail):
        (JSC::JITStubs::cti_op_get_by_id_proto_list):
        (JSC::JITStubs::cti_op_get_by_id_proto_list_full):
        (JSC::JITStubs::cti_op_get_by_id_proto_fail):
        (JSC::JITStubs::cti_op_get_by_id_array_fail):
        (JSC::JITStubs::cti_op_get_by_id_string_fail):
        (JSC::JITStubs::cti_op_instanceof):
        (JSC::JITStubs::cti_op_del_by_id):
        (JSC::JITStubs::cti_op_mul):
        (JSC::JITStubs::cti_op_new_func):
        (JSC::JITStubs::cti_op_call_JSFunction):
        (JSC::JITStubs::cti_op_call_arityCheck):
        (JSC::JITStubs::cti_vm_dontLazyLinkCall):
        (JSC::JITStubs::cti_vm_lazyLinkCall):
        (JSC::JITStubs::cti_op_push_activation):
        (JSC::JITStubs::cti_op_call_NotJSFunction):
        (JSC::JITStubs::cti_op_create_arguments):
        (JSC::JITStubs::cti_op_create_arguments_no_params):
        (JSC::JITStubs::cti_op_tear_off_activation):
        (JSC::JITStubs::cti_op_tear_off_arguments):
        (JSC::JITStubs::cti_op_profile_will_call):
        (JSC::JITStubs::cti_op_profile_did_call):
        (JSC::JITStubs::cti_op_ret_scopeChain):
        (JSC::JITStubs::cti_op_new_array):
        (JSC::JITStubs::cti_op_resolve):
        (JSC::JITStubs::cti_op_construct_JSConstruct):
        (JSC::JITStubs::cti_op_construct_NotJSConstruct):
        (JSC::JITStubs::cti_op_get_by_val):
        (JSC::JITStubs::cti_op_get_by_val_string):
        (JSC::JITStubs::cti_op_get_by_val_byte_array):
        (JSC::JITStubs::cti_op_resolve_func):
        (JSC::JITStubs::cti_op_sub):
        (JSC::JITStubs::cti_op_put_by_val):
        (JSC::JITStubs::cti_op_put_by_val_array):
        (JSC::JITStubs::cti_op_put_by_val_byte_array):
        (JSC::JITStubs::cti_op_lesseq):
        (JSC::JITStubs::cti_op_loop_if_true):
        (JSC::JITStubs::cti_op_load_varargs):
        (JSC::JITStubs::cti_op_negate):
        (JSC::JITStubs::cti_op_resolve_base):
        (JSC::JITStubs::cti_op_resolve_skip):
        (JSC::JITStubs::cti_op_resolve_global):
        (JSC::JITStubs::cti_op_div):
        (JSC::JITStubs::cti_op_pre_dec):
        (JSC::JITStubs::cti_op_jless):
        (JSC::JITStubs::cti_op_not):
        (JSC::JITStubs::cti_op_jtrue):
        (JSC::JITStubs::cti_op_post_inc):
        (JSC::JITStubs::cti_op_eq):
        (JSC::JITStubs::cti_op_lshift):
        (JSC::JITStubs::cti_op_bitand):
        (JSC::JITStubs::cti_op_rshift):
        (JSC::JITStubs::cti_op_bitnot):
        (JSC::JITStubs::cti_op_resolve_with_base):
        (JSC::JITStubs::cti_op_new_func_exp):
        (JSC::JITStubs::cti_op_mod):
        (JSC::JITStubs::cti_op_less):
        (JSC::JITStubs::cti_op_neq):
        (JSC::JITStubs::cti_op_post_dec):
        (JSC::JITStubs::cti_op_urshift):
        (JSC::JITStubs::cti_op_bitxor):
        (JSC::JITStubs::cti_op_new_regexp):
        (JSC::JITStubs::cti_op_bitor):
        (JSC::JITStubs::cti_op_call_eval):
        (JSC::JITStubs::cti_op_throw):
        (JSC::JITStubs::cti_op_get_pnames):
        (JSC::JITStubs::cti_op_next_pname):
        (JSC::JITStubs::cti_op_push_scope):
        (JSC::JITStubs::cti_op_pop_scope):
        (JSC::JITStubs::cti_op_typeof):
        (JSC::JITStubs::cti_op_is_undefined):
        (JSC::JITStubs::cti_op_is_boolean):
        (JSC::JITStubs::cti_op_is_number):
        (JSC::JITStubs::cti_op_is_string):
        (JSC::JITStubs::cti_op_is_object):
        (JSC::JITStubs::cti_op_is_function):
        (JSC::JITStubs::cti_op_stricteq):
        (JSC::JITStubs::cti_op_to_primitive):
        (JSC::JITStubs::cti_op_strcat):
        (JSC::JITStubs::cti_op_nstricteq):
        (JSC::JITStubs::cti_op_to_jsnumber):
        (JSC::JITStubs::cti_op_in):
        (JSC::JITStubs::cti_op_push_new_scope):
        (JSC::JITStubs::cti_op_jmp_scopes):
        (JSC::JITStubs::cti_op_put_by_index):
        (JSC::JITStubs::cti_op_switch_imm):
        (JSC::JITStubs::cti_op_switch_char):
        (JSC::JITStubs::cti_op_switch_string):
        (JSC::JITStubs::cti_op_del_by_val):
        (JSC::JITStubs::cti_op_put_getter):
        (JSC::JITStubs::cti_op_put_setter):
        (JSC::JITStubs::cti_op_new_error):
        (JSC::JITStubs::cti_op_debug):
        (JSC::JITStubs::cti_vm_throw):
        * jit/JITStubs.h:
        (JSC::JITStackFrame::returnAddressSlot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 7 May 2009 20:17:55 +0000 (20:17 +0000)]
2009-05-07  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        * parser/Lexer.cpp:
        (JSC::Lexer::lex): Fix missing braces. This would make us always
        take the slower case for string parsing and Visual Studio correctly
        noticed unreachable code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 7 May 2009 20:16:20 +0000 (20:16 +0000)]
2009-05-07  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=25625
        Implement Image/Option constructors in V8 bindings.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::NAMED_PROPERTY_GETTER): Removed old JS-based code.
        * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Added.
        * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Thu, 7 May 2009 20:06:26 +0000 (20:06 +0000)]
2009-05-07  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
        (WebKit::FrameLoaderClient::dispatchDidCommitLoad): Add missing
        call to notifyStatus in the committed case and a missing property notify.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 7 May 2009 20:03:48 +0000 (20:03 +0000)]
2009-05-07  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 25589: goto instead of state machine in lexer
        https://bugs.webkit.org/show_bug.cgi?id=25589

        SunSpider is 0.8% faster.

        * parser/Lexer.cpp:
        (JSC::Lexer::currentCharacter): Added.
        (JSC::Lexer::currentOffset): Changed to call currentCharacter for clarity.
        (JSC::Lexer::setCode): Removed code to set now-obsolete m_skipLineEnd.
        (JSC::Lexer::shiftLineTerminator): Added. Handles line numbers and the
        two-character line terminators.
        (JSC::Lexer::makeIdentifier): Changed to take characters and length rather
        than a vector, since we now make these directly out of the source buffer
        when possible.
        (JSC::Lexer::lastTokenWasRestrKeyword): Added.
        (JSC::isNonASCIIIdentStart): Broke out the non-inline part.
        (JSC::isIdentStart): Moved here.
        (JSC::isNonASCIIIdentPart): Broke out the non-inline part.
        (JSC::isIdentPart): Moved here.
        (JSC::singleEscape): Moved here, and removed some unneeded cases.
        (JSC::Lexer::record8): Moved here.
        (JSC::Lexer::record16): Moved here.
        (JSC::Lexer::lex): Rewrote this whole function to use goto and not use
        a state machine. Got rid of most of the local variables. Also rolled the
        matchPunctuator function in here.
        (JSC::Lexer::scanRegExp): Changed to use the new version of isLineTerminator.
        Clear m_buffer16 after using it instead of before.

        * parser/Lexer.h: Removed State enum, setDone function, nextLine function,
        lookupKeywordFunction, one of the isLineTerminator functions, m_done data member,
        m_skipLineEnd data member, and m_state data member. Added shiftLineTerminator
        function, currentCharacter function, and changed the arguments to the makeIdentifier
        function. Removed one branch from the isLineTerminator function.

        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncReplace): Streamlined the case where we don't replace anything.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 7 May 2009 19:36:27 +0000 (19:36 +0000)]
2009-05-07  Brady Eidson  <beidson@apple.com>

        I hate myself for doing this, but need to fix that ChangeLog entry.

        * ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 7 May 2009 19:29:35 +0000 (19:29 +0000)]
2009-05-07  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Darin Adler

        * html/HTMLParser.cpp: Use the correct style of BUILD_ON_* for WebCore.
        * html/HTMLParser.h: Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Thu, 7 May 2009 19:13:53 +0000 (19:13 +0000)]
WebCore:

2009-05-07  David Hyatt  <hyatt@apple.com>

        Restore intrinsic margins to all form controls on Mac and Windows.  Some of this regressed in 43007
        when textareas were given explicit margins.  Some of it had already regressed earlier whenever intrinsic
        margins were turned off in themeWin.css.

        Reviewed by Beth Dakin.

        * css/html4.css:
        * css/themeWin.css:

LayoutTests:

2009-05-07  David Hyatt  <hyatt@apple.com>

        Restore intrinsic margins to all form controls on Mac and Windows.

        Reviewed by Beth Dakin.

        * fast/forms/text-control-intrinsic-widths-expected.txt:
        * fast/replaced/table-percent-height-text-controls-expected.txt:
        * platform/mac/editing/inserting/4960120-1-expected.checksum:
        * platform/mac/editing/inserting/4960120-1-expected.png:
        * platform/mac/editing/inserting/4960120-1-expected.txt:
        * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
        * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png:
        * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
        * platform/mac/editing/pasteboard/pasting-tabs-expected.checksum:
        * platform/mac/editing/pasteboard/pasting-tabs-expected.png:
        * platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
        * platform/mac/fast/css/resize-corner-tracking-expected.checksum:
        * platform/mac/fast/css/resize-corner-tracking-expected.png:
        * platform/mac/fast/css/resize-corner-tracking-expected.txt:
        * platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum:
        * platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
        * platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
        * platform/mac/fast/dynamic/008-expected.checksum:
        * platform/mac/fast/dynamic/008-expected.png:
        * platform/mac/fast/dynamic/008-expected.txt:
        * platform/mac/fast/forms/001-expected.checksum:
        * platform/mac/fast/forms/001-expected.png:
        * platform/mac/fast/forms/basic-textareas-expected.checksum:
        * platform/mac/fast/forms/basic-textareas-expected.png:
        * platform/mac/fast/forms/basic-textareas-expected.txt:
        * platform/mac/fast/forms/form-element-geometry-expected.checksum:
        * platform/mac/fast/forms/form-element-geometry-expected.png:
        * platform/mac/fast/forms/form-element-geometry-expected.txt:
        * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
        * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
        * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
        * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.checksum:
        * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
        * platform/mac/fast/forms/menulist-clip-expected.checksum:
        * platform/mac/fast/forms/menulist-clip-expected.png:
        * platform/mac/fast/forms/menulist-narrow-width-expected.checksum:
        * platform/mac/fast/forms/menulist-narrow-width-expected.png:
        * platform/mac/fast/forms/menulist-option-wrap-expected.checksum:
        * platform/mac/fast/forms/menulist-option-wrap-expected.png:
        * platform/mac/fast/forms/menulist-restrict-line-height-expected.checksum:
        * platform/mac/fast/forms/menulist-restrict-line-height-expected.png:
        * platform/mac/fast/forms/negativeLineHeight-expected.checksum:
        * platform/mac/fast/forms/negativeLineHeight-expected.png:
        * platform/mac/fast/forms/negativeLineHeight-expected.txt:
        * platform/mac/fast/forms/select-baseline-expected.checksum:
        * platform/mac/fast/forms/select-baseline-expected.png:
        * platform/mac/fast/forms/select-style-expected.checksum:
        * platform/mac/fast/forms/select-style-expected.png:
        * platform/mac/fast/forms/textAreaLineHeight-expected.checksum:
        * platform/mac/fast/forms/textAreaLineHeight-expected.png:
        * platform/mac/fast/forms/textAreaLineHeight-expected.txt:
        * platform/mac/fast/forms/textarea-align-expected.checksum:
        * platform/mac/fast/forms/textarea-align-expected.png:
        * platform/mac/fast/forms/textarea-align-expected.txt:
        * platform/mac/fast/forms/textarea-rows-cols-expected.checksum:
        * platform/mac/fast/forms/textarea-rows-cols-expected.png:
        * platform/mac/fast/forms/textarea-rows-cols-expected.txt:
        * platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
        * platform/mac/fast/forms/textarea-scroll-height-expected.png:
        * platform/mac/fast/forms/textarea-scroll-height-expected.txt:
        * platform/mac/fast/forms/textarea-scrollbar-expected.checksum:
        * platform/mac/fast/forms/textarea-scrollbar-expected.png:
        * platform/mac/fast/forms/textarea-scrollbar-expected.txt:
        * platform/mac/fast/forms/textarea-scrolled-type-expected.checksum:
        * platform/mac/fast/forms/textarea-scrolled-type-expected.png:
        * platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
        * platform/mac/fast/forms/textarea-setinnerhtml-expected.checksum:
        * platform/mac/fast/forms/textarea-setinnerhtml-expected.png:
        * platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
        * platform/mac/fast/forms/textarea-width-expected.checksum:
        * platform/mac/fast/forms/textarea-width-expected.png:
        * platform/mac/fast/forms/textarea-width-expected.txt:
        * platform/mac/fast/overflow/overflow-focus-ring-expected.checksum:
        * platform/mac/fast/overflow/overflow-focus-ring-expected.png:
        * platform/mac/fast/overflow/overflow-x-y-expected.checksum:
        * platform/mac/fast/overflow/overflow-x-y-expected.png:
        * platform/mac/fast/overflow/overflow-x-y-expected.txt:
        * platform/mac/fast/parser/comment-in-textarea-expected.checksum:
        * platform/mac/fast/parser/comment-in-textarea-expected.png:
        * platform/mac/fast/parser/comment-in-textarea-expected.txt:
        * platform/mac/fast/parser/entity-comment-in-textarea-expected.checksum:
        * platform/mac/fast/parser/entity-comment-in-textarea-expected.png:
        * platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
        * platform/mac/fast/parser/open-comment-in-textarea-expected.checksum:
        * platform/mac/fast/parser/open-comment-in-textarea-expected.png:
        * platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
        * platform/mac/fast/replaced/selection-rect-transform-expected.png:
        * platform/mac/fast/replaced/width100percent-textarea-expected.checksum:
        * platform/mac/fast/replaced/width100percent-textarea-expected.png:
        * platform/mac/fast/replaced/width100percent-textarea-expected.txt:
        * platform/mac/fast/table/003-expected.checksum:
        * platform/mac/fast/table/003-expected.png:
        * platform/mac/fast/table/003-expected.txt:
        * platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.checksum:
        * platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.png:
        * platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
        * platform/mac/http/tests/navigation/anchor-basic-expected.txt:
        * platform/mac/http/tests/navigation/anchor-frames-expected.checksum:
        * platform/mac/http/tests/navigation/anchor-frames-expected.png:
        * platform/mac/http/tests/navigation/anchor-frames-expected.txt:
        * platform/mac/http/tests/navigation/anchor-goback-expected.checksum:
        * platform/mac/http/tests/navigation/anchor-goback-expected.png:
        * platform/mac/http/tests/navigation/anchor-goback-expected.txt:
        * platform/mac/http/tests/navigation/anchor-subframeload-expected.checksum:
        * platform/mac/http/tests/navigation/anchor-subframeload-expected.png:
        * platform/mac/http/tests/navigation/anchor-subframeload-expected.txt:
        * platform/mac/http/tests/navigation/javascriptlink-basic-expected.checksum:
        * platform/mac/http/tests/navigation/javascriptlink-basic-expected.png:
        * platform/mac/http/tests/navigation/javascriptlink-basic-expected.txt:
        * platform/mac/http/tests/navigation/javascriptlink-frames-expected.checksum:
        * platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
        * platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
        * platform/mac/http/tests/navigation/javascriptlink-goback-expected.checksum:
        * platform/mac/http/tests/navigation/javascriptlink-goback-expected.png:
        * platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt:
        * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.checksum:
        * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.png:
        * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.txt:
        * platform/mac/http/tests/navigation/metaredirect-basic-expected.checksum:
        * platform/mac/http/tests/navigation/metaredirect-basic-expected.png:
        * platform/mac/http/tests/navigation/metaredirect-basic-expected.txt:
        * platform/mac/http/tests/navigation/metaredirect-frames-expected.checksum:
        * platform/mac/http/tests/navigation/metaredirect-frames-expected.png:
        * platform/mac/http/tests/navigation/metaredirect-frames-expected.txt:
        * platform/mac/http/tests/navigation/metaredirect-goback-expected.checksum:
        * platform/mac/http/tests/navigation/metaredirect-goback-expected.png:
        * platform/mac/http/tests/navigation/metaredirect-goback-expected.txt:
        * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.checksum:
        * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.png:
        * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.txt:
        * platform/mac/http/tests/navigation/post-goback2-expected.checksum:
        * platform/mac/http/tests/navigation/post-goback2-expected.png:
        * platform/mac/http/tests/navigation/post-goback2-expected.txt:
        * platform/mac/http/tests/navigation/postredirect-goback2-expected.checksum:
        * platform/mac/http/tests/navigation/postredirect-goback2-expected.png:
        * platform/mac/http/tests/navigation/postredirect-goback2-expected.txt:
        * platform/mac/http/tests/navigation/redirect302-basic-expected.checksum:
        * platform/mac/http/tests/navigation/redirect302-basic-expected.png:
        * platform/mac/http/tests/navigation/redirect302-basic-expected.txt:
        * platform/mac/http/tests/navigation/redirect302-frames-expected.checksum:
        * platform/mac/http/tests/navigation/redirect302-frames-expected.png:
        * platform/mac/http/tests/navigation/redirect302-frames-expected.txt:
        * platform/mac/http/tests/navigation/redirect302-goback-expected.checksum:
        * platform/mac/http/tests/navigation/redirect302-goback-expected.png:
        * platform/mac/http/tests/navigation/redirect302-goback-expected.txt:
        * platform/mac/http/tests/navigation/redirect302-subframeload-expected.checksum:
        * platform/mac/http/tests/navigation/redirect302-subframeload-expected.png:
        * platform/mac/http/tests/navigation/redirect302-subframeload-expected.txt:
        * platform/mac/http/tests/navigation/relativeanchor-basic-expected.txt:
        * platform/mac/http/tests/navigation/relativeanchor-frames-expected.checksum:
        * platform/mac/http/tests/navigation/relativeanchor-frames-expected.png:
        * platform/mac/http/tests/navigation/relativeanchor-frames-expected.txt:
        * platform/mac/http/tests/navigation/relativeanchor-goback-expected.txt:
        * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.checksum:
        * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.png:
        * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.txt:
        * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.checksum:
        * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.png:
        * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.txt:
        * platform/mac/http/tests/navigation/success200-basic-expected.checksum:
        * platform/mac/http/tests/navigation/success200-basic-expected.png:
        * platform/mac/http/tests/navigation/success200-basic-expected.txt:
        * platform/mac/http/tests/navigation/success200-frames-expected.checksum:
        * platform/mac/http/tests/navigation/success200-frames-expected.png:
        * platform/mac/http/tests/navigation/success200-frames-expected.txt:
        * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.checksum:
        * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.png:
        * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt:
        * platform/mac/http/tests/navigation/success200-goback-expected.checksum:
        * platform/mac/http/tests/navigation/success200-goback-expected.png:
        * platform/mac/http/tests/navigation/success200-goback-expected.txt:
        * platform/mac/http/tests/navigation/success200-loadsame-expected.checksum:
        * platform/mac/http/tests/navigation/success200-loadsame-expected.png:
        * platform/mac/http/tests/navigation/success200-loadsame-expected.txt:
        * platform/mac/http/tests/navigation/success200-reload-expected.checksum:
        * platform/mac/http/tests/navigation/success200-reload-expected.png:
        * platform/mac/http/tests/navigation/success200-reload-expected.txt:
        * platform/mac/http/tests/navigation/success200-subframeload-expected.checksum:
        * platform/mac/http/tests/navigation/success200-subframeload-expected.png:
        * platform/mac/http/tests/navigation/success200-subframeload-expected.txt:
        * platform/mac/http/tests/navigation/timerredirect-basic-expected.checksum:
        * platform/mac/http/tests/navigation/timerredirect-basic-expected.png:
        * platform/mac/http/tests/navigation/timerredirect-basic-expected.txt:
        * platform/mac/http/tests/navigation/timerredirect-frames-expected.checksum:
        * platform/mac/http/tests/navigation/timerredirect-frames-expected.png:
        * platform/mac/http/tests/navigation/timerredirect-frames-expected.txt:
        * platform/mac/http/tests/navigation/timerredirect-goback-expected.checksum:
        * platform/mac/http/tests/navigation/timerredirect-goback-expected.png:
        * platform/mac/http/tests/navigation/timerredirect-goback-expected.txt:
        * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.checksum:
        * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.png:
        * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug194024-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug194024-expected.png:
        * platform/mac/tables/mozilla/bugs/bug194024-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug30559-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug30559-expected.png:
        * platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug30692-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fixes for Python extension and DRT.
kevino@webkit.org [Thu, 7 May 2009 19:09:58 +0000 (19:09 +0000)]
wx build fixes for Python extension and DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 7 May 2009 19:03:59 +0000 (19:03 +0000)]
2009-05-07  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler and Alexey Proskuryakov.

        <rdar://problem/6863795> Exception occurs in Mail when attempting to create signatures due to <head> element creation

        * dom/Document.cpp:
        (WebCore::Document::implicitClose): Check shouldCreateImplicitHead() before creating it.

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError): Check shouldCreateImplicitHead() before creating it.
        (WebCore::HTMLParser::bodyCreateErrorCheck): Ditto.
        (WebCore::shouldCreateImplicitHead): For Tiger/Leopard when running under Mail, the implicit <head> shouldn't be created.
        * html/HTMLParser.h:
        (WebCore::shouldCreateImplicitHead): Inline implementation for non-Tiger/Leopard platforms

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 7 May 2009 18:45:34 +0000 (18:45 +0000)]
2009-05-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Gavin Barraclough.

        Removed a few more special constants, and replaced them with uses of
        the JITStackFrame struct.

        Removed one of the two possible definitions of VoidPtrPair. The Mac
        definition was more elegant, but SunSpider doesn't think it's any
        faster, and it's net less elegant to have two ways of doing things.

        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        (JSC::JIT::privateCompile):
        * jit/JITStubs.h:
        (JSC::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Remove manifest fixup from r42729 to fix clean builds.
sfalken@apple.com [Thu, 7 May 2009 18:44:31 +0000 (18:44 +0000)]
    Remove manifest fixup from r42729 to fix clean builds.

        * DumpRenderTree/win/DumpRenderTree.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFixed Radar #
ggaren@apple.com [Thu, 7 May 2009 18:35:10 +0000 (18:35 +0000)]
Fixed Radar #

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 7 May 2009 17:48:06 +0000 (17:48 +0000)]
2009-05-07  Simon Fraser  <simon.fraser@apple.com>

        Source changes reviewed by Darin Adler

        <rdar://problem/6864091> Endcap of media controls slider is fuzzy

        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Antony Sargent <asargent@chromium.org>
darin@chromium.org [Thu, 7 May 2009 17:45:00 +0000 (17:45 +0000)]
2009-05-07  Antony Sargent  <asargent@chromium.org>

        Reviewed by Darin Fisher.

        Fix a memory leak in V8EventListenerList::remove.

        https://bugs.webkit.org/show_bug.cgi?id=25618

        No new functionality so no new tests.

        * bindings/v8/V8EventListenerList.cpp:
        (WebCore::V8EventListenerList::remove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 7 May 2009 16:41:35 +0000 (16:41 +0000)]
2009-05-07  Darin Adler  <darin@apple.com>

        * runtime/ScopeChain.h:
        (JSC::ScopeChainNode::~ScopeChainNode): Tweak formatting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 7 May 2009 16:17:25 +0000 (16:17 +0000)]
2009-05-07  Darin Fisher  <darin@chromium.org>

        Fix Chromium build bustage.

        * bindings/v8/custom/V8HTMLFormElementCustom.cpp: Add missing
        HTMLCollection.h include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 25598: AX: if a radio button has a label and a title, the label is not exposed
cfleizach@apple.com [Thu, 7 May 2009 16:01:03 +0000 (16:01 +0000)]
Bug 25598: AX: if a radio button has a label and a title, the label is not exposed
https://bugs.webkit.org/show_bug.cgi?id=25598

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 7 May 2009 15:57:50 +0000 (15:57 +0000)]
2009-05-07  Darin Fisher  <darin@chromium.org>

        Fix Chromium build bustage.

        * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
        (WebCore::INDEXED_PROPERTY_GETTER): ":" should be "::"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Thu, 7 May 2009 13:59:19 +0000 (13:59 +0000)]
2009-05-07  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Fix the build thread stack base determination build on Symbian,
        by moving the code block before PLATFORM(UNIX), which is also
        enabled on Symbian builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 7 May 2009 12:36:01 +0000 (12:36 +0000)]
2009-05-07  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=25610
        [GTK] text.caretOffset is reportedly always 0

        Use the right function to get the caret offset in an
        element. selectionStart() would only work for text
        controls (there's even an ASSERT when calculating the selected
        text range). Instead just get the selection and get the offset of
        the start position.

        * page/gtk/AccessibilityObjectWrapperAtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix crash due to incorrectly using an invalid scopechain
oliver@apple.com [Thu, 7 May 2009 10:05:07 +0000 (10:05 +0000)]
Fix crash due to incorrectly using an invalid scopechain

Reviewed by Gavin Barraclough.

stringProtoFuncReplace was checking for an exception on a CachedCall
by asking for the cached callframes exception.  Unfortunately this
could crash in certain circumstances as CachedCall does not guarantee
a valid callframe following a call.  Even more unfortunately the check
was entirely unnecessary as there is only a single exception slot per
global data, so it was already checked via the initial exec->hadException()
check.

To make bugs like this more obvious, i've added a debug only destructor
to ScopeChainNode that 0's all of its fields.  This exposed a crash in
the standard javascriptcore tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Thu, 7 May 2009 08:58:13 +0000 (08:58 +0000)]
2009-05-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix support for antialiased CSS border-radius

        WebKit implements border-radius by drawing a double-size border,
        and then letting the clip constrain the border to the right width
        and position. This requires support for antialiased clipping, as
        well as painting, to get a nice smooth border.

        Qt only does antialiased clipping if the anti-alias flag is set
        at the time of clipping, so we have to enable this in the method
        addInnerRoundedRectClip(), as well as when we draw the border.

        Currently the raster-engine is the only Qt paint engine to support
        anti-aliased clipping, but the OpenGL and Mac paint engines could
        potentially support this in the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 7 May 2009 08:27:58 +0000 (08:27 +0000)]
2009-05-07  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by NOBODY (OOPS!).

        Enable op_strcat across += assignments.  This patch allows the lhs of a read/modify node
        to be included within the concatenation operation, and also modifies the implementation
        of the concatenation to attempt to reuse and cat onto the leftmost string, rather than
        always allocating a new empty output string to copy into (as was previously the behaviour).

        ~0.5% progression, due to a 3%-3.5% progression on the string tests (particularly validate).

        * parser/Nodes.cpp:
        (JSC::BinaryOpNode::emitStrcat):
        (JSC::emitReadModifyAssignment):
        (JSC::ReadModifyResolveNode::emitBytecode):
        (JSC::ReadModifyDotNode::emitBytecode):
        (JSC::ReadModifyBracketNode::emitBytecode):
        * parser/Nodes.h:
        * runtime/Operations.h:
        (JSC::concatenateStrings):
        * runtime/UString.cpp:
        (JSC::UString::reserveCapacity):
        * runtime/UString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Thu, 7 May 2009 07:46:40 +0000 (07:46 +0000)]
2009-05-07  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Oliver Hunt.

        Fix the build on Windows without JIT: interpreter/RegisterFile.h needs
        roundUpAllocationSize, which is protected by #if ENABLED(ASSEMBLER).
        Moved the #ifdef down and always offer the function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-07 Adam Langley <agl@google.com>
eric@webkit.org [Thu, 7 May 2009 07:42:29 +0000 (07:42 +0000)]
2009-05-07  Adam Langley  <agl@google.com>

        Reviewed by Eric Seidel.

        Render empty optgroup elements.

        https://bugs.webkit.org/show_bug.cgi?id=24900

        Currently, optgroup elements which are empty are not rendered. The
        HTML specification gives no guidance on this situation.

        However, the test for being empty is that they have no children, thus
        this will not render:
          <optgroup label="test"></optgroup>
        while this /will/ render (because of the text node child):
          <optgroup label="test"> </optgroup>

        This patch will cause both cases to render which matches IE's and
        Firefox's behaviour.

        The difference only appears when opening the select element and does
        not appear in the render tree. Thus, a manual layout-test is required.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::recalcListItems):
        * manual-tests/optgroup-empty-and-nested.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Maciej Stachowiak.
eric@webkit.org [Thu, 7 May 2009 07:38:30 +0000 (07:38 +0000)]
    Reviewed by Maciej Stachowiak.

        Update Contributing instructions after feedback from Julie Parent.
        https://bugs.webkit.org/show_bug.cgi?id=25611

        * coding/contributing.html: Add a few more comments on ChangeLogs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Julie Parent <jparent@google.com>
eric@webkit.org [Thu, 7 May 2009 06:48:00 +0000 (06:48 +0000)]
2009-05-06  Julie Parent  <jparent@google.com>

        Reviewed by Eric Seidel.

        Bug 25608: Unused m_frame in ChromiumClipboard.
        https://bugs.webkit.org/show_bug.cgi?id=25608

        * platform/chromium/ClipboardChromium.h:

        No tests added as this is only removing dead code, no functional changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 7 May 2009 06:36:35 +0000 (06:36 +0000)]
2009-05-06  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Gavin "++" Barraclough.

        Added some abstraction around the JIT stub calling convention by creating
        a struct to represent the persistent stack frame JIT code shares with
        JIT stubs.

        SunSpider reports no change.

        * jit/JIT.h:
        * jit/JITStubs.cpp:
        (JSC::JITStubs::cti_op_convert_this):
        (JSC::JITStubs::cti_op_end):
        (JSC::JITStubs::cti_op_add):
        (JSC::JITStubs::cti_op_pre_inc):
        (JSC::JITStubs::cti_timeout_check):
        (JSC::JITStubs::cti_register_file_check):
        (JSC::JITStubs::cti_op_loop_if_less):
        (JSC::JITStubs::cti_op_loop_if_lesseq):
        (JSC::JITStubs::cti_op_new_object):
        (JSC::JITStubs::cti_op_put_by_id_generic):
        (JSC::JITStubs::cti_op_get_by_id_generic):
        (JSC::JITStubs::cti_op_put_by_id):
        (JSC::JITStubs::cti_op_put_by_id_second):
        (JSC::JITStubs::cti_op_put_by_id_fail):
        (JSC::JITStubs::cti_op_get_by_id):
        (JSC::JITStubs::cti_op_get_by_id_second):
        (JSC::JITStubs::cti_op_get_by_id_self_fail):
        (JSC::JITStubs::cti_op_get_by_id_proto_list):
        (JSC::JITStubs::cti_op_get_by_id_proto_list_full):
        (JSC::JITStubs::cti_op_get_by_id_proto_fail):
        (JSC::JITStubs::cti_op_get_by_id_array_fail):
        (JSC::JITStubs::cti_op_get_by_id_string_fail):
        (JSC::JITStubs::cti_op_instanceof):
        (JSC::JITStubs::cti_op_del_by_id):
        (JSC::JITStubs::cti_op_mul):
        (JSC::JITStubs::cti_op_new_func):
        (JSC::JITStubs::cti_op_call_JSFunction):
        (JSC::JITStubs::cti_op_call_arityCheck):
        (JSC::JITStubs::cti_vm_dontLazyLinkCall):
        (JSC::JITStubs::cti_vm_lazyLinkCall):
        (JSC::JITStubs::cti_op_push_activation):
        (JSC::JITStubs::cti_op_call_NotJSFunction):
        (JSC::JITStubs::cti_op_create_arguments):
        (JSC::JITStubs::cti_op_create_arguments_no_params):
        (JSC::JITStubs::cti_op_tear_off_activation):
        (JSC::JITStubs::cti_op_tear_off_arguments):
        (JSC::JITStubs::cti_op_profile_will_call):
        (JSC::JITStubs::cti_op_profile_did_call):
        (JSC::JITStubs::cti_op_ret_scopeChain):
        (JSC::JITStubs::cti_op_new_array):
        (JSC::JITStubs::cti_op_resolve):
        (JSC::JITStubs::cti_op_construct_JSConstruct):
        (JSC::JITStubs::cti_op_construct_NotJSConstruct):
        (JSC::JITStubs::cti_op_get_by_val):
        (JSC::JITStubs::cti_op_get_by_val_string):
        (JSC::JITStubs::cti_op_get_by_val_byte_array):
        (JSC::JITStubs::cti_op_resolve_func):
        (JSC::JITStubs::cti_op_sub):
        (JSC::JITStubs::cti_op_put_by_val):
        (JSC::JITStubs::cti_op_put_by_val_array):
        (JSC::JITStubs::cti_op_put_by_val_byte_array):
        (JSC::JITStubs::cti_op_lesseq):
        (JSC::JITStubs::cti_op_loop_if_true):
        (JSC::JITStubs::cti_op_load_varargs):
        (JSC::JITStubs::cti_op_negate):
        (JSC::JITStubs::cti_op_resolve_base):
        (JSC::JITStubs::cti_op_resolve_skip):
        (JSC::JITStubs::cti_op_resolve_global):
        (JSC::JITStubs::cti_op_div):
        (JSC::JITStubs::cti_op_pre_dec):
        (JSC::JITStubs::cti_op_jless):
        (JSC::JITStubs::cti_op_not):
        (JSC::JITStubs::cti_op_jtrue):
        (JSC::JITStubs::cti_op_post_inc):
        (JSC::JITStubs::cti_op_eq):
        (JSC::JITStubs::cti_op_lshift):
        (JSC::JITStubs::cti_op_bitand):
        (JSC::JITStubs::cti_op_rshift):
        (JSC::JITStubs::cti_op_bitnot):
        (JSC::JITStubs::cti_op_resolve_with_base):
        (JSC::JITStubs::cti_op_new_func_exp):
        (JSC::JITStubs::cti_op_mod):
        (JSC::JITStubs::cti_op_less):
        (JSC::JITStubs::cti_op_neq):
        (JSC::JITStubs::cti_op_post_dec):
        (JSC::JITStubs::cti_op_urshift):
        (JSC::JITStubs::cti_op_bitxor):
        (JSC::JITStubs::cti_op_new_regexp):
        (JSC::JITStubs::cti_op_bitor):
        (JSC::JITStubs::cti_op_call_eval):
        (JSC::JITStubs::cti_op_throw):
        (JSC::JITStubs::cti_op_get_pnames):
        (JSC::JITStubs::cti_op_next_pname):
        (JSC::JITStubs::cti_op_push_scope):
        (JSC::JITStubs::cti_op_pop_scope):
        (JSC::JITStubs::cti_op_typeof):
        (JSC::JITStubs::cti_op_is_undefined):
        (JSC::JITStubs::cti_op_is_boolean):
        (JSC::JITStubs::cti_op_is_number):
        (JSC::JITStubs::cti_op_is_string):
        (JSC::JITStubs::cti_op_is_object):
        (JSC::JITStubs::cti_op_is_function):
        (JSC::JITStubs::cti_op_stricteq):
        (JSC::JITStubs::cti_op_to_primitive):
        (JSC::JITStubs::cti_op_strcat):
        (JSC::JITStubs::cti_op_nstricteq):
        (JSC::JITStubs::cti_op_to_jsnumber):
        (JSC::JITStubs::cti_op_in):
        (JSC::JITStubs::cti_op_push_new_scope):
        (JSC::JITStubs::cti_op_jmp_scopes):
        (JSC::JITStubs::cti_op_put_by_index):
        (JSC::JITStubs::cti_op_switch_imm):
        (JSC::JITStubs::cti_op_switch_char):
        (JSC::JITStubs::cti_op_switch_string):
        (JSC::JITStubs::cti_op_del_by_val):
        (JSC::JITStubs::cti_op_put_getter):
        (JSC::JITStubs::cti_op_put_setter):
        (JSC::JITStubs::cti_op_new_error):
        (JSC::JITStubs::cti_op_debug):
        (JSC::JITStubs::cti_vm_throw):
        * jit/JITStubs.h:
        (JSC::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Thu, 7 May 2009 03:38:25 +0000 (03:38 +0000)]
WebCore:

        Reviewed by Simon Fraser and Justin Garcia.

        - fix another part of <rdar://problem/6703873> Triple-click quoted line
          and type Return creates an extra quoted blank line

        Test: editing/inserting/6703873-2.html

        * editing/BreakBlockquoteCommand.cpp:
        (WebCore::BreakBlockquoteCommand::doApply): Corrected the logic for
        determining the first node that should go into the new blockquote
        given the split position: if it is at the end of a container, use the
        next node after the container. Otherwise, use the child at the
        position's offset.

LayoutTests:

        Reviewed by Simon Fraser and Justin Garcia.

        - test for another part of <rdar://problem/6703873> Triple-click quoted
          line and type Return creates an extra quoted blank line

        * editing/inserting/6703873-2-expected.txt: Added.
        * editing/inserting/6703873-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 7 May 2009 01:23:17 +0000 (01:23 +0000)]
2009-05-06  Simon Fraser  <simon.fraser@apple.com>

        Rubber-stampted by Eric Seidel

        Add braces to clarify logic flow in RenderObject::adjustStyleDifference.
        Only affects ACCELERATED_COMPOSITING builds.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::adjustStyleDifference):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 7 May 2009 00:06:07 +0000 (00:06 +0000)]
2009-05-06  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Maciej Stachowiak & Darin Adler.

        Improve string concatenation (as coded in JS as a sequence of adds).

        Detect patterns corresponding to string concatenation, and change the bytecode
        generation to emit a new op_strcat instruction.  By handling the full set of
        additions within a single function we do not need allocate JSString wrappers
        for intermediate results, and we can calculate the size of the output string
        prior to allocating storage, in order to prevent reallocation of the buffer.

        1.5%-2% progression on Sunspider, largely due to a 30% progression on date-format-xparb.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
            Add new opcodes.
        * bytecode/Opcode.h:
            Add new opcodes.
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitStrcat):
        (JSC::BytecodeGenerator::emitToPrimitive):
            Add generation of new opcodes.
        * bytecompiler/BytecodeGenerator.h:
            Add generation of new opcodes.
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):
            Add implmentation of new opcodes.
        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        (JSC::JIT::privateCompileSlowCases):
            Add implmentation of new opcodes.
        * jit/JITStubs.cpp:
        (JSC::JITStubs::cti_op_to_primitive):
        (JSC::JITStubs::cti_op_strcat):
            Add implmentation of new opcodes.
        * jit/JITStubs.h:
            Add implmentation of new opcodes.
        * parser/Nodes.cpp:
        (JSC::BinaryOpNode::emitStrcat):
        (JSC::BinaryOpNode::emitBytecode):
        (JSC::ReadModifyResolveNode::emitBytecode):
            Add generation of new opcodes.
        * parser/Nodes.h:
        (JSC::ExpressionNode::):
        (JSC::AddNode::):
            Add methods to allow identification of add nodes.
        * parser/ResultType.h:
        (JSC::ResultType::definitelyIsString):
        (JSC::ResultType::forAdd):
            Fix error in detection of adds that will produce string results.
        * runtime/Operations.h:
        (JSC::concatenateStrings):
            Add implmentation of new opcodes.
        * runtime/UString.cpp:
        (JSC::UString::appendNumeric):
            Add methods to append numbers to an existing string.
        * runtime/UString.h:
        (JSC::UString::Rep::createEmptyBuffer):
        (JSC::UString::BaseString::BaseString):
            Add support for creating an empty string with a non-zero capacity available in the BaseString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix, fixes for wx trunk builds.
kevino@webkit.org [Wed, 6 May 2009 23:56:18 +0000 (23:56 +0000)]
wx build fix, fixes for wx trunk builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Albert J. Wong <ajwong@chromium.org>
levin@chromium.org [Wed, 6 May 2009 22:55:24 +0000 (22:55 +0000)]
2009-05-06  Albert J. Wong  <ajwong@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=25597
        Fix API drift compile errors that occurred while this was ifdef-ed out.
        The two big issues were that RenderObject::element() became
        RenderObject::node() and some of the wk* drawing functions had
        an extra theme parameter added to the argument list.

        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton):
        (WebCore::RenderThemeChromiumMac::paintMediaMuteButton):
        (WebCore::RenderThemeChromiumMac::paintMediaPlayButton):
        (WebCore::RenderThemeChromiumMac::paintMediaSeekBackButton):
        (WebCore::RenderThemeChromiumMac::paintMediaSeekForwardButton):
        (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
        (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Jian Li <jianli@chromium.org>
levin@chromium.org [Wed, 6 May 2009 22:00:19 +0000 (22:00 +0000)]
2009-05-06  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25385
        Upstream changes to V8 bindings for supporting nested workers.

        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::ToV8Object):
        (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object):
        * bindings/v8/custom/V8WorkerCustom.cpp:
        (WebCore::getEventListener):
        (WebCore::ACCESSOR_SETTER WorkerOnmessage):
        (WebCore::CALLBACK_FUNC_DECL WorkerAddEventListener):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Dave Moore <davemoore@google.com>
levin@chromium.org [Wed, 6 May 2009 22:00:13 +0000 (22:00 +0000)]
2009-05-06  Dave Moore  <davemoore@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25513
        The V8 bindings convert every javascript property to its associated css style
        name. It then calls functions that convert that name to an id. This makes
        getting or setting css styles on elements slow.

        The patch fixes this by caching the results of the transformation, mapping a
        javascript property name to its css property id. It then calls the already
        public webkit methods that take the id in place of the string property names.

        * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Nate Chapin <japhet@google.com>
levin@chromium.org [Wed, 6 May 2009 22:00:06 +0000 (22:00 +0000)]
2009-05-06  Nate Chapin  <japhet@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25591
        Upstream V8HTMLFormElement from the Chromium repository.

        * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
        (WebCore::INDEXED_PROPERTY_GETTER HTMLFormElement): Upstreamed from Chromium repository
        (WebCore::NAMED_PROPERTY_GETTER HTMLFormElement): Changed empty element return case to return notHandledByInterceptor();
        (WebCore::CALLBACK_FUNC_DECL HTMLFormElementSubmit): Upstreamed from Chromium repository

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Albert J. Wong <ajwong@chromium.org>
levin@chromium.org [Wed, 6 May 2009 21:59:58 +0000 (21:59 +0000)]
2009-05-06  Albert J. Wong  <ajwong@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25595
        Upstream V8CanvasPixelArrayCustom from chromium port tree.

        * bindings/v8/V8CanvasPixelArrayCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 6 May 2009 21:31:50 +0000 (21:31 +0000)]
2009-05-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        <rdar://problem/6862550> Reduce size of RenderText in 64-bit

        Rearrange data members of RenderText so that an int comes
        first, to minimize padding.

        * rendering/RenderText.cpp:
        (WebCore::RenderText::RenderText):
        * rendering/RenderText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 6 May 2009 21:21:04 +0000 (21:21 +0000)]
2009-05-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        <rdar://problem/6862823> Reduce size of RenderStyle in 64-bit

        Rearrange data members of RenderStyle to minimize padding
        when building for 64-bit.

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::RenderStyle):
        * rendering/style/RenderStyle.h:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 6 May 2009 21:07:11 +0000 (21:07 +0000)]
2009-05-06  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25596

        Fixes Chromium build bustage caused by r43317 (making
        RefCountedBase::m_refCount private)

        * page/chromium/AccessibilityObjectWrapper.h:
        (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Hin-Chung Lam <hclam@chromium.org>
darin@chromium.org [Wed, 6 May 2009 19:57:47 +0000 (19:57 +0000)]
2009-05-06  Hin-Chung Lam  <hclam@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=25593

        Refactor for MediaPlayerPrivate for Chromium port. Remove
        the implementation of MediaPlayerPrivateInferface from it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Daniel Nylander <po@danielnylander.se>
kov@webkit.org [Wed, 6 May 2009 19:46:46 +0000 (19:46 +0000)]
2009-05-06  Daniel Nylander  <po@danielnylander.se>

        Rubber-stamped by Gustavo Noronha.

        Swedish translation for WebKitGTK+.

        * sv.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 6 May 2009 19:38:53 +0000 (19:38 +0000)]
2009-05-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=24786
        WebKitDownload sometimes suggests peculiar filenames

        When a download is requested by an ongoing request, use the already
        provided response to set the suggested filename for the WebKitDownload
        object, if available.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::download):
        * webkit/webkitdownload.cpp:
        (_WebKitDownloadPrivate::webkit_download_set_property):
        (_WebKitDownloadPrivate::webkit_download_get_suggested_filename):
        (_WebKitDownloadPrivate::webkit_download_set_suggested_filename):
        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/win:
sfalken@apple.com [Wed, 6 May 2009 19:23:59 +0000 (19:23 +0000)]
WebKit/win:

2009-05-06  Steve Falkenburg  <sfalken@apple.com>

        Change default value of WebKitPaintNativeControls to true.

        Reviewed by Adam Roben.

        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):

WebKitTools:

2009-05-06  Steve Falkenburg  <sfalken@apple.com>

        Explicitly set WebKitPaintNativeControls to false to allow Windows results to match Mac.

        Reviewed by Adam Roben.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 6 May 2009 19:15:04 +0000 (19:15 +0000)]
2009-05-06  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Made RefCounted::m_refCount private.

        * runtime/Structure.h: Removed addressOfCount.
        * wtf/RefCounted.h: Made m_refCount private.
        Added addressOfCount.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 6 May 2009 18:57:30 +0000 (18:57 +0000)]
2009-05-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt, Dan Bernstein

        <rdar://problem/6860197> Reduce the size of FontFallbackList in 64-bit

        Re-order the data members of FontFallbackList to save 8 bytes when building 64-bit.

        * platform/graphics/FontFallbackList.cpp:
        (WebCore::FontFallbackList::FontFallbackList):
        * platform/graphics/FontFallbackList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 6 May 2009 18:47:47 +0000 (18:47 +0000)]
2009-05-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler, Dan Bernstein

        <rdar://problem/6860068> Reduce size of InlineBox in 64-bit

        Re-order the data members of InlineBox to save 8 bytes when building 64-bit.

        * rendering/InlineBox.h:
        (WebCore::InlineBox::InlineBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 6 May 2009 18:28:49 +0000 (18:28 +0000)]
2009-05-06  David Levin  <levin@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25588
        Adding the custom v8 bindings Document.location.

        * bindings/v8/custom/V8DocumentLocationCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 6 May 2009 18:17:48 +0000 (18:17 +0000)]
2009-05-06  Darin Adler  <darin@apple.com>

        Fixed assertion seen a lot!

        * parser/Nodes.cpp:
        (JSC::FunctionBodyNode::~FunctionBodyNode): Removed now-bogus assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 6 May 2009 17:50:04 +0000 (17:50 +0000)]
2009-05-06  Kevin McCullough  <kmccullough@apple.com>

        -Clarified a comment

        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 6 May 2009 17:10:22 +0000 (17:10 +0000)]
2009-05-06  Darin Adler  <darin@apple.com>

        Working with Sam Weinig.

        Redo parse tree constructor optimization without breaking the Windows
        build the way I did yesterday. The previous try broke the build by adding
        an include of Lexer.h and all its dependencies that had to work outside
        the JavaScriptCore project.

        * GNUmakefile.am: Added NodeConstructors.h.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
        Removed byteocde directory -- we no longer are trying to include Lexer.h
        outside JavaScriptCore.

        * JavaScriptCore.xcodeproj/project.pbxproj: Change SegmentedVector.h
        and Lexer.h back to internal files. Added NodeConstructors.h.

        * parser/Grammar.y: Added include of NodeConstructors.h.
        Changed use of ConstDeclNode to use public functions.

        * parser/NodeConstructors.h: Copied from parser/Nodes.h.
        Just contains the inlined constructors now.

        * parser/Nodes.cpp: Added include of NodeConstructors.h.
        Moved node constructors into the header.
        (JSC::FunctionBodyNode::FunctionBodyNode): Removed m_refCount
        initialization.

        * parser/Nodes.h: Removed all the constructor definitions, and also
        removed the JSC_FAST_CALL from them since these are all inlined, so the
        calling convention is irrelevant. Made more things private. Used a data
        member for operator opcodes instead of a virtual function. Removed the
        special FunctionBodyNode::ref/deref functions since the default functions
        are now just as fast.

        * runtime/FunctionConstructor.cpp:
        (JSC::extractFunctionBody): Fixed types here so we don't typecast until
        after we do type checking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Fix WML enabled builds by including "MappedAttribute.h" in several...
zimmermann@webkit.org [Wed, 6 May 2009 15:44:32 +0000 (15:44 +0000)]
Not reviewed. Fix WML enabled builds by including "MappedAttribute.h" in several places.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 6 May 2009 15:24:21 +0000 (15:24 +0000)]
2009-05-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Disable more new tests.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 6 May 2009 14:25:08 +0000 (14:25 +0000)]
2009-05-06  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=25526
        [Gtk] Additional support is needed for caret browsing

        Emit AtkText::text-selection-changed when the selection changes
        and the current selection is of Range (ie, the start and end
        positions are different) type. This seems to match what Gecko
        does.

        * editing/gtk/SelectionControllerGtk.cpp:
        (WebCore::SelectionController::notifyAccessibilityForSelectionChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 6 May 2009 14:24:53 +0000 (14:24 +0000)]
2009-05-05  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=25526
        [Gtk] Additional support is needed for caret browsing

        Emit AtkText::text-caret-moved when selection changes.

        * GNUmakefile.am:
        * editing/SelectionController.h:
        * editing/gtk/SelectionController.cpp: Added.
        (WebCore::SelectionController::notifyAccessibilityForSelectionChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Wed, 6 May 2009 14:04:18 +0000 (14:04 +0000)]
2009-05-06  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Gustavo Noronha.

        Use mozilla cursors for the previously not implemented
        cursors. The manual-tests/cursor.html is looking complete
        now.

        * platform/gtk/CursorGtk.cpp:
        (WebCore::cellCursor):
        (WebCore::noDropCursor):
        (WebCore::progressCursor):
        (WebCore::noneCursor):
        (WebCore::notAllowedCursor):
        (WebCore::grabCursor):
        (WebCore::grabbingCursor):
        * platform/gtk/CursorGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Wed, 6 May 2009 14:03:54 +0000 (14:03 +0000)]
2009-05-06  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Xan Lopez.

        Properly indent the header file.

        * platform/gtk/CursorGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Wed, 6 May 2009 14:03:33 +0000 (14:03 +0000)]
2009-05-06  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Gustavo Noronha.

        Use the mozilla copyright header. Use MPL1.1/GPL2.0
        and LGPL2.1 as the license compared to LGPL2.0.

        * platform/gtk/CursorGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Wed, 6 May 2009 14:03:10 +0000 (14:03 +0000)]
2009-05-06  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Gustavo Noronha.

        Move PluginView::invalidateRegion from the
        TemporaryLinkStubs to PluginViewGtk.cpp and implement
        it with a call to Widget::invalidate() just like
        mac is doing. Optimisations would have to be window
        system specific.

        * platform/gtk/TemporaryLinkStubs.cpp:
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::invalidateRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 6 May 2009 13:56:19 +0000 (13:56 +0000)]
2009-05-06  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        GTK+ API implementation files have bogus extern "C" entries
        https://bugs.webkit.org/show_bug.cgi?id=24322

        Remove bogus extern "C" from the source files.

        * webkit/webkitdownload.cpp:
        (DownloadClient::cannotShowURL):
        * webkit/webkiterror.cpp:
        (webkit_plugin_error_quark):
        * webkit/webkitnetworkrequest.cpp:
        (webkit_network_request_get_uri):
        * webkit/webkitprivate.cpp:
        (webkit_init):
        * webkit/webkitversion.cpp:
        (webkit_micro_version):
        * webkit/webkitwebbackforwardlist.cpp:
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_get_load_status):
        * webkit/webkitwebhistoryitem.cpp:
        * webkit/webkitwebinspector.cpp:
        (webkit_web_inspector_set_inspector_client):
        * webkit/webkitwebnavigationaction.cpp:
        (webkit_web_navigation_action_get_modifier_state):
        * webkit/webkitwebpolicydecision.cpp:
        (webkit_web_policy_decision_cancel):
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_get_spell_languages):
        * webkit/webkitwebview.cpp:
        * webkit/webkitwebwindowfeatures.cpp:
        (webkit_web_window_features_equal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 May 2009 13:24:54 +0000 (13:24 +0000)]
2009-05-06  Eric Seidel  <eric@webkit.org>

        No review, just fixing my previous broken commit.

        Commit correct results for event-function-toString.html

        * fast/events/event-function-toString-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 6 May 2009 13:20:52 +0000 (13:20 +0000)]
2009-05-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Fixing typo in my last commit.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 6 May 2009 13:12:26 +0000 (13:12 +0000)]
2009-05-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Disabling failing new tests that do not represent regressions.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Wed, 6 May 2009 13:12:04 +0000 (13:12 +0000)]
2009-05-06  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        Fix the Qt build on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Wed, 6 May 2009 13:11:54 +0000 (13:11 +0000)]
2009-05-06  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        Fix the Qt build on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Wed, 6 May 2009 13:11:47 +0000 (13:11 +0000)]
2009-05-06  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        Enable the JIT for the Qt build on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 6 May 2009 12:24:52 +0000 (12:24 +0000)]
2009-05-06  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        Misc fixes to InspectorClientGtk.

        * GNUmakefile.am: Add localizedStrings.js to webinspector_DATA.
        This prevents copious amounts "Localized string not found" errors
        in the console

2009-05-06  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        Misc fixes to InspectorClientGtk.

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::createPage): use g_filename_to_uri to
        get the URI and use web_view_load_uri instead of the deprecated
        web_view_open method for loading the URI.
        (WebKit::InspectorClient::localizedStringsURL): implement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
hausmann@webkit.org [Wed, 6 May 2009 10:26:22 +0000 (10:26 +0000)]
2009-05-05  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Simon Hausmann.

        Improve behaviour of the QWebElement enclose* functions, to work
        similar to the jQuery wrap functions. We now enclose the contents
        of the element in the child of the deepest descendant element
        within the structure of the enclose element structure given.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
hausmann@webkit.org [Wed, 6 May 2009 10:23:12 +0000 (10:23 +0000)]
2009-05-06  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Simon Hausmann.

        After commit rev @43215, setHtml() without a <head> tag,
        automatically adds it, so update our test case to respect this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
hausmann@webkit.org [Wed, 6 May 2009 09:34:49 +0000 (09:34 +0000)]
JavaScriptCore:
    2009-05-06  Simon Hausmann  <simon.hausmann@nokia.com>

            Reviewed by Tor Arne Vestbø.

            Tweak JavaScriptCore.pri for being able to override the generated sources dir for the
            generated_files target.

WebCore:
    2009-05-06  Simon Hausmann  <simon.hausmann@nokia.com>

            Reviewed by Tor Arne Vestbø.

            Tweak WebCore.pro for being able to override the generated sources dir for the
            generated_files target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Wed, 6 May 2009 09:12:21 +0000 (09:12 +0000)]
2009-05-06  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Holger Freyther.

        Fix the Qt/Windows build, use iface instead of interface to avoid conflict
        with VS2005 headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Joerg Bornemann <joerg.bornemann@trolltech.com>
hausmann@webkit.org [Wed, 6 May 2009 08:53:27 +0000 (08:53 +0000)]
2009-05-06  Joerg Bornemann  <joerg.bornemann@trolltech.com>

        Reviewed by Simon Hausmann.

        We need to include StringExtras.h on Windows CE to access the strdup function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Soren Gjesse <sgjesse@chromium.org>
eric@webkit.org [Wed, 6 May 2009 08:25:21 +0000 (08:25 +0000)]
2009-05-06  Soren Gjesse  <sgjesse@chromium.org>

        Reviewed by Eric Seidel.

        Changed the toString behaviour for non document dom node event handlers in the V8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=25544

        In the V8 bindings non document dom node event handlers are wrapped in a number of with blocks and uses an inner
        function. This causes the default toString on such a handler to return all this wrapper code. As some web sites
        use the source of an event handler to create new functions this wrapper code causes compatibility problems.

        Create a specific toString function for these handlers which will return a function source compatible with the
        source returned by the JSC bindings and other browsers.

        Test: fast/events/event-function-toString.html

        * bindings/v8/ScriptEventListener.cpp:
        (WebCore::createAttributeEventListener):
        * bindings/v8/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListener::V8LazyEventListener):
        (WebCore::V8LazyEventListener::getListenerFunction):
        (WebCore::V8LazyEventListenerToString):
        (WebCore::V8LazyEventListener::getWrappedListenerFunction):
        * bindings/v8/V8LazyEventListener.h:
        (WebCore::V8LazyEventListener::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild QtWebKit as a framework on Mac
vestbo@webkit.org [Wed, 6 May 2009 08:20:38 +0000 (08:20 +0000)]
Build QtWebKit as a framework on Mac

This implies both debug and release build by default, unless
one of the --debug or --release config options are passed to
the build-webkit script.

Frameworks can be disabled by passing CONFIG+=webkit_no_framework
to the build-webkit script.

To be able to build both debug and release targets in parallel
we have to use separate output directories for the generated
sources, which is not optimal, but required to avoid race conditions.

An optimization would be to only require this spit-up on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Use $$GENERATED_SOURCES_DIR as output when running bison
vestbo@webkit.org [Wed, 6 May 2009 08:20:19 +0000 (08:20 +0000)]
[Qt] Use $$GENERATED_SOURCES_DIR as output when running bison

A couple of the generators left the bison output file in the source
tree, and then moved it into $$GENERATED_SOURCES_DIR, which did not
work well when building release and debug configurations in parallel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Wed, 6 May 2009 08:02:27 +0000 (08:02 +0000)]
WebCore:

        Reviewed by Justin Garcia.

        - fix an assertion failure in RemoveNodeCommand() when deleting a <br>
          between a block and a mail blockquote

        Test: editing/deleting/removeNodeCommand-assert.html

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::mergeParagraphs): Pass the start block
        to prune() instead of passing m_upstreamStart.node(), because the latter
        may have been removed already.

LayoutTests:

        Reviewed by Justin Garcia.

        - test for an assertion failure in RemoveNodeCommand() when deleting a
          <br> between a block and a mail blockquote

        * editing/deleting/removeNodeCommand-assert-expected.txt: Added.
        * editing/deleting/removeNodeCommand-assert.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Wed, 6 May 2009 07:27:20 +0000 (07:27 +0000)]
2009-05-06  Simon Hausmann  <simon.hausmann@nokia.com>

        Unreviewed Qt build fix.

        Dont' use ENABLE() in Qt API headers, as they are not available when building
        against the API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 May 2009 06:40:24 +0000 (06:40 +0000)]
2009-05-05  Eric Seidel  <eric@webkit.org>

        No review, roll out only.

        Roll out r23072 since it broke layout tests

        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Ben Murdoch <benm@google.com>
eric@webkit.org [Wed, 6 May 2009 06:00:12 +0000 (06:00 +0000)]
2009-05-05  Ben Murdoch  <benm@google.com>

        Reviewed by Eric Seidel.

        Add #if ENABLE(DATABASE) guards around database code so toggling ENABLE_DATABASE off does not break builds.
        https://bugs.webkit.org/show_bug.cgi?id=24776

        No functional changes, thus no tests.

        * bindings/js/JSCustomSQLStatementCallback.cpp:
        * bindings/js/JSCustomSQLStatementCallback.h:
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
        * bindings/js/JSCustomSQLStatementErrorCallback.h:
        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        * bindings/js/JSCustomSQLTransactionCallback.h:
        * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
        * bindings/js/JSCustomSQLTransactionErrorCallback.h:
        * bindings/js/JSDatabaseCustom.cpp:
        * bindings/js/JSSQLTransactionCustom.cpp:
        * loader/EmptyClients.h:
        * page/ChromeClient.h:
        * storage/ChangeVersionWrapper.cpp:
        * storage/ChangeVersionWrapper.h:
        * storage/Database.cpp:
        (WebCore::Database::databaseInfoTableName):
        * storage/Database.h:
        * storage/Database.idl:
        * storage/DatabaseTask.cpp:
        * storage/DatabaseTask.h:
        * storage/DatabaseThread.cpp:
        * storage/DatabaseThread.h:
        * storage/DatabaseTracker.cpp:
        * storage/DatabaseTracker.h:
        * storage/DatabaseTrackerClient.h:
        * storage/OriginQuotaManager.cpp:
        * storage/OriginQuotaManager.h:
        * storage/SQLStatement.cpp:
        * storage/SQLStatement.h:
        * storage/SQLTransaction.cpp:
        * storage/SQLTransaction.h:
        * storage/SQLTransaction.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Jeremy Moskovich <jeremy@chromium.org>
eric@webkit.org [Wed, 6 May 2009 05:49:35 +0000 (05:49 +0000)]
2009-05-05  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Eric Seidel.

        Add some documentation to InlineBox::x(),y().
        https://bugs.webkit.org/show_bug.cgi?id=25378

        * rendering/InlineBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43282 268f45cc-cd09-0410-ab3c-d52691b4dbfc