WebKit-https.git
8 years agoUnreviewed, GTK rebaseline after r106445
philn@webkit.org [Wed, 1 Feb 2012 10:25:36 +0000 (10:25 +0000)]
Unreviewed, GTK rebaseline after r106445

* platform/gtk/security/block-test-expected.txt:
* platform/gtk/security/block-test-no-port-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Unreviewed gardening after r106426.
ossy@webkit.org [Wed, 1 Feb 2012 10:20:12 +0000 (10:20 +0000)]
[WK2] Unreviewed gardening after r106426.
Skip new failing tests because of missing layoutTestController.dumpResourceResponseMIMETypes().
https://bugs.webkit.org/show_bug.cgi?id=42543

* platform/qt-wk2/Skipped: Remove a test also skipped in wk2/Skipped.
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, another GTK build fix after r106446.
philn@webkit.org [Wed, 1 Feb 2012 10:08:19 +0000 (10:08 +0000)]
Unreviewed, another GTK build fix after r106446.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
Restore webKitWebSrcGetProtocols as it was before r106446.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectaion change.
yuzo@google.com [Wed, 1 Feb 2012 10:05:25 +0000 (10:05 +0000)]
[Chromium] Unreviewed test expectaion change.
plugins/createScriptableObject-before-start.html is flaky on LINUX.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement Error.stack
ossy@webkit.org [Wed, 1 Feb 2012 10:00:36 +0000 (10:00 +0000)]
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994

Unreviewed, rolling out r106407.

Source/JavaScriptCore:

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
* interpreter/Interpreter.h:
(JSC):
(Interpreter):
* jsc.cpp:
(GlobalObject::finishCreation):
* parser/Parser.h:
(JSC::::parse):
* runtime/CommonIdentifiers.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/Error.h:
(JSC):

LayoutTests:

* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:
* fast/js/script-tests/stack-trace.js: Removed.
* fast/js/stack-trace-expected.txt: Removed.
* fast/js/stack-trace.html: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectaion change.
yuzo@google.com [Wed, 1 Feb 2012 09:54:17 +0000 (09:54 +0000)]
[Chromium] Unreviewed test expectaion change.
media/controls-drag-timebar.html passes or times out on WIN and LINUX.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK build fix after r106446.
philn@webkit.org [Wed, 1 Feb 2012 09:50:35 +0000 (09:50 +0000)]
Unreviewed, GTK build fix after r106446.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r106432.
commit-queue@webkit.org [Wed, 1 Feb 2012 09:49:34 +0000 (09:49 +0000)]
Unreviewed, rolling out r106432.
http://trac.webkit.org/changeset/106432
https://bugs.webkit.org/show_bug.cgi?id=77529

it breaks tests (Requested by shinyak on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-01

Source/WebCore:

* dom/Element.cpp:
(WebCore::Element::attach):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::recalcShadowTreeStyle):
* dom/ShadowRoot.h:
(ShadowRoot):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):

LayoutTests:

* fast/dom/shadow/content-element-move-expected.txt: Removed.
* fast/dom/shadow/content-element-move.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix after r106386. The empty anchor element was generating an erroneous whitespace.
rniwa@webkit.org [Wed, 1 Feb 2012 09:47:41 +0000 (09:47 +0000)]
Fix after r106386. The empty anchor element was generating an erroneous whitespace.

* Bindings/event-target-wrapper.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unnecessary [OldStyleObjC] from ShadowRoot.idl.
hayato@chromium.org [Wed, 1 Feb 2012 09:44:03 +0000 (09:44 +0000)]
Remove unnecessary [OldStyleObjC] from ShadowRoot.idl.
https://bugs.webkit.org/show_bug.cgi?id=77516

Reviewed by Kentaro Hara.

No new tests. No change in behavior.

* dom/ShadowRoot.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAnother fix after r106379.
rniwa@webkit.org [Wed, 1 Feb 2012 09:39:13 +0000 (09:39 +0000)]
Another fix after r106379.

* Parser/html5-full-render.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectaion change.
yuzo@google.com [Wed, 1 Feb 2012 09:38:24 +0000 (09:38 +0000)]
[Chromium] Unreviewed test expectaion change.
svg/text/text-align-04-b.svg is flaky on WIN and LINUX.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] 0.11 webkitwebsrc
philn@webkit.org [Wed, 1 Feb 2012 09:36:47 +0000 (09:36 +0000)]
[GStreamer] 0.11 webkitwebsrc
https://bugs.webkit.org/show_bug.cgi?id=77086

Port the webkitwebsrc element to GStreamer 0.11 APIs.

Reviewed by Gustavo Noronha Silva.

No new tests, existing http media layout tests should cover this.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit/gtk: Patch by Philippe Normand <pnormand@igalia.com> and Sergio Villar...
philn@webkit.org [Wed, 1 Feb 2012 09:29:03 +0000 (09:29 +0000)]
Source/WebKit/gtk: Patch by Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin <svillar@igalia.com> on 2012-02-01
Reviewed by Martin Robinson.

[GTK] Improve FrameLoader signals. Resource loading
https://bugs.webkit.org/show_bug.cgi?id=49543

New signals:
WebKitWebFrame::resource-request-starting
WebKitWebFrame::resource-response-received
WebKitWebFrame::resource-load-finished
WebKitWebFrame::resource-content-length-received
WebKitWebFrame::resource-load-failed
WebKitWebResource::response-received
WebKitWebResource::load-failed
WebKitWebResource::load-finished
WebKitWebResource::content-length-received
WebKitWebView::resource-response-received
WebKitWebView::resource-load-finished
WebKitWebView::resource-content-length-received
WebKitWebView::resource-load-failed

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchWillSendRequest):
(WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
(WebKit::FrameLoaderClient::dispatchDidReceiveContentLength):
(WebKit::FrameLoaderClient::dispatchDidFinishLoading):
(WebKit::FrameLoaderClient::dispatchDidFailLoading):
* webkit/webkitwebframe.cpp:
(webkit_web_frame_class_init):
* webkit/webkitwebresource.cpp:
(webkit_web_resource_class_init):
* webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
* webkitmarshal.list:

Tools: Patch by Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin <svillar@igalia.com> on 2012-02-01
Reviewed by Martin Robinson.

[GTK] Improve FrameLoader signals. Resource loading
https://bugs.webkit.org/show_bug.cgi?id=49543

Support for the new loader signals in DRT.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(urlPath):
(willSendRequestCallback):
(urlSuitableForTestResult):
(descriptionSuitableForTestResult):
(didReceiveResponse):
(didFinishLoading):
(didFailLoadingWithError):
(createWebView):

LayoutTests: Reviewed by Martin Robinson.

[GTK] Improve FrameLoader signals. Resource loading
https://bugs.webkit.org/show_bug.cgi?id=49543

Unskip tests now passing.

* platform/gtk/Skipped:
* platform/gtk/fast/loader/file-protocol-fragment-expected.txt: Added.
* platform/gtk/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago [Qt] Unreviewed gardening after r106373.
kkristof@inf.u-szeged.hu [Wed, 1 Feb 2012 09:22:23 +0000 (09:22 +0000)]
    [Qt] Unreviewed gardening after r106373.

        * fast/forms/implicit-submission-expected.txt:
        * platform/qt/fast/dom/Window/window-properties-expected.txt:
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
        * platform/qt/fast/js/global-constructors-expected.txt:
        * platform/qt/http/tests/security/cross-frame-access-put-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectation change.
yuzo@google.com [Wed, 1 Feb 2012 09:19:01 +0000 (09:19 +0000)]
[Chromium] Unreviewed test expectation change.
https://bugs.webkit.org/show_bug.cgi?id=77521
fast/repaint/search-field-cancel.html is failing on LINUX.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorun-perf-tests should restart DRT for each test
rniwa@webkit.org [Wed, 1 Feb 2012 09:15:18 +0000 (09:15 +0000)]
run-perf-tests should restart DRT for each test
https://bugs.webkit.org/show_bug.cgi?id=77506

Reviewed by Adam Barth.

Always restart DRT when running performance tests in order to minimize the dependency between tests.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.stop):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(create_runner):
(test_run_passing_test):
(test_run_silent_test):
(test_run_failed_test):
(test_run_tonguey_test):
(test_run_timeout_test):
(test_run_crash_test):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectation change.
yuzo@google.com [Wed, 1 Feb 2012 09:13:17 +0000 (09:13 +0000)]
[Chromium] Unreviewed test expectation change.
fast/repaint/textarea-set-disabled.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=77521

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectation change.
yuzo@google.com [Wed, 1 Feb 2012 09:06:28 +0000 (09:06 +0000)]
[Chromium] Unreviewed test expectation change.
Layout Test fast/forms/textfield-overflow.html is failing on WIN and LINUX.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Disable WebFrameTest.FindInPage
tkent@chromium.org [Wed, 1 Feb 2012 09:01:30 +0000 (09:01 +0000)]
[Chromium] Disable WebFrameTest.FindInPage
https://bugs.webkit.org/show_bug.cgi?id=77186

Disable it because PlatformContextSkiaTest.trackOpaqueOvalTest has
been failing since FindInPage test was committed.

* tests/WebFrameTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeech Input: Report speech element rect relative to window rather than frame
hans@chromium.org [Wed, 1 Feb 2012 08:52:10 +0000 (08:52 +0000)]
Speech Input: Report speech element rect relative to window rather than frame
https://bugs.webkit.org/show_bug.cgi?id=76443

Reviewed by Darin Fisher.

Source/WebCore:

When requesting speech input, report the speech element rect relative
to the window rather than the frame. The embedder will typically use
this position to show a bubble indicating that speech recognition is
in progress.

Test: fast/speech/bubble-position.html

* html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

Tools:

Update LayoutTestController to allow for retrieving the speech
element's position used in a request.

In Chromium this is handled by the MockWebSpeechInputController;
adding stubs for the other implementations.

* DumpRenderTree/LayoutTestController.cpp:
(setMockSpeechInputDumpRectCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setMockSpeechInputDumpRect):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
(MockWebSpeechInputController::setDumpRect):
(MockWebSpeechInputController::clearResults):
(MockWebSpeechInputController::startRecognition):
(MockWebSpeechInputController::MockWebSpeechInputController):
(makeRectResult):
(MockWebSpeechInputController::speechTaskFired):
* DumpRenderTree/chromium/MockWebSpeechInputController.h:
(MockWebSpeechInputController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setMockSpeechInputDumpRect):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setMockSpeechInputDumpRect):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setMockSpeechInputDumpRect):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setMockSpeechInputDumpRect):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setMockSpeechInputDumpRect):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setMockSpeechInputDumpRect):

LayoutTests:

Add layout test to check that the element position used when
requesting speech input is relative to the window, not the frame.

* fast/speech/bubble-position-expected.txt: Added.
* fast/speech/bubble-position.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline after r106373 and r106361.
philn@webkit.org [Wed, 1 Feb 2012 08:09:00 +0000 (08:09 +0000)]
Unreviewed, GTK rebaseline after r106373 and r106361.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
* platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-perf.appspot.com should accept test results without medians
rniwa@webkit.org [Wed, 1 Feb 2012 07:47:08 +0000 (07:47 +0000)]
webkit-perf.appspot.com should accept test results without medians
https://bugs.webkit.org/show_bug.cgi?id=77513

Reviewed by Hajime Morita.

Don't store 0s when values are not in JSON.

* Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post._float_or_none):
(ReportHandler.post):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake elements that don't have attributes smaller.
kling@webkit.org [Wed, 1 Feb 2012 07:36:21 +0000 (07:36 +0000)]
Make elements that don't have attributes smaller.
<http://webkit.org/b/76876>

Reviewed by Sam Weinig and Antti Koivisto.

Move the inline style declaration from StyledElement to ElementAttributeData, since having
an inline style declaration also implies having a style attribute on the element.
This saves one CPU word per element that has no attributes.

This reduces memory consumption by 412 kB (on 64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>.

This was rolled out once because of a performance regression which has been averted this
time around by adding an Element::ensureAttributeMap() so we can force creation of the
NamedNodeMap without also serializing the inline style for the "style" attribute.

* dom/Element.h:
(Element):
(WebCore::Element::ensureAttributeMap):
(WebCore):
* dom/ElementAttributeData.h:
(ElementAttributeData):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::ensureInlineStyleDecl):
(WebCore):
(WebCore::NamedNodeMap::destroyInlineStyleDecl):
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::inlineStyleDecl):
(NamedNodeMap):
* dom/StyledElement.cpp:
(WebCore::StyledElement::addSubresourceAttributeURLs):
* dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(StyledElement):
(WebCore::StyledElement::destroyInlineStyleDecl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd APIs, getElementsByXXX family, to ShadowRoot IDL.
hayato@chromium.org [Wed, 1 Feb 2012 06:55:17 +0000 (06:55 +0000)]
Add APIs, getElementsByXXX family, to ShadowRoot IDL.
https://bugs.webkit.org/show_bug.cgi?id=77323

Reviewed by Dimitri Glazkov.

Add APIs (getElementById, getElemesntByTagName, getElementsByClassName and getElementsByTagNameNS)
to ShadowRoot IDL.

Source/WebCore:

* dom/ShadowRoot.idl:

LayoutTests:

* fast/dom/shadow/shadow-root-js-api-expected.txt:
* fast/dom/shadow/shadow-root-js-api.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd missing JS_PRIVATE_EXPORTs
commit-queue@webkit.org [Wed, 1 Feb 2012 06:49:26 +0000 (06:49 +0000)]
Add missing JS_PRIVATE_EXPORTs
https://bugs.webkit.org/show_bug.cgi?id=77507

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-31
Reviewed by Kevin Ollivier.

* heap/MarkedSpace.h:
(MarkedSpace):
* interpreter/Interpreter.h:
(Interpreter):
* runtime/JSValue.h:
(JSValue):
* wtf/text/AtomicString.h:
(WTF::AtomicString::add):
* wtf/text/WTFString.h:
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoContent element should be able to be dynamically added/removed/replaced in a shadow...
commit-queue@webkit.org [Wed, 1 Feb 2012 06:39:11 +0000 (06:39 +0000)]
Content element should be able to be dynamically added/removed/replaced in a shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=76611

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-31
Reviewed by Hajime Morita.

Source/WebCore:

When a content element is added/removed/replaced in a shadow tree, we have to recreate
the shadow tree to recalculate inclusions of content elements. Currently we didn't recalculate it
when content element is removed. (When added, it is recalculated.)
This patch enables us to recalcurate the shadow tree when content element is removed.

Test: fast/dom/shadow/content-element-move.html

* dom/Element.cpp:
(WebCore::Element::attach):
  If a shadow root exists, attaches shadow tree before attaching child elements.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::recalcShadowTreeStyle):
  Recalculates light children and shadow tree.
(WebCore::ShadowRoot::reattachHostChildrenAndShadow):
  Detaches shadow tree and host light children, and attaches them again.
* dom/ShadowRoot.h:
  Added a flag to recalculate shadow tree.
(WebCore::ShadowRoot::setNeedsShadowTreeStyleRecalc):
(WebCore::ShadowRoot::clearNeedsShadowTreeStyleRecalc):
(WebCore::ShadowRoot::needsShadowTreeStyleRecalc):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::attach):
  Does not need to detach included elements, because they are not attached in ContainerNode anymore.
(WebCore::HTMLContentElement::detach):
  When a content element detached, reattaches a shadow tree.

LayoutTests:

Test cases for appending/removing/replacing content element in a shadow tree.

* fast/dom/shadow/content-element-move-expected.txt: Added.
* fast/dom/shadow/content-element-move.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Add basic DRT/Efl implementation to support viewport test.
ryuan.choi@samsung.com [Wed, 1 Feb 2012 05:46:30 +0000 (05:46 +0000)]
[EFL] Add basic DRT/Efl implementation to support viewport test.
https://bugs.webkit.org/show_bug.cgi?id=77320

Reviewed by Andreas Kling.

Source/WebKit/efl:

Add dumpConfigurationForViewport.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::dumpConfigurationForViewport):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().

LayoutTests:

Remove fast/viewport from Skipped and add some tests which aren't passed.
These skipped tests are also in qt/Skipped and gtk/Skipped.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=76801
commit-queue@webkit.org [Wed, 1 Feb 2012 05:37:49 +0000 (05:37 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=76801
Listboxes incorrectly display contents when cleared and then re-populated.

Whenever the number of items in the listbox is less than the size of listbox (number of visible items the listbox can accomodate),
we set the listbox scroll-offset to zero. The scroll-offset of the Scrollbar should also be set to 0 so that when the listbox is re-populated,
scrollbar position and the content inside the listbox are in sync.

Source/WebCore:

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-31
Reviewed by Andreas Kling.

Tests: fast/forms/listbox-clear-restore.html

* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computeLogicalHeight): Setting the scroll-offset of the Scrollbar to 0 when scrollbar is not needed.

LayoutTests:

Added test case.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-31
Reviewed by Andreas Kling.

* fast/forms/listbox-clear-restore-expected.html: Added.
* fast/forms/listbox-clear-restore.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStop using -fomit-frame-pointer
ggaren@apple.com [Wed, 1 Feb 2012 05:25:09 +0000 (05:25 +0000)]
Stop using -fomit-frame-pointer
https://bugs.webkit.org/show_bug.cgi?id=77403

Reviewed by Filip Pizlo.

JavaScriptCore is too fast. I'm just the man to fix it.

* Configurations/JavaScriptCore.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectation change.
yuzo@google.com [Wed, 1 Feb 2012 05:19:38 +0000 (05:19 +0000)]
[Chromium] Unreviewed test expectation change.
LayoutTest platform/mac/fast/events/non-roman-key-code.html crashes at r106422.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix build break after r106373.
gyuyoung.kim@samsung.com [Wed, 1 Feb 2012 04:31:26 +0000 (04:31 +0000)]
Unreviewed. Fix build break after r106373.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTMLPreloadScanner should understand the <base> element
abarth@webkit.org [Wed, 1 Feb 2012 04:07:52 +0000 (04:07 +0000)]
HTMLPreloadScanner should understand the <base> element
https://bugs.webkit.org/show_bug.cgi?id=77231

Reviewed by Eric Seidel.

Source/WebCore:

Previously, the HTMLPreloadScanner would ignore the <base> element when
preloading resources.  If there was a <base> tag, this could cause the
preload scanner to make a bunch of useless requests.

This patch teaches the preload scanner to use <base> tags to better
predict which URLs will be used by the document.

Tests: fast/preloader/first-base-tag-scanned-wins.html
       fast/preloader/first-base-tag-wins.html
       fast/preloader/understands-base-tag.html

* dom/Document.cpp:
(WebCore::Document::completeURL):
(WebCore):
* dom/Document.h:
(Document):
(WebCore::Document::baseElementURL):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::HTMLNames::PreloadTask::PreloadTask):
(WebCore::HTMLNames::PreloadTask::processAttributes):
(WebCore::HTMLNames::PreloadTask::preload):
(WebCore::HTMLNames::PreloadTask::baseElementHref):
(PreloadTask):
(WebCore::HTMLPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::processToken):
(WebCore::HTMLPreloadScanner::updatePredictedBaseElementURL):
(WebCore):
* html/parser/HTMLPreloadScanner.h:
(HTMLPreloadScanner):

LayoutTests:

These tests ensure that we understand the <base> element and that we
understand that the first <base> element is the one that maters.

* fast/preloader/first-base-tag-scanned-wins-expected.txt: Added.
* fast/preloader/first-base-tag-scanned-wins.html: Added.
* fast/preloader/first-base-tag-wins-expected.txt: Added.
* fast/preloader/first-base-tag-wins.html: Added.
* fast/preloader/resources/base-image1.png: Copied from LayoutTests/fast/preloader/resources/image1.png.
* fast/preloader/resources/base-image2.png: Copied from LayoutTests/fast/preloader/resources/image1.png.
* fast/preloader/resources/base-image3.png: Copied from LayoutTests/fast/preloader/resources/image1.png.
* fast/preloader/understands-base-tag-expected.txt: Added.
* fast/preloader/understands-base-tag.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImport Dromaeo to WebKit repository.
morrita@google.com [Wed, 1 Feb 2012 03:51:23 +0000 (03:51 +0000)]
Import Dromaeo to WebKit repository.
https://bugs.webkit.org/show_bug.cgi?id=77328

Reviewed by Ryosuke Niwa.

Imported a modified version of Dromaeo which is able to
run on the DRT.

The imported version originally came from:
https://github.com/omo/dromaeo/commit/c942a1452109cdd5f759b3c4aee8d68d490d44a2

* Dromaeo/resources/dromaeo/web/application.css: Added.
* Dromaeo/resources/dromaeo/web/favicon.ico: Added.
* Dromaeo/resources/dromaeo/web/favicon.png: Added.
* Dromaeo/resources/dromaeo/web/htmlrunner.js: Added.
* Dromaeo/resources/dromaeo/web/ie.css: Added.
* Dromaeo/resources/dromaeo/web/images/bg.png: Added.
* Dromaeo/resources/dromaeo/web/images/clouds.png: Added.
* Dromaeo/resources/dromaeo/web/images/clouds2.png: Added.
* Dromaeo/resources/dromaeo/web/images/comets.png: Added.
* Dromaeo/resources/dromaeo/web/images/dino1.png: Added.
* Dromaeo/resources/dromaeo/web/images/dino2.png: Added.
* Dromaeo/resources/dromaeo/web/images/dino3.png: Added.
* Dromaeo/resources/dromaeo/web/images/dino4.png: Added.
* Dromaeo/resources/dromaeo/web/images/dino5.png: Added.
* Dromaeo/resources/dromaeo/web/images/dino6.png: Added.
* Dromaeo/resources/dromaeo/web/images/dino7.png: Added.
* Dromaeo/resources/dromaeo/web/images/dino8.png: Added.
* Dromaeo/resources/dromaeo/web/images/left.png: Added.
* Dromaeo/resources/dromaeo/web/images/logo.png: Added.
* Dromaeo/resources/dromaeo/web/images/logo2.png: Added.
* Dromaeo/resources/dromaeo/web/images/logo3.png: Added.
* Dromaeo/resources/dromaeo/web/images/right.png: Added.
* Dromaeo/resources/dromaeo/web/images/top.png: Added.
* Dromaeo/resources/dromaeo/web/images/water.png: Added.
* Dromaeo/resources/dromaeo/web/index.html: Added.
* Dromaeo/resources/dromaeo/web/jquery.js: Added.
* Dromaeo/resources/dromaeo/web/lib/dojo.js: Added.
* Dromaeo/resources/dromaeo/web/lib/jquery.js: Added.
* Dromaeo/resources/dromaeo/web/lib/mootools.js: Added.
* Dromaeo/resources/dromaeo/web/lib/prototype.js: Added.
* Dromaeo/resources/dromaeo/web/pngfix.js: Added.
* Dromaeo/resources/dromaeo/web/reset.css: Added.
* Dromaeo/resources/dromaeo/web/test-head.html: Added.
* Dromaeo/resources/dromaeo/web/test-head.js: Added.
* Dromaeo/resources/dromaeo/web/test-tail.html: Added.
* Dromaeo/resources/dromaeo/web/test-tail.js: Added.
* Dromaeo/resources/dromaeo/web/tests/MANIFEST.json: Added.
* Dromaeo/resources/dromaeo/web/tests/cssquery-dojo.html: Added.
* Dromaeo/resources/dromaeo/web/tests/cssquery-jquery.html: Added.
* Dromaeo/resources/dromaeo/web/tests/cssquery-mootools.html: Added.
* Dromaeo/resources/dromaeo/web/tests/cssquery-prototype.html: Added.
* Dromaeo/resources/dromaeo/web/tests/cssquery-yui.html: Added.
* Dromaeo/resources/dromaeo/web/tests/dom-attr.html: Added.
* Dromaeo/resources/dromaeo/web/tests/dom-modify.html: Added.
* Dromaeo/resources/dromaeo/web/tests/dom-query.html: Added.
* Dromaeo/resources/dromaeo/web/tests/dom-traverse.html: Added.
* Dromaeo/resources/dromaeo/web/tests/dromaeo-3d-cube.html: Added.
* Dromaeo/resources/dromaeo/web/tests/dromaeo-core-eval.html: Added.
* Dromaeo/resources/dromaeo/web/tests/dromaeo-object-array.html: Added.
* Dromaeo/resources/dromaeo/web/tests/dromaeo-object-regexp.html: Added.
* Dromaeo/resources/dromaeo/web/tests/dromaeo-object-string.html: Added.
* Dromaeo/resources/dromaeo/web/tests/dromaeo-string-base64.html: Added.
* Dromaeo/resources/dromaeo/web/tests/jslib-attr-jquery.html: Added.
* Dromaeo/resources/dromaeo/web/tests/jslib-attr-prototype.html: Added.
* Dromaeo/resources/dromaeo/web/tests/jslib-event-jquery.html: Added.
* Dromaeo/resources/dromaeo/web/tests/jslib-event-prototype.html: Added.
* Dromaeo/resources/dromaeo/web/tests/jslib-modify-jquery.html: Added.
* Dromaeo/resources/dromaeo/web/tests/jslib-modify-prototype.html: Added.
* Dromaeo/resources/dromaeo/web/tests/jslib-style-jquery.html: Added.
* Dromaeo/resources/dromaeo/web/tests/jslib-style-prototype.html: Added.
* Dromaeo/resources/dromaeo/web/tests/jslib-traverse-jquery.html: Added.
* Dromaeo/resources/dromaeo/web/tests/jslib-traverse-prototype.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-3d-morph.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-3d-raytrace.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-access-binary-trees.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-access-fannkuch.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-access-nbody.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-access-nsieve.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-bitops-3bit-bits-in-byte.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-bitops-bits-in-byte.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-bitops-bitwise-and.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-bitops-nsieve-bits.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-controlflow-recursive.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-aes.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-md5.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-sha1.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-date-format-tofte.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-date-format-xparb.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-math-cordic.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-math-partial-sums.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-math-spectral-norm.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-regexp-dna.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-string-fasta.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-string-tagcloud.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-string-unpack-code.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-string-validate-input.html: Added.
* Dromaeo/resources/dromaeo/web/tests/v8-crypto.html: Added.
* Dromaeo/resources/dromaeo/web/tests/v8-deltablue.html: Added.
* Dromaeo/resources/dromaeo/web/tests/v8-earley-boyer.html: Added.
* Dromaeo/resources/dromaeo/web/tests/v8-raytrace.html: Added.
* Dromaeo/resources/dromaeo/web/tests/v8-richards.html: Added.
* Dromaeo/resources/dromaeo/web/tests/72px.png: Added.
* Dromaeo/resources/dromaeo/web/web-style.css: Added.
* Dromaeo/resources/dromaeo/web/webrunner.js: Added.
* Skipped: Unskip the dromaeo driver.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Set content hint information for ewk_view_single.
commit-queue@webkit.org [Wed, 1 Feb 2012 03:38:27 +0000 (03:38 +0000)]
[EFL] Set content hint information for ewk_view_single.
https://bugs.webkit.org/show_bug.cgi?id=77319

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-01-31
Reviewed by Ryosuke Niwa.

The content hint information corresponding to opengl_x11 engine is set
for the image object which ewk_view_single owns when evas is based on
opengl_x11 engine.

* ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_backing_store_add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDynamic allocate AudioBus with required number of channels for AudioNodeInput
commit-queue@webkit.org [Wed, 1 Feb 2012 03:23:12 +0000 (03:23 +0000)]
Dynamic allocate AudioBus with required number of channels for AudioNodeInput
https://bugs.webkit.org/show_bug.cgi?id=76516

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-01-31
Reviewed by Kenneth Russell.

No new tests required.

* webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::checkNumberOfChannelsForInput):
* webaudio/AudioChannelMerger.cpp:
(WebCore::AudioChannelMerger::checkNumberOfChannelsForInput):
* webaudio/AudioGainNode.cpp:
(WebCore::AudioGainNode::checkNumberOfChannelsForInput):
* webaudio/AudioNode.cpp:
(WebCore::AudioNode::checkNumberOfChannelsForInput):
* webaudio/AudioNode.h:
* webaudio/AudioNodeInput.cpp:
(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::updateInternalBus):
(WebCore::AudioNodeInput::internalSummingBus):
* webaudio/AudioNodeInput.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
ap@apple.com [Wed, 1 Feb 2012 03:21:24 +0000 (03:21 +0000)]
REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
https://bugs.webkit.org/show_bug.cgi?id=77473
<rdar://problem/10751357>

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/fast/events/non-roman-key-code.html

* WebCore.exp.in:
* platform/mac/PlatformEventFactoryMac.h:
* platform/mac/PlatformEventFactoryMac.mm:
(WebCore::keyIdentifierForKeyEvent):
(WebCore::windowsKeyCodeForKeyEvent):
Export functions for reuse in WebKit2. I did not attempt any larger refactoring at this time.

Source/WebKit2:

* Shared/mac/WebEventFactory.mm: Removed broken copy/pasted implementation in favor of
WebCore ones.

Tools:

* DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController keyDown:withModifiers:withLocation:]):
* WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::keyDown):
Added a new special keyDown value to test this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake WebGL put synthesized errors in the JS console
commit-queue@webkit.org [Wed, 1 Feb 2012 03:17:06 +0000 (03:17 +0000)]
Make WebGL put synthesized errors in the JS console
https://bugs.webkit.org/show_bug.cgi?id=77267

Patch by Gregg Tavares <gman@google.com> on 2012-01-31
Reviewed by Kenneth Russell.

No new functionality so no new tests.

* html/canvas/WebGLCompressedTextures.cpp:
(WebCore::WebGLCompressedTextures::validateCompressedTexFuncData):
(WebCore::WebGLCompressedTextures::compressedTexImage2D):
(WebCore::WebGLCompressedTextures::compressedTexSubImage2D):
* html/canvas/WebGLCompressedTextures.h:
(WebGLCompressedTextures):
* html/canvas/WebGLDebugShaders.cpp:
(WebCore::WebGLDebugShaders::getTranslatedShaderSource):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::activeTexture):
(WebCore::WebGLRenderingContext::attachShader):
(WebCore::WebGLRenderingContext::bindAttribLocation):
(WebCore::WebGLRenderingContext::checkObjectToBeBound):
(WebCore::WebGLRenderingContext::bindBuffer):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::bindRenderbuffer):
(WebCore::WebGLRenderingContext::bindTexture):
(WebCore::WebGLRenderingContext::blendEquation):
(WebCore::WebGLRenderingContext::blendEquationSeparate):
(WebCore::WebGLRenderingContext::blendFunc):
(WebCore::WebGLRenderingContext::blendFuncSeparate):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::checkFramebufferStatus):
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::compileShader):
(WebCore::WebGLRenderingContext::compressedTexImage2D):
(WebCore::WebGLRenderingContext::compressedTexSubImage2D):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::createShader):
(WebCore::WebGLRenderingContext::deleteObject):
(WebCore::WebGLRenderingContext::depthRange):
(WebCore::WebGLRenderingContext::detachShader):
(WebCore::WebGLRenderingContext::disable):
(WebCore::WebGLRenderingContext::disableVertexAttribArray):
(WebCore::WebGLRenderingContext::validateWebGLObject):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::enable):
(WebCore::WebGLRenderingContext::enableVertexAttribArray):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer):
(WebCore::WebGLRenderingContext::framebufferTexture2D):
(WebCore::WebGLRenderingContext::generateMipmap):
(WebCore::WebGLRenderingContext::getActiveAttrib):
(WebCore::WebGLRenderingContext::getActiveUniform):
(WebCore::WebGLRenderingContext::getAttachedShaders):
(WebCore::WebGLRenderingContext::getAttribLocation):
(WebCore::WebGLRenderingContext::getBufferParameter):
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getProgramParameter):
(WebCore::WebGLRenderingContext::getProgramInfoLog):
(WebCore::WebGLRenderingContext::getRenderbufferParameter):
(WebCore::WebGLRenderingContext::getShaderParameter):
(WebCore::WebGLRenderingContext::getShaderInfoLog):
(WebCore::WebGLRenderingContext::getShaderSource):
(WebCore::WebGLRenderingContext::getTexParameter):
(WebCore::WebGLRenderingContext::getUniform):
(WebCore::WebGLRenderingContext::getUniformLocation):
(WebCore::WebGLRenderingContext::getVertexAttrib):
(WebCore::WebGLRenderingContext::hint):
(WebCore::WebGLRenderingContext::isEnabled):
(WebCore::WebGLRenderingContext::linkProgram):
(WebCore::WebGLRenderingContext::pixelStorei):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::renderbufferStorage):
(WebCore::WebGLRenderingContext::scissor):
(WebCore::WebGLRenderingContext::shaderSource):
(WebCore::WebGLRenderingContext::stencilFunc):
(WebCore::WebGLRenderingContext::stencilFuncSeparate):
(WebCore::WebGLRenderingContext::stencilMaskSeparate):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texImage2DImpl):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::videoFrameToImage):
(WebCore::WebGLRenderingContext::texParameter):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::uniform1f):
(WebCore::WebGLRenderingContext::uniform1fv):
(WebCore::WebGLRenderingContext::uniform1i):
(WebCore::WebGLRenderingContext::uniform1iv):
(WebCore::WebGLRenderingContext::uniform2f):
(WebCore::WebGLRenderingContext::uniform2fv):
(WebCore::WebGLRenderingContext::uniform2i):
(WebCore::WebGLRenderingContext::uniform2iv):
(WebCore::WebGLRenderingContext::uniform3f):
(WebCore::WebGLRenderingContext::uniform3fv):
(WebCore::WebGLRenderingContext::uniform3i):
(WebCore::WebGLRenderingContext::uniform3iv):
(WebCore::WebGLRenderingContext::uniform4f):
(WebCore::WebGLRenderingContext::uniform4fv):
(WebCore::WebGLRenderingContext::uniform4i):
(WebCore::WebGLRenderingContext::uniform4iv):
(WebCore::WebGLRenderingContext::uniformMatrix2fv):
(WebCore::WebGLRenderingContext::uniformMatrix3fv):
(WebCore::WebGLRenderingContext::uniformMatrix4fv):
(WebCore::WebGLRenderingContext::useProgram):
(WebCore::WebGLRenderingContext::validateProgram):
(WebCore::WebGLRenderingContext::vertexAttrib1f):
(WebCore::WebGLRenderingContext::vertexAttrib1fv):
(WebCore::WebGLRenderingContext::vertexAttrib2f):
(WebCore::WebGLRenderingContext::vertexAttrib2fv):
(WebCore::WebGLRenderingContext::vertexAttrib3f):
(WebCore::WebGLRenderingContext::vertexAttrib3fv):
(WebCore::WebGLRenderingContext::vertexAttrib4f):
(WebCore::WebGLRenderingContext::vertexAttrib4fv):
(WebCore::WebGLRenderingContext::vertexAttribPointer):
(WebCore::WebGLRenderingContext::viewport):
(WebCore::WebGLRenderingContext::forceLostContext):
(WebCore::WebGLRenderingContext::loseContextImpl):
(WebCore::WebGLRenderingContext::forceRestoreContext):
(WebCore::WebGLRenderingContext::validateTextureBinding):
(WebCore::WebGLRenderingContext::validateLocationLength):
(WebCore::WebGLRenderingContext::validateSize):
(WebCore::WebGLRenderingContext::validateString):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContext::validateTexFuncLevel):
(WebCore::WebGLRenderingContext::validateTexFuncParameters):
(WebCore::WebGLRenderingContext::validateTexFuncData):
(WebCore::WebGLRenderingContext::validateDrawMode):
(WebCore::WebGLRenderingContext::validateStencilSettings):
(WebCore::WebGLRenderingContext::validateStencilFunc):
(WebCore::WebGLRenderingContext::validateFramebufferFuncParameters):
(WebCore::WebGLRenderingContext::validateBlendEquation):
(WebCore::WebGLRenderingContext::validateBlendFuncFactors):
(WebCore::WebGLRenderingContext::validateCapability):
(WebCore::WebGLRenderingContext::validateUniformParameters):
(WebCore::WebGLRenderingContext::validateUniformMatrixParameters):
(WebCore::WebGLRenderingContext::validateBufferDataParameters):
(WebCore::WebGLRenderingContext::validateHTMLImageElement):
(WebCore::WebGLRenderingContext::vertexAttribfImpl):
(WebCore::WebGLRenderingContext::vertexAttribfvImpl):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
(WebCore):
(WebCore::WebGLRenderingContext::synthesizeGLError):
* html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up m_processLock logic in AudioBasicProcessorNode and AudioGainNode
commit-queue@webkit.org [Wed, 1 Feb 2012 03:04:48 +0000 (03:04 +0000)]
Clean up m_processLock logic in AudioBasicProcessorNode and AudioGainNode
https://bugs.webkit.org/show_bug.cgi?id=76772

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-01-31
Reviewed by Kenneth Russell.

No new tests required.

* webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::process):
(WebCore::AudioBasicProcessorNode::checkNumberOfChannelsForInput):
* webaudio/AudioBasicProcessorNode.h:
* webaudio/AudioGainNode.cpp:
(WebCore::AudioGainNode::process):
(WebCore::AudioGainNode::checkNumberOfChannelsForInput):
* webaudio/AudioGainNode.h:
(AudioGainNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix Parser/html5-full-render.html after r106379.
rniwa@webkit.org [Wed, 1 Feb 2012 01:55:03 +0000 (01:55 +0000)]
Fix Parser/html5-full-render.html after r106379.

* Parser/html5-full-render.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoProcessingInstruction should not be a ContainerNode
adamk@chromium.org [Wed, 1 Feb 2012 01:54:09 +0000 (01:54 +0000)]
ProcessingInstruction should not be a ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=75141

Reviewed by Darin Adler.

Source/WebCore:

Per the DOM spec, ProcessingInstruction can't have any children.
And the WebCore behavior already matches the spec by always returning
false for childTypeAllowed(). This change simplifies
ProcessingInstruction's implementation by making it subclass Node
instead of ContainerNode.

Test: fast/dom/processing-instruction-appendChild-exceptions.xhtml

* dom/ContainerNode.cpp: Moved dispatchBeforeLoadEvent up to Node.
* dom/ContainerNode.h:
* dom/Node.cpp:
(WebCore::Node::dispatchBeforeLoadEvent): Moved up from ContainerNode
since it's used both by ProcessingInstruction and various Element
subclasses.
* dom/Node.h:
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::ProcessingInstruction): Call Node constructor.
(WebCore::ProcessingInstruction::insertedIntoDocument): Call Node impl.
(WebCore::ProcessingInstruction::removedFromDocument): ditto.
(WebCore::ProcessingInstruction::finishParsingChildren): ditto.
* dom/ProcessingInstruction.h:

LayoutTests:

* fast/dom/processing-instruction-appendChild-exceptions-expected.txt: Added.
* fast/dom/processing-instruction-appendChild-exceptions.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStringProtoFuncToUpperCase should call StringImpl::upper similar to StringProtoToLowe...
msaboff@apple.com [Wed, 1 Feb 2012 01:49:15 +0000 (01:49 +0000)]
StringProtoFuncToUpperCase should call StringImpl::upper similar to StringProtoToLowerCase
https://bugs.webkit.org/show_bug.cgi?id=76647

Reviewed by Darin Adler.

Changed stringProtoFuncToUpperCase to call StringImpl::upper() in a manor similar
to stringProtoFuncToLowerCase().  Fixed StringImpl::upper() to handle to special
cases.  One case is s-sharp (0xdf) which converts to "SS".  The other case is
for characters which become 16 bit values when converted to upper case.  For
those, we up convert the the source string and use the 16 bit path.

* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncToUpperCase):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::upper):
* wtf/unicode/CharacterNames.h:
(smallLetterSharpS): New constant

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: fix the mock port to work with DriverProxy, reftests
dpranke@chromium.org [Wed, 1 Feb 2012 01:41:35 +0000 (01:41 +0000)]
nrwt: fix the mock port to work with DriverProxy, reftests
https://bugs.webkit.org/show_bug.cgi?id=77170

Reviewed by Eric Seidel.

The DryrunPort used for benchmarking and testing NRWT has been
broken since we added the DriverProxy code. It isn't really
needed any more, so I've removed it.

The MockDRT port was also broken by DriverProxy, and moreover,
never worked w/ reftests. Since we don't exercise this module in
the unit tests, the code had also bitrotted some. I have cleaned
it up and made it use DriverInput and DriverOutput for
consistency.

* Scripts/webkitpy/layout_tests/port/dryrun.py:
(DryRunPort.__init__):
(DryRunPort):
(DryRunPort.real_name):
(DryRunPort.create_driver):
(DryRunPort.driver_cmd_line):
(DryRunPort._driver_class):
(DryrunDriver):
(DryrunDriver.run_test):
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
(MockDRTPort.create_driver):
(MockChromiumDRT.run_one_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFailing 2d.shadow.enable.off.2.html on Lion
mdelaney@apple.com [Wed, 1 Feb 2012 01:21:32 +0000 (01:21 +0000)]
Failing 2d.shadow.enable.off.2.html on Lion
https://bugs.webkit.org/show_bug.cgi?id=77489

Reviewed by Dan Bernstein.

Source/WebCore:

The canvas spec requires that shadows not be drawn under certain
circumstances outlined here: http://www.whatwg.org/specs/web-apps/current-work/#shadows
This patch adds in those checks which allows us to pass now (on Lion)
the philip canvas test that was checking that constraint.

No new tests. Unskipping the test on Lion that this patch fixes.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setAllAttributesToDefault):
(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::applyShadow):
(WebCore::CanvasRenderingContext2D::shouldDrawShadows):
* html/canvas/CanvasRenderingContext2D.h:
(CanvasRenderingContext2D):

LayoutTests:

* platform/mac-lion/Skipped: We can unskip this test now that this patch has us passing this test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unneeded sourceId property
oliver@apple.com [Wed, 1 Feb 2012 01:18:38 +0000 (01:18 +0000)]
Remove unneeded sourceId property
https://bugs.webkit.org/show_bug.cgi?id=77495

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

sourceId isn't used anymore, so we'll just remove it.

* runtime/Error.cpp:
(JSC):
(JSC::addErrorInfo):
(JSC::hasErrorInfo):

LayoutTests:

Update the test for the removal of sourceId

* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectation change.
yuzo@google.com [Wed, 1 Feb 2012 01:09:25 +0000 (01:09 +0000)]
[Chromium] Unreviewed test expectation change.
fast/replaced/width100percent-searchfield.html is failing on MAC.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorun-webkit-tests calls out to webkit-build-directory twice
ojan@chromium.org [Wed, 1 Feb 2012 00:32:57 +0000 (00:32 +0000)]
run-webkit-tests calls out to webkit-build-directory twice
https://bugs.webkit.org/show_bug.cgi?id=77248

Reviewed by Dirk Pranke.

* Scripts/webkit-build-directory:
If called with no arguments, print out both the top-level directory and the
configuration directory

* Scripts/webkitpy/layout_tests/port/config.py:
(Config.build_directory):
When called with no arguments, get and cache both the top-level and configuration directories.

* Scripts/webkitpy/layout_tests/port/config_standalone.py:
(main):
* Scripts/webkitpy/layout_tests/port/config_unittest.py:
(ConfigTest.assert_configuration):
(ConfigTest.test_build_directory.mock_webkit_build_directory):
(ConfigTest.test_build_directory):
(ConfigTest.test_default_configuration__notfound):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._build_path):
Cache the build directory in the options object so that other users
of the options object don't need to call out to webkit-build-directory.
Also, properly support the existing --build-directory argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTileCache::setNeedsDisplayInRect cleanup
andersca@apple.com [Tue, 31 Jan 2012 23:58:04 +0000 (23:58 +0000)]
TileCache::setNeedsDisplayInRect cleanup
https://bugs.webkit.org/show_bug.cgi?id=77486

Reviewed by Andreas Kling.

* platform/graphics/ca/mac/TileCache.h:
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setNeedsDisplayInRect):
TileCache::tileLayerAtIndex can in the future return nil, so cope with that. Also, replace
nested if statements with continue statements.

(WebCore::TileCache::getTileIndexRangeForRect):
Rename this to better indicate that it returns a range of indices.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] enable -Wexit-time-destructors for webkit unit tests
commit-queue@webkit.org [Tue, 31 Jan 2012 23:55:39 +0000 (23:55 +0000)]
[chromium] enable -Wexit-time-destructors for webkit unit tests
https://bugs.webkit.org/show_bug.cgi?id=77300
Fix the only extant violation (verified by building webkit_unit_tests in static build).

Patch by Ami Fischman <fischman@chromium.org> on 2012-01-31
Reviewed by Tony Chang.

* WebKitUnitTests.gyp:
* tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::defaultWebFrameClient):
(WebKit::FrameTestHelpers::defaultWebViewClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBump up the timeout for performance tests since DOM/DOMTable.html
rniwa@webkit.org [Tue, 31 Jan 2012 23:49:32 +0000 (23:49 +0000)]
Bump up the timeout for performance tests since DOM/DOMTable.html
and Parser/html5-full-render.html are timing out on the bot.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd contains() test to Region
commit-queue@webkit.org [Tue, 31 Jan 2012 23:36:06 +0000 (23:36 +0000)]
Add contains() test to Region
https://bugs.webkit.org/show_bug.cgi?id=72294

Patch by Dana Jansens <danakj@chromium.org> on 2012-01-31
Reviewed by Anders Carlsson.

* platform/graphics/Region.cpp:
(WebCore::Region::contains):
(WebCore):
* platform/graphics/Region.h:
(Region):
(Shape):
(WebCore::operator==):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement Error.stack
oliver@apple.com [Tue, 31 Jan 2012 23:24:55 +0000 (23:24 +0000)]
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Original patch by Juan Carlos Montemayor Elosua:
    This patch utilizes topCallFrame to create a stack trace when
    an error is thrown. Users will also be able to use the stack()
    command in jsc to get arrays with stack trace information.

Modified to be correct on ToT, with a variety of correctness,
performance, and security improvements.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::getCallerLine):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
* interpreter/Interpreter.h:
(JSC::StackFrame::toString):
* jsc.cpp:
(GlobalObject::finishCreation):
(functionJSCStack):
* parser/Parser.h:
(JSC::Parser::parse):
* runtime/CommonIdentifiers.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/Error.h:

LayoutTests:

Reviewed by Gavin Barraclough

Original patch by Juan Carlos Montemayor Elosua.

Unit tests that contain both normal and special cases for stack trace
generation.

* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:
* fast/js/script-tests/stack-trace.js: Added.
(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):
* fast/js/stack-trace-expected.txt: Added.
* fast/js/stack-trace.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Compositor debug borders are not scaled correctly
commit-queue@webkit.org [Tue, 31 Jan 2012 23:20:32 +0000 (23:20 +0000)]
[chromium] Compositor debug borders are not scaled correctly
https://bugs.webkit.org/show_bug.cgi?id=77468

Use CCLayerImpl::contentBounds() instead of CCLayerImpl::bounds() to calculate debug
border geometry so that the borders are properly scaled.

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-31
Reviewed by James Robinson.

* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::appendDebugBorderQuad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Re-enable structured-clone test
jsbell@chromium.org [Tue, 31 Jan 2012 23:17:25 +0000 (23:17 +0000)]
IndexedDB: Re-enable structured-clone test
https://bugs.webkit.org/show_bug.cgi?id=77239

This test was landed disabled, since it was failing. Turns out Date serialization
differs ("PST" vs. "Pacific Standard Time") across machines, so debug statements
in the test were removed.

Reviewed by Tony Chang.

* platform/chromium/test_expectations.txt:
* storage/indexeddb/structured-clone-expected.txt:
* storage/indexeddb/structured-clone.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the update_webgl_conformance_tests.py script in order to enable it
commit-queue@webkit.org [Tue, 31 Jan 2012 23:11:13 +0000 (23:11 +0000)]
Fix the update_webgl_conformance_tests.py script in order to enable it
to detect the SCM being used correctly.
https://bugs.webkit.org/show_bug.cgi?id=77462

Patch by Ehsan Akhgari <ehsan.akhgari@gmail.com> on 2012-01-31
Reviewed by Kenneth Russell.

* Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
(default_out_dir):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] bot lacks mobility
kbalazs@webkit.org [Tue, 31 Jan 2012 23:09:51 +0000 (23:09 +0000)]
[Qt][WK2] bot lacks mobility
https://bugs.webkit.org/show_bug.cgi?id=68243

Unreviewed gardening.
Removing tests from skipped list. These tests are no
longer failing since the Qt5 tree we use includes
the required modules that used to live in mobility.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTry to fix Qt build.
antti@apple.com [Tue, 31 Jan 2012 23:07:49 +0000 (23:07 +0000)]
Try to fix Qt build.

Not reviewed.

* Api/qwebelement.cpp:
(QWebElement::styleProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Expose windowResizerRectChanged() on WebWidget.
thakis@chromium.org [Tue, 31 Jan 2012 23:02:14 +0000 (23:02 +0000)]
[chromium] Expose windowResizerRectChanged() on WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=77453

Needed for http://crbug.com/111266

Reviewed by Darin Fisher.

* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::didChangeWindowResizerRect):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::didChangeWindowResizerRect):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r106376.
commit-queue@webkit.org [Tue, 31 Jan 2012 22:58:23 +0000 (22:58 +0000)]
Unreviewed, rolling out r106376.
http://trac.webkit.org/changeset/106376
https://bugs.webkit.org/show_bug.cgi?id=77481

Broke WebGLLayerChromiumTest in webkit_unit_tests (Requested
by kbr_google on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-31

Source/WebCore:

* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):
(WebCore::DrawingBuffer::reset):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Import PaintAggregator
nduca@chromium.org [Tue, 31 Jan 2012 22:57:20 +0000 (22:57 +0000)]
[chromium] Import PaintAggregator
https://bugs.webkit.org/show_bug.cgi?id=53715

Reviewed by Darin Fisher.

* WebKit.gyp:
* WebKit.gypi:
* src/painting/PaintAggregator.cpp: Added.
(WebKit::calculateArea):
(WebKit::subtractIntersection):
(WebKit::sharesEdge):
(WebKit::PaintAggregator::PendingUpdate::PendingUpdate):
(WebKit::PaintAggregator::PendingUpdate::~PendingUpdate):
(WebKit::PaintAggregator::PendingUpdate::calculateScrollDamage):
(WebKit::PaintAggregator::PendingUpdate::calculatePaintBounds):
(WebKit::PaintAggregator::hasPendingUpdate):
(WebKit::PaintAggregator::clearPendingUpdate):
(WebKit::PaintAggregator::popPendingUpdate):
(WebKit::PaintAggregator::invalidateRect):
(WebKit::PaintAggregator::scrollRect):
(WebKit::PaintAggregator::scrollPaintRect):
(WebKit::PaintAggregator::shouldInvalidateScrollRect):
(WebKit::PaintAggregator::invalidateScrollRect):
(WebKit::PaintAggregator::combinePaintRects):
* src/painting/PaintAggregator.h: Added.
* tests/PaintAggregatorTest.cpp: Added.
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSSRegions]Reduce the cases when the box style in region is computed
mihnea@adobe.com [Tue, 31 Jan 2012 22:55:00 +0000 (22:55 +0000)]
[CSSRegions]Reduce the cases when the box style in region is computed
https://bugs.webkit.org/show_bug.cgi?id=77446

Reviewed by David Hyatt.

Covered by existing region style tests.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRegionBoxesRegionStyle):
(WebCore::RenderRegion::restoreRegionBoxesOriginalStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPut tiles in a HashMap
andersca@apple.com [Tue, 31 Jan 2012 22:46:39 +0000 (22:46 +0000)]
Put tiles in a HashMap
https://bugs.webkit.org/show_bug.cgi?id=77480

Reviewed by Antti Koivisto.

Put tiles in a hash map keyed off the tile index.

* platform/graphics/ca/mac/TileCache.h:
Shuffle member variables around so the order makes more sense.
Add the tile map.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache):
Update member initializers.

(WebCore::TileCache::setNeedsDisplayInRect):
Call tileLayerAtIndex instead of tileLayerAtPosition.

(WebCore::TileCache::setAcceleratesDrawing):
(WebCore::TileCache::setTileDebugBorderWidth):
(WebCore::TileCache::setTileDebugBorderColor):
Iterate over the hash map instead of the sublayers.

(WebCore::TileCache::resizeTileGrid):
Add the created layers to the map.

(WebCore::TileCache::tileLayerAtIndex):
Rename from tileLayerAtPoint to better reflect that this member function
returns a tile layer at the given index and not the given point.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch apply-from-bug should work regardless of your CWD
eric@webkit.org [Tue, 31 Jan 2012 22:45:22 +0000 (22:45 +0000)]
webkit-patch apply-from-bug should work regardless of your CWD
https://bugs.webkit.org/show_bug.cgi?id=77482

Reviewed by Adam Barth.

webkit-patch only ever works with patches made from the root
directory.  We should pass the CWD to svn-apply in the case
where we're running not from the webkit root.  I believe
this used to work in the past and regressed.

* Scripts/webkitpy/common/checkout/checkout.py:
(Checkout.apply_patch):
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
(CheckoutTest.test_apply_patch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] ChromeClientImpl::dispatchViewportPropertiesDidChange is repeatedly called...
fsamuel@chromium.org [Tue, 31 Jan 2012 22:42:26 +0000 (22:42 +0000)]
[Chromium] ChromeClientImpl::dispatchViewportPropertiesDidChange is repeatedly called in Google News
https://bugs.webkit.org/show_bug.cgi?id=77429

Reviewed by Darin Fisher.

m_webView->isPageScaleFactorSet() is tested in ChromeClientImpl::layoutUpdated, and it is never true,
because WebViewImpl::setPageScaleFactorPreservingScrollOffset is called repeatedly and exits early
and thus never calls WebViewImpl::setPageScaleFactor which sets the flag.

The simplest solution is to simply get rid of the early return in
WebViewImpl::setPageScaleFactorPreservingScrollOffset.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Expose setLayoutFallbackWidth as a WebSetting
fsamuel@chromium.org [Tue, 31 Jan 2012 22:40:19 +0000 (22:40 +0000)]
[Chromium] Expose setLayoutFallbackWidth as a WebSetting
https://bugs.webkit.org/show_bug.cgi?id=77431

Reviewed by Darin Fisher.

The layout fallback width is the default fixed layout width
set for desktop web pages that lack a viewport tag. This width
can vary from platform to platform and can depend on other factors,
and so it should be a setting exposed to Chromium.

* public/WebSettings.h:
():
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setLayoutFallbackWidth):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake CSSOM style() return CSSStyleDeclaration*
antti@apple.com [Tue, 31 Jan 2012 22:30:22 +0000 (22:30 +0000)]
Make CSSOM style() return CSSStyleDeclaration*
https://bugs.webkit.org/show_bug.cgi?id=77475

Reviewed by Anders Carlsson

CSSStyleRule::style() and some other places return CSSMutableStyleDeclaration.
They should return the plain CSSOM type instead.

CSSMutableStyleDeclaration* should be available through non-CSSOM function.

* css/CSSFontFaceRule.h:
(WebCore::CSSFontFaceRule::style):
(WebCore::CSSFontFaceRule::declaration):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
* css/CSSStyleRule.h:
(WebCore::CSSStyleRule::style):
(WebCore::CSSStyleRule::declaration):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForKeyframe):
* css/WebKitCSSKeyframeRule.h:
(WebCore):
(WebCore::WebKitCSSKeyframeRule::style):
(WebCore::WebKitCSSKeyframeRule::declaration):
(WebKitCSSKeyframeRule):
* editing/EditingStyle.cpp:
(WebCore::styleFromMatchedRulesForElement):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::revalidateStyle):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::retrieveResourcesForCSSRule):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::parseMappedAttribute):
(WebCore::SVGFontFaceElement::fontFamily):
(WebCore::SVGFontFaceElement::rebuildFontFace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: refactor basics layout test so that it can be run on workers.
dgrogan@chromium.org [Tue, 31 Jan 2012 22:05:31 +0000 (22:05 +0000)]
IndexedDB: refactor basics layout test so that it can be run on workers.
https://bugs.webkit.org/show_bug.cgi?id=76683

Reviewed by Tony Chang.

* storage/indexeddb/basics-workers-expected.txt: Added.
* storage/indexeddb/basics-workers.html: Added.
* storage/indexeddb/basics.html:
* storage/indexeddb/resources/basics.js: Copied from LayoutTests/storage/indexeddb/basics.html.
(test):
(openCallback):
* storage/indexeddb/resources/idb-worker-common.js: Added.
(debug):
(finishJSTest):
(description):
(testPassed):
(testFailed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove references to gyp cygwin build target
commit-queue@webkit.org [Tue, 31 Jan 2012 22:00:10 +0000 (22:00 +0000)]
[Chromium] Remove references to gyp cygwin build target
https://bugs.webkit.org/show_bug.cgi?id=77253

Patch by Scott Graham <scottmg@chromium.org> on 2012-01-31
Reviewed by Julien Chaffraix.

Target dependency is no longer required, it's done earlier in the
build process.

Source/JavaScriptCore:

* JavaScriptCore.gyp/JavaScriptCore.gyp:

Source/WebCore:

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline results after http://trac.webkit.org/changeset/106373
eric@webkit.org [Tue, 31 Jan 2012 21:57:01 +0000 (21:57 +0000)]
Rebaseline results after trac.webkit.org/changeset/106373

Unreviewed.

* fast/forms/implicit-submission-expected.txt:
* platform/chromium-mac/fast/dom/Window/window-lookup-precedence-expected.txt: Removed.
* platform/chromium-mac/fast/dom/wrapper-classes-expected.txt: Removed.
* platform/chromium-win/fast/forms/implicit-submission-expected.txt:
* platform/chromium/fast/dom/Window/element-constructors-on-window-expected.txt:
* platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt:
* platform/chromium/fast/dom/wrapper-classes-expected.txt:
* platform/mac/fast/forms/implicit-submission-expected.txt: Copied from LayoutTests/fast/forms/implicit-submission-expected.txt.
* platform/qt/fast/forms/implicit-submission-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r106302.
ojan@chromium.org [Tue, 31 Jan 2012 21:46:09 +0000 (21:46 +0000)]
Unreviewed, rolling out r106302.
http://trac.webkit.org/changeset/106302
https://bugs.webkit.org/show_bug.cgi?id=77472

Broke building DRT before running the tests (Requested by ojan
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-31

* Scripts/webkit-build-directory:
* Scripts/webkitpy/layout_tests/port/config.py:
(Config.build_directory):
* Scripts/webkitpy/layout_tests/port/config_standalone.py:
(main):
* Scripts/webkitpy/layout_tests/port/config_unittest.py:
(ConfigTest.assert_configuration):
(ConfigTest.test_build_directory.mock_webkit_build_directory):
(ConfigTest.test_build_directory):
(ConfigTest.test_default_configuration__notfound):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._build_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHidden form elements do not save their state prior to form submission
jonlee@apple.com [Tue, 31 Jan 2012 21:43:56 +0000 (21:43 +0000)]
Hidden form elements do not save their state prior to form submission
https://bugs.webkit.org/show_bug.cgi?id=77391
<rdar://problem/10563108>

Reviewed by Brady Eidson.

Source/WebCore:

Test: fast/forms/state-restore-hidden.html

* html/HiddenInputType.cpp: Teach hidden inputs to save and restore their state.
(WebCore::HiddenInputType::saveFormControlState):
(WebCore::HiddenInputType::restoreFormControlState):
* html/HiddenInputType.h:
(HiddenInputType):

LayoutTests:

The test changes the value of the hidden input element via Javascript prior to
submitting the form. The form action goes back one page, and we check to see
that the hidden input value is what it was set to by Javascript, rather than what
it was originally assigned.

* fast/forms/state-restore-hidden-expected.txt: Added.
* fast/forms/state-restore-hidden.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: IDBCursor.update() should raise exception if key changed
jsbell@chromium.org [Tue, 31 Jan 2012 21:39:33 +0000 (21:39 +0000)]
IndexedDB: IDBCursor.update() should raise exception if key changed
https://bugs.webkit.org/show_bug.cgi?id=76952

Source/WebCore:

Move the test from the async task to the synchronous call, per spec. Also re-ordered the tests
done during the synchronous call and the asynchronous task to follow the spec order.

Reviewed by Tony Chang.

Tests: storage/indexeddb/cursor-update.html

* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put): Added check during update() call, order checks per spec.
(WebCore::IDBObjectStoreBackendImpl::putInternal): Move effective key calculation inline.
* storage/IDBObjectStoreBackendImpl.h: Removed selectKeyForPut method.

LayoutTests:

Reviewed by Tony Chang.

* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/cursor-update.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPerfTestRunner should automatically create pre#log
rniwa@webkit.org [Tue, 31 Jan 2012 21:35:51 +0000 (21:35 +0000)]
PerfTestRunner should automatically create pre#log
https://bugs.webkit.org/show_bug.cgi?id=77469

Reviewed by Tony Chang.

Automatically generate <pre id="log"></pre> if there isn't one.

* Bindings/event-target-wrapper.html:
* DOM/Accessors.html:
* DOM/CloneNodes.html:
* DOM/CreateNodes.html:
* DOM/DOMDivWalk.html:
* DOM/DOMTable.html:
* DOM/DOMWalk.html:
* DOM/Events.html:
* DOM/GetElement.html:
* DOM/GridSort.html:
* DOM/Template.html:
* Dromaeo/dom-query.html:
* Dromaeo/resources/dromaeorunner.js:
* Parser/html-parser.html:
* Parser/html5-full-render.html:
* Parser/simple-url.html:
* Parser/tiny-innerHTML.html:
* Parser/url-parser.html:
* Parser/xml-parser.html:
* resources/runner.js:
(PerfTestRunner.log):
(PerfTestRunner.printStatistics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInform the tile cache whenever the visible rect changes
andersca@apple.com [Tue, 31 Jan 2012 21:31:17 +0000 (21:31 +0000)]
Inform the tile cache whenever the visible rect changes
https://bugs.webkit.org/show_bug.cgi?id=77470

Reviewed by Andreas Kling.

* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::visibleRectChanged):
Add empty function.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::visibleRectChanged):
Call through to the PlatformCALayer.

* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::visibleRectChanged):
Call through to the underlying WebTileCacheLayer.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::visibleRectChanged):
Add empty stub.

(WebCore::TileCache::visibleRect):
Add new (currently unused) helper function that returns the visible rect of the
tile cache layer.

* platform/graphics/ca/mac/WebTileCacheLayer.h:
* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer visibleRectChanged]):
Call through to the TielCache object.

* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::visibleRectChanged):
Add stub.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):
Call GraphicsLayer::visibleRectChanged.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove CSSStyleDeclaration isElementStyleDeclaration bit
antti@apple.com [Tue, 31 Jan 2012 21:24:12 +0000 (21:24 +0000)]
Remove CSSStyleDeclaration isElementStyleDeclaration bit
https://bugs.webkit.org/show_bug.cgi?id=77460

Reviewed by Andreas Kling.

Inline style declaration is now the only type of style declaration with element parent.
We can remove the bit and the associated logic.

* bindings/js/JSDOMBinding.h:
(WebCore::root):
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::createInline):
(CSSMutableStyleDeclaration):
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
(WebCore):
(WebCore::CSSStyleDeclaration::parentStyleSheet):
* css/CSSStyleDeclaration.h:
(WebCore::CSSStyleDeclaration::parentRule):
(WebCore::CSSStyleDeclaration::clearParentRule):
(WebCore::CSSStyleDeclaration::parentElement):
(WebCore::CSSStyleDeclaration::clearParentElement):
(CSSStyleDeclaration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Compute occlusion during paint loop
commit-queue@webkit.org [Tue, 31 Jan 2012 21:15:27 +0000 (21:15 +0000)]
[chromium] Compute occlusion during paint loop
https://bugs.webkit.org/show_bug.cgi?id=76858

Patch by Dana Jansens <danakj@chromium.org> on 2012-01-31
Reviewed by James Robinson.

Source/WebCore:

New unit tests in TiledLayerChromiumTest.cpp, CCLayerTreeHostCommonTest.cpp, CCLayerTreeHostTest.cpp

* platform/graphics/FloatRect.cpp:
(WebCore::enclosedIntRect):
(WebCore):
* platform/graphics/FloatRect.h:
(WebCore):
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerChromium):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/ImageLayerChromium.h:
(ImageLayerChromium):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::contentToScreenSpaceTransform):
(WebCore):
(WebCore::LayerChromium::addSelfToOccludedScreenSpace):
(WebCore::LayerChromium::isPaintedAxisAlignedInScreen):
* platform/graphics/chromium/LayerChromium.h:
(WebCore):
(WebCore::LayerChromium::paintContentsIfDirty):
(LayerChromium):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::addSelfToOccludedScreenSpace):
* platform/graphics/chromium/TiledLayerChromium.h:
(WebCore):
():
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(RenderSurfaceRegion):
(WebCore):
(WebCore::pushTargetRenderSurfaceRegion):
(WebCore::popAndPushTargetRenderSurfaceRegion):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
():
* platform/graphics/chromium/cc/CCQuadCuller.cpp:

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:
(WebCore::TEST):
(WebCore):
* tests/CCLayerTreeHostTest.cpp:
(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF):
(TestLayerChromium):
(WTF::TestLayerChromium::create):
(WTF::TestLayerChromium::paintContentsIfDirty):
(WTF::TestLayerChromium::drawsContent):
(WTF::TestLayerChromium::occludedScreenSpace):
(WTF::TestLayerChromium::clearOccludedScreenSpace):
(WTF::TestLayerChromium::TestLayerChromium):
(WTF::setLayerPropertiesForTesting):
(CCLayerTreeHostTestLayerOcclusion):
(WTF::CCLayerTreeHostTestLayerOcclusion::CCLayerTreeHostTestLayerOcclusion):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusion::afterTest):
* tests/Canvas2DLayerChromiumTest.cpp:
(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
* tests/TiledLayerChromiumTest.cpp:
(WTF::FakeLayerTextureUpdater::setOpaquePaintRect):
(FakeLayerTextureUpdater):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::FakeLayerTextureUpdater::prepareToUpdate):
(WTF::TEST):
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Add chromium-style tracing support
commit-queue@webkit.org [Tue, 31 Jan 2012 21:02:45 +0000 (21:02 +0000)]
[Chromium] Add chromium-style tracing support
https://bugs.webkit.org/show_bug.cgi?id=76885

Patch by John Bates <jbates@google.com> on 2012-01-31
Reviewed by Darin Fisher.

This code enables WebKit trace events to pass through more data to the
chromium platform tracing API and generally to use the full tracing
API provided by chromium.

Source/WebCore:

* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluate): Replace old tracing API.
* page/Console.cpp:
(WebCore::Console::time): Replace old tracing API.
(WebCore::Console::timeEnd): Replace old tracing API.
* platform/chromium/PlatformSupport.h:
* platform/chromium/TraceEvent.h:
(WebCore::TraceEvent::TraceID::TraceID):
(WebCore::TraceEvent::TraceID::data):
(WebCore::TraceEvent::TraceStringWithCopy::TraceStringWithCopy):
(WebCore::TraceEvent::TraceStringWithCopy::operator const char* ):
(WebCore::TraceEvent::setTraceValue):
(WebCore::TraceEvent::addTraceEvent):
(WebCore::TraceEvent::TraceEndOnScopeClose::TraceEndOnScopeClose):
(WebCore::TraceEvent::TraceEndOnScopeClose::~TraceEndOnScopeClose):
(WebCore::TraceEvent::TraceEndOnScopeClose::initialize):
(WebCore::TraceEvent::TraceEndOnScopeClose::addEventIfEnabled):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::TraceEndOnScopeCloseThreshold):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::~TraceEndOnScopeCloseThreshold):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::initialize):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::addEventIfEnabled):

Source/WebKit/chromium:

* public/platform/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::getTraceCategoryEnabledFlag):
(WebKit::WebKitPlatformSupport::addTraceEvent):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::getTraceCategoryEnabledFlag):
(WebCore::PlatformSupport::addTraceEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd back temporarily WebKitPlatformSupport::createGraphicsContext3D() to fix build
piman@chromium.org [Tue, 31 Jan 2012 20:49:18 +0000 (20:49 +0000)]
Add back temporarily WebKitPlatformSupport::createGraphicsContext3D() to fix build
https://bugs.webkit.org/show_bug.cgi?id=77467

Rubber-stamped by Nate Chapin <japhet@chromium.org>.

* public/platform/WebKitPlatformSupport.h:
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::createGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Crash in DeleteSelectionCommand::handleGeneralDelete when attempting...
rniwa@webkit.org [Tue, 31 Jan 2012 20:41:05 +0000 (20:41 +0000)]
Source/WebCore: Crash in DeleteSelectionCommand::handleGeneralDelete when attempting to delete the start block
https://bugs.webkit.org/show_bug.cgi?id=77077

Reviewed by Enrica Casucci.

The crash was caused by a missing null check after removing the position out of the start block.
Fixed the bug by adding an early return.

Tests: editing/deleting/delete-start-block.html
       editing/selection/move-into-empty-root-inline-box.html

* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):

LayoutTests: Crash in previousLinePosition when moving into a root inline box without leaves
https://bugs.webkit.org/show_bug.cgi?id=76812

Reviewed by Enrica Casucci.

Add a regression test for the crash. Unfortunately, we can only test previousLinePosition.

* editing/selection/move-into-empty-root-inline-box-expected.txt: Added.
* editing/selection/move-into-empty-root-inline-box.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorunner.js in performance tests should define a class
rniwa@webkit.org [Tue, 31 Jan 2012 20:05:37 +0000 (20:05 +0000)]
runner.js in performance tests should define a class
https://bugs.webkit.org/show_bug.cgi?id=77074

Reviewed by Eric Seidel.

Wrap all functions in runner.js by PerfTestRunner and update tests that runner.js accordingly.
Also replace compute* functions in runner.js by more robust code from dom-perf.js.

* Bindings/event-target-wrapper.html:
* DOM/DOMTable.html:
* DOM/resources/dom-perf.js:
(BenchmarkSuite.prototype.RunSingle):
(runBenchmarkSuite):
* Mutation/append-child-deep.html:
* Mutation/append-child.html:
* Mutation/inner-html.html:
* Mutation/remove-child-deep.html:
* Mutation/remove-child.html:
* Parser/html-parser.html:
* Parser/html5-full-render.html:
* Parser/simple-url.html:
* Parser/tiny-innerHTML.html:
* Parser/url-parser.html:
* Parser/xml-parser.html:
* resources/runner.js:
(PerfTestRunner.log):
(PerfTestRunner.logInfo):
(PerfTestRunner.loadFile):
(PerfTestRunner.computeStatistics):
(PerfTestRunner.logStatistics):
(PerfTestRunner._runLoop.else):
(PerfTestRunner._runLoop):
(PerfTestRunner._runner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fix css3/flexbox/cross-axis-scrollbar-expected to work on
tony@chromium.org [Tue, 31 Jan 2012 20:05:29 +0000 (20:05 +0000)]
[chromium] Fix css3/flexbox/cross-axis-scrollbar-expected to work on
chromium win.

The scrollbars overflow the bounds of the scrollbar rect (see bug 77368).
Work around this by using positioned elements and setting the z-index as
negative.  It didn't work previously because when the scrollbar was
positioned, it clipped the extra pixels.  Tested to verify that this works
on Chromium Win and Chromium Linux.

Unreviewed, test fix.

* css3/flexbox/cross-axis-scrollbar-expected.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTMLIsIndexElement should not expose HTMLInputElement properties
eric@webkit.org [Tue, 31 Jan 2012 20:00:37 +0000 (20:00 +0000)]
HTMLIsIndexElement should not expose HTMLInputElement properties
https://bugs.webkit.org/show_bug.cgi?id=76095

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-31
Reviewed by Eric Seidel.

This is a buildfix for r106373.

* DerivedSources.pri: Removed reference to HTMLIsIndexElement.idl

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebGL must allocate smaller drawing buffer when the allocation fails.
commit-queue@webkit.org [Tue, 31 Jan 2012 20:00:09 +0000 (20:00 +0000)]
WebGL must allocate smaller drawing buffer when the allocation fails.
https://bugs.webkit.org/show_bug.cgi?id=76654

Patch by Yongsheng Zhu <yongsheng.zhu@intel.com> on 2012-01-31
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/drawingbuffer-test.html

* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago PluginProcess should be able to use remote open and save panels
ap@apple.com [Tue, 31 Jan 2012 19:58:07 +0000 (19:58 +0000)]
    PluginProcess should be able to use remote open and save panels
        https://bugs.webkit.org/show_bug.cgi?id=77461
        <rdar://problem/10783615>

        Reviewed by Mark Rowe.

        * PluginProcess/mac/PluginProcess.entitlements: Added.
        * PluginProcess/mac/add-entitlements.sh: Added.
        * WebKit2.xcodeproj/project.pbxproj:
        Add appropriate entitlement, plus ad hoc binary signing for it to work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTMLIsIndexElement should not expose HTMLInputElement properties
eric@webkit.org [Tue, 31 Jan 2012 19:33:22 +0000 (19:33 +0000)]
HTMLIsIndexElement should not expose HTMLInputElement properties
https://bugs.webkit.org/show_bug.cgi?id=76095

Reviewed by Adam Barth.

Source/WebCore:

document.createElement("isindex") should produce an HTMLUnknownElement
per the HTML5 spec.  The parser automagically translates <isindex> into
a whole dom tree roughly representing what <isindex> used to do 15 years ago. :)

This patch just removes our support for HTMLIsIndexElement.  The parser
support was already in.  Having support for HTMLIsIndexElement was causing
one of the IE TestCenter tests to fail.

Test: fast/dom/HTMLIsIndexElement/prototype-chain.html

* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.order:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/gobject/GNUmakefile.am:
* bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
(WebKit::createHTMLElementWrapper):
* bindings/objc/DOM.mm:
(WebCore::createElementClassMap):
* bindings/objc/DOMHTML.h:
* bindings/objc/PublicDOMInterfaces.h:
* html/HTMLElementsAllInOne.cpp:
* html/HTMLIsIndexElement.cpp: Removed.
* html/HTMLIsIndexElement.h: Removed.
* html/HTMLIsIndexElement.idl: Removed.
* html/HTMLTagNames.in:
* page/DOMWindow.idl:

Source/WebKit/mac:

* MigrateHeaders.make:

LayoutTests:

* fast/dom/HTMLIsIndexElement/prototype-chain-expected.txt: Added.
* fast/dom/HTMLIsIndexElement/prototype-chain.html: Added.
* fast/dom/HTMLIsIndexElement/script-tests/prototype-chain.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Use ICU if available
commit-queue@webkit.org [Tue, 31 Jan 2012 19:13:21 +0000 (19:13 +0000)]
[Qt] Use ICU if available
https://bugs.webkit.org/show_bug.cgi?id=76821

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-31
Reviewed by Csaba Osztrogon√°c.

After r105997, some tests had different expected results but they were passing
like /fast/text/find-{kana|russian|soft-hyphen}.html and editing/execCommand/findString-diacriticals.html.
The test editing/selection/regional-indicators.html had a false expected file,
and the rest was moved to a more specific folder (i.e. some bugs skipped on qt5 and qt-wk2
didn't need to be on qt-wk2 as well, etc.) and/or created specific bugs for further investigation.

* platform/qt-4.8/Skipped:
* platform/qt-4.8/css1/text_properties/text_transform-expected.txt: Copied from LayoutTests/platform/qt/css1/text_properties/text_transform-expected.txt.
* platform/qt-4.8/editing/selection/regional-indicators-expected.txt: Renamed from LayoutTests/platform/qt/editing/selection/regional-indicators-expected.txt.
* platform/qt-4.8/fast/text/find-kana-expected.txt: Renamed from LayoutTests/platform/qt/fast/text/find-kana-expected.txt.
* platform/qt-4.8/fast/text/find-russian-expected.txt: Renamed from LayoutTests/platform/qt/fast/text/find-russian-expected.txt.
* platform/qt-4.8/fast/text/find-soft-hyphen-expected.txt: Renamed from LayoutTests/platform/qt/fast/text/find-soft-hyphen-expected.txt.
* platform/qt-5.0/Skipped:
* platform/qt-5.0/css1/text_properties/text_transform-expected.txt: Renamed from LayoutTests/platform/qt/css1/text_properties/text_transform-expected.txt.
* platform/qt-5.0/editing/execCommand/findString-diacriticals-expected.txt: Added.
* platform/qt-wk2/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMerge WebGraphicsContext3D creation and initialization, and move it to
piman@chromium.org [Tue, 31 Jan 2012 19:11:54 +0000 (19:11 +0000)]
Merge WebGraphicsContext3D creation and initialization, and move it to
WebViewClient.
https://bugs.webkit.org/show_bug.cgi?id=76593

Reviewed by Darin Fisher.

Source/WebKit/chromium:

* public/WebViewClient.h:
(WebKit::WebViewClient::createGraphicsContext3D):
* public/platform/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::initialize):
* public/platform/WebKitPlatformSupport.h:
* src/GraphicsContext3DChromium.cpp:

Tools:

* DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::TestWebPlugin):
(TestWebPlugin::initialize):
* DumpRenderTree/chromium/TestWebPlugin.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createGraphicsContext3D):
(WebViewHost::createPlugin):
* DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoASSERT(m_jumpsToLink.isEmpty()) failing in ARMv7Assembler dtor
msaboff@apple.com [Tue, 31 Jan 2012 19:07:44 +0000 (19:07 +0000)]
ASSERT(m_jumpsToLink.isEmpty()) failing in ARMv7Assembler dtor
https://bugs.webkit.org/show_bug.cgi?id=77443

Reviewed by Gavin Barraclough.

Removed failing ASSERT() and thus destructor.  The ASSERT isn't needed.
We are hitting it in the YARR JIT case where we bail out and go to the
interpreter with a partially JIT'ed function.  Since we haven't linked
the JIT'ed code, there is likely to be some unresolved jumps in the vector
when the ARMv7Assembler destructor is called.  For the case where we
complete the JIT process, we clear the vector at the end of
LinkBuffer::linkCode (LinkBuffer.h:292).

* assembler/ARMv7Assembler.h:
(ARMv7Assembler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] build-webkit warning.
rgabor@webkit.org [Tue, 31 Jan 2012 19:00:21 +0000 (19:00 +0000)]
[GTK] build-webkit warning.
https://bugs.webkit.org/show_bug.cgi?id=77411

Reviewed by Philippe Normand.

* Scripts/webkitdirs.pm:
(isCrossCompilation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVector<T>::operator== shouldn't require T to have operator!=
andersca@apple.com [Tue, 31 Jan 2012 18:06:23 +0000 (18:06 +0000)]
Vector<T>::operator== shouldn't require T to have operator!=
https://bugs.webkit.org/show_bug.cgi?id=77448

Reviewed by Andreas Kling.

Change VectorComparer::compare to use !(a == b) instead of a != b since
it makes more sense for Vector::operator== to use the element's operator==.

* wtf/Vector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWhen generating derived sources, use the same compiler that is used to compile WebKit...
mitz@apple.com [Tue, 31 Jan 2012 17:39:34 +0000 (17:39 +0000)]
When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.

Reviewed by Anders Carlsson.

* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed include cleanup.
alexis.menard@openbossa.org [Tue, 31 Jan 2012 17:29:00 +0000 (17:29 +0000)]
Unreviewed include cleanup.

Tested locally on Qt and Chromium port.

* dom/Node.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIf the QTDIR environment variable is set, the build system fails to compile WinCairo
ossy@webkit.org [Tue, 31 Jan 2012 17:11:45 +0000 (17:11 +0000)]
If the QTDIR environment variable is set, the build system fails to compile WinCairo
https://bugs.webkit.org/show_bug.cgi?id=77112

Reviewed by Daniel Bates.

* Scripts/webkitdirs.pm:
(determineIsQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnsure tiles are repainted when scrolling using mouse wheel.
commit-queue@webkit.org [Tue, 31 Jan 2012 17:09:13 +0000 (17:09 +0000)]
Ensure tiles are repainted when scrolling using mouse wheel.
https://bugs.webkit.org/show_bug.cgi?id=77339

A new slot visibleContentRectAndScaleChanged has been added
that is emited by non-animated scrolling code in the
QtViewportInteractionEngine.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-01-31
Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initializeDesktop):
(QQuickWebViewPrivate::initializeTouch):
(QQuickWebViewPrivate::_q_resume):
(QQuickWebViewPrivate::_q_updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::updateTouchViewportSize):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::wheelEvent):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe spec renamed addTrack() to addTextTrack().
commit-queue@webkit.org [Tue, 31 Jan 2012 16:44:15 +0000 (16:44 +0000)]
The spec renamed addTrack() to addTextTrack().
https://bugs.webkit.org/show_bug.cgi?id=77381

Patch by Arko Saha <arko@motorola.com> on 2012-01-31
Reviewed by Eric Carlson.

Renamed addTrack() to addTextTrack().
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#media-elements

Source/WebCore:

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::addTextTrack):
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::addTextTrack):
* html/HTMLMediaElement.idl:

LayoutTests:

* media/track/track-add-track-expected.txt:
* media/track/track-add-track.html:
* media/track/track-addtrack-kind-expected.txt:
* media/track/track-addtrack-kind.html:
* media/track/track-text-track-destructor-crash.html:
* media/track/track-texttracks-expected.txt:
* media/track/track-texttracks.html:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: CodeGeneratorInspector.py: reimplement generated array types
vsevik@chromium.org [Tue, 31 Jan 2012 15:35:04 +0000 (15:35 +0000)]
Web Inspector: CodeGeneratorInspector.py: reimplement generated array types
https://bugs.webkit.org/show_bug.cgi?id=77289

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-31
Reviewed by Vsevolod Vlasov.

Arrays are now rendered as a single template class. Its type-specific
details are provided by an additional ArrayItemHelper class that is
defined using C++ specialization technique.

* inspector/CodeGeneratorInspector.py:
(RawTypes.String):
(RawTypes.String.get_array_item_raw_c_type_text):
(RawTypes.Int):
(RawTypes.Int.get_array_item_raw_c_type_text):
(RawTypes.Number):
(RawTypes.Number.get_array_item_raw_c_type_text):
(RawTypes.Bool):
(RawTypes.Bool.get_array_item_raw_c_type_text):
(RawTypes.Object):
(RawTypes.Object.get_array_item_raw_c_type_text):
(RawTypes.Any):
(RawTypes.Any.get_array_item_raw_c_type_text):
(RawTypes.Array):
(RawTypes.Array.get_array_item_raw_c_type_text):
(RawTypes):
(TypeBindings.create_type_declaration_.EnumBinding):
(TypeBindings.create_type_declaration_.EnumBinding.get_array_item_c_type_text):
(TypeBindings.create_type_declaration_.PlainString):
(TypeBindings.create_type_declaration_.PlainString.get_array_item_c_type_text):
(TypeBindings.create_type_declaration_.TypedefString):
(TypeBindings.create_type_declaration_.TypedefString.get_array_item_c_type_text):
(StructItemTraits):
(get_array_item_c_type_text):
(PlainObjectBinding):
(PlainObjectBinding.get_array_item_c_type_text):
(AdHocTypeContext):
(AdHocTypeContext.get_type_name_fix):
(AdHocTypeContext.add_type):
(ArrayBinding):
(ArrayBinding.resolve_inner):
(ArrayBinding.resolve_inner.ResolveData):
(ArrayBinding.request_user_runtime_cast):
(ArrayBinding.request_internal_runtime_cast):
(ArrayBinding.get_code_generator):
(ArrayBinding.get_code_generator.CodeGenerator):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_forward_declaration):
(ArrayBinding.get_code_generator.CodeGenerator.register_use):
(ArrayBinding.get_code_generator.CodeGenerator.get_generate_pass_id):
(ArrayBinding.get_validator_call_text):
(ArrayBinding.get_in_c_type_text):
(ArrayBinding.get_array_item_c_type_text):
(ArrayBinding.get_setter_value_expression_pattern):
(ArrayBinding.reduce_to_raw_type):
(RawTypeBinding.get_array_item_c_type_text):
(ArrayItemHelper):
(typename):
(ArrayOf):
(Traits):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOnly call -typingAttributes on WebViews, not WebHTMLViews
aroben@apple.com [Tue, 31 Jan 2012 15:09:33 +0000 (15:09 +0000)]
Only call -typingAttributes on WebViews, not WebHTMLViews

Looks like this case was just missed in r105908.

Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing

Reviewed by Antti Koivisto.

* TestWebKitAPI/Tests/mac/InspectorBar.mm:
(TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
earlier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoParent SVGFontFaceElements style declaration to the rule
antti@apple.com [Tue, 31 Jan 2012 14:58:37 +0000 (14:58 +0000)]
Parent SVGFontFaceElements style declaration to the rule
https://bugs.webkit.org/show_bug.cgi?id=77421

Reviewed by Adam Roben.

For some reason the declaration is parented to the element which adds a bunch of unnecessary special case code.
The invalidation on mutation is done explicitly by SVGFontFaceElement so that is not affected. The declaration
is not exposed so the change is not observable with a test.

* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::~CSSFontFaceRule):
* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::createInline):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
(WebCore::SVGFontFaceElement::parseMappedAttribute):
(WebCore::SVGFontFaceElement::fontFamily):
(WebCore::SVGFontFaceElement::rebuildFontFace):
* svg/SVGFontFaceElement.h:

    Remove the unnecessary m_styleDeclaration field, access through m_fontFaceRule instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTap highlighting: Support better outlines for multiline inlines https://bugs.webkit...
kenneth@webkit.org [Tue, 31 Jan 2012 14:28:13 +0000 (14:28 +0000)]
Tap highlighting: Support better outlines for multiline inlines https://bugs.webkit.org/show_bug.cgi?id=77428

Reviewed by Simon Hausmann.

.:

Update the test to use a transform.

* ManualTests/qt/tap-highlighting-inlines.html:

Source/WebCore:

Covered by manual tests.

Do not use the linesBoundingBox anymore but draw a custom path
with rounded corners. Inlines are drawn as max 3 rects, first
line rect, joined middle rect and the rect for the last line.

* page/GestureTapHighlighter.cpp:
* platform/graphics/Path.h: Make addBeziersForRoundedRect public.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
jocelyn.turcotte@nokia.com [Tue, 31 Jan 2012 14:03:35 +0000 (14:03 +0000)]
[Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
https://bugs.webkit.org/show_bug.cgi?id=77221

Reviewed by Kenneth Rohde Christiansen.

This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::sendTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106356 268f45cc-cd09-0410-ab3c-d52691b4dbfc