WebKit-https.git
8 years agoAdd UA string tags for Windows 64.
pkasting@chromium.org [Thu, 10 Mar 2011 06:31:32 +0000 (06:31 +0000)]
Add UA string tags for Windows 64.
https://bugs.webkit.org/show_bug.cgi?id=55226

Reviewed by Ryosuke Niwa.

* StringsNotToBeLocalized.txt:
* platform/win/SystemInfo.cpp:
(WebCore::osVersionForUAString):
(WebCore::isWOW64):
(WebCore::processorArchitecture):
(WebCore::architectureTokenForUAString):
(WebCore::windowsVersionForUAString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Thu, 10 Mar 2011 06:15:13 +0000 (06:15 +0000)]
2011-03-09  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: tweaking of Chromium test_expectations.txt

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Thu, 10 Mar 2011 05:38:47 +0000 (05:38 +0000)]
2011-03-09  Daniel Bates  <dbates@rim.com>

        Attempt to fix the WinCE build after changeset 80684 <http://trac.webkit.org/changeset/80684>
        (Bug #56041<https://bugs.webkit.org/show_bug.cgi?id=56041>).

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute): Substitute variable callFrame for exec in call to createSyntaxError().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, attempted build fix.
pkasting@chromium.org [Thu, 10 Mar 2011 04:50:57 +0000 (04:50 +0000)]
Unreviewed, attempted build fix.

* WebCore.pri: Try to update include path for Qt Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, build fix.
pkasting@chromium.org [Thu, 10 Mar 2011 04:24:34 +0000 (04:24 +0000)]
Unreviewed, build fix.

* platform/win/SystemInfo.cpp:
(WebCore::windowsVersionForUAString): Fix const conversion warning on Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnify Windows version checks.
pkasting@chromium.org [Thu, 10 Mar 2011 04:19:56 +0000 (04:19 +0000)]
Unify Windows version checks.
https://bugs.webkit.org/show_bug.cgi?id=55979

Reviewed by Mihai Parparita.

Source/WebCore:

* GNUmakefile.am: Fix spaces -> tabs.
* StringsNotToBeLocalized.txt:
* WebCore.pro: Add SystemInfo.* to Qt build.
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
(WebCore::ScrollbarThemeChromiumWin::getThemeState):
(WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
* platform/win/CursorWin.cpp:
(WebCore::createSharedCursor):
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::ScrollbarThemeWin):
* platform/win/SystemInfo.cpp: Add full-fledged version check and UA string helper function.
(WebCore::windowsVersion):
(WebCore::windowsVersionForUAString):
* platform/win/SystemInfo.h: Add full-fledged version check and UA string helper function.
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::getNonClientMetrics):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::getThemeData):
(WebCore::RenderThemeWin::paintMenuList):
(WebCore::RenderThemeWin::paintMenuListButton):

Source/WebKit/gtk:

* webkit/webkitwebsettings.cpp:
(webkitOSVersion):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::userAgentForUrl):

Source/WebKit/win:

* WebView.cpp:
(WebView::standardUserAgentWithApplicationName):
(webKitVersionString):

Source/WebKit2:

* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::standardUserAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 10 Mar 2011 03:30:57 +0000 (03:30 +0000)]
2011-03-09  Mihai Parparita  <mihaip@chromium.org>

        JSC now implements Object.freeze/seal (as of r80378) and correct
        expectations have been checked in, therefore we now pass more
        ietestcenter tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 10 Mar 2011 02:55:02 +0000 (02:55 +0000)]
2011-03-09  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Gentilcore.

        REGRESSION (r74807): memory corruption after CachedResourceLoader refactoring
        https://bugs.webkit.org/show_bug.cgi?id=53045

        Copy the URL out of the CachedResource that is being revalidated, so
        that we can still use it (in m_validatedURLs) after removing the
        resource from the memory cache, which may delete it.

        No new tests, since I was not able to trigger this locally (in a layout
        test or otherwise).

        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::revalidateResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVO reporting incorrect list count for http://www.macworld.com/news.html
cfleizach@apple.com [Thu, 10 Mar 2011 02:23:58 +0000 (02:23 +0000)]
VO reporting incorrect list count for macworld.com/news.html
https://bugs.webkit.org/show_bug.cgi?id=56064

Reviewed by Beth Dakin.

Source/WebCore:

<li> tags should not be ignored, because they provide valuable information
to screen readers.

Test: platform/mac/accessibility/list-items-ignored.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests:

* platform/mac/accessibility/list-items-ignored-expected.txt: Added.
* platform/mac/accessibility/list-items-ignored.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBug 56041 - RexExp constructor should only accept flags "gim"
barraclough@apple.com [Thu, 10 Mar 2011 02:22:50 +0000 (02:22 +0000)]
Bug 56041 - RexExp constructor should only accept flags "gim"
Fix for issues introduced in r80667.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Invalid flags to a RegExp literal are a late syntax error!

* bytecode/CodeBlock.h:
(JSC::CodeBlock::addRegExp):
    - Pass a PassRefPtr<RegExp>
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addRegExp):
(JSC::BytecodeGenerator::emitNewRegExp):
* bytecompiler/BytecodeGenerator.h:
    - Pass a PassRefPtr<RegExp>
* bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
    - Should not be ASSERTing that the flags are valid - this is a late(er) error.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
    - Need to check for error from RegExp constructor.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
    - Need to check for error from RegExp constructor.
* runtime/RegExp.h:
(JSC::RegExp::isValid):
    - Make isValid check that the regexp was created with valid flags.
* runtime/RegExpKey.h:
    - Since we'll not create RegExp objects with invalid flags, separate out the deleted value.

LayoutTests:

* fast/regex/script-tests/parentheses.js:
* fast/regex/script-tests/pcre-test-1.js:
    - Providing invalid flags to RegExp literals is an error in ES5.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=56068
adele@apple.com [Thu, 10 Mar 2011 02:21:53 +0000 (02:21 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=56068
<rdar://problem/9058245> WebKit2: Can't uncheck 'Spelling and Grammar' contextual items

Reviewed by Anders Carlsson.

* UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::contextMenuItemSelected):
Add cases for ContextMenuItemTagCorrectSpellingAutomatically, ContextMenuItemTagCheckSpellingWhileTyping,
and ContextMenuItemTagCheckGrammarWithSpelling

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: <rdar://problem/8733254> Float disappears after incremental layout
mitz@apple.com [Thu, 10 Mar 2011 01:56:27 +0000 (01:56 +0000)]
Source/WebCore: <rdar://problem/8733254> Float disappears after incremental layout
Fixed the original bug and a copule more issues noticed while doing so.

Reviewed by Dave Hyatt.

Tests: fast/dynamic/dirty-float-in-clean-line.html
       fast/dynamic/float-at-line-break.html
       fast/dynamic/float-from-empty-line.html

* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): If findNextLineBreak() returned an empty line,
update the line break info of the last line with the new line break position. This is tested
by float-from-empty-line.html.
(WebCore::RenderBlock::checkFloatsInCleanLine): Factored out code from determineStartPosition()
into this new function.
(WebCore::RenderBlock::determineStartPosition): Call checkFloatsInCleanLine().
(WebCore::RenderBlock::determineEndPosition): When iterating over lines, check clean lines with
floats, as they may yet become dirty because of the floats. This is tested by
dirty-float-in-clean-line.html.
(WebCore::RenderBlock::findNextLineBreak): If a float fits on the line, and the current line
break is at the float, advance it to after the float. Otherwise, if the line gets dirty and the
next one does not, the float will not make it into any line. This is tested by
float-at-line-break.html.

LayoutTests: <rdar://problem/8733254> Float disappears after incremental layout

Reviewed by Dave Hyatt.

* fast/dynamic/dirty-float-in-clean-line-expected.checksum: Added.
* fast/dynamic/dirty-float-in-clean-line-expected.png: Added.
* fast/dynamic/dirty-float-in-clean-line-expected.txt: Added.
* fast/dynamic/dirty-float-in-clean-line.html: Added.
* fast/dynamic/float-at-line-break-expected.checksum: Added.
* fast/dynamic/float-at-line-break-expected.png: Added.
* fast/dynamic/float-at-line-break-expected.txt: Added.
* fast/dynamic/float-at-line-break.html: Added.
* fast/dynamic/float-from-empty-line-expected.checksum: Added.
* fast/dynamic/float-from-empty-line-expected.png: Added.
* fast/dynamic/float-from-empty-line-expected.txt: Added.
* fast/dynamic/float-from-empty-line.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 10 Mar 2011 01:46:41 +0000 (01:46 +0000)]
2011-03-09  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        selectionStart reports wrong caret position when the last characters are newlines
        https://bugs.webkit.org/show_bug.cgi?id=56061

        The bug was caused by SelectionController::setSelection's not calling
        notifyRendererOfSelectionChange when old selection was equal to new selection.

        Because InsertLineBreakCommand inserts a text node with a single LF before the caret,
        this condition holds after the command is executed. However, the values of
        selectionStart and selectionEnd still need to be updated in this case because
        the offsets counted from the beginning of textarea have been increased by 1.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection): Call notifyRendererOfSelectionChange
        when m_selection = s.
        * manual-tests/selection-start-after-inserting-line-break-in-textarea.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 10 Mar 2011 01:21:58 +0000 (01:21 +0000)]
2011-03-09  Martin Robinson  <mrobinson@igalia.com>

        Add some new GTK+ test results.

        * platform/gtk/fast/blockflow/text-orientation-basic-expected.checksum: Added.
        * platform/gtk/fast/blockflow/text-orientation-basic-expected.png: Added.
        * platform/gtk/fast/blockflow/text-orientation-basic-expected.txt: Added.
        * platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
        * platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
        * platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
        * platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
        * platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
        * platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 10 Mar 2011 00:49:50 +0000 (00:49 +0000)]
2011-03-09  Tony Chang  <tony@chromium.org>

        Unreviewed, third and final set of baselines for chromium linux lucid x86_64.
        These are small rounding differences.
        https://bugs.webkit.org/show_bug.cgi?id=55527

        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-12-t-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
        * platform/chromium-linux-x86_64/svg/hixie/perf/001-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/hixie/perf/001-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/hixie/perf/001-expected.txt: Added.
        * platform/chromium-linux-x86_64/svg/hixie/perf/002-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/hixie/perf/002-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/hixie/perf/002-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 10 Mar 2011 00:43:25 +0000 (00:43 +0000)]
2011-03-09  Tony Chang  <tony@chromium.org>

        Unreviewed, land a second set of baselines for chromium linux lucid x86_64.
        These are differences due to a newer freetype and a few rounding
        differences in gradients.
        https://bugs.webkit.org/show_bug.cgi?id=55527

        * platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.checksum: Added.
        * platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.png: Added.
        * platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.checksum: Added.
        * platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.png: Added.
        * platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.checksum: Added.
        * platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.png: Added.
        * platform/chromium-linux-x86_64/fast/images/animated-svg-as-image-expected.checksum: Added.
        * platform/chromium-linux-x86_64/fast/images/animated-svg-as-image-expected.png: Added.
        * platform/chromium-linux-x86_64/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
        * platform/chromium-linux-x86_64/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
        * platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.checksum: Added.
        * platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/text-text-01-b-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/batik/text/textFeatures-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/batik/text/textFeatures-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/batik/text/textLayout-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/batik/text/textLayout-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-and-object-creation-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-creation-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-creation-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/custom/js-late-gradient-creation-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/custom/js-late-gradient-creation-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/custom/js-late-pattern-creation-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/custom/js-late-pattern-creation-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/custom/svg-curve-with-relative-cordinates-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png: Added.
        * platform/chromium-linux-x86_64/svg/text/text-text-01-b-expected.checksum: Added.
        * platform/chromium-linux-x86_64/svg/text/text-text-01-b-expected.png: Added.
        * platform/chromium-linux-x86_64/transforms/2d/transform-borderbox-expected.checksum: Added.
        * platform/chromium-linux-x86_64/transforms/2d/transform-borderbox-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Reviewed by Dan Bernstein.
ap@apple.com [Thu, 10 Mar 2011 00:39:12 +0000 (00:39 +0000)]
    Reviewed by Dan Bernstein.

        Frequent crashes when printing in WebPageProxy::setAutodisplay
        https://bugs.webkit.org/show_bug.cgi?id=56057
        <rdar://problem/9053290>

        * UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _delayedResumeAutodisplayTimerFired]):
        Null check the page, there is no reason for it to still exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows build fix part 2.
barraclough@apple.com [Thu, 10 Mar 2011 00:29:32 +0000 (00:29 +0000)]
Windows build fix part 2.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 10 Mar 2011 00:29:03 +0000 (00:29 +0000)]
2011-03-09  Tony Chang  <tony@chromium.org>

        Unreviewed, first set of baselines for chromium linux lucid x86_64.
        These are just small rounding differences.
        https://bugs.webkit.org/show_bug.cgi?id=55527

        * platform/chromium-linux-x86_64/fast/repaint/moving-shadow-on-container-expected.txt: Added.
        * platform/chromium-linux-x86_64/fast/repaint/moving-shadow-on-path-expected.txt: Added.
        * platform/chromium-linux-x86_64/svg/css/composite-shadow-example-expected.txt: Added.
        * platform/chromium-linux-x86_64/svg/css/composite-shadow-with-opacity-expected.txt: Added.
        * platform/chromium-linux-x86_64/svg/css/stars-with-shadow-expected.txt: Added.
        * platform/chromium-linux-x86_64/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Andy Estes <aestes@apple.com>
inferno@chromium.org [Thu, 10 Mar 2011 00:18:08 +0000 (00:18 +0000)]
2011-03-09  Andy Estes  <aestes@apple.com>

        Reviewed by Adam Barth.

        Bad cast in HTMLTreeBuilder::processStartTag
        https://bugs.webkit.org/show_bug.cgi?id=55955

        * fast/parser/self-closing-foreign-content-expected.txt: Added.
        * fast/parser/self-closing-foreign-content.html: Added.
2011-03-09  Andy Estes  <aestes@apple.com>

        Reviewed by Adam Barth.

        Bad cast in HTMLTreeBuilder::processStartTag
        https://bugs.webkit.org/show_bug.cgi?id=55955

        Test: fast/parser/self-closing-foreign-content.html

        When the parser encounters an svg or mathml root element, it places the
        insertion mode into InForeignContentMode. However, if the root element
        is self-closing (e.g. <svg />) then the element is never placed on the
        open elements stack. This leaves the parser in an inconsistent state
        where it is in InForeignContentMode but no foreign content is in the
        open element stack.

        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTagForInBody): If a self-closing
        foreign element is inserted into the tree, do not set the insertion
        mode to InForeignContentMode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows build fix part 1.
barraclough@apple.com [Thu, 10 Mar 2011 00:17:47 +0000 (00:17 +0000)]
Windows build fix part 1.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Thu, 10 Mar 2011 00:16:07 +0000 (00:16 +0000)]
2011-03-09  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Mihai Parparita.

        Fix some potentially flaky tests
        https://bugs.webkit.org/show_bug.cgi?id=56049

        These tests were not resilient to parser yields for reasons explained below.

        * media/video-src-plus-source.html: loadstart or loadmetadata could have fired before
        the waitForEvent() calls. So define them prior to the <video> element.
        * platform/mac/accessibility/aria-expanded-notifications.html: The aria events could
        have fired before successfullyParsed was set, so run the test in the onload handler.
        * plugins/npruntime/npruntime.html: The plugin could have been loaded before
        successfullyParsed was set, so set it before including the plugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoQt build fix.
barraclough@apple.com [Thu, 10 Mar 2011 00:15:39 +0000 (00:15 +0000)]
Qt build fix.

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Andy Estes <aestes@apple.com>
aestes@apple.com [Thu, 10 Mar 2011 00:03:38 +0000 (00:03 +0000)]
2011-03-09  Andy Estes  <aestes@apple.com>

        Reviewed by Adam Barth.

        REGRESSION (r80320): Assertion failure when processing mis-nested foreign content.
        https://bugs.webkit.org/show_bug.cgi?id=55982

        * fast/parser/fragment-foreign-content-misnested-expected.txt: Added.
        * fast/parser/fragment-foreign-content-misnested.html: Added.
2011-03-09  Andy Estes  <aestes@apple.com>

        Reviewed by Adam Barth.

        REGRESSION (r80320): Assertion failure when processing mis-nested foreign content.
        https://bugs.webkit.org/show_bug.cgi?id=55982

        Test: fast/parser/fragment-foreign-content-misnested.html

        It is a parse error to encounter certain start tags while the parser's
        insertion mode is InForeignContentMode (e.g. <br>). In these cases, we
        are to pop open elements off the HTMLElementStack until a foreign
        content scope marker is encountered. Before the change in r80320 to not
        insert a fake HTML element during fragment parsing, said fake HTML
        element counted as a foreign content scope marker.

        With r80320, no fake HTML element is inserted and the stack is popped
        until empty in cases where no other element claims to be a foreign
        content scope marker. Fix this by treating the DocumentFragment as a
        foreign content scope marker.

        * html/parser/HTMLElementStack.cpp:
        (WebCore::HTMLNames::isForeignContentScopeMarker): Take a
        ContainerNode* instead of a Element*.
        (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker): Pass
        topNode() to isForeignContentScopeMarker() instead of top().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBug 56041 - RexExp constructor should only accept flags "gim"
barraclough@apple.com [Wed, 9 Mar 2011 23:04:27 +0000 (23:04 +0000)]
Bug 56041 - RexExp constructor should only accept flags "gim"
We also should be passing the flags around as a bitfield rather than a string,
and should not have redundant, incompatible code for converting the string to a bitfield!

Reviewed by Darin Adler.

Source/JavaScriptCore:

* JavaScriptCore.exp:
* bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
    - Need to parse flags string to enum.
* runtime/RegExp.cpp:
(JSC::regExpFlags):
(JSC::RegExp::RegExp):
(JSC::RegExp::create):
    - Add method to parse flags string to enum, change constructor/create args to take enum.
* runtime/RegExp.h:
(JSC::RegExp::global):
(JSC::RegExp::ignoreCase):
(JSC::RegExp::multiline):
    - Change to use new enum values.
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):
* runtime/RegExpCache.h:
    - Changed to use regExpFlags enum instead of int/const UString&.
* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
    - Add use new enum parsing, check for error.
* runtime/RegExpKey.h:
(JSC::RegExpKey::RegExpKey):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
    - Pass NoFlags value instead of empty string.
(JSC::regExpProtoFuncCompile):
    - Add use new enum parsing, check for error.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
    - Pass NoFlags value instead of empty string.

Source/WebCore:

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readTerminal):
    - Need to parse flags string back to enum.

LayoutTests:

* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T2-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T4-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T5-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T6-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T7-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T8-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T9-expected.txt:
    - Check in passing results!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 9 Mar 2011 22:46:49 +0000 (22:46 +0000)]
2011-03-09  Martin Robinson  <mrobinson@igalia.com>

        jquery/manipulation.html fails after r80598
        https://bugs.webkit.org/show_bug.cgi?id=56019

        Skip jquery test failing on the GTK+ debug bots. Move another
        failing test to the appropriate section.

        * platform/gtk/Skipped: Update skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 9 Mar 2011 22:27:43 +0000 (22:27 +0000)]
2011-03-09  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium]: Regression - Explicitly copy compositing properties from LayerChromium to CCLayerImpl
        https://bugs.webkit.org/show_bug.cgi?id=56021

        Adds a test for basic functionality of the backface-visibility
        property.

        * compositing/backface-visibility-expected.checksum: Added.
        * compositing/backface-visibility-expected.png: Added.
        * compositing/backface-visibility-expected.txt: Added.
        * compositing/backface-visibility.html: Added.
2011-03-09  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium]: Regression - Explicitly copy compositing properties from LayerChromium to CCLayerImpl
        https://bugs.webkit.org/show_bug.cgi?id=56021

        Initializes the m_doubleSided flag of LayerChromiums to the default
        value of true so the back sides of layers without
        backface-visibility:hidden are rendered.

        Test: compositing/backface-visibility.html

        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::LayerChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRestore lists layout test to its pre-text-orientation patch results now that ex units...
hyatt@apple.com [Wed, 9 Mar 2011 22:22:05 +0000 (22:22 +0000)]
Restore lists layout test to its pre-text-orientation patch results now that ex units are fixed for vertical text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Andrei Popescu <andreip@google.com>
andreip@google.com [Wed, 9 Mar 2011 22:21:00 +0000 (22:21 +0000)]
2011-03-09  Andrei Popescu  <andreip@google.com>

        Unreviewed, build fix.

        [Chromium] test_expectations.txt needs updating to expect crashes in tests
        that trigger the assertion in FontCache::releaseFontData.
        https://bugs.webkit.org/show_bug.cgi?id=56051

        We have started seeing an assertion failure in FontCache.cpp:310 after r80582.
        It is unclear whether r80582 caused the assertion or whether the problem was
        already present at r80582 just made it manifest itself more often. Update the
        test_expectations.txt file while we're investigating.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9110316> REGRESSION: 'ex' unit broken for vertical text
hyatt@apple.com [Wed, 9 Mar 2011 22:20:34 +0000 (22:20 +0000)]
<rdar://problem/9110316> REGRESSION: 'ex' unit broken for vertical text

Reviewed by Dan Bernstein.

Fall back to the verticalRightOrientation data when obtaining the x-height for vertically oriented
text. That way we use the same metrics as for horizontal.

This fixes regressions in fast/lists and fast/overflow vertical text tests.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformBoundsForGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build correction.
bfulgham@webkit.org [Wed, 9 Mar 2011 22:07:16 +0000 (22:07 +0000)]
Unreviewed build correction.

* UIProcess/DrawingAreaProxy.messages.in: Exclude the other
  method using LayerTreeContext for non-accelerated composition case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 9 Mar 2011 21:47:30 +0000 (21:47 +0000)]
2011-03-09  Xiaomei Ji  <xji@chromium.org>

        Unreviewed.

        Rebaseline after r80622.

        * platform/chromium-linux/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
        * platform/chromium-linux/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
        * platform/chromium-linux/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
        * platform/chromium-linux/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
        * platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
        * platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
        * platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
        * platform/chromium-mac/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
        * platform/chromium-win/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
        * platform/chromium-win/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
        * platform/chromium-win/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
        * platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
        * platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
        * platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 9 Mar 2011 21:18:58 +0000 (21:18 +0000)]
2011-03-09  Abhishek Arya  <inferno@chromium.org>

        Unreviewed. Rebaselining after text orientation change in r80582.

        * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 9 Mar 2011 20:25:24 +0000 (20:25 +0000)]
2011-03-09  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        REGRESSION: crash in nextLinePosition when extending selection forward by line in an empty document
        https://bugs.webkit.org/show_bug.cgi?id=56004

        Added a regression test.

        * editing/selection/extend-by-line-in-empty-document-expected.txt: Added.
        * editing/selection/extend-by-line-in-empty-document.html: Added.
2011-03-09  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        REGRESSION: crash in nextLinePosition when extending selection forward by line in an empty document
        https://bugs.webkit.org/show_bug.cgi?id=56004

        The crash was caused by the false assumption that rootEditableElement() or documentElement()
        always return non-null pointer. Fixed the bug by adding an early exit.

        Test: editing/selection/extend-by-line-in-empty-document.html

        * editing/visible_units.cpp:
        (WebCore::previousLinePosition):
        (WebCore::nextLinePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHide Leaks Viewer's URL prompt by default
aroben@apple.com [Wed, 9 Mar 2011 19:49:16 +0000 (19:49 +0000)]
Hide Leaks Viewer's URL prompt by default

We will show it as needed. I think I left it visible by default by accident after doing some
testing.

Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
URL is passed as a query parameter, but does

Reviewed by Simon Fraser.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't use Element.classList or box-shadow in Leaks Viewer
aroben@apple.com [Wed, 9 Mar 2011 19:42:12 +0000 (19:42 +0000)]
Don't use Element.classList or box-shadow in Leaks Viewer

They aren't supported by Safari 5. Luckily we have substitutes for them!

Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5

Reviewed by Simon Fraser.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
(#url-prompt): Use -webkit-box-shadow instead of box-shadow.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer.urlPromptButtonClicked):
(LeaksViewer._displayURLPrompt):
(LeaksViewer._setLoadingIndicatorHidden):
Use add/removeStyleClass (from utilities.js) instead of Element.classList.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 9 Mar 2011 19:21:30 +0000 (19:21 +0000)]
2011-03-09  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: it should be possible to copy stack trace from call stack sidebar pane.
        https://bugs.webkit.org/show_bug.cgi?id=56024

        * English.lproj/localizedStrings.js:
        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane):
        (WebInspector.CallStackSidebarPane.prototype.update):
        (WebInspector.CallStackSidebarPane.prototype._contextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPatch FontPlatformDataLinux to properly initialize and copy orientation/text-orientat...
hyatt@apple.com [Wed, 9 Mar 2011 19:17:44 +0000 (19:17 +0000)]
Patch FontPlatformDataLinux to properly initialize and copy orientation/text-orientation in all
places.  Make sure text-orientation is specified in the lookups/creation in FontCustomPlatformData
and FontCache.

Reviewed by Darin Adler.

* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/chromium/FontPlatformDataLinux.h:
(WebCore::FontPlatformData::FontPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Steve Block <steveblock@google.com>
steveblock@google.com [Wed, 9 Mar 2011 19:14:12 +0000 (19:14 +0000)]
2011-03-09  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        JavaNPObject should not use JNI directly
        https://bugs.webkit.org/show_bug.cgi?id=56009

        We move the JNI code to access a Java object's fields into
        a new JavaInstance::getField() method.

        No new tests, refactoring only.

        * bridge/jni/v8/JavaInstanceV8.cpp:
        (JavaInstance::getField):
        * bridge/jni/v8/JavaInstanceV8.h:
        * bridge/jni/v8/JavaNPObjectV8.cpp:
        (JSC::Bindings::JavaNPObjectGetProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a link to the Leaks Viewer tool on the build.webkit.org homepage
aroben@apple.com [Wed, 9 Mar 2011 18:55:08 +0000 (18:55 +0000)]
Add a link to the Leaks Viewer tool on the build.webkit.org homepage

Rubber-stamped by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/templates/root.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a Leaks Viewer tool to build.webkit.org
aroben@apple.com [Wed, 9 Mar 2011 18:50:39 +0000 (18:50 +0000)]
Add a Leaks Viewer tool to build.webkit.org

This tool parses leaks from the files generated by the leaks bot and displays them in a
view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
code).

The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
be passed to the tool via the "url" query parameter.

Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
Inspector's Heavy profile view. But it's still pretty useful as-is.

Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots

Reviewed by Darin Adler.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
(#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
(#url-prompt): This is the prompt itself.

(#loading-indicator):
(#loading-indicator > img):
These show a spinner in the bottom-right when we're loading a leaks file.

(.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
as percentages.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
(LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
URL if one wasn't given to us as a query parameter).

(LeaksViewer.get loading):
(LeaksViewer.set loading):
(LeaksViewer.get url):
(LeaksViewer.set url):
Pretty simple accessors.

(LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
prompt.
(LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
(LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
the profile to the Web Inspector code once it's been created.
(LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
(LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
(LeaksViewer._updateTitle): Set our title based on our URL and loading status.
(getResource): Helper function to fetch a resource via XHR and pass it to a callback.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
(WebInspector.UIString): Just a simple implementation since this tool isn't localized.
(ProfilerAgent.getProfile): Store the callback.
(ProfilerAgent.profileReady): Call the callback.
(monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
count and total leak counts as real values, not percentages or milliseconds.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
(onmessage): Create a profile based on the leaks file and pass it back to our caller.
(parseLeaks): Extract call stacks out of a leaks file.
(createNode): Helper function to create a new empty profile node.
(createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
WebInspector.ProfileView.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate expected results of svg/css/getComputedStyle-basic after r80582.
bweinstein@apple.com [Wed, 9 Mar 2011 18:24:32 +0000 (18:24 +0000)]
Update expected results of svg/css/getComputedStyle-basic after r80582.

* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 9 Mar 2011 18:21:10 +0000 (18:21 +0000)]
2011-03-09  Mihai Parparita  <mihaip@chromium.org>

        Update chromium-gpu expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate lists vertical tests after text-orientation landing.
hyatt@apple.com [Wed, 9 Mar 2011 18:19:42 +0000 (18:19 +0000)]
Update lists vertical tests after text-orientation landing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Steve Block <steveblock@google.com>
steveblock@google.com [Wed, 9 Mar 2011 18:17:17 +0000 (18:17 +0000)]
2011-03-09  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        NPAPI - jvalue conversion should not be in JavaInstance
        https://bugs.webkit.org/show_bug.cgi?id=55967

        No new tests, refactoring only.

        * bridge/jni/v8/JavaInstanceV8.cpp:
        (JavaInstance::invokeMethod):
        * bridge/jni/v8/JavaInstanceV8.h:
        * bridge/jni/v8/JavaNPObjectV8.cpp:
        (JSC::Bindings::JavaNPObjectInvoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange plugins to use their own executable on Mac OS X
weinig@apple.com [Wed, 9 Mar 2011 18:06:10 +0000 (18:06 +0000)]
Change plugins to use their own executable on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=55991

Reviewed by Anders Carlsson.

* Configurations/PluginProcess.xcconfig: Copied from Source/WebKit2/Configurations/WebProcess.xcconfig.
* PluginProcess/Info.plist: Copied from Source/WebKit2/WebProcess/Info.plist.
Add files necessary for adding PluginProcess.app.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
Launch the PluginProcess.app when launching a plugin process.

* WebKit2.xcodeproj/project.pbxproj:
Add new executable and new files, removes some unneeded copying
and duplicate compiling of files.

* WebProcess/Info.plist:
Sorted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate expected results of computed-style and computed-style-without-renderer after
bweinstein@apple.com [Wed, 9 Mar 2011 18:03:14 +0000 (18:03 +0000)]
Update expected results of computed-style and computed-style-without-renderer after
r80582.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ossy@webkit.org [Wed, 9 Mar 2011 17:47:15 +0000 (17:47 +0000)]
Unreviewed.

jquery/manipulation.html fails after r80598
https://bugs.webkit.org/show_bug.cgi?id=56019

* platform/qt/Skipped:Add jquery tests to make buildbots happier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse the Cookie Storage from the Private Browsing Storage Session directly
jberlin@webkit.org [Wed, 9 Mar 2011 16:41:43 +0000 (16:41 +0000)]
Use the Cookie Storage from the Private Browsing Storage Session directly
https://bugs.webkit.org/show_bug.cgi?id=55986

Reviewed by Adam Roben.

Source/WebCore:

* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

* platform/network/mac/CookieStorageMac.mm:
(WebCore::setCookieStoragePrivateBrowsingEnabled):
Just copy the cookie storage from the private browsing storage session.
* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::setCookieStoragePrivateBrowsingEnabled):
Ditto.

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

WebKitLibraries:

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCombine multiple --ignore-tests values
mitz@apple.com [Wed, 9 Mar 2011 16:15:33 +0000 (16:15 +0000)]
Combine multiple --ignore-tests values
https://bugs.webkit.org/show_bug.cgi?id=56016

Reviewed by Adam Roben.

* Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 9 Mar 2011 14:49:49 +0000 (14:49 +0000)]
2011-03-09  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Fixed a crash in InspectorInstrumentation::didReceiveResponse() when loader is null (broken in r80639)

        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 9 Mar 2011 14:02:55 +0000 (14:02 +0000)]
2011-03-09  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: pass explicit agent references to InspectorBackendDispatcher
        https://bugs.webkit.org/show_bug.cgi?id=55820

        * http/tests/inspector-enabled/open-close-open-expected.txt:
        * http/tests/inspector-enabled/open-close-open.html:
        * http/tests/inspector/inspector-test.js:
        ():
2011-03-09  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: pass explicit agent references to InspectorBackendDispatcher
        https://bugs.webkit.org/show_bug.cgi?id=55820

        * inspector/CodeGeneratorInspector.pm:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::disconnectFrontend):
        (WebCore::InspectorController::dispatchMessageFromFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 9 Mar 2011 13:40:08 +0000 (13:40 +0000)]
2011-03-09  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: resource errors are not reported before front-end is opened
        https://bugs.webkit.org/show_bug.cgi?id=55939

        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::didReceiveResourceResponse):
        (WebCore::InspectorInstrumentation::didFailLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 9 Mar 2011 13:34:37 +0000 (13:34 +0000)]
2011-03-09  Alejandro G. Castro  <alex@igalia.com>

        Fix compilation after r80596, add soup Download stubs.

        * GNUmakefile.am:
        * WebProcess/Downloads/soup/DownloadSoup.cpp: Added.
        (WebKit::Download::start):
        (WebKit::Download::startWithHandle):
        (WebKit::Download::cancel):
        (WebKit::Download::platformInvalidate):
        (WebKit::Download::didDecideDestination):
        (WebKit::Download::platformDidFinish):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 9 Mar 2011 13:32:34 +0000 (13:32 +0000)]
2011-03-09  Alejandro G. Castro  <alex@igalia.com>

        Fix GTK+ compilation after r80619. Add WebFullScreenManager.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 9 Mar 2011 13:05:35 +0000 (13:05 +0000)]
2011-03-09  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: assign bug entries to Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Wed, 9 Mar 2011 12:05:48 +0000 (12:05 +0000)]
2011-03-08  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Add BackingStoreType parameter to IDBFactoryBackendInterface::open
        https://bugs.webkit.org/show_bug.cgi?id=55948

        Add a parameter that allows for selection of alternative backing store
        implementations.

        No new tests: no new functionality.

        * storage/IDBFactory.cpp:
        (WebCore::IDBFactory::open):
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::IDBFactoryBackendImpl::open):
        * storage/IDBFactoryBackendImpl.h:
        * storage/IDBFactoryBackendInterface.h:
2011-03-08  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Add BackingStoreType parameter to IDBFactoryBackendInterface::open
        https://bugs.webkit.org/show_bug.cgi?id=55948

        Add a parameter that allows for selection of alternative backing store
        implementations.

        * public/WebIDBFactory.h:
        (WebKit::WebIDBFactory::open):
        * src/AssertMatchingEnums.cpp:
        * src/IDBFactoryBackendProxy.cpp:
        (WebCore::IDBFactoryBackendProxy::open):
        * src/IDBFactoryBackendProxy.h:
        * src/WebIDBFactoryImpl.cpp:
        (WebKit::WebIDBFactoryImpl::open):
        * src/WebIDBFactoryImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Wed, 9 Mar 2011 11:52:23 +0000 (11:52 +0000)]
2011-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Move fast/canvas/rgba-parsing.html to the group of
        tests failing due to rounding color problems in cairo/pixman.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Steve Block <steveblock@google.com>
steveblock@google.com [Wed, 9 Mar 2011 11:09:20 +0000 (11:09 +0000)]
2011-03-08  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Factor out JNI method call to be used by both JSC and V8
        https://bugs.webkit.org/show_bug.cgi?id=55966

        No new tests, refactoring only.

        * bridge/jni/JNIUtility.cpp:
        (JSC::Bindings::callJNIMethod):
        * bridge/jni/JNIUtility.h:
        * bridge/jni/jsc/JavaInstanceJSC.cpp:
        (JavaInstance::invokeMethod):
        * bridge/jni/v8/JavaInstanceV8.cpp:
        (JavaInstance::invokeMethod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Wed, 9 Mar 2011 11:01:57 +0000 (11:01 +0000)]
2011-03-09  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: [Text editor] Regression in handling DOMNodeInserted/DOMNodeRemoved events
        https://bugs.webkit.org/show_bug.cgi?id=55818

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 9 Mar 2011 10:53:51 +0000 (10:53 +0000)]
2011-03-09  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: more vertical text fallout for the chromium test expectations.
        Also, a rebaseline.

        * platform/chromium-mac/fast/lists/003-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/lists/003-vertical-expected.png: Added.
        * platform/chromium-mac/fast/lists/003-vertical-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 9 Mar 2011 10:00:08 +0000 (10:00 +0000)]
2011-03-09  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Web Inspector: we don't need to transfer objectId and hasChildren for primitive values.
        https://bugs.webkit.org/show_bug.cgi?id=55998

        * inspector/protocol/console-agent-expected.txt:
        * inspector/protocol/runtime-agent-expected.txt:
2011-03-09  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Web Inspector: we don't need to transfer objectId and hasChildren for primitive values.
        https://bugs.webkit.org/show_bug.cgi?id=55998

        * inspector/InjectedScriptSource.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 9 Mar 2011 09:57:38 +0000 (09:57 +0000)]
2011-03-09  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: watch expressions should show string values in quotes.
        https://bugs.webkit.org/show_bug.cgi?id=55846

        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest):
        * inspector/console/console-dir-expected.txt:
        * inspector/console/console-dir.html:
        * inspector/debugger/debugger-expand-scope-expected.txt:
        * inspector/debugger/debugger-expand-scope.html:
        * platform/chromium/inspector/console/console-dir-expected.txt:
        * platform/chromium/inspector/debugger/debugger-expand-scope-expected.txt:
2011-03-09  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: watch expressions should show string values in quotes.
        https://bugs.webkit.org/show_bug.cgi?id=55846

        * inspector/InjectedScriptSource.js:
        * inspector/front-end/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertyTreeElement.prototype.update):
        * inspector/front-end/RemoteObject.js:
        (WebInspector.LocalJSONObject.prototype.get description):
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSection.prototype.update):
        * inspector/front-end/inspector.css:
        (.console-formatted-string, .console-formatted-regexp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 9 Mar 2011 09:53:56 +0000 (09:53 +0000)]
2011-03-09  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: "length" getter is invoked upon console object formatting.
        https://bugs.webkit.org/show_bug.cgi?id=55220

        * inspector/console/console-format-expected.txt:
        * inspector/console/console-format.html:
        * platform/chromium/inspector/console/console-format-expected.txt:
2011-03-09  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: "length" getter is invoked upon console object formatting.
        https://bugs.webkit.org/show_bug.cgi?id=55220

        * inspector/InjectedScriptSource.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 9 Mar 2011 09:25:51 +0000 (09:25 +0000)]
2011-03-09  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: yet more tweaking of the chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 9 Mar 2011 09:07:19 +0000 (09:07 +0000)]
2011-03-09  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: fix chromium test expectations file.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 9 Mar 2011 08:46:03 +0000 (08:46 +0000)]
2011-03-09  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: update chromium test expectations

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>
xji@chromium.org [Wed, 9 Mar 2011 06:58:49 +0000 (06:58 +0000)]
2011-03-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove groupName from objectId.
        https://bugs.webkit.org/show_bug.cgi?id=55825

        * inspector/protocol/runtime-agent-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 9 Mar 2011 06:32:41 +0000 (06:32 +0000)]
2011-03-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove groupName from objectId.
        https://bugs.webkit.org/show_bug.cgi?id=55825

        * inspector/protocol/runtime-agent-expected.txt:
2011-03-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove groupName from objectId.
        https://bugs.webkit.org/show_bug.cgi?id=55825

        * inspector/InjectedScriptSource.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 9 Mar 2011 06:23:37 +0000 (06:23 +0000)]
2011-03-08  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
        https://bugs.webkit.org/show_bug.cgi?id=55077.

        * fast/dom/scroll-reveal-left-overflow.html: Added.
        * fast/dom/scroll-reveal-top-overflow.html: Added.
        * platform/mac/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
        * platform/mac/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
        * platform/mac/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
        * platform/mac/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
        * platform/mac/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
        * platform/mac/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
2011-03-08  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
        https://bugs.webkit.org/show_bug.cgi?id=55077.

        Inside ScrollView::calculateOverhangAreasForPainting(), when scroll position
        is negative, should include the position value into overhang rectangle's
        starting position.

        Tests: fast/dom/scroll-reveal-left-overflow.html
               fast/dom/scroll-reveal-top-overflow.html

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::calculateOverhangAreasForPainting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBug 55994 - Functions on Array.prototype should check length first.
barraclough@apple.com [Wed, 9 Mar 2011 05:57:29 +0000 (05:57 +0000)]
Bug 55994 - Functions on Array.prototype should check length first.
These methods are designed to work on generic objects too, and if 'length'
is a getter that throws an exception, ensure this is correctly thrown
(even if other exceptions would be thrown, too).

Reviewed by Sam Weinig

Source/JavaScriptCore:

Make the length check the first thing we do.
This change shows a progression on SunSpider on my machine, but this is likely bogus.

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

LayoutTests:

Added test cases.

* fast/js/array-proto-func-length-getter-except-expected.txt: Added.
* fast/js/array-proto-func-length-getter-except.html: Added.
* fast/js/script-tests/array-proto-func-length-getter-except.js: Added.
(lengthGetter):
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 9 Mar 2011 05:57:23 +0000 (05:57 +0000)]
2011-03-08  Daniel Bates  <dbates@rim.com>

        Reviewed by Darin Adler.

        Add templatized CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
        https://bugs.webkit.org/show_bug.cgi?id=55351

        By using some template magic CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
        can be called on an array A without the caller explicitly specifying the size of A.

        No functionality was changed. So no new tests.

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Modified to call templatized variants of
        CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}().
        (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Renamed second argument from "number" to "size"
        to better reflect its purpose - to be the size of the passed array.
        (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Ditto.
        (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
        (WebCore::CSSMutableStyleDeclaration::cssText): Modified to call templatized variant of CSSMutableStyleDeclaration::getShorthandValue().
        * css/CSSMutableStyleDeclaration.h:
        (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Added templatized function that can determine
        the size of a passed array. Changed type of second argument to size_t since it represents the size of
        an array.
        (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
        (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 9 Mar 2011 05:19:38 +0000 (05:19 +0000)]
2011-03-08  Jer Noble  <jer.noble@apple.com>

        Reviewed by Sam Weinig.

        WebKit2: Plumb through the FULLSCREEN_API Chrome client calls
        https://bugs.webkit.org/show_bug.cgi?id=55273

        The FULLSCREEN_API Chrome client calls need to be plumbed through from the
        WebProcess to the UIProcess.  To do this, WebFullScreenManager (and Proxy)
        classes have been added to WebPage.

        * DerivedSources.make: Added rules necessary to build DerivedSources for new .in files.
        * DerivedSources.pro: Ditto.
        * Platform/CoreIPC/MessageID.h: Added message types for WebFullScreenManager.
        * Shared/API/c/WKBase.h: Added WKFullScreenManagerRef.
        * Shared/APIObject.h: Added APIType for WebFullScreenManager.
        * UIProcess/WebFullScreenManagerProxy.cpp: Added.
        * UIProcess/WebFullScreenManagerProxy.h: Added.
        * UIProcess/WebFullScreenManagerProxy.messages.in: Added.
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::close): Invalidate and clear m_fullScreenManager.
        (WebKit::WebPageProxy::processDidCrash): Ditto.
        (WebKit::WebPageProxy::didReceiveMessage): Pass messages on to WebFullScreenManagerProxy.
        (WebKit::WebPageProxy::didReceiveSyncMessage): Ditto.
        (WebKit::WebPageProxy::fullScreenManager): Added. Lazy instantiation of m_fullScreenManager.
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        * UIProcess/WebUIClient.cpp:
        * UIProcess/WebUIClient.h:
        * WebKit2.xcodeproj/project.pbxproj: Added references to new classes in project file.
        * WebKit2.pro: Ditto.
        * win/WebKit2.vcproj: Ditto.
        * WebKit2.pri: Added new directories to include file path.
        * win/WebKit2Common.vsprops: Ditto.
        * WebProcess/FullScreen/WebFullScreenManager.cpp: Added.
        * WebProcess/FullScreen/WebFullScreenManager.h: Added.
        * WebProcess/FullScreen/WebFullScreenManager.messages.in: Added.
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::supportsFullScreenForElement): Pass through to WebFullScreenManager.
        (WebKit::WebChromeClient::enterFullScreenForElement): Ditto.
        (WebKit::WebChromeClient::exitFullScreenForElement): Ditto.
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::close): Invalidate and clear m_fullScreenManager.
        (WebKit::WebPage::fullScreenManager): Lazy instantiation of m_fullScreenManager.
        (WebKit::WebPage::didReceiveMessage): Pass messages through to WebFullScreenManager.
        * WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 9 Mar 2011 03:44:27 +0000 (03:44 +0000)]
2011-03-08  Mihai Parparita  <mihaip@chromium.org>

        Add failing expectation for compositing/webgl/
        webgl-nonpremultiplied-blend.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Wed, 9 Mar 2011 03:15:28 +0000 (03:15 +0000)]
2011-03-08  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        Destroying WorkerFileSystemCallbacksBridge on main thread results in ASSERT in WorkerContext::Observer::~Observer
        https://bugs.webkit.org/show_bug.cgi?id=55895

        * src/WorkerFileSystemCallbacksBridge.cpp:
        (WebKit::WorkerFileSystemCallbacksBridge::runTaskOnWorkerThread):
        Added stopObserving() so that releasing the bridge on the main thread
        (this could happen before or after the runTaskOnWorkerThread) does
        not cause the assertion error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThere's more chance that this will work if the file is compiled.
mrowe@apple.com [Wed, 9 Mar 2011 03:04:24 +0000 (03:04 +0000)]
There's more chance that this will work if the file is compiled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: Copied content loses formatting on paste to external apps.
enrica@apple.com [Wed, 9 Mar 2011 02:28:12 +0000 (02:28 +0000)]
REGRESSION: Copied content loses formatting on paste to external apps.
https://bugs.webkit.org/show_bug.cgi?id=47615
<rdar://problem/9001214>

Reviewed by Darin Adler.

This is a resubmission of a patch that was landed a while ago then rolled
back because of a build failure on SnowLeopard and Leopard on the 32-bit builds.

This patch adds a way for WebKit2 to create NSAttributedStrings from
a DOM range without using the AppKit api initWithDOMRange that internally
needs to access the WebView. The NSAttributedString is needed to create
RTF formats in the pasteboard.
This is to be considered a first step, since in the future we want to have
an implementation based on the TextIterator.
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/HTMLConverter.h: Added.
* platform/mac/HTMLConverter.mm: Added.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 9 Mar 2011 02:25:54 +0000 (02:25 +0000)]
2011-03-08  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Explicitly copy compositing properties from LayerChromium to CCLayerImpl
        https://bugs.webkit.org/show_bug.cgi?id=55900

        This adds an explicit step to synchronize properties from
        LayerChromiums to their corresponding CCLayerImpls.

        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::setBounds):
        * platform/graphics/chromium/LayerChromium.h:
        (WebCore::LayerChromium::bounds):
        (WebCore::LayerChromium::doubleSided):
        (WebCore::LayerChromium::setDoubleSided):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
        * platform/graphics/chromium/cc/CCLayerImpl.cpp:
        (WebCore::CCLayerImpl::CCLayerImpl):
        (WebCore::CCLayerImpl::updateFromLayer):
        (WebCore::CCLayerImpl::descendantsDrawsContent):
        * platform/graphics/chromium/cc/CCLayerImpl.h:
        (WebCore::CCLayerImpl::anchorPoint):
        (WebCore::CCLayerImpl::anchorPointZ):
        (WebCore::CCLayerImpl::masksToBounds):
        (WebCore::CCLayerImpl::opacity):
        (WebCore::CCLayerImpl::position):
        (WebCore::CCLayerImpl::preserves3D):
        (WebCore::CCLayerImpl::sublayerTransform):
        (WebCore::CCLayerImpl::transform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 9 Mar 2011 02:22:45 +0000 (02:22 +0000)]
2011-03-08  James Robinson  <jamesr@chromium.org>

        Chromium compile fix.

        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        (WebCore::SimpleFontData::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 9 Mar 2011 02:09:18 +0000 (02:09 +0000)]
2011-03-08  Jer Noble  <jer.noble@apple.com>

        Reviewed by Sam Weinig.

        WebKit2: Plumb through the "supportsFullScreen" preference.
        https://bugs.webkit.org/show_bug.cgi?id=55261

        The "supportsFullScreen" preference needs to be plumbed through from
        the UIProcess to the WebProcess.

        * Shared/WebPreferencesStore.h: Add a new macro entry.
        * UIProcess/API/C/WKPreferences.cpp: Implement preferences getter and setter.
        (WKPreferencesSetFullScreenEnabled):
        (WKPreferencesGetFullScreenEnabled):
        * UIProcess/API/C/WKPreferences.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::updatePreferences): Sync the fullScreenEnabled setting through to
            the settings object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnify Windows version checks, part 1.
pkasting@chromium.org [Wed, 9 Mar 2011 01:44:10 +0000 (01:44 +0000)]
Unify Windows version checks, part 1.
https://bugs.webkit.org/show_bug.cgi?id=55979

Reviewed by James Robinson.

Make everyone (I hope) pull in SystemInfo.cpp.  Eliminate the
now-unnecessary WindowsVersion.cpp from Chromium.

* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
(WebCore::ScrollbarThemeChromiumWin::getThemeState):
(WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
* platform/chromium/WindowsVersion.cpp: Removed.
* platform/chromium/WindowsVersion.h: Removed.
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::getNonClientMetrics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 9 Mar 2011 01:39:46 +0000 (01:39 +0000)]
2011-03-08  Ryosuke Niwa  <rniwa@webkit.org>

        Chromium Linux build fix attempt after r80582.

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        (WebCore::SimpleFontData::platformInit):
        * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
        (WebCore::GlyphPage::fill):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Wed, 9 Mar 2011 01:35:18 +0000 (01:35 +0000)]
2011-03-08  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adele Peterson.

        WebKit2: Implement Windows glue for Undo/Redo
        https://bugs.webkit.org/show_bug.cgi?id=55961

        Expose Undo/Redo infrastructure through WKView on Windows by
        adding an undo client as well as APIs to reapply and unapply
        an edit command.

        * UIProcess/API/C/win/WKView.cpp:
        (WKViewSetViewUndoClient): Added.
        (WKViewReapplyEditCommand): Added.
        (WKViewUnapplyEditCommand): Added.
        * UIProcess/API/C/win/WKView.h: Added WKViewUndoClient, WKViewSetViewUndoClient(), and WKViewUnapplyEditCommand().
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::isValidEditCommand): Added, used to validated an edit command from a WKView API.
        * UIProcess/WebPageProxy.h: Added isValidEditCommand().
        * UIProcess/win/WebUndoClient.cpp: Added, APIClient for WKViewUndoClient.
        (WebKit::WebUndoClient::registerEditCommand): Added.
        (WebKit::WebUndoClient::clearAllEditCommands): Added.
        * UIProcess/win/WebUndoClient.h: Added, APIClient for WKViewUndoClient.
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::initializeUndoClient): Added.
        (WebKit::WebView::close): Clear out undo client.
        (WebKit::WebView::registerEditCommand): Implemented to call through to WKViewUndoClient.
        (WebKit::WebView::clearAllEditCommands): Implmented to call through to WKViewUndoClient.
        (WebKit::WebView::reapplyEditCommand): Added.
        (WebKit::WebView::unapplyEditCommand): Added.
        * UIProcess/win/WebView.h: Added undo client support.
        * win/WebKit2.vcproj: Added WebUndoClient.cpp and WebUndoClient.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 9 Mar 2011 01:27:48 +0000 (01:27 +0000)]
2011-03-08  Ryosuke Niwa  <rniwa@webkit.org>

        Mac build fix attempt for r80582.

        * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
        (WebCore::disableLigatures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding myself to the committer file.
imasaki@chromium.org [Wed, 9 Mar 2011 01:25:31 +0000 (01:25 +0000)]
Adding myself to the committer file.

Reviewed by David Levin.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Clean up Media GPU test expectation since
imasaki@chromium.org [Wed, 9 Mar 2011 01:16:52 +0000 (01:16 +0000)]
[Chromium] Clean up Media GPU test expectation since
http://crbug.com?id=74887 was fixed. These expectations are based
on the results on flakiness dashboard.

Reviewed by David Levin.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Wed, 9 Mar 2011 01:00:35 +0000 (01:00 +0000)]
2011-03-08  Jeff Miller  <jeffm@apple.com>

        Reviewed by Sam Weinig.

        WebKit2: Expose WebEditCommandProxy in the C API on Windows
        https://bugs.webkit.org/show_bug.cgi?id=55962

        Make WebEditCommandProxy a subclass of APIObject, and define
        WKEditCommandRef as the type that will be exposed through the C API.

        * Shared/API/c/win/WKBaseWin.h: Add WKEditCommandRef.
        * Shared/APIObject.h: Add platform-specific TypeEditCommandProxy.
        * UIProcess/API/C/win/WKAPICastWin.h: Add API mapping for WKEditCommandRef.
        * UIProcess/WebEditCommandProxy.h: Subclass WebEditCommandProxy from APIObject.
        (WebKit::WebEditCommandProxy::type): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 9 Mar 2011 00:51:00 +0000 (00:51 +0000)]
2011-03-08  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Remove calls to deprecatedEditingOffset in SelectionController and VisibleSelection
        https://bugs.webkit.org/show_bug.cgi?id=54937

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection): Calls anchorNode() instead of deprecatedNode() to obtain
        the document. Also restrained the lifetime of document variable.
        (WebCore::removingNodeRemovesPosition): Compare the node with anchorNode() instead of deprecatedNode()
        to determine whether or not position becomes null after removing a node.
        (WebCore::SelectionController::directionOfEnclosingBlock): The enclosing block is always a container
        so call containerNode() instead of deprecatedNode().
        (WebCore::SelectionController::debugRenderer): Call containerNode() and computeOffsetInContainer()
        instead of deprecatedNode() and deprecatedEditingOffset() respectively.
        (WebCore::SelectionController::isInPasswordField): Look for the shadow root from containerNode()
        instead of deprecatedNode to determine whether or not selection inside a password field. Also assert
        that the specified position is not before or after the shadow root as it violates our assumption.
        * editing/VisibleSelection.cpp:
        (WebCore::makeSearchRange): Call containerNode() and offsetInContainerNode() instead of deprecatedNode()
        and deprecatedEditingOffset() respectively because start is always parent anchored and therefore
        guaranteed to be an offset inside an anchor node.
        (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Call containerNode()
        instead of deprecatedNode() to look for the lowest editable ancestor because position before or after
        an editable element isn't editable.
        * page/DOMSelection.cpp: Call containerNode() and offsetInContainerNode() instead of deprecatedNode()
        and deprecatedEditingOffset() respectively in the following functions because they are exposed to
        DOM, which doesn't have before/after concept.
        (WebCore::DOMSelection::anchorNode):
        (WebCore::DOMSelection::anchorOffset):
        (WebCore::DOMSelection::focusNode):
        (WebCore::DOMSelection::focusOffset):
        (WebCore::DOMSelection::baseNode):
        (WebCore::DOMSelection::baseOffset):
        (WebCore::DOMSelection::extentNode):
        (WebCore::DOMSelection::extentOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Wed, 9 Mar 2011 00:18:46 +0000 (00:18 +0000)]
2011-03-08  Jeff Miller  <jeffm@apple.com>

        Reviewed by Oliver Hunt.

        WebKit2: Redo is broken
        https://bugs.webkit.org/show_bug.cgi?id=55978

        WebEditCommandProxy::unapply() and WebEditCommandProxy::reapply() were registering the wrong edit command when an undo or redo happens.
        For example, when we unapply(), we should register a Redo command, not an Undo command.

        * UIProcess/WebEditCommandProxy.cpp:
        (WebKit::WebEditCommandProxy::unapply): Register a Redo command, not an Undo command.
        (WebKit::WebEditCommandProxy::reapply): Register an Undo command, not a Redo command.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=55977
bfulgham@webkit.org [Wed, 9 Mar 2011 00:02:34 +0000 (00:02 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55977
Refine CF/CFNet distinctions for better code sharing.
1. Rename Downloads/cf/win/DownloadCFNetWin.cpp to DownloadCFWin.cpp
   since it does not use any CFNETWORK features.
2. Create new cfnet directory.
3. Move Downloads/cf/DownloadCFNet.cpp to Downloads/cfnet
4. Update project file.

Reviewed by Adam Roben.

* WebProcess/Downloads/cf/DownloadCFNet.cpp: Removed.
* WebProcess/Downloads/cf/win/DownloadCFNetWin.cpp: Removed.
* WebProcess/Downloads/cf/win/DownloadCFWin.cpp: Copied from WebProcess/Downloads/cf/win/DownloadCFNetWin.cpp.
* WebProcess/Downloads/cfnet: Added.
* WebProcess/Downloads/cfnet/DownloadCFNet.cpp: Copied from WebProcess/Downloads/cf/DownloadCFNet.cpp.
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCorrect uninitialized variable in PolicyCallback found while
bfulgham@webkit.org [Wed, 9 Mar 2011 00:00:26 +0000 (00:00 +0000)]
Correct uninitialized variable in PolicyCallback found while
running WebKit in BoundsChecker.
https://bugs.webkit.org/show_bug.cgi?id=45199.

Reviewed by Adam Roben.

* loader/PolicyCallback.cpp:
(WebCore::PolicyCallback::PolicyCallback): Initialize
m_argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/55976> Provisional URL should be loaded when restoring session...
mrowe@apple.com [Tue, 8 Mar 2011 23:44:35 +0000 (23:44 +0000)]
<webkit.org/b/55976> Provisional URL should be loaded when restoring session state even if there are back / forward list entries.

Reviewed by Brady Eidson.

* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData): If there's a provisional URL that we will load then restore the session state
without navigating to the current item.
* WebProcess/WebPage/WebPage.messages.in: Expose the ability to restore the session state without navigating to the current item.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix two leaks I introduced into the API tests.
jberlin@webkit.org [Tue, 8 Mar 2011 23:43:23 +0000 (23:43 +0000)]
Fix two leaks I introduced into the API tests.

Rubber-stamped by Adam Roben.

* TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-07 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 8 Mar 2011 23:17:32 +0000 (23:17 +0000)]
2011-03-07  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make CodeBlock GC write barrier safe
        https://bugs.webkit.org/show_bug.cgi?id=55910

        In order to make CodeBlock WriteBarrier safe it was necessary
        to make it have a single GC owner, and for that reason I have
        made ExecutableBase a GC allocated object.  This required
        updating their creation routines as well as all sites that hold
        a reference to them.  GC objects that held Executable's have been
        converted to WriteBarriers, and all other sites now use Global<>.

        As an added benefit this gets rid of JSGlobalData's list of
        GlobalCodeBlocks.

        Perf testing shows a 0.5% progression on v8, vs. a 0.3% regression
        on SunSpider.  Given none of the tests that show regressions
        demonstrate a regression on their own, and sampling shows up nothing.
        I suspect we're just getting one or two additional gc passes at
        the end of the run.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        (JSC::CodeBlock::CodeBlock):
        (JSC::EvalCodeCache::markAggregate):
        (JSC::CodeBlock::markAggregate):
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::ownerExecutable):
        (JSC::CodeBlock::addConstant):
        (JSC::CodeBlock::constantRegister):
        (JSC::CodeBlock::getConstant):
        (JSC::CodeBlock::addFunctionDecl):
        (JSC::CodeBlock::addFunctionExpr):
        (JSC::GlobalCodeBlock::GlobalCodeBlock):
        (JSC::ExecState::r):
        * bytecode/EvalCodeCache.h:
        (JSC::EvalCodeCache::get):
        * bytecode/SamplingTool.h:
        (JSC::ScriptSampleRecord::ScriptSampleRecord):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::addConstantValue):
        (JSC::BytecodeGenerator::emitEqualityOp):
        * bytecompiler/BytecodeGenerator.h:
        (JSC::BytecodeGenerator::makeFunction):
        * debugger/Debugger.cpp:
        (JSC::evaluateInGlobalCallFrame):
        * debugger/DebuggerCallFrame.cpp:
        (JSC::DebuggerCallFrame::evaluate):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::callEval):
        * jit/JITInlineMethods.h:
        (JSC::JIT::emitLoadDouble):
        (JSC::JIT::emitLoadInt32ToDouble):
        * jit/JITStubs.cpp:
        (JSC::JITThunks::JITThunks):
        (JSC::JITThunks::hostFunctionStub):
        (JSC::JITThunks::clearHostFunctionStubs):
        * jit/JITStubs.h:
        * runtime/Completion.cpp:
        (JSC::checkSyntax):
        (JSC::evaluate):
        * runtime/Executable.cpp:
        (JSC::EvalExecutable::EvalExecutable):
        (JSC::ProgramExecutable::ProgramExecutable):
        (JSC::FunctionExecutable::FunctionExecutable):
        (JSC::FunctionExecutable::~FunctionExecutable):
        (JSC::EvalExecutable::markChildren):
        (JSC::ProgramExecutable::markChildren):
        (JSC::FunctionExecutable::markChildren):
        (JSC::FunctionExecutable::fromGlobalCode):
        * runtime/Executable.h:
        (JSC::ExecutableBase::ExecutableBase):
        (JSC::ExecutableBase::createStructure):
        (JSC::NativeExecutable::create):
        (JSC::NativeExecutable::NativeExecutable):
        (JSC::VPtrHackExecutable::VPtrHackExecutable):
        (JSC::ScriptExecutable::ScriptExecutable):
        (JSC::EvalExecutable::create):
        (JSC::EvalExecutable::createStructure):
        (JSC::ProgramExecutable::create):
        (JSC::ProgramExecutable::createStructure):
        (JSC::FunctionExecutable::create):
        (JSC::FunctionExecutable::createStructure):
        * runtime/FunctionConstructor.cpp:
        (JSC::constructFunction):
        * runtime/Heap.cpp:
        (JSC::Heap::destroy):
        (JSC::Heap::markRoots):
        * runtime/Heap.h:
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::JSActivation):
        (JSC::JSActivation::markChildren):
        * runtime/JSActivation.h:
        (JSC::JSActivation::JSActivationData::JSActivationData):
        * runtime/JSCell.h:
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::JSFunction):
        (JSC::JSFunction::~JSFunction):
        (JSC::JSFunction::markChildren):
        * runtime/JSFunction.h:
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::storeVPtrs):
        (JSC::JSGlobalData::JSGlobalData):
        (JSC::JSGlobalData::getHostFunction):
        * runtime/JSGlobalData.h:
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncEval):
        * runtime/JSObject.cpp:
        * runtime/JSStaticScopeObject.cpp:
        (JSC::JSStaticScopeObject::markChildren):
        * runtime/JSStaticScopeObject.h:
        (JSC::JSStaticScopeObject::JSStaticScopeObjectData::JSStaticScopeObjectData):
        (JSC::JSStaticScopeObject::JSStaticScopeObject):
        * runtime/JSZombie.cpp:
        (JSC::JSZombie::leakedZombieStructure):
        * runtime/JSZombie.h:
        (JSC::JSZombie::createStructure):
        * runtime/MarkedSpace.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 8 Mar 2011 23:13:19 +0000 (23:13 +0000)]
2011-03-08  Martin Robinson  <mrobinson@igalia.com>

        Rebaseline a GTK+ result after r80582.

        * platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=55956
bfulgham@webkit.org [Tue, 8 Mar 2011 23:06:08 +0000 (23:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55956
WebKit2 Changes to correct WinCairo port build

Reviewed by Anders Carlsson.

* Shared/LayerTreeContext.h: Don't exclude CoreIPC declarations for non-accelerated
  compositing case.
* UIProcess/DrawingAreaProxy.h: Add "stdint.h" include needed for Cairo build.
* UIProcess/DrawingAreaProxyImpl.cpp: Exclude accelerated compositing code for
  WinCairo build.
(WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidUpdateBackingStoreState):
* UIProcess/DrawingAreaProxyImpl.h: Exclude declarations for code only used when
  accelerated compositing is enabled.
(WebKit::DrawingAreaProxyImpl::isInAcceleratedCompositingMode):
* UIProcess/win/WebView.cpp: Protect CG-specific drawing code.
(WebKit::WebView::setFindIndicator):
* WebProcess/Downloads/Download.h: Allow CFLite implentation to share overwrite flag,
  as well as destination and bundle paths.
* WebProcess/Downloads/curl/DownloadCurl.cpp: Remove stub (to share CFNet implementation
  of file handling.  This will be moved to a common area in a future patch.)
* WebProcess/WebPage/DrawingAreaImpl.cpp: Exclude accelerated-compositing paths.
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
* WebProcess/WebPage/WebPage.cpp: Protect CG-specific drawing code.
(WebKit::WebPage::drawRectToPDF):
(WebKit::WebPage::drawPagesToPDF):
* win/WebKit2.vcproj: Exclude unused LayerTreeContext from WinCairo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ossy@webkit.org [Tue, 8 Mar 2011 22:49:02 +0000 (22:49 +0000)]
Unreviewed.

https://bugs.webkit.org/show_bug.cgi?id=48540, support the text-orientation CSS property.
Update Qt specific expected results after r80582.

* platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore build bustage fix.
bfulgham@webkit.org [Tue, 8 Mar 2011 22:37:38 +0000 (22:37 +0000)]
More build bustage fix.

* platform/graphics/win/cairo/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation): Duplicate accessor
in WinCairo-local header.  This is such a mess!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Ivan Krstić <ike@apple.com>
ike@apple.com [Tue, 8 Mar 2011 22:16:21 +0000 (22:16 +0000)]
2011-03-08  Ivan Krstić  <ike@apple.com>

        Reviewed by Sam Weinig.

        Re-fix: can't paste from 3rd party text editor into WebKit2 window
        <rdar://problem/8978624>

        * WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix build bustage. Hide orientation setting behind a setter and stub it out in all
hyatt@apple.com [Tue, 8 Mar 2011 22:05:14 +0000 (22:05 +0000)]
Fix build bustage.  Hide orientation setting behind a setter and stub it out in all
FontPlatformData classes.  (This class really needs to move to a common header with ifdefs.)

* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::verticalRightOrientationFontData):
* platform/graphics/cg/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/chromium/FontPlatformDataChromiumWin.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/chromium/FontPlatformDataLinux.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/cocoa/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/freetype/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/wince/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/wx/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80589 268f45cc-cd09-0410-ab3c-d52691b4dbfc