WebKit-https.git
13 years ago Slight clarification to an exception message.
ggaren [Mon, 28 May 2007 19:37:18 +0000 (19:37 +0000)]
    Slight clarification to an exception message.

        * API/JSCallbackObject.cpp:
        (KJS::JSCallbackObject::put):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-05-29 Mark Rowe <mrowe@apple.com>
bdash [Mon, 28 May 2007 19:29:27 +0000 (19:29 +0000)]
2007-05-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Geoff.

        64-bit build fix.  Ensure that use of WebNSUInteger in headers is matched by WebNSUInteger in implementations.

        * DefaultDelegates/WebScriptDebugServer.h:
        * DefaultDelegates/WebScriptDebugServer.m:
        (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
        (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
        * DefaultDelegates/WebScriptDebugServerPrivate.h:
        * History/WebBackForwardList.mm:
        (-[WebBackForwardList setPageCacheSize:]):
        (-[WebBackForwardList pageCacheSize]):
        * WebView/WebView.mm:
        (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-05-29 Mark Rowe <mrowe@apple.com>
bdash [Mon, 28 May 2007 18:47:41 +0000 (18:47 +0000)]
2007-05-29  Mark Rowe  <mrowe@apple.com>

        Build fix after r21745.

        * Scripts/check-for-global-initializers: Skip CachedPage.o as it now has a global initializer in debug builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoImplementing public settings Api for the Qt port.
zack [Mon, 28 May 2007 13:53:12 +0000 (13:53 +0000)]
Implementing public settings Api for the Qt port.

Adds value based QWebSettings object which is settable on
a QWebPage. Done after discussions with Lars and Simon.

r=andersca,simon

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTestResults:
ddkilzer [Mon, 28 May 2007 13:15:03 +0000 (13:15 +0000)]
LayoutTestResults:

        Reviewed by NOBODY (newly passing tests).

        http://bugs.webkit.org/show_bug.cgi?id=13793
        RULES=groups overridden by border, colgroup=span not honored by border collapsing

        Moved three now-passing tests from tables/mozilla_expected_failures to tables/mozilla.

        * qt/tables/mozilla/marvin/colgroup_width_pct-expected.txt:
          Copied from qt/tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt.
        * qt/tables/mozilla/marvin/colgroup_width_px-expected.txt:
          Copied from qt/tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt.
        * qt/tables/mozilla/marvin/x_colgroup_width_pct-expected.txt:
          Copied from qt/tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt.
        * qt/tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt: Removed.
        * qt/tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt: Removed.
        * qt/tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt: Removed.

LayoutTests:

        Reviewed by NOBODY (newly passing tests).

        http://bugs.webkit.org/show_bug.cgi?id=13793
        RULES=groups overridden by border, colgroup=span not honored by border collapsing

        Moved three now-passing tests from tables/mozilla_expected_failures to tables/mozilla.

        * tables/mozilla/marvin/colgroup_width_pct-expected.checksum:
          Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.checksum.
        * tables/mozilla/marvin/colgroup_width_pct-expected.png:
          Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.png.
        * tables/mozilla/marvin/colgroup_width_pct-expected.txt:
          Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt.
        * tables/mozilla/marvin/colgroup_width_pct.html:
          Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct.html.
        * tables/mozilla/marvin/colgroup_width_px-expected.checksum:
          Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.checksum.
        * tables/mozilla/marvin/colgroup_width_px-expected.png:
          Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.png.
        * tables/mozilla/marvin/colgroup_width_px-expected.txt:
          Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt.
        * tables/mozilla/marvin/colgroup_width_px.html:
          Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px.html.
        * tables/mozilla/marvin/x_colgroup_width_pct-expected.checksum:
          Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.checksum.
        * tables/mozilla/marvin/x_colgroup_width_pct-expected.png:
          Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.png.
        * tables/mozilla/marvin/x_colgroup_width_pct-expected.txt:
          Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt.
        * tables/mozilla/marvin/x_colgroup_width_pct.xml:
          Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct.xml.
        * tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.checksum: Removed.
        * tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.png: Removed.
        * tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt: Removed.
        * tables/mozilla_expected_failures/marvin/colgroup_width_pct.html: Removed.
        * tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.checksum: Removed.
        * tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.png: Removed.
        * tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt: Removed.
        * tables/mozilla_expected_failures/marvin/colgroup_width_px.html: Removed.
        * tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.checksum: Removed.
        * tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.png: Removed.
        * tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt: Removed.
        * tables/mozilla_expected_failures/marvin/x_colgroup_width_pct.xml: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Qt and Gdk build fix.
weinig [Mon, 28 May 2007 04:47:52 +0000 (04:47 +0000)]
    Qt and Gdk build fix.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Mon, 28 May 2007 04:40:10 +0000 (04:40 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Update results for http://bugs.webkit.org/show_bug.cgi?id=13893
        Autogenerate the JS bindings for the HTMLObjectElement,
        HTMLEmbedElement and HTMLAppletElement

        - account for the new JSHTMLObjectElement and JSHTMLEmbedElement that are
          being autogenerated and can now produce constructors.

        * fast/dom/Window/element-constructors-on-window-expected.txt:
        * fast/dom/Window/window-properties-expected.txt:

WebCore:

        Reviewed by Hyatt.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13893
        Autogenerate the JS bindings for the HTMLObjectElement,
        HTMLEmbedElement and HTMLAppletElement

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLAppletElementCustom.cpp: Added.
        (WebCore::JSHTMLAppletElement::customGetOwnPropertySlot):
        (WebCore::JSHTMLAppletElement::customPut):
        (WebCore::JSHTMLAppletElement::implementsCall):
        (WebCore::JSHTMLAppletElement::callAsFunction):
        (WebCore::JSHTMLAppletElement::canGetItemsForName):
        (WebCore::JSHTMLAppletElement::nameGetter):
        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        * bindings/js/JSHTMLEmbedElementCustom.cpp: Added.
        (WebCore::JSHTMLEmbedElement::customGetOwnPropertySlot):
        (WebCore::JSHTMLEmbedElement::customPut):
        (WebCore::JSHTMLEmbedElement::implementsCall):
        (WebCore::JSHTMLEmbedElement::callAsFunction):
        (WebCore::JSHTMLEmbedElement::canGetItemsForName):
        (WebCore::JSHTMLEmbedElement::nameGetter):
        * bindings/js/JSHTMLObjectElementCustom.cpp: Added.
        (WebCore::JSHTMLObjectElement::customGetOwnPropertySlot):
        (WebCore::JSHTMLObjectElement::customPut):
        (WebCore::JSHTMLObjectElement::implementsCall):
        (WebCore::JSHTMLObjectElement::callAsFunction):
        (WebCore::JSHTMLObjectElement::canGetItemsForName):
        (WebCore::JSHTMLObjectElement::nameGetter):
        * bindings/js/kjs_html.cpp:
        (KJS::):
        (KJS::JSHTMLElement::toString):
        (KJS::JSHTMLElement::pushEventHandlerScope):
        (KJS::runtimeObjectGetter):
        (KJS::runtimeObjectPropertyGetter):
        (KJS::runtimeObjectCustomGetOwnPropertySlot):
        (KJS::runtimeObjectCustomPut):
        (KJS::runtimeObjectImplementsCall):
        (KJS::runtimeObjectCallAsFunction):
        * bindings/js/kjs_html.h:
        (KJS::JSHTMLElement::classInfo):
        * bindings/scripts/CodeGeneratorJS.pm: Add support for
        CustomGetOwnPropertySlot, CustomPutFunction, CustomCall,
        and SVGCheckSecurityDocument properties.
        * html/HTMLAppletElement.idl:
        * html/HTMLEmbedElement.idl:
        * html/HTMLObjectElement.idl:
        * page/DOMWindow.idl: Uncomment constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
weinig [Mon, 28 May 2007 02:23:19 +0000 (02:23 +0000)]
    Reviewed by Oliver.

        Gdk build fix.

        * platform/graphics/Path.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark Rowe.
weinig [Mon, 28 May 2007 02:09:05 +0000 (02:09 +0000)]
    Reviewed by Mark Rowe.

        * wtf/Platform.h: Move Gdk up to allow building WebKit/Gdk on Darwin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Gdk build fix. Forgot to update a few instances of notImplementedGdk() to...
weinig [Mon, 28 May 2007 01:46:32 +0000 (01:46 +0000)]
    Gdk build fix.  Forgot to update a few instances of notImplementedGdk() to notImplemented().

        * page/gdk/EventHandlerGdk.cpp:
        (WebCore::EventHandler::passMousePressEventToScrollbar):
        * platform/gdk/EditorClientGdk.cpp:
        (WebCore::EditorClientGdk::ignoreWordInSpellDocument):
        (WebCore::EditorClientGdk::learnWord):
        (WebCore::EditorClientGdk::checkSpellingOfString):
        (WebCore::EditorClientGdk::checkGrammarOfString):
        (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
        (WebCore::EditorClientGdk::updateSpellingUIWithMisspelledWord):
        (WebCore::EditorClientGdk::showSpellingUI):
        (WebCore::EditorClientGdk::spellingUIIsShowing):
        (WebCore::EditorClientGdk::getGuessesForWord):
        * platform/gdk/FrameGdk.cpp:
        (WebCore::Frame::dashboardRegionsChanged):
        * platform/gdk/PlatformScrollBarGdk.cpp:
        (PlatformScrollbar::paint):
        (PlatformScrollbar::updateThumbPosition):
        (PlatformScrollbar::updateThumbProportion):
        * platform/gdk/TemporaryLinkStubs.cpp:
        (Widget::setEnabled):
        (Widget::isEnabled):
        (Widget::removeFromParent):
        (Widget::paint):
        (Widget::setIsSelected):
        (Widget::invalidate):
        (Widget::invalidateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam and Oliver.
weinig [Mon, 28 May 2007 01:24:43 +0000 (01:24 +0000)]
    Reviewed by Sam and Oliver.

        Implement PathCairo. This patch is based on changes in Mike Emmel's
        WebKit fork with some additional clean-ups and updates.

        * platform/graphics/Path.h:
        * platform/graphics/cairo/CairoPath.h: Added.
        (CairoPath::CairoPath):
        (CairoPath::~CairoPath):
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::clip):
        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::Path):
        (WebCore::Path::~Path):
        (WebCore::Path::operator=):
        (WebCore::Path::clear):
        (WebCore::Path::isEmpty):
        (WebCore::Path::translate):
        (WebCore::Path::moveTo):
        (WebCore::Path::addLineTo):
        (WebCore::Path::addRect):
        (WebCore::Path::addQuadCurveTo):
        (WebCore::Path::addBezierCurveTo):
        (WebCore::Path::addArc):
        (WebCore::Path::addArcTo):
        (WebCore::Path::addEllipse):
        (WebCore::Path::closeSubpath):
        (WebCore::Path::boundingRect):
        (WebCore::Path::contains):
        (WebCore::Path::apply):
        (WebCore::Path::transform):
        (WebCore::Path::debugString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
kevino [Mon, 28 May 2007 00:39:59 +0000 (00:39 +0000)]
WebCore:

        Reviewed by Sam Weinig.

        Consolidate all notImplemented() macro definitions into
        one header file for all platforms.

        * loader/gdk/DocumentLoaderGdk.cpp:
        (WebCore::DocumentLoader::getResponseModifiedHeader):
        * loader/gdk/FrameLoaderClientGdk.cpp:
        (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge):
        (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge):
        (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest):
        (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest):
        (WebCore::FrameLoaderClientGdk::createPlugin):
        (WebCore::FrameLoaderClientGdk::createFrame):
        (WebCore::FrameLoaderClientGdk::redirectDataToPlugin):
        (WebCore::FrameLoaderClientGdk::createJavaAppletWidget):
        (WebCore::FrameLoaderClientGdk::objectContentType):
        (WebCore::FrameLoaderClientGdk::overrideMediaType):
        (WebCore::FrameLoaderClientGdk::windowObjectCleared):
        (WebCore::FrameLoaderClientGdk::hasWebView):
        (WebCore::FrameLoaderClientGdk::hasFrameView):
        (WebCore::FrameLoaderClientGdk::frameLoadCompleted):
        (WebCore::FrameLoaderClientGdk::saveViewStateToItem):
        (WebCore::FrameLoaderClientGdk::restoreViewState):
        (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled):
        (WebCore::FrameLoaderClientGdk::makeDocumentView):
        (WebCore::FrameLoaderClientGdk::makeRepresentation):
        (WebCore::FrameLoaderClientGdk::forceLayout):
        (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML):
        (WebCore::FrameLoaderClientGdk::setCopiesOnScroll):
        (WebCore::FrameLoaderClientGdk::detachedFromParent1):
        (WebCore::FrameLoaderClientGdk::detachedFromParent2):
        (WebCore::FrameLoaderClientGdk::detachedFromParent3):
        (WebCore::FrameLoaderClientGdk::detachedFromParent4):
        (WebCore::FrameLoaderClientGdk::loadedFromCachedPage):
        (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents):
        (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad):
        (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect):
        (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect):
        (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage):
        (WebCore::FrameLoaderClientGdk::dispatchWillClose):
        (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon):
        (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad):
        (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle):
        (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad):
        (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad):
        (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout):
        (WebCore::FrameLoaderClientGdk::dispatchShow):
        (WebCore::FrameLoaderClientGdk::cancelPolicyCheck):
        (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource):
        (WebCore::FrameLoaderClientGdk::revertToProvisionalState):
        (WebCore::FrameLoaderClientGdk::clearUnarchivingState):
        (WebCore::FrameLoaderClientGdk::willChangeTitle):
        (WebCore::FrameLoaderClientGdk::finishedLoading):
        (WebCore::FrameLoaderClientGdk::finalSetupForReplace):
        (WebCore::FrameLoaderClientGdk::setDefersLoading):
        (WebCore::FrameLoaderClientGdk::isArchiveLoadPending):
        (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad):
        (WebCore::FrameLoaderClientGdk::clearArchivedResources):
        (WebCore::FrameLoaderClientGdk::canHandleRequest):
        (WebCore::FrameLoaderClientGdk::canShowMIMEType):
        (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme):
        (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme):
        (WebCore::FrameLoaderClientGdk::provisionalLoadStarted):
        (WebCore::FrameLoaderClientGdk::didFinishLoad):
        (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement):
        (WebCore::FrameLoaderClientGdk::setTitle):
        (WebCore::FrameLoaderClientGdk::setDocumentViewFromCachedPage):
        (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength):
        (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading):
        (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading):
        (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache):
        (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad):
        (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad):
        (WebCore::FrameLoaderClientGdk::download):
        (WebCore::FrameLoaderClientGdk::cancelledError):
        (WebCore::FrameLoaderClientGdk::blockedError):
        (WebCore::FrameLoaderClientGdk::cannotShowURLError):
        (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError):
        (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError):
        (WebCore::FrameLoaderClientGdk::fileDoesNotExistError):
        (WebCore::FrameLoaderClientGdk::shouldFallBack):
        (WebCore::FrameLoaderClientGdk::willUseArchive):
        (WebCore::FrameLoaderClientGdk::saveDocumentViewToCachedPage):
        (WebCore::FrameLoaderClientGdk::canCachePage):
        (WebCore::FrameLoaderClientGdk::dispatchCreatePage):
        (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy):
        (WebCore::FrameLoaderClientGdk::setMainDocumentError):
        (WebCore::FrameLoaderClientGdk::startDownload):
        (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad):
        (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload):
        * loader/qt/DocumentLoaderQt.cpp:
        * page/gdk/ContextMenuClientGdk.cpp:
        (WebCore::ContextMenuClientGdk::contextMenuDestroyed):
        (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems):
        (WebCore::ContextMenuClientGdk::contextMenuItemSelected):
        (WebCore::ContextMenuClientGdk::downloadURL):
        (WebCore::ContextMenuClientGdk::copyImageToClipboard):
        (WebCore::ContextMenuClientGdk::searchWithGoogle):
        (WebCore::ContextMenuClientGdk::lookUpInDictionary):
        (WebCore::ContextMenuClientGdk::speak):
        (WebCore::ContextMenuClientGdk::stopSpeaking):
        * page/gdk/EventHandlerGdk.cpp:
        (WebCore::EventHandler::passMouseDownEventToWidget):
        (WebCore::EventHandler::eventActivatedView):
        (WebCore::EventHandler::passSubframeEventToSubframe):
        (WebCore::EventHandler::passWheelEventToWidget):
        (WebCore::EventHandler::createDraggingClipboard):
        * page/qt/EventHandlerQt.cpp:
        * page/qt/FrameQt.cpp:
        * platform/NotImplemented.h: Added.
        * platform/gdk/CursorGdk.cpp:
        (WebCore::Cursor::Cursor):
        * platform/gdk/EditorClientGdk.cpp:
        (WebCore::EditorClientGdk::shouldDeleteRange):
        (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled):
        (WebCore::EditorClientGdk::isGrammarCheckingEnabled):
        (WebCore::EditorClientGdk::spellCheckerDocumentTag):
        (WebCore::EditorClientGdk::shouldBeginEditing):
        (WebCore::EditorClientGdk::shouldEndEditing):
        (WebCore::EditorClientGdk::shouldInsertText):
        (WebCore::EditorClientGdk::shouldChangeSelectedRange):
        (WebCore::EditorClientGdk::shouldApplyStyle):
        (WebCore::EditorClientGdk::didBeginEditing):
        (WebCore::EditorClientGdk::respondToChangedContents):
        (WebCore::EditorClientGdk::respondToChangedSelection):
        (WebCore::EditorClientGdk::didEndEditing):
        (WebCore::EditorClientGdk::didWriteSelectionToPasteboard):
        (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard):
        (WebCore::EditorClientGdk::selectWordBeforeMenuEvent):
        (WebCore::EditorClientGdk::isEditable):
        (WebCore::EditorClientGdk::registerCommandForUndo):
        (WebCore::EditorClientGdk::registerCommandForRedo):
        (WebCore::EditorClientGdk::clearUndoRedoOperations):
        (WebCore::EditorClientGdk::canUndo):
        (WebCore::EditorClientGdk::canRedo):
        (WebCore::EditorClientGdk::undo):
        (WebCore::EditorClientGdk::redo):
        (WebCore::EditorClientGdk::shouldInsertNode):
        (WebCore::EditorClientGdk::pageDestroyed):
        (WebCore::EditorClientGdk::smartInsertDeleteEnabled):
        (WebCore::EditorClientGdk::toggleContinuousSpellChecking):
        (WebCore::EditorClientGdk::handleInputMethodKeypress):
        (WebCore::EditorClientGdk::textFieldDidBeginEditing):
        (WebCore::EditorClientGdk::textFieldDidEndEditing):
        (WebCore::EditorClientGdk::textDidChangeInTextField):
        (WebCore::EditorClientGdk::doTextFieldCommandFromEvent):
        (WebCore::EditorClientGdk::textWillBeDeletedInTextField):
        (WebCore::EditorClientGdk::textDidChangeInTextArea):
        * platform/gdk/FrameGdk.cpp:
        (WebCore::Frame::print):
        (WebCore::Frame::issueTransposeCommand):
        (WebCore::Frame::cleanupPlatformScriptObjects):
        (WebCore::Frame::dragImageForSelection):
        * platform/gdk/NotImplementedGdk.h: Removed.
        * platform/gdk/PopupMenuGdk.cpp:
        (WebCore::PopupMenu::PopupMenu):
        (WebCore::PopupMenu::~PopupMenu):
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::hide):
        (WebCore::PopupMenu::updateFromElement):
        * platform/gdk/RenderThemeGdk.cpp:
        (WebCore::RenderThemeGdk::setCheckboxSize):
        (WebCore::RenderThemeGdk::setRadioSize):
        (WebCore::RenderThemeGdk::adjustTextFieldStyle):
        * platform/gdk/ScreenGdk.cpp:
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        (WebCore::screenRect):
        (WebCore::screenAvailableRect):
        * platform/gdk/ScrollViewGdk.cpp:
        (WebCore::ScrollView::update):
        (WebCore::ScrollView::addChild):
        (WebCore::ScrollView::removeChild):
        (WebCore::ScrollView::scrollRectIntoViewRecursively):
        (WebCore::ScrollView::inWindow):
        (WebCore::ScrollView::wheelEvent):
        (WebCore::ScrollView::updateScrollbars):
        (WebCore::ScrollView::updateScrollInfo):
        (WebCore::ScrollView::windowToContents):
        (WebCore::ScrollView::contentsToWindow):
        (WebCore::ScrollView::scrollbarUnderMouse):
        * platform/gdk/TemporaryLinkStubs.cpp:
        (FrameView::updateBorder):
        (WebCore::findNextWordFromIndex):
        (WebCore::currentTextBreakLocaleID):
        (ChromeClientGdk::chromeDestroyed):
        (ChromeClientGdk::windowRect):
        (ChromeClientGdk::setWindowRect):
        (ChromeClientGdk::pageRect):
        (ChromeClientGdk::scaleFactor):
        (ChromeClientGdk::focus):
        (ChromeClientGdk::unfocus):
        (ChromeClientGdk::createWindow):
        (ChromeClientGdk::createModalDialog):
        (ChromeClientGdk::show):
        (ChromeClientGdk::canRunModal):
        (ChromeClientGdk::runModal):
        (ChromeClientGdk::setToolbarsVisible):
        (ChromeClientGdk::toolbarsVisible):
        (ChromeClientGdk::setStatusbarVisible):
        (ChromeClientGdk::statusbarVisible):
        (ChromeClientGdk::setScrollbarsVisible):
        (ChromeClientGdk::scrollbarsVisible):
        (ChromeClientGdk::setMenubarVisible):
        (ChromeClientGdk::menubarVisible):
        (ChromeClientGdk::setResizable):
        (ChromeClientGdk::closeWindowSoon):
        (ChromeClientGdk::canTakeFocus):
        (ChromeClientGdk::takeFocus):
        (ChromeClientGdk::canRunBeforeUnloadConfirmPanel):
        (ChromeClientGdk::addMessageToConsole):
        (ChromeClientGdk::runBeforeUnloadConfirmPanel):
        (ChromeClientGdk::runJavaScriptAlert):
        (ChromeClientGdk::runJavaScriptConfirm):
        (ChromeClientGdk::runJavaScriptPrompt):
        (ChromeClientGdk::setStatusbarText):
        (ChromeClientGdk::shouldInterruptJavaScript):
        (ChromeClientGdk::tabsToLinks):
        (ChromeClientGdk::windowResizerRect):
        (ChromeClientGdk::addToDirtyRegion):
        (ChromeClientGdk::scrollBackingStore):
        (ChromeClientGdk::updateBackingStore):
        (PlugInInfoStore::createPluginInfoForPluginAtIndex):
        (PlugInInfoStore::pluginCount):
        (WebCore::PlugInInfoStore::supportsMIMEType):
        (WebCore::refreshPlugins):
        (SearchPopupMenu::saveRecentSearches):
        (SearchPopupMenu::loadRecentSearches):
        (SearchPopupMenu::SearchPopupMenu):
        (SearchPopupMenu::enabled):
        (FileChooser::FileChooser):
        (FileChooser::~FileChooser):
        (FileChooser::openFileChooser):
        (FileChooser::basenameForWidth):
        (ResourceHandle::willLoadFromCache):
        (ResourceHandle::loadsBlocked):
        (ResourceHandle::loadResourceSynchronously):
        (Icon::Icon):
        (Icon::~Icon):
        (Icon::newIconForFile):
        (Icon::paint):
        (Font::selectionRectForComplexText):
        (Font::drawComplexText):
        (Font::floatWidthForComplexText):
        (Font::offsetForPositionForComplexText):
        (CachedPage::close):
        (Editor::newGeneralClipboard):
        (Pasteboard::generalPasteboard):
        (Pasteboard::writeSelection):
        (Pasteboard::writeURL):
        (Pasteboard::writeImage):
        (Pasteboard::clear):
        (Pasteboard::canSmartReplace):
        (Pasteboard::documentFragment):
        (Pasteboard::plainText):
        (Pasteboard::Pasteboard):
        (Pasteboard::~Pasteboard):
        (ContextMenu::ContextMenu):
        (ContextMenu::~ContextMenu):
        (ContextMenu::appendItem):
        (ContextMenuItem::ContextMenuItem):
        (ContextMenuItem::~ContextMenuItem):
        (ContextMenuItem::releasePlatformDescription):
        (ContextMenuItem::type):
        (ContextMenuItem::setType):
        (ContextMenuItem::action):
        (ContextMenuItem::setAction):
        (ContextMenuItem::title):
        (ContextMenuItem::setTitle):
        (ContextMenuItem::platformSubMenu):
        (ContextMenuItem::setSubMenu):
        (ContextMenuItem::setChecked):
        (ContextMenuItem::setEnabled):
        (WebCore::supportedKeySizes):
        (WebCore::systemBeep):
        (WebCore::userIdleTime):
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        * platform/graphics/cairo/PathCairo.cpp:
        * platform/graphics/gdk/ImageGdk.cpp:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        * platform/graphics/qt/IconQt.cpp:
        * platform/graphics/qt/ImageQt.cpp:
        * platform/network/gdk/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandle::setDefersLoading):
        * platform/network/gdk/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::setupPUT):
        (WebCore::ResourceHandleManager::setupPOST):
        * platform/network/qt/ResourceHandleQt.cpp:
        * platform/qt/ClipboardQt.cpp:
        * platform/qt/CursorQt.cpp:
        * platform/qt/DragDataQt.cpp:
        * platform/qt/FileChooserQt.cpp:
        * platform/qt/MimeTypeRegistryQt.cpp:
        * platform/qt/PasteboardQt.cpp:
        * platform/qt/PlatformScrollBarQt.cpp:
        * platform/qt/PopupMenuQt.cpp:
        * platform/qt/ScrollViewQt.cpp:
        * platform/qt/TemporaryLinkStubs.cpp:
        * platform/qt/TextBoundaries.cpp:
        * platform/qt/WidgetQt.cpp:
        * platform/win/FontWin.cpp:
        * platform/win/TemporaryLinkStubs.cpp:
        * platform/wx/ClipboardWx.cpp:
        * platform/wx/FontWx.cpp:
        * platform/wx/ScrollViewWx.cpp:
        * platform/wx/SharedTimerWx.cpp:
        * platform/wx/TemporaryLinkStubs.cpp:

WebKitQt:

        Reviewed by Sam Weinig.

        Consolidate all notImplemented() macro definitions into
        one header file for all platforms.

        * WebCoreSupport/ChromeClientQt.cpp:
        * WebCoreSupport/ContextMenuClientQt.cpp:
        * WebCoreSupport/EditorClientQt.cpp:
        * WebCoreSupport/FrameLoaderClientQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - fix a couple ifdefs that said WIN instead of WIN_OS
darin [Sun, 27 May 2007 22:40:20 +0000 (22:40 +0000)]
    - fix a couple ifdefs that said WIN instead of WIN_OS

        * kjs/collector.cpp:
        (KJS::allocateBlock): WIN -> WIN_OS
        (KJS::freeBlock): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
rwlbuis [Sun, 27 May 2007 09:49:36 +0000 (09:49 +0000)]
    Reviewed by Oliver.

        http://bugs.webkit.org/show_bug.cgi?id=13828
        x/y values on rootmost <svg> elements should be ignored

        Make sure that root-most <svg> elements do not take into account x/y.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for radar bug 5219562, PNG isn't displayed on SVG test suite.
hyatt [Sun, 27 May 2007 06:09:36 +0000 (06:09 +0000)]
    Fix for radar bug 5219562, PNG isn't displayed on SVG test suite.
        Improve <object> error handling so that it recovers properly when
        <td> is used inside it.

        Reviewed by olliej

        Added fast/invalid/td-inside-object.html

        * html/HTMLObjectElement.h:
        (WebCore::HTMLObjectElement::tagPriority):
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError):
        * html/HTMLParserErrorCodes.cpp:
        (WebCore::htmlParserErrorMessageTemplate):
        * html/HTMLParserErrorCodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Don't compare the "isset" variables in background layers, since they
hyatt [Sun, 27 May 2007 05:01:15 +0000 (05:01 +0000)]
    Don't compare the "isset" variables in background layers, since they
        lead us to turn off the Aqua look incorrectly, even when the background
        matches the default.

        Reviewed by olliej

        * rendering/RenderStyle.cpp:
        (WebCore::BackgroundLayer::operator==):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Improve the </p> -> <p></p> error message to not spew two errors.
hyatt [Sun, 27 May 2007 04:56:03 +0000 (04:56 +0000)]
    Improve the </p> -> <p></p> error message to not spew two errors.
        Fix a bug where errors reported inside document.write didn't get
        reported as such because of a mistake in the notation of SegmentedString.

        Reviewed by aroben

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::processCloseTag):
        * platform/SegmentedString.h:
        (WebCore::SegmentedSubstring::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd layout test for bug 13887.
hyatt [Sun, 27 May 2007 04:53:13 +0000 (04:53 +0000)]
Add layout test for bug 13887.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 13887, percentage height block not sized correctly inside
hyatt [Sun, 27 May 2007 04:51:43 +0000 (04:51 +0000)]
    Fix for bug 13887, percentage height block not sized correctly inside
        positioned percentage height containing block.

        Reviewed by mitz

        fast/block/positioning/complex-percentage-height.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcPercentageHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver Hunt.
andersca [Sat, 26 May 2007 23:09:53 +0000 (23:09 +0000)]
    Reviewed by Oliver Hunt.

        - finish fixing http://bugs.webkit.org/show_bug.cgi?id=13871
          Box shadow should not apply to Aqua-themed controls

        Covered by fast/forms/box-shadow-override.html

        I forgot to include adjustSliderThumbStyle in the previous patch and the
        test didn't detect it because of a bug introduced in r21739.

        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::adjustSliderThumbStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Sat, 26 May 2007 22:09:26 +0000 (22:09 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - updated tests for http://bugs.webkit.org/show_bug.cgi?id=13876
          Box-Shadow disappears if shadow doesn't fit in the window size

        * fast/repaint/box-shadow-h-expected.checksum:
        * fast/repaint/box-shadow-h-expected.png:
        * fast/repaint/box-shadow-h-expected.txt:
        * fast/repaint/box-shadow-h.html:
        * fast/repaint/box-shadow-v-expected.checksum:
        * fast/repaint/box-shadow-v-expected.png:
        * fast/repaint/box-shadow-v-expected.txt:
        * fast/repaint/box-shadow-v.html:

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13876
          Box-Shadow disappears if shadow doesn't fit in the window size

        Tests: fast/repaint/box-shadow-h.html
               fast/repaint/box-shadow-v.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
weinig [Sat, 26 May 2007 21:57:28 +0000 (21:57 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13854
        Port of commit 667785 from kjs

        - special case calling String.localeCompare() with no parameters to return 0.

        * kjs/string_object.cpp:
        (KJS::StringProtoFunc::callAsFunction):

LayoutTests:

        Reviewed by Darin.

        Update tests http://bugs.webkit.org/show_bug.cgi?id=13854
        Port of commit 667785 from kjs

        - update tests and results to match kde.

        * fast/js/kde/StringObject-expected.txt:
        * fast/js/kde/resources/StringObject.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoVersioning.
bdash [Sat, 26 May 2007 17:38:27 +0000 (17:38 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap [Sat, 26 May 2007 15:36:11 +0000 (15:36 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=13605
        REGRESSION: Browser crashes when switching Kotoeri input modes

        The problem could no longer be reproduced with Kotoeri thanks to
        a fix in <http://trac.webkit.org/projects/webkit/changeset/21728>,
        but we still need to protect from invalid ranges passed from
        input methods.

        Test: editing/input/replace-invalid-range.html

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge selectNSRange:]): Added a null check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago"on this makefile itself"
darin [Sat, 26 May 2007 15:26:25 +0000 (15:26 +0000)]
"on this makefile itself"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
darin [Sat, 26 May 2007 15:24:02 +0000 (15:24 +0000)]
    Reviewed by Tim Hatcher.

        * MigrateHeaders.make: Added dependency on this header file itself, which is
        useful when you change the sed command or other aspect of this file. My build
        failed until I made this fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * platform/network/mac/ResourceResponseMac.mm:
darin [Sat, 26 May 2007 14:40:25 +0000 (14:40 +0000)]
    * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::doUpdateResourceResponse):
        Alexey pointed out that I was wrong about object lifetime, so
        rolling this change out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
darin [Sat, 26 May 2007 14:32:19 +0000 (14:32 +0000)]
    Reviewed by Anders.

        * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::doUpdateResourceResponse):
        Fixed code where a temporary String is used after destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-05-26 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 26 May 2007 13:36:44 +0000 (13:36 +0000)]
2007-05-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=13842
          Simplify Color::light() and Color::dark()

        Not testable.

        * platform/graphics/Color.cpp:
        (WebCore::Color::light):
        (WebCore::Color::dark):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-05-26 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 26 May 2007 13:32:39 +0000 (13:32 +0000)]
2007-05-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13870
          RenderFrameSet should only allow frame and frameset children

        Covered by fast/frames/inline-object-inside-frameset.html

        * rendering/RenderFrame.h:
        (WebCore::RenderFrame::isFrame): Added.
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::paint): Removed check for inline objects that is
        no longer needed.
        (WebCore::RenderFrameSet::isChildAllowed): Added. Allows the child only
        if it is a frame or another frameset.
        * rendering/RenderFrameSet.h:
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isFrame): Added.

2007-05-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - updated test results for http://bugs.webkit.org/show_bug.cgi?id=13870
          RenderFrameSet should only allow frame and frameset children

        * fast/frames/inline-object-inside-frameset-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-05-26 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 26 May 2007 13:29:07 +0000 (13:29 +0000)]
2007-05-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=13871
          Box shadow should not apply to Aqua-themed controls

        Test: fast/forms/box-shadow-override.html

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustCheckboxStyle):
        (WebCore::RenderTheme::adjustRadioStyle):
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::adjustButtonStyle):
        (WebCore::RenderThemeMac::adjustMenuListStyle):
        (WebCore::RenderThemeMac::adjustSliderTrackStyle):
        (WebCore::RenderThemeMac::adjustSearchFieldStyle):
        (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
        (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
        (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
        (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):

2007-05-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=13871
          Box shadow should not apply to Aqua-themed controls

        * fast/forms/box-shadow-override-expected.checksum: Added.
        * fast/forms/box-shadow-override-expected.png: Added.
        * fast/forms/box-shadow-override-expected.txt: Added.
        * fast/forms/box-shadow-override.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-05-26 Holger Freyther <zecke@selfish.org>
bdash [Sat, 26 May 2007 13:14:28 +0000 (13:14 +0000)]
2007-05-26  Holger Freyther  <zecke@selfish.org>

        Reviewed by Anders.

        * platform/gdk/FrameGdk.cpp: Catch up to make it compile
        (WebCore::FrameGdk::FrameGdk): The Settings is now owned by the Page

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver of the Hunt.
weinig [Sat, 26 May 2007 03:06:25 +0000 (03:06 +0000)]
    Reviewed by Oliver of the Hunt.

        Fixed <rdar://problem/5230247> at least 43 xhtml tests fail in
        Leopard because they are being interpreted as html

        Adds a work around for <rdar://problem/5230154> which explicitly
        sets local .xhtml files to have the MIME type application/xhtml+xml.

        * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::doUpdateResourceResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ggaren [Sat, 26 May 2007 00:28:27 +0000 (00:28 +0000)]
WebCore:

        Reviewed by Darin Adler.

        Fixed <rdar://problem/5055182> The page cache has no global cap.

        Beefed up the PageCache class to track which HistoryItems are
        cached, and decide how to evict old HistoryItems as new ones are
        added.

        * history/BackForwardList.cpp: Removed support for managing the page cache
        through the BackForwardList since this is deprecated in Mac's
        WebBackForwardList, and doesn't exist on other platforms.

        Added a Page* back pointer so that Mac WebBackForwardList can still support
        its deprecated API, using the new hotness. This isn't a big burden, since
        Page is responsible for calling BackForwardList::close upon destruction,
        anyway.

        * history/HistoryItem.cpp: Replaced CachedPage* with boolean that tells
        you whether you're in the page cache. This prevents us from having more
        than one persistent repository for cached pages.

        * history/PageCache.cpp: If you're playing along at home, this code is
        the reason for the patch.

        * loader/FrameLoader.cpp: If you're playing along at home, the minuses in
        this file are the reason for the patch.

        Replaced call to FrameLoaderClient::loadedFromCachedPage with its one-line
        implementation because WebCore calling itself through WebKit is uncivilized.

        * page/Settings.cpp: Added support for removing a Page's HistoryItems from
        the page cache.

WebKit:

        Reviewed by Darin Adler.

        Fixed <rdar://problem/5055182> The page cache has no global cap.

        The main WebKit changes are:
            1. Changed -[WebBackForwardList setPageCacheSize] and -[WebBackForwardList
            pageCacheSize] to accomodate the new global page cache model, updating
            their documentation.

            2. Added -[WebPreferences setShouldUsePageCache] and -[WebPreferences
            shouldUsePageCache] as pending public API.

            3. Centralized calculation of object cache and page cache sizes inside
            WebPreferences.

            Cchanged our old behavior of reading a preference and applying a fudge
            factor with a new behavior of just using the preference directly. The
            old behavior was confusing and often inappropriate. (For example, if
            you set a page cache size of 100, a 256MB machine would somewhat
            arbitrarily reduce that number to 98. ???)

        * WebView/WebView.mm: Added support for two flags to determine whether
        to use the page cache. If either -[WebBackForwardList setPageCacheSize:0]
        or -[WebPreferences setShouldUsePageCache:NO] is called, we don't use
        the page cache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca [Fri, 25 May 2007 23:53:39 +0000 (23:53 +0000)]
    Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13869
          Many leaks seen on buildbot after r21735

        - fix another regression from r21739: ::-webkit-slider-thumb style not
          applied.

        Test: fast/forms/slider-thumb-stylability.html

        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::setStyle):
        (WebCore::RenderSlider::createThumbStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin [Fri, 25 May 2007 23:50:00 +0000 (23:50 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - Fix for http://bugs.webkit.org/show_bug.cgi?id=13456
        REGRESSION: setTimeout "arguments" object gets shadowed by a local variable

        - Add a explicit check for arguments. Previously check was done with getDirect,
        but since the arguments is created on-demand in ActivationImp, it doesn't
        show up in the test. 'arguments' should always be in the VarDeclNode's
        evaluation scope.

        * kjs/nodes.cpp:
        (VarDeclNode::evaluate): Additional check if the var decl identifier is 'arguments'

LayoutTests:

        Reviewed by Darin.

        - Test cases for http://bugs.webkit.org/show_bug.cgi?id=13456
          REGRESSION: setTimeout"arguments" object gets shadowed by a local variable

        * fast/js/resources/vardecl-preserve-arguments.js: Added.
        * fast/js/vardecl-preserve-arguments-expected.txt: Added.
        * fast/js/vardecl-preserve-arguments.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
darin [Fri, 25 May 2007 23:45:29 +0000 (23:45 +0000)]
LayoutTests:

        Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=13869
          Many leaks seen on buildbot after r21735

        Added a test that ::-webkit-slider-thumb style is actually applied.

        * fast/forms/slider-thumb-stylability-expected.checksum: Added.
        * fast/forms/slider-thumb-stylability-expected.png: Added.
        * fast/forms/slider-thumb-stylability-expected.txt: Added.
        * fast/forms/slider-thumb-stylability.html: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13869
          Many leaks seen on buildbot after r21735

        - fix another regression from r21739: ::-webkit-slider-thumb style not
          applied.

        Test: fast/forms/slider-thumb-stylability.html

        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::setStyle):
        (WebCore::RenderSlider::createThumbStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
mjs [Fri, 25 May 2007 23:33:41 +0000 (23:33 +0000)]
    Reviewed by Geoff.

        - fix layout test that is failing due to hardcoded file paths in the results by moving it to the http tests

        * fast/history/redirect-load-no-form-restoration-expected.txt: Removed.
        * fast/history/redirect-load-no-form-restoration.html: Removed.
        * fast/history/resources/redirect-load.html: Removed.
        * http/tests/navigation/redirect-load-no-form-restoration-expected.txt: Added.
        * http/tests/redirect-load-no-form-restoration.html: Removed.
        * http/tests/resources/redirect-load.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
kmccullo [Fri, 25 May 2007 23:27:21 +0000 (23:27 +0000)]
LayoutTests:

        Reviewed by .

        - updating previous comment.

        * ChangeLog:

WebCore:

        Reviewed by.

        - Updating previous comment.

        * ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Fri, 25 May 2007 23:21:40 +0000 (23:21 +0000)]
LayoutTests:

        Reviewed by Harrison.

        <rdar://problem/5228141>
        REGRESSION: Can't apply style to selection that ends after an image

        * editing/style/5228141-expected.checksum: Added.
        * editing/style/5228141-expected.png: Added.
        * editing/style/5228141-expected.txt: Added.
        * editing/style/5228141.html: Added.

WebCore:

        Reviewed by Harrison.

        <rdar://problem/5228141>
        REGRESSION: Can't apply style to selection that ends after an image

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyInlineStyle):
        Use range compliant equivalents when creating the Range
        used to compute pastEndNode(), otherwise Range's constructor
        ASSERTs and pastEndNode() returns null. Added a testcase.
        If the incoming Range is collapsed at [br, 0], callers want
        the style to be applied to the br, so expand the Range to include
        it.  We got away without expanding before because pastEndNode
        of a Range from [br, 0] to [br, 0] is the node after the br.
        Using range compliant equivalents changed that. There's already
        test coverage for this change.
        Changed while loop termination for finding the end of a run
        so that we don't process pastEnd.  end.node() may now be
        non-atomic and we'd blow past it. There's already test
        coverage for this change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber stamped by Hyatt
bdakin [Fri, 25 May 2007 23:02:31 +0000 (23:02 +0000)]
    Rubber stamped by Hyatt

        Adding an ASSERT for good measure.

        * page/FrameView.cpp:
        (WebCore::FrameView::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
kmccullo [Fri, 25 May 2007 22:59:47 +0000 (22:59 +0000)]
LayoutTests:

        Reviewed by Geoff.

        - rdar://problem/5183523
        - Change load to check the URL as well as the referrer since it is possilbe to have a referrer which limits a load even thought the URL would allow it. There is a bug about how we need to re-evaluate the whole load architecture: <rdar://problem/5227992> Rethink canLoad() to have a consistent and comprehensive architecture.
        - These tests do not dumpAsText since DRT doesn't seem to be able to handle text in frames.  If it is in the future then these tests already have sufficient text to change to that output and give correct results.

        * fast/dom/frame-loading-via-document-write-expected.txt: Added.
        * fast/dom/frame-loading-via-document-write.html: Added.
        * fast/dom/resources/abe.png: Added.
        * http/tests/security/frame-loading-via-document-write-expected.txt: Added.
        * http/tests/security/frame-loading-via-document-write.html: Added.
        * http/tests/security/resources/abe.png: Added.

WebCore:

        Reviewed by Geoff.

        - rdar://problem/5183523
        - Change load to check the URL as well as the referrer since it is possilbe to have a referrer which limits a load even thought the URL would allow it.  There is a bug about how we need to re-evaluate the whole load architecture: <rdar://problem/5227992> Rethink canLoad() to have a consistent and comprehensive architecture.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadSubframe):
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::canLoad):
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-05-25 George Staikos <staikos@kde.org>
staikos [Fri, 25 May 2007 22:45:22 +0000 (22:45 +0000)]
2007-05-25  George Staikos  <staikos@kde.org>

        Reviewed by Maciej.

        - Use COMPILER(GCC), not PLATFORM(GCC) - as Platform.h defines

        * wtf/FastMalloc.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
andersca [Fri, 25 May 2007 22:43:57 +0000 (22:43 +0000)]
    Reviewed by Brady.

        <rdar://problem/5209536>
        http://bugs.webkit.org/show_bug.cgi?id=13757
        REGRESSION: Leaks seen on buildbot after r21497.

        Fix multipart data loading so it works like Tiger Safari. When one part of a multipart connection has been loaded,
        move the subresource loader from the subresource loaders set and into a special multipart subresource loader set. This set
        is not considered when asking a document loader if it's currently loading.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::stopLoading):
        Always stop the multipart subresource loaders here.

        (WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):
        New function that moves the loader from m_subresourceLoaders to m_multipartSubresourceLoaders and updates the document loader's state.

        * loader/ProgressTracker.cpp:
        (WebCore::ProgressTracker::incrementProgress):
        If a progress item already exists, reuse it. This can happen in some rare circumstances when dealing with multipart data.

        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::didReceiveResponse):
        Call subresourceLoaderFinishedLoadingOnePart if the response is multipart.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin Decker.
thatcher [Fri, 25 May 2007 22:20:55 +0000 (22:20 +0000)]
    Reviewed by Kevin Decker.

        <rdar://problem/5219089> Changes for migration of DictionaryServices

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _lookUpInDictionaryFromMenu:]): look for the HIDictionaryWindowShow symbol in HIToolbox

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/4918397> Exception raise inspecting note contents in the background
pyeh [Fri, 25 May 2007 21:52:51 +0000 (21:52 +0000)]
<rdar://problem/4918397> Exception raise inspecting note contents in the background

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityDescription]):
        Only allow asking the attachmentView for description if attachmentView supports this description attribute

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver Hunt.
ggaren [Fri, 25 May 2007 21:51:16 +0000 (21:51 +0000)]
    Reviewed by Oliver Hunt.

        Fixed global initializer (like you fix a dog).

        I'm not sure how our script missed this. I tested, and it generally doesn't
        seem to work very well.

        * WebView/WebHTMLView.mm: Allocate lazily to avoid the performance hit of
        a global initializer.
        (promisedDataClient):
        (-[WebHTMLViewPrivate dealloc]):
        (-[WebHTMLViewPrivate clear]):
        (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver and Hyatt.
bdakin [Fri, 25 May 2007 21:44:44 +0000 (21:44 +0000)]
    Reviewed by Oliver and Hyatt.

        Fix for <rdar://problem/5228363> REGRESSION: In Mail, attempting to
        create a To Do results in a crash

        This regressed with r21635. Now that -boundingBox updates layout if
        it is needed, we infinitely recurse when Mail draws a custom
        highlight. The fix is to put a guard around laying out the render
        tree.

        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::reset):
        (WebCore::FrameView::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/5221986> selection in web areas doesn't seem to be working for text...
pyeh [Fri, 25 May 2007 21:04:47 +0000 (21:04 +0000)]
<rdar://problem/5221986> selection in web areas doesn't seem to be working for text navigation

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityIsAttributeSettable:]):
        Fixed up incorrect string comparison for AXSelectedTextMarkerRange ax attribute so
        this attribute can actually announce its settability.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin
beidson [Fri, 25 May 2007 20:37:20 +0000 (20:37 +0000)]
    Reviewed by Darin

        <rdar://problem/5228371> - REGRESSION - Certain mail message bodies display as empty

        This is due to http://trac.webkit.org/projects/webkit/changeset/21480 which unintentionally
        made applewebdata urls result in check.call(false) instead of check.call(true)

        Best place for a fix is to have the FrameLoaderClient::canHandleRequest() call return true, which
        really is rooted in WebView

        <rdar://problem/5229587> tracks adding a layout test

        * WebView/WebView.mm:
        (+[WebView _canHandleRequest:]): Return true for applewebdata URLs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - updated tests results that were affected by Hyatt's change to
darin [Fri, 25 May 2007 20:24:34 +0000 (20:24 +0000)]
    - updated tests results that were affected by Hyatt's change to
          turn the odious <script/> quirk back on

        * fast/parser/script-tag-with-trailing-slash-expected.txt: Updated
        test result to reflect now-expected failure. It would be good some
        day to change the test to be more clear that this is working as
        designed.

        * fast/tokenizer/script_extra_close-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - Hixie (who originally wrote this test) and Hyatt say that this
darin [Fri, 25 May 2007 20:19:31 +0000 (20:19 +0000)]
    - Hixie (who originally wrote this test) and Hyatt say that this
          test is invalid, and should be removed -- and it's failing too
          so gotta remove it

        * fast/block/basic/017-expected.checksum: Removed.
        * fast/block/basic/017-expected.png: Removed.
        * fast/block/basic/017-expected.txt: Removed.
        * fast/block/basic/017.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Alice.
darin [Fri, 25 May 2007 20:00:25 +0000 (20:00 +0000)]
    Reviewed by Alice.

        - fix <rdar://problem/5228048> REGRESSION: In a new Mail message, the caret isn't
          immediately inserted when tabbing into or clicking in the message body

        This latent problem was uncovered by <http://trac.webkit.org/projects/webkit/changeset/21476>,
        which removed some code that did extra work whenever setCaretVisible made the caret visible.

        * page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged): Call invalidateCaretRect
        when turning the caret on. All other call sites that touched m_caretPaint were doing
        this, but this was not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Harrison.
darin [Fri, 25 May 2007 19:13:21 +0000 (19:13 +0000)]
    Reviewed by Harrison.

        * DerivedSources.make: Tweaked spelling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTouching this to force DerivedSources.make to rebuild.
thatcher [Fri, 25 May 2007 19:11:33 +0000 (19:11 +0000)]
Touching this to force DerivedSources.make to rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - updated some test results that were affected by Anders's change
darin [Fri, 25 May 2007 19:07:39 +0000 (19:07 +0000)]
    - updated some test results that were affected by Anders's change
          to make image documents use quirks mode

        * dom/xhtml/level2/html/frame-expected.txt: Updated.
        * dom/xhtml/level2/html/iframe-expected.txt: Updated.
        * editing/pasteboard/copy-standalone-image-expected.txt: Updated.
        * fast/events/standalone-image-drag-to-editable-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler, Tim Hatcher.
ggaren [Fri, 25 May 2007 18:59:39 +0000 (18:59 +0000)]
    Reviewed by Darin Adler, Tim Hatcher.

        "unsigned" => "WebNSUInteger" in public API.

        * History/WebBackForwardList.h:
        * WebView/WebScriptDebugDelegate.h:
        * WebView/WebUIDelegate.h:
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Fri, 25 May 2007 18:51:55 +0000 (18:51 +0000)]
LayoutTests:

        Reviewed by Darin.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=13872
          REGRESSION: An empty search field can have a cancel button

        * fast/forms/search-cancel-button-style-sharing-expected.checksum: Added.
        * fast/forms/search-cancel-button-style-sharing-expected.png: Added.
        * fast/forms/search-cancel-button-style-sharing-expected.txt: Added.
        * fast/forms/search-cancel-button-style-sharing.html: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13872
          REGRESSION: An empty search field can have a cancel button

        Test: fast/forms/search-cancel-button-style-sharing.html

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::createCancelButtonStyle): Prevented sharing of
        the cancel button style between search fields that share style, because
        each search field mutates the style to show and hide the cancel button.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix build.
andersca [Fri, 25 May 2007 18:39:35 +0000 (18:39 +0000)]
    Fix build.

        * DumpRenderTree/DumpRenderTree.m:
        * DumpRenderTree/FrameLoadDelegate.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin and Geoff.
harrison [Fri, 25 May 2007 18:04:25 +0000 (18:04 +0000)]
    Reviewed by Kevin and Geoff.

        * DerivedSources.make:
        Add an inclusion guard for CSSGrammar.h and XPathGrammar.h, because older versions of bison do not

        * css/maketokenizer:
        Unconditionally define the flex basic types that are not part of newer versions of flex. Was
        only needed on Linux. Now needed on Mac OS 10.5, and is OK to do on 10.4.9.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ggaren [Fri, 25 May 2007 17:50:03 +0000 (17:50 +0000)]
WebCore:

        Reviewed by Darin Adler.

        Moved JavaScriptCore-related pending public API to public API.

        Moved -JSObject

        * bindings/objc/WebScriptObjectPendingPublic.h: from here
        * bindings/objc/WebScriptObject.h: to here
        * bindings/objc/WebScriptObject.mm: and out of its temporary category

WebKit:

        Reviewed by Darin Adler.

        Moved JavaScriptCore-related pending public API to public API.

        * MigrateHeaders.make: Hack to prevent <JavaScriptCore/JSBase.h> from
        automatically converting to <WebKit/JSBase.h>

        Moved -windowObject and -globalContext

        * WebView/WebFramePrivate.h: from here
        * WebView/WebFrame.h: to here
        * WebView/WebFrame.mm: and out of its temporary category

        Moved -didClearWindowObject:forFrame:

        * WebView/WebViewPrivate.h: from here
        * WebView/WebFrameLoadDelegate.h: to here

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * fast/table/rowindex-comment-nodes-expected.txt: Update to reflect success.
darin [Fri, 25 May 2007 17:43:11 +0000 (17:43 +0000)]
    * fast/table/rowindex-comment-nodes-expected.txt: Update to reflect success.
        A recent check-in fixed this test, but nobody checked in updated results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - updated some test results that were affected by Hyatt's fix for
darin [Fri, 25 May 2007 17:27:33 +0000 (17:27 +0000)]
    - updated some test results that were affected by Hyatt's fix for
          <rdar://problem/5208440> REGRESSION: Raw text needs to be pulled
          outside of tables (13753)

        The whitespace in the DOM has changed the child indices of various elements,
        which shows up in the caret and selection logging.

        * editing/deleting/5026848-2-expected.txt: Updated.
        * editing/deleting/5026848-3-expected.txt: Updated.
        * editing/deleting/5126166-expected.txt: Updated.
        * editing/deleting/delete-block-table-expected.txt: Updated.
        * fast/forms/input-double-click-selection-gap-bug-expected.txt: Updated.
        * fast/replaced/selection-rect-in-table-cell-expected.txt: Updated.
        * fast/text/textIteratorNilRenderer-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
weinig [Fri, 25 May 2007 17:26:32 +0000 (17:26 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=13623 (Decompilation of function
          doesn't compile with "++(x,y)")
        - Create the error node based on the actual node, not the node inside
          parenthesis
        - Fix applies to postfix, prefix and typeof operators
        - Produces run-time ReferenceError like other non-lvalue assignments etc.

        * kjs/grammar.y: Create {Prefix,Postfix}ErrorNode based on the actual node,
        not the based on the node returned by "nodeInsideAllParens()". Same for
        TypeOfValueNode.

LayoutTests:

        Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=13623 (Decompilation of function
          doesn't compile with "++(x,y)")
        - Contains tests for grouping expression that is inside typeof or prefix/postfix
          expression

        * fast/js/resources/toString-prefix-postfix-preserve-parens.js: Added.
        * fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Added.
        * fast/js/toString-prefix-postfix-preserve-parens.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Fri, 25 May 2007 17:14:10 +0000 (17:14 +0000)]
LayoutTests:

        Reviewed by Darin.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=13767
          REGRESSION: Multipart image documents are garbled

        * http/tests/multipart/invalid-image-data-standalone-expected.checksum: Added.
        * http/tests/multipart/invalid-image-data-standalone-expected.png: Added.
        * http/tests/multipart/invalid-image-data-standalone-expected.txt: Added.
        * http/tests/multipart/invalid-image-data-standalone.html: Added.
        * http/tests/multipart/resources/green-100x100.png: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13767
          REGRESSION: Multipart image documents are garbled

        Test: http/tests/multipart/invalid-image-data-standalone.html

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::isLoadingMultipartContent): Added.
        * loader/DocumentLoader.h:
        * loader/ImageDocument.cpp:
        (WebCore::ImageTokenizer::finish): If the image is multipart, make a copy
        of the current part instead of using the resource data, which is going to be
        overwritten by the next part.
        * loader/MainResourceLoader.h:
        (WebCore::MainResourceLoader::isLoadingMultipartContent): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix no-svg build.
andersca [Fri, 25 May 2007 16:52:22 +0000 (16:52 +0000)]
    Fix no-svg build.

        * bindings/js/kjs_html.cpp:
        (KJS::HTMLElementFunction::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
andersca [Fri, 25 May 2007 16:15:19 +0000 (16:15 +0000)]
    Reviewed by Mitz.

        <rdar://problem/5226788> After resizing the window larger than the image, hovering over the image still shows magnify glass

        One part of the bug was already fixed by my previous commit. This fixes the case where the window is sized so the image fit
        after it has been zoomed in.

        * loader/ImageDocument.cpp:
        (WebCore::ImageDocument::windowSizeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders and Tim
sullivan [Fri, 25 May 2007 16:06:51 +0000 (16:06 +0000)]
    Reviewed by Anders and Tim

        - fixed <rdar://problem/5226000> REGRESSION: In Gmail and Mail, a hang occurs when attempting
          to grammar/spellcheck a word in a reply

        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::checkGrammarOfString):
        Fixed recently-introduced false assumption that NSNotFound == -1

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders and Tim
sullivan [Fri, 25 May 2007 16:06:08 +0000 (16:06 +0000)]
    Reviewed by Anders and Tim

        - WebCore change for:
          <rdar://problem/5226000> REGRESSION: In Gmail and Mail, a hang occurs when attempting to grammar/spellcheck a word in a reply

        * editing/Editor.cpp:
        (WebCore::findFirstBadGrammarInRange):
        Use the more obvious way to check whether a range is empty. In this case the more obvious way
        would also have caused no problem to occur. Also added an assertion. Though this change is
        enough to fix the symptom of the bug, the real fix is in WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin (Sorta).
andersca [Fri, 25 May 2007 15:51:44 +0000 (15:51 +0000)]
    Reviewed by Darin (Sorta).

        * loader/ImageDocument.cpp:
        (WebCore::ImageDocument::restoreImageSize):
        Use removeProperty here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoThe http loader should only ask for http cookies. (not, for example, data: cookies)
staikos [Fri, 25 May 2007 15:37:43 +0000 (15:37 +0000)]
The http loader should only ask for http cookies. (not, for example, data: cookies)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFor the keyDown binding use QStringList instead of QList<QString>. The former is...
hausmann [Fri, 25 May 2007 13:37:22 +0000 (13:37 +0000)]
For the keyDown binding use QStringList instead of QList<QString>. The former is a default
registered metatype. Also print out critical messages in dumprendertree's qt message handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix crash in Qt JavaScript bindings when the arguments used on the Qt side are not
hausmann [Fri, 25 May 2007 13:37:09 +0000 (13:37 +0000)]
Fix crash in Qt JavaScript bindings when the arguments used on the Qt side are not
registered with QMetaType.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
ggaren [Fri, 25 May 2007 09:46:53 +0000 (09:46 +0000)]
    Reviewed by Darin Adler.

        Some cleanup to Cache while Fixing <rdar://problem/5055182> The page cache
        has no global cap.

        * loader/Cache.cpp: Removed destructor to help identify this class as a
        singleton.

        * loader/Cache.h: Made constructor and destructor private to match the
        singleton model of PageCache.

        Put structs related to Cache inside its declaration to fix some namespace
        conflicts I had while writing my patch. (They don't exist anymore, but
        I figured this might help future development.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
ggaren [Fri, 25 May 2007 09:13:32 +0000 (09:13 +0000)]
    Reviewed by Darin Adler.

        Fixed a bug with Settings where a number of different objects held bare
        Settings* data members, even though the Page owns the Settings object and
        deletes it upon destruction.

        Added NULL checks since the Page can be deleted before the frame/document.

        * page/Settings.cpp: Removed reliance on setNeedsReapplyStylesForSettingsChange.

        * css/cssstyleselector.cpp: CSSStyleSelector was the worst offender. It
        held a number of back pointers that were not guaranteed. I removed the
        Settings*, Frame*, and FrameView* back pointers, but others could probably
        go, too. I replaced them with a single Document* pointer, which is guaranteed
        because the Document owns the CSSStyleSelector.

        * page/Page.cpp: Removed setNeedsReapplyStylesForSettingsChange -- the
        Settings object is now a proper subcontroller of Page, so it doesn't need
        to use a global table to find its page anymore. Also, this function
        confusingly implied that the Frames in a page can have heterogeneous settings,
        which is not true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
bdakin [Fri, 25 May 2007 07:42:06 +0000 (07:42 +0000)]
    Reviewed by Geoff.

        Fix for <rdar://problem/5023545> QuickBooks Pro 2007:hang/crash
        after closing QuickBooks Tutorial Center with Leopard9A377

        We can hit a race condition where drawRect will be called after the
        WebView has closed. Quickbooks does not properly close the WebView
        and set the UIDelegate to nil, so the UIDelegate is stale and we
        crash. This is a regression because the code that uses the
        UIDelegate in the drawRect code path was only added recently. The
        method that the UIDelegate calls into is new -- it does not exist
        on Tiger -- so there is no harm in not running this code for
        applications linked against older WebKits. Other applications may
        run into this same bug so I am not doing a bundle
        check...particularly because, as I mentioned, the new UIDelegate
        call would not be implemented by older clients anyway.

        * Misc/WebKitVersionChecks.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawSingleRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make sure -webkit-border-fit accounts for padding as well as border.
hyatt [Fri, 25 May 2007 07:07:43 +0000 (07:07 +0000)]
    Make sure -webkit-border-fit accounts for padding as well as border.

        Reviewed by aroben

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::borderFitAdjust):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rework line numbering (again). This time I finally think I have
hyatt [Fri, 25 May 2007 06:58:03 +0000 (06:58 +0000)]
    Rework line numbering (again).  This time I finally think I have
        it right for all the document.write insanity that can occur.

        Reviewed by aroben

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::reportErrorToConsole):
        * html/HTMLParserErrorCodes.cpp:
        (WebCore::htmlParserDocumentWriteMessage):
        * html/HTMLParserErrorCodes.h:
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::write):
        * html/HTMLTokenizer.h:
        (WebCore::HTMLTokenizer::lineNumberPtr):
        (WebCore::HTMLTokenizer::processingContentWrittenByScript):
        * platform/SegementedSring.cpp
        (WebCore::SegmentedString::setExcludeLineNumbers):
        * platform/SegmentedString.h:
        (WebCore::SegmentedSubstring::SegmentedSubstring):
        (WebCore::SegmentedSubstring::clear):
        (WebCore::SegmentedSubstring::excludeLineNumbers):
        (WebCore::SegmentedSubstring::setExcludeLineNumbers):
        (WebCore::SegmentedString::excludeLineNumbers):
        (WebCore::SegmentedString::advance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
ggaren [Fri, 25 May 2007 06:13:23 +0000 (06:13 +0000)]
    Reviewed by Adam Roben.

        Added a debug-only CachedPage counter. This helped me track down an SVG
        timer bug in my recent page cache work.

        * history/CachedPage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Improve <form> error reporting to catch <form>s inside table parts.
hyatt [Fri, 25 May 2007 04:42:11 +0000 (04:42 +0000)]
    Improve <form> error reporting to catch <form>s inside table parts.
        Tweak the wording of some of the error messages to be a bit better.

        Reviewed by olliej

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::insertNode):
        (WebCore::HTMLParser::processCloseTag):
        (WebCore::HTMLParser::popBlock):
        * html/HTMLParserErrorCodes.cpp:
        (WebCore::htmlParserErrorMessageTemplate):
        * html/HTMLParserErrorCodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Fri, 25 May 2007 01:28:55 +0000 (01:28 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Test cases for:
        http://bugs.webkit.org/show_bug.cgi?id=4104
        first-letter not updating style with hover
        http://bugs.webkit.org/show_bug.cgi?id=13169
        css-formatted first letter won't hide dynamically

        * fast/css/first-letter-hover-expected.checksum: Added.
        * fast/css/first-letter-hover-expected.png: Added.
        * fast/css/first-letter-hover-expected.txt: Added.
        * fast/css/first-letter-hover.html: Added.
        * fast/css/first-letter-visibility-expected.checksum: Added.
        * fast/css/first-letter-visibility-expected.png: Added.
        * fast/css/first-letter-visibility-expected.txt: Added.
        * fast/css/first-letter-visibility.html: Added.

WebCore:

        Reviewed by Hyatt.

        http://bugs.webkit.org/show_bug.cgi?id=4104
        first-letter not updating style with hover
        http://bugs.webkit.org/show_bug.cgi?id=13169
        css-formatted first letter won't hide dynamically

        Update first letter when RenderBlock::setStyle is called.

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::checkOneSelector):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::createElement):
        * dom/Document.h:
        (WebCore::Document::usesFirstLetterRules):
        (WebCore::Document::setUsesFirstLetterRules):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::setStyle):
        (WebCore::RenderBlock::updateFirstLetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
weinig [Thu, 24 May 2007 23:57:25 +0000 (23:57 +0000)]
    Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=13823
          REGRESSION: fast/forms/select-item-background-clip.html failing pixel test

        Updated the test and the results.

        * fast/forms/select-item-background-clip-expected.checksum:
        * fast/forms/select-item-background-clip-expected.png:
        * fast/forms/select-item-background-clip-expected.txt:
        * fast/forms/select-item-background-clip.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Thu, 24 May 2007 23:51:23 +0000 (23:51 +0000)]
LayoutTests:

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13800
          REGRESSION: Moving a slider moves another unrelated slider

        * fast/forms/slider-thumb-shared-style-expected.checksum: Added.
        * fast/forms/slider-thumb-shared-style-expected.png: Added.
        * fast/forms/slider-thumb-shared-style-expected.txt: Added.
        * fast/forms/slider-thumb-shared-style.html: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13800
          REGRESSION: Moving a slider moves another unrelated slider

        Test: fast/forms/slider-thumb-shared-style.html

        RenderSlider mutates the thumb's style, therefore it must not be shared
        with another slider's thumb, a situation that could occur if the sliders
        themselves shared style.

        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::createThumbStyle): Always use a private copy for
        the thumb style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Thu, 24 May 2007 23:48:02 +0000 (23:48 +0000)]
LayoutTests:

        Reviewed by Darin.

        Test for <rdar://problem/5211921> Form values sometimes get transposed (iGoogle)

        * fast/history/redirect-load-no-form-restoration-expected.txt: Added.
        * fast/history/redirect-load-no-form-restoration.html: Added.
        * fast/history/resources/redirect-load.html: Added.

WebCore:

        Reviewed by Darin.

        Fix for <rdar://problem/5211921> Form values sometimes get transposed (iGoogle)

        Test: fast/history/redirect-load-no-form-restoration.html

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::setURL): Clear the document state when the url changes for a HistoryItem.
        (WebCore::HistoryItem::isCurrentDocument): Added. Compares the HistoryItem url to the document's url.  This might not be the best way to do this, but it works for now.
        * history/HistoryItem.h:
        * loader/FrameLoader.cpp: (WebCore::FrameLoader::saveDocumentState): Only set the document (and form) state if the document is current for the history item.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin
weinig [Thu, 24 May 2007 23:28:28 +0000 (23:28 +0000)]
    Reviewed by Darin

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13855
        Port patch 666176 to JavaScriptCore

        - Renamed JSValue::downcast() to JSValue::asCell() which makes the
        function meaning cleaner. It's modeled after Harri Porten change in
        KDE trunk.

        * kjs/collector.cpp:
        (KJS::Collector::protect):
        (KJS::Collector::unprotect):
        (KJS::Collector::collectOnMainThreadOnly):
        * kjs/object.h:
        (KJS::JSValue::isObject):
        * kjs/string_object.cpp:
        (KJS::StringProtoFunc::callAsFunction):
        * kjs/value.h:
        (KJS::JSValue::asCell):
        (KJS::JSValue::isNumber):
        (KJS::JSValue::isString):
        (KJS::JSValue::isObject):
        (KJS::JSValue::getNumber):
        (KJS::JSValue::getString):
        (KJS::JSValue::getObject):
        (KJS::JSValue::getUInt32):
        (KJS::JSValue::mark):
        (KJS::JSValue::marked):
        (KJS::JSValue::type):
        (KJS::JSValue::toPrimitive):
        (KJS::JSValue::toBoolean):
        (KJS::JSValue::toNumber):
        (KJS::JSValue::toString):
        (KJS::JSValue::toObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate results for better whitespace handling in framesets and tables.
hyatt [Thu, 24 May 2007 23:20:05 +0000 (23:20 +0000)]
Update results for better whitespace handling in framesets and tables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Thu, 24 May 2007 23:05:47 +0000 (23:05 +0000)]
LayoutTests:

        Reviewed by Adele.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13857
          REGRESSION: onChange function applied to select element executes twice when focus is set

        * fast/forms/select-double-onchange-expected.txt: Added.
        * fast/forms/select-double-onchange.html: Added.

WebCore:

        Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13857
          REGRESSION: onChange function applied to select element executes twice when focus is set

        Test: fast/forms/select-double-onchange.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::menuListOnChange): Changed to update m_lastOnChangeIndex
        before dispatching the change event to avoid reentrancy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate results for better whitespace handling in framesets and tables.
hyatt [Thu, 24 May 2007 22:58:40 +0000 (22:58 +0000)]
Update results for better whitespace handling in framesets and tables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
darin [Thu, 24 May 2007 22:56:33 +0000 (22:56 +0000)]
    Reviewed by Hyatt.

        - fix <rdar://problem/5226451> REGRESSION (21618): Mail block quotes
          are missing the lines on the side

        This patch fixes three problems:

        1) makes the "skip canLoad check" boolean also skip the check
           that prevents any loads while the document is in provisional
           state; this is the proximate cause of the bug

        * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
        Don't check the frame's state if skipCanLoadCheck is true.

        2) moves the "skip canLoad check" boolean to the Request object;
           the old implementation would cause that flag to affect the
           new request we served, which might not be the resource with
           that flag set

        3) fixes error-handling code path that would leak requests

        * html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
        Pass false to the CachedImage constructor to indicate we are not making
        this object for the cache.

        * loader/Cache.cpp:
        (WebCore::createResource): Pass true to the CachedImage constructor to
        indicate we are making this object for the cache.
        (WebCore::Cache::requestResource): Add new code that assumes the object
        will already have the inCache bit set, and that will delete the object
        and return 0 if the cache is disabled and the load failed.

        * loader/CachedImage.h:
        * loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage):
        Added a forCache boolean parameter. Always false for the constructor
        that's only used outside the cache code, and passed in as a boolean
        for the constructor that's used both in cache and outside cache.

        * loader/CachedResource.h:
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::CachedResource): Added a forCache boolean
        parameter that determines the initial state of the m_inCache flag.
        This is needed to prevent a resource from being destroyed if an
        error occurs during the initial load.

        * loader/DocLoader.cpp:
        (WebCore::DocLoader::requestCSSStyleSheet): Added FIXME.
        (WebCore::DocLoader::setLoadInProgress): Added null check.

        * loader/Request.h:
        * loader/Request.cpp: (WebCore::Request::Request):
        Added a shouldSkipCanLoadCheck boolean here, since we need to track
        this for each request.

        * loader/loader.h:
        * loader/loader.cpp:
        (WebCore::Loader::load): Pass the skipCanLoadCheck boolean to the
        Request constructor rather than to the servePendingRequests function.
        (WebCore::Loader::servePendingRequests): Add a loop so we can handle
        cases where the request fails immediately without leaking the request
        and thinking that we're loading forever.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add error reporting for residual style.
hyatt [Thu, 24 May 2007 22:29:00 +0000 (22:29 +0000)]
    Add error reporting for residual style.

        Reviewed by aroben

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
        (WebCore::HTMLParser::reopenResidualStyleTags):
        * html/HTMLParserErrorCodes.cpp:
        (WebCore::htmlParserErrorMessageTemplate):
        * html/HTMLParserErrorCodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
darin [Thu, 24 May 2007 22:13:55 +0000 (22:13 +0000)]
    * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand updated tests.
hyatt [Thu, 24 May 2007 21:49:37 +0000 (21:49 +0000)]
Land updated tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-05-24 Oliver Hunt <oliver@apple.com>
oliver [Thu, 24 May 2007 20:57:00 +0000 (20:57 +0000)]
2007-05-24  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam, Darin, and Geoff.

        Fix for <rdar://problem/5000470> REGRESSION: The IM reconvert
        function returns incorrect symbol due to inconsistent range
        domains in TSM

        Text Services Management uses ranges provided by the
        NSTextInput API to index into the string return by
        -[WebHTMLView string]. As a result some input methods
        incorrectly get their candidate text from the beginning
        of the document instead of from the input element.

        TSM prefers to query -textStorage over -string so as a
        workaround we provide an implementation of -textStorage that
        returns the content of the current text input.  TSM only ever
        queries the result of textStorage as an NSAttributedString so
        we do not need to implement a fake NSTextStorage class

        This should not cause harm to anything else as textStorage is
        actually a method on NSTextView, which we clearly are not. TSM
        only queries the method because it uses respondsToSelector to
        control behaviour.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView textStorage]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Report <script/> as a warning instead of an error for now, since we
hyatt [Thu, 24 May 2007 20:45:26 +0000 (20:45 +0000)]
    Report <script/> as a warning instead of an error for now, since we
        actually do close it.  (Sigh.)

        Reviewed by beth

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::parseToken):
        (WebCore::HTMLParser::reportErrorToConsole):
        * html/HTMLParserErrorCodes.cpp:
        (WebCore::htmlParserErrorMessageTemplate):
        (WebCore::isWarning):
        * html/HTMLParserErrorCodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add error reporting for the </p> -> <p></p> quirk.
hyatt [Thu, 24 May 2007 20:26:31 +0000 (20:26 +0000)]
    Add error reporting for the </p> -> <p></p> quirk.

        Add error reporting when a stray close tag is encountered with no
        corresponding open tag.

        Reviewed by adele

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::HTMLParser):
        (WebCore::HTMLParser::processCloseTag):
        (WebCore::HTMLParser::popBlock):
        * html/HTMLParser.h:
        (WebCore::HTMLParser::popBlock):
        * html/HTMLParserErrorCodes.cpp:
        (WebCore::htmlParserErrorMessageTemplate):
        * html/HTMLParserErrorCodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by.
kmccullo [Thu, 24 May 2007 20:16:03 +0000 (20:16 +0000)]
    Reviewed by.

        - Do you ever feel like Charlie Brown? *sigh*

        * fast/dom/HTMLHeadElement/resources/head-check.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
kmccullo [Thu, 24 May 2007 20:06:56 +0000 (20:06 +0000)]
LayoutTests:

        Reviewed by.

        - Rolling back change to fix the build until I have a good fix for data: urls.

        * ChangeLog:
        * fast/dom/HTMLHeadElement/resources/head-check.js:
        * fast/dom/frame-loading-via-document-write-expected.txt: Removed.
        * fast/dom/frame-loading-via-document-write.html: Removed.
        * fast/dom/resources/frame-loading-via-document-write.js: Removed.
        * fast/dom/resources/green250x50.png: Removed.
        * fast/dom/resources/success.html: Removed.
        * http/tests/security/frame-loading-via-document-write-expected.txt: Removed.
        * http/tests/security/frame-loading-via-document-write.html: Removed.
        * http/tests/security/resources/frame-loading-via-document-write.js: Removed.
        * http/tests/security/resources/success.html: Removed.

WebCore:

        Reviewed by.

        - Rolling back change to fix the build until I have a good fix for data: urls.

        * ChangeLog:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::open):
        * platform/String.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add two more error messages to the HTMLParser.
hyatt [Thu, 24 May 2007 19:54:47 +0000 (19:54 +0000)]
    Add two more error messages to the HTMLParser.

        Report when the </br> -> <br> quirk is triggered.

        Also report whenever the broken XML self-closing tag syntax is used on
        tags that can actually have an end tag (either optional or required).

        Reviewed by aroben

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::parseToken):
        * html/HTMLParserErrorCodes.cpp:
        (WebCore::htmlParserErrorMessageTemplate):
        * html/HTMLParserErrorCodes.h:
        (WebCore::):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseTag):
        * html/HTMLTokenizer.h:
        (WebCore::Token::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
weinig [Thu, 24 May 2007 18:30:27 +0000 (18:30 +0000)]
    Reviewed by Anders.

        Rename JSHTMLFrameSetCustom.cpp to JSHTMLFrameSetElementCustom.cpp
        for consistency.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLFrameSetCustom.cpp: Removed.
        * bindings/js/JSHTMLFrameSetElementCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for <rdar://problem/5208440> (13753)
hyatt [Thu, 24 May 2007 18:26:21 +0000 (18:26 +0000)]
    Fix for <rdar://problem/5208440> (13753)

        REGRESSION: Raw text needs to be pulled outside of tables

        Reviewed by aroben

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError):
        * html/HTMLTableColElement.cpp:
        (WebCore::HTMLTableColElement::checkDTD):
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::checkDTD):
        * html/HTMLTableRowElement.cpp:
        (WebCore::HTMLTableRowElement::checkDTD):
        * html/HTMLTableSectionElement.cpp:
        (WebCore::HTMLTableSectionElement::checkDTD):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21720 268f45cc-cd09-0410-ab3c-d52691b4dbfc