WebKit-https.git
8 years agoREGRESSION: flexbox content-size fails to exclude scrollbar
tony@chromium.org [Wed, 1 Aug 2012 00:54:19 +0000 (00:54 +0000)]
REGRESSION: flexbox content-size fails to exclude scrollbar
https://bugs.webkit.org/show_bug.cgi?id=92667

Reviewed by Ojan Vafai.

Source/WebCore:

In r123909, we switched to computing the height using computeContentLogicalHeightUsing().
Unfortunately, this includes the scrollbar when we want the content height. Add a helper
method for computing the value needed by flexbox.

Test: css3/flexbox/content-height-with-scrollbars.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisContentExtent): Use computeLogicalClientHeight
(WebCore::RenderFlexibleBox::computeLogicalClientHeight): Add new method for taking scrollbar into consideration.
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace): Use computeLogicalClientHeight
(WebCore::RenderFlexibleBox::lineBreakLength): Use computeLogicalClientHeight
* rendering/RenderFlexibleBox.h:

LayoutTests:

Add column flow test cases with scrollbars forced on.

* css3/flexbox/content-height-with-scrollbars-expected.html: Added.
* css3/flexbox/content-height-with-scrollbars.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused method HTMLElementStack::bottom()
commit-queue@webkit.org [Wed, 1 Aug 2012 00:51:51 +0000 (00:51 +0000)]
Remove unused method HTMLElementStack::bottom()
https://bugs.webkit.org/show_bug.cgi?id=92807

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-07-31
Reviewed by Kentaro Hara.

HTMLElementStack::bottom() was replaced with HTMLElementStack::rootNode()
in r80231.

No functional change, so no new tests.

* html/parser/HTMLElementStack.cpp:
* html/parser/HTMLElementStack.h:
(HTMLElementStack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago-webkit-order should take an integer, not a number
tony@chromium.org [Wed, 1 Aug 2012 00:44:18 +0000 (00:44 +0000)]
-webkit-order should take an integer, not a number
https://bugs.webkit.org/show_bug.cgi?id=92688

Reviewed by Ojan Vafai.

Source/WebCore:

The spec changed back from floats to integers:
http://lists.w3.org/Archives/Public/www-style/2012Jul/0607.html

Tests: css3/flexbox/css-properties.html: Updated.
       css3/flexbox/flex-order.html: Test cases modified.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
* rendering/RenderFlexibleBox.cpp:
(WebCore):
(RenderFlexibleBox::OrderHashTraits):
(WebCore::RenderFlexibleBox::OrderHashTraits::emptyValue):
(WebCore::RenderFlexibleBox::OrderHashTraits::constructDeletedValue):
(WebCore::RenderFlexibleBox::OrderHashTraits::isDeletedValue):
(RenderFlexibleBox::OrderIterator):
* rendering/RenderFlexibleBox.h:
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):

LayoutTests:

Update tests.

* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/css-properties.html:
* css3/flexbox/flex-order.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Use skia directly in CCHeadsUpDisplayLayerImpl
jamesr@google.com [Wed, 1 Aug 2012 00:34:43 +0000 (00:34 +0000)]
[chromium] Use skia directly in CCHeadsUpDisplayLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=92810

Reviewed by Adrienne Walker.

The chromium compositor HUD doesn't need to use a full GraphicsContext/etc, all it draws are rectangles and a
simple stroked path. This draws the HUD with straight skia calls and removes the now unnecessary PlatformCanvas
wrapper.

* WebCore.gypi:
* platform/graphics/chromium/PlatformCanvas.cpp: Removed.
* platform/graphics/chromium/PlatformCanvas.h: Removed.
* platform/graphics/chromium/cc/CCFontAtlas.cpp:
(WebCore::CCFontAtlas::drawText):
* platform/graphics/chromium/cc/CCFontAtlas.h:
(CCFontAtlas):
* platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
(WebCore::CCHeadsUpDisplayLayerImpl::willDraw):
(WebCore::CCHeadsUpDisplayLayerImpl::drawHudContents):
(WebCore::CCHeadsUpDisplayLayerImpl::drawFPSCounter):
(WebCore::CCHeadsUpDisplayLayerImpl::drawFPSCounterText):
(WebCore::CCHeadsUpDisplayLayerImpl::drawDebugRects):
* platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
rniwa@webkit.org [Wed, 1 Aug 2012 00:19:37 +0000 (00:19 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-31

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImageCG doesn't initialize m_decodedPropertiesSize in BitmapImage constructor
dino@apple.com [Wed, 1 Aug 2012 00:07:49 +0000 (00:07 +0000)]
ImageCG doesn't initialize m_decodedPropertiesSize in BitmapImage constructor
https://bugs.webkit.org/show_bug.cgi?id=92418

Reviewed by Dan Bernstein.

Tested by existing content.

* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::BitmapImage): initialize m_decodedPropertiesSize to zero.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the Windows build.
weinig@apple.com [Tue, 31 Jul 2012 23:50:04 +0000 (23:50 +0000)]
Fix the Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMaybe fix the GCC build.
ggaren@apple.com [Tue, 31 Jul 2012 23:46:53 +0000 (23:46 +0000)]
Maybe fix the GCC build.

* heap/HeapBlock.h:
(HeapBlock): Accommodate incorrect parsing in GCC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Hit test points are being clipped by layers that should not clip
shawnsingh@chromium.org [Tue, 31 Jul 2012 23:38:39 +0000 (23:38 +0000)]
[chromium] Hit test points are being clipped by layers that should not clip
https://bugs.webkit.org/show_bug.cgi?id=92786

Reviewed by James Robinson.

Source/WebCore:

On impl-side hit testing for chromium compositor, we are
accidentally checking all ancestor layers for clipping, instead of
only layers that actually clip something. This patch fixes it.

Added new unit test that reproduces the scenario:
  CCLayerTreeHostCommonTest.verifyHitTestingForNonClippingIntermediateLayer

* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::pointIsClippedBySurfaceOrClipRect):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp: adds a test where the
  hit-testable layer does not overlap its parent. The parent does
  not clip, so the layer should still be hittable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] REGRESSION(r123644) Compositor HUD crashes immediately with --show-paint...
jamesr@google.com [Tue, 31 Jul 2012 23:31:09 +0000 (23:31 +0000)]
[chromium] REGRESSION(r123644) Compositor HUD crashes immediately with --show-paint-rects
https://bugs.webkit.org/show_bug.cgi?id=92775

Reviewed by Adrienne Walker.

In r123644, the compositor HUD was turned into a normal layer. When the HUD is supposed to cover the entire
viewport - for instance if the showPlatformLayerTree or showDebugRects settings are true -
HeadsUpDisplayLayerChromium's constructor tries to size itself to its layerTreeHost()'s device viewport size.
Unfortunately, its layerTreeHost pointer is always nil in the constructor since the layer is not yet in the
tree. Additionally, this doesn't handle resize at all.

To fix this, this grabs the device viewport size and settings in a LayerChromium::update() OVERRIDE. Also
changes CCLayerTreeHost::willCommit to only reparent the HUD layer if needed instead of on every frame.

Tested manually, we don't have any layout tests for the debug HUD.

* platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp:
(WebCore::HeadsUpDisplayLayerChromium::create):
(WebCore::HeadsUpDisplayLayerChromium::HeadsUpDisplayLayerChromium):
* platform/graphics/chromium/HeadsUpDisplayLayerChromium.h:
(HeadsUpDisplayLayerChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::willCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStop masking 8 bits off of the visited link hash. We need all the bits!
weinig@apple.com [Tue, 31 Jul 2012 23:24:31 +0000 (23:24 +0000)]
Stop masking 8 bits off of the visited link hash. We need all the bits!
https://bugs.webkit.org/show_bug.cgi?id=92799

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

* runtime/Identifier.cpp:
(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierLCharFromUCharTranslator::hash):
* runtime/Identifier.h:
(JSC::IdentifierCharBufferTranslator::hash):
Update for new function names.

Source/WebCore:

* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::urlHostHash):
* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::hashCredentialInfo):
* plugins/blackberry/PluginPackageBlackBerry.cpp:
(WebCore::PluginPackage::hash):
Update for new function names.

Source/WTF:

* wtf/StringHasher.h:
(WTF::StringHasher::hashWithTop8BitsMasked):
(WTF::StringHasher::hash):
(StringHasher):
(WTF::StringHasher::computeHashAndMaskTop8Bits):
(WTF::StringHasher::hashMemory):
(WTF::StringHasher::avalancheBits):
Rename existing computeHash and hash functions to computeHashAndMaskTop8Bits
and hashWithTop8BitsMasked respectively. Add new computeHash and hash functions
that do the StringHash without the masking.

* wtf/text/AtomicString.cpp:
(WTF::CStringTranslator::hash):
(WTF::UCharBufferTranslator::hash):
(WTF::HashAndCharactersTranslator::hash):
(WTF::SubstringTranslator::hash):
(WTF::LCharBufferFromLiteralDataTranslator::hash):
(WTF::AtomicString::fromUTF8Internal):
* wtf/text/StringHash.h:
(WTF::CaseFoldingHash::hash):
* wtf/text/StringImpl.h:
(WTF::StringImpl::setHash):
* wtf/text/StringStatics.cpp:
(WTF::StringImpl::hashSlowCase):
* wtf/unicode/UTF8.cpp:
(WTF::Unicode::calculateStringHashAndLengthFromUTF8MaskingTop8Bits):
* wtf/unicode/UTF8.h:
Update for new function names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: rename worker.py to layout_test_runner.py
dpranke@chromium.org [Tue, 31 Jul 2012 23:20:07 +0000 (23:20 +0000)]
nrwt: rename worker.py to layout_test_runner.py
https://bugs.webkit.org/show_bug.cgi?id=92804

Reviewed by Ojan Vafai.

Home stretch of this round of manager refactoring ... I will be
moving all of the actual test-running code (which includes the
code that shards the tests for the workers) into a different
module, and it makes sense for that module to contain the actual
worker code, so I'm renaming worker.py to layout_test_runner.py.

* Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/worker.py.
(Worker):
(Worker.__init__):
(Worker.__del__):
(Worker.start):
(Worker.handle):
(Worker._update_test_input):
(Worker._run_test):
(Worker.stop):
(Worker._timeout):
(Worker._kill_driver):
(Worker._run_test_with_timeout):
(Worker._clean_up_after_test):
(Worker._run_test_in_another_thread):
(Worker._run_test_in_another_thread.SingleTestThread):
(Worker._run_test_in_another_thread.SingleTestThread.__init__):
(Worker._run_test_in_another_thread.SingleTestThread.run):
(Worker._run_test_in_this_thread):
(Worker._run_single_test):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests.worker_factory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMaybe break the Windows build.
ggaren@apple.com [Tue, 31 Jul 2012 23:07:46 +0000 (23:07 +0000)]
Maybe break the Windows build.

Reviewed by Anders Carlsson.

Formally objected to by Sam Weinig.

* heap/HeapBlock.h:
(HeapBlock): Try to slightly improve this because we don't want Windows to control our lives.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStructures should be swept after all other objects
mhahnenberg@apple.com [Tue, 31 Jul 2012 23:05:12 +0000 (23:05 +0000)]
Structures should be swept after all other objects
https://bugs.webkit.org/show_bug.cgi?id=92679

Reviewed by Filip Pizlo.

In order to get rid of ClassInfo from our objects, we need to be able to safely get the
ClassInfo during the destruction of objects. We'd like to get the ClassInfo out of the
Structure, but currently it is not safe to do so because the order of destruction of objects
is not guaranteed to sweep objects before their corresponding Structure. We can fix this by
sweeping Structures after everything else.

* heap/Heap.cpp:
(JSC::Heap::isSafeToSweepStructures): Add a function that checks if it is safe to sweep Structures.
If the Heap's IncrementalSweeper member is null, that means we're shutting down this VM and it is
safe to sweep structures since we'll always do Structures last anyways due to the ordering of
MarkedSpace::forEachBlock.
(JSC):
(JSC::Heap::didStartVMShutdown): Add this intermediate function to the Heap that ~JSGlobalData now
calls rather than calling the two HeapTimer objects individually. This allows the Heap to null out
these pointers after it has invalidated them to prevent accidental use-after-free in the sweep()
calls during lastChanceToFinalize().
* heap/Heap.h:
(Heap):
* heap/HeapTimer.h:
(HeapTimer):
* heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::structuresCanBeSwept): Determines if it is currently safe to sweep Structures.
This decision is based on whether we have gotten to the end of the vector of blocks that need sweeping
the first time.
(JSC):
(JSC::IncrementalSweeper::doSweep): We add a second pass over the vector to sweep Structures after we
make our first pass. We now null out the slots as we sweep them so that we can quickly find the
Structures during the second pass.
(JSC::IncrementalSweeper::startSweeping): Initialize our new Structure sweeping index.
(JSC::IncrementalSweeper::willFinishSweeping): Callback that is called by MarkedSpace::sweep to notify
the IncrementalSweeper that we are going to sweep all of the remaining blocks in the Heap so it can
assume that everything is taken care of in the correct order. Since MarkedSpace::forEachBlock
iterates over the Structure blocks after all other blocks, the ordering property for sweeping Structures holds.
(JSC::IncrementalSweeper::IncrementalSweeper): Initialize Structure sweeping index.
* heap/IncrementalSweeper.h: Add declarations for new stuff.
(IncrementalSweeper):
* heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper): We now check if the current block only contains structures and
if so and it isn't safe to sweep Structures according to the Heap, we just return early instead of doing
the normal lazy sweep. If this proves to be too much of a waste in the future we can add an extra clause that
will sweep some number of other blocks in place of the current block to mitigate the cost of the floating
Structure garbage.
(JSC::MarkedAllocator::addBlock):
* heap/MarkedAllocator.h:
(JSC::MarkedAllocator::zapFreeList): When we zap the free list in the MarkedAllocator, the current block is no
longer valid to allocate from, so we set the current block to null.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweepHelper): Added a couple assertions to make sure that we weren't trying to sweep Structures
at an unsafe time.
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::sweep): Notify the IncrementalSweeper that the MarkedSpace will finish all currently remaining sweeping.
(JSC):
* heap/MarkedSpace.h:
(JSC):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::~JSGlobalData): Call the new Heap::didStartVMShutdown.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow AudioDestination to support local/live audio input
crogers@google.com [Tue, 31 Jul 2012 23:04:48 +0000 (23:04 +0000)]
Allow AudioDestination to support local/live audio input
https://bugs.webkit.org/show_bug.cgi?id=90318

Reviewed by Kenneth Russell.

Source/Platform:

* chromium/public/WebAudioDevice.h:
(WebKit::WebAudioDevice::RenderCallback::render):
(RenderCallback):

Source/WebCore:

* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* GNUmakefile.list.am:
Add AudioIOCallback.h to make files.

* Modules/webaudio/AudioDestinationNode.h:
* Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::render):
Change provideInput() method to render() to support optional audio input.

(AudioDestinationNode):
(WebCore::AudioDestinationNode::localAudioInputProvider):
Expose public access to an AudioSourceProvider for local/live audio input.

(LocalAudioInputProvider):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::LocalAudioInputProvider):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::set):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::provideInput):
Add simple AudioSourceProvider implementation which dishes out a single AudioBus each
render quantum for optional local/live audio input.

* Modules/webaudio/OfflineAudioDestinationNode.h:
* Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::startRendering):
(WebCore::OfflineAudioDestinationNode::offlineRenderEntry):
(WebCore::OfflineAudioDestinationNode::offlineRender):
Simple name change using "offline" prefix to avoid confusion with AudioDestinationNode::render() method (implementing AudioIOCallback)

* platform/audio/AudioDestination.h:
Switch create() method to take an AudioIOCallback instead of AudioSourceProvider.

* platform/audio/AudioIOCallback.h:
(WebCore::AudioIOCallback::~AudioIOCallback):
Add new AudioIOCallback interface for audio input/output.

* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
* platform/audio/gstreamer/AudioDestinationGStreamer.h:
(AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::callback):
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(_WebKitWebAudioSourcePrivate):
(webKitWebAudioSrcSetProperty):
(webKitWebAudioSrcLoop):
Small tweaks to AudioDestinationGStreamer implementation to account for switch to AudioIOCallback.

* platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationMac::AudioDestinationMac):
(WebCore::AudioDestinationMac::render):
* platform/audio/mac/AudioDestinationMac.h:
(AudioDestinationMac):
Small tweaks to AudioDestinationMac implementation to account for switch to AudioIOCallback.

Source/WebKit/chromium:

* src/AudioDestinationChromium.cpp:
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::provideInput):
(WebCore):
* src/AudioDestinationChromium.h:
(AudioDestinationChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix all the other builds I just broke. Maybe fix the Windows build.
ggaren@apple.com [Tue, 31 Jul 2012 23:00:53 +0000 (23:00 +0000)]
Fix all the other builds I just broke. Maybe fix the Windows build.

* heap/HeapBlock.h:
(HeapBlock): WTF?

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRead tag names and attributes from the saved tokens in HTMLTreeBuilder::processEndTag...
kseo@webkit.org [Tue, 31 Jul 2012 23:00:18 +0000 (23:00 +0000)]
Read tag names and attributes from the saved tokens in HTMLTreeBuilder::processEndTag(AtomicHTMLToken*)
https://bugs.webkit.org/show_bug.cgi?id=92715

Reviewed by Adam Barth.

This is a follow-up patch for r123577. Changed oneBelowTop to return HTMLStackItem*.

No new tests, covered by existing tests.

* html/parser/HTMLConstructionSite.h:
(WebCore::HTMLConstructionSite::oneBelowTop):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::oneBelowTop):
* html/parser/HTMLElementStack.h:
(HTMLElementStack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMaybe fix the Windows build.
ggaren@apple.com [Tue, 31 Jul 2012 22:59:49 +0000 (22:59 +0000)]
Maybe fix the Windows build.

* heap/HeapBlock.h:
(HeapBlock): WTF?

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStyleResolver::canShareStyleWithElement does not need to use getAttribute for classAt...
eric@webkit.org [Tue, 31 Jul 2012 22:55:18 +0000 (22:55 +0000)]
StyleResolver::canShareStyleWithElement does not need to use getAttribute for classAttr in the non-SVG case
https://bugs.webkit.org/show_bug.cgi?id=92687

Reviewed by Antti Koivisto.

Previously 10% of samples in canShareStyleWithElement hit this line, after this change < 1% do.
This is a small speedup for the non-SVG case.  Since this call is made for every element
when style is resolved, any small speedup in this function matters on large documents.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPrefer the Oracle Java plug-in over the Apple Java plug-in
andersca@apple.com [Tue, 31 Jul 2012 22:44:53 +0000 (22:44 +0000)]
Prefer the Oracle Java plug-in over the Apple Java plug-in
https://bugs.webkit.org/show_bug.cgi?id=92780

Reviewed by Oliver Hunt.

* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::findPluginWithBundleIdentifier):
Add a new helper for finding a plug-in with the given bundle identifier.

(WebKit::checkForPreferredPlugin):
Helper function for making sure that an old plug-in is never loaded if a new plug-in is found, and that the old plug-in
is removed from the list of loaded plug-ins if the new plug-in is found.

(WebKit::PluginInfoStore::shouldUsePlugin):
Prefer the Oracle Java plug-in over the Apple Java plug-in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHeap-use-after-free in WebCore::StyleResolver::loadPendingImage
macpherson@chromium.org [Tue, 31 Jul 2012 22:36:20 +0000 (22:36 +0000)]
Heap-use-after-free in WebCore::StyleResolver::loadPendingImage
https://bugs.webkit.org/show_bug.cgi?id=92606

Reviewed by Abhishek Arya.

Source/WebCore:

Changes StyleResolver's m_pendingImageProperties set to a map, such that for each property we keep
a RefPtr to the CSSValue used to set that property. This ensures that CSSValues are not freed before
they are needed by loadPendingImage.

Test: fast/css/variables/deferred-image-load-from-variable.html

* css/StyleResolver.cpp:
* css/StyleResolver.h:

LayoutTests:

Exercises the codepath where an image is loaded using a url specified via a variable.

* fast/css/variables/deferred-image-load-from-variable-expected.txt: Added.
* fast/css/variables/deferred-image-load-from-variable.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaselines.
pkasting@chromium.org [Tue, 31 Jul 2012 22:34:18 +0000 (22:34 +0000)]
[Chromium] Rebaselines.
https://bugs.webkit.org/show_bug.cgi?id=58008
https://bugs.webkit.org/show_bug.cgi?id=81145
https://bugs.webkit.org/show_bug.cgi?id=92537

Unreviewed, test updates.

Mostly rebaselining for
http://src.chromium.org/viewvc/chrome?view=rev&revision=149198 , which
resulted in some i18n font changes due to
http://trac.webkit.org/changeset/83126 .

* fast/dom/52776-expected.txt: Added.
* fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
* platform/chromium-linux-x86/fast/text/international: Removed.
* platform/chromium-linux-x86/fast/text/international/bidi-neutral-run-expected.png: Removed.
* platform/chromium-linux-x86/platform/chromium/compositing: Added.
* platform/chromium-linux-x86/platform/chromium/compositing/scrollbars: Added.
* platform/chromium-linux-x86/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/52776-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/52776-expected.txt:
* platform/chromium-mac-snowleopard/fast/text/complex-text-opacity-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.txt:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-CS-after-AN-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png:
* platform/chromium-mac/fast/dom/52776-expected.png:
* platform/chromium-mac/fast/dom/52776-expected.txt: Removed.
* platform/chromium-mac/fast/text/complex-text-opacity-expected.png:
* platform/chromium-mac/fast/text/complex-text-opacity-expected.txt: Removed.
* platform/chromium-mac/fast/text/international/arabic-justify-expected.png:
* platform/chromium-mac/fast/text/international/arabic-justify-expected.txt: Removed.
* platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.png:
* platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.txt: Removed.
* platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.png:
* platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.txt: Removed.
* platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
* platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
* platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Removed.
* platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.png: Added.
* platform/chromium-win-xp/fast/text/international/bidi-neutral-run-expected.png: Removed.
* platform/chromium/TestExpectations:
* platform/efl/fast/dom/52776-expected.txt: Removed.
* platform/efl/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Removed.
* platform/gtk/fast/dom/52776-expected.txt: Removed.
* platform/gtk/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMaybe fix the Windows build.
ggaren@apple.com [Tue, 31 Jul 2012 22:27:38 +0000 (22:27 +0000)]
Maybe fix the Windows build.

* heap/HeapBlock.h:
(HeapBlock): WTF?

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd stub implementation for MediaStreamAudioSourceNode
crogers@google.com [Tue, 31 Jul 2012 22:07:20 +0000 (22:07 +0000)]
Add stub implementation for MediaStreamAudioSourceNode
https://bugs.webkit.org/show_bug.cgi?id=90110

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/mediastreamaudiosourcenode.html

* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
Add MediaStreamAudioSourceNode files to make files.

* Modules/webaudio/AudioContext.cpp:
* Modules/webaudio/AudioContext.h:
* Modules/webaudio/AudioContext.idl:
(WebCore::AudioContext::createMediaStreamSource):
Add new createMediaStreamSource() method.

* Modules/webaudio/AudioNode.h:
Add NodeTypeMediaStreamAudioSource.

* Modules/webaudio/MediaStreamAudioSourceNode.cpp: Added.
* Modules/webaudio/MediaStreamAudioSourceNode.h: Added.
(WebCore::MediaStreamAudioSourceNode::create):
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
(WebCore::MediaStreamAudioSourceNode::~MediaStreamAudioSourceNode):
(WebCore::MediaStreamAudioSourceNode::setFormat):
(WebCore::MediaStreamAudioSourceNode::process):
(WebCore::MediaStreamAudioSourceNode::reset):
(WebCore::MediaStreamAudioSourceNode::mediaStream):
(WebCore::MediaStreamAudioSourceNode::audioSourceProvider):
Basic MediaStreamAudioSourceNode implementation.

* Modules/webaudio/MediaStreamAudioSourceNode.idl: Added.

LayoutTests:

* webaudio/mediastreamaudiosourcenode-expected.txt: Added.
* webaudio/mediastreamaudiosourcenode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaselines.
pkasting@chromium.org [Tue, 31 Jul 2012 22:00:39 +0000 (22:00 +0000)]
[Chromium] Rebaselines.
https://bugs.webkit.org/show_bug.cgi?id=45991
https://bugs.webkit.org/show_bug.cgi?id=81145
https://bugs.webkit.org/show_bug.cgi?id=82911
http://crbug.com/131187
http://crbug.com/135709
http://crbug.com/139796

Mostly rebaselining in the wake of r124209, with a few other things
mixed in.

* platform/chromium-linux-x86/fast/gradients: Added.
* platform/chromium-linux-x86/fast/gradients/crash-on-zero-radius-expected.png: Added.
* platform/chromium-linux-x86/fast/gradients/generated-gradients-expected.png: Added.
* platform/chromium-linux-x86/fast/gradients/list-item-gradient-expected.png: Added.
* platform/chromium-linux-x86/fast/gradients/simple-gradients-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Removed.
* platform/chromium-linux-x86/svg/as-background-image: Added.
* platform/chromium-linux-x86/svg/as-background-image/svg-as-background-3-expected.png: Added.
* platform/chromium-linux-x86/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Removed.
* platform/chromium-linux/fast/gradients/crash-on-zero-radius-expected.png:
* platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
* platform/chromium-linux/fast/gradients/list-item-gradient-expected.png:
* platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
* platform/chromium-linux/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
* platform/chromium-linux/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium-mac-snowleopard/fast/gradients/generated-gradients-expected.png:
* platform/chromium-mac-snowleopard/fast/gradients/list-item-gradient-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.behind-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.beside-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.shape2-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.touch1-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.touch3-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
* platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.behind-expected.txt: Removed.
* platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.beside-expected.txt: Removed.
* platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt: Removed.
* platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.shape2-expected.txt: Removed.
* platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Removed.
* platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.touch1-expected.txt: Removed.
* platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.touch3-expected.txt: Removed.
* platform/chromium-mac/fast/canvas/canvas-currentColor-expected.txt: Removed.
* platform/chromium-mac/fast/gradients/crash-on-zero-radius-expected.png:
* platform/chromium-mac/fast/gradients/css3-color-stop-units-expected.png: Added.
* platform/chromium-mac/fast/gradients/generated-gradients-expected.png:
* platform/chromium-mac/fast/gradients/list-item-gradient-expected.png:
* platform/chromium-mac/fast/gradients/simple-gradients-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.behind-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.beside-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.shape2-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.touch1-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.touch3-expected.txt: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
* platform/chromium-mac/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium-mac/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
* platform/chromium-mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium-win-xp/svg/as-background-image: Added.
* platform/chromium-win-xp/svg/as-background-image/svg-as-background-3-expected.png: Added.
* platform/chromium-win-xp/svg/as-background-image/svg-as-background-6-expected.png: Added.
* platform/chromium-win-xp/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
* platform/chromium-win/fast/gradients/crash-on-zero-radius-expected.png:
* platform/chromium-win/fast/gradients/generated-gradients-expected.png:
* platform/chromium-win/fast/gradients/list-item-gradient-expected.png:
* platform/chromium-win/fast/gradients/simple-gradients-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
* platform/chromium-win/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFractionalLayoutUnit minor math bugs
allan.jensen@nokia.com [Tue, 31 Jul 2012 21:32:03 +0000 (21:32 +0000)]
FractionalLayoutUnit minor math bugs
https://bugs.webkit.org/show_bug.cgi?id=86065

Reviewed by Levi Weintraub.

Implement a consistent set of subject modifying operators, to ensure
operations that need to be in float are performed in float.

Scale FractionalLayoutSize in FractionalLayoutUnits instead of intergers.

No new functionality. No new tests.

* platform/FractionalLayoutUnit.h:
(WebCore::operator-=):
(WebCore::operator*=):
(WebCore::operator/=):
* platform/graphics/FractionalLayoutSize.h:
(WebCore::FractionalLayoutSize::scale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium-Android] We should hueristically detect content intents on touch
abarth@webkit.org [Tue, 31 Jul 2012 21:29:31 +0000 (21:29 +0000)]
[Chromium-Android] We should hueristically detect content intents on touch
https://bugs.webkit.org/show_bug.cgi?id=92346

Reviewed by Nate Chapin.

On Android, when the user touches a block of text, we run a bunch of
OS-provided hueristics to detect content intents, such as telephone
numbers and mailing addresses.

This patch introduces the WebViewClient functions and the
detectContentIntentOnTouch function, but does not wire the code into
the event system. There are some decisions to make about how to wire it
into the event system, we'll tackle in the next patch.

* public/WebViewClient.h:
(WebKit::WebViewClient::detectContentIntentAround):
(WebViewClient):
(WebKit::WebViewClient::scheduleContentIntent):
(WebKit::WebViewClient::cancelScheduledContentIntents):
* src/WebViewImpl.cpp:
(WebKit):
(WebKit::tapHighlightColorForNode):
(WebKit::WebViewImpl::showTouchHighlightQuads):
(WebKit::WebViewImpl::detectContentIntentOnTouch):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviwed gardening.
senorblanco@chromium.org [Tue, 31 Jul 2012 21:29:03 +0000 (21:29 +0000)]
[chromium] Unreviwed gardening.
Some TestExpectations hygiene.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoved some public data and casting from the Heap
ggaren@apple.com [Tue, 31 Jul 2012 21:26:38 +0000 (21:26 +0000)]
Removed some public data and casting from the Heap
https://bugs.webkit.org/show_bug.cgi?id=92777

Reviewed by Oliver Hunt.

* heap/BlockAllocator.cpp:
(JSC::BlockAllocator::releaseFreeBlocks):
(JSC::BlockAllocator::blockFreeingThreadMain): Use the DeadBlock class
since HeapBlock is a template, and not a class, now. Call destroy()
instead of monkeying around with DeadBlock's internal data because
encapsulation is good.

* heap/BlockAllocator.h:
(DeadBlock): Added a class to represent a dead block, since HeapBlock is
a template now, and can't be instantiated directly.

(JSC::DeadBlock::DeadBlock):
(JSC::DeadBlock::create):
(BlockAllocator):
(JSC::BlockAllocator::allocate):
(JSC::BlockAllocator::deallocate): Use the DeadBlock class because
encapsulation is good.

* heap/CopiedBlock.h:
(CopiedBlock::destroy): No need for a destroy() function, since we
inherit one now.

(JSC::CopiedBlock::CopiedBlock):
(JSC::CopiedBlock::payloadEnd):
(JSC::CopiedBlock::capacity): Updated for some encapsulation inside
HeapBlock.

* heap/CopiedSpace.cpp:
(JSC::CopiedSpace::~CopiedSpace):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::size):
(JSC::CopiedSpace::capacity):
(JSC::isBlockListPagedOut): Removed a bunch of casting. This is no longer
necessary, now that our list and its nodes have the right type.

* heap/CopiedSpace.h: Use the right type in our data structures because
it improves clarity.

* heap/CopiedSpaceInlineMethods.h:
(JSC::CopiedSpace::startedCopying): Use swap to avoid duplicating it.

* heap/HeapBlock.h:
(HeapBlock): Made this a class template so we can return the right type
in linked list operations. Made our data private because encapsulation
is good.

(JSC::HeapBlock::destroy): Since we know our type, we can also eliminate
duplicate destroy() functions in our subclasses.

(JSC::HeapBlock::allocation): Added an accessor so we can hide our data.
By using const, this accessor prevents clients from accidentally deleting
our allocation.

* heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::isPagedOut):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::removeBlock): Removed a bunch of casting. This is
no longer necessary, now that our list and its nodes have the right type.

* heap/MarkedAllocator.h:
(MarkedAllocator):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::forEachBlock): Use the right type, do less casting.

* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::destroy): Removed this function because our parent
class provides it for us now.

(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedBlock.h:
(MarkedBlock):
(JSC::MarkedBlock::capacity): Updated for encapsulation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago [WK2] Use an actual WebProcessProxy when decoding messages
ap@apple.com [Tue, 31 Jul 2012 21:22:37 +0000 (21:22 +0000)]
    [WK2] Use an actual WebProcessProxy when decoding messages
        https://bugs.webkit.org/show_bug.cgi?id=92788

        Reviewed by Anders Carlsson.

        WebContextUserMessageDecoder gets process proxy from a WebContext object, but we
        know which process a message came from, and can just use that.

        * UIProcess/WebContextUserMessageCoders.h:
        (WebKit::WebContextUserMessageDecoder::WebContextUserMessageDecoder):
        (WebKit::WebContextUserMessageDecoder::decode):
        This is the focal point of this patch - decoder no longer needs to call m_context->process().

        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::didReceiveMessage):
        (WebKit::WebContext::didReceiveSyncMessage):
        * UIProcess/WebContext.h:
        These methods now take a WebProcessProxy pointer instead of IPC::Connection,
        so that they can call the updated coder.
        A number of other didReceiveMessage can be modified to take WebProcessProxy later
        if needed (it's a richer interface than IPC::Connection), although not all messages
        come from WebProcesses.

        * UIProcess/WebConnectionToWebProcess.cpp:
        (WebKit::WebConnectionToWebProcess::didReceiveMessage):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::willGoToBackForwardListItem):
        (WebKit::WebPageProxy::registerIntentServiceForFrame):
        (WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
        (WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
        (WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
        (WebKit::WebPageProxy::didCommitLoadForFrame):
        (WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
        (WebKit::WebPageProxy::didFinishLoadForFrame):
        (WebKit::WebPageProxy::didFailLoadForFrame):
        (WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
        (WebKit::WebPageProxy::didReceiveTitleForFrame):
        (WebKit::WebPageProxy::didFirstLayoutForFrame):
        (WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
        (WebKit::WebPageProxy::didNewFirstVisuallyNonEmptyLayout):
        (WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
        (WebKit::WebPageProxy::didDisplayInsecureContentForFrame):
        (WebKit::WebPageProxy::didRunInsecureContentForFrame):
        (WebKit::WebPageProxy::didDetectXSSForFrame):
        (WebKit::WebPageProxy::didReceiveIntentForFrame):
        (WebKit::WebPageProxy::decidePolicyForNavigationAction):
        (WebKit::WebPageProxy::decidePolicyForNewWindowAction):
        (WebKit::WebPageProxy::decidePolicyForResponse):
        (WebKit::WebPageProxy::unableToImplementPolicy):
        (WebKit::WebPageProxy::willSubmitForm):
        (WebKit::WebPageProxy::mouseDidMoveOverElement):
        (WebKit::WebPageProxy::internalShowContextMenu):
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::didReceiveMessage):
        (WebKit::WebProcessProxy::didReceiveSyncMessage):
        Updated arguments accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Tue, 31 Jul 2012 20:55:05 +0000 (20:55 +0000)]
[chromium] Unreviewed gardening.

* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-incremental-repaint-2-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: clean up names in sharding code
dpranke@chromium.org [Tue, 31 Jul 2012 20:50:52 +0000 (20:50 +0000)]
nrwt: clean up names in sharding code
https://bugs.webkit.org/show_bug.cgi?id=92785

Reviewed by Ryosuke Niwa.

More refactoring ... this makes the methods use TestInputs
consistently (and updates the names accordingly) and improves
encapsulation a bit. The sharding code is now pretty
self-contained.

This change adds no new functionality and is covered by the
existing (updated) tests.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(TestShard.visible.__init__):
(TestShard.visible.__repr__):
(Manager._dir_for_test_input):
(Manager._shard_tests):
(Manager._shard_in_two):
(Manager._shard_every_file):
(Manager._shard_by_directory):
(Manager._run_tests):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerWrapper._test_input_for_file):
(ShardingTests.get_shards):
* Scripts/webkitpy/layout_tests/models/test_input.py:
(TestInput.__init__):
(TestInput.__repr__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: clean up TestInputs in preparation for cleaning up sharding
dpranke@chromium.org [Tue, 31 Jul 2012 20:48:56 +0000 (20:48 +0000)]
nrwt: clean up TestInputs in preparation for cleaning up sharding
https://bugs.webkit.org/show_bug.cgi?id=92784

Reviewed by Ryosuke Niwa.

Currently, in order to shard the tests you need to refer to
state in the manager as well as the state in the TestInputs;
this change embeds the necessary state into the TestInputs so
sharding them can be a standalone operation.

The actual clean up of the sharding will follow in a subsequent patch.

Covered by existing tests; no new functionality. However, I did
rework the sharding tests to be less dependent on the test
scaffolding and easier to follow.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._test_input_for_file):
(Manager._shard_in_two):
(Manager._shard_every_file):
(Manager._shard_by_directory):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerWrapper._test_input_for_file):
(ShardingTests.assert_shards):
(ShardingTests.test_shard_by_dir):
(ShardingTests.test_shard_by_dir_sharding_ref_tests):
(ShardingTests.test_shard_every_file):
(ShardingTests.test_shard_in_two):
(ShardingTests.test_shard_in_two_sharding_ref_tests):
(ShardingTests.test_shard_in_two_has_no_unlocked_shards):
(ShardingTests.test_multiple_locked_shards):
* Scripts/webkitpy/layout_tests/models/test_input.py:
(TestInput.__init__):
(TestInput.__repr__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Tue, 31 Jul 2012 20:46:08 +0000 (20:46 +0000)]
[chromium] Unreviewed gardening.

Add new mac baselines for fill-stroke-clip-reset-path.  These have red
squares for the dashboard results, since chrome doesn't support
dashboard mode.  The same had already been done for Win and Linux.

* platform/chromium-mac-snowleopard/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
* platform/chromium-mac/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Dump a backtrace in case of a crash
commit-queue@webkit.org [Tue, 31 Jul 2012 20:30:30 +0000 (20:30 +0000)]
[EFL] Dump a backtrace in case of a crash
https://bugs.webkit.org/show_bug.cgi?id=92489

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-31
Reviewed by Csaba Osztrogonác.

Dump a stack trace in case of a unexpected signal. This should
provide a better report at the build bots when WTR crashes.

* DumpRenderTree/efl/DumpRenderTree.cpp:
(main):
* TestWebKitAPI/efl/InjectedBundleController.cpp:
(TestWebKitAPI::InjectedBundleController::platformInitialize):
* WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp:
(WTR::InjectedBundle::platformInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosuppress gradient tests on skia/mac that have incorrectly "recorded failure", now...
reed@google.com [Tue, 31 Jul 2012 20:24:46 +0000 (20:24 +0000)]
suppress gradient tests on skia/mac that have incorrectly "recorded failure", now that those tests are actually passing (drawing correctly)
https://bugs.webkit.org/show_bug.cgi?id=92787

Reviewed by NOBODY - expectations only

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Enable CSS Filter Effects
commit-queue@webkit.org [Tue, 31 Jul 2012 19:52:34 +0000 (19:52 +0000)]
[BlackBerry] Enable CSS Filter Effects
https://bugs.webkit.org/show_bug.cgi?id=92685

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-31
Reviewed by Rob Buis.

Enable CSS filter effects, with the exception of custom effects (CSS shaders) and reference effects (SVG effects)

.:

Internally reviewed by Arvid Nilsson <anilsson@rim.com> and Antonio Gomes <agomes@rim.com>.

* Source/cmake/OptionsBlackBerry.cmake: Add LayerFilterRenderer
* Source/cmakeconfig.h.cmake: Acknowledge CSS filter effects

Source/WebCore:

No new tests, because this is covered by tests from other platforms.

Internally reviewed by Arvid Nilsson <anilsson@rim.com> and Antonio Gomes <agomes@rim.com>.

* CMakeLists.txt:
* PlatformBlackBerry.cmake:
* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore):
(WebCore::GraphicsLayerBlackBerry::setFilters):
(WebCore::GraphicsLayerBlackBerry::updateFilters):
* platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
(GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::filters):
* platform/graphics/blackberry/LayerCompositingThread.h:
(LayerOverride):
(WebCore):
(WebCore::LayerCompositingThread::filterOperationsChanged):
(WebCore::LayerCompositingThread::setFilterOperationsChanged):
(LayerCompositingThread):
(WebCore::LayerCompositingThread::filterActions):
(WebCore::LayerCompositingThread::setFilterActions):
* platform/graphics/blackberry/LayerData.h:
(LayerData):
(WebCore::LayerData::filters):
* platform/graphics/blackberry/LayerFilterRenderer.cpp: Added.
(WebCore):
(WebCore::operationTypeToProgramID):
(WebCore::Uniformf::Uniformf):
(WebCore::Uniform1f::apply):
(WebCore::Uniform1f::create):
(WebCore::Uniform1f::Uniform1f):
(WebCore::Uniform2f::apply):
(WebCore::Uniform2f::create):
(WebCore::Uniform2f::Uniform2f):
(WebCore::Uniform3f::apply):
(WebCore::Uniform3f::create):
(WebCore::Uniform3f::Uniform3f):
(WebCore::LayerFilterRendererAction::create):
(WebCore::LayerFilterRendererAction::LayerFilterRendererAction):
(WebCore::LayerFilterRendererAction::~LayerFilterRendererAction):
(WebCore::LayerFilterRendererAction::useActionOn):
(WebCore::LayerFilterRenderer::create):
(WebCore::LayerFilterRenderer::LayerFilterRenderer):
(WebCore::LayerFilterRenderer::bindCommonAttribLocation):
(WebCore::LayerFilterRenderer::initializeSharedGLObjects):
(WebCore::LayerFilterRenderer::ping):
(WebCore::LayerFilterRenderer::pong):
(WebCore::LayerFilterRenderer::pushSnapshot):
(WebCore::LayerFilterRenderer::popSnapshot):
(WebCore::LayerFilterRenderer::actionsForOperations):
(WebCore::LayerFilterRenderer::applyActions):
* platform/graphics/blackberry/LayerFilterRenderer.h: Added.
(WebCore):
(Uniformf):
(WebCore::Uniformf::location):
(Uniform1f):
(Uniform2f):
(Uniform3f):
(LayerFilterRendererAction):
(WebCore::LayerFilterRendererAction::shouldPushSnapshot):
(WebCore::LayerFilterRendererAction::setPushSnapshot):
(WebCore::LayerFilterRendererAction::shouldPopSnapshot):
(WebCore::LayerFilterRendererAction::setPopSnapshot):
(WebCore::LayerFilterRendererAction::appendUniform):
(LayerFilterRenderer):
(WebCore::LayerFilterRenderer::isEnabled):
(WebCore::LayerFilterRenderer::disable):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::loadShader):
(WebCore::LayerRenderer::loadShaderProgram):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore):
(WebCore::LayerRenderer::initializeSharedGLObjects):
* platform/graphics/blackberry/LayerRenderer.h:
(LayerRenderer):
* platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
(WebCore):
(WebCore::LayerWebKitThread::filtersCanBeComposited):
* platform/graphics/blackberry/LayerWebKitThread.h:
(LayerWebKitThread):
(WebCore::LayerWebKitThread::setFilters):
* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::resizeContext):
(WebCore::FECustomFilter::bindProgramAndBuffers):
* platform/graphics/filters/FilterOperation.h:
(WebCore):
(FilterOperation):

Tools:

Internally reviewed by Arvid Nilsson <anilsson@rim.com> and Antonio Gomes <agomes@rim.com>.

* Scripts/webkitperl/FeatureList.pm: Acknowledge CSS filter effects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGet rid of "parser" type casts in CSSGrammar.y
alexis.menard@openbossa.org [Tue, 31 Jul 2012 19:50:00 +0000 (19:50 +0000)]
Get rid of "parser" type casts in CSSGrammar.y
https://bugs.webkit.org/show_bug.cgi?id=92760

Reviewed by Adam Barth.

r124099 now type the parser parameter, it is therefore not needed to
cast to CSSParser* everywhere as we know have a CSSParser* type
already.

No new tests : refactor with no behavior change expected.

* css/CSSGrammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: clean up prepare_lists_and_print_output, run, set_up_run a bit
dpranke@chromium.org [Tue, 31 Jul 2012 19:42:55 +0000 (19:42 +0000)]
nrwt: clean up prepare_lists_and_print_output, run, set_up_run a bit
https://bugs.webkit.org/show_bug.cgi?id=92781

Reviewed by Ryosuke Niwa.

More refactoring ... rename prepare_lists_and_print_output to
just prepare_lists so that it only has a single purpose, and
clean up the surrounding code a bit as well.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._collect_tests):
(Manager._prepare_lists):
(Manager._set_up_run):
(Manager.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Use WebAnimation and related classes in GraphicsLayerChromium and AnimTran...
vollick@chromium.org [Tue, 31 Jul 2012 19:38:33 +0000 (19:38 +0000)]
[chromium] Use WebAnimation and related classes in GraphicsLayerChromium and AnimTranslationUtil
https://bugs.webkit.org/show_bug.cgi?id=90468

Reviewed by James Robinson.

Source/Platform:

* Platform.gypi:
* chromium/public/WebAnimation.h:
(WebAnimation):
(WebKit::WebAnimation::WebAnimation):
* chromium/public/WebAnimationDelegate.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationDelegate.h.
(WebKit):
(WebAnimationDelegate):
* chromium/public/WebLayer.h:
(WebKit):
(WebLayer):

Source/WebCore:

No new tests. No new functionality.

* WebCore.gypi:
* platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::appendKeyframe):
(WebCore::WebTransformAnimationCurve):
(WebCore::createWebAnimation):
* platform/graphics/chromium/AnimationTranslationUtil.h:
(WebKit):
(WebCore):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
* platform/graphics/chromium/LayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.h:
(WebKit):
(WebCore):
(WebCore::LayerChromium::setLayerAnimationDelegate):
(LayerChromium):
* platform/graphics/chromium/LinkHighlight.h:
(LinkHighlight):

Source/WebKit/chromium:

* src/WebAnimation.cpp:
(WebKit::WebAnimation::targetProperty):
(WebKit):
(WebKit::WebAnimation::initialize):
* src/WebLayer.cpp:
(WebKit::WebLayer::setAnimationDelegate):
(WebKit):
(WebKit::WebLayer::addAnimation):
(WebKit::WebLayer::removeAnimation):
(WebKit::WebLayer::pauseAnimation):
(WebKit::WebLayer::suspendAnimations):
(WebKit::WebLayer::resumeAnimations):
(WebKit::WebLayer::transferAnimationsTo):
* tests/CCThreadedTest.cpp:
* tests/CCThreadedTest.h:
(TestHooks):
* tests/WebAnimationTest.cpp:
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix potential build error on LocalFileSystem::deleteFileSystem.
commit-queue@webkit.org [Tue, 31 Jul 2012 19:20:31 +0000 (19:20 +0000)]
Fix potential build error on LocalFileSystem::deleteFileSystem.
https://bugs.webkit.org/show_bug.cgi?id=92695

Non-Chrome build of WebKit with FILE_SYSTEM flag will be broken at
LocalFileSystem::deleteFileSystem.
Chrome does not use this source and most of other ports don't turn on
FILE_SYSTEM flag for now. So, we've not seen the breakage explicitly yet.

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-31
Reviewed by Adam Barth.

Non-Chrome WebKit build with FILE_SYSTEM should be finished successfully.

* Modules/filesystem/LocalFileSystem.cpp:
(WebCore::LocalFileSystem::deleteFileSystem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAudioPannerNode should raise exception when distanceModel is set incorrectly
commit-queue@webkit.org [Tue, 31 Jul 2012 19:14:07 +0000 (19:14 +0000)]
AudioPannerNode should raise exception when distanceModel is set incorrectly
https://bugs.webkit.org/show_bug.cgi?id=90952

Patch by Li Yin <li.yin@intel.com> on 2012-07-31
Reviewed by Chris Rogers.

Source/WebCore:

Spec: http://www.w3.org/TR/webaudio/#AudioPannerNode-section
The distance model can be only set to LINEAR_DISTANCE, INVERSE_DISTANCE or EXPONENTIAL_DISTANCE.
If the incorrect value is set, it will raise the exception.
Use the unsigned short to replace unsigned long in AudioPannerNode.idl.

Test: webaudio/audiopannernode-basic.html

* Modules/webaudio/AudioPannerNode.cpp:
(WebCore::AudioPannerNode::setDistanceModel): raise exception
(WebCore):
* Modules/webaudio/AudioPannerNode.h:
(AudioPannerNode):
* Modules/webaudio/AudioPannerNode.idl: using unsigned short to replace unsigned long

LayoutTests:

Spec: http://www.w3.org/TR/webaudio/#AudioPannerNode-section
Add tests for distanceModel,numberOfInputs and numberOfInputs of AudioPannerNode.

* webaudio/audiopannernode-basic-expected.txt: Added.
* webaudio/audiopannernode-basic.html: Added.
* webaudio/panner-set-model-expected.txt: Removed.
* webaudio/panner-set-model.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: clean up self._test_files_list vs. self._test_files, other nits
dpranke@chromium.org [Tue, 31 Jul 2012 19:11:09 +0000 (19:11 +0000)]
nrwt: clean up self._test_files_list vs. self._test_files, other nits
https://bugs.webkit.org/show_bug.cgi?id=92702

Reviewed by Ojan Vafai.

Get rid of self._test_files, rename self._test_files_list to
self._test_names (removing the confusion between the two fields).

Also inline the one call to _parse_expectations, remove the one
use of more_tests_to_skip, and fix a couple of minor nits.

* Scripts/webkitpy/layout_tests/controllers/finder.py:
(LayoutTestFinder.split_into_chunks):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.__init__):
(Manager._collect_tests):
(Manager._http_tests):
(Manager._websocket_tests):
(Manager._is_perf_test):
(Manager.prepare_lists_and_print_output):
(Manager.needs_servers):
(Manager.run):
(Manager._mark_interrupted_tests_as_skipped):
(Manager._update_summary_with_result):
(Manager._upload_json_files):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_interrupt_if_at_failure_limits):
(ManagerTest.test_needs_servers.get_manager_with_tests):
(ManagerTest.test_servers_started):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: --verbose logging does not work right on windows
dpranke@chromium.org [Tue, 31 Jul 2012 19:09:51 +0000 (19:09 +0000)]
nrwt: --verbose logging does not work right on windows
https://bugs.webkit.org/show_bug.cgi?id=92673

Reviewed by Ojan Vafai.

Add a test for r124090.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_verbose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(124116): Number of skipped tests isn't printed anymore
dpranke@chromium.org [Tue, 31 Jul 2012 19:05:27 +0000 (19:05 +0000)]
REGRESSION(124116): Number of skipped tests isn't printed anymore
https://bugs.webkit.org/show_bug.cgi?id=92736

Reviewed by Tony Chang.

Add the skipped number back in; it was useful ... also clean up
the formatting a little bit.

* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_found):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Shaders] CSS parser rejects parameter names that are also CSS keywords
commit-queue@webkit.org [Tue, 31 Jul 2012 19:04:04 +0000 (19:04 +0000)]
[CSS Shaders] CSS parser rejects parameter names that are also CSS keywords
https://bugs.webkit.org/show_bug.cgi?id=92537

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-07-31
Reviewed by Dirk Schulze.

Source/WebCore:

Remove the CSS keyword check for CSS Shaders parameter names. Parameters are allowed to be
any valid CSS identifier, including CSS keywords. See the spec:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/custom/index.html#feCustom

The CSS parser was rejecting input like the following because it uses a CSS keyword
"background" as a parameter name:
-webkit-filter: custom(none url(fragment.shader), background 0 1 0 1);

Test: css3/filters/custom/custom-filter-css-keyword-as-parameter-name.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseCustomFilter): Do not return early when the parameter name is a
CSS keyword (i.e. when the CSSParserValue has a non-zero id).

LayoutTests:

Add a pixel test that uses the CSS keyword "background" as a CSS Shaders parameter name.
Add a parsing test case that uses the CSS keyword "background".

* css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
* css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.txt: Added.
* css3/filters/custom/custom-filter-css-keyword-as-parameter-name.html: Added.
* css3/filters/custom/custom-filter-property-parsing-expected.txt:
* css3/filters/resources/css-keyword-as-parameter-name.fs: Added.
* css3/filters/script-tests/custom-filter-property-parsing.js:
* platform/chromium/TestExpectations:
* platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTypo: doubleTa*b*ZoomAnimationDurationInSeconds in WebViewImpl.cpp
abarth@webkit.org [Tue, 31 Jul 2012 19:01:46 +0000 (19:01 +0000)]
Typo: doubleTa*b*ZoomAnimationDurationInSeconds in WebViewImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=92135

Reviewed by Kentaro Hara.

This patch fixes a typo.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animateZoomAroundPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCaret position is wrong when a editable container has word-wrap:normal set
commit-queue@webkit.org [Tue, 31 Jul 2012 18:56:26 +0000 (18:56 +0000)]
Caret position is wrong when a editable container has word-wrap:normal set
https://bugs.webkit.org/show_bug.cgi?id=89649

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-31
Reviewed by Levi Weintraub.

Source/WebCore:

Correcting the incorrect addumption that the min and max position for the caret rect is constrained to
the logical containing block width. This assumption is incorrect when the text has word-wrap:normal and
flows beyound the visible rect of the container.

Test: editing/input/editable-container-with-word-wrap-normal.html

* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):

LayoutTests:

* editing/input/editable-container-with-word-wrap-normal-expected.txt: Added.
* editing/input/editable-container-with-word-wrap-normal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG OSR exit profiling has unusual oversights
fpizlo@apple.com [Tue, 31 Jul 2012 18:48:17 +0000 (18:48 +0000)]
DFG OSR exit profiling has unusual oversights
https://bugs.webkit.org/show_bug.cgi?id=92728

Reviewed by Geoffrey Garen.

* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in FrameLoader::checkLoadComplete with non-browser client app
antti@apple.com [Tue, 31 Jul 2012 18:47:33 +0000 (18:47 +0000)]
Crash in FrameLoader::checkLoadComplete with non-browser client app
https://bugs.webkit.org/show_bug.cgi?id=92774

Reviewed by Alexey Proskuryakov..

Speculative fix. It is possible that CSSFontSelector could get deleted during the timer callback
and memory reused, making m_document point to some garbage when it is tested at the end.

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::beginLoadTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd MIPS add32 function
commit-queue@webkit.org [Tue, 31 Jul 2012 18:44:03 +0000 (18:44 +0000)]
Add MIPS add32 function
https://bugs.webkit.org/show_bug.cgi?id=91522

Patch by Chao-ying Fu <fu@mips.com> on 2012-07-31
Reviewed by Oliver Hunt.

Add isCompactPtrAlignedAddressOffset.
Add a new version of add32 that accepts AbsoluteAddress as inputs.

* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::isCompactPtrAlignedAddressOffset): New.
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::add32): Support AbsoluteAddress as inputs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Fix crash in InputHandler spell checking.
mifenton@rim.com [Tue, 31 Jul 2012 18:43:02 +0000 (18:43 +0000)]
[BlackBerry] Fix crash in InputHandler spell checking.
https://bugs.webkit.org/show_bug.cgi?id=92763

Reviewed by Antonio Gomes.

PR 185574.

Fix crash in getSpellChecker by guarding the calling paths
to ensure that m_currentFocusElement is valid.

Also add ASSERTs for previous crash.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::getSpellChecker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening of failing tests and new passes
commit-queue@webkit.org [Tue, 31 Jul 2012 18:31:41 +0000 (18:31 +0000)]
[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=92770

Unreviewed gardening.

New baselines, skipped some failing tests and removed test
expectations that are the same as the global expectations.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-31

* platform/efl/TestExpectations:
* platform/efl/compositing/iframes/leave-compositing-iframe-expected.txt: Removed.
* platform/efl/compositing/plugins/1x1-composited-plugin-expected.txt: Removed.
* platform/efl/compositing/plugins/large-to-small-composited-plugin-expected.txt: Removed.
* platform/efl/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
* platform/efl/fast/block/positioning/rtl-fixed-positioning-expected.txt: Removed.
* platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
* platform/efl/fast/forms/listbox-clip-expected.txt: Removed.
* platform/efl/fast/html/details-position-expected.txt: Removed.
* platform/efl/mathml/msub-anonymous-child-render-crash-expected.txt: Removed.
* platform/efl/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Added.
* platform/efl/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeech JavaScript API: Throw exception for start() when already started
hans@chromium.org [Tue, 31 Jul 2012 18:26:45 +0000 (18:26 +0000)]
Speech JavaScript API: Throw exception for start() when already started
https://bugs.webkit.org/show_bug.cgi?id=92756

Reviewed by Adam Barth.

Source/WebCore:

Make the start() function throw an exception if the SpeechRecognition
object was already started.

Test: fast/speech/scripted/start-exception.html

* Modules/speech/SpeechRecognition.cpp:
(WebCore::SpeechRecognition::start):
(WebCore::SpeechRecognition::stopFunction):
(WebCore::SpeechRecognition::abort):
(WebCore::SpeechRecognition::didReceiveError):
(WebCore::SpeechRecognition::didEnd):
(WebCore::SpeechRecognition::SpeechRecognition):
* Modules/speech/SpeechRecognition.h:
(SpeechRecognition):
* Modules/speech/SpeechRecognition.idl:

Tools:

Fix the task queue in MockWebSpeechRecognizer.
It's important that we remove the task from the queue before we run
it, as running the task could alter the queue's state.

* DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
(MockWebSpeechRecognizer::abort):
(MockWebSpeechRecognizer::setError):
(MockWebSpeechRecognizer::clearTaskQueue):
(MockWebSpeechRecognizer::StepTask::runIfValid):
* DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
(MockWebSpeechRecognizer):

LayoutTests:

Layout test for checking that calling start on an already started
SpeechRecognition object throws an exception.

* fast/speech/scripted/start-exception-expected.txt: Added.
* fast/speech/scripted/start-exception.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: move handling the initial list of tests to skip to finder
dpranke@chromium.org [Tue, 31 Jul 2012 18:19:42 +0000 (18:19 +0000)]
nrwt: move handling the initial list of tests to skip to finder
https://bugs.webkit.org/show_bug.cgi?id=92701

Reviewed by Ryosuke Niwa.

More refactoring of manager ...

* Scripts/webkitpy/layout_tests/controllers/finder.py:
(LayoutTestFinder.skip_tests):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._collect_tests):
(Manager.prepare_lists_and_print_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r124207.
zandobersek@gmail.com [Tue, 31 Jul 2012 18:16:48 +0000 (18:16 +0000)]
Unreviewed, rolling out r124207.
http://trac.webkit.org/changeset/124207
https://bugs.webkit.org/show_bug.cgi?id=92773

Patch causes crashes on the 64-bit debug builder (and other
builders likely) (Requested by zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-31

Source/WebCore:

* GNUmakefile.am:
* GNUmakefile.list.am:
* platform/text/gtk/TextCheckerEnchant.cpp: Removed.
* platform/text/gtk/TextCheckerEnchant.h: Removed.

Source/WebKit/gtk:

* webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(createEnchantBrokerIfNeeded):
(freeSpellCheckingLanguage):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(wordEndIsAContractionApostrophe):
(checkSpellingOfString):
(getGuessesForWord):
(getAvailableDictionariesCallback):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] transforms/3d/point-mapping/3d-point-mapping-*.html failing on Win
enne@google.com [Tue, 31 Jul 2012 18:13:41 +0000 (18:13 +0000)]
[Chromium] transforms/3d/point-mapping/3d-point-mapping-*.html failing on Win
https://bugs.webkit.org/show_bug.cgi?id=92707

Unreviewed, updating expectations after r124052.

For efficiency's sake, ScrollbarLayerChromium doesn't draw the top and
bottom part of the track differently on "native" scrollbars. This
changes the way the mock Windows scrollbars look in tests.

* platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png: Removed.
* platform/chromium-win-xp/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Removed.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoinspector/profiler/heap-snapshot-containment-show-all.html test crashing during WebVi...
msaboff@apple.com [Tue, 31 Jul 2012 17:43:30 +0000 (17:43 +0000)]
inspector/profiler/heap-snapshot-containment-show-all.html test crashing during WebView closing
<rdar://problem/11991881>

* platform/mac-lion/Skipped: Added inspector/debugger/debugger-expand-scope.html to skip list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Kill the concept of secondary shared process
ap@apple.com [Tue, 31 Jul 2012 17:42:46 +0000 (17:42 +0000)]
[WK2] Kill the concept of secondary shared process
https://bugs.webkit.org/show_bug.cgi?id=92676

Reviewed by Sam Weinig.

* MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Update Windows build fix.
Don't create a new context for every view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Don't use ninja for building Chromium for Android
peter@chromium.org [Tue, 31 Jul 2012 17:26:50 +0000 (17:26 +0000)]
[Chromium] Don't use ninja for building Chromium for Android
https://bugs.webkit.org/show_bug.cgi?id=92764

Reviewed by Adam Barth.

When Ninja projects files are generated (which will be done for Android),
make sure that the Android builder doesn't unintentionally switch to
using Ninja. We should make that switch at a predetermined time.

* Scripts/webkitdirs.pm:
(buildChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSend an onContextMenu event to the page content
commit-queue@webkit.org [Tue, 31 Jul 2012 17:21:01 +0000 (17:21 +0000)]
Send an onContextMenu event to the page content
so that context menus can be prevented. We use
the node's event handler because we want to use
the fat finger's node. If we use  the EventHandler's
sendContextMenuEvent it will hit test with the mouse
position which may not be what we want.
PR #184032
https://bugs.webkit.org/show_bug.cgi?id=92766

Patch by Genevieve Mak <gmak@rim.com> on 2012-07-31
Reviewed by Antonio Gomes.
Reviewed Internally by Antonio Gomes.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::contextNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] Live stream support is weak
philn@webkit.org [Tue, 31 Jul 2012 17:16:24 +0000 (17:16 +0000)]
[GStreamer] Live stream support is weak
https://bugs.webkit.org/show_bug.cgi?id=90084

Reviewed by Martin Robinson.

Make sure on-disk buffering is disabled for live streams. It is
enabled initially when loading any remote media file if preload is
set to Auto. Later on if the player detects that the media is live
it disables on-disk buffering. This patch also adds support for
caching the total size of the media.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::load): Keep track of the
media url as an instance attribute.
(WebCore::MediaPlayerPrivateGStreamer::duration): Logging improvement.
(WebCore::MediaPlayerPrivateGStreamer::setRate): use the new
isLiveStream() method.
(WebCore::MediaPlayerPrivateGStreamer::buffered): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Indicate
source of duration message.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): Perform an
anonymous duration change emission, mostly to cache its value.
(WebCore::MediaPlayerPrivateGStreamer::totalBytes): Return
cached size when available.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Use the new
isLiveStream() method and handle state change corner cases for live streams.
(WebCore::MediaPlayerPrivateGStreamer::durationChanged): Cache
media total size and re-enable on-disk buffering if caching succeeds.
(WebCore::MediaPlayerPrivateGStreamer::movieLoadType): New
implementation handling on-disk buffered and live streaming cases.
(WebCore::MediaPlayerPrivateGStreamer::setPreload): Remember the
case where preload is updated from Auto to another value, do
on-disk buffering only for Auto preload attribute.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::isLiveStream): Utility
method, a stream is live if it goes to PAUSE without prerolling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Unreviewed gardening, last attempt to paint the WK2 bot green today.
ossy@webkit.org [Tue, 31 Jul 2012 17:02:10 +0000 (17:02 +0000)]
[Qt][WK2] Unreviewed gardening, last attempt to paint the WK2 bot green today.

* platform/qt-5.0-wk2/Skipped: Skip a failing test.
* platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a mechanism to dump the stack trace in case of a crash
commit-queue@webkit.org [Tue, 31 Jul 2012 16:42:20 +0000 (16:42 +0000)]
Add a mechanism to dump the stack trace in case of a crash
https://bugs.webkit.org/show_bug.cgi?id=92666

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-31
Reviewed by Csaba Osztrogonác.

Source/WTF:

Unix based ports can make use of signal handlers to dump the stack
trace in case of a crash. This is specially handy when a test crashes on
the bot without hitting an assertion, we might have a chance to see
some insightful information at the reports.

* wtf/Assertions.cpp:
* wtf/Assertions.h:

Tools:

Move crash signal handlers to WTFInstallReportBacktraceOnCrashHook()
and eliminate some duplicated code.

* DumpRenderTree/qt/main.cpp:
(main):
* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
(WTR::InjectedBundle::platformInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Blackberry][FullScreen] HTML5 <video> controls are scaled differently depending...
tonikitoo@webkit.org [Tue, 31 Jul 2012 16:21:12 +0000 (16:21 +0000)]
[Blackberry][FullScreen] HTML5 <video> controls are scaled differently depending on the current webpage scale
https://bugs.webkit.org/show_bug.cgi?id=90884
PR #162839

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

The way the BlackBerry port implements the FULLSCREEN_API for media
elements might result in the controls being oversized, proportionally
to the current page scale. That happens because the fullscreen element
gets sized to be as big as the viewport size, and the viewport size might
get outstretched to fit to the screen dimensions.

In order to fix that, the patch strips out the Page scale factor from
the media controls multiplier.

Patch also changes many integer-based calculations to be float-based, in
order to get the needed precision.

Internally reviewed by Jacky Jiang.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
(WebCore::determineFullScreenMultiplier):
(WebCore::RenderThemeBlackBerry::adjustSliderThumbSize):
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::adjustSliderTrackStyle):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the clone() method from FilterOperation (and subclasses).
senorblanco@chromium.org [Tue, 31 Jul 2012 16:10:39 +0000 (16:10 +0000)]
Remove the clone() method from FilterOperation (and subclasses).
https://bugs.webkit.org/show_bug.cgi?id=92757

Reviewed by Kentaro Hara.

Since the move to WebFilterOperation in Chromium, this is now dead
code.

Covered by existing tests in css3/filters.

* platform/graphics/filters/CustomFilterOperation.h:
* platform/graphics/filters/FilterOperation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression(r124135): SVG tests crashing on ports using Cairo
commit-queue@webkit.org [Tue, 31 Jul 2012 16:08:56 +0000 (16:08 +0000)]
Regression(r124135): SVG tests crashing on ports using Cairo
https://bugs.webkit.org/show_bug.cgi?id=92752

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-31
Reviewed by Martin Robinson.

* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r124208.
loislo@chromium.org [Tue, 31 Jul 2012 16:05:11 +0000 (16:05 +0000)]
Unreviewed, rolling out r124208.
http://trac.webkit.org/changeset/124208
https://bugs.webkit.org/show_bug.cgi?id=92765

it broke compilation on mac (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-31

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorMemoryAgent.cpp:
(WebCore):
* inspector/MemoryInstrumentationImpl.cpp: Removed.
* inspector/MemoryInstrumentationImpl.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoxmlserializer strips xlink from xlink:html svg image tag
schenney@chromium.org [Tue, 31 Jul 2012 16:02:14 +0000 (16:02 +0000)]
xmlserializer strips xlink from xlink:html svg image tag
https://bugs.webkit.org/show_bug.cgi?id=79586

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Adding code to ensure the correct prefix on attributes in the xml,
xmlns and xlink namespaces. We now follow the rules in
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#serializing-html-fragments
(circa the time of this change).

Rob Buis wrote the original test for this patch and did the initial work.

Tests: fast/dom/XMLSerializer-xml-namespace.html
       svg/custom/xlink-prefix-in-attributes.html

* editing/MarkupAccumulator.cpp:
(WebCore::attributeIsInSerializedNamespace): Test for an attribute in
a specially serialized namespace: xml, xmlns, xlink.
(WebCore):
(WebCore::MarkupAccumulator::appendAttribute): Check the namespace of
attributes upon serialization, and add any necessary prefixes.
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::adjustForeignAttributes): Use WTF::xmlAtom etc for AtomicString arguments.

Source/WTF:

Add WTF::xlinkAtom as a global AtomicString constant.

* wtf/text/AtomicString.h:
(WTF): Add xlinkAtom.
* wtf/text/StringStatics.cpp:
(WTF): Add xlinkAtom.
(WTF::AtomicString::init): Add xlinkAtom.

LayoutTests:

Adding code to ensure the correct prefix on attributes in the xml,
xmlns and xlink namespaces. We now follow the rules in
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#serializing-html-fragments
(circa the time of this change).

Rob Buis wrote the original test for this patch and did the initial work.

* editing/pasteboard/paste-noscript-svg-expected.txt: Updated.
* fast/dom/XMLSerializer-xml-namespace-expected.txt: Added.
* fast/dom/XMLSerializer-xml-namespace.html: Added. Tests serializing attributes with the xml namespace.
* svg/custom/xlink-prefix-in-attributes-expected.txt: Added.
* svg/custom/xlink-prefix-in-attributes.html: Added. Tests serializing attributes in the xmlns and xlink namespaces.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoskia: switch to conical gradient to match css/svg spec for two-point gradients
reed@google.com [Tue, 31 Jul 2012 15:55:48 +0000 (15:55 +0000)]
skia: switch to conical gradient to match css/svg spec for two-point gradients
https://bugs.webkit.org/show_bug.cgi?id=92754

Reviewed by Stephen White.

Source/WebCore:

Switching to skia's TwoPointConical gradient, which has been written explicitly to match the css/svg spec.
Leaving the existing TwoPointRadial gradient in skia, for other callers that may want the old behavior.

No new tests. existing layouttests exercise this change (9 pending rebaselines associated with this CL).

* platform/graphics/skia/GradientSkia.cpp:
(WebCore::Gradient::platformGradient):

LayoutTests:

Update expectations to rebaseline 9 images after this change lands

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: extract MemoryInstrumentationImpl into separate files for future reusi...
loislo@chromium.org [Tue, 31 Jul 2012 15:53:15 +0000 (15:53 +0000)]
Web Inspector: extract MemoryInstrumentationImpl into separate files for future reusing in unit tests
https://bugs.webkit.org/show_bug.cgi?id=92751

Reviewed by Yury Semikhatsky.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorMemoryAgent.cpp:
(WebCore):
* inspector/MemoryInstrumentationImpl.cpp: Added.
(WebCore):
(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::processDeferredInstrumentedPointers):
(WebCore::MemoryInstrumentationImpl::countObjectSize):
(WebCore::MemoryInstrumentationImpl::deferInstrumentedPointer):
(WebCore::MemoryInstrumentationImpl::visited):
(WebCore::MemoryInstrumentationImpl::selfSize):
* inspector/MemoryInstrumentationImpl.h: Added.
(WebCore):
(MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::totalTypeSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add a new and reusable enchant-based spellchecker in WebCore
mario@webkit.org [Tue, 31 Jul 2012 15:51:29 +0000 (15:51 +0000)]
[GTK] Add a new and reusable enchant-based spellchecker in WebCore
https://bugs.webkit.org/show_bug.cgi?id=90269

Reviewed by Martin Robinson.

Source/WebCore:

Move enchant specific code down to WebCore, into a new class
TextCheckerEnchant, that we can use from WK1 and WK2.

* GNUmakefile.am: Add flags to handle the SPELLCHECK feature.
* GNUmakefile.list.am: Added new files.
* platform/text/gtk/TextCheckerEnchant.cpp: Added.
(getAvailableDictionariesCallback):
(TextCheckerEnchant::TextCheckerEnchant):
(TextCheckerEnchant::~TextCheckerEnchant):
(TextCheckerEnchant::ignoreWord):
(TextCheckerEnchant::learnWord):
(TextCheckerEnchant::checkSpellingOfString):
(TextCheckerEnchant::getGuessesForWord):
(TextCheckerEnchant::updateSpellCheckingLanguages):
(TextCheckerEnchant::freeEnchantBrokerDictionaries):
* platform/text/gtk/TextCheckerEnchant.h: Added.
(WebCore):
(TextCheckerEnchant):
(WebCore::TextCheckerEnchant::create):

Source/WebKit/gtk:

Remove enchant specific code from WebKitSpellCheckerEnchant and
implement it relying in the new TextCheckerEnchant class in WebCore.

* webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(checkSpellingOfString):
(getGuessesForWord):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, rebaseline fast/ruby/overhang-horizontal.html.
apavlov@chromium.org [Tue, 31 Jul 2012 15:44:32 +0000 (15:44 +0000)]
[Chromium] Unreviewed, rebaseline fast/ruby/overhang-horizontal.html.

* platform/chromium-win/fast/ruby/overhang-horizontal-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Support Negotiate auth
commit-queue@webkit.org [Tue, 31 Jul 2012 15:41:12 +0000 (15:41 +0000)]
[BlackBerry] Support Negotiate auth
https://bugs.webkit.org/show_bug.cgi?id=91871

Patch by Joe Mason <jmason@rim.com> on 2012-07-31
Reviewed by George Staikos.

Add Negotiate to the list of auth schemes allowed in the platform request.

Add "success" and "requireCredentials" parameters to notifyAuthReceived (which is now called
with success = true on successful authentication, as well as on failures).

When success is true, update the stored credential to use the auth scheme actually reported
rather than that set in the request. (This is used when Negotiate auth can't get a ticket
and falls back to a different supported auth type.)

When requireCredentials is false, just set the auth type and start a new request using empty
credentials.

RIM PR# 166514
Internally reviewed by Jonathan Dong

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived): Add Negotiate to the auth scheme switch. Handle
success param by updating auth type in stored credentials; pass requireCredentials param on
to sendRequestWithCredentials.
(WebCore::NetworkJob::startNewJobWithRequest): Fix typo in increaseRedirectCount parameter
name.
(WebCore::NetworkJob::sendRequestWithCredentials): Use empty credentials if
requireCredentials is false.
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):
* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob): Add Negotiate to the auth scheme switch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, skip new failing tests.
ossy@webkit.org [Tue, 31 Jul 2012 15:37:40 +0000 (15:37 +0000)]
[Qt] Unreviewed gardening, skip new failing tests.

* platform/qt/Skipped:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Unreviewed gardening. Skip failing tests and remove unnecessary expected...
ossy@webkit.org [Tue, 31 Jul 2012 15:20:54 +0000 (15:20 +0000)]
[Qt][WK2] Unreviewed gardening. Skip failing tests and remove unnecessary expected files. (bug85203)

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Removed.
* platform/qt-5.0-wk2/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/dynamic/008-expected.png: Removed.
* platform/qt-5.0-wk2/fast/dynamic/008-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/parser/entity-comment-in-textarea-expected.png: Removed.
* platform/qt-5.0-wk2/fast/parser/entity-comment-in-textarea-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/parser/open-comment-in-textarea-expected.png: Removed.
* platform/qt-5.0-wk2/fast/parser/open-comment-in-textarea-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, rebaseline some platform/chromium/virtual/gpu/fast/canvas...
apavlov@chromium.org [Tue, 31 Jul 2012 15:15:28 +0000 (15:15 +0000)]
[Chromium] Unreviewed, rebaseline some platform/chromium/virtual/gpu/fast/canvas tests due to antialiasing changes.

* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/arc360-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-skewed-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/arc360-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-skewed-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: take into account the whole security origin instead of just host
commit-queue@webkit.org [Tue, 31 Jul 2012 15:05:44 +0000 (15:05 +0000)]
Web Inspector: take into account the whole security origin instead of just host
https://bugs.webkit.org/show_bug.cgi?id=92740

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-31
Reviewed by Pavel Feldman.

Source/WebCore:

Make the DOM Storage Agent take into account all the
information relevant to the security origin, i.e. protocol, host, and
port. Previously only the host was taken into account. That caused
inspector to show the first storage only in the case a page operated
over several security origins sharing the same host (but having
different protocols e.g. http and https).

* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::isSameOriginAndType):
(WebCore::InspectorDOMStorageResource::bind):
* inspector/InspectorDOMStorageResource.h:
(InspectorDOMStorageResource):

LayoutTests:

* http/tests/inspector-enabled/dom-storage-open-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Visible content rect update with null trajectory vector does not reach the...
abecsi@webkit.org [Tue, 31 Jul 2012 14:41:37 +0000 (14:41 +0000)]
[WK2] Visible content rect update with null trajectory vector does not reach the backing store
https://bugs.webkit.org/show_bug.cgi?id=92750

Reviewed by Jocelyn Turcotte.

Make sure that notifications with a null trajectory vector reach the backing store
since a null vector means that all tiles around the viewport were requested.

* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::setVisibleContentsRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Backing store output flickers when using WebPageCompositor
commit-queue@webkit.org [Tue, 31 Jul 2012 14:35:24 +0000 (14:35 +0000)]
[BlackBerry] Backing store output flickers when using WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=90291

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-07-31
Reviewed by Antonio Gomes.

The backing store doesn't know when the API client swaps the buffers,
so it doesn't know when to signal the blit generation condition
variable. Fixed by using EGL fence sync instead, when available, so we
don't have to know.

Reviewed internally by Filip Spacek.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):
* Api/BackingStore_p.h:
(BackingStorePrivate):
* WebKitSupport/BackingStoreTile.cpp:
(BlackBerry::WebKit::TileBuffer::TileBuffer):
* WebKitSupport/BackingStoreTile.h:
(BlackBerry::WebKit::TileBuffer::syncObject):
(BlackBerry::WebKit::TileBuffer::setSyncObject):
(TileBuffer):
* WebKitSupport/SurfacePool.cpp:
(WebKit):
(BlackBerry::WebKit::SurfacePool::SurfacePool):
(BlackBerry::WebKit::SurfacePool::initialize):
(BlackBerry::WebKit::SurfacePool::waitForBuffer):
(BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
* WebKitSupport/SurfacePool.h:
(SurfacePool):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSlider ticks are drawn at wrong positions
keishi@webkit.org [Tue, 31 Jul 2012 13:50:39 +0000 (13:50 +0000)]
Slider ticks are drawn at wrong positions
https://bugs.webkit.org/show_bug.cgi?id=92720

Reviewed by Kent Tamura.

Source/WebCore:

Slider tick marks for vertical sliders were drawn reversed. And the tick
mark positions were slightly off from the thumb position because of rounding.

No new tests. Covered in input-appearance-range-with-datalist.html.

* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):

LayoutTests:

* fast/forms/datalist/input-appearance-range-with-datalist.html: Added values to input elements so we can see if the slider thumb position matches with the tick marks.
* platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
* platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
* platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
* platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Input method update should also include hints
commit-queue@webkit.org [Tue, 31 Jul 2012 13:42:08 +0000 (13:42 +0000)]
[Qt] Input method update should also include hints
https://bugs.webkit.org/show_bug.cgi?id=92744

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-07-31
Reviewed by Simon Hausmann.

The QInputMethod is told to query for input method hints when updated.

* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::updateTextInputState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOlder ShadowDOM is still rendered when a new ShadowDOM is added when they don't have...
shinyak@chromium.org [Tue, 31 Jul 2012 13:15:26 +0000 (13:15 +0000)]
Older ShadowDOM is still rendered when a new ShadowDOM is added when they don't have any InsertionPoints.
https://bugs.webkit.org/show_bug.cgi?id=92456

Reviewed by Hajime Morita.

Source/WebCore:

When adding a new ShadowRoot to an element having other ShadowRoots, and they don't have any InsretionPoint,
the older ShadowDOM is still rendered.

When ContentDistributor's validity is 'Undetermined', ElementShadow reattaches the host and the whole shadow
subtree. Since adding a new ShadowRoot makes the validity 'Undetermined', we have had to make it 'Undetermined'.

This change enables us to remove a unnecessary InvalidationType flag from the code. We should call
setValidityUndetermined() instead of using InvalidateAndForceReattach.

Test: fast/dom/shadow/invalidate-distribution.html

* dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot): Calls setValidityUndetermined().
(WebCore::ElementShadow::removeAllShadowRoots):
(WebCore::ElementShadow::setValidityUndetermined):
(WebCore::ElementShadow::invalidateDistribution): When validity is undetermined, we will reattach the
host and the shadow subtree.
* dom/ElementShadow.h:
(ElementShadow):
* html/shadow/ContentDistributor.cpp:
* html/shadow/ContentDistributor.h:
(WebCore::ContentDistributor::setValidity):
(ContentDistributor):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::insertedInto): Calls setValidityUndetermined().

LayoutTests:

* fast/dom/shadow/invalidate-distribution-expected.html: Added.
* fast/dom/shadow/invalidate-distribution.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] move EventSender into TestRunner.a
jochen@chromium.org [Tue, 31 Jul 2012 13:02:39 +0000 (13:02 +0000)]
[chromium] move EventSender into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=92277

Reviewed by Adam Barth.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/chromium/TestRunner/EventSender.cpp: Renamed from Tools/DumpRenderTree/chromium/EventSender.cpp.
* DumpRenderTree/chromium/TestRunner/EventSender.h: Renamed from Tools/DumpRenderTree/chromium/EventSender.h.
* DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
(TestInterfaces::Internal::eventSender):
(TestInterfaces::Internal):
(TestInterfaces::Internal::Internal):
(TestInterfaces::Internal::~Internal):
(TestInterfaces::Internal::setWebView):
(TestInterfaces::Internal::setDelegate):
(TestInterfaces::Internal::bindTo):
(TestInterfaces::Internal::resetAll):
(TestInterfaces::eventSender):
* DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
(TestInterfaces):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::eventSender):
(TestShell):
* DumpRenderTree/chromium/WebViewHost.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, remove unnecessary expected files.
ossy@webkit.org [Tue, 31 Jul 2012 12:57:34 +0000 (12:57 +0000)]
[Qt] Unreviewed gardening, remove unnecessary expected files.

* platform/qt-5.0/fast/css/beforeSelectorOnCodeElement-expected.txt: Removed.
* platform/qt-5.0/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Removed.
* platform/qt-5.0/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Removed.
* platform/qt-5.0/fast/dynamic/008-expected.png: Removed.
* platform/qt-5.0/fast/dynamic/008-expected.txt: Removed.
* platform/qt-5.0/fast/html/font-weight-bold-for-b-and-strong-expected.png: Removed.
* platform/qt-5.0/fast/html/font-weight-bold-for-b-and-strong-expected.txt: Removed.
* platform/qt-5.0/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntroduce a minimal RTCPeerConnection together with Dictionary changes
tommyw@google.com [Tue, 31 Jul 2012 11:59:37 +0000 (11:59 +0000)]
Introduce a minimal RTCPeerConnection together with Dictionary changes
https://bugs.webkit.org/show_bug.cgi?id=92380

Reviewed by Kentaro Hara.

Source/WebCore:

This patch introduces a shell RTCPeerConnection together with neccecary changes to
Dictionary.

The W3C specification can be found here:
http://dev.w3.org/2011/webrtc/editor/webrtc.html#rtcpeerconnection

Since Dictionaries can't be fully copied around adding
get(const String& name, Vector<Dictionary>& result)
isn't feasible so I have added a new ArrayValue class.

Test: fast/mediastream/RTCPeerConnection.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/mediastream/DOMWindowMediaStream.idl:
* Modules/mediastream/RTCPeerConnection.cpp: Added.
(WebCore):
(RTCIceServer):
(WebCore::RTCIceServer::create):
(WebCore::RTCIceServer::~RTCIceServer):
(WebCore::RTCIceServer::uri):
(WebCore::RTCIceServer::credential):
(WebCore::RTCIceServer::RTCIceServer):
(RTCConfiguration):
(WebCore::RTCConfiguration::create):
(WebCore::RTCConfiguration::~RTCConfiguration):
(WebCore::RTCConfiguration::appendServer):
(WebCore::RTCConfiguration::numberOfServers):
(WebCore::RTCConfiguration::server):
(WebCore::RTCConfiguration::RTCConfiguration):
(WebCore::RTCPeerConnection::parseConfiguration):
(WebCore::RTCPeerConnection::create):
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::~RTCPeerConnection):
(WebCore::RTCPeerConnection::interfaceName):
(WebCore::RTCPeerConnection::scriptExecutionContext):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::eventTargetData):
(WebCore::RTCPeerConnection::ensureEventTargetData):
* Modules/mediastream/RTCPeerConnection.h: Added.
(WebCore):
(RTCPeerConnection):
(WebCore::RTCPeerConnection::refEventTarget):
(WebCore::RTCPeerConnection::derefEventTarget):
* Modules/mediastream/RTCPeerConnection.idl: Added.
* Target.pri:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitRTCPeerConnectionEnabled):
* bindings/js/ArrayValue.cpp: Added.
(WebCore):
(WebCore::ArrayValue::ArrayValue):
(WebCore::ArrayValue::operator=):
(WebCore::ArrayValue::isUndefinedOrNull):
(WebCore::ArrayValue::length):
(WebCore::ArrayValue::get):
* bindings/js/ArrayValue.h: Added.
(WebCore):
(ArrayValue):
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
(WebCore):
* bindings/js/JSDictionary.h:
(WebCore):
* bindings/v8/ArrayValue.cpp: Added.
(WebCore):
(WebCore::ArrayValue::operator=):
(WebCore::ArrayValue::isUndefinedOrNull):
(WebCore::ArrayValue::length):
(WebCore::ArrayValue::get):
* bindings/v8/ArrayValue.h: Added.
(WebCore):
(ArrayValue):
(WebCore::ArrayValue::ArrayValue):
(WebCore::ArrayValue::~ArrayValue):
* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
(WebCore):
* bindings/v8/Dictionary.h:
(WebCore):
(Dictionary):
* dom/EventTargetFactory.in:

LayoutTests:

* fast/mediastream/RTCPeerConnection-expected.txt: Added.
* fast/mediastream/RTCPeerConnection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][EFL] New inspector/styles/region-style-crash.html introduced in r124186 fails
ossy@webkit.org [Tue, 31 Jul 2012 11:28:49 +0000 (11:28 +0000)]
[Qt][EFL] New inspector/styles/region-style-crash.html introduced in r124186 fails
https://bugs.webkit.org/show_bug.cgi?id=91503

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-31
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening after r124189, remove unnecessary expected files.
ossy@webkit.org [Tue, 31 Jul 2012 11:27:53 +0000 (11:27 +0000)]
[Qt] Unreviewed gardening after r124189, remove unnecessary expected files.

* platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt.
* platform/qt-5.0/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Removed.
* platform/qt-5.0/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Removed.
* platform/qt-5.0/fast/images/object-image-expected.txt: Added.
* platform/qt-5.0/fast/parser/entity-comment-in-textarea-expected.png: Removed.
* platform/qt-5.0/fast/parser/entity-comment-in-textarea-expected.txt: Removed.
* platform/qt-5.0/fast/parser/open-comment-in-textarea-expected.png: Removed.
* platform/qt-5.0/fast/parser/open-comment-in-textarea-expected.txt: Removed.
* platform/qt-5.0/fast/repaint/continuation-after-outline-expected.txt: Removed.
* platform/qt-5.0/fast/replaced/three-selects-break-expected.png: Removed.
* platform/qt-5.0/fast/replaced/three-selects-break-expected.txt: Removed.
* platform/qt-5.0/fast/writing-mode/fallback-orientation-expected.txt: Removed.
* platform/qt-5.0/fast/xsl/document-function-expected.png: Removed.
* platform/qt-5.0/fast/xsl/document-function-expected.txt: Removed.
* platform/qt-5.0/fast/xsl/xslt-entity-expected.png: Removed.
* platform/qt-5.0/fast/xsl/xslt-entity-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Update watchlist
jochen@chromium.org [Tue, 31 Jul 2012 10:46:04 +0000 (10:46 +0000)]
Unreviewed. Update watchlist

* Scripts/webkitpy/common/config/watchlist: Turned out to be less useful than I had hoped

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Unskip passing tests and add new expected files. (bug85203)
ossy@webkit.org [Tue, 31 Jul 2012 10:33:02 +0000 (10:33 +0000)]
[Qt] Unreviewed gardening. Unskip passing tests and add new expected files. (bug85203)

* platform/qt-5.0/Skipped: Unskip passing tests.
* platform/qt/Skipped: Skip the remaining failing tests and add bug reports.
* platform/qt/css2.1/t040103-ident-03-c-expected.png: Added.
* platform/qt/css2.1/t040103-ident-03-c-expected.txt: Added.
* platform/qt/editing/pasteboard/4242293-1-expected.txt:
* platform/qt/editing/pasteboard/5761530-1-expected.txt: Added.
* platform/qt/fast/backgrounds/mask-box-image-expected.png:
* platform/qt/fast/backgrounds/mask-box-image-expected.txt:
* platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.png: Copied from LayoutTests/platform/qt/fast/invalid/020-expected.png.
* platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
* platform/qt/fast/backgrounds/svg-as-mask-expected.png:
* platform/qt/fast/backgrounds/svg-as-mask-expected.txt:
* platform/qt/fast/block/positioning/051-expected.png:
* platform/qt/fast/block/positioning/051-expected.txt:
* platform/qt/fast/compact/003-expected.png:
* platform/qt/fast/compact/003-expected.txt:
* platform/qt/fast/css-generated-content/010-expected.png:
* platform/qt/fast/css-generated-content/010-expected.txt:
* platform/qt/fast/css-grid-layout/place-cell-by-index-expected.txt: Added.
* platform/qt/fast/css/font-face-descending-unicode-range-expected.txt:
* platform/qt/fast/css/font-face-font-family-descriptor-expected.txt:
* platform/qt/fast/css/imageTileOpacity-expected.png:
* platform/qt/fast/css/imageTileOpacity-expected.txt:
* platform/qt/fast/css/live-cssrules-expected.png:
* platform/qt/fast/css/live-cssrules-expected.txt:
* platform/qt/fast/css/rgba-custom-text-expected.txt: Added.
* platform/qt/fast/css/rtl-to-viewport-expected.png:
* platform/qt/fast/css/rtl-to-viewport-expected.txt:
* platform/qt/fast/css/vertical-align-lengths-expected.png:
* platform/qt/fast/css/vertical-align-lengths-expected.txt:
* platform/qt/fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png:
* platform/qt/fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt:
* platform/qt/fast/dom/HTMLHeadElement/textInHead1-expected.png:
* platform/qt/fast/dom/HTMLHeadElement/textInHead1-expected.txt:
* platform/qt/fast/dom/HTMLHeadElement/textInHead2-expected.png:
* platform/qt/fast/dom/HTMLHeadElement/textInHead2-expected.txt:
* platform/qt/fast/dom/HTMLHeadElement/textInHead3-expected.png:
* platform/qt/fast/dom/HTMLHeadElement/textInHead3-expected.txt:
* platform/qt/fast/dom/HTMLHeadElement/textInHead4-expected.png:
* platform/qt/fast/dom/HTMLHeadElement/textInHead4-expected.txt:
* platform/qt/fast/dom/HTMLHeadElement/textInHead5-expected.png:
* platform/qt/fast/dom/HTMLHeadElement/textInHead5-expected.txt:
* platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png:
* platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
* platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png:
* platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
* platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.png:
* platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.txt:
* platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png:
* platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt:
* platform/qt/fast/dom/comment-not-documentElement-expected.png:
* platform/qt/fast/dom/comment-not-documentElement-expected.txt:
* platform/qt/fast/dom/icon-url-change-expected.txt: Added.
* platform/qt/fast/dom/icon-url-list-expected.txt: Added.
* platform/qt/fast/dynamic/010-expected.png:
* platform/qt/fast/dynamic/010-expected.txt:
* platform/qt/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png.
* platform/qt/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt:
* platform/qt/fast/dynamic/genContentDestroyChildren-expected.png: Added.
* platform/qt/fast/dynamic/genContentDestroyChildren-expected.txt:
* platform/qt/fast/dynamic/move-node-with-selection-expected.png:
* platform/qt/fast/dynamic/move-node-with-selection-expected.txt:
* platform/qt/fast/dynamic/positioned-movement-with-positioned-children-expected.png:
* platform/qt/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
* platform/qt/fast/html/details-add-summary-1-expected.png:
* platform/qt/fast/html/details-add-summary-1-expected.txt:
* platform/qt/fast/html/details-add-summary-10-expected.png:
* platform/qt/fast/html/details-add-summary-10-expected.txt:
* platform/qt/fast/html/details-add-summary-2-expected.png:
* platform/qt/fast/html/details-add-summary-2-expected.txt:
* platform/qt/fast/html/details-add-summary-3-expected.png:
* platform/qt/fast/html/details-add-summary-3-expected.txt:
* platform/qt/fast/html/details-add-summary-4-expected.png:
* platform/qt/fast/html/details-add-summary-4-expected.txt:
* platform/qt/fast/html/details-add-summary-5-expected.png:
* platform/qt/fast/html/details-add-summary-5-expected.txt:
* platform/qt/fast/html/details-add-summary-6-expected.png:
* platform/qt/fast/html/details-add-summary-6-expected.txt:
* platform/qt/fast/html/details-add-summary-7-expected.png:
* platform/qt/fast/html/details-add-summary-7-expected.txt:
* platform/qt/fast/html/details-add-summary-8-expected.png:
* platform/qt/fast/html/details-add-summary-8-expected.txt:
* platform/qt/fast/html/details-add-summary-9-expected.png:
* platform/qt/fast/html/details-add-summary-9-expected.txt:
* platform/qt/fast/html/details-no-summary1-expected.png:
* platform/qt/fast/html/details-no-summary1-expected.txt:
* platform/qt/fast/html/details-no-summary2-expected.png:
* platform/qt/fast/html/details-no-summary2-expected.txt:
* platform/qt/fast/html/details-no-summary3-expected.png:
* platform/qt/fast/html/details-no-summary3-expected.txt:
* platform/qt/fast/html/details-open1-expected.png:
* platform/qt/fast/html/details-open1-expected.txt:
* platform/qt/fast/html/details-open3-expected.png:
* platform/qt/fast/html/details-open3-expected.txt:
* platform/qt/fast/html/details-open5-expected.png:
* platform/qt/fast/html/details-open5-expected.txt:
* platform/qt/fast/html/details-open6-expected.png:
* platform/qt/fast/html/details-open6-expected.txt:
* platform/qt/fast/html/details-remove-summary-1-expected.png:
* platform/qt/fast/html/details-remove-summary-1-expected.txt:
* platform/qt/fast/html/details-remove-summary-2-expected.png:
* platform/qt/fast/html/details-remove-summary-2-expected.txt:
* platform/qt/fast/html/details-remove-summary-3-expected.png:
* platform/qt/fast/html/details-remove-summary-3-expected.txt:
* platform/qt/fast/html/details-remove-summary-4-expected.png:
* platform/qt/fast/html/details-remove-summary-4-expected.txt:
* platform/qt/fast/html/details-remove-summary-5-expected.png:
* platform/qt/fast/html/details-remove-summary-5-expected.txt:
* platform/qt/fast/html/details-remove-summary-6-expected.png:
* platform/qt/fast/html/details-remove-summary-6-expected.txt:
* platform/qt/fast/images/image-in-map-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/selection-clear-expected.png.
* platform/qt/fast/images/image-in-map-expected.txt:
* platform/qt/fast/inline/002-expected.png: Copied from LayoutTests/platform/qt/fast/dynamic/010-expected.png.
* platform/qt/fast/inline/002-expected.txt:
* platform/qt/fast/inline/inline-fixed-position-boundingbox-expected.txt: Added.
* platform/qt/fast/inline/inline-relative-offset-boundingbox-expected.txt: Added.
* platform/qt/fast/inline/positioned-object-between-replaced-elements-expected.txt:
* platform/qt/fast/inline/positionedLifetime-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/continuation-after-outline-expected.png.
* platform/qt/fast/inline/positionedLifetime-expected.txt:
* platform/qt/fast/invalid/005-expected.png: Copied from LayoutTests/platform/qt/fast/dom/comment-not-documentElement-expected.png.
* platform/qt/fast/invalid/005-expected.txt:
* platform/qt/fast/invalid/007-expected.png: Copied from LayoutTests/platform/qt/fast/html/details-remove-summary-6-expected.png.
* platform/qt/fast/invalid/007-expected.txt:
* platform/qt/fast/invalid/020-expected.png:
* platform/qt/fast/invalid/020-expected.txt:
* platform/qt/fast/lists/004-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png.
* platform/qt/fast/lists/004-expected.txt:
* platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png.
* platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
* platform/qt/fast/lists/ol-start-dynamic-expected.png: Copied from LayoutTests/platform/qt/fast/html/details-no-summary2-expected.png.
* platform/qt/fast/lists/ol-start-dynamic-expected.txt:
* platform/qt/fast/multicol/hit-test-gap-between-pages-expected.txt: Added.
* platform/qt/fast/multicol/table-vertical-align-expected.txt:
* platform/qt/fast/multicol/vertical-rl/rule-style-expected.txt:
* platform/qt/fast/parser/tabs-in-scripts-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png.
* platform/qt/fast/parser/tabs-in-scripts-expected.txt:
* platform/qt/fast/reflections/reflection-direction-expected.png: Added.
* platform/qt/fast/reflections/reflection-direction-expected.txt:
* platform/qt/fast/reflections/reflection-masks-expected.png: Added.
* platform/qt/fast/reflections/reflection-masks-expected.txt:
* platform/qt/fast/reflections/reflection-masks-opacity-expected.png: Added.
* platform/qt/fast/reflections/reflection-masks-opacity-expected.txt:
* platform/qt/fast/repaint/block-no-inflow-children-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png.
* platform/qt/fast/repaint/block-no-inflow-children-expected.txt:
* platform/qt/fast/repaint/button-spurious-layout-hint-expected.txt:
* platform/qt/fast/repaint/clip-with-layout-delta-expected.txt:
* platform/qt/fast/repaint/continuation-after-outline-expected.png:
* platform/qt/fast/repaint/continuation-after-outline-expected.txt:
* platform/qt/fast/repaint/float-overflow-expected.png:
* platform/qt/fast/repaint/float-overflow-expected.txt:
* platform/qt/fast/repaint/float-overflow-right-expected.png:
* platform/qt/fast/repaint/float-overflow-right-expected.txt:
* platform/qt/fast/repaint/gradients-em-stops-repaint-expected.png:
* platform/qt/fast/repaint/gradients-em-stops-repaint-expected.txt:
* platform/qt/fast/repaint/iframe-scroll-repaint-expected.txt:
* platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png.
* platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.txt:
* platform/qt/fast/repaint/lines-with-layout-delta-expected.png:
* platform/qt/fast/repaint/lines-with-layout-delta-expected.txt:
* platform/qt/fast/repaint/reflection-repaint-test-expected.png:
* platform/qt/fast/repaint/reflection-repaint-test-expected.txt:
* platform/qt/fast/repaint/repaint-svg-after-style-change-expected.png: Copied from LayoutTests/platform/qt/fast/dynamic/positioned-movement-with-positioned-children-expected.png.
* platform/qt/fast/repaint/repaint-svg-after-style-change-expected.txt:
* platform/qt/fast/repaint/selection-clear-expected.png:
* platform/qt/fast/repaint/selection-clear-expected.txt:
* platform/qt/fast/repaint/transform-layout-repaint-expected.png:
* platform/qt/fast/repaint/transform-layout-repaint-expected.txt:
* platform/qt/fast/replaced/image-onload-expected.png:
* platform/qt/fast/replaced/image-onload-expected.txt:
* platform/qt/fast/runin/002-expected.png:
* platform/qt/fast/runin/002-expected.txt:
* platform/qt/fast/runin/generated4-expected.png:
* platform/qt/fast/runin/generated4-expected.txt:
* platform/qt/svg/custom/use-instanceRoot-event-listeners-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, update watchlist
tkent@chromium.org [Tue, 31 Jul 2012 10:22:02 +0000 (10:22 +0000)]
Unreviewed, update watchlist

* Scripts/webkitpy/common/config/watchlist:
- Improve "Forms" filename pattern.
- tkent stops watching Chromium DRT. It was not so helpful.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, handle more tests failing after r124052.
apavlov@chromium.org [Tue, 31 Jul 2012 10:20:33 +0000 (10:20 +0000)]
[Chromium] Unreviewed, handle more tests failing after r124052.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInspector crashes when trying to inspect a page with CSS region styling
commit-queue@webkit.org [Tue, 31 Jul 2012 10:08:45 +0000 (10:08 +0000)]
Inspector crashes when trying to inspect a page with CSS region styling
https://bugs.webkit.org/show_bug.cgi?id=91503

Patch by Raul Hudea <rhudea@adobe.com> on 2012-07-31
Reviewed by Alexander Pavlov.

Source/WebCore:

Fix by making sure a CSSRuleSourceData is always created when parsing @-webkit-region rules.

Test: inspector/styles/region-style-crash.html

* css/CSSGrammar.y: Made ruleset called explicitly markRuleBodyStart instead of depending on updateLastSelectorLineAndPosition to call it.
* css/CSSParser.cpp:
(WebCore::CSSParser::updateLastSelectorLineAndPosition): markRuleBodyStart should be called via at_rule_body_start.
* css/CSSPropertySourceData.h:

LayoutTests:

Test to make sure inspector is not crashing when having to parse @-webkit-region rules

* inspector/styles/region-style-crash-expected.txt: Added.
* inspector/styles/region-style-crash.html: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r124179.
commit-queue@webkit.org [Tue, 31 Jul 2012 09:41:08 +0000 (09:41 +0000)]
Unreviewed, rolling out r124179.
http://trac.webkit.org/changeset/124179
https://bugs.webkit.org/show_bug.cgi?id=92730

Breaks Chromium Linux 32 bots with "error: integer constant is
too large for 'long' type" in IDBLevelDBCodingTest.cpp
(Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-31

Source/WebCore:

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeByte):
(WebCore::IDBLevelDBCoding::encodeBool):
(WebCore::IDBLevelDBCoding::encodeInt):
(WebCore::IDBLevelDBCoding::encodeVarInt):
(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::encodeDouble):
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::encodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::KeyPrefix::encode):
* Modules/indexeddb/IDBLevelDBCoding.h:
(IDBLevelDBCoding):

Source/WebKit/chromium:

* tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPerf-o-matic: dashboard images are not generated properly from incrementally updated...
rniwa@webkit.org [Tue, 31 Jul 2012 09:00:33 +0000 (09:00 +0000)]
Perf-o-matic: dashboard images are not generated properly from incrementally updated JSON
https://bugs.webkit.org/show_bug.cgi?id=92717

Reviewed by Hajime Morita.

Sort the values by timestamp. Unfortunately, there isn't a good way of testing this fix.

* Websites/webkit-perf.appspot.com/models.py:
(Runs.chart_params):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[jhbuild] Also try to load jhbuild Python module from the source checkout
mrobinson@webkit.org [Tue, 31 Jul 2012 08:53:05 +0000 (08:53 +0000)]
[jhbuild] Also try to load jhbuild Python module from the source checkout

Reviewed by Philippe Normand.

JHBuild also seems to have an installation mode where it prefers to load its
Python modules from the source checkout. This seems to be used particularly
on the GTK+ 64-bit release bot. We should fall back to this mode.

* jhbuild/jhbuildutils.py:
(enter_jhbuild_environment_if_available): Use the source checkout if there
is no installation path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoadd Farstream flags/deps to WebKit, for WebRTC
commit-queue@webkit.org [Tue, 31 Jul 2012 08:46:59 +0000 (08:46 +0000)]
add Farstream flags/deps to WebKit, for WebRTC
https://bugs.webkit.org/show_bug.cgi?id=87524

Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2012-07-31
Reviewed by Philippe Normand.

Since Farstream will be used as the backend for GTK's WebRTC, this
patch adds it as a dependency to the build system.

.:

* GNUmakefile.am:
* configure.ac:

Source/WebCore:

No new features or code changes were added, so new tests aren't necessary.

* GNUmakefile.am:

Source/WebKit2:

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed crash fix after r124135.
zandobersek@gmail.com [Tue, 31 Jul 2012 08:09:49 +0000 (08:09 +0000)]
Unreviewed crash fix after r124135.

* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::Path): Ensure the Cairo path when acquiring its context,
crashes ensue otherwise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange Element::isReadOnlyFormControl to Element::shouldMatchReadOnlySelector/shouldM...
yosin@chromium.org [Tue, 31 Jul 2012 07:58:47 +0000 (07:58 +0000)]
Change Element::isReadOnlyFormControl to Element::shouldMatchReadOnlySelector/shouldMatchReadWriteSelector or HTMLFormControlElement::readOnly
https://bugs.webkit.org/show_bug.cgi?id=92602

Reviewed by Kent Tamura.

This patch replaces Element::isReadOnlyFormControl() by
Element::shouldMatchReadOnlySelector/shouldMatchReadOnlySelector or
HTMLFormControlElement::readOnly() to make intention of functions
self descriptive.

No new tests. This patch doesn't change behavior.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Replaced isReadOnlyFormControl() by shouldMatchReadOnlySelector() for :read-only pseudo class, and replaced isReadOnlyFormControl() by shouldMatchReadOnlySelector() for :read-only pseudo class.
* dom/Element.cpp:
(WebCore::Element::shouldMatchReadOnlySelector): Added for default implementation.
(WebCore::Element::shouldMatchReadWriteSelector): for default implementation.
* dom/Element.h:
(Element): Removed isReadOnlyFormControl() and added shouldMatchReadOnlySelector and shouldMatchReadWriteSelector.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::shouldMatchReadOnlySelector): Added.
(WebCore::HTMLFormControlElement::shouldMatchReadWriteSelector): Added.
* html/HTMLFormControlElement.h:
(HTMLFormControlElement): Removed isReadOnlyFormControl() and added shouldMatchReadOnlySelector and shouldMatchReadWriteSelector.
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::shouldMatchReadOnlySelector): Added.
(WebCore::SliderThumbElement::shouldMatchReadWriteSelector): Added.
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SliderThumbElement::willRespondToMouseClickEvents): ditto.
(SliderThumbElement):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents): ditto.
(WebCore::SpinButtonElement::willRespondToMouseClickEvents): ditto.
(WebCore::SpinButtonElement::shouldMatchReadOnlySelector): Added.
(WebCore::SpinButtonElement::shouldMatchReadWriteSelector): Added.
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
* html/shadow/TextControlInnerElements.h:
(SpinButtonElement): Removed isReadOnlyFormControl() and added shouldMatchReadOnlySelector and shouldMatchReadWriteSelector.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isReadOnlyControl): Replaced isReadOnlyControl() by shouldMatchReadOnlySelector().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Size the Vector in encodeInt/encodeVarInt/encodeString
commit-queue@webkit.org [Tue, 31 Jul 2012 07:12:23 +0000 (07:12 +0000)]
IndexedDB: Size the Vector in encodeInt/encodeVarInt/encodeString
https://bugs.webkit.org/show_bug.cgi?id=91813

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-07-31
Reviewed by Kentaro Hara.

To avoid memory re-allocation in Vector, init the capability or size of Vector in encodeInt(), encodeVarInt(),
encodeBool(), encodeIDBKey() etc.

No new tests - Low level functions covered by existing layout tests and also covered by Chromium
webkit_unit_tests IDBLevelIDBCodingTest.* which validates the sizes of buffers returned by encodeVarInt.

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeInt):
(WebCore::IDBLevelDBCoding::encodeVarInt):
(WebCore::IDBLevelDBCoding::encodeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124179 268f45cc-cd09-0410-ab3c-d52691b4dbfc