WebKit-https.git
9 years ago2011-03-30 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 1 Apr 2011 10:51:20 +0000 (10:51 +0000)]
2011-03-30  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove dead code from Script.js.
        https://bugs.webkit.org/show_bug.cgi?id=57454

        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
        * inspector/front-end/Script.js:
        (WebInspector.Script):
        (WebInspector.Script.prototype.requestSource.didGetScriptSource):
        (WebInspector.Script.prototype.requestSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
podivilov@chromium.org [Fri, 1 Apr 2011 10:45:56 +0000 (10:45 +0000)]
2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82667.
        http://trac.webkit.org/changeset/82667
        https://bugs.webkit.org/show_bug.cgi?id=57612

        Breaks Leopard layout tests (Requested by podivilov on
        #webkit).

        * inspector/debugger/script-formatter-expected.txt: Removed.
        * inspector/debugger/script-formatter.html: Removed.
        * platform/chromium/test_expectations.txt:
2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82667.
        http://trac.webkit.org/changeset/82667
        https://bugs.webkit.org/show_bug.cgi?id=57612

        Breaks Leopard layout tests (Requested by podivilov on
        #webkit).

        * GNUmakefile.am:
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-30 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 1 Apr 2011 10:26:34 +0000 (10:26 +0000)]
2011-03-30  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove unused SourceFrameContent class.
        https://bugs.webkit.org/show_bug.cgi?id=57453

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ResourceView.js:
        (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._createTextViewer):
        * inspector/front-end/SourceFrameContent.js: Removed.
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-30 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 1 Apr 2011 10:17:26 +0000 (10:17 +0000)]
2011-03-30  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add test for script formatter worker.
        https://bugs.webkit.org/show_bug.cgi?id=57447

        * inspector/debugger/script-formatter-expected.txt: Added.
        * inspector/debugger/script-formatter.html: Added.
        * platform/chromium/test_expectations.txt:
2011-03-30  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add test for script formatter worker.
        https://bugs.webkit.org/show_bug.cgi?id=57447

        Test: inspector/debugger/script-formatter.html

        * GNUmakefile.am:
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-30 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 1 Apr 2011 09:53:31 +0000 (09:53 +0000)]
2011-03-30  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [chromium] script formatting doesn't work when all scripts are concatenated.
        https://bugs.webkit.org/show_bug.cgi?id=57446

        * inspector/front-end/ScriptFormatterWorker.js:
2011-03-30  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [chromium] script formatting doesn't work when all scripts are concatenated.
        https://bugs.webkit.org/show_bug.cgi?id=57446

        * WebKit.gyp:
        * scripts/inline_js_imports.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 1 Apr 2011 09:32:02 +0000 (09:32 +0000)]
2011-04-01  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: allow file access from inspector page so inspector can use workers.
        https://bugs.webkit.org/show_bug.cgi?id=57339

        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 1 Apr 2011 08:59:10 +0000 (08:59 +0000)]
2011-03-31  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: inspected page crashes on attempt to log object with broken .toString
        https://bugs.webkit.org/show_bug.cgi?id=57557

        * inspector/console/console-log-toString-object-expected.txt: Added.
        * inspector/console/console-log-toString-object.html: Added.
2011-03-31  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: inspected page crashes on attempt to log object with broken .toString
        https://bugs.webkit.org/show_bug.cgi?id=57557

        If ScriptValue.toString causes a JavaScript exception, the exception is cleared
        before returning from the toString method.

        Test: inspector/console/console-log-toString-object.html

        * bindings/js/ScriptValue.cpp:
        (WebCore::ScriptValue::toString):
        * bindings/js/ScriptValue.h:
        * bindings/v8/ScriptValue.cpp:
        (WebCore::ScriptValue::toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 1 Apr 2011 08:56:55 +0000 (08:56 +0000)]
2011-03-31  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: provide front-end wrappers for DOMAgent.querySelector[All]() that take care of fetching the document
        https://bugs.webkit.org/show_bug.cgi?id=57466

        - removed documentWide parameter to querySelector[All]() (user document node id instead)
        - factor out document request logic within DOMAgent into separate method
        - add querySelector() and querySelectorAll() to DOMAgent.js, assure we have document before calling back-end
        - use the above wrappers for querySelector() and querySelectorAll(), do not call backend directly
        - minor style fixes in Inspector.json
        - more error logging

        * inspector/Inspector.json:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::querySelector):
        (WebCore::InspectorDOMAgent::querySelectorAll):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
        (WebInspector.CSSStyleModel.prototype.setRuleSelector):
        (WebInspector.CSSStyleModel.prototype.addRule.callback):
        (WebInspector.CSSStyleModel.prototype.addRule):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMAgent.prototype.requestDocument.onDocumentAvailable):
        (WebInspector.DOMAgent.prototype.requestDocument):
        (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
        (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
        (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
        (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):
        (WebInspector.DOMAgent.prototype.cancelSearch):
        (WebInspector.DOMAgent.prototype.querySelector):
        (WebInspector.DOMAgent.prototype.querySelectorAll):

2011-03-31  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: provide front-end wrappers for DOMAgent.querySelector[All]() that take care of fetching the document
        https://bugs.webkit.org/show_bug.cgi?id=57466

        * inspector/elements/dom-agent-query-selector.html: removed documentWide parameter to querySelectorAll

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 1 Apr 2011 07:55:45 +0000 (07:55 +0000)]
2011-04-01  Kent Tamura  <tkent@chromium.org>

        Apply sort-Xcode-project-file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Apr 2011 05:46:28 +0000 (05:46 +0000)]
2011-03-31  Adam Barth  <abarth@webkit.org>

        Add two more preloader tests to the WebKit2 Skipped list.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed WinCairo build fix after r82632.
bfulgham@webkit.org [Fri, 1 Apr 2011 05:12:59 +0000 (05:12 +0000)]
Unreviewed WinCairo build fix after r82632.

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::visibilityDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Apr 2011 04:30:18 +0000 (04:30 +0000)]
2011-03-31  Adam Barth  <abarth@webkit.org>

        Rebaseline my own test on Linux!  The great JavaScript MIME type war
        claims another victim.

        * platform/chromium-linux/fast/preloader/scan-body-from-head-script-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Apr 2011 03:45:50 +0000 (03:45 +0000)]
2011-03-31  Adam Barth  <abarth@webkit.org>

        Reviewed by Tony Gentilcore.

        fast/preloader/scan-body-from-head.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=57594

        This test was flaky because the script and the import load would race.
        By breaking down this test into two pieces, we can still see that the
        parse-blocking loads happen before the non-blocking load (the img) but
        we don't suffer flakiness.

        * fast/preloader/scan-body-from-head-expected.txt: Removed.
        * fast/preloader/scan-body-from-head-import-expected.txt: Added.
        * fast/preloader/scan-body-from-head-import.html: Added.
        * fast/preloader/scan-body-from-head-script-expected.txt: Added.
        * fast/preloader/scan-body-from-head-script.html: Added.
        * fast/preloader/scan-body-from-head.html-disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Fri, 1 Apr 2011 02:52:16 +0000 (02:52 +0000)]
2011-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82652.
        http://trac.webkit.org/changeset/82652
        https://bugs.webkit.org/show_bug.cgi?id=57603

        Test still fails (Requested by abarth|gardener on #webkit).

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::setWidget):
2011-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82652.
        http://trac.webkit.org/changeset/82652
        https://bugs.webkit.org/show_bug.cgi?id=57603

        Test still fails (Requested by abarth|gardener on #webkit).

        * plugins/windowless_plugin_paint_test-expected.txt: Removed.
        * plugins/windowless_plugin_paint_test.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Fri, 1 Apr 2011 02:32:27 +0000 (02:32 +0000)]
2011-03-31  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Kent Tamura.

        REGRESSION (r64712): Safari removes the first blank line in a textarea
        https://bugs.webkit.org/show_bug.cgi?id=56434

        * fast/forms/textarea-newline-expected.txt: Added.
        * fast/forms/textarea-newline.html: Added to check the only first blank line in a textarea is correctly removed.
2011-03-31  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Kent Tamura.

        REGRESSION (r64712): Safari removes the first blank line in a textarea
        https://bugs.webkit.org/show_bug.cgi?id=56434

        Test: fast/forms/textarea-newline.html

        A linefeed removal after a textarea tag is originally processed in WebCore::HTMLTextAreaElement::defaultValue().
        But HTML5 tree builder now removes the linefeed. It means linefeed removal happens twice.
        And devalutValue() removal is not needed anymore.

        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::setDefaultValue): Remove an extra linefeed insertion at the beginning.
        (WebCore::HTMLTextAreaElement::defaultValue): Remove linefeed removal check in default value creation function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed.
antti@apple.com [Fri, 1 Apr 2011 02:07:59 +0000 (02:07 +0000)]
Not reviewed.

Skipping

fast/preloader/document-write.html
fast/preloader/document-write-2.html

due to Javascript MIME type mismatch.

* platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Fri, 1 Apr 2011 01:39:23 +0000 (01:39 +0000)]
2011-03-31  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Dimitri Glazkov.

        Remove refcounting of CSSStyleApplyProperty singleton
        https://bugs.webkit.org/show_bug.cgi?id=57592

        No new tests required as no functionality changes.

        * css/CSSStyleApplyProperty.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Apr 2011 01:31:53 +0000 (01:31 +0000)]
2011-03-31  Adam Barth  <abarth@webkit.org>

        Attempt to fix the chromium-mac-leopard baselines for these tests.  For
        some reason, the automatic tools were unable to fix these, so I created
        them manually.

        * platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.checksum:
        * platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/list-marker-expected.checksum:
        * platform/chromium-mac-leopard/fast/repaint/list-marker-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Anantanarayanan G Iyengar <ananta@chromium.org>
commit-queue@webkit.org [Fri, 1 Apr 2011 01:14:24 +0000 (01:14 +0000)]
2011-03-31  Anantanarayanan G Iyengar  <ananta@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=45855
        Windowless plugins added dynamically to the DOM should receive paint events.
        This is done by ensuring that the plugin widget is marked for painting when
        it is added.

        * plugins/windowless_plugin_paint_test-expected.txt: Added.
        * plugins/windowless_plugin_paint_test.html: Added.
2011-03-31  Anantanarayanan G Iyengar  <ananta@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=45855
        Windowless plugins added dynamically to the DOM should receive paint events.
        This is done by ensuring that the plugin widget is marked for painting when
        it is added.

        Test: plugins/windowless_plugin_paint_test.html

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::setWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd SharedMemory::adopt, which can take ownership of an existing file mapping object
aroben@apple.com [Fri, 1 Apr 2011 01:05:40 +0000 (01:05 +0000)]
Add SharedMemory::adopt, which can take ownership of an existing file mapping object

Fixes <http://webkit.org/b/57599> Need a way to wrap an existing file mapping object in a
SharedMemory

Reviewed by Anders Carlsson.

* Platform/SharedMemory.h: Added adopt.

* Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::create): Moved code to adopt the HANDLE from here...
(WebKit::SharedMemory::adopt): ...to here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a new AbstractCACFLayerTreeHost base class
aroben@apple.com [Fri, 1 Apr 2011 01:05:06 +0000 (01:05 +0000)]
Add a new AbstractCACFLayerTreeHost base class

This class exposes the interface that LayerChangesFlusher and PlatformCALayer rely on.
CACFLayerTreeHost now derives from AbstractCACFLayerTreeHost. In the future, WebKit2's
LayerTreeHostCA will also derive from it (on Windows).

This should cause no change in behavior.

Fixes <http://webkit.org/b/57598> Coupling between CACFLayerTreeHost and other CACF-related
code is too high

Reviewed by Anders Carlsson.

* WebCore.vcproj/WebCore.vcproj: Added AbstractCACFLayerTreeHost, and let VS reorder files.

* platform/graphics/ca/win/AbstractCACFLayerTreeHost.h: Added.

* platform/graphics/ca/win/CACFLayerTreeHost.h: Changed to derive from
AbstractCACFLayerTreeHost, and annotated the overrides of its functions.
AbstractCACFLayerTreeHost also allows us to get rid of the friend relationship with
PlatformCALayer.

* platform/graphics/ca/win/LayerChangesFlusher.cpp:
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon):
(WebCore::LayerChangesFlusher::cancelPendingFlush):
(WebCore::LayerChangesFlusher::hookFired):
* platform/graphics/ca/win/LayerChangesFlusher.h:
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(layerTreeHostForLayer):
(PlatformCALayer::rootLayer):
(PlatformCALayer::setNeedsCommit):
(PlatformCALayer::addAnimationForKey):
(PlatformCALayer::removeAnimationForKey):
Changed to use AbstractCACFLayerTreeHost instead of using CACFLayerTreeHost directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Fri, 1 Apr 2011 01:01:58 +0000 (01:01 +0000)]
2011-03-31  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.clearAllDatabases
        https://bugs.webkit.org/show_bug.cgi?id=42540

        Remove passed tests.

        * platform/mac-wk2/Skipped:
2011-03-31  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.clearAllDatabases
        https://bugs.webkit.org/show_bug.cgi?id=42540

        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
        (WKBundleClearAllDatabases):
        * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::clearAllDatabases):
        * WebProcess/InjectedBundle/InjectedBundle.h:
        * WebProcess/WebCoreSupport/WebDatabaseManager.h:
2011-03-31  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.clearAllDatabases
        https://bugs.webkit.org/show_bug.cgi?id=42540

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::beginTesting):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::clearAllDatabases):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Apr 2011 00:50:41 +0000 (00:50 +0000)]
2011-03-31  Adam Barth  <abarth@webkit.org>

        Note another flaky test.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Andy Estes <aestes@apple.com>
aestes@apple.com [Fri, 1 Apr 2011 00:12:53 +0000 (00:12 +0000)]
2011-03-31  Andy Estes  <aestes@apple.com>

        Reviewed by Alexey Proskuryakov.

        REGRESSION: Java applet fails to load when <object> has a classid attribute.
        https://bugs.webkit.org/show_bug.cgi?id=52703

        Java applets embedded with the object element sometimes use classid to
        specify their main resource. When this is done, the classid is prefixed
        with "java:". Treat these as supported classids in WebKit.

        Test: java/embedding-java-with-object.html

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::hasValidClassId): If the MIME type is a
        Java Applet type and the classid starts with "java:", the classid
        should be considered valid.
2011-03-31  Andy Estes  <aestes@apple.com>

        Reviewed by Alexey Proskuryakov.

        REGRESSION: Java applet fails to load when <object> has a classid attribute
        https://bugs.webkit.org/show_bug.cgi?id=52703

        Test various ways that a Java applet can be embedded using the object element.

        * java/embedding-java-with-object-expected.txt: Added.
        * java/embedding-java-with-object.html: Added.
        * platform/mac-wk2/Skipped: WK2 doesn't implement
        layoutTestController.overridePreference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Apr 2011 00:04:52 +0000 (00:04 +0000)]
2011-03-31  Adam Barth  <abarth@webkit.org>

        Fix name of test.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 31 Mar 2011 23:58:27 +0000 (23:58 +0000)]
2011-03-31  Adam Barth  <abarth@webkit.org>

        Update chromium-win expectations for these baseline changes from
        Mr. Hyatt.

        * platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.checksum:
        * platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.png:
        * platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.txt:
        * platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum:
        * platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
        * platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
        * platform/chromium-win/fast/multicol/nested-columns-expected.checksum:
        * platform/chromium-win/fast/multicol/nested-columns-expected.png:
        * platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.checksum:
        * platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
        * platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.checksum:
        * platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 31 Mar 2011 23:50:06 +0000 (23:50 +0000)]
2011-03-31  Adam Barth  <abarth@webkit.org>

        Disable this test because it's very flaky on all platforms.  See
        https://bugs.webkit.org/show_bug.cgi?id=57594 for making the test
        non-flaky.

        * fast/preloader/scan-body-from-head.html: Removed.
        * fast/preloader/scan-body-from-head.html-disabled: Copied from LayoutTests/fast/preloader/scan-body-from-head.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Victoria Kirst <vrk@google.com>
scherkus@chromium.org [Thu, 31 Mar 2011 23:43:45 +0000 (23:43 +0000)]
2011-03-31  Victoria Kirst  <vrk@google.com>

        Reviewed by Eric Carlson.

        [chromium] Implement preload=none, setPreload hooks to media player
        https://bugs.webkit.org/show_bug.cgi?id=56983

        This patch implements preload=none in Chromium. It also replaces
        the now-deprecated setAutobuffer method with setPreload.

        * public/WebMediaPlayer.h:
        (WebKit::WebMediaPlayer::setPreload):
        * public/WebMediaPlayerClient.h:
        * src/WebMediaPlayerClientImpl.cpp:
        (WebKit::WebMediaPlayerClientImpl::preload):
        (WebKit::WebMediaPlayerClientImpl::load):
        (WebKit::WebMediaPlayerClientImpl::loadInternal):
        (WebKit::WebMediaPlayerClientImpl::prepareToPlay):
        (WebKit::WebMediaPlayerClientImpl::setPreload):
        (WebKit::WebMediaPlayerClientImpl::startDelayedLoad):
        (WebKit::WebMediaPlayerClientImpl::WebMediaPlayerClientImpl):
        * src/WebMediaPlayerClientImpl.h:

2011-03-31  Victoria Kirst  <vrk@google.com>

        Reviewed by Eric Carlson.

        [chromium] Implement preload=none, setPreload hooks to media player
        https://bugs.webkit.org/show_bug.cgi?id=56983

        Reenabling video-preload.html layout test for chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed Adam Roben.
bfulgham@webkit.org [Thu, 31 Mar 2011 23:42:19 +0000 (23:42 +0000)]
Reviewed Adam Roben.

[WinCairo] Implement Missing drawWindowsBitmap method.
https://bugs.webkit.org/show_bug.cgi?id=57409

* WebCore.vcproj/WebCore.vcproj: Add new DIBPixelData files.
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::WindowsBitmap::buffer):
(WebCore::GraphicsContext::WindowsBitmap::bufferLength):
(WebCore::GraphicsContext::WindowsBitmap::size):
(WebCore::GraphicsContext::WindowsBitmap::bytesPerRow):
(WebCore::GraphicsContext::WindowsBitmap::bitsPerPixel):
(WebCore::GraphicsContext::WindowsBitmap::windowsDIB):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::CGContextWithHDC):
(WebCore::GraphicsContext::releaseWindowsContext): Modified to use
new common routines.
* platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::drawBitmapToContext): New common drawing implementation.
(WebCore::GraphicsContext::releaseWindowsContext): Modified to use
new common routines.
(WebCore::GraphicsContext::drawWindowsBitmap):
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): Modified
to use new DIBPixelData data type.
* platform/graphics/win/DIBPixelData.cpp: Added.
(WebCore::DIBPixelData::DIBPixelData):
(WebCore::DIBPixelData::initialize):
* platform/graphics/win/DIBPixelData.h: Added.
(WebCore::DIBPixelData::DIBPixelData):
(WebCore::DIBPixelData::buffer):
(WebCore::DIBPixelData::bufferLength):
(WebCore::DIBPixelData::size):
(WebCore::DIBPixelData::bytesPerRow):
(WebCore::DIBPixelData::bitsPerPixel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 31 Mar 2011 23:36:03 +0000 (23:36 +0000)]
2011-03-31  Adam Barth  <abarth@webkit.org>

        Add setSerializeHTTPLoads supressions.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed.
antti@apple.com [Thu, 31 Mar 2011 23:32:34 +0000 (23:32 +0000)]
Not reviewed.

- Skip on platforms that don't have setSerializeHTTPLoads, make it a requirement.
- Update results after typo fix.

* fast/preloader/document-write-2-expected.txt:
* fast/preloader/document-write-2.html:
* fast/preloader/document-write-expected.txt:
* fast/preloader/document-write.html:
* platform/gtk/Skipped:
* platform/mac-wk2/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Sheriff Bot <webkit.review.bot@gmail.com>
inferno@chromium.org [Thu, 31 Mar 2011 23:29:29 +0000 (23:29 +0000)]
2011-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81849.
        http://trac.webkit.org/changeset/81849
        https://bugs.webkit.org/show_bug.cgi?id=57588

        CSS Parsing broke with -webkit-calc and introduced crashes
        (Requested by inferno-sec on #webkit).

        * css/CSSGrammar.y:
        * css/CSSParserValues.cpp:
        * css/CSSParserValues.h:
        * css/tokenizer.flex:
2011-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81849.
        http://trac.webkit.org/changeset/81849
        https://bugs.webkit.org/show_bug.cgi?id=57588

        CSS Parsing broke with -webkit-calc and introduced crashes
        (Requested by inferno-sec on #webkit).

        * css3/calc/calc-errors-expected.txt: Removed.
        * css3/calc/calc-errors.html: Removed.
        * css3/calc/minmax-errors-expected.txt: Removed.
        * css3/calc/minmax-errors.html: Removed.
        * css3/calc/simple-calcs-expected.txt: Removed.
        * css3/calc/simple-calcs.html: Removed.
        * css3/calc/simple-minmax-expected.txt: Removed.
        * css3/calc/simple-minmax.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd some more media related things to the sandbox profile.
andersca@apple.com [Thu, 31 Mar 2011 23:21:48 +0000 (23:21 +0000)]
Add some more media related things to the sandbox profile.

Reviewed by Sam Weinig.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't ref CACFLayerTreeHosts when telling them to flush layer changes
aroben@apple.com [Thu, 31 Mar 2011 23:15:52 +0000 (23:15 +0000)]
Don't ref CACFLayerTreeHosts when telling them to flush layer changes

LayerChangesFlusher was reffing CACFLayerTreeHosts before calling out to them. This would
have protected us if calling out to one CACFLayerTreeHost could cause a different
CACFLayerTreeHost to be destroyed. But that isn't possible; each CACFLayerTreeHost is
associated with its own page, and flushing layer changes doesn't touch any other page. So it
isn't possible for a CACFLayerTreeHost to be deleted while another one is flushing layer
changes.

One benefit of this change is that it will make it easier to make LayerChangesFlusher
interact with a forthcoming abstract base class, rather than with CACFLayerTreeHost itself.

This should cause no change in behavior.

Fixes <http://webkit.org/b/57590> LayerChangesFlusher unnecessarily refs CACFLayerTreeHost
before calling out to it

Reviewed by Darin Adler.

* platform/graphics/ca/win/LayerChangesFlusher.cpp:
(WebCore::LayerChangesFlusher::hookFired): Just store bare pointers to the
CACFLayerTreeHosts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 31 Mar 2011 23:05:44 +0000 (23:05 +0000)]
2011-03-31  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Tabbed pages redraw unnecessarily when activated
        https://bugs.webkit.org/show_bug.cgi?id=57589
        <rdar://problem/9218258>

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::visibilityDidChange):
        If we become visible and have no backing store, make sure to call backingStoreStateDidChange
        so that the next time we're asked to paint we'll wait for something to paint.

        (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
        Remove now redundant call to backingStoreStateDidChange.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=57574
antti@apple.com [Thu, 31 Mar 2011 22:50:52 +0000 (22:50 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57574
Preload scanner fails to pick up resources from document.write() output

Reviewed by Oliver Hunt.

Source/WebCore:

- Scan script inserted source using a separate preload scanner.
- Make the main preload scanner correctly process the remaining source if script execution blocked the parser.

Tests: fast/preloader/document-write-2.html
       fast/preloader/document-write.html

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan):
* html/parser/HTMLDocumentParser.h:
(WebCore::HTMLDocumentParser::hasPreloadScanner):
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::execute):
* html/parser/HTMLScriptRunnerHost.h:

LayoutTests:

* fast/preloader/document-write-2-expected.txt: Added.
* fast/preloader/document-write-2.html: Added.
* fast/preloader/document-write-expected.txt: Added.
* fast/preloader/document-write.html: Added.
* fast/preloader/resources/document-write-plaintext.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Thu, 31 Mar 2011 22:43:48 +0000 (22:43 +0000)]
2011-03-31  Tony Gentilcore  <tonyg@chromium.org>

        Build fix: Add missing include
        https://bugs.webkit.org/show_bug.cgi?id=57587

        * loader/cache/CachedResourceLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Thu, 31 Mar 2011 22:19:48 +0000 (22:19 +0000)]
2011-03-31  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
        https://bugs.webkit.org/show_bug.cgi?id=42692

        Unskip passed tests.

        * platform/mac-wk2/Skipped:
2011-03-31  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
        https://bugs.webkit.org/show_bug.cgi?id=42692

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Thu, 31 Mar 2011 22:14:27 +0000 (22:14 +0000)]
2011-03-31  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Antti Koivisto.

        PreloadScanner doesn&apos;t find image while executing script in head
        https://bugs.webkit.org/show_bug.cgi?id=45072

        * fast/loader/willSendRequest-null-for-preload.html: Need to call
        setWilSendRequestReturnsNull() prior to invoking the preload scanner
        while blocked on empty-script.js.
        * fast/preloader/scan-body-from-head-expected.txt: Added.
        * fast/preloader/scan-body-from-head.html: Added. Notice that in the
        loaded resource output, the script and style are requested before the
        image even though the image is first in the DOM. This means it was
        queued up to wait for renderering rather than loaded immediately.
2011-03-31  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Antti Koivisto.

        PreloadScanner doesn&apos;t find image while executing script in head
        https://bugs.webkit.org/show_bug.cgi?id=45072

        Previously, while parsing the head, no resources in the body would be
        preloaded. After this patch, we will preload scripts and styles in the
        body, although we continue to hold off on all images until the page is
        first rendered.

        To evaluate this change, I've recorded a sampling of 45 of alexa's top
        sites and replayed them under simulated bandwidth conditions, loading
        each 5-15 times until stddev is small enough.

        Time to the load event improved at the overall average by 3%.
        Most sites are unchanged, but sites with certain blocking patterns had
        big wins -- ebay 19% (331ms), microsoft 15% (226ms), conduit 15% (277ms)
        nytimes 7% (182ms).

        Time to DOM content loaded event improved by 6% with some even bigger
        individual wins.

        First paint time held steady.

        Note that I originally wanted to allow preloading of images while in the
        head, but that regressed first paint time (even though it was better for
        overall load time).

        Test: fast/preloader/scan-body-from-head.html

        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::preload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Thu, 31 Mar 2011 22:12:17 +0000 (22:12 +0000)]
2011-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82616.
        http://trac.webkit.org/changeset/82616
        https://bugs.webkit.org/show_bug.cgi?id=57585

        New test does not pass on Gtk, chromium-mac, chromium-linux
        and possibly elsewhere (Requested by abarth|gardener on
        #webkit).

        * plugins/windowless_plugin_paint_test-expected.txt: Removed.
        * plugins/windowless_plugin_paint_test.html: Removed.
2011-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82616.
        http://trac.webkit.org/changeset/82616
        https://bugs.webkit.org/show_bug.cgi?id=57585

        New test does not pass on Gtk, chromium-mac, chromium-linux
        and possibly elsewhere (Requested by abarth|gardener on
        #webkit).

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::setWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSandbox violations when playing back HTML5 video on YouTube
weinig@apple.com [Thu, 31 Mar 2011 22:10:40 +0000 (22:10 +0000)]
Sandbox violations when playing back HTML5 video on YouTube
<rdar://problem/8950692>

Reviewed by Anders Carlsson.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 31 Mar 2011 22:09:32 +0000 (22:09 +0000)]
2011-03-31  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=57573

        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
        (WKBundlePageSimulateMouseDown): Added.
        (WKBundlePageSimulateMouseUp): Added.
        (WKBundlePageSimulateMouseMotion): Added.
        * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Added above functions.
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::simulateMouseDown): Added.
        (WebKit::WebPage::simulateMouseUp): Added.
        (WebKit::WebPage::simulateMouseMotion): Added.
        * WebProcess/WebPage/WebPage.h: Added above functions.
2011-03-31  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=57573

        * platform/mac-wk2/Skipped: Removed now-passing tests. Resorted
        the section under eventSender, and expanded directories to list
        the individual tests in that section.
2011-03-31  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=57573

        * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
        Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
        Removed fake definitions of keyDown and contextClick.

        * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
        (WTR::operator==): Added. So we can compare two WKPoint structs.
        (WTR::parseModifier): Added.
        (WTR::parseModifierArray): Added.
        (WTR::EventSendingController::EventSendingController): Initialize the
        new data members.
        (WTR::EventSendingController::mouseDown): Added. Calls
        WKBundlePageSimulateMouseDown.
        (WTR::EventSendingController::mouseUp): Added. Calls
        WKBundlePageSimulateMouseUp.
        (WTR::EventSendingController::mouseMoveTo): Added. Calls
        WKBundlePageSimulateMouseMotion.
        (WTR::EventSendingController::leapForward): Added.
        (WTR::EventSendingController::updateClickCount): Added. Used by the
        mouseDown/Up functions to create a click count.

        * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
        for the changes above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 31 Mar 2011 22:07:06 +0000 (22:07 +0000)]
2011-03-31  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Fix ownership semantics for LayerChromium/CCLayerImpl
        https://bugs.webkit.org/show_bug.cgi?id=57577

        LayerRendererChromium now uses a RefPtr to preserve ownership of all
        of the CCLayerImpl layers that it is using during the update/draw
        pass.  Addtionally, when a LayerChromium is destroyed, the weak
        owner pointer from its CCLayerImpl is correctly unset.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::compareLayerZ):
        (WebCore::LayerRendererChromium::updateAndDrawLayers):
        (WebCore::LayerRendererChromium::updateLayers):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
        (WebCore::LayerRendererChromium::drawLayer):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/RenderSurfaceChromium.h:
        * platform/graphics/chromium/VideoLayerChromium.cpp:
        (WebCore::VideoLayerChromium::updateCompositorResources):
        * platform/graphics/chromium/cc/CCLayerImpl.cpp:
        (WebCore::CCLayerImpl::drawsContent):
        (WebCore::CCLayerImpl::cleanupResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 31 Mar 2011 22:01:57 +0000 (22:01 +0000)]
2011-03-31  Adam Barth  <abarth@webkit.org>

        Update Chromium expected results for Hyatt's change.  I haven't
        verified these with Hyatt, but they seem reasonable.

        * platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.checksum:
        * platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.png:
        * platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum:
        * platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png:
        * platform/chromium-linux/fast/multicol/layers-in-multicol-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/nested-columns-expected.checksum:
        * platform/chromium-linux/fast/multicol/nested-columns-expected.png:
        * platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.checksum:
        * platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png:
        * platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.checksum:
        * platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png:
        * platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.checksum: Added.
        * platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png: Added.
        * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
        * platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/nested-columns-expected.png: Added.
        * platform/chromium-mac/fast/multicol/vertical-lr: Added.
        * platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
        * platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
        * platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/list-marker-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 31 Mar 2011 21:58:33 +0000 (21:58 +0000)]
2011-03-31  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Rename WebCore's UI_STRING to WEB_UI_STRING to not overlap with WebKit API
        https://bugs.webkit.org/show_bug.cgi?id=57582

        * platform/DefaultLocalizationStrategy.cpp:
        * platform/LocalizedStrings.h:
2011-03-31  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Rename WebCore's UI_STRING to WEB_UI_STRING to not overlap with WebKit API
        https://bugs.webkit.org/show_bug.cgi?id=57582

        * PluginProcess/mac/PluginProcessMac.mm:
        (WebKit::PluginProcess::platformInitialize):
        * UIProcess/mac/WebInspectorProxyMac.mm:
        (WebKit::WebInspectorProxy::platformInspectedURLChanged):
        * WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
        * WebProcess/mac/WebProcessMac.mm:
        (WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 31 Mar 2011 21:47:35 +0000 (21:47 +0000)]
2011-03-31  Adam Barth  <abarth@webkit.org>

        One more results update.  This change is just 1px off from the result
        Hyatt landed.

        * platform/gtk/fast/text/emphasis-avoid-ruby-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 31 Mar 2011 21:40:14 +0000 (21:40 +0000)]
2011-03-31  Adam Barth  <abarth@webkit.org>

        Hyatt says these are also progressions.

        * platform/gtk/fast/inline-block/inline-block-vertical-align-expected.txt:
        * platform/gtk/fast/multicol/layers-in-multicol-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 31 Mar 2011 21:35:48 +0000 (21:35 +0000)]
2011-03-31  Adam Barth  <abarth@webkit.org>

        Hyatt says this is a progression.

        * platform/qt/fast/multicol/layers-in-multicol-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 31 Mar 2011 21:33:10 +0000 (21:33 +0000)]
2011-03-31  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Rename BidiResolver::lastBeforeET to m_lastBeforeET to match modern style
        https://bugs.webkit.org/show_bug.cgi?id=57550

        * platform/text/BidiResolver.h:
        (WebCore::::createBidiRunsForLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Thouraya ANDOLSI <thouraya.andolsi@st.com>
commit-queue@webkit.org [Thu, 31 Mar 2011 21:25:42 +0000 (21:25 +0000)]
2011-03-31  Thouraya ANDOLSI  <thouraya.andolsi@st.com>

        Reviewed by Oliver Hunt.

        SH4 JIT SUPPORT.
        https://bugs.webkit.org/show_bug.cgi?id=44329

        Add YARR support for SH4 platforms (disabled by default).

        * GNUmakefile.am:
        * assembler/MacroAssembler.h:
        * assembler/MacroAssemblerSH4.cpp: Added.
        * assembler/MacroAssemblerSH4.h: Added.
        * assembler/SH4Assembler.h: Added.
        * yarr/YarrJIT.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Anantanarayanan G Iyengar <ananta@chromium.org>
commit-queue@webkit.org [Thu, 31 Mar 2011 21:25:19 +0000 (21:25 +0000)]
2011-03-31  Anantanarayanan G Iyengar  <ananta@chromium.org>

        Reviewed by James Robinson.

        https://bugs.webkit.org/show_bug.cgi?id=45855
        Windowless plugins added dynamically to the DOM should receive paint events.
        This is done by ensuring that the plugin widget is marked for painting when
        it is added.

        * plugins/windowless_plugin_paint_test-expected.txt: Added.
        * plugins/windowless_plugin_paint_test.html: Added.
2011-03-31  Anantanarayanan G Iyengar  <ananta@chromium.org>

        Reviewed by James Robinson.

        https://bugs.webkit.org/show_bug.cgi?id=45855
        Windowless plugins added dynamically to the DOM should receive paint events.
        This is done by ensuring that the plugin widget is marked for painting when
        it is added.

        Test: plugins/windowless_plugin_paint_test.html

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::setWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpecify both FILE_MAP_READ and FILE_MAP_WRITE when creating a read-write SharedMemory...
aroben@apple.com [Thu, 31 Mar 2011 21:09:30 +0000 (21:09 +0000)]
Specify both FILE_MAP_READ and FILE_MAP_WRITE when creating a read-write SharedMemory object

When passed to ::MapViewOfFile, FILE_MAP_WRITE implies FILE_MAP_READ, but other file mapping
APIs don't work that way. This bug wasn't causing any problems in practice, but it would
have prevented us from creating a DIB that wraps a SharedMemory object (which I noticed
while working on another bug).

Fixes <http://webkit.org/b/57576> File mappings used by read-write SharedMemory objects
aren't correctly marked as read-write after being sent over a CoreIPC::Connection

Reviewed by Brian Weinstein.

* Platform/win/SharedMemoryWin.cpp:
(WebKit::accessRights): Specify FILE_MAP_READ in addition to FILE_MAP_WRITE for read-write
SharedMemory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Thu, 31 Mar 2011 20:53:21 +0000 (20:53 +0000)]
2011-03-31  Stephen White  <senorblanco@chromium.org>

        Reviewed by Kenneth Russell.

        Speed up accelerated path drawing.
        https://bugs.webkit.org/show_bug.cgi?id=57371
        This CL does three things:  re-uses the same vertex and index buffer
        for all path draws, converts all vertex layouts from vec3 to vec2, and
        does a convexity check for polygons before passing them to the
        tesselator.

        Covered by canvas/philip/tests/2d.path.bezierCurveTo.*, and others.

        * platform/graphics/chromium/GLES2Canvas.cpp:
        Replace the Vector<double> for interpolated curves with a
        Vector<FloatPoint>.
        (WebCore::Cubic::evaluate):
        Inline the evaluation function (as Quadratic does).
        (WebCore::GLES2Canvas::GLES2Canvas):
        Initialize the m_pathIndexBuffer.
        (WebCore::GLES2Canvas::~GLES2Canvas):
        Delete the path vertex and index buffers on destruction.
        (WebCore::interpolateQuadratic):
        (WebCore::interpolateCubic):
        Interpolate directly to a Vector<FloatPoint>, rather than
        Vector<double>.
        (WebCore::PolygonData::PolygonData):
        (WebCore::combineData):
        Replace the DoubleVector with a FloatPointVector.
        (WebCore::GLES2Canvas::tesselateAndFillPath):
        Move curve drawing into this function, and rename it to reflect the
        new behaviour.  Re-use the common vertex and index buffers.  If the
        curve consists of a single convex polygon, draw the curve as a single
        triangle fan.  Otherwise, convert it to doubles and pass it to the
        tesselator.
        (WebCore::GLES2Canvas::fillPathInternal):
        * platform/graphics/chromium/GLES2Canvas.h:
        Rename createVertexBufferFromPath() -> tesselateAndFillPath().
        Add a persistent index buffer for all path draws.
        * platform/graphics/gpu/BicubicShader.cpp:
        (WebCore::BicubicShader::create):
        (WebCore::BicubicShader::use):
        * platform/graphics/gpu/ConvolutionShader.cpp:
        (WebCore::ConvolutionShader::create):
        (WebCore::ConvolutionShader::use):
        Use vec2s instead of vec3s for all vertex data.
        * platform/graphics/gpu/LoopBlinnMathUtils.cpp:
        (WebCore::LoopBlinnMathUtils::convexCompare):
        (WebCore::LoopBlinnMathUtils::convexCross):
        (WebCore::LoopBlinnMathUtils::convexCheckTriple):
        (WebCore::LoopBlinnMathUtils::isConvex):
        * platform/graphics/gpu/LoopBlinnMathUtils.h:
        Implement a convexity check, based on the code in Graphics Gems IV.
        * platform/graphics/gpu/Shader.cpp:
        (WebCore::Shader::generateVertex):
        * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
        (WebCore::SharedGraphicsContext3D::useQuadVertices):
        * platform/graphics/gpu/SolidFillShader.cpp:
        (WebCore::SolidFillShader::use):
        * platform/graphics/gpu/TexShader.cpp:
        (WebCore::TexShader::use):
        Use vec2s instead of vec3s for all vertex data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 31 Mar 2011 20:42:33 +0000 (20:42 +0000)]
2011-03-31  Adam Barth  <abarth@webkit.org>

        Copy expectation from downstream.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 31 Mar 2011 20:41:42 +0000 (20:41 +0000)]
2011-03-31  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]
        https://bugs.webkit.org/show_bug.cgi?id=26667

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _handleStyleKeyEquivalent:]): Handle the case where WebView is
        nil rather than asserting that it is non-nil. One case where WebView will be nil
        is when the frame is closed, but in any case where it is nil, the correct thing
        to do is to not try to handle the style key.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=57565
hyatt@apple.com [Thu, 31 Mar 2011 20:40:48 +0000 (20:40 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57565

Reviewed by Simon Fraser.

Source/WebCore:

Optimize overflow computations on lines to avoid allocating RenderOverflows in nearly all cases and to avoid even having
to check the line for overflow in the first place.

For the purposes of overflow computation, an inline object's default containment box for overflow is now assumed to extend
all the way from lineTop to lineBottom instead of snugly fitting the inline object's own block dimensions. This allows
replaced objects to be inside spans without triggering overflow allocation.

The overflow accessors on InlineFlowBox have been changed to require passing in the lineTop and lineBottom so that the block
dimensions can be forced to those values. Because these values are checked during painting and hit testing of lines, the
lineTop and lineBottom are now passed as arguments to the painting and hit testing functions to avoid repeatedly crawling
back up to the root box to fetch them.

Added a new boolean flag to all InlineBoxes, knownToHaveNoOverflow(), and optimized for common cases where no overflow can
possibly be present.  When the bit is set, computeOverflow will just immediately return.

This change speeds up line layout by ~10%.

* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::nodeAtPoint):
* rendering/EllipsisBox.h:
* rendering/InlineBox.cpp:
(WebCore::InlineBox::paint):
(WebCore::InlineBox::nodeAtPoint):
(WebCore::InlineBox::clearKnownToHaveNoOverflow):
* rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::logicalFrameRect):
(WebCore::InlineBox::knownToHaveNoOverflow):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::addReplacedChildOverflow):
(WebCore::InlineFlowBox::computeOverflow):
(WebCore::InlineFlowBox::setLayoutOverflow):
(WebCore::InlineFlowBox::setVisualOverflow):
(WebCore::InlineFlowBox::setOverflowFromLogicalRects):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
(WebCore::InlineFlowBox::logicalRightLayoutOverflow):
(WebCore::InlineFlowBox::logicalTopLayoutOverflow):
(WebCore::InlineFlowBox::logicalBottomLayoutOverflow):
(WebCore::InlineFlowBox::logicalLayoutOverflowRect):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):
(WebCore::InlineFlowBox::logicalTopVisualOverflow):
(WebCore::InlineFlowBox::logicalBottomVisualOverflow):
(WebCore::InlineFlowBox::logicalVisualOverflowRect):
(WebCore::InlineFlowBox::frameRectIncludingLineHeight):
(WebCore::InlineFlowBox::logicalFrameRectIncludingLineHeight):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):
* rendering/InlineTextBox.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::adjustLinePositionForPagination):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
* rendering/RenderBox.h:
(WebCore::RenderBox::hasRenderOverflow):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::paintEllipsisBox):
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::paint):
(WebCore::RootInlineBox::nodeAtPoint):
(WebCore::RootInlineBox::paddedLayoutOverflowRect):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::logicalTopVisualOverflow):
(WebCore::RootInlineBox::logicalBottomVisualOverflow):
(WebCore::RootInlineBox::logicalTopLayoutOverflow):
(WebCore::RootInlineBox::logicalBottomLayoutOverflow):
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paint):
* rendering/svg/SVGInlineFlowBox.h:
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paint):
* rendering/svg/SVGInlineTextBox.h:
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):
* rendering/svg/SVGRootInlineBox.h:

LayoutTests:

Optimize overflow computations on lines to avoid allocating RenderOverflows in nearly all cases and to avoid even having
to check the line for overflow in the first place.

Updated results for tests that progressed.

* fast/text/emphasis-avoid-ruby-expected.txt:
* platform/mac/fast/inline-block/inline-block-vertical-align-expected.checksum:
* platform/mac/fast/inline-block/inline-block-vertical-align-expected.png:
* platform/mac/fast/inline-block/inline-block-vertical-align-expected.txt:
* platform/mac/fast/multicol/layers-in-multicol-expected.checksum:
* platform/mac/fast/multicol/layers-in-multicol-expected.png:
* platform/mac/fast/multicol/layers-in-multicol-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoQuote the executable path we pass to ::CreateProcessW
aroben@apple.com [Thu, 31 Mar 2011 20:21:07 +0000 (20:21 +0000)]
Quote the executable path we pass to ::CreateProcessW

This will ensure that spaces in the path will be interpreted correctly.

Fixes <http://webkit.org/b/57569> Web process sometimes fails to launch when there are
spaces in its path

Reviewed by Steve Falkenburg.

* UIProcess/Launcher/win/ProcessLauncherWin.cpp:
(WebKit::ProcessLauncher::launchProcess): Surround the executable path in quotes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 31 Mar 2011 20:12:18 +0000 (20:12 +0000)]
2011-03-31  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: disable properties abbreviation.
        https://bugs.webkit.org/show_bug.cgi?id=57525

        * inspector/console/console-dir-global.html:
        * inspector/protocol/runtime-agent-expected.txt:
        * inspector/protocol/runtime-agent.html:
2011-03-31  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: disable properties abbreviation.
        https://bugs.webkit.org/show_bug.cgi?id=57525

        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::getProperties):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptSource.js:
        (.):
        ():
        * inspector/Inspector.json:
        * inspector/InspectorRuntimeAgent.cpp:
        (WebCore::InspectorRuntimeAgent::getProperties):
        * inspector/InspectorRuntimeAgent.h:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.completions.evaluated):
        (WebInspector.ConsoleView.prototype._formatarray):
        * inspector/front-end/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertiesSection.prototype.update.callback):
        (WebInspector.ObjectPropertiesSection.prototype.update):
        (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
        (WebInspector.ObjectPropertyTreeElement.prototype.update):
        (WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
        * inspector/front-end/PropertiesSidebarPane.js:
        (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
        * inspector/front-end/RemoteObject.js:
        (WebInspector.RemoteObject.prototype.getOwnProperties):
        (WebInspector.RemoteObject.prototype.getAllProperties):
        (WebInspector.RemoteObject.prototype._getProperties):
        (WebInspector.LocalJSONObject.prototype.getOwnProperties):
        (WebInspector.LocalJSONObject.prototype.getAllProperties):
        * inspector/front-end/inspector.css:
        (.console-formatted-string, .console-formatted-regexp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate WKCACFViewLayerTreeHost for changes to WKCACFView API
aroben@apple.com [Thu, 31 Mar 2011 20:05:05 +0000 (20:05 +0000)]
Update WKCACFViewLayerTreeHost for changes to WKCACFView API

This should not result in any change in behavior.

Fixes <http://webkit.org/b/57560> WKCACFViewLayerTreeHost needs to tell WKCACFView where to
render

Reviewed by Darin Adler.

* platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Updated API declarations.
(WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost): Tell WKCACFView it should
render into the window we give it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Thu, 31 Mar 2011 19:48:37 +0000 (19:48 +0000)]
2011-03-31  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] Activate 10 tests for media elements.
        https://bugs.webkit.org/show_bug.cgi?id=57553

        Skip that one for now. The bots need to be updated.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Marius Storm-Olsen <marius.storm-olsen@nokia.com>
commit-queue@webkit.org [Thu, 31 Mar 2011 19:30:25 +0000 (19:30 +0000)]
2011-03-31  Marius Storm-Olsen  <marius.storm-olsen@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
        https://bugs.webkit.org/show_bug.cgi?id=57017

        Build fix. No new tests.

        * WebCore.pri:
2011-03-31  Marius Storm-Olsen  <marius.storm-olsen@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
        https://bugs.webkit.org/show_bug.cgi?id=57017

        Build fix. No new tests.

        * QtWebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Thu, 31 Mar 2011 19:27:30 +0000 (19:27 +0000)]
2011-03-31  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        XML viewer is not shown when frame has non-null opener
        https://bugs.webkit.org/show_bug.cgi?id=56384

        Enabled test for extensions hooks in xml viewer.

        * http/tests/xmlviewer/extensions-api-expected.txt: Added.
        * http/tests/xmlviewer/extensions-api.html: Added.
        * http/tests/xmlviewer/resources/sample.xml: Added.
        * platform/qt/Skipped:
        * xmlviewer/extensions-api-expected.txt: Removed.
        * xmlviewer/extensions-api.html_disabled: Removed.
2011-03-31  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        XML viewer is not shown when frame has non-null opener
        https://bugs.webkit.org/show_bug.cgi?id=56384

        Removed opener check in XML viewer

        Test: http/tests/xmlviewer/extensions-api.html

        * xml/XMLTreeViewer.cpp:
        (WebCore::XMLTreeViewer::hasNoStyleInformation):
        * xml/XMLViewer.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Patch by John Harvey, reviewed and tweaked by me.
ap@apple.com [Thu, 31 Mar 2011 18:55:38 +0000 (18:55 +0000)]
    Patch by John Harvey, reviewed and tweaked by me.

        <rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text.

        * Plugins/Hosted/WebTextInputWindowController.m:
        (-[WebTextInputPanel _interpretKeyEvent:string:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Thu, 31 Mar 2011 18:17:05 +0000 (18:17 +0000)]
2011-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82589.
        http://trac.webkit.org/changeset/82589
        https://bugs.webkit.org/show_bug.cgi?id=57564

        This patch requires many more updated results than it contains
        (Requested by abarth|gardener on #webkit).

        * fast/dom/HTMLMeterElement/meter-element.html:
        * fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html:
        * fast/dom/HTMLMeterElement/meter-styles.html:
        * platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum:
        * platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
        * platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.png:
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
2011-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82589.
        http://trac.webkit.org/changeset/82589
        https://bugs.webkit.org/show_bug.cgi?id=57564

        This patch requires many more updated results than it contains
        (Requested by abarth|gardener on #webkit).

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::pseudoId):
        (WebCore::nameToPseudoTypeMap):
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        * css/html.css:
        (meter::-webkit-meter-horizontal-bar):
        (meter::-webkit-meter-vertical-bar):
        (meter::-webkit-meter-horizontal-optimum-value):
        (meter::-webkit-meter-horizontal-suboptimal-value):
        (meter::-webkit-meter-horizontal-even-less-good-value):
        (meter::-webkit-meter-vertical-optimum-value):
        (meter::-webkit-meter-vertical-suboptimal-value):
        (meter::-webkit-meter-vertical-even-less-good-value):
        * rendering/RenderMeter.cpp:
        (WebCore::MeterPartElement::MeterPartElement):
        (WebCore::MeterPartElement::createForPart):
        (WebCore::MeterPartElement::hide):
        (WebCore::MeterPartElement::restoreVisibility):
        (WebCore::MeterPartElement::updateStyleForPart):
        (WebCore::MeterPartElement::saveVisibility):
        (WebCore::RenderMeter::~RenderMeter):
        (WebCore::RenderMeter::createPart):
        (WebCore::RenderMeter::updateFromElement):
        (WebCore::RenderMeter::layoutParts):
        (WebCore::RenderMeter::shouldHaveParts):
        (WebCore::RenderMeter::valuePartRect):
        (WebCore::RenderMeter::orientation):
        (WebCore::RenderMeter::valuePseudoId):
        (WebCore::RenderMeter::barPseudoId):
        * rendering/RenderMeter.h:
        (WebCore::RenderMeter::shadowAttached):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::supportsMeter):
        * rendering/RenderTheme.h:
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintMeter):
        (WebCore::RenderThemeMac::supportsMeter):
        * rendering/style/RenderStyleConstants.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Thu, 31 Mar 2011 18:14:59 +0000 (18:14 +0000)]
2011-03-31  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] Activate 10 tests for media elements.
        https://bugs.webkit.org/show_bug.cgi?id=57553

        Reactivate some media tests for Qt so we improve our coverage.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 31 Mar 2011 18:04:39 +0000 (18:04 +0000)]
2011-03-31  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan, Darin Adler, Dan Bernstein and Sam Weinig.

        If a user doesn't have a Database/LocalStorage directory, it can't be created (sandbox violations)
        https://bugs.webkit.org/show_bug.cgi?id=57561
        <rdar://problem/9127411>

        Ensure that any readwrite sandbox directories actually exist before entering the sandbox.

        * WebProcess/mac/WebProcessMac.mm:
        (WebKit::appendReadwriteSandboxDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 31 Mar 2011 17:37:59 +0000 (17:37 +0000)]
2011-03-31  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Link explicitly with XRender on Linux/Unix
        https://bugs.webkit.org/show_bug.cgi?id=57558

        Some linkers, like GNU Gold, require explicit linkage of all the
        libraries used instead of relying on our dependencies to bring
        them in. In this case, the build fails because we use XRender in
        the plugin code but don't link directly to it.

        * configure.ac: check for XRender on UNIX.
2011-03-31  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Link explicitly with XRender on Linux/Unix
        https://bugs.webkit.org/show_bug.cgi?id=57558

        * GNUmakefile.am: add XRender CFLAGS.
2011-03-31  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Link explicitly with XRender on Linux/Unix
        https://bugs.webkit.org/show_bug.cgi?id=57558

        * GNUmakefile.am: add XRender LIBS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove XMLViewer.css and XMLViewer.js from the WebCore Sources to fix a warning.
timothy@apple.com [Thu, 31 Mar 2011 17:35:29 +0000 (17:35 +0000)]
Remove XMLViewer.css and XMLViewer.js from the WebCore Sources to fix a warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 31 Mar 2011 17:25:56 +0000 (17:25 +0000)]
2011-03-31  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Rename BidiResolver::emptyRun to m_emtpyRun to match modern style
        https://bugs.webkit.org/show_bug.cgi?id=57549

        * platform/text/BidiResolver.h:
        (WebCore::BidiResolver::BidiResolver):
        (WebCore::::appendRun):
        (WebCore::::lowerExplicitEmbeddingLevel):
        (WebCore::::raiseExplicitEmbeddingLevel):
        (WebCore::::deleteRuns):
        (WebCore::::createBidiRunsForLine):
        * rendering/InlineIterator.h:
        (WebCore::InlineBidiResolver::appendRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Tom Sepez <tsepez@chromium.org>
inferno@chromium.org [Thu, 31 Mar 2011 17:20:13 +0000 (17:20 +0000)]
2011-03-31  Tom Sepez  <tsepez@chromium.org>

        Reviewed by Eric Seidel.

        Make ContainerNode::insertIntoDocument() collect all nodes before
        operating on any of them.  Add small helper function and use it
        througout the file where this action is already taking place.
        https://bugs.webkit.org/show_bug.cgi?id=57265

        Test: svg/dom/range-delete.html

        * dom/ContainerNode.cpp:
        (WebCore::collectNodes):
        (WebCore::collectTargetNodes):
        (WebCore::ContainerNode::takeAllChildrenFrom):
        (WebCore::willRemoveChildren):
        (WebCore::ContainerNode::insertedIntoDocument):
2011-03-31  Tom Sepez  <tsepez@chromium.org>

        Reviewed by Eric Seidel.

        Test that script inside an SVG can delete a range containing
        itself when invoked on top of script manipulating it.
        https://bugs.webkit.org/show_bug.cgi?id=57265

        * svg/dom/range-delete-expected.txt: Added.
        * svg/dom/range-delete.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Satish Sampath <satish@chromium.org>
satish@chromium.org [Thu, 31 Mar 2011 17:18:02 +0000 (17:18 +0000)]
2011-03-31  Satish Sampath  <satish@chromium.org>

        Reviewed by Steve Block.

        While drawing a speech input button, validate that the node is really a speech input button.
        https://bugs.webkit.org/show_bug.cgi?id=57469

        * fast/speech/speech-style-on-non-speech-elements-expected.txt: Added.
        * fast/speech/speech-style-on-non-speech-elements.html: Added.
2011-03-31  Satish Sampath  <satish@chromium.org>

        Reviewed by Steve Block.

        While drawing a speech input button, validate that the node is really a speech input button.
        https://bugs.webkit.org/show_bug.cgi?id=57469

        Test: fast/speech/speech-style-on-non-speech-elements.html

        * dom/Element.h:
        (WebCore::Element::isInputFieldSpeechButtonElement):
        * html/shadow/TextControlInnerElements.h:
        (WebCore::InputFieldSpeechButtonElement::isInputFieldSpeechButtonElement):
        (WebCore::toInputFieldSpeechButtonElement):
        * rendering/RenderInputSpeech.cpp:
        (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9214824> Find client not told when WKPageCountStringMatches exceeds...
sullivan@apple.com [Thu, 31 Mar 2011 17:09:53 +0000 (17:09 +0000)]
<rdar://problem/9214824> Find client not told when WKPageCountStringMatches exceeds maximum
https://bugs.webkit.org/show_bug.cgi?id=57552

Reviewed by Darin Adler and Adam Roben.

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::countStringMatches):
Use the same technique as findString() to report kWKMoreThanMaximumMatchCount when appropriate.
(WebKit::FindController::findString):
Convert numeric_limits::max() to max() - 1 to avoid overflow case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 31 Mar 2011 16:59:57 +0000 (16:59 +0000)]
2011-03-31  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix after r82588. Reverted unintentional change.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyMovingLeft):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Thu, 31 Mar 2011 16:57:24 +0000 (16:57 +0000)]
2011-03-31  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Warnings happening because of unhandled switch cases in AccessibilityObjectWrapperAtk
        https://bugs.webkit.org/show_bug.cgi?id=57534

        Fix compilation warnings.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (getAttributeSetForAccessibilityObject): Add unhandled cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Thu, 31 Mar 2011 16:53:35 +0000 (16:53 +0000)]
2011-03-31  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
        https://bugs.webkit.org/show_bug.cgi?id=57362

        * platform/gtk/Skipped: unskipped
        fast/loader/onload-willSendRequest-null-for-frame.html.
2011-03-31  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
        https://bugs.webkit.org/show_bug.cgi?id=57362

        Do not generate DRT output if willSendRequestReturnsNull is set.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (willSendRequestCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-30 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 31 Mar 2011 16:34:13 +0000 (16:34 +0000)]
2011-03-30  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove unnecessary newBody output parameter from editScriptSource protocol method.
        https://bugs.webkit.org/show_bug.cgi?id=57444

        * http/tests/inspector/debugger-test.js:
        (initialize_DebuggerTest):
        * inspector/debugger/live-edit-expected.txt:
        * inspector/debugger/live-edit.html:
        * inspector/debugger/resources/edit-me-when-paused.js: Added.
        (f2):
        (f1):
2011-03-30  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove unnecessary newBody output parameter from editScriptSource protocol method.
        https://bugs.webkit.org/show_bug.cgi?id=57444

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::editScriptSource):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::editScriptSource):
        * bindings/v8/ScriptDebugServer.h:
        * inspector/Inspector.json:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::editScriptSource):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.editScriptSource):
        (WebInspector.DebuggerModel.prototype._didEditScriptSource):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
        (WebInspector.SourceFrame.prototype._handleSave):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-30 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 31 Mar 2011 16:32:03 +0000 (16:32 +0000)]
2011-03-30  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        <meter> can only support horizontal indicator
        https://bugs.webkit.org/show_bug.cgi?id=56001

        - Simpflied some test cases which had vertical indicators.
        - Updated expectations due to shadow structure change

        * fast/dom/HTMLMeterElement/meter-element.html:
        * fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html:
        * fast/dom/HTMLMeterElement/meter-styles.html:
        * platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum:
        * platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
        * platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.png:
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
2011-03-30  MORITA Hajime <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        <meter> can only support horizontal indicator
        https://bugs.webkit.org/show_bug.cgi?id=56001

        - Removed code which deals with the direction and
          left the horizontal path.
        - Removed "horizontal" from related names which is now
          redundant.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::pseudoId):
        (WebCore::nameToPseudoTypeMap):
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        * css/html.css:
        (meter::-webkit-meter-bar):
        (meter::-webkit-meter-optimum-value):
        (meter::-webkit-meter-suboptimal-value):
        (meter::-webkit-meter-even-less-good-value):
        * rendering/RenderMeter.cpp:
        (WebCore::RenderMeter::~RenderMeter):
        (WebCore::RenderMeter::createPart):
        (WebCore::RenderMeter::updateFromElement):
        (WebCore::RenderMeter::layoutParts):
        (WebCore::RenderMeter::styleDidChange):
        (WebCore::RenderMeter::shouldHaveParts):
        (WebCore::RenderMeter::valuePartRect):
        (WebCore::RenderMeter::valuePseudoId):
        (WebCore::RenderMeter::barPseudoId):
        (WebCore::RenderMeter::detachShadows):
        (WebCore::RenderMeter::updateShadows):
        * rendering/RenderMeter.h:
        (WebCore::RenderMeter::shadowAttached):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::supportsMeter):
        * rendering/RenderTheme.h:
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintMeter):
        (WebCore::RenderThemeMac::supportsMeter):
        * rendering/style/RenderStyleConstants.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-30 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Thu, 31 Mar 2011 16:17:25 +0000 (16:17 +0000)]
2011-03-30  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Ryosuke Niwa.

        Experiment with moving caret by word in visual order.
        https://bugs.webkit.org/show_bug.cgi?id=57336

        * editing/selection/move-by-word-visually-expected.txt: Added.
        * editing/selection/move-by-word-visually.html: Added.
2011-03-30  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Ryosuke Niwa.

        Experiment with moving caret by word in visual order.
        https://bugs.webkit.org/show_bug.cgi?id=57336

        Follow Firefox's convention in Windows,
        In LTR block, word break visually moves cursor to the left boundary of words,
        In RTL block, word break visually moves cursor to the right boundary of words.

        This is the 1st version of implementing "move caret by word in visual order".
        It only works in the following situation:
        1. For a LTR box in a LTR block or a RTL box in RTL block,
        when caret is at the left boundary of the box and we are looking for
        the word boundary in right.
        2. For a LTR or RTL box in a LTR block, when caret is at the left boundary
        of the box and we are looking for the word boundary in left and
        previous box is a LTR box.
        3. For a LTR or RTL box in a RTL block, when the caret is at the right
        boundary of the box and we are looking for the word boundary in right and next box is RTL box.

        An experimental granularity is introduced, as a side effect, functions having switch statements
        to handle those granularities have to add more one case to handle this new granularity.
        The experimental granularity is exposed though JS by '-webkit-visual-word".

        The overall algorithm is looping through inline boxes visually and looking
        for the visually nearest word break position.

        Test: editing/selection/move-by-word-visually.html

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyExtendingRight):
        (WebCore::SelectionController::modifyExtendingForward):
        (WebCore::SelectionController::modifyMovingRight):
        (WebCore::SelectionController::modifyMovingForward):
        (WebCore::SelectionController::modifyExtendingLeft):
        (WebCore::SelectionController::modifyExtendingBackward):
        (WebCore::SelectionController::modifyMovingLeft):
        (WebCore::SelectionController::modifyMovingBackward):
        * editing/TextGranularity.h:
        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
        * editing/visible_units.cpp:
        (WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality):
        (WebCore::wordBoundaryInBox):
        (WebCore::wordBoundaryInAdjacentBoxes):
        (WebCore::leftWordBoundary):
        (WebCore::rightWordBoundary):
        (WebCore::leftWordPosition):
        (WebCore::rightWordPosition):
        * editing/visible_units.h:
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::modify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 31 Mar 2011 16:15:16 +0000 (16:15 +0000)]
2011-03-31  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r82580.

        * WebCoreSupport/FrameLoaderClientWinCE.h: StringWithDirection is in WebCore
                                                   and not in WTF namespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Evan Martin <evan@chromium.org>
evan@chromium.org [Thu, 31 Mar 2011 16:13:40 +0000 (16:13 +0000)]
2011-03-31  Evan Martin  <evan@chromium.org>

        Another build fix.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::updateGlobalHistory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Nancy Piedra <nancy.piedra@nokia.com>
commit-queue@webkit.org [Thu, 31 Mar 2011 16:07:25 +0000 (16:07 +0000)]
2011-03-31  Nancy Piedra  <nancy.piedra@nokia.com>

        Reviewed by Benjamin Poulain.

        [Qt] ChromeClientQt.h has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40239

        * WebCoreSupport/ChromeClientQt.h:
        (WebCore::ChromeClientQt::scrollbarsModeDidChange):
        (WebCore::ChromeClientQt::needTouchEvents):
        (WebCore::ChromeClientQt::formStateDidChange):
        (WebCore::ChromeClientQt::scrollRectIntoView):
        (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
        (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 31 Mar 2011 16:01:13 +0000 (16:01 +0000)]
2011-03-31  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Move coordinate-computing logic into MouseRelatedEvent.
        https://bugs.webkit.org/show_bug.cgi?id=57521

        Refactoring, covered by existing tests.

        * dom/EventDispatcher.cpp:
        (WebCore::EventDispatcher::dispatchWheelEvent): Yank calculation of
            coordinates out.
        (WebCore::EventDispatcher::dispatchMouseEvent): Ditto.
        * dom/MouseEvent.cpp:
        (WebCore::MouseEvent::create): Add coordinate-computing logic.
        * dom/MouseEvent.h: Adjust decl to reflect new meaning of params.
        * dom/MouseRelatedEvent.cpp:
        (WebCore::MouseRelatedEvent::MouseRelatedEvent): Ditto.
        * page/EventHandler.cpp:
        (WebCore::EventHandler::dispatchDragEvent): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-30 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 31 Mar 2011 15:58:02 +0000 (15:58 +0000)]
2011-03-30  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: document CSS agent.
        https://bugs.webkit.org/show_bug.cgi?id=57435

        * inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Evan Martin <evan@chromium.org>
evan@chromium.org [Thu, 31 Mar 2011 15:34:27 +0000 (15:34 +0000)]
2011-03-31  Evan Martin  <evan@chromium.org>

        Build fix from previous change.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
2011-03-31  Evan Martin  <evan@chromium.org>

        Build fix from previous change.

        * Api/qwebframe.cpp:
        (QWebFrame::title):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Thu, 31 Mar 2011 15:21:33 +0000 (15:21 +0000)]
2011-03-31  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: remove periods at the end of error messages
        https://bugs.webkit.org/show_bug.cgi?id=57544

        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::getProperties):
        (WebCore::InjectedScript::makeObjectCall):
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::elementForId):
        (WebCore::InspectorCSSAgent::styleSheetForId):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::assertNode):
        (WebCore::InspectorDOMAgent::assertElement):
        (WebCore::InspectorDOMAgent::assertHTMLElement):
        (WebCore::InspectorDOMAgent::querySelector):
        (WebCore::InspectorDOMAgent::querySelectorAll):
        (WebCore::InspectorDOMAgent::setAttribute):
        (WebCore::InspectorDOMAgent::removeAttribute):
        (WebCore::InspectorDOMAgent::removeNode):
        (WebCore::InspectorDOMAgent::setNodeValue):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::resourceContent):
        (WebCore::InspectorResourceAgent::resourceContentBase64):
        (WebCore::InspectorResourceAgent::getResourceContent):
        * inspector/InspectorRuntimeAgent.cpp:
        (WebCore::InspectorRuntimeAgent::setPropertyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Evan Martin <evan@chromium.org>
evan@chromium.org [Thu, 31 Mar 2011 15:17:13 +0000 (15:17 +0000)]
2011-03-31  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        <title> should support dir attribute
        https://bugs.webkit.org/show_bug.cgi?id=50961

        Introduce a new StringWithDirection object that carries a String along
        with the TextDirection associated with the String.  Use this object for
        document titles used within WebCore, because in HTML the direction of
        a title can be set with the 'dir' attribute.

        Put FIXMEs at the WebKit level to expose the new direction information
        to clients.

        No behavioral change intended, so no new tests.  A follow-up will expose
        the title direction and hopefully can be accompanied by tests that
        verify it is correct.

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::updateTitle):
        (WebCore::Document::setTitle):
        (WebCore::Document::removeTitle):
        * dom/Document.h:
        (WebCore::Document::title):
        * html/HTMLTitleElement.cpp:
        (WebCore::HTMLTitleElement::HTMLTitleElement):
        (WebCore::HTMLTitleElement::childrenChanged):
        (WebCore::HTMLTitleElement::text):
        (WebCore::HTMLTitleElement::textWithDirection):
        * html/HTMLTitleElement.h:
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::setTitle):
        * loader/DocumentLoader.h:
        (WebCore::DocumentLoader::title):
        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::dispatchDidReceiveTitle):
        (WebCore::EmptyFrameLoaderClient::setTitle):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::receivedFirstData):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::setTitle):
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/HistoryController.cpp:
        (WebCore::HistoryController::updateForBackForwardNavigation):
        (WebCore::HistoryController::updateForReload):
        (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
        (WebCore::HistoryController::updateForClientRedirect):
        (WebCore::HistoryController::updateForCommit):
        (WebCore::HistoryController::setCurrentItemTitle):
        (WebCore::HistoryController::initializeItem):
        * loader/HistoryController.h:
        * platform/text/StringWithDirection.h: Added.
        (WebCore::StringWithDirection::StringWithDirection):
        (WebCore::StringWithDirection::operator==):
        (WebCore::StringWithDirection::operator!=):
        * svg/SVGTitleElement.cpp:
        (WebCore::SVGTitleElement::insertedIntoDocument):
        (WebCore::SVGTitleElement::childrenChanged):
2011-03-31  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        <title> should support dir attribute
        https://bugs.webkit.org/show_bug.cgi?id=50961

        Update to new FrameLoaderClient interface.

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidReceiveTitle):
        (WebKit::FrameLoaderClientImpl::setTitle):
        * src/FrameLoaderClientImpl.h:
        * src/WebDataSourceImpl.cpp:
        (WebKit::WebDataSourceImpl::pageTitle):
2011-03-31  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        <title> should support dir attribute
        https://bugs.webkit.org/show_bug.cgi?id=50961

        Update to new FrameLoaderClient interface.

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::dispatchDidReceiveTitle):
        (WebCore::FrameLoaderClientEfl::setTitle):
        * WebCoreSupport/FrameLoaderClientEfl.h:
2011-03-31  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        <title> should support dir attribute
        https://bugs.webkit.org/show_bug.cgi?id=50961

        Update to new FrameLoaderClient interface.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
        (WebKit::FrameLoaderClient::setTitle):
        * WebCoreSupport/FrameLoaderClientGtk.h:
2011-03-31  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        <title> should support dir attribute
        https://bugs.webkit.org/show_bug.cgi?id=50961

        Update to new FrameLoaderClient interface.

        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
        (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveTitle):
        * WebCoreSupport/FrameLoaderClientHaiku.h:
2011-03-31  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        <title> should support dir attribute
        https://bugs.webkit.org/show_bug.cgi?id=50961

        Update to new FrameLoaderClient interface.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidReceiveTitle):
        (WebFrameLoaderClient::setTitle):
2011-03-31  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        <title> should support dir attribute
        https://bugs.webkit.org/show_bug.cgi?id=50961

        Update to new FrameLoaderClient interface.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
        (WebCore::FrameLoaderClientQt::setTitle):
        * WebCoreSupport/FrameLoaderClientQt.h:
2011-03-31  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        <title> should support dir attribute
        https://bugs.webkit.org/show_bug.cgi?id=50961

        Update to new FrameLoaderClient interface.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::dispatchDidReceiveTitle):
        * WebCoreSupport/WebFrameLoaderClient.h:
2011-03-31  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        <title> should support dir attribute
        https://bugs.webkit.org/show_bug.cgi?id=50961

        Update to new FrameLoaderClient interface.

        * WebCoreSupport/FrameLoaderClientWinCE.cpp:
        (WebKit::FrameLoaderClientWinCE::dispatchDidReceiveTitle):
        (WebKit::FrameLoaderClientWinCE::setTitle):
        * WebCoreSupport/FrameLoaderClientWinCE.h:
2011-03-31  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        <title> should support dir attribute
        https://bugs.webkit.org/show_bug.cgi?id=50961

        Update to new FrameLoaderClient interface.

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::dispatchDidReceiveTitle):
        (WebCore::FrameLoaderClientWx::setTitle):
        * WebKitSupport/FrameLoaderClientWx.h:
2011-03-31  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        <title> should support dir attribute
        https://bugs.webkit.org/show_bug.cgi?id=50961

        Update to new FrameLoaderClient interface.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
        (WebKit::WebFrameLoaderClient::setTitle):
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 31 Mar 2011 15:12:34 +0000 (15:12 +0000)]
2011-03-31  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, update chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 31 Mar 2011 15:03:50 +0000 (15:03 +0000)]
2011-03-31  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: CSS domain - make a "range" object, get rid of "properties" object for Style objects
        https://bugs.webkit.org/show_bug.cgi?id=57538

        WebCore:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::buildSourceRangeObject):
        (WebCore::InspectorStyle::buildObjectForStyle):
        (WebCore::InspectorStyle::populateObjectWithStyleProperties):
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleDeclaration):

        LayoutTests:
        * http/tests/inspector/elements-test.js:
        (initialize_ElementTest.InspectorTest.rangeText):
        (initialize_ElementTest):
        * inspector/styles/get-set-stylesheet-text.html:
        * inspector/styles/styles-new-API.html:
        * inspector/styles/styles-source-offsets.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Thu, 31 Mar 2011 14:54:48 +0000 (14:54 +0000)]
2011-03-31  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Csaba Osztrogon√°c.

        [WK2] Introduce an option for no NPAPI support
        https://bugs.webkit.org/show_bug.cgi?id=55828

        Stub out NPAPI support for platform and OS combinations that are
        not supported yet. Ancestor patch was made by Laszlo Gombos.

        * GNUmakefile.am: Add NetscapePluginModuleNone.cpp and NetscapePluginNone.cpp
        to the build system.

        * Shared/Plugins/Netscape/NetscapePluginModule.cpp:
        Remove the sanity check because from now all combinations that
        don't have an explicitly set plugin architecture fall into
        the PLUGIN_ARCHITECTURE(UNSUPPORTED) category and has a stubbed
        implementation.

        * Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp: Added.
        Stubbed implementation.
        (WebKit::NetscapePluginModule::getPluginInfo):
        (WebKit::NetscapePluginModule::determineQuirks):

        * Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp: Guard with
        PLUGIN_ARCHITECTURE(X11).

        * WebKit2.pro: Add NetscapePluginModuleNone.cpp and NetscapePluginNone.cpp
        to the build system.

        * WebProcess/Plugins/Netscape/NetscapePluginNone.cpp: Added.
        Stubbed implementation
        (WebKit::NetscapePlugin::platformPostInitialize):
        (WebKit::NetscapePlugin::platformDestroy):
        (WebKit::NetscapePlugin::platformInvalidate):
        (WebKit::NetscapePlugin::platformGeometryDidChange):
        (WebKit::NetscapePlugin::platformPaint):
        (WebKit::NetscapePlugin::platformHandleMouseEvent):
        (WebKit::NetscapePlugin::platformHandleWheelEvent):
        (WebKit::NetscapePlugin::platformSetFocus):
        (WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
        (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
        (WebKit::NetscapePlugin::platformHandleKeyboardEvent):

        * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Guard with
        PLUGIN_ARCHITECTURE(X11)

        * config.h: Introduce PLUGIN_ARCHITECTURE(UNSUPPORTED) as another
        option. Make platform and OS combinations that are not supported
        yet fall into this. Don't use Q_WS_X11 to test the window system
        for Qt because it is not defined without including <QtGlobal>.
        No clue about how could it work so far.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 31 Mar 2011 14:40:07 +0000 (14:40 +0000)]
2011-03-31  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, fix expectation files names after r82573.

        * platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-actual.checksum: Removed.
        * platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-actual.png.
        * platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-actual.checksum: Removed.
        * platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-actual.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 31 Mar 2011 14:29:51 +0000 (14:29 +0000)]
2011-03-31  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, mark two canvas tests as TIMEOUT on chromium-gpu

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 31 Mar 2011 14:25:25 +0000 (14:25 +0000)]
2011-03-31  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline of a bidi svg test.

        * platform/gtk/svg/text/bidi-embedded-direction-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 31 Mar 2011 14:11:26 +0000 (14:11 +0000)]
2011-03-31  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, update chromium-gpu-linux compositing expectations.

        * platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-actual.checksum: Added.
        * platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-actual.png: Added.
        * platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-actual.checksum: Added.
        * platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-actual.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 31 Mar 2011 13:53:57 +0000 (13:53 +0000)]
2011-03-31  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline of 2 tests.

        * platform/gtk/fast/borders/rtl-border-04-expected.txt:
        * platform/gtk/fast/borders/rtl-border-05-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 31 Mar 2011 13:24:54 +0000 (13:24 +0000)]
2011-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82565.
        http://trac.webkit.org/changeset/82565
        https://bugs.webkit.org/show_bug.cgi?id=57541

        Caused assertion failures. (Requested by bbandix on #webkit).

        * platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.checksum: Removed.
        * platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Removed.
        * platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.checksum: Removed.
        * platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Removed.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.checksum: Removed.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Removed.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.checksum: Removed.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Removed.
        * svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.txt: Removed.
        * svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html: Removed.
        * svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.txt: Removed.
        * svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html: Removed.
        * svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.txt: Removed.
        * svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html: Removed.
        * svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.txt: Removed.
        * svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html: Removed.
        * svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.js: Removed.
        * svg/dynamic-updates/script-tests/SVGFEFloodElement-inherit-flood-color-css-prop.js: Removed.
        * svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.js: Removed.
        * svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-lighting-color-css-prop.js: Removed.
2011-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82565.
        http://trac.webkit.org/changeset/82565
        https://bugs.webkit.org/show_bug.cgi?id=57541

        Caused assertion failures. (Requested by bbandix on #webkit).

        * platform/graphics/filters/FEFlood.cpp:
        (WebCore::FEFlood::setFloodColor):
        (WebCore::FEFlood::setFloodOpacity):
        * platform/graphics/filters/FEFlood.h:
        * platform/graphics/filters/FESpecularLighting.cpp:
        (WebCore::FESpecularLighting::setLightingColor):
        * platform/graphics/filters/FESpecularLighting.h:
        * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
        * rendering/svg/RenderSVGResourceFilterPrimitive.h:
        * rendering/svg/SVGResourcesCache.cpp:
        (WebCore::SVGResourcesCache::clientStyleChanged):
        * svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
        * svg/SVGFEFloodElement.cpp:
        * svg/SVGFEFloodElement.h:
        * svg/SVGFESpecularLightingElement.cpp:
        (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Vamshikrishna.Yellenki <vamshi@motorola.com> and Alejandro G. Castro...
alex@webkit.org [Thu, 31 Mar 2011 12:53:43 +0000 (12:53 +0000)]
2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        Implement MiniBrowser for Gtk port.
        https://bugs.webkit.org/show_bug.cgi?id=48512

        Initial implementation of the Gtk MiniBrowser.

        * GNUmakefile.am:

2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        Implement MiniBrowser for Gtk port.
        https://bugs.webkit.org/show_bug.cgi?id=48512

        Initial implementation of the Gtk MiniBrowser.

        * MiniBrowser/gtk/GNUmakefile.am: Added.
        * MiniBrowser/gtk/main.c: Added.
        (activateUriEntryCallback):
        (destroyCallback):
        (goBackCallback):
        (goForwardCallback):
        (createToolbar):
        (createWebView):
        (createWindow):
        (argumentToURL):
        (main):

2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        Implement MiniBrowser for Gtk port.
        https://bugs.webkit.org/show_bug.cgi?id=48512

        * Shared/API/c/gtk/WKBaseGtk.h: Add the stdbool.h include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 31 Mar 2011 12:40:42 +0000 (12:40 +0000)]
2011-03-31  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, fix error in chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 31 Mar 2011 12:37:43 +0000 (12:37 +0000)]
2011-03-31  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for tests added in r82303, r82419,
        r82400 and r82411.

        * platform/gtk/fast/block/float/float-forced-below-other-floats-expected.checksum: Added.
        * platform/gtk/fast/block/float/float-forced-below-other-floats-expected.png: Added.
        * platform/gtk/fast/block/float/float-forced-below-other-floats-expected.txt: Added.
        * platform/gtk/fast/borders/border-radius-inline-flow-expected.checksum: Added.
        * platform/gtk/fast/borders/border-radius-inline-flow-expected.png: Added.
        * platform/gtk/fast/borders/rtl-border-01-expected.checksum: Added.
        * platform/gtk/fast/borders/rtl-border-01-expected.png: Added.
        * platform/gtk/fast/borders/rtl-border-01-expected.txt: Added.
        * platform/gtk/fast/borders/rtl-border-02-expected.checksum: Added.
        * platform/gtk/fast/borders/rtl-border-02-expected.png: Added.
        * platform/gtk/fast/borders/rtl-border-02-expected.txt: Added.
        * platform/gtk/fast/borders/rtl-border-03-expected.checksum: Added.
        * platform/gtk/fast/borders/rtl-border-03-expected.png: Added.
        * platform/gtk/fast/borders/rtl-border-03-expected.txt: Added.
        * platform/gtk/fast/borders/rtl-border-04-expected.checksum: Added.
        * platform/gtk/fast/borders/rtl-border-04-expected.png: Added.
        * platform/gtk/fast/borders/rtl-border-04-expected.txt: Added.
        * platform/gtk/fast/borders/rtl-border-05-expected.checksum: Added.
        * platform/gtk/fast/borders/rtl-border-05-expected.png: Added.
        * platform/gtk/fast/borders/rtl-border-05-expected.txt: Added.
        * platform/gtk/fast/css/h1-in-section-elements-expected.checksum: Added.
        * platform/gtk/fast/css/h1-in-section-elements-expected.png: Added.
        * platform/gtk/fast/css/h1-in-section-elements-expected.txt: Added.
        * platform/gtk/svg/text/bidi-embedded-direction-expected.checksum: Added.
        * platform/gtk/svg/text/bidi-embedded-direction-expected.png: Added.
        * platform/gtk/svg/text/bidi-embedded-direction-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 31 Mar 2011 12:36:17 +0000 (12:36 +0000)]
2011-03-31  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: follow up to XMLViewer change with expectations update.

        * fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt:
        * svg/hixie/error/dumpAsText/005-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS related SVG*Element changes doesn't require relayout
reni@webkit.org [Thu, 31 Mar 2011 12:33:49 +0000 (12:33 +0000)]
CSS related SVG*Element changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=56906

Reviewed by Dirk Schulze.

Source/WebCore:

The changes of some CSS related SVGFilter properties e.g. lighting-color, flood-color, flood-opacity
need only repaint. To avoid the default invalidation of filters in SVGResourceCache::clientStyleChange()
we need an early return. So RenderSVGResourceFilterPrimitive::styleDidChange() can handle these properties
via RenderSVGResourceFilter::primitiveAttributeChanged() the same way like we do it for the other SVGAttributes.

Tests: svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html
       svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html
       svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html
       svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html

* platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::setFloodColor):
(WebCore::FEFlood::setFloodOpacity):
* platform/graphics/filters/FEFlood.h:
* platform/graphics/filters/FESpecularLighting.cpp:
(WebCore::FESpecularLighting::setLightingColor):
* platform/graphics/filters/FESpecularLighting.h:
* rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):
* rendering/svg/RenderSVGResourceFilterPrimitive.h:
* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientStyleChanged):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
* svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::setFilterEffectAttribute):
* svg/SVGFEFloodElement.h:
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):

LayoutTests:

Testing inherited CSS related SVG property changes by FEFlood, FESpecularLighting and FEDiffuseLighing filters.
Adding a missing test to check the dynamic update of lighting-color property of FESpecularLighting.
All the other modifications are covered by the existing dyanmic-update tests.

* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
* svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html: Added.
* svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.txt: Added.
* svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html: Added.
* svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html: Added.
* svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html: Added.
* svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEFloodElement-inherit-flood-color-css-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-lighting-color-css-prop.js: Added.
(executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82565 268f45cc-cd09-0410-ab3c-d52691b4dbfc