WebKit-https.git
7 years agoUnreviewed, rolling out r98483.
jchaffraix@webkit.org [Wed, 26 Oct 2011 18:58:59 +0000 (18:58 +0000)]
Unreviewed, rolling out r98483.
http://trac.webkit.org/changeset/98483
https://bugs.webkit.org/show_bug.cgi?id=47156

Change is causing some crashes and ASSERTs.

Source/WebCore:

* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::lookupImageForSize):
(WebCore::CachedImage::lookupImageForRenderer):
(WebCore::CachedImage::lookupOrCreateImageForRenderer):
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):
(WebCore::CachedImage::computeIntrinsicDimensions):
(WebCore::CachedImage::createImage):
* loader/cache/CachedImage.h:
* page/ChromeClient.h:
* rendering/ImageBySizeCache.cpp:
(WebCore::ImageBySizeCache::addClient):
(WebCore::ImageBySizeCache::removeClient):
(WebCore::ImageBySizeCache::imageForSize):
(WebCore::ImageBySizeCache::sizeForClient):
* rendering/ImageBySizeCache.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
* rendering/RenderBoxModelObject.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):
(WebCore::RenderImage::computeReplacedLogicalWidth):
(WebCore::RenderImage::computeReplacedLogicalHeight):
(WebCore::RenderImage::calcAspectRatioLogicalWidth):
(WebCore::RenderImage::calcAspectRatioLogicalHeight):
* rendering/RenderImage.h:
* rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::setContainerSizeForRenderer):
* rendering/RenderImageResourceStyleImage.cpp:
* rendering/RenderImageResourceStyleImage.h:
(WebCore::RenderImageResourceStyleImage::image):
(WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::computePreferredLogicalWidths):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeIntrinsicLogicalWidth):
(WebCore::RenderReplaced::computeIntrinsicLogicalHeight):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
* rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::computeIntrinsicDimensions):
(WebCore::StyleCachedImage::setContainerSizeForRenderer):
(WebCore::StyleCachedImage::addClient):
(WebCore::StyleCachedImage::removeClient):
* rendering/style/StyleCachedImage.h:
* rendering/style/StyleGeneratedImage.h:
(WebCore::StyleGeneratedImage::setContainerSizeForRenderer):
* rendering/style/StyleImage.h:
* rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::setContainerSizeForRenderer):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::layout):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeIntrinsicWidth):
(WebCore::RenderSVGRoot::computeIntrinsicHeight):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::paint):
(WebCore::RenderSVGRoot::calcViewport):
(WebCore::RenderSVGRoot::computeRectForRepaint):
* rendering/svg/RenderSVGRoot.h:
* svg/SVGLength.cpp:
(WebCore::SVGLength::determineViewport):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::relativeWidthValue):
(WebCore::SVGSVGElement::relativeHeightValue):
(WebCore::SVGSVGElement::currentViewBoxRect):
* svg/SVGSVGElement.h:
(WebCore::SVGSVGElement::setContainerSize):
(WebCore::SVGSVGElement::containerSize):
(WebCore::SVGSVGElement::hasSetContainerSize):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::usesContainerSize):
(WebCore::SVGImage::size):
(WebCore::SVGImage::hasRelativeWidth):
(WebCore::SVGImage::hasRelativeHeight):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::computeIntrinsicDimensions):
(WebCore::SVGImage::dataChanged):
* svg/graphics/SVGImage.h:

LayoutTests:

* css2.1/20110323/background-intrinsic-001.htm: Removed.
* css2.1/20110323/background-intrinsic-002.htm: Removed.
* css2.1/20110323/background-intrinsic-003.htm: Removed.
* css2.1/20110323/background-intrinsic-004.htm: Removed.
* css2.1/20110323/background-intrinsic-005.htm: Removed.
* css2.1/20110323/background-intrinsic-006.htm: Removed.
* css2.1/20110323/background-intrinsic-007.htm: Removed.
* css2.1/20110323/background-intrinsic-008.htm: Removed.
* css2.1/20110323/background-intrinsic-009.htm: Removed.
* css2.1/20110323/resources/green-intrinsic-height-ratio.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-height.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-none.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-ratio-landscape.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-ratio-portrait.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-width-height.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-width-pc-height-pc.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-width-ratio.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-width.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-height-ratio.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-height.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-none.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-ratio-landscape.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-ratio-portrait.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-width-height.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-width-pc-height-pc.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-width-ratio.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-width.svg: Removed.
* fast/backgrounds/size/contain-and-cover-zoomed.html: Removed.
* fast/images/percent-height-image-expected.txt:
* fast/images/percent-height-image.html:
* platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/mac/css1/text_properties/vertical_align-expected.txt:
* platform/mac/css2.1/20110323/background-intrinsic-001-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-002-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-003-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-003-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-004-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-005-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-006-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-006-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-007-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-008-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-009-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
* platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
* platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
* platform/mac/fast/block/float/015-expected.png:
* platform/mac/fast/block/float/015-expected.txt:
* platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
* platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt:
* platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt:
* platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Removed.
* platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Removed.
* platform/mac/svg/as-background-image/background-image-tiled-expected.png: Removed.
* platform/mac/svg/as-background-image/background-image-tiled-expected.txt: Removed.
* platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.png: Removed.
* platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Removed.
* platform/mac/svg/as-background-image/svg-as-background-4-expected.png:
* platform/mac/svg/as-border-image/svg-as-border-image-expected.png:
* platform/mac/svg/as-image/animated-svg-as-image-expected.png:
* platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Removed.
* platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Removed.
* platform/mac/svg/as-image/same-image-two-instances-expected.png: Removed.
* platform/mac/svg/as-image/same-image-two-instances-expected.txt: Removed.
* platform/mac/svg/as-image/svg-as-relative-image-expected.png:
* platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Removed.
* platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Removed.
* platform/mac/svg/as-image/svg-image-change-content-size-expected.png: Removed.
* platform/mac/svg/as-image/svg-image-change-content-size-expected.txt: Removed.
* platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
* platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
* platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Removed.
* platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
* platform/mac/svg/zoom/page/zoom-background-images-expected.png: Removed.
* platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
* platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
* platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
* platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Removed.
* platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
* platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Removed.
* platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
* svg/as-background-image/background-image-preserveaspectRatio-support.html: Removed.
* svg/as-background-image/background-image-tiled.html: Removed.
* svg/as-background-image/resources/construction-tape.svg: Removed.
* svg/as-background-image/resources/hearts.svg:
* svg/as-background-image/same-image-two-instances-background-image.html: Removed.
* svg/as-image/img-preserveAspectRatio-support-1.html: Removed.
* svg/as-image/resources/circle-default-meet.svg: Removed.
* svg/as-image/resources/circle-default-none.svg: Removed.
* svg/as-image/resources/circle-default-slice.svg: Removed.
* svg/as-image/resources/circle-nosize.svg: Removed.
* svg/as-image/resources/circle-viewbox-default.svg: Removed.
* svg/as-image/resources/circle-viewbox-meet.svg: Removed.
* svg/as-image/resources/circle-viewbox-none.svg: Removed.
* svg/as-image/resources/circle-viewbox-slice.svg: Removed.
* svg/as-image/resources/green-relative-size-rect.svg:
* svg/as-image/same-image-two-instances.html: Removed.
* svg/as-image/svg-as-relative-image-with-explicit-size.html: Removed.
* svg/as-image/svg-image-change-content-size.xhtml: Removed.
* svg/zoom/page/resources/relative-sized-background-with-viewBox.svg: Removed.
* svg/zoom/page/zoom-background-image-tiled.html: Removed.
* svg/zoom/page/zoom-background-images.html: Removed.
* svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: Removed.
* svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html: Removed.
* svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConstructors for all TextTrack interfaces should be available on DOMWindow
eric.carlson@apple.com [Wed, 26 Oct 2011 18:51:17 +0000 (18:51 +0000)]
Constructors for all TextTrack interfaces should be available on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=70734

Source/WebCore:

Reviewed by Sam Weinig.

window-properties-expected.txt and global-constructors-expected.txt updated for this change.

* page/DOMWindow.idl: Add HTMLTrackElement, TextTrack, and TextTrackCueList.

LayoutTests:

Reviewed by Sam Weinig.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r93108): Shadow DOM media controls created for plug-in backed media elements.
aestes@apple.com [Wed, 26 Oct 2011 18:41:27 +0000 (18:41 +0000)]
REGRESSION (r93108): Shadow DOM media controls created for plug-in backed media elements.
https://bugs.webkit.org/show_bug.cgi?id=70872

Reviewed by Eric Carlson.

r93108 added a call to HTMLMediaElement::configureMediaControls() in
HTMLMediaElement::prepareForLoad(), which creates shadow DOM media
controls and is only appropriate to call when media elements are not
backed by plug-in proxies.

Resolve this by refactoring configureMediaControls() to do the right
thing for the plug-in proxy case by calling MediaPlayer::setControls().

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged): Call
configureMediaControls() directly and remove the preprocessor
conditional.
(WebCore::HTMLMediaElement::configureMediaControls): Call
MediaPlayer::setControls() if PLUGIN_PROXY_FOR_VIDEO is enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoselectedIndex gets set from -1 to 0 when modifying options
jonlee@apple.com [Wed, 26 Oct 2011 18:36:22 +0000 (18:36 +0000)]
selectedIndex gets set from -1 to 0 when modifying options
https://bugs.webkit.org/show_bug.cgi?id=70547
<rdar://problem/8388856>

Reviewed by Darin Adler.

Source/WebCore:

Changing the text causes a recalculation of the list items, which in the menu list case
forces the first element to be selected. We check the value of the selected option prior,
and restore it if it differs.

Test: fast/dom/HTMLSelectElement/selected-index-preserved-when-option-text-changes.html

* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setText):
* html/HTMLSelectElement.h: promote usesMenuList() from private to public for use by HTMLOptionElement

LayoutTests:

The added tests set the selected index to either -1 or 1 (a legitimate value), and then change
the text, value, and label of the option. In all cases, the selected index should remain unchanged.

* fast/dom/HTMLSelectElement/selected-index-preserved-when-option-text-changes-expected.txt: Added.
* fast/dom/HTMLSelectElement/selected-index-preserved-when-option-text-changes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd new CSS escape sequence parsing tests
zherczeg@webkit.org [Wed, 26 Oct 2011 18:29:55 +0000 (18:29 +0000)]
Add new CSS escape sequence parsing tests
https://bugs.webkit.org/show_bug.cgi?id=70909

Reviewed by Darin Adler.

Test escape various sequences terminated by \n \f \r and \r\n.

* fast/css/parsing-css-escapes-expected.txt: Added.
* fast/css/parsing-css-escapes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Embedded PDFs should be known to DocumentLoader
ap@apple.com [Wed, 26 Oct 2011 18:11:51 +0000 (18:11 +0000)]
    Embedded PDFs should be known to DocumentLoader
        https://bugs.webkit.org/show_bug.cgi?id=70864

        Reviewed by Darin Adler.

        * WebProcess/Plugins/Plugin.h: Plugin stream load notifications now contain a suggested
        file name, in case the plug-in wants to save the file properly.

        * WebProcess/Plugins/PDF/BuiltInPDFView.h:
        * WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
        (WebKit::BuiltInPDFView::addArchiveResource): Add the PDF as resource in DocumentLoader.
        (WebKit::BuiltInPDFView::pdfDocumentDidLoad): Call addArchiveResource.
        (WebKit::BuiltInPDFView::initialize): We need to remember source URL to create a resource
        for that. The URL needs to match one in HitTestResult, so we can't use response URL.
        (WebKit::BuiltInPDFView::streamDidReceiveResponse): Remember suggested file name, so
        that we could put it in archive resource later.
        (WebKit::BuiltInPDFView::manualStreamDidReceiveResponse): Ditto.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::streamDidReceiveResponse):
        (WebKit::PluginControllerProxy::manualStreamDidReceiveResponse):
        Pass an empty string for suggested file name. No plug-in that runs in a separate process
        cares about it, so it's not sent to the plugin process.

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::streamDidReceiveResponse):
        (WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
        * WebProcess/Plugins/Netscape/NetscapePlugin.h:
        Updated for new signatures.

        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::streamDidReceiveResponse):
        (WebKit::PluginProxy::manualStreamDidReceiveResponse):
        * WebProcess/Plugins/PluginProxy.h:
        Updated for new signatures.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::Stream::didReceiveResponse):
        (WebKit::PluginView::manualLoadDidReceiveResponse):
        Pass suggested file name to plug-in, in case the plug-in wants to save the file properly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium Mac editing test rebaseline.
rniwa@webkit.org [Wed, 26 Oct 2011 17:56:41 +0000 (17:56 +0000)]
Chromium Mac editing test rebaseline.

* platform/chromium-cg-mac-leopard/platform/mac/editing: Added.
* platform/chromium-cg-mac-leopard/platform/mac/editing/pasteboard: Added.
* platform/chromium-cg-mac-leopard/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/security: Added.
* platform/chromium-mac-leopard/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
* platform/chromium-mac-leopard/platform/mac: Added.
* platform/chromium-mac-leopard/platform/mac/editing: Added.
* platform/chromium-mac-leopard/platform/mac/editing/pasteboard: Added.
* platform/chromium-mac-leopard/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
* platform/chromium-mac-snowleopard/http: Added.
* platform/chromium-mac-snowleopard/http/tests: Added.
* platform/chromium-mac-snowleopard/http/tests/security: Added.
* platform/chromium-mac-snowleopard/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
* platform/chromium-mac-snowleopard/platform: Added.
* platform/chromium-mac-snowleopard/platform/mac: Added.
* platform/chromium-mac-snowleopard/platform/mac/editing: Added.
* platform/chromium-mac-snowleopard/platform/mac/editing/pasteboard: Added.
* platform/chromium-mac-snowleopard/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove getOwnPropertySlotVirtual
mhahnenberg@apple.com [Wed, 26 Oct 2011 17:55:34 +0000 (17:55 +0000)]
Remove getOwnPropertySlotVirtual
https://bugs.webkit.org/show_bug.cgi?id=70741

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertyDescriptor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertySlot):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
* runtime/Arguments.h:
* runtime/ArrayConstructor.cpp:
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
* runtime/ArrayPrototype.h:
* runtime/BooleanPrototype.cpp:
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
* runtime/DateConstructor.h:
* runtime/DatePrototype.cpp:
* runtime/DatePrototype.h:
(JSC::DatePrototype::create):
* runtime/ErrorPrototype.cpp:
* runtime/ErrorPrototype.h:
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertySlotByIndex):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::hasOwnProperty):
* runtime/JSObject.h:
(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSValue::get):
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/JSString.cpp:
(JSC::JSString::getOwnPropertySlot):
* runtime/JSString.h:
* runtime/MathObject.cpp:
* runtime/MathObject.h:
(JSC::MathObject::create):
* runtime/NumberConstructor.cpp:
* runtime/NumberConstructor.h:
* runtime/NumberPrototype.cpp:
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.cpp:
* runtime/ObjectPrototype.h:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::createStructure):
* runtime/RegExpObject.cpp:
* runtime/RegExpObject.h:
* runtime/RegExpPrototype.cpp:
* runtime/RegExpPrototype.h:
* runtime/StringConstructor.cpp:
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
* runtime/StringObject.h:
* runtime/StringPrototype.cpp:
* runtime/StringPrototype.h:

Source/JavaScriptGlue:

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

* UserObjectImp.cpp:
* UserObjectImp.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

* WebCore.exp.in:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::DialogHandler::returnValue):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::getOwnPropertySlot):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::getSparseIndex):
(WebCore::CloneSerializer::getProperty):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
* bridge/qt/qt_runtime.cpp:
* bridge/qt/qt_runtime.h:
* bridge/runtime_array.cpp:
* bridge/runtime_array.h:
* bridge/runtime_method.cpp:
* bridge/runtime_method.h:
* bridge/runtime_object.cpp:
* bridge/runtime_object.h:

Source/WebKit2:

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
* WebProcess/Plugins/Netscape/JSNPObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-26 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 26 Oct 2011 17:54:00 +0000 (17:54 +0000)]
2011-10-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] Update NEWS and configure.ac for 1.7.1 release
        https://bugs.webkit.org/show_bug.cgi?id=70932

        Reviewed by Martin Robinson.

        * configure.ac: Bumped version number.

2011-10-26  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Update NEWS and configure.ac for 1.7.1 release
        https://bugs.webkit.org/show_bug.cgi?id=70932

        Reviewed by Martin Robinson.

        * NEWS: Added release notes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix typo. The expected results don't change.
ojan@chromium.org [Wed, 26 Oct 2011 17:53:52 +0000 (17:53 +0000)]
Fix typo. The expected results don't change.

* fast/writing-mode/borders.html:
* fast/writing-mode/margins.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-26 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 26 Oct 2011 17:45:31 +0000 (17:45 +0000)]
2011-10-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] [WK2] Add WebKit2 distcheck support
        https://bugs.webkit.org/show_bug.cgi?id=70933

        Reviewed by Martin Robinson.

        * GNUmakefile.am: Added WebKit2 compilation to the distcheck.
        * configure.ac: Removed WebKit2 doc generation for the moment.

2011-10-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] [WK2] Add WebKit2 distcheck support
        https://bugs.webkit.org/show_bug.cgi?id=70933

        Reviewed by Martin Robinson.

        * GNUmakefile.list.am: Add MemoryStatistics.h to the sources list.

2011-10-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] [WK2] Add WebKit2 distcheck support
        https://bugs.webkit.org/show_bug.cgi?id=70933

        Reviewed by Martin Robinson.

        * GNUmakefile.am: Add a bunch of missing files from API and
        sources, also include more files in the EXTRA_DIST.
        * UIProcess/API/gtk/docs/GNUmakefile.am: Add the version.xml to
        the cleaning section.

2011-10-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] [WK2] Add WebKit2 distcheck support
        https://bugs.webkit.org/show_bug.cgi?id=70933

        Reviewed by Martin Robinson.

        * WebKitTestRunner/GNUmakefile.am: Add missing files to the
        sources and EXTRA_DIST.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-26 Carlos Garcia Campos <cgarcia@igalia.com>
alex@webkit.org [Wed, 26 Oct 2011 17:40:08 +0000 (17:40 +0000)]
2011-10-26  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Fix gtk-doc warnings and style issues in WebKit2 GTK+ API
        https://bugs.webkit.org/show_bug.cgi?id=70930

        Reviewed by Martin Robinson.

        * UIProcess/API/gtk/WebKitBackForwardListItem.cpp:
        * UIProcess/API/gtk/WebKitSettings.cpp:
        (webkit_settings_class_init):
        * UIProcess/API/gtk/WebKitWebView.h:
        * UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-26 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 26 Oct 2011 17:35:41 +0000 (17:35 +0000)]
2011-10-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] Fix distcheck compilation
        https://bugs.webkit.org/show_bug.cgi?id=70921

        Add EventTargetFactory.in to the dist files, required after
        r98388.

        Reviewed by Martin Robinson.

        * GNUmakefile.am:

2011-10-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] Fix distcheck compilation
        https://bugs.webkit.org/show_bug.cgi?id=70921

        Add new files required by doc compilation to the clean process.

        Reviewed by Martin Robinson.

        * docs/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIncrease StringImpl Flag Bits for 8 bit Strings
msaboff@apple.com [Wed, 26 Oct 2011 17:12:13 +0000 (17:12 +0000)]
Increase StringImpl Flag Bits for 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=70937

Increased the number of bits used for flags in StringImpl
from 6 to 8 bits. This frees up 2 flag bits that will be
used for 8-bit string support. Updated hash methods accordingly.
Changed hash value masking from the low bits to the high
bits.

Reviewed by Darin Adler.

Source/JavaScriptCore:

* create_hash_table:
* wtf/StringHasher.h:
(WTF::StringHasher::hash):
* wtf/text/StringImpl.h:

Source/WebCore:

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHashValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse the right contents scale factor for non-Mac plug-ins
andersca@apple.com [Wed, 26 Oct 2011 17:06:03 +0000 (17:06 +0000)]
Use the right contents scale factor for non-Mac plug-ins
https://bugs.webkit.org/show_bug.cgi?id=70939

Reviewed by Adam Roben.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r94887): Scrolling the HTML spec is more jerky now than it was (regression)
dglazkov@chromium.org [Wed, 26 Oct 2011 16:58:44 +0000 (16:58 +0000)]
REGRESSION (r94887): Scrolling the HTML spec is more jerky now than it was (regression)
https://bugs.webkit.org/show_bug.cgi?id=70857

Source/WebCore:

Revert r94887, because it regressed performance.

Rubber-stamped by Antti Koivisto.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::parentStylePreventsSharing):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
* dom/Element.cpp:
(WebCore::Element::recalcStyle):
(WebCore::checkForSiblingStyleChanges):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::childrenAffectedByDirectAdjacentRules):
(WebCore::InheritedFlags::setChildrenAffectedByDirectAdjacentRules):

LayoutTests:

Rubber-stamped by Antti Koivisto.

* fast/css/adjacent-sibling-selector-expected.txt: Removed.
* fast/css/adjacent-sibling-selector.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix.
mitz@apple.com [Wed, 26 Oct 2011 16:30:50 +0000 (16:30 +0000)]
Build fix.

Reverted r98488, which caused the scripts’ status messages to be included in the generated
files.

* create_hash_table:
* create_jit_stubs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoinspector/cookie-parser.html is a flaky crash
kbalazs@webkit.org [Wed, 26 Oct 2011 16:27:50 +0000 (16:27 +0000)]
inspector/cookie-parser.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=62662

Unreviewed Qt-Debug gardening.

Add CRASH+PASS expectation instead of the skipping madness
because the first inspector test is always a flaky crash,
no matter which one is that.

* platform/qt/Skipped:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Need workaround for the red crossed circle in the status bar not bring...
apavlov@chromium.org [Wed, 26 Oct 2011 16:20:57 +0000 (16:20 +0000)]
Web Inspector: Need workaround for the red crossed circle in the status bar not bringing up the console when clicked
https://bugs.webkit.org/show_bug.cgi?id=70928

Reviewed by Pavel Feldman.

* inspector/front-end/inspector.css:
(#error-count-img):
(#error-count + #warning-count-img):
(#warning-count-img):
* inspector/front-end/inspector.js:
(WebInspector._updateErrorAndWarningCounts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't print regular output to STDERR when generating hashtables and JIT stubs
vestbo@webkit.org [Wed, 26 Oct 2011 16:05:00 +0000 (16:05 +0000)]
Don't print regular output to STDERR when generating hashtables and JIT stubs

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unreviewed gardening.
kbalazs@webkit.org [Wed, 26 Oct 2011 16:02:34 +0000 (16:02 +0000)]
[Qt][WK2] Unreviewed gardening.

[Qt][WK2] fast/transforms/scrollIntoView-transformed.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=70935

[Qt][WK2] Metric mismatches (fast/text/justify-padding-distribution.html and svg/as-object/svg-embedded-in-html-in-iframe.html)
https://bugs.webkit.org/show_bug.cgi?id=70915
The test became flaky after added platform result.

Skip flaky tests.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[skia] replace offscreen technique with native support for antialiased clipping
reed@google.com [Wed, 26 Oct 2011 15:48:38 +0000 (15:48 +0000)]
[skia] replace offscreen technique with native support for antialiased clipping
https://bugs.webkit.org/show_bug.cgi?id=70748

Reviewed by Stephen White.

~100 layout tests need to be rebaselined, as the native aa-clipping differs sometimes in the low
bits of the result. Other than that, the results should be the same, except that now the drawing
can go directly to the canvas, rather than being direct offscreen and then have that result
"clipped" during the restore. This has the effect of allowing LCD text to be drawing inside a
antialiased clip area.

Source/WebCore:

* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::State::cloneInheritedProperties):
(WebCore::PlatformContextSkia::clipPathAntiAliased):
(WebCore::PlatformContextSkia::restore):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add missing symbols to WebKit2 gtk-doc files
carlosgc@webkit.org [Wed, 26 Oct 2011 15:43:52 +0000 (15:43 +0000)]
[GTK] Add missing symbols to WebKit2 gtk-doc files
https://bugs.webkit.org/show_bug.cgi?id=70927

Reviewed by Martin Robinson.

* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add sections for
WebKitBackForwardList, WebKitBackForwardListItem and WebKitSettings.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add missing symbols.
* UIProcess/API/gtk/docs/webkit2gtk.types: Add missing types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Inconsistent name of WebKitSettings macros
carlosgc@webkit.org [Wed, 26 Oct 2011 15:40:56 +0000 (15:40 +0000)]
[GTK] Inconsistent name of WebKitSettings macros
https://bugs.webkit.org/show_bug.cgi?id=70924

Reviewed by Martin Robinson.

Rename WEBKIT_TYPE_WEB_SETTINGS as WEBKIT_TYPE_SETTINGS and
WEBKIT_IS_WEB_SETTINGS as WEBKIT_IS_SETTINGS.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_init):
(webkit_settings_new):
(webkit_settings_get_enable_javascript):
(webkit_settings_set_enable_javascript):
(webkit_settings_get_auto_load_images):
(webkit_settings_set_auto_load_images):
(webkit_settings_get_load_icons_ignoring_image_load_setting):
(webkit_settings_set_load_icons_ignoring_image_load_setting):
(webkit_settings_get_enable_offline_web_application_cache):
(webkit_settings_set_enable_offline_web_application_cache):
(webkit_settings_get_enable_html5_local_storage):
(webkit_settings_set_enable_html5_local_storage):
(webkit_settings_get_enable_html5_database):
(webkit_settings_set_enable_html5_database):
(webkit_settings_get_enable_xss_auditor):
(webkit_settings_set_enable_xss_auditor):
(webkit_settings_get_enable_frame_flattening):
(webkit_settings_set_enable_frame_flattening):
(webkit_settings_get_enable_plugins):
(webkit_settings_set_enable_plugins):
(webkit_settings_get_enable_java):
(webkit_settings_set_enable_java):
(webkit_settings_get_javascript_can_open_windows_automatically):
(webkit_settings_set_javascript_can_open_windows_automatically):
(webkit_settings_get_enable_hyperlink_auditing):
(webkit_settings_set_enable_hyperlink_auditing):
* UIProcess/API/gtk/WebKitSettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-26 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 26 Oct 2011 15:27:44 +0000 (15:27 +0000)]
2011-10-26  Nikolas Zimmermann  <nzimmermann@rim.com>

        CSS 2.1 failure: background-intrinsic-*
        https://bugs.webkit.org/show_bug.cgi?id=47156

        Reviewed by Antti Koivisto.

        Add all *intrinsic* tests from the CSS 2.1 Testsuite - we pass all of them now.
        All tests regarding SVG are now imported in LayoutTests, none are failing anymore.

        Add several new testcases covering the SVG Image size negotiation logic, as defined in CSS 2.1.

        * css2.1/20110323/background-intrinsic-001.htm: Added.
        * css2.1/20110323/background-intrinsic-002.htm: Added.
        * css2.1/20110323/background-intrinsic-003.htm: Added.
        * css2.1/20110323/background-intrinsic-004.htm: Added.
        * css2.1/20110323/background-intrinsic-005.htm: Added.
        * css2.1/20110323/background-intrinsic-006.htm: Added.
        * css2.1/20110323/background-intrinsic-007.htm: Added.
        * css2.1/20110323/background-intrinsic-008.htm: Added.
        * css2.1/20110323/background-intrinsic-009.htm: Added.
        * css2.1/20110323/resources/green-intrinsic-height-ratio.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-height.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-none.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-ratio-landscape.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-ratio-portrait.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-width-height.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-width-pc-height-pc.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-width-ratio.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-width.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-height-ratio.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-height.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-none.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-ratio-landscape.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-ratio-portrait.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-width-height.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-width-pc-height-pc.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-width-ratio.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-width.svg: Added.
        * fast/backgrounds/size/contain-and-cover-zoomed.html: Added.
        * fast/images/percent-height-image-expected.txt: Update results, testcase is fixed now.
        * fast/images/percent-height-image.html: Make test async, to make it work cross-browser. With this patch we now pass this testcase.
        * platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
        * platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
        * platform/mac/css1/text_properties/vertical_align-expected.txt: Update for rounding differences.
        * platform/mac/css2.1/20110323/background-intrinsic-001-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-002-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-003-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-004-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-005-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-006-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-007-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-008-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-009-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
        * platform/mac/fast/backgrounds/size/contain-and-cover-expected.png: Updated for rounding differences.
        * platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
        * platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
        * platform/mac/fast/block/float/015-expected.png: Slight changes, due 49x50 -> 50x50 size change.
        * platform/mac/fast/block/float/015-expected.txt: Ditto.
        * platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Slight changes due to rounding.
        * platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Ditto.
        * platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Ditto.
        * platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Ditto.
        * platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
        * platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
        * platform/mac/svg/as-background-image/background-image-tiled-expected.png: Added.
        * platform/mac/svg/as-background-image/background-image-tiled-expected.txt: Added.
        * platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
        * platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
        * platform/mac/svg/as-background-image/svg-as-background-4-expected.png: Adapt to preserveAspectRatio changes in hearts.svg.
        * platform/mac/svg/as-border-image/svg-as-border-image-expected.png: This needed a rebaseline, it was forgotten before.
        * platform/mac/svg/as-image/animated-svg-as-image-expected.png: Progression, now both images share the same size & ratio, as desired.
        * platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
        * platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
        * platform/mac/svg/as-image/same-image-two-instances-expected.png: Added.
        * platform/mac/svg/as-image/same-image-two-instances-expected.txt: Added.
        * platform/mac/svg/as-image/svg-as-relative-image-expected.png: Adapt to green-relative-size-rect.svg - a circle got added to make it easier to compare.
        * platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
        * platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
        * platform/mac/svg/as-image/svg-image-change-content-size-expected.png: Added.
        * platform/mac/svg/as-image/svg-image-change-content-size-expected.txt: Added.
        * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
        * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Ditto.
        * platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-background-images-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
        * platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Ditto.
        * platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
        * svg/as-background-image/background-image-preserveaspectRatio-support.html: Added.
        * svg/as-background-image/background-image-tiled.html: Added.
        * svg/as-background-image/resources/construction-tape.svg: Added.
        * svg/as-background-image/resources/hearts.svg: Fix testcase, by adding pAR="none", which is now respected. Now the image looks as desired across Opera/FF and us.
        * svg/as-background-image/same-image-two-instances-background-image.html: Added.
        * svg/as-image/img-preserveAspectRatio-support-1.html: Added.
        * svg/as-image/resources/circle-default-meet.svg: Added.
        * svg/as-image/resources/circle-default-none.svg: Added.
        * svg/as-image/resources/circle-default-slice.svg: Added.
        * svg/as-image/resources/circle-nosize.svg: Added.
        * svg/as-image/resources/circle-viewbox-default.svg: Added.
        * svg/as-image/resources/circle-viewbox-meet.svg: Added.
        * svg/as-image/resources/circle-viewbox-none.svg: Added.
        * svg/as-image/resources/circle-viewbox-slice.svg: Added.
        * svg/as-image/resources/green-relative-size-rect.svg: Use relative units everywhere as intended. Add circle to make it easy to spot ratio changes.
        * svg/as-image/same-image-two-instances.html: Added.
        * svg/as-image/svg-as-relative-image-with-explicit-size.html: Added.
        * svg/as-image/svg-image-change-content-size.xhtml: Added.
        * svg/zoom/page/resources/relative-sized-background-with-viewBox.svg: Added.
        * svg/zoom/page/zoom-background-image-tiled.html: Added.
        * svg/zoom/page/zoom-background-images.html: Added.
        * svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: Added.
        * svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html: Added.
        * svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Added.

2011-10-26  Nikolas Zimmermann  <nzimmermann@rim.com>

        CSS 2.1 failure: background-intrinsic-*
        https://bugs.webkit.org/show_bug.cgi?id=47156

        SVGs do not work as tiled background images
        https://bugs.webkit.org/show_bug.cgi?id=16281

        Apply preserveAspectRatio and synthesize viewboxes in <img>
        https://bugs.webkit.org/show_bug.cgi?id=34521

        SVG background doesn't resize properly when dimensions are changed
        https://bugs.webkit.org/show_bug.cgi?id=42944

        Images with percent height inside a floated div should use intrinsic height.
        https://bugs.webkit.org/show_bug.cgi?id=45439

        SVG image in HTML changes size as the window is resized
        https://bugs.webkit.org/show_bug.cgi?id=52045

        Reviewed by Antti Koivisto.

        Implement intrinsic sizing support for SVGImage (svg embedded through <html:img>/<svg:image>/background-image/border-image/...).
        This is demanded by CSS 2.1, and covered by new layout tests in LayoutTests/css2.1 and several new custom testcases.

        Tests: css2.1/20110323/background-intrinsic-001.htm
               css2.1/20110323/background-intrinsic-002.htm
               css2.1/20110323/background-intrinsic-003.htm
               css2.1/20110323/background-intrinsic-004.htm
               css2.1/20110323/background-intrinsic-005.htm
               css2.1/20110323/background-intrinsic-006.htm
               css2.1/20110323/background-intrinsic-007.htm
               css2.1/20110323/background-intrinsic-008.htm
               css2.1/20110323/background-intrinsic-009.htm
               svg/as-background-image/background-image-preserveaspectRatio-support.html (adapted from testcase from bug 34521)
               svg/as-background-image/background-image-tiled.html (reduction from bug 16281)
               svg/as-background-image/same-image-two-instances-background-image.html
               svg/as-image/img-preserveAspectRatio-support-1.html (reduction from bug 34521)
               svg/as-image/same-image-two-instances.html
               svg/as-image/svg-as-relative-image-with-explicit-size.html
               svg/as-image/svg-image-change-content-size.xhtml (reduction from bug 42944)
               svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html

        * loader/cache/CachedImage.cpp: Enable SVGImage <-> IntSize cache.
        (WebCore::CachedImage::lookupImageForSize): Use recently introduced ImageBySizeCache, to lookup an image for a certain size.
        (WebCore::CachedImage::lookupImageForRenderer): Lookup image by renderer, which first looks up a size for a renderer, then uses lookupImageForSize().
        (WebCore::createSVGImage): Refactored from createImage(), contains the SVGImage creation part only.
        (WebCore::CachedImage::lookupOrCreateImageForRenderer): Use recently introduced ImageBySizeCache, to dynamically create copies of m_image if needed.
        (WebCore::CachedImage::setContainerSizeForRenderer): For SVGImages, pass on container size handling to ImageBySizeCache.
        (WebCore::CachedImage::imageSizeForRenderer): Figure out the image size, respecting per-renderer overrides, for a certain renderer.
        (WebCore::CachedImage::computeIntrinsicDimensions): Remove unnecessary RenderObject parameter.
        (WebCore::CachedImage::addClientForRenderer): Special variant of addClient(), overriding the existing in CachedResource.
        (WebCore::CachedImage::removeClientForRenderer): Special variant of removeClient(), that also clears the image in the ImageBySizeCache.
        (WebCore::CachedImage::createImage): Refactor SVGImage creation into createSVGImage() free function, to be useable from lookupOrCreateImageForRenderer().
        * loader/cache/CachedImage.h: Expose removeClientForRenderer().
        * page/ChromeClient.h:
        (WebCore::ChromeClient::isSVGImageChromeClient): Used to identify whether a RenderSVGRoot is embedded through a SVGImage. Returns false, by default.
        * rendering/ImageBySizeCache.cpp:
        (WebCore::ImageBySizeCache::addClient): Assert the passed renderer is valid.
        (WebCore::ImageBySizeCache::removeClient): Ditto. Allow removeClient() to be called w/o prio addClient() usage.
        (WebCore::ImageBySizeCache::setClient): New helper function, that combines the usage of addClient/removeClient, for the use in CachedImage.
        (WebCore::ImageBySizeCache::imageForSize): Respect empty sizes, just return 0, instead of asserting.
        (WebCore::ImageBySizeCache::imageForRenderer): Added a helper that retrieves an image for a renderer, by lookup up its size and using imageForSize().
        * rendering/ImageBySizeCache.h: Expose setClient() & imageForRenderer().
        * rendering/RenderBoxModelObject.cpp: Implement CSS 2.1 intrinsic size negotiation for images.
        (WebCore::resolveWidthForRatio): New inline helper function used bz calculateImageIntrinsicDimensions.
        (WebCore::resolveHeightForRatio): Ditto.
        (WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio): Ditto.
        (WebCore::resolveAgainstIntrinsicRatio):  Ditto.
        (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): New helper function, containing the main algorithm, which is a pure transcription of the spec.
        (WebCore::RenderBoxModelObject::calculateFillTileSize): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size.
        (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Propagate calculateFillTileSize() result to the image resource, via setContainerSizeForRenderer().
        (WebCore::RenderBoxModelObject::paintNinePieceImage): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size.
        * rendering/RenderBoxModelObject.h: Clarify some variable names, added calculateImageIntrinsicDimensions().
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::RenderImage): Use IntSize(), instead of IntSize(0, 0).
        (WebCore::RenderImage::updateIntrinsicSizeIfNeeded): Refactored from imageDimensionsChanged().
        (WebCore::RenderImage::imageDimensionsChanged): Use updateIntrinsicSizeIfNeeded().
        (WebCore::RenderImage::computeReplacedLogicalWidth): Use RenderReplaced::computeReplacedLogicalWidth() exclusively. For this to work, the intrinsic size must be correct.
        (WebCore::RenderImage::computeIntrinsicRatioInformation): Default implementation for non-SVGImages.
        (WebCore::RenderImage::needsPreferredWidthsRecalculation): Return true, just like RenderPart, if embeddedContentBox is not null.
        (WebCore::RenderImage::embeddedContentBox): Returns the RenderSVGRoot* renderer of the embedded SVG, if possible.
        * rendering/RenderImage.h: Remove isLogicalWidth/HeightSpecified() / computeReplacedLogicalHeight() / calcAspectRatioLogicalWidth/Height().
        * rendering/RenderImageResource.cpp:
        (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass around new "float containerZoomFactor" parameter.
        * rendering/RenderImageResourceStyleImage.cpp:
        (WebCore::RenderImageResourceStyleImage::image): embeddedContentBox() is now calling image() earlier than before. We now have to handle the case that the image is pending.
        (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Pass zoom factor.
        * rendering/RenderImageResourceStyleImage.h:
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::computePreferredLogicalWidths): Pass effective zoom to setContainerSizeForRenderer().
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): Generalized this code, as RenderImage is using it as well now. Marginal changes needed.
        (WebCore::RenderReplaced::computeIntrinsicLogicalHeight): Ditto.
        (WebCore::RenderReplaced::computeReplacedLogicalWidth): Ditto.
        * rendering/style/StyleCachedImage.cpp:
        (WebCore::StyleCachedImage::computeIntrinsicDimensions): Stop passing m_renderer to CachedImage, it's no longer needed.
        (WebCore::StyleCachedImage::setContainerSizeForRenderer): Add "float containerZoomFactor" parameter.
        (WebCore::StyleCachedImage::addClient): Forward to new addClientForRenderer().
        (WebCore::StyleCachedImage::removeClient): Call new removeClientForRenderer() instead of removeClient(), so the ImageBySizeCache is also updated.
        * rendering/style/StyleCachedImage.h: Add "float containerZoomFactor" parameter to setContainerSizeForRenderer.
        * rendering/style/StyleGeneratedImage.h:
        (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Ditto.
        * rendering/style/StyleImage.h: Ditto.
        * rendering/style/StylePendingImage.h:
        (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto.
        * rendering/svg/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::layout): Always supply a container size when embedding SVGs in <svg:image>.
        * rendering/svg/RenderSVGRoot.cpp: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs.
        (WebCore::RenderSVGRoot::isEmbeddedThroughImageElement): Add helper method to determine whether we're loaded through SVGImage.
        (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): If we have a valid container size, it has precendence (only supplied via external SVGImages).
        (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
        (WebCore::RenderSVGRoot::layout): Remove calcViewport() usage, no need to track/override the viewport size anymore, all done in coputeReplacedLogical* now.
        (WebCore::RenderSVGRoot::paint): Use borderBoxRect() which now always matches the previously computed m_viewportSize.
        (WebCore::RenderSVGRoot::computeRectForRepaint): Ditto.
        * rendering/svg/RenderSVGRoot.h: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs.
        (WebCore::RenderSVGRoot::containerSize):
        (WebCore::RenderSVGRoot::setContainerSize):
        * svg/SVGLength.cpp:
        (WebCore::SVGLength::determineViewport): Resolve lengths against override container size in documents embedded through SVGImage.
        * svg/SVGSVGElement.cpp: Remove "override container size" handling from SVGSVGElement.
        (WebCore::SVGSVGElement::SVGSVGElement): Ditto.
        (WebCore::SVGSVGElement::currentViewBoxRect): Always synthesize a viewBox, if we're embedded through SVGImage, as demanded by SVG 1.1 2nd Edition.
        * svg/SVGSVGElement.h:
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImageChromeClient::setObserver): Helper function.
        (WebCore::SVGImageChromeClient::isSVGImageChromeClient): Return true, used to identify whether RenderSVGRoot is embedded through SVGImage.
        (WebCore::SVGImage::setContainerZoom): Forwarded to Page::setPageZoomFactor.
        (WebCore::SVGImage::setContainerSize): Assert that container size is not empty. We should never receive an empty container size.
        (WebCore::SVGImage::usesContainerSize): Adapt to override container size changes, it now lives in RenderSVGRoot instead of SVGSVGElement.
        (WebCore::SVGImage::size): New algorithm to figure out the size of an embedded SVG, as demanded by the CSS/SVG specs.
        (WebCore::SVGImage::draw): Stop calling layout() while painting!
        (WebCore::SVGImage::embeddedContentBox): Add helper which returns the RenderSVGRoot of the document.
        (WebCore::SVGImage::computeIntrinsicDimensions): Implement intrinsic ratio calculation.
        (WebCore::SVGImage::dataChanged): Force calling FrameView::setCanHaveScrollbars(false), as SVG images now always synthesize a viewBox, and thus never receive scrollbars.
        * svg/graphics/SVGImage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-26 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 26 Oct 2011 14:59:13 +0000 (14:59 +0000)]
2011-10-26  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Mark compositing/video/video-poster.html as timing out on Mac10.6 CPU-CG.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProperly suspend/resume Geolocation/DeviceMotion/DeviceOrientation objects
kenneth@webkit.org [Wed, 26 Oct 2011 14:56:09 +0000 (14:56 +0000)]
Properly suspend/resume Geolocation/DeviceMotion/DeviceOrientation objects
https://bugs.webkit.org/show_bug.cgi?id=70328

Reviewed by Simon Hausmann.

Also remove checks for m_client in DeviceMotionController as it can never be null.

No new tests, as the suspend/resume functionality is not fully working yet.

* dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::timerFired):
(WebCore::DeviceMotionController::addListener):
(WebCore::DeviceMotionController::removeListener):
(WebCore::DeviceMotionController::removeAllListeners):
(WebCore::DeviceMotionController::suspend):
(WebCore::DeviceMotionController::resume):
* dom/DeviceMotionController.h:
* dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::suspend):
(WebCore::DeviceOrientationController::resume):
* dom/DeviceOrientationController.h:
* dom/Document.cpp:
(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):
(WebCore::Document::stopActiveDOMObjects):
* dom/Document.h:
* dom/ScriptExecutionContext.h:
* page/GeolocationController.cpp:
(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::removeObserver):
(WebCore::GeolocationController::suspend):
(WebCore::GeolocationController::resume):
* page/GeolocationController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unreviewed gardening.
kbalazs@webkit.org [Wed, 26 Oct 2011 14:54:14 +0000 (14:54 +0000)]
[Qt][WK2] Unreviewed gardening.

[Qt][WK2] fast/css/font-face-descending-unicode-range.html fails
https://bugs.webkit.org/show_bug.cgi?id=70922
Skipped

[Qt][WK2] Metric mismatches (fast/text/justify-padding-distribution.html and svg/as-object/svg-embedded-in-html-in-iframe.html)
https://bugs.webkit.org/show_bug.cgi?id=70915
The svg test has correct pixel results so it's ok to add platform results.

* platform/qt-wk2/Skipped:
* platform/qt-wk2/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-26 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 26 Oct 2011 14:44:20 +0000 (14:44 +0000)]
2011-10-26  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Revert change to test_expectations.txt due to test failures.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-26 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 26 Oct 2011 14:32:04 +0000 (14:32 +0000)]
2011-10-26  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: follow up to 98236 - moved inspector settings initialization earlier to unbreak settings panel.

        * inspector/front-end/TextEditorModel.js:
        (WebInspector.TextEditorModel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-26 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 26 Oct 2011 13:56:06 +0000 (13:56 +0000)]
2011-10-26  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Mark compositing/video/video-poster.html as timing out on Mac10.6 GPU.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Rename clean-up of QtPinchGestureRecognizer and QtViewportInteractionEngine
abecsi@webkit.org [Wed, 26 Oct 2011 13:50:05 +0000 (13:50 +0000)]
[Qt][WK2] Rename clean-up of QtPinchGestureRecognizer and QtViewportInteractionEngine
https://bugs.webkit.org/show_bug.cgi?id=70903

Reviewed by Kenneth Rohde Christiansen.

Rename computeTouchCenter to computePinchCenter,
and use the plural form of coordinate where appropriate.

* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::_q_viewportUpdated):
* UIProcess/qt/QtPinchGestureRecognizer.cpp:
(WebKit::computePinchCenter):
(WebKit::QtPinchGestureRecognizer::recognize):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::contentRectInViewportCoordinates):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):
* UIProcess/qt/QtViewportInteractionEngine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Qt-WK2 gardening.
kbalazs@webkit.org [Wed, 26 Oct 2011 13:34:27 +0000 (13:34 +0000)]
Unreviewed Qt-WK2 gardening.

[Qt][WK2] Crash with http/tests/websocket/tests/hixie76/long-invalid-header.html
https://bugs.webkit.org/show_bug.cgi?id=70917

[Qt][WK2] fast/events/drag-selects-image.html fails
https://bugs.webkit.org/show_bug.cgi?id=70907

[Qt][WK2] Metric mismatches (fast/text/justify-padding-distribution.html and svg/as-object/svg-embedded-in-html-in-iframe.html)
https://bugs.webkit.org/show_bug.cgi?id=70915

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoName viewport change event consistently.
hausmann@webkit.org [Wed, 26 Oct 2011 13:32:59 +0000 (13:32 +0000)]
Name viewport change event consistently.
https://bugs.webkit.org/show_bug.cgi?id=70901

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-10-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

No tests needed as the change is only method renaming.

* page/Chrome.cpp:
(WebCore::Chrome::dispatchViewportPropertiesDidChange):
* page/Chrome.h:
* page/ChromeClient.h:
(WebCore::ChromeClient::dispatchViewportPropertiesDidChange):
* page/Page.cpp:
(WebCore::Page::updateViewportArguments):

Source/WebKit/efl:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::dispatchViewportPropertiesDidChange):
* WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::dispatchViewportPropertiesDidChange):
* WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/qt:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::dispatchViewportPropertiesDidChange):
* WebCoreSupport/ChromeClientQt.h:

Source/WebKit2:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::didChangeViewportProperties):
* UIProcess/API/efl/PageClientImpl.h:
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::didChangeViewportProperties):
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didChangeViewportProperties):
* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::didChangeViewportProperties):
* UIProcess/API/qt/qdesktopwebview_p.h:
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::didChangeViewportProperties):
* UIProcess/API/qt/qtouchwebview_p.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeViewportProperties):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/qt/QtDesktopWebPageProxy.cpp:
(QtDesktopWebPageProxy::didChangeViewportProperties):
* UIProcess/qt/QtDesktopWebPageProxy.h:
* UIProcess/qt/QtTouchViewInterface.cpp:
(WebKit::QtTouchViewInterface::didChangeViewportProperties):
* UIProcess/qt/QtTouchViewInterface.h:
* UIProcess/qt/QtViewInterface.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::didChangeViewportProperties):
* UIProcess/qt/QtWebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::didChangeViewportProperties):
* UIProcess/win/WebView.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):
* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Canvas2D should rate-limit drawing to prevent swamping the GPU process.
senorblanco@chromium.org [Wed, 26 Oct 2011 13:24:56 +0000 (13:24 +0000)]
[chromium] Canvas2D should rate-limit drawing to prevent swamping the GPU process.
https://bugs.webkit.org/show_bug.cgi?id=70367

Source/WebCore:

Reviewed by James Robinson.

Sadly, we don't have infrastructure to test this kind of GPU swamping
yet.

* WebCore.gypi:
Add RateLimiter.* to the Chromium build.
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::contentChanged):
When the layer is notified that the contents have changed, ping the
rate limiter.
* platform/graphics/chromium/Canvas2DLayerChromium.h:
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
Call (new) virtual contentChanged() on a layer when its contents have
been changed (e.g., by a drawing call).
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::contentChanged):
New virtual contentChanged().
* platform/graphics/chromium/RateLimiter.cpp: Added.
(WebCore::RateLimiter::create):
Rate limiter factory function.
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::start):
Public API to start rate limiting a context.
(WebCore::RateLimiter::stop):
Public API to stop rate limiting a context.
(WebCore::RateLimiter::rateLimitContext):
Internal timer callback when a context should be rate limited.
* platform/graphics/chromium/RateLimiter.h: Added.
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::WebGLLayerChromium):
Remove rate limiting timer and extension check (moved to RateLimiter).
(WebCore::WebGLLayerChromium::contentChanged):
The function formerly known as setTextureUpdated(), now renamed to
match the base class virtual contentChanged().  Call rate limiter in
CCLayerTreeHost (local implementation removed).
(WebCore::WebGLLayerChromium::setContext):
When the context is changed, stop the pending rate limiter on the old
context.  Remove extension check (moved to RateLimiter).
* platform/graphics/chromium/WebGLLayerChromium.h:
Remove rate limiting timer and extension check (moved to RateLimiter).
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::startRateLimiter):
Public API for starting per-context rate limiter.
(WebCore::CCLayerTreeHost::stopRateLimiter):
Public API for stopping per-context rate limiter.
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
Implementation of per-GraphicsContext3D RateLimiter.

Source/WebKit/chromium:

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::markContextChanged):
Remove the call to setTextureChanged (it will be handled internally
by the compositor in setContextNeedsDisplay() instead).  This decouples
GraphicsContext3D from WebGLLayerChromium a bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-26 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 26 Oct 2011 13:10:28 +0000 (13:10 +0000)]
2011-10-26  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: fixing inspector extensions tests.

        * inspector/front-end/ConsoleMessage.js:
        (WebInspector.ConsoleMessageImpl):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onAddConsoleMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Wed, 26 Oct 2011 12:58:45 +0000 (12:58 +0000)]
[Qt] Unreviewed gardening.

Skip failing tests temporarily because of missing Qt Mobility on the buildbot.

* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Remove g_thread_init() calls from gtk-doc scanner too
carlosgc@webkit.org [Wed, 26 Oct 2011 12:39:02 +0000 (12:39 +0000)]
[GTK] Remove g_thread_init() calls from gtk-doc scanner too
https://bugs.webkit.org/show_bug.cgi?id=70908

Reviewed by Gustavo Noronha Silva.

Source/WebKit/gtk:

* docs/GNUmakefile.am:

Source/WebKit2:

* UIProcess/API/gtk/docs/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-26 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 26 Oct 2011 12:33:45 +0000 (12:33 +0000)]
2011-10-26  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed, gardening. Mark editing/selection/designmode-no-caret.html as failing in debug mode.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] inspector/extensions/extensions-console.html is failing
kbalazs@webkit.org [Wed, 26 Oct 2011 12:11:14 +0000 (12:11 +0000)]
[Qt] inspector/extensions/extensions-console.html is failing
https://bugs.webkit.org/show_bug.cgi?id=70905

Unreviewed gardening. Skip failing test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoParallelJobs path of FEConvolveMatrix is erroneous
kbalazs@webkit.org [Wed, 26 Oct 2011 11:44:12 +0000 (11:44 +0000)]
ParallelJobs path of FEConvolveMatrix is erroneous
https://bugs.webkit.org/show_bug.cgi?id=70409

Reviewed by Zoltan Herczeg.

Covered by existing tests.

* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::fastSetInteriorPixels):
Reject the silly idea that bytes per pixel ratio is 3 in preserveAlphaValues mode.
The bug was hidden so far because that computation has no effect when we are going
with the full inferior area in one round (in that case clipBottom and yEnd are equals
and the value of the expression is always 0). With ParallelJobs we process sub-areas
on each thread which has triggered the issue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Fix failing assertion on startup of MiniBrowser -touch.
hausmann@webkit.org [Wed, 26 Oct 2011 09:59:17 +0000 (09:59 +0000)]
[Qt][WK2] Fix failing assertion on startup of MiniBrowser -touch.

Reviewed by Tor Arne Vestbø.

We're using QScroller since r98460, which requires QWidget/QApplication. So
use QApplication and QtWidgets for the time being.

* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):
* MiniBrowser/qt/MiniBrowserApplication.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Add the animations on the ViewportInteractionEngine
abecsi@webkit.org [Wed, 26 Oct 2011 09:49:21 +0000 (09:49 +0000)]
[Qt][WK2] Add the animations on the ViewportInteractionEngine
https://bugs.webkit.org/show_bug.cgi?id=66664

Reviewed by Kenneth Rohde Christiansen.

Introduce a QScroller based panning and a QVariantAnimation based scale animation.
QScroller also handles flick gestures and animates overshoot.
If a pinch gesture ends, the scale animation will scale and reposition the content
such that it is within valid boundaries. The content is by default animated such
that the content position as seen in the center of the visible viewport stays
in the center, unless the content would be out of valid bounds.
The patch also simplifies the ViewportUpdateGuard by using reference counting
instead of a boolean for defering update requests.

* UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::recognize):
* UIProcess/qt/QtPanGestureRecognizer.h:
* UIProcess/qt/QtPinchGestureRecognizer.cpp:
(WebKit::QtPinchGestureRecognizer::recognize):
* UIProcess/qt/QtTouchWebPageProxy.cpp:
(QtTouchWebPageProxy::doneWithTouchEvent):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::bindToScaleLimits):
(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::innerBoundedScale):
(WebKit::QtViewportInteractionEngine::outerBoundedScale):
(WebKit::QtViewportInteractionEngine::updateVisibleRect):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::stopAnimations):
(WebKit::QtViewportInteractionEngine::calculateBoundariesForScale):
(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::setConstraints):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureCancelled):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::contentViewportChanged):
* UIProcess/qt/QtViewportInteractionEngine.h:
(WebKit::QtViewportInteractionEngine::scroller):
(WebKit::QtViewportInteractionEngine::ScaleAnimation::ScaleAnimation):
(WebKit::QtViewportInteractionEngine::ScaleAnimation::updateCurrentValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed skip. fast/canvas/canvas-composite-image.html failing on Qt
rgabor@webkit.org [Wed, 26 Oct 2011 09:41:27 +0000 (09:41 +0000)]
[Qt] Unreviewed skip. fast/canvas/canvas-composite-image.html failing on Qt

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r98393.
yurys@chromium.org [Wed, 26 Oct 2011 09:38:42 +0000 (09:38 +0000)]
Unreviewed, rolling out r98393.
http://trac.webkit.org/changeset/98393
https://bugs.webkit.org/show_bug.cgi?id=70892

"Compilation is broken on Chromium Webkit Mac Builder (dbg) "
(Requested by yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-26

Source/WebCore:

* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setMasksToBounds):
(WebCore::LayerChromium::setMaskLayer):

Source/WebKit/chromium:

* WebKit.gypi:
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::setDrawsContent):
* src/WebExternalTextureLayerImpl.cpp:
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
* src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::~WebLayerImpl):
* tests/LayerChromiumTest.cpp:
* tests/WebLayerTest.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix editing/selection/caret-mode-paragraph-keys-navigation.html for Mac
rniwa@webkit.org [Wed, 26 Oct 2011 09:33:51 +0000 (09:33 +0000)]
Fix editing/selection/caret-mode-paragraph-keys-navigation.html for Mac
https://bugs.webkit.org/show_bug.cgi?id=70880

Reviewed by Eric Seidel.

Use option key (instead of control key) to move between word boundaries on Mac.

* editing/selection/caret-mode-paragraph-keys-navigation.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: order console message parameters for better optional parameters handling.
pfeldman@chromium.org [Wed, 26 Oct 2011 09:25:39 +0000 (09:25 +0000)]
Web Inspector: order console message parameters for better optional parameters handling.
https://bugs.webkit.org/show_bug.cgi?id=70809

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/Inspector.json:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
* inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleCommandResult):
(WebInspector.ConsoleMessage.create):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddConsoleMessage):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
* inspector/front-end/inspector.js:
(WebInspector.log.logMessage):
(WebInspector.log):

LayoutTests:

* inspector/console/console-preserve-log.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix rebaseline done in r98439.
rniwa@webkit.org [Wed, 26 Oct 2011 09:14:26 +0000 (09:14 +0000)]
Fix rebaseline done in r98439.

* platform/chromium-cg-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Removed.
* platform/chromium/editing/pasteboard/copy-standalone-image-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Debugger fails when there is an invalid watch expression.
vsevik@chromium.org [Wed, 26 Oct 2011 09:07:50 +0000 (09:07 +0000)]
Web Inspector: Debugger fails when there is an invalid watch expression.
https://bugs.webkit.org/show_bug.cgi?id=70718

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/watch-expressions-panel-switch.html

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

* inspector/debugger/error-in-watch-expressions.html:
* inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.
* inspector/debugger/watch-expressions-panel-switch.html: Added.
* platform/chromium/inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPage Scale Factor broken when navigating history on pages with child frames
fsamuel@chromium.org [Wed, 26 Oct 2011 08:52:42 +0000 (08:52 +0000)]
Page Scale Factor broken when navigating history on pages with child frames
https://bugs.webkit.org/show_bug.cgi?id=70459

Reviewed by Darin Fisher.

With frameScaleFactor now always returning 1.0 for subframes and pageScaleFactor for the mainFrame,
and there being only a single pageScaleFactor, history for scaling is broken. Scaling history is
saved on a per frame basis but restored, overriding the per-page pageScaleFactor multiple times.
As a result, sometimes pages that have subframes end up getting a scale factor of 1.0 instead
of the correct scale factor that was assigned to the main frame.

No new tests because I don't know how to test this.

* loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFiled more bugs.
rniwa@webkit.org [Wed, 26 Oct 2011 08:52:40 +0000 (08:52 +0000)]
Filed more bugs.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore Chromium test expectation updates. Filed a bunch of bugs to track real failures
rniwa@webkit.org [Wed, 26 Oct 2011 08:45:09 +0000 (08:45 +0000)]
More Chromium test expectation updates. Filed a bunch of bugs to track real failures
and removed erroneous failing test expectations.

* platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
* platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Rewrite MiniBrowser in QML
hausmann@webkit.org [Wed, 26 Oct 2011 08:29:48 +0000 (08:29 +0000)]
[Qt][WK2] Rewrite MiniBrowser in QML
https://bugs.webkit.org/show_bug.cgi?id=70315

Add the first QML based implementation of MiniBrowser.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
         Zeno Albisser <zeno.albisser@nokia.com>

Source/WebKit2:

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-26
Reviewed by Tor Arne Vestbø.

* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebView::mousePressEvent):

 2011-10-20  Zeno Albisser  <zeno.albisser@nokia.com>

[Qt][WK2] Disable Context Menus until we have a proper QML implementation
https://bugs.webkit.org/show_bug.cgi?id=70537

This is just a temporary fix to avoid crashes in QtGui based
MiniBrowser that does not link to QtWidgets.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
         Zeno Albisser <zeno.albisser@nokia.com>

Reviewed by Simon Hausmann.

* UIProcess/qt/WebContextMenuProxyQt.cpp:
(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):

Tools:

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Tor Arne Vestbø.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::webView):
(BrowserWindow::load):
(BrowserWindow::keyPressEvent):
(BrowserWindow::~BrowserWindow):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::handleUserOptions):
* MiniBrowser/qt/MiniBrowserApplication.h:
(WindowOptions::WindowOptions):
* MiniBrowser/qt/UrlLoader.cpp:
(UrlLoader::UrlLoader):
* MiniBrowser/qt/icons/next.png: Added.
* MiniBrowser/qt/icons/previous.png: Added.
* MiniBrowser/qt/icons/refresh.png: Added.
* MiniBrowser/qt/icons/stop.png: Added.
* MiniBrowser/qt/main.cpp:
(main):
* MiniBrowser/qt/qml/BrowserWindow.qml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago 2011-10-20 Zeno Albisser <zeno.albisser@nokia.com>
hausmann@webkit.org [Wed, 26 Oct 2011 08:29:16 +0000 (08:29 +0000)]
 2011-10-20  Zeno Albisser  <zeno.albisser@nokia.com>

[Qt][WK2] Disable Context Menus until we have a proper QML implementation
https://bugs.webkit.org/show_bug.cgi?id=70537

This is just a temporary fix to avoid crashes in QtGui based
MiniBrowser that does not link to QtWidgets.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
         Zeno Albisser <zeno.albisser@nokia.com>

Reviewed by Simon Hausmann.

* UIProcess/qt/WebContextMenuProxyQt.cpp:
(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Remove QtWidgets dependency in MiniBrowser
hausmann@webkit.org [Wed, 26 Oct 2011 08:29:00 +0000 (08:29 +0000)]
[Qt][WK2] Remove QtWidgets dependency in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=70529

Remove obsolete code for a new QML based implementation
of MiniBrowser.
Change BrowserWindow to derive from QSGView instead of
QMainWindow. QSGView is used as a top level window that
provides the container for placing QML content.
Make MiniBrowserApplication derive from QGuiApplication
instead of QApplication.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
         Zeno Albisser <zeno.albisser@nokia.com>

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Simon Hausmann.

* MiniBrowser/qt/BrowserView.cpp: Removed.
* MiniBrowser/qt/BrowserView.h: Removed.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::load):
(BrowserWindow::screenshot):
(BrowserWindow::loadURLListFromFile):
(BrowserWindow::updateUserAgentList):
(BrowserWindow::~BrowserWindow):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):
* MiniBrowser/qt/MiniBrowserApplication.h:
* MiniBrowser/qt/UrlLoader.cpp:
(UrlLoader::UrlLoader):
* MiniBrowser/qt/main.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Remove QAction from MiniBrowser
hausmann@webkit.org [Wed, 26 Oct 2011 08:28:30 +0000 (08:28 +0000)]
[Qt][WK2] Remove QAction from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=70525

In order to rewrite MiniBrowser in QML we need a suitable
mechanism for triggering navigation actions.
Due to the QtWidgets dependency of QAction the current
solution is not suitable anymore. Therefore we introduce
invokable methods and export properties in QWebNavigationController.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
         Zeno Albisser <zeno.albisser@nokia.com>

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Simon Hausmann.

Source/WebKit2:

* UIProcess/API/qt/WKView.h:
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qwebkittypes.h: Removed.
* UIProcess/API/qt/qwebnavigationcontroller.cpp:
(QWebNavigationController::QWebNavigationController):
(QWebNavigationController::canGoBack):
(QWebNavigationController::canGoForward):
(QWebNavigationController::canStop):
(QWebNavigationController::canReload):
(QWebNavigationController::goBack):
(QWebNavigationController::goForward):
(QWebNavigationController::stop):
(QWebNavigationController::reload):
* UIProcess/API/qt/qwebnavigationcontroller.h:
* UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
(tst_CommonViewTests::backAndForward):
(tst_CommonViewTests::reload):
(tst_CommonViewTests::stop):
* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::goBack):
(WebViewAbstraction::goForward):
(WebViewAbstraction::stop):
(WebViewAbstraction::reload):
* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
* UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:
(tst_QDesktopWebView::navigationStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QDesktopWebView::stopEnabledAfterLoadStarted):
* UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:
(tst_QTouchWebView::navigationStatusAtStartup):
* UIProcess/qt/ClientImpl.cpp:
(dispatchLoadSucceeded):
(dispatchLoadFailed):
(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didSameDocumentNavigationForFrame):
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::canGoBack):
(QtWebPageProxy::goBack):
(QtWebPageProxy::canGoForward):
(QtWebPageProxy::goForward):
(QtWebPageProxy::canStop):
(QtWebPageProxy::stop):
(QtWebPageProxy::canReload):
(QtWebPageProxy::reload):
(QtWebPageProxy::navigationStateChanged):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):
* UIProcess/qt/QtWebPageProxy.h:
* WebKit2API.pri:

Tools:

* MiniBrowser/qt/BrowserView.cpp:
* MiniBrowser/qt/BrowserView.h:
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Private function _ewk_view_viewport_attributes_compute takes an internal data...
commit-queue@webkit.org [Wed, 26 Oct 2011 08:27:45 +0000 (08:27 +0000)]
[EFL] Private function _ewk_view_viewport_attributes_compute takes an internal data of ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66366

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-10-26
Reviewed by Ryosuke Niwa.

Passes to _ewk_view_viewport_attributes_compute an internal data of ewk_view instead of the view object.
Adds to ewk_view_viewport_attributes_get NULL checks to avoid unexpected results since this is API.

* ewk/ewk_view.cpp:
(_ewk_view_viewport_attributes_compute):
(ewk_view_viewport_attributes_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r98429.
yurys@chromium.org [Wed, 26 Oct 2011 08:24:51 +0000 (08:24 +0000)]
Unreviewed, rolling out r98429.
http://trac.webkit.org/changeset/98429
https://bugs.webkit.org/show_bug.cgi?id=70881

"webkit_gpu_tests fail in Chromium" (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-26

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::layerRendererContext):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::enabled):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::setNeedsAnimate):
(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* public/WebLayerTreeView.h:
* src/WebCompositorImpl.cpp:
(WebKit::WebCompositor::setThread):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unregister viewport,changed signal in EWebLauncher.
gyuyoung.kim@samsung.com [Wed, 26 Oct 2011 08:13:01 +0000 (08:13 +0000)]
[EFL] Unregister viewport,changed signal in EWebLauncher.
https://bugs.webkit.org/show_bug.cgi?id=70478

Reviewed by Eric Seidel.

'viewport,changed' signal was registered by EWebLauncher in order to test viewport meta tag.
However, it sets wrong layout to some web sites which have viewport meta tag. Because, host pc
doesn't support proper DPI value though viewport is using DPI value to compute layout values.
This signal is for mobile device.

* EWebLauncher/main.c:
(browserCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCleanup Chromium test expectation. These tests were erroneously marked as timing...
rniwa@webkit.org [Wed, 26 Oct 2011 08:07:28 +0000 (08:07 +0000)]
Cleanup Chromium test expectation. These tests were erroneously marked as timing out intermittently
even though the Chromium issue 66085 was fixed a long time ago.

Remove failing expectations from these tests except http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html
which is still timing out intermittently on Chromium Linux. Filed the bug 70878 to track the failure.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove temporary hack needed to ease Chromium/WebKit commit.
commit-queue@webkit.org [Wed, 26 Oct 2011 07:57:50 +0000 (07:57 +0000)]
Remove temporary hack needed to ease Chromium/WebKit commit.
https://bugs.webkit.org/show_bug.cgi?id=70791

Patch by Polina Sokolova <polina@chromium.org> on 2011-10-26
Reviewed by Darin Fisher.

* public/WebDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium editing test rebaselines and editing test expectations updates.
rniwa@webkit.org [Wed, 26 Oct 2011 07:57:16 +0000 (07:57 +0000)]
Chromium editing test rebaselines and editing test expectations updates.

* platform/chromium-linux/editing/selection/5354455-2-expected.png:
* platform/chromium-mac-leopard/editing/inserting/12882-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/12882-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/5354455-2-expected.png: Added.
* platform/chromium-mac/editing/inserting/12882-expected.png: Removed.
* platform/chromium-mac/editing/selection/5354455-2-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCanvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy...
commit-queue@webkit.org [Wed, 26 Oct 2011 07:52:07 +0000 (07:52 +0000)]
Canvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=66920

Patch by Ben Wells <benwells@chromium.org> on 2011-10-26
Reviewed by James Robinson.

Source/WebCore:

Test: fast/canvas/canvas-composite-image.html

Use the same method as fills to handle composited drawImage calls that will affect the whole
canvas. To do this code used when doing fills has been factored into seperate functions and
used by drawImage. Some functions used to do these types of operations have also been renamed.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::isFullCanvasCompositeMode):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::calculateCompositingBufferRect):
(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):
* html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

* fast/canvas/canvas-composite-image-expected.txt: Added.
* fast/canvas/canvas-composite-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium Mac rebaseline, trusting the baseline optimizer.
rniwa@webkit.org [Wed, 26 Oct 2011 07:36:06 +0000 (07:36 +0000)]
Chromium Mac rebaseline, trusting the baseline optimizer.

* platform/chromium-cg-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Added.
* platform/chromium-cg-mac/editing/pasteboard/copy-standalone-image-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Added.
* platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother GTK build fix attempt after r98413 and r98416.
rniwa@webkit.org [Wed, 26 Oct 2011 07:07:56 +0000 (07:07 +0000)]
Another GTK build fix attempt after r98413 and r98416.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoC/C++ needs ; after each statement.
rniwa@webkit.org [Wed, 26 Oct 2011 06:57:58 +0000 (06:57 +0000)]
C/C++ needs ; after each statement.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::geometryDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac, Qt, and Windows rebaseline r98407.
rniwa@webkit.org [Wed, 26 Oct 2011 06:56:02 +0000 (06:56 +0000)]
Mac, Qt, and Windows rebaseline r98407.

* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGTK build fix attempt after r98413 and r98416.
rniwa@webkit.org [Wed, 26 Oct 2011 06:47:12 +0000 (06:47 +0000)]
GTK build fix attempt after r98413 and r98416.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
(WebKit::PluginControllerProxy::geometryDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r98379.
commit-queue@webkit.org [Wed, 26 Oct 2011 06:46:35 +0000 (06:46 +0000)]
Unreviewed, rolling out r98379.
http://trac.webkit.org/changeset/98379
https://bugs.webkit.org/show_bug.cgi?id=70875

Did not pass on JSC ports (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-25

Source/WebCore:

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):
* html/canvas/CanvasRenderingContext2D.idl:
* page/DOMWindow.idl:

LayoutTests:

* fast/canvas/canvas-putImageData-expected.txt:
* fast/canvas/canvas-putImageData.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r98346.
commit-queue@webkit.org [Wed, 26 Oct 2011 06:25:39 +0000 (06:25 +0000)]
Unreviewed, rolling out r98346.
http://trac.webkit.org/changeset/98346
https://bugs.webkit.org/show_bug.cgi?id=70874

Breaks JSC-based bots. (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-25

Source/WebCore:

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

* inspector/debugger/error-in-watch-expressions.html:
* inspector/debugger/watch-expressions-panel-switch-expected.txt: Removed.
* inspector/debugger/watch-expressions-panel-switch.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFlaky Test: editing/pasteboard/copy-standalone-image.html
rniwa@webkit.org [Wed, 26 Oct 2011 06:20:40 +0000 (06:20 +0000)]
Flaky Test: editing/pasteboard/copy-standalone-image.html
https://bugs.webkit.org/show_bug.cgi?id=61813

Reviewed by Adam Barth.

The flakiness was caused by the fact test didn't wait until iframe finish loading.

HTML5 section 4.8.2. the iframe element (http://www.whatwg.org/specs/web-apps/current-work/#the-iframe-element):
    When there is an active parser in the iframe, and when anything in the iframe is delaying the load event
    of the iframe's browsing context's active document, the iframe must delay the load event of its document.

Since an image doesn't require an active parser, it does not delay the load event of the document.

* editing/pasteboard/copy-standalone-image.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSplit DFGJITCodeGenerator::callOperation methods
barraclough@apple.com [Wed, 26 Oct 2011 05:55:27 +0000 (05:55 +0000)]
Split DFGJITCodeGenerator::callOperation methods
https://bugs.webkit.org/show_bug.cgi?id=70870

Reviewed by Filip Pizlo.

The DFGJITCodeGenerator currently contains two sets of callOperation methods.
One set works with the JSVALUE64 value representation and passes arguments in
registers (suitable for use on x86-64), and one set works with the JSVALUE32_64
value representation and passes arguments in memory  (suitable for use on x86).
By refactoring out the representation and calling convention specific aspects
of the code we can also configure the DFG JIT to operator on platforms that use
the JSVALUE32_64 value representation but pass arguments in registers.

On platforms supported by the JIT, the payload precedes the tag of a value in
argument/result ordering, as such, in order to make the setupResults method
generally applicable to return the results of a function that are returned in
two registers, the ordering of arguments to this function has been reversed -
as is the ordering of augments passed to setupArguments methods, with respect
to the ordering with which they are passed in to callOperation.
This inconsistency will be resolved in a later change when we combine the pairs
of arguments passed into callOperation, such that the function signatures can
be made consistent across the two value representations (the callOperation
methods will be passed a reference to a struct representing the JSValue
temporary, this will consist of two gprs on 32_64 and one on 64).

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::resetCallArguments):
(JSC::DFG::addCallArgument):
    - moved, removed tag,payload version of this method.
(JSC::DFG::setupArguments):
(JSC::DFG::setupArgumentsExecState):
(JSC::DFG::setupArgumentsWithExecState):
    - Calling convention specific portion of callOperation refactored out into these methods.
(JSC::DFG::callOperation):
    - updated these methods to use setupArguments* methods.
(JSC::DFG::setupResults):
    - setupResults is now passed payload,tag.
(JSC::DFG::appendCallWithExceptionCheckSetResult):
    - Added fpr versions of this function.
(JSC::DFG::appendCallSetResult):
    - Added versions of this function without exception check.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
    - setupResults is now passed payload,tag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable editing/selection/move-by-word-visually-inline-block-positioned-element.html...
xji@chromium.org [Wed, 26 Oct 2011 05:17:48 +0000 (05:17 +0000)]
Disable editing/selection/move-by-word-visually-inline-block-positioned-element.html in QT after r98428.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Enable threaded compositing via CCThreadProxy::hasThread only
nduca@chromium.org [Wed, 26 Oct 2011 05:02:41 +0000 (05:02 +0000)]
[chromium] Enable threaded compositing via CCThreadProxy::hasThread only
https://bugs.webkit.org/show_bug.cgi?id=70838

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::layerRendererContext):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::enabled):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::setNeedsAnimate):
(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::hasThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* public/WebLayerTreeView.h:
* src/WebCompositorImpl.cpp:
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago--webkit-visual-word does not work in multi-line
xji@chromium.org [Wed, 26 Oct 2011 04:57:39 +0000 (04:57 +0000)]
--webkit-visual-word does not work in multi-line
https://bugs.webkit.org/show_bug.cgi?id=61344

Reviewed by Ryosuke Niwa.

Source/WebCore:

Get next or previous root inline box (which is not in the same
render object as the current root inline box) by traversing DOM node.

Test: editing/selection/move-by-word-visually-inline-block-positioned-element.html

* editing/visible_units.cpp:
(WebCore::previousRootInlineBox):
(WebCore::nextRootInlineBox):
(WebCore::leftInlineBox):
(WebCore::rightInlineBox):

LayoutTests:

* editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt: Added.
* editing/selection/move-by-word-visually-inline-block-positioned-element.html: Added.
* editing/selection/move-by-word-visually-multi-line-expected.txt:
* editing/selection/move-by-word-visually-single-space-one-element-expected.txt:
* editing/selection/move-by-word-visually-single-space-one-element.html:
* platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSEventTarget.cpp has a bunch of unnessary includes
abarth@webkit.org [Wed, 26 Oct 2011 03:06:58 +0000 (03:06 +0000)]
JSEventTarget.cpp has a bunch of unnessary includes
https://bugs.webkit.org/show_bug.cgi?id=70865

Reviewed by Eric Seidel.

In the process of removing these includes, I noticed we had a bunch of
non-autogenerated code in this file, which I've now autogenerated.

* bindings/js/JSEventTarget.cpp:
(WebCore::toEventTarget):
    - One subtly here is the outter static_cast, which is caused by an
      inheritance infelicity in JavaScriptAudioNode, which I've noted
      with a FIXME.  In any case, the extra static_cast shouldn't cause
      any trouble.
* webaudio/JavaScriptAudioNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoV8DOMWrapper.cpp has unneeded header includes
abarth@webkit.org [Wed, 26 Oct 2011 02:14:53 +0000 (02:14 +0000)]
V8DOMWrapper.cpp has unneeded header includes
https://bugs.webkit.org/show_bug.cgi?id=70863

Reviewed by Eric Seidel.

* bindings/v8/V8DOMWrapper.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix ad hoc test.
arv@chromium.org [Wed, 26 Oct 2011 02:12:22 +0000 (02:12 +0000)]
Fix ad hoc test.

unreviewed.

* fast/canvas/webgl/gl-teximage.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix occurrence of unpainted tiles while scrolling and zooming.
commit-queue@webkit.org [Wed, 26 Oct 2011 02:11:33 +0000 (02:11 +0000)]
Fix occurrence of unpainted tiles while scrolling and zooming.
https://bugs.webkit.org/show_bug.cgi?id=70711

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-10-25
Reviewed by Adam Barth.

Cast one of operatees to float type when ewk_tiled_backing_store calculate tiles list on viewport.
For the proper calculation to generate a float number, at least one of operatees must be a float type.
But, currently both two operatees to calculate the number of tiles on viewport routine aren't float type,
so it generates smaller result than expected result when it is using ceil API.
As a result, it can lose a line of tiles which should be displayed in viewport area while scrolling and zooming.

* ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_recalc_renderers):
(ewk_tiled_backing_store_zoom_weak_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoResetting baseline for test bindings
mhahnenberg@apple.com [Wed, 26 Oct 2011 01:59:37 +0000 (01:59 +0000)]
Resetting baseline for test bindings

Unreviewed preemptive build fix

No new tests.

* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove deletePropertyVirtual
mhahnenberg@apple.com [Wed, 26 Oct 2011 01:49:00 +0000 (01:49 +0000)]
Remove deletePropertyVirtual
https://bugs.webkit.org/show_bug.cgi?id=70738

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::deletePropertyByIndex):
* API/JSObjectRef.cpp:
(JSObjectDeleteProperty):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::deleteProperty):
* debugger/DebuggerActivation.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Arguments.cpp:
* runtime/Arguments.h:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::deleteProperty):
(JSC::JSArray::deletePropertyByIndex):
* runtime/JSArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::deleteProperty):
(JSC::JSCell::deletePropertyByIndex):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::Walker::walk):
* runtime/JSObject.cpp:
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
* runtime/JSVariableObject.cpp:
* runtime/JSVariableObject.h:
* runtime/RegExpMatchesArray.h:
* runtime/StrictEvalActivation.cpp:
* runtime/StrictEvalActivation.h:
* runtime/StringObject.cpp:
* runtime/StringObject.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

* WebCore.exp.in:
* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::deleteProperty):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::deleteProperty):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::deleteProperty):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::deleteProperty):
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::deleteProperty):
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::deleteProperty):
* bindings/js/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::remove):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject removeWebScriptKey:]):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* bridge/NP_jsobject.cpp:
(_NPN_RemoveProperty):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::removeMember):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
* bridge/runtime_array.cpp:
* bridge/runtime_array.h:
* bridge/runtime_object.cpp:
* bridge/runtime_object.h:

Source/WebKit/mac:

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::removeProperty):

Source/WebKit2:

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
* WebProcess/Plugins/Netscape/JSNPObject.h:
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::removeProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: WebKit does not expose HTML label for slider elements
cfleizach@apple.com [Wed, 26 Oct 2011 01:45:40 +0000 (01:45 +0000)]
AX: WebKit does not expose HTML label for slider elements
https://bugs.webkit.org/show_bug.cgi?id=70856

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/accessibility/slider-allows-title-ui-element.html

* accessibility/AccessibilitySlider.h:
(WebCore::AccessibilitySlider::isControl):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

* platform/mac/accessibility/slider-allows-title-ui-element-expected.txt: Added.
* platform/mac/accessibility/slider-allows-title-ui-element.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
jchaffraix@webkit.org [Wed, 26 Oct 2011 01:38:31 +0000 (01:38 +0000)]
Unreviewed gardening.

* platform/chromium/test_expectations.txt:
fast/forms/form-associated-element-crash3.html has
been timing out very regularly on linux debug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Move assignment of some variables out of loop for ewk_tiled_backing_store.
commit-queue@webkit.org [Wed, 26 Oct 2011 01:15:22 +0000 (01:15 +0000)]
[EFL] Move assignment of some variables out of loop for ewk_tiled_backing_store.
https://bugs.webkit.org/show_bug.cgi?id=67588

Some of variables which aren't related with loop count or other variables
inside of loop are moved out of loop.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-10-25
Reviewed by Adam Barth.

* ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_view_wrap_up):
(_ewk_tiled_backing_store_view_wrap_down):
(_ewk_tiled_backing_store_view_wrap_left):
(_ewk_tiled_backing_store_view_wrap_right):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Unreviewed build fix after r97587.
bfulgham@webkit.org [Wed, 26 Oct 2011 01:13:52 +0000 (01:13 +0000)]
[WinCairo] Unreviewed build fix after r97587.

* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix expectation.
arv@chromium.org [Wed, 26 Oct 2011 01:01:46 +0000 (01:01 +0000)]
[Chromium] Fix expectation.

unreviewed.

* platform/chromium/fast/js/kde/garbage-n-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCG plug-ins are always given a context with a scale factor of 1, even when the device...
andersca@apple.com [Wed, 26 Oct 2011 01:00:14 +0000 (01:00 +0000)]
CG plug-ins are always given a context with a scale factor of 1, even when the device scale factor is something else
https://bugs.webkit.org/show_bug.cgi?id=67227
<rdar://problem/10048319>

Reviewed by Sam Weinig.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
Apply the scale factor when painting.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
Apply the scale factor when painting.

(WebKit::PluginProxy::geometryDidChange):
Make sure to apply the contents scale factor to the backing store size.

(WebKit::PluginProxy::update):
Apply the scale factor (when painting).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove putVirtual
mhahnenberg@apple.com [Wed, 26 Oct 2011 00:56:55 +0000 (00:56 +0000)]
Remove putVirtual
https://bugs.webkit.org/show_bug.cgi?id=70740

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
* API/JSObjectRef.cpp:
(JSObjectSetProperty):
(JSObjectSetPropertyAtIndex):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::put):
* debugger/DebuggerActivation.h:
* dfg/DFGOperations.cpp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
* jsc.cpp:
(GlobalObject::finishCreation):
* runtime/Arguments.cpp:
* runtime/Arguments.h:
* runtime/ArrayPrototype.cpp:
(JSC::putProperty):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::put):
(JSC::JSCell::putByIndex):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::Walker::walk):
* runtime/JSObject.cpp:
(JSC::JSObject::putByIndex):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
(JSC::JSValue::put):
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/ObjectPrototype.cpp:
* runtime/ObjectPrototype.h:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
* runtime/RegExpObject.cpp:
* runtime/RegExpObject.h:
* runtime/StringObject.cpp:
* runtime/StringObject.h:
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncSplit):

Source/JavaScriptGlue:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

* JSValueWrapper.cpp:
(JSValueWrapper::JSObjectSetProperty):
* UserObjectImp.cpp:
* UserObjectImp.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

* WebCore.exp.in:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::put):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::runtimeObjectCustomPut):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::putProperty):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject setWebScriptValueAtIndex:value:]):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bridge/NP_jsobject.cpp:
(_NPN_SetProperty):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::setMember):
(JavaJSObject::setSlot):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):
* bridge/runtime_array.cpp:
* bridge/runtime_array.h:
* bridge/runtime_object.cpp:
* bridge/runtime_object.h:
* bridge/testqtbindings.cpp:
(main):

Source/WebKit/efl:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

* ewk/ewk_view.cpp:
(ewk_view_js_object_add):

Source/WebKit/mac:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::setProperty):

Source/WebKit/qt:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

* Api/qwebframe.cpp:
(QWebFrame::addToJavaScriptWindowObject):

Source/WebKit2:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
* WebProcess/Plugins/Netscape/JSNPObject.h:
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::setProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd radar.
andersca@apple.com [Wed, 26 Oct 2011 00:34:58 +0000 (00:34 +0000)]
Add radar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlug-ins have no way to find out when the device scale factor changes
andersca@apple.com [Wed, 26 Oct 2011 00:30:39 +0000 (00:30 +0000)]
Plug-ins have no way to find out when the device scale factor changes
https://bugs.webkit.org/show_bug.cgi?id=67226

Reviewed by Sam Weinig.

Source/WebKit2:

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::geometryDidChange):
* PluginProcess/PluginControllerProxy.h:
This now takes the contentsScaleFactor and calls contentsScaleFactorChanged on its plug-in
if the scale factor changes.

* PluginProcess/PluginControllerProxy.messages.in:
GeometryDidChange now takes a contents scale factor parameter.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::contentsScaleFactorChanged):
Implement contentsScaleFactorChanged and call NPP_SetValue with the new scale factor.

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::contentsScaleFactorChanged):
* WebProcess/Plugins/PDF/BuiltInPDFView.h:
Add stub.

* WebProcess/Plugins/Plugin.h:
Add pure virtual contentsScaleFactorChanged member function.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
Add geometryDidChange overload that doesn't take any parameters. Make it send over the
new scale factor to the plug-in process.

(WebKit::PluginProxy::contentsScaleFactorChanged):
Call geometryDidChange.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setDeviceScaleFactor):
Call Plugin::contentsScaleFactorChanged.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setDeviceScaleFactor):
Call setDeviceScaleFactor on all registered plug-ins.

Tools:

Keep a cached copy of the contents scale and update it when it changes.

* DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:
(ContentsScaleFactor::ContentsScaleFactor):
(ContentsScaleFactor::cachedContentsScaleFactor):
(ContentsScaleFactor::ScriptableObject::hasProperty):
(ContentsScaleFactor::ScriptableObject::getProperty):
(ContentsScaleFactor::NPP_New):
(ContentsScaleFactor::NPP_SetValue):

LayoutTests:

Update test to check that the scale factor is updated correctly.

* platform/mac-wk2/plugins/contents-scale-factor.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEventTargetFactory.in is not sorted
abarth@webkit.org [Tue, 25 Oct 2011 23:43:33 +0000 (23:43 +0000)]
EventTargetFactory.in is not sorted
https://bugs.webkit.org/show_bug.cgi?id=70855

Reviewed by Eric Seidel.

PerformanceTests:

Add a microbenchmark for wrapping event target.

* Bindings: Added.
* Bindings/event-target-wrapper.html: Added.
* Parser/resources/runner.js:
(runLoop):
    - Let the user of the harness get a callback when the test is done.

Source/WebCore:

This patch sorts the file.  I was not able to measure a performance
difference using the microbenchmark included with this patch.

* dom/EventTargetFactory.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMade Table tests for Bug 70678 Platform Independent
fsamuel@chromium.org [Tue, 25 Oct 2011 23:42:57 +0000 (23:42 +0000)]
Made Table tests for Bug 70678 Platform Independent
https://bugs.webkit.org/show_bug.cgi?id=70850

Reviewed by Adam Barth.

* fast/table/table-anonymous-cell-bug-expected.png: Added.
* fast/table/table-anonymous-cell-bug-expected.txt:
* fast/table/table-anonymous-cell-bug.html:
* fast/table/table-anonymous-row-bug-expected.png: Added.
* fast/table/table-anonymous-row-bug-expected.txt:
* fast/table/table-anonymous-row-bug.html:
* fast/table/table-anonymous-section-bug-expected.png: Added.
* fast/table/table-anonymous-section-bug-expected.txt:
* fast/table/table-anonymous-section-bug.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAttempt to fix the Windows build. Windows mashes all these files into
abarth@webkit.org [Tue, 25 Oct 2011 23:39:28 +0000 (23:39 +0000)]
Attempt to fix the Windows build.  Windows mashes all these files into
one, which doesn't respect the compilation unit rules of C++.

* bindings/js/JSEventCustom.cpp:
* bindings/js/JSEventTarget.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd WKBrowsingContextLoadDelegateTest test for a failed load
weinig@apple.com [Tue, 25 Oct 2011 23:19:00 +0000 (23:19 +0000)]
Add WKBrowsingContextLoadDelegateTest test for a failed load
https://bugs.webkit.org/show_bug.cgi?id=70859

Reviewed by Anders Carlsson.

* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
(TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).

(-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
Test that we are getting the correct NSError code and domain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMoving to the start of line should not place the caret outside of the table
rniwa@webkit.org [Tue, 25 Oct 2011 23:17:59 +0000 (23:17 +0000)]
Moving to the start of line should not place the caret outside of the table
https://bugs.webkit.org/show_bug.cgi?id=70757

Reviewed by Chang Shu.

Source/WebCore:

The bug was caused by positionAvoidingFirstPositionInTable. Get rid of the function.

Test: editing/selection/table-lineboundary.html

* editing/visible_units.cpp:
(WebCore::startPositionForLine):

LayoutTests:

Added a test to move the caret to lineboundaries in the first and the last table cell.
The caret should remain inside a table cell.

* editing/selection/table-lineboundary-expected.txt: Added.
* editing/selection/table-lineboundary.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJS Test Harness: Make successfullyParsed optional
arv@chromium.org [Tue, 25 Oct 2011 23:10:43 +0000 (23:10 +0000)]
JS Test Harness: Make successfullyParsed optional
https://bugs.webkit.org/show_bug.cgi?id=70784

Reviewed by Ojan Vafai.

Tools:

* Scripts/make-new-script-test:
(writeTestFile): Update the template for script tests.

LayoutTests:

This makes "successfullyParsed = true" optional in favor of tracking syntax errors
using window.onerror.

* fast/*: Remove successfullyParsed.
* fast/dom/Window/new-window-opener.html: Cleanup.
* fast/dom/Window/resources/window-appendages-cleared-results.html:
* fast/dom/Window/webkitConvertPoint.html: Ditto.
* fast/dom/Window/webkitConvertPointUpdateLayout.html: Ditto.
* fast/js/kde/evil-n.html: This is now a normal test since it is not supposed to fail.
* fast/js/kde/garbage-n-expected.txt:
* fast/js/kde/garbage-n.html: Use shouldHaveHadError instead of js-test-post-n.js
* fast/js/kde/string-1-n.html: Ditto.
* fast/js/kde/string-2-n.html: Ditto.
* fast/js/resources/js-test-post-async.js: Ensure we didn't get an error.
* fast/js/resources/js-test-post-function.js: Ditto.
* fast/js/resources/js-test-post-n.js: Removed.
* fast/js/resources/js-test-pre.js: Added shouldHaveHadError function that can be used to assert that the
                                    error message is what was expected.
                                    Ensure we didn't get an error in finistJSTest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=70852
bdakin@apple.com [Tue, 25 Oct 2011 23:10:12 +0000 (23:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=70852
Setting up a HiDPI base-level GraphicsContext should be more straightforward for
WebKit2

Reviewed by Dan Bernstein.

Source/WebCore:

This patch removes the old cg-only GraphicsContext::setBaseCTM() api, and adds
platform-independent GraphicsContext::applyDeviceScaleFactor().
* WebCore.exp.in:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
(WebCore::GraphicsContext::applyDeviceScaleFactor):
* platform/graphics/GraphicsContext.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):

Since this patch removes GraphicsContext::setBaseCTM(), this code has been
reverted to do what it used to do before that was added; it just calls into
WebCoreSystemInterface directly.
* platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):

Source/WebKit2:

When we need a base-level HiDPI GraphicsContext, call into new GraphicsContext api
GraphicsContext::applyDeviceScaleFactor() rather than manually scaling and
adjusting the base CTM.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSeparate out function linking & exception check data structures.
barraclough@apple.com [Tue, 25 Oct 2011 23:06:13 +0000 (23:06 +0000)]
Separate out function linking & exception check data structures.
https://bugs.webkit.org/show_bug.cgi?id=70858

Reviewed by Oliver Hunt.

This will make it easier to refactor the callOperation methods to spilt the value
representation specific handling from the cpu/calling-convention implementation.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::appendCallWithExceptionCheck):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::CallLinkRecord::CallLinkRecord):
(JSC::DFG::CallExceptionRecord::CallExceptionRecord):
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::appendCall):
(JSC::DFG::JITCompiler::addExceptionCheck):
(JSC::DFG::JITCompiler::addFastExceptionCheck):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore gardening.
jchaffraix@webkit.org [Tue, 25 Oct 2011 23:02:53 +0000 (23:02 +0000)]
More gardening.

* platform/chromium/test_expectations.txt: Missed some cases where
video-porter.html times out. Also added zoom-animator-scale-test2.html
that has been timing out for several days.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Plug-ins have to use JavaScript to find out the current device scale...
andersca@apple.com [Tue, 25 Oct 2011 23:00:37 +0000 (23:00 +0000)]
Source/WebCore: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225

Reviewed by Darin Adler.

Test: platform/mac-wk2/plugins/contents-scale-factor.html

Add NPNVcontentsScaleFactor, as per https://wiki.mozilla.org/NPAPI:ContentsScaleFactor.

* plugins/npapi.h:

Source/WebKit2: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize m_contentsScaleFactor.

* PluginProcess/PluginControllerProxy.h:
Add contentsScaleFactor member function and m_contentsScaleFactor member variable.

* PluginProcess/PluginCreationParameters.cpp:
(WebKit::PluginCreationParameters::PluginCreationParameters):
(WebKit::PluginCreationParameters::encode):
(WebKit::PluginCreationParameters::decode):
* PluginProcess/PluginCreationParameters.h:
Add contentsScaleFactor to the creation parameters.

* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::contentsScaleFactor):
Return the cached m_contentsScaleFactor.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Handle getting the scale factor by calling NetscapePlugin::contentsScaleFactor.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::contentsScaleFactor):
Ask the plug-in controller for the contents scale factor.

* WebProcess/Plugins/PluginController.h:
Add contentsScaleFactor pure virtual member function.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
Set contentsScaleFactor in the creation parameters.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::contentsScaleFactor):
Get the device scale factor from the page.

* WebProcess/Plugins/PluginView.h:
Add contentsScaleFactor().

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setDeviceScaleFactor):
Bail if the scale factor didn't change.

Tools: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

Add a plug-in test for getting the contents scale factor.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp: Added.
(ContentsScaleFactor::ContentsScaleFactor):
(ContentsScaleFactor::contentsScaleFactor):
(ContentsScaleFactor::ScriptableObject::hasProperty):
(ContentsScaleFactor::ScriptableObject::getProperty):
(ContentsScaleFactor::ScriptableObject::pluginTest):
(ContentsScaleFactor::NPP_GetValue):

LayoutTests: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

Add tests.

* platform/mac-wk2/plugins/contents-scale-factor-expected.txt: Added.
* platform/mac-wk2/plugins/contents-scale-factor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98403 268f45cc-cd09-0410-ab3c-d52691b4dbfc