WebKit-https.git
11 years ago2009-01-13 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 14 Jan 2009 00:15:36 +0000 (00:15 +0000)]
2009-01-13  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Fix for: https://bugs.webkit.org/show_bug.cgi?id=23292

        Implementation of two argument canDoFastAdditiveOperations does not correlate well with reality.

        * runtime/JSImmediate.h:
        (JSC::JSFastMath::canDoFastAdditiveOperations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Implemented https://bugs.webkit.org/show_bug.cgi?id=23298
cmarrin@apple.com [Tue, 13 Jan 2009 22:47:14 +0000 (22:47 +0000)]
    Implemented https://bugs.webkit.org/show_bug.cgi?id=23298
        Simple fix to convertToLength to catch style==null cases

        * css/CSSStyleSelector.cpp:
        (WebCore::convertToLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKitTools:
andersca@apple.com [Tue, 13 Jan 2009 22:36:59 +0000 (22:36 +0000)]
WebKitTools:

2009-01-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add NPRuntime test.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
        (testNPRuntime):
        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
        (NPP_New):
        (NPP_GetValue):

LayoutTests:

2009-01-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add NPRuntime test.

        * plugins/npruntime-expected.txt: Added.
        * plugins/npruntime.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Mark Rowe.
eric@webkit.org [Tue, 13 Jan 2009 21:15:26 +0000 (21:15 +0000)]
    Reviewed by Mark Rowe.

        Speculative fix for an Uninitialized Memory Read (UMR)
        seen by purify in chormium's equivalent V8 file.

        * bindings/js/JSSVGPODTypeWrapper.h:
        (WebCore::PODTypeWrapperCacheInfo::PODTypeWrapperCacheInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 13 Jan 2009 20:55:04 +0000 (20:55 +0000)]
2009-01-13  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Land portions of platform/graphics/chromium.
        https://bugs.webkit.org/show_bug.cgi?id=23297

        * platform/graphics/chromium/FontCustomPlatformData.cpp: Added.
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        (WebCore::FontCustomPlatformData::fontPlatformData):
        (WebCore::EOTStream::EOTStream):
        (WebCore::EOTStream::read):
        (WebCore::readEmbedProc):
        (WebCore::createUniqueFontName):
        (WebCore::createFontCustomPlatformData):
        * platform/graphics/chromium/FontCustomPlatformData.h: Added.
        (WebCore::FontCustomPlatformData::FontCustomPlatformData):
        * platform/graphics/chromium/FontLinux.cpp: Added.
        (WebCore::Font::drawGlyphs):
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/chromium/FontPlatformData.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-08 Yongjun Zhang <yongjun.zhang@nokia.com>
hausmann@webkit.org [Tue, 13 Jan 2009 20:44:07 +0000 (20:44 +0000)]
2009-01-08  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=23187

        Update webview with the intersected rect.

        In ChromeClientQt::repaint, view should be updated with the
        intersected rect, not the whole windowRect;

        This generally is not a problem for normal viewport setup where
        viewport size is the same as the qwebview widget size.  However, if we
        set the viewport size smaller than qwebkit widget, we will see
        unwanted painting outside the viewport.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Tue, 13 Jan 2009 20:43:03 +0000 (20:43 +0000)]
2009-01-13  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Tor Arne Vestbø.

        [Qt] Missing piece from my previous commit:
        Disable and enable the cursor navigation actions when contentEditable
        is changed.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::updateEditorActions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDon't copy DOMStringList.idl into the framework bundle.
mrowe@apple.com [Tue, 13 Jan 2009 20:24:13 +0000 (20:24 +0000)]
Don't copy DOMStringList.idl into the framework bundle.

Rubber-stamped by Oliver Hunt.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=23290
mrowe@apple.com [Tue, 13 Jan 2009 20:07:09 +0000 (20:07 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=23290
Fix JSImmediate::isImmediate(src) to !src->isCell()

Reviewed by Darin Adler.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Tue, 13 Jan 2009 20:07:00 +0000 (20:07 +0000)]
2009-01-13  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Create actions for cursor navigation for QWebPage.
        Also properly disable and enable them when contentEditable is toggled.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::updateAction):
        (QWebPage::action):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 13 Jan 2009 19:26:02 +0000 (19:26 +0000)]
2009-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Add a bunch of methods to WebKitPluginClient.defs, and implement them.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::fromUTF8WithLatin1Fallback):
        If the length isn't specified, get it by calling strlen.

        (WKPCEvaluate):
        Evaluate doesn't take any arguments.

        (WKPCGetIntIdentifier):
        Call _NPN_GetIntIdentifier.

        (identifierFromServerIdentifier):
        New helper function that returns a JSC Identifier from an NPIdentifier.

        (WKPCInvoke):
        Call identifierFromServerIdentifier.

        (WKPCRemoveProperty):
        (WKPCHasProperty):
        (WKPCHasMethod):
        Call NetscapePluginInstanceProxy.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::removeProperty):
        (WebKit::NetscapePluginInstanceProxy::hasProperty):
        (WebKit::NetscapePluginInstanceProxy::hasMethod):

        * Plugins/Hosted/WebKitPluginClient.defs:
        Add new definitions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-13 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Tue, 13 Jan 2009 19:25:18 +0000 (19:25 +0000)]
2009-01-13  Christian Dywan  <christian@twotoasts.de>

        Build fix, StorageEvent is only defined if we have DOM_STORAGE

        * dom/Document.cpp:
        (WebCore::Document::createEvent): Conditionalize StorageEvent

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 13 Jan 2009 19:17:51 +0000 (19:17 +0000)]
2009-01-13  Anders Carlsson  <andersca@apple.com>

        Fix build.

        * WebView/WebView.mm:
        (-[WebView _initWithArguments:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-13 Dmitry Titov <dimich@chromium.org>
dglazkov@chromium.org [Tue, 13 Jan 2009 19:13:50 +0000 (19:13 +0000)]
2009-01-13  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23281
        Fix the Chromium Win build.
        Need to use PLATFORM(WIN_OS) instead of PLATFORM(WIN).
        Moved GTK and WX up in #if sequence because they could come with WIN_OS too,
        while they have their own implementation even on Windows.

        * wtf/CurrentTime.cpp:
        (WTF::currentTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Adds a workaround for the flip4mac installer plugin decoding a WebView from...
timothy@apple.com [Tue, 13 Jan 2009 18:12:18 +0000 (18:12 +0000)]
    Adds a workaround for the flip4mac installer plugin decoding a WebView from a NIB on a secondary thread.

        <rdar://problem/6489788> New WebKit thread checks break installation of flip4mac (thread violation)

        Reviewed by Darin Adler.

        * Misc/WebKitVersionChecks.h: Add WEBKIT_FIRST_VERSION_WITHOUT_WEBVIEW_INIT_THREAD_WORKAROUND.
        * Misc/WebNSObjectExtras.h: Add _webkit_performSelectorOnMainThread:withObject:.
        * Misc/WebNSObjectExtras.mm:
        (-[NSObject _webkit_performSelectorWithArguments:]): Renamed from _webkit_getPropertyWithArguments.
        Passes the optional object to the selector.
        (-[NSObject _webkit_performSelectorOnMainThread:withObject:]): Renamed from _webkit_getPropertyOnMainThread:.
        Put the optional object into the arguments dictionary.
        (-[NSObject _webkit_getPropertyOnMainThread:]): Call _webkit_performSelectorOnMainThread with a nil object.
        * WebView/WebResource.mm:
        (-[WebResource _ignoreWhenUnarchiving]): Use _cmd instead of making the selector again.
        (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): Use the new
        _webkit_performSelectorOnMainThread:withObject: method instead of performSelectorOnMainThread.
        * WebView/WebView.mm:
        (-[WebView _initWithArguments:]): Added. Pulls arguments out of the dictionary and calls the right init method.
        (needsWebViewInitThreadWorkaround): Checks if the thead is not the main thread and if we are in the Installer bundle.
        (-[WebView initWithFrame:frameName:groupName:]): Call needsWebViewInitThreadWorkaround and use _webkit_performSelectorOnMainThread
        to call _initWithArguments: passing the frame, frameName and groupName.
        (-[WebView initWithCoder:]): Ditto, except pass the coder to _initWithArguments:.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-13 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 13 Jan 2009 17:59:47 +0000 (17:59 +0000)]
2009-01-13  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        Bug 23277: space bar scrolls the page when typed in any text field
        https://bugs.webkit.org/show_bug.cgi?id=23277
        rdar://problem/6490249

        There's already a regression test for this, since bug 16421 was the same problem, but on
        Mac. The regression test is fast/events/space-scroll-event.html, so I won't write a new one.

        This bug doesn't affect Mac because the canEdit check in -[WebHTMLView insertText:] prevents
        a text input event from being generated at all. That difference may in itself be a bug, but
        the only symptom is that you get text input events in more cases on platforms other than Mac.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleTextInputEvent): Return whether the event's default was
        handled, not the result of the dispatchEvent function, which indicates only whether the
        default behavior was prevented, not if the default behavior did some insertion. This fix
        makes it so the keyboard event handler can detect that no space was inserted and know that
        the space bar keypress event can be treated as a scrolling command.
        (WebCore::EventHandler::defaultKeyboardEventHandler): Handle the keypress event, not the
        keydown event. Without the change above, making this change would have restored the old
        behavior, reintroducing bug 22913 where the space bar doesn't scroll at all on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-13 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Tue, 13 Jan 2009 17:58:57 +0000 (17:58 +0000)]
2009-01-13  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        https://bugs.webkit.org/show_bug.cgi?id=23171

        Based on patch by Yael Aharon  <yael.aharon@nokia.com>

        Make the QWebSettings functions for setting the path for the local
        storage database private QtWebkit API, including the ability to
        associated a QWebPage with a named page group.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Tue, 13 Jan 2009 17:24:02 +0000 (17:24 +0000)]
2009-01-13  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon Hausmann.

        [Qt] Make sure media elements dispatch the 'loaded' event

        We assume that when Phonon goes into paused state that we have the
        complete media file. Once we do media loading ourselves we can
        distinguish between loading the first frame and the complete media.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-13 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 13 Jan 2009 16:48:29 +0000 (16:48 +0000)]
2009-01-13  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        Landing portions of platform/chromium/, taken from here:
        http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/

        * platform/chromium/ChromiumBridge.h: Added.
        * platform/chromium/ChromiumDataObject.cpp: Added.
        (WebCore::ChromiumDataObject::clear):
        (WebCore::ChromiumDataObject::hasData):
        * platform/chromium/ChromiumDataObject.h: Added.
        (WebCore::ChromiumDataObject::create):
        (WebCore::ChromiumDataObject::ChromiumDataObject):
        * platform/chromium/ClipboardChromium.cpp: Added.
        (WebCore::):
        (WebCore::clipboardTypeFromMIMEType):
        (WebCore::ClipboardChromium::ClipboardChromium):
        (WebCore::ClipboardChromium::create):
        (WebCore::ClipboardChromium::clearData):
        (WebCore::ClipboardChromium::clearAllData):
        (WebCore::ClipboardChromium::getData):
        (WebCore::ClipboardChromium::setData):
        (WebCore::ClipboardChromium::types):
        (WebCore::ClipboardChromium::setDragImage):
        (WebCore::ClipboardChromium::setDragImageElement):
        (WebCore::ClipboardChromium::createDragImage):
        (WebCore::imageToMarkup):
        (WebCore::getCachedImage):
        (WebCore::writeImageToDataObject):
        (WebCore::ClipboardChromium::declareAndWriteDragImage):
        (WebCore::ClipboardChromium::writeURL):
        (WebCore::ClipboardChromium::writeRange):
        (WebCore::ClipboardChromium::hasData):
        * platform/chromium/ClipboardChromium.h: Added.
        (WebCore::ClipboardChromium::~ClipboardChromium):
        (WebCore::ClipboardChromium::dataObject):
        * platform/chromium/ClipboardUtilitiesChromium.cpp: Added.
        (WebCore::replaceNewlinesWithWindowsStyleNewlines):
        (WebCore::replaceNBSPWithSpace):
        (WebCore::urlToMarkup):
        * platform/chromium/ClipboardUtilitiesChromium.h: Added.
        * platform/chromium/ContextMenuChromium.cpp: Added.
        (WebCore::ContextMenu::ContextMenu):
        (WebCore::ContextMenu::~ContextMenu):
        (WebCore::ContextMenu::itemCount):
        (WebCore::ContextMenu::insertItem):
        (WebCore::ContextMenu::appendItem):
        (WebCore::ContextMenu::itemWithAction):
        (WebCore::ContextMenu::itemAtIndex):
        (WebCore::ContextMenu::setPlatformDescription):
        (WebCore::ContextMenu::platformDescription):
        (WebCore::ContextMenu::releasePlatformDescription):
        * platform/chromium/ContextMenuItemChromium.cpp: Added.
        (WebCore::ContextMenuItem::ContextMenuItem):
        (WebCore::ContextMenuItem::~ContextMenuItem):
        (WebCore::ContextMenuItem::releasePlatformDescription):
        (WebCore::ContextMenuItem::type):
        (WebCore::ContextMenuItem::action):
        (WebCore::ContextMenuItem::title):
        (WebCore::ContextMenuItem::platformSubMenu):
        (WebCore::ContextMenuItem::setType):
        (WebCore::ContextMenuItem::setAction):
        (WebCore::ContextMenuItem::setTitle):
        (WebCore::ContextMenuItem::setSubMenu):
        (WebCore::ContextMenuItem::setChecked):
        (WebCore::ContextMenuItem::setEnabled):
        (WebCore::ContextMenuItem::enabled):
        * platform/chromium/CursorChromium.cpp: Added.
        (WebCore::Cursor::Cursor):
        (WebCore::Cursor::~Cursor):
        (WebCore::Cursor::operator=):
        (WebCore::pointerCursor):
        (WebCore::crossCursor):
        (WebCore::handCursor):
        (WebCore::iBeamCursor):
        (WebCore::waitCursor):
        (WebCore::helpCursor):
        (WebCore::eastResizeCursor):
        (WebCore::northResizeCursor):
        (WebCore::northEastResizeCursor):
        (WebCore::northWestResizeCursor):
        (WebCore::southResizeCursor):
        (WebCore::southEastResizeCursor):
        (WebCore::southWestResizeCursor):
        (WebCore::westResizeCursor):
        (WebCore::northSouthResizeCursor):
        (WebCore::eastWestResizeCursor):
        (WebCore::northEastSouthWestResizeCursor):
        (WebCore::northWestSouthEastResizeCursor):
        (WebCore::columnResizeCursor):
        (WebCore::rowResizeCursor):
        (WebCore::middlePanningCursor):
        (WebCore::eastPanningCursor):
        (WebCore::northPanningCursor):
        (WebCore::northEastPanningCursor):
        (WebCore::northWestPanningCursor):
        (WebCore::southPanningCursor):
        (WebCore::southEastPanningCursor):
        (WebCore::southWestPanningCursor):
        (WebCore::westPanningCursor):
        (WebCore::moveCursor):
        (WebCore::verticalTextCursor):
        (WebCore::cellCursor):
        (WebCore::contextMenuCursor):
        (WebCore::aliasCursor):
        (WebCore::progressCursor):
        (WebCore::noDropCursor):
        (WebCore::copyCursor):
        (WebCore::noneCursor):
        (WebCore::notAllowedCursor):
        (WebCore::zoomInCursor):
        (WebCore::zoomOutCursor):
        (WebCore::grabCursor):
        (WebCore::grabbingCursor):
        * platform/chromium/DragDataChromium.cpp: Added.
        (WebCore::containsHTML):
        (WebCore::DragData::createClipboard):
        (WebCore::DragData::containsURL):
        (WebCore::DragData::asURL):
        (WebCore::DragData::containsFiles):
        (WebCore::DragData::asFilenames):
        (WebCore::DragData::containsPlainText):
        (WebCore::DragData::asPlainText):
        (WebCore::DragData::containsColor):
        (WebCore::DragData::canSmartReplace):
        (WebCore::DragData::containsCompatibleContent):
        (WebCore::DragData::asFragment):
        (WebCore::DragData::asColor):
        * platform/chromium/EditorChromium.cpp: Added.
        (WebCore::Editor::newGeneralClipboard):
        * platform/chromium/FileChooserChromium.cpp: Added.
        (WebCore::FileChooser::basenameForWidth):
        * platform/chromium/FileSystemChromium.cpp: Added.
        (WebCore::deleteFile):
        (WebCore::deleteEmptyDirectory):
        (WebCore::getFileSize):
        (WebCore::getFileModificationTime):
        (WebCore::directoryName):
        (WebCore::pathByAppendingComponent):
        (WebCore::makeAllDirectories):
        (WebCore::fileExists):
        * platform/chromium/FileSystemChromiumLinux.cpp: Added.
        (WebCore::pathGetFileName):
        * platform/chromium/FileSystemChromiumMac.mm: Added.
        (WebCore::pathGetFileName):
        * platform/chromium/FileSystemChromiumWin.cpp: Added.
        (WebCore::pathGetFileName):
        * platform/chromium/FramelessScrollView.cpp: Added.
        (WebCore::FramelessScrollView::~FramelessScrollView):
        (WebCore::FramelessScrollView::invalidateScrollbarRect):
        (WebCore::FramelessScrollView::isActive):
        (WebCore::FramelessScrollView::invalidateRect):
        (WebCore::FramelessScrollView::hostWindow):
        (WebCore::FramelessScrollView::windowClipRect):
        (WebCore::FramelessScrollView::paintContents):
        (WebCore::FramelessScrollView::contentsResized):
        (WebCore::FramelessScrollView::visibleContentsResized):
        * platform/chromium/FramelessScrollView.h: Added.
        (WebCore::FramelessScrollView::FramelessScrollView):
        (WebCore::FramelessScrollView::client):
        (WebCore::FramelessScrollView::setClient):
        * platform/chromium/FramelessScrollViewClient.h: Added.
        * platform/chromium/ScrollbarThemeChromiumWin.cpp: Added.
        (WebCore::):
        (WebCore::ScrollbarThemeChromium::scrollbarThickness):
        (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit):
        (WebCore::ScrollbarThemeChromium::paintTrackPiece):
        (WebCore::ScrollbarThemeChromium::paintButton):
        (WebCore::ScrollbarThemeChromium::paintThumb):
        (WebCore::ScrollbarThemeChromium::getThemeState):
        (WebCore::ScrollbarThemeChromium::getThemeArrowState):
        (WebCore::ScrollbarThemeChromium::getClassicThemeState):
        * platform/chromium/SoundChromiumPosix.cpp: Added.
        (WebCore::systemBeep):
        * platform/chromium/SoundChromiumWin.cpp: Added.
        (WebCore::systemBeep):
        * platform/chromium/SystemTimeChromium.cpp: Added.
        (WebCore::currentTime):
        (WebCore::userIdleTime):
        * platform/chromium/WidgetChromium.cpp: Added.
        (WebCore::Widget::Widget):
        (WebCore::Widget::~Widget):
        (WebCore::Widget::show):
        (WebCore::Widget::hide):
        (WebCore::Widget::setCursor):
        (WebCore::Widget::paint):
        (WebCore::Widget::setFocus):
        (WebCore::Widget::setIsSelected):
        (WebCore::Widget::frameRect):
        (WebCore::Widget::setFrameRect):
        * platform/chromium/WindowsVersion.cpp: Added.
        (WebCore::isVistaOrNewer):
        * platform/chromium/WindowsVersion.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Tue, 13 Jan 2009 16:38:54 +0000 (16:38 +0000)]
2009-01-13  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon Hausmann.

        [Qt] Add more verbose error output when loading NPAPI plugins

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-13 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Tue, 13 Jan 2009 16:17:32 +0000 (16:17 +0000)]
2009-01-13  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Fix crash in the Qt port when deleting a popup from within a
        JavaScript onchange handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[GIO] Make sure to untef the GFile and the GInputStream on destruction
zecke@webkit.org [Tue, 13 Jan 2009 14:58:28 +0000 (14:58 +0000)]
[GIO] Make sure to untef the GFile and the GInputStream on destruction

Make sure to call cleanupGioOperation from the ResourceHandleInternal
d'tor. Change the signature of cleanupGioOperation so we can do the
cleanup of GIO next to the cleanup of SOUP.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[GIO] Attach the ResourceHandle to the GObject and get it from the GObject
zecke@webkit.org [Tue, 13 Jan 2009 14:58:15 +0000 (14:58 +0000)]
[GIO] Attach the ResourceHandle to the GObject and get it from the GObject

https://bugs.webkit.org/show_bug.cgi?id=23116 discussed with Benjamin Otte

Sometimes it is not possible to cancel a pending GIO operation and the
callback might be invoked with a pointer to an already destructed
ResourceHandle. To avoid this issue we will attach the ResourceHandle
to the GObject* and in the callback attempt to get the ResourceHandle
from the GObject*. If no ResourceHandle is attached we silently fail
as the cleanup has been already done.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[GIO] Invoke cleanupGioOperation before calling didFail to avoid crashes
zecke@webkit.org [Tue, 13 Jan 2009 14:58:02 +0000 (14:58 +0000)]
[GIO] Invoke cleanupGioOperation before calling didFail to avoid crashes

https://bugs.webkit.org/show_bug.cgi?id=23116

The ResourceHandle becomes invalid (e.g. got destructed) from within
the invocation of didFail. Avoid this by cleaning up everything before
calling didFail and simply return afterwards.

This is happening with many tests from dom/html/level2/html e.g.
LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-13 Alexander V. Butenko <alex@digiqube.com>
zecke@webkit.org [Tue, 13 Jan 2009 14:57:47 +0000 (14:57 +0000)]
2009-01-13  Alexander V. Butenko  <alex@digiqube.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=23279

        Fix crash on WebView dispose stage.

        Add null checks to webkit_web_view_set_scroll_adjustments  and
        webkit_web_view_get_accessible as they get called from within
        the dispose.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Tue, 13 Jan 2009 14:51:41 +0000 (14:51 +0000)]
2009-01-13  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon Hausmann.

        Change how themes adjust mediaControls.css to match html4/quicks.css

        Instead of providing the full style sheet, the themes provide extra
        overrides to the default style defined in UserAgentStyleSheetsData.

        https://bugs.webkit.org/show_bug.cgi?id=23210

        Also, merge WebKitResources.qrc and WebCoreResources.qrc to speed up
        build time for the Qt port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix.
sfalken@apple.com [Tue, 13 Jan 2009 08:11:36 +0000 (08:11 +0000)]
    Build fix.

        * WebScriptCallFrame.cpp:
        (WebScriptCallFrame::jsValueToString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUse the modern spelling of WebKit.
mrowe@apple.com [Tue, 13 Jan 2009 07:54:27 +0000 (07:54 +0000)]
Use the modern spelling of WebKit.

* Scripts/find-extra-includes:
* Scripts/report-include-statistics:
* Scripts/run-webkit-app:
* Scripts/svn-unapply:
* Scripts/update-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
barraclough@apple.com [Tue, 13 Jan 2009 04:51:16 +0000 (04:51 +0000)]
JavaScriptCore:

2009-01-12  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Make the JSImmediate interface private.

        All manipulation of JS values should be through the JSValuePtr class, not by using JSImmediate
        directly.  The key missing methods on JSValuePtr are:

            * isCell() - check for values that are JSCell*s, and as such where asCell() may be used.
            * isInt32Fast() getInt32Fast() - fast check/access for integer immediates.
            * isUInt32Fast() getUInt32Fast() - ditto for unsigned integer immediates.

        The JIT is allowed full access to JSImmediate, since it needs to be able to directly
        manipulate JSValuePtrs.  The Interpreter is provided access to perform operations directly
        on JSValuePtrs through the new JSFastMath interface.

        No performance impact.

        * API/JSCallbackObjectFunctions.h:
        (JSC::::toNumber):
        * API/JSValueRef.cpp:
        (JSValueIsEqual):
        (JSValueIsStrictEqual):
        * JavaScriptCore.exp:
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::isKnownNotImmediate):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::keyForImmediateSwitch):
        * bytecompiler/BytecodeGenerator.h:
        (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue):
        (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
        * interpreter/Interpreter.cpp:
        (JSC::jsLess):
        (JSC::jsLessEq):
        (JSC::jsAdd):
        (JSC::jsIsObjectType):
        (JSC::cachePrototypeChain):
        (JSC::Interpreter::tryCachePutByID):
        (JSC::Interpreter::tryCacheGetByID):
        (JSC::Interpreter::privateExecute):
        (JSC::Interpreter::tryCTICachePutByID):
        (JSC::Interpreter::tryCTICacheGetByID):
        (JSC::Interpreter::cti_op_add):
        (JSC::Interpreter::cti_op_get_by_id_self_fail):
        (JSC::Interpreter::cti_op_get_by_id_proto_list):
        (JSC::Interpreter::cti_op_instanceof):
        (JSC::Interpreter::cti_op_mul):
        (JSC::Interpreter::cti_op_get_by_val):
        (JSC::Interpreter::cti_op_get_by_val_byte_array):
        (JSC::Interpreter::cti_op_sub):
        (JSC::Interpreter::cti_op_put_by_val):
        (JSC::Interpreter::cti_op_put_by_val_array):
        (JSC::Interpreter::cti_op_put_by_val_byte_array):
        (JSC::Interpreter::cti_op_negate):
        (JSC::Interpreter::cti_op_div):
        (JSC::Interpreter::cti_op_eq):
        (JSC::Interpreter::cti_op_lshift):
        (JSC::Interpreter::cti_op_bitand):
        (JSC::Interpreter::cti_op_rshift):
        (JSC::Interpreter::cti_op_bitnot):
        (JSC::Interpreter::cti_op_neq):
        (JSC::Interpreter::cti_op_urshift):
        (JSC::Interpreter::cti_op_call_eval):
        (JSC::Interpreter::cti_op_throw):
        (JSC::Interpreter::cti_op_is_undefined):
        (JSC::Interpreter::cti_op_stricteq):
        (JSC::Interpreter::cti_op_nstricteq):
        (JSC::Interpreter::cti_op_switch_imm):
        (JSC::Interpreter::cti_vm_throw):
        * interpreter/Interpreter.h:
        (JSC::Interpreter::isJSArray):
        (JSC::Interpreter::isJSString):
        (JSC::Interpreter::isJSByteArray):
        * jit/JIT.cpp:
        (JSC::JIT::compileOpStrictEq):
        (JSC::JIT::privateCompileMainPass):
        * jit/JIT.h:
        (JSC::JIT::isStrictEqCaseHandledInJITCode):
        * jit/JITArithmetic.cpp:
        (JSC::JIT::compileFastArith_op_rshift):
        (JSC::JIT::compileFastArith_op_bitand):
        (JSC::JIT::compileFastArith_op_mod):
        * jit/JITCall.cpp:
        (JSC::JIT::unlinkCall):
        (JSC::JIT::compileOpCall):
        * jit/JITInlineMethods.h:
        (JSC::JIT::getConstantOperandImmediateInt):
        (JSC::JIT::isOperandConstantImmediateInt):
        * parser/Nodes.cpp:
        (JSC::processClauseList):
        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncIndexOf):
        (JSC::arrayProtoFuncLastIndexOf):
        * runtime/BooleanPrototype.cpp:
        (JSC::booleanProtoFuncValueOf):
        * runtime/Collector.cpp:
        (JSC::Heap::protect):
        (JSC::Heap::unprotect):
        (JSC::Heap::heap):
        * runtime/JSByteArray.cpp:
        (JSC::JSByteArray::getOwnPropertySlot):
        * runtime/JSByteArray.h:
        (JSC::JSByteArray::getIndex):
        * runtime/JSCell.cpp:
        * runtime/JSCell.h:
        (JSC::JSValuePtr::isNumberCell):
        (JSC::JSValuePtr::asCell):
        (JSC::JSValuePtr::isNumber):
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncParseInt):
        * runtime/JSImmediate.h:
        (JSC::js0):
        (JSC::jsImpossibleValue):
        (JSC::JSValuePtr::toInt32):
        (JSC::JSValuePtr::toUInt32):
        (JSC::JSValuePtr::isCell):
        (JSC::JSValuePtr::isInt32Fast):
        (JSC::JSValuePtr::getInt32Fast):
        (JSC::JSValuePtr::isUInt32Fast):
        (JSC::JSValuePtr::getUInt32Fast):
        (JSC::JSValuePtr::makeInt32Fast):
        (JSC::JSValuePtr::areBothInt32Fast):
        (JSC::JSFastMath::canDoFastBitwiseOperations):
        (JSC::JSFastMath::equal):
        (JSC::JSFastMath::notEqual):
        (JSC::JSFastMath::andImmediateNumbers):
        (JSC::JSFastMath::xorImmediateNumbers):
        (JSC::JSFastMath::orImmediateNumbers):
        (JSC::JSFastMath::canDoFastRshift):
        (JSC::JSFastMath::canDoFastUrshift):
        (JSC::JSFastMath::rightShiftImmediateNumbers):
        (JSC::JSFastMath::canDoFastAdditiveOperations):
        (JSC::JSFastMath::addImmediateNumbers):
        (JSC::JSFastMath::subImmediateNumbers):
        (JSC::JSFastMath::incImmediateNumber):
        (JSC::JSFastMath::decImmediateNumber):
        * runtime/JSNumberCell.h:
        (JSC::JSValuePtr::asNumberCell):
        (JSC::jsNumber):
        (JSC::JSValuePtr::uncheckedGetNumber):
        (JSC::JSNumberCell::toInt32):
        (JSC::JSNumberCell::toUInt32):
        (JSC::JSValuePtr::toJSNumber):
        (JSC::JSValuePtr::getNumber):
        (JSC::JSValuePtr::numberToInt32):
        (JSC::JSValuePtr::numberToUInt32):
        * runtime/JSObject.h:
        (JSC::JSValuePtr::isObject):
        (JSC::JSValuePtr::get):
        (JSC::JSValuePtr::put):
        * runtime/JSValue.cpp:
        (JSC::JSValuePtr::toInteger):
        (JSC::JSValuePtr::toIntegerPreserveNaN):
        * runtime/JSValue.h:
        * runtime/Operations.cpp:
        (JSC::JSValuePtr::equalSlowCase):
        (JSC::JSValuePtr::strictEqualSlowCase):
        * runtime/Operations.h:
        (JSC::JSValuePtr::equal):
        (JSC::JSValuePtr::equalSlowCaseInline):
        (JSC::JSValuePtr::strictEqual):
        (JSC::JSValuePtr::strictEqualSlowCaseInline):
        * runtime/Protect.h:
        (JSC::gcProtect):
        (JSC::gcUnprotect):
        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncCharAt):
        (JSC::stringProtoFuncCharCodeAt):
        * runtime/Structure.cpp:
        (JSC::Structure::createCachedPrototypeChain):

WebCore:

2009-01-12  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Deprecate JSValuePtr::getNumber() - two ways to get a number should  be enough.

        * bindings/js/JSSQLTransactionCustom.cpp:
        (WebCore::JSSQLTransaction::executeSql):
        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):

WebKit/mac:

2009-01-12  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Deprecate JSValuePtr::getNumber() - two ways to get a number should  be enough.

        * WebView/WebView.mm:
        (aeDescFromJSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 13 Jan 2009 02:33:30 +0000 (02:33 +0000)]
2009-01-12  Brady Eidson  <beidson@apple.com>

        Reviewed by NOBODY (OOPS!).

        <rdar://problem/6490446> - Crash when going back to a cached page

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::savePlatformDataToCachedPage):  ENABLE(CFNETWORK) needed to be USE(CFNETWORK)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fixed https://bugs.webkit.org/show_bug.cgi?id=22919
cmarrin@apple.com [Tue, 13 Jan 2009 01:09:42 +0000 (01:09 +0000)]
    Fixed https://bugs.webkit.org/show_bug.cgi?id=22919

        I added a common getElapsedTime() function to AnimationBase which uses a combination of
        the techniques from KeyframeAnimation and AnimationBase to compute elapsedTime in all
        states.

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::progress):
        (WebCore::AnimationBase::getElapsedTime):
        * page/animation/AnimationBase.h:
        * page/animation/KeyframeAnimation.cpp:
        (WebCore::KeyframeAnimation::animate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCorrect scrolldelay units (s -> ms)
bfulgham@webkit.org [Tue, 13 Jan 2009 00:22:54 +0000 (00:22 +0000)]
Correct scrolldelay units (s -> ms)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 13 Jan 2009 00:20:10 +0000 (00:20 +0000)]
2009-01-12  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=23273

        In RenderBox::repaintLayerRectsForImage(), the repaint rect does not have
        to be computed in absolute coordintes. Instead, we compute a repaintRect
        relative to the RenderObject, which can repaint itself.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::repaintLayerRectsForImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 13 Jan 2009 00:15:41 +0000 (00:15 +0000)]
2009-01-12  David Hyatt  <hyatt@apple.com>

        Apply the same idea as the previous fix but for matched declarations.

        Reviewed by Dan Bernstein

        * css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
beidson@apple.com [Tue, 13 Jan 2009 00:15:14 +0000 (00:15 +0000)]
WebCore:

2009-01-12  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/6468274> - Track Non-get requests in global history

        * WebCore.base.exp:

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::HistoryItem):
        * history/HistoryItem.h:
        (WebCore::HistoryItem::lastVisitWasHTTPNonGet):
        (WebCore::HistoryItem::setLastVisitWasHTTPNonGet):

WebKit/mac:

2009-01-12  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/6468274> - Track Non-get requests in global history

        * History/WebHistory.mm:
        (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
        * History/WebHistoryInternal.h:

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem initFromDictionaryRepresentation:]):
        (-[WebHistoryItem dictionaryRepresentation]):
        (-[WebHistoryItem _lastVisitWasHTTPNonGet]):
        * History/WebHistoryItemPrivate.h:

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::updateGlobalHistory): Only pass the method through if it was an HTTP load

WebKit/win:

2009-01-12  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/6468274> - Track Non-get requests in global history

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::updateGlobalHistory):

        * WebHistory.cpp:
        (WebHistory::addItem):
        * WebHistory.h:

        * Interfaces/IWebHistoryItemPrivate.idl:
        * WebHistoryItem.cpp:
        (WebHistoryItem::initFromDictionaryRepresentation):
        (WebHistoryItem::dictionaryRepresentation):
        (WebHistoryItem::lastVisitWasHTTPNonGet):
        (WebHistoryItem::setLastVisitWasHTTPNonGet):
        * WebHistoryItem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. JSValue* -> JSValuePtr.
kevino@webkit.org [Mon, 12 Jan 2009 23:49:20 +0000 (23:49 +0000)]
wx build fix. JSValue* -> JSValuePtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago!ENABLE(SVG_FONTS) build fix. Move defaultUnitsPerEm into a non-SVG header so it...
kevino@webkit.org [Mon, 12 Jan 2009 23:47:06 +0000 (23:47 +0000)]
!ENABLE(SVG_FONTS) build fix. Move defaultUnitsPerEm into a non-SVG header so it can be used by all builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build typo fix.
kevino@webkit.org [Mon, 12 Jan 2009 23:41:38 +0000 (23:41 +0000)]
wx build typo fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSince platform date time functions have moved to JSC, now the wx port JSC needs to...
kevino@webkit.org [Mon, 12 Jan 2009 23:39:40 +0000 (23:39 +0000)]
Since platform date time functions have moved to JSC, now the wx port JSC needs to depend on wx.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 12 Jan 2009 23:18:49 +0000 (23:18 +0000)]
2009-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Move marshalling into NetscapePluginInstanceProxy.

        Add support for marshallin strings.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEvaluate):
        (WKPCInvoke):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::evaluate):
        (WebKit::NetscapePluginInstanceProxy::invoke):
        (WebKit::NetscapePluginInstanceProxy::marshalValue):
        * Plugins/Hosted/WebKitPluginHostTypes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 12 Jan 2009 23:01:48 +0000 (23:01 +0000)]
2009-01-12  David Hyatt  <hyatt@apple.com>

        Make sure the set of matched rules has a reserved capacity of 32.  This prevents remalloc thrash as
        elements are matched, since the Vector is shrinking and growing over and over.  1% PLT speedup.

        Reviewed by Oliver Hunt

        * css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 12 Jan 2009 22:37:29 +0000 (22:37 +0000)]
2009-01-12  David Hyatt  <hyatt@apple.com>

        Optimize Element::attributeChanged to just check if accessibility is enabled up front before looking at the
        two accessibility-related attributes.  This avoids the rest of the code for all attributes on the PLT.
        Tiny speedup.

        Reviewed by Oliver Hunt

        * dom/Element.cpp:
        (WebCore::Element::attributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 12 Jan 2009 22:34:23 +0000 (22:34 +0000)]
2009-01-12  David Hyatt  <hyatt@apple.com>

        Optimize the retrieval of line height.  If the document is not using any first-line rules, just immediately
        default to the normal case.  Tiny speedup on PLT.

        Reviewed by Oliver Hunt

        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::lineHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 12 Jan 2009 22:25:43 +0000 (22:25 +0000)]
2009-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement WKPCInvoke.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEvaluate):
        (WKPCInvoke):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::idForObject):
        (WebKit::NetscapePluginInstanceProxy::invoke):
        * Plugins/Hosted/WebKitPluginClient.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 12 Jan 2009 22:15:18 +0000 (22:15 +0000)]
2009-01-12  David Hyatt  <hyatt@apple.com>

        Fix 0.6% regression in PLT.  Make sure not to waste time updating NSScrollView's can blit on scroll state
        in the ScrollView constructor, since this is always going to be properly updated by FrameView anyway.

        Reviewed by Oliver Hunt

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::ScrollView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 12 Jan 2009 21:42:25 +0000 (21:42 +0000)]
2009-01-12  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=23220

        Merge layoutDelta into LayoutState. This requires that we
        push even when layoutState is disabled, so that layoutDelta
        can still be stored.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 12 Jan 2009 21:38:19 +0000 (21:38 +0000)]
2009-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Move marshalling code to NetscapePluginInstanceProxy. Add support for marshalling JS objects.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEvaluate):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::marshalValue):
        * Plugins/Hosted/WebKitPluginHostTypes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
jchaffraix@webkit.org [Mon, 12 Jan 2009 21:31:11 +0000 (21:31 +0000)]
2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>

        Reviewed by Holger Freyther.

        [Qt] Build fix after turning the fontCache to a singleton
        https://bugs.webkit.org/show_bug.cgi?id=23253

        Add a stub implementation for WebCore::fontCache() and FontCache::FontCache().

        * platform/graphics/qt/FontCacheQt.cpp:
        (WebCore::fontCache):
        (WebCore::FontCache::FontCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Eric Roman <eroman@chromium.org>
dglazkov@chromium.org [Mon, 12 Jan 2009 21:07:19 +0000 (21:07 +0000)]
2009-01-12  Eric Roman  <eroman@chromium.org>

        Reviewed by Darin Adler.

        Fix some bugs with Selection::appendTrailingWhitespace().
        https://bugs.webkit.org/show_bug.cgi?id=23232

        Test: editing/selection/doubleclick-whitespace-crash.html

        * editing/Selection.cpp:
        (WebCore::makeSearchRange):
        (WebCore::Selection::appendTrailingWhitespace):

2009-01-12  Eric Roman  <eroman@chromium.org>

        Reviewed by Darin Adler.
        https://bugs.webkit.org/show_bug.cgi?id=23232

        * editing/selection/doubleclick-whitespace-crash-expected.txt: Added.
        * editing/selection/doubleclick-whitespace-crash.html: Added.
        * editing/selection/doubleclick-whitespace-expected.txt:
        * editing/selection/doubleclick-whitespace.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Dimitri Glazkov <dglazkov@chromium.org>
eric@webkit.org [Mon, 12 Jan 2009 20:26:27 +0000 (20:26 +0000)]
2009-01-12  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Add the first pieces of platform/graphics/chromium
        https://bugs.webkit.org/show_bug.cgi?id=23257

        * platform/graphics/chromium/ColorChromium.cpp: Added.
        (WebCore::focusRingColor):
        * platform/graphics/chromium/FontCacheChromiumWin.cpp: Added.
        (WebCore::FontCache::platformInit):
        (WebCore::isStringASCII):
        (WebCore::LookupAltName):
        (WebCore::FontCodepage::):
        (WebCore::FontCodepage::if):
        (WebCore::createFontIndirectAndGetWinName):
        (WebCore::fontContainsCharacter):
        (WebCore::FontCache::getFontDataForCharacters):
        (WebCore::FontCache::alternateFamilyName):
        (WebCore::FontCache::getSimilarFontPlatformData):
        (WebCore::FontCache::getLastResortFallbackFont):
        (WebCore::toGDIFontWeight):
        (WebCore::FontCache::getGenericFontForScript):
        (WebCore::FillLogFont):
        (WebCore::FontCache::fontExists):
        (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData):
        (WebCore::traitsInFamilyEnumProc):
        (WebCore::FontCache::getTraitsInFamily):
        (WebCore::FontCache::createFontPlatformData):
        * platform/graphics/chromium/FontCacheLinux.cpp: Added.
        (WebCore::FontCache::platformInit):
        (WebCore::FontCache::getFontDataForCharacters):
        (WebCore::FontCache::alternateFamilyName):
        (WebCore::FontCache::getSimilarFontPlatformData):
        (WebCore::FontCache::getLastResortFallbackFont):
        (WebCore::FontCache::getTraitsInFamily):
        (WebCore::FontCache::createFontPlatformData):
        (WebCore::FontCache::getGenericFontForScript):
        * platform/graphics/chromium/FontChromiumWin.cpp: Added.
        (WebCore::windowsCanHandleTextDrawing):
        (WebCore::skiaDrawText):
        (WebCore::PaintSkiaText):
        (WebCore::Font::drawGlyphs):
        (WebCore::Font::selectionRectForComplexText):
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Darin Fisher <darin@chromium.org>
darin@chromium.org [Mon, 12 Jan 2009 19:25:09 +0000 (19:25 +0000)]
2009-01-12  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23254
        Upstream page/chromium/

        * page/chromium/AXObjectCacheChromium.cpp: Added.
        (WebCore::AXObjectCache::detachWrapper):
        (WebCore::AXObjectCache::attachWrapper):
        (WebCore::AXObjectCache::postNotification):
        (WebCore::AXObjectCache::postNotificationToElement):
        (WebCore::AXObjectCache::handleFocusedUIElementChanged):
        * page/chromium/AccessibilityObjectChromium.cpp:
        * page/chromium/AccessibilityObjectWrapper.h:
        * page/chromium/ChromeClientChromium.h: Added.
        * page/chromium/DragControllerChromium.cpp: Added.
        (WebCore::DragController::dragOperation):
        (WebCore::DragController::isCopyKeyDown):
        (WebCore::DragController::maxDragImageSize):
        (WebCore::DragController::cleanupAfterSystemDrag):
        * page/chromium/EventHandlerChromium.cpp: Added.
        (WebCore::EventHandler::passMousePressEventToSubframe):
        (WebCore::EventHandler::passMouseMoveEventToSubframe):
        (WebCore::EventHandler::passMouseReleaseEventToSubframe):
        (WebCore::EventHandler::passWheelEventToWidget):
        (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
        (WebCore::EventHandler::passMouseDownEventToWidget):
        (WebCore::EventHandler::tabsToAllControls):
        (WebCore::EventHandler::eventActivatedView):
        (WebCore::EventHandler::createDraggingClipboard):
        (WebCore::EventHandler::focusDocumentView):
        (WebCore::EventHandler::accessKeyModifiers):
        * page/chromium/FrameChromium.cpp: Added.
        (WebCore::computePageRectsForFrame):
        (WebCore::Frame::dragImageForSelection):
        * page/chromium/FrameChromium.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-01-12 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 12 Jan 2009 19:10:03 +0000 (19:10 +0000)]
2008-01-12  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22936
        Fix uninitialized memory read error, reported by Purify.

        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::SimpleFontData): Added initializer for
            m_unitsPerEm using cDefaultUnitsPerEm constant.
        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::unitsPerEm): Replaced literal value with
            the constant.
        * svg/SVGFontFaceElement.h: Added cDefaultUnitsPerEm constant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDo not set fixedLayoutSize for anything other than the mainframe during
treat@webkit.org [Mon, 12 Jan 2009 15:50:42 +0000 (15:50 +0000)]
Do not set fixedLayoutSize for anything other than the mainframe during
the transition as this is a page level state like the viewportSize.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Mon, 12 Jan 2009 13:03:15 +0000 (13:03 +0000)]
2009-01-12  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon Hausmann.

        [Qt] Ensure that we're always notified of navigation actions for local anchors

        FrameLoader::checkNavigationPolicy() does not notify us if the request has
        been checked before (which happens for local anchors), but in the case of
        our clients not accepting the navigation request we do want to be notified
        again later on, so we clear the lastCheckedRequest flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Ariya Hidayat <ariya.hidayat@trolltech.com>
vestbo@webkit.org [Mon, 12 Jan 2009 12:51:55 +0000 (12:51 +0000)]
2009-01-12  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Tor Arne Vestbø.

        Build fix: use qobject_cast which does not rely on RTTI. This fixes the
        unit test when building it with a version of Qt (e.g. Qt/Embedded)
        configured without RTTI.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Update test results.
ap@webkit.org [Mon, 12 Jan 2009 11:10:02 +0000 (11:10 +0000)]
    Update test results.

        * fast/dom/Window/window-properties-expected.txt: Remove appcache dynamic entries methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
jchaffraix@webkit.org [Mon, 12 Jan 2009 10:46:22 +0000 (10:46 +0000)]
WebCore:

2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>

        Reviewed by Darin Adler.

        Bug 22861: Turn the FontCache into a singleton
        https://bugs.webkit.org/show_bug.cgi?id=22861

        - Added fontCache() to get the global FontCache.

        - Made all the methods in FontCache instance method.

        - Changed FontCache:: to fontCache()-> in WebCore.

        * WebCore.base.exp: Now export fontCache().
        * css/CSSFontFaceSource.cpp:
        (WebCore::CSSFontFaceSource::getFontData):
        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::CSSFontSelector):
        (WebCore::CSSFontSelector::~CSSFontSelector):
        (WebCore::CSSFontSelector::addFontFaceRule):
        (WebCore::fontDataForGenericFamily):
        * platform/graphics/Font.cpp:
        (WebCore::Font::glyphDataForCharacter):
        * platform/graphics/FontCache.cpp:
        (WebCore::fontCache):
        (WebCore::FontCache::FontCache):
        * platform/graphics/FontCache.h:
        * platform/graphics/FontFallbackList.cpp:
        (WebCore::FontFallbackList::FontFallbackList):
        (WebCore::FontFallbackList::invalidate):
        (WebCore::FontFallbackList::releaseFontData):
        (WebCore::FontFallbackList::fontDataAt):
        (WebCore::FontFallbackList::fontDataForCharacters):
        (WebCore::FontFallbackList::setPlatformFont):
        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::~SimpleFontData):
        * platform/graphics/mac/FontCacheMac.mm:
        (WebCore::fontCacheATSNotificationCallback):
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::smallCapsFontData):
        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::getCJKCodePageMasks):
        * platform/graphics/win/SimpleFontDataWin.cpp:
        (WebCore::SimpleFontData::containsCharacters):

WebKit/mac:

2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>

        Reviewed by Darin Adler.

        Bug 22861: Turn the FontCache into a singleton
        https://bugs.webkit.org/show_bug.cgi?id=22861

        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics cachedFontDataCount]):
        (+[WebCoreStatistics cachedFontDataInactiveCount]):
        (+[WebCoreStatistics purgeInactiveFontData]):
        Redirected all the static calls to the global FontCache
        instance.

WebKit/win:

2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>

        Reviewed by Darin Adler.

        Bug 22861: Turn the FontCache into a singleton
        https://bugs.webkit.org/show_bug.cgi?id=22861

        * WebCoreStatistics.cpp:
        (WebCoreStatistics::cachedFontDataCount):
        (WebCoreStatistics::cachedFontDataInactiveCount):
        (WebCoreStatistics::purgeInactiveFontData):
        Redirected all the static calls to the global FontCache
        instance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 12 Jan 2009 09:41:03 +0000 (09:41 +0000)]
2009-01-12  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Tor Arne Vestbø.

        When the QWebView is disabled context menus implemented in JavaScript should not pop up.

        Just like in QWidget::event() we have to check for the disabled state and
        ignore context menu events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Simon Hausmann <simon.hausmann@nokia.com
hausmann@webkit.org [Mon, 12 Jan 2009 09:36:53 +0000 (09:36 +0000)]
2009-01-12  Simon Hausmann  <simon.hausmann@nokia.com

        Reviewed by Tor Arne Vestbø.

        Fix QWebView appearance when showed uninitialized without page.

        Only set WA_OpaquePaintEvent if we have a page set that will actually
        paint the entire contents, otherwise the optimization does not apply
        as we do not have a paintEvent() implementation and Qt has to fill the
        view with its default background instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Ariya Hidayat <ariya.hidayat@trolltech.com>
vestbo@webkit.org [Mon, 12 Jan 2009 09:12:50 +0000 (09:12 +0000)]
2009-01-11  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Tor Arne Vestbø.

        Do not create a QVariant from QObject* directly, use the
        template-specialized function.

        * tests/qwebframe/tst_qwebframe.cpp:
        (MyQObject::myOverloadedSlot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Mon, 12 Jan 2009 07:48:35 +0000 (07:48 +0000)]
WebCore:

2009-01-11  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23247: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
        https://bugs.webkit.org/show_bug.cgi?id=23247

        Also fix problems where partially parsed paths will still have an effect
        rather than failing parsing and being ignored.

        Test: dom/path-segments.html

        * platform/graphics/Path.h:
        (WebCore::Path::swap): Added.

        * svg/SVGParserUtilities.cpp:
        (WebCore::SVGPathParser::parseSVG): Removed unneeded special case for empty string.
        (WebCore::PathBuilder::build): Changed to not modify the path if parsing fails.
        (WebCore::SVGPathSegListBuilder::build): Changed to not modify the segment list if
        parsing fails.
        (WebCore::SVGPathSegListBuilder::svgMoveTo): Put the path element into the vector,
        not directly into the segment list.
        (WebCore::SVGPathSegListBuilder::svgLineTo): Ditto.
        (WebCore::SVGPathSegListBuilder::svgLineToHorizontal): Ditto.
        (WebCore::SVGPathSegListBuilder::svgLineToVertical): Ditto.
        (WebCore::SVGPathSegListBuilder::svgCurveToCubic): Ditto.
        (WebCore::SVGPathSegListBuilder::svgCurveToCubicSmooth): Ditto.
        (WebCore::SVGPathSegListBuilder::svgCurveToQuadratic): Ditto.
        (WebCore::SVGPathSegListBuilder::svgCurveToQuadraticSmooth): Ditto.
        (WebCore::SVGPathSegListBuilder::svgArcTo): Ditto.
        (WebCore::SVGPathSegListBuilder::svgClosePath): Ditto.

        * svg/SVGPathSegCurvetoCubicSmooth.h:
        (WebCore::SVGPathSegCurvetoCubicSmooth::SVGPathSegCurvetoCubicSmooth):
        Set y2 to y2, not to y.

WebKitTools:

2009-01-11  Darin Adler  <darin@apple.com>

        * Scripts/make-js-test-wrappers: Updated so it won't overwrite tests in the svg/dom
        directory that aren't using standard wrappers.

LayoutTests:

2009-01-11  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23247: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
        https://bugs.webkit.org/show_bug.cgi?id=23247

        Also fix problems where partially parsed paths will still have an effect
        rather than failing parsing and being ignored.

        Renamed the path-parser.html test to fuzz-path-parser.html, since it's a fuzz test,
        to make room for a non-fuzz test of the path parser.

        * platform/mac/svg/custom/path-bad-data-expected.txt: Updated results, since the old
        ones were based on incorrect path parsing behavior.

        * svg/dom/fuzz-path-parser-expected.txt: Copied from svg/dom/path-parser-expected.txt.
        Also updated because the parser no longer tolerates extra characters at the end of the
        string, which it was doing by accident.
        * svg/dom/fuzz-path-parser.html: Copied from svg/dom/path-parser.html.

        * svg/dom/path-parser-expected.txt: Replaced fuzz test results with new test results.
        * svg/dom/path-parser.html: Replaced fuzz test with a new test.
        * svg/dom/path-segments-expected.txt: Added.
        * svg/dom/path-segments.html: Added.

        * svg/dom/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.

        * svg/dom/resources/path-parser.js: Added. Mostly, this test shows that we are
        processing the path while parsing it, which is a bug. This test would be much more
        useful if that was fixed. But it also shows that we were incorrectly tolerating
        extra characters after the path, which is now fixed.

        * svg/dom/resources/path-segments.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 12 Jan 2009 07:44:27 +0000 (07:44 +0000)]
2009-01-11  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Bug 23102: turn on unused parameter warnings in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=23102

        Fourth step: Remove arguments entirely in the many cases where they are not
        needed at all. This step is a little less mechanical than the earlier ones.

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::isXMLMIMEType): Pass TextCaseSensitive when creating
        the regular expression, since we already specify a-zA-Z in our expression.

        * dom/Document.cpp:
        (WebCore::Document::databaseThread): Don't pass in the document when creating
        a DatabaseThread.

        * dom/Element.cpp:
        (WebCore::Element::createRareData): Don't pass the element when creating an
        ElementRareData.
        (WebCore::Element::detach): Don't pass the element when calling resetComputedStyle.
        (WebCore::Element::recalcStyle): Ditto.

        * dom/ElementRareData.h: Remove the unused Element* from the constructor and
        the resetComputedStyle function.

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchEvent): Don't pass ec to dispatchGenericEvent.
        (WebCore::EventTargetNode::dispatchGenericEvent): Remove the unused ec argument.
        (WebCore::EventTargetNode::dispatchWindowEvent): Don't pass ec to dispatchGenericEvent.
        * dom/EventTargetNode.h: Remove the ExceptionCode& argument form disaptchGenericEvent.

        * editing/ApplyStyleCommand.cpp: Remove the empty removeBlockStyle function.
        (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Remove the unused
        start and end arguments.
        (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Don't pass start
        and end to pushDownTextDecorationStyleAroundNode.

        * editing/ApplyStyleCommand.h: Remove the empty removeBlockStyle function. Removed the
        unused start and end arguments from pushDownTextDecorationStyleAroundNode.

        * editing/htmlediting.cpp: Removed include of unused RegularExpression.h header.

        * html/HTMLTokenizer.cpp:
        (WebCore::Token::addAttribute): Removed unused Document* argument.
        (WebCore::HTMLTokenizer::parseTag): Don't pass document to addAttribute.

        * html/HTMLTokenizer.h: Removed unused Document* argument to to addAttribute.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::localStorage): Don't pass the frame to storageArea.

        * page/DragController.cpp:
        (WebCore::DragController::dragIsMove): Removed unused DragData argument.
        (WebCore::DragController::performDrag): Call concludeEditDrag rather than
        concludeDrag.
        (WebCore::DragController::tryDocumentDrag): Don't pass dragData to dragIsMove.
        (WebCore::DragController::concludeEditDrag): Renamed to make it clear this
        should only be called for edit drags. Removed the action mask argument. Also
        changed dragIsMove call sites to not pass dragData.

        * page/DragController.h: Updated for above changes and tweaked comment format.

        * page/Frame.cpp:
        (WebCore::createRegExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
        when creating regular expressions for clarity. Call match instead of search,
        since both do the same thing except for with negative start offsets, and none
        used here are negative.
        (WebCore::Frame::matchLabelsAgainstElement): Ditto.

        * page/Page.h: Moved TextCaseSensitivity from here to StringImpl.h in platform.

        * page/mac/AccessibilityObjectWrapper.mm:
        (AXAttributeStringSetHeadingLevel): Removed unused object argument.
        (AXAttributedStringAppendText): Ditto.
        (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Ditto.

        * page/mac/FrameMac.mm:
        (WebCore::regExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
        when creating regular expressions for clarity. Call match instead of search,
        since both do the same thing except for with negative start offsets, and none
        used here are negative.
        (WebCore::Frame::matchLabelsAgainstElement): Ditto.

        * platform/graphics/SegmentedFontData.cpp:
        (WebCore::SegmentedFontData::containsCharacter): Added.
        (WebCore::SegmentedFontData::containsCharacters): Updated to check all characters
        instead of just the first one, using containsCharacter.

        * platform/graphics/SegmentedFontData.h: Made more members private.
        Added containsCharacter function member.

        * platform/mac/DragImageMac.mm:
        (WebCore::dragImageSize): Changed to use RetainPtr<NSImage> directly instead of
        DragImageRef for clarity, since this is platform-specific code.
        (WebCore::deleteDragImage): Ditto. Also remove argument name to get rid of unused
        variable warning.
        (WebCore::scaleDragImage): Ditto.
        (WebCore::dissolveDragImageToFraction): Ditto.
        (WebCore::createDragImageFromImage): Ditto.
        (WebCore::createDragImageIconForCachedImage): Ditto.

        * platform/mac/WebFontCache.mm:
        (acceptableChoice): Removed the unused weight-related arguments.
        (betterChoice): Ditto.
        (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Ditto.

        * platform/posix/FileSystemPOSIX.cpp: Removed the implementation of listDirectory
        because we'd rather get a link error rather than a runtime error if we use it
        for anything, and right now it's not used.

        * platform/text/RegularExpression.cpp: Removed unused private data,
        including pattern, lastMatchString, lastMatchOffsets, lastMatchCount,
        and lastMatchPos. Made the RegularExpression::Private::regex be private
        and use an accessor function to get at it.
        (WebCore::RegularExpression::RegularExpression): Removed the const char* version
        of the constructor because it's not any more efficient. Changed the boolean
        constructor argument to use TextCaseSensitivity instead to make it less likely
        we'll use it wrong.
        (WebCore::RegularExpression::operator=): Since the only member is a single RefPtr,
        just use plain old assignment on it. The only reason we do this instead of using
        the compiler generated assignment operator is that we want the Private structure
        to be internal to the .cpp file.
        (WebCore::RegularExpression::match): Added a null check so we won't crash if
        we fail to compile the regular expression. Removed the code to handle multiple
        match strings, since that was unused.

        * platform/text/RegularExpression.h: Changed the case sensitivity argument to use
        TextCaseSensitivity and not have a default value. Removed the default constructor,
        and the pattern, match, and pos functions.

        * platform/text/StringImpl.h: Moved the TextCaseSensitivity enum here from
        Page.h, because we should eventually use it in all the places where we have
        an argument to control case sensitivity, starting with the functions in this
        class.

        * platform/text/mac/ShapeArabic.c:
        (shapeUnicode): Removed the unused options and pErrorCode arguments. Even though
        this is code borrowed from ICU, this seems like a simple safe change to make.
        (shapeArabic): Don't pass options or pErrorCode in to shapeUnicode.

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::RenderPath): Removed the unused style argument.
        Also removed the type check. The argument already has the correct type,
        so it's not helpful to upcast it and then check its type again, unless
        we have some reason to believe the type is not reliable. And we don't.

        * rendering/RenderPath.h: Removed the RenderStyle* argument to the
        constructor. Also removed the explicit declaration of the destructor.
        It's not helpful or needed.

        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::localCaretRect): Updated the comment here to
        make it clear that just returning an empty rect is not a good implementation.
        Removed the argument names to get rid of the warning.

        * rendering/RenderTreeAsText.cpp:
        (WebCore::printBorderStyle): Removed the unused RenderObject argument.
        (WebCore::operator<<): Updated for the change to printBorderStyle function.

        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::DatabaseThread): Removed the unused document argument.
        * storage/DatabaseThread.h: Ditto.

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea): Removed the unused Frame* argument.
        * storage/LocalStorage.h: Ditto.

        * svg/SVGElement.cpp:
        (WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't pass an exception
        code location to dispatchGenericEvent.
        * svg/SVGElementInstance.cpp:
        (WebCore::SVGElementInstance::dispatchEvent): Ditto.

        * svg/SVGStyledTransformableElement.cpp: Removed include of unused RegularExpression.h.
        (WebCore::SVGStyledTransformableElement::createRenderer): Don't pass style in to
        the RenderPath constructor.

        * svg/SVGTransformable.cpp: Removed include of unused RegularExpression.h.

        * xml/XSLTProcessor.cpp:
        (WebCore::createFragmentFromSource): Removed unused sourceNode argument.
        (WebCore::XSLTProcessor::transformToFragment): Don't pass sourceNode to createFragmentFromSource.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 David Levin <levin@chromium.org>
ap@webkit.org [Mon, 12 Jan 2009 07:34:12 +0000 (07:34 +0000)]
2009-01-11  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23245

        Add initializeThreading to key places in JS API to ensure that
        UString is properly initialized.

        * API/JSContextRef.cpp:
        (JSContextGroupCreate):
        (JSGlobalContextCreate):
        * API/JSObjectRef.cpp:
        (JSClassCreate):
        * API/JSStringRef.cpp:
        (JSStringCreateWithCharacters):
        (JSStringCreateWithUTF8CString):
        * API/JSStringRefCF.cpp:
        (JSStringCreateWithCFString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Mon, 12 Jan 2009 07:21:46 +0000 (07:21 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23165
        Disable application cache dynamic entries support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 David Levin <levin@chromium.org>
darin@apple.com [Mon, 12 Jan 2009 03:19:23 +0000 (03:19 +0000)]
2009-01-11  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23175

        Separate out BaseString information from UString::Rep and make all baseString access go through
        a member function, so that it may be used for something else (in the future) in the BaseString
        case.

        * runtime/SmallStrings.cpp:
        (JSC::SmallStringsStorage::rep):
        (JSC::SmallStringsStorage::SmallStringsStorage):
        (JSC::SmallStrings::SmallStrings):
        (JSC::SmallStrings::mark):
        Adjust to account for the changes in UString and put the UString in place in
        SmallStringsStorage to aid in locality of reference among the UChar[] and UString::Rep's.

        * runtime/SmallStrings.h:
        * runtime/UString.cpp:
        (JSC::initializeStaticBaseString):
        (JSC::initializeUString):
        (JSC::UString::Rep::create):
        (JSC::UString::Rep::destroy):
        (JSC::UString::Rep::checkConsistency):
        (JSC::expandCapacity):
        (JSC::UString::expandPreCapacity):
        (JSC::concatenate):
        (JSC::UString::append):
        (JSC::UString::operator=):
        * runtime/UString.h:
        (JSC::UString::Rep::baseIsSelf):
        (JSC::UString::Rep::setBaseString):
        (JSC::UString::Rep::baseString):
        (JSC::UString::Rep::):
        (JSC::UString::Rep::null):
        (JSC::UString::Rep::empty):
        (JSC::UString::Rep::data):
        (JSC::UString::cost):
        Separate out the items out used by base strings from those used in Rep's that only
        point to base strings.  (This potentially saves 24 bytes per Rep.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 12 Jan 2009 03:17:34 +0000 (03:17 +0000)]
2009-01-11  Darin Adler  <darin@apple.com>

        * fast/frames/frame-deep-nested-resize-expected.txt: This time for sure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 12 Jan 2009 02:07:00 +0000 (02:07 +0000)]
2009-01-11  Darin Adler  <darin@apple.com>

        Fix failure of new test seen on buildbots.

        * fast/frames/frame-deep-nested-resize-expected.txt: Updated newlines to
        match what DumpRenderTree generates on Mac. I believe Adam generated his
        results under Qt DumpRenderTree. If so, then the Qt version will need to
        change to match the Mac version, since all the expected results were
        generated on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCorrect coordinate transformation for deeply nested frames on resizing. This
treat@webkit.org [Mon, 12 Jan 2009 00:54:09 +0000 (00:54 +0000)]
Correct coordinate transformation for deeply nested frames on resizing.  This
fixes https://bugs.webkit.org/show_bug.cgi?id=20766.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTiger build fix. The connection parameter is still used on Tiger in this method.
mrowe@apple.com [Sun, 11 Jan 2009 23:55:05 +0000 (23:55 +0000)]
Tiger build fix.  The connection parameter is still used on Tiger in this method.

* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 11 Jan 2009 22:01:21 +0000 (22:01 +0000)]
2009-01-11  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23102: turn on unused parameter warnings in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=23102

        Third step: Deal with cases of arguments used only in assertions.

        * dom/MessagePort.cpp:
        (WebCore::MessagePortCloseEventTask::performTask): Use ASSERT_UNUSED.
        * dom/Worker.cpp:
        (WebCore::Worker::notifyFinished): Ditto.
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::notifyFinished): Ditto.
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto.
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::verifySchemaVersion): Ditto.
        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::didReceiveData): Since loader and size are only
        used when logging, use UNUSED_PARAM when logging is disabled.
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::beforeMouseDown): Use ASSERT_UNUSED.
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Use the
        argument since it's probably a tiny bit more efficient and gets rid
        of the unused argument warning.
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::createInlineBox): Use ASSERT_UNUSED.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createInlineBox): Ditto.
        * rendering/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::createInlineBox): Use UNUSED_PARAM.
        I couldn't use ASSERT_UNUSED because it's a single assertion, but it's
        the only use for two different arguments.
        * rendering/RenderText.cpp:
        (WebCore::RenderText::createInlineBox): Use ASSERT_UNUSED.
        * rendering/RenderThemeMac.mm:
        (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 11 Jan 2009 21:58:23 +0000 (21:58 +0000)]
2009-01-11  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23239: improve handling of unused arguments in JavaScriptCore
        https://bugs.webkit.org/show_bug.cgi?id=23239

        * runtime/DatePrototype.cpp: Moved LocaleDateTimeFormat enum outside #if
        so we can use this on all platforms. Changed valueOf to share the same
        function with getTime, since the contents of the two are identical. Removed
        a FIXME since the idea isn't really specific enough or helpful enough to
        need to sit here in the source code.
        (JSC::formatLocaleDate): Changed the Mac version of this function to take
        the same arguments as the non-Mac version so the caller doesn't have to
        special-case the two platforms. Also made the formatString array be const;
        before the characters were, but the array was a modifiable global variable.
        (JSC::dateProtoFuncToLocaleString): Changed to call the new unified
        version of formatLocaleDate and remove the ifdef.
        (JSC::dateProtoFuncToLocaleDateString): Ditto.
        (JSC::dateProtoFuncToLocaleTimeString): Ditto.

        * runtime/JSNotAnObject.cpp:
        (JSC::JSNotAnObject::toObject): Use the new ASSERT_UNUSED instead of the
        old UNUSED_PARAM.

        * runtime/RegExp.cpp:
        (JSC::RegExp::RegExp): Changed to only use UNUSED_PARAM when the parameter
        is actually unused.

        * wtf/TCSystemAlloc.cpp:
        (TCMalloc_SystemRelease): Changed to only use UNUSED_PARAM when the parameter
        is actually unused.
        (TCMalloc_SystemCommit): Changed to omit the argument names instead of using
        UNUSED_PARAM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSet the svn:mime-type property of recently-added PNG files to image/png.
mitz@apple.com [Sun, 11 Jan 2009 21:42:47 +0000 (21:42 +0000)]
Set the svn:mime-type property of recently-added PNG files to image/png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 11 Jan 2009 21:22:04 +0000 (21:22 +0000)]
2009-01-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Oliver Hunt

        https://bugs.webkit.org/show_bug.cgi?id=23242

        Fix CanvasRenderingContext2D::transform to do a pre-multiply,
        rather than a post-multiply into m_transform. This bug did not affect
        drawing, but did cause m_transform to be incorrect, which impacted
        willDraw(), and isPointInPath.

        Test: fast/canvas/canvas-incremental-repaint-2.html

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::transform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 11 Jan 2009 20:05:45 +0000 (20:05 +0000)]
2009-01-11  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23102: turn on unused parameter warnings in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=23102

        Second step: Fix simple Objective-C cases where we need to use UNUSED_PARAM.
        That's because you can't omit an argument name in Objective-C methods.

        * bindings/objc/DOMObject.mm:
        (-[DOMObject copyWithZone:]): Use UNUSED_PARAM. Also rename argument to include
        the word "unused" so we don't just start using it without removing the macro.
        * bindings/objc/WebScriptObject.mm:
        (+[WebUndefined allocWithZone:]): Ditto.
        (-[WebUndefined initWithCoder:]): Ditto.
        (-[WebUndefined encodeWithCoder:]): Ditto.
        (-[WebUndefined copyWithZone:]): Ditto.
        * page/mac/WebDashboardRegion.m:
        (-[WebDashboardRegion copyWithZone:]): Ditto.
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::mainThreadSetNeedsDisplay): Omit argument name.
        (-[WebCoreMovieObserver loadStateChanged:]): Use UNUSED_PARAM as above.
        (-[WebCoreMovieObserver rateChanged:]): Ditto.
        (-[WebCoreMovieObserver sizeChanged:]): Ditto.
        (-[WebCoreMovieObserver timeChanged:]): Ditto.
        (-[WebCoreMovieObserver didEnd:]): Ditto.
        (-[WebCoreMovieObserver newImageAvailable:]): Ditto.
        * platform/mac/ScrollbarThemeMac.mm:
        (+[ScrollbarPrefsObserver appearancePrefsChanged:]): Ditto.
        (+[ScrollbarPrefsObserver behaviorPrefsChanged:]): Ditto.
        * platform/mac/SharedTimerMac.mm:
        (-[WebCorePowerNotifier didWake:]): Ditto.
        * platform/mac/WebCoreKeyGenerator.m:
        (-[WebCoreKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): Ditto.
        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Ditto.
        (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto.
        (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 11 Jan 2009 19:59:52 +0000 (19:59 +0000)]
2009-01-11  Dirk Schulze  <krit@webkit.org>

        Reviewed by Darin Adler.

        Move platform dependent strokeContains back to RenderPath, Path and delete
        unneeded Code in svg.

        RenderPath clean-up for strokeContains
        [https://bugs.webkit.org/show_bug.cgi?id=22957]

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/Path.h:
        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::strokeContains):
        * platform/graphics/cg/PathCG.cpp:
        (WebCore::Path::strokeContains):
        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::strokeContains):
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::strokeContains):
        * svg/graphics/cairo/RenderPathCairo.cpp: Removed.
        * svg/graphics/cg/CgSupport.cpp: Removed.
        * svg/graphics/cg/CgSupport.h: Removed.
        * svg/graphics/cg/RenderPathCg.cpp: Removed.
        * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
        * svg/graphics/cg/SVGResourceMaskerCg.mm:
        * svg/graphics/qt/RenderPathQt.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Xan Lopez <xan@gnome.org>
zecke@webkit.org [Sun, 11 Jan 2009 19:59:13 +0000 (19:59 +0000)]
2009-01-11 Xan Lopez <xan@gnome.org>

        Reviewed by Holger Freyther.

        Bump version to 1.1.0 since we are breaking ABI and adding new
        major features.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Xan Lopez <xan@gnome.org>
zecke@webkit.org [Sun, 11 Jan 2009 19:57:32 +0000 (19:57 +0000)]
2009-01-11 Xan Lopez <xan@gnome.org>

        Reviewed by Holger Freyther.

        Use NULL instead of 0 when dealing with pointers, as agreed for
        the coding style of the WebKit GTK port for its GTK+ specific
        files.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Xan Lopez <xan@gnome.org>
zecke@webkit.org [Sun, 11 Jan 2009 19:55:30 +0000 (19:55 +0000)]
2009-01-11 Xan Lopez <xan@gnome.org>

        Reviewed by Holger Freyther.

        Add padding to the class structs to avoid breaking ABI each time
        we add stuff there.

        * webkit/webkitnetworkrequest.h:
        * webkit/webkitwebbackforwardlist.h:
        * webkit/webkitwebhistoryitem.h:
        * webkit/webkitwebnavigationaction.h:
        * webkit/webkitwebpolicydecision.h:
        * webkit/webkitwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[GTK] make distcheck complains that distclean is not deleting JSWorkerContextBase...
zecke@webkit.org [Sun, 11 Jan 2009 19:47:53 +0000 (19:47 +0000)]
[GTK] make distcheck complains that distclean is not deleting JSWorkerContextBase.lut.h

make distcheck pass by adding JSWorkerContextBase.lut.h to the
CLEANFILES that will be cleaned on a make distclean.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agobuild fix
oliver@apple.com [Sun, 11 Jan 2009 19:47:34 +0000 (19:47 +0000)]
build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23128: get/put_by_val need to respecialise in the face of ByteArray
oliver@apple.com [Sun, 11 Jan 2009 19:12:47 +0000 (19:12 +0000)]
Bug 23128: get/put_by_val need to respecialise in the face of ByteArray

Reviewed by Darin Adler and Anders Carlsson

Restructure the code slightly, and add comments per Darin's suggestions

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix exception check for string indexing
oliver@apple.com [Sun, 11 Jan 2009 18:56:07 +0000 (18:56 +0000)]
Fix exception check for string indexing

Reviewed by Anders Carlsson.

Whoops, I accidentally removed an exception check from fast the
fast path for string indexing when i originally landed the
byte array logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoattempt to fix win build
oliver@apple.com [Sun, 11 Jan 2009 16:54:05 +0000 (16:54 +0000)]
attempt to fix win build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23128: get/put_by_val need to respecialise in the face of ByteArray
oliver@apple.com [Sun, 11 Jan 2009 16:48:39 +0000 (16:48 +0000)]
Bug 23128: get/put_by_val need to respecialise in the face of ByteArray
<https://bugs.webkit.org/show_bug.cgi?id=23128>

Reviewed by Anders Carlsson.

Fairly simple patch, add specialised versions of cti_op_get/put_by_val
that assume ByteArray, thus avoiding a few branches in the case of bytearray
manipulation.

No effect on SunSpider.  15% win on the original testcase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Zalan Bujtas <zbujtas@gmail.com>
ap@webkit.org [Sun, 11 Jan 2009 11:06:32 +0000 (11:06 +0000)]
2009-01-11  Zalan Bujtas  <zbujtas@gmail.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=23235
        Build fix for non-VIDEO builds.

        * rendering/RenderTheme.cpp:
        * rendering/RenderTheme.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Try to fix Windows build.
ap@webkit.org [Sun, 11 Jan 2009 11:03:02 +0000 (11:03 +0000)]
    Try to fix Windows build.

        * wtf/CurrentTime.cpp: Added a definition of msPerSecond (previously, this code was in
        DateMath.cpp, with constant definition in DateTime.h)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Alexey Proskuryakov <ap@webkit.org>
ap@webkit.org [Sun, 11 Jan 2009 10:36:23 +0000 (10:36 +0000)]
2009-01-11  Alexey Proskuryakov  <ap@webkit.org>

        Try to fix Windows build.

        * wtf/CurrentTime.cpp: Include <sys/types.h> and <sys/timeb.h>, as MSDN says to.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Gabriella Toth <gtoth@inf.u-szeged.hu>
ap@webkit.org [Sun, 11 Jan 2009 10:27:03 +0000 (10:27 +0000)]
2009-01-11  Gabriella Toth  <gtoth@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19287
        return value of malloc() is not checked in npruntime.cpp

        Checking whether malloc can allocate memory or not. If it can't, CRASH macro is invoked
        (like in fastMalloc).

        * bridge/npruntime.cpp:
        (_NPN_GetStringIdentifier):
        (_NPN_GetIntIdentifier):
        (NPN_InitializeVariantWithStringCopy):
        (_NPN_CreateObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Glenn Wilson <gwilson@google.com>
ap@webkit.org [Sun, 11 Jan 2009 10:24:52 +0000 (10:24 +0000)]
2009-01-11  Glenn Wilson  <gwilson@google.com>

        Reviewed by Darin Adler.

        Changes radio buttons so they can be 'checked' even if they
        don't have the name attribute set.

        See https://bugs.webkit.org/show_bug.cgi?id=21534

        Test: fast/html/select-unnamed-radio.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::preDispatchEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 tony chang <tony@chromium.org>
ap@webkit.org [Sun, 11 Jan 2009 09:48:26 +0000 (09:48 +0000)]
2009-01-11  tony chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        Remove svn:eol-style native from some utf16 files so
        windows-svn doesn't alter them on checkout.

        * fast/xsl/xslt-enc16.xml: remove svn:eol-style
        * fast/xsl/xslt-enc16to16.xml: remove svn:eol-style

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix ChangeLog date.
ap@webkit.org [Sun, 11 Jan 2009 09:44:21 +0000 (09:44 +0000)]
Fix ChangeLog date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Robert Blaut <webkit@blaut.biz>
ap@webkit.org [Sun, 11 Jan 2009 09:43:03 +0000 (09:43 +0000)]
2009-01-11  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Eric Seidel.

        <https://bugs.webkit.org/show_bug.cgi?id=23134>
        Update bisect-builds for Safari 3.2 to prevent crashes

        * Scripts/bisect-builds: Added Safari 3.2 and the corresponding minimal revision, r37348.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Jungshik Shin <jshin@chromium.org>
ap@webkit.org [Sun, 11 Jan 2009 09:40:29 +0000 (09:40 +0000)]
2009-01-11  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Alexey Proskuryakov

        - Make fast/encoding/char-encoding test work with Chromium by replacing
        'data:' with 'file:' pointing to resources/dummy.html (an empty file).
        - Put old Mac encodings in a separate char-encoding-mac.html to make it
        possible to to skip it.
        - Factor out common functions in char-encoding.html and char-encoding-mac.html
        and put them in char-encoding-utils.js

        See: https://bugs.webkit.org/show_bug.cgi?id=22882

        * fast/encoding/char-encoding-mac-expected.txt: Added.
        * fast/encoding/char-encoding-mac.html: Added.
        * fast/encoding/char-encoding.html:
        * fast/encoding/resources/char-encoding-utils.js: Added.
        * fast/encoding/resources/dummy.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-12-18 Bernhard Rosenkraenzer <bero@arklinux.ch>
ap@webkit.org [Sun, 11 Jan 2009 09:36:14 +0000 (09:36 +0000)]
2008-12-18  Bernhard Rosenkraenzer <bero@arklinux.ch>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22205
        Fix compatibility with bison 2.4, partially based on older patch by
        Priit Laes <amd@store20.com>

        * WebCore/css/CSSGrammar.y: Made compatible with bison 2.4

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Jeremy Moskovich <jeremy@chromium.org>
ap@webkit.org [Sun, 11 Jan 2009 09:18:21 +0000 (09:18 +0000)]
2009-01-11  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=16001
        Incorrect assumption that selection is always contiguous LTR.

        Test: editing/selection/extend-selection-bidi.html

        * rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::fillLineSelectionGap):
        Make this function  not assume a contiguous visual LTR selection range.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Sun, 11 Jan 2009 08:14:58 +0000 (08:14 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23207
        Moved currentTime() to from WebCore to WTF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Dmitry Titov <dimich@chromium.org>
ap@webkit.org [Sun, 11 Jan 2009 08:06:58 +0000 (08:06 +0000)]
2009-01-11  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Darin Adler.

        Make ScheduledAction (Timeout callback) able to execute the callback under WorkerContext.
        Part of 'Timers in Workers' work.
        https://bugs.webkit.org/show_bug.cgi?id=23223

        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute): new method that takes WorkerContext.
        (WebCore::ScheduledAction::executeFunctionInContext): Executes a JSFunction in proper context with 'this' object.
        * bindings/js/ScheduledAction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-10 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Sun, 11 Jan 2009 07:45:45 +0000 (07:45 +0000)]
2009-01-10  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23210
        Make it easier for ports to define custom UI for media controls

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::styleForElement): call theme()->styleSheetForMediaControls to
        get the media controller style sheet

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlInputElement::hitTest): Added
        * rendering/MediaControlElements.h: Updated

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function
        so control elements don't necessarily have to be rectangular

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::styleSheetForMediaControls):  Added
        (WebCore::RenderTheme::hitTestMediaControlPart):  Added
        * rendering/RenderTheme.h: Updated

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 11 Jan 2009 02:47:51 +0000 (02:47 +0000)]
2009-01-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=23222

        We need to disable LayoutState when an object has transforms,
        because LayoutState is not transform-aware and therefore
        repaint rects can be computed incorrectly.

        Test: fast/repaint/transform-disable-layoutstate.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::layoutOnlyPositionedObjects):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRevert 39779.
abarth@webkit.org [Sun, 11 Jan 2009 00:05:19 +0000 (00:05 +0000)]
Revert 39779.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39780 268f45cc-cd09-0410-ab3c-d52691b4dbfc