WebKit-https.git
10 years ago2009-12-19 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Sun, 20 Dec 2009 03:30:14 +0000 (03:30 +0000)]
2009-12-19  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Invalid url should raise SYNTAX_ERR exception.
        https://bugs.wbekit.org/show_bug.cgi?id=32700

        * websocket/tests/bad-sub-protocol-expected.txt: add CONSOLE MESSAGEs
        * websocket/tests/script-tests/url-parsing.js: add invalid url tests.
          Also changed url from ws://127.0.0.1/ to ws://127.0.0.1:8880/websocket/tests/simple to make it sure no errors on console message for these tests by not receiving unexpected response from 127.0.0.1:80.
        * websocket/tests/url-parsing-expected.txt:
2009-12-19  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Invalid url should raise SYNTAX_ERR exception.
        https://bugs.webkit.org/show_bug.cgi?id=32700

        Check url is valid in WebSocket::connect.
        Also log the detailed reason of websocket failures to console.

        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::connect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 20 Dec 2009 02:40:53 +0000 (02:40 +0000)]
2009-12-19  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Tweak the CSS to make the dashboard prettier.

        * QueueStatusServer/stylesheets/dashboard.css:
        * QueueStatusServer/templates/dashboard.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION: Up/down arrow keys do not step numeric CSS property values
mitz@apple.com [Sun, 20 Dec 2009 02:32:29 +0000 (02:32 +0000)]
REGRESSION: Up/down arrow keys do not step numeric CSS property values
https://bugs.webkit.org/show_bug.cgi?id=32776

Reviewed by Darin Adler.

* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown): Call the focused element’s
handleKeyEvent method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 20 Dec 2009 01:37:13 +0000 (01:37 +0000)]
2009-12-19  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        QueueStatusServer needs a human readable dashboard
        https://bugs.webkit.org/show_bug.cgi?id=32769

        Here is a first cut at the dashboard.  There's a lot left to do.

        * QueueStatusServer/filters/webkit_extras.py:
        * QueueStatusServer/handlers/dashboard.py: Added.
        * QueueStatusServer/handlers/patchstatus.py:
        * QueueStatusServer/handlers/recentstatus.py:
        * QueueStatusServer/handlers/showresults.py:
        * QueueStatusServer/handlers/statusbubble.py:
        * QueueStatusServer/handlers/updatestatus.py:
        * QueueStatusServer/main.py:
        * QueueStatusServer/model/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
        * QueueStatusServer/model/queuestatus.py: Renamed from WebKitTools/QueueStatusServer/model.py.
        * QueueStatusServer/stylesheets/dashboard.css: Added.
        * QueueStatusServer/templates/dashboard.html: Added.
        * QueueStatusServer/templates/statusbubble.html: Renamed from WebKitTools/QueueStatusServer/status_bubble.html.
        * QueueStatusServer/templates/updatestatus.html: Renamed from WebKitTools/QueueStatusServer/update_status.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-19 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Sat, 19 Dec 2009 21:58:51 +0000 (21:58 +0000)]
2009-12-19  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Speed-up SVG Masking
        https://bugs.webkit.org/show_bug.cgi?id=32738

        This patch makes SVG Masking faster. At the moment we create a new ImageBuffer
        and copy the complete pixel array. That is rather inefficient. This patch
        uses the mask image directly.
        It also bounds the direct pixel manipultation to the viewable area to minimize
        the calculation of the mask.

        No change in functionality. So no new test.

        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):
        * svg/SVGMaskElement.h:
        * svg/graphics/SVGResourceMasker.cpp:
        (WebCore::SVGResourceMasker::applyMask):
        * svg/graphics/SVGResourceMasker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-19 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Sat, 19 Dec 2009 21:35:59 +0000 (21:35 +0000)]
2009-12-19  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Add tests to check filter, mask, clip, opacity and marker ordering
        https://bugs.webkit.org/show_bug.cgi?id=14010

        Tests the right order of filter and clipper/masker aplied to a SVG
        object.

        * platform/mac/svg/filters/filter-clip-expected.checksum: Added.
        * platform/mac/svg/filters/filter-clip-expected.png: Added.
        * platform/mac/svg/filters/filter-clip-expected.txt: Added.
        * svg/filters/filter-clip.svg: Added.
2009-12-19  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Add tests to check filter, mask, clip, opacity and marker ordering
        https://bugs.webkit.org/show_bug.cgi?id=14010

        The right ordering for applying effects on objects in SVG is filters,
        clipper/masker and opacity. This patch fixes the order of filter and
        clipper/masker. Opacity and marker need another test.
        This change is according to the SVG Specification:
        http://www.w3.org/TR/SVG11/render.html#Elements

        Test: svg/filters/filter-clip.svg

        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::prepareToRenderSVGContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-19 Daniel Bates <dbates@webkit.org>
eric@webkit.org [Sat, 19 Dec 2009 20:53:19 +0000 (20:53 +0000)]
2009-12-19  Daniel Bates  <dbates@webkit.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=32462

        Added --inspector-frontend flag to build-webkit to copy any changes
        to the inspector front-end files to the built WebCore framework. This
        will make inspector development more consistent with the rest of
        WebKit development.

        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-19 Evan Martin <evan@chromium.org>
eric@webkit.org [Sat, 19 Dec 2009 18:55:25 +0000 (18:55 +0000)]
2009-12-19  Evan Martin  <evan@chromium.org>

        Reviewed by Gustavo Noronha Silva.

        Revert my attempt at making --disable-geolocation work; it is
        more complicated than I anticipated.  (It passed on the build bots
        because they build with --enable-geolocation.)

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoadd forgotten file
otte@webkit.org [Sat, 19 Dec 2009 18:52:09 +0000 (18:52 +0000)]
add forgotten file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaselined test after revision 52335.
otte@webkit.org [Sat, 19 Dec 2009 18:45:37 +0000 (18:45 +0000)]
Rebaselined test after revision 52335.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-19 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Sat, 19 Dec 2009 18:37:56 +0000 (18:37 +0000)]
2009-12-19  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        Tests for https://bugs.webkit.org/show_bug.cgi?id=28153
        can't middle-button paste within a single window

        * LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste-expected.txt: Added
        * LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste.html: Adeed
2009-12-19  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        Fixed the problem when pasting in the same window with the
        middle-button, now we store a reference to the range instead of
        requesting it every time, and we do not release it until the
        clipboard is requested.
        https://bugs.webkit.org/show_bug.cgi?id=28153

        * WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:
        * WebKit/gtk/WebCoreSupport/EditorClientGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-19 MORITA Hajime <morrita@gmail.com>
eric@webkit.org [Sat, 19 Dec 2009 18:30:40 +0000 (18:30 +0000)]
2009-12-19  MORITA Hajime  <morrita@gmail.com>

        Reviewed by Darin Adler.

        WebCore::Range::surroundContents NULL pointer crash.

        https://bugs.webkit.org/show_bug.cgi?id=31684

        * fast/dom/Range/31684-expected.txt: Added.
        * fast/dom/Range/31684.html: Added.
        * fast/dom/Range/script-tests/31684.js: Added.
2009-12-19  MORITA Hajime  <morrita@gmail.com>

        Reviewed by Darin Adler.

        WebCore::Range::surroundContents NULL pointer crash.

        https://bugs.webkit.org/show_bug.cgi?id=31684

        Test: fast/dom/Range/31684.html

        * dom/Range.cpp:
        (WebCore::Range::surroundContents):
        throw exception when parentOfNewParent->parentNode() is NULL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Xan Lopez.
kov@webkit.org [Sat, 19 Dec 2009 18:24:52 +0000 (18:24 +0000)]
Reviewed by Xan Lopez.

Protect download objects when reporting errors, to make sure the
download stays alive between the status change notification, and
the error signal emission.

* webkit/webkitdownload.cpp:
(webkit_download_error):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-19 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Sat, 19 Dec 2009 18:08:28 +0000 (18:08 +0000)]
2009-12-19  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha Silva.

        Don't use an icon for all spelling guess menu items.

        * platform/gtk/ContextMenuItemGtk.cpp:
        (WebCore::gtkStockIDFromContextMenuAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 19 Dec 2009 17:23:15 +0000 (17:23 +0000)]
2009-12-19  Adam Barth  <abarth@webkit.org>

        Unreviewed fixes for me being terrible at python.

        * Scripts/modules/bugzilla.py:
        * Scripts/run-webkit-unittests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Sat, 19 Dec 2009 16:24:32 +0000 (16:24 +0000)]
2009-12-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed build fix. Missing \.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-19 Evan Martin <evan@chromium.org>
eric@webkit.org [Sat, 19 Dec 2009 15:16:01 +0000 (15:16 +0000)]
2009-12-19  Evan Martin  <evan@chromium.org>

        Reviewed by Gustavo Noronha Silva.

        Add a couple of WebKitGtk files to .gitignore.

        * .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-19 Evan Martin <evan@chromium.org>
eric@webkit.org [Sat, 19 Dec 2009 11:52:23 +0000 (11:52 +0000)]
2009-12-19  Evan Martin  <evan@chromium.org>

        Reviewed by Gustavo Noronha Silva.

        Make --disable-geolocation and --disable-svg work, by conditionally
        building the relevant files.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 19 Dec 2009 07:14:07 +0000 (07:14 +0000)]
2009-12-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Split QueueStatus server into modules
        https://bugs.webkit.org/show_bug.cgi?id=32768

        One monolithic file is no good.

        * QueueStatusServer/app.yaml:
        * QueueStatusServer/handlers/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
        * QueueStatusServer/handlers/patchstatus.py: Added.
        * QueueStatusServer/handlers/recentstatus.py: Added.
        * QueueStatusServer/handlers/showresults.py: Added.
        * QueueStatusServer/handlers/statusbubble.py: Added.
        * QueueStatusServer/handlers/updatestatus.py: Added.
        * QueueStatusServer/main.py: Added.
        * QueueStatusServer/model.py: Added.
        * QueueStatusServer/queue_status.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Kenneth Russell <kbr@google.com>
eric@webkit.org [Sat, 19 Dec 2009 07:12:47 +0000 (07:12 +0000)]
2009-12-18  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        [Chromium] Eliminate redundant data copy in GraphicsContext3D readback
        https://bugs.webkit.org/show_bug.cgi?id=32763

        Eliminated useless creation of a CGBitmapContext and from there a
        CGImage. Now create CGImage directly from data. Also changed
        readPixels parameters and CGImage alpha info to try to avoid byte
        swapping, and disabled interpolation when drawing the GL content.
        Some test cases run twice as fast with these changes, though more
        work is needed to achieve desired performance.

        No test case; performance optimization only. Ran WebGL demos from
        Khronos site to verify changes.

        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::reshape):
        (WebCore::GraphicsContext3DInternal::beginPaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Peter Kasting <pkasting@google.com>
eric@webkit.org [Sat, 19 Dec 2009 06:40:22 +0000 (06:40 +0000)]
2009-12-18  Peter Kasting  <pkasting@google.com>

        Reviewed by Simon Fraser.

        Add a comment about some confusing code that otherwise would look like
        it might be a bug.
        https://bugs.webkit.org/show_bug.cgi?id=32534

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateScrollInfoAfterLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 19 Dec 2009 06:33:49 +0000 (06:33 +0000)]
2009-12-18  Adam Barth  <abarth@webkit.org>

        Rubber stamped by Eric Seidel.

        Renamed WorkQueue to QueueEngine.  WorkQueue is not a queue.

        * Scripts/modules/commands/queues.py:
        * Scripts/modules/queueengine.py: Added.
        * Scripts/modules/queueengine_unittest.py: Added.
        * Scripts/modules/stepsequence.py:
        * Scripts/modules/workqueue.py: Removed.
        * Scripts/modules/workqueue_unittest.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 19 Dec 2009 06:05:14 +0000 (06:05 +0000)]
2009-12-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add watches for EWS
        https://bugs.webkit.org/show_bug.cgi?id=32767

        dglazkov wanted to be added.

        * Scripts/modules/bugzilla.py:
        * Scripts/modules/commands/early_warning_system.py:
        * Scripts/modules/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdated localizable strings after r52368
mitz@apple.com [Sat, 19 Dec 2009 06:02:24 +0000 (06:02 +0000)]
Updated localizable strings after r52368

* English.lproj/Localizable.strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 19 Dec 2009 05:14:28 +0000 (05:14 +0000)]
2009-12-18  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Messed up the XCode file, trying to fix.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 19 Dec 2009 04:44:38 +0000 (04:44 +0000)]
2009-12-18  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed, fix typos in WebCore.xcodeproj.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 19 Dec 2009 04:34:57 +0000 (04:34 +0000)]
2009-12-18  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Eric Seidel.

        SVGAngle / SVGPreserveAspectRatio should be POD types
        https://bugs.webkit.org/show_bug.cgi?id=32758

        Convert SVGAngle / SVGPreserveAspectRatio to be non-refcounted types, just
        like it has been done for SVGMatrix / SVGLength before.

        This patch prepares removing the special DOMObjectWithSVGContext hack.
        No change in functionality, thus no new tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix, no review.
dumi@chromium.org [Sat, 19 Dec 2009 02:34:27 +0000 (02:34 +0000)]
Chromium build fix, no review.

* storage/chromium/DatabaseTrackerChromium.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix, no review.
bfulgham@webkit.org [Sat, 19 Dec 2009 02:04:24 +0000 (02:04 +0000)]
Build fix, no review.

* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::createFontPlatformData): Correct my typo
  on the CG build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake DatabaseTrackerChromium::removeOpenDatabase() send and IPC on
dumi@chromium.org [Sat, 19 Dec 2009 02:03:00 +0000 (02:03 +0000)]
Make DatabaseTrackerChromium::removeOpenDatabase() send and IPC on
the main thread when a database is being closed.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32627

* storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::removeOpenDatabaseOnMainThread):
(WebCore::DatabaseTracker::removeOpenDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix, no review.
bfulgham@webkit.org [Sat, 19 Dec 2009 01:59:18 +0000 (01:59 +0000)]
Build fix, no review.

* page/win/FrameCairoWin.cpp: Add missing include.
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::createFontPlatformData): Conditionalize
  Safari-only call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Mac WebKit side of the client based geolocation provider.
weinig@apple.com [Sat, 19 Dec 2009 01:56:45 +0000 (01:56 +0000)]
Add Mac WebKit side of the client based geolocation provider.

Reviewed by Dan Bernstein.

WebKit:

* WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

* Misc/WebKitErrors.m:
(registerErrors): Add Geolocation errors.
* Misc/WebKitErrorsPrivate.h:
* WebCoreSupport/WebGeolocationControllerClient.h: Added.
(WebGeolocationControllerClient::webView):
* WebCoreSupport/WebGeolocationControllerClient.mm: Added.
(WebGeolocationControllerClient::WebGeolocationControllerClient):
(WebGeolocationControllerClient::startUpdating):
(WebGeolocationControllerClient::stopUpdating):
(WebGeolocationControllerClient::lastPosition):
Add implementation of the WebGeolocationControllerClient.

* WebView/WebGeolocationPosition.h: Added.
* WebView/WebGeolocationPosition.mm: Added.
(-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
(core):
(-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
* WebView/WebGeolocationPositionInternal.h: Added.
Add an Objective-C wrapper for GeolocationPosition.

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Set the GeolocationControllerClient.
(-[WebView _setGeolocationProvider:]): Set the GeolocationProvider
(-[WebView _geolocationProvider]): Return the GeolocationProvider.
(-[WebView _geolocationDidChangePosition:]): Notify WebCore that the position changed.
(-[WebView _geolocationDidFailWithError:]): Notify WebCore that an error occured.
* WebView/WebViewData.h:
* WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove some code related to database closing from the destructor to
dumi@chromium.org [Sat, 19 Dec 2009 01:27:14 +0000 (01:27 +0000)]
Move some code related to database closing from the destructor to
the close() method. This would allow us to do things such as post
tasks to other threads when a database closes, which cannot be
done now, because we cannot increment the ref count to a database
object when we're in its destructor.

Reviewed by Dmitry Titov.

https://bugs.webkit.org/show_bug.cgi?id=32626

* storage/Database.cpp:
(WebCore::Database::~Database):
(WebCore::Database::close):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Peter Kasting <pkasting@google.com>
eric@webkit.org [Sat, 19 Dec 2009 00:47:20 +0000 (00:47 +0000)]
2009-12-18  Peter Kasting  <pkasting@google.com>

        Reviewed by Adam Barth.

        Chromium build fix
        https://bugs.webkit.org/show_bug.cgi?id=32756

        * public/WebAccessibilityRole.h:
        (WebKit::):
        * src/AssertMatchingEnums.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 19 Dec 2009 00:33:34 +0000 (00:33 +0000)]
2009-12-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        REGRESSION(52325) Chromium build broken due to link failure
        https://bugs.webkit.org/show_bug.cgi?id=32753

        * WebCoreSupport/WebSystemInterface.m:
         - Chromium Mac builds use this file, but do not
           enable Pre-compiled Header (PCH) files so that
           Chromium build bots can take advantage of the faster
           distcc 3.  Eventually all mac builds will likely use
           distcc, but for now we'll add Platform.h here and document
           its usage so it's not removed by accident.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Sat, 19 Dec 2009 00:29:53 +0000 (00:29 +0000)]
2009-12-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Move some build decisions from Qt build system into source files
        https://bugs.webkit.org/show_bug.cgi?id=31956

        * JavaScriptCore.pri: Compile files unconditionally
        * jit/ExecutableAllocatorPosix.cpp: Guard with PLATFORM(UNIX) && !PLATFORM(SYMBIAN)
        * jit/ExecutableAllocatorWin.cpp: Guard with PLATFORM(WIN_OS)
        * runtime/MarkStackPosix.cpp: Guard with PLATFORM(UNIX) && !PLATFORM(SYMBIAN)
        * runtime/MarkStackSymbian.cpp: Guard with PLATFORM(SYMBIAN)
        * runtime/MarkStackWin.cpp: Guard with PLATFORM(WIN_OS)
        * wtf/Platform.h: Guard ENABLE_JSC_MULTIPLE_THREADS with ENABLE_SINGLE_THREADED for the Qt port
        * wtf/ThreadingNone.cpp: Guard with ENABLE(SINGLE_THREADED)
        * wtf/qt/ThreadingQt.cpp: Guard with !ENABLE(SINGLE_THREADED)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 19 Dec 2009 00:22:34 +0000 (00:22 +0000)]
2009-12-18  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Crash when accessing webkitTransition property after setting webkitTransitionProperty with invalid value.
        https://bugs.webkit.org/show_bug.cgi?id=31559

        Fix an array bounds error when accessing the CSS value for a shorthand property that takes
        a comma-separated list, after the list for one of the component properties has been set to a different length.

        Test: fast/css/shorthand-mismatched-list-crash.html

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r52233): MSAA: Accessibility role of lists is wrong
jhoneycutt@apple.com [Sat, 19 Dec 2009 00:05:59 +0000 (00:05 +0000)]
REGRESSION(r52233): MSAA: Accessibility role of lists is wrong

https://bugs.webkit.org/show_bug.cgi?id=32736

Reviewed by Adam Roben.

WebCore:

Test: platform/win/accessibility/list-role.html

* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::roleValueForMSAA):
Return roleValue(), rather than m_role, as subclasses may override it.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::roleValueForMSAA):
Fallback to roleValue(), rather than m_role, as it may be overriden.

LayoutTests:

* platform/win/accessibility/list-role-expected.txt: Added.
* platform/win/accessibility/list-role.html: Added.
Verify that lists return the "list" role.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMSAA: Accessibility role of list items is wrong
jhoneycutt@apple.com [Sat, 19 Dec 2009 00:05:38 +0000 (00:05 +0000)]
MSAA: Accessibility role of list items is wrong

https://bugs.webkit.org/show_bug.cgi?id=32688

Reviewed by Adam Roben.

WebCore:

Test: platform/win/accessibility/list-item-role.html

* accessibility/AccessibilityObject.h:
(WebCore::):
Add a ListItemRole to the enum.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::msaaRoleForRenderer):
Return the role for the RenderObject, or UnknownRole if unknown.
(WebCore::AccessibilityRenderObject::roleValueForMSAA):
Call msaaRoleForRenderer() to get the role. If it is UnknownRole, fall
back to m_role.

WebKit/win:

* AccessibleBase.cpp:
(MSAARole):
Make the WebCore list item role map to the MSAA list item role.

LayoutTests:

* platform/win/accessibility/list-item-role-expected.txt: Added.
* platform/win/accessibility/list-item-role.html: Added.
Verify that the list item role is "list item".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMSAA: Accessibility role of list markers is wrong
jhoneycutt@apple.com [Sat, 19 Dec 2009 00:05:14 +0000 (00:05 +0000)]
MSAA: Accessibility role of list markers is wrong

https://bugs.webkit.org/show_bug.cgi?id=32687

Reviewed by Adam Roben.

WebKit/win:

* AccessibleBase.cpp:
(MSAARole):
Make the WebCore list marker role map to the MSAA static text role.

LayoutTests:

* platform/win/accessibility/list-marker-role-expected.txt: Added.
* platform/win/accessibility/list-marker-role.html: Added.
Verify that the list marker role is "text".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 19 Dec 2009 00:00:43 +0000 (00:00 +0000)]
2009-12-18  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Mark Rowe.

        Remove WebCore.ClientBasedGeolocation.exp from Sources, and remove two IDL files from Resources.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix part II, this time it's personal.x
bweinstein@apple.com [Fri, 18 Dec 2009 23:57:54 +0000 (23:57 +0000)]
Build fix part II, this time it's personal.x

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFirst step at a Windows build fix, get it to link JavaScriptCore. Might fail later.
bweinstein@apple.com [Fri, 18 Dec 2009 23:46:15 +0000 (23:46 +0000)]
First step at a Windows build fix, get it to link JavaScriptCore. Might fail later.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd createNonCopying method to UString to make replace constructor passed bool,
barraclough@apple.com [Fri, 18 Dec 2009 22:59:18 +0000 (22:59 +0000)]
Add createNonCopying method to UString to make replace constructor passed bool,
to make behaviour more explicit.  Add createFromUTF8 to UString (wrapping method
on UString::Rep), since other cases of transliteration (e.g.  from ascii) are
performed in UString constructors.  Add/use setHash & size() accessors on Rep,
rather than accessing _hash/len directly.

Reviewed by Sam Weinig.

* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
* API/OpaqueJSString.cpp:
(OpaqueJSString::ustring):
* JavaScriptCore.exp:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
* runtime/Identifier.cpp:
(JSC::Identifier::equal):
(JSC::CStringTranslator::translate):
(JSC::UCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
* runtime/JSString.h:
(JSC::JSString::Rope::Fiber::refAndGetLength):
(JSC::JSString::Rope::append):
* runtime/StringBuilder.h:
(JSC::StringBuilder::release):
* runtime/StringConstructor.cpp:
(JSC::stringFromCharCodeSlowCase):
* runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
* runtime/UString.cpp:
(JSC::UString::UString):
(JSC::UString::createNonCopying):
(JSC::UString::createFromUTF8):
* runtime/UString.h:
(JSC::UString::Rep::setHash):
(JSC::UString::~UString):
(JSC::makeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix mac Geolocation build.
weinig@apple.com [Fri, 18 Dec 2009 22:51:42 +0000 (22:51 +0000)]
Fix mac Geolocation build.

* DerivedSources.make:
* WebCore.ClientBasedGeolocation.exp: Added.
* WebCore.xcodeproj/project.pbxproj:
* page/Geolocation.h:
* page/GeolocationError.h:
(WebCore::GeolocationError::GeolocationError):
* page/GeolocationPosition.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix preference key name.
weinig@apple.com [Fri, 18 Dec 2009 22:44:16 +0000 (22:44 +0000)]
Fix preference key name.

Reviewed by Anders Carlsson.

* WebView/WebPreferenceKeysPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChanged Register constructors to assignment operators, to streamline
ggaren@apple.com [Fri, 18 Dec 2009 22:18:11 +0000 (22:18 +0000)]
Changed Register constructors to assignment operators, to streamline
moving values into registers. (In theory, there's no difference between
the two, since the constructor should just inline away, but there seems
to be a big difference in the addled mind of the GCC optimizer.)

Reviewed by Cameron Zwarich and Gavin Barraclough.

In the interpreter, this is a 3.5% SunSpider speedup and a 1K-2K
reduction in stack usage per privateExecute stack frame.

* interpreter/CallFrame.h:
(JSC::ExecState::setCalleeArguments):
(JSC::ExecState::setCallerFrame):
(JSC::ExecState::setScopeChain):
(JSC::ExecState::init):
(JSC::ExecState::setArgumentCount):
(JSC::ExecState::setCallee):
(JSC::ExecState::setCodeBlock): Added a little bit of casting so these
functions could use the new Register assignment operators.

* interpreter/Register.h:
(JSC::Register::withInt):
(JSC::Register::Register):
(JSC::Register::operator=): Swapped in assignment operators for constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPass preference to plug-in host.
andersca@apple.com [Fri, 18 Dec 2009 22:05:34 +0000 (22:05 +0000)]
Pass preference to plug-in host.

Reviewed by Sam Weinig.

* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::spawnPluginHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixes <http://webkit.org/b/32613>.
bweinstein@apple.com [Fri, 18 Dec 2009 21:57:19 +0000 (21:57 +0000)]
Fixes <http://webkit.org/b/32613>.
REGRESSION (r52008): Middle-clicking on a linked image starts a pan scroll,
but should follow the link instead.

Reviewed by Adam Roben.

WebCore:

The node itself isn't the only possible node that can be a link (that was the
original check), any of its ancestors could be links as well, we need to climb
up the tree to see. Created a new function (enclosingAnchorNode), that finds a
node's enclosing anchor element (if it exists), that we can share between RenderLayer
and Node, and also added tests that test pan scrolling behavior in image maps.

Tests: platform/win/fast/events/panScroll-image-no-scroll.html
       platform/win/fast/events/panScroll-imageMap-href-no-scroll.html
       platform/win/fast/events/panScroll-imageMap-noHref-scroll.html

* dom/Node.cpp:
(WebCore::Node::enclosingAnchorNode):
(WebCore::Node::defaultEventHandler):
* dom/Node.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):

LayoutTests:

Added tests that test pan scrolling behavior when you middle click on images with
links, and if you click on parts on image maps that are links, and that aren't.

* platform/win/fast/events/panScroll-image-no-scroll-expected.txt: Added.
* platform/win/fast/events/panScroll-image-no-scroll.html: Added.
* platform/win/fast/events/panScroll-imageMap-href-no-scroll-expected.txt: Added.
* platform/win/fast/events/panScroll-imageMap-href-no-scroll.html: Added.
* platform/win/fast/events/panScroll-imageMap-noHref-scroll-expected.txt: Added.
* platform/win/fast/events/panScroll-imageMap-noHref-scroll.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Ariya Hidayat <ariya.hidayat@gmail.com>
ariya@webkit.org [Fri, 18 Dec 2009 21:55:40 +0000 (21:55 +0000)]
2009-12-18  Ariya Hidayat  <ariya.hidayat@gmail.com>

        Build fix, not reviewed.

        * QtLauncher/main.cpp:
        (MainWindow::setTouchMocking): Leave setTouchMocking as an empty
        function for Qt < 4.6 so that moc still creates a slot for that.
        Otherwise, it would have generated a linker error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 18 Dec 2009 21:45:53 +0000 (21:45 +0000)]
2009-12-18  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        move bugzilla.py off of urllib2
        https://bugs.webkit.org/show_bug.cgi?id=32729

        * Scripts/modules/bugzilla.py: use mechanize for all url fetching.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd WKPCRunSyncOpenPanel implementation.
andersca@apple.com [Fri, 18 Dec 2009 21:43:36 +0000 (21:43 +0000)]
Add WKPCRunSyncOpenPanel implementation.

Reviewed by Sam Weinig.

* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCRunSyncOpenPanel):
* Plugins/Hosted/WebKitPluginClient.defs:
* Plugins/Hosted/WebKitPluginHost.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Yongjun Zhang <yongjun.zhang@nokia.com>
eric@webkit.org [Fri, 18 Dec 2009 21:18:13 +0000 (21:18 +0000)]
2009-12-18  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=32713
        [Qt] make wtf/Assertions.h compile in winscw compiler.

        Add string arg before ellipsis to help winscw compiler resolve variadic
        macro definitions in wtf/Assertions.h.

        * wtf/Assertions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a useProxiedOpenPanel WebPreference and tunnel it through to the plug-in host.
andersca@apple.com [Fri, 18 Dec 2009 21:17:38 +0000 (21:17 +0000)]
Add a useProxiedOpenPanel WebPreference and tunnel it through to the plug-in host.

Reviewed by Sam Weinig.

* Plugins/Hosted/NetscapePluginHostManager.h:
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::hostForPackage):
(WebKit::NetscapePluginHostManager::spawnPluginHost):
(WebKit::NetscapePluginHostManager::instantiatePlugin):
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences usesProxiedOpenPanel]):
(-[WebPreferences setUsesProxiedOpenPanel:]):
* WebView/WebPreferencesPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] RemoveDashboard support. It's useless.
otte@webkit.org [Fri, 18 Dec 2009 20:50:32 +0000 (20:50 +0000)]
[GTK] RemoveDashboard support. It's useless.

* configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed intermittent failure seen on Windows buildbot, and in other JSC
ggaren@apple.com [Fri, 18 Dec 2009 20:46:08 +0000 (20:46 +0000)]
Fixed intermittent failure seen on Windows buildbot, and in other JSC
API clients.

Reviewed by Adam Roben.

Added a WeakGCPtr class and changed OpaqueJSClass::cachedPrototype to
use it, to avoid vending a stale object as a prototype.

* API/JSClassRef.cpp:
(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::prototype):
* API/JSClassRef.h: Use WeakGCPtr.

* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/WeakGCPtr.h: Added.
(JSC::WeakGCPtr::WeakGCPtr):
(JSC::WeakGCPtr::get):
(JSC::WeakGCPtr::clear):
(JSC::WeakGCPtr::operator*):
(JSC::WeakGCPtr::operator->):
(JSC::WeakGCPtr::operator!):
(JSC::WeakGCPtr::operator bool):
(JSC::WeakGCPtr::operator UnspecifiedBoolType):
(JSC::WeakGCPtr::assign):
(JSC::::operator):
(JSC::operator==):
(JSC::operator!=):
(JSC::static_pointer_cast):
(JSC::const_pointer_cast):
(JSC::getPtr): Added WeakGCPtr to the project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a needed export to fix the Windows build.
bweinstein@apple.com [Fri, 18 Dec 2009 20:45:54 +0000 (20:45 +0000)]
Add a needed export to fix the Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Fri, 18 Dec 2009 20:42:42 +0000 (20:42 +0000)]
2009-12-18  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Xan Lopez.

        [GTK] context menu overriding API is very limited
        https://bugs.webkit.org/show_bug.cgi?id=27546

        Omit SearchWeb from the context menu in the GTK+ port.

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd export the new symbol in WebCoreSystemInterface.
weinig@apple.com [Fri, 18 Dec 2009 20:41:23 +0000 (20:41 +0000)]
Add export the new symbol in WebCoreSystemInterface.

Reviewed by Anders Carlsson.

* WebCore.base.exp:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoForward declare NSMutableArray when not compiling for Objective-C.
weinig@apple.com [Fri, 18 Dec 2009 20:26:31 +0000 (20:26 +0000)]
Forward declare NSMutableArray when not compiling for Objective-C.

Reviewed by Anders Carlsson.

* platform/mac/WebCoreSystemInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=32720
barraclough@apple.com [Fri, 18 Dec 2009 20:02:34 +0000 (20:02 +0000)]
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=32720

Reviewed by Sam Weinig.

* JavaScriptCore.exp:
    - Remove exports for UString::append
* JavaScriptCore.xcodeproj/project.pbxproj:
    - Make StringBuilder a private header (was project).

WebCore: https://bugs.webkit.org/show_bug.cgi?id=32720
Replace UString addition/append with use of JSC::StringBuilder.

Reviewed by Sam Weinig.

* ForwardingHeaders/runtime/StringBuilder.h: Added.
* bindings/js/ScriptString.h:
(WebCore::ScriptString::operator+=):
* bridge/jni/jni_runtime.cpp:
(appendClassName):
(JavaMethod::signature):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::addProfileFinishedMessageToConsole):
(WebCore::InspectorController::addStartProfilingMessageToConsole):
(WebCore::InspectorController::getCurrentUserInitiatedProfileName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Fri, 18 Dec 2009 19:55:27 +0000 (19:55 +0000)]
2009-12-18  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] GRefPtr does not take a reference when assigned a raw pointer
        https://bugs.webkit.org/show_bug.cgi?id=32709

        Ensure that when assigning a raw pointer to a GRefPtr, the reference
        count is incremented. Also remove the GRefPtr conversion overload as
        GRefPtr types have necessarily incompatible reference counting.

        * wtf/gtk/GRefPtr.h:
        (WTF::GRefPtr::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Kenneth Russell <kbr@google.com>
eric@webkit.org [Fri, 18 Dec 2009 19:43:18 +0000 (19:43 +0000)]
2009-12-18  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Index validation for drawElements examines too many indices
        https://bugs.webkit.org/show_bug.cgi?id=32692

        * fast/canvas/webgl/bug-32692-expected.txt: Added.
        * fast/canvas/webgl/bug-32692.html: Added.
2009-12-18  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Index validation for drawElements examines too many indices
        https://bugs.webkit.org/show_bug.cgi?id=32692

        Test: fast/canvas/webgl/bug-32692.html

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Fri, 18 Dec 2009 19:36:06 +0000 (19:36 +0000)]
2009-12-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Xan Lopez.

        Disable page cache for tests.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (copyWebSettingKey):
        (LayoutTestController::overridePreference):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Update WebKitSystemInterface for <rdar://problem/7237059>.
weinig@apple.com [Fri, 18 Dec 2009 19:22:44 +0000 (19:22 +0000)]
WebCore: Update WebKitSystemInterface for <rdar://problem/7237059>.

Reviewed by Anders Carlsson.

* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

WebKit/mac: Update WebKitSystemInterface for <rdar://problem/7237059>.

Reviewed by Anders Carlsson.

* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):

WebKitLibraries: Update WebKitSystemInterface for <rdar://problem/7237059>.

Reviewed by Anders Carlsson.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Adam Roben.
bweinstein@apple.com [Fri, 18 Dec 2009 19:16:19 +0000 (19:16 +0000)]
Rubber-stamped by Adam Roben.

Add expected failing results for fast/dom/Element/id-in-deleteutton.html.
The progress of fixing the failure is being tracked by:
<https://bugs.webkit.org/show_bug.cgi?id=32727>.

* platform/win/fast/dom/Element: Added.
* platform/win/fast/dom/Element/id-in-deletebutton-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 18 Dec 2009 18:48:35 +0000 (18:48 +0000)]
2009-12-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Fix gtk-doc of webkit_web_resource_new.

        * webkit/webkitwebresource.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGTK build fix
aroben@apple.com [Fri, 18 Dec 2009 18:35:27 +0000 (18:35 +0000)]
GTK build fix

* plugins/gtk/PluginViewGtk.cpp: Added #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fixes
aroben@apple.com [Fri, 18 Dec 2009 18:00:52 +0000 (18:00 +0000)]
Build fixes

WebCore: Chromium build fix

* platform/chromium/PopupMenuChromium.cpp: Added #include.

WebKit/chromium: Chromium build fix

* src/ChromiumBridge.cpp:
* src/WebPluginContainerImpl.cpp:
* src/WebViewImpl.cpp:
Added #includes.

WebKit/qt: Qt build fix

* Api/qwebpage.cpp: Added #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix
aroben@apple.com [Fri, 18 Dec 2009 17:54:24 +0000 (17:54 +0000)]
Chromium build fix

* html/HTMLLinkElement.cpp: Added #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoQt build fix
aroben@apple.com [Fri, 18 Dec 2009 17:52:35 +0000 (17:52 +0000)]
Qt build fix

WebCore:

* platform/qt/RenderThemeQt.cpp:
* plugins/qt/PluginDataQt.cpp:
* plugins/qt/PluginViewQt.cpp:
Added #includes.

WebKit/qt:

* Api/qwebpage.cpp:
Added #includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 18 Dec 2009 17:47:21 +0000 (17:47 +0000)]
2009-12-18  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by David Levin.

        Check one space before end of line comments.
        https://bugs.webkit.org/show_bug.cgi?id=32597

        Fix to check one space before end of line comments in whitespace and build/header_guard.
        Also fix build/header_guard to use WebKit header guard defines.

        * Scripts/modules/cpp_style.py:
        * Scripts/modules/cpp_style_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoV8 build fix
aroben@apple.com [Fri, 18 Dec 2009 17:47:09 +0000 (17:47 +0000)]
V8 build fix

* bindings/v8/custom/V8DOMWindowCustom.cpp: Added #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGTK build fix
aroben@apple.com [Fri, 18 Dec 2009 17:45:38 +0000 (17:45 +0000)]
GTK build fix

* webkit/webkitprivate.cpp: Added #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGTK (and others?) build fix
aroben@apple.com [Fri, 18 Dec 2009 17:42:33 +0000 (17:42 +0000)]
GTK (and others?) build fix

* platform/text/StringImpl.h: Added #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReduce #includes in a few high-use headers
aroben@apple.com [Fri, 18 Dec 2009 17:38:45 +0000 (17:38 +0000)]
Reduce #includes in a few high-use headers

Removed unnecessary #includes in these headers:
  - Frame.h
  - FrameWin.h
  - Node.h
  - Page.h
  - StringImpl.h

The rest of the patch is all adding #includes to source files that now
require them.

Fixes <http://webkit.org/b/32718>.

Rubber-stamped by Anders Carlsson.

WebCore:

* dom/Node.h:
* page/Frame.h:
* page/Page.h:
* page/win/FrameWin.h:
* platform/text/StringImpl.h:
Removed unnecessary #includes.

* accessibility/win/AXObjectCacheWin.cpp:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowCustom.cpp:
* dom/Document.cpp:
* dom/InputElement.cpp:
* dom/Node.cpp:
* dom/SelectElement.cpp:
* editing/EditorCommand.cpp:
* html/HTMLFormControlElement.cpp:
* html/HTMLFormElement.cpp:
* html/HTMLMediaElement.cpp:
* html/HTMLParser.cpp:
* html/HTMLTextAreaElement.cpp:
* html/HTMLVideoElement.cpp:
* inspector/InspectorController.cpp:
* loader/FrameLoader.cpp:
* loader/HistoryController.cpp:
* loader/appcache/ApplicationCacheGroup.cpp:
* page/Console.cpp:
* page/EventHandler.cpp:
* page/Frame.cpp:
* page/FrameView.cpp:
* page/Navigator.cpp:
* page/PageGroup.cpp:
* page/Settings.cpp:
* page/mac/EventHandlerMac.mm:
* platform/KURL.h:
* platform/ScrollbarThemeComposite.cpp:
* platform/cf/BinaryPropertyList.cpp:
* platform/graphics/mac/GraphicsLayerCA.h:
* platform/graphics/win/WKCACFLayerRenderer.cpp:
* platform/mac/PopupMenuMac.mm:
* platform/mac/WidgetMac.mm:
* platform/network/cf/DNSCFNet.cpp:
* platform/text/StringImpl.cpp:
* platform/win/FileSystemWin.cpp:
* platform/win/PlatformScreenWin.cpp:
* platform/win/PopupMenuWin.cpp:
* platform/win/WidgetWin.cpp:
* plugins/PluginView.cpp:
* plugins/win/PluginViewWin.cpp:
* rendering/InlineTextBox.cpp:
* rendering/RenderBox.cpp:
* rendering/RenderFileUploadControl.cpp:
* rendering/RenderInline.cpp:
* rendering/RenderLayerCompositor.cpp:
* rendering/RenderObject.cpp:
* rendering/RootInlineBox.cpp:
* storage/DatabaseTracker.cpp:
* storage/DatabaseTracker.h:
* storage/SQLTransactionClient.cpp:
* svg/graphics/SVGImage.cpp:
Added now-needed #includes.

WebKit/mac:

Add #includes needed after WebCore clean-up

* WebView/WebFrame.mm:
* WebView/WebFrameView.mm:
* WebView/WebView.mm:

WebKit/win:

Add #includes needed after WebCore clean-up

* WebCoreSupport/WebContextMenuClient.cpp:
* WebDataSource.cpp:
* WebHTMLRepresentation.cpp:
* WebView.cpp:
* WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Clean up the qmake build system to distinguish between trunk builds and package...
hausmann@webkit.org [Fri, 18 Dec 2009 17:06:24 +0000 (17:06 +0000)]
[Qt] Clean up the qmake build system to distinguish between trunk builds and package builds

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=32716

.:

* WebKit.pri: Use standalone_package instead of QTDIR_build

JavaScriptCore:

* pcre/pcre.pri: Use standalone_package instead of QTDIR_build

WebCore:

Introduce standalone_package as config that is set when QTDIR_build is set or when
the directory for the generated files is present.

Renamed uses of QTDIR_build that apply to generic package builds to use standalone_package.
Others remain as they are specific to building inside Qt.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Fri, 18 Dec 2009 16:40:57 +0000 (16:40 +0000)]
2009-12-18  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Darin Adler.

        New test cases for isId support.
        https://bugs.webkit.org/show_bug.cgi?id=5578

        * dom/xhtml/level3/core/attrisid04-expected.txt:
        * dom/xhtml/level3/core/attrisid04.js:
        (setUpPage):
        * dom/xhtml/level3/core/attrisid05-expected.txt:
        * dom/xhtml/level3/core/attrisid05.js:
        (setUpPage):
        * fast/dom/Element/attrisid-extra01-expected.txt: Added.
        * fast/dom/Element/attrisid-extra01.html: Added.
        * fast/dom/Element/id-in-applet-expected.txt: Added.
        * fast/dom/Element/id-in-applet.html: Added.
        * fast/dom/Element/id-in-deletebutton-expected.txt: Added.
        * fast/dom/Element/id-in-deletebutton.html: Added.
        * fast/dom/Element/id-in-formcollection-expected.txt: Added.
        * fast/dom/Element/id-in-formcollection.html: Added.
        * fast/dom/Element/id-in-frame-expected.txt: Added.
        * fast/dom/Element/id-in-frame.html: Added.
        * fast/dom/Element/id-in-frameset-expected.txt: Added.
        * fast/dom/Element/id-in-frameset.html: Added.
        * fast/dom/Element/id-in-getelement01-expected.txt: Added.
        * fast/dom/Element/id-in-getelement01.html: Added.
        * fast/dom/Element/id-in-insert-hr-expected.txt: Added.
        * fast/dom/Element/id-in-insert-hr.html: Added.
        * fast/dom/Element/id-in-map-expected.txt: Added.
        * fast/dom/Element/id-in-map.html: Added.
        * fast/dom/Element/id-in-param-expected.txt: Added.
        * fast/dom/Element/id-in-param.html: Added.
2009-12-18  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Darin Adler.

        Implemented isId as specified by DOM Level 3. See detailed description below.
        https://bugs.webkit.org/show_bug.cgi?id=5578

        Added isId property and implementation:
        Tests: dom/xhtml/level3/core/attrisid01-07.xhtml
               fast/dom/Element/attrisid-extra01.html
        * dom/Attr.cpp:
        (WebCore::Attr::isId):
        * dom/Attr.h:
        * dom/Attr.idl:

        Replaced instances of HTMLNames::idAttr with Element::idAttributeName()
        for the reason that id attribute name could be customized to a different
        string other than "id". A test case is associated to each code change.
        * dom/Document.cpp:
        (WebCore::Document::getElementById): Test: fast/dom/Element/id-in-getelement01.html
        * dom/Element.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml
        (WebCore::Element::setAttribute):
        (WebCore::Element::setAttributeMap):
        (WebCore::Element::insertedIntoDocument):
        (WebCore::Element::removedFromDocument):
        (WebCore::Element::formatForDebugger):
        (WebCore::Element::rareIDAttributeName):
        * dom/Element.h: Added function idAttributeName().
        (WebCore::Element::idAttributeName):
        * dom/ElementRareData.h: Added member variable to store customized id name in ElementRareData.
        (WebCore::ElementRareData::ElementRareData):
        * dom/NamedAttrMap.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml
        (WebCore::NamedNodeMap::setNamedItem):
        (WebCore::NamedNodeMap::removeNamedItem):
        (WebCore::NamedNodeMap::setAttributes):
        * dom/Node.cpp: Removed ASSERT as it may not hold any more.
        (WebCore::Node::querySelector):
        * dom/SelectorNodeList.cpp: Removed ASSERT as it may not hold any more.
        (WebCore::createSelectorNodeList):
        * dom/StyledElement.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml
        (WebCore::StyledElement::parseMappedAttribute):
        * editing/DeleteButtonController.cpp: Test: fast/dom/Element/id-in-deletebutton.html
        (WebCore::DeleteButtonController::createDeletionUI):
        * editing/EditorCommand.cpp: Test: fast/dom/Element/id-in-insert-hr.html
        (WebCore::executeInsertHorizontalRule):
        * html/HTMLAppletElement.cpp: Test: fast/dom/Element/id-in-applet.html
        (WebCore::HTMLAppletElement::parseMappedAttribute):
        (WebCore::HTMLAppletElement::createRenderer):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::checkForNameMatch): Test: fast/forms/select-namedItem.html
        (WebCore::HTMLCollection::updateNameCache): Test: fast/dom/collection-namedItem-via-item.html
        * html/HTMLDataGridColElement.cpp:
        (WebCore::HTMLDataGridColElement::ensureColumn): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom.html
        (WebCore::HTMLDataGridColElement::parseMappedAttribute): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::parseMappedAttribute):
        * html/HTMLFormCollection.cpp: Test: fast/dom/Element/id-in-formcollection.html
        (WebCore::HTMLFormCollection::getNamedFormItem):
        (WebCore::HTMLFormCollection::nextNamedItem):
        (WebCore::HTMLFormCollection::updateNameCache):
        * html/HTMLFrameElementBase.cpp: Test: fast/dom/Element/id-in-frame.html
        (WebCore::HTMLFrameElementBase::parseMappedAttribute):
        (WebCore::HTMLFrameElementBase::setNameAndOpenURL):
        * html/HTMLImageElement.cpp: Test: fast/dom/Element/id-in-deletebutton.html
        (WebCore::HTMLImageElement::parseMappedAttribute):
        * html/HTMLMapElement.cpp: Test: fast/dom/Element/id-in-map.html
        (WebCore::HTMLMapElement::parseMappedAttribute):
        * html/HTMLNameCollection.cpp: Test: fast/dom/Element/id-in-frameset.html
        (WebCore::HTMLNameCollection::itemAfter):
        * html/HTMLObjectElement.cpp: Test: fast/dom/HTMLDocument/object-by-name-or-id.html
        (WebCore::HTMLObjectElement::parseMappedAttribute):
        * html/HTMLParamElement.cpp: Test: fast/dom/Element/id-in-param.html
        (WebCore::HTMLParamElement::parseMappedAttribute):
        * loader/CachedFont.cpp: Test: svg/custom/acid3-test-77.html
        (WebCore::CachedFont::getSVGFontById):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::createGraphicsLayer): Debug-only code
        * rendering/SVGRenderTreeAsText.cpp: Test: svg/text/text-gradient-positioning.svg
        (WebCore::writeRenderResources):
        * svg/SVGElement.cpp: Test: svg/custom/acid3-test-77.html
        (WebCore::SVGElement::insertedIntoDocument):
        * svg/SVGStyledElement.cpp: Test: svg/custom/js-update-image-and-display.svg
        (WebCore::SVGStyledElement::isKnownAttribute):
        * wml/WMLElement.cpp:
        (WebCore::WMLElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Joe Ligman <joseph.ligman@nokia.com>
eric@webkit.org [Fri, 18 Dec 2009 15:04:00 +0000 (15:04 +0000)]
2009-12-18  Joe Ligman  <joseph.ligman@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Add new API to QWebFrame to scrollRecursively starting with any css overflow
        then checking current frame and then ancestors
        https://bugs.webkit.org/show_bug.cgi?id=32668

        * Api/qwebframe.cpp:
        (QWebFramePrivate::scrollOverflow):
        (QWebFrame::scrollRecursively):
        * Api/qwebframe.h:
        * Api/qwebframe_p.h:
        * tests/qwebframe/qwebframe.qrc:
        * tests/qwebframe/testiframe.html: Added.
        * tests/qwebframe/testiframe2.html: Added.
        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix the build on Symbian.
hausmann@webkit.org [Fri, 18 Dec 2009 14:03:51 +0000 (14:03 +0000)]
[Qt] Fix the build on Symbian.

Reviewed by Tor Arne Vestbø.

Use QFont::lastRestortFamily() instead of QFont::lastRestortFont(),
which is a missing symbol in Qt 4.6.0 on Symbian.

Functionally they should be equivalent, according to the source.

* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 18 Dec 2009 14:01:19 +0000 (14:01 +0000)]
2009-12-18  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] segfault during controls initialization if not GTK theme is present.
        https://bugs.webkit.org/show_bug.cgi?id=32705

        Create empty images for the controls if no GTK theme is set.

        * platform/graphics/gtk/ImageGtk.cpp:
        (WebCore::getThemeIconFileName):
        (WebCore::loadImageFromFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert r52305, since it breaks many http tests. We will try a better
kov@webkit.org [Fri, 18 Dec 2009 13:38:22 +0000 (13:38 +0000)]
Revert r52305, since it breaks many http tests. We will try a better
solution for Soup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix infinite recursion in touch mocking.
hausmann@webkit.org [Fri, 18 Dec 2009 13:32:53 +0000 (13:32 +0000)]
[Qt] Fix infinite recursion in touch mocking.

Reviewed by Tor Arne Vestbø.

Don't send the fake touch events to the view, as that'll trigger the
event filter again.

* QtLauncher/main.cpp:
(MainWindow::sendTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Kalle Vahlman <kalle.vahlman@movial.com> and Alejandro G. Castro <alex...
eric@webkit.org [Fri, 18 Dec 2009 12:00:29 +0000 (12:00 +0000)]
2009-12-18  Kalle Vahlman  <kalle.vahlman@movial.com> and Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Add enable-page-cache property to WebSettings for disabling the Page Cache

        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::):
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove the fragment identifier from url before passing it to libsoup.
otte@webkit.org [Fri, 18 Dec 2009 10:51:35 +0000 (10:51 +0000)]
Remove the fragment identifier from url before passing it to libsoup.

In newer releases libsoup emits a warning when it gets handed a
fragment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Fri, 18 Dec 2009 10:37:51 +0000 (10:37 +0000)]
2009-12-18  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Compile warning from line 29 of GRefPtr.cpp
        https://bugs.webkit.org/show_bug.cgi?id=32703

        Fix memory leak and compiler warning in GRefPtr GHashTable template
        specialization.

        * wtf/gtk/GRefPtr.cpp:
        (WTF::refGPtr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Fri, 18 Dec 2009 09:50:26 +0000 (09:50 +0000)]
2009-12-18  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Darin Adler.

        REGRESSION (r38898): Using the up arrow in a textarea gets "stuck"
        at the beginning.
        https://bugs.webkit.org/show_bug.cgi?id=31920

        Added test showing the problem described in the bug.

        * editing/selection/wrapped-line-caret-3.html:
        * editing/selection/wrapped-line-caret-3-expected.txt:
2009-12-18  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Darin Adler.

        REGRESSION (r38898): Using the up arrow in a textarea gets "stuck"
        at the beginning.
        https://bugs.webkit.org/show_bug.cgi?id=31920

        Moving up from a position after the end of the previous lines
        should use UPSTREAM affinity to render the caret in the previous
        line.

        Test: editing/selection/wrapped-line-caret-3.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::positionForPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 18 Dec 2009 07:17:12 +0000 (07:17 +0000)]
2009-12-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Adler.

        HTMLInputElement::stepMismatch() uses ambiguous overload of pow()
        https://bugs.webkit.org/show_bug.cgi?id=32675

        Use the double constant 2.0 instead of static_cast<double>(2).

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::stepMismatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Dirk Pranke <dpranke@chromium.org>
eric@webkit.org [Fri, 18 Dec 2009 06:39:50 +0000 (06:39 +0000)]
2009-12-17  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        Upstreaming an XSS test from chromium.org.
        https://bugs.webkit.org/show_bug.cgi?id=32685

        * http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt: Added.
        * http/tests/security/xss-DENIED-assign-location-href-javascript.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Justin Schuh <jschuh@chromium.org>
eric@webkit.org [Fri, 18 Dec 2009 06:12:35 +0000 (06:12 +0000)]
2009-12-17  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dan Bernstein.

        Bug 32357: SVG test case crashes WebKit (invalid font URL)
        https://bugs.webkit.org/show_bug.cgi?id=32357

        Added check for NULL return value from DocLoader::requestFont()

        * svg/text/text-font-uri-invalid-expected.txt: Added.
        * svg/text/text-font-uri-invalid.svg: Added.
2009-12-17  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dan Bernstein.

        Bug 32357: SVG test case crashes WebKit (invalid font URL)
        https://bugs.webkit.org/show_bug.cgi?id=32357

        Added check for NULL return value from DocLoader::requestFont()

        * svg/SVGFontFaceUriElement.cpp:
        (WebCore::SVGFontFaceUriElement::loadFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 18 Dec 2009 05:42:26 +0000 (05:42 +0000)]
2009-12-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        marquee with display:inline causes crash
        https://bugs.webkit.org/show_bug.cgi?id=32374

        * fast/inline/inline-marquee-crash-expected.txt: Added.
        * fast/inline/inline-marquee-crash.html: Added.
2009-12-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        marquee with display:inline causes crash
        https://bugs.webkit.org/show_bug.cgi?id=32374

        Test: fast/inline/inline-marquee-crash.html

        * html/HTMLMarqueeElement.cpp:
        (WebCore::HTMLMarqueeElement::start):
        (WebCore::HTMLMarqueeElement::stop):
        (WebCore::HTMLMarqueeElement::suspend):
        (WebCore::HTMLMarqueeElement::resume):
        (WebCore::HTMLMarqueeElement::renderMarquee):
        * html/HTMLMarqueeElement.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::styleChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: Add BUILDING_ON_SNOW_LEOPARD and TARGETING_SNOW_LEOPARD #defines.
weinig@apple.com [Fri, 18 Dec 2009 04:14:02 +0000 (04:14 +0000)]
JavaScriptCore: Add BUILDING_ON_SNOW_LEOPARD and TARGETING_SNOW_LEOPARD #defines.

Reviewed by Mark Rowe.

* wtf/Platform.h:

WebKitTools: Add BUILDING_ON_SNOW_LEOPARD #define.

Reviewed by Mark Rowe.

* DumpRenderTree/mac/DumpRenderTreeMac.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Unskip websocket tests
ukai@chromium.org [Fri, 18 Dec 2009 04:12:50 +0000 (04:12 +0000)]
Unreviewed. Unskip websocket tests

New pywebsocket (0.4.5) landed at WebKit r52296, so
sub-protocol-with-space.html should pass.

* platform/mac/Skipped: delete websocket/tests/sub-protocol-with-space.html
* platform/win/Skipped: delete websocket/tests/sub-protocol-with-space.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Yuzo Fujishima <yuzo@google.com>
ukai@chromium.org [Fri, 18 Dec 2009 02:38:01 +0000 (02:38 +0000)]
2009-12-17  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Alexey Proskuryakov.

        Update pywebsocket to 0.4.5 and make handshake checking stricter
        https://bugs.webkit.org/show_bug.cgi?id=32249

        * Scripts/run-webkit-tests:
        * pywebsocket/mod_pywebsocket/handshake.py:
        * pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
        * pywebsocket/mod_pywebsocket/standalone.py:
        * pywebsocket/setup.py:
        * pywebsocket/test/test_handshake.py:
        * pywebsocket/test/test_memorizingfile.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 18 Dec 2009 01:28:27 +0000 (01:28 +0000)]
2009-12-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Command.show_in_main_help should default to False
        https://bugs.webkit.org/show_bug.cgi?id=32686

        * Scripts/modules/commands/download.py:
        * Scripts/modules/commands/queries.py:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/commands/upload.py:
        * Scripts/modules/multicommandtool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Zoltan Horvath <zoltan@webkit.org>
eric@webkit.org [Fri, 18 Dec 2009 00:51:13 +0000 (00:51 +0000)]
2009-12-17  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for inspector's classes
        https://bugs.webkit.org/show_bug.cgi?id=32660

        Inherits the following classes from Noncopyable because these are
        instantiated by 'new' and no need to be copyable:

        class name                  - instantiated at:  WebCore/'location'

        class JavaScriptDebugServer - inspector/JavaScriptDebugServer.cpp:72
        class ConsoleMessage        - inspector/InspectorController.cpp:329
        class InspectorController   - page/Page.cpp:119

        * inspector/ConsoleMessage.h:
        * inspector/InspectorController.h:
        * inspector/JavaScriptDebugServer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 17 Dec 2009 23:22:35 +0000 (23:22 +0000)]
2009-12-17  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52291.
        http://trac.webkit.org/changeset/52291
        https://bugs.webkit.org/show_bug.cgi?id=32618

        Darin Fisher points out that this will likely break
        the SSL security indicator in Chromium.  Rolling out for now.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Steve Block <steveblock@google.com>
eric@webkit.org [Thu, 17 Dec 2009 22:37:17 +0000 (22:37 +0000)]
2009-12-17  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        Fixes HTMLInputElement::stepMismatch() to avoid ambiguous overload of pow().
        https://bugs.webkit.org/show_bug.cgi?id=32675

        Build fix only, no new tests.

        * html/HTMLInputElement.cpp: Modified.
        (WebCore::HTMLInputElement::stepMismatch): Cast first argument of pow to double to force 'double pow(double, int)'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Thu, 17 Dec 2009 22:14:38 +0000 (22:14 +0000)]
2009-12-17  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Eric Seidel.

        Disable memory cache client calls so that a new identifier isn't created
        for the same resource on reload.

        With the calls enabled, duplicate entries for cached resources are created
        in the Web Inspector. Safari for Windows disables the calls near the point of the
        Frame instance creation, and we just follow this for Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=32618

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Thu, 17 Dec 2009 22:10:30 +0000 (22:10 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52290 268f45cc-cd09-0410-ab3c-d52691b4dbfc