WebKit-https.git
7 years agoCSP reports should send an empty 'referrer' rather than nothing.
commit-queue@webkit.org [Thu, 20 Sep 2012 18:52:31 +0000 (18:52 +0000)]
CSP reports should send an empty 'referrer' rather than nothing.
https://bugs.webkit.org/show_bug.cgi?id=97233

Patch by Mike West <mkwst@chromium.org> on 2012-09-20
Reviewed by Adam Barth.

Source/WebCore:

Currently, if a protected resource doesn't have a referrer, then any
Content Security Policy violations send a report that doesn't contain
a referrer attribute. It's arguably friendlier to developers to include
an explicitly empty attribute.

This new behavior is covered by updates to existing test expectations
around the reporting functionality.

* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
    Drop the 'if', and always write out a referrer.

LayoutTests:

* http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
* http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt:
* http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt:
* http/tests/security/contentSecurityPolicy/report-only-expected.txt:
* http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
* http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
    Adding the empty 'referrer' attribute to the expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd WK2-specific result for this frame-flattening test (seems to be a scrollbars...
simon.fraser@apple.com [Thu, 20 Sep 2012 18:42:23 +0000 (18:42 +0000)]
Add WK2-specific result for this frame-flattening test (seems to be a scrollbars difference).
Tracked by https://bugs.webkit.org/show_bug.cgi?id=97240.

* platform/mac-wk2/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: layout test results doesn't show diffs
dpranke@chromium.org [Thu, 20 Sep 2012 18:41:46 +0000 (18:41 +0000)]
REGRESSION: layout test results doesn't show diffs
https://bugs.webkit.org/show_bug.cgi?id=97182

Reviewed by Ojan Vafai.

Go back to storing TEXT, AUDIO, and IMAGE+TEXT in results.json
so that results.html (and hopefully garden-o-matic) can
determine which things actually failed. However, we keep mapping
these results to Failure so that we still only have a single
expectation type for them.

* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
(TestExpectations):
(TestExpectations.result_was_expected):
* Scripts/webkitpy/layout_tests/models/test_failures.py:
(determine_result_type):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_missing_and_unexpected_results):
(MainTest.test_retrying_and_flaky_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[MathML] Increase visual space around fraction parts, italic variables, and operators
dbarton@mathscribe.com [Thu, 20 Sep 2012 18:27:15 +0000 (18:27 +0000)]
[MathML] Increase visual space around fraction parts, italic variables, and operators
https://bugs.webkit.org/show_bug.cgi?id=97228

Reviewed by Eric Seidel.

Source/WebCore:

This makes MathML more readable, and more in agreement with Firefox and TeX.

Tested by existing tests.

* css/mathml.css:
(mfrac > :first-child):
(mfrac > :last-child):
(mfrac):
(mi):
(msub > mi:first-child, msubsup > mi:first-child):
    - Subscripts don't need to move right after an italic <mi>.
(msubsup > mi:first-child + * + *):
    - Superscripts do need to move right after an italic <mi>.
(math > mo, mrow > mo, msqrt > mo, mtd > mo):
    - These are ok values for now. It will be better to use different values for different operators, as the FIXME says.
(math > mo:last-child, mrow > mo:last-child, msqrt > mo:last-child, mtd > mo:last-child):
    - Prefix and postfix operators, including fences, generally get less spacing than infix operators.

* rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::createMathMLOperator):
    - Usually the separator is a comma or semicolon, so we only put space after it for now.
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
(WebCore::RenderMathMLFenced::styleDidChange):
* rendering/mathml/RenderMathMLFenced.h:
(RenderMathMLFenced):

* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore):
(WebCore::RenderMathMLFraction::updateFromElement):
    - gDenominatorPad is now handled by mathml.css.

* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore):
(WebCore::RenderMathMLSubSup::fixScriptsStyle):
    - gSubsupScriptMargin is now handled by mathml.css.

LayoutTests:

* platform/mac/mathml/presentation/attributes-expected.png:
* platform/mac/mathml/presentation/attributes-expected.txt:
* platform/mac/mathml/presentation/fenced-expected.png:
* platform/mac/mathml/presentation/fenced-expected.txt:
* platform/mac/mathml/presentation/fenced-mi-expected.png:
* platform/mac/mathml/presentation/fenced-mi-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.png:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/mo-expected.png:
* platform/mac/mathml/presentation/mo-expected.txt:
* platform/mac/mathml/presentation/mo-stretch-expected.png:
* platform/mac/mathml/presentation/mo-stretch-expected.txt:
* platform/mac/mathml/presentation/mroot-pref-width-expected.png:
* platform/mac/mathml/presentation/mroot-pref-width-expected.txt:
* platform/mac/mathml/presentation/over-expected.png:
* platform/mac/mathml/presentation/over-expected.txt:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.png:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/row-expected.png:
* platform/mac/mathml/presentation/row-expected.txt:
* platform/mac/mathml/presentation/style-expected.png:
* platform/mac/mathml/presentation/style-expected.txt:
* platform/mac/mathml/presentation/sub-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.png:
* platform/mac/mathml/presentation/subsup-expected.txt:
* platform/mac/mathml/presentation/sup-expected.png:
* platform/mac/mathml/presentation/sup-expected.txt:
* platform/mac/mathml/presentation/tokenElements-expected.png:
* platform/mac/mathml/presentation/tokenElements-expected.txt:
* platform/mac/mathml/presentation/under-expected.txt:
* platform/mac/mathml/presentation/underover-expected.png:
* platform/mac/mathml/presentation/underover-expected.txt:
* platform/mac/mathml/xHeight-expected.png:
* platform/mac/mathml/xHeight-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Extend UserMediaRequest with a ownerDocument method
tommyw@google.com [Thu, 20 Sep 2012 18:23:13 +0000 (18:23 +0000)]
MediaStream API: Extend UserMediaRequest with a ownerDocument method
https://bugs.webkit.org/show_bug.cgi?id=97095

Reviewed by Adam Barth.

Source/WebCore:

Chromium need to know exactly which frame called getUserMedia so that it can
clean away the stream when the frame goes away.
Since that information is available in webkit add an accessor method.

Chromium mock class extended to test the added method.

* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::ownerDocument):
(WebCore):
* Modules/mediastream/UserMediaRequest.h:
(WebCore):
(UserMediaRequest):

Source/WebKit/chromium:

Chromium need to know exactly which frame called getUserMedia so that it can clean
away the stream when the frame goes away.
Since that information is available in webkit add an accessor method.

Also taking the opportunity to remove an unused deprecated method,
and adding asserts in case the object is empty.

* public/WebUserMediaRequest.h:
(WebKit):
(WebUserMediaRequest):
* src/WebUserMediaRequest.cpp:
(WebKit::WebUserMediaRequest::ownerDocument):

Tools:

Extending WebUserMediaClientMock to check that the owning document is valid,
and that the document has a frame.

* DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(WebKit::WebUserMediaClientMock::requestUserMedia):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrevent reading stale data from InlineTextBoxes
leviw@chromium.org [Thu, 20 Sep 2012 18:20:26 +0000 (18:20 +0000)]
Prevent reading stale data from InlineTextBoxes
https://bugs.webkit.org/show_bug.cgi?id=94750

Reviewed by Eric Seidel.

Text from dirty InlineTextBoxes should never be read or used. This change enforces this
design goal by forcefully zero-ing out the start and length of InlineTextBoxes when
they're being marked dirty. It also adds asserts to accessors for those members.

This change involves making markDirty virtual. Running the line-layout performance test
as well as profiling resizing the html5 spec showed negligable impact with this change.

No new tests as this doesn't change any proper behavior.

* rendering/InlineBox.h:
(WebCore::InlineBox::markDirty): Making virtual to allow InlineTextBox to overload and
zero out its start and length.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::markDirty): Zeroing out start and length when we mark the box dirty.
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::start): Adding an assert when we hit this case.
(WebCore::InlineTextBox::end): Ditto.
(WebCore::InlineTextBox::len): Ditto.
(WebCore::InlineTextBox::offsetRun): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport paths in Content Security Policy directives.
commit-queue@webkit.org [Thu, 20 Sep 2012 18:11:19 +0000 (18:11 +0000)]
Support paths in Content Security Policy directives.
https://bugs.webkit.org/show_bug.cgi?id=89750

Patch by Mike West <mkwst@chromium.org> on 2012-09-20
Reviewed by Adam Barth.

Source/WebCore:

In CSP 1.0, paths are simply ignored: 'script-src
http://example.com/path/to/a/file' would allow script to be loaded from
http://example.com/path/to/a/file/javascript.js, but also from
http://example.com/javascript.js.

This patch is an experimental implementation of more granular path
support in CSP source lists as proposed in the current editor's draft of
CSP 1.1. Paths are treated as specifying directories in which resources
can be found, and are implicitly terminated with a '/': in other words,
'script-src http://a.com/path' is the same as
'script-src http://a.com/path/'. Moreover, paths cannot contain either
'?' or '#' characters.

This is implemented outside the CSP_NEXT flag. All ports will be
effected.

Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#matching

Tests: http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01.html
       http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02.html

* page/ContentSecurityPolicy.cpp:
(WebCore::CSPSource::CSPSource):
    Store a path along with each CSP source.
(WebCore::CSPSource::matches):
    Check the path when comparing a URL to the source.
(WebCore::CSPSource::pathMatches):
    Compare the URL-decoded version of the resource to validate against
    the source's stored path. If the resource's path begins with the
    stored path, then it matches! If not, it doesn't.
(CSPSource):
    Store a path along with each CSP source.
(WebCore::CSPSourceList::parse):
    Pass a 'path' in when creating CSPSource objects.
(WebCore::CSPSourceList::parsePath):
    Actually parse the path, flagging errors if '?' or '#' are present,
    URL-decoding the result, and ensuring that a terminal '/' is
    added if necessary.
(WebCore::CSPSourceList::addSourceSelf):
    Ensure that 'self' sources have an empty path.
* page/ContentSecurityPolicy.h:
    Dropping the "ignored path component" console warning.

LayoutTests:

* http/tests/security/contentSecurityPolicy/source-list-parsing-05-expected.txt:
* http/tests/security/contentSecurityPolicy/source-list-parsing-05.html:
* http/tests/security/contentSecurityPolicy/source-list-parsing-06-expected.txt:
* http/tests/security/contentSecurityPolicy/source-list-parsing-06.html:
    The behavior of these tests changes based on the new functionality.
* http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01.html: Added.
* http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02.html: Added.
    New tests for various path cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Rewrite confusing call sequence layout tests
jsbell@chromium.org [Thu, 20 Sep 2012 18:00:18 +0000 (18:00 +0000)]
IndexedDB: Rewrite confusing call sequence layout tests
https://bugs.webkit.org/show_bug.cgi?id=97051

Reviewed by Tony Chang.

Rewrite some convoluted and hard to understand/maintain tests in a more idiomatic fashion.
This patch maintains the bulk of the non-standard output to verify that the tests have not
changed in behavior; follow-ups will make the output more standard and split the tests
into separate files.

* storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
* storage/indexeddb/open-close-version-expected.txt:
* storage/indexeddb/resources/factory-deletedatabase-interactions.js:
* storage/indexeddb/resources/open-close-version.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] ControlsPanel string is not localized in LocalizedStringsGtk
commit-queue@webkit.org [Thu, 20 Sep 2012 17:56:00 +0000 (17:56 +0000)]
[GTK] ControlsPanel string is not localized in LocalizedStringsGtk
https://bugs.webkit.org/show_bug.cgi?id=96502

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-20
Reviewed by Chris Fleizach.

Source/WebCore:

Adds the ControlsPanel string to the strings localized in LocalizedStringsGtk.

Test: platform/gtk/accessibility/media-controls-panel-title.html

* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedMediaControlElementString):

LayoutTests:

Added a new test to verify that the accessible object associated with the
MediaControlsPanel has the expected accessible name.

* platform/gtk/accessibility/media-controls-panel-title-expected.txt: Added.
* platform/gtk/accessibility/media-controls-panel-title.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSafari 6 notifications' onclick handlers can't call window.open()
jonlee@apple.com [Thu, 20 Sep 2012 17:49:31 +0000 (17:49 +0000)]
Safari 6 notifications' onclick handlers can't call window.open()
https://bugs.webkit.org/show_bug.cgi?id=96959
<rdar://problem/12132427>

Reviewed by Darin Adler.

Source/WebKit2:

The click is not being treated as a user gesture when the message is sent to the web process.

* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::didClickNotification): Gets called when the user clicks on the
platform notification. Set UserGestureIndicator to show the click event is due to user gesture.

LayoutTests:

The test shows and clicks a platform notification. The onclick handler calls window.open(),
which in turn calls a function on the main page to confirm that a window was opened.

* http/tests/notifications/legacy/window-show-on-click-expected.txt: Added.
* http/tests/notifications/legacy/window-show-on-click.html: Added.
* http/tests/notifications/resources/window-show-on-click.html: Added.
* http/tests/notifications/window-show-on-click-expected.txt: Added.
* http/tests/notifications/window-show-on-click.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] DRT does not support --dump-all-pixels flag
schenney@chromium.org [Thu, 20 Sep 2012 15:57:31 +0000 (15:57 +0000)]
[Chromium] DRT does not support --dump-all-pixels flag
https://bugs.webkit.org/show_bug.cgi?id=95098

Reviewed by Dirk Pranke.

Add support for the --pixel-tests and shorthand -p option in Chromium DumpRenderTree. Use
of this flag causes pixel results to be created for all tests, regardless of
individual test options. If an individual test provides a pixel hash it will be used,
otherwise the hash will be empty. This replaces a previously defined but unused option
--dump-all-pixels, and is useful primarily when debugging DRT instances.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(runTest): Add a parameter and code to force pixel results for the test.
(main): Add parameter handling for --pixels-test and -p, and remove --dump-all-pixels.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] run-api-tests should not buffer test stdout
carlosgc@webkit.org [Thu, 20 Sep 2012 15:48:36 +0000 (15:48 +0000)]
[GTK] run-api-tests should not buffer test stdout
https://bugs.webkit.org/show_bug.cgi?id=88474

Reviewed by Philippe Normand.

* Scripts/run-gtk-tests:
(TestRunner._run_test_command): Use os.forkpty() instead of
subprocess.Popen() so that gtest sends the output with colors to
stdout. Use common.parse_output_lines() to parse the output and
write it to stdout while it's read.
(TestRunner._run_test_command.parse_line): Parse the line to get
the test pid and write the line to stdout.
(TestRunner._run_test_command.waitpid): Helper function to call
waitpid handling EINTR.
(TestRunner._run_test_command.return_code_from_exit_status):
Helper function to convert exit status of test commands to a
return code.
* gtk/common.py:
(parse_output_lines): Helper function that uses select to read
the given file descriptor and call the given callback for every
line read.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove isStartColumn in the border collapsing code
jchaffraix@webkit.org [Thu, 20 Sep 2012 15:05:30 +0000 (15:05 +0000)]
Remove isStartColumn in the border collapsing code
https://bugs.webkit.org/show_bug.cgi?id=97024

Reviewed by Abhishek Arya.

isStartColumn is embedding the same information as prevCell. As we need to compute it
in most of the cases, we may as well just reuse them.

While touching this code, I cleaned up the code by removing some unneeded checks and renaming
some variables in preparation for bug 79272.

Refactoring covered by existing collapsing borders tests.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeCollapsedStartBorder):
Removed |isStartColumn|.

(WebCore::RenderTableCell::computeCollapsedEndBorder):
Added a comment about why |isEndColumn| is needed. Also cleaned up this code to be
consistent with computeCollapsedStartBorder.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Unskip fast/exclusions tests, because they pass now.
ossy@webkit.org [Thu, 20 Sep 2012 14:50:31 +0000 (14:50 +0000)]
[Qt] Unreviewed gardening. Unskip fast/exclusions tests, because they pass now.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add APIs to create, delete and get ewk_context.
commit-queue@webkit.org [Thu, 20 Sep 2012 14:39:23 +0000 (14:39 +0000)]
[EFL][WK2] Add APIs to create, delete and get ewk_context.
https://bugs.webkit.org/show_bug.cgi?id=89186

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-20
Reviewed by Kenneth Rohde Christiansen.

Provide APIs to create ewk_context with or without injected bundle path
and delete created ewk_context.
Additionally, the ewk_view can be created with ewk_context which is not
default context, so we have to get ewk_context from ewk_view.

* PlatformEfl.cmake:
* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::handleDownloadRequest):
* UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(ewk_context_ref):
(ewk_context_unref):
(ewk_context_new):
(ewk_context_new_with_injected_bundle_path):
* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_ewk_view_priv_del):
(_ewk_view_initialize):
(ewk_view_context_get):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/InjectedBundle/injected_bundle_sample.cpp: Added.
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:
(EWK2UnitTest::EWK2UnitTestEnvironment::injectedBundleSample):
(EWK2UnitTest):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
(EWK2UnitTestEnvironment):
* UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):
* UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(TEST_F):
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unreviwed gardening. Skip test failing with timeout.
kkristof@inf.u-szeged.hu [Thu, 20 Sep 2012 14:34:24 +0000 (14:34 +0000)]
[Qt][WK2] Unreviwed gardening. Skip test failing with timeout.
https://bugs.webkit.org/show_bug.cgi?id=96397

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-09-20

* platform/qt-5.0-wk2/Skipped: skip fast/spatial-navigation/snav-media-elements.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Rebase and move compositing/geometry/fixed-position.html
ryuan.choi@samsung.com [Thu, 20 Sep 2012 14:25:28 +0000 (14:25 +0000)]
[EFL] Rebase and move compositing/geometry/fixed-position.html
https://bugs.webkit.org/show_bug.cgi?id=97207

Unreviewed EFL gardening.

Rebase and move fixed-position.html to efl-wk1 TestExpectations
since it does not fail on the WebKit2 bots with rebased.

* platform/efl-wk1/TestExpectations:
* platform/efl/Skipped:
* platform/efl/compositing/geometry/fixed-position-expected.png: Added.
* platform/efl/compositing/geometry/fixed-position-expected.txt: Rebased.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix initial build
hausmann@webkit.org [Thu, 20 Sep 2012 14:11:51 +0000 (14:11 +0000)]
[Qt] Fix initial build

Reviewed by Tor Arne Vestbø.

When building QtWebKit the first time there is no qt_webkit.pri module pri file, and therefore
$$QT.webkit.name isn't set and so creating_module isn't set. That has all sorts of implications
causing incorrect linking for Makefile.api, etc.

Fix the determination by simply checking if MODULE is set, which only happens in api.pri.

* qmake/mkspecs/features/webkit_modules.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Skip tests that will be broken by an upcoming V8 roll.
peter@chromium.org [Thu, 20 Sep 2012 14:01:23 +0000 (14:01 +0000)]
[chromium] Skip tests that will be broken by an upcoming V8 roll.
https://bugs.webkit.org/show_bug.cgi?id=97206

Unreviewed preemptive gardening.

These three tests will be broken by an upcoming V8 roll. I plan on
rebaselining them along with webkit.org/b/94332.

Patch by Mike West <mkwst@google.com> on 2012-09-20

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] r129045 broke the ARM build
rgabor@webkit.org [Thu, 20 Sep 2012 13:25:12 +0000 (13:25 +0000)]
[Qt] r129045 broke the ARM build
https://bugs.webkit.org/show_bug.cgi?id=97195

Reviewed by Zoltan Herczeg.

Implementing missing store8 function.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::store8):
(MacroAssemblerARM):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Enable CSS regions by default
ossy@webkit.org [Thu, 20 Sep 2012 13:20:55 +0000 (13:20 +0000)]
[Qt] Enable CSS regions by default
https://bugs.webkit.org/show_bug.cgi?id=97196

Source/WebKit/qt:

Reviewed by Dirk Schulze.

* Api/qwebsettings.cpp:
(QWebSettings::QWebSettings):

LayoutTests:

Add Qt specific expected results for non-reftests,
results are compared to Mac results manually.

Reviewed by Dirk Schulze.

* platform/qt/Skipped: Unskip passing fast/regions tests, skip 3 failing reftest.
* platform/qt/fast/regions/autoheight-regions-mark-expected.png: Added.
* platform/qt/fast/regions/autoheight-regions-mark-expected.txt: Added.
* platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
* platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
* platform/qt/fast/regions/flow-content-basic-expected.png: Added.
* platform/qt/fast/regions/flow-content-basic-expected.txt: Added.
* platform/qt/fast/regions/flow-content-basic-vertical-expected.png: Added.
* platform/qt/fast/regions/flow-content-basic-vertical-expected.txt: Added.
* platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
* platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
* platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
* platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
* platform/qt/fast/regions/flows-dependency-same-flow-expected.png: Added.
* platform/qt/fast/regions/flows-dependency-same-flow-expected.txt: Added.
* platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Added.
* platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
* platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
* platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
* platform/qt/fast/regions/overflow-in-variable-width-regions-expected.png: Added.
* platform/qt/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
* platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
* platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
* platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Added.
* platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
* platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
* platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
* platform/qt/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Added.
* platform/qt/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
* platform/qt/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Added.
* platform/qt/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
* platform/qt/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Added.
* platform/qt/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
* platform/qt/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Added.
* platform/qt/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
* platform/qt/fast/regions/percentage-margins-variable-width-regions-expected.png: Added.
* platform/qt/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
* platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
* platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
* platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
* platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
* platform/qt/fast/regions/region-style-block-background-color-expected.png: Added.
* platform/qt/fast/regions/region-style-block-background-color-expected.txt: Added.
* platform/qt/fast/regions/region-style-block-background-color2-expected.png: Added.
* platform/qt/fast/regions/region-style-block-background-color2-expected.txt: Added.
* platform/qt/fast/regions/text-region-split-small-pagination-expected.png: Added.
* platform/qt/fast/regions/text-region-split-small-pagination-expected.txt: Added.
* platform/qt/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
* platform/qt/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
* platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
* platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
* platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
* platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
* platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
* platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
* platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Added.
* platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
* platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
* platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
* platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
* platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
* platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
* platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium ] Add new localized string, OtherDateLabel, to be used in input type=date...
keishi@webkit.org [Thu, 20 Sep 2012 13:18:22 +0000 (13:18 +0000)]
[Chromium ] Add new localized string, OtherDateLabel, to be used in input type=date datalist UI
https://bugs.webkit.org/show_bug.cgi?id=97200

Reviewed by Kent Tamura.

Adding new localized string to be used in the SuggestionPicker for input type=date.

* chromium/public/WebLocalizedString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Adding the 'google_apis' directory to .gitignore.
commit-queue@webkit.org [Thu, 20 Sep 2012 13:14:14 +0000 (13:14 +0000)]
[chromium] Adding the 'google_apis' directory to .gitignore.
https://bugs.webkit.org/show_bug.cgi?id=97187

Patch by Mike West <mkwst@google.com> on 2012-09-20
Reviewed by Jochen Eisinger.

'chromium/google_apis' should be ignored, as it's not in the git repo.

* .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r129091.
ossy@webkit.org [Thu, 20 Sep 2012 13:11:50 +0000 (13:11 +0000)]
Unreviewed, rolling out r129091.
http://trac.webkit.org/changeset/129091
https://bugs.webkit.org/show_bug.cgi?id=97205

It broke perf tests everywhere (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-20

PerformanceTests:

* resources/runner.js:
(PerfTestRunner.computeStatistics):
(PerfTestRunner.printStatistics):

Tools:

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output):
(PageLoadingPerfTest.run):
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest.test_run):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_and_show_results):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_memory_test):
(test_run_with_json_output):
(test_run_with_description):
(test_run_with_slave_config_json):
(test_run_with_multiple_repositories):

LayoutTests:

* fast/harness/perftests/runs-per-second-log-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: setPropertyValue does not work for non-finite numbers
commit-queue@webkit.org [Thu, 20 Sep 2012 12:44:51 +0000 (12:44 +0000)]
Web Inspector: setPropertyValue does not work for non-finite numbers
https://bugs.webkit.org/show_bug.cgi?id=97016

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-20
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Fix: setting a property to NaN, Infinity or -Infinity numbers did not work.

* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.setPropertyValue):

LayoutTests:

Expands the test with non-finite numbers case.

* inspector/runtime/runtime-setPropertyValue-expected.txt:
* inspector/runtime/runtime-setPropertyValue.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Implemented color picker API
commit-queue@webkit.org [Thu, 20 Sep 2012 12:09:08 +0000 (12:09 +0000)]
[EFL][WK2] Implemented color picker API
https://bugs.webkit.org/show_bug.cgi?id=91832

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-09-20
Reviewed by Kenneth Rohde Christiansen.

Add support for color picker API for EFL port in WebKit2.

The external application can implement input picker by overriding
smart class function.

* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(ewk_view_color_picker_request):
(ewk_view_color_picker_dismiss):
(ewk_view_color_picker_color_set):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_private.h:
* UIProcess/API/efl/ewk_view_ui_client.cpp:
(showColorPicker):
(hideColorPicker):
(ewk_view_ui_client_attach):
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(onColorPickerDone):
(setColorPickerColor):
(showColorPicker):
(hideColorPicker):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] [WK1] Spaces missing in output of fast/forms/mailto/advanced-{get,put}.html
commit-queue@webkit.org [Thu, 20 Sep 2012 12:05:56 +0000 (12:05 +0000)]
[Qt] [WK1] Spaces missing in output of fast/forms/mailto/advanced-{get,put}.html
https://bugs.webkit.org/show_bug.cgi?id=92551

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-20
Reviewed by Adam Barth.

The problem here is that the text input boxes are rendered differently
in chromium and qt/gtk/efl, causing the text dump to also differ.

There are 4 adjacent input boxes in a page 800 pixel wide, the width
of these inputs is unspecified, as it should since this is unrelated
to purpose of the test, and left for the port to decide. Chromium puts
the four in the same line, qt/gtk/efl breaks the line before the fourth
input, causing an extra space to appear in the text dump.

The test was corrected by defining a fixed width for the input
elements, ensuring the text dumps will be identical in all platforms,
eliminating the need for special expected files.

* fast/forms/mailto/advanced-get.html:
* fast/forms/mailto/advanced-put.html:
* platform/efl/fast/forms/mailto/advanced-get-expected.txt: Removed.
* platform/efl/fast/forms/mailto/advanced-put-expected.txt: Removed.
* platform/gtk/fast/forms/mailto/advanced-get-expected.txt: Removed.
* platform/gtk/fast/forms/mailto/advanced-put-expected.txt: Removed.
* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/fast/forms/mailto/advanced-get-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/mailto/advanced-put-expected.txt: Removed.
* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] QtWebKit module header includes private dependencies
hausmann@webkit.org [Thu, 20 Sep 2012 11:58:44 +0000 (11:58 +0000)]
[Qt] QtWebKit module header includes private dependencies

Reviewed by Tor Arne Vestbø.

.:

Moved loading of webkit_modules.prf a few lines down after the definition
of QT_API_DEPENDS, because webkit_modules.prf does the sanitization of the
QT variable now and therefore needs QT_API_DEPENDS.

* Source/api.pri:

Tools:

* qmake/mkspecs/features/default_post.prf: Don't try to sanitize LIBS, because we can make sure
that LIBS_PRIVATE is set from the beginning. Moved the creating_module and PKGCONFIG/QT(_PRIVATE)
sanitization into webkit_modules.prf. creating_module determination requires TARGET to be set, so
we can't do it in default_pre.
* qmake/mkspecs/features/webkit_modules.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Cookie info in Network Resources Cookies tab are incorrect
commit-queue@webkit.org [Thu, 20 Sep 2012 11:34:33 +0000 (11:34 +0000)]
Web Inspector: Cookie info in Network Resources Cookies tab are incorrect
https://bugs.webkit.org/show_bug.cgi?id=95491

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-20
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Web Inspector: Cookie info in Network Resources Cookies tab are incorrect
https://bugs.webkit.org/show_bug.cgi?id=95491

Fixing a typo that causes cookies to appear as a "Session"
cookie in the Networking panel because it can never find a properly named
"expired" header.

This bug exposes another bug where the cookie GMT strings are inproperly
parsed, causing an "invalid date" error to show up in the cookies tab in
the Networking panel.

Also changed test expectations in LayoutTests/inspector/cookie-parser-expected.txt

* inspector/front-end/CookieParser.js:
(WebInspector.Cookie.prototype.get session):

LayoutTests:

Changed test expectation. If a cookie has an expired value, session should
return false.

* inspector/cookie-parser-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Elements] Word wrap disablement in the DOM tree broken
apavlov@chromium.org [Thu, 20 Sep 2012 11:22:02 +0000 (11:22 +0000)]
Web Inspector: [Elements] Word wrap disablement in the DOM tree broken
https://bugs.webkit.org/show_bug.cgi?id=97185

Reviewed by Pavel Feldman.

Restored the effective "white-space: nowrap" for the tree elements.

* inspector/front-end/inspector.css:
(.nowrap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CoordinatedGraphics] Don't reset m_shouldSyncFrame in flushPendingLayerChanges
kbalazs@webkit.org [Thu, 20 Sep 2012 11:14:10 +0000 (11:14 +0000)]
[CoordinatedGraphics] Don't reset m_shouldSyncFrame in flushPendingLayerChanges
https://bugs.webkit.org/show_bug.cgi?id=97108

Reviewed by Noam Rosenthal.

Stop ignoring if m_shouldSyncFrame has been set between the two
layer flush. It can be set during layout in several situations,
for example when a layer is deleted or changed state. We want to
send the DidRenderFrame message at the next flush in those situations
so the UI process will apply the changes as soon as possible.

* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix build with MingW
hausmann@webkit.org [Thu, 20 Sep 2012 11:06:35 +0000 (11:06 +0000)]
[Qt] Fix build with MingW

Reviewed by Tor Arne Vestbø.

Don't try to compile WebCore, etc. with debug symbols for production
builds, it's just too big.

* qmake/mkspecs/features/production_build.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Unskip fast/frames/flattening/iframe-tiny.html
commit-queue@webkit.org [Thu, 20 Sep 2012 10:54:49 +0000 (10:54 +0000)]
[EFL][WK2] Unskip fast/frames/flattening/iframe-tiny.html
https://bugs.webkit.org/show_bug.cgi?id=97191

Unreviewed gardening.

Test fast/frames/flattening/iframe-tiny.html shall be unskipped as it was fixed in r129046.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-20

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 20 Sep 2012 10:40:37 +0000 (10:40 +0000)]
Unreviewed GTK gardening.

Adding failure expectations for tests added in r129068 and r129106.

Removing flaky crasher expectations for tests that were fixed in
r129065.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] To support "Frames View" of "TimeLine" panel in Inspector
commit-queue@webkit.org [Thu, 20 Sep 2012 10:38:45 +0000 (10:38 +0000)]
[BlackBerry] To support "Frames View" of "TimeLine" panel  in Inspector
https://bugs.webkit.org/show_bug.cgi?id=96077

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-09-20
Reviewed by Pavel Feldman.

A minor modification to make the inspecting results more accurate.
Internally reviewd by Arvid, Robin.C, and Konrad.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderJob):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
* WebKitSupport/RenderQueue.cpp:
(BlackBerry::WebKit::RenderQueue::render):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Check timeout on waitUntilLoadFinished() and waitUntilTitleChangedTo().
commit-queue@webkit.org [Thu, 20 Sep 2012 10:27:23 +0000 (10:27 +0000)]
[EFL][WK2] Check timeout on waitUntilLoadFinished() and waitUntilTitleChangedTo().
https://bugs.webkit.org/show_bug.cgi?id=97081

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-20
Reviewed by Gyuyoung Kim.

Add assertion to check timeout on waitUntilLoadFinished() and
waitUntilTitleChangedTo().
Set the default timeout for the functions as 10 seconds.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):
* UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
(TEST_F):
* UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
commit-queue@webkit.org [Thu, 20 Sep 2012 10:16:35 +0000 (10:16 +0000)]
[EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
https://bugs.webkit.org/show_bug.cgi?id=97087

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-09-20
Reviewed by Gyuyoung Kim.

Tools:

Add focusing a main frame on settings reset.
After editing/undo/undo-iframe-location-change was executed a frame
was left in unfocused state. This caused flakiness in two tests results.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

LayoutTests:

Remove two flaky tests from TestExpectations as they pass after setting focus
on settings reset.

* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Rebaseline after r129074
commit-queue@webkit.org [Thu, 20 Sep 2012 08:47:53 +0000 (08:47 +0000)]
[EFL] Rebaseline after r129074
https://bugs.webkit.org/show_bug.cgi?id=97181

Unreviewed rebaseline.

Following tests are rebased after r129074
svg/W3C-I18N/text-dirRTL-ubNone.svg
svg/W3C-I18N/tspan-direction-rtl.svg

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-20

* platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[TouchAdjustment] Simplify and improve hybrid distance function.
allan.jensen@nokia.com [Thu, 20 Sep 2012 08:44:43 +0000 (08:44 +0000)]
[TouchAdjustment] Simplify and improve hybrid distance function.
https://bugs.webkit.org/show_bug.cgi?id=96519

Reviewed by Antonio Gomes.

The current distance function is a combination of two functions. One measuring the distance from
the hot-spot in the touch-area to the centerline of the target, and one measuring how much of the
target is covered.

The distance to the center-line was used instead of just the distance to the target, to make it
easier to hit small targets near big targets. The very same feature is however also the reason
measuring how much the target is covered is added. Using the distance to center-line is therefore
redundant now, and can be replaced with the simpler 'distance the hot-spot needs to be adjusted'.

Tested by existing touchadjustment tests.

* page/TouchAdjustment.cpp:
(TouchAdjustment):
(WebCore::TouchAdjustment::hybridDistanceFunction):
* platform/graphics/IntRect.cpp:
* platform/graphics/IntRect.h:
(IntRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] HTMLSelectElement should call formStateDidChange on both menulist and lisbox...
yosin@chromium.org [Thu, 20 Sep 2012 08:41:27 +0000 (08:41 +0000)]
[Forms] HTMLSelectElement should call formStateDidChange on both menulist and lisbox mode
https://bugs.webkit.org/show_bug.cgi?id=97177

Reviewed by Kent Tamura.

This patch makes listbox mode select element to call formStateDidChange()
when selected options are changed.

For this change, this patch moves notifyFormStateChanged() to
HTMLFormControlElementWithState class from HTMLTextFormControlElement
for sharing code HTMLSelectElement class and HTMLInputElement/HTMLTextAreaElement
derived from HTMLTextFormControlElement.

No new tests. We can't test this change in WebKit test tools. Test script
will be implemented in Chromium side.

* html/HTMLFormControlElementWithState.cpp:
(WebCore::HTMLFormControlElementWithState::notifyFormStateChanged):
(WebCore):
* html/HTMLFormControlElementWithState.h: Moved a declaration of notifyFormStateChanged() from HTMLTextFormControlElement.
(HTMLFormControlElementWithState): Moved an implemented of notifyFormStateChanged() from HTMLTextFormControlElement.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectOption): Changed to call notifyFormStateChanged() instead of formStateDidChange().
(WebCore::HTMLSelectElement::updateListBoxSelection): Changed to call notifyFormStateChanged().
* html/HTMLTextFormControlElement.cpp: Moved an implemented of notifyFormStateChanged() to HTMLFormControlElementWithState class.
* html/HTMLTextFormControlElement.h: Moved a declaration of notifyFormStateChanged() to HTMLFormControlElementWithState class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r127727): Can't navigate between months with arrow keys in calendar picker
keishi@webkit.org [Thu, 20 Sep 2012 08:35:20 +0000 (08:35 +0000)]
REGRESSION(r127727): Can't navigate between months with arrow keys in calendar picker
https://bugs.webkit.org/show_bug.cgi?id=97166

Reviewed by Kent Tamura.

Source/WebCore:

Fixing bug in r127727 so arrow keys work properly.

Test: fast/forms/date/calendar-picker-key-operations.html

* Resources/pagepopups/calendarPicker.js:
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):

LayoutTests:

* fast/forms/date/calendar-picker-key-operations-expected.txt: Added.
* fast/forms/date/calendar-picker-key-operations.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Use and process the actual ScriptId in the protocol EventListener...
apavlov@chromium.org [Thu, 20 Sep 2012 08:33:46 +0000 (08:33 +0000)]
Web Inspector: Use and process the actual ScriptId in the protocol EventListener object
https://bugs.webkit.org/show_bug.cgi?id=93271

Reviewed by Yury Semikhatsky.

- Use the actual script identifier in the "location" object's "scriptId" field
  for the DOM.EventListener protocol type, but send the script URL in the new "sourceName" field.
- Use 0-based lines in the "location" object's "lineNumber" field for linkifyRawLocation() to work correctly.
- Fixed formatting of links to listener locations to contain "(program)" rather than empty string.

* bindings/js/ScriptEventListener.cpp:
(WebCore::eventListenerHandlerLocation):
* bindings/js/ScriptEventListener.h:
(WebCore):
* bindings/v8/ScriptEventListener.cpp:
(WebCore::eventListenerHandlerLocation):
* bindings/v8/ScriptEventListener.h:
(WebCore):
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
* inspector/front-end/BreakpointsSidebarPane.js:
* inspector/front-end/EventListenersSidebarPane.js:
* inspector/front-end/Linkifier.js:
(WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor):
* inspector/front-end/ResourceUtils.js:
(WebInspector.formatLinkText): Use "(program)" if URL is empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Rebaseline after r129050
commit-queue@webkit.org [Thu, 20 Sep 2012 08:31:45 +0000 (08:31 +0000)]
[EFL] Rebaseline after r129050
https://bugs.webkit.org/show_bug.cgi?id=97180

Unreviewed rebaseline.

Rebase of following tests after r129050
fast/text/atsui-multiple-renderers.html
fast/text/atsui-spacing-features.html
fast/text/wide-zero-width-space.html

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-20

* platform/efl/fast/text/atsui-multiple-renderers-expected.txt:
* platform/efl/fast/text/atsui-spacing-features-expected.txt:
* platform/efl/fast/text/wide-zero-width-space-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] fast/spatial-navigation/snav-media-elements.html timeouts
allan.jensen@nokia.com [Thu, 20 Sep 2012 08:22:05 +0000 (08:22 +0000)]
[Qt][WK2] fast/spatial-navigation/snav-media-elements.html timeouts
https://bugs.webkit.org/show_bug.cgi?id=96397

Reviewed by Antonio Gomes.

Use the js-test-post.js as intended to protect against race-conditions.

* fast/spatial-navigation/snav-media-elements.html:
* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add eventSender.gestureTap
commit-queue@webkit.org [Thu, 20 Sep 2012 08:19:32 +0000 (08:19 +0000)]
[Qt] Add eventSender.gestureTap
https://bugs.webkit.org/show_bug.cgi?id=66173

Patch by Allan Sandfeld Jensen <allan.jensen@digia.com> on 2012-09-20
Reviewed by Kenneth Rohde Christiansen.

Tools:

Implement support for sending raw QGesture events.

* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::EventSender):
(EventSender::gestureTap):
* DumpRenderTree/qt/EventSenderQt.h:
(EventSender):

LayoutTests:

Change test to only being skipped in Qt WebKit2.

* platform/qt-5.0-wk2/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Change the log macro names to be more consistent with EINA LOG
commit-queue@webkit.org [Thu, 20 Sep 2012 08:14:06 +0000 (08:14 +0000)]
[EFL] Change the log macro names to be more consistent with EINA LOG
https://bugs.webkit.org/show_bug.cgi?id=97158

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-20
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/efl:

Some log macro names in WebKit1 are inconsistent with EINA LOG names
such as WRN/INF not WARN/INFO.

  #define WRN(...) EINA_LOG_DOM_WARN(_ewk_log_dom, __VA_ARGS__)
  #define INF(...) EINA_LOG_DOM_INFO(_ewk_log_dom, __VA_ARGS__)

This patch changes the such names to be consistent with EINA LOG's names.

* ewk/ewk_frame.cpp:
(_ewk_frame_smart_resize):
(ewk_frame_source_get):
(ewk_frame_uri_changed):
* ewk/ewk_main.cpp:
(_ewk_init_body):
* ewk/ewk_private.h:
* ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_render):
(_ewk_tiled_backing_store_recalc_renderers):
(_ewk_tiled_backing_store_smart_calculate_offset_force):
(_ewk_tiled_backing_store_smart_calculate_offset):
(ewk_tiled_backing_store_pre_render_relative_radius):
* ewk/ewk_tiled_matrix.cpp:
(ewk_tile_matrix_free):
(ewk_tile_matrix_tile_exact_get):
(_ewk_tile_matrix_slicer_setup):
* ewk/ewk_view.cpp:
(_ewk_view_smart_add_console_message):
(_ewk_view_smart_run_javascript_alert):
(_ewk_view_smart_run_javascript_confirm):
(_ewk_view_smart_should_interrupt_javascript):
(_ewk_view_smart_run_javascript_prompt):
(_ewk_view_smart_pre_render_region):
(_ewk_view_smart_pre_render_relative_radius):
(_ewk_view_smart_pre_render_start):
(_ewk_view_smart_pre_render_cancel):
(_ewk_view_smart_disable_render):
(_ewk_view_smart_enable_render):
(ewk_view_bg_color_set):
(ewk_view_zoom_set):
(ewk_view_zoom_weak_set):
(ewk_view_zoom_animated_set):
(ewk_view_statusbar_text_set):
(ewk_view_exceeded_application_cache_quota):
(ewk_view_exceeded_database_quota):
(ewk_view_scroll):
(ewk_view_popup_new):
(ewk_view_popup_destroy):
(ewk_view_popup_selected_set):
(ewk_view_color_chooser_new):
(ewk_view_color_chooser_destroy):
(ewk_view_color_chooser_color_set):
(ewk_view_color_chooser_changed):
(ewk_view_zoom_range_set):
* ewk/ewk_view_private.h:

Source/WebKit2:

Some log macro names in WebKit2 are inconsistent with EINA LOG names
such as WRN/INF not WARN/INFO.

  #define WRN(...) EINA_LOG_DOM_WARN(_ewk_log_dom, __VA_ARGS__)
  #define INF(...) EINA_LOG_DOM_INFO(_ewk_log_dom, __VA_ARGS__)

This patch changes the such names to be consistent with EINA LOG's names.

* UIProcess/API/efl/ewk_main.cpp:
(ewk_init):
* UIProcess/API/efl/ewk_private.h:
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_webprocess_crashed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Mark http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html
yurys@chromium.org [Thu, 20 Sep 2012 08:01:34 +0000 (08:01 +0000)]
Unreviewed. Mark http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html
as flaky.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Same page navigation does not update view URI
commit-queue@webkit.org [Thu, 20 Sep 2012 07:16:09 +0000 (07:16 +0000)]
[EFL][WK2] Same page navigation does not update view URI
https://bugs.webkit.org/show_bug.cgi?id=97094

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-20
Reviewed by Kenneth Rohde Christiansen.

Handle didSameDocumentNavigationForFrame callback in
WKPageLoaderClient in order to update the view URI.
This fixes issues with the view URI not being updated
in case of a same page navigation.

* UIProcess/API/efl/ewk_view_loader_client.cpp:
(didSameDocumentNavigationForFrame):
(ewk_view_loader_client_attach):
* UIProcess/API/efl/ewk_view_private.h:
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(CallbackDataTimer):
(EWK2UnitTest::CallbackDataTimer::CallbackDataTimer):
(EWK2UnitTest::CallbackDataTimer::~CallbackDataTimer):
(EWK2UnitTest::CallbackDataTimer::isDone):
(EWK2UnitTest::CallbackDataTimer::setDone):
(EWK2UnitTest::CallbackDataTimer::didTimeOut):
(EWK2UnitTest::CallbackDataTimer::setTimedOut):
(EWK2UnitTest):
(CallbackDataExpectedValue):
(EWK2UnitTest::CallbackDataExpectedValue::CallbackDataExpectedValue):
(EWK2UnitTest::CallbackDataExpectedValue::expectedValue):
(EWK2UnitTest::onLoadFinished):
(EWK2UnitTest::timeOutWhileWaitingUntilLoadFinished):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilLoadFinished):
(EWK2UnitTest::onTitleChanged):
(EWK2UnitTest::timeOutWhileWaitingUntilTitleChangedTo):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilTitleChangedTo):
(EWK2UnitTest::onURIChanged):
(EWK2UnitTest::timeOutWhileWaitingUntilURIChangedTo):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilURIChangedTo): Add convenience function to test
framework in order to wait until the view URI changes to a given value.
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):
* UIProcess/API/efl/tests/resources/same_page_navigation.html: Added.
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F): Add corresponding unit test to verify fix and prevent regressions
in the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unskip JS tests that are no longer crashing after r129065
commit-queue@webkit.org [Thu, 20 Sep 2012 06:56:08 +0000 (06:56 +0000)]
[EFL] Unskip JS tests that are no longer crashing after r129065
https://bugs.webkit.org/show_bug.cgi?id=97174

Unreviewed EFL gardening.

Unskip several JS tests that are no longer crashing now that
the fix has landed.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-19

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: WebCore part of adding a setting and API for disabling screen font...
mitz@apple.com [Thu, 20 Sep 2012 06:55:54 +0000 (06:55 +0000)]
Source/WebCore: WebCore part of adding a setting and API for disabling screen font substitution
https://bugs.webkit.org/show_bug.cgi?id=97168

Reviewed by Tim Horton.

* WebCore.exp.in: Added an entry for Settings::setScreenFontSubstitutionEnabled.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use printer fonts if
screen font substitution is not enabled.
* page/Settings.cpp:
(WebCore::Settings::Settings): Added initializer for new m_screenFontSubstitutionEnabled
member variable. The initial value is true, matching existing behavior.
(WebCore::Settings::setScreenFontSubstitutionEnabled): Added this setter, which updated the
member variable and forces a style recalc in all pages using this Settings.
* page/Settings.h:
(Settings): Added m_screenFontSubstitutionEnabled boolean member variable.
(WebCore::Settings::screenFontSubstitutionEnabled): Added this getter.

Source/WebKit/mac: WebKit/mac part of adding a setting and API for disabling screen font substitution
https://bugs.webkit.org/show_bug.cgi?id=97168

Reviewed by Tim Horton.

* WebView/WebPreferenceKeysPrivate.h: Defined WebKitScreenFontSubstitutionEnabledKey.
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Added a default value of YES for the new preference key.
(-[WebPreferences setScreenFontSubstitutionEnabled:]): Added this setter.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Added a call to Settings::setScreenFontSubstitutionEnabled
to push the preference down to Settings.

Source/WebKit2: WebKit2 part of adding a setting and API for disabling screen font substitution
https://bugs.webkit.org/show_bug.cgi?id=97168

Reviewed by Tim Horton.

* Shared/WebPreferencesStore.h:
(WebKit): Defined ScreenFontSubstitutionEnabled key with a default value of true.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetScreenFontSubstitutionEnabled): Added this setter.
(WKPreferencesGetScreenFontSubstitutionEnabled): Added this getter.
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Added a call to Settings::setScreenFontSubstitutionEnabled
to push the preference into Settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix unused parameter compile warnings in WebKit/WebKit2
commit-queue@webkit.org [Thu, 20 Sep 2012 06:52:56 +0000 (06:52 +0000)]
Fix unused parameter compile warnings in WebKit/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=96742

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-19
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Fix unused parameter compile warning messages(-Wunused-parameter) in WebKit during EFL build.
WebCore's warning messages were fixed in r128570.

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::createWindow):
(WebCore::ChromeClientEfl::mouseDidMoveOverElement):
(WebCore::ChromeClientEfl::print):
(WebCore::ChromeClientEfl::reachedMaxAppCacheSize):
(WebCore::ChromeClientEfl::invalidateContents):
(WebCore::ChromeClientEfl::invalidateRootView):
(WebCore::ChromeClientEfl::invalidateContentsAndRootView):
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::handleInputMethodKeydown):
(WebCore::EditorClientEfl::getGuessesForWord):
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveAuthenticationChallenge):
(WebCore::FrameLoaderClientEfl::dispatchDidCancelAuthenticationChallenge):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientEfl::createFrame):
(WebCore::FrameLoaderClientEfl::createJavaAppletWidget):
(WebCore::FrameLoaderClientEfl::shouldStopLoadingForHistoryItem):
(WebCore::FrameLoaderClientEfl::canShowMIMETypeAsHTML):
(WebCore::FrameLoaderClientEfl::setTitle):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveContentLength):
(WebCore::FrameLoaderClientEfl::dispatchDidLoadResourceFromMemoryCache):
(WebCore::FrameLoaderClientEfl::setMainDocumentError):
* WebCoreSupport/FullscreenVideoControllerEfl.cpp:
(FullscreenVideoController::showHud):
(FullscreenVideoController::setVolume):
(FullscreenVideoController::setCurrentTime):
* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::notifyWebInspectorDestroy):
(WebCore::InspectorFrontendSettingsEfl::getProperty):
(WebCore::InspectorFrontendSettingsEfl::setProperty):
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::getPluginInfo):
* ewk/ewk_auth_soup.cpp:
(ewk_auth_soup_dialog_class_init):
(ewk_auth_soup_dialog_init):
(ewk_auth_soup_dialog_session_feature_init):
(session_authenticate):
* ewk/ewk_file_chooser.cpp:
(ewk_file_chooser_allows_directory_upload_get):
* ewk/ewk_frame.cpp:
(ewk_frame_feed_focus_out):
(ewk_frame_view_state_save):
(ewk_frame_plugin_create):
* ewk/ewk_js.cpp:
(ewk_js_object_new):
(ewk_js_object_free):
(ewk_js_object_view_get):
(ewk_js_object_properties_get):
(ewk_js_object_name_get):
(ewk_js_object_invoke):
(ewk_js_object_type_get):
(ewk_js_object_type_set):
(ewk_js_variant_free):
(ewk_js_variant_array_free):
* ewk/ewk_tiled_model.cpp:
(tile_account):
(_ewk_tile_account_allocated):
(_ewk_tile_account_freed):
* ewk/ewk_view.cpp:
(_ewk_view_smart_add_console_message):
(_ewk_view_smart_run_javascript_alert):
(_ewk_view_smart_run_javascript_confirm):
(_ewk_view_smart_should_interrupt_javascript):
(_ewk_view_smart_run_javascript_prompt):
(_ewk_view_smart_move):
(_ewk_view_smart_contents_resize):
(_ewk_view_editor_command_string_get):
(ewk_view_popup_new):
(ewk_view_js_object_add):
(ewk_view_accelerated_compositing_object_create):
(ewk_view_accelerated_compositing_context_get):
(ewk_view_setting_web_audio_get):
(ewk_view_setting_web_audio_set):
* ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_bg_color_set):
* ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_updates_process_pre):
(_ewk_view_tiled_contents_size_changed_cb):
(_ewk_view_tiled_smart_bg_color_set):

Source/WebKit2:

Fix unused parameter compile warning messages(-Wunused-parameter) in WebKit2 during EFL build.
WebCore's warning messages were fixed in r128570.

* Shared/FontInfo.cpp:
(WebKit::FontInfo::encode):
(WebKit::FontInfo::decode):
* Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):
* Shared/SandboxExtension.h:
(WebKit::SandboxExtension::createHandleForTemporaryFile):
* Shared/ShareableSurface.cpp:
(WebKit::ShareableSurface::create):
* Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):
* UIProcess/API/C/WKPage.cpp:
(WKPageGetContentsAsMHTMLData):
* UIProcess/API/C/WKPluginSiteDataManager.cpp:
(WKPluginSiteDataManagerClearSiteData):
(WKPluginSiteDataManagerClearAllSiteData):
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetHixie76WebSocketProtocolEnabled):
(WKPreferencesGetHixie76WebSocketProtocolEnabled):
* UIProcess/API/efl/BatteryProvider.cpp:
(startUpdatingCallback):
(stopUpdatingCallback):
* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::doneWithTouchEvent):
* UIProcess/API/efl/VibrationProvider.cpp:
(vibrateCallback):
(cancelVibrationCallback):
* UIProcess/API/efl/ewk_context_download_client.cpp:
(decideDestinationWithSuggestedFilename):
(didCreateDestination):
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_on_focus_in):
(_ewk_view_on_focus_out):
(_ewk_view_on_mouse_wheel):
(_ewk_view_on_mouse_down):
(_ewk_view_on_mouse_up):
(_ewk_view_on_mouse_move):
(_ewk_view_on_key_down):
(_ewk_view_on_key_up):
(_ewk_view_smart_move):
(ewk_view_contents_size_changed):
* UIProcess/API/efl/ewk_view_find_client.cpp:
(didFindString):
* UIProcess/API/efl/ewk_view_form_client.cpp:
(willSubmitForm):
* UIProcess/API/efl/ewk_view_loader_client.cpp:
(didReceiveIntentForFrame):
(registerIntentServiceForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didChangeBackForwardList):
* UIProcess/API/efl/ewk_view_policy_client.cpp:
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
(decidePolicyForResponseCallback):
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::update):
(WebKit::DrawingAreaProxy::didUpdateBackingStoreState):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::updateAcceleratedCompositingMode):
* UIProcess/FindIndicator.cpp:
(WebKit::FindIndicator::draw):
* UIProcess/GeolocationPermissionRequestManagerProxy.cpp:
(WebKit::GeolocationPermissionRequestManagerProxy::didReceiveGeolocationPermissionDecision):
* UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
(WebKit::PluginInfoStore::shouldUsePlugin):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::setHTTPPipeliningEnabled):
* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::supportsFullScreen):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sessionStateData):
(WebKit::WebPageProxy::recommendedScrollbarStyleDidChange):
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
* UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
* UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):
* UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::standardUserAgent):
(WebKit::WebPageProxy::getEditorCommandsForKeyEvent):
* WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::didDecideDestination):
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):
* WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::didChangePosition):
* WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::synchronousIconForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconURLForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconDataKnownForIconURL):
(WebKit::WebIconDatabaseProxy::synchronousLoadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::iconDataForIconURL):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopyWebArchiveFilteringSubframes):
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKAccessibilityRootObject):
(WKAccessibilityFocusedObject):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setGeoLocationPermission):
(WebKit::InjectedBundle::didReceiveMessage):
(WebKit::InjectedBundle::webNotificationID):
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::initialize):
(WebKit::WebNotificationManager::didUpdateNotificationDecision):
(WebKit::WebNotificationManager::didRemoveNotificationDecisions):
(WebKit::WebNotificationManager::policyForOrigin):
(WebKit::WebNotificationManager::notificationIDForTesting):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):
(WebKit::WebNotificationManager::didShowNotification):
(WebKit::WebNotificationManager::didClickNotification):
(WebKit::WebNotificationManager::didCloseNotifications):
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::addMessageToConsole):
(WebKit::WebChromeClient::contentsSizeChanged):
(WebKit::WebChromeClient::customHighlightRect):
(WebKit::WebChromeClient::paintCustomHighlight):
(WebKit::WebChromeClient::supportsFullScreenForElement):
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::downloadURL):
* WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::dragSourceActionMaskForPoint):
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
(WebKit::WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
(WebKit::WebFrameLoaderClient::shouldStopLoadingForHistoryItem):
(WebKit::WebFrameLoaderClient::canShowMIMEType):
(WebKit::WebFrameLoaderClient::canShowMIMETypeAsHTML):
(WebKit::WebFrameLoaderClient::representationExistsForURLScheme):
(WebKit::WebFrameLoaderClient::generatedMIMETypeForURLScheme):
(WebKit::WebFrameLoaderClient::createFrame):
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
(WebKit::WebFrameLoaderClient::registerForIconNotification):
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::drawRect):
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::forceRepaintAsync):
(WebKit::DrawingArea::updateBackingStoreState):
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::mouseEvent):
* WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create):
* WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::forceRepaintAsync):
* WebProcess/WebPage/TapHighlightController.cpp:
(WebKit::TapHighlightController::drawRect):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getWebArchiveOfFrame):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):
* WebProcess/soup/WebKitSoupRequestGeneric.cpp:
(webkitSoupRequestGenericSendFinish):
* WebProcess/soup/WebKitSoupRequestInputStream.cpp:
(webkitSoupRequestInputStreamReadAsync):
(webkitSoupRequestInputStreamReadFinish):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] multiple fields time input UI should call notifyFormStateChanged() when value...
yosin@chromium.org [Thu, 20 Sep 2012 06:13:37 +0000 (06:13 +0000)]
[Forms] multiple fields time input UI should call notifyFormStateChanged() when value of field is changed
https://bugs.webkit.org/show_bug.cgi?id=97169

Reviewed by Kent Tamura.

This patch makes multiple fields time input UI calls notifyFormStateChanged()
when field value is changed as other input types do.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. We can't test this change in WebKit test tools. Test script
will be implemented in Chromium side.

* html/TimeInputType.cpp:
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r127727): Calendar picker focus ring should be hidden until key event
keishi@webkit.org [Thu, 20 Sep 2012 06:02:30 +0000 (06:02 +0000)]
REGRESSION(r127727): Calendar picker focus ring should be hidden until key event
https://bugs.webkit.org/show_bug.cgi?id=97165

Reviewed by Kent Tamura.

The regression was caused because NoFocusRing class was being removed
from then main element inside resetMain().

No new tests. Covered by calendar-picker-appearance.html.

* Resources/pagepopups/calendarPicker.js:
(initialize):
(CalendarPicker):
(CalendarPicker.prototype._layout):
(DaysTable.prototype._handleKey):
(CalendarPicker.prototype._handleBodyKeyDown):
(CalendarPicker.prototype.maybeUpdateFocusStyle): Make this a method of CalendarPicker because we don't use it for other pickers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test expectations update.
noel.gordon@gmail.com [Thu, 20 Sep 2012 05:52:12 +0000 (05:52 +0000)]
Unreviewed test expectations update.

* platform/mac/TestExpectations: Change bug number reference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r129007.
ossy@webkit.org [Thu, 20 Sep 2012 05:50:25 +0000 (05:50 +0000)]
Unreviewed, rolling out r129007.
http://trac.webkit.org/changeset/129007
https://bugs.webkit.org/show_bug.cgi?id=97172

It broke the build on the Qt bots (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-19

* qmake/config.tests/gccdepends/empty.cpp:
* qmake/config.tests/gccdepends/gccdepends.pro:
* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun-perf-tests should record indivisual value instead of statistics
rniwa@webkit.org [Thu, 20 Sep 2012 05:14:16 +0000 (05:14 +0000)]
run-perf-tests should record indivisual value instead of statistics
https://bugs.webkit.org/show_bug.cgi?id=97155

Reviewed by Hajime Morita.

PerformanceTests:

Report the list of values as "values" so that run-perf-tests can parse them.

* resources/runner.js:
(PerfTestRunner.computeStatistics):
(PerfTestRunner.printStatistics):

Tools:

Parse the list of indivisual value reported by tests and include them as "values".
We strip "values" from the output JSON when uploading it to the perf-o-matic
since it doesn't know how to parse "values" or ignore it.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output): Parse and report "values".
(PageLoadingPerfTest.run): Report indivisual page loading time in "values".
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest.test_run):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_and_show_results): Strip "values" from each result
until we update perf-o-matic.
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_memory_test):
(test_run_with_json_output):
(test_run_with_description):
(test_run_with_slave_config_json):
(test_run_with_multiple_repositories):

LayoutTests:

The expected result now contains indivisual value.

* fast/harness/perftests/runs-per-second-log-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Print console warning about setVersion
dgrogan@chromium.org [Thu, 20 Sep 2012 04:49:43 +0000 (04:49 +0000)]
IndexedDB: Print console warning about setVersion
https://bugs.webkit.org/show_bug.cgi?id=96575

Reviewed by Tony Chang.

Source/WebCore:

setVersion has been out of the spec for almost a year but there are
still a lot of users.

We show the warning once per database object as an approximation for
once per page.

No new tests, but 150-something rebaselines.

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::setVersion):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):

LayoutTests:

* http/tests/inspector/indexeddb/database-data-expected.txt:
* http/tests/inspector/indexeddb/database-structure-expected.txt:
* http/tests/inspector/indexeddb/resources-panel-expected.txt:
* storage/indexeddb/create-and-remove-object-store-expected.txt:
* storage/indexeddb/create-object-store-options-expected.txt:
* storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
* storage/indexeddb/createObjectStore-null-name-expected.txt:
* storage/indexeddb/cursor-added-bug-expected.txt:
* storage/indexeddb/cursor-advance-expected.txt:
* storage/indexeddb/cursor-continue-dir-expected.txt:
* storage/indexeddb/cursor-continue-expected.txt:
* storage/indexeddb/cursor-continue-validity-expected.txt:
* storage/indexeddb/cursor-delete-expected.txt:
* storage/indexeddb/cursor-inconsistency-expected.txt:
* storage/indexeddb/cursor-index-delete-expected.txt:
* storage/indexeddb/cursor-key-order-expected.txt:
* storage/indexeddb/cursor-overloads-expected.txt:
* storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
* storage/indexeddb/cursor-primary-key-order-expected.txt:
* storage/indexeddb/cursor-reverse-bug-expected.txt:
* storage/indexeddb/cursor-skip-deleted-expected.txt:
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/cursor-update-value-argument-required-expected.txt:
* storage/indexeddb/cursor-value-expected.txt:
* storage/indexeddb/data-corruption-expected.txt:
* storage/indexeddb/database-basics-expected.txt:
* storage/indexeddb/database-close-expected.txt:
* storage/indexeddb/database-closepending-flag-expected.txt:
* storage/indexeddb/database-deletepending-flag-expected.txt:
* storage/indexeddb/delete-closed-database-object-expected.txt:
* storage/indexeddb/delete-range-expected.txt:
* storage/indexeddb/deleteIndex-expected.txt:
* storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
* storage/indexeddb/deleteObjectStore-null-name-expected.txt:
* storage/indexeddb/deleted-objects-expected.txt:
* storage/indexeddb/deletedatabase-transaction-expected.txt:
* storage/indexeddb/duplicates-expected.txt:
* storage/indexeddb/error-causes-abort-by-default-expected.txt:
* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/indexeddb/exceptions-expected.txt:
* storage/indexeddb/factory-deletedatabase-expected.txt:
* storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
* storage/indexeddb/get-keyrange-expected.txt:
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics-workers-expected.txt:
* storage/indexeddb/index-count-expected.txt:
* storage/indexeddb/index-cursor-expected.txt:
* storage/indexeddb/index-duplicate-keypaths-expected.txt:
* storage/indexeddb/index-get-key-argument-required-expected.txt:
* storage/indexeddb/index-multientry-expected.txt:
* storage/indexeddb/index-population-expected.txt:
* storage/indexeddb/index-unique-expected.txt:
* storage/indexeddb/intversion-and-setversion-expected.txt:
* storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt:
* storage/indexeddb/intversion-long-queue-expected.txt:
* storage/indexeddb/invalid-keys-expected.txt:
* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/key-sort-order-across-types-expected.txt:
* storage/indexeddb/key-sort-order-date-expected.txt:
* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/key-type-infinity-expected.txt:
* storage/indexeddb/keypath-arrays-expected.txt:
* storage/indexeddb/keypath-basics-expected.txt:
* storage/indexeddb/keypath-edges-expected.txt:
* storage/indexeddb/keypath-fetch-key-expected.txt:
* storage/indexeddb/keypath-intrinsic-properties-expected.txt:
* storage/indexeddb/lazy-index-population-expected.txt:
* storage/indexeddb/legacy-constants-expected.txt:
* storage/indexeddb/list-ordering-expected.txt:
* storage/indexeddb/metadata-expected.txt:
* storage/indexeddb/mozilla/add-twice-failure-expected.txt:
* storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
* storage/indexeddb/mozilla/bad-keypath-expected.txt:
* storage/indexeddb/mozilla/clear-expected.txt:
* storage/indexeddb/mozilla/create-index-unique-expected.txt:
* storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
* storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
* storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
* storage/indexeddb/mozilla/cursor-mutation-expected.txt:
* storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
* storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
* storage/indexeddb/mozilla/cursors-expected.txt:
* storage/indexeddb/mozilla/delete-result-expected.txt:
* storage/indexeddb/mozilla/event-source-expected.txt:
* storage/indexeddb/mozilla/global-data-expected.txt:
* storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
* storage/indexeddb/mozilla/indexes-expected.txt:
* storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
* storage/indexeddb/mozilla/key-requirements-expected.txt:
* storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
* storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
* storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
* storage/indexeddb/mozilla/object-cursors-expected.txt:
* storage/indexeddb/mozilla/object-identity-expected.txt:
* storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
* storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
* storage/indexeddb/mozilla/objectstorenames-expected.txt:
* storage/indexeddb/mozilla/odd-result-order-expected.txt:
* storage/indexeddb/mozilla/put-get-values-expected.txt:
* storage/indexeddb/mozilla/readonly-transactions-expected.txt:
* storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
* storage/indexeddb/mozilla/readyState-expected.txt:
* storage/indexeddb/mozilla/remove-index-expected.txt:
* storage/indexeddb/mozilla/remove-objectstore-expected.txt:
* storage/indexeddb/mozilla/versionchange-abort-expected.txt:
* storage/indexeddb/mozilla/versionchange-expected.txt:
* storage/indexeddb/mutating-cursor-expected.txt:
* storage/indexeddb/noblobs-expected.txt:
* storage/indexeddb/objectStore-required-arguments-expected.txt:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/objectstore-clear-expected.txt:
* storage/indexeddb/objectstore-count-expected.txt:
* storage/indexeddb/objectstore-cursor-expected.txt:
* storage/indexeddb/objectstore-removeobjectstore-expected.txt:
* storage/indexeddb/odd-strings-expected.txt:
* storage/indexeddb/open-close-version-expected.txt:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/open-during-transaction-expected.txt:
* storage/indexeddb/opencursor-key-expected.txt:
* storage/indexeddb/pending-activity-expected.txt:
* storage/indexeddb/pending-activity-workers-expected.txt:
* storage/indexeddb/pending-version-change-on-exit-expected.txt:
* storage/indexeddb/persistence-expected.txt:
* storage/indexeddb/prefetch-bugfix-108071-expected.txt:
* storage/indexeddb/queued-commands-expected.txt:
* storage/indexeddb/readonly-expected.txt:
* storage/indexeddb/readonly-properties-expected.txt:
* storage/indexeddb/request-continue-abort-expected.txt:
* storage/indexeddb/request-event-propagation-expected.txt:
* storage/indexeddb/setVersion-null-expected.txt:
* storage/indexeddb/set_version_blocked-expected.txt:
* storage/indexeddb/set_version_queue-expected.txt:
* storage/indexeddb/structured-clone-expected.txt:
* storage/indexeddb/three-setversion-calls-expected.txt:
* storage/indexeddb/transaction-abort-expected.txt:
* storage/indexeddb/transaction-active-flag-expected.txt:
* storage/indexeddb/transaction-after-close-expected.txt:
* storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
* storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
* storage/indexeddb/transaction-complete-workers-expected.txt:
* storage/indexeddb/transaction-crash-on-abort-expected.txt:
* storage/indexeddb/transaction-error-expected.txt:
* storage/indexeddb/transaction-event-propagation-expected.txt:
* storage/indexeddb/transaction-read-only-expected.txt:
* storage/indexeddb/transaction-rollback-expected.txt:
* storage/indexeddb/transaction-storeNames-required-expected.txt:
* storage/indexeddb/tutorial-expected.txt:
* storage/indexeddb/two-version-changes-expected.txt:
* storage/indexeddb/value-undefined-expected.txt:
* storage/indexeddb/values-odd-types-expected.txt:
* storage/indexeddb/version-change-abort-expected.txt:
* storage/indexeddb/version-change-exclusive-expected.txt:
* storage/indexeddb/versionchangerequest-activedomobject-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOSR exit sometimes neglects to create the arguments object
ggaren@apple.com [Thu, 20 Sep 2012 04:44:43 +0000 (04:44 +0000)]
OSR exit sometimes neglects to create the arguments object
https://bugs.webkit.org/show_bug.cgi?id=97162

Reviewed by Filip Pizlo.

../JavaScriptCore:

No performance change.

I don't know of any case where this is a real problem in TOT, but it
will become a problem if we start compiling eval, with, or catch, and/or
sometimes stop doing arguments optimizations in the bytecode.

* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run): Account for a
CreateArguments that has transformed into PhantomArguments. We used to
clear our reference to the CreateArguments node, but now we hold onto it,
so we need to account for it transforming.

Don't replace a SetLocal(CreateArguments) with a SetLocal(JSValue())
because that doesn't leave enough information behind for OSR exit to do
the right thing. Instead, maintain our reference to CreateArguments, and
rely on CreateArguments transforming into PhantomArguments after
optimization. SetLocal(PhantomArguments) is efficient, and it's a marker
for OSR exit to create the arguments object.

Don't ASSERT that all PhantomArguments are unreferenced because we now
leave them in the graph as SetLocal(PhantomArguments), and that's harmless.

* dfg/DFGArgumentsSimplificationPhase.h:
(NullableHashTraits):
(JSC::DFG::NullableHashTraits::emptyValue): Export our special hash table
for inline call frames so the OSR exit compiler can use it.

* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit): Don't load the 'arguments'
register to decide if we need to create the arguments object. Optimization
may have eliminated the initializing store to this register, in which
case we'll load garbage. Instead, use the global knowledge that all call
frames that optimized out 'arguments' now need to create it, and use a hash
table to make sure we do so only once per call frame.

* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): SetLocal(PhantomArguments) is unique
because we haven't just changed a value's format or elided a load or store;
instead, we've replaced an object with JSValue(). We could try to account
for this in a general way, but for now it's a special-case optimization,
so we give it a specific OSR hint instead.

../WTF:

* wtf/HashTraits.h:
(NullableHashTraits):
(WTF::NullableHashTraits::emptyValue):
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd partial load test for PNG images with no alpha
noel.gordon@gmail.com [Thu, 20 Sep 2012 04:27:46 +0000 (04:27 +0000)]
Add partial load test for PNG images with no alpha
https://bugs.webkit.org/show_bug.cgi?id=96064

Reviewed by Simon Fraser.

Partial load test for a PNG image with no alpha: receive a partial number of image
bytes and stall forever. The partial image should be decoded and drawn and the green
<img> background should be visible.

* fast/images/resources/lenna.png: Added: this PNG image has no alpha.
* http/tests/images/png-partial-load-no-alpha-expected.png: Added.
* http/tests/images/png-partial-load-no-alpha-expected.txt: Added.
* http/tests/images/png-partial-load-no-alpha.html: Added.
* platform/chromium/http/tests/images/png-partial-load-no-alpha-expected.png: Added.
* platform/mac/TestExpectations: Add an IMAGE failure for the mac port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Basic authentication challenge credentials for stored credentials again...
commit-queue@webkit.org [Thu, 20 Sep 2012 02:34:43 +0000 (02:34 +0000)]
[BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
https://bugs.webkit.org/show_bug.cgi?id=96362

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-09-19
Reviewed by Rob Buis.

Source/WebCore:

This patch enable reading credentials from the persistent credential storage
when it is not private browsing mode and there is not a credential in the RAM
for the requested resource.

Since we don't load persistent stored credentials into RAM at the starting time,
even we have saved the credentials at the last browsing, after restarting the browser,
it will still challenge for credentials for the requesting resources.

No new tests, it uses the original authentication tests. There is no way to
clear all credentials or restarting browsers to test this feature.

* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::getProtectionSpace):
(WebCore):
* platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):

Source/WebKit/blackberry:

Make the FrameLoaderClient use credential storage according to the macro
BLACKBERRY_CREDENTIAL_PERSIST

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
(WebCore):
* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refactoring] ButtonInputType of <input> element should have innerElement to make...
shinyak@chromium.org [Thu, 20 Sep 2012 02:07:27 +0000 (02:07 +0000)]
[Refactoring] ButtonInputType of <input> element should have innerElement to make <input> AuthorShadowDOM-ready
https://bugs.webkit.org/show_bug.cgi?id=95939

Reviewed by Dimitri Glazkov.

We had 2 ways to show text in RenderButton. One is to use RenderButton::setText() and the other is to add renderer
as a child of RenderButton. <input type="button"> used the former one, and <button> used the latter one.
The former makes RenderButton a bit messy, and also prevents from making <input> AuthorShadowDOM ready.

So we remove RenderButton::setText() and refactor <input type="button"> to use a Shadow DOM to show text.

Since the text in <input type="button"> should create RenderTextFragment, we introduce TextForButtonInputType
class. RenderText will allow us to select the inner text of <input>, but it should not.

No new tests, existing tests should cover the change.

* html/BaseButtonInputType.cpp:
(TextForButtonInputType): Special Text node which creates RenderTextFragment.
(WebCore):
(WebCore::TextForButtonInputType::create):
(WebCore::TextForButtonInputType::TextForButtonInputType):
(WebCore::TextForButtonInputType::createRenderer):
(WebCore::BaseButtonInputType::BaseButtonInputType):
(WebCore::BaseButtonInputType::createShadowSubtree):
(WebCore::BaseButtonInputType::destroyShadowSubtree):
(WebCore::BaseButtonInputType::valueAttributeChanged): When a button value is changed, we reflect the value to
the text node in ShadowDOM.
* html/BaseButtonInputType.h:
(BaseButtonInputType):
* html/FileInputType.cpp:
(WebCore::UploadButtonElement::create): Creates Shadow DOM subtree.
(WebCore::UploadButtonElement::createForMultiple): Creates Shadow DOM subtree.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
* html/InputType.cpp:
(WebCore::InputType::valueAttributeChanged):
(WebCore):
* html/InputType.h:
(InputType):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::RenderButton):
(WebCore::RenderButton::styleDidChange): Removed unnecessary text related code.
* rendering/RenderButton.h:
(RenderButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove webkitPostMessage
abarth@webkit.org [Thu, 20 Sep 2012 02:05:09 +0000 (02:05 +0000)]
Remove webkitPostMessage
https://bugs.webkit.org/show_bug.cgi?id=96577

Reviewed by Ojan Vafai.

Actually disable webkitPostMessage. See
http://trac.webkit.org/changeset/128658 for more information.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Get infinite amount of requests after attempting re-authentication basic.
jason.liu@torchmobile.com.cn [Thu, 20 Sep 2012 02:05:05 +0000 (02:05 +0000)]
[BlackBerry] Get infinite amount of requests after attempting re-authentication basic.
https://bugs.webkit.org/show_bug.cgi?id=96994

Reviewed by Rob Buis.

We should remove the wrong credentials before calling sendRequestWithCredentials again.
#PR 200226
Reviewed internally by Jonathan Dong.

No new tests. It is covered by ManualTests/blackberry/http-auth-challenge.html.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix regex groups for bug matching in flakiness dashboard.
dpranke@chromium.org [Thu, 20 Sep 2012 01:52:02 +0000 (01:52 +0000)]
Fix regex groups for bug matching in flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=97152

Unreviewed, build fix.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(htmlForBugs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove Blob.webkitSlice
abarth@webkit.org [Thu, 20 Sep 2012 01:41:03 +0000 (01:41 +0000)]
Remove Blob.webkitSlice
https://bugs.webkit.org/show_bug.cgi?id=96715

Reviewed by Darin Fisher.

Based on these usage metrics, it appears that it is safe to remove
Blob.webkitSlice. Folks that were previously calling webkitSlice should
just call slice instead. They do the same thing.

Ratio of Blob.webkitSlice calls to Blob.slice: 14.87%
Ratio of Blob.webkitSlice calls to Document creation: 0.0053%

* fileapi/Blob.cpp:
(WebCore::Blob::slice):
* fileapi/Blob.h:
(Blob):
* fileapi/Blob.idl:
* fileapi/File.h:
(File):
* inspector/front-end/FileUtils.js:
(WebInspector.ChunkedFileReader.prototype._loadChunk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: print unexpected results using new TestExpectations syntax
dpranke@chromium.org [Thu, 20 Sep 2012 01:34:02 +0000 (01:34 +0000)]
nrwt: print unexpected results using new TestExpectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97159

Unreviewed, build fix.

Change new-run-webkit-tests to print out failures using the new
syntax when there are unexpected results, e.g.:

52 tests ran as expected, 19 didn't:

Regressions: Unexpected failures : (2)
  failures/flaky/text.html [ Failure ]
  failures/unexpected/text-image-checksum.html [ Failure ]

and so forth

* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._print_unexpected_results):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoupdate flakiness dashboard after cutover to new test expectations syntax
dpranke@chromium.org [Thu, 20 Sep 2012 01:13:32 +0000 (01:13 +0000)]
update flakiness dashboard after cutover to new test expectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97152

Unreviewed, build fix.

Handle (??) the new Bug notations as well. Hopefully we don't
still need the old ones.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(filterBugs):
(htmlForBugs):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoupdate flakiness dashboard after cutover to new test expectations syntax
dpranke@chromium.org [Thu, 20 Sep 2012 00:59:24 +0000 (00:59 +0000)]
update flakiness dashboard after cutover to new test expectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97152

Reviewed by Ryosuke Niwa.

This change clones the TestExpectation parsing state machine
from python into javascript.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(parsedExpectations.lines.forEach):
(parsedExpectations):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe collapsing border code needs direction-aware border getters
jchaffraix@webkit.org [Thu, 20 Sep 2012 00:58:58 +0000 (00:58 +0000)]
The collapsing border code needs direction-aware border getters
https://bugs.webkit.org/show_bug.cgi?id=96710

Reviewed by Ojan Vafai.

This refactoring is needed to extend our collapsing border support for mixed directionality
at the table cell level (we currently wrongly ignore any direction below the row-group). For
now, the new helpers are dumb and return exactly the old result but they will be made
direction-aware in a follow-up change.

Refactoring covered by existing tests.

* rendering/RenderBox.h:
(WebCore::RenderBox::hasSameDirectionAs):
Added this helper function. For now, it's only used to compare against
the table direction but we will reuse it to compare the current cell
direction against the other table parts.

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
Transitioned those 2 functions to using the new direction-aware functions.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::tableStartBorderAdjoiningCell):
(WebCore::RenderTable::tableEndBorderAdjoiningCell):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::firstRowCellAdjoiningTableStart):
(WebCore::RenderTableSection::firstRowCellAdjoiningTableEnd):
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::borderAdjoiningTableStart):
(WebCore::RenderTableCell::borderAdjoiningTableEnd):
* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::borderAdjoiningTableStart):
(WebCore::RenderTableSection::borderAdjoiningTableEnd):
Updated those call sites to use RenderBox::hasSameDirectionAs.

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::borderAdjoiningNextCell):
(WebCore::RenderTableCell::borderAdjoiningPreviousCell):
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::borderAdjoiningCellStartBorder):
(WebCore::RenderTableCol::borderAdjoiningCellEndBorder):
(WebCore::RenderTableCol::borderAdjoiningCellBefore):
(WebCore::RenderTableCol::borderAdjoiningCellAfter):
* rendering/RenderTableCol.h:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::borderAdjoiningStartCell):
(WebCore::RenderTableRow::borderAdjoiningEndCell):
* rendering/RenderTableRow.h:
(WebCore::RenderTableRow::borderAdjoiningTableStart):
(WebCore::RenderTableRow::borderAdjoiningTableEnd):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::borderAdjoiningStartCell):
(WebCore::RenderTableSection::borderAdjoiningEndCell):
New direction-aware functions. Added some ASSERT to ensure
we don't call them with the wrong parameters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] ScriptController::compileAndRunScript() can crash
haraken@chromium.org [Thu, 20 Sep 2012 00:41:26 +0000 (00:41 +0000)]
[V8] ScriptController::compileAndRunScript() can crash
https://bugs.webkit.org/show_bug.cgi?id=96567

Reviewed by Adam Barth.

See chromium bug: http://code.google.com/p/chromium/issues/detail?id=146776

The root cause is that v8::PreCompile() can return 0 when the stack of
V8's parser overflows (c.f. http://code.google.com/codesearch#OAMlx_jo-ck/src/v8/src/parser.cc&exact_package=chromium&q=kPreParseStackOverflow&type=cs&l=6021).

This patch adds the 0 check to the caller side. Given that precompileScript()
is just trying to speculatively precompile a script, it's OK to give up
precompiling for such edge cases.

Manually tested with the html generated by the following shell script:

  echo '<script language="JavaScript" type="text/javascript" src="asan-crash.js"></script>' > asan-crash.html
  echo 'if(wURLF.search("")>=0) {}' > asan-crash.js
  for i in `seq 14830`
  do
    echo 'else if(wURLF.search("")>=0) {}' >> asan-crash.js
  done

I didn't add the test because '14380' depends on an environment
and because we don't want to add a huge html test.

* bindings/v8/ScriptSourceCode.cpp:
(WebCore::ScriptSourceCode::precompileScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Pending call cleanup
jsbell@chromium.org [Thu, 20 Sep 2012 00:12:51 +0000 (00:12 +0000)]
IndexedDB: Pending call cleanup
https://bugs.webkit.org/show_bug.cgi?id=96952

Reviewed by Tony Chang.

Replace RefPtr usage with OwnPtr for PendingXXXCalls (since they're never referenced twice)
and replace queue of "second half open" calls with a single item.

No new tests - no functional changes.

* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::close):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAttempt to unskip some tests by removing them from the Skipped list.
simon.fraser@apple.com [Thu, 20 Sep 2012 00:06:28 +0000 (00:06 +0000)]
Attempt to unskip some tests by removing them from the Skipped list.

Added new baselines for those that need them.

* platform/mac/Skipped:
* platform/mac/fast/block/float/float-in-float-hit-testing-expected.txt:
* platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
* platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.txt:
* platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
* platform/mac/fast/layers/video-layer-expected.txt:
* platform/mac/fast/table/cell-pref-width-invalidation-expected.txt:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/mac/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
* platform/mac/media/video-empty-source-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2123-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2509-expected.txt:
* platform/mac/tables/mozilla/bugs/bug34176-expected.txt:
* platform/mac/tables/mozilla/bugs/bug44505-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Improve glyph positioning of HarfBuzzShaper
bashi@chromium.org [Thu, 20 Sep 2012 00:00:45 +0000 (00:00 +0000)]
[Chromium] Improve glyph positioning of HarfBuzzShaper
https://bugs.webkit.org/show_bug.cgi?id=97093

Reviewed by Tony Chang.

For proper positioning, HarfBuzzShaper requires the positions(offsets and advance)
of the previous glyph. This mean we need to shape all HarfBuzzRuns before glyph positioning.
Collect and shape HarfBuzzRuns, then set positions of glyphs.

No new tests. Tests that uses spacing for complex text (e.g. fast/text/atsui-negative-spacing-features.html)
should close in the expectations. (not the identical, maybe there are subtle differences between
harfbuzz old and harfbuzz ng)

* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzRun::applyShapeResult): Allocate m_offsets.
(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions): Renamed and set offset too.
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
(WebCore::HarfBuzzShaper::shape): Call fillGlyphBuffer() if we need to fill glyphBuffer.
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Removed glyph positioning code.
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun): Ditto.
(WebCore::HarfBuzzShaper::fillGlyphBufferFromHarfBuzzRun): Added.
(WebCore):
(WebCore::HarfBuzzShaper::fillGlyphBuffer): Added.
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:
(HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::offsets): Added.
(WebCore::HarfBuzzShaper::HarfBuzzRun::glyphToCharacterIndexes): Added.
(HarfBuzzShaper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd backer@chromium.org as contributor
danakj@chromium.org [Wed, 19 Sep 2012 23:59:01 +0000 (23:59 +0000)]
Add backer@chromium.org as contributor
https://bugs.webkit.org/show_bug.cgi?id=97150

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix expectation conflict on fast/hidpi/video-controls-in-hidpi.html
dpranke@chromium.org [Wed, 19 Sep 2012 23:58:07 +0000 (23:58 +0000)]
[chromium] Fix expectation conflict on fast/hidpi/video-controls-in-hidpi.html

Unreviewed, exepectations change.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix v8 bug urls after syntax conversion
dpranke@chromium.org [Wed, 19 Sep 2012 23:55:02 +0000 (23:55 +0000)]
Fix v8 bug urls after syntax conversion

Unreviewed, expectations change.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Disable resource load scheduling
simonjam@chromium.org [Wed, 19 Sep 2012 23:53:31 +0000 (23:53 +0000)]
[Chromium] Disable resource load scheduling
https://bugs.webkit.org/show_bug.cgi?id=97131

Reviewed by Nate Chapin.

Source/WebCore:

We'll use Chrome's network stack for scheduling instead.

No new tests.

* loader/ResourceLoadScheduler.cpp:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::preload):

LayoutTests:

The preload scanner loads resources sooner and these tests are affected.

* platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
* platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofix MISSING after TestExpectations conversion
dpranke@chromium.org [Wed, 19 Sep 2012 23:49:55 +0000 (23:49 +0000)]
fix MISSING after TestExpectations conversion
https://bugs.webkit.org/show_bug.cgi?id=97148

Tools:

Unreviewed, expectations change / build fix.

* Scripts/convert-test-expectations:
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):

LayoutTests:

Unreviewed, expectations change.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt-4.8/TestExpectations:
* platform/qt-mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWhen kerning is enabled, word spacing is doubly accounted for in RenderText::computeP...
mitz@apple.com [Wed, 19 Sep 2012 23:37:36 +0000 (23:37 +0000)]
When kerning is enabled, word spacing is doubly accounted for in RenderText::computePreferredLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=97146

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/text/word-space-with-kerning.html

* rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths): When kerning is enabled, words are
measured with their trailing space, if there is one, then the width of a space is subtracted.
Changed that width, stored in the local variable wordTrailingSpaceWidth, to include the
word spacing, since it is included in the result of widthFromCache().

LayoutTests:

* fast/text/word-space-with-kerning-expected.html: Added.
* fast/text/word-space-with-kerning.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix lines missed (??) in mac-wk2/TestExpectations
dpranke@chromium.org [Wed, 19 Sep 2012 23:29:41 +0000 (23:29 +0000)]
Fix lines missed (??) in mac-wk2/TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=97143

Unreviewed, expectations change.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Remove "current transaction" concept from backing store
jsbell@chromium.org [Wed, 19 Sep 2012 23:27:20 +0000 (23:27 +0000)]
IndexedDB: Remove "current transaction" concept from backing store
https://bugs.webkit.org/show_bug.cgi?id=96663

Reviewed by Tony Chang.

Source/WebCore:

IndexedDB should allow multiple transactions to run in parallel within and
across databases within an origin. As an initial step to enabling this, the
backing store should not hold a "current transaction" - instead, operations
should be done relative to a transaction managed by the database.

No new tests - no functional changes.

* Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
(WebCore::IDBDatabaseBackendImpl::setIntVersionInternal):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):
* Modules/indexeddb/IDBIndexBackendImpl.h:
(IDBIndexBackendImpl):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
(WebCore):
(WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::clearObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::deleteIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::findKeyInIndex):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openObjectStoreKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):
(WebCore::IDBLevelDBBackingStore::Transaction::Transaction):
(WebCore::IDBLevelDBBackingStore::Transaction::begin):
(WebCore::IDBLevelDBBackingStore::Transaction::commit):
(WebCore::IDBLevelDBBackingStore::Transaction::rollback):
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
(WebCore::IDBLevelDBBackingStore::Transaction::levelDBTransaction):
(Transaction):
(WebCore::IDBLevelDBBackingStore::Transaction::levelDBTransactionFrom):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::count):
(WebCore::IDBObjectStoreBackendImpl::countInternal):
(WebCore::IDBObjectStoreBackendImpl::generateKey):
(WebCore::IDBObjectStoreBackendImpl::updateKeyGenerator):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):

Source/WebKit/chromium:

Update fake class with new method signatures.

* tests/IDBFakeBackingStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r128802): It made some JS tests crash
fpizlo@apple.com [Wed, 19 Sep 2012 23:27:00 +0000 (23:27 +0000)]
REGRESSION(r128802): It made some JS tests crash
https://bugs.webkit.org/show_bug.cgi?id=97001

Reviewed by Mark Hahnenberg.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoconvert chromium android TestExpectations to the new syntax
dpranke@chromium.org [Wed, 19 Sep 2012 23:25:50 +0000 (23:25 +0000)]
convert chromium android TestExpectations to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97145

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

* platform/chromium-android/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: convert chromium TestExpectations to the new syntax
dpranke@chromium.org [Wed, 19 Sep 2012 23:23:02 +0000 (23:23 +0000)]
nrwt: convert chromium TestExpectations to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97139

Reviewed by Ryosuke Niwa.

Actually land the file supposedly landed below :).

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoconvert apple win TestExpectations files to the new syntax
dpranke@chromium.org [Wed, 19 Sep 2012 23:19:44 +0000 (23:19 +0000)]
convert apple win TestExpectations files to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97144

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

* platform/win-wk2/TestExpectations:
* platform/win-xp/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoconvert apple mac TestExpectations files to the new syntax
dpranke@chromium.org [Wed, 19 Sep 2012 23:17:44 +0000 (23:17 +0000)]
convert apple mac TestExpectations files to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97143

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

* platform/mac-lion/TestExpectations:
* platform/mac-snowleopard/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoconvert Efl TestExpectations to the new syntax
dpranke@chromium.org [Wed, 19 Sep 2012 23:15:07 +0000 (23:15 +0000)]
convert Efl TestExpectations to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97142

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoconvert Gtk TestExpectations files to the new syntax
dpranke@chromium.org [Wed, 19 Sep 2012 23:11:34 +0000 (23:11 +0000)]
convert Gtk TestExpectations files to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97141

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: convert Qt TestExpectations to the new format
dpranke@chromium.org [Wed, 19 Sep 2012 23:02:43 +0000 (23:02 +0000)]
nrwt: convert Qt TestExpectations to the new format
https://bugs.webkit.org/show_bug.cgi?id=97140

Unreviewed, expectations change.

Files were converted using Tools/Scripts/convert-test-expectations.

* platform/qt-4.8/TestExpectations:
* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-arm/TestExpectations:
* platform/qt-mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: convert chromium TestExpectations to the new syntax
dpranke@chromium.org [Wed, 19 Sep 2012 23:00:37 +0000 (23:00 +0000)]
nrwt: convert chromium TestExpectations to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97139

Tools:

Reviewed by Ryosuke Niwa.

Add in a file temporarily that does the conversion of
test expectations formats

* Tools/Scripts/convert-test-expectations: Added.

LayoutTests:

Reviewed by Ryosuke Niwa.

This does a wholesale change of the file from

  BUGS MODIFIERS : test = EXPECTATIONS

to

  Bugs [ Modifiers] test [ Expectations ]

as per the new syntax.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed - remove debugging code from a pair of tests.
jsbell@chromium.org [Wed, 19 Sep 2012 22:53:20 +0000 (22:53 +0000)]
Unreviewed - remove debugging code from a pair of tests.

During development these tests had their own timers to terminate early
rather than timing out, so partial script output could be seen. Removing,
as it could cause the tests to flake under load.

* storage/indexeddb/lazy-index-population.html:
* storage/indexeddb/resources/cursor-finished.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: run-perf-tests no longer reports the total test time
rniwa@webkit.org [Wed, 19 Sep 2012 22:48:03 +0000 (22:48 +0000)]
REGRESSION: run-perf-tests no longer reports the total test time
https://bugs.webkit.org/show_bug.cgi?id=97138

Reviewed by Tony Chang.

Report the finished time as a info-level log as opposed to a debug level log.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._run_single_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_run_memory_test):
(_test_run_with_json_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Store the contents scale factor in PlatformContextSkia on initialization
commit-queue@webkit.org [Wed, 19 Sep 2012 22:43:51 +0000 (22:43 +0000)]
[chromium] Store the contents scale factor in PlatformContextSkia on initialization
https://bugs.webkit.org/show_bug.cgi?id=96137

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-09-19
Reviewed by Stephen White.

Source/WebCore:

When the compositor creates a PlatformContextSkia, the scale on |canvas| will
be equal to the content scale factor (which, without pinch-to-zoom, will be
the same as the device scale factor). Set this value as a member on PlatformContextSkia,
which will be used to correctly render glyphs when hinting is used and the device
scale factor is not 1.

Tests: added two new unit tests.

* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::setupPaintCommon):
* platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
(WebCore::PlatformContextSkia::setHintingScaleFactor):
(WebCore::PlatformContextSkia::hintingScaleFactor):

Source/WebKit/chromium:

Define SK_SUPPORT_HINTING_SCALE_FACTOR by default. This is also used
for the skia patch here: https://codereview.appspot.com/6506099/.
Also added two new unit tests.

* features.gypi:
* tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore):
(WebCore::HintingScaleCallback::HintingScaleCallback):
(HintingScaleCallback):
(WebCore::HintingScaleCallback::operator()):
(WebCore::TEST_F):
* tests/PlatformContextSkiaTest.cpp:
(WebCore):
(WebCore::TEST):

LayoutTests:

These tests will fail due to a font hinting/rasterization issue with
chromium DRT pixel tests having a page/device scale factor of 2.
See crbug.com/150682.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG should not assume that a ByVal access is generic just because it was unprofiled
fpizlo@apple.com [Wed, 19 Sep 2012 22:36:44 +0000 (22:36 +0000)]
DFG should not assume that a ByVal access is generic just because it was unprofiled
https://bugs.webkit.org/show_bug.cgi?id=97088

Reviewed by Geoffrey Garen.

We were not disambiguating between "Undecided" in the sense that the array profile
has no useful information versus "Undecided" in the sense that the array profile
knows that the access has not executed. That's an important distinction, since
the former form of "Undecided" means that we should consult value profiling, while
the latter means that we should force exit unless the value profiling indicates
that the access must be generic (base is not cell or property is not int).

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGArrayMode.cpp:
(JSC::DFG::fromObserved):
(JSC::DFG::refineArrayMode):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):
* dfg/DFGArrayMode.h:
(JSC::DFG::canCSEStorage):
(JSC::DFG::modeIsSpecific):
(JSC::DFG::modeSupportsLength):
(JSC::DFG::benefitsFromStructureCheck):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport new TestExpectations format alongside old one
dpranke@chromium.org [Wed, 19 Sep 2012 22:36:35 +0000 (22:36 +0000)]
Support new TestExpectations format alongside old one
https://bugs.webkit.org/show_bug.cgi?id=96588

Reviewed by Ojan Vafai.

This patch adds support for actually reading in lines formatted
in the new style, and when we re-serialize/write out the file,
all lines will be written in the new style. Note that reading in
the old style is still supported, and no updates are being made
to the actual TestExpectations files as part of this change.

This change updates most but not all of the unit tests to use
the new syntax. I will update the rest when (or before where
possible) I drop support for the old format.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
(TestExpectationParser._tokenize_line):
(TestExpectationParser._tokenize_line_using_new_format):
(TestExpectationLine.to_string):
(TestExpectationLine._format_line):
(TestExpectations):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_parse_warning):
(SkippedTests.test_skipped_entry_dont_exist):
(NewExpectationSyntaxTests.test_warnings):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):
(RebaseliningTest.test_remove):
(RebaseliningTest.test_no_get_rebaselining_failures):
(TestExpectationParserTests.test_tokenize_blank):
(TestExpectationParserTests.test_tokenize_extra_colon):
(TestExpectationParserTests.test_tokenize_missing_equal):
(TestExpectationParserTests.test_tokenize_extra_equal):
(TestExpectationSerializationTests.test_unparsed_to_string):
(TestExpectationSerializationTests.test_unparsed_list_to_string):
(TestExpectationSerializationTests.test_parsed_to_string):
(TestExpectationSerializationTests.test_format_line):
(TestExpectationSerializationTests.test_string_roundtrip):
(TestExpectationSerializationTests.test_list_roundtrip):
(TestExpectationSerializationTests.test_reconstitute_only_these):
(TestExpectationSerializationTests.test_string_whitespace_stripping):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(LintTest.test_lint_test_files__errors):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_basic):
(PrintExpectationsTest.test_multiple):
(PrintExpectationsTest.test_full):
(PrintExpectationsTest.test_exclude):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineExpectations.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_expectations_noop):
(test_overrides_are_included_correctly):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoimplement first part of support for the new TestExpectations syntax
dpranke@chromium.org [Wed, 19 Sep 2012 22:29:45 +0000 (22:29 +0000)]
implement first part of support for the new TestExpectations syntax
https://bugs.webkit.org/show_bug.cgi?id=96569

Reviewed by Ryosuke Niwa.

This patch implements support for parsing a line of the new
format for the TestExpectations file and converting it back into
the old format for compatibility. This routine is not yet used
by anything.

The new format is documented at:
  http://trac.webkit.org/wiki/TestExpectations

but, in short:

  [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]

- Comments are indicated with "#" instead of "//"
- If no expectations are specified we default to Skip for
  compatibility with the Skipped files (these two changes make
  Skipped files a subset of TestExpectations files)

- All of the tokens are now CamelCase instead of ALLCAPS.
- FAIL -> Failure
- IMAGE -> ImageOnlyFailure
- WONTFIX -> WontFix
- modifiers refer to just the platforms and configurations
  (release/debug) that the line applies to.
- WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
  expectations
- expectations will typically be written out in lexicographic order
- We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
  instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
(TestExpectationParser._tokenize_line_using_new_format):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(NewExpectationSyntaxTests):
(NewExpectationSyntaxTests.assert_exp):
(NewExpectationSyntaxTests.test_bare_name):
(NewExpectationSyntaxTests.test_bare_name_and_bugs):
(NewExpectationSyntaxTests.test_comments):
(NewExpectationSyntaxTests.test_config_modifiers):
(NewExpectationSyntaxTests.test_unknown_config):
(NewExpectationSyntaxTests.test_unknown_expectation):
(NewExpectationSyntaxTests.test_skip):
(NewExpectationSyntaxTests.test_slow):
(NewExpectationSyntaxTests.test_wontfix):
(NewExpectationSyntaxTests.test_blank_line):
(NewExpectationSyntaxTests.test_warnings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] HarfBuzzShaper should take into account combining characters
bashi@chromium.org [Wed, 19 Sep 2012 22:29:05 +0000 (22:29 +0000)]
[Chromium] HarfBuzzShaper should take into account combining characters
https://bugs.webkit.org/show_bug.cgi?id=97069

Reviewed by Tony Chang.

When dividing a text run into HarfBuzzRuns, try to find suitable SimpleFontData for
combining character sequence if there are one or more mark characters are followed.
If there is no combined glyphs in the font, use fallback font for mark characters.

No new tests.
In platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html,
U+0947 (devanagari vowel sign e) should be displayed.
In fast/text/wide-zero-width-space.html, &eacute; and e&#0301; should look identical.

* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore):
(WebCore::fontDataForCombiningCharacterSequence): Added.
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns): See above description.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWarning in SandboxExtension.h if WEB_PROCESS_SANDBOX is not enabled
psolanki@apple.com [Wed, 19 Sep 2012 22:23:25 +0000 (22:23 +0000)]
Warning in SandboxExtension.h if WEB_PROCESS_SANDBOX is not enabled
https://bugs.webkit.org/show_bug.cgi?id=97137

Reviewed by Benjamin Poulain.

m_size is only used when WEB_PROCESS_SANDBOX is enabled, so move its declaration inside
#if ENABLE(WEB_PROCESS_SANDBOX).

* Shared/SandboxExtension.h:
(HandleArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable some failing IDB tests
dgrogan@chromium.org [Wed, 19 Sep 2012 22:01:09 +0000 (22:01 +0000)]
Disable some failing IDB tests
https://bugs.webkit.org/show_bug.cgi?id=97135

Reviewed by Nate Chapin.

They were broken in r129037.

* tests/IDBDatabaseBackendTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
dpranke@chromium.org [Wed, 19 Sep 2012 21:51:57 +0000 (21:51 +0000)]
nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
https://bugs.webkit.org/show_bug.cgi?id=96845

Reviewed by Ojan Vafai.

In preparation for the new TestExpectations syntax, we replace
all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
make switching to the new syntax lossless (i.e., we lose
information now, not then).

Tools:

Note that we can still parse in results.json files that have the
old data for backwards compatibility.

* Scripts/webkitpy/common/net/resultsjsonparser.py:
(JSONTestResult._failure_types_from_actual_result):
* Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
(ResultsJSONParserTest):
(test_basic):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.test_summarized_results_wontfix):
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations):
(TestExpectations.remove_pixel_failures):
(TestExpectations.has_pixel_failures):
(TestExpectations.suffixes_for_expectations):
(TestExpectations.get_rebaselining_failures):
(TestExpectations.remove_configuration_from_test):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(assert_bad_expectations):
(BasicTests):
(BasicTests.test_basic):
(MiscTests):
(MiscTests.test_multiple_results):
(MiscTests.test_result_was_expected):
(MiscTests.test_remove_pixel_failures):
(MiscTests.test_suffixes_for_expectations):
(test_get_expectations_string):
(test_parse_warning):
(test_error_on_different_platform):
(test_error_on_different_build_type):
(test_overrides):
(test_overrides__directory):
(test_overrides__duplicate):
(test_pixel_tests_flag):
(test_more_specific_override_resets_skip):
(SkippedTests.test_skipped_file_overrides_expectations):
(SkippedTests.test_skipped_dir_overrides_expectations):
(SkippedTests.test_skipped_file_overrides_overrides):
(SkippedTests.test_skipped_dir_overrides_overrides):
(ExpectationSyntaxTests.test_missing_colon):
(ExpectationSyntaxTests.test_too_many_equals_signs):
(SemanticTests.test_bug_format):
(SemanticTests.test_bad_bugid):
(SemanticTests.test_missing_bugid):
(SemanticTests.test_rebaseline):
(test_missing_file):
(test_more_modifiers):
(test_order_in_file):
(test_macro_overrides):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):
(RebaseliningTest.test_remove):
(TestExpectationSerializationTests.test_serialize_parsed_expectations):
* Scripts/webkitpy/layout_tests/models/test_failures.py:
(determine_result_type):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(test_test_expectations):
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_missing_and_unexpected_results):
(MainTest.test_retrying_and_flaky_tests):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_valid_expectations):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_basic):
(PrintExpectationsTest.test_multiple):
(PrintExpectationsTest.test_full):
(PrintExpectationsTest.test_exclude):
(PrintExpectationsTest.test_csv):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_does_not_include_overrides):
(test_overrides_are_included_correctly):

LayoutTests:

* platform/chromium-android/TestExpectations:
* platform/chromium/TestExpectations:
* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt-4.8/TestExpectations:
* platform/qt-arm/TestExpectations:
* platform/qt-mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129047 268f45cc-cd09-0410-ab3c-d52691b4dbfc