WebKit-https.git
9 years ago2010-09-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 20 Sep 2010 04:26:46 +0000 (04:26 +0000)]
2010-09-19  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move reviewtool to action=review
        https://bugs.webkit.org/show_bug.cgi?id=46071

        This patch removes the old Review Patch screen and moves the new
        reviewtool from Pretty Diff to Review Patch.

        * attachment.cgi:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2 decidePolicyForNavigationAction should include mouse button information
weinig@apple.com [Mon, 20 Sep 2010 04:06:45 +0000 (04:06 +0000)]
WebKit2 decidePolicyForNavigationAction should include mouse button information
<rdar://problem/8413165>
https://bugs.webkit.org/show_bug.cgi?id=46060

Reviewed by Anders Carlsson.

WebKit2:

* UIProcess/API/C/WKAPICast.h:
(WebKit::toRef):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
* UIProcess/WebPolicyClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::findMouseEvent):
(WebKit::mouseButtonForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebKitTools:

* MiniBrowser/mac/BrowserWindowController.m:
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 20 Sep 2010 03:05:26 +0000 (03:05 +0000)]
2010-09-19  Adam Barth  <abarth@webkit.org>

        Review tool UI tweak.  This patch lengthens the status bubbles so all
        the bubble fit (even when they have numbers inside).

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Mon, 20 Sep 2010 02:41:14 +0000 (02:41 +0000)]
2010-09-19  Daniel Bates  <dbates@rim.com>

        Reviewed by Martin Robinson.

        Add unit tests for diffs that delete or modify a change log entry
        or describe changes that are far apart
        https://bugs.webkit.org/show_bug.cgi?id=46046

        Add additional unit tests to test change log diffs that contain
        deletions or changes that are far apart from each other in the
        ChangeLog file.

        * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
          - Added the following unit tests:
          "fixChangeLogPatch: [no change] In-place change."
          "fixChangeLogPatch: [no change] Remove first entry."
          "fixChangeLogPatch: [no change] Remove entry in the middle."
          "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Mon, 20 Sep 2010 02:27:15 +0000 (02:27 +0000)]
2010-09-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r67749.
        http://trac.webkit.org/changeset/67749
        https://bugs.webkit.org/show_bug.cgi?id=46068

        breaking ToT chromium canary build (Requested by shans on
        #webkit).

        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::createNewContext):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::registeredExtensionWithV8):
        (WebCore::V8Proxy::registerExtension):
        * bindings/v8/V8Proxy.h:
        * loader/EmptyClients.h:
        * loader/FrameLoaderClient.h:
2010-09-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r67749.
        http://trac.webkit.org/changeset/67749
        https://bugs.webkit.org/show_bug.cgi?id=46068

        breaking ToT chromium canary build (Requested by shans on
        #webkit).

        * public/WebFrameClient.h:
        * public/WebScriptController.h:
        * src/FrameLoaderClientImpl.cpp:
        * src/FrameLoaderClientImpl.h:
        * src/WebScriptController.cpp:
        (WebKit::WebScriptController::registerExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 20 Sep 2010 02:00:55 +0000 (02:00 +0000)]
2010-09-19  Dimitri Glazkov  <dglazkov@chromium.org>

        Move win-xp-specific baselines to their proper places.

        * platform/chromium-win-xp/fast/forms/search-styled-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/forms/search-styled-expected.txt.
        * platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.checksum.
        * platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png.
        * platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.txt.
        * platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.checksum.
        * platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png.
        * platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.txt.
        * platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.checksum.
        * platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.png.
        * platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt.
        * platform/chromium-win-xp/fast/text/international/plane2-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.checksum.
        * platform/chromium-win-xp/fast/text/international/plane2-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.png.
        * platform/chromium-win-xp/fast/text/international/plane2-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.txt.
        * platform/chromium-win-xp/svg/text/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.checksum.
        * platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.png.
        * platform/chromium-win-xp/svg/text/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix pt 2.
barraclough@apple.com [Mon, 20 Sep 2010 01:59:08 +0000 (01:59 +0000)]
Windows build fix pt 2.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Mihai Parparita <mihaip@chromium.org>
abarth@webkit.org [Mon, 20 Sep 2010 01:52:01 +0000 (01:52 +0000)]
2010-09-19  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] userscripts/user-script-top-frame-only.html has incorrect expectations
        https://bugs.webkit.org/show_bug.cgi?id=46064

        r62958 added incorrect expectations for this test. Chromium DRT actually
        gets this test right if we let it use the base expectations file. Mark
        the test as failing with test_shell only.

        * platform/chromium-mac/userscripts/user-script-top-frame-only-expected.txt: Removed.
        * platform/chromium-win/userscripts/user-script-top-frame-only-expected.txt: Removed.
        * platform/chromium/drt_expectations.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix pt 1.
barraclough@apple.com [Mon, 20 Sep 2010 01:43:11 +0000 (01:43 +0000)]
Windows build fix pt 1.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix - implicit double-to-int conversion invalid on 32-bit.
barraclough@apple.com [Mon, 20 Sep 2010 01:35:10 +0000 (01:35 +0000)]
Build fix - implicit double-to-int conversion invalid on 32-bit.

* runtime/DatePrototype.cpp:
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncSetYear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 46065 - Unify implementation of ToInt32 and ToUInt32, don't use fmod.
barraclough@apple.com [Mon, 20 Sep 2010 01:23:33 +0000 (01:23 +0000)]
Bug 46065 - Unify implementation of ToInt32 and ToUInt32, don't use fmod.

Reviewed by Oliver Hunt.

These methods implement the same conversion (see discussion in the notes
of sections of 9.5 and 9.6 of the spec), only differing in how the result
is interpretted.

JavaScriptCore:

Date prototype is incorrectly using toInt32, and this is causing us to
provide an output value indicating whether the input to ToInt32 was finite
(the corresponding methods on Date are actually spec'ed to use ToInteger,
not ToInt32).  This patch partially fixes this in order to remove this
bogus output value, hoewever more work will be require to bring Date
fully up to spec compliance (the constructor is still performing ToInt32
conversions).

* JavaScriptCore.exp:
* runtime/DatePrototype.cpp:
(JSC::fillStructuresUsingTimeArgs):
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncSetYear):
* runtime/JSValue.cpp:
(JSC::toInt32):
* runtime/JSValue.h:
(JSC::toUInt32):
(JSC::JSValue::toInt32):
(JSC::JSValue::toUInt32):

WebCore:

Removing JSValue::toInt32 (since this has weird, non-spec function).
A couple of places in the binding are using this method, so adding
finiteInt32Value to the bindings to maintain current behaviour.

Test: fast/js/toInt32UInt32.html

* bindings/js/JSDOMBinding.h:
(WebCore::finiteInt32Value):
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::add):
* bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
* bindings/js/JSSVGPODListCustom.h:
(WebCore::JSSVGPODListCustom::getItem):
(WebCore::JSSVGPODListCustom::insertItemBefore):
(WebCore::JSSVGPODListCustom::replaceItem):
(WebCore::JSSVGPODListCustom::removeItem):
* bindings/js/JSSVGPathSegListCustom.cpp:
(WebCore::JSSVGPathSegList::getItem):
(WebCore::JSSVGPathSegList::insertItemBefore):
(WebCore::JSSVGPathSegList::replaceItem):
(WebCore::JSSVGPathSegList::removeItem):

LayoutTests:

Add test cases for ToInt32 / ToUInt32 functionality.

* fast/js/script-tests/toInt32UInt32.js: Added.
* fast/js/toInt32UInt32-expected.txt: Added.
* fast/js/toInt32UInt32.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 19 Sep 2010 23:45:38 +0000 (23:45 +0000)]
2010-09-19  Dimitri Glazkov  <dglazkov@chromium.org>

        Fix up expectation sadness I introduced in http://trac.webkit.org/changeset/67822, because no sadness is allowed.

        * platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win-vista/css2.1/t1202-counter-09-b-checksum.png.
        * platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win-vista/css2.1/t1202-counters-09-b-checksum.png.
        * platform/chromium-win-xp/svg/batik/text/textFeatures-expected.checksum: Removed.
        * platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 19 Sep 2010 22:46:17 +0000 (22:46 +0000)]
2010-09-19  Dimitri Glazkov  <dglazkov@chromium.org>

        Create one more text baseline for win-vista.

        * platform/chromium-win-vista/fast/forms/search-styled-expected.txt: Added.
        * platform/chromium/drt_expectations.txt: Removed search-styled as it's now passing.
        * platform/chromium/test_expectations.txt: Removed an errant line break.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 19 Sep 2010 22:31:49 +0000 (22:31 +0000)]
2010-09-19  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        Update win-vista baselines for Chromium to make a few more tests pass.
        https://bugs.webkit.org/show_bug.cgi?id=46056

        * platform/chromium-win-vista/css2.1/t1202-counter-09-b-checksum.png: Added.
        * platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.png: Added.
        * platform/chromium-win-vista/css2.1/t1202-counters-09-b-checksum.png: Added.
        * platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.png: Added.
        * platform/chromium-win-vista/fast/text/atsui-spacing-features-expected.checksum:
        * platform/chromium-win-vista/fast/text/atsui-spacing-features-expected.png:
        * platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.checksum: Added.
        * platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.png: Added.
        * platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.txt: Added.
        * platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
        * platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
        * platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
        * platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.checksum: Added.
        * platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.png: Added.
        * platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.checksum: Added.
        * platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.png: Added.
        * platform/chromium-win-vista/fast/text/international/plane2-expected.checksum: Added.
        * platform/chromium-win-vista/fast/text/international/plane2-expected.png: Added.
        * platform/chromium-win-vista/fast/text/international/plane2-expected.txt: Added.
        * platform/chromium-win-vista/svg/batik/text/textFeatures-expected.checksum: Removed.
        * platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Removed.
        * platform/chromium-win-vista/svg/batik/text/verticalText-expected.checksum:
        * platform/chromium-win-vista/svg/batik/text/verticalText-expected.png:
        * platform/chromium-win-vista/svg/text/text-intro-05-t-expected.checksum: Added.
        * platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
        * platform/chromium/drt_expectations.txt: Removed expectations of failure, also added more info on remaining Windows failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 19 Sep 2010 22:09:14 +0000 (22:09 +0000)]
2010-09-19  Adam Barth  <abarth@webkit.org>

        Turns out these still fail.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 19 Sep 2010 21:57:36 +0000 (21:57 +0000)]
2010-09-19  Adam Barth  <abarth@webkit.org>

        These tests now pass.  Go team.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Sun, 19 Sep 2010 21:14:13 +0000 (21:14 +0000)]
2010-09-19  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] clipBoundingRect() should return rect relevant to current layer
        https://bugs.webkit.org/show_bug.cgi?id=46059

        r65791 inadvertently changed clipBoundingRect() to always use the GC painter
        without checking the TransparencyLayer stack first.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContextPlatformPrivate::p):
        (WebCore::GraphicsContextPlatformPrivate::clipBoundingRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace WKBundleRangeRef with WKBundleRangeHandleRef.
weinig@apple.com [Sun, 19 Sep 2010 21:10:50 +0000 (21:10 +0000)]
Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054

Reviewed by Anders Carlsson.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 19 Sep 2010 21:08:22 +0000 (21:08 +0000)]
2010-09-19  Adam Barth  <abarth@webkit.org>

        Also update mac-leopard and mac-tiger.
        See https://bugs.webkit.org/show_bug.cgi?id=46042

        * platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
        * platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Patrick Gansterer <paroga@paroga.com>
paroga@webkit.org [Sun, 19 Sep 2010 19:54:56 +0000 (19:54 +0000)]
2010-09-19  Patrick Gansterer  <paroga@paroga.com>

        Unreviewed.

        [WINCE] Buildfix for Gradient after r67801.

        * platform/graphics/Gradient.h:
        * platform/graphics/wince/GradientWinCE.cpp:
        (WebCore::Gradient::getStops):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed buildfix after r67813.
ossy@webkit.org [Sun, 19 Sep 2010 18:25:36 +0000 (18:25 +0000)]
[Qt] Unreviewed buildfix after r67813.

Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054

* DerivedSources.pro: Add WebCore/generated/JSRange.h to WEBCORE_GENERATED_HEADERS_FOR_WEBKIT2

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed buildfix after r67802.
ossy@webkit.org [Sun, 19 Sep 2010 17:47:04 +0000 (17:47 +0000)]
[Qt] Unreviewed buildfix after r67802.

WebKit2: Improve/unify the PageLoadClient interfaces.
https://bugs.webkit.org/show_bug.cgi?id=46043

* UIProcess/API/qt/ClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace WKBundleRangeRef with WKBundleRangeHandleRef.
weinig@apple.com [Sun, 19 Sep 2010 17:40:36 +0000 (17:40 +0000)]
Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054

Reviewed by Anders Carlsson.

The new one acts like WKBundleNodeHandleRef and allows for getting a
wrapper in a specific world for the handle.

WebKit2:

* Shared/APIObject.h:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
* WebProcess/InjectedBundle/API/c/WKBundleBase.h:
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetJavaScriptWrapperForRangeForWorld):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/API/c/WKBundleRange.cpp: Removed.
* WebProcess/InjectedBundle/API/c/WKBundleRange.h: Removed.
* WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp: Added.
(WKBundleRangeHandleGetTypeID):
* WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.h: Added.
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::getOrCreate):
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
* WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp: Added.
(WebKit::domHandleCache):
(WebKit::InjectedBundleRangeHandle::getOrCreate):
(WebKit::InjectedBundleRangeHandle::create):
(WebKit::InjectedBundleRangeHandle::InjectedBundleRangeHandle):
(WebKit::InjectedBundleRangeHandle::~InjectedBundleRangeHandle):
(WebKit::InjectedBundleRangeHandle::coreRange):
* WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h: Added.
(WebKit::InjectedBundleRangeHandle::type):
* WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
(WebKit::InjectedBundlePageEditorClient::shouldBeginEditing):
(WebKit::InjectedBundlePageEditorClient::shouldEndEditing):
(WebKit::InjectedBundlePageEditorClient::shouldInsertNode):
(WebKit::InjectedBundlePageEditorClient::shouldInsertText):
(WebKit::InjectedBundlePageEditorClient::shouldDeleteRange):
(WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange):
(WebKit::InjectedBundlePageEditorClient::shouldApplyStyle):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::jsWrapperForWorld):
* WebProcess/WebPage/WebFrame.h:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:

WebKitTools:

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::propertyValue):
(WTR::propertyValueDouble):
(WTR::propertyValueInt):
(WTR::numericWindowPropertyValue):
(WTR::toStr):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed a typo.
mitz@apple.com [Sun, 19 Sep 2010 17:37:52 +0000 (17:37 +0000)]
Fixed a typo.

Reviewed by Anders Carlsson.

* code-review.js: Changed the label of the OK button from Ok to OK.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Sun, 19 Sep 2010 13:31:36 +0000 (13:31 +0000)]
2010-09-19  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Add is<input type>() functions to WebInputElement
        https://bugs.webkit.org/show_bug.cgi?id=46035

        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::isText): Added. It is used by WebKit/chromium.
2010-09-19  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Add is<input type>() functions to WebInputElement
        https://bugs.webkit.org/show_bug.cgi?id=46035

        We're going to stop exposing HTMLInputElemnt::InputType. So, add
        isFoo() functions in order to remove WebInputElement::InputType.

        * public/WebInputElement.h:
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::isTextField):
        (WebKit::WebInputElement::isText):
        (WebKit::WebInputElement::isPasswordField):
        (WebKit::WebInputElement::isImageButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Sun, 19 Sep 2010 13:30:29 +0000 (13:30 +0000)]
2010-09-19  Kent Tamura  <tkent@chromium.org>

        Unreviewed. Fix WebGL test regressions by r67809.

        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-19 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Sun, 19 Sep 2010 12:55:50 +0000 (12:55 +0000)]
2010-09-19  Kent Tamura  <tkent@chromium.org>

        Reviewed by Adam Barth.

        [DRT/Chromium] Fix a WebSettings handling bug
        https://bugs.webkit.org/show_bug.cgi?id=45945

        * platform/chromium/drt_expectations.txt:
         Remove link-opens-new-window.html, which is fixed by this revision.
2010-09-19  Kent Tamura  <tkent@chromium.org>

        Reviewed by Adam Barth.

        [DRT/Chromium] Fix a WebSettings handling bug
        https://bugs.webkit.org/show_bug.cgi?id=45945

        Before this change, Chromium DRT reset WebSettings for every new
        window. It was wrong.
        If new window is not the first one, we have to apply the same
        settings as the first window.  So, we introduce WebPreference to
        store the current settings, and apply it to new windows. It's same
        as test_shell's behavior.

        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
          Use WebPreferences instead of WebSettings.
        (LayoutTestController::setUserStyleSheetEnabled):
        (LayoutTestController::setUserStyleSheetLocation):
        (LayoutTestController::setAuthorAndUserStylesEnabled):
        (LayoutTestController::setPopupBlockingEnabled):
        (LayoutTestController::disableImageLoading):
        (LayoutTestController::setJavaScriptCanAccessClipboard):
        (LayoutTestController::setXSSAuditorEnabled):
        (LayoutTestController::setAllowUniversalAccessFromFileURLs):
        (LayoutTestController::setAllowFileAccessFromFileURLs):
        (LayoutTestController::overridePreference):
        (LayoutTestController::setEditingBehavior):
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetWebSettings): Use WebPreferences.
        (TestShell::runFileTest): ditto.
        (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell::preferences):
        (TestShell::applyPreferences):
        * DumpRenderTree/chromium/WebPreferences.cpp: Added.
        * DumpRenderTree/chromium/WebPreferences.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Sun, 19 Sep 2010 03:12:05 +0000 (03:12 +0000)]
2010-09-18  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Path: Remove unused member variable
        https://bugs.webkit.org/show_bug.cgi?id=46048

        Path::m_lastMoveToIndex is not used for anything, so remove it.

        * platform/graphics/Path.h:
        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::Path):
        (WebCore::Path::operator=):
        (WebCore::Path::moveTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Patrick Gansterer <paroga@paroga.com>
abarth@webkit.org [Sun, 19 Sep 2010 03:01:51 +0000 (03:01 +0000)]
2010-09-18  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        Use AtomicString insted of String in XMLDocumentParser
        https://bugs.webkit.org/show_bug.cgi?id=45990

        Create AtomicString as early as possible.
        This can avoid unnecessary memcpy of String content.

        * dom/XMLDocumentParser.h:
        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::toAtomicString):
        (WebCore::handleElementNamespaces):
        (WebCore::handleElementAttributes):
        (WebCore::XMLDocumentParser::startElementNs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Prasad Tammana <prasadt@chromium.org>
abarth@webkit.org [Sun, 19 Sep 2010 01:21:13 +0000 (01:21 +0000)]
2010-09-18  Prasad Tammana  <prasadt@chromium.org>

        Reviewed by David Levin.

        update-webkit --chromium spitting out a spurious error
        https://bugs.webkit.org/show_bug.cgi?id=45868

        * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Erik Arvidsson <arv@chromium.org>
abarth@webkit.org [Sun, 19 Sep 2010 01:05:08 +0000 (01:05 +0000)]
2010-09-18  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Nate Chapin.

        [Chromium] fast/dom/dataset-gc.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=45426

        * platform/chromium/test_expectations.txt:
2010-09-18  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Nate Chapin.

        [Chromium] fast/dom/dataset-gc.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=45426

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/custom/V8DOMStringMapCustom.cpp:
        (WebCore::toV8):
        * dom/DOMStringMap.h:
        * dom/DatasetDOMStringMap.h:
        (WebCore::DatasetDOMStringMap::element):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Sun, 19 Sep 2010 00:52:02 +0000 (00:52 +0000)]
2010-09-18  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Oliver Hunt.

        Gradient: Fast-path for the ideal case in sortStopsIfNecessary()
        https://bugs.webkit.org/show_bug.cgi?id=46045

        Avoid calling std::stable_sort for 2-stop gradients that are already in order.

        * platform/graphics/Gradient.cpp:
        (WebCore::Gradient::sortStopsIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Kwang Yul Seo <skyul@company100.net>
abarth@webkit.org [Sun, 19 Sep 2010 00:46:57 +0000 (00:46 +0000)]
2010-09-18  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Andreas Kling.

        [BREWMP] Fix a typo in key code name
        https://bugs.webkit.org/show_bug.cgi?id=46003

        AVK_CLR is the right Brew MP key code name for VK_BACK.

        * platform/brew/PlatformKeyboardEventBrew.cpp:
        (WebCore::windowsKeyCodeForKeyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Improve/unify the PageLoadClient interfaces.
weinig@apple.com [Sun, 19 Sep 2010 00:30:48 +0000 (00:30 +0000)]
WebKit2: Improve/unify the PageLoadClient interfaces.
https://bugs.webkit.org/show_bug.cgi?id=46043

Reviewed by Dan Bernstein.

- Ensure that all the PageLoadClient functions (that are load related)
  have bundle API equivalents (this meant adding didFirstLayoutForFrame
  and didFirstVisuallyNonEmptyLayoutForFrame to the BundlePageLoadClient).
- Add a userData out parameters to all the now paired BundlePageLoadClient
  functions, and a matching userData parameter to the PageLoadClient ones.

* UIProcess/API/C/WKPage.h:
* UIProcess/API/qt/ClientImpl.cpp:
(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didReceiveServerRedirectForProvisionalLoadForFrame):
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didFinishDocumentLoadForFrame):
(qt_wk_didFinishLoadForFrame):
(qt_wk_didFailLoadWithErrorForFrame):
(qt_wk_didReceiveTitleForFrame):
(qt_wk_didFirstLayoutForFrame):
(qt_wk_didFirstVisuallyNonEmptyLayoutForFrame):
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didCommitLoadForFrame):
(WebKit::WebLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::WebLoaderClient::didFinishLoadForFrame):
(WebKit::WebLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didReceiveTitleForFrame):
(WebKit::WebLoaderClient::didFirstLayoutForFrame):
(WebKit::WebLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebLoaderClient::didStartProgress):
(WebKit::WebLoaderClient::didChangeProgress):
(WebKit::WebLoaderClient::didFinishProgress):
(WebKit::WebLoaderClient::didBecomeUnresponsive):
(WebKit::WebLoaderClient::didBecomeResponsive):
(WebKit::WebLoaderClient::processDidExit):
(WebKit::WebLoaderClient::didChangeBackForwardList):
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::didFirstLayoutForFrame):
(WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
* UIProcess/WebPageProxy.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCommitLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveTitleForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCancelClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didChangeLocationWithinPageForFrame):
(WebKit::InjectedBundlePageLoaderClient::didHandleOnloadEventsForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):
(WebKit::WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):

WebKitTools: Improve/unify the PageLoadClient interfaces
https://bugs.webkit.org/show_bug.cgi?id=46043

Reviewed by Dan Bernstein.

* MiniBrowser/mac/BrowserWindowController.m:
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didCommitLoadForFrame):
(didFinishDocumentLoadForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didReceiveTitleForFrame):
(didFirstLayoutForFrame):
(didFirstVisuallyNonEmptyLayoutForFrame):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didCommitLoadForFrame):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveMessageFromInjectedBundle):
(WTR::TestController::didFinishLoadForFrame):
* WebKitTestRunner/TestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Sun, 19 Sep 2010 00:23:33 +0000 (00:23 +0000)]
2010-09-18  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Oliver Hunt.

        Gradient: Pre-reserve space for 2 color stops
        https://bugs.webkit.org/show_bug.cgi?id=46044

        Most gradients have only 2 color stops, pre-reserve space for these in m_stops
        to avoid growing the vector dynamically in the common case.

        * platform/graphics/Gradient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 18 Sep 2010 23:54:30 +0000 (23:54 +0000)]
2010-09-18  Adam Barth  <abarth@webkit.org>

        Also update the snow-leopard result.

        * platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 18 Sep 2010 23:48:50 +0000 (23:48 +0000)]
2010-09-18  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r67792.
        http://trac.webkit.org/changeset/67792
        https://bugs.webkit.org/show_bug.cgi?id=45976

        Broke over a hundred SVG tests.

        * canvas/philip/tests/2d.drawImage.negativeOneDest-expected.txt: Removed.
        * canvas/philip/tests/2d.drawImage.negativeOneDest.html: Removed.
        * canvas/philip/tests/2d.drawImage.negativeOneSource-expected.txt: Removed.
        * canvas/philip/tests/2d.drawImage.negativeOneSource.html: Removed.
2010-09-18  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r67792.
        http://trac.webkit.org/changeset/67792
        https://bugs.webkit.org/show_bug.cgi?id=45976

        Broke over a hundred SVG tests.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::drawImage):
        (WebCore::GraphicsContext::drawImageBuffer):
        * platform/graphics/GraphicsContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 18 Sep 2010 23:28:51 +0000 (23:28 +0000)]
2010-09-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        file-url-mimetypes-2.html fails on my Snow Leopard box
        https://bugs.webkit.org/show_bug.cgi?id=46042

        This line of this test seems to depend on something besides WebKit.  It
        fails on my Snow Leopard box because it reports text/plain instead of
        postscript.  This is blocking me from running a commit-cluster machine
        on my box.

        * platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
        * platform/mac/fast/loader/file-url-mimetypes-2.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Sat, 18 Sep 2010 23:02:45 +0000 (23:02 +0000)]
2010-09-18  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Simon Fraser.

        webkitAnimationEnd event doesn't fire when skipping over final iteration
        https://bugs.webkit.org/show_bug.cgi?id=46010

        Add a test with a short enough animation interval (0.001s) that we
        appear to always skip the second iteration.

        * animations/animation-end-event-short-iterations-expected.txt: Added.
        * animations/animation-end-event-short-iterations.html: Added.
2010-09-18  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Simon Fraser.

        webkitAnimationEnd event doesn't fire when skipping over final iteration
        https://bugs.webkit.org/show_bug.cgi?id=46010

        It's possible for AnimationBase::fireAnimationEventsIfNeeded to decide
        that the animation is ended while we're in the looping state, if the
        animation timer never fires during an iteration. That then fails the
        assert in AnimationBase::updateStateMachine (we don't expect
        AnimationStateInputEndTimerFired while in the looping state). Jump the
        state to AnimationStateEnding, which is more accurate.

        Test: animations/animation-end-event-short-iterations.html

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::fireAnimationEventsIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFirst step in fixing Windows build.
darin@apple.com [Sat, 18 Sep 2010 23:02:41 +0000 (23:02 +0000)]
First step in fixing Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Removed incorrect symbol. The build will probably still fail,
but the failure will tell us what symbol to add.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, fix use of wrong case in name.
kevino@webkit.org [Sat, 18 Sep 2010 22:52:49 +0000 (22:52 +0000)]
[wx] Build fix, fix use of wrong case in name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Sat, 18 Sep 2010 22:48:44 +0000 (22:48 +0000)]
2010-09-18  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Andreas Kling.

        [BREWMP] Wrong key code type in keyIdentifierForBrewKeyCode
        https://bugs.webkit.org/show_bug.cgi?id=46005

        The type of key code in Brew MP is uint16. Take uint16 instead of int16 in keyIdentifierForBrewKeyCode.

        * platform/brew/PlatformKeyboardEventBrew.cpp:
        (WebCore::keyIdentifierForBrewKeyCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Mihai Parparita <mihaip@chromium.org>
abarth@webkit.org [Sat, 18 Sep 2010 22:43:45 +0000 (22:43 +0000)]
2010-09-17  Mihai Parparita  <mihaip@chromium.org>

       Reviewed by James Robinson.

       Remove passing animation tests from Chromium's test_expectations.txt
       https://bugs.webkit.org/show_bug.cgi?id=45996

       Update Chromium test_expectations.txt to remove tests that now pass:

       animations/animation-shorthand-removed.html, animations/
       animation-shorthand.html, and transitions/inherit-other-props.html were
       fixed by http://trac.webkit.org/changeset/67634.

       transforms/2d/transform-value-types.html has not failed in the last
       1,500 runs.

       animations/animation-drt-api.html was most likely fixed by 66641 (it
       hasn't failed in the last 1,500 runs either).

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Matthew Delaney <mdelaney@apple.com>
commit-queue@webkit.org [Sat, 18 Sep 2010 21:47:04 +0000 (21:47 +0000)]
2010-09-18  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Oliver Hunt.

        Canvas drawImage with source or destination widths/heights of -1 renders incorrectly.
        https://bugs.webkit.org/show_bug.cgi?id=45976

        * canvas/philip/tests/2d.drawImage.negativeOneDest-expected.txt: Added.
        * canvas/philip/tests/2d.drawImage.negativeOneDest.html: Added. Tests that using -1
        for the destination width/height renders correctly.
        * canvas/philip/tests/2d.drawImage.negativeOneSource-expected.txt: Added.
        * canvas/philip/tests/2d.drawImage.negativeOneSource.html: Added. Tests that using -1
        for the source width/height renders correctly.
2010-09-18  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Oliver Hunt.

        Canvas drawImage with source or destination widths/heights of -1 renders incorrectly.
        https://bugs.webkit.org/show_bug.cgi?id=45976

        Specifying a -1 width or height for either the source or destination rectangle in drawImage
        get improperly drawn with -1 replaced as the corresponding image width or height. This was because
        the value -1 was being passed around to signal non-specified widths and heights and thus was
        interpreted lower down in the drawImage implementation which disallowed any calls that actually
        wanted to use -1 as the widths or heights. Fixed this by moving the default logic up and not using
        -1 in-band signaling to denote default behavior.

        Tests: canvas/philip/tests/2d.drawImage.negativeOneDest.html
               canvas/philip/tests/2d.drawImage.negativeOneSource.html

        * platform/graphics/GraphicsContext.cpp: Removed -1 in-band signals and replaced cascased calls to have
        the desired replaces for unspecified widths and heights earlier on.
        * platform/graphics/GraphicsContext.h: Removed faulty default value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 18 Sep 2010 21:30:09 +0000 (21:30 +0000)]
2010-09-17  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Adding a shell script I use to run the
        commit-queue. Now that multiple machines run the cq,
        it makes sense to share the script between them.

        * EWSTools/start-commit-queue.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Sat, 18 Sep 2010 21:04:15 +0000 (21:04 +0000)]
2010-09-18  Michael Saboff  <msaboff@apple.com>

        Reviewed by Gavin Barraclough.

        Added code to unroll regular expressions containing ^.
        Alternatives that begin with ^ are tagged during parsing
        and rolled up in containing sub expression structs.
        After parsing, a regular expression flagged as containing
        a ^ (a.k.a. BOL) is processed further in optimizeBOL().
        A copy of the disjunction is made excluding alternatives that
        are rooted with BOL.  The original alternatives are flagged
        to only be executed once.  The copy of the other alternatives are
        added to the original expression.
        In the case that all original alternatives are flagged, there
        won't be any looping alternatives.
        The JIT generator will emit code accordingly, executing the
        original alternatives once and then looping over the
        alternatives that aren't anchored with a BOL (if any).
        https://bugs.webkit.org/show_bug.cgi?id=45787

        * yarr/RegexCompiler.cpp:
        (JSC::Yarr::RegexPatternConstructor::assertionBOL):
        (JSC::Yarr::RegexPatternConstructor::atomParenthesesEnd):
        (JSC::Yarr::RegexPatternConstructor::copyDisjunction):
        (JSC::Yarr::RegexPatternConstructor::copyTerm):
        (JSC::Yarr::RegexPatternConstructor::optimizeBOL):
        (JSC::Yarr::compileRegex):
        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::generateDisjunction):
        * yarr/RegexPattern.h:
        (JSC::Yarr::PatternAlternative::PatternAlternative):
        (JSC::Yarr::PatternAlternative::setOnceThrough):
        (JSC::Yarr::PatternAlternative::onceThrough):
        (JSC::Yarr::PatternDisjunction::PatternDisjunction):
        (JSC::Yarr::RegexPattern::RegexPattern):
        (JSC::Yarr::RegexPattern::reset):
2010-09-18  Michael Saboff  <msaboff@apple.com>

        Reviewed by Gavin Barraclough.

        Added new tests to check for proper handling of ^ in multiline
        regular expressions.  Added as part of
        https://bugs.webkit.org/show_bug.cgi?id=45787

        * fast/js/regexp-bol-with-multiline-expected.txt: Added.
        * fast/js/regexp-bol-with-multiline.html: Added.
        * fast/js/script-tests/regexp-bol-with-multiline.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 18 Sep 2010 20:52:32 +0000 (20:52 +0000)]
2010-09-18  Dimitri Glazkov  <dglazkov@chromium.org>

        Remove duplicate expectations from platform/chromium-win-xp.

        * platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.checksum: Removed.
        * platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.png: Removed.
        * platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.checksum: Removed.
        * platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Patrick Gansterer <paroga@paroga.com>
paroga@webkit.org [Sat, 18 Sep 2010 20:41:03 +0000 (20:41 +0000)]
2010-09-18  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        Rename Wince files to WinCE
        https://bugs.webkit.org/show_bug.cgi?id=37287

        * wtf/unicode/Unicode.h:
        * wtf/unicode/wince/UnicodeWinCE.cpp: Copied from JavaScriptCore/wtf/unicode/wince/UnicodeWince.cpp.
        * wtf/unicode/wince/UnicodeWinCE.h: Copied from JavaScriptCore/wtf/unicode/wince/UnicodeWince.h.
        * wtf/unicode/wince/UnicodeWince.cpp: Removed.
        * wtf/unicode/wince/UnicodeWince.h: Removed.
        * wtf/wince/FastMallocWinCE.h: Copied from JavaScriptCore/wtf/wince/FastMallocWince.h.
        * wtf/wince/FastMallocWince.h: Removed.
2010-09-18  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Enable Platform Strategies on Qt

        [Qt] Turn on PLATFORM_STRATEGIES
        https://bugs.webkit.org/show_bug.cgi?id=45831

        * WebCore.pro: Adding/removing implementation files
        * platform/qt/Language.cpp: Added, WebCore::defaultLanguage() was
        moved from platform/qt/Localizations.cpp
        (WebCore::defaultLanguage): Moved from Localizations.cpp
        * platform/qt/Localizations.cpp: Removed (code is now inside
        WebCoreSupport/WebPlatformStrategies.cpp)
        * plugins/qt/PluginDataQt.cpp: Removed (idem)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Sat, 18 Sep 2010 20:15:52 +0000 (20:15 +0000)]
2010-09-18  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Enable Platform Strategies on Qt

        [Qt] Turn on PLATFORM_STRATEGIES
        https://bugs.webkit.org/show_bug.cgi?id=45831

        * wtf/Platform.h: Enable Platform Strategies when building QtWebkit
2010-09-18  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Enable Platform Strategies on Qt

        [Qt] Turn on PLATFORM_STRATEGIES
        https://bugs.webkit.org/show_bug.cgi?id=45831

        * WebCore.pro: Adding/removing implementation files
        * platform/qt/Language.cpp: Added, WebCore::defaultLanguage() was
        moved from platform/qt/Localizations.cpp
        (WebCore::defaultLanguage): Moved from Localizations.cpp
        * platform/qt/Localizations.cpp: Removed (code is now inside
        WebCoreSupport/WebPlatformStrategies.cpp)
        * plugins/qt/PluginDataQt.cpp: Removed (idem)
2010-09-18  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Enable Platform Strategies on Qt

        [Qt] Turn on PLATFORM_STRATEGIES
        https://bugs.webkit.org/show_bug.cgi?id=45831

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate): Initialize the PlatformStrategy
        singleton.
        * WebCoreSupport/WebPlatformStrategies.cpp: Added, code was moved
        from platform/qt/Localizations.cpp and plugins/qt/PluginDataQt.cpp
        (WebPlatformStrategies::initialize): create the singleton,
        following the same "pattern" used by Mac and Win ports.
        (WebPlatformStrategies::WebPlatformStrategies):
        (WebPlatformStrategies::createPluginStrategy):
        (WebPlatformStrategies::createLocalizationStrategy):
        (WebPlatformStrategies::createVisitedLinkStrategy):
        (WebPlatformStrategies::refreshPlugins):
        (WebPlatformStrategies::getPluginInfo):
        (WebPlatformStrategies::inputElementAltText):
        (WebPlatformStrategies::resetButtonDefaultLabel):
        (WebPlatformStrategies::searchableIndexIntroduction):
        (WebPlatformStrategies::submitButtonDefaultLabel):
        (WebPlatformStrategies::fileButtonChooseFileLabel):
        (WebPlatformStrategies::fileButtonNoFileSelectedLabel):
        (WebPlatformStrategies::contextMenuItemTagOpenLinkInNewWindow):
        (WebPlatformStrategies::contextMenuItemTagDownloadLinkToDisk):
        (WebPlatformStrategies::contextMenuItemTagCopyLinkToClipboard):
        (WebPlatformStrategies::contextMenuItemTagOpenImageInNewWindow):
        (WebPlatformStrategies::contextMenuItemTagDownloadImageToDisk):
        (WebPlatformStrategies::contextMenuItemTagCopyImageToClipboard):
        (WebPlatformStrategies::contextMenuItemTagOpenFrameInNewWindow):
        (WebPlatformStrategies::contextMenuItemTagCopy):
        (WebPlatformStrategies::contextMenuItemTagGoBack):
        (WebPlatformStrategies::contextMenuItemTagGoForward):
        (WebPlatformStrategies::contextMenuItemTagStop):
        (WebPlatformStrategies::contextMenuItemTagReload):
        (WebPlatformStrategies::contextMenuItemTagCut):
        (WebPlatformStrategies::contextMenuItemTagPaste):
        (WebPlatformStrategies::contextMenuItemTagNoGuessesFound):
        (WebPlatformStrategies::contextMenuItemTagIgnoreSpelling):
        (WebPlatformStrategies::contextMenuItemTagLearnSpelling):
        (WebPlatformStrategies::contextMenuItemTagSearchWeb):
        (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):
        (WebPlatformStrategies::contextMenuItemTagOpenLink):
        (WebPlatformStrategies::contextMenuItemTagIgnoreGrammar):
        (WebPlatformStrategies::contextMenuItemTagSpellingMenu):
        (WebPlatformStrategies::contextMenuItemTagShowSpellingPanel):
        (WebPlatformStrategies::contextMenuItemTagCheckSpelling):
        (WebPlatformStrategies::contextMenuItemTagCheckSpellingWhileTyping):
        (WebPlatformStrategies::contextMenuItemTagCheckGrammarWithSpelling):
        (WebPlatformStrategies::contextMenuItemTagFontMenu):
        (WebPlatformStrategies::contextMenuItemTagBold):
        (WebPlatformStrategies::contextMenuItemTagItalic):
        (WebPlatformStrategies::contextMenuItemTagUnderline):
        (WebPlatformStrategies::contextMenuItemTagOutline):
        (WebPlatformStrategies::contextMenuItemTagWritingDirectionMenu):
        (WebPlatformStrategies::contextMenuItemTagTextDirectionMenu):
        (WebPlatformStrategies::contextMenuItemTagDefaultDirection):
        (WebPlatformStrategies::contextMenuItemTagLeftToRight):
        (WebPlatformStrategies::contextMenuItemTagRightToLeft):
        (WebPlatformStrategies::contextMenuItemTagInspectElement):
        (WebPlatformStrategies::searchMenuNoRecentSearchesText):
        (WebPlatformStrategies::searchMenuRecentSearchesText):
        (WebPlatformStrategies::searchMenuClearRecentSearchesText):
        (WebPlatformStrategies::AXWebAreaText):
        (WebPlatformStrategies::AXLinkText):
        (WebPlatformStrategies::AXListMarkerText):
        (WebPlatformStrategies::AXImageMapText):
        (WebPlatformStrategies::AXHeadingText):
        (WebPlatformStrategies::AXDefinitionListTermText):
        (WebPlatformStrategies::AXDefinitionListDefinitionText):
        (WebPlatformStrategies::AXButtonActionVerb):
        (WebPlatformStrategies::AXRadioButtonActionVerb):
        (WebPlatformStrategies::AXTextFieldActionVerb):
        (WebPlatformStrategies::AXCheckedCheckBoxActionVerb):
        (WebPlatformStrategies::AXUncheckedCheckBoxActionVerb):
        (WebPlatformStrategies::AXMenuListActionVerb):
        (WebPlatformStrategies::AXMenuListPopupActionVerb):
        (WebPlatformStrategies::AXLinkActionVerb):
        (WebPlatformStrategies::missingPluginText):
        (WebPlatformStrategies::crashedPluginText):
        (WebPlatformStrategies::multipleFileUploadText):
        (WebPlatformStrategies::unknownFileSizeText):
        (WebPlatformStrategies::imageTitle):
        (WebPlatformStrategies::mediaElementLoadingStateText):
        (WebPlatformStrategies::mediaElementLiveBroadcastStateText):
        (WebPlatformStrategies::localizedMediaControlElementString):
        (WebPlatformStrategies::localizedMediaControlElementHelpText):
        (WebPlatformStrategies::localizedMediaTimeDescription):
        (WebPlatformStrategies::validationMessageValueMissingText):
        (WebPlatformStrategies::validationMessageTypeMismatchText):
        (WebPlatformStrategies::validationMessagePatternMismatchText):
        (WebPlatformStrategies::validationMessageTooLongText):
        (WebPlatformStrategies::validationMessageRangeUnderflowText):
        (WebPlatformStrategies::validationMessageRangeOverflowText):
        (WebPlatformStrategies::validationMessageStepMismatchText):
        (WebPlatformStrategies::isLinkVisited):
        (WebPlatformStrategies::addVisitedLink):
        * WebCoreSupport/WebPlatformStrategies.h: Added, based on Mac and Win
        versions.
2010-09-18  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Enable Platform Strategies on Qt

        [Qt] Turn on PLATFORM_STRATEGIES
        https://bugs.webkit.org/show_bug.cgi?id=45831

        * WebKit2.pro: Added Added WebPlatformStrategies.{cpp,h}

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Mike Lawther <mikelawther@chromium.org>
commit-queue@webkit.org [Sat, 18 Sep 2010 19:33:23 +0000 (19:33 +0000)]
2010-09-18  Mike Lawther  <mikelawther@chromium.org>

        Reviewed by Nate Chapin.

        Remove passing tests from chromium test_expectations
        https://bugs.webkit.org/show_bug.cgi?id=45948

        Removes tests the flakiness dashboard shows as having passed for a couple of weeks

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Sat, 18 Sep 2010 19:21:33 +0000 (19:21 +0000)]
2010-09-18  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Eric Seidel.

        Move Plugin*None.cpp from CMakeLists.txt into CMakeListsEfl.txt
        https://bugs.webkit.org/show_bug.cgi?id=45900

        PluginDataNone.cpp and PluginViewNone.cpp are not used by all port.
        Move them into plaform sepcific build system.

        * CMakeLists.txt:
        * CMakeListsEfl.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 William Siegrist <wsiegrist@apple.com>
wsiegrist@apple.com [Sat, 18 Sep 2010 19:03:54 +0000 (19:03 +0000)]
2010-09-18 William Siegrist <wsiegrist@apple.com>

Increase alternating row contract in result viewer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Sat, 18 Sep 2010 18:16:35 +0000 (18:16 +0000)]
2010-09-18  Daniel Bates  <dbates@rim.com>

        Rubber-stamped by Sam Weinig.

        REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
        https://bugs.webkit.org/show_bug.cgi?id=42863

        Fix some minor, non-visual typos that do not affect the test result.

        * fast/css/preserve-user-specified-zoom-level-on-reload.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Mihai Parparita <mihaip@chromium.org>
krit@webkit.org [Sat, 18 Sep 2010 17:44:48 +0000 (17:44 +0000)]
2010-09-18  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Dirk Schulze.

        fast/css/preserve-user-specified-zoom-level-on-reload.html does not clean up after itself
        https://bugs.webkit.org/show_bug.cgi?id=46040

        Delete the sessionStorage property that this test adds once it's complete.
        Otherwise it fails when run with --iterations=2 and also causes a diff in
        in fast/dom/prototype-inheritance-2.html (which runs after it).

        * fast/css/preserve-user-specified-zoom-level-on-reload.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Sat, 18 Sep 2010 16:37:34 +0000 (16:37 +0000)]
2010-09-18  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] V8 port: Add FrameLoaderClientQt::allowScriptExtension()
        https://bugs.webkit.org/show_bug.cgi?id=46034

        r67749 added FrameLoaderClient::allowScriptExtension() (V8-specific)
        Add a stub implementation that simply returns false for now.

        * WebCoreSupport/FrameLoaderClientQt.h:
        (WebCore::FrameLoaderClientQt::allowScriptExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Sat, 18 Sep 2010 15:23:47 +0000 (15:23 +0000)]
2010-09-18  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Don't copy clip path to TransparencyLayer
        https://bugs.webkit.org/show_bug.cgi?id=45965

        We don't need to copy the GC's clip path to the TransparencyLayer since it will
        clip anyway when ending the layer.

        * platform/graphics/qt/TransparencyLayer.h:
        (WebCore::TransparencyLayer::TransparencyLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Patrick Gansterer <paroga@paroga.com>
paroga@webkit.org [Sat, 18 Sep 2010 13:55:03 +0000 (13:55 +0000)]
2010-09-18  Patrick Gansterer  <paroga@paroga.com>

        Unreviewed.

        [WINCE] Buildfix for FrameWince.cpp after r51353, r67762 and r67771.

        * page/wince/FrameWince.cpp:
        (WebCore::computePageRectsForFrame):
        (WebCore::imageFromSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-18 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Sat, 18 Sep 2010 12:19:09 +0000 (12:19 +0000)]
2010-09-18  Kent Tamura  <tkent@chromium.org>

        Unreviewed, a trivial change.

        Run sort-Xcode-project-file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r67762): Over 160 layout tests failing due to incorrect zoom factors...
mitz@apple.com [Sat, 18 Sep 2010 10:04:02 +0000 (10:04 +0000)]
REGRESSION (r67762): Over 160 layout tests failing due to incorrect zoom factors in subframes
https://bugs.webkit.org/show_bug.cgi?id=46031

Reviewed by Eric Seidel.

* page/Frame.cpp:
(WebCore::parentPageZoomFactor): Return the zoom factor of the parent frame.
(WebCore::parentTextZoomFactor): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed a way to load data (as plain text) in a WKPage
weinig@apple.com [Sat, 18 Sep 2010 06:16:25 +0000 (06:16 +0000)]
Need a way to load data (as plain text) in a WKPage
<rdar://problem/8424239>

Reviewed by Jon Honeycutt.

WebCore:

* WebCore.exp.in:

WebKit2:

* Shared/CoreIPCSupport/WebPageMessageKinds.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageLoadHTMLString):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadHTMLString):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadHTMLString):
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace all uses of WTF::String and WTF::AtomicString with
weinig@apple.com [Sat, 18 Sep 2010 05:34:21 +0000 (05:34 +0000)]
Replace all uses of WTF::String and WTF::AtomicString with
String and AtomicString.

Rubber-stamped by Anders Carlsson.

* Platform/Module.h:
* Shared/CommandLine.h:
(WebKit::CommandLine::operator[]):
* Shared/WebCoreArgumentCoders.h:
* Shared/WebEvent.h:
(WebKit::WebKeyboardEvent::WebKeyboardEvent):
(WebKit::WebKeyboardEvent::text):
(WebKit::WebKeyboardEvent::unmodifiedText):
(WebKit::WebKeyboardEvent::keyIdentifier):
(WebKit::WebKeyboardEvent::decode):
* Shared/WebNavigationDataStore.h:
* Shared/WebPreferencesStore.h:
* Shared/WebString.h:
(WebKit::WebString::create):
(WebKit::WebString::string):
(WebKit::WebString::WebString):
* Shared/WebURL.h:
(WebKit::WebURL::create):
(WebKit::WebURL::string):
(WebKit::WebURL::WebURL):
* UIProcess/API/C/WKAPICast.h:
(WebKit::toRef):
(WebKit::toURLRef):
(WebKit::toCopiedRef):
(WebKit::toCopiedURLRef):
(WebKit::toWTFString):
* UIProcess/API/C/WKContext.cpp:
(WKContextCreate):
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::nsStringFromWebCoreString):
* UIProcess/PageClient.h:
* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::setAdditionalPluginsDirectories):
* UIProcess/Plugins/PluginInfoStore.h:
* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::getMIMETypeForExtension):
* UIProcess/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::setOriginalURL):
(WebKit::WebBackForwardListItem::originalURL):
(WebKit::WebBackForwardListItem::setURL):
(WebKit::WebBackForwardListItem::url):
(WebKit::WebBackForwardListItem::setTitle):
(WebKit::WebBackForwardListItem::title):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::setAdditionalPluginsDirectory):
* UIProcess/WebContext.h:
(WebKit::WebContext::injectedBundlePath):
* UIProcess/WebContextInjectedBundleClient.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didReceiveTitle):
* UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):
* UIProcess/WebHistoryClient.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didReceiveTitleForFrame):
* UIProcess/WebLoaderClient.h:
* UIProcess/WebNavigationData.h:
(WebKit::WebNavigationData::title):
(WebKit::WebNavigationData::url):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::pageTitle):
(WebKit::WebPageProxy::toolTip):
(WebKit::WebPageProxy::urlAtProcessExit):
* UIProcess/WebPolicyClient.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginHostConnection):
* UIProcess/WebProcessProxy.h:
* UIProcess/WebUIClient.h:
* WebProcess/InjectedBundle/InjectedBundle.h:
(WebKit::InjectedBundle::create):
(WebKit::InjectedBundle::setSandboxToken):
* WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
* WebProcess/Plugins/NPRuntimeObjectMap.h:
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/NetscapePluginModule.h:
* WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
(WebKit::NetscapePluginStream::start):
* WebProcess/Plugins/Netscape/NetscapePluginStream.h:
* WebProcess/Plugins/Plugin.h:
* WebProcess/Plugins/PluginController.h:
* WebProcess/Plugins/PluginView.h:
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/WebContextMenuClient.h:
* WebProcess/WebCoreSupport/WebDragClient.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::showCorrectionPanel):
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebCoreSupport/WebInspectorClient.h:
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
* WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:
(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):
* WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
* WebProcess/WebPage/WebFrame.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::registerURLSchemeAsEmptyDocument):
* WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=46027, image on gamespot.com paginates withou...
hyatt@apple.com [Sat, 18 Sep 2010 04:09:23 +0000 (04:09 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46027, image on gamespot.com paginates without bringing its enclosing border along.

Reviewed by Sam Weinig.

Make sure that unsplittable objects like replaced elements propagate their pagination strut outward to the parent block
when appropriate.  An image on a line did this, but a block-level image did not.

Added fast/multicol/image-inside-nested-blocks-with-border.html

WebCore:

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChild):

LayoutTests:

* fast/multicol/image-inside-nested-blocks-with-border-expected.txt: Added.
* fast/multicol/image-inside-nested-blocks-with-border.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 18 Sep 2010 03:38:02 +0000 (03:38 +0000)]
2010-09-17  Dimitri Glazkov  <dglazkov@chromium.org>

        Remove passing tests from expectations.

        * platform/chromium/drt_expectations.txt: Removed tests that are now
            consistently passing on Chromium Windows DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 18 Sep 2010 02:59:25 +0000 (02:59 +0000)]
2010-09-17  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        Move calls from frameView->pageZoomFactor() to frame->pageZoomFactor().

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleTouchEvent): Removed a helper function,
            added direct calls to frame->pageZoomFactor().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination...
hyatt@apple.com [Sat, 18 Sep 2010 02:13:48 +0000 (02:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.

Reviewed by Simon Fraser.

WebCore:

Make printing store the page height in the RenderView and push that into the layout state to
use the new pagination model.  The old pagination model is retained because it is still used
for embedded WebViews.

* page/FrameView.cpp:
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
(WebCore::FrameView::forceLayout):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::adjustPageHeight):
* page/FrameView.h:
* page/PrintContext.cpp:
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcHeight):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::paintReplaced):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::paint):
(WebCore::RenderView::setBestTruncatedAt):
* rendering/RenderView.h:
(WebCore::RenderView::popLayoutState):
(WebCore::RenderView::pageHeight):
(WebCore::RenderView::setPageHeight):
(WebCore::RenderView::bestTruncatedAt):
(WebCore::RenderView::truncatedAt):
(WebCore::RenderView::setTruncatedAt):
(WebCore::RenderView::printRect):
(WebCore::RenderView::setPrintRect):
(WebCore::RenderView::pushLayoutState):
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
(WebCore::LayoutStateMaintainer::pop):

WebKit/mac:

Make printing store the page height in the RenderView and push that into the layout state to
use the new pagination model.  The old pagination model is retained because it is still used
for embedded WebViews.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):

LayoutTests:

Remove the overflow test, since the new model treats overflow:auto/scroll as unsplittable.

* printing/page-break-always-for-overflow-expected.txt: Removed.
* printing/page-break-always-for-overflow.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCanvas sizing ignores intrinsic size
mitz@apple.com [Sat, 18 Sep 2010 02:09:08 +0000 (02:09 +0000)]
Canvas sizing ignores intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=46024

Reviewed by Simon Fraser.

WebCore:

Updated fast/replaced/table-percent-height.html

* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject): If this is used as a proxy
for <video>, behave like it has an intrinsic size (e.g. preserve aspect ratio when
width is auto and height is specified).
* rendering/RenderImage.cpp:
(WebCore::RenderImage::calcAspectRatioWidth): Changed to explicitly invoke
RenderBox::calcReplacedHeight(), now that RenderReplaced has its own implementation
which we don’t want.
(WebCore::RenderImage::calcAspectRatioHeight): Similarly with calcReplacedWidth().
* rendering/RenderImage.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::RenderReplaced): Initialize m_hasIntrinsicSize.
(WebCore::lengthIsSpecified): Added this helper function, based on RenderImage’s
is{Width,Height}Specified().
(WebCore::RenderReplaced::calcReplacedWidth): Moved from RenderVideo all the way
up here so other replaced objects could use this logic.
(WebCore::RenderReplaced::calcReplacedHeight): Ditto.
(WebCore::RenderReplaced::calcAspectRatioWidth): Ditto.
(WebCore::RenderReplaced::calcAspectRatioHeight): Ditto.
(WebCore::RenderReplaced::calcPrefWidths): Replaced with the RenderImage version
of the logic.
(WebCore::RenderReplaced::setIntrinsicSize): Added an assertion.
* rendering/RenderReplaced.h:
(WebCore::RenderReplaced::minimumReplacedHeight): Promoted from private to protected
to allow RenderVideo to call through.
(WebCore::RenderReplaced::setHasIntrinsicSize): Added this setter.
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updateIntrinsicSize): Factor zoom into the intrinsic size,
the way other RenderReplaced objects do.
(WebCore::RenderVideo::calcReplacedWidth): Invoke the RenderReplaced implementation,
which matches what used to be here, skipping over the RenderImage implementation.
(WebCore::RenderVideo::calcReplacedHeight): Ditto.
(WebCore::RenderVideo::minimumReplacedHeight): Ditto.
* rendering/RenderVideo.h:

LayoutTests:

* fast/replaced/table-percent-height-expected.txt: Updated.
* fast/replaced/table-percent-height.html: Changed to expect canvas to maintain
its intrinsic ratio.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Sat, 18 Sep 2010 01:06:59 +0000 (01:06 +0000)]
2010-09-17  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Imprecise tracking of variable capture leads to overly pessimistic creation of activations
        https://bugs.webkit.org/show_bug.cgi?id=46020

        The old logic for track free and captured variables would cause us
        to decide we needed an activation in every function along the scope
        chain between a variable capture and its declaration.  We now track
        captured variables precisely which requires a bit of additional work

        The most substantial change is that the parsing routine needs to
        be passed the list of function parameters when reparsing a function
        as when reparsing we don't parse the function declaration itself only
        its body.

        * JavaScriptCore.exp:
        * parser/JSParser.cpp:
        (JSC::JSParser::Scope::Scope):
        (JSC::JSParser::Scope::needsFullActivation):
           We need to distinguish between use of a feature that requires
           an activation and eval so we now get this additional flag.
        (JSC::JSParser::Scope::collectFreeVariables):
        (JSC::JSParser::Scope::getCapturedVariables):
           We can't simply return the list of "capturedVariables" now as
           is insufficiently precise, so we compute them instead.
        (JSC::JSParser::popScope):
        (JSC::jsParse):
        (JSC::JSParser::JSParser):
        (JSC::JSParser::parseProgram):
        (JSC::JSParser::parseWithStatement):
        (JSC::JSParser::parseTryStatement):
        (JSC::JSParser::parseFunctionInfo):
        (JSC::JSParser::parseFunctionDeclaration):
        (JSC::JSParser::parseProperty):
        (JSC::JSParser::parseMemberExpression):
        * parser/JSParser.h:
        * parser/Parser.cpp:
        (JSC::Parser::parse):
        * parser/Parser.h:
        (JSC::Parser::parse):
        * runtime/Executable.cpp:
        (JSC::EvalExecutable::compileInternal):
        (JSC::ProgramExecutable::checkSyntax):
        (JSC::ProgramExecutable::compileInternal):
        (JSC::FunctionExecutable::compileForCallInternal):
        (JSC::FunctionExecutable::compileForConstructInternal):
        (JSC::FunctionExecutable::reparseExceptionInfo):
        (JSC::EvalExecutable::reparseExceptionInfo):
        (JSC::FunctionExecutable::fromGlobalCode):
           Pass function parameters (if available) to the parser.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
bweinstein@apple.com [Sat, 18 Sep 2010 01:01:50 +0000 (01:01 +0000)]
The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
slightly harder to read, so this reverts the previous background colors for various
states, making it easier to read.

Reviewed by Jon Honeycutt.

* BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(.success):
(.failure):
(.warnings):
(.exception):
(.start,.running,td.building):
(.offline,td.offline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for platforms that compile Touch.
darin@apple.com [Sat, 18 Sep 2010 01:00:10 +0000 (01:00 +0000)]
Build fix for platforms that compile Touch.

* dom/Touch.cpp:
(WebCore::contentsX):
(WebCore::contentsY):
Get zoom factor from Frame rather than FrameView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 18 Sep 2010 00:57:32 +0000 (00:57 +0000)]
2010-09-17  Adam Barth  <abarth@webkit.org>

        Remove Leopard specific expected results because these now match Snow
        Leopard.

        https://bugs.webkit.org/show_bug.cgi?id=38402

        * platform/mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
        * platform/mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Removed.
        * platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
        * platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
        * platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd IsFloatingPoint and IsArithmetic type traits
andersca@apple.com [Sat, 18 Sep 2010 00:40:46 +0000 (00:40 +0000)]
Add IsFloatingPoint and IsArithmetic type traits
https://bugs.webkit.org/show_bug.cgi?id=46018

Reviewed by Sam Weinig.

* wtf/TypeTraits.h:
* wtf/TypeTraits.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Sat, 18 Sep 2010 00:38:14 +0000 (00:38 +0000)]
2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r67692.
        http://trac.webkit.org/changeset/67692
        https://bugs.webkit.org/show_bug.cgi?id=46011

        broke layout test dashboard (Requested by johnny_g on
        #webkit).

        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Windows and Qt builds.
weinig@apple.com [Sat, 18 Sep 2010 00:34:04 +0000 (00:34 +0000)]
Fix Windows and Qt builds.

* Shared/qt/PlatformCertificateInfo.h:
(WebKit::PlatformCertificateInfo::decode):
* Shared/win/PlatformCertificateInfo.h:
(WebKit::PlatformCertificateInfo::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 18 Sep 2010 00:32:24 +0000 (00:32 +0000)]
2010-09-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
        https://bugs.webkit.org/show_bug.cgi?id=42863

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::createPlugin):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setZoomLevel):
        Call functions on Frame instead of FrameView.
2010-09-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
        https://bugs.webkit.org/show_bug.cgi?id=42863

        * Api/qwebframe.cpp:
        (QWebFrame::setTextSizeMultiplier):
        (QWebFrame::textSizeMultiplier):
        (QWebFrame::setZoomFactor):
        (QWebFrame::zoomFactor):
        Call functions on Frame instead of FrameView.
2010-09-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
        https://bugs.webkit.org/show_bug.cgi?id=42863

        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_zoom_level):
        (webkit_web_view_apply_zoom_level):
        (webkit_web_view_set_full_content_zoom):
        Call functions on Frame instead of FrameView.
2010-09-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
        https://bugs.webkit.org/show_bug.cgi?id=42863

        * WebView.cpp:
        (WebView::setZoomMultiplier):
        Call functions on Frame instead of FrameView.
2010-09-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
        https://bugs.webkit.org/show_bug.cgi?id=42863

        * WebFrame.cpp:
        (wxWebFrame::IncreaseTextSize):
        (wxWebFrame::DecreaseTextSize):
        (wxWebFrame::ResetTextSize):
        Call functions on Frame instead of FrameView.
2010-09-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
        https://bugs.webkit.org/show_bug.cgi?id=42863

        * WebView/WebView.mm:
        (-[WebView _setZoomMultiplier:isTextOnly:]):
        Call functions on Frame instead of FrameView.
2010-09-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
        https://bugs.webkit.org/show_bug.cgi?id=42863

        * ewk/ewk_frame.cpp:
        (ewk_frame_zoom_get):
        (ewk_frame_zoom_set):
        (ewk_frame_zoom_text_only_set):
        Call functions on Frame instead of FrameView.
2010-09-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
        https://bugs.webkit.org/show_bug.cgi?id=42863

        Moved zoom level back from FrameView to Frame.
        I had forgotten that FrameView's lifetime is much shorter than
        Frame's, and until that is fixed it's best to leave this on Frame.

        * WebCore.exp.in: Updated.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::styleForDocument):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
        * dom/Document.cpp:
        (WebCore::Document::nodesFromRect):
        (WebCore::Document::elementFromPoint):
        (WebCore::Document::caretRangeFromPoint):
        * dom/MouseRelatedEvent.cpp:
        (WebCore::contentsX):
        (WebCore::contentsY):
        (WebCore::pageZoomFactor):
        * dom/Node.cpp:
        (WebCore::Node::dispatchMouseEvent):
        (WebCore::Node::dispatchWheelEvent):
        * html/HTMLBodyElement.cpp:
        (WebCore::adjustForZoom):
        (WebCore::HTMLBodyElement::scrollLeft):
        (WebCore::HTMLBodyElement::setScrollLeft):
        (WebCore::HTMLBodyElement::scrollTop):
        (WebCore::HTMLBodyElement::setScrollTop):
        (WebCore::HTMLBodyElement::scrollHeight):
        (WebCore::HTMLBodyElement::scrollWidth):
        * html/ImageDocument.cpp:
        (WebCore::pageZoomFactor):
        (WebCore::ImageDocument::scale):
        (WebCore::ImageDocument::imageFitsInWindow):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::innerHeight):
        (WebCore::DOMWindow::innerWidth):
        (WebCore::DOMWindow::scrollX):
        (WebCore::DOMWindow::scrollY):
        (WebCore::DOMWindow::scrollTo):
        * page/DragController.cpp:
        (WebCore::elementUnderMouse):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::zoomFactor):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::currentScale):
        (WebCore::SVGSVGElement::setCurrentScale):
        Get zoom factor from Frame rather than FrameView.

        * page/Frame.cpp:
        (WebCore::parentPageZoomFactor): Moved back here from FrameView.
        (WebCore::parentTextZoomFactor): Ditto.
        (WebCore::Frame::Frame): Ditto.
        (WebCore::Frame::setPageZoomFactor): Ditto.
        (WebCore::Frame::setTextZoomFactor): Ditto.
        (WebCore::Frame::setPageAndTextZoomFactors): Ditto.

        * page/Frame.h: Moved functions and data for zooming back here
        from FrameView.

        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView):
        * page/FrameView.h:
        Removed code from here.
2010-09-17  Daniel Bates  <dbates@rim.com>

        Reviewed by Darin Adler.

        REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
        https://bugs.webkit.org/show_bug.cgi?id=42863

        * fast/css/preserve-user-specified-zoom-level-on-reload.html: Added.
        * platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
        * platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
        * platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
2010-09-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
        https://bugs.webkit.org/show_bug.cgi?id=42863

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::textZoomFactor):
        (WebKit::WebPage::setTextZoomFactor):
        (WebKit::WebPage::pageZoomFactor):
        (WebKit::WebPage::setPageZoomFactor):
        (WebKit::WebPage::setPageAndTextZoomFactors):
        Call functions on Frame instead of FrameView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoResize corner jiggles when resizing slowly in WebKit2
weinig@apple.com [Sat, 18 Sep 2010 00:23:19 +0000 (00:23 +0000)]
Resize corner jiggles when resizing slowly in WebKit2
<rdar://problem/7897425>
https://bugs.webkit.org/show_bug.cgi?id=45601

Reviewed by Anders Carlsson.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowResizerRect):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowResizerRect):
* WebProcess/WebPage/WebPage.h:
Move resize corner logic to WebPage and use the FrameView's size instead of the WebPages
stored size, which doesn't get updated at the right time. This is in line with all other
scrollbar metrics which are in terms of the FrameView's size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake certificate data available to the WKFrameRef after it is committed
weinig@apple.com [Sat, 18 Sep 2010 00:20:23 +0000 (00:20 +0000)]
Make certificate data available to the WKFrameRef after it is committed
Part of <rdar://problem/8350189>
https://bugs.webkit.org/show_bug.cgi?id=45998

Reviewed by Anders Carlsson.

* Shared/APIObject.h:
Add new type.

* Shared/WebCertificateInfo.h: Added.
(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::platformCertificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):
(WebKit::WebCertificateInfo::type):
Add API type for vending.

* Shared/mac/PlatformCertificateInfo.h: Added.
(WebKit::PlatformCertificateInfo::peerCertificates):
* Shared/mac/PlatformCertificateInfo.mm: Added.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
(WebKit::PlatformCertificateInfo::dump):
* Shared/qt/PlatformCertificateInfo.h: Added.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
* Shared/win/PlatformCertificateInfo.h: Added.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
Add platform specific holder for certificate data and encode/decode functions
to send it over the wire. Right now, this only implemented for the mac.

* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKBase.h:
* UIProcess/API/C/WKCertificateInfo.cpp: Added.
(WKCertificateInfoGetTypeID):
* UIProcess/API/C/WKCertificateInfo.h: Added.
Add wrapper for WebCertificateInfo.

* UIProcess/API/C/WKFrame.cpp:
(WKFrameGetCertificateInfo):
* UIProcess/API/C/WKFrame.h:
Add getter for a WKCertificateInfo.

* UIProcess/API/C/mac/WKCertificateInfoMac.h: Added.
* UIProcess/API/C/mac/WKCertificateInfoMac.mm: Added.
(WKCertificateInfoGetPeerCertificates):
Add mac specific getters for the platform specific certificate
data.

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::setCertificateInfo):
* UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::certificateInfo):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didCommitLoadForFrame):
* UIProcess/WebPageProxy.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
Pipe the certificate info through to the WebFrameProxy on
commit.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Tony Chang <tony@chromium.org>
tony@chromium.org [Sat, 18 Sep 2010 00:09:35 +0000 (00:09 +0000)]
2010-09-17  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] 16 more chromium linux baselines (scrollbars change)
        https://bugs.webkit.org/show_bug.cgi?id=46009

        * platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug650-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug650-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:
        * platform/chromium-linux/tables/mozilla/core/captions-expected.checksum:
        * platform/chromium-linux/tables/mozilla/core/captions-expected.png:
        * platform/chromium-linux/tables/mozilla/core/cell_heights-expected.checksum:
        * platform/chromium-linux/tables/mozilla/core/cell_heights-expected.png:
        * platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
        * platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
        * platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
        * platform/chromium-linux/tables/mozilla/other/nestedTables-expected.checksum:
        * platform/chromium-linux/tables/mozilla/other/nestedTables-expected.png:
        * platform/chromium-linux/tables/mozilla/other/test3-expected.checksum:
        * platform/chromium-linux/tables/mozilla/other/test3-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Matthew Delaney <mdelaney@apple.com>
commit-queue@webkit.org [Fri, 17 Sep 2010 23:23:17 +0000 (23:23 +0000)]
2010-09-17  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Reduce minimum DOMTimer interval
        https://bugs.webkit.org/show_bug.cgi?id=45362

        Reduced the minimum allowed DOMTimer interval to 4ms. This has us matching Chrome,
        which hasn't had any problem with 4ms in the past 2 years, as well as increasing our
        performance on perf tests that have tight frequent loops such as canvas "animation"
        performance tests.

        No new tests added. Can't reliably instrument a test in javascript to verify that
        the minimum clamped interval time is in fact 4ms.

        * WebCore.exp.in:
        * page/DOMTimer.cpp: Removed old comments.
        * page/DOMTimer.h: Removed old comments.
        * page/Settings.cpp: Exposted new method to set minimum DOMTimer interval.
        * page/Settings.h:
2010-09-17  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Reduce minimum DOMTimer interval
        https://bugs.webkit.org/show_bug.cgi?id=45362

        * WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.
2010-09-17  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Reduce minimum DOMTimer interval
        https://bugs.webkit.org/show_bug.cgi?id=45362

        * WebView.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
2010-09-17  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Reduce minimum DOMTimer interval
        https://bugs.webkit.org/show_bug.cgi?id=45362

        * WebProcess/WebPage/WebPage.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Kenneth Russell <kbr@google.com>
kbr@google.com [Fri, 17 Sep 2010 23:12:35 +0000 (23:12 +0000)]
2010-09-17  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Roll forward Chromium DEPS to pick up Mesa DRT changes
        https://bugs.webkit.org/show_bug.cgi?id=46006

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
mrowe@apple.com [Fri, 17 Sep 2010 22:50:20 +0000 (22:50 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCoreIPC argument coder improvements
andersca@apple.com [Fri, 17 Sep 2010 22:48:42 +0000 (22:48 +0000)]
CoreIPC argument coder improvements
https://bugs.webkit.org/show_bug.cgi?id=45999

Reviewed by Sam Weinig.

* Platform/CoreIPC/ArgumentCoders.h:
Add explicit specialization for a vector of bytes.

* Platform/CoreIPC/Arguments.h:
(CoreIPC::Arguments1::decode):
(CoreIPC::Arguments2::decode):
(CoreIPC::Arguments3::decode):
(CoreIPC::Arguments4::decode):
(CoreIPC::Arguments5::decode):
(CoreIPC::Arguments6::decode):
Use the injected class name for less typing.

(CoreIPC::Arguments7::Arguments7):
(CoreIPC::Arguments7::encode):
(CoreIPC::Arguments7::decode):
(CoreIPC::In):
(CoreIPC::Out):
Add Arguments7 class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 17 Sep 2010 22:43:42 +0000 (22:43 +0000)]
2010-09-17  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] rebaseline tests that are only scrollbar differences on Linux
        https://bugs.webkit.org/show_bug.cgi?id=46000

        * platform/chromium-linux/css1/basic/containment-expected.checksum:
        * platform/chromium-linux/css1/basic/containment-expected.png:
        * platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
        * platform/chromium-linux/css1/box_properties/padding_right-expected.png:
        * platform/chromium-linux/css1/font_properties/font_size-expected.checksum:
        * platform/chromium-linux/css1/font_properties/font_size-expected.png:
        * platform/chromium-linux/fast/block/float/nested-clearance-expected.checksum:
        * platform/chromium-linux/fast/block/float/nested-clearance-expected.png:
        * platform/chromium-linux/fast/block/positioning/051-expected.checksum:
        * platform/chromium-linux/fast/block/positioning/051-expected.png:
        * platform/chromium-linux/fast/block/positioning/055-expected.checksum:
        * platform/chromium-linux/fast/block/positioning/055-expected.png:
        * platform/chromium-linux/fast/forms/select-change-listbox-size-expected.checksum:
        * platform/chromium-linux/fast/forms/select-change-listbox-size-expected.png:
        * platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.checksum:
        * platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.png:
        * platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.checksum:
        * platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.png:
        * platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.checksum:
        * platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.png:
        * platform/chromium-linux/http/tests/navigation/error404-frames-expected.checksum:
        * platform/chromium-linux/http/tests/navigation/error404-frames-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Kenneth Russell <kbr@google.com>
kbr@google.com [Fri, 17 Sep 2010 22:36:16 +0000 (22:36 +0000)]
2010-09-17  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        [chromium] Add mesa as DumpRenderTree dependency
        https://bugs.webkit.org/show_bug.cgi?id=46001

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Marc-Antoine Ruel <maruel@chromium.org>
commit-queue@webkit.org [Fri, 17 Sep 2010 22:23:22 +0000 (22:23 +0000)]
2010-09-17  Marc-Antoine Ruel  <maruel@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Split webcore_platform off webcore_remaining

        Further reduce webcore_remaining size by moving platform/ code in its
        own static libary.
        https://bugs.webkit.org/show_bug.cgi?id=45915

        * WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Sergio Villar Senin <svillar@igalia.com>
commit-queue@webkit.org [Fri, 17 Sep 2010 21:59:09 +0000 (21:59 +0000)]
2010-09-17  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        http/tests/security/xss-DENIED-mime-type-execute-as-html.html fails
        https://bugs.webkit.org/show_bug.cgi?id=37540

        * platform/gtk/Skipped: test works fine after the fix for
        https://bugs.webkit.org/show_bug.cgi?id=45377

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-13 Matt Perry <mpcomplete@chromium.org>
mpcomplete@chromium.org [Fri, 17 Sep 2010 21:57:37 +0000 (21:57 +0000)]
2010-09-13  Matt Perry  <mpcomplete@chromium.org>

        Reviewed by Darin Fisher.

        Have V8DOMWindowShell ask the embedder whether to run a V8 extension
        in a particular script context.
        https://bugs.webkit.org/show_bug.cgi?id=45721

        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::createNewContext):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::registeredExtensionWithV8):
        (WebCore::V8Proxy::registerExtension):
        * bindings/v8/V8Proxy.h:
        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::allowScriptExtension):
        * loader/FrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Andy Estes <aestes@apple.com>
aestes@apple.com [Fri, 17 Sep 2010 21:50:23 +0000 (21:50 +0000)]
2010-09-17  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/8440903> WK2: REGRESSION (r66156): Web sites using
        AppleConnect fail to log in: "HTTP Status 404 - /ssowebapp/scriptFrame"
        https://bugs.webkit.org/show_bug.cgi?id=45960

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Fri, 17 Sep 2010 21:47:00 +0000 (21:47 +0000)]
2010-09-17  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Dimitri Glazkov.

        http/tests/navigation/post-goback1.html should not be a pixel test
        https://bugs.webkit.org/show_bug.cgi?id=45834

        Convert post-goback1.html to be a simpler dumpAsText test. It can use
        the form-target.pl that was added r67466 with some small modifications.

        To be extra safe, clear the back forward list for all the tests that
        were converted to use dumpAsText.

        * http/tests/navigation/post-basic.html:
        * http/tests/navigation/post-frames.html:
        * http/tests/navigation/post-goback1-expected.txt: Added.
        * http/tests/navigation/post-goback1.html:
        * http/tests/navigation/resources/form-target.pl:
        * http/tests/navigation/resources/go-back.html: Added.
        * platform/chromium-linux/http/tests/navigation/post-goback1-expected.checksum: Removed.
        * platform/chromium-linux/http/tests/navigation/post-goback1-expected.png: Removed.
        * platform/chromium-win/http/tests/navigation/post-goback1-expected.checksum: Removed.
        * platform/chromium-win/http/tests/navigation/post-goback1-expected.png: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/mac/http/tests/navigation/post-goback1-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/post-goback1-expected.png: Removed.
        * platform/mac/http/tests/navigation/post-goback1-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r66711): Plug-in replacement text is never shown
andersca@apple.com [Fri, 17 Sep 2010 21:29:27 +0000 (21:29 +0000)]
REGRESSION (r66711): Plug-in replacement text is never shown
https://bugs.webkit.org/show_bug.cgi?id=45997
<rdar://problem/8446766>

Reviewed by Sam Weinig.

Don't return when the plug-in has replacement text.

* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintReplaced):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 17 Sep 2010 21:27:14 +0000 (21:27 +0000)]
2010-09-17  Eric Carlson  <eric.carlson@apple.com>

        Rubber-stamped by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=45983

        * platform/win/Skipped: Skip media-can-play-mpeg4-video.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 17 Sep 2010 20:42:25 +0000 (20:42 +0000)]
2010-09-17  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Unskip the canvas philip suite
        https://bugs.webkit.org/show_bug.cgi?id=45991

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed, tweaked, and landed by Anders Carlsson.
andersca@apple.com [Fri, 17 Sep 2010 20:27:44 +0000 (20:27 +0000)]
Reviewed, tweaked, and landed by Anders Carlsson.

Patch by Sam Weinig <sam@webkit.org> on 2010-09-17
Add WKCopyNSURLResponsePeerCertificates.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake WebNumbers immutable matching CF.
weinig@apple.com [Fri, 17 Sep 2010 20:11:26 +0000 (20:11 +0000)]
Make WebNumbers immutable matching CF.

Reviewed by Anders Carlsson.

* Shared/WebNumber.h:
(WebKit::WebNumber::value):
(WebKit::WebNumber::WebNumber):
* UIProcess/API/C/WKNumber.cpp:
(WKUInt64GetValue):
* UIProcess/API/C/WKNumber.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unimplemented destructor declaration to fix Chromium build.
levin@chromium.org [Fri, 17 Sep 2010 20:04:47 +0000 (20:04 +0000)]
Remove unimplemented destructor declaration to fix Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=45987

Patch by Eric Uhrhane <ericu@chromium.org> on 2010-09-17
Reviewed by David Levin.

* src/AsyncFileWriterChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/45989> Add WebArchiveInternal.h to Xcode project
ddkilzer@apple.com [Fri, 17 Sep 2010 20:01:10 +0000 (20:01 +0000)]
<webkit.org/b/45989> Add WebArchiveInternal.h to Xcode project

Reviewed by Joseph Pecoraro.

* WebKit.xcodeproj/project.pbxproj: Added missing
WebArchiveInternal.h header file to the project.  It has been
missing since r31281!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd bool wrapper for WebKit2 API
weinig@apple.com [Fri, 17 Sep 2010 19:35:33 +0000 (19:35 +0000)]
Add bool wrapper for WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=45985

Reviewed by John Sullivan.

* Shared/APIObject.h:
* Shared/WebNumber.h:
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKBase.h:
* UIProcess/API/C/WKNumber.cpp:
(WKBooleanGetTypeID):
(WKBooleanCreate):
(WKBooleanGetValue):
(WKBooleanSetValue):
* UIProcess/API/C/WKNumber.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip the new test fast/files/create-blob-url-crash.html in unsupported
jianli@chromium.org [Fri, 17 Sep 2010 19:25:08 +0000 (19:25 +0000)]
Skip the new test fast/files/create-blob-url-crash.html in unsupported
platforms.

* platform/gtk/Skipped:
* platform/mac-wk2/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Fri, 17 Sep 2010 19:07:50 +0000 (19:07 +0000)]
2010-09-17  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Unreviewed, build fix. Add files missed in r67704.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 17 Sep 2010 19:00:03 +0000 (19:00 +0000)]
2010-09-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Chris Marrin.

        Remove scroll and clip layers for WKCACFLayerRenderer
        https://bugs.webkit.org/show_bug.cgi?id=45922

        WKCACFLayerRenderer no longer needs its own layers for managing scrolling
        and clipping, because RenderLayerCompositor provides this functionality.

        * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
        (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Remove call to setScrollFrame().
        (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Ditto.

        * platform/graphics/win/WKCACFLayerRenderer.cpp: Remove references to scroll and clip layers
        (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
        (WebCore::WKCACFLayerRenderer::setRootChildLayer):
        (WebCore::WKCACFLayerRenderer::destroyRenderer):
        (WebCore::WKCACFLayerRenderer::resize):
        * platform/graphics/win/WKCACFLayerRenderer.h:

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::layerTreeAsText): Dump the layers from the root platform layer.
        (WebCore::RenderLayerCompositor::requiresScrollLayer): On Windows,
        always say yes.

2010-09-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Chris Marrin.

        Remove scroll and clip layers for WKCACFLayerRenderer
        https://bugs.webkit.org/show_bug.cgi?id=45922

        WKCACFLayerRenderer no longer needs its own layers for managing scrolling
        and clipping, because RenderLayerCompositor provides this functionality.

        * WebView.cpp:
        (WebView::sizeChanged): Moved code that handles the WM_SIZE message
        into this method. Use it to resize the layer renderer.
        (WebView::WebViewWndProc): Call sizeChanged().
        (WebView::updateRootLayerContents): No need to call setScrollFrame() any more.
        (WebView::layerRendererBecameVisible): Move this from the header (no need to be inline).
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocreateBlobURL with no argument causes crash.
jianli@chromium.org [Fri, 17 Sep 2010 18:59:15 +0000 (18:59 +0000)]
createBlobURL with no argument causes crash.
https://bugs.webkit.org/show_bug.cgi?id=45880

Reviewed by Dmitry Titov.

WebCore:

The fix is to check if the passing blob argument is NULL or not.

Test: fast/files/create-blob-url-crash.html

* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::createPublicBlobURL):
* page/DOMWindow.idl: Add attribute to convert null string to undefined.

LayoutTests:

* fast/files/create-blob-url-crash-expected.txt: Added.
* fast/files/create-blob-url-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67734 268f45cc-cd09-0410-ab3c-d52691b4dbfc