WebKit-https.git
9 years ago[GTK] webkitgtk 1.3.7 build without translations
christian@webkit.org [Thu, 24 Feb 2011 11:22:00 +0000 (11:22 +0000)]
[GTK] webkitgtk 1.3.7 build without translations
https://bugs.webkit.org/show_bug.cgi?id=50612

Rubber-stamped by Eric Seidel.

* GNUmakefile.am: Require stamp-po target for all-local so
    that po files are built before they install.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 24 Feb 2011 11:09:14 +0000 (11:09 +0000)]
2011-02-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Ojan Vafai.

        Crash when deleting inside a blockquote with a large offset
        https://bugs.webkit.org/show_bug.cgi?id=55098

        The bug was caused by inconsistency in lineBreakExistsAtPosition and breakOutOfEmptyMailBlockquotedParagraph.
        While lineBreakExistsAtPosition was checking that a line break exists at the downstream of the given position,
        breakOutOfEmptyMailBlockquotedParagraph wasn't using the downstream for caretPos. Fixed the bug by using
        the downstream position to instantiate caretPos.

        Co-author: Abhishek Arya <inferno@chromium.org>.

        Test: editing/deleting/delete-blockquote-large-offsets.html

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
2011-02-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Ojan Vafai.

        Crash when deleting inside a blockquote with a large offset
        https://bugs.webkit.org/show_bug.cgi?id=55098

        Added a test to ensure WebKit doesn't crash when deleting line inside a blockquote
        and the caret is programmatically set to have a large offset.

        Co-author: Abhishek Arya <inferno@chromium.org>.

        * editing/deleting/delete-blockquote-large-offsets-expected.txt: Added.
        * editing/deleting/delete-blockquote-large-offsets.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-24 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 24 Feb 2011 11:03:40 +0000 (11:03 +0000)]
2011-02-24  MORITA Hajime  <morrita@google.com>

        Unreviewed test_expectations.txt update

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-24 Robert Kroeger <rjkroege@chromium.org>
commit-queue@webkit.org [Thu, 24 Feb 2011 10:57:28 +0000 (10:57 +0000)]
2011-02-24  Robert Kroeger  <rjkroege@chromium.org>

        Reviewed by Darin Fisher.

        Added timestamps to PlatformTouchEvent etc.

        PlatformTouchEvent doesn't have a timestamp and so
        eventSender.leapForward cannot be used for touchevent based tests.
        This change adds a timestamp to PlatformTouchEvent and initializes
        it in a reasonable manner on Android and Qt platforms.

        [chromium] [WebCore] [android] Touch events are missing time stamps
        https://bugs.webkit.org/show_bug.cgi?id=53510

        * platform/PlatformTouchEvent.h:
        (WebCore::PlatformTouchEvent::PlatformTouchEvent):
        (WebCore::PlatformTouchEvent::timestamp):
        * platform/android/PlatformTouchEventAndroid.cpp:
        (WebCore::PlatformTouchEvent::PlatformTouchEvent):
        * platform/qt/PlatformTouchEventQt.cpp:
        (WebCore::PlatformTouchEvent::PlatformTouchEvent):
2011-02-24  Robert Kroeger <rjkroege@chromium.org>

        Reviewed by Darin Fisher.

        Added timestamps to PlatformTouchEvent etc.

        PlatformTouchEvent doesn't have a timestamp and so
        eventSender.leapForward cannot be used for touchevent based tests.
        This change constructs PlatformTouchEvents with timestamps
        provided from a WebTouchEvent on chromium. It also adds an enum
        to make code referring to specific WebTouchPoints easier to read.

        [chromium] [WebCore] [android] Touch events are missing time stamps
        https://bugs.webkit.org/show_bug.cgi?id=53510

        * public/WebTouchPoint.h:
        (WebKit::WebTouchPoint::WebTouchPoint):
        * src/WebInputEventConversion.cpp:
        (WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-24 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 24 Feb 2011 10:49:22 +0000 (10:49 +0000)]
2011-02-24  Andreas Kling  <kling@webkit.org>

        Unreviewed Qt rebaseline.

        * platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 24 Feb 2011 10:36:55 +0000 (10:36 +0000)]
2011-02-24  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Mac rebaselines for r79490 and r79493.

        * fast/repaint/text-emphasis-h-expected.txt:
        * platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-24 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 24 Feb 2011 10:24:26 +0000 (10:24 +0000)]
2011-02-24  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, unskip 2 fixed SVG tests on GTK after r79530.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK, Snow Leopard build fix for r79474.
reni@webkit.org [Thu, 24 Feb 2011 10:21:17 +0000 (10:21 +0000)]
Unreviewed GTK, Snow Leopard build fix for r79474.

* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::setKernelUnitLength):
* platform/graphics/filters/FEConvolveMatrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-24 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 24 Feb 2011 10:18:01 +0000 (10:18 +0000)]
2011-02-24 MORITA Hajime  <morrita@google.com>

        Unreviewed skipping failing tests. (r79517 removed too many.)

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-24 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 24 Feb 2011 10:12:50 +0000 (10:12 +0000)]
2011-02-24  Philippe Normand  <pnormand@igalia.com>

        Unreviewed; skip canvas/philip/tests/2d.imageData.object.round.html and
        canvas/philip/tests/2d.imageData.object.wrap.html on GTK.

        They were passing before r79501.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 24 Feb 2011 10:00:14 +0000 (10:00 +0000)]
2011-02-24  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; skip canvas/philip/tests/2d.imageData.object.round.html and
        canvas/philip/tests/2d.imageData.object.wrap.html on Mac.

        It was removed from the skipped list in r64156 but it wasn't added back
        when r79501 reverted it.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 24 Feb 2011 09:34:15 +0000 (09:34 +0000)]
2011-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Xan Lopez.

        Use IntRect instead of a pointer to a GtkAllocation struct to avoid
        unnecessary memory allocations.

        * plugins/PluginView.h:
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded):
        (WebCore::PluginView::plugAddedCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-24 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 24 Feb 2011 09:30:09 +0000 (09:30 +0000)]
2011-02-24  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip flaky media test on GTK.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 24 Feb 2011 09:05:39 +0000 (09:05 +0000)]
2011-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix the build with GTK+ 3.

        * plugins/PluginView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-24 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 24 Feb 2011 08:55:57 +0000 (08:55 +0000)]
2011-02-24  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skipping 2 GTK+ SVG crashing tests.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-24 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 24 Feb 2011 08:22:31 +0000 (08:22 +0000)]
2011-02-24  MORITA Hajime  <morrita@google.com>

        Unreviewed skipping failing tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 24 Feb 2011 08:20:16 +0000 (08:20 +0000)]
2011-02-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Refactor HTMLEquivalent into a hierachy of classes
        https://bugs.webkit.org/show_bug.cgi?id=55025

        Converted HTMLEquivalent into a class.  Some logic in removeImplicitlyStyledElement is
        extracted as member functions of HTMLEquivalent and its subclasses.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::HTMLEquivalent::create): Added.
        (WebCore::HTMLEquivalent::~HTMLEquivalent): Added.
        (WebCore::HTMLEquivalent::matches): Returns true if the element is an equivalent, meaning that
        the element's implicit style affects the property of this equivalence.
        (WebCore::HTMLEquivalent::hasAttribute): Returns true if this equivalence requires attributes;
        e.g. color, size, dir.
        (WebCore::HTMLEquivalent::propertyExistsInStyle): Returns true if the property of this equivalence
        exists in the specified style. e.g. if this equivalence is for size attribute and font-size property,
        this function returns true if the specified style has font-size property set.
        (WebCore::HTMLEquivalent::HTMLEquivalent): Added.
        (WebCore::HTMLEquivalent::valueIsPresentInStyle): Returns true if the specified style has the
        implicit style of the specified element of this equivalence.
        (WebCore::HTMLEquivalent::addToStyle): Adds the implicit style of the element of this equivalence
        to the specified mutable style.
        (WebCore::HTMLEquivalentValueList::create): Added.
        (WebCore::HTMLEquivalentValueList::HTMLEquivalentValueList): Added.
        (WebCore::HTMLEquivalentValueList::valueIsPresentInStyle): Added.
        (WebCore::HTMLEquivalentAttribute::create): Added.
        (WebCore::HTMLEquivalentAttribute::matches): Added.
        (WebCore::HTMLEquivalentAttribute::hasAttribute): Added.
        (WebCore::HTMLEquivalentAttribute::attributeName): Added.
        (WebCore::HTMLEquivalentAttribute::HTMLEquivalentAttribute): Added.
        (WebCore::HTMLEquivalentAttribute::valueIsPresentInStyle): Added.
        (WebCore::HTMLEquivalentAttribute::addToStyle): Added.
        (WebCore::HTMLEquivalentAttribute::attributeValueAsCSSValue): Added.
        (WebCore::HTMLEquivalentFontSizeAttribute::create): Added.
        (WebCore::HTMLEquivalentFontSizeAttribute::HTMLEquivalentFontSizeAttribute): Added.
        (WebCore::HTMLEquivalentFontSizeAttribute::attributeValueAsCSSValue): Added.
        (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Uses new classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 24 Feb 2011 08:13:44 +0000 (08:13 +0000)]
2011-02-22  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        fix revision number finding when creating git patches
        https://bugs.webkit.org/show_bug.cgi?id=55024

        HEAD~n does not walk merge commits correctly. git log however does.

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 24 Feb 2011 07:56:52 +0000 (07:56 +0000)]
2011-02-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Ojan Vafai.

        Add missing files to JavaScriptCore.gypi
        https://bugs.webkit.org/show_bug.cgi?id=55020

        gypi files are supposed to list every file under the sun.  This patch
        adds some missing files and sorts the rest.

        * JavaScriptCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r79510.
ossy@webkit.org [Thu, 24 Feb 2011 07:03:30 +0000 (07:03 +0000)]
Unreviewed, rolling out r79510.
http://trac.webkit.org/changeset/79510
https://bugs.webkit.org/show_bug.cgi?id=55114

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-02-23
It made ~200 tests crash on Qt bot (Requested by Ossy_ on
#webkit).

* platform/text/TextBreakIterator.h:
* platform/text/TextBreakIteratorICU.cpp:
(WebCore::lineBreakIterator):
* platform/text/qt/TextBreakIteratorQt.cpp:
(WebCore::lineBreakIterator):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::findNextLineBreak):
* rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths):
* rendering/break_lines.cpp:
(WebCore::nextBreakablePosition):
* rendering/break_lines.h:
(WebCore::isBreakable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 24 Feb 2011 06:05:23 +0000 (06:05 +0000)]
2011-02-23  MORITA Hajime <morrita@google.com>

        Unreviewed unskipping another passed tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 24 Feb 2011 05:14:42 +0000 (05:14 +0000)]
2011-02-23  Martin Robinson  <mrobinson@igalia.com>

        Rebaseline a couple GTK+ test results.

        * platform/gtk/fast/repaint/text-emphasis-h-expected.txt:
        * platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 24 Feb 2011 04:21:56 +0000 (04:21 +0000)]
2011-02-23  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        autocomplete=off prevents refilling form fields on back/forward navigation
        https://bugs.webkit.org/show_bug.cgi?id=47463

        I haven't actually run this patch due to the difficulty of getting
        a bugzilla instance running. It's simple enough code that I'm not too worried
        about it.

        * committers-autocomplete.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 24 Feb 2011 03:38:48 +0000 (03:38 +0000)]
2011-02-23  MORITA Hajime  <morrita@google.com>

        Unreviewed unskipping passed tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUsed svn merge -r79502:79501 to roll out r79502 because it broke the
ggaren@apple.com [Thu, 24 Feb 2011 02:12:57 +0000 (02:12 +0000)]
Used svn merge -r79502:79501 to roll out r79502 because it broke the
SnowLeopard and Leopard builds.

Reviewed by Mark Rowe.

* WebCore.xcodeproj/project.pbxproj:
* platform/mac/HTMLConverter.h: Removed.
* platform/mac/HTMLConverter.mm: Removed.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 24 Feb 2011 01:56:34 +0000 (01:56 +0000)]
2011-02-23  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Refactored MarkedSpace to operate in terms of size classes
        https://bugs.webkit.org/show_bug.cgi?id=55106

        SunSpider reports no change.

        * runtime/JSCell.h:
        (JSC::JSCell::MarkedSpace::sizeClassFor):
        (JSC::JSCell::MarkedSpace::allocate): Delegate allocation based on size
        class. Since these functions are inline, the compiler can constant fold
        them.

        * runtime/MarkedBlock.h:
        (JSC::MarkedBlock::cellSize):
        (JSC::MarkedBlock::size): Factored out a cellSize() helper.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::allocateBlock):
        (JSC::MarkedSpace::allocateFromSizeClass):
        (JSC::MarkedSpace::shrink):
        (JSC::MarkedSpace::reset):
        * runtime/MarkedSpace.h:
        (JSC::MarkedSpace::SizeClass::SizeClass):
        (JSC::MarkedSpace::SizeClass::reset): Changed to operate in terms of
        abstract SizeClass objects, which are independent linked lists of blocks
        of a certain size class, instead of a single m_heap object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for <rdar://problem/9002157> Garbage in the bottom right corner of the window
bdakin@apple.com [Thu, 24 Feb 2011 01:47:24 +0000 (01:47 +0000)]
Fix for <rdar://problem/9002157> Garbage in the bottom right corner of the window
when scrolling

Reviewed by Dan Bernstein.

When there is both a horizontal and a vertical scrollbar, it is necessary to
include the space between them in the invalidation.
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMinimize calls to ubrk_setText()
mitz@apple.com [Thu, 24 Feb 2011 01:45:06 +0000 (01:45 +0000)]
Minimize calls to ubrk_setText()
https://bugs.webkit.org/show_bug.cgi?id=54912
<rdar://problem/9032774>

Patch by Ned Holbrook <nholbrook@apple.com> on 2011-02-23
Reviewed by Dan Bernstein.

Avoid calling ubrk_setText() once per call to isBreakable() by using a LazyLineBreakIterator, which defers
break iterator creation until needed. This requires replacing the global line break iterator primitive with a
version that can be nested, since in some cases two iterators may need to be outstanding. In particular,
layoutInlineChildren() may indirectly call computePreferredLogicalWidths() and each may need an iterator.
In a test with a paragraph of Japanese text, this reduced the number of ubrk_setText() calls from 164 to 1.

* platform/text/TextBreakIterator.h: Add LazyLineBreakIterator.
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::~LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::string):
(WebCore::LazyLineBreakIterator::length):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
* platform/text/TextBreakIteratorICU.cpp: Replace lineBreakIterator() primitive with acquireLineBreakIterator()/releaseLineBreakIterator().
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
* platform/text/qt/TextBreakIteratorQt.cpp: Ditto TextBreakIteratorICU.cpp.
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Pass a mapping of RenderText to LazyLineBreakIterator from one call of findNextLineBreak() to the next.
(WebCore::RenderBlock::findNextLineBreak): Use said mapping, resetting LazyLineBreakIterator for any newly-encountered RenderText.
* rendering/RenderText.cpp: Use a local LazyLineBreakIterator.
(WebCore::RenderText::computePreferredLogicalWidths):
* rendering/break_lines.cpp: Accept LazyLineBreakIterator rather than TextBreakIterator.
(WebCore::nextBreakablePosition):
* rendering/break_lines.h: Accept LazyLineBreakIterator rather than TextBreakIterator.
(WebCore::isBreakable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 24 Feb 2011 01:40:24 +0000 (01:40 +0000)]
2011-02-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Remove some of the old accelerated compositing code
        https://bugs.webkit.org/show_bug.cgi?id=55084

        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::exitAcceleratedCompositingMode):
        * UIProcess/API/mac/WKView.mm:
        * UIProcess/API/mac/WKViewInternal.h:
        * UIProcess/API/qt/qwkpage_p.h:
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::exitAcceleratedCompositingMode):
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        * UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
        (WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):
        (WebKit::LayerBackedDrawingAreaProxy::detachCompositingContext):
        * UIProcess/win/WebView.cpp:
        * UIProcess/win/WebView.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::enterAcceleratedCompositingMode):
        (WebKit::WebPage::exitAcceleratedCompositingMode):
        * WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
andersca@apple.com [Thu, 24 Feb 2011 01:28:59 +0000 (01:28 +0000)]
Fix build.

* platform/mac/HTMLConverter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Thu, 24 Feb 2011 01:20:57 +0000 (01:20 +0000)]
2011-02-23  Emil A Eklund  <eae@chromium.org>

        Unreviewed.

        Add myself to the list of committers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoved outdated/incorrect chromium baselins. Unreviewed.
atwilson@chromium.org [Thu, 24 Feb 2011 01:00:06 +0000 (01:00 +0000)]
Removed outdated/incorrect chromium baselins. Unreviewed.

* platform/chromium-mac-leopard/editing/deleting/delete-tab-003-expected.txt: Removed.
* platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.txt: Removed.
* platform/chromium-mac-leopard/editing/inserting/insert-tab-003-expected.txt: Removed.
* platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 24 Feb 2011 00:49:50 +0000 (00:49 +0000)]
2011-02-23  James Robinson  <jamesr@chromium.org>

        Update chromium expectations for fast/repaint/text-emphasis-h.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 24 Feb 2011 00:23:35 +0000 (00:23 +0000)]
2011-02-23  James Robinson  <jamesr@chromium.org>

        Update chromium baselines and expectations.

        * platform/chromium-mac/fast/repaint/text-emphasis-h-expected.txt: Added.
        * platform/chromium-mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
        * platform/chromium-win/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 24 Feb 2011 00:18:05 +0000 (00:18 +0000)]
2011-02-23  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        [Chromium] Use WebKitClient for OSRandomSource instead of trying to talk to the file system in the sandbox
        https://bugs.webkit.org/show_bug.cgi?id=55093

        Exclude OSRandomSource.cpp from the Chromium build.  This function is
        implemented in WebKit/chromium/src instead.

        * JavaScriptCore.gyp/JavaScriptCore.gyp:
2011-02-23  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        [Chromium] Use WebKitClient for OSRandomSource instead of trying to talk to the file system in the sandbox
        https://bugs.webkit.org/show_bug.cgi?id=55093

        We need to get OS randomness from the WebKit client rather than try to
        get it from /dev/urandom directly because WebKit doesn't have access to
        the file system when running inside the Chromium sandbox.

        * WebKit.gyp:
        * src/ChromiumOSRandomSource.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: Copied content loses formatting on paste to external apps.
enrica@apple.com [Thu, 24 Feb 2011 00:09:02 +0000 (00:09 +0000)]
REGRESSION: Copied content loses formatting on paste to external apps.
https://bugs.webkit.org/show_bug.cgi?id=47615
<rdar://problem/9001214>

Reviewed by Darin Adler.

This patch adds a way for WebKit2 to create NSAttributedStrings from
a DOM range without using the AppKit api initWithDOMRange that internally
needs to access the WebView. The NSAttributedString is needed to create
RTF formats in the pasteboard.
This is to be considered a first step, since in the future we want to have
an implementation based on the TextIterator.

* WebCore.xcodeproj/project.pbxproj: Added new file.
* platform/mac/HTMLConverter.h: Added.
* platform/mac/HTMLConverter.mm: Added.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
class for WebKit2 to create the NSAttributedString from the DOM range.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll out r64156 as it introduces incorrect behaviour.
oliver@apple.com [Thu, 24 Feb 2011 00:04:41 +0000 (00:04 +0000)]
Roll out r64156 as it introduces incorrect behaviour.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 24 Feb 2011 00:02:56 +0000 (00:02 +0000)]
2011-02-23  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        Roll Chromium DEPS
        https://bugs.webkit.org/show_bug.cgi?id=55096

        Rolling to the future, like a truck.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReverting an unintentional change that was part of http://trac.webkit.org/changeset...
enrica@apple.com [Wed, 23 Feb 2011 23:57:05 +0000 (23:57 +0000)]
Reverting an unintentional change that was part of trac.webkit.org/changeset/79494.
Unreviewed.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::interceptEditingKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed removal of superfluous chromium expectations.
atwilson@chromium.org [Wed, 23 Feb 2011 23:34:12 +0000 (23:34 +0000)]
Unreviewed removal of superfluous chromium expectations.

* platform/chromium-mac/editing/selection/move-past-trailing-space-expected.checksum: Removed.
* platform/chromium-mac/editing/style/create-block-for-style-011-expected.checksum: Removed.
* platform/chromium-mac/editing/style/create-block-for-style-011-expected.png: Removed.
* platform/chromium-mac/editing/style/create-block-for-style-012-expected.checksum: Removed.
* platform/chromium-mac/editing/style/create-block-for-style-012-expected.png: Removed.
* platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.checksum: Removed.
* platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Removed.
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Removed.
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
* platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.checksum: Removed.
* platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
* platform/chromium-mac/fast/text/trailing-white-space-2-expected.checksum: Removed.
* platform/chromium-mac/fast/text/trailing-white-space-expected.checksum: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with...
hyatt@apple.com [Wed, 23 Feb 2011 23:27:01 +0000 (23:27 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Patch computePositionedLogicalHeightUsing to be writing-mode-aware.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
* rendering/RenderBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 23 Feb 2011 23:19:18 +0000 (23:19 +0000)]
2011-02-23  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed. Revert incorrect baseline added by r79473.

        * platform/mac-leopard/fast/forms/text-control-intrinsic-widths-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 23 Feb 2011 23:05:22 +0000 (23:05 +0000)]
2011-02-23  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Flash item placed on wrong location right after load
        https://bugs.webkit.org/show_bug.cgi?id=37769

        If a plugin is GtkSocket based, do not set the widget allocation until the
        window is actually embedded in the parent. When the window is embedded, use
        any pending allocation for the call to gtk_widget_size_allocate. This bug
        seems to only appear with Flash movies loaded as the src of an iframe.

        * manual-tests/plugins/windowed-in-iframe.html: Added.
        * plugins/PluginView.h: Add a few new members to track window embedding state.
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded): If this is a GtkSocket-based plugin
        wait until the plug-added signal fires to set the widget allocation.
        (WebCore::PluginView::plugAddedCallback): Updated to be a static method, so that
        we can access private members. If there is a pending allocation, call gtk_widget_size_allocate
        with it.
        (WebCore::PluginView::platformStart): Update the plugin state, so that we do not
        call gtk_widget_size_allocate if the window isn't embedded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Mac OS X Services are not available for selected text in WebKit2...
enrica@apple.com [Wed, 23 Feb 2011 22:56:48 +0000 (22:56 +0000)]
Source/WebCore: Mac OS X Services are not available for selected text in WebKit2 windows.
https://bugs.webkit.org/show_bug.cgi?id=54777
<rdar://problem/8666428>

Reviewed by Adam Roben.

The changes to WebCore for this bug are limited to exposing a new
entry point in the Editor class to write to the pasteboard and
changes to the Pasteboard class to write the selection with
a given set of pasteboard types. The majority of the work
is done in WebKit2.

* WebCore.exp.in:
* editing/Editor.h:
* editing/mac/EditorMac.mm: Added entrypoint to write the
selection to the pasteboard.
(WebCore::Editor::writeSelectionToPasteboard):
* platform/Pasteboard.h:
* platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::writeRange):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection):

Source/WebKit2: Mac OS X Services are not available for selected text in WebKit2 windows.
https://bugs.webkit.org/show_bug.cgi?id=54777
<rdar://problem/8666428>

Reviewed by Adam Roben.

This patch adds support for Mac OS X Services in WebKit2 windows.
In WKView we now call registerServicesMenuSendTypes providing the
pasteboard types supported by WebKit and we also implement the two
protocol methods required to validate the send type and write the
content to the pasteboard. Unfortunately, AppKit expects the content
to be available in the pasteboard upon return from writeSelectionToPasteboard and
this is the reason why the call to the WebProcess is synchronous.

* Shared/SelectionState.h:
(WebKit::SelectionState::SelectionState): Extended to include
isContentRichlyEditable
* Shared/mac/PasteboardTypes.h:
* Shared/mac/PasteboardTypes.mm:
(WebKit::PasteboardTypes::forSelection): Added.
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]): Added call
to registerServicesMenuSendTypes.
(-[WKView writeSelectionToPasteboard:types:]): Added.
(-[WKView validRequestorForSendType:returnType:]): Added.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::writeSelectionToPasteboard):
* UIProcess/WebPageProxy.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection): Modified to
support the new SelectionState value.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::writeSelectionToPasteboard): Added synchronous
message to write the selected content to the pasteboard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with...
hyatt@apple.com [Wed, 23 Feb 2011 22:55:20 +0000 (22:55 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Simon Fraser.

Patch computePositionedLogicalHeight to be writing-mode-aware.  Functions it calls have not been
patched yet, so still not testable in a vertical text environment.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 23 Feb 2011 22:51:58 +0000 (22:51 +0000)]
2011-02-23  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Moved the "nextAtom" allocation pointer into MarkedBlock for better encapsulation
        https://bugs.webkit.org/show_bug.cgi?id=55079

        SunSpider reports no change.

        * runtime/Heap.cpp:
        (JSC::Heap::reset): Moved Zombie sweeping here, up from MarkedSpace,
        since we want Heap to logically control MarkedSpace. MarkedSpace should
        never choose to sweep itself.

        * runtime/JSCell.h:
        (JSC::JSCell::MarkedBlock::allocate): Updated for nextAtom becoming a
        member of MarkedBlock. No need to reset nextAtom to firstAtom() when
        we reach the end of a block, since there's now an explicit reset pass
        during GC.

        * runtime/MarkedBlock.cpp:
        (JSC::MarkedBlock::MarkedBlock):
        * runtime/MarkedBlock.h:
        (JSC::MarkedBlock::reset): Added the nextAtom data member, and reordered
        some data members to improve cache locality.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::MarkedSpace):
        (JSC::MarkedSpace::allocate):
        (JSC::MarkedSpace::reset):
        * runtime/MarkedSpace.h:
        (JSC::CollectorHeap::CollectorHeap): Removed nextAtom, and added an
        explicit reset pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 23 Feb 2011 22:47:30 +0000 (22:47 +0000)]
2011-02-23  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update. Remove tests that pass after
        r79473, do the equivalent chromium-mac-leopard update for
        fast/text/international/pop-up-button-text-alignment-and-direction.html

        * platform/chromium-mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with...
hyatt@apple.com [Wed, 23 Feb 2011 22:25:10 +0000 (22:25 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Patch computePositionedLogicalWidthUsing to be writing-mode-aware. Still not testable in a vertical text
environment, since height computations will overwrite all values computed here until they are patched as well.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
* rendering/RenderBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore unreviewed expectations cleanup for chromium.
atwilson@chromium.org [Wed, 23 Feb 2011 22:22:49 +0000 (22:22 +0000)]
More unreviewed expectations cleanup for chromium.

* platform/chromium-mac-leopard/editing/deleting/delete-tab-003-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/deleting/delete-tab-003-expected.png: Added.
* platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
* platform/chromium-mac-leopard/editing/inserting/insert-tab-003-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/inserting/insert-tab-003-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Renata Hodovan <reni@webkit.org>
reni@webkit.org [Wed, 23 Feb 2011 22:11:28 +0000 (22:11 +0000)]
2011-02-23  Renata Hodovan  <reni@webkit.org>

        Reviewed by Nikolas Zimmermann.

        FEColorMatrixElement changes doesn't require relayout
        https://bugs.webkit.org/show_bug.cgi?id=54880

        When the FEColorMatrixElement receives an update message but the given value remains the same we don't need
        to relayout the filter.

        No new tests are needed because this modificiation is covered by the dynamic update tests of FEColorMatrix.

        * platform/graphics/filters/FEColorMatrix.cpp:
        (WebCore::FEColorMatrix::setType):
        (WebCore::FEColorMatrix::setValues):
        * platform/graphics/filters/FEColorMatrix.h:
        * svg/SVGFEColorMatrixElement.cpp:
        (WebCore::SVGFEColorMatrixElement::setFilterEffectAttribute):
        (WebCore::SVGFEColorMatrixElement::svgAttributeChanged):
        * svg/SVGFEColorMatrixElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 23 Feb 2011 22:08:04 +0000 (22:08 +0000)]
2011-02-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        [Chromium] Add WebKitClient::cryptographicallyRandomValues
        https://bugs.webkit.org/show_bug.cgi?id=55073

        This patch adds a WebKit client API to get cryptographic randomness.
        We'll use this API to gather seed randomness while inside the sandbox.

        * public/WebKitClient.h:
        (WebKit::WebKitClient::cryptographicallyRandomValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 23 Feb 2011 22:06:26 +0000 (22:06 +0000)]
2011-02-23  James Robinson  <jamesr@chromium.org>

        REGRESSION(79466): fast/parser/test-unicode-characters-in-attribute-name.html fails

        Reverts TextCodecUTF16.cpp back to pre-79466 state.  The crash fix in 79466 was for UTF-8 only, it also caused the UTF16 path to fail.

        * platform/text/TextCodecUTF16.cpp:
        (WebCore::newStreamingTextDecoderUTF16LE):
        (WebCore::newStreamingTextDecoderUTF16BE):
        (WebCore::TextCodecUTF16::decode):
        (WebCore::TextCodecUTF16::encode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with...
hyatt@apple.com [Wed, 23 Feb 2011 22:04:21 +0000 (22:04 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Patch computePositionedLogicalWidth to be writing-mode-aware.  Functions it calls have not been
patched yet, so still not testable in a vertical text environment.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 23 Feb 2011 21:55:55 +0000 (21:55 +0000)]
2011-02-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add a ShareableBitmap::create overload that takes an existing SharedMemory object
        https://bugs.webkit.org/show_bug.cgi?id=55081

        * Shared/ShareableBitmap.cpp:
        (WebKit::ShareableBitmap::createShareable):
        (WebKit::ShareableBitmap::create):
        * Shared/ShareableBitmap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 23 Feb 2011 21:40:17 +0000 (21:40 +0000)]
2011-02-23  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r79428.
        http://trac.webkit.org/changeset/79428
        https://bugs.webkit.org/show_bug.cgi?id=54714

        Does not work in the Chromium sandbox

        * JavaScriptCore.exp:
2011-02-23  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r79428.
        http://trac.webkit.org/changeset/79428
        https://bugs.webkit.org/show_bug.cgi?id=54714

        Does not work in the Chromium sandbox

        * websockets/WebSocketHandshake.cpp:
        (WebCore::generateSecWebSocketKey):
        (WebCore::generateKey3):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with...
hyatt@apple.com [Wed, 23 Feb 2011 21:32:32 +0000 (21:32 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Add logical accessors for the left()/right()/top()/bottom() properties on the RenderStyle.

* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::logicalLeft):
(WebCore::InheritedFlags::logicalRight):
(WebCore::InheritedFlags::logicalTop):
(WebCore::InheritedFlags::logicalBottom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 23 Feb 2011 21:31:31 +0000 (21:31 +0000)]
2011-02-23  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update. Add failing expectations for
        two editing tests that were hidden by the TIMEOUT expectation remove by
        r79480.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 23 Feb 2011 21:21:43 +0000 (21:21 +0000)]
2011-02-23  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed.

        Many tests started timing out on the chrome mac canaries around r79035
        https://bugs.webkit.org/show_bug.cgi?id=54885

        Remove TIMEOUT expectations from tests, they were caused by a bad bot
        (and are passing now that the bot has been restarted).

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 23 Feb 2011 21:08:35 +0000 (21:08 +0000)]
2011-02-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Web Inspector toolbar looks bad in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=55076
        <rdar://problem/8866258>

        * UIProcess/API/mac/WKView.mm:
        (-[WKView mouseDownCanMoveWindow]):
        Return NO from mouseDownCanMoveWindow to prevent drags in the (now transparent) inspector WKView
        from dragging the window around.

        * UIProcess/mac/WebInspectorProxyMac.mm:
        (WebKit::WebInspectorProxy::platformCreateInspectorPage):
        Call [WKView setDrawsBackground:NO].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed expectations update for chromium.
atwilson@chromium.org [Wed, 23 Feb 2011 21:05:16 +0000 (21:05 +0000)]
Unreviewed expectations update for chromium.

* platform/chromium-mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.png: Added.
* platform/chromium-mac-leopard/editing/pasteboard/4641033-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/pasteboard/4641033-expected.png: Added.
* platform/chromium-mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.png: Added.
* platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.png: Added.
* platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.png: Added.
* platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-2-expected.png: Added.
* platform/chromium-mac-leopard/editing/pasteboard/pasting-tabs-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/pasteboard/pasting-tabs-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/3690703-2-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/3690703-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/selection/3690703-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/3690719-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/selection/3690719-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/4975120-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/selection/4975120-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/5240265-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/selection/5240265-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/replaced-boundaries-3-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/selection/replaced-boundaries-3-expected.png: Added.
* platform/chromium-mac-leopard/editing/style/5046875-1-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/style/5046875-1-expected.png: Added.
* platform/chromium-mac-leopard/editing/style/table-selection-expected.checksum: Added.
* platform/chromium-mac-leopard/editing/style/table-selection-expected.png: Added.
* platform/chromium-mac-leopard/fast/block/positioning/inline-block-relposition-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/block/positioning/inline-block-relposition-expected.png: Added.
* platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/continuationCrash-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/css/continuationCrash-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/css2-system-fonts-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/css/css2-system-fonts-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/font-face-locally-installed-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/css/font-face-locally-installed-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/margin-top-bottom-dynamic-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/css/margin-top-bottom-dynamic-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-strict-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-strict-expected.png: Added.
* platform/chromium-mac-leopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
* platform/chromium-mac-leopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
* platform/chromium-mac-leopard/fast/events/autoscroll-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/events/autoscroll-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label01-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label01-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label02-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label02-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label03-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label03-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label04-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label04-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/basic-textareas-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/basic-textareas-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/basic-textareas-quirks-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/basic-textareas-quirks-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/blankbuttons-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/blankbuttons-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/button-align-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/button-align-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/button-cannot-be-nested-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/button-cannot-be-nested-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/button-default-title-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/button-default-title-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/button-generated-content-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/button-generated-content-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/button-positioned-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/button-positioned-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/button-style-color-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/button-style-color-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/button-table-styles-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/button-table-styles-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/button-text-transform-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/button-text-transform-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/button-white-space-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/button-white-space-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/control-clip-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/control-clip-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/control-restrict-line-height-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/control-restrict-line-height-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/formmove3-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/formmove3-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-align-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-align-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-first-letter-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-first-letter-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-spaces-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-spaces-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-table-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-table-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/menulist-no-overflow-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/menulist-no-overflow-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/menulist-width-change-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/menulist-width-change-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/option-strip-whitespace-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/option-strip-whitespace-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/option-text-clip-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/option-text-clip-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/placeholder-set-value-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/placeholder-set-value-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/search-cancel-button-style-sharing-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/search-cancel-button-style-sharing-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/search-rtl-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/search-rtl-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/search-zoomed-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/search-zoomed-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/select-align-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/select-align-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/select-change-listbox-to-popup-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/select-change-listbox-to-popup-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/select-disabled-appearance-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/select-disabled-appearance-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/select-initial-position-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/select-initial-position-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/select-selected-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/select-selected-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/stuff-on-my-optgroup-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/stuff-on-my-optgroup-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/targeted-frame-submission-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/targeted-frame-submission-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/textarea-align-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/textarea-align-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/textarea-placeholder-set-value-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/textarea-placeholder-set-value-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/textarea-scroll-height-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/textarea-scroll-height-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/textarea-scrolled-type-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/textarea-scrolled-type-expected.png: Added.
* platform/chromium-mac-leopard/fast/parser/document-write-option-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/parser/document-write-option-expected.png: Added.
* platform/chromium-mac-leopard/fast/parser/entity-comment-in-textarea-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/parser/entity-comment-in-textarea-expected.png: Added.
* platform/chromium-mac-leopard/fast/parser/open-comment-in-textarea-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/parser/open-comment-in-textarea-expected.png: Added.
* platform/chromium-mac-leopard/fast/replaced/width100percent-button-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/replaced/width100percent-button-expected.png: Added.
* platform/chromium-mac-leopard/fast/replaced/width100percent-searchfield-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/replaced/width100percent-searchfield-expected.png: Added.
* platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png: Added.
* platform/chromium-mac-leopard/fast/selectors/064-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/selectors/064-expected.png: Added.
* platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png: Added.
* platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.txt: Added.
* platform/chromium-mac-leopard/fast/table/append-cells2-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/table/append-cells2-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/table/border-collapsing/004-vertical-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/frame-and-rules-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/table/frame-and-rules-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/remove-td-display-none-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/table/remove-td-display-none-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/atsui-partial-selection-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/text/atsui-partial-selection-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/capitalize-boundaries-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/text/capitalize-boundaries-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/line-breaks-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/text/line-breaks-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/word-break-run-rounding-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/text/word-break-run-rounding-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug138725-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug138725-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug14323-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug14323-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug26178-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug26178-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2962-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2962-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug30692-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug30692-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug33855-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug33855-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug39209-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug39209-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4429-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4429-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug44505-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug44505-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug51727-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug51727-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug52505-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug52505-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug52506-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug52506-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug60749-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug60749-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug67915-1-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug67915-1-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug68912-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug68912-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug88035-1-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug88035-1-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug88035-2-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug88035-2-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/collapsing_borders/bug41262-4-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.checksum: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix crash seen in one of the regression tests.
darin@apple.com [Wed, 23 Feb 2011 20:57:54 +0000 (20:57 +0000)]
Fix crash seen in one of the regression tests.

Reviewed by Alexey Proskuryakov.

* platform/text/TextCodecUTF16.cpp:
(WebCore::TextCodecUTF16::decode): Handle case where we did not decode any new data,
we were not told to flush, and we had a buffered byte. The assertion here was incorrect,
and the correct thing to do is nothing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Sergey Glazunov <serg.glazunov@gmail.com>
jschuh@chromium.org [Wed, 23 Feb 2011 20:49:10 +0000 (20:49 +0000)]
2011-02-23  Sergey Glazunov  <serg.glazunov@gmail.com>

        Reviewed by James Robinson.

        SVGCursorElement::removeClient() should verify that its argument is connected with
        the proper cursor element.
        https://bugs.webkit.org/show_bug.cgi?id=54979

        Test: svg/css/multiple-cursors-crash.html

        * svg/SVGCursorElement.cpp:
        (WebCore::SVGCursorElement::removeClient):
2011-02-23  Sergey Glazunov  <serg.glazunov@gmail.com>

        Reviewed by James Robinson.

        SVGCursorElement::removeClient() should verify that its argument is connected with
        the proper cursor element.
        https://bugs.webkit.org/show_bug.cgi?id=54979

        * svg/css/multiple-cursors-crash-expected.txt: Added.
        * svg/css/multiple-cursors-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix an off-by-one error in JSC::appendSourceToError
aroben@apple.com [Wed, 23 Feb 2011 20:45:24 +0000 (20:45 +0000)]
Fix an off-by-one error in JSC::appendSourceToError

Looks like this bug has been around since the code was first added in r35245.

Fixes <http://webkit.org/b/55052> <rdar://problem/9043512> Crash in JSC::appendSourceToError
when running fast/dom/objc-big-method-name.html on Windows with full page heap enabled

Reviewed by Darin Adler.

* interpreter/Interpreter.cpp:
(JSC::appendSourceToError): When trimming whitespace off the end of the string, examine the
character at stop-1 rather than at stop. At this point in the code, stop represents the
index just past the end of the characters we care about, and can even be just past the end
of the entire data buffer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Renata Hodovan <reni@webkit.org>
reni@webkit.org [Wed, 23 Feb 2011 20:45:20 +0000 (20:45 +0000)]
2011-02-23  Renata Hodovan  <reni@webkit.org>

        Reviewed by Darin Adler.

        FEConvolveMatrixElement changes doesn't require relayout
        https://bugs.webkit.org/show_bug.cgi?id=55067

        When the FEConvolveMatrixElement receives an update message but the
        given value remains the same we don't need to relayout the filter.

        No new tests are needed because this modificiation is covered by the
        dynamic update tests of FEConvolveMatrix.

        * platform/graphics/filters/FEConvolveMatrix.cpp:
        (WebCore::FEConvolveMatrix::setDivisor):
        (WebCore::FEConvolveMatrix::setBias):
        (WebCore::FEConvolveMatrix::setTargetOffset):
        (WebCore::FEConvolveMatrix::edgeMode):
        (WebCore::FEConvolveMatrix::setEdgeMode):
        (WebCore::FEConvolveMatrix::setPreserveAlpha):
        * platform/graphics/filters/FEConvolveMatrix.h:
        * svg/SVGFEConvolveMatrixElement.cpp:
        (WebCore::SVGFEConvolveMatrixElement::setFilterEffectAttribute):
        (WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged):
        * svg/SVGFEConvolveMatrixElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 23 Feb 2011 20:45:01 +0000 (20:45 +0000)]
2011-02-22  Simon Fraser  <simon.fraser@apple.com>

        New Leopard results after r78846.

        * platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt:
        * platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt:
        * platform/mac-leopard/fast/blockflow/border-vertical-lr-expected.txt: Added.
        * platform/mac-leopard/fast/dom/52776-expected.txt:
        * platform/mac-leopard/fast/forms/basic-selects-expected.txt:
        * platform/mac-leopard/fast/forms/select-writing-direction-natural-expected.txt:
        * platform/mac-leopard/fast/forms/text-control-intrinsic-widths-expected.txt: Added.
        * platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt:
        * platform/mac-leopard/fast/text/international/bidi-menulist-expected.txt:
        * platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
        * platform/mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
        * platform/mac-leopard/fast/text/international/text-combine-image-test-expected.txt: Added.
        * platform/mac-leopard/media/controls-after-reload-expected.txt:
        * platform/mac-leopard/media/controls-strict-expected.txt:
        * platform/mac-leopard/media/controls-styling-expected.txt:
        * platform/mac-leopard/media/video-controls-rendering-expected.txt:
        * platform/mac-leopard/media/video-display-toggle-expected.txt:
        * platform/mac-leopard/media/video-no-audio-expected.txt:
        * platform/mac-leopard/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Removed.
        * platform/mac-leopard/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 23 Feb 2011 20:25:17 +0000 (20:25 +0000)]
2011-02-23  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Rolled back in r79367 with SnowLeopard Release bot crash fixed.
        https://bugs.webkit.org/show_bug.cgi?id=54999

        The crash was caused by failure to update the "nextBlock" pointer when
        removing a block from the list while shrinking. The fix is to update the
        "nextBlock" pointer.

        This crash was very rare because it only happened in cases where the very
        first block in the heap contained no marked cells.
2011-02-23  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Rolled back in r79367 with SnowLeopard Release bot crash fixed.
        https://bugs.webkit.org/show_bug.cgi?id=54999
2011-02-23  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Rolled back in r79367 with SnowLeopard Release bot crash fixed.
        https://bugs.webkit.org/show_bug.cgi?id=54999

        * ForwardingHeaders/wtf/DoublyLinkedList.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove WKPageForceRepaintWithInvalidation and instead make WKPageForceRepaint
weinig@apple.com [Wed, 23 Feb 2011 20:13:40 +0000 (20:13 +0000)]
Remove WKPageForceRepaintWithInvalidation and instead make WKPageForceRepaint
always dirty the entire page.

Reviewed by Anders Carlsson.

* Shared/ForceRepaintFlags.h: Removed.
* UIProcess/API/C/WKPage.cpp:
(WKPageForceRepaint):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::forceRepaint):
* UIProcess/WebPageProxy.h:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::forceRepaint):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::forceRepaint):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 23 Feb 2011 20:08:24 +0000 (20:08 +0000)]
2011-02-23  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add more thorough manual test coverage for media controls
        https://bugs.webkit.org/show_bug.cgi?id=55006

        * manual-tests/media-controls.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
darin@apple.com [Wed, 23 Feb 2011 20:07:20 +0000 (20:07 +0000)]
Fix build.

* platform/text/TextCodecUTF16.cpp:
(WebCore::TextCodecUTF16::decode): Removed stray unused local variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 23 Feb 2011 20:06:49 +0000 (20:06 +0000)]
2011-02-23  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Setting shadow host should also attach and set inDocument, just like
        appending/inserting a child.
        https://bugs.webkit.org/show_bug.cgi?id=55065

        No new tests, because functionality is not yet used.

        * dom/Element.cpp:
        (WebCore::Element::setShadowRoot): Add attaching and setting inDocument
            for the shadow DOM subtree, like the host.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with...
hyatt@apple.com [Wed, 23 Feb 2011 20:00:47 +0000 (20:00 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Darin Adler and Simon Fraser.

- Add clientLogicalWidth and clientLogicalHeight that call the correct clientWidth or clientHeight based off
writing-mode.
- Patch clientLogicalBottom to use clientLogicalHeight.
- Convert containingBlockWidthForPositioned and containingBlockHeightForPositioned to be logical and to make use of
clientLogicalHeight/Width.  Also make them able to handle perpendicular writing mode containining blocks.
- Refine containingBlockLogicalHeightForPositioned to match containingBlockLogicalWidthForPositioned more closely.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
* rendering/RenderBox.h:
(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):
(WebCore::RenderBox::clientLogicalBottom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 23 Feb 2011 20:00:25 +0000 (20:00 +0000)]
2011-02-23  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        REGRESSION (new UTF-8 decoder): Reproducible crash on alltommac.se
        https://bugs.webkit.org/show_bug.cgi?id=54862

        Correct handling of end of buffer partial sequence in UTF-8 and UTF-16 decoders when flushing with zero length
        https://bugs.webkit.org/show_bug.cgi?id=54444

        No new tests at this time. I will add some tests later, but since multiple
        people are hitting this I wanted to get it in as quickly as possible.

        * platform/text/TextCodecUTF16.cpp:
        (WebCore::TextCodecUTF16::decode): Tweaked coding style quite a bit.
        Removed special case for zero length now that main code handles it
        correctly. Used words instead of abbreviations for local variable names.
        Added error handling for a trailing byte.

        * platform/text/TextCodecUTF8.cpp:
        (WebCore::TextCodecUTF8::consumePartialSequenceByte): Added. Helper function
        to make the handleError and handlePartialSequence functions clearer.
        (WebCore::TextCodecUTF8::handleError): Added. Helper function to make the
        handlePartialSequence clearer.
        (WebCore::TextCodecUTF8::handlePartialSequence): Added. Factored out code for
        the partial sequence case. Making this a separate function probably helps make
        the fast case a little faster. This new version handles more cases correctly,
        which is what fixes the crashes we were seeing. In particular, it no longer
        assumes that the partial sequence is truly partial, because there are cases
        where we end up handling complete sequences here, such as when a complete
        sequence is inside a malformed partial sequence.
        (WebCore::TextCodecUTF8::decode): Removed partial sequence code and made this
        call handlePartialSequence instead. Could be streamlined if we double checked
        that passing a reference to "destination" and "source" doesn't harm code
        generation too much, so perhaps someone can do that research on a few compilers
        later and clean this up. Removed special case for zero length now that the
        main code handles that correctly.

        * platform/text/TextCodecUTF8.h: Added declarations for new functions.
        Made partial sequence buffer large enough to hold a whole sequence so we can
        use it to complete and decode a sequence in place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 23 Feb 2011 19:42:28 +0000 (19:42 +0000)]
2011-02-23  Abhishek Arya  <inferno@chromium.org>

        Unreviewed. Qt rebaseline for my crasher test in r79462.

        * platform/qt/fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 23 Feb 2011 19:17:35 +0000 (19:17 +0000)]
2011-02-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Race condition when creating and destroying pages quickly
        https://bugs.webkit.org/show_bug.cgi?id=55061
        <rdar://problem/8708435>

        When the last page in a web process is closed, the web process would
        previously terminate, even if the UI process had created a new page
        (the CreateNewPage message just wouldn't have reached the web process yet).

        Fix this by adding a ShouldTerminate message that the web process sends when it's
        about to terminate. If the UI process has any pending pages, downloads etc. it will
        prevent the web process from terminating. Otherwise, it will immmediately disconnect
        the WebPageProxy so that creating a page after that will launch a new web process.

        * UIProcess/Plugins/WebPluginSiteDataManager.cpp:
        (WebKit::WebPluginSiteDataManager::shouldTerminate):
        * UIProcess/Plugins/WebPluginSiteDataManager.h:
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::shouldTerminate):
        (WebKit::WebContext::disconnectProcess):
        * UIProcess/WebContext.h:
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::disconnect):
        (WebKit::WebProcessProxy::didReceiveSyncMessage):
        (WebKit::WebProcessProxy::didClose):
        (WebKit::WebProcessProxy::shouldTerminate):
        * UIProcess/WebProcessProxy.h:
        * UIProcess/WebProcessProxy.messages.in:
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::terminateIfPossible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Alexis Menard <alexis.menard@openbossa.org>
commit-queue@webkit.org [Wed, 23 Feb 2011 19:03:32 +0000 (19:03 +0000)]
2011-02-23  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Ariya Hidayat.

        [Qt] tst_QWebView::setPalette(activeFG) fails
        https://bugs.webkit.org/show_bug.cgi?id=55029

        Attempt to make the test more robust. By investigating with the bot virtual machine
        I discovered that the activation can take some time. In this patch we make sure that
        the active window we want to have is the same as the QApplication.

        * tests/qwebview/tst_qwebview.cpp:
        (tst_QWebView::setPalette):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 23 Feb 2011 19:03:05 +0000 (19:03 +0000)]
2011-02-23  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Rename a layouttest for conformity. Tests that we do not crash
        when trying to overflow the logical height of a root inline box.
        https://bugs.webkit.org/show_bug.cgi?id=54995

        * fast/overflow/overflow-block-logical-height-crash-expected.txt: Removed.
        * fast/overflow/overflow-block-logical-height-crash.html: Removed.
        * fast/overflow/overflow-height-float-not-removed-crash2-expected.txt: Added.
        * fast/overflow/overflow-height-float-not-removed-crash2.html: Added.
        * fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: Added.
        * fast/overflow/overflow-height-float-not-removed-crash3.html: Added.
2011-02-23  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Make clear float lineboxes resilient against overflows.
        https://bugs.webkit.org/show_bug.cgi?id=54995

        We try to dirty everthing in block range if we have a negative
        logical bottom, or if our logical bottom is less than our logical
        top, or if our logical top is equal to INT_MAX. Plus, we also dirty
        a linebox if its block logical height is less than zero.
        Tests: fast/overflow/overflow-height-float-not-removed-crash2.html
               fast/overflow/overflow-height-float-not-removed-crash3.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeFloatingObject):
        (WebCore::RenderBlock::markLinesDirtyInBlockRange):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::alignBoxesInBlockDirection): remove the hack
        added in r69735. we don't need this anymore since we are making the
        underlying float dirty logic resilient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInclude frame numbers in backtraces.
mitz@apple.com [Wed, 23 Feb 2011 19:01:34 +0000 (19:01 +0000)]
Include frame numbers in backtraces.
https://bugs.webkit.org/show_bug.cgi?id=55060

Reviewed by Gavin Barraclough.

* wtf/Assertions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 23 Feb 2011 18:55:29 +0000 (18:55 +0000)]
2011-02-23  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gavin Barraclough.

        latest jsc for armv7 crashes in sunspider tests
        https://bugs.webkit.org/show_bug.cgi?id=54667

        Update JIT offset values in ARMv7 after r78732. Fixes crashes in
        SunSpider and JavaScript tests.

        * jit/JIT.h: update values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWKBundleNavigationAction.h should be exposed as a public header
mthole@apple.com [Wed, 23 Feb 2011 18:50:16 +0000 (18:50 +0000)]
WKBundleNavigationAction.h should be exposed as a public header
https://bugs.webkit.org/show_bug.cgi?id=55059

Reviewed by Darin Adler.

* WebKit2.xcodeproj/project.pbxproj:
Changed WKBundleNavigationAction.h from 'project' to 'public'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Wed, 23 Feb 2011 18:34:53 +0000 (18:34 +0000)]
2011-02-23  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Each layout test should use a separate DB
        https://bugs.webkit.org/show_bug.cgi?id=55042

        Each layout test should use a separate database to avoid problems in
        case tests are run concurrently.

        * storage/indexeddb/basics-expected.txt:
        * storage/indexeddb/basics.html:
        * storage/indexeddb/create-and-remove-object-store-expected.txt:
        * storage/indexeddb/create-and-remove-object-store.html:
        * storage/indexeddb/create-object-store-options-expected.txt:
        * storage/indexeddb/create-object-store-options.html:
        * storage/indexeddb/cursor-delete-expected.txt:
        * storage/indexeddb/cursor-delete.html:
        * storage/indexeddb/cursor-index-delete-expected.txt:
        * storage/indexeddb/cursor-index-delete.html:
        * storage/indexeddb/cursor-skip-deleted-expected.txt:
        * storage/indexeddb/cursor-skip-deleted.html:
        * storage/indexeddb/cursor-update-expected.txt:
        * storage/indexeddb/cursor-update.html:
        * storage/indexeddb/data-corruption-expected.txt:
        * storage/indexeddb/data-corruption.html:
        * storage/indexeddb/database-basics-expected.txt:
        * storage/indexeddb/database-basics.html:
        * storage/indexeddb/database-quota-expected.txt:
        * storage/indexeddb/database-quota.html:
        * storage/indexeddb/duplicates-expected.txt:
        * storage/indexeddb/duplicates.html:
        * storage/indexeddb/error-causes-abort-by-default-expected.txt:
        * storage/indexeddb/error-causes-abort-by-default.html:
        * storage/indexeddb/exception-in-event-aborts-expected.txt:
        * storage/indexeddb/exception-in-event-aborts.html:
        * storage/indexeddb/index-basics-expected.txt:
        * storage/indexeddb/index-basics.html:
        * storage/indexeddb/index-cursor-expected.txt:
        * storage/indexeddb/index-cursor.html:
        * storage/indexeddb/objectstore-autoincrement-expected.txt:
        * storage/indexeddb/objectstore-autoincrement.html:
        * storage/indexeddb/objectstore-basics-expected.txt:
        * storage/indexeddb/objectstore-basics.html:
        * storage/indexeddb/objectstore-clear-expected.txt:
        * storage/indexeddb/objectstore-clear.html:
        * storage/indexeddb/objectstore-cursor-expected.txt:
        * storage/indexeddb/objectstore-cursor.html:
        * storage/indexeddb/objectstore-removeobjectstore-expected.txt:
        * storage/indexeddb/objectstore-removeobjectstore.html:
        * storage/indexeddb/open-cursor-expected.txt:
        * storage/indexeddb/open-cursor.html:
        * storage/indexeddb/queued-commands-expected.txt:
        * storage/indexeddb/queued-commands.html:
        * storage/indexeddb/request-event-propagation-expected.txt:
        * storage/indexeddb/request-event-propagation.html:
        * storage/indexeddb/set_version_blocked-expected.txt:
        * storage/indexeddb/set_version_blocked.html:
        * storage/indexeddb/set_version_queue-expected.txt:
        * storage/indexeddb/set_version_queue.html:
        * storage/indexeddb/transaction-after-close-expected.txt:
        * storage/indexeddb/transaction-after-close.html:
        * storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
        * storage/indexeddb/transaction-and-objectstore-calls.html:
        * storage/indexeddb/transaction-basics-expected.txt:
        * storage/indexeddb/transaction-basics.html:
        * storage/indexeddb/transaction-crash-on-abort-expected.txt:
        * storage/indexeddb/transaction-crash-on-abort.html:
        * storage/indexeddb/transaction-event-propagation-expected.txt:
        * storage/indexeddb/transaction-event-propagation.html:
        * storage/indexeddb/transaction-read-only-expected.txt:
        * storage/indexeddb/transaction-read-only.html:
        * storage/indexeddb/tutorial.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 23 Feb 2011 18:26:59 +0000 (18:26 +0000)]
2011-02-23  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update. Add final set of
        Snow Leopard-only failures.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 23 Feb 2011 18:14:52 +0000 (18:14 +0000)]
2011-02-23  Kenneth Russell  <kbr@google.com>

        Unreviewed, rolling out r79387.
        https://bugs.webkit.org/show_bug.cgi?id=54885

        Reapply the code changes from r79038 since they weren't the root
        cause of the test timeouts.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::reset):
2011-02-23  Kenneth Russell  <kbr@google.com>

        Unreviewed, rolling out r79387.
        https://bugs.webkit.org/show_bug.cgi?id=54885

        Reapply the code changes from r79038 since they weren't the root
        cause of the test timeouts.

        * src/WebKit.cpp:
        (WebKit::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 23 Feb 2011 18:00:09 +0000 (18:00 +0000)]
2011-02-22  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Per-page minimum DOMTimer interval broken for repeating timers
        https://bugs.webkit.org/show_bug.cgi?id=55014

        When the minimum timer interval is adjusted, if the timer is
        repeating, cause its repeat interval to be set to its original
        timeout clamped to the new minimum interval.

        Tests: fast/dom/timer-increase-min-interval-repeating.html
               fast/dom/timer-increase-then-decrease-min-interval-repeating.html

        * page/DOMTimer.cpp:
        (WebCore::DOMTimer::adjustMinimumTimerInterval):
2011-02-23  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Per-page minimum DOMTimer interval broken for repeating timers
        https://bugs.webkit.org/show_bug.cgi?id=55014

        Add tests using setInterval rather than setTimeout.
        timer-increase-then-decrease-min-interval-repeating.html catches
        the bug.

        * fast/dom/timer-increase-min-interval-repeating-expected.txt: Added.
        * fast/dom/timer-increase-min-interval-repeating.html: Added.
        * fast/dom/timer-increase-then-decrease-min-interval-repeating-expected.txt: Added.
        * fast/dom/timer-increase-then-decrease-min-interval-repeating.html: Added.
        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows 7 Release Tests] ~26 tests failing after r78846
jberlin@webkit.org [Wed, 23 Feb 2011 17:43:26 +0000 (17:43 +0000)]
[Windows 7 Release Tests] ~26 tests failing after r78846
https://bugs.webkit.org/show_bug.cgi?id=54748

Update the pixel results for fast/blockflow/Kusa-Makura-background-canvas.html.
The pixel results for fast/ruby/nested-ruby.html turned out to be identical to
those before r78846. Unreviewed.

* platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
* platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 23 Feb 2011 17:38:20 +0000 (17:38 +0000)]
2011-02-23  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update. Mark failures from bug 54885
        as being Leopard-only (which they are) so that they don't result in
        duplicates with all the Snow Leopard expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 23 Feb 2011 17:27:58 +0000 (17:27 +0000)]
2011-02-23  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update. Add more Snow Leopard-only
        failures.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix two issues seen in WebKit2 views on Mac:
mitz@apple.com [Wed, 23 Feb 2011 17:10:33 +0000 (17:10 +0000)]
Fix two issues seen in WebKit2 views on Mac:
- <rdar://problem/8867831> WebKit2: Insertion points in form fields no longer blink
- <rdar://problem/8950362> REGRESSION (WebKit2): Cannot deselect text

Reviewed by Maciej Stachowiak.

* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler): Initialize m_activationEventNumber
to -1. Since WebKit2 doesn't support non-activating clicks yet (<http://webkit.org/b/55053>
<rdar://problem/9042197>) and doesn't send event numbers, all events were considered to be
window-activating events. This in turn prevented them from clearing the selection and resuming
caret blinking on mouse up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Alexis Menard <alexis.menard@openbossa.org>
commit-queue@webkit.org [Wed, 23 Feb 2011 17:07:31 +0000 (17:07 +0000)]
2011-02-23  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Dan Bernstein.

        [Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
        http://trac.webkit.org/changeset/79167 refactored the way the bound size of
        the frame is handled. A new API setBoundsSize was added, we need to call it
        in addition to setFrameRect. I could call setBoundSize after setFrameRect but
        I thought It would be more elegant to use the resize method.

        * Api/qwebpage.cpp:
        (QWebPage::setViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Jacob Dinu <dinu.jacob@nokia.com>
commit-queue@webkit.org [Wed, 23 Feb 2011 16:38:05 +0000 (16:38 +0000)]
2011-02-23  Jacob Dinu  <dinu.jacob@nokia.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Linking error for some InspectorController symbols
        https://bugs.webkit.org/show_bug.cgi?id=54953

        Moved out hideHighlight definition from under JAVASCRIPT_DEBUGGER flag

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::hideHighlight):
        (WebCore::InspectorController::resume):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 23 Feb 2011 16:30:11 +0000 (16:30 +0000)]
2011-02-23  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update. Add more Snow Leopard-only
        failures.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 23 Feb 2011 16:14:17 +0000 (16:14 +0000)]
2011-02-23  MORITA Hajime  <morrita@google.com>

        Unreviewed test_expectations.txt update.

        Added TIMEOUTs that the last change missed.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Siddharth Mathur <siddharth.mathur@nokia.com>
laszlo.1.gombos@nokia.com [Wed, 23 Feb 2011 15:41:14 +0000 (15:41 +0000)]
2011-02-23  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Make sure Symbian binary UIDs are unique

        * WebProcess.pro: Resolve the UID collision with QtTestBrowser.pro
        by changing the UID.

2011-02-23  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Make sure Symbian binary UIDs are unique

        * MiniBrowser/qt/MiniBrowser.pro: Resolve the UID collision with
        QtTestBrowser.pro by changing the UID.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Wed, 23 Feb 2011 15:10:43 +0000 (15:10 +0000)]
2011-02-23  Hans Wennborg  <hans@chromium.org>

        IndexedDB: Move some SQL code into IDBBackingStore
        https://bugs.webkit.org/show_bug.cgi?id=54889

        The idea is to gather all the SQL logic into IDBBackingStore.

        No new functionality, so no new tests.

        * storage/IDBBackingStore.cpp:
        (WebCore::IDBBackingStore::IDBBackingStore):
        (WebCore::runCommands):
        (WebCore::createTables):
        (WebCore::createMetaDataTable):
        (WebCore::getDatabaseSchemaVersion):
        (WebCore::migrateDatabase):
        (WebCore::IDBBackingStore::open):
        (WebCore::IDBBackingStore::extractIDBDatabaseMetaData):
        (WebCore::IDBBackingStore::setIDBDatabaseMetaData):
        (WebCore::IDBBackingStore::getObjectStores):
        (WebCore::IDBBackingStore::createObjectStore):
        (WebCore::doDelete):
        (WebCore::IDBBackingStore::deleteObjectStore):
        (WebCore::whereSyntaxForKey):
        (WebCore::bindKeyToQuery):
        (WebCore::IDBBackingStore::getObjectStoreRecord):
        (WebCore::bindKeyToQueryWithNulls):
        (WebCore::IDBBackingStore::putObjectStoreRecord):
        (WebCore::IDBBackingStore::deleteIndexDataForRecord):
        (WebCore::IDBBackingStore::putIndexDataForRecord):
        (WebCore::IDBBackingStore::createIndex):
        (WebCore::IDBBackingStore::deleteIndex):
        (WebCore::IDBBackingStore::clearObjectStore):
        * storage/IDBBackingStore.h:
        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
        (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
        (WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
        (WebCore::IDBDatabaseBackendImpl::setVersionInternal):
        (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl):
        (WebCore::IDBFactoryBackendImpl::addIDBBackingStore):
        (WebCore::IDBFactoryBackendImpl::removeIDBBackingStore):
        (WebCore::IDBFactoryBackendImpl::open):
        * storage/IDBFactoryBackendImpl.h:
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::getInternal):
        (WebCore::IDBObjectStoreBackendImpl::putInternal):
        (WebCore::IDBObjectStoreBackendImpl::clearInternal):
        (WebCore::populateIndex):
        (WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
        (WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 23 Feb 2011 14:48:16 +0000 (14:48 +0000)]
2011-02-23 MORITA Hajime  <morrita@google.com>

        Unreviewed test_expectations.txt update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue@webkit.org [Wed, 23 Feb 2011 14:46:31 +0000 (14:46 +0000)]
2011-02-23  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Fix the Symbian build after r79334
        https://bugs.webkit.org/show_bug.cgi?id=55044

        No new tests as there is no new functionality.

        * WebCore.pri: Reorder symbian blocks to make sure that
        system-sqlite is set before it is tested.

        Copy the rules from JavaScriptCore.pri for defineTest().
2011-02-23  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Fix the Symbian build after r79334
        https://bugs.webkit.org/show_bug.cgi?id=55044

        * WebKit2.pri: Copy the rules from JavaScriptCore.pri for
        defineTest().

        Remove addWebKit2LibWholeArchive as it is no longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Sheriff Bot <webkit.review.bot@gmail.com>
morrita@google.com [Wed, 23 Feb 2011 14:40:47 +0000 (14:40 +0000)]
2011-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79418.
        http://trac.webkit.org/changeset/79418
        https://bugs.webkit.org/show_bug.cgi?id=55043

        "breaks shlib linux build" (Requested by morrita on #webkit).

        * JavaScriptCore.gyp/JavaScriptCore.gyp:
        * JavaScriptCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 23 Feb 2011 14:05:35 +0000 (14:05 +0000)]
2011-02-23  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Use AtomicString::fromUTF8 instead of String::fromUTF8 for AtomicStrings
        https://bugs.webkit.org/show_bug.cgi?id=54992

        * websockets/WebSocketHandshake.cpp:
        (WebCore::WebSocketHandshake::readHTTPHeaders):
2011-02-23  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Use AtomicString::fromUTF8 instead of String::fromUTF8 for AtomicStrings
        https://bugs.webkit.org/show_bug.cgi?id=54992

        Also remove the WTF namespace from AtomicString and String.

        * ewk/ewk_view.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 23 Feb 2011 14:00:11 +0000 (14:00 +0000)]
2011-02-23  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, fixed GTK WebKit2 compilation after r79366.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 23 Feb 2011 13:32:19 +0000 (13:32 +0000)]
2011-02-23  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Move platform dependent files out of main CMakeLists.txt
        https://bugs.webkit.org/show_bug.cgi?id=53891

        Apple Windows port does not use the image decoders,
        so move them into the platform specific CMake files.

        * CMakeLists.txt:
        * CMakeListsEfl.txt:
        * CMakeListsWinCE.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-23 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 23 Feb 2011 12:31:27 +0000 (12:31 +0000)]
2011-02-23 MORITA Hajime <morrita@google.com>

        Unreviewed test_expectations.txt update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79438 268f45cc-cd09-0410-ab3c-d52691b4dbfc