WebKit-https.git
8 years ago[WK2] Anchor elements doesn't get focus on TAB key press.
commit-queue@webkit.org [Fri, 2 Sep 2011 14:09:27 +0000 (14:09 +0000)]
[WK2] Anchor elements doesn't get focus on TAB key press.
https://bugs.webkit.org/show_bug.cgi?id=66949

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-02
Reviewed by Adam Roben.

Setting the default property value of TabsToLinks to true
only for GTK platform since Win & Mac platforms doesn't want
it to be set to true by default.

* Shared/WebPreferencesStore.h:
Set the default value of key TabsToLinks to true for GTK platform only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] 4 tests are failing, skip them
zoltan@webkit.org [Fri, 2 Sep 2011 14:05:43 +0000 (14:05 +0000)]
[Qt][WK2] 4 tests are failing, skip them
https://bugs.webkit.org/show_bug.cgi?id=67485

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-02

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed test fix.
dominicc@chromium.org [Fri, 2 Sep 2011 14:02:57 +0000 (14:02 +0000)]
Unreviewed test fix.

Sadly window-property-descriptors enumerates functions in the test
harness. r94362 added a couple of functions, so these results need
to be updated.

* fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix after r67110.
leandro@webkit.org [Fri, 2 Sep 2011 13:22:45 +0000 (13:22 +0000)]
Unreviewed build fix after r67110.

* ewk/ewk_view.cpp:
(ewk_view_need_touch_events_get): Make the function signature match
its declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Two tests are passing after r94324. They are unskipped:
reni@webkit.org [Fri, 2 Sep 2011 13:09:02 +0000 (13:09 +0000)]
[Qt] Two tests are passing after r94324. They are unskipped:
fast/events/document-elementFromPoint.html
plugins/mouse-events-fixedpos.html

Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, update test expectations.
apavlov@chromium.org [Fri, 2 Sep 2011 12:46:47 +0000 (12:46 +0000)]
[Chromium] Unreviewed, update test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Cannot gathering glyph page statistics
kbalazs@webkit.org [Fri, 2 Sep 2011 12:35:46 +0000 (12:35 +0000)]
[Qt][WK2] Cannot gathering glyph page statistics
https://bugs.webkit.org/show_bug.cgi?id=67475

Rubber stamped by Csaba Osztrogonác.

Fix Qt WK2 build without having QRAWFONT.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getWebCoreStatistics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Make it more clear when requests are loaded from cache on network...
vsevik@chromium.org [Fri, 2 Sep 2011 11:49:36 +0000 (11:49 +0000)]
Web Inspector: Make it more clear when requests are loaded from cache on network panel.
https://bugs.webkit.org/show_bug.cgi?id=67396

Reviewed by Pavel Feldman.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
* inspector/front-end/ResourceHeadersView.js:
(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
* inspector/front-end/networkPanel.css:
(.resource-headers-view .outline-disclosure li .status-from-cache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Should remove resource highlight on sort/filter in network panel.
vsevik@chromium.org [Fri, 2 Sep 2011 11:41:55 +0000 (11:41 +0000)]
Web Inspector: Should remove resource highlight on sort/filter in network panel.
https://bugs.webkit.org/show_bug.cgi?id=67411

Reviewed by Pavel Feldman.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._sortItems):
(WebInspector.NetworkLogView.prototype._sortByTimeline):
(WebInspector.NetworkLogView.prototype._updateFilter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Network: jump to initiator's record in case of redirect
vsevik@chromium.org [Fri, 2 Sep 2011 11:39:00 +0000 (11:39 +0000)]
Web Inspector: Network: jump to initiator's record in case of redirect
https://bugs.webkit.org/show_bug.cgi?id=67367

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get redirectSource):
(WebInspector.Resource.prototype.set redirectSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Build dependency problems
ossy@webkit.org [Fri, 2 Sep 2011 11:36:40 +0000 (11:36 +0000)]
[Qt] Build dependency problems
https://bugs.webkit.org/show_bug.cgi?id=38054

Trivial fix after r94288.

Rubber-stamped by Andras Becsi.

* Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
(buildQMakeProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize recalcStyle()
antti@apple.com [Fri, 2 Sep 2011 11:19:35 +0000 (11:19 +0000)]
De-virtualize recalcStyle()
https://bugs.webkit.org/show_bug.cgi?id=67378

Reviewed by Dimitri Glazkov.

Element::recalcStyle() does not need to be virtual, there are very few legit overrides. This will
also make it possible to de-recursify it later.

Added willRecalcStyle()/didRecalcStyle() virtual function for subclasses that need custom style recalc.
These are only invoked if hasCustomWillOrDidRecalcStyle() bit is set.

* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::recalcStyle):
* dom/Element.h:
(WebCore::Element::willRecalcStyle):
(WebCore::Element::didRecalcStyle):
* dom/Node.h:
(WebCore::Node::hasCustomWillOrDidRecalcStyle):
(WebCore::Node::setHasCustomWillOrDidRecalcStyle):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::recalcShadowTreeStyle):
* dom/ShadowRoot.h:
* dom/Text.cpp:
(WebCore::Text::recalcTextStyle):
* dom/Text.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::didRecalcStyle):
* html/HTMLFormControlElement.h:
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
(WebCore::HTMLFrameSetElement::willRecalcStyle):
* html/HTMLFrameSetElement.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::didRecalcStyle):
* html/HTMLMediaElement.h:
* html/HTMLNoScriptElement.cpp:
(WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
(WebCore::HTMLNoScriptElement::willRecalcStyle):
* html/HTMLNoScriptElement.h:
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::willRecalcStyle):
* html/HTMLPlugInImageElement.h:
* html/HTMLSelectElement.cpp:
* html/HTMLSelectElement.h:
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::SVGTRefElement):
(WebCore::SVGShadowText::willRecalcStyle):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::didRecalcStyle):
* svg/SVGUseElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebSocket: Send Blob as WebSocket binary message
yutak@chromium.org [Fri, 2 Sep 2011 11:16:40 +0000 (11:16 +0000)]
WebSocket: Send Blob as WebSocket binary message
https://bugs.webkit.org/show_bug.cgi?id=67465

Reviewed by Kent Tamura.

Re-lands r94399 with a fix for Leopard builds.

Source/WebCore:

* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::send):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::sendCallback):
* websockets/ThreadableWebSocketChannel.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
* websockets/WebSocket.h:
* websockets/WebSocket.idl:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
* websockets/WebSocketChannel.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendBlob):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
* websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

* http/tests/websocket/tests/hixie76/send-empty-expected.txt: Added.
* http/tests/websocket/tests/hixie76/send-empty.html: Added.
* http/tests/websocket/tests/hixie76/send-object-expected.txt: Added.
* http/tests/websocket/tests/hixie76/send-object.html: Added.
* http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
* http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
* http/tests/websocket/tests/hybi/send-blob-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-blob.html: Added.
* http/tests/websocket/tests/hybi/send-blob_wsh.py: Added.
* http/tests/websocket/tests/hybi/send-empty-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-empty.html: Added.
* http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-file-blob-fail.html: Added.
* http/tests/websocket/tests/hybi/send-file-blob.html: Added.
* http/tests/websocket/tests/hybi/send-file-blob_wsh.py: Added.
* http/tests/websocket/tests/hybi/workers/resources/send-blob.js: Added.
* http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py: Added.
* http/tests/websocket/tests/hybi/workers/send-blob-expected.txt: Added.
* http/tests/websocket/tests/hybi/workers/send-blob.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Generate gobject bindings for Notification and NotificationCenter
paroga@webkit.org [Fri, 2 Sep 2011 11:10:49 +0000 (11:10 +0000)]
[GTK] Generate gobject bindings for Notification and NotificationCenter
https://bugs.webkit.org/show_bug.cgi?id=67380

Reviewed by Philippe Normand.

* bindings/gobject/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] editing/selection/regional-indicators.html timing out on Linux
bashi@chromium.org [Fri, 2 Sep 2011 10:54:05 +0000 (10:54 +0000)]
[chromium] editing/selection/regional-indicators.html timing out on Linux
https://bugs.webkit.org/show_bug.cgi?id=66510

Reviewed by Kent Tamura.

Source/WebCore:

Uses SurrogatePairAwareTextIerator in ComplexTextControllerLinux to handle surrogate pairs correctly.

No new tests. editing/selection/regional-indicators.html should pass with this patch.

* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::nextScriptRun): Used SurrogatePairAwareTextIterator to split run.
(WebCore::surrogatePairAwareFirstCharacter): Added.
(WebCore::ComplexTextController::setupFontForScriptRun): Used surrogatePairAwareFirstCharacter() to get appropriate FontData.

LayoutTests:

ComplexTextControllerLinux is now surrogate pairs aware, therefore;
- editing/selection/regional-indicators.html should pass.
- editing/deleting/regional-indicators.html should not timeout.
- fast/text/regional-indicator-symbols.html should pass.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94399.
commit-queue@webkit.org [Fri, 2 Sep 2011 10:51:49 +0000 (10:51 +0000)]
Unreviewed, rolling out r94399.
http://trac.webkit.org/changeset/94399
https://bugs.webkit.org/show_bug.cgi?id=67471

Broke Leopard build (Requested by yutak on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

Source/WebCore:

* bindings/js/JSWebSocketCustom.cpp:
* bindings/v8/custom/V8WebSocketCustom.cpp:
* websockets/ThreadableWebSocketChannel.h:
* websockets/WebSocket.cpp:
* websockets/WebSocket.h:
* websockets/WebSocket.idl:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
* websockets/WebSocketChannel.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
* websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

* http/tests/websocket/tests/hixie76/send-empty-expected.txt: Removed.
* http/tests/websocket/tests/hixie76/send-empty.html: Removed.
* http/tests/websocket/tests/hixie76/send-object-expected.txt: Removed.
* http/tests/websocket/tests/hixie76/send-object.html: Removed.
* http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
* http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
* http/tests/websocket/tests/hybi/send-blob-expected.txt: Removed.
* http/tests/websocket/tests/hybi/send-blob.html: Removed.
* http/tests/websocket/tests/hybi/send-blob_wsh.py: Removed.
* http/tests/websocket/tests/hybi/send-empty-expected.txt: Removed.
* http/tests/websocket/tests/hybi/send-empty.html: Removed.
* http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Removed.
* http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Removed.
* http/tests/websocket/tests/hybi/send-file-blob-fail.html: Removed.
* http/tests/websocket/tests/hybi/send-file-blob.html: Removed.
* http/tests/websocket/tests/hybi/send-file-blob_wsh.py: Removed.
* http/tests/websocket/tests/hybi/workers/resources/send-blob.js: Removed.
* http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py: Removed.
* http/tests/websocket/tests/hybi/workers/send-blob-expected.txt: Removed.
* http/tests/websocket/tests/hybi/workers/send-blob.html: Removed.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94393.
commit-queue@webkit.org [Fri, 2 Sep 2011 10:40:18 +0000 (10:40 +0000)]
Unreviewed, rolling out r94393.
http://trac.webkit.org/changeset/94393
https://bugs.webkit.org/show_bug.cgi?id=67470

It broke Qt-SL build (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Webfonts display bold in Windows
bashi@chromium.org [Fri, 2 Sep 2011 10:38:57 +0000 (10:38 +0000)]
[Chromium] Webfonts display bold in Windows
https://bugs.webkit.org/show_bug.cgi?id=67387

Uses font's default weight for webfonts by setting FW_DONTCARE.

Reviewed by Kent Tamura.

No new tests. We don't have fonts to test this change.

* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Sets FW_DONTCARE to use default font weight.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebSocket: Send Blob as WebSocket binary message
yutak@chromium.org [Fri, 2 Sep 2011 10:36:43 +0000 (10:36 +0000)]
WebSocket: Send Blob as WebSocket binary message
https://bugs.webkit.org/show_bug.cgi?id=67465

Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hixie76/send-empty.html
       http/tests/websocket/tests/hixie76/send-object.html
       http/tests/websocket/tests/hybi/send-blob.html
       http/tests/websocket/tests/hybi/send-empty.html
       http/tests/websocket/tests/hybi/send-file-blob-fail.html
       http/tests/websocket/tests/hybi/send-file-blob.html
       http/tests/websocket/tests/hybi/workers/send-blob.html
       http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)

* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::send):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::sendCallback):
* websockets/ThreadableWebSocketChannel.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
* websockets/WebSocket.h:
* websockets/WebSocket.idl:
Fixing code generator did not sound easy, because there are some classes depending on
broken behavior of current code generator (one such example is CanvasRenderingContext2D).
As a temporary workaround, new custom handlers for send() are added.
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
* websockets/WebSocketChannel.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendBlob):
A Blob can be deserialized from url, type and size.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
KURL, String and long long (corresponding to url, type and size, respectively) can be passed
safely across threads.
* websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

* http/tests/websocket/tests/hixie76/send-empty-expected.txt: Added.
* http/tests/websocket/tests/hixie76/send-empty.html: Added.
* http/tests/websocket/tests/hixie76/send-object-expected.txt: Added.
* http/tests/websocket/tests/hixie76/send-object.html: Added.
* http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
* http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
Updated. Added tests to send Blobs.
* http/tests/websocket/tests/hybi/send-blob-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-blob.html:
Added. Send three Blobs each of which contains a small binary message.
* http/tests/websocket/tests/hybi/send-blob_wsh.py:
Added. receive_message() returns a unicode value if the received message was text, or
a str value if the message was binary.
* http/tests/websocket/tests/hybi/send-empty-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-empty.html: Added.
* http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-file-blob-fail.html:
Added. If we delete a file before reading it, FileReaderLoader reliably fails.
* http/tests/websocket/tests/hybi/send-file-blob.html:
Added. Create a File and try to send it as a Blob.
* http/tests/websocket/tests/hybi/send-file-blob_wsh.py: Added.
* http/tests/websocket/tests/hybi/workers/resources/send-blob.js:
Added. Same as send-blob.html above.
* http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py:
Added. Same as send-blob_wsh.py above.
* http/tests/websocket/tests/hybi/workers/send-blob-expected.txt: Added.
* http/tests/websocket/tests/hybi/workers/send-blob.html: Added.
* platform/gtk/Skipped:
send-file-blob.html and send-file-blob-fail.html depend on availability of File API.
* platform/mac/Skipped: Ditto.
* platform/qt/Skipped: Ditto.
* platform/win/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/67467> WebProcessProxy::secItemCopyMatching / WebProcessProxy...
mrowe@apple.com [Fri, 2 Sep 2011 10:21:56 +0000 (10:21 +0000)]
<webkit.org/b/67467> WebProcessProxy::secItemCopyMatching / WebProcessProxy::secItemAdd
leak the results of the APIs they wrap.

Reviewed by Dan Bernstein.

* UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::secItemCopyMatching): Adopt the result of SecItemCopyMatching in to a
RetainPtr to ensure it gets released at the appropriate time.
(WebKit::WebProcessProxy::secItemAdd): Ditto for SecItemAdd.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebAudio] Undeclared dependency to VIDEO
philn@webkit.org [Fri, 2 Sep 2011 09:58:12 +0000 (09:58 +0000)]
[WebAudio] Undeclared dependency to VIDEO
https://bugs.webkit.org/show_bug.cgi?id=66893

Reviewed by Kenneth Russell.

Build MediaAudioSourceNode only if VIDEO is enabled

* webaudio/AudioContext.cpp:
* webaudio/AudioContext.h:
* webaudio/AudioContext.idl:
* webaudio/MediaElementAudioSourceNode.cpp:
* webaudio/MediaElementAudioSourceNode.h:
* webaudio/MediaElementAudioSourceNode.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove my old e-mail address and add my new one.
abecsi@webkit.org [Fri, 2 Sep 2011 09:53:58 +0000 (09:53 +0000)]
Remove my old e-mail address and add my new one.

Rubber-stamped by Tor Arne Vestbø.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline after r94304.
philn@webkit.org [Fri, 2 Sep 2011 09:09:28 +0000 (09:09 +0000)]
Unreviewed, GTK rebaseline after r94304.

* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Update Qt specific expected files after r94304.
reni@webkit.org [Fri, 2 Sep 2011 08:49:24 +0000 (08:49 +0000)]
[Qt] Update Qt specific expected files after r94304.

Unreviewed gardening.

* platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.png:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Unreviewed speculative buildfix.
ossy@webkit.org [Fri, 2 Sep 2011 08:26:19 +0000 (08:26 +0000)]
[Qt][WK2] Unreviewed speculative buildfix.

* WebCore.pro: Add platform/graphics/GlyphPageTreeNode.cpp to SOURCES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Add Qt expecteds for new tests.
reni@webkit.org [Fri, 2 Sep 2011 08:25:12 +0000 (08:25 +0000)]
[Qt] Add Qt expecteds for new tests.

Unreviewed gardening.

* platform/qt/fast/borders/border-image-slices-expected.png: Added.
* platform/qt/fast/borders/border-image-slices-expected.txt: Added.
* platform/qt/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/qt/svg/custom/pattern-rotate-gaps-expected.png: Added.
* platform/qt/svg/custom/pattern-rotate-gaps-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94389.
commit-queue@webkit.org [Fri, 2 Sep 2011 07:58:05 +0000 (07:58 +0000)]
Unreviewed, rolling out r94389.
http://trac.webkit.org/changeset/94389
https://bugs.webkit.org/show_bug.cgi?id=67468

breaks mac build (Requested by philn-tp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

* webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaElementSource):
* webaudio/AudioContext.h:
* webaudio/AudioContext.idl:
* webaudio/MediaElementAudioSourceNode.cpp:
* webaudio/MediaElementAudioSourceNode.h:
* webaudio/MediaElementAudioSourceNode.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGenerate an EventSource constructor of V8 using the IDL 'Constructor' extended attribute
commit-queue@webkit.org [Fri, 2 Sep 2011 07:41:41 +0000 (07:41 +0000)]
Generate an EventSource constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67459

Patch by Kentaro Hara <haraken@google.com> on 2011-09-02
Reviewed by Adam Barth.

Tests: fast/eventsource/eventsource-constructor.html
       fast/eventsource/eventsource-attribute-listeners.html

* WebCore.gypi: Removed V8EventSourceConstructor.cpp.
* WebCore.pro: Removed V8EventSourceConstructor.cpp.
* bindings/v8/custom/V8EventSourceConstructor.cpp: Removed.
* page/EventSource.idl: Added the 'Constructor' extended attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebAudio] Undeclared dependency to VIDEO
philn@webkit.org [Fri, 2 Sep 2011 07:35:13 +0000 (07:35 +0000)]
[WebAudio] Undeclared dependency to VIDEO
https://bugs.webkit.org/show_bug.cgi?id=66893

Reviewed by Kenneth Russell.

Build MediaAudioSourceNode only if VIDEO is enabled

* webaudio/AudioContext.cpp:
* webaudio/AudioContext.h:
* webaudio/AudioContext.idl:
* webaudio/MediaElementAudioSourceNode.cpp:
* webaudio/MediaElementAudioSourceNode.h:
* webaudio/MediaElementAudioSourceNode.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago [GTK] run-gtk-tests leaves a zombie Xvfb process
philn@webkit.org [Fri, 2 Sep 2011 07:32:26 +0000 (07:32 +0000)]
    [GTK] run-gtk-tests leaves a zombie Xvfb process
        https://bugs.webkit.org/show_bug.cgi?id=67389

        Reviewed by Martin Robinson.

        * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
        child process instead of doing shell redirection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebSocket] Implement WebSocket::close() code and reason handling.
commit-queue@webkit.org [Fri, 2 Sep 2011 06:33:52 +0000 (06:33 +0000)]
[WebSocket] Implement WebSocket::close() code and reason handling.
https://bugs.webkit.org/show_bug.cgi?id=66925

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-09-01
Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/close.html
       http/tests/websocket/tests/hybi/workers/close.html

* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::close):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::closeCallback):
Add custom bridge for WebSocket::close().
* websockets/ThreadableWebSocketChannel.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::close):
* websockets/WebSocket.h:
* websockets/WebSocket.idl:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::close):
Add code and reason arguments handling.
(WebCore::WebSocketChannel::startClosingHandshake):
Send a close frame without code and reason on server initiated closing handshakes.
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::processFrameHixie76):
* websockets/WebSocketChannel.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::close):
(WebCore::WorkerThreadableWebSocketChannel::Peer::close):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadClose):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
* websockets/WorkerThreadableWebSocketChannel.h:
Add code and reason arguments handling.

LayoutTests:

* http/tests/websocket/tests/hybi/close-expected.txt: Added.
* http/tests/websocket/tests/hybi/close.html: Added.
* http/tests/websocket/tests/hybi/close_wsh.py: Added.
* http/tests/websocket/tests/hybi/workers/close-expected.txt: Added.
* http/tests/websocket/tests/hybi/workers/close.html: Added.
* http/tests/websocket/tests/hybi/workers/resources/close.js: Added.
(postResult):
(testFailed):
(debug):
(shouldBe):
(shouldBeTrue):
(shouldBeFalse):
(handleOpen):
(handleError):
(handleClose):
(handleMessage):
(setDefaultHandlers):
(runCodeTest.else.ws.onclose):
(runCodeTest):
(runInvalidStringTest):
(runReasonTest.else.ws.onclose):
(runReasonTest):
(runCodeAndReasonTest.):
(runCodeAndReasonTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the build by adding some more missing return types.
mrowe@apple.com [Fri, 2 Sep 2011 04:57:23 +0000 (04:57 +0000)]
Fix the build by adding some more missing return types.

Source/WebCore:

* page/mac/WebCoreViewFactory.m:
(-[WebCoreViewFactory init]):

Source/WebKit/mac:

* WebView/WebDashboardRegion.h:
* WebView/WebDashboardRegion.mm:
(-[WebDashboardRegion initWithRect:clip:type:]):

Tools:

* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed test fix.
dominicc@chromium.org [Fri, 2 Sep 2011 04:03:22 +0000 (04:03 +0000)]
Unreviewed test fix.

r94362 erroneously changed the description wording generated by
the js-test-pre.

* fast/js/resources/js-test-pre.js:
(description): add the word 'see'
* platform/chromium/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add chromium-mac-leopard pixel baselines for new/modified tests with text
jamesr@google.com [Fri, 2 Sep 2011 03:59:11 +0000 (03:59 +0000)]
[chromium] Add chromium-mac-leopard pixel baselines for new/modified tests with text

* platform/chromium-cg-mac-leopard/fast/text/fallback-traits-fixup-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/custom/pattern-rotate-gaps-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Fix a crashing bug due to raciness around SQL database shutdown.
michaeln@google.com [Fri, 2 Sep 2011 02:27:34 +0000 (02:27 +0000)]
[Chromium] Fix a crashing bug due to raciness around SQL database shutdown.
https://bugs.webkit.org/show_bug.cgi?id=67457

The removeOpenDatabase() method can get called multiple times.
Subsequent calls to it should be harmeless instead of cause a crash.

Reviewed by David Levin.

* storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::removeOpenDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe filename text color of a file upload control should be inherited.
tkent@chromium.org [Fri, 2 Sep 2011 02:12:28 +0000 (02:12 +0000)]
The filename text color of a file upload control should be inherited.
https://bugs.webkit.org/show_bug.cgi?id=67368

Reviewed by Darin Adler.

Source/WebCore:

* css/html.css:
(input[type="file"]):
Add 'color: inherit'.
The declaration for 'input' contains 'color: initial;'. So a file
upload control has had black foreground color unless it has been
specified 'color' property explicitly.
Because a file upload control uses inherited background color, the
foreground color also should be inherited.

LayoutTests:

* fast/forms/file/file-style-inheritance-expected.txt:
* fast/forms/file/file-style-inheritance.html: Add a testcase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGenerate a Worker constructor of V8 using the IDL 'Constructor' extended attribute
commit-queue@webkit.org [Fri, 2 Sep 2011 01:37:55 +0000 (01:37 +0000)]
Generate a Worker constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67447

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

Test: fast/workers/worker-constructor.html
      fast/workers/worker-event-listener.html

* bindings/v8/custom/V8WorkerCustom.cpp: Removed constructorCallback().
* workers/Worker.idl: Added the 'Constructor' extended attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Allow controlling minimum DOMTimer interval on a per-page basis
gyuyoung.kim@samsung.com [Fri, 2 Sep 2011 01:35:10 +0000 (01:35 +0000)]
[EFL] Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=67012

Reviewed by Kenneth Russell.

Set default minimum DOMTimer interval to 4ms instead of 10ms. Because, 4ms is known
to better minimum value for performance. Mac, android, chromium and window ports already
use 4ms instead of 10ms.

It is desirable to be able to change the minimum DOMTimer interval on per-page basis
in order to avoid consuming excessive CPU and battery life on mobile devices. In addition,
other ports have already used this setting by means of Bug 54312.

* ewk/ewk_main.cpp:
(_ewk_init_body):
* ewk/ewk_settings.cpp:
(ewk_settings_default_timer_interval_get):
* ewk/ewk_settings.h:
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_setting_minimum_timer_interval_set):
(ewk_view_setting_minimum_timer_interval_get):
* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add chromium leopard baselines
jamesr@google.com [Fri, 2 Sep 2011 01:33:37 +0000 (01:33 +0000)]
[chromium] Add chromium leopard baselines

* platform/chromium-cg-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/chromium-cg-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Copied from LayoutTests/platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt.
* platform/win-wk2/fast/text/international/bidi-mirror-he-ar-expected.txt: Renamed from LayoutTests/platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Remove unused code related with priv->render.process_entire_queue in ewk_tiled_...
commit-queue@webkit.org [Fri, 2 Sep 2011 01:25:03 +0000 (01:25 +0000)]
[EFL] Remove unused code related with priv->render.process_entire_queue in ewk_tiled_backing_store.
https://bugs.webkit.org/show_bug.cgi?id=63377

priv->render.process_entire_queue affects no logical flow of ewk_tiled_backing_store,
But, ewk_view_tiled_process_entire_queue_set is now provided as setter api for it.
So removal of this api and some codes related with it is required.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-09-01
Reviewed by Antonio Gomes.

* ewk/ewk_tiled_backing_store.c:
(_ewk_tiled_backing_store_smart_add):
(ewk_tiled_backing_store_enable_render):
* ewk/ewk_tiled_backing_store.h:
* ewk/ewk_view.h:
* ewk/ewk_view_tiled.c:
(ewk_view_tiled_unused_cache_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove expectation lines for tests that pass
jamesr@google.com [Fri, 2 Sep 2011 01:00:23 +0000 (01:00 +0000)]
[chromium] Remove expectation lines for tests that pass

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the build.
mrowe@apple.com [Fri, 2 Sep 2011 00:51:15 +0000 (00:51 +0000)]
Fix the build.

* JavaScriptCore.JSVALUE32_64only.exp:
* JavaScriptCore.JSVALUE64only.exp:
* JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGenerate a FileReader constructor of V8 using the IDL 'Constructor' extended attribute
commit-queue@webkit.org [Fri, 2 Sep 2011 00:49:28 +0000 (00:49 +0000)]
Generate a FileReader constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67412

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Adam Barth.

Test: fast/files/blob-slice-test.html
      fast/files/file-reader-abort.html

* bindings/v8/custom/V8FileReaderCustom.cpp: Removed constructorCallback().
* fileapi/FileReader.idl: Added the 'Constructor' extended attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded Snow Leopard expected results to the test added in r94352.
mitz@apple.com [Fri, 2 Sep 2011 00:42:50 +0000 (00:42 +0000)]
Added Snow Leopard expected results to the test added in r94352.

* platform/mac-snowleopard/fast/text/fallback-traits-fixup-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: [chromium] Code cleanup FIXME in Chromium recognizer
commit-queue@webkit.org [Fri, 2 Sep 2011 00:32:00 +0000 (00:32 +0000)]
Source/WebCore:        [chromium] Code cleanup FIXME in Chromium recognizer
https://bugs.webkit.org/show_bug.cgi?id=67448

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-01
Reviewed by Adam Barth.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
Fixed a bug noticed by a benjaminp while reviewing a different
ndonned patch where global positions were not being set correctly
on gesture-driven mouse wheel events.
* platform/chromium/GestureRecognizerChromium.cpp:
Changed static per-edge functions into methods and improves
encapsulation. No new functionality is present.
(WebCore::GestureRecognizerChromium::GestureRecognizerChromium):
(WebCore::GestureRecognizerChromium::reset):
(WebCore::GestureRecognizerChromium::~GestureRecognizerChromium):
(WebCore::GestureRecognizerChromium::addEdgeFunction):
(WebCore::GestureRecognizerChromium::isInClickTimeWindow):
(WebCore::GestureRecognizerChromium::isInsideManhattanSquare):
(WebCore::GestureRecognizerChromium::appendClickGestureEvent):
(WebCore::GestureRecognizerChromium::processTouchEventForGestures):
(WebCore::GestureRecognizerChromium::appendScrollGestureBegin):
(WebCore::GestureRecognizerChromium::appendScrollGestureEnd):
(WebCore::GestureRecognizerChromium::appendScrollGestureUpdate):
(WebCore::GestureRecognizerChromium::updateValues):
(WebCore::GestureRecognizerChromium::signature):
(WebCore::GestureRecognizerChromium::touchDown):
(WebCore::GestureRecognizerChromium::scrollEnd):
(WebCore::GestureRecognizerChromium::noGesture):
(WebCore::GestureRecognizerChromium::click):
(WebCore::GestureRecognizerChromium::isClickOrScroll):
(WebCore::GestureRecognizerChromium::inScroll):
* platform/chromium/GestureRecognizerChromium.h:
(WebCore::GestureRecognizerChromium::setState):

Source/WebKit/chromium: [chromium] Code cleanup FIXME in Chromium recognizer
https://bugs.webkit.org/show_bug.cgi?id=67448

Updated GestureRecognizer unit tests for more encapsulated
gesture recognizer implementation.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-01
Reviewed by Adam Barth.

* tests/InnerGestureRecognizerTest.cpp:
(InspectableGestureRecognizerChromium::InspectableGestureRecognizerChromium):
(InspectableGestureRecognizerChromium::signature):
(InspectableGestureRecognizerChromium::edgeFunction):
(InspectableGestureRecognizerChromium::updateValues):
(InspectableGestureRecognizerChromium::addEdgeFunction):
(InspectableGestureRecognizerChromium::setStateTest):
(InspectableGestureRecognizerChromium::isInsideManhattanSquare):
(InspectableGestureRecognizerChromium::isInClickTimeWindow):
(InspectableGestureRecognizerChromium::stubEdgeFunction):
(GestureRecognizerTest::GestureRecognizerTest):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove LayoutRepainter to its own class
jchaffraix@webkit.org [Fri, 2 Sep 2011 00:29:23 +0000 (00:29 +0000)]
Move LayoutRepainter to its own class
https://bugs.webkit.org/show_bug.cgi?id=66255

Reviewed by Hajime Morita.

No new tests, code movement only.

* rendering/RenderObject.h: Moved code from here ...
* rendering/LayoutRepainter.cpp: Added.
(WebCore::LayoutRepainter::LayoutRepainter):
(WebCore::LayoutRepainter::repaintAfterLayout):
* rendering/LayoutRepainter.h: Added.
(WebCore::LayoutRepainter::checkForRepaint):
... to those 2 files.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Updated our build systems.

* rendering/RenderingAllInOne.cpp:
Needed for the Windows bot.

* rendering/RenderBlock.cpp:
* rendering/RenderDeprecatedFlexibleBox.cpp:
* rendering/RenderReplaced.cpp:
* rendering/RenderTable.cpp:
* rendering/svg/RenderSVGContainer.cpp:
* rendering/svg/RenderSVGForeignObject.cpp:
* rendering/svg/RenderSVGImage.cpp:
* rendering/svg/RenderSVGPath.cpp:
* rendering/svg/RenderSVGRoot.cpp:
* rendering/svg/RenderSVGText.cpp:
Added #include "LayoutRepainter".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Cleanup refactoring for https://bugs.webkit.org/show_bug.cgi?id=67160
adachan@apple.com [Fri, 2 Sep 2011 00:20:30 +0000 (00:20 +0000)]
Source/WebCore: Cleanup refactoring for https://bugs.webkit.org/show_bug.cgi?id=67160

Don't ifdef out the data member xslStyleSheets in MemoryCache::Statistics to cut down
the ifdefs in getWebCoreMemoryCacheStatistics() in WebKit2/WebProcess/WebProcess.cpp.

Reviewed by Darin Adler.

No new tests required.  Just small code refactoring.

* loader/cache/MemoryCache.h:

Source/WebKit2: Cut down the ifdefs in WebKit::getWebCoreMemoryCacheStatistics() now that
MemoryCache::Statistics always has the xslStyleSheets field.

Reviewed by Darin Adler.

* WebProcess/WebProcess.cpp:
(WebKit::getWebCoreMemoryCacheStatistics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update leopard pixel baselines for svg tests
jamesr@google.com [Fri, 2 Sep 2011 00:20:04 +0000 (00:20 +0000)]
[chromium] Update leopard pixel baselines for svg tests

* platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/custom/non-scaling-stroke-expected.png:
* platform/chromium-cg-mac-leopard/svg/custom/pattern-rotate-expected.png:
* platform/chromium-cg-mac-leopard/svg/custom/pattern-skew-transformed-expected.png: Removed.
* platform/chromium-cg-mac-leopard/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-cg-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-cg-mac-leopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-cg-mac/svg/custom/pattern-rotate-expected.png: Added.
* platform/chromium-cg-mac/svg/custom/pattern-rotate-gaps-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r84327-r84329): CSS stylesheets fail to load on www.flagstar.com login...
jchaffraix@webkit.org [Fri, 2 Sep 2011 00:18:17 +0000 (00:18 +0000)]
REGRESSION (r84327-r84329): CSS stylesheets fail to load on flagstar.com login page
https://bugs.webkit.org/show_bug.cgi?id=65140

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/css/stylesheet-enable-first-alternate-link.html
       fast/css/stylesheet-enable-first-alternate-on-load-link.html
       fast/css/stylesheet-enable-first-alternate-on-load-sheet.html
       fast/css/stylesheet-enable-second-alternate-link.html
       fast/css/stylesheet-enable-second-alternate-on-load-link.html
       fast/css/stylesheet-enable-second-alternate-on-load-sheet.html
       http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html
       http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html

This patch basically reverts 88479 and 84329 while keeping the tests
we developped during the implementation.

Following discussion, it looks like HTML5 will need to be amended.
In the meantime, we will just revert the changes so that we can come
up with a better change.

* dom/Document.cpp:
(WebCore::Document::recalcStyleSelector):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::process):
Revert those method to their original content.

* html/HTMLLinkElement.h:
(WebCore::HTMLLinkElement::isDisabled):
(WebCore::HTMLLinkElement::isEnabledViaScript):
(WebCore::HTMLLinkElement::isAlternate):
Re-introduced the DisabledState enum.

* html/HTMLLinkElement.idl: |disabled| is Reflect'ed again.

LayoutTests:

* fast/css/stylesheet-enable-first-alternate-link-expected.txt: Added.
* fast/css/stylesheet-enable-first-alternate-link.html: Added.
* fast/css/stylesheet-enable-first-alternate-on-load-link-expected.txt: Added.
* fast/css/stylesheet-enable-first-alternate-on-load-link.html: Added.
* fast/css/stylesheet-enable-first-alternate-on-load-sheet-expected.txt: Added.
* fast/css/stylesheet-enable-first-alternate-on-load-sheet.html: Added.
* fast/css/stylesheet-enable-second-alternate-link-expected.txt: Added.
* fast/css/stylesheet-enable-second-alternate-link.html: Added.
* fast/css/stylesheet-enable-second-alternate-on-load-link-expected.txt: Added.
* fast/css/stylesheet-enable-second-alternate-on-load-link.html: Added.
* fast/css/stylesheet-enable-second-alternate-on-load-sheet-expected.txt: Added.
* fast/css/stylesheet-enable-second-alternate-on-load-sheet.html: Added.
* http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt: Added.
* http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
* http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Added.
* http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html: Added.
* http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet-in-error.js: Added.
(onSheetLoaded):
(testWhenLoaded):
* http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet.js: Added.
(onSheetLoaded):
(testWhenLoaded):
* http/tests/css/resources/slow-loading-sheet-in-error.php: Added.
* http/tests/css/resources/slow-loading-sheet.php: Added.
New tests developped for 65140. The baselines matches what FF and Opera are doing (IE does not support
link.sheet at the moment). Those failures are covered by bug 67436.

* fast/css/link-disabled-attr-expected.txt:
* fast/dom/HTMLLinkElement/disabled-attribute-expected.txt:
Fixed the baseline to match our behavior. The FAIL are our current deviation from the spec. Those
failures are covered by bug 67436.

* fast/dom/boolean-attribute-reflection-expected.txt:
* fast/dom/script-tests/boolean-attribute-reflection.js:
Re-added link.disabled as a reflected attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix layout test regressions from r94352.
mitz@apple.com [Fri, 2 Sep 2011 00:16:30 +0000 (00:16 +0000)]
Fix layout test regressions from r94352.

Reviewed by Anders Carlsson.

* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters): In the custom font case (that is, when there is
not base NSFont) always get and use the best variation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert r94355 because it caused bunch of builds to break.
rniwa@webkit.org [Fri, 2 Sep 2011 00:11:33 +0000 (00:11 +0000)]
Revert r94355 because it caused bunch of builds to break.

Source/WebCore:

* page/DOMWindow.idl:

LayoutTests:

* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update chromium baselines+expectations for fast/text/fallback-traits-fixup...
jamesr@google.com [Thu, 1 Sep 2011 23:57:45 +0000 (23:57 +0000)]
[chromium] Update chromium baselines+expectations for fast/text/fallback-traits-fixup.html

* platform/chromium-cg-mac/fast/text/fallback-traits-fixup-expected.png: Added.
* platform/chromium-cg-mac/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/chromium-linux/fast/text/fallback-traits-fixup-expected.png: Added.
* platform/chromium-linux/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/10063411> WebScriptObject.h declares an Objective-C method without...
mrowe@apple.com [Thu, 1 Sep 2011 23:53:38 +0000 (23:53 +0000)]
<rdar://problem/10063411> WebScriptObject.h declares an Objective-C method without a return type.

Rubber-stamped by Anders Carlsson.

* bridge/objc/WebScriptObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnzip initialization lists and constructors in JSCell hierarchy (4/7)
commit-queue@webkit.org [Thu, 1 Sep 2011 23:49:23 +0000 (23:49 +0000)]
Unzip initialization lists and constructors in JSCell hierarchy (4/7)
https://bugs.webkit.org/show_bug.cgi?id=67174

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-01
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
(JSC::JSCallbackConstructor::finishCreation):
* API/JSCallbackConstructor.h:
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::create):
* API/JSCallbackObjectFunctions.h:
(JSC::::JSCallbackObject):
(JSC::::finishCreation):
* JavaScriptCore.JSVALUE64only.exp:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::DebuggerActivation):
(JSC::DebuggerActivation::create):
* debugger/DebuggerActivation.h:
* runtime/Arguments.h:
(JSC::Arguments::create):
(JSC::Arguments::createNoParameters):
(JSC::Arguments::Arguments):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::ArrayPrototype):
(JSC::ArrayPrototype::finishCreation):
* runtime/ArrayPrototype.h:
* runtime/BooleanObject.cpp:
(JSC::BooleanObject::BooleanObject):
(JSC::BooleanObject::finishCreation):
* runtime/BooleanObject.h:
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
(JSC::DateInstance::finishCreation):
* runtime/DateInstance.h:
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
* runtime/ErrorInstance.h:
(JSC::ErrorInstance::create):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::finishCreation):
* runtime/ErrorPrototype.h:
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::InterruptedExecutionError::create):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::create):
* runtime/Executable.cpp:
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
(JSC::InternalFunction::finishCreation):
* runtime/InternalFunction.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::finishCreation):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
* runtime/JSArray.h:
(JSC::JSArray::create):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::JSByteArray):
* runtime/JSByteArray.h:
(JSC::JSByteArray::create):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::finishCreation):
* runtime/JSFunction.h:
(JSC::JSFunction::create):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::finishCreation):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::JSNotAnObject):
(JSC::JSNotAnObject::create):
* runtime/JSONObject.cpp:
(JSC::JSONObject::JSONObject):
(JSC::JSONObject::finishCreation):
* runtime/JSONObject.h:
* runtime/JSObjectWithGlobalObject.cpp:
(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
* runtime/JSObjectWithGlobalObject.h:
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::finishCreation):
(JSC::JSStaticScopeObject::JSStaticScopeObject):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::JSVariableObject):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::JSWrapperObject):
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
(JSC::MathObject::finishCreation):
* runtime/MathObject.h:
* runtime/NumberObject.cpp:
(JSC::NumberObject::NumberObject):
(JSC::NumberObject::finishCreation):
* runtime/NumberObject.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
* runtime/ObjectPrototype.h:
(JSC::ObjectPrototype::create):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpMatchesArray::RegExpMatchesArray):
(JSC::RegExpMatchesArray::finishCreation):
* runtime/RegExpMatchesArray.h:
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::finishCreation):
* runtime/RegExpObject.h:
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::StrictEvalActivation):
* runtime/StrictEvalActivation.h:
(JSC::StrictEvalActivation::create):
* runtime/StringObject.cpp:
(JSC::StringObject::StringObject):
(JSC::StringObject::finishCreation):
* runtime/StringObject.h:

Source/JavaScriptGlue:

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* UserObjectImp.cpp:
(UserObjectImp::UserObjectImp):
* UserObjectImp.h:
(UserObjectImp::create):

Source/WebCore:

No new tests.

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::create):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::JSDOMWrapper):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createWindowShell):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObjPrototype::JSTestObjPrototype):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
(JSC::Bindings::ObjcFallbackObjectImp::finishCreation):
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::RuntimeArray):
(JSC::RuntimeArray::finishCreation):
* bridge/runtime_array.h:
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::RuntimeObject):
(JSC::Bindings::RuntimeObject::finishCreation):
* bridge/runtime_object.h:

Source/WebKit2:

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::finishCreation):
* WebProcess/Plugins/Netscape/JSNPObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove unsafe raw GraphicsContext3D pointer from ProgramBinding
enne@google.com [Thu, 1 Sep 2011 23:45:02 +0000 (23:45 +0000)]
[chromium] Remove unsafe raw GraphicsContext3D pointer from ProgramBinding
https://bugs.webkit.org/show_bug.cgi?id=67003

Reviewed by James Robinson.

ProgramBinding now takes an explicit cleanup call to destroy its
resources. This will assert if it is not called and will leak no
longer potentially dereference a dead pointer.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::borderProgram):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgram):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
(WebCore::LayerRendererChromium::tilerProgram):
(WebCore::LayerRendererChromium::tilerProgramSwizzle):
(WebCore::LayerRendererChromium::tilerProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleAA):
(WebCore::LayerRendererChromium::canvasLayerProgram):
(WebCore::LayerRendererChromium::pluginLayerProgram):
(WebCore::LayerRendererChromium::videoLayerRGBAProgram):
(WebCore::LayerRendererChromium::videoLayerYUVProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/ProgramBinding.cpp:
(WebCore::ProgramBindingBase::ProgramBindingBase):
(WebCore::ProgramBindingBase::~ProgramBindingBase):
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::cleanup):
(WebCore::ProgramBindingBase::loadShader):
(WebCore::ProgramBindingBase::createShaderProgram):
* platform/graphics/chromium/ProgramBinding.h:
(WebCore::ProgramBinding::ProgramBinding):
(WebCore::ProgramBinding::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/dom/global-constructors.html and fast/dom/prototype-inheritance.html are way...
jamesr@google.com [Thu, 1 Sep 2011 23:41:12 +0000 (23:41 +0000)]
fast/dom/global-constructors.html and fast/dom/prototype-inheritance.html are way too fragile
https://bugs.webkit.org/show_bug.cgi?id=67452

Reviewed by Darin Adler.

Modifies these tests to not print PASS lines for all of the expected successes, since that means they have to be
updated whenever the set of properties on the global object is changed.  That is not the point of these tests
and it just causes excessive churn.

* fast/dom/global-constructors-expected.txt:
* fast/dom/global-constructors.html:
* fast/dom/prototype-inheritance-expected.txt:
* fast/dom/script-tests/prototype-inheritance.js:
* fast/js/resources/js-test-pre.js:
(description):
(descriptionQuiet):
(shouldBe):
(shouldBeTrueQuiet):
* platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt:
* platform/chromium/fast/dom/global-constructors-expected.txt: Removed.
* platform/chromium/fast/dom/prototype-inheritance-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/dom/prototype-inheritance-expected.txt: Removed.
* platform/mac/fast/dom/prototype-inheritance-expected.txt: Removed.
* platform/qt/fast/dom/prototype-inheritance-expected.txt: Removed.
* platform/win/fast/dom/prototype-inheritance-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded Windows expected results to the test added in r94352.
mitz@apple.com [Thu, 1 Sep 2011 23:32:20 +0000 (23:32 +0000)]
Added Windows expected results to the test added in r94352.

* platform/win/fast/text/fallback-traits-fixup-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't include unnecessary headers in V8 bindings
paroga@webkit.org [Thu, 1 Sep 2011 23:29:06 +0000 (23:29 +0000)]
Don't include unnecessary headers in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=67435

Reviewed by Darin Adler.

When an IDL attribue is Conditonal the corresponding headers
need to be surrounded with the correct #if ENABLE().

* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium, Skia] Add virtual to WebGraphicsContext3D to create a new GrGLInterface...
commit-queue@webkit.org [Thu, 1 Sep 2011 23:25:04 +0000 (23:25 +0000)]
[Chromium, Skia] Add virtual to WebGraphicsContext3D to create a new GrGLInterface per context. Insert per-skia-GL-function callback to set correct GL context.
https://bugs.webkit.org/show_bug.cgi?id=67395

Patch by Brian Salomon <bsalomon@google.com> on 2011-09-01
Reviewed by Kenneth Russell.

* WebKit.gyp:
* public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::onCreateGrGLInterface):
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::grContext):
* src/WebGraphicsContext3D.cpp: Added.
(WebKit::WebGraphicsContext3D::createGrGLInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename CFNETWORK_DATA_ARRAY_CALLBACK to NETWORK_CFDATA_ARRAY_CALLBACK
psolanki@apple.com [Thu, 1 Sep 2011 23:22:03 +0000 (23:22 +0000)]
Rename CFNETWORK_DATA_ARRAY_CALLBACK to NETWORK_CFDATA_ARRAY_CALLBACK
https://bugs.webkit.org/show_bug.cgi?id=67348

Reviewed by Alexey Proskuryakov.

* loader/ResourceLoader.h:
* loader/SubresourceLoader.h:
* loader/cf/SubresourceLoaderCF.cpp:
* loader/mac/ResourceLoaderMac.mm:
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::clear):
(WebCore::SharedBuffer::buffer):
* platform/SharedBuffer.h:
* platform/cf/SharedBufferCF.cpp:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
* platform/network/mac/ResourceHandleMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTypeError should be thrown when a constructor is called as a normal function.
commit-queue@webkit.org [Thu, 1 Sep 2011 23:06:49 +0000 (23:06 +0000)]
TypeError should be thrown when a constructor is called as a normal function.
https://bugs.webkit.org/show_bug.cgi?id=67381

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Darin Adler.

The spec is here: http://www.w3.org/TR/WebIDL/#es-interface-call
For example, "Image()" or "XMLHttpRequest()" should throw TypeError.

Source/WebCore:

Test: fast/dom/call-a-constructor-as-a-function.html

* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallback): Throws TypeError if args.IsConstructCall() is false.
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray): Ditto.
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback): Ditto.
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallback): Ditto.
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
(WebCore::v8HTMLAudioElementConstructorCallback): Ditto.
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback): Ditto.
* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
(WebCore::v8HTMLOptionElementConstructorCallback): Ditto.
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::V8MessageChannel::constructorCallback): Ditto.
* bindings/v8/custom/V8SharedWorkerCustom.cpp:
(WebCore::V8SharedWorker::constructorCallback): Ditto.
* bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:
(WebCore::V8WebKitCSSMatrix::constructorCallback): Ditto.
* bindings/v8/custom/V8WebKitPointConstructor.cpp:
(WebCore::V8WebKitPoint::constructorCallback): Ditto.
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback): Ditto.
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::V8Worker::constructorCallback): Ditto.

LayoutTests:

* fast/dom/call-a-constructor-as-a-function-expected.txt: Added. The test result for JSC.
* fast/dom/call-a-constructor-as-a-function.html: Added. Checks if TypeError is thrown.
* platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt: Added. The test result for V8.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] TextureManager overestimates the size of non-RGBA texture formats
enne@google.com [Thu, 1 Sep 2011 23:03:58 +0000 (23:03 +0000)]
[chromium] TextureManager overestimates the size of non-RGBA texture formats
https://bugs.webkit.org/show_bug.cgi?id=66917

Reviewed by James Robinson.

Use GraphicsContext3D to determine the size of a given texture format.
Also, make TextureManager use more GraphicsContext3D types.

* platform/graphics/GraphicsContext3D.h:
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::memoryUseBytes):
* platform/graphics/chromium/TextureManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd missing Event constructors to DOMWindow.idl
weinig@apple.com [Thu, 1 Sep 2011 22:48:46 +0000 (22:48 +0000)]
Add missing Event constructors to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=67449

Reviewed by Anders Carlsson.

Source/WebCore:

Covered by existing tests.

* page/DOMWindow.idl:

LayoutTests:

* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-expected.txt:
* platform/mac/fast/js/global-constructors-expected.txt:
Update results for new constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConsider Conditional attribute in CodeGenerator for methods
paroga@webkit.org [Thu, 1 Sep 2011 22:42:20 +0000 (22:42 +0000)]
Consider Conditional attribute in CodeGenerator for methods
https://bugs.webkit.org/show_bug.cgi?id=67409

Reviewed by Darin Adler.

This change adds appropriate #if ENABLE() lines for the preprocessor around the
generated functions depending on the Conditional attribute in the IDL file.

* bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Introduce CCSingleThreadProxy in order to move LayerRenderer to CCLayerTre...
nduca@chromium.org [Thu, 1 Sep 2011 22:40:08 +0000 (22:40 +0000)]
[chromium] Introduce CCSingleThreadProxy in order to move LayerRenderer to CCLayerTreeHostImpl
https://bugs.webkit.org/show_bug.cgi?id=66807

Reviewed by James Robinson.

Source/WebCore:

* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setLayerRendererRecursive):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::close):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::isContextLost):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::capabilities):
(WebCore::LayerRendererChromium::rootLayerImpl):
(WebCore::LayerRendererChromium::contextSupportsMapSub):
(WebCore::LayerRendererChromium::viewportSize):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setLayerTreeHost):
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::reserveTextures):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::animateAndLayout):
(WebCore::CCLayerTreeHost::preCommit):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::createCompositorThread):
(WebCore::CCLayerTreeHost::createLayerTreeHostContext3D):
(WebCore::CCLayerTreeHost::createLayerTreeHostImpl):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::scheduleComposite):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::finishAllRendering):
(WebCore::CCLayerTreeHost::layerRendererCapabilities):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::skiaContext):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::loseCompositorContext):
(WebCore::CCLayerTreeHost::contentsTextureManager):
(WebCore::CCLayerTreeHost::composite):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
* platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Removed.
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::create):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::context):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::finishAllRendering):
(WebCore::CCLayerTreeHostImpl::isContextLost):
(WebCore::CCLayerTreeHostImpl::layerRendererCapabilities):
(WebCore::CCLayerTreeHostImpl::present):
(WebCore::CCLayerTreeHostImpl::readback):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
(WebCore::CCLayerTreeHostImpl::updateLayers):
(WebCore::CCLayerTreeHostImpl::setViewport):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::layerRenderer):
(WebCore::CCLayerTreeHostImpl::rootLayer):
(WebCore::CCLayerTreeHostImpl::viewportSize):
* platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Removed.
* platform/graphics/chromium/cc/CCMainThreadTask.h:
(WebCore::MainThreadTask4::create):
(WebCore::MainThreadTask4::MainThreadTask4):
(WebCore::MainThreadTask4::performTask):
(WebCore::MainThreadTask5::create):
(WebCore::MainThreadTask5::MainThreadTask5):
(WebCore::MainThreadTask5::performTask):
(WebCore::createMainThreadTask):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
* platform/graphics/chromium/cc/CCProxy.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp.
(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::setImplThread):
* platform/graphics/chromium/cc/CCProxy.h: Added.
(WebCore::CCProxy::~CCProxy):
(WebCore::CCProxy::CCProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: Added.
(WebCore::ScopedSetImplThread::ScopedSetImplThread):
(WebCore::ScopedSetImplThread::~ScopedSetImplThread):
(WebCore::CCSingleThreadProxy::create):
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::start):
(WebCore::CCSingleThreadProxy::~CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::context):
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::isStarted):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::layerRendererCapabilities):
(WebCore::CCSingleThreadProxy::loseCompositorContext):
(WebCore::CCSingleThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::skiaContext):
(WebCore::CCSingleThreadProxy::contentsTextureManager):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::compositeIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h.
* platform/graphics/chromium/cc/CCThreadProxy.cpp: Added.
(WebCore::CCThreadProxy::create):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::layerRendererCapabilities):
(WebCore::CCThreadProxy::loseCompositorContext):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::skiaContext):
(WebCore::CCThreadProxy::contentsTextureManager):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
(WebCore::CCThreadProxy::initializeImplOnCCThread):
(WebCore::CCThreadProxy::initializeLayerRendererOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
* platform/graphics/chromium/cc/CCThreadProxy.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h.
* platform/graphics/chromium/cc/CCThreadTask.h:
(WebCore::CCThreadTask5::create):
(WebCore::CCThreadTask5::CCThreadTask5):
(WebCore::CCThreadTask5::performTask):
(WebCore::createCCThreadTask):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
* tests/CCThreadTaskTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9528843> STIX glyphs not rendered on this stackoverflow answer
mitz@apple.com [Thu, 1 Sep 2011 22:32:43 +0000 (22:32 +0000)]
<rdar://problem/9528843> STIX glyphs not rendered on this stackoverflow answer
https://bugs.webkit.org/show_bug.cgi?id=67444

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/text/fallback-traits-fixup.html

After obtaining STIX Regular as a fallback font for some characters, getFontDataForCharacters()
proceeded to ask for a font from the same family having the desired traits and weight (because
wkGetFontInLanguageForRange() does not preserve traits and weight). The returned font was different
and happened to not contain the desired character.

* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters): Only ask for a family member with the desired
traits and weight if the substitute font does not already have them, and only use the returned
member if it actually contains the desired character.

LayoutTests:

* fast/text/fallback-traits-fixup.html: Added.
* platform/mac/fast/text/fallback-traits-fixup-expected.png: Added.
* platform/mac/fast/text/fallback-traits-fixup-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update more SVG baselines
jamesr@google.com [Thu, 1 Sep 2011 22:27:53 +0000 (22:27 +0000)]
[chromium] Update more SVG baselines

* platform/chromium-cg-mac/svg/custom/non-scaling-stroke-expected.png:
* platform/chromium-cg-mac/svg/custom/pattern-skew-transformed-expected.png:
* platform/chromium-cg-mac/svg/custom/pattern-with-transformation-expected.png:
* platform/mac/svg/custom/non-scaling-stroke-expected.txt: Removed.
* platform/mac/svg/custom/pattern-skew-transformed-expected.txt: Removed.
* platform/qt/svg/custom/non-scaling-stroke-expected.txt: Removed.
* platform/qt/svg/custom/pattern-skew-transformed-expected.txt: Removed.
* svg/custom/non-scaling-stroke-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/non-scaling-stroke-expected.txt.
* svg/custom/pattern-skew-transformed-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/pattern-skew-transformed-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGenerate an XSLTProcessor constructor of V8 using the IDL 'Constructor' extended...
commit-queue@webkit.org [Thu, 1 Sep 2011 22:16:23 +0000 (22:16 +0000)]
Generate an XSLTProcessor constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67414

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

Test: fast/dom/Window/custom-constructors.html
      fast/xsl/default-html.html

* bindings/v8/custom/V8XSLTProcessorCustom.cpp: Removed constructorCallback().
* xml/XSLTProcessor.idl: Added the 'Constructor' extended attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Mark test that renders differently in 32 vs 64 bit mode as failing (WTF?)
jamesr@google.com [Thu, 1 Sep 2011 22:02:42 +0000 (22:02 +0000)]
[chromium] Mark test that renders differently in 32 vs 64 bit mode as failing (WTF?)

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update chromium baselines for 94338 for windows/mac
jamesr@google.com [Thu, 1 Sep 2011 21:40:59 +0000 (21:40 +0000)]
[chromium] Update chromium baselines for 94338 for windows/mac

* platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
* platform/chromium-cg-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
* platform/chromium-cg-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding control rendering at various sizes.
jonlee@apple.com [Thu, 1 Sep 2011 21:30:42 +0000 (21:30 +0000)]
Adding control rendering at various sizes.

* projects/forms/survey.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update chromium baselines for 94338
jamesr@google.com [Thu, 1 Sep 2011 21:30:23 +0000 (21:30 +0000)]
[chromium] Update chromium baselines for 94338

* platform/chromium-linux/svg/custom/pattern-rotate-expected.png:
* platform/chromium-win/svg/custom/pattern-rotate-expected.png:
* platform/chromium/test_expectations.txt:
* platform/qt/svg/custom/pattern-rotate-expected.txt: Removed.
* svg/custom/pattern-rotate-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/pattern-rotate-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
eric@webkit.org [Thu, 1 Sep 2011 21:29:51 +0000 (21:29 +0000)]
REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
https://bugs.webkit.org/show_bug.cgi?id=66228

Reviewed by Dirk Pranke.

ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
The LeaksViewer tool globs for all *-leaks.txt files.
This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.

In order to test this I had to fix a limitation in our MockFileSystem.glob
method.  However, doing so uncovered a typo and bug in the integration tests.
I've disabled the offending integration tests.

* Scripts/webkitpy/common/system/filesystem_mock.py:
* Scripts/webkitpy/layout_tests/port/leakdetector.py:
* Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTMLMediaElement should use fastHasAttribute instead of hasAttribute
eric.carlson@apple.com [Thu, 1 Sep 2011 21:22:24 +0000 (21:22 +0000)]
HTMLMediaElement should use fastHasAttribute instead of hasAttribute
https://bugs.webkit.org/show_bug.cgi?id=67421

Reviewed by Simon Fraser.

Use fastHasAttribute instead of hasAttribute because it is faster, and HTMLMediaElement
doesn't ever need to check style or SVG animated attributes.

No new tests required, this is just an optimization.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::selectMediaResource): hasAttribute -> fastHasAttribute.
(WebCore::HTMLMediaElement::loadResource): Ditto.
(WebCore::HTMLMediaElement::autoplay): Ditto.
(WebCore::HTMLMediaElement::loop): Ditto.
(WebCore::HTMLMediaElement::controls): Ditto.
(WebCore::HTMLMediaElement::selectNextSourceChild): Ditto.
(WebCore::HTMLMediaElement::sourceWasAdded): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Add API functions to enable starting and stopping speech input,
commit-queue@webkit.org [Thu, 1 Sep 2011 21:14:56 +0000 (21:14 +0000)]
Source/WebCore: Add API functions to enable starting and stopping speech input,
and checking the current speech input state.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

Test: fast/speech/input-text-speechstart.html

* html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):
(WebCore::InputFieldSpeechButtonElement::stopSpeechInput):
* html/shadow/TextControlInnerElements.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::speechButtonElement):
* rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium: Add API functions to enable starting and stopping speech input,
and checking the current speech input state.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

* public/WebInputElement.h:
* src/AssertMatchingEnums.cpp:
* src/WebInputElement.cpp:
(WebKit::WebInputElement::isSpeechInputEnabled):
(WebKit::WebInputElement::getSpeechInputState):
(WebKit::WebInputElement::startSpeechInput):
(WebKit::WebInputElement::stopSpeechInput):

Tools: Adds a LayoutTestController method to make it possible to test
starting speech input via an API call.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::startSpeechInput):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::startSpeechInput):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::startSpeechInput):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::startSpeechInput):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::startSpeechInput):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::startSpeechInput):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::startSpeechInput):

LayoutTests: Adds a new test that checks triggering speech input via an API call.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

* fast/speech/input-text-speechtrigger-expected.txt: Added.
* fast/speech/input-text-speechtrigger.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoQNX GCC distribution doesn't support vasprintf()
dbates@webkit.org [Thu, 1 Sep 2011 21:06:26 +0000 (21:06 +0000)]
QNX GCC distribution doesn't support vasprintf()
https://bugs.webkit.org/show_bug.cgi?id=67423

Reviewed by Antonio Gomes.

* wtf/Platform.h: Don't enable HAVE_VASPRINTF when building with GCC on QNX.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed; new baselines (Skia on Mac, next chunk of files)
caryclark@google.com [Thu, 1 Sep 2011 20:46:32 +0000 (20:46 +0000)]
Unreviewed; new baselines (Skia on Mac, next chunk of files)
Some images incorrectly created with LCD text replaced with gray-scale.
Updated newer tests with reference images.
Deleted images with correct fallbacks.

* platform/chromium-mac/http/tests/navigation/error404-basic-expected.png: Removed.
(remaining files omitted for brevity)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGather memory cache statistics in WebProcess::getWebCoreStatistics().
adachan@apple.com [Thu, 1 Sep 2011 20:39:46 +0000 (20:39 +0000)]
Gather memory cache statistics in WebProcess::getWebCoreStatistics().
https://bugs.webkit.org/show_bug.cgi?id=67160

Reviewed by Darin Adler.

Encode and decode webCoreCacheStatistics data member in StatisticsData.
* Shared/StatisticsData.cpp:
(WebKit::StatisticsData::encode):
(WebKit::StatisticsData::decode):
* Shared/StatisticsData.h:

Convert the cache statistics data into an ImmutableArray and return it in WebContext::didGetWebCoreStatistics().
* UIProcess/WebContext.cpp:
(WebKit::WebContext::didGetWebCoreStatistics):

Store memory cache statistics into the StatisticsData object.
* WebProcess/WebProcess.cpp:
(WebKit::getWebCoreMemoryCacheStatistics):
(WebKit::WebProcess::getWebCoreStatistics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Land chromium baselines for fast/css/focus-ring-multiline-writingmode...
jamesr@google.com [Thu, 1 Sep 2011 20:38:22 +0000 (20:38 +0000)]
[chromium] Land chromium baselines for fast/css/focus-ring-multiline-writingmode-vertical.html

* platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
* platform/chromium-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/chromium-win/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/chromium-win/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: Rendering artifacts on a rotated, pattern filled SVG shape
timothy_horton@apple.com [Thu, 1 Sep 2011 20:27:29 +0000 (20:27 +0000)]
REGRESSION: Rendering artifacts on a rotated, pattern filled SVG shape
https://bugs.webkit.org/show_bug.cgi?id=53055
<rdar://problem/8910917>

Reviewed by Simon Fraser.

Make use of wkCGPatternCreateWithImageAndTransform
when tiling patterns in both directions. This helps to avoid
pixel-cracking along pattern tiling boundaries.

Ignore 2D rotation when computing the size of a pattern's tile image,
as it artificially inflates the size of the tile, which can cause
pixel-cracking.

Test: svg/custom/pattern-rotate-gaps.svg

* platform/graphics/cg/PatternCG.cpp:
(WebCore::Pattern::createPlatformPattern):
* rendering/svg/RenderSVGResourcePattern.cpp:
* rendering/svg/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::roundedImageBufferSize):
* rendering/svg/SVGImageBufferTools.h:

Add a test that makes pixel cracking in transformed SVG patterns quite blatant,
and rebaseline some other tests affected by the change.

* platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/mac/svg/custom/pattern-rotate-expected.png:
* platform/mac/svg/custom/pattern-rotate-gaps-expected.png: Added.
* platform/mac/svg/custom/pattern-rotate-gaps-expected.txt: Added.
* platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* svg/custom/pattern-rotate-gaps.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update expectations and baselines
jamesr@google.com [Thu, 1 Sep 2011 20:09:39 +0000 (20:09 +0000)]
[chromium] Update expectations and baselines

* platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
* platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
* platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove simple usage of UString::characters() from JavaScriptCore
msaboff@apple.com [Thu, 1 Sep 2011 20:04:34 +0000 (20:04 +0000)]
Remove simple usage of UString::characters() from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=67340

In preparation to allowing StringImpl to be backed by 8 bit
characters when appropriate, we need to eliminate or change the
usage of StringImpl::characters().  Most of the changes below
change s->characters()[0] to s[0].

Reviewed by Geoffrey Garen.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::keyForCharacterSwitch):
* bytecompiler/NodesCodegen.cpp:
(JSC::processClauseList):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Identifier.cpp:
(JSC::Identifier::addSlowCase):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::jsToNumber):
(JSC::parseFloat):
* runtime/JSString.cpp:
(JSC::JSString::substringFromRope):
* runtime/JSString.h:
(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString):
* runtime/RegExp.cpp:
(JSC::regExpFlags):
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::operator[]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix TestWebKitAPI build on clang-2.0
timothy_horton@apple.com [Thu, 1 Sep 2011 19:56:45 +0000 (19:56 +0000)]
Fix TestWebKitAPI build on clang-2.0

* TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94284.
paroga@webkit.org [Thu, 1 Sep 2011 19:51:52 +0000 (19:51 +0000)]
Unreviewed, rolling out r94284.
http://trac.webkit.org/changeset/94284
https://bugs.webkit.org/show_bug.cgi?id=65050

Broke building without SVG enabled on Chromium.

* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r93247): 2 http/tests/misc tests failing on SnowLeopard Intel Release...
ap@apple.com [Thu, 1 Sep 2011 19:50:22 +0000 (19:50 +0000)]
REGRESSION (r93247): 2 http/tests/misc tests failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=67374

Reviewed by Simon Fraser.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::applyBasicAuthorizationHeader):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::applyBasicAuthorizationHeader):
Some versions of CFNetwork carry along an Authorization header, some don't. We shouldn't
repeat its value twice, this is not one of those headers that allow comma separated lists
of values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Move ImageBuffer::platformLayer()
noel.gordon@gmail.com [Thu, 1 Sep 2011 19:40:17 +0000 (19:40 +0000)]
[chromium] Move ImageBuffer::platformLayer()
https://bugs.webkit.org/show_bug.cgi?id=67372

Reviewed by Kenneth Russell.

No new tests: refactoring only, covered by existting tests.

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::platformLayer):  Move it away from the toDataURL code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFocus ring is rendered incorrectly for a block with -webkit-writing-mode
commit-queue@webkit.org [Thu, 1 Sep 2011 19:38:53 +0000 (19:38 +0000)]
Focus ring is rendered incorrectly for a block with -webkit-writing-mode
https://bugs.webkit.org/show_bug.cgi?id=62915

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2011-09-01
Reviewed by Simon Fraser.

Source/WebCore:

RenderBlock::addFocusRingRects() should consider physical box position and
dimension instead of logical values for focus ring rects calculation.

Test: fast/css/focus-ring-multiline-writingmode-vertical.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addFocusRingRects):

LayoutTests:

* fast/css/focus-ring-multiline-writingmode-vertical.html: Added.
* platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Unreviewed, GTK build fix after r94299.
philn@webkit.org [Thu, 1 Sep 2011 19:33:04 +0000 (19:33 +0000)]
    Unreviewed, GTK build fix after r94299.

        * GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium/Skia] Use GraphicsContext3D::grContext() to create GrContext for accelerate...
commit-queue@webkit.org [Thu, 1 Sep 2011 19:28:50 +0000 (19:28 +0000)]
[Chromium/Skia] Use GraphicsContext3D::grContext() to create GrContext for accelerated drawing
https://bugs.webkit.org/show_bug.cgi?id=67419

Patch by Brian Salomon <bsalomon@google.com> on 2011-09-01
Reviewed by James Robinson.

Accelerated drawing is not enabled in layout tests. However, once it is this change will be tested by every test.

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::contextSupportsAcceleratedPainting):
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterSkPicture::create):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename GraphicsContext3DInternal to GraphicsContext3DPrivate and add a dummy version...
commit-queue@webkit.org [Thu, 1 Sep 2011 19:27:03 +0000 (19:27 +0000)]
Rename GraphicsContext3DInternal to GraphicsContext3DPrivate and add a dummy version of this class for Mac
https://bugs.webkit.org/show_bug.cgi?id=67172

Build fix, completing rename for GTK file.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2011-09-01
Reviewed by Chris Marrin.

* platform/graphics/gtk/GraphicsContext3DPrivate.cpp: Renamed from Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.cpp.
(sharedDisplay):
(WebCore::activeGraphicsContexts):
(WebCore::GraphicsContext3DPrivate::addActiveGraphicsContext):
(WebCore::GraphicsContext3DPrivate::removeActiveGraphicsContext):
(WebCore::GraphicsContext3DPrivate::cleanupActiveContextsAtExit):
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::createPbufferContext):
(WebCore::GraphicsContext3DPrivate::createPixmapContext):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agor93794 results in ruby tests causing assertion failure in RenderBlock.cpp
simon.fraser@apple.com [Thu, 1 Sep 2011 19:12:01 +0000 (19:12 +0000)]
r93794 results in ruby tests causing assertion failure in RenderBlock.cpp
https://bugs.webkit.org/show_bug.cgi?id=67007

Reviewed by Beth Dakin.

Disable these asserting ruby tests until the underlying issue can be fixed.

* fast/ruby/after-block-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/after-block-doesnt-crash.html.
* fast/ruby/after-table-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/after-table-doesnt-crash.html.
* fast/ruby/generated-after-counter-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/generated-after-counter-doesnt-crash.html.
* fast/ruby/generated-before-and-after-counter-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/generated-before-and-after-counter-doesnt-crash.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update baselines for vertical-text-glyph-test.html
jamesr@google.com [Thu, 1 Sep 2011 19:01:16 +0000 (19:01 +0000)]
[chromium] Update baselines for vertical-text-glyph-test.html

* platform/chromium-cg-mac/fast/text/international/vertical-text-glyph-test-expected.png: Added.
* platform/chromium-cg-mac/fast/text/international/vertical-text-glyph-test-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused "extension" parameter from rebaseline gardeningserver handler
jamesr@google.com [Thu, 1 Sep 2011 18:57:09 +0000 (18:57 +0000)]
Remove unused "extension" parameter from rebaseline gardeningserver handler
https://bugs.webkit.org/show_bug.cgi?id=67384

Patch by Adam Barth <abarth@webkit.org> on 2011-09-01
Reviewed by James Robinson.

This parameter hasn't done anything in a while.

* Scripts/webkitpy/tool/commands/rebaseline.py:
* Scripts/webkitpy/tool/servers/gardeningserver.py:
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r94259): Two tests doing hit testing were broken by this change.
simon.fraser@apple.com [Thu, 1 Sep 2011 18:44:26 +0000 (18:44 +0000)]
REGRESSION (r94259): Two tests doing hit testing were broken by this change.
https://bugs.webkit.org/show_bug.cgi?id=67353

Reviewed by Chris Marrin.

Fix a regression from r94259; that change missed a fix in RenderView,
which affects coordinate transforms in position:fixed elements.

This fixes these tests:
    fast/events/document-elementFromPoint.html
    fast/events/offsetX-offsetY.html
    plugins/mouse-events-fixedpos.html

* rendering/RenderView.cpp:
(WebCore::RenderView::mapAbsoluteToLocalPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
tonyg@chromium.org [Thu, 1 Sep 2011 18:41:37 +0000 (18:41 +0000)]
[chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=66673

Reviewed by James Robinson.

This was fixed for other ports in http://trac.webkit.org/changeset/88260.
However, it was missed in FontCacheLinux likely due to similar param in the nested call to getCachedFontPlatformData().

No new tests because no directly observable change in behavior.

* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Chromium] Perform a more effective JS GC
mnaganov@chromium.org [Thu, 1 Sep 2011 18:39:51 +0000 (18:39 +0000)]
Web Inspector: [Chromium] Perform a more effective JS GC
https://bugs.webkit.org/show_bug.cgi?id=67304

Reviewed by Pavel Feldman.

* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectGarbage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Transform QtFallbackWebPopupCombo into QtWebComboBox
caio.oliveira@openbossa.org [Thu, 1 Sep 2011 18:39:12 +0000 (18:39 +0000)]
[Qt] Transform QtFallbackWebPopupCombo into QtWebComboBox
https://bugs.webkit.org/show_bug.cgi?id=67344

Reviewed by Andreas Kling.

Renamed QtFallbackWebPopup to QtWebComboBox and decoupled it from
QtFallbackWebPopup. The new class is a QComboBox with the features that
we need for QtWebKit: tracking when the popup is hidden (via the didHide()
signal) and a convenience method to show its popup in the cursor position.

An important change was made to the combobox: instead of hooking our actions in
showPopup() and hidePopup(), as well as watching for popup visibility events, we
now just watch for the visibility events. This allowed us to get rid of
m_popupVisible and tracking the Show event.

This commit also removed a workaround for input focus added in r40970 after
reviewers request. See bug report for details.

* QtWebKit.pro:
* WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
(WebCore::QtFallbackWebPopup::~QtFallbackWebPopup):
(WebCore::QtFallbackWebPopup::show):
(WebCore::QtFallbackWebPopup::deleteComboBox):
* WebCoreSupport/QtFallbackWebPopup.h:
* WebCoreSupport/QtWebComboBox.cpp: Added.
(WebCore::QtWebComboBox::QtWebComboBox):
(WebCore::QtWebComboBox::showPopupAtCursorPosition):
(WebCore::QtWebComboBox::eventFilter):
* WebCoreSupport/QtWebComboBox.h: Added.

* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::popupFocus):
Change the test to use QObject::findChild(). The old method couldn't find our
new class because we defined a new metaclass for it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttp/tests/loading/empty-urls.html shouldn't
japhet@chromium.org [Thu, 1 Sep 2011 18:37:07 +0000 (18:37 +0000)]
http/tests/loading/empty-urls.html shouldn't
fail if the load event fires before we finish.
https://bugs.webkit.org/show_bug.cgi?id=67359

Reviewed by Adam Barth.

* http/tests/loading/empty-urls-expected.txt:
* http/tests/loading/empty-urls.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebGLContextEvent should have its own JS wrapper
weinig@apple.com [Thu, 1 Sep 2011 18:20:45 +0000 (18:20 +0000)]
WebGLContextEvent should have its own JS wrapper
https://bugs.webkit.org/show_bug.cgi?id=67352

Reviewed by Anders Carlsson.

Source/WebCore:

The WebGLContextEvent was missing a proper JS wrapper, and thus
anyone using one in an EventListener was actually just getting
a plain old Event. Rectify this by generating the wrapper and
wrapping it on creating.

Test: fast/canvas/webgl/WebGLContextEvent.html

* CodeGenerators.pri:
Add WebGLContextEvent.idl

* DerivedSources.make:
Add WebGLContextEvent and sort.

* WebCore.xcodeproj/project.pbxproj:
Add generated JSWebGLContextEvent.h/cpp.

* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
Wrap WebGLContextEvents as JSWebGLContextEvents.

* dom/Event.cpp:
(WebCore::Event::isWebGLContextEvent):
* dom/Event.h:
* html/canvas/WebGLContextEvent.cpp:
(WebCore::WebGLContextEvent::isWebGLContextEvent):
* html/canvas/WebGLContextEvent.h:
Add predicate for WebGLContextEvent.

LayoutTests:

* fast/canvas/webgl/WebGLContextEvent-expected.txt: Added.
* fast/canvas/webgl/WebGLContextEvent.html: Added.
Add a test that shows that WebGLContextEvents are not just base Events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd 'muted' content attribute to HTMLMediaElement
eric.carlson@apple.com [Thu, 1 Sep 2011 18:10:51 +0000 (18:10 +0000)]
Add 'muted' content attribute to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=58369

Source/WebCore:

Reviewed by Darin Adler.

Test: media/video-defaultmuted.html

* html/HTMLAttributeNames.in: Add muted.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource): Deal with the 'muted' attribute.
* html/HTMLMediaElement.idl: Add defaultMuted.

LayoutTests:

Reviewed by Darin Adler.

* media/video-defaultmuted-expected.txt: Added.
* media/video-defaultmuted.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94318 268f45cc-cd09-0410-ab3c-d52691b4dbfc