12 years agoExpose the ProfileNode functionName sorting functions on
timothy@apple.com [Tue, 20 May 2008 17:12:40 +0000 (17:12 +0000)]
Expose the ProfileNode functionName sorting functions on

Reviewed by Kevin McCullough.

* page/JavaScriptProfileNode.cpp:
(WebCore::sortFunctionNameDescending): Call ProfileNode.
(WebCore::sortFunctionNameAscending): Ditto.
(WebCore::ProfileNodeClass): Add static functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRename sortFileName{Ascending,Descending} to
timothy@apple.com [Tue, 20 May 2008 17:12:10 +0000 (17:12 +0000)]
Rename sortFileName{Ascending,Descending} to

Reviewed by Kevin McCullough.

* JavaScriptCore.exp:
* kjs/config.h:
* profiler/Profile.h:
* profiler/ProfileNode.cpp:
* profiler/ProfileNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-20 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 20 May 2008 16:41:43 +0000 (16:41 +0000)]
2008-05-20  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - a first small step of CSS DOM refactoring -- the eventual goal is to
          reduce StyleBase and possibly eliminate it, since it has multiple
          purposes and unneccessarily ties many classes together

        * css/CSSCursorImageValue.cpp:
        (WebCore::isSVGCursorIdentifier): Mark static so it has internal linkage.
        (WebCore::resourceReferencedByCursorElement): Ditto.
        (WebCore::CSSCursorImageValue::CSSCursorImageValue): Removed unused style
        (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Removed code to
        check if X and Y changed before changing them -- there's no reason to do
        that. Removed code that depended on the internals of CSSImageValue. The
        new code uses only protected functions rather than going right at the
        fields and uing internal knowledge of the base class.
        * css/CSSCursorImageValue.h: Added a create function, made constructor
        private, removed unused style argument.

        * css/CSSImageValue.cpp:
        (WebCore::CSSImageValue::CSSImageValue): Removed unused style argument.
        (WebCore::CSSImageValue::cachedImageURL): Added. A protected function for
        use by CSSCursorImageValue that gives the URL.
        (WebCore::CSSImageValue::clearCachedImage): Added. A protected function for
        use by CSSCursorImageValue that clears the CachedImage.
        * css/CSSImageValue.h: Added create functions, made constructors protected
        and private, removed unused style argument, made data members private, added
        some protected functions for use by CSSCursorImageValue.

        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::setCSSStyleSheet): Changed to call checkLoaded on
        the parent. This is part of preparation to move the checkLoaded function from
        StyleBase to StyleSheet.
        (WebCore::CSSImportRule::insertedIntoParent): Changed code to check the URL
        of the style sheet to use the href function of the style sheet rather than
        the baseURL function. This eliminates an O(n^2) algorithm here and reduces
        the use of baseURL, part of preparation to move it from StyleBase
        to CSSStyleSheet.

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::setImageProperty): Changed to use create
        function instead of a direct call to new for the CSSImageValue classes.
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Ditto.
        (WebCore::CSSParser::parseContent): Ditto.
        (WebCore::CSSParser::parseFillImage): Ditto.
        (WebCore::CSSParser::parseBorderImage): Ditto.

        * css/CSSStyleSelector.cpp: Removed unneeded include of CSSImageValue.h.
        * rendering/style/RenderStyle.h: Removed unneeded include of
        CSSCursorImageValue.h, which was causing us to rebuild the world way too often.

        * xml/XSLImportRule.cpp:
        (WebCore::XSLImportRule::setXSLStyleSheet): See change to CSSImportRule above.
        (WebCore::XSLImportRule::loadSheet): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-20 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 20 May 2008 15:55:23 +0000 (15:55 +0000)]
2008-05-20  Kevin McCullough  <kmccullough@apple.com>

        Rubber stamped by Adam.

        -Minor fix. Should not use a reference since the original may disappear.

        * page/Console.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fixes for PluginViewWx.cpp and WebKit/wx/WebView.cpp
kevino@webkit.org [Tue, 20 May 2008 15:40:56 +0000 (15:40 +0000)]
wx build fixes for PluginViewWx.cpp and WebKit/wx/WebView.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoExpose the ProfileNode sorting functions on JavaScriptProfileNode.
timothy@apple.com [Tue, 20 May 2008 13:58:27 +0000 (13:58 +0000)]
Expose the ProfileNode sorting functions on JavaScriptProfileNode.

Reviewed by Kevin McCullough.

* page/JavaScriptProfileNode.cpp:
(WebCore::sortTotalTimeDescending): Call ProfileNode.
(WebCore::sortTotalTimeAscending): Ditto.
(WebCore::sortSelfTimeDescending): Ditto.
(WebCore::sortSelfTimeAscending): Ditto.
(WebCore::sortCallsDescending): Ditto.
(WebCore::sortCallsAscending): Ditto.
(WebCore::ProfileNodeClass): Add static static functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake the profiler use higher than millisecond resolution time-stamps.
timothy@apple.com [Tue, 20 May 2008 13:58:12 +0000 (13:58 +0000)]
Make the profiler use higher than millisecond resolution time-stamps.

Reviewed by Kevin McCullough.

* kjs/DateMath.cpp:
(KJS::getCurrentUTCTime): Call getCurrentUTCTimeWithMicroseconds and
floor the result.
(KJS::getCurrentUTCTimeWithMicroseconds): Copied from the previous
implementation of getCurrentUTCTime without the floor call.
* kjs/DateMath.h: Addded getCurrentUTCTimeWithMicroseconds.
* profiler/ProfileNode.cpp:
(KJS::ProfileNode::ProfileNode): Use getCurrentUTCTimeWithMicroseconds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* page/InspectorController.cpp: Change the include for
timothy@apple.com [Tue, 20 May 2008 13:57:58 +0000 (13:57 +0000)]
* page/InspectorController.cpp: Change the include for
JavaScriptProfile.h to sue double quotes instead of backets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes a bug in the profiler where call and apply would show up
timothy@apple.com [Tue, 20 May 2008 13:57:41 +0000 (13:57 +0000)]
Fixes a bug in the profiler where call and apply would show up
and double the time spent in a function. We don't want to show call
and apply at all in the profiles. This change excludes them.

Reviewed by Kevin McCullough.

* profiler/ProfileNode.cpp:
(KJS::ProfileNode::stopProfiling): Remove a second for loop and
calculate self time in the existing loop.
* profiler/Profiler.cpp:
(KJS::shouldExcludeFunction): Helper inline function that returns
true in the current function in an InternalFunctionImp and it is
has the functionName call or apply.
(KJS::Profiler::willExecute): Call shouldExcludeFunction and return
early if if returns true.
(KJS::Profiler::didExecute): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdds a DataGrid object that is used for multi-column data
timothy@apple.com [Tue, 20 May 2008 13:57:27 +0000 (13:57 +0000)]
Adds a DataGrid object that is used for multi-column data
and can contain hierarchical content with disclosure arrows.
A lot of DataGrid was copied from treeoutline.js. This change
makes the database views use the DataGrid. It will later be
used by the ProfileView.

Reviewed by Adam Roben.

* page/inspector/DataGrid.js: Added. Most copied from treeoutline.js
and modified to work with table elements.
* page/inspector/DatabaseQueryView.js:
Call DatabasesPanel.dataGridForResult and adds the inline style to
the DataGrid element.
* page/inspector/DatabaseTableView.js:
Call DatabasesPanel.dataGridForResult.
* page/inspector/DatabasesPanel.js:
(WebInspector.DatabasesPanel.prototype._tableForResult): Removed.
(WebInspector.DatabasesPanel.prototype.dataGridForResult): Added.
Similar to the previous _tableForResult function, but makes a DataGrid.
* page/inspector/inspector.css: Changes to the data-grid
style rules.
* WebCore.vcproj/WebCore.vcproj: Add DataGrid.js.
* page/inspector/WebKit.qrc: Ditto.
* page/inspector/inspector.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Tue, 20 May 2008 11:52:08 +0000 (11:52 +0000)]
2008-05-20  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Alp.

        [Gtk] Autotools should match build-webkit default flags

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agofix changelog
slewis@apple.com [Tue, 20 May 2008 07:29:40 +0000 (07:29 +0000)]
fix changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Tue, 20 May 2008 06:49:46 +0000 (06:49 +0000)]
2008-05-19  Stephanie Lewis  <slewis@apple.com>

        Explicitly set run mode to 32bit unless overridden to avoid
        confusion when running tests

        * Scripts/build-dumprendertree:
        * Scripts/gdb-safari:
        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make WebKit.idl rebuild whenever any of its included interfaces are changed
aroben@apple.com [Tue, 20 May 2008 04:00:31 +0000 (04:00 +0000)]
    Make WebKit.idl rebuild whenever any of its included interfaces are changed

        Reviewed by Tim Hatcher.

        * WebKit.vcproj/DerivedSources.make: Touch WebKit.idl whenever any
        other IDL file is changed. This will force VS to rebuild WebKit.idl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
mitz@apple.com [Tue, 20 May 2008 03:42:50 +0000 (03:42 +0000)]
    Reviewed by Adam Roben.

        - update test results following <http://trac.webkit.org/changeset/33395>

        * platform/mac/fast/frames/viewsource-attribute-expected.checksum:
        * platform/mac/fast/frames/viewsource-attribute-expected.png:
        * platform/mac/fast/frames/viewsource-attribute-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 20 May 2008 03:31:28 +0000 (03:31 +0000)]
2008-05-19  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/5770054> JavaScript profiler (10928)
        - Implement sorting by function name.

        * JavaScriptCore.exp:
        * profiler/Profile.h:
        * profiler/ProfileNode.cpp:
        * profiler/ProfileNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 20 May 2008 03:23:34 +0000 (03:23 +0000)]
2008-05-19  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        -build fix.

        * bindings/js/JSConsoleCustom.cpp:
        * page/Console.cpp:
        * page/Console.h:
        * page/Console.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 20 May 2008 03:19:04 +0000 (03:19 +0000)]
2008-05-19  Alp Toker  <alp@nuanti.com>

        Reviewed by Maciej.

        GTK+/soup fixes:

        Remove the fragment part of the URL since the file backend doesn't
        deal with it.

        Fix a typo in the cleanup function.

        * platform/network/soup/ResourceHandleSoup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
kmccullough@apple.com [Tue, 20 May 2008 02:03:14 +0000 (02:03 +0000)]

2008-05-19  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        <rdar://problem/5770054> JavaScript profiler (10928)
        - Pass the exec state to profiler when calling startProfiling so that if
        profiling is started within an execution context that location is
        recorded correctly.

        * JavaScriptCore.exp:
        * profiler/ProfileNode.cpp:
        (KJS::ProfileNode::printDataInspectorStyle): Dump more info for debugging
        * profiler/Profiler.cpp:
        * profiler/Profiler.h:


2008-05-19  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        <rdar://problem/5770054> JavaScript profiler (10928)
        - Send the executing context to the profiler so it can attribute time
        correctly to parent functions when calling profile() and profileEnd()
        while nested.

        * page/Console.cpp:
        * page/Console.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 20 May 2008 01:14:28 +0000 (01:14 +0000)]
2008-05-19  Kevin McCullough  <kmccullough@apple.com>

        Rubberstamped by Geoff.

        Turn off the profiler because it is a performance regression.

        * kjs/config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 20 May 2008 01:12:20 +0000 (01:12 +0000)]
2008-05-19  Alp Toker  <alp@nuanti.com>

        Reviewed by Anders and Beth.

        [GTK] Accessibility support with ATK/AT-SPI

        Initial ATK/AT-SPI accessibility support for the GTK+ port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Tue, 20 May 2008 00:46:32 +0000 (00:46 +0000)]

2008-05-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Support navigator.onLine from HTML5.

        Add Windows NetworkStateNotifier implementation using the IP Helper API.

        * WebCore.vcproj/WebCore.vcproj:
        * platform/network/NetworkStateNotifier.h:
        * platform/network/win/NetworkStateNotifierWin.cpp: Added.


2008-05-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Support navigator.onLine from HTML5.

        Link with iphlpapi.lib, and make iphlpapi.dll a delay loaded library.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Disable C4273, C4565 for CSSGrammar.cpp, XPathGrammar.cpp to fix build.
sfalken@apple.com [Tue, 20 May 2008 00:00:46 +0000 (00:00 +0000)]
    Disable C4273, C4565 for CSSGrammar.cpp, XPathGrammar.cpp to fix build.

        Reviewed by Adam Roben.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Bug 19065: Resources with a space in their URL don't get error/warning...
aroben@apple.com [Mon, 19 May 2008 23:52:33 +0000 (23:52 +0000)]
    Fix Bug 19065: Resources with a space in their URL don't get error/warning bubbles


        Reviewed by Dan Bernstein.

        Test: manual-tests/inspector/errors-with-space in-url.html

        * manual-tests/inspector/errors-with-space in-url.html: Added.
        * page/Console.cpp:
        Pass the raw URL to the Inspector, not the pretty URL, to match the
        URL that was used when initially telling the Inspector about this
        resource. We continue to pass the pretty URL to the ChromeClient for
        backwards compatibility.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Mon, 19 May 2008 23:22:08 +0000 (23:22 +0000)]
2008-05-19  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Darin.

        more fast teardown performance work

        * Misc/WebDownload.m:
        (-[WebDownloadInternal downloadDidBegin:]):
        (-[WebDownloadInternal downloadDidFinish:]):
        (-[WebDownloadInternal download:didFailWithError:]):
        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:

        more fast teardown performance work, WebCore plumbing

        * page/Chrome.cpp:
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/Page.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Alp Toker <alp@nuanti.com>
alp@webkit.org [Mon, 19 May 2008 23:06:49 +0000 (23:06 +0000)]
2008-05-19  Alp Toker  <alp@nuanti.com>

        GTK+ build fix for Mac/Win. Don't check for FreeType/FontConfig when
        the Pango font backend is selected.

        * GNUmakefile.am:
        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Kuchhal <kuchal@yahoo.com>
justin.garcia@apple.com [Mon, 19 May 2008 22:44:45 +0000 (22:44 +0000)]
2008-05-19  Kuchhal  <kuchal@yahoo.com>

        Reviewed by Justin.

        <rdar://problem/5863412> Crash when Ctrl C is pressed after a series of specific mouse events (18506)

        * editing/markup.cpp:
        (WebCore::createMarkup): Null check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5912195> CrashTracer: [USER] 1 crash in Mail at -[AccessibilityObject...
cfleizach@apple.com [Mon, 19 May 2008 22:17:09 +0000 (22:17 +0000)]
<rdar://problem/5912195> CrashTracer: [USER] 1 crash in Mail at -[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Mon, 19 May 2008 22:15:30 +0000 (22:15 +0000)]
2008-05-19  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/5770054> JavaScript profiler (10928)
        -In an effort to make the profiler as efficient as possible instead of
        prepending to a vector we keep the vector in reverse order and operate
        over it backwards.

        * profiler/Profile.cpp:
        * profiler/ProfileNode.cpp:
        * profiler/ProfileNode.h:
        * profiler/Profiler.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 19 May 2008 20:44:20 +0000 (20:44 +0000)]
2008-05-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin, Alexey, Jess and Brady.

        Set the application cache path.

        * WebView.cpp:
        New function that sets the cache path.

        Set the application cache path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded methods to get/set current cookie storage.
adachan@apple.com [Mon, 19 May 2008 19:55:56 +0000 (19:55 +0000)]
Added methods to get/set current cookie storage.

        Added CookieStorageWin.h/cpp, introducing methods to get/set the current CFHTTPCookieStorageRef.
        When setting cookies-related attributes in CFURLRequest, make sure we get them from the
        current CFHTTPCookieStorageRef.  Also, set the cookie storage in CFURLRequest.

        Reviewed by Steve Falkenburg.

        * WebCore.vcproj/WebCore.vcproj:
        * platform/network/cf/ResourceHandleCFNet.cpp:
        * platform/network/cf/ResourceRequestCFNet.cpp:
        * platform/network/win/CookieJarCFNetWin.cpp:
        * platform/network/win/CookieStorageWin.cpp: Added.
        * platform/network/win/CookieStorageWin.h: Added.

        Added IWebCookieManager interface which allows client to set the
        CFHTTPCookieStorageRef that WebCore should use.

        Implement IWebCookieManager interface in WebCookieManager.

        Update the cookie accept policy in the current cookie storage.

        Reviewed by Steve Falkenburg.

        * ForEachCoClass.h:
        * Interfaces/IWebCookieManager.idl: Added.
        * Interfaces/WebKit.idl:
        * WebCookieManager.cpp: Added.
        * WebCookieManager.h: Added.
        * WebKit.vcproj/WebKit.vcproj:
        * WebKitClassFactory.cpp:
        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Mon, 19 May 2008 19:21:51 +0000 (19:21 +0000)]
    Reviewed by Darin.

        SVG Encoding error with fill attribute

        This is caused by problems with data: URL loading. Besides what is fixed by this patch,
        I filed <rdar://problem/5845875> for CFNetwork.

        While at it, fixed a related javascript: URL issue.

        Tests: fast/loader/data-url-encoding-html.html

        * platform/KURL.cpp:
        (WebCore::KURL::parse): Fix a FIXME, use UTF-8 instead of dropping high bytes. This fixes
        javascript: URL handling.
        (WebCore::encodeRelativeString): Like mailto: URLs, data: ones are all UTF-8. Restructured
        the code to not search for "#" if both parts are to be encoded as UTF-8 anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Mon, 19 May 2008 19:12:55 +0000 (19:12 +0000)]
    Reviewed by Darin.

        <rdar://problem/5857369> XMLHttpRequest does not properly encode & and < in outgoing messages

        Test: http/tests/xmlhttprequest/serialize-document.html

        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::send): Use createMarkup() instead of Document::toString().

        * dom/Attr.cpp:
        * dom/Attr.h:
        * dom/Document.cpp:
        * dom/Document.h:
        * dom/DocumentFragment.cpp:
        * dom/DocumentFragment.h:
        * dom/Element.cpp:
        * dom/Element.h:
        * dom/Entity.cpp:
        * dom/Entity.h:
        * dom/EntityReference.cpp:
        * dom/EntityReference.h:
        * dom/Node.h:
        * dom/Text.cpp:
        * dom/Text.h:
        * html/HTMLElement.cpp:
        * html/HTMLElement.h:
        Removed most Node::toString() methods, which were massively wrong, and only used for
        XMLHttpRequest::send(). The remanining ones are still used in markup.cpp, but should probably
        be folded into it for consistency.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 19 May 2008 18:33:30 +0000 (18:33 +0000)]
2008-05-19  Anders Carlsson  <andersca@apple.com>

        Fix Windows build.

        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5935694> AX: crash in text marker range
cfleizach@apple.com [Mon, 19 May 2008 18:22:11 +0000 (18:22 +0000)]
<rdar://problem/5935694> AX: crash in text marker range

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 19 May 2008 17:43:16 +0000 (17:43 +0000)]
2008-05-19  Darin Adler  <darin@apple.com>

        - fix WebKit build

        * WebCore.xcodeproj/project.pbxproj: Make CSSReflectionDirection.h "private" instead of "project".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5700830> VO: VoiceOver should fall back to title attr if form element...
cfleizach@apple.com [Mon, 19 May 2008 16:56:46 +0000 (16:56 +0000)]
<rdar://problem/5700830> VO: VoiceOver should fall back to title attr if form element is not labeled

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 19 May 2008 16:42:26 +0000 (16:42 +0000)]
2008-05-19  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - tweak CSSReflectValue, possibly fixing the leaks seen on the buildbot

        * WebCore.vcproj/WebCore.vcproj: Added CSSReflectionDirection.h.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * css/CSSReflectionDirection.h: Added.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForReflection): Changed to use CSSReflectValue::create.
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseReflect): Ditto.

        * css/CSSReflectValue.h: Added a create function. Got rid of the setter
        functions, which had const PassRefPtr& arguments -- those probably caused
        the leaks although I'm not exactly sure why. Made the contructor and all
        the data members private.

        * rendering/style/RenderStyle.h: Changed to include CSSReflectionDirection.h
        instead of CSSReflectValue.h so we can tweak CSSReflectValue without
        recompiling the world.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Mon, 19 May 2008 10:17:17 +0000 (10:17 +0000)]
2008-05-19  Holger Hans Peter Freyther  <zecke@selfish.org>

        Rubber Stamped by Simon.

        Enforce the WebKit Coding Style.

        * plugins/PluginView.cpp:
        * plugins/gtk/PluginViewGtk.cpp:
        * plugins/qt/PluginViewQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-14 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk>
zecke@webkit.org [Mon, 19 May 2008 10:09:38 +0000 (10:09 +0000)]
2008-05-14  Marc Ordinas i Llopis  <marc.ordinasillopis@collabora.co.uk>

        Reviewed by Holger.

        Based also on work by Chris Lord.

        Provides support for NPAPI plugins that pass NULL as their instance
        info. There are two kinds:
        - Some call NPN_UserAgent and NPN_GetValue before a PluginView has
        been created. For those we provide static versions of those functions.
        - Others call NPN_* functions with a NULL instance inside NPP_*
        calls, for those we've added extra currentPluginView guards.

        * plugins/PluginView.cpp: Add additional currentPluginView guards and
        some small style changes.
        * plugins/PluginView.h: Added static versions of NPN_UserAgent and
        * plugins/gtk/PluginViewGtk.cpp: Add additional currentPluginView
        guards and some small style changes.
        (WebCore::PluginView::userAgentStatic): Added to deal with plugins
        that query this before having a PluginView.
        (WebCore::PluginView::getValueStatic): Added to deal with plugins
        that call this before we have created a PluginView.
        (WebCore::PluginView::getValue): Moved some code to getValueStatic.
        * plugins/npapi.cpp: Call PluginView::userAgentStatic
        and PluginView::getValueStatic if no PluginView is
        * plugins/qt/PluginPackageQt.cpp:
        (WebCore::PluginPackage::fetchInfo): Corrected split args because ignoring
        empty entries crashed.
        (WebCore::PluginPackage::load): Resolve all symbols when loading plugins
        to protect against XPCOM dependencies.
        * plugins/qt/PluginViewQt.cpp: Add additional currentPluginView guards and
        some small style changes.
        (WebCore::PluginView::userAgentStatic): Added to deal with plugins
        that query this before having a PluginView.
        (WebCore::PluginView::getValueStatic): Added to deal with plugins
        that call this before we have created a PluginView.
        (WebCore::PluginView::getValue): Moved some code to getValueStatic.
        (WebCore::PluginView::init): m_needsXEmbed init was moved to constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-19 Alp Toker <alp@nuanti.com>
alp@webkit.org [Mon, 19 May 2008 08:59:07 +0000 (08:59 +0000)]
2008-05-19  Alp Toker  <alp@nuanti.com>

        GTK+ build fix on Mac. Conditionalize XP_UNIX use.

        * plugins/gtk/PluginPackageGtk.cpp:
        * plugins/gtk/PluginViewGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5942076> WebKit can no longer find URL links with VoiceOVer-U command...
cfleizach@apple.com [Mon, 19 May 2008 03:58:08 +0000 (03:58 +0000)]
<rdar://problem/5942076> WebKit can no longer find URL links with VoiceOVer-U command (19100)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Mon, 19 May 2008 00:42:59 +0000 (00:42 +0000)]

2008-05-18  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - fix <rdar://problem/5943569> crash due to stale ownerNode pointer

        Test: fast/dom/StyleSheet/ownerNode-lifetime.html

        * bindings/js/JSStyleSheetCustom.cpp:
        (WebCore::JSStyleSheet::mark): Added code to mark ownerNode. Includes a comment about how
        it would be even better to solve this in the DOM rather than just in the JavaScript binding.

        * css/StyleSheet.idl: Added CustomMarkFunction attribute.


2008-05-18  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - test for <rdar://problem/5943569> crash due to stale ownerNode pointer

        * fast/dom/StyleSheet: Added.
        * fast/dom/StyleSheet/ownerNode-lifetime-expected.txt: Added.
        * fast/dom/StyleSheet/ownerNode-lifetime.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Sun, 18 May 2008 23:51:54 +0000 (23:51 +0000)]

2008-05-18  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19111
        Allow `delete storage.itemName` syntax as an alias for `storage.removeItem("itemName")`

        Tests: storage/domstorage/localstorage/delete-removal.html

        * bindings/js/JSStorageCustom.cpp:
        (WebCore::JSStorage::deleteProperty): Only do the delete for non-built in properties
        * storage/Storage.idl:


2008-05-18  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19111
        Allow `delete storage.itemName` syntax as an alias for `storage.removeItem("itemName")`

        * storage/domstorage/localstorage/delete-removal-expected.txt: Added.
        * storage/domstorage/localstorage/delete-removal.html: Added.
        * storage/domstorage/sessionstorage/delete-removal-expected.txt: Added.
        * storage/domstorage/sessionstorage/delete-removal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
mitz@apple.com [Sun, 18 May 2008 19:08:50 +0000 (19:08 +0000)]
    Reviewed by Sam Weinig.

        - fix <rdar://problem/5944596> IDNs are displayed as punycode in the authentication panel

        * Panels/WebAuthenticationPanel.m:
        (-[WebAuthenticationPanel setUpForChallenge:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-17 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 18 May 2008 03:41:53 +0000 (03:41 +0000)]
2008-05-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Re-factor core setRequestHeader logic into setRequestHeaderInternal.

        * xml/XMLHttpRequest.cpp:
        * xml/XMLHttpRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Sun, 18 May 2008 01:21:20 +0000 (01:21 +0000)]

2008-05-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Differentiate between cancelation errors and generic network error in XHR.

        * loader/FrameLoader.cpp:
        * platform/network/ResourceErrorBase.h:
        Add state that differentiates between errors created by cancelation and those made
        by all other generic network errors as this differentiation is needed by some specs.

        * xml/XMLHttpRequest.cpp:
        * xml/XMLHttpRequest.h:
        * xml/XMLHttpRequestException.h:
        * xml/XMLHttpRequestException.idl:
        Add ABORT_ERR. This error cannot be raised with the current WebKit architecture
        as it requires the ability to cancel a synchronous XHR, which we cannot currently
        do.  It may be possible in the future though.


2008-05-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Update expected results for new ABORT_ERR.

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-17 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Sun, 18 May 2008 00:08:02 +0000 (00:08 +0000)]
2008-05-17  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig.

        Including wtf/Platform.h or using any of the macros it defines in headers that may be
        included from outside of the WebKit project causes any project using those headers to
        fail to build.

        * page/mac/WebDashboardRegion.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-17 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 17 May 2008 22:45:11 +0000 (22:45 +0000)]
2008-05-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Brady Eidson.

        Re-factor send() logic a little to make adding cross-site requests easier.

        * xml/XMLHttpRequest.cpp:
        * xml/XMLHttpRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-16 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Sat, 17 May 2008 06:43:12 +0000 (06:43 +0000)]
2008-05-16 Stephanie Lewis <slewis@apple.com>

Reviewed by Steve.

Get pending unload event count from WebCore.

 * Interfaces/IWebFramePrivate.idl:
 * WebFrame.cpp:
 * WebFrame.h:

Print out pending unload event count. Also print out main framename to match Mac. +
* DumpRenderTree/win/FrameLoadDelegate.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-16 Matt Lilek <webkit@mattlilek.com>
pewtermoose@webkit.org [Sat, 17 May 2008 05:34:09 +0000 (05:34 +0000)]
2008-05-16  Matt Lilek  <webkit@mattlilek.com>

        Rubber stamped by Oliver.

        Remove the Drosera sub-project.

        * WebKit.vcproj/WebKit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove the Drosera project, code and resources since it has been
timothy@apple.com [Sat, 17 May 2008 04:21:22 +0000 (04:21 +0000)]
Remove the Drosera project, code and resources since it has been
replaced with the Web Inspector's debugger. Removes references to
Drosera in various scripts and makefiles.

Rubber-stamped by Mark Rowe.

* BuildSlaveSupport/build-launcher-app:
* Drosera/DebuggerDocument.cpp: Removed.
* Drosera/DebuggerDocument.h: Removed.
* Drosera/Drosera.icns: Removed.
* Drosera/DroseraWin.make: Removed.
* Drosera/English.lproj/Debugger.nib/classes.nib: Removed.
* Drosera/English.lproj/Debugger.nib/info.nib: Removed.
* Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Removed.
* Drosera/English.lproj/MainMenu.nib/classes.nib: Removed.
* Drosera/English.lproj/MainMenu.nib/info.nib: Removed.
* Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Removed.
* Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
* Drosera/ForwardingHeaders/wtf/HashTraits.h: Removed.
* Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
* Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
* Drosera/ForwardingHeaders/wtf/Platform.h: Removed.
* Drosera/ForwardingHeaders/wtf/RetainPtr.h: Removed.
* Drosera/Images/Drosera.ico: Removed.
* Drosera/Images/SourceArrow.png: Removed.
* Drosera/Images/SourceArrowBlank.png: Removed.
* Drosera/Images/SourceArrowOpen.png: Removed.
* Drosera/Images/background_stripe.png: Removed.
* Drosera/Images/breakPoint.tif: Removed.
* Drosera/Images/breakPointDisabled.tif: Removed.
* Drosera/Images/breakpointeditor.png: Removed.
* Drosera/Images/close.tif: Removed.
* Drosera/Images/close_active.tif: Removed.
* Drosera/Images/close_hover.tif: Removed.
* Drosera/Images/console.png: Removed.
* Drosera/Images/continue.tif: Removed.
* Drosera/Images/fileIcon.jpg: Removed.
* Drosera/Images/finishFunction.tif: Removed.
* Drosera/Images/glossyFooterFill.tif: Removed.
* Drosera/Images/glossyHeader.png: Removed.
* Drosera/Images/glossyHeaderPressed.png: Removed.
* Drosera/Images/gradientBackground.png: Removed.
* Drosera/Images/gutter.png: Removed.
* Drosera/Images/navLeftDisabled.png: Removed.
* Drosera/Images/navLeftNormal.png: Removed.
* Drosera/Images/navLeftPressed.png: Removed.
* Drosera/Images/navRightDisabled.png: Removed.
* Drosera/Images/navRightNormal.png: Removed.
* Drosera/Images/navRightPressed.png: Removed.
* Drosera/Images/pause.tif: Removed.
* Drosera/Images/popUpArrows.png: Removed.
* Drosera/Images/programCounter.tif: Removed.
* Drosera/Images/programCounterBreakPoint.tif: Removed.
* Drosera/Images/programCounterBreakPointDisabled.tif: Removed.
* Drosera/Images/run.tif: Removed.
* Drosera/Images/siteCollapsed.tif: Removed.
* Drosera/Images/siteExpanded.tif: Removed.
* Drosera/Images/siteIcon.tif: Removed.
* Drosera/Images/small.ico: Removed.
* Drosera/Images/splitterBar.tif: Removed.
* Drosera/Images/splitterDimple.tif: Removed.
* Drosera/Images/step.tif: Removed.
* Drosera/Images/stepOut.tif: Removed.
* Drosera/Images/stepOver.tif: Removed.
* Drosera/Images/stop.tif: Removed.
* Drosera/Images/toolbarBackground.png: Removed.
* Drosera/Images/verticalSplitterBar.tiff: Removed.
* Drosera/Images/verticalSplitterDimple.tiff: Removed.
* Drosera/Makefile: Removed.
* Drosera/breakpointEditor.html: Removed.
* Drosera/config.h: Removed.
* Drosera/console.css: Removed.
* Drosera/console.html: Removed.
* Drosera/console.js: Removed.
* Drosera/debugger.css: Removed.
* Drosera/debugger.html: Removed.
* Drosera/debugger.js: Removed.
* Drosera/mac/DebuggerApplication.h: Removed.
* Drosera/mac/DebuggerApplication.mm: Removed.
* Drosera/mac/DebuggerClient.h: Removed.
* Drosera/mac/DebuggerClient.mm: Removed.
* Drosera/mac/DebuggerDocumentPlatform.mm: Removed.
* Drosera/mac/Drosera.xcodeproj/project.pbxproj: Removed.
* Drosera/mac/Info.plist: Removed.
* Drosera/mac/LauncherInfo.plist: Removed.
* Drosera/mac/Makefile: Removed.
* Drosera/mac/ServerConnection.h: Removed.
* Drosera/mac/ServerConnection.mm: Removed.
* Drosera/mac/launcher.m: Removed.
* Drosera/mac/main.m: Removed.
* Drosera/viewer.css: Removed.
* Drosera/viewer.html: Removed.
* Drosera/win/BaseDelegate.h: Removed.
* Drosera/win/DebuggerClient.cpp: Removed.
* Drosera/win/DebuggerClient.h: Removed.
* Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
* Drosera/win/Drosera.cpp: Removed.
* Drosera/win/Drosera.h: Removed.
* Drosera/win/Drosera.vcproj/Drosera.rc: Removed.
* Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed.
* Drosera/win/DroseraPrefix.cpp: Removed.
* Drosera/win/DroseraPrefix.h: Removed.
* Drosera/win/Info.plist: Removed.
* Drosera/win/ServerConnection.cpp: Removed.
* Drosera/win/ServerConnection.h: Removed.
* Drosera/win/resource.h: Removed.
* Makefile:
* Scripts/build-drosera: Removed.
* Scripts/gdb-drosera: Removed.
* Scripts/run-drosera: Removed.
* Scripts/run-drosera-nightly.cmd: Removed.
* Scripts/run-drosera.cmd: Removed.
* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-16 Brady Eidson <beidson@apple.com>
beidson@apple.com [Sat, 17 May 2008 01:46:18 +0000 (01:46 +0000)]
2008-05-16  Brady Eidson  <beidson@apple.com>

        Reviewed by Steve Falkenburg

        <rdar://problem/5942624> - Get LocalStorage persistence working on Windows

        * WebPreferenceKeysPrivate.h: Add the LocalStorageDirectory defaults key

        * WebPreferences.cpp:
        * WebPreferences.h:
        * Interfaces/IWebPreferencesPrivate.idl:

        * WebView.cpp:
        (WebView::initWithFrame): Set the path in the WebCore::Settings after new Page creation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 17 May 2008 01:16:38 +0000 (01:16 +0000)]
2008-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Copy appcache headers.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
antti@apple.com [Sat, 17 May 2008 00:50:42 +0000 (00:50 +0000)]

2008-05-16  Antti Koivisto  <antti@apple.com>

        Reviewed by Anders.

        Fix <rdar://problem/5934400>
        Movie controller does not update on first load of http://www.apple.com/getamac/ads/

        The issue is that we execute scripts while there are still pending stylesheet loads.
        If the script depends on a stylesheet having been applied it may fail.

        This will make external script execution block on external stylesheet loads. A full
        fix (as discussed with Hyatt) will also need to block inline script execution.

        Test: http/tests/local/stylesheet-and-script-load-order-http.html

        * html/HTMLTokenizer.cpp:


2008-05-16  Antti Koivisto  <antti@apple.com>

        Reviewed by Anders.

        Test for <rdar://problem/5934400>
        Movie controller does not update on first load of http://www.apple.com/getamac/ads/

        * http/tests/local/stylesheet-and-script-load-order-http-expected.txt: Added.
        * http/tests/local/stylesheet-and-script-load-order-http.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5582483> Mail compose area needs to allow AXValue to be settable
cfleizach@apple.com [Sat, 17 May 2008 00:28:11 +0000 (00:28 +0000)]
<rdar://problem/5582483> Mail compose area needs to allow AXValue to be settable

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning.
mrowe@apple.com [Sat, 17 May 2008 00:23:34 +0000 (00:23 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-16 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Sat, 17 May 2008 00:18:32 +0000 (00:18 +0000)]
2008-05-16  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Maciej.

        track onbeforeunlaod event counts. Pretty much identical to unload event tracking.
        Also rename methods from onunload tracking to be more clear.

        increment/decrement event counts when onunload and onbeforeunload events are added/removed
        * dom/Document.cpp:
        * dom/Document.h:

        clear onunload count after unload events are dispatched
        * loader/FrameLoader.cpp:

        track onunload and onbeforeunload event counts for each frame
        * page/EventHandler.cpp:
        * page/EventHandler.h:

        clear unbeforeunload count after unbeforeunload events are detached
        * page/Frame.cpp:

        track total event count at page level
        * page/Page.cpp:
        * page/Page.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Sat, 17 May 2008 00:07:15 +0000 (00:07 +0000)]

2008-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        REGRESSION: fast/loader/xmlhttprequest-missing-file-exception.html fails on Windows.

        Replicate the Mac behavior when a sync load fails.

        * platform/network/cf/ResourceHandleCFNet.cpp:


2008-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        REGRESSION: fast/loader/xmlhttprequest-missing-file-exception.html fails on Windows.

        Remove test from skipped list.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 16 May 2008 23:26:20 +0000 (23:26 +0000)]
2008-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        Parse and set the headers on the response.

        * loader/appcache/ApplicationCacheStorage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemoves WebScriptDebugServer files and related calls. This removes
timothy@apple.com [Fri, 16 May 2008 22:53:38 +0000 (22:53 +0000)]
Removes WebScriptDebugServer files and related calls. This removes
the hooks that Drosera uses for debugging. Now that the Web Inspector
has a better debugger, we don't need these anymore.

Reviewed by Sam Weinig.

* DefaultDelegates/WebScriptDebugServer.h: Removed.
* DefaultDelegates/WebScriptDebugServer.m: Removed.
* DefaultDelegates/WebScriptDebugServerPrivate.h: Removed.
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebKit.exp:
* WebView/WebScriptDebugDelegate.mm:
* WebView/WebScriptDebugger.mm:
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
* WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdds the "this" object to the Local scope section of the
timothy@apple.com [Fri, 16 May 2008 22:30:12 +0000 (22:30 +0000)]
Adds the "this" object to the Local scope section of the
Scope Variables pane.

<rdar://problem/5774773> Web Inspector doesn't show the "this"
object in its variables list (10438)

Reviewed by Oliver Hunt.

* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::thisObject): Returns the thisObject
of the JavaScriptCallFrame impl. Returns jsNull if the impl is invalid.
* page/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::thisObject): Return the thisValue from
the ExecState. Return 0 if m_exec is null.
* page/JavaScriptCallFrame.h:
* page/JavaScriptCallFrame.idl: Add thisObject.
* page/inspector/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection): Adds two new arguments.
The ignoreHasOwnProperty tells the section to show all properties,
including inherited ones. And extraProperties is an object of
additional properties to show.
(WebInspector.ObjectPropertiesSection.prototype): Honor the
extraProperties and ignoreHasOwnProperty properties.
* page/inspector/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane.prototype.update): Add a this
property to an extra object that is passed to the ObjectPropertiesSection.
Also pass true for ignoreHasOwnProperty since we want to show all properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 16 May 2008 22:26:58 +0000 (22:26 +0000)]
2008-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        Add mimeType and textEncodingName to the resource table.

        * loader/appcache/ApplicationCacheStorage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
kmccullough@apple.com [Fri, 16 May 2008 22:23:09 +0000 (22:23 +0000)]

2008-05-16  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/5770054> JavaScript profiler (10928)
        Implement sorting for the profiler.
        I chose to sort the profileNodes in place since there is no reason they
        need to retain their original order.

        * JavaScriptCore.exp: Export the symbols.
        * profiler/Profile.h: Add the different ways a profile can be sorted.
        * profiler/ProfileNode.cpp: Implement those ways.
        * profiler/ProfileNode.h: No longer use a Deque since it cannot be
        sorted by std::sort and there was no reason not to use a Vector.  I
        previously had though I would do prepending but am not.
        * profiler/Profiler.cpp: Removed these functions as they can be called
        directoy on the Profile object after getting the Vector of them.
        * profiler/Profiler.h:


2008-05-16  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/5770054> JavaScript profiler (10928)
        Use a Vector instead of a Deque since we don't use the extra capabilities
        of the Deque.

        * page/JavaScriptProfileNode.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-16 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 16 May 2008 22:19:43 +0000 (22:19 +0000)]
2008-05-16  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        <rdar://problem/5942616> - Need to standardize LocalStorage persistence path

        Took the opportunity to touch up another pref that needs the same standardization.
        That pref is currently not in use on Mac.

        * WebView/WebPreferences.m:
        (-[WebPreferences _setFTPDirectoryTemplatePath:]):
        (-[WebPreferences _localStorageDatabasePath]):
        (-[WebPreferences _setLocalStorageDatabasePath:]):
        (-[WebPreferences _ftpDirectoryTemplatePath]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the build.
timothy@apple.com [Fri, 16 May 2008 21:30:59 +0000 (21:30 +0000)]
Fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 16 May 2008 21:24:45 +0000 (21:24 +0000)]
2008-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        Add a version table to the database.

        * loader/appcache/ApplicationCacheStorage.cpp:
        * loader/appcache/ApplicationCacheStorage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRestore some ChangeLog entries I nuked in the previous commits.
timothy@apple.com [Fri, 16 May 2008 21:10:46 +0000 (21:10 +0000)]
Restore some ChangeLog entries I nuked in the previous commits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdds the ability to evaluate expressions in the local scope
timothy@apple.com [Fri, 16 May 2008 20:47:22 +0000 (20:47 +0000)]
Adds the ability to evaluate expressions in the local scope
of the selected call frame.


Reviewed by Geoff Garen.

* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::evaluate): Pass the exception
from evaluate to the calling ExecState.
* page/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate): Added an exception out
argument. Simplified the code by calling KJS:eval directly.
* page/JavaScriptCallFrame.h: Change evalutate to take an exception
out argument.
* page/inspector/Console.js: Check if the debugger is paused and
call evaluateInSelectedCallFrame on the Scripts panel.
* page/inspector/ScriptsPanel.js: Added a paused getter and
evaluateInSelectedCallFrame which does the evaluation and updates
the scope variables pane afterwards.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed the bug where the Inspector node highlight would not show
timothy@apple.com [Fri, 16 May 2008 20:47:09 +0000 (20:47 +0000)]
Fixed the bug where the Inspector node highlight would not show
in the correct place for nodes in frames.

<rdar://problem/5712834> Elements in iframes are highlighted incorrectly (14408)

Reviewed by John Sullivan.

* page/InspectorController.cpp:
(WebCore::convertFromFrameToMainFrame): Helper function to convert
IntRect coordinates from one frame to the main frame.
(WebCore::InspectorController::drawNodeHighlight): Call the
convertFromFrameToMainFrame helper for all the rects we get from
the node since they are in the owner frame's coordinate space.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdds an error and warning count indicator at the bottom right in the
timothy@apple.com [Fri, 16 May 2008 20:46:57 +0000 (20:46 +0000)]
Adds an error and warning count indicator at the bottom right in the
Inspector's status bar.


Initial implementation by Adam Roben.
Reviewed by Sam Weinig.

Test: manual-tests/inspector/error-warning-count.html

* English.lproj/localizedStrings.js: Added new strings.
* manual-tests/inspector/error-warning-count.html: Added.
* page/inspector/Console.js:
(WebInspector.Console.prototype.show): Don't do anything if visible.
(WebInspector.Console.prototype.hide): Don't do anything if hidden.
Temporally set properties and classes to mimic the post-animation
values so panels like Elements in their updateStatusBarItems call will
size things to fit the final location.
* page/inspector/ElementsPanel.js:
Account for the #error-warning-count width when sizing breadcrumbs.
* page/inspector/Resource.js:
(WebInspector.Resource.prototype.set errors): Update the global error count.
(WebInspector.Resource.prototype.set warnings): Update the global warning count.
* page/inspector/inspector.css: Make .hidden's display property
!important to ensure things really hide, and added styling for the new
* page/inspector/inspector.html: Added an #error-warning-count div
in the #anchored-status-bar-items div.
* page/inspector/inspector.js:
(WebInspector.get errors): Added.
(WebInspector.set errors): Added. Calls _updateErrorAndWarningCounts.
(WebInspector.get warnings): Added.
(WebInspector.set warnings): Added. Calls _updateErrorAndWarningCounts.
(WebInspector._updateErrorAndWarningCounts): Added. Update the
(WebInspector.loaded): Add a click event listener to the
_updateErrorAndWarningCounts to display the initial error/warning counts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
jchaffraix@webkit.org [Fri, 16 May 2008 20:38:48 +0000 (20:38 +0000)]

2008-05-16  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Preparatory work for bug 9191: JS*ElementWrapperFactory should be autogenerated

        Make video tags use a header guard so that make_names.pl for factory generation.

        - Add video tag guard in HTMLTagNames.in & give an extraDefines parameter to make_names.pl
        when generating HTMLNames.

        - Modify the different build systems to accomodate the new parameter.

        - Small make_names.pl clean up (mainly code generated coding style issue).

        * DerivedSources.make: Add HTML_FLAGS and pass it to make_names.pl
        if it is defined (similar to SVG)

        * GNUmakefile.am: Add HTML_FEATURES & HTML_FLAGS and pass it to
        make_names.pl if HTML_FLAGS is defined.

        * WebCore.pro: Pass $${DEFINES} to make_names.pl.

        * dom/make_names.pl:
        * html/HTMLElement.cpp:
        (WebCore::inlineTagList): Add ENABLE(VIDEO) guard.
        * html/HTMLTagNames.in: Ditto.

2008-05-16  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Preparatory work for bug 9191: JS*ElementWrapperFactory should be autogenerated

        * configure.ac: Add HTML_FLAGS and set it when video is enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 16 May 2008 18:47:03 +0000 (18:47 +0000)]
2008-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Fire progress events.

        * loader/appcache/ApplicationCacheGroup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 16 May 2008 17:28:58 +0000 (17:28 +0000)]
2008-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jess.

        Add manifest MIME type.

        * .htaccess:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 16 May 2008 17:27:59 +0000 (17:27 +0000)]
2008-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by John.

        Handle the case where the main resource load is cancelled while the cache attempt is in progress.

        * loader/DocumentLoader.cpp:
        Tell the group that the main resource failed to load.

        * loader/appcache/ApplicationCacheGroup.cpp:
        Call cacheUpdateFailed.

        Stop loading if the update failed.

        * loader/appcache/ApplicationCacheGroup.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5710317> REGRESSION:Selecting ranges of text should be possible using...
cfleizach@apple.com [Fri, 16 May 2008 17:26:23 +0000 (17:26 +0000)]
<rdar://problem/5710317> REGRESSION:Selecting ranges of text should be possible using the keyboard (15310)

Adds support to select text ranges when enhanced accessibility is turned on

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 16 May 2008 17:25:22 +0000 (17:25 +0000)]
2008-05-15  Anders Carlsson  <andersca@apple.com>

        Update test results now that navigator.onLine exists.

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-15 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 16 May 2008 14:25:57 +0000 (14:25 +0000)]
2008-05-15  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Since WebKitGtk is fully using autotools now, clean-up the .pro/.pri files
        from gtk-port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Gtk build.
hausmann@webkit.org [Fri, 16 May 2008 07:22:22 +0000 (07:22 +0000)]
Fix the Gtk build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Qt build.
hausmann@webkit.org [Fri, 16 May 2008 07:12:34 +0000 (07:12 +0000)]
Fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt.
rwlbuis@webkit.org [Fri, 16 May 2008 07:10:26 +0000 (07:10 +0000)]
    Reviewed by Dave Hyatt.

        getComputedStyle() -> clip returns empty string

        Make getComputedStyle return a shape value for clip
        if it is set.

        Tests: fast/css/getPropertyValue-clip.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. Add rendering/style to includes dir.
kevino@webkit.org [Fri, 16 May 2008 05:53:47 +0000 (05:53 +0000)]
wx build fix. Add rendering/style to includes dir.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-15 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 16 May 2008 05:10:32 +0000 (05:10 +0000)]
2008-05-15  Kevin McCullough  <kmccullough@apple.com>

        - Build fix.

        * JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-15 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Fri, 16 May 2008 03:27:24 +0000 (03:27 +0000)]
2008-05-15  Alice Liu  <alice.liu@apple.com>

        Reviewed by Beth Dakin.

        Fixed <rdar://problem/5882283> Implement ARIA aria-activedescendant
        Also added support for aria roles listbox and option, and aria-selected,
        and aria-multiselectable for listboxes

        * dom/Element.cpp:
        * dom/Element.h:
        * dom/StyledElement.cpp:
        * html/HTMLAttributeNames.in:
        * page/AXObjectCache.cpp:
        * page/AXObjectCache.h:
        * page/AccessibilityListBox.cpp:
        * page/AccessibilityListBox.h:
        * page/AccessibilityListBoxOption.h:
        * page/AccessibilityObject.cpp:
        * page/AccessibilityObject.h:
        * page/AccessibilityRenderObject.cpp:
        * page/AccessibilityRenderObject.h:
        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes a bug in the view source parsing of text within <script>,
timothy@apple.com [Fri, 16 May 2008 03:20:44 +0000 (03:20 +0000)]
Fixes a bug in the view source parsing of text within <script>,
<style>, <xmp>, <textarea> and other special tags. The text was
being parsed as HTML and would be syntax highlighted if a "<"
was encountered.

<rdar://problem/5790805> Inspector's source view missing some words,
doubles others in JS source in <script> tag (17752)

Reviewed by Dave Hyatt.

Added test: fast/frames/viewsource-plain-text-tags.html

* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::scriptHandler): Set scriptCodeSize and
scriptCodeResync to zero before an early return in view source mode.
This was causing text from a previous script tag to show up in
then next style tag.
(WebCore::HTMLTokenizer::parseTag): Enter an if block in view source
mode even if n is null. The n is property guarded in other places
and not used by view source mode. Removes a redundant null check on n.
Add a new null check of n before setting scriptSrcCharset. Other code
in HTMLTokenizer is already guarded for this code path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoChanges the Web Inspector node highlight to be less aggressive
timothy@apple.com [Fri, 16 May 2008 03:20:25 +0000 (03:20 +0000)]
Changes the Web Inspector node highlight to be less aggressive
and only highlight when hovering over the selected node in the DOM
tree or breadcrumbs. You can highlight on hover for any node if
you hold down the Alt/Option key while hovering.

Reviewed by Kevin McCullough.

* page/inspector/ElementsPanel.js:
* page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-15 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 16 May 2008 02:51:33 +0000 (02:51 +0000)]
2008-05-15  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/5770054> JavaScript profiler (10928)
        - Cache some values to save on computing them repetitively. This will be
        a big savings when we sort since we won't have to walk the tree for
        every comparison!
        - We cache these values when we end profiling because otherwise we won't
        know which profile to get the totalTime for the whole profile from without
        retaining a reference to the head profile or looking up the profile from
        the list of all profiles.
        - Also it's safe to assume we won't be asked for these values while we
        are still profiling since the WebInspector only get's profileNodes from
        profiles that are in the allProfiles() list and a profile is only added
        to that list after it has finished and these values will no longer

        * JavaScriptCore.exp:
        * profiler/ProfileNode.cpp:
        * profiler/ProfileNode.h:
        * profiler/Profiler.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-15 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Fri, 16 May 2008 02:37:00 +0000 (02:37 +0000)]
2008-05-15  Stephanie Lewis  <slewis@apple.com>

        fix mac build

        * WebView/WebView.mm:
        (-[WebView closeWithFastTeardown]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-15 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Fri, 16 May 2008 02:31:14 +0000 (02:31 +0000)]
2008-05-15  Stephanie Lewis  <slewis@apple.com>

        Fix windows build

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-15 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Fri, 16 May 2008 01:07:49 +0000 (01:07 +0000)]
2008-05-15  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Anders.

        Turn on fast teardown.  I added a preference for using full teardown because
        the LEAKS output will be useless without a full teardown.

        preference for fullteardown
        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.m:
        (-[WebPreferences setFullDocumentTeardownEnabled:]):
        (-[WebPreferences fullDocumentTeardownEnabled]):
        * WebView/WebPreferencesPrivate.h:

        on application quit dispatch unload events and destroy plugins then exit
        * WebView/WebView.mm:
        (-[WebView closeWithFastTeardown]):
        (-[WebView _close]):
        * WebView/WebViewPrivate.h:

       export a symbol needed for fast teardown

        * WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-15 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Fri, 16 May 2008 00:51:54 +0000 (00:51 +0000)]
2008-05-15  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Anders.

        Keep track on pending unload event counts

        No change in behavior so no new tests, but I am dumping the
        unload event count to track the new variable.

        * WebCore.base.exp:

        increment/decrement the count when an event is added/removed
        * dom/Document.cpp:
        * dom/Document.h:

        set the count to 0 for each frame after the unload event has been dispatched
        * loader/FrameLoader.cpp:

        keep track of the number of pending unload events for the eventHandler's frame
        * page/EventHandler.cpp:
        * page/EventHandler.h:

        keep track of the total number of pending unload events for all of the frames
        * page/Page.cpp:

        get the pending frame unload count from WebCore

        * WebView/WebFrame.mm:
        (-[WebFrame _pendingFrameUnloadEventCount]):
        * WebView/WebFramePrivate.h:

        Dump the unload count for a frame after parsing is finished.

        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):

        Dump unload event counts for frames.

        * fast/dom/Window/get-set-properties-expected.txt:
        * fast/events/onunload-expected.txt:
        * fast/events/onunload-not-on-body-expected.txt:
        * fast/events/onunload-window-property-expected.txt:
        * fast/forms/button-state-restore-expected.txt:
        * fast/history/history_reload-expected.txt:
        * fast/loader/onunload-form-submit-crash-2-expected.txt:
        * fast/loader/onunload-form-submit-crash-expected.txt:
        * http/tests/xmlhttprequest/xhr-onunload-expected.txt:
        * platform/mac/fast/loader/start-load-in-unload-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-15 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Thu, 15 May 2008 23:40:12 +0000 (23:40 +0000)]
2008-05-15  Steve Falkenburg  <sfalken@apple.com>

        Fix build.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-15 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Thu, 15 May 2008 23:39:36 +0000 (23:39 +0000)]
2008-05-15  John Sullivan  <sullivan@apple.com>

        Reviewed by Kevin Decker

        - fixed <rdar://problem/5940275> Inspector highlighting moves to bottom-left corner of
          screen when new tab appears

        The highlight should go away entirely, but this simple patch just makes it not jump away.
        The issue with it not going away entirely is harder to fix and covered by <rdar://problem/5322306>

        * WebInspector/WebNodeHighlight.m:
        (-[WebNodeHighlight _repositionHighlightWindow]):
        Bail out if target view isn't in a window

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-15 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Thu, 15 May 2008 23:37:33 +0000 (23:37 +0000)]
2008-05-15  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Anders.

        Track views that contain plugin instances so that they can be destroyed at application
        quit without walking the entire document tree.

        Add/Remove Netscape plugin views from instance list.  Start/stop are when netscape
        plugins are created and destroyed
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView start]):
        (-[WebBaseNetscapePluginView stop]):

        Add/remove WebKit plugin views from instance list
        * Plugins/WebPluginController.mm:
        (-[WebPluginController addPlugin:]):
        (-[WebPluginController destroyPlugin:]):
        (-[WebPluginController destroyAllPlugins]):

        Add a set of views with plugin instances to the WebPluginDatabase
        * Plugins/WebPluginDatabase.h:
        * Plugins/WebPluginDatabase.mm:
        (-[WebPluginDatabase init]):
        (-[WebPluginDatabase dealloc]):
        (-[WebPluginDatabase addPluginInstanceView:]):
        (-[WebPluginDatabase removePluginInstanceView:]):
        (-[WebPluginDatabase removePluginInstanceViewsFor:]):
        (-[WebPluginDatabase destroyAllPluginInstanceViews]):

        Handle cases where plugin views are detached before the plugin is destroyed.
        * WebCoreSupport/WebFrameLoaderClient.mm:

        Add plugin instances to the set in the WebPluginDatabase by way of the WebView
        * WebView/WebHTMLView.mm:

        * WebView/WebHTMLViewInternal.h:
        * WebView/WebView.mm:
        (-[WebView addPluginInstanceView:]):
        (-[WebView removePluginInstanceView:]):
        (-[WebView removePluginInstanceViewsFor:]):
        * WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit/mac:
beidson@apple.com [Thu, 15 May 2008 23:10:35 +0000 (23:10 +0000)]

2008-05-15  Brady Eidson  <beidson@apple.com>

        Reviewed by Tim Hatcher

        Until the settings/preferences equation can be reworked, we'll need to manually set the local storage path
        before setting the page group of the new page.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]): Set the LocalStorage path
          immediately after creating the page so it is in place for initializing the LocalStorageThread


2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Tim Hatcher

        Until the settings/preferences equation can be reworked, we'll need to manually set the local storage path
        before setting the page group of the new page.

        Since I still need to add the local storage path to WebPreferences on Windows, mark this with a FIXME for now.

        * WebView.cpp:
        (WebView::initWithFrame): Mark an important FIXME for setting the LocalStorage path as
          appropriate.  Until this FIXME is handled, Windows will have no persistent LocalStorage

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-15 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Thu, 15 May 2008 23:03:47 +0000 (23:03 +0000)]
2008-05-15  Steve Falkenburg  <sfalken@apple.com>

        Fix build.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-15 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Thu, 15 May 2008 22:25:33 +0000 (22:25 +0000)]
2008-05-15  Steve Falkenburg  <sfalken@apple.com>

        Fix build.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
ddkilzer@apple.com [Thu, 15 May 2008 21:08:08 +0000 (21:08 +0000)]

        Bug 19085: font-family: initial sets font-family differently than font: initial


        Reviewed by David Hyatt.

        Test: fast/css/font-family-initial.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Don't set family if first
        family of initial font description is empty.


        Bug 19085: font-family: initial sets font-family differently than font: initial


        Reviewed by David Hyatt.

        * fast/css/font-family-initial-expected.txt: Added.
        * fast/css/font-family-initial.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-15 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 15 May 2008 21:00:25 +0000 (21:00 +0000)]
2008-05-15  David Hyatt  <hyatt@apple.com>

        Move RenderStyle into a new subdirectory, rendering/style/, in preparation for breaking it up into
        a bunch of smaller files.

        Reviewed by Dan Bernstein

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * rendering/RenderStyle.cpp: Removed.
        * rendering/RenderStyle.h: Removed.
        * rendering/style: Added.
        * rendering/style/RenderStyle.cpp: Copied from rendering/RenderStyle.cpp.
        * rendering/style/RenderStyle.h: Copied from rendering/RenderStyle.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix leaks when stopping a page from loading
ddkilzer@apple.com [Thu, 15 May 2008 20:42:11 +0000 (20:42 +0000)]
    Fix leaks when stopping a page from loading

        Patch suggested by Antti.  Reviewed by Antti.

        * loader/DocLoader.cpp:
        (WebCore::DocLoader::clearPreloads): If a resource is in m_preloads but
        never made it to the cache, delete it to prevent it from leaking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33494 268f45cc-cd09-0410-ab3c-d52691b4dbfc