WebKit-https.git
8 years agoConvert CSS and Parser tests to runs/s tests
rniwa@webkit.org [Mon, 14 May 2012 21:19:51 +0000 (21:19 +0000)]
Convert CSS and Parser tests to runs/s tests
https://bugs.webkit.org/show_bug.cgi?id=86399

Reviewed by Ojan Vafai.

Use runPerSecond instead of run to measure results in function calls per second (run/s) instead of time (ms).
This allows us to continue measuring performance reliably even when WebKit's performance improves and results
become too small for Date.now()'s precision (around 15 ms).

It should also reduce perf. bots cycle time for slower tests because we limit the number of function calls by time.

* CSS/CSSPropertySetterGetter.html:
* CSS/CSSPropertyUpdateValue.html:
* Parser/css-parser-yui.html:
* Parser/simple-url.html:
* Parser/tiny-innerHTML.html:
* Parser/url-parser.html:
* Parser/xml-parser.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove redundant pixel snapping in calculateCompositedBounds()
simon.fraser@apple.com [Mon, 14 May 2012 21:12:38 +0000 (21:12 +0000)]
Remove redundant pixel snapping in calculateCompositedBounds()
https://bugs.webkit.org/show_bug.cgi?id=86400

Reviewed by Sam Weinig.

RenderLayer::calculateLayerBounds() returns a pixel-snapped rect,
so we don't need to pixel-snap it again.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Layout Test svg/carto.net/window.svg is failing
schenney@chromium.org [Mon, 14 May 2012 21:10:02 +0000 (21:10 +0000)]
[chromium] Layout Test svg/carto.net/window.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=84810

Unreviewed Chromium test expectations update.

* platform/chromium-linux/svg/carto.net/window-expected.png:
* platform/chromium-mac-leopard/svg/carto.net/window-expected.png:
* platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
* platform/chromium-mac/svg/carto.net/window-expected.png:
* platform/chromium-win/svg/carto.net/window-expected.png:
* platform/chromium-win/svg/carto.net/window-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/efl/svg/carto.net/window-expected.txt: Removed.
* platform/gtk/svg/carto.net/window-expected.txt: Removed.
* svg/carto.net/window-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] android/WebInputEventFactory should handle wheel events and gesture events
abarth@webkit.org [Mon, 14 May 2012 21:04:10 +0000 (21:04 +0000)]
[Chromium] android/WebInputEventFactory should handle wheel events and gesture events
https://bugs.webkit.org/show_bug.cgi?id=86270

Reviewed by Eric Seidel.

* public/android/WebInputEventFactory.h:
* src/android/WebInputEventFactory.cpp:
(WebKit::WebInputEventFactory::keyboardEvent):
(WebKit::WebInputEventFactory::mouseEvent):
(WebKit):
(WebKit::WebInputEventFactory::mouseWheelEvent):
(WebKit::WebInputEventFactory::gestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAvoid logging related to setting shadow-related properties on a transform-only layer
simon.fraser@apple.com [Mon, 14 May 2012 20:58:39 +0000 (20:58 +0000)]
Avoid logging related to setting shadow-related properties on a transform-only layer
https://bugs.webkit.org/show_bug.cgi?id=86398

Reviewed by Dan Bernstein.

When making a CATransformLayer to support transform-style: preserve-3d, avoid trying
to set filters on the transform layer. We should never have this combination,
because filters force flattening to occur.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::ensureStructuralLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116983.
commit-queue@webkit.org [Mon, 14 May 2012 20:52:05 +0000 (20:52 +0000)]
Unreviewed, rolling out r116983.
http://trac.webkit.org/changeset/116983
https://bugs.webkit.org/show_bug.cgi?id=86397

Does not compile on chromium-win (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14

Source/WebCore:

* WebCore.gypi:
* page/TouchAdjustment.cpp:

Source/WebKit/chromium:

* features.gypi:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe "plug-in was blocked" callback needs to include enough info to uniquely identify...
andersca@apple.com [Mon, 14 May 2012 20:49:54 +0000 (20:49 +0000)]
The "plug-in was blocked" callback needs to include enough info to uniquely identify the plug-in + version
https://bugs.webkit.org/show_bug.cgi?id=86395
<rdar://problem/11447652>

Reviewed by John Sullivan.

Add the plug-in identifier and version string to the didFail client callback.

* UIProcess/API/C/WKPage.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didFailToInitializePlugin):
Pass a null plug-in identifier and version here since we don't have the plug-in information here.

(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
* UIProcess/WebLoaderClient.h:
(WebLoaderClient):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[SVG] Nothing should be stroked when the stroke-width is 0
schenney@chromium.org [Mon, 14 May 2012 20:48:43 +0000 (20:48 +0000)]
[SVG] Nothing should be stroked when the stroke-width is 0
https://bugs.webkit.org/show_bug.cgi?id=83568

Unreviewed Chromium test expectations update.

* platform/chromium-linux/svg/custom/path-zero-strokewidth-expected.png:
* platform/chromium-mac/svg/custom/js-update-style-expected.png:
* platform/chromium-mac/svg/custom/path-zero-strokewidth-expected.png: Modified property svn:mime-type.
* platform/chromium-win/svg/custom/js-update-style-expected.png:
* platform/chromium-win/svg/custom/path-zero-strokewidth-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Added more detail to marked test failure for chromium.
jianli@chromium.org [Mon, 14 May 2012 20:39:46 +0000 (20:39 +0000)]
Unreviewed. Added more detail to marked test failure for chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix typo in expectations file causing lint to fail.
dpranke@chromium.org [Mon, 14 May 2012 20:20:49 +0000 (20:20 +0000)]
Fix typo in expectations file causing lint to fail.

Unreviewed, build fix.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a line layout performance test
mitz@apple.com [Mon, 14 May 2012 20:16:32 +0000 (20:16 +0000)]
Add a line layout performance test
https://bugs.webkit.org/show_bug.cgi?id=86216

Reviewed by Ryosuke Niwa.

* Layout/line-layout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic should specify which types of baselines to rebaseline
dpranke@chromium.org [Mon, 14 May 2012 20:11:23 +0000 (20:11 +0000)]
garden-o-matic should specify which types of baselines to rebaseline
https://bugs.webkit.org/show_bug.cgi?id=86242

Reviewed by Adam Barth.

This change modifies garden-o-matic so that we are explicit
about whether to rebaseline the text file, the image file, or
both. This should prevent us from pulling incorrect or
unexpected baselines off the bots.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
(.):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
(AbstractRebaseliningCommand.__init__):
(RebaselineTest):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest.execute):
(OptimizeBaselines):
(OptimizeBaselines._optimize_baseline):
(OptimizeBaselines.execute):
(AnalyzeBaselines):
(AnalyzeBaselines._analyze_baseline):
(AnalyzeBaselines.execute):
(RebaselineExpectations._rebaseline_port):
* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.rebaseline):
(GardeningHTTPRequestHandler.optimizebaselines):
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaseline):
(GardeningServerTest.test_rebaseline_new_port):
(GardeningServerTest.test_optimizebaselines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] ASSERT failure in FrameView::paintContents when refleshing www.thestar...
commit-queue@webkit.org [Mon, 14 May 2012 20:09:41 +0000 (20:09 +0000)]
[BlackBerry] ASSERT failure in FrameView::paintContents when refleshing thestar.com/iphone
https://bugs.webkit.org/show_bug.cgi?id=86391

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-05-14
Reviewed by Adam Treat.

PR 156992
Request layout first if needed before painting contents.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPagination splits lines that could fit on a single page if it were not for their...
mitz@apple.com [Mon, 14 May 2012 20:04:37 +0000 (20:04 +0000)]
Pagination splits lines that could fit on a single page if it were not for their top leading
https://bugs.webkit.org/show_bug.cgi?id=86388

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/split-in-top-margin.html

When a line’s visible content fits on a page, but adding the top leading makes it taller than
a page, instead of giving up and splitting the line in an arbitrary position, add a strut
to push it downwards so that the split occurs in the top leading, and the visible content is
fully contained on a single page.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustLinePositionForPagination):

LayoutTests:

* fast/multicol/split-in-top-margin-expected.html: Added.
* fast/multicol/split-in-top-margin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed - remove a Chromium test expectation. Regressed (with others) by r115582,
jsbell@chromium.org [Mon, 14 May 2012 19:52:16 +0000 (19:52 +0000)]
Unreviewed - remove a Chromium test expectation. Regressed (with others) by r115582,
the specific test (storage/indexeddb/noblobs.html) was fixed in r116337.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't append log lines while perf tests are running.
tony@chromium.org [Mon, 14 May 2012 19:28:47 +0000 (19:28 +0000)]
Don't append log lines while perf tests are running.
https://bugs.webkit.org/show_bug.cgi?id=86028

Reviewed by Ryosuke Niwa.

In some tests, the extra DOM nodes can cause the test timing to change.
Avoid adding DOM nodes until the test is over. When running in a browser,
we append nodes as we run so the user can have some feedback.

* resources/runner.js:
(PerfTestRunner.log): Store the log lines in an array until the test is finished.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Compute the best target node on a GestureTap event
commit-queue@webkit.org [Mon, 14 May 2012 19:24:16 +0000 (19:24 +0000)]
[chromium] Compute the best target node on a GestureTap event
https://bugs.webkit.org/show_bug.cgi?id=85101

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-14
Reviewed by Adam Barth.

Source/WebCore:

Using tests in the touchadjustment/ directory.

* WebCore.gypi:
Include TouchAdjustment.* files.
* page/TouchAdjustment.cpp:
Included math.h because of an 'Undeclared identifier: INFINITY' when
this patch was landed before.

Source/WebKit/chromium:

* features.gypi:
Enable the touch adjustment code by default.
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
In the case of a GestureTap, deltaX represents the horizontal padding of the touch
area and deltaY represents the vertical padding of the touch area.

LayoutTests:

* platform/chromium/test_expectations.txt:
The flaky tests in touchadjustment/ have been addressed in WK86218.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] Fix WebCore library path
commit-queue@webkit.org [Mon, 14 May 2012 19:14:03 +0000 (19:14 +0000)]
[EFL][DRT] Fix WebCore library path
https://bugs.webkit.org/show_bug.cgi?id=86355

Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-14
Reviewed by Dirk Pranke.

Currently EFL DRT uses wrong WebCore library path when running DRT.
This patch simply adjusted it.

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_webcore_library):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Mark one test as failed on chromium.
jianli@chromium.org [Mon, 14 May 2012 19:12:24 +0000 (19:12 +0000)]
Unreviewed. Mark one test as failed on chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add compositor debug asserts for blocked main thread
enne@google.com [Mon, 14 May 2012 19:10:19 +0000 (19:10 +0000)]
[chromium] Add compositor debug asserts for blocked main thread
https://bugs.webkit.org/show_bug.cgi?id=86384

Reviewed by James Robinson.

Source/WebCore:

Where we depend for thread-safety that the main thread is blocked,
assert that this is actually the case.

* platform/graphics/chromium/cc/CCProxy.cpp:
(WebCore):
(WebCore::CCProxy::isMainThreadBlocked):
(WebCore::CCProxy::setMainThreadBlocked):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
(WebCore):
(DebugScopedSetMainThreadBlocked):
(WebCore::DebugScopedSetMainThreadBlocked::DebugScopedSetMainThreadBlocked):
(WebCore::DebugScopedSetMainThreadBlocked::~DebugScopedSetMainThreadBlocked):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::stop):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::beginFrame):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):

Source/WebKit/chromium:

For tests that are just on the impl tree, pretend that the main thread
is always blocked.

* tests/CCLayerTreeHostImplTest.cpp:
(CCLayerTreeHostImplTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPatch by Swapna P <spottabathini@innominds.com> on 2012-05-14
commit-queue@webkit.org [Mon, 14 May 2012 19:06:54 +0000 (19:06 +0000)]
Patch by Swapna P <spottabathini@innominds.com> on 2012-05-14
Reviewed by Eric Seidel.

Bug: Cannot resize frames because frameborder=0
https://bugs.webkit.org/show_bug.cgi?id=23750

Source/WebCore:

Removed check for frameborder, in order to allow resize of frames even in case of frameborder=0.

Test: fast/frames/frames-with-frameborder-zero-can-be-resized.html

* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::startResizing):
(WebCore::RenderFrameSet::canResizeRow):
(WebCore::RenderFrameSet::canResizeColumn):

LayoutTests:

Added test case to test whether the frame can be resized when frameborder=0.

* fast/frames/frames-with-frameborder-zero-can-be-resized-expected.txt: Added.
* fast/frames/frames-with-frameborder-zero-can-be-resized.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore gardening after r115846.
jchaffraix@webkit.org [Mon, 14 May 2012 19:03:42 +0000 (19:03 +0000)]
More gardening after r115846.

The rebaselining was partially done. Removed the expected TEXT failures from our Mac bots
and rebaselined more platforms.

* platform/chromium-linux-x86/fast/forms/form-element-geometry-expected.txt: Removed.
* platform/chromium-linux-x86/fast/forms/input-value-expected.txt: Removed.
* platform/chromium-linux-x86/fast/table/colspanMinWidth-vertical-expected.txt: Removed.
* platform/chromium-linux-x86/fast/text/textIteratorNilRenderer-expected.txt: Removed.
* platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
* platform/chromium-linux/fast/forms/input-value-expected.txt:
* platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.txt: Added.
* platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.txt:
* platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix. Don't adjust calls per iteration in the second run.
rniwa@webkit.org [Mon, 14 May 2012 18:59:03 +0000 (18:59 +0000)]
Build fix. Don't adjust calls per iteration in the second run.

* resources/runner.js:
(PerfTestRunner._perSecondRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnify RenderMathMLSquareRoot.cpp and RenderMathMLRoot.cpp
commit-queue@webkit.org [Mon, 14 May 2012 18:57:34 +0000 (18:57 +0000)]
Unify RenderMathMLSquareRoot.cpp and RenderMathMLRoot.cpp
https://bugs.webkit.org/show_bug.cgi?id=86319

Patch by David Barton <dbarton@mathscribe.com> on 2012-05-14
Reviewed by Darin Adler.

Source/WebCore:

Most of RenderMathMLSquareRoot.cpp is duplicated in RenderMathMLRoot.cpp and can be
eliminated. We also define RenderMathMLRoot::computePreferredLogicalWidths().

Test: mathml/presentation/mroot-pref-width.html

* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths):
(WebCore::RenderMathMLRoot::layout):
(WebCore::RenderMathMLRoot::paint):
* rendering/mathml/RenderMathMLRoot.h:
* rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot):
(WebCore::RenderMathMLSquareRoot::addChild):
* rendering/mathml/RenderMathMLSquareRoot.h:

LayoutTests:

* mathml/presentation/mroot-pref-width.html: Added.
* platform/mac/mathml/presentation/mroot-pref-width-expected.png: Added.
* platform/mac/mathml/presentation/mroot-pref-width-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Shadow DOM][Refactoring] HTMLContentSelector family should have better name
morrita@google.com [Mon, 14 May 2012 18:54:22 +0000 (18:54 +0000)]
[Shadow DOM][Refactoring] HTMLContentSelector family should have better name
https://bugs.webkit.org/show_bug.cgi?id=86064

Reviewed by Dimitri Glazkov.

This change renames classes around shadow content distribution.
- Renamed HTMLContentSelector to ContentDistributor
- Renamed HTMLContentSelectionList to ContentDistribution
- Renamed HTMLContentSelection to ContentDistribution::Item
- Inlined HTMLContentSelectionSet into ContentDistributor

Associated rename and inlining are also happening for method names.

No new tests. No behavior change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseParent):
* dom/ElementShadow.cpp:
(WebCore::ElementShadow::ElementShadow):
(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::insertionPointFor):
(WebCore::ElementShadow::distributionItemFor):
(WebCore::ElementShadow::recalcStyle):
(WebCore::ElementShadow::needsRedistributing):
(WebCore::ElementShadow::hostChildrenChanged):
(WebCore::ElementShadow::setNeedsRedistributing):
* dom/ElementShadow.h:
(WebCore):
(ElementShadow):
(WebCore::ElementShadow::distributor):
(WebCore::ElementShadow::clearNeedsRedistributing):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::nextRendererOfInsertionPoint):
(WebCore::previousRendererOfInsertionPoint):
(WebCore::firstRendererOfInsertionPoint):
(WebCore::lastRendererOfInsertionPoint):
* dom/ShadowRoot.cpp:
* dom/ShadowRoot.h:
(WebCore):
* html/shadow/ContentDistributor.cpp: Renamed from Source/WebCore/html/shadow/HTMLContentSelector.cpp.
(WebCore):
(WebCore::ContentDistribution::ContentDistribution):
(WebCore::ContentDistribution::~ContentDistribution):
(WebCore::ContentDistribution::find):
(WebCore::ContentDistribution::clear):
(WebCore::ContentDistribution::append):
(WebCore::ContentDistributor::ContentDistributor):
(WebCore::ContentDistributor::~ContentDistributor):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::clearDistribution):
(WebCore::ContentDistributor::findFor):
(WebCore::ContentDistributor::findInsertionPointFor):
(WebCore::ContentDistributor::willDistribute):
(WebCore::ContentDistributor::didDistribute):
(WebCore::ContentDistributor::preparePoolFor):
* html/shadow/ContentDistributor.h: Added.
(WebCore):
(ContentDistribution):
(Item):
(WebCore::ContentDistribution::Item::insertionPoint):
(WebCore::ContentDistribution::Item::node):
(WebCore::ContentDistribution::Item::next):
(WebCore::ContentDistribution::Item::previous):
(WebCore::ContentDistribution::Item::create):
(WebCore::ContentDistribution::Item::Item):
(WebCore::ContentDistribution::first):
(WebCore::ContentDistribution::last):
(WebCore::ContentDistribution::firstNode):
(WebCore::ContentDistribution::lastNode):
(WebCore::ContentDistribution::isEmpty):
(ContentDistributor):
(Translator):
(WebCore::ContentDistributor::Translator::hash):
(WebCore::ContentDistributor::Translator::equal):
(WebCore::ContentDistributor::Hash::hash):
(WebCore::ContentDistributor::Hash::equal):
(Hash):
(WebCore::ContentDistributor::inDistribution):
(WebCore::ContentDistributor::poolIsReady):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::parseAttribute):
* html/shadow/HTMLContentSelector.h: Removed.
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::distributeHostChildren):
(WebCore::InsertionPoint::clearDistribution):
(WebCore::InsertionPoint::attachDistributedNode):
(WebCore::InsertionPoint::assignShadowRoot):
(WebCore::InsertionPoint::clearAssignment):
* html/shadow/InsertionPoint.h:
(WebCore::InsertionPoint::distribution):
(WebCore::InsertionPoint::hasDistribution):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] ImageDiff should be build for host on Android
commit-queue@webkit.org [Mon, 14 May 2012 18:26:41 +0000 (18:26 +0000)]
[Chromium] ImageDiff should be build for host on Android
https://bugs.webkit.org/show_bug.cgi?id=82039

Patch by Wei James <james.wei@intel.com> on 2012-05-14
Reviewed by Adam Barth.

Source/WTF:

* WTF.gyp/WTF.gyp:

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixup: Two of the touch-adjustment tests are flaky
commit-queue@webkit.org [Mon, 14 May 2012 18:18:50 +0000 (18:18 +0000)]
Fixup: Two of the touch-adjustment tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=86218

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-14
Reviewed by Darin Adler.

One test cases was still not working all platforms.
Change used font to Ahem to have stable layout across platforms.

* touchadjustment/touch-inlines.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r116796): Assertion failure in API tests
kling@webkit.org [Mon, 14 May 2012 18:17:02 +0000 (18:17 +0000)]
REGRESSION(r116796): Assertion failure in API tests
<http://webkit.org/b/86378>
<rdar://problem/10777218>

Reviewed by Anders Carlsson.

Invalidate the plugin work queue in ~WebContext to avoid hitting
the !m_isValid assertion in ~WorkQueue later on.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::~WebContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116969.
kling@webkit.org [Mon, 14 May 2012 18:14:26 +0000 (18:14 +0000)]
Unreviewed, rolling out r116969.
http://trac.webkit.org/changeset/116969
https://bugs.webkit.org/show_bug.cgi?id=86386

i accidentally the icondatabase (Requested by kling on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14

Source/WebCore:

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::retainedPageURLCount):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::syncThreadMainLoop):
* loader/icon/IconDatabase.h:
(IconDatabase):

Source/WebKit2:

* UIProcess/WebContext.cpp:
(WebKit::WebContext::~WebContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r116796): Assertion failure in API tests
kling@webkit.org [Mon, 14 May 2012 18:04:17 +0000 (18:04 +0000)]
REGRESSION(r116796): Assertion failure in API tests
<http://webkit.org/b/86378>
<rdar://problem/10777218>

Reviewed by Anders Carlsson.

Invalidate the plugin work queue in ~WebContext to avoid hitting
the !m_isValid assertion in ~WorkQueue later on.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::~WebContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Unreviewed trivial buildfix after r116958.
ossy@webkit.org [Mon, 14 May 2012 17:54:58 +0000 (17:54 +0000)]
[Qt][WK2] Unreviewed trivial buildfix after r116958.

* UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Updating email for committers.py script.
joone@webkit.org [Mon, 14 May 2012 17:48:40 +0000 (17:48 +0000)]
Unreviewed. Updating email for committers.py script.

Patch by Joone Hur <joone@webkit.org> on 2012-05-14

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline after r115846.
jchaffraix@webkit.org [Mon, 14 May 2012 17:46:33 +0000 (17:46 +0000)]
Unreviewed rebaseline after r115846.

Those are layers additions & baselines churns due to sharing or splitting
between ports.

* fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
* fast/repaint/lines-with-layout-delta-expected.txt: Added.
* fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
* fast/repaint/repaint-resized-overflow-expected.txt: Added.
* fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
* fast/repaint/subtree-root-clip-2-expected.png: Added.
* fast/repaint/subtree-root-clip-expected.png: Added.
* platform/chromium-linux-x86/fast/forms/form-element-geometry-expected.txt: Added.
* platform/chromium-linux-x86/fast/forms/input-value-expected.txt: Added.
* platform/chromium-linux-x86/fast/layers: Removed.
* platform/chromium-linux-x86/fast/repaint/inline-relative-positioned-expected.txt: Added.
* platform/chromium-linux-x86/fast/replaced/replaced-breaking-expected.txt: Added.
* platform/chromium-linux-x86/fast/table/colspanMinWidth-vertical-expected.txt: Added.
* platform/chromium-linux-x86/fast/text/textIteratorNilRenderer-expected.txt: Added.
* platform/chromium-mac-leopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
* platform/chromium-mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/inline-relative-positioned-expected.txt:
* platform/chromium-mac/fast/repaint/lines-with-layout-delta-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.txt: Removed.
* platform/chromium-mac/fast/replaced/replaced-breaking-expected.txt: Removed.
* platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.txt: Removed.
* platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt: Removed.
* platform/chromium-win-vista/fast/layers: Removed.
* platform/chromium-win-vista/fast/repaint/inline-relative-positioned-expected.txt: Added.
* platform/chromium-win-xp/fast/layers: Removed.
* platform/chromium-win-xp/fast/repaint/inline-relative-positioned-expected.txt: Added.
* platform/chromium-win/editing/spelling/inline_spelling_markers-expected.txt:
* platform/chromium-win/fast/forms/form-element-geometry-expected.txt:
* platform/chromium-win/fast/forms/input-value-expected.txt:
* platform/chromium-win/fast/layers/remove-layer-with-nested-stacking-expected.txt:
* platform/chromium-win/fast/repaint/inline-relative-positioned-expected.txt:
* platform/chromium-win/fast/repaint/lines-with-layout-delta-expected.txt:
* platform/chromium-win/fast/repaint/repaint-resized-overflow-expected.txt:
* platform/chromium-win/fast/repaint/subtree-layoutstate-transform-expected.txt:
* platform/chromium-win/fast/repaint/subtree-root-skipped-expected.txt:
* platform/chromium-win/fast/replaced/replaced-breaking-expected.txt:
* platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
* platform/chromium-win/fast/text/textIteratorNilRenderer-expected.txt:
* platform/chromium/fast/layers: Removed.
* platform/chromium/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
* platform/chromium/fast/repaint/overflow-clip-subtree-layout-expected.txt: Removed.
* platform/chromium/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
* platform/chromium/fast/repaint/subtree-root-clip-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/efl/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
* platform/efl/fast/repaint/lines-with-layout-delta-expected.txt: Removed.
* platform/efl/fast/repaint/overflow-clip-subtree-layout-expected.png: Removed.
* platform/efl/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
* platform/efl/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
* platform/efl/fast/repaint/subtree-root-clip-2-expected.png: Removed.
* platform/efl/fast/repaint/subtree-root-clip-expected.png: Removed.
* platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
* platform/gtk/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
* platform/gtk/fast/repaint/lines-with-layout-delta-expected.txt: Removed.
* platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.png: Removed.
* platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.txt: Removed.
* platform/gtk/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
* platform/gtk/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
* platform/gtk/fast/repaint/subtree-root-clip-2-expected.png: Removed.
* platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
* platform/gtk/fast/repaint/subtree-root-clip-expected.png: Removed.
* platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Removed.
* platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
* platform/qt/fast/repaint/overflow-clip-subtree-layout-expected.txt: Removed.
* platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
* platform/qt/fast/repaint/subtree-root-clip-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Remove ewk_view_core_page_get().
rakuco@webkit.org [Mon, 14 May 2012 17:45:05 +0000 (17:45 +0000)]
[EFL] Remove ewk_view_core_page_get().
https://bugs.webkit.org/show_bug.cgi?id=86326

Reviewed by Antonio Gomes.

Right now, we have both ewk_view_core_page_get() and
EWKPrivate::corePage() doing the same thing, but the latter is
better encapsulated.

Remove the former then.

* WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
(WebCore::AcceleratedCompositingContext::syncLayersNow): Add
missing ewk_private.h and use EWKPrivate::corePage().
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::createWindow): Use
EWKPrivate::corePage().
* ewk/ewk_private.h: Remove ewk_view_core_page_get() declaration.
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(EWKPrivate::corePage): Fix coding style while here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[wx] Unreviewed build fixes for wxMSW build.
kevino@webkit.org [Mon, 14 May 2012 17:30:40 +0000 (17:30 +0000)]
[wx] Unreviewed build fixes for wxMSW build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[wx] Unreviewed build fix. Fix for wxMSW windows.h load order bug.
kevino@webkit.org [Mon, 14 May 2012 17:27:24 +0000 (17:27 +0000)]
[wx] Unreviewed build fix. Fix for wxMSW windows.h load order bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<video> won't load when URL ends with .php
eric.carlson@apple.com [Mon, 14 May 2012 17:17:40 +0000 (17:17 +0000)]
<video> won't load when URL ends with .php
https://bugs.webkit.org/show_bug.cgi?id=86308

Source/WebCore:

Reviewed by NOBODY (OOPS!).

Test: http/tests/media/video-query-url.html

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::MediaPlayer): Initialize m_typeInferredFromExtension.
(WebCore::MediaPlayer::load): Set m_typeInferredFromExtension appropriately.
(WebCore::MediaPlayer::loadWithNextMediaEngine): If we don't find a media engine registered
    for a MIME type, and the type was inferred from the extension, give the first registered
    media engine a chance anwyay just as we do when there is no MIME type at all.
* platform/graphics/MediaPlayer.h: Add m_typeInferredFromExtension.

LayoutTests:

Reviewed by Darin Adler.

* http/tests/media/resources/load-video.php: Added.
* http/tests/media/video-query-url-expected.txt: Added.
* http/tests/media/video-query-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: do not update $0-$4 console variables for the objects from loaded...
loislo@chromium.org [Mon, 14 May 2012 17:12:11 +0000 (17:12 +0000)]
Web Inspector: do not update $0-$4 console variables for the objects from loaded from file heap snapshot.
https://bugs.webkit.org/show_bug.cgi?id=86371

When the user selects an object in HeapSnapshot we are updating $0 variable in console API.
But if the snapshot was loaded from file then we can't map object id for the selected obect
from the snapshot to the live objects in the inspected page.

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._inspectedObjectChanged):
(WebInspector.HeapSnapshotView.prototype._updateFilterOptions):
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.canSaveToFile):
(WebInspector.HeapProfileHeader.prototype.saveToFile):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader):
(WebInspector.ProfileHeader.prototype.loadFromFile):
(WebInspector.ProfileHeader.prototype.fromFile):
(WebInspector.ProfilesPanel.prototype._loadFromFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Simplify OTHER_FILES for QML tests project files
vestbo@webkit.org [Mon, 14 May 2012 16:44:19 +0000 (16:44 +0000)]
[Qt] Simplify OTHER_FILES for QML tests project files

Reviewed by Jocelyn Turcotte.

* UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
* UIProcess/API/qt/tests/qmltests/WebView.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Extensions API] allow extensions to evaluate in the context of their...
caseq@chromium.org [Mon, 14 May 2012 16:34:15 +0000 (16:34 +0000)]
Web Inspector: [Extensions API] allow extensions to evaluate in the context of their content scripts
https://bugs.webkit.org/show_bug.cgi?id=86361

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/extensions/extensions-eval-content-script.html

* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression): Added evaluateOptions optional parameter.
(injectedExtensionAPI.InspectedWindow.prototype.eval):
(injectedExtensionAPI.extractCallbackArgument): A helper to extract callback function from last argument.
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionSidebarPane.prototype.setExpression): Added evaluateOptions optional parameter.
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onSetSidebarContent): Use ExtensionServer.evaluate() wrapper.
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage): Ditto.
(WebInspector.ExtensionServer.prototype._normalizePath):
(WebInspector.ExtensionServer.prototype.evaluate): A wrapper for PageAgent.evaluate() that handles evaluateOptions.
* inspector/front-end/JavaScriptContextManager.js:
(WebInspector.JavaScriptContextManager.prototype.contextByFrameAndSecurityOrigin): Expose interface to locate context id by frame and content script security origin.
(WebInspector.FrameEvaluationContext.prototype._addExecutionContext): Maintain contexts sorted by name.
(WebInspector.FrameEvaluationContext.prototype.isolatedContexts): ditto (skip sorting when returning contexts)
(WebInspector.FrameEvaluationContext.prototype.contextBySecurityOrigin):
* inspector/front-end/inspector.js: Hold/expose javaScriptContextManager.

LayoutTests:

* inspector/extensions/extensions-eval-content-script-expected.txt: Added.
* inspector/extensions/extensions-eval-content-script.html: Added.
* platform/gtk/test_expectations.txt:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix make distcheck.
carlosgc@webkit.org [Mon, 14 May 2012 16:10:01 +0000 (16:10 +0000)]
Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

* GNUmakefile.list.am: Add missing header file.

Source/WebKit2:

* GNUmakefile.am: Explicitly link WebProcess to
libjavascriptcoregtk to make sure it uses the non installed
library.
* GNUmakefile.list.am: Add missing header file.

Tools:

* GNUmakefile.am: Add run-api-tests script to EXTRA_DIST.
* gtk/run-api-tests:
(TestRunner._lookup_atspi2_binary): Handle the case when
pkg_config_file_variable() return None.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSSRegions]Convert render-region-custom-style-mark to ref test
mihnea@adobe.com [Mon, 14 May 2012 16:06:41 +0000 (16:06 +0000)]
[CSSRegions]Convert render-region-custom-style-mark to ref test
https://bugs.webkit.org/show_bug.cgi?id=86289

Reviewed by Andreas Kling.

This test verifies that:
- If an element is displayed in a region with a region styling rule, that rule is applied.
- If an element is collected into a named flow and we add a region (with a region style rule) to display the named flow,
that region styling rule is applied.
- If an element is displayed in a region with a region styling rule, and the region element is changed into a non-region,
the region styling rule is not applied.

* fast/regions/render-region-custom-style-mark-expected.html: Added.
* fast/regions/render-region-custom-style-mark.html:
* platform/chromium-linux/fast/regions/render-region-custom-style-mark-expected.png: Removed.
* platform/chromium-mac-leopard/fast/regions/render-region-custom-style-mark-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
* platform/chromium-mac/fast/regions/render-region-custom-style-mark-expected.png: Removed.
* platform/chromium-win/fast/regions/render-region-custom-style-mark-expected.png: Removed.
* platform/chromium-win/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
* platform/gtk/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
* platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.png: Removed.
* platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
* platform/mac/fast/regions/render-region-custom-style-mark-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: preserve tab index while widening / shrinking tabbed pane area.
pfeldman@chromium.org [Mon, 14 May 2012 15:53:05 +0000 (15:53 +0000)]
Web Inspector: preserve tab index while widening / shrinking tabbed pane area.
https://bugs.webkit.org/show_bug.cgi?id=86359

Reviewed by Vsevolod Vlasov.

After the drag'n'drop reorder, we should preserve tab index while widening /
shrinking the tabbed pane area.

* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype._innerCloseTab):
(WebInspector.TabbedPane.prototype._showTabElement):
(WebInspector.TabbedPane.prototype._hideTabElement):
(WebInspector.TabbedPane.prototype._updateTabsDropDown):
(WebInspector.TabbedPane.prototype.elementsToRestoreScrollPositionsFor):
(WebInspector.TabbedPane.prototype._insertBefore):
(WebInspector.TabbedPaneTab):
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabDragging):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Update expectations after fix for 84846
schenney@chromium.org [Mon, 14 May 2012 15:48:17 +0000 (15:48 +0000)]
[Chromium] Update expectations after fix for 84846
https://bugs.webkit.org/show_bug.cgi?id=86374

Unreviewed Chromium test expectations update.

* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Request / response headers should be stored in name-value pairs array...
vsevik@chromium.org [Mon, 14 May 2012 15:44:05 +0000 (15:44 +0000)]
Web Inspector: Request / response headers should be stored in name-value pairs array, not a map on front-end.
https://bugs.webkit.org/show_bug.cgi?id=86357

Reviewed by Pavel Feldman.

Source/WebCore:

Storing headers as name-value pairs array information more accurate and allows
to treat Set-Cookie headers (which become not parseable when joined by comma) correctly.

* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype._isCompressed):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.hasResponseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeaderMatch):
* inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype._buildRequest):
(WebInspector.HAREntry.prototype._buildResponse):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._headersMapToHeadersArray):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithRequest):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithResponse):
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.get transferSize):
(WebInspector.NetworkRequest.prototype.get requestHeaders):
(WebInspector.NetworkRequest.prototype.get requestHeadersText):
(WebInspector.NetworkRequest.prototype.get responseHeaders):
(WebInspector.NetworkRequest.prototype.get responseHeadersText):
(WebInspector.NetworkRequest.prototype._headerValue):
* inspector/front-end/RequestHeadersView.js:
(WebInspector.RequestHeadersView.prototype._refreshRequestHeaders):
(WebInspector.RequestHeadersView.prototype._refreshResponseHeaders):
(WebInspector.RequestHeadersView.prototype._refreshHeaders):
* platform/chromium/support/WebHTTPLoadInfo.cpp:
(WebKit::addHeader):

LayoutTests:

* http/tests/inspector/resource-har-conversion.html:
* http/tests/inspector/resource-har-headers-expected.txt:
* http/tests/inspector/resource-har-headers.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/JavaScriptCore: DFG JIT didn't work with ARM EABI.
commit-queue@webkit.org [Mon, 14 May 2012 15:35:38 +0000 (15:35 +0000)]
Source/JavaScriptCore: DFG JIT didn't work with ARM EABI.
https://bugs.webkit.org/show_bug.cgi?id=84449

Patch by Yong Li <yoli@rim.com> on 2012-05-14
Reviewed by Filip Pizlo.

Add a 32-bit dummy argument for some callOperation()
methods to make it work for ARM EABI.

* dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::callOperation):

Source/WTF: DFG JIT is not ARM EABI compatible
https://bugs.webkit.org/show_bug.cgi?id=84449

Patch by Yong Li <yoli@rim.com> on 2012-05-14
Reviewed by Filip Pizlo.

Add COMPILER_SUPPORTS(EABI) when __ARM_EABI__
or __EABI__ is defined.

* wtf/Compiler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] [WK2] Memory leaks in WebKitWebSettings
commit-queue@webkit.org [Mon, 14 May 2012 15:33:05 +0000 (15:33 +0000)]
[GTK] [WK2] Memory leaks in WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=86365

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-14
Reviewed by Martin Robinson.

Fix memory leaks in WebKitWebSettings by adopting allocations
using adoptWK.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_init):
(webkit_settings_set_serif_font_family):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Gtk][DOM Bindings] Feature-protected interface usage in set/get property must be...
commit-queue@webkit.org [Mon, 14 May 2012 15:28:24 +0000 (15:28 +0000)]
[Gtk][DOM Bindings] Feature-protected interface usage in set/get property must be under condition guards
https://bugs.webkit.org/show_bug.cgi?id=86060

Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-05-14
Reviewed by Martin Robinson.

Property set/get functions generated was referencing WebCore::interface without any condition guard.
This issue was triggered usually when an interface gets disabled; For instance; --disable-video, disables WebCore::HTMLMediaElement.
Also updated the GObject binding reference tests

No new tests - covered by existing bindings tests

* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperties):
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
(webkit_dom_test_active_dom_object_get_property):
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
(webkit_dom_test_event_constructor_get_property):
* bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
(webkit_dom_test_exception_get_property):
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_get_property):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Wrong documentation for Web Database
commit-queue@webkit.org [Mon, 14 May 2012 15:23:43 +0000 (15:23 +0000)]
[GTK] Wrong documentation for Web Database
https://bugs.webkit.org/show_bug.cgi?id=86362

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-14
Reviewed by Martin Robinson.

Fixed docs for webkit_set_default_web_database_quota().

* webkit/webkitwebdatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116935.
ossy@webkit.org [Mon, 14 May 2012 15:15:26 +0000 (15:15 +0000)]
Unreviewed, rolling out r116935.
http://trac.webkit.org/changeset/116935
https://bugs.webkit.org/show_bug.cgi?id=86373

Something is still broken (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14

* Scripts/webkitpy/common/checksvnconfigfile.py: Removed.
* Scripts/webkitpy/style/checkers/png.py:
(PNGChecker.check):
(PNGChecker):
(PNGChecker._config_file_path):
* Scripts/webkitpy/tool/commands/download.py:
(Land):
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Removed.
* Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Styles] css properties copied into clipboard contain extra line break...
apavlov@chromium.org [Mon, 14 May 2012 14:49:18 +0000 (14:49 +0000)]
Web Inspector: [Styles] css properties copied into clipboard contain extra line breaks before color values
https://bugs.webkit.org/show_bug.cgi?id=86372

Reviewed by Vsevolod Vlasov.

The "display: block" property found in the ".swatch-inner" CSS class was causing the issue
(an additional \n was rendered in the plain text value).

* inspector/front-end/inspector.css:
(.swatch-inner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] fast/loader/null-request-after-willSendRequest.html and fast/loader/recursive...
commit-queue@webkit.org [Mon, 14 May 2012 14:05:50 +0000 (14:05 +0000)]
[EFL] fast/loader/null-request-after-willSendRequest.html and fast/loader/recursive-before-unload-crash.html can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=86368

Unreviewed EFL gardening.

Remove fast/loader/null-request-after-willSendRequest.html and
fast/loader/recursive-before-unload-crash.html from skip list now that
EFL port has proper support for LayoutTestController's
dumpFrameLoadCallbacks.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-14

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Doesn't build with ENABLE_INSPECTOR=0
commit-queue@webkit.org [Mon, 14 May 2012 14:01:50 +0000 (14:01 +0000)]
[Qt] Doesn't build with ENABLE_INSPECTOR=0
https://bugs.webkit.org/show_bug.cgi?id=85056

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-14
Reviewed by Tor Arne Vestbø.

Source/WebKit2:

* Target.pri:
* UIProcess/qt/QtWebContext.cpp:
(WebKit::initInspectorServer):

Tools:

* WebKitTestRunner/TestInvocation.cpp: Ifdef otherwise unused static function.
* qmake/mkspecs/features/features.prf:
* qmake/mkspecs/features/features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Unreviewed gardening, unskip now passing tests.
ossy@webkit.org [Mon, 14 May 2012 13:58:56 +0000 (13:58 +0000)]
[Qt][WK2] Unreviewed gardening, unskip now passing tests.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] Unskipping a set of remaining media failures
commit-queue@webkit.org [Mon, 14 May 2012 13:39:01 +0000 (13:39 +0000)]
[EFL][DRT] Unskipping a set of remaining media failures
https://bugs.webkit.org/show_bug.cgi?id=86104

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-14

* platform/efl/Skipped:
* platform/efl/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
* platform/efl/media/audio-controls-rendering-expected.png:
* platform/efl/media/audio-controls-rendering-expected.txt:
* platform/efl/media/audio-repaint-expected.png:
* platform/efl/media/audio-repaint-expected.txt:
* platform/efl/media/controls-after-reload-expected.png:
* platform/efl/media/controls-after-reload-expected.txt:
* platform/efl/media/controls-strict-expected.png:
* platform/efl/media/controls-strict-expected.txt:
* platform/efl/media/controls-without-preload-expected.png:
* platform/efl/media/controls-without-preload-expected.txt:
* platform/efl/media/media-document-audio-repaint-expected.png: Added.
* platform/efl/media/media-document-audio-repaint-expected.txt: Added.
* platform/efl/media/video-controls-rendering-expected.png:
* platform/efl/media/video-controls-rendering-expected.txt:
* platform/efl/media/video-display-toggle-expected.png:
* platform/efl/media/video-display-toggle-expected.txt:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening; unskip tests fixed in r116929.
rakuco@webkit.org [Mon, 14 May 2012 13:36:17 +0000 (13:36 +0000)]
[EFL] Gardening; unskip tests fixed in r116929.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] REGRESSION (r116789): inspector/debugger/script-formatter-console.html fails
pfeldman@chromium.org [Mon, 14 May 2012 13:25:43 +0000 (13:25 +0000)]
[Qt] REGRESSION (r116789): inspector/debugger/script-formatter-console.html fails
https://bugs.webkit.org/show_bug.cgi?id=86336

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.location):

LayoutTests:

* inspector/debugger/script-formatter-breakpoints.html:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116932.
commit-queue@webkit.org [Mon, 14 May 2012 13:10:44 +0000 (13:10 +0000)]
Unreviewed, rolling out r116932.
http://trac.webkit.org/changeset/116932
https://bugs.webkit.org/show_bug.cgi?id=86364

It still fails on 32 bit platforms (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTiledBackingStore: Prevent partial tile updates when they intersect the keep rect.
jocelyn.turcotte@nokia.com [Mon, 14 May 2012 13:07:03 +0000 (13:07 +0000)]
TiledBackingStore: Prevent partial tile updates when they intersect the keep rect.
https://bugs.webkit.org/show_bug.cgi?id=85488

Reviewed by Kenneth Rohde Christiansen.

Right now an invalidate can cause problems for tiles on the boundary of the keep
rect. Intersecting the dirty rect causes only part of the tile to be updated,
and the glitch becomes visible if the user scrolls this tile back into the viewport.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::invalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] fast/viewport testcases are skipped
commit-queue@webkit.org [Mon, 14 May 2012 12:45:51 +0000 (12:45 +0000)]
[EFL][DRT] fast/viewport testcases are skipped
https://bugs.webkit.org/show_bug.cgi?id=86360

Unreviewed, unskipping now passing fast/viewport tests after
bug https://bugs.webkit.org/show_bug.cgi?id=70609 got fixed.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-14

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Make sure dialogs have their parent and attached properties set before Component...
vestbo@webkit.org [Mon, 14 May 2012 12:38:01 +0000 (12:38 +0000)]
[Qt] Make sure dialogs have their parent and attached properties set before Component.onCompleted

https://bugs.webkit.org/show_bug.cgi?id=86222

The WebView QML api for dialogs is based on delegates for each dialog, which
are implemented as components. Since there's no explicit API to show the dialog,
the natural place to allow the dialog to choose how to display itself is in
Component.onCompleted.

The issue was that we were using QQmlComponent::create() when instantiating the
component, at which point the component did not have a parent or it's attached
WebView property set. That meant that we had to do some ugly workaround in our
test, using a 1ms timer, to get a callback once the parent was there.

We now use the QQmlComponent::beginCreate() -> QQmlComponent::completeCreate()
pair, which allows us to set the relevant properties before triggering the
Component.onCompleted callback. We were already doing this for the context
menus (except for setting the parent, which we did afterwards).

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch land should automatically add svn:mime-type for .png files
ossy@webkit.org [Mon, 14 May 2012 12:31:07 +0000 (12:31 +0000)]
webkit-patch land should automatically add svn:mime-type for .png files
https://bugs.webkit.org/show_bug.cgi?id=75825
I refactored the png.py to avoid code duplication.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-05-14
Reviewed by Dirk Pranke.

* Scripts/webkitpy/common/checksvnconfigfile.py: Added.
(check):
(_config_file_path):
(errorstr_autoprop):
(errorstr_png):
* Scripts/webkitpy/style/checkers/png.py:
(PNGChecker.check):
* Scripts/webkitpy/tool/commands/download.py:
(Land):
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Added.
(AddSvnMimetypeForPng):
(AddSvnMimetypeForPng.__init__):
(AddSvnMimetypeForPng.run):
(AddSvnMimetypeForPng._check_pngs):
* Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Added.
(MockSCMDetector):
(MockSCMDetector.__init__):
(MockSCMDetector.display_name):
(AddSvnMimetypeForPngTest):
(AddSvnMimetypeForPngTest.test_run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch apply-attachment is very slow for big patches
ddkilzer@apple.com [Mon, 14 May 2012 12:08:16 +0000 (12:08 +0000)]
webkit-patch apply-attachment is very slow for big patches
https://bugs.webkit.org/show_bug.cgi?id=74929

Add "excludefield=attachmentdata" to the URL everywhere
"ctype=xml" is used to exclude this field from the XML.

Reviewed by Adam Barth.

* Scripts/prepare-ChangeLog:
(fetchBugDescriptionFromURL):
* Scripts/webkitpy/common/config/urls.py:
* Scripts/webkitpy/common/config/urls_unittest.py:
(URLsTest.test_parse_bug_id):
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.bug_url_for_bug_id):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Esc should revert the colorpicker-modifed color to the original
apavlov@chromium.org [Mon, 14 May 2012 11:42:09 +0000 (11:42 +0000)]
Web Inspector: Esc should revert the colorpicker-modifed color to the original
https://bugs.webkit.org/show_bug.cgi?id=86349

Reviewed by Vsevolod Vlasov.

A boolean parameter has been added to the Spectrum's hide() method to denote the picker cancellation,
which gets passed into the "Hidden" event listeners. StylesSidebarPane is made to remember the original property value
when the picker is opened, and restore it if the color picker is cancelled.

* inspector/front-end/Spectrum.js:
(WebInspector.Spectrum):
(WebInspector.Spectrum.prototype.toggle):
(WebInspector.Spectrum.prototype.show):
(WebInspector.Spectrum.prototype.hide):
(WebInspector.Spectrum.prototype._onKeyDown):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype.willHide):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, unskip a now passing test.
ossy@webkit.org [Mon, 14 May 2012 11:08:53 +0000 (11:08 +0000)]
[Qt] Unreviewed gardening, unskip a now passing test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] TextureMapperGL::drawTexture marked OVERRIDE but does not override any member...
zeno.albisser@nokia.com [Mon, 14 May 2012 11:03:35 +0000 (11:03 +0000)]
[Qt] TextureMapperGL::drawTexture marked OVERRIDE but does not override any member function.
https://bugs.webkit.org/show_bug.cgi?id=86347

This bug was introduced by r116834.
TextureMapperGL implements two drawTexture functions.
The first one takes a BitmapTexture as an argument and does override TextureMapper::drawTexture().
The second one takes a texture id as an argument and does not override any member function.

* platform/graphics/texmap/TextureMapperGL.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: implement tabs reordering via drag'n'drop.
pfeldman@chromium.org [Mon, 14 May 2012 09:46:33 +0000 (09:46 +0000)]
Web Inspector: implement tabs reordering via drag'n'drop.
https://bugs.webkit.org/show_bug.cgi?id=86294

Reviewed by Yury Semikhatsky.

* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):
(WebInspector.TabbedPaneTab.prototype._tabMouseDown):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu):
(WebInspector.TabbedPaneTab.prototype._tabMouseMove):
(WebInspector.TabbedPaneTab.prototype._tabDragging):
(WebInspector.TabbedPaneTab.prototype._endTabDragging):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, unskip now passing tests after r116926.
ossy@webkit.org [Mon, 14 May 2012 08:56:40 +0000 (08:56 +0000)]
[Qt] Unreviewed gardening, unskip now passing tests after r116926.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, removing test expectations for two tests that were
zandobersek@gmail.com [Mon, 14 May 2012 08:13:03 +0000 (08:13 +0000)]
Unreviewed, removing test expectations for two tests that were
fixed in r116926.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShould have Node::inDetach() for assertion purposes.
morrita@google.com [Mon, 14 May 2012 07:49:59 +0000 (07:49 +0000)]
Should have Node::inDetach() for assertion purposes.
https://bugs.webkit.org/show_bug.cgi?id=86157

Reviewed by Darin Adler.

Implemented Node::inDetach() and added an assertio in Document::setFocusedNode().
This is a follow up of r116644 which removes inDetach() checking.

No new tests. Just adding an asssertion.

* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* dom/Node.cpp:
(WebCore):
(WebCore::Node::inDetach):
(WebCore::Node::detach):
* dom/Node.h:
(Node):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntroduce PropertyName class
barraclough@apple.com [Mon, 14 May 2012 07:26:14 +0000 (07:26 +0000)]
Introduce PropertyName class
https://bugs.webkit.org/show_bug.cgi?id=86241

Reviewed by Darin Adler.

This patch introduced a couple of small bugs.

* runtime/PropertyName.h:
(JSC::toUInt32FromCharacters):
    - Returning wrong value for "" - should not convert to 0.
(JSC::PropertyName::PropertyName):
    - Remove the ASSERT, it was a little too aspirational.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG performs incorrect constant folding on double-to-uint32 conversion in
fpizlo@apple.com [Mon, 14 May 2012 06:47:24 +0000 (06:47 +0000)]
DFG performs incorrect constant folding on double-to-uint32 conversion in
Uint32Array PutByVal
https://bugs.webkit.org/show_bug.cgi?id=86330

Source/JavaScriptCore:

Reviewed by Darin Adler.

static_cast<int>(d) is wrong, since JS semantics require us to use toInt32(d).
In particular, C++ casts on typical hardware (like x86 and similar) will
return 0x80000000 for double values that are out of range of the int32 domain
(i.e. less than -2^31 or greater than or equal to 2^31). But JS semantics call
for wrap-around; for example the double value 4294967297 ought to become the
int32 value 1, not 0x80000000.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

LayoutTests:

Rubber stamped by Darin Adler.

* fast/js/dfg-uint32array-overflow-constant-expected.txt: Added.
* fast/js/dfg-uint32array-overflow-constant.html: Added.
* fast/js/script-tests/dfg-uint32array-overflow-constant.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove platform/image-decoders/xbm from WebCore.gyp
noel.gordon@gmail.com [Mon, 14 May 2012 06:44:52 +0000 (06:44 +0000)]
[chromium] Remove platform/image-decoders/xbm from WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=86333

Reviewed by Adam Barth.

No new tests. No change in behavior.

* WebCore.gyp/WebCore.gyp: Remove reference to platform/image-decoders/xbm
since that directory was removed from the repository long ago.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, skip new asserting and failing test to paint the bots...
ossy@webkit.org [Mon, 14 May 2012 06:42:57 +0000 (06:42 +0000)]
[Qt] Unreviewed gardening, skip new asserting and failing test to paint the bots green.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed test fix: these calc() tests are dumpAsText().
noel.gordon@gmail.com [Mon, 14 May 2012 06:27:58 +0000 (06:27 +0000)]
Unreviewed test fix: these calc() tests are dumpAsText().

* css3/calc/transition-crash.html:
* css3/calc/transition-crash2.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Several dom tests are failing after r116828
commit-queue@webkit.org [Mon, 14 May 2012 06:23:34 +0000 (06:23 +0000)]
[EFL] Several dom tests are failing after r116828
https://bugs.webkit.org/show_bug.cgi?id=86334

Unreviewed EFL gardening.

Move fast/dom/CSSStyleDeclaration/empty-string-property.html and
fast/dom/collection-null-like-arguments.html to test_expectations.txt.
Those tests are failing due to a regression introduced in r116828.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-13

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
zandobersek@gmail.com [Mon, 14 May 2012 05:58:58 +0000 (05:58 +0000)]
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, remove test expectations for plenty of sputnik tests that
were specific for debug builds. These tests are now consistently
passing on all the builders but that was only noticed when migration to
using test_expectations.txt was complete, meaning their test expectations
were out of date and moreover erroneous.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CG] Unneeded CFRetain/Release of CGImageRef in BitmapImage::draw
darin@apple.com [Mon, 14 May 2012 05:34:41 +0000 (05:34 +0000)]
[CG] Unneeded CFRetain/Release of CGImageRef in BitmapImage::draw
https://bugs.webkit.org/show_bug.cgi?id=86332

Reviewed by Dan Bernstein.

* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw): Don't use RetainPtr since the result of
the function is used before anything could call CFRelease on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
zandobersek@gmail.com [Mon, 14 May 2012 05:32:58 +0000 (05:32 +0000)]
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, remove test expectations for another test which
consistently passess on all the Gtk builders.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoListeners map uses raw pointers, but should use OwnPtr
darin@apple.com [Mon, 14 May 2012 05:26:17 +0000 (05:26 +0000)]
Listeners map uses raw pointers, but should use OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86298

Reviewed by Dan Bernstein.

* bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::~PageScriptDebugServer): Removed call
to deleteAllValues since the destructor now takes care of this
(WebCore::PageScriptDebugServer::addListener): Changed idiom of the add
function call here to use adoptPtr.
(WebCore::PageScriptDebugServer::removeListener): Added a now-needed
call to get and removed a now-uneeeded call to delete.
* bindings/js/PageScriptDebugServer.h: Changed the key type of
PageListenersMap to OwnPtr.

* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::~ScriptDebugServer): Removed code to delete
the values in m_pageListenersMap. This map was never used and so I have
removed it.
* bindings/js/ScriptDebugServer.h: Removed the type PageListenersMap
and the unused data member, m_pageListenersMap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoperformance tests should be able to measure runs/sec rather than time
rniwa@webkit.org [Mon, 14 May 2012 05:23:37 +0000 (05:23 +0000)]
performance tests should be able to measure runs/sec rather than time
https://bugs.webkit.org/show_bug.cgi?id=86021

Reviewed by Ojan Vafai.

PerformanceTests:

Add PerfTestRunner.runPerSecond. It uses _runLoop but replaces _runner by _perSecondRunner
to compute runs/s of runFunction.

When _perSecondRunner is called for the first time, i.e. _completedRuns is 0 (notice this is -1
in regular run/_runner), it slowly increases the number of function calls to runFunction between
time measurements in order to discount the time used by new Date() calls themselves until the
total time spent reaches 100 milliseconds.

By default, runPerSecond runs the test for at least 750 milliseconds in each run, and executes
21 runs, yielding the total run time of roughly 18 seconds. This is significantly faster than
most of existing performance tests. Also see http://ejohn.org/blog/accuracy-of-javascript-time/.

Finally, refactored the existing methods of PerfTestRunner to allow "runs/s" unit and share code.

* Layout/flexbox-column-nowrap.html:
* Layout/flexbox-column-wrap.html:
* Layout/flexbox-row-nowrap.html:
* Layout/flexbox-row-wrap.html:
* resources/runner.js:
(PerfTestRunner.computeStatistics): Takes unit.
(PerfTestRunner.logStatistics): Ditto.
(PerfTestRunner._runLoop):
(PerfTestRunner._runner):
(PerfTestRunner.runPerSecond): Added.
(PerfTestRunner._perSecondRunner): Added. Called by _runLoop.
(PerfTestRunner._perSecondRunnerIterator): Added.

Tools:

Allow " runs/s" or " ms" to appear after numerical values in tests.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):

LayoutTests:

Add tests for PerfTestRunner.runPerSecond.

* fast/harness/perftests/runs-per-second-iterations-expected.txt: Added.
* fast/harness/perftests/runs-per-second-iterations.html: Added.
* fast/harness/perftests/runs-per-second-log-expected.txt: Added.
* fast/harness/perftests/runs-per-second-log.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] Move ValidityState methods implementation to another place
commit-queue@webkit.org [Mon, 14 May 2012 04:22:44 +0000 (04:22 +0000)]
[Forms] Move ValidityState methods implementation to another place
https://bugs.webkit.org/show_bug.cgi?id=86058

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-05-13
Reviewed by Kent Tamura.

This patch changes ValidityState class for limiting scope of
number/range input type related methods for introducing decimal
arithmetic.

Methods related to validation are moved from ValidateState to
input, select and textarea elements with virtual method based
dispatching via FormAssociateElement instead of tag name
dispatching so far for code simplification.

No new tests. This patch doesn't change behavior.

* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::customError): Added. Called from ValidateState. Returns custom error mssage in member variable.
(WebCore::FormAssociatedElement::patternMismatch): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::rangeOverflow): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::rangeUnderflow): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::stepMismatch): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::tooLong): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::typeMismatch): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::valid): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::valueMissing): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::customValidationMessage): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::validationMessage): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::setCustomValidity): Added.  set custom error message.
* html/FormAssociatedElement.h:
(FormAssociatedElement): Added new instance value m_customValidationMessage.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::validationMessage): Removed. Note: HTMLInputElement, HTMLSelectElement, and HTMLTextAreaElement implement this method.
(WebCore::HTMLFormControlElement::setCustomValidity): Changed. Calls base class setCustomValidity.
* html/HTMLFormControlElement.h:
(HTMLFormControlElement):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isValidValue): Call m_inputType methods instead of HTMLInputElement's.
(WebCore::HTMLInputElement::tooLong): Call m_inputType methods instead of HTMLInputElement's.
(WebCore):
(WebCore::HTMLInputElement::typeMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::valueMissing):  Move implementation to InputType.
(WebCore::HTMLInputElement::patternMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::rangeUnderflow): Move implementation to InputType.
(WebCore::HTMLInputElement::rangeOverflow): Move implementation to InputType.
(WebCore::HTMLInputElement::validationMessage): Move implementation to InputType.
(WebCore::HTMLInputElement::stepMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::isInRange): Call m_inputType methods instead of HTMLInputElement's.
(WebCore::HTMLInputElement::isOutOfRange): Call m_inputType methods instead of HTMLInputElement's.
* html/HTMLInputElement.h:
(HTMLInputElement): Make tooLong method private.
* html/HTMLObjectElement.h: Add "virtual" and "OVERRIDE".
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::validationMessage): Added. Implementation for HTMLSelectElement.
(WebCore::HTMLSelectElement::valueMissing): Added. Implementation for HTMLSelectElement.
* html/HTMLSelectElement.h:
(HTMLSelectElement):  Added entries for newly added methods.
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::validationMessage): Added. Implementation for HTMLTextAreaElement.
(WebCore::HTMLTextAreaElement::valueMissing): Added. Implementation for HTMLTextAreaElement.
(WebCore::HTMLTextAreaElement::tooLong): Added. Implementation for HTMLTextAreaElement.
* html/HTMLTextAreaElement.h:
(HTMLTextAreaElement): Added entries for newly added methods. Change tooLong and valueMissing private.
* html/InputType.cpp:
(WebCore::InputType::stepMismatch): Change method signature.
(WebCore::InputType::alignValueForStep):  Changed for calling InputClass instead of HTMLINputElement.
(WebCore::InputType::stepUpFromRenderer):  Added. Moved from HTMLInputElement.
(WebCore::InputType::validationMessage): Added.  Moved from HTMLInputElement.
* html/InputType.h:
(InputType): Added entries for newly added methods and update methods signature.
* html/ValidityState.cpp: Move actual implementation to FormAssociatedElement and derived classes for localizing implementation change of elements and input types.
(WebCore::ValidityState::validationMessage): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::valueMissing): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::typeMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::patternMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::tooLong): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::rangeUnderflow): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::rangeOverflow): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::stepMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::customError): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::valid):
* html/ValidityState.h:
(ValidityState): Remove custom validation message related things.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHeap-use-after-free in WTF::HashMap<int, WTF::RefPtr<WebCore::CalculationValue>,...
mikelawther@chromium.org [Mon, 14 May 2012 03:30:46 +0000 (03:30 +0000)]
Heap-use-after-free in WTF::HashMap<int, WTF::RefPtr<WebCore::CalculationValue>, WTF::IntHash<unsigned int>, WTF::HashTrait
https://bugs.webkit.org/show_bug.cgi?id=85195

Source/WebCore:

This bug was caused by Length not understanding that calc expressions shouldn't be
blended - a Length with a calc expression handle was created without incrementing
the ref count of the expression. Length no longer attempts to blend calc expressions,
http://webkit.org/b/86160 has been filed to track expression blending. Fixing this fixed
the crash.

Once this was fixed, the RenderStyle diff checker thought the style was changing,
as Length didn't know how to compare calc expressions, resulting in an infinite
loop of style recalcs. Expressions can now compare themselves.

Reviewed by Darin Adler.

Tests: css3/calc/transition-crash.html
       css3/calc/transition-crash2.html

* platform/CalculationValue.h:
(WebCore::CalcExpressionNode::CalcExpressionNode):
(CalcExpressionNode):
(WebCore::CalcExpressionNode::type):
(CalculationValue):
(WebCore::CalculationValue::operator==):
(WebCore::CalcExpressionNumber::CalcExpressionNumber):
(WebCore::CalcExpressionNumber::operator==):
(CalcExpressionNumber):
(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::CalcExpressionLength::operator==):
(CalcExpressionLength):
(WebCore::CalcExpressionBinaryOperation::CalcExpressionBinaryOperation):
(WebCore::CalcExpressionBinaryOperation::operator==):
(CalcExpressionBinaryOperation):
* platform/Length.cpp:
(WebCore::Length::isCalculatedEqual):
(WebCore):
* platform/Length.h:
(WebCore::Length::operator==):
(Length):
(WebCore::Length::blend):

LayoutTests:

Reviewed by Darin Adler.

* css3/calc/transition-crash-expected.txt: Added.
* css3/calc/transition-crash.html: Added.
* css3/calc/transition-crash2-expected.txt: Added.
* css3/calc/transition-crash2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK test_expectations update.
philn@webkit.org [Mon, 14 May 2012 03:23:54 +0000 (03:23 +0000)]
Unreviewed GTK test_expectations update.

* platform/gtk/test_expectations.txt: Mark
media/video-controls-toggling.html as failing and move 2 other
media failures to the correct section.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK test_expectations update.
philn@webkit.org [Mon, 14 May 2012 01:48:15 +0000 (01:48 +0000)]
Unreviewed GTK test_expectations update.

* platform/gtk/test_expectations.txt: Flag another 2 media failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK test_expectations update.
philn@webkit.org [Mon, 14 May 2012 01:40:30 +0000 (01:40 +0000)]
Unreviewed GTK test_expectations update.

* platform/gtk/test_expectations.txt: Flag failing media test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRoll out local changes accidentally landed in r116905.
darin@apple.com [Sun, 13 May 2012 23:48:25 +0000 (23:48 +0000)]
Roll out local changes accidentally landed in r116905.

* platform/graphics/GraphicsContext.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
* platform/graphics/cg/ImageCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse emptyString instead of String("")
rwlbuis@webkit.org [Sun, 13 May 2012 23:47:02 +0000 (23:47 +0000)]
Use emptyString instead of String("")
https://bugs.webkit.org/show_bug.cgi?id=86305

Reviewed by Darin Adler.

Use emptyString() instead of String("") because it is better style and faster.

No new tests. No change in behavior.

* Modules/webdatabase/AbstractDatabase.cpp:
(WebCore::AbstractDatabase::performOpenAndVerify):
* Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::extensions):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValueFromRenderer):
* platform/SharedBufferChunkReader.cpp:
(WebCore::SharedBufferChunkReader::nextChunkAsUTF8StringWithLatin1Fallback):
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::setProxyInfo):
* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::initializeLocalizedDateFormatText):
* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::originalText):
* storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::localStorageNamespace):
* svg/SVGStringList.cpp:
(WebCore::SVGStringList::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImage::initPlatformData is always an empty function so we can remove it
darin@apple.com [Sun, 13 May 2012 23:42:24 +0000 (23:42 +0000)]
Image::initPlatformData is always an empty function so we can remove it
https://bugs.webkit.org/show_bug.cgi?id=86297

Reviewed by Dan Bernstein.

* platform/graphics/BitmapImage.h: Removed declaration of initPlatformData.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
* platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage): Ditto.
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::BitmapImage): Ditto.
* platform/graphics/chromium/ImageChromiumMac.mm: Removed empty
initPlatformData function.
* platform/graphics/efl/ImageEfl.cpp: Ditto.
* platform/graphics/gtk/ImageGtk.cpp:
* platform/graphics/mac/ImageMac.mm:
* platform/graphics/openvg/ImageOpenVG.cpp:
(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
Removed empty initPlatformData function.
* platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
Removed empty initPlatformData function.
* platform/graphics/skia/ImageSkia.cpp: Removed empty initPlatformData function.
* platform/graphics/win/ImageWin.cpp: Ditto.
* platform/graphics/wx/ImageWx.cpp: Ditto.
(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderView::selectionBounds and RenderView::setSelection use maps with raw pointers...
darin@apple.com [Sun, 13 May 2012 23:39:53 +0000 (23:39 +0000)]
RenderView::selectionBounds and RenderView::setSelection use maps with raw pointers that should be OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86300

Reviewed by Eric Seidel.

* rendering/RenderView.cpp:
(WebCore::RenderView::selectionBounds): Changed SelectionMap type to use OwnPtr.
Added code to do adoptPtr as needed and removed explicit delete code.
(WebCore::RenderView::setSelection): Changed SelectedBlockMap type to use OwnPtr.
Added code to do adoptPtr as needed and removed explicit delete code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFractionalLayoutUnit class has unneeded redundant uses of "inline" keyword
darin@apple.com [Sun, 13 May 2012 23:36:03 +0000 (23:36 +0000)]
FractionalLayoutUnit class has unneeded redundant uses of "inline" keyword
https://bugs.webkit.org/show_bug.cgi?id=86301

Reviewed by Andreas Kling.

* platform/FractionalLayoutUnit.h: Removed uses of inline for functions
defined inside a class definition. The C++ language defines that all such
functions are treated as if specified with inline, and explicitly stating
inline in addition does not add anything or change behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDangling node to ID maps vector uses raw pointers, but should use OwnPtr
darin@apple.com [Sun, 13 May 2012 23:25:04 +0000 (23:25 +0000)]
Dangling node to ID maps vector uses raw pointers, but should use OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86299

Reviewed by Pavel Feldman.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::releaseDanglingNodes): Removed now-unneeded call
to deleteAllValues since the clear function now takes care of that.
(WebCore::InspectorDOMAgent::pushNodePathToFrontend): Added code that uses
adoptPtr and release as neeed to deal with a Vector<OwnPtr>.
* inspector/InspectorDOMAgent.h: Changed m_danglingNodeToIdMaps to be
Vector<OwnPtr> instead of a vector of raw pointers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed, fix test skipped in the previous commit.
rakuco@webkit.org [Sun, 13 May 2012 21:45:41 +0000 (21:45 +0000)]
[EFL] Unreviewed, fix test skipped in the previous commit.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening; skip tests after r116900.
rakuco@webkit.org [Sun, 13 May 2012 21:43:24 +0000 (21:43 +0000)]
[EFL] Gardening; skip tests after r116900.

The patch only updated the chromium and mac expectations...

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening; skip test added in r116858.
rakuco@webkit.org [Sun, 13 May 2012 21:09:25 +0000 (21:09 +0000)]
[EFL] Gardening; skip test added in r116858.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVolume slider needs to be displayed below the mute button
commit-queue@webkit.org [Sun, 13 May 2012 19:11:51 +0000 (19:11 +0000)]
Volume slider needs to be displayed below the mute button
https://bugs.webkit.org/show_bug.cgi?id=85990

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-05-13
Reviewed by Dimitri Glazkov.

Source/WebCore:

Added back code for rendering offset, but used only when the volume slider
needs to be displayed below the controls.

Test: media/media-volume-slider-rendered-below.html

* css/mediaControlsChromium.css:
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
Changed positioning of the slider to absolute, otherwise it is not possible to position it from the layout() method.
* css/mediaControlsQuickTime.css:
Added back the double mute-button and changed the z-index of the original button. When the slider is displayed
the second mute button is actually there.
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
Added copy.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::makeTransparent): Disabled the possible of hiding controls. WebVTT rendering
in the place of controls when these are visible is not possible with the current code.
(RenderMediaVolumeSliderContainer):
(WebCore):
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaVolumeSliderContainer::layout):
Checked if the absolute coordinates of the corner of the slider would be rendered outside the page. This part of the
code is faulty if display:none is toggled on the controls.
(WebCore::MediaControlVolumeSliderContainerElement::createRenderer):
* html/shadow/MediaControlElements.h:
(MediaControlVolumeSliderContainerElement):
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::create):

LayoutTests:

Updated tests expectation and marked failing tests accordingly.

* media/media-volume-slider-rendered-below.html: Added.
* media/media-volume-slider-rendered-expected.txt: Added.
* platform/chromium/test_expectations.txt: Updated.
* platform/mac/media/audio-controls-rendering-expected.txt: Updated (z-index change).
* platform/mac/media/controls-after-reload-expected.txt: Same.
* platform/mac/media/controls-strict-expected.txt: Same.
* platform/mac/media/video-controls-rendering-expected.txt: Same.
* platform/mac/media/video-display-toggle-expected.txt: Same.
* platform/mac/media/video-playing-and-pause-expected.txt: Same.
* platform/mac/test_expectations.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Texmap] TextureMapperAnimations does not support keyframe with multiple animations
igor.o@sisa.samsung.com [Sun, 13 May 2012 17:00:50 +0000 (17:00 +0000)]
[Texmap] TextureMapperAnimations does not support keyframe with multiple animations
https://bugs.webkit.org/show_bug.cgi?id=86303

Qt and GTK, in WebKit1, use TextureMapper to store AC animations using
TextureMapperAnimations::add(keyframeName, TextureMapperAnimation). And when a
CSS animation animates several CSS properties, TextureMapperAnimations::add is
called more than once with the same keyframeName value. However, currently,
TextureMapperAnimations can not store more than one animated property in the keyframe
because it is using HashMap<String, TextureMapperAnimation>, and WebKit HashMap
does not support add the same key twice.

Reviewed by Noam Rosenthal.

* platform/graphics/texmap/TextureMapperAnimation.cpp:
(WebCore::TextureMapperAnimations::hasActiveAnimationsOfType):
(WebCore::TextureMapperAnimations::hasRunningAnimations):
(WebCore::TextureMapperAnimations::add):
(WebCore):
(WebCore::TextureMapperAnimations::pause):
(WebCore::TextureMapperAnimations::apply):
* platform/graphics/texmap/TextureMapperAnimation.h:
(TextureMapperAnimations): Use HashMap<String, Vector<TextureMapperAnimation> >,
so we can support an keyframe with multiple animations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116812.
commit-queue@webkit.org [Sun, 13 May 2012 06:07:20 +0000 (06:07 +0000)]
Unreviewed, rolling out r116812.
http://trac.webkit.org/changeset/116812
https://bugs.webkit.org/show_bug.cgi?id=86313

Appears to be causing a top crash (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-12

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
* chromium/public/WebStorageArea.h: Removed.
* chromium/public/WebStorageNamespace.h: Removed.

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebStorageArea.h:
(WebKit):
(WebStorageArea):
(WebKit::WebStorageArea::~WebStorageArea):
(WebKit::WebStorageArea::setItem):
(WebKit::WebStorageArea::removeItem):
(WebKit::WebStorageArea::clear):
* public/WebStorageNamespace.h:
(WebKit):
(WebStorageNamespace):
(WebKit::WebStorageNamespace::~WebStorageNamespace):
(WebKit::WebStorageNamespace::isSameNamespace):
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::createLocalStorageNamespace):
* src/StorageAreaProxy.cpp:
* src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespace::localStorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in HTMLSelectElement::setOption
inferno@chromium.org [Sun, 13 May 2012 04:22:42 +0000 (04:22 +0000)]
Crash in HTMLSelectElement::setOption
https://bugs.webkit.org/show_bug.cgi?id=85420

Source/WebCore:

Reviewed by Eric Seidel

RefPtr before option in HTMLSelectElement::setOption since it
can get destroyed due to mutation events.

Test: fast/dom/HTMLSelectElement/option-add-crash.html

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setOption):

LayoutTests:

Reviewed by Eric Seidel.

* fast/dom/HTMLSelectElement/option-add-crash-expected.txt: Added.
* fast/dom/HTMLSelectElement/option-add-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[wx] Restore paste implementation and fix a couple typos.
kevino@webkit.org [Sun, 13 May 2012 03:51:08 +0000 (03:51 +0000)]
[wx] Restore paste implementation and fix a couple typos.
https://bugs.webkit.org/show_bug.cgi?id=86311

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116863 268f45cc-cd09-0410-ab3c-d52691b4dbfc