WebKit-https.git
14 years agoLayoutTests:
ggaren [Tue, 25 Apr 2006 22:58:56 +0000 (22:58 +0000)]
LayoutTests:

        Reviewed by Maciej.

        Test for the DOM properties supported by object, embed, attribute:
        * fast/dom/plugin-attributes-enumeration-expected.txt: Added.
        * fast/dom/plugin-attributes-enumeration.html: Added.

        Test for setting attributes through DOM properties:
        * plugins/embed-attributes-setting-expected.txt: Added.
        * plugins/embed-attributes-setting.html: Added.

        Test for the special attribute-to-style mappings on embed.
        * plugins/embed-attributes-style-expected.txt: Added.
        * plugins/embed-attributes-style.html: Added.

WebCore:

        Reviewed by Maciej.

        - Removed special handling of attributes in the DOM. To match
        WinIE, we used to make all attributes available as properties of
        their elements in the DOM, but that has caused us more
        compatibility woes than it has solved, so, after talking with Darin
        and Maciej, I'm taking it out. (Firefox does not support it.)

        A layout test regression caused by this change led me to do the
        following as well:

        - Implemented DOM properties missing on EMBED elements: align, height,
        name, width, src, type. Since align, height, name, and width are
        common to all plugin elements, I factored them and some other common
        functionality out into a new abstract base class, HTMLPlugInElement.

        - Removed extraneous attribute-to-style mappings on EMBED elements:
        valign, border. Why they were there in the first place is a question
        for the ages. Neither FF nor IE supports them.

        * bindings/js/kjs_dom.cpp:
        (KJS::getRuntimeObject):
        * bindings/js/kjs_html.cpp:
        (KJS::):
        (KJS::JSHTMLElement::classInfo):
        (KJS::JSHTMLElement::accessors):
        (KJS::JSHTMLElement::embedGetter):
        (KJS::JSHTMLElement::embedSetter):
        * bindings/js/kjs_html.h:
        (KJS::JSHTMLElement::):
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Element.idl:
        * html/html_objectimpl.cpp:
        (WebCore::HTMLPlugInElement::HTMLPlugInElement):
        (WebCore::HTMLPlugInElement::align):
        (WebCore::HTMLPlugInElement::setAlign):
        (WebCore::HTMLPlugInElement::height):
        (WebCore::HTMLPlugInElement::setHeight):
        (WebCore::HTMLPlugInElement::name):
        (WebCore::HTMLPlugInElement::setName):
        (WebCore::HTMLPlugInElement::width):
        (WebCore::HTMLPlugInElement::setWidth):
        (WebCore::HTMLPlugInElement::mapToEntry):
        (WebCore::HTMLPlugInElement::parseMappedAttribute):
        (WebCore::HTMLPlugInElement::checkDTD):
        (WebCore::HTMLAppletElement::HTMLAppletElement):
        (WebCore::HTMLAppletElement::~HTMLAppletElement):
        (WebCore::HTMLAppletElement::parseMappedAttribute):
        (WebCore::HTMLAppletElement::insertedIntoDocument):
        (WebCore::HTMLAppletElement::removedFromDocument):
        (WebCore::HTMLAppletElement::getInstance):
        (WebCore::HTMLAppletElement::closeRenderer):
        (WebCore::HTMLAppletElement::detach):
        (WebCore::HTMLEmbedElement::HTMLEmbedElement):
        (WebCore::HTMLEmbedElement::~HTMLEmbedElement):
        (WebCore::HTMLEmbedElement::getInstance):
        (WebCore::HTMLEmbedElement::mapToEntry):
        (WebCore::HTMLEmbedElement::parseMappedAttribute):
        (WebCore::HTMLEmbedElement::attach):
        (WebCore::HTMLEmbedElement::detach):
        (WebCore::HTMLEmbedElement::insertedIntoDocument):
        (WebCore::HTMLEmbedElement::removedFromDocument):
        (WebCore::HTMLEmbedElement::src):
        (WebCore::HTMLEmbedElement::setSrc):
        (WebCore::HTMLEmbedElement::type):
        (WebCore::HTMLEmbedElement::setType):
        (WebCore::HTMLObjectElement::HTMLObjectElement):
        (WebCore::HTMLObjectElement::~HTMLObjectElement):
        (WebCore::HTMLObjectElement::getInstance):
        (WebCore::HTMLObjectElement::parseMappedAttribute):
        (WebCore::HTMLObjectElement::rendererIsNeeded):
        (WebCore::HTMLObjectElement::attach):
        (WebCore::HTMLObjectElement::closeRenderer):
        (WebCore::HTMLObjectElement::detach):
        (WebCore::HTMLObjectElement::insertedIntoDocument):
        (WebCore::HTMLObjectElement::removedFromDocument):
        (WebCore::HTMLObjectElement::recalcStyle):
        * html/html_objectimpl.h:
        (WebCore::HTMLPlugInElement::endTagRequirement):
        (WebCore::HTMLAppletElement::tagPriority):
        (WebCore::HTMLEmbedElement::tagPriority):
        (WebCore::HTMLObjectElement::tagPriority):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
tomernic [Tue, 25 Apr 2006 22:42:04 +0000 (22:42 +0000)]
    Reviewed by Eric.

        <rdar://problem/4526120> -[WebBasePluginPackage finalize] leaks the CFBundle (under GC only)

        * Plugins/WebBasePluginPackage.m:
        (-[WebBasePluginPackage finalize]):
        Release the CFBundle here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
bdakin [Tue, 25 Apr 2006 22:35:33 +0000 (22:35 +0000)]
    Reviewed by Maciej.

        Fix for <rdar://problem/4518632> getComputedStyle returns 'auto'
        for dimensions like 'margin-left'

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): For
        margin and padding, to match Firefox we now go to the renderer to
        get the property value instead of calling valueForLength() on the
        style attribute. valueForLength() will return the string 'auto' if
        that was what was specified in the CSS, or a percentage if it was
        specified as a percent. But to match Firefox, we always want to
        return a pixel value for margin and padding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-04-26 Mitz Pettel <opendarwin.org@mitzpettel.com>
eseidel [Tue, 25 Apr 2006 21:26:50 +0000 (21:26 +0000)]
2006-04-26  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed by hyatt.  Landed by eseidel.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8549
          Enable detection of excessive repainting with DumpRenderTree

        * DumpRenderTree/DumpRenderTree.m:
        (-[LayoutTestController display]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
tomernic [Tue, 25 Apr 2006 21:24:57 +0000 (21:24 +0000)]
    Reviewed by Geoff.

        <rdar://problem/4472037>

        Private extensions to the WebPlugin interface.  A plugin may implement these methods to receive loading callbacks
        for its main resource.  Plug-ins that implement this SPI show better loading progress in the browser, can be saved
        to disk, and are more efficient by avoiding making duplicate GET or POST requests for the plug-in's main resource.

        I want to provide a solid API for plug-in networking, but time constraints require that I first provide this simple
        SPI for internal clients.

        * Plugins/WebPluginViewFactoryPrivate.h:
        Added a new plugin argument, WebPlugInShouldLoadMainResourceKey.  If YES, the plugin is responsible
        for loading its own content.  If NO, the plugin should wait for WebKit to send it the data via the
        new request-sharing SPI.

        * Plugins/WebPluginPrivate.h: Added.
        Request-sharing SPI.  See comments in code.

        * Plugins/WebPluginDocumentView.h:
        Hang onto the plugin view as an ivar so we can call the new resource loading methods on it.
        * Plugins/WebPluginDocumentView.m:
        (-[WebPluginDocumentView dealloc]):
        Release pluginView ivar.
        (-[WebPluginDocumentView setDataSource:]):
        Pass NO for WebPlugInShouldLoadMainResourceKey to indicate to the plugin that it should not
        load its own main resource -- the data will come from WebKit.  This is only necessary for plugin
        documents.  By the time we create the view for a plugin document, we already have fetched some
        of its main resource's data.  Embedded plugins do not have this issue because WebKit is not
        involved in loading their content.
        Call -webPlugInMainResourceDidReceivResponse: on the plugin if necessary.  This lets the plugin
        know how much and what kind of data is going to be received.
        (-[WebPluginDocumentView dataSourceUpdated:]):
        If the plugin implements the new request-sharing SPI, don't cancel the in-progress request.
        (-[WebPluginDocumentView receivedData:withDataSource:]):
        Forward to the plugin via the new request-sharing SPI.
        (-[WebPluginDocumentView receivedError:withDataSource:]):
        ditto
        (-[WebPluginDocumentView finishedLoadingWithDataSource:]):
        ditto

        * Plugins/WebPluginPackage.m:
        Added WebPlugInShouldLoadMainResourceKey, tweaked some style a bit.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]):
        Pass YES for WebPlugInShouldLoadMainResourceKey.  Embedded plugins must load their own data.
        (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]):
        ditto

        * WebKit.xcodeproj/project.pbxproj:
        Added WebPluginPrivate.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-04-26 Mitz Pettel <opendarwin.org@mitzpettel.com>
eseidel [Tue, 25 Apr 2006 21:23:53 +0000 (21:23 +0000)]
2006-04-26  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed by darin.  Landed by eseidel.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8452
          mangleme(0x58c22e11): Random crashes

        Test: fast/frames/empty-cols-attribute.html

        * platform/StringImpl.cpp:
        (WebCore::StringImpl::toLengthArray): If the string is empty, return 0
        but set len to 1. This gives the same behavior you get if you don't specify
        the attribute at all, matching WinIE and Firefox. Previously, the empty
        string resulted in len being set to 0 (and a memory smasher in
        RenderFrameSet::layout()).
        * rendering/render_frames.cpp:
        (WebCore::RenderFrameSet::layout): Added an assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-04-26 Oliver Hunt <ojh16@student.canterbury.ac.nz>
eseidel [Tue, 25 Apr 2006 21:22:40 +0000 (21:22 +0000)]
2006-04-26  Oliver Hunt  <ojh16@student.canterbury.ac.nz>

        Reviewed by eseidel.  Landed by eseidel.

        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/KCanvasFilters.cpp:
        (WebCore::operator<<):
        * kcanvas/KCanvasFilters.h:
        (WebCore::KCComponentTransferFunction::KCComponentTransferFunction):
        * kcanvas/device/quartz/KCanvasFilterQuartz.h:
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (WebCore::getVectorForChannel):
        (WebCore::genImageFromTable):
        (WebCore::filterForComponentFunc):
        (WebCore::setParametersForComponentFunc):
        (WebCore::getFilterForFunc):
        (WebCore::KCanvasFEComponentTransferQuartz::getFunctionFilter):
        (WebCore::KCanvasFEComponentTransferQuartz::getCIFilter):
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        (WebCore::KRenderingDeviceQuartz::createFilterEffect):
        * kcanvas/device/quartz/filters/WKComponentMergeFilter.cikernel: Added.
        * kcanvas/device/quartz/filters/WKComponentMergeFilter.h: Added.
        * kcanvas/device/quartz/filters/WKComponentMergeFilter.m: Added.
        (+[WKComponentMergeFilter initialize]):
        (+[WKComponentMergeFilter filterWithName:]):
        (-[WKComponentMergeFilter init]):
        (-[WKComponentMergeFilter outputImage]):
        * kcanvas/device/quartz/filters/WKDiscreteTransferFilter.cikernel: Added.
        * kcanvas/device/quartz/filters/WKDiscreteTransferFilter.h: Added.
        * kcanvas/device/quartz/filters/WKDiscreteTransferFilter.m: Added.
        (+[WKDiscreteTransferFilter initialize]):
        (+[WKDiscreteTransferFilter filterWithName:]):
        (-[WKDiscreteTransferFilter init]):
        (-[WKDiscreteTransferFilter outputImage]):
        * kcanvas/device/quartz/filters/WKGammaTransferFilter.cikernel: Added.
        * kcanvas/device/quartz/filters/WKGammaTransferFilter.h: Added.
        * kcanvas/device/quartz/filters/WKGammaTransferFilter.m: Added.
        (+[WKGammaTransferFilter initialize]):
        (+[WKGammaTransferFilter filterWithName:]):
        (-[WKGammaTransferFilter init]):
        (-[WKGammaTransferFilter outputImage]):
        * kcanvas/device/quartz/filters/WKIdentityTransferFilter.h: Added.
        * kcanvas/device/quartz/filters/WKIdentityTransferFilter.m: Added.
        (+[WKIdentityTransferFilter initialize]):
        (+[WKIdentityTransferFilter filterWithName:]):
        (-[WKIdentityTransferFilter init]):
        (-[WKIdentityTransferFilter outputImage]):
        * kcanvas/device/quartz/filters/WKLinearTransferFilter.cikernel: Added.
        * kcanvas/device/quartz/filters/WKLinearTransferFilter.h: Added.
        * kcanvas/device/quartz/filters/WKLinearTransferFilter.m: Added.
        (+[WKLinearTransferFilter initialize]):
        (+[WKLinearTransferFilter filterWithName:]):
        (-[WKLinearTransferFilter init]):
        (-[WKLinearTransferFilter outputImage]):
        * kcanvas/device/quartz/filters/WKTableTransferFilter.cikernel: Added.
        * kcanvas/device/quartz/filters/WKTableTransferFilter.h: Added.
        * kcanvas/device/quartz/filters/WKTableTransferFilter.m: Added.
        (+[WKTableTransferFilter initialize]):
        (+[WKTableTransferFilter filterWithName:]):
        (-[WKTableTransferFilter init]):
        (-[WKTableTransferFilter outputImage]):
        * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
        (SVGComponentTransferFunctionElement::parseMappedAttribute):
        (SVGComponentTransferFunctionElement::transferFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-04-25 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 25 Apr 2006 19:32:34 +0000 (19:32 +0000)]
2006-04-25  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        Fixes for our 3rd and 5th most common crashtracers:
        <rdar://problem/4233435> CrashTracer: 2698 crashes in Safari at com.apple.WebCore: khtml::RenderBlock::addChildToFlow + 156
        <rdar://problem/4129744> [REGRESSION]CrashTracer: ..400 crashes at com.apple.WebCore: DOM::NodeImpl::createRendererIfNeeded + 44

        Test case landed on trunk but not on branch.

        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::setFocusNode): use m_inDetach bool copied from trunk
        * khtml/xml/dom_nodeimpl.cpp:
        (NodeImpl::NodeImpl):
        (NodeImpl::detach): set m_inDetach
        (NodeImpl::createRendererIfNeeded):
        (NodeBaseImpl::removeChildren): remove node from tree before calling detach.
        * khtml/xml/dom_nodeimpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agochangelog fixup
ggaren [Tue, 25 Apr 2006 18:53:06 +0000 (18:53 +0000)]
changelog fixup

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
mjs [Tue, 25 Apr 2006 18:38:34 +0000 (18:38 +0000)]
    Reviewed by Adele.

        - don't have a fini method, since trying to call it will actually call the subclass method
        and mess up the bridge count.

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge dealloc]):
        (-[WebCoreFrameBridge finalize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-04-25 Steve Falkenburg <sfalkenburg@apple.com>
sfalken [Tue, 25 Apr 2006 17:59:35 +0000 (17:59 +0000)]
2006-04-25  Steve Falkenburg  <sfalkenburg@apple.com>

        Reviewed by eseidel.

        No test case needed

        * platform/win/TemporaryLinkStubs.cpp:
        (KWQFileButton::setFrameGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-04-25 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 25 Apr 2006 08:51:32 +0000 (08:51 +0000)]
2006-04-25  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Fix reproducible crash in html parser code.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7137

        Test: fast/parser/remove-current-node-parent.html

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
mjs [Tue, 25 Apr 2006 08:11:15 +0000 (08:11 +0000)]
    Reviewed by Eric.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=8575
        New KWQFileButton leaks reported by buildbot

        * kwq/KWQFileButton.mm:
        (KWQFileButton::KWQFileButton): Add a missing release

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for 8336, focus ring redrawing on top of itself. Make sure
hyatt [Tue, 25 Apr 2006 07:18:25 +0000 (07:18 +0000)]
    Fix for 8336, focus ring redrawing on top of itself.  Make sure
        not to include empty rects when doing the focus ring drawing, since
        that results in a draw with no clip set.

        Reviewed by adele

        * platform/mac/GraphicsContextMac.mm:
        (WebCore::GraphicsContext::drawFocusRing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-04-24 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 25 Apr 2006 05:24:21 +0000 (05:24 +0000)]
2006-04-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        Fix for 5th worst unresolved crasher:
        <rdar://problem/4129744> [REGRESSION]CrashTracer: ..400 crashes at com.apple.WebCore: DOM::NodeImpl::createRendererIfNeeded + 44

        Test: fast/dom/remove-style-element.html

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::removeChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
mjs [Tue, 25 Apr 2006 05:01:03 +0000 (05:01 +0000)]
    Reviewed by Geoff.

        <rdar://problem/4525364> REGRESSION (yesterday?): LOG() mechanism is broken

        - initialize WebKit's log channels

        * Misc/WebKitLogging.h:
        * Misc/WebKitLogging.m:
        (initializeLogChannel):
        (WebKitInitializeLoggingChannelsIfNecessary):
        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):
        * WebView/WebView.m:
        (-[WebView _commonInitializationWithFrameName:groupName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-04-24 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 25 Apr 2006 05:00:39 +0000 (05:00 +0000)]
2006-04-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Speculative fix for our 7th worst crasher.
        Also added ASSERTs to help us better understand the issue.
        <rdar://problem/4153404> CrashTracer: 2412 crashes in Safari at com.apple.WebCore: khtml::RenderStyle::RenderStyle[unified] + 44

        * dom/Document.cpp:
        (WebCore::Document::recalcStyle):
        (WebCore::Document::setInPageCache):
        * dom/Document.h:
        * dom/Element.cpp:
        (WebCore::Element::recalcStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
adele [Tue, 25 Apr 2006 00:30:13 +0000 (00:30 +0000)]
    Reviewed by Hyatt.

        Fix for <rdar://problem/4503438> REGRESSION (NativeTextField): Can't insert caret when
        selection is active in field (Business/Unit)

        * css/html4.css: Added -webkit-user-select:text for input elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mjs [Tue, 25 Apr 2006 00:22:40 +0000 (00:22 +0000)]
WebCore:

        Build fix:

        - move some prematurely code back

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge fini]):

WebKit:

        Build fix:

        - move some prematurely code back

        * WebCoreSupport/WebFrameBridge.h:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge fini]):
        (-[WebFrameBridge _preferences]):
        (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]):
        (-[WebFrameBridge keyboardUIMode]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mjs [Mon, 24 Apr 2006 22:56:25 +0000 (22:56 +0000)]
WebCore:

        Reviewed by Darin.

        - move more code from WebFrameBridge to WebCoreFrameBridge

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge domain]):
        (-[WebCoreFrameBridge canTargetLoadInFrame:]):
        (-[WebCoreFrameBridge fini]):
        (-[WebCoreFrameBridge dealloc]):
        (-[WebCoreFrameBridge finalize]):
        (_getPreSmartSet):
        (_getPostSmartSet):
        (-[WebCoreFrameBridge isCharacterSmartReplaceExempt:isPreviousCharacter:]):
        (-[WebCoreFrameBridge _retrieveKeyboardUIModeFromPreferences:]):
        (-[WebCoreFrameBridge keyboardUIMode]):

WebKit:

        Reviewed by Darin.

        - move more code from WebFrameBridge to WebCoreFrameBridge

        * WebCoreSupport/WebFrameBridge.h:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge fini]):
        (-[WebFrameBridge expiresTimeForResponse:]):
        (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
        (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
        (-[WebFrameBridge valueForKey:keys:values:]):
        (-[WebFrameBridge _preferences]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim O.
adele [Mon, 24 Apr 2006 21:59:55 +0000 (21:59 +0000)]
    Reviewed by Tim O.

        Fix to send textFieldDidBeginEditing on the first editing change instead of on focus.
        This matches our old behavior.

        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dispatchFocusEvent):
        * rendering/RenderTextField.cpp: (WebCore::RenderTextField::subtreeHasChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Mon, 24 Apr 2006 21:10:19 +0000 (21:10 +0000)]
LayoutTests:

        Reviewed by Maciej.

        * fast/dom/prototype-chain-expected.txt: Updated now that 'JS' is
        no longer used as a prefix when serializing DOM elements to string.
        * fast/events/event-view-toString.html: ditto

WebCore:

        Reviewed by Eric.

        Fix for <rdar://problem/4513383> REGRESSION: Crash in
        WebCore::shouldEmitTabBeforeNode() when iterating through document
        text

        * editing/TextIterator.cpp:
        (WebCore::shouldEmitTabBeforeNode): Need to nil-check the renderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
bdakin [Mon, 24 Apr 2006 18:50:02 +0000 (18:50 +0000)]
    Reviewed by Eric.

        Fix for <rdar://problem/4513383> REGRESSION: Crash in
        WebCore::shouldEmitTabBeforeNode() when iterating through document
        text

        * editing/TextIterator.cpp:
        (WebCore::shouldEmitTabBeforeNode): Need to nil-check the renderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
mjs [Mon, 24 Apr 2006 09:30:56 +0000 (09:30 +0000)]
    Reviewed by Anders.

        - Remove use of _webSuperviewOfClass: and related
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8562

        I removed all use of these, now objects get at each other via
        actual pointers, not using the view hierarchy. However, I left two
        of the calls in because other clients rely on them as SPI (ugh).

        * History/WebHistoryItem.m:
        * Misc/WebNSViewExtras.h:
        * Misc/WebNSViewExtras.m:
        (-[NSView _web_superviewOfClass:]):
        (-[NSView _web_parentWebFrameView]):
        * Plugins/WebNetscapePluginDocumentView.m:
        (-[WebNetscapePluginDocumentView layout]):
        * Plugins/WebNetscapePluginEmbeddedView.h:
        * Plugins/WebNetscapePluginEmbeddedView.m:
        (-[WebNetscapePluginEmbeddedView setWebFrame:]):
        (-[WebNetscapePluginEmbeddedView dataSource]):
        * Plugins/WebNullPluginView.h:
        * Plugins/WebNullPluginView.m:
        (-[WebNullPluginView setWebFrame:]):
        (-[WebNullPluginView viewDidMoveToWindow]):
        * Plugins/WebPluginController.h:
        * Plugins/WebPluginController.m:
        (-[WebPluginController setDataSource:]):
        (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
        (-[WebPluginController webPlugInContainerShowStatus:]):
        (-[WebPluginController webPlugInContainerSelectionColor]):
        (-[WebPluginController webFrame]):
        * Plugins/WebPluginDocumentView.h:
        * Plugins/WebPluginDocumentView.m:
        (-[WebPluginDocumentView setDataSource:]):
        (-[WebPluginDocumentView layout]):
        (-[WebPluginDocumentView currentWindow]):
        (-[WebPluginDocumentView viewWillMoveToWindow:]):
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge formControlIsBecomingFirstResponder:]):
        (-[WebFrameBridge formControlIsResigningFirstResponder:]):
        (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]):
        * WebCoreSupport/WebViewFactory.m:
        (-[WebViewFactory bridgeForView:]):
        * WebView/WebClipView.m:
        (-[NSView initWithFrame:]):
        * WebView/WebFrameView.m:
        (-[WebFrameView _shouldDrawBorder]):
        (-[WebFrameView webCoreBridge]):
        * WebView/WebHTMLView.m:
        (-[WebTextCompleteController dealloc]):
        (-[WebHTMLView _dataSource]):
        (-[WebHTMLView _bridge]):
        (-[WebHTMLView _webView]):
        (-[WebHTMLView _frameView]):
        (-[WebHTMLView _web_firstResponderCausesFocusDisplay]):
        (-[NSArray becomeFirstResponder]):
        (-[NSArray setDataSource:]):
        (-[NSArray pageUp:]):
        (-[NSArray pageDown:]):
        (-[NSArray pageUpAndModifySelection:]):
        (-[NSArray pageDownAndModifySelection:]):
        (-[WebHTMLView _frame]):
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebImageView.h:
        * WebView/WebImageView.m:
        (-[WebImageView drawRect:]):
        (-[WebImageView adjustFrameSize]):
        (-[WebImageView setDataSource:]):
        (-[WebImageView webView]):
        (-[WebImageView writeImageToPasteboard:types:]):
        (-[WebImageView copy:]):
        (-[WebImageView elementAtPoint:]):
        (-[WebImageView mouseDragged:]):
        * WebView/WebPDFView.h:
        * WebView/WebPDFView.m:
        (-[WebPDFView _applyPDFDefaults]):
        (-[WebPDFView _trackFirstResponder]):
        (-[PDFPrefUpdatingProxy forwardInvocation:]):
        * WebView/WebRenderNode.m:
        (-[WebRenderNode initWithWebFrameView:]):
        * WebView/WebTextView.h:
        * WebView/WebTextView.m:
        (-[WebTextView _textSizeMultiplierFromWebView]):
        (-[WebTextView _preferences]):
        (-[WebTextView setDataSource:]):
        (-[WebTextView _webFrame]):
        (-[WebTextView dragSelectionWithEvent:offset:slideBack:]):
        (-[WebTextView menuForEvent:]):
        (-[WebTextView resignFirstResponder]):
        (-[WebTextView drawPageBorderWithSize:]):
        (-[WebTextView knowsPageRange:]):
        * WebView/WebView.m:
        (-[WebView searchFor:direction:caseSensitive:wrap:]):
        (containingFrameView):
        (-[WebView _focusedFrame]):
        (-[WebView _frameViewAtWindowPoint:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ggaren [Mon, 24 Apr 2006 04:58:53 +0000 (04:58 +0000)]
    Reviewed by Darin.

        - Took the larger snippets of C++ in the code generator and broke
        them into HERE documents in the hopes of improving readability.

        * bindings/scripts/CodeGeneratorJS.pm: I indented variable names
        level with their corresponding HERE documents to clearly
        "sandwich" the HERE documents between opening and closing EOF
        statements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mjs [Mon, 24 Apr 2006 03:47:00 +0000 (03:47 +0000)]
WebCore:

        Reviewed by Darin.

        - push WebFileButton and WebStringTruncator code down to WebCore
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8552

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreStringTruncator.h: Added.
        * bridge/mac/WebCoreStringTruncator.mm: Added.
        (stringWidth):
        (truncateString):
        (+[WebCoreStringTruncator widthOfString:font:]):
        * bridge/mac/WebCoreViewFactory.h:
        * kwq/KWQFileButton.h:
        * kwq/KWQFileButton.mm:
        (-[WebFileChooserButton initWithWidget::]):
        (-[WebCoreFileButton positionButton]):
        (-[WebCoreFileButton initWithWidget:]):
        (-[WebCoreFileButton initWithFrame:]):
        (-[WebCoreFileButton dealloc]):
        (-[WebCoreFileButton isFlipped]):
        (-[WebCoreFileButton drawRect:]):
        (-[WebCoreFileButton updateLabel]):
        (-[WebCoreFileButton setFilename:]):
        (-[WebCoreFileButton filename]):
        (-[WebCoreFileButton setFrameSize:]):
        (-[WebCoreFileButton bestVisualFrameSizeForCharacterCount:]):
        (-[WebCoreFileButton visualFrame]):
        (-[WebCoreFileButton setVisualFrame:]):
        (-[WebCoreFileButton baseline]):
        (-[WebCoreFileButton beginSheet]):
        (-[WebCoreFileButton chooseFilename:]):
        (-[WebCoreFileButton cancel]):
        (-[WebCoreFileButton chooseButtonPressed:]):
        (-[WebCoreFileButton mouseDown:]):
        (-[WebCoreFileButton acceptsFirstResponder]):
        (-[WebCoreFileButton becomeFirstResponder]):
        (-[WebCoreFileButton nextKeyView]):
        (-[WebCoreFileButton previousKeyView]):
        (-[WebCoreFileButton nextValidKeyView]):
        (-[WebCoreFileButton previousValidKeyView]):
        (-[WebCoreFileButton performClick]):
        (-[WebFileChooserButton initWithWidget:]):
        (-[WebFileChooserButton nextValidKeyView]):
        (-[WebFileChooserButton previousValidKeyView]):
        (-[WebFileChooserButton resignFirstResponder]):
        (KWQFileButton::KWQFileButton):
        (KWQFileButton::setFilename):
        (KWQFileButton::click):
        (KWQFileButton::sizeForCharacterWidth):
        (KWQFileButton::frameGeometry):
        (KWQFileButton::setFrameGeometry):
        (KWQFileButton::baselinePosition):
        (KWQFileButton::filenameChanged):

WebKit:

        Reviewed by Darin.

        - push WebFileButton and WebStringTruncator code down to WebCore
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8552

        * Misc/WebStringTruncator.m:
        (+[WebStringTruncator centerTruncateString:toWidth:]):
        (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
        (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
        (+[WebStringTruncator widthOfString:font:]):
        * WebCoreSupport/WebFileButton.h: Removed.
        * WebCoreSupport/WebFileButton.m: Removed.
        * WebCoreSupport/WebFrameBridge.h:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]):
        * WebCoreSupport/WebViewFactory.m:
        (-[WebViewFactory fileButtonChooseFileLabel]):
        (-[WebViewFactory fileButtonNoFileSelectedLabel]):
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mjs [Sun, 23 Apr 2006 23:11:40 +0000 (23:11 +0000)]
WebCore:

        Reviewed by Eric.

        - remove WebCoreCookieAdapter, instead make mac implementation of
        CookieJar use Foundation directly.

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/mac/CookieJar.mm:
        (WebCore::cookies):
        (WebCore::setCookies):
        (WebCore::cookiesEnabled):
        * platform/mac/WebCoreCookieAdapter.h: Removed.
        * platform/mac/WebCoreCookieAdapter.m: Removed.

WebKit:

        Reviewed by Eric.

        - remove WebCookieAdapter, WebCore can just use Foundation directly.

        * WebCoreSupport/WebCookieAdapter.h: Removed.
        * WebCoreSupport/WebCookieAdapter.m: Removed.
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebFrameView.m:
        (-[WebFrameView initWithFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
mjs [Sun, 23 Apr 2006 23:09:10 +0000 (23:09 +0000)]
    Reviewed by Adele.

        - prune WebView SPI of unused calls

        Specifically I moved methods that have no callers outside WebKit
        to WebViewInternal.h or removed them entirely.

        * DefaultDelegates/WebDefaultContextMenuDelegate.m:
        * Plugins/WebBaseNetscapePluginView.m:
        * Plugins/WebNetscapePluginDocumentView.m:
        * Plugins/WebNetscapePluginStream.m:
        * Plugins/WebNullPluginView.m:
        * Plugins/WebPluginContainerCheck.m:
        * Plugins/WebPluginController.m:
        * WebCoreSupport/WebFrameBridge.m:
        * WebCoreSupport/WebPageBridge.m:
        * WebCoreSupport/WebSubresourceLoader.m:
        * WebView/WebDataSource.m:
        * WebView/WebHTMLView.m:
        * WebView/WebImageView.m:
        * WebView/WebLoader.m:
        * WebView/WebMainResourceLoader.m:
        * WebView/WebPDFView.m:
        * WebView/WebScriptDebugDelegate.m:
        * WebView/WebView.m:
        (-[WebView _downloadURL:]):
        * WebView/WebViewInternal.h:
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-04-21 Rob Buis <buis@kde.org>
eseidel [Sun, 23 Apr 2006 22:57:22 +0000 (22:57 +0000)]
2006-04-21  Rob Buis  <buis@kde.org>

        Reviewed by hyatt.  Landed by eseidel.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8170:
        SVG CSS property values with extra items do not get treated
        as invalid (they should)

        Fixes the handling of invalid svg css properties similar
        to how invalid html css properties are handled, ie. discard
        the property if there are more values in the value list than
        expected.

        Test: svg/custom/invalid-css.svg

        * ksvg2/css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-04-23 Michael Emmel <mike.emmel@gmail.com>
eseidel [Sun, 23 Apr 2006 22:45:07 +0000 (22:45 +0000)]
2006-04-23  Michael Emmel  <mike.emmel@gmail.com>

        Reviewed by mjs.  Landed by eseidel.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8517
        No test necessary, no functional change.

        * DerivedSources.make: use VPATH more consistently.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-04-21 Jon Shier <jshier@iastate.edu>
eseidel [Sun, 23 Apr 2006 22:39:07 +0000 (22:39 +0000)]
2006-04-21  Jon Shier  <jshier@iastate.edu>

        Reviewed by ggaren.  Landed by eseidel.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8511
        onerror JS property does not register listener properly

        * ChangeLog:
        * bindings/js/kjs_dom.cpp:
        (KJS::DOMEventTargetNode::getValueProperty): changed khtmlErrorEvent to errorEvent.
        (KJS::DOMEventTargetNode::putValueProperty): ditto.
        * bindings/js/kjs_window.cpp:
        (KJS::Window::getValueProperty): ditto.
        (KJS::Window::put):
        * dom/EventNames.h: Removed khtmlError macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
adele [Sun, 23 Apr 2006 19:16:26 +0000 (19:16 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=6905
          DumpRenderTree needs a way to force painting (to allow invalidation tests)

        * DumpRenderTree/DumpRenderTree.m:
        (dump): If display() has been called during the test, grab the pixels from
        the view, after letting it repaint invalidated rects.
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (-[LayoutTestController display]): Added. Calls -display on the view
        and changes the subsequent behavior of dump().
        (dumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-04-23 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 23 Apr 2006 09:19:29 +0000 (09:19 +0000)]
2006-04-23  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt.

        Reproducible crasher with <li value=1234567890 type=A>
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8542

        Fixed our alphabetical list generation to match WinIE (not FireFox)
        Previously our alphabetical lists were completely wrong past 26 items.

        Tests:
        * fast/lists/alpha-list-wrap.html
        * fast/lists/li-style-alpha-huge-value-crash.html

        * rendering/render_list.cpp:
        (WebCore::toLetterString):
        (WebCore::toHebrew):
        (WebCore::RenderListMarker::calcMinMaxWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoGeoff seems to have checked in the change log, but not the updated result.
darin [Sun, 23 Apr 2006 04:23:28 +0000 (04:23 +0000)]
Geoff seems to have checked in the change log, but not the updated result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
mjs [Sun, 23 Apr 2006 01:52:37 +0000 (01:52 +0000)]
    Reviewed by Eric.

        - remove WebKit copy of assertions code, use the assertions
        stuff from JavaScriptCore instead.

        * Carbon/HIViewAdapter.m:
        * DOM/WebDOMOperations.m:
        * DefaultDelegates/WebDefaultContextMenuDelegate.m:
        * DefaultDelegates/WebDefaultPolicyDelegate.m:
        (-[WebDefaultPolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
        * History/WebBackForwardList.m:
        * History/WebHistory.m:
        (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]):
        (-[WebHistoryPrivate _saveHistoryGuts:URL:error:]):
        * History/WebHistoryItem.m:
        * Misc/WebAssertions.h: Removed.
        * Misc/WebAssertions.m: Removed.
        * Misc/WebDatabase.m:
        * Misc/WebDownload.m:
        * Misc/WebFileDatabase.m:
        (SetThreadPriority):
        * Misc/WebIconDatabase.m:
        (-[NSMutableDictionary iconForURL:withSize:cache:]):
        (-[NSMutableDictionary releaseIconForURL:]):
        (-[NSMutableDictionary delayDatabaseCleanup]):
        (-[NSMutableDictionary allowDatabaseCleanup]):
        (-[WebIconDatabase _loadIconDictionaries]):
        (-[WebIconDatabase _updateFileDatabase]):
        (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]):
        * Misc/WebIconLoader.m:
        * Misc/WebKitLogging.h:
        * Misc/WebKitLogging.m:
        * Misc/WebKitSystemBits.m:
        (initCapabilities):
        * Misc/WebLRUFileList.m:
        (WebLRUFileListRemoveOldestFileFromList):
        (WebLRUFileListGetFileSize):
        * Misc/WebLocalizableStrings.m:
        * Misc/WebNSCalendarDateExtras.m:
        * Misc/WebNSDataExtras.m:
        * Misc/WebNSDictionaryExtras.m:
        * Misc/WebNSFileManagerExtras.m:
        * Misc/WebNSPasteboardExtras.m:
        * Misc/WebNSURLExtras.m:
        (hexDigit):
        (hexDigitValue):
        (allCharactersInIDNScriptWhiteList):
        * Misc/WebNSURLRequestExtras.m:
        * Misc/WebNSUserDefaultsExtras.m:
        * Misc/WebStringTruncator.m:
        * Panels/WebAuthenticationPanel.m:
        (-[WebAuthenticationPanel loadNib]):
        * Panels/WebPanelAuthenticationHandler.m:
        * Plugins/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
        (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
        * Plugins/WebBaseNetscapePluginView.m:
        (TSMEventHandler):
        (-[WebBaseNetscapePluginView start]):
        (-[WebBaseNetscapePluginView status:]):
        (-[WebBaseNetscapePluginView _printedPluginBitmap]):
        * Plugins/WebBasePluginPackage.m:
        * Plugins/WebNetscapePluginDocumentView.m:
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage load]):
        * Plugins/WebNetscapePluginRepresentation.m:
        * Plugins/WebPluginContainerCheck.m:
        * Plugins/WebPluginController.m:
        (-[WebPluginController addPlugin:]):
        (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
        (-[WebPluginController webPlugInContainerShowStatus:]):
        * Plugins/WebPluginDatabase.m:
        * Plugins/WebPluginDocumentView.m:
        * WebCoreSupport/WebCookieAdapter.m:
        * WebCoreSupport/WebFileButton.m:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge runModal]):
        * WebCoreSupport/WebImageData.m:
        (-[WebImageData _checkSolidColor:]):
        (-[WebImageData tileInRect:fromPoint:context:]):
        (-[WebImageData scaleAndTileInRect:fromRect:withHorizontalTileRule:withVerticalTileRule:context:]):
        * WebCoreSupport/WebImageDecoder.m:
        * WebCoreSupport/WebImageRenderer.m:
        (-[WebImageRenderer TIFFRepresentation]):
        * WebCoreSupport/WebImageRendererFactory.m:
        * WebCoreSupport/WebJavaScriptTextInputPanel.m:
        * WebCoreSupport/WebKeyGenerator.m:
        * WebCoreSupport/WebPageBridge.m:
        * WebCoreSupport/WebSubresourceLoader.m:
        * WebCoreSupport/WebTextRenderer.m:
        (widthForGlyph):
        (-[WebTextRenderer initWithFont:]):
        (drawGlyphs):
        (initializeATSUStyle):
        (createATSULayoutParameters):
        (getTextBounds):
        (ATSU_draw):
        * WebCoreSupport/WebTextRendererFactory.m:
        * WebCoreSupport/WebViewFactory.m:
        * WebKit.exp:
        * WebKit.xcodeproj/project.pbxproj:
        * WebKitPrefix.h:
        * WebView/WebArchiver.m:
        (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
        * WebView/WebClipView.m:
        * WebView/WebDataProtocol.m:
        * WebView/WebDataSource.m:
        (-[WebDataSource _startLoading]):
        * WebView/WebFormDataStream.m:
        (formEventCallback):
        (webSetHTTPBody):
        * WebView/WebFrame.m:
        (-[WebFrame _transitionToCommitted:]):
        * WebView/WebFrameView.m:
        * WebView/WebHTMLRepresentation.m:
        * WebView/WebHTMLView.m:
        (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
        (-[NSArray drawSingleRect:]):
        (-[NSArray namesOfPromisedFilesDroppedAtDestination:]):
        (-[NSArray _scaleFactorForPrintOperation:]):
        (-[NSArray deleteBackwardByDecomposingPreviousCharacter:]):
        (-[NSArray checkSpelling:]):
        (-[NSArray showGuessPanel:]):
        (-[NSArray _changeSpellingToWord:]):
        (-[NSArray ignoreSpelling:]):
        (-[NSArray performFindPanelAction:]):
        (-[WebTextCompleteController doCompletion]):
        * WebView/WebImageView.m:
        * WebView/WebLoader.m:
        (-[NSURLProtocol connection:willCacheResponse:]):
        * WebView/WebPDFRepresentation.m:
        (+[WebPDFRepresentation PDFDocumentClass]):
        * WebView/WebPDFView.m:
        (+[WebPDFView PDFKitBundle]):
        (+[WebPDFView PDFViewClass]):
        (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
        * WebView/WebTextRepresentation.m:
        * WebView/WebTextView.m:
        * WebView/WebUnarchivingState.m:
        * WebView/WebView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
thatcher [Sat, 22 Apr 2006 23:48:23 +0000 (23:48 +0000)]
    Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8514
        Bug 8514: Web Inspector hides when the app is in the background

        Makes the inspector not hide in the background. Since the inspector is a floating panel
        we need to call setFloatingPanel:NO when the app is switching into the background. Then
        call setFloatingPanel:YES when the app is activated again. Without this the inspector
        would float above all applications.

        * WebInspector/WebInspector.m:
        (-[NSWindow window]): setHidesOnDeactivate:NO
        (-[NSWindow windowWillClose:]): de-regiser appliction active notifications
        (-[NSWindow showWindow:]): register for appliction active notifications
        (-[WebInspector _applicationWillResignActive]): setFloatingPanel:NO
        (-[WebInspector _applicationDidBecomeActive]): setFloatingPanel:YES

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Sat, 22 Apr 2006 22:11:18 +0000 (22:11 +0000)]
LayoutTests:

        Reviewed by Darin.

        - Updated prototype chain expectation since DOMElement no longer
        exists

        * fast/dom/prototype-chain-expected.txt:

WebCore:

        Reviewed by Darin.

        - Finished autogeneration of Element

        * bindings/js/kjs_dom.cpp: Removed DOMElement class
        * bindings/js/kjs_dom.h: ditto
        * bindings/scripts/CodeGeneratorJS.pm: added support for special
        attribute lookup that elements do
        * dom/Element.idl: added new attribute,
        "IncludeAttributesInPropertyLookup," which tells the code generator
        to include HTML element attributes in property lookup

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Sat, 22 Apr 2006 22:01:09 +0000 (22:01 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8529
          Extra Qaulification in header
        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8530
          Missing assert.h include

        * rendering/RenderObject.h: Removed erroneous RenderObject::
        prefix from a member function name.
        * rendering/RenderText.h: Removed erroneous RenderText::
        prefix from a member function name.

        * platform/Arena.cpp: Added <assert.h> to list of includes.
        * platform/KURL.cpp: Ditto.
        * platform/StringImpl.cpp: Ditto.
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Ditto.
        * platform/image-decoders/png/PNGImageDecoder.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * doc: Added.
darin [Sat, 22 Apr 2006 21:57:25 +0000 (21:57 +0000)]
    * doc: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
ap [Sat, 22 Apr 2006 20:23:04 +0000 (20:23 +0000)]
    Reviewed by Maciej.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8532
          Update iExploder to 1.3.2

        Test case numbers are not compatible with iExploder 1.2.

        * Scripts/run-iexploder-tests: Print the numbers of the last five tests that were accessed.

        * iExploder/CHANGELOG.txt: Added.
        * iExploder/LICENSE.txt: Changed to a standard zlib/png license.
        * iExploder/README.txt: Added some performance hints.

        * iExploder/htdocs/config.rb: Added.
        * iExploder/htdocs/cssproperties.in:
        * iExploder/htdocs/cssvalues.in:
        * iExploder/htdocs/htmlattrs.in:
        * iExploder/htdocs/htmltags.in:
        * iExploder/htdocs/iexploder.cgi:
         - Updated to support the latest HTML & CSS tags, properties, and values from both
           the WebKit and Mozilla CVS tree
         - cssproperties.in cleanup
         - Modularized the code a little bit.
         - Fix subtest bug that was causing last 5 tags to be missed
         - new subtest algorithm to deal better with larger tag counts
         - default HTML_MAX_TAGS increased from 32 to 96

        * iExploder/htdocs/index.html: Updated version to 1.3.2.
        * iExploder/htdocs/webserver.rb: Added. New standalone webserver, can be used as an
        alternative to our run-iexploder-tests.
        * iExploder/tools/showtest.rb: Added. Similar to run-iexploder-tests --get.
        * iExploder/htdocs/iexploder.rb: Added. Used by webserver.rb.
        * iExploder/tools/osx_last_crash.rb: Find logs modified in the last two days.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCommit Scripts/run-mangleme-tests (missed it the previous time).
ap [Sat, 22 Apr 2006 20:07:16 +0000 (20:07 +0000)]
Commit Scripts/run-mangleme-tests (missed it the previous time).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
mjs [Sat, 22 Apr 2006 19:04:45 +0000 (19:04 +0000)]
    Reviewed by Eric.

        - push down a bunch of WebCoreFrameBridge code to C++ (plus some reformatting)

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge isDescendantOfFrame:]):
        (-[WebCoreFrameBridge traverseNextFrameStayWithin:]):
        (-[WebCoreFrameBridge nextFrameWithWrap:]):
        (-[WebCoreFrameBridge previousFrameWithWrap:]):
        (+[WebCoreFrameBridge bridgeForDOMDocument:]):
        (-[WebCoreFrameBridge parent]):
        (-[WebCoreFrameBridge addData:]):
        (-[WebCoreFrameBridge didNotOpenURL:pageCache:]):
        (-[WebCoreFrameBridge restoreDocumentState]):
        (-[WebCoreFrameBridge _stringWithDocumentTypeStringAndMarkupString:]):
        (-[WebCoreFrameBridge nodesFromList:]):
        (-[WebCoreFrameBridge markupStringFromNode:nodes:]):
        (-[WebCoreFrameBridge markupStringFromRange:nodes:]):
        (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
        (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
        (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
        (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:verticalDistance:]):
        (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
        (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
        (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
        (-[WebCoreFrameBridge increaseSelectionListLevel]):
        (-[WebCoreFrameBridge decreaseSelectionListLevel]):
        (-[WebCoreFrameBridge insertLineBreak]):
        (-[WebCoreFrameBridge insertParagraphSeparator]):
        (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]):
        (-[WebCoreFrameBridge insertText:selectInsertedText:]):
        (-[WebCoreFrameBridge deleteSelectionWithSmartDelete:]):
        (-[WebCoreFrameBridge ensureSelectionVisible]):
        (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:allowShadowContent:]):
        * page/Frame.cpp:
        (WebCore::Frame::nodeInfoAtPoint):
        (WebCore::Frame::hasSelection):
        (WebCore::Frame::documentTypeString):
        * page/Frame.h:
        * page/FrameTree.cpp:
        (WebCore::FrameTree::traverseNextWithWrap):
        (WebCore::FrameTree::traversePreviousWithWrap):
        (WebCore::FrameTree::deepLastChild):
        * page/FrameTree.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
bdakin [Sat, 22 Apr 2006 08:01:36 +0000 (08:01 +0000)]
    Reviewed by Hyatt.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6141
        DOMCSSPrimitiveValue is always returning values in pixels when
        using getComputedStyle:

        getFloatValue() took a unit type as a parameter, ignored it, and
        returned m_value.num. This patch writes a second version of the
        function that actually converts m_value.num to the specified unites
        before returning it. Where a conversion is not required, I removed
        the unit type from the caller so that it would go directly to the
        inline version of the function.

        * css/css_valueimpl.cpp:
        (WebCore::CSSPrimitiveValue::computeLengthFloat): Remove type
        parameter since a conversion is not needed.
        (WebCore::scaleFactorForConversion): Helper function for
        conversion.
        (WebCore::CSSPrimitiveValue::getFloatValue): This version of
        getFloatValue() takes a unit type parameter and converts
        m_value.num.
        * css/css_valueimpl.h:
        (WebCore::CSSPrimitiveValue::getFloatValue): This version does not
        take a parameter and just returns m_value.num.
        * css/cssparser.cpp:
        (WebCore::BorderImageParseContext::commitBorderImage): Remove type
        parameter since a conversion is not needed.
        * css/cssstyleselector.cpp:
        (WebCore::convertToLength): Same.
        (WebCore::CSSStyleSelector::applyProperty): Same.
        (WebCore::CSSStyleSelector::mapBackgroundSize): Same.
        (WebCore::CSSStyleSelector::mapBackgroundXPosition): Same.
        (WebCore::CSSStyleSelector::mapBackgroundYPosition): Same.
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Same.
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty): Same.
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        (WebCore::KSVGPainterFactory::cssPrimitiveToLength): Same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Sat, 22 Apr 2006 07:33:04 +0000 (07:33 +0000)]
LayoutTests:

        - Layout test for whether the error event bubbles.

        * fast/events/onerror-bubbling-expected.txt: Added.
        * fast/events/onerror-bubbling.html: Added.

WebCore:

        Reviewed by John.

        - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=8509
        javascript:document.importNode(null)

        * dom/Document.cpp:
        (WebCore::Document::importNode): Throw an error if the node is null.
        This happens when the object provided in the JavaScript call is not
        a node.
        (WebCore::Document::adoptNode): Set the DOM exception code in all error
        cases instead of just a few, because that's what the spec requires.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFixing bug number & title in last commit.
adele [Sat, 22 Apr 2006 06:08:01 +0000 (06:08 +0000)]
Fixing bug number & title in last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele [Sat, 22 Apr 2006 06:06:00 +0000 (06:06 +0000)]
WebCore:

        Test for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8213
        REGRESSION: Can't tab out of text field if iframe comes after it

        * manual-tests/tabbing-input-google.html: Added.

WebKit:

        Reviewed by Darin.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8181
        REGRESSION: After tabbing in page's field, attempting to tab from Google toolbar search to page fails on first try

        Test: manual-tests/tabbing-input-google.html

        * WebView/WebHTMLView.m: (-[NSArray resignFirstResponder]):
        When resigning first responder, reset willBecomeFirstResponderForNodeFocus, so when the WebHTMLView gets focus again
        it knows it can start moving through the tab cycle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin [Sat, 22 Apr 2006 05:31:57 +0000 (05:31 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8507
          Compilation fixes for building on gcc 4.0.2, and without precomp headers

        * kjs/operations.h:
        * kxmlcore/Assertions.cpp:
        * kxmlcore/FastMalloc.cpp:
        Added necessary headers to resolve compilation issues when not using
        precompiled headers.

        * kjs/value.h: Declare the JSCell class before friend declaration
        to resolve compilation issues with gcc 4.0.2.

        * kxmlcore/Platform.h: Set Unicode support to use ICU on platforms
        other than KDE (previously only defined for Win and Mac OS)

WebCore:

        Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8507
          Compilation fixes for building on gcc 4.0.2, and without precomp headers

        * platform/Cursor.h: Created a fallback case that typedefs PlatformCursor
        to void * if it isn't defined to anything else. (Useful to help get new ports
        initially compiling.)

        * bindings/js/kjs_window.cpp:
        * rendering/RenderTextField.cpp:
        * rendering/RenderBox.cpp:
        Add missing headers to resolve issues when compiling without precompiled
        headers.

        * rendering/RenderText.h: Declare the InlineTextBox class before
        friend declaration to resolve compilation issues with gcc 4.0.2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Sat, 22 Apr 2006 01:29:30 +0000 (01:29 +0000)]
LayoutTests:

        Reviewed by Darin.

        Test for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8213
        REGRESSION: Can't tab out of text field if iframe comes after it

        * fast/forms/tabbing-input-iframe-expected.checksum: Added.
        * fast/forms/tabbing-input-iframe-expected.png: Added.
        * fast/forms/tabbing-input-iframe-expected.txt: Added.
        * fast/forms/tabbing-input-iframe.html: Added.

WebCore:

        Reviewed by Darin.

        Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8213
        REGRESSION: Can't tab out of text field if iframe comes after it

        Test: fast/forms/tabbing-input-iframe.html

        * bridge/mac/FrameMac.mm: (WebCore::FrameMac::nextKeyViewInFrame):
          If the next focusable node is a RenderWidget without a view, then continue in the loop.  We used to break out in this case.
          I also made some formatting changes and reorganized the function to make it easier to read.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth.
adele [Fri, 21 Apr 2006 23:59:20 +0000 (23:59 +0000)]
    Reviewed by Beth.

        Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8496
        REGRESSION: Dragging to select text around a text field causes the text field to scroll.

        Test: manual-tests/text-field-autoscroll.html

        * bridge/mac/FrameMac.mm: (WebCore::FrameMac::handleMouseMoveEvent): Start the frame's autoscroll timer
        even when we're calling over the bridge to handle the autoscroll.
        * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Clear out pointer to layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
tomernic [Fri, 21 Apr 2006 20:32:05 +0000 (20:32 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4476875> Support printing for embedded Netscape plugins

        NOTE: This only works with the Flash plugin right now.  It appears that the other
        major plugins either have awful printing support, or no printing support.  If someone
        can find an example of any other embedded Netscape plugin printing in any browser on
        the Mac, I will be happy to eat my own words!

        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView drawRect:]):
        When printing, get the printed bitmap via -_printedPluginBitmap, and draw it into the
        plugin view.
        (-[WebBaseNetscapePluginView _printedPluginBitmap]):
        Call NPP_Print on the plugin to render it into a GWorld.  This GWorld has the same
        underlying buffer as an NSBitmapImageRep, which is returned to the caller.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Adding a few more background-size tests that include background-
bdakin [Fri, 21 Apr 2006 18:18:49 +0000 (18:18 +0000)]
    Adding a few more background-size tests that include background-
        origin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - And again.
ggaren [Fri, 21 Apr 2006 17:24:53 +0000 (17:24 +0000)]
    - And again.

        * WebCore.vcproj/WebCore/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - Futile attempt to fix Windows build.
ggaren [Fri, 21 Apr 2006 17:09:53 +0000 (17:09 +0000)]
    - Futile attempt to fix Windows build.

        * WebCore.vcproj/WebCore/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Fri, 21 Apr 2006 16:29:02 +0000 (16:29 +0000)]
LayoutTests:

        Tests for global constants related to CSSRule, CSSValue, Event, and
        NodeFilter objects.

        * fast/dom/constants-expected.txt: Added.
        * fast/dom/constants.html: Added.
        * fast/dom/prototype-chain-expected.txt:
        * fast/dom/resources/stylesheet.css: Added.
        * fast/dom/xmlhttprequest-get-expected.txt:

WebCore:

        Reviewed by Maciej.

        - Added autogeneration of JS bindings for CSSRule, CSSValue,
        Event, and NodeFilter.

        - Made related prototype objects hold the relevant constants, to
        match Mozilla and the DOM 2 spec. (Previously, only the related
        constructor objects held those constants, in accordance with the
        DOM 3 spec.)

        - Fixed up remaining Windows build issues.

        * DerivedSources.make: Added new autogenerated files
        * WebCore.xcodeproj/project.pbxproj: ditto
        * bindings/js/kjs_css.cpp:
        (KJS::DOMCSSRule::classInfo):
        (KJS::DOMCSSRule::getOwnPropertySlot): scope call to classInfo()
        because it's virtual and DOMCSSRule has a derrived class now.
        (KJS::DOMCSSRule::put): ditto
        (KJS::DOMCSSRuleFunc::callAsFunction):
        (KJS::toJS):
        * bindings/js/kjs_css.h:
        * bindings/js/kjs_events.cpp:
        (KJS::toJS):
        * bindings/js/kjs_events.h:
        * bindings/js/kjs_html.cpp:
        (KJS::OptionConstructorImp::OptionConstructorImp):
        * bindings/js/kjs_traversal.cpp:
        (KJS::toJS):
        * bindings/js/kjs_traversal.h:
        * bindings/js/kjs_window.cpp:
        (KJS::Window::getValueProperty): added CSSValue global object
        * bindings/js/kjs_window.h:
        (KJS::Window::):
        * bindings/scripts/CodeGeneratorJS.pm: Changed generator to write
        constants to prototype objects (previously only wrote constants to
        constructor objects)
        * css/CSSPrimitiveValue.idl: Removed LegacyParent since CSSValue now
        exists in IDL
        * css/CSSRule.idl: Added.
        * css/CSSValue.idl: Added.
        * css/css_ruleimpl.h:
        (WebCore::CSSRule::):
        * css/css_valueimpl.h:
        * dom/Event.idl: Added.
        * dom/MutationEvent.idl: Removed LegacyParent since Event now exists
        in IDL
        * dom/NodeFilter.idl: Added.
        * dom/UIEvent.idl: Removed LegacyParent since event now exists in IDL
        * dom/dom2_eventsimpl.h:
        (WebCore::Event::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - one more attempt to fix Windows build
darin [Fri, 21 Apr 2006 07:57:11 +0000 (07:57 +0000)]
    - one more attempt to fix Windows build

        * platform/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::fillRect): Update to use Color and match
        the similar function on GraphicsContextMac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
bdakin [Fri, 21 Apr 2006 07:54:57 +0000 (07:54 +0000)]
    Reviewed by Hyatt.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8495
        REGRESSION: Sidebar on cnn.com is hosed

        * platform/mac/ImageMac.mm:
        (WebCore::Image::drawTiled): Use the size of the destination rect,
        not the oneTileRect in the no-pattern case.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBackgroundExtended): Initialize
        scaledWidth and scaledHeight to the appropriate value (was wrong in
        scroll case), adjust position at appropriate times, and take out
        no-repeat clause for now since we don't have enough test cases yet
        to be sure we won't cause massive regressions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - attempt to fix Windows build after my last check-in
darin [Fri, 21 Apr 2006 07:49:15 +0000 (07:49 +0000)]
    - attempt to fix Windows build after my last check-in

        * WebCore.vcproj/Image Viewer/ImageView.cpp: Changed calls to use the
        new IntRect-based API.

        * html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern):
        Put appropriate ifdefs around the m_platformImage initializer.

        * page/Frame.cpp: Make Frame::adjustPageHeight Mac-OS-X-only for now
        since it's used for printing and we don't have printing going on any
        other platforms yet.

        * platform/cairo/GraphicsContextCairo.cpp: Take out constructor that
        takes only the "for printing" boolean for now.

        * platform/cairo/ImageCairo.cpp: Include the GraphicsContext.h header.

        * platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::setShadow):
        Fix up this stub and remove the GraphicsContext empty constructor stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix build
darin [Fri, 21 Apr 2006 07:27:17 +0000 (07:27 +0000)]
    - fix build

        * WebCore.xcodeproj/project.pbxproj: Replaced absolute path on my system
        with a build-result-relative path; also removed some source files from the
        list of resources to install!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
darin [Fri, 21 Apr 2006 06:52:11 +0000 (06:52 +0000)]
    Reviewed by Hyatt.

        - make <canvas> element and related API behave more like the draft of
          the WhatWG Web Application specification, checking parameter validity
          and raising exceptions
        - changed HTMLCanvasElement bindings to be auto-generated, fixing all
          issues so we can generate bindings for classes drived from HTMLElement
        - change GraphicsContext API to use IntRect/Point/Size in more cases
        - change GraphicsContext so it is closer to truly wrapping a graphics
          context rather than representing the current NSGraphicsContext; there
          are still some things like text and rectangle fills that are tied to
          NSGraphicsContext, but we're most of the way there
        - removed Brush class since it just amounted to a color, using an RGBA32
          instead where we used to use a Brush

        * DerivedSources.make: Added JSHTMLCanvasElement.h.
        * WebCore.xcodeproj/project.pbxproj: Added new files.

        * bindings/js/JSCanvasRenderingContext2DBase.h: Added toJS.
        * bindings/js/JSCanvasRenderingContext2DBase.cpp:
        (WebCore::JSCanvasRenderingContext2DBaseProtoFunc::callAsFunction):
        Added exception code handling for strokeRect, drawImage, and createPattern.
        Added version of createPattern that takes a canvas. Use TYPE_MISMATCH_ERR
        instead of JavaScript TypeError when parameter is neither an image or canvas
        element. Adapt for new HTMLCanvasElement binding.
        (WebCore::toJS): Added. Converts context object to JS wrapper.

        * bindings/js/JSHTMLElementWrapperFactory.h: Added.
        * bindings/js/JSHTMLElementWrapperFactory.cpp: Added. Creates a JavaScript
        wrapper for an arbitrary HTML element. Better than putting this all in the
        DOM node class toJS function.

        * bindings/js/JSXMLSerializer.cpp: Tweaked to make it build.
        * bindings/js/kjs_dom.cpp: (KJS::toJS): Changed to call the
        JSHTMLElementWrapperFactory function createJSWrapper, instead
        of always creating a JSHTMLElement.

        * bindings/js/kjs_html.h: Removed canvas-related stuff. Added HTMLElement
        prototype.
        * bindings/js/kjs_html.cpp:
        (KJS::JSHTMLElement::classInfo): Removed canvas element.
        (KJS::JSHTMLElement::accessors): Ditto.
        (KJS::JSHTMLElementProtoFunc::callAsFunction): Added, to help the auto-binding
        machiner cope with HTMLElement.
        (KJS::HTMLElementFunction::callAsFunction): Removed canvas element.

        * bindings/scripts/CodeGeneratorJS.pm: Added types needed for HTMLCanvasElement.

        * bridge/mac/FrameMac.mm: (WebCore::FrameMac::setDisplaysWithFocusAttributes):
        Changed to create a GraphicsContext with the new constructor that takes
        a CGContextRef.
        * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]):
        Changed to create a GraphicsContext with the new constructor that takes
        a NSGraphicsContext.
        * page/Frame.cpp: (WebCore::Frame::adjustPageHeight): Changed to create a
        GraphicsContext with the new constructor that takes a CGContextRef.

        * editing/SelectionController.cpp: (WebCore::SelectionController::paintCaret):
        Eliminated a use of obsolete class Brush.

        * html/CanvasPattern.h:
        * html/CanvasPattern.cpp:
        (WebCore::CanvasPattern::parseRepetitionType): Added. Parses a repetition
        type. Different from the old logic in that it is case-sensitive and rejects
        anything other than null, empty string, or the four repeat types.
        (WebCore::CanvasPattern::CanvasPattern): Added constructor that takes
        a CGImageRef. Changed constructor to take two booleans instead of the repetition
        type string. It's the caller's responsibility to parse the string.
        (WebCore::CanvasPattern::~CanvasPattern): Release the CGImage.
        (WebCore::patternCallback): Handle the CGImage case. Also changed the code
        to create a GraphicsContext as needed and call the image drawing code with that.
        (WebCore::CanvasPattern::createPattern): Handle both the image element case and
        the canvas element case.

        * html/CanvasRenderingContext2D.h:
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::State::State): Change line cap, line join,
        and global composite to store enum values instead of strings.
        (WebCore::CanvasRenderingContext2D::setLineWidth): Do nothing if width is NaN
        or <= 0.
        (WebCore::CanvasRenderingContext2D::lineCap): Return a string based on a
        stored enum, rather than returning a stored string.
        (WebCore::CanvasRenderingContext2D::setLineCap): Do nothing if the string is
        not one of the standard line cap types. Also case sensitive and stores enum
        rather than the string.
        (WebCore::CanvasRenderingContext2D::lineJoin): Return a string based on a
        stored enum, rather than returning a stored string.
        (WebCore::CanvasRenderingContext2D::setLineJoin): Do nothing if the string is
        not one of the standard line join types. Also case sensitive and stores enum
        rather than the string.
        (WebCore::CanvasRenderingContext2D::setMiterLimit): Do nothing if limit is NaN
        or <= 0.
        (WebCore::CanvasRenderingContext2D::setGlobalAlpha): Do nothing if alpha is NaN
        or < 0 or > 1.
        (WebCore::CanvasRenderingContext2D::globalCompositeOperation): Return a string
        based on a stored enum, rather than returning a stored string.
        (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation): Do nothing if
        the string is not one of the standard compositing modes. Also case sensitive and
        stores enum rather than the string.
        (WebCore::CanvasRenderingContext2D::arcTo): Generate INDEX_SIZE_ERR exception
        if radius is NaN or <= 0.
        (WebCore::CanvasRenderingContext2D::arc): Ditto.
        (WebCore::CanvasRenderingContext2D::rect): Generate INDEX_SIZE_ERR exception
        if width or height is NaN or <= 0.
        (WebCore::CanvasRenderingContext2D::clearRect): Ditto.
        (WebCore::CanvasRenderingContext2D::fillRect): Ditto.
        (WebCore::CanvasRenderingContext2D::strokeRect): Ditto, same for line width.
        Changed the case where the line width is not specified to share code with the
        case where it is.
        (WebCore::size): Renamed from imageSize, since C++ overloads based on parameter
        types anyway.
        (WebCore::CanvasRenderingContext2D::drawImage): Generate INDEX_SIZE_ERR exception
        if the source rect is not entirely inside the image rect, or if the width or height
        of either the source or destination rect is NaN or <= 0. Changed image drawing
        code to be platform-independent for the image element case, but not yet for the
        canvas case.
        (WebCore::CanvasRenderingContext2D::drawImageFromRect): Change code to parse the
        composite operation to use the new code shared with Image.
        (WebCore::CanvasRenderingContext2D::createPattern): Added code to parse the
        repetition type separately before creating the pattern. Added an overload for
        canvas elements.
        (WebCore::CanvasRenderingContext2D::drawingContext): Changed to return a
        GraphicsContext*.
        (WebCore::CanvasRenderingContext2D::platformContext): Added. Now does what
        drawingContext used to do.

        * html/CanvasRenderingContext2D.idl: Added exception declarations as needed
        for changes above.

        * html/HTMLCanvasElement.h:
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::HTMLCanvasElement): Changed m_drawingContext
        to be a GraphicsContext instead of a CGContextRef.
        (WebCore::HTMLCanvasElement::~HTMLCanvasElement): Ditto.
        (WebCore::HTMLCanvasElement::getContext): Removed special cases for null
        and empty string. Only give a 2D graphics context if the string is "2d".
        (WebCore::HTMLCanvasElement::reset): Updated for change to GraphicsContext
        from CGContextRef.
        (WebCore::HTMLCanvasElement::paint): Ditto.
        (WebCore::HTMLCanvasElement::createDrawingContext): Changed to create a
        GraphicsContext* instead of a CGContextRef.
        (WebCore::HTMLCanvasElement::drawingContext): Changed to return a
        GraphicsContext* instead of a CGContextRef.
        (WebCore::HTMLCanvasElement::createPlatformImage): Updated for changes above.

        * html/HTMLCanvasElement.idl: Added.

        * html/HTMLParser.h:
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::canvasCreateErrorCheck): Added. An attempt to implement the
        fallback behavior for canvas elements when JavaScript is off.
        (WebCore::HTMLParser::getNode): Sorted list of functions. Added case for canvas.

        * html/html_imageimpl.h:
        * html/html_imageimpl.cpp:
        (WebCore::HTMLImageElement::HTMLImageElement): Changed m_compositeOperator to be
        an enum instead of a string.
        (WebCore::HTMLImageElement::parseMappedAttribute): Parse the enum here.

        * kcanvas/KCanvasResources.h:
        * kcanvas/KCanvasResources.cpp: (WebCore::KCanvasMarker::draw): Changed to take a
        GraphicsContext parameter.

        * kcanvas/RenderPath.h: Added GraphicsContext parameter to drawMarkersIfNeeded.

        * kcanvas/RenderPath.cpp: (WebCore::RenderPath::paint):
        * kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
        * kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
        Changed to generate and use an appropriate GraphicsContext.

        * kcanvas/device/quartz/KCanvasItemQuartz.h: Added GraphicsContext parameter to
        drawMarkersIfNeeded.
        * kcanvas/device/quartz/KCanvasItemQuartz.mm:
        (WebCore::DrawMarkersData::DrawMarkersData): Added GraphicsContext*.
        (WebCore::drawMarkerWithData): Pass along a GraphicsContext*.
        (WebCore::drawStartAndMidMarkers): Ditto.
        (WebCore::KCanvasItemQuartz::drawMarkersIfNeeded): Pass a long a GraphicsContext*.

        * kcanvas/device/KRenderingDevice.h: Added a pure virtual createGraphicsContext
        to bridge back to a GraphicsContext. Long term that class will replace this one.
        * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        (WebCore::KRenderingDeviceContextQuartz::createGraphicsContext): Added.

        * ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
        Create and pass a GraphicsContext -- old code used the default constructor for
        GraphicsContext which meant "current context", and that no longer exists.
        * ksvg2/svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::drawPatternContentIntoTile): Ditto.

        * platform/Brush.h: Removed.
        * platform/CompositeOperator.h: Added.
        * platform/CompositeOperator.cpp: Added.

        * platform/Font.h: Changed calls to use IntPoint instead of pairs of ints.
        Also removed the const from all the uses of GraphicsContext*.

        * platform/GraphicsContext.h: Eliminated default constructor and constructor
        that takes only a boolean. Replaced with constructors that take platform
        graphics contexts only. Replaced brush-related calls with fill color calls.
        Replaced use of Brush with use of Color. Changed Image::CompositeOperator to
        just plain CompositeOperator. Changed tuples of ints into IntRect and IntPoint.
        Moved setFocusRingClip and clearFocusRingClip out of ifdefs. Removed unused
        getCompositeOperation and string-based setCompositeOperation. Moved
        currentCGContext and the other setCompositeOperation out of the GraphicsContext
        class and made them global functions. Fixed platformContext so it won't always
        return the CGContextRef of the current NSGraphicsContext. Instead, it will
        return the appropriate CGContextRef for the GraphicsContext. This eliminates
        the need to use void* for the image-drawing functions.

        * platform/GraphicsContext.cpp:
        (WebCore::GraphicsContextState::GraphicsContextState): Replaced Brush with
        an RGBA fill color.
        (WebCore::GraphicsContext::setFillColor): Renamed from setBrush.
        (WebCore::GraphicsContext::fillColor): Renamed from brush.
        (WebCore::GraphicsContext::drawImage): Changed to use IntRect.
        (WebCore::GraphicsContext::drawTiledImage): Moved here from GraphicsContextMac.mm.
        (WebCore::GraphicsContext::drawText): Changed to use IntPoint.
        (WebCore::GraphicsContext::drawHighlightForText): Ditto.
        (WebCore::GraphicsContext::drawLineForText): Ditto.
        (WebCore::GraphicsContext::drawLineForMisspelling): Ditto.

        * platform/Image.h: Removed CompositeOperator and related functions.
        Removed void* context parameters from draw functions.

        * platform/Image.cpp: Removed compositeOperatorFromString.

        * platform/Widget.h: Added a GraphicsContext* return value from lockDrawingFocus
        that you pass back to unlockDrawingFocus (for deletion).

        * platform/mac/FontMac.mm:
        (WebCore::Font::selectionRectForText): Changed parameter to point and removed
        const on GraphicsContext* parameter.
        (WebCore::Font::drawText): Ditto.
        (WebCore::Font::drawHighlightForText): Ditto.
        (WebCore::Font::drawLineForText): Ditto.
        (WebCore::Font::drawLineForMisspelling): Ditto.
        (WebCore::Font::misspellingLineThickness): Removed const.

        * platform/mac/GraphicsContextMac.mm:
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
        Added fields to store a CGContextRef and an NSGraphicsContext.
        (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
        Release both the CGContextRef and the NSGraphicsContext.
        (WebCore::GraphicsContext::GraphicsContext): Implement to set up both the
        CGContextRef and the NSGraphicsContext in one case, and only the CGContextRef
        in the other.
        (WebCore::GraphicsContext::savePlatformState): Implement for the CGContext-only
        case.
        (WebCore::GraphicsContext::restorePlatformState): Ditto.
        (WebCore::GraphicsContext::drawRect): Assert that the NS context is present
        and
        (WebCore::GraphicsContext::setColorFromFillColor): Renamed from
        setColorFromBrush.
        (WebCore::GraphicsContext::setColorFromPen): Added assertion.
        (WebCore::GraphicsContext::drawLine): Added assertion.
        (WebCore::GraphicsContext::drawEllipse): Get CGContext from the platformContext
        function instead of currentCGContext, and changed to use fillColor.
        (WebCore::GraphicsContext::drawArc): Ditto.
        (WebCore::GraphicsContext::drawConvexPolygon): Ditto.
        (WebCore::setCompositeOperation): Changed to global function and also changed
        to do the work here -- no need to use WebCoreImageRendererFactory.
        (WebCore::GraphicsContext::drawImage): Move most of this into GraphicsContext.cpp.
        Remove the void* context parameter. Changed to take rects instead of separate coordinates.
        (WebCore::GraphicsContext::fillRect): Changed to take color instead of Brush.
        (WebCore::GraphicsContext::addClip): Added assertion.
        (WebCore::GraphicsContext::addRoundedRectClip): Get CGContextRef from the platformContext
        function instead of currentCGContext.
        (WebCore::GraphicsContext::createRenderingDeviceContext): Ditto.
        (WebCore::GraphicsContext::beginTransparencyLayer): Ditto.
        (WebCore::GraphicsContext::endTransparencyLayer): Ditto.
        (WebCore::GraphicsContext::setShadow): Change to take size instead of x,y. Also get
        CGCOntextRef from the platformContext function instead of currentCGContext.
        (WebCore::GraphicsContext::clearShadow): Get CGContextRef from the platformContext
        function instead of currentCGContext.
        (WebCore::GraphicsContext::platformContext): Added. Returns m_data->m_cgContext.

        * platform/mac/ImageMac.mm:
        (WebCore::fillSolidColorInRect): Updated for change in CompositeOperator type.
        (WebCore::Image::checkForSolidColor): Ditto.
        (WebCore::Image::draw): Removed void* context parameter and replaced it with
        a GraphicsContext* parameter. Renamed from drawInRect.
        (WebCore::Image::drawTiled): Ditto. Renamed from tileInRect and scaleAndTileInRect.

        * platform/mac/PDFDocumentImage.h: Updated for change in CompositeOperator type.
        * platform/mac/PDFDocumentImage.mm: (WebCore::PDFDocumentImage::draw): Ditto.

        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::lockDrawingFocus): Changed to return a GraphicsContext*.
        (WebCore::Widget::unlockDrawingFocus): Changed to take a GraphicsContext*.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::selectionRect): Changed to pass IntPoint.
        (WebCore::InlineTextBox::paint): Changed to pass IntSize.
        (WebCore::InlineTextBox::paintSelection): More of the same.
        (WebCore::InlineTextBox::paintMarkedTextBackground): Ditto.
        (WebCore::InlineTextBox::paintDecoration): Ditto.
        (WebCore::InlineTextBox::paintSpellingMarker): Ditto.
        (WebCore::InlineTextBox::paintTextMatchMarker): Ditto.
        (WebCore::InlineTextBox::paintMarkedTextUnderline): Ditto.
        (WebCore::InlineTextBox::positionForOffset): Ditto.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::fillHorizontalSelectionGap): Ditto.
        (WebCore::RenderBlock::fillVerticalSelectionGap): Ditto.
        (WebCore::RenderBlock::fillLeftSelectionGap): Ditto.
        (WebCore::RenderBlock::fillRightSelectionGap): Ditto.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBackgroundExtended): Ditto.
        (WebCore::RenderBox::outlineBox): Ditto.
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint): Ditto.
        * rendering/RenderLayer.cpp:
        (WebCore::setClip): Take out ifdefs. We'll do that inside GraphicsContext instead.
        (WebCore::restoreClip): Ditto.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBorder): More of the same.
        (WebCore::RenderObject::paintBorderImage): Ditto.
        * rendering/render_line.cpp:
        (WebCore::InlineFlowBox::paintDecorations): Ditto.
        (WebCore::EllipsisBox::paint): Ditto.
        * rendering/render_list.cpp:
        (WebCore::RenderListMarker::paint): Ditto.

        * rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize): Set up a graphics
        context by calling lockDrawingFocus. Also changed a color here to be a constant.

        * platform/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::drawImage): Update for parameter type changes.
        (WebCore::GraphicsContext::drawScaledAndTiledImage):
        (WebCore::GraphicsContext::setFocusRingClip):
        (WebCore::GraphicsContext::clearFocusRingClip):
        * platform/cairo/ImageCairo.cpp:
        (WebCore::setCompositingOperation):
        (WebCore::Image::tileInRect):
        (WebCore::Image::scaleAndTileInRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Updated test results for:
adele [Fri, 21 Apr 2006 05:56:37 +0000 (05:56 +0000)]
    Updated test results for:
        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8276
          REGRESSION (NativeTextField): Pasting a Finder item into a text field results in
            a file: URL being pasted instead of just the file name
        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8283
          REGRESSION: File's path doesn't appear after dragging file into input field

        * editing/pasteboard/drop-text-without-selection-expected.txt:
        * fast/forms/input-paste-undo-expected.txt:
        * fast/forms/input-truncate-newline-expected.txt:
        * fast/forms/plaintext-mode-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele [Fri, 21 Apr 2006 04:51:48 +0000 (04:51 +0000)]
WebCore:

        Reviewed by Darin.

        WebCore part of:
        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8276
          REGRESSION (NativeTextField): Pasting a Finder item into a text field results in
            a file: URL being pasted instead of just the file name
        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8283
          REGRESSION: File's path doesn't appear after dragging file into input field

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge isDragCaretRichlyEditable]): Added.
        * manual-tests/plain-text-paste.html: Added.
        * manual-tests/resources/plain-text-paste: Added.
        * manual-tests/resources/plain-text-paste/1.textClipping: Added.
        * manual-tests/resources/plain-text-paste/2.textClipping: Added.
        * manual-tests/resources/plain-text-paste/3.gif: Added.
        * manual-tests/resources/plain-text-paste/4.txt: Added.
        * manual-tests/resources/plain-text-paste/5.webloc: Added.

WebKit:

        Reviewed by Darin.

        WebKit part of:
        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8276
          REGRESSION (NativeTextField): Pasting a Finder item into a text field results in
            a file: URL being pasted instead of just the file name
        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8283
          REGRESSION: File's path doesn't appear after dragging file into input field

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _plainTextFromPasteboard:]): Added method that tries to copy AppKit
        text fields' logic for extracting plain text from the pasteboard.
        (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added helper method.
        (-[WebHTMLView _shouldInsertText:replacingDOMRange:givenAction:]):
        (-[WebHTMLView _shouldReplaceSelectionWithText:givenAction:]):
        (-[WebHTMLView readSelectionFromPasteboard:]): Paste as plain text if
        rich text is not allowed.
        (-[WebHTMLView validateUserInterfaceItem:]): Changed to not allow pasteAsRichText:
        if the paste is not going to be handled by the DOM and the selection
        does not allow pasting rich text.
        (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Paste as plain text if
        rich text is not allowed.
        (-[WebHTMLView paste:]): Ditto.
        (-[WebHTMLView pasteAsPlainText:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin [Fri, 21 Apr 2006 04:32:26 +0000 (04:32 +0000)]
WebCore:

        Reviewed by Adele.

        - WebCore part of http://bugzilla.opendarwin.org/show_bug.cgi?id=8505
          eliminate WebCoreGraphics bridge, demonstrate new SystemInterface technique

        * platform/mac/WebCoreGraphicsBridge.h: Removed.
        * platform/mac/WebCoreGraphicsBridge.m: Removed.
        * platform/mac/WebCoreSystemInterface.h: Added.
        * platform/mac/WebCoreSystemInterface.mm: Added.

        * WebCore.exp: Add new SystemInterface globals, remove WebCoreGraphicsBridge.

        * WebCore.xcodeproj/project.pbxproj: Updated for removed and added files.
        Sorted files.

        * bridge/mac/FrameMac.mm: Removed unneeded include of WebCoreGraphicsBridge.h.

        * platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::setDragImage):
        Moved code from WebGraphicsBridge here, using WebCoreSystemInterface so we can
        call wkSetDragImage.

        * platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):
        Moved code from WebGraphicsBridge here, using WebCoreSystemInterface so we can
        call wkDrawFocusRing.

        * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextField):
        Call wkDrawBezeledTextFieldCell from WebCoreSystemInterface instead of using
        WebGraphicsBridge to do the same thing.

WebKit:

        Reviewed by Adele.

        - WebKit part of http://bugzilla.opendarwin.org/show_bug.cgi?id=8505
          eliminate WebCoreGraphics bridge, demonstrate new SystemInterface technique

        * WebCoreSupport/WebGraphicsBridge.h: Removed.
        * WebCoreSupport/WebGraphicsBridge.m: Removed.
        * WebCoreSupport/WebSystemInterface.h: Added.
        * WebCoreSupport/WebSystemInterface.m: Added.

        * WebKit.xcodeproj/project.pbxproj: Updated for removed and added files.

        * WebCoreSupport/WebImageData.m: Removed unneeded include of WebGraphicsBridge.h.
        * WebCoreSupport/WebImageRenderer.m: Ditto.
        * WebCoreSupport/WebTextRenderer.m: Ditto.

        * WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]): Guarded all the one-time
        initialization inside a boolean, just in case some things take a little time. Added
        a call to InitWebCoreSystemInterface to the one-time initialization here. Later, we
        will need to add it in some other places if we call code that requires the use of
        WebCoreSystemInterface functions from anywhere that can be invoked before creations
        of the first WebFrameView, but for now there is no need.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Thu, 20 Apr 2006 22:22:14 +0000 (22:22 +0000)]
LayoutTests:

        Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8273
        REGRESSION: Read only input text field renders at the wrong height when value attribute is not present

        * fast/forms/input-readonly-empty-expected.checksum: Added.
        * fast/forms/input-readonly-empty-expected.png: Added.
        * fast/forms/input-readonly-empty-expected.txt: Added.
        * fast/forms/input-readonly-empty.html: Added.

WebCore:

        Reviewed by Hyatt.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8273
        REGRESSION: Read only input text field renders at the wrong height when value attribute is not present

        Test: fast/forms/input-readonly-empty.html

        * rendering/RenderBlock.h: Added hasLineIfEmpty.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::hasLineIfEmpty): Added.  Checks for rootEditableElement as well as
         a shadowNode who has an input element as a parent.
        (WebCore::RenderBlock::getBaselineOfLastLineBox): Calls hasLineIfEmpty instead of just checking for the rootEditableElement.
        * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Timothy.
thatcher [Thu, 20 Apr 2006 19:08:18 +0000 (19:08 +0000)]
    Reviewed by Timothy.

        Removed TO_NODE_OFFSET and TO_NODE_ADDRESS macros. These can just be done inline with pointer math.

        * platform/DeprecatedString.cpp:
        (allocateNode):
        (freeHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Updated test to use webkit-block-placeholder instead of khtml-block-placeholder.
adele [Thu, 20 Apr 2006 06:31:18 +0000 (06:31 +0000)]
    Updated test to use webkit-block-placeholder instead of khtml-block-placeholder.

        * editing/inserting/insert-div-010.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Updating test results that were incorrectly checked in
adele [Thu, 20 Apr 2006 06:05:24 +0000 (06:05 +0000)]
    Updating test results that were incorrectly checked in
        when many of the table test results changed recently due to Color
        improvements.

        * tables/mozilla/bugs/bug625-expected.checksum:
        * tables/mozilla/bugs/bug625-expected.png:
        * tables/mozilla/bugs/bug625-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Updated results after rolling out optimizations in setInnerText and setInnerHTML.
adele [Thu, 20 Apr 2006 05:22:37 +0000 (05:22 +0000)]
    Updated results after rolling out optimizations in setInnerText and setInnerHTML.

        * fast/events/updateLayoutForHitTest-expected.txt:
        * fast/forms/input-text-paste-maxlength-expected.txt:
        * fast/text/attributed-substring-from-range-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Darin.
adele [Thu, 20 Apr 2006 03:01:54 +0000 (03:01 +0000)]
    Rubber-stamped by Darin.

        Removed optimizations recently added in setInnerHTML and setInnerText.  The setInnerHTML change broke a first-letter style test.
        The setInnerText change caused an empty text node to get added when setting inner text to an empty string.  The bug that this
        change went in with remains fixed.

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::setInnerHTML):
        (WebCore::HTMLElement::setInnerText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Haytt.
thatcher [Thu, 20 Apr 2006 02:51:48 +0000 (02:51 +0000)]
    Reviewed by Haytt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6770
          REGRESSION: Incomplete repaint when block with clipping grows

        * manual-tests/repaint-resized-overflow.html: Added.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer):
        (WebCore::RenderLayer::computeRepaintRects): Set the m_repaintOverflowOnResize
        flag to true if our object itself needs layout or if we're an overflow
        and have a normal child that needs layout, in which case if we end up
        resizing it will be because of the child, and that child might have not repainted
        itself correctly during its own layout.
        (WebCore::RenderLayer::updateLayerPositions): Do a full repaint if
        m_repaintOverflowOnResize is set and we resized but didn't move.
        * rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
thatcher [Thu, 20 Apr 2006 02:33:53 +0000 (02:33 +0000)]
    Reviewed by Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8352
          CSS text-shadow does not repaint completely when changed

        * manual-tests/dynamic-shadow.html: Added.
        * rendering/render_style.cpp:
        (WebCore::RenderStyle::diff): Changed to return Layout when text-shadow
        changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Timothy.
thatcher [Thu, 20 Apr 2006 02:18:56 +0000 (02:18 +0000)]
    Reviewed by Timothy.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8442
        Bug 8442: improvements to Cocoa bindings support in WebView - code simplification

        Removes the WebController class added earlier; changes NSTreeController and
        WebView to together without it. Now you can just bind the contentObject binding
        of the tree controller directly to the mainFrameDocument key of the WebView.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge windowObjectCleared]):
        * WebView/WebDataSource.m:
        (-[WebDataSource _setTitle:]):
        * WebView/WebFrame.m:
        (-[WebFrame _closeOldDataSources]):
        * WebView/WebView.m:
        (-[WebView _progressStarted:]):
        (-[WebView _finalProgressComplete]):
        (-[WebView _commonInitializationWithFrameName:groupName:]):
        (-[WebView setMainFrameDocumentReady:]):
        (-[WebView mainFrameDocument]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the change log for my last commit, change was done by James G. Speth <speth...
thatcher [Thu, 20 Apr 2006 02:07:32 +0000 (02:07 +0000)]
Fix the change log for my last commit, change was done by James G. Speth  <speth@end.com>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Timothy.
thatcher [Thu, 20 Apr 2006 02:06:44 +0000 (02:06 +0000)]
    Reviewed by Timothy.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=6635
        Bug 6635: Crash selecting inspector nodes for tabs that aren't foremost

        Stop observing window will close notifications before we tell the highlight window to close,
        this prevents the crash. Also prevent drawing highlights for hidden tabs.

        * WebInspector/WebInspector.m:
        (-[WebInspector _highlightNode:]):
        * WebInspector/WebNodeHighlight.m:
        (-[WebNodeHighlight expire]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
adele [Thu, 20 Apr 2006 02:04:46 +0000 (02:04 +0000)]
    Reviewed by Darin.

        Added readOnly methods for HTMLInputElement and HTMLTextAreaElement so the DOM bindings can call
        a method with the same name.  This will make it easier to autogenerate the DOM bindings in the future.

        * html/HTMLInputElement.h: (WebCore::HTMLInputElement::readOnly): Added. Calls isReadOnlyControl.
        * html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::readOnly): ditto.
        * bindings/js/kjs_html.cpp:
        (KJS::JSHTMLElement::inputGetter): Calls readOnly instead of isReadOnlyControl.
        (KJS::JSHTMLElement::textAreaGetter): ditto.
        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLInputElement readOnly]): ditto.
        (-[DOMHTMLTextAreaElement readOnly]): Calls readOnly instead of getting the attribute directly.
        (-[DOMHTMLTextAreaElement setReadOnly:]): Calls setReadOnly instead of setting the attribute directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Timothy.
thatcher [Thu, 20 Apr 2006 01:44:35 +0000 (01:44 +0000)]
    Reviewed by Timothy.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=6637
        Bug 6637: selecting node in Inspector after closing window crashes Safari

        When the window the Web Inspector was inspecting is closed, the inspector goes into its
        no-selection state. Choosing to inspect another element activates it again. The inspector
        will also follow the WebView if the URL changes and select the root element on the new page.

        * WebInspector/WebInspector.m:
        (-[NSWindow setWebFrame:]):
        (-[NSWindow setRootDOMNode:]):
        (-[WebInspector _revealAndSelectNodeInTree:]):
        (-[WebInspector _update]):
        (-[WebInspector _updateRoot]):
        (-[WebInspector inspectedWebViewProgressFinished:]):
        (-[WebInspector inspectedWindowWillClose:]):
        (-[WebInspector webView:didFinishLoadForFrame:]):
        * WebInspector/WebInspectorPanel.m:
        (-[WebInspectorPanel canBecomeMainWindow]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Thu, 20 Apr 2006 01:03:50 +0000 (01:03 +0000)]
LayoutTests:

        Updated results for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8297
        REGRESSION: Input element extends outside of DIV element at http://www.macdock.com/

        * editing/selection/3690703-2-expected.checksum:
        * editing/selection/3690703-2-expected.png:
        * editing/selection/3690703-2-expected.txt:
        * editing/selection/3690703-expected.checksum:
        * editing/selection/3690703-expected.png:
        * editing/selection/3690703-expected.txt:
        * editing/selection/3690719-expected.checksum:
        * editing/selection/3690719-expected.png:
        * editing/selection/3690719-expected.txt:
        * fast/forms/input-appearance-minWidth-expected.checksum:
        * fast/forms/input-appearance-minWidth-expected.png:
        * fast/forms/input-appearance-minWidth-expected.txt:
        * fast/forms/input-appearance-width-expected.checksum:
        * fast/forms/input-appearance-width-expected.png:
        * fast/forms/input-appearance-width-expected.txt:
        * fast/forms/input-double-click-selection-gap-bug-expected.checksum:
        * fast/replaced/width100percent-expected.checksum:
        * fast/replaced/width100percent-expected.png:
        * fast/replaced/width100percent-expected.txt:
        * tables/mozilla/bugs/bug1188-expected.checksum:
        * tables/mozilla/bugs/bug1188-expected.png:
        * tables/mozilla/bugs/bug1188-expected.txt:
        * tables/mozilla/bugs/bug12384-expected.checksum:
        * tables/mozilla/bugs/bug12384-expected.png:
        * tables/mozilla/bugs/bug12384-expected.txt:
        * tables/mozilla/bugs/bug18359-expected.checksum:
        * tables/mozilla/bugs/bug18359-expected.png:
        * tables/mozilla/bugs/bug18359-expected.txt:
        * tables/mozilla/bugs/bug55545-expected.checksum:
        * tables/mozilla/bugs/bug55545-expected.png:
        * tables/mozilla/bugs/bug55545-expected.txt:
        * tables/mozilla/bugs/bug7342-expected.checksum:
        * tables/mozilla/bugs/bug7342-expected.png:
        * tables/mozilla/bugs/bug7342-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug2479-2-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug2479-2-expected.png:
        * tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt:

WebCore:

        Reviewed by Hyatt.

        Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8297
        REGRESSION: Input element extends outside of DIV element at http://www.macdock.com/

        * platform/Font.h: Added runRounding parameter to floatWidth.
        * platform/mac/FontMac.mm: (WebCore::Font::floatWidth): ditto.
        * platform/win/FontWin.cpp: (WebCore::Font::floatWidth): ditto.
        * rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
          Use new floatWidth parameter to turn off run rounding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth.
adele [Wed, 19 Apr 2006 22:40:10 +0000 (22:40 +0000)]
    Reviewed by Beth.

        Fix for Windows build.

        * rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::determineState):
        Use isReadOnlyControl instead of isReadOnly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Wed, 19 Apr 2006 22:21:22 +0000 (22:21 +0000)]
LayoutTests:

        Tests for change to make readonly text fields have dimmed borders.

        * fast/forms/input-appearance-readonly-expected.checksum:
        * fast/forms/input-appearance-readonly-expected.png:
        * fast/forms/input-readonly-dimmed-expected.checksum: Added.
        * fast/forms/input-readonly-dimmed-expected.png: Added.
        * fast/forms/input-readonly-dimmed-expected.txt: Added.
        * fast/forms/input-readonly-dimmed.html: Added.

WebCore:

 2006-04-19  Adele Peterson  <adele@apple.com>

         Reviewed by Beth.

         Fix to make readonly text fields have dimmed borders to match AppKit behavior.

         Test: fast/forms/input-readonly-dimmed.html

         * dom/Node.h: (WebCore::Node::isReadOnlyControl): Changed from const version of isReadOnly.
         * dom/Node.cpp:
         (WebCore::Node::isReadOnlyNode): Changed from isReadOnly.
         (WebCore::Node::setNodeValue): Uses isReadOnlyNode instead of isReadOnly.
         (WebCore::Node::checkSetPrefix): ditto.
         (WebCore::Node::checkAddChild): ditto.
         * dom/Attr.cpp: (WebCore::Attr::setValue): ditto.
         * dom/CharacterData.cpp:
         (WebCore::CharacterData::setData): ditto.
         (WebCore::CharacterData::appendData): ditto.
         (WebCore::CharacterData::checkCharDataOperation): ditto.
         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChild): ditto.
         * dom/Element.cpp: (WebCore::Element::setAttribute): ditto.
         * dom/NamedAttrMap.cpp:
         (WebCore::NamedAttrMap::setNamedItem): ditto.
         (WebCore::NamedAttrMap::removeNamedItem): ditto.
         * dom/NamedAttrMap.h: (WebCore::NamedAttrMap::isReadOnlyNode): ditto.
         * dom/NamedNodeMap.h: (WebCore::NamedNodeMap::isReadOnlyNode): ditto.
         * dom/Range.cpp:
         (WebCore::Range::checkDeleteExtract): ditto.
         (WebCore::Range::containedByReadOnly): ditto.
         * dom/Text.cpp: (WebCore::Text::splitText): ditto.
         * dom/dom_xmlimpl.cpp: (WebCore::ProcessingInstruction::setData): ditto.

         * bindings/js/kjs_html.cpp:
         (KJS::JSHTMLElement::inputGetter): Uses isReadOnlyControl instead of isReadOnly.
         (KJS::JSHTMLElement::textAreaGetter): ditto.
         * bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement readOnly]): ditto.
         * rendering/render_form.cpp:
         (WebCore::RenderLineEdit::updateFromElement): ditto.
         (WebCore::RenderTextArea::updateFromElement): ditto.
         * rendering/RenderTextField.cpp:
         (WebCore::RenderTextField::createDivStyle): ditto.
         (WebCore::RenderTextField::updateFromElement): ditto.

         * html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::parseMappedAttribute):
           When readonly attribute changes, update the theme so the control will repaint.
         * html/HTMLGenericFormElement.h: (WebCore::HTMLGenericFormElement::isReadOnlyControl): Renamed from readOnly.
         * html/HTMLInputElement.h: Removed isReadOnly, since isReadOnlyControl now exists on HTMLGenericFormElement.
         * rendering/RenderTheme.cpp: (WebCore::RenderTheme::isReadOnlyControl): Renamed from isReadOnly.
         * rendering/RenderTheme.h: (WebCore::): Added ReadOnlyState to ControlState enum.
         * rendering/RenderThemeMac.h: Removed NSTextFieldCell since it was only being used to store the enabled state.
           Removed setTextFieldState since it was updating the enabled state of the cell, which is only used in one place.
         * rendering/RenderThemeMac.mm:
         (WebCore::RenderThemeMac::RenderThemeMac): No longer initialized the NSTextFieldCell.
         (WebCore::RenderThemeMac::adjustRepaintRect): No longer calls setTextFieldState.
         (WebCore::RenderThemeMac::paintTextField): Uses the enabled state and the readonly state to determine whether to draw
          a dimmed version of the aqua border.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
bdakin [Wed, 19 Apr 2006 19:35:09 +0000 (19:35 +0000)]
    Reviewed by Hyatt.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8467 Block
        with percentage background-size doesn't repaint properly when it
        grows

        * manual-tests/backgroundSizeRepaint.html: Added.
        * manual-tests/resources/apple.jpg: Added.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::mustRepaintBackgroundOrBorder): We must
        return true if we have a percentage background-size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for a regression in the new text fields. Don't allow the repaint
hyatt [Wed, 19 Apr 2006 18:47:03 +0000 (18:47 +0000)]
    Fix for a regression in the new text fields.  Don't allow the repaint
        rect created by dynamic line layout changes to spill out of an overflow
        area's clip region.

        (There is no test, since we have no way of testing cases where we repaint
         too much rather than too little.)

        Reviewed by darin

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for bug 8449, incomplete repaint of table cell that moved. This
hyatt [Wed, 19 Apr 2006 18:17:54 +0000 (18:17 +0000)]
    Fix for bug 8449, incomplete repaint of table cell that moved.  This
        fix also solves some of the textfield repainting problems (e.g., on
        google.com and lxr.mozilla.org).

        Reviewed by hyatt

        * manual-tests/table-cell-move.html: Added.
        * rendering/RenderCanvas.cpp:
        (WebCore::RenderCanvas::repaintViewRectangle):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::layoutRows):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix by Mitz Pettel, reviewed by Eric.
ap [Wed, 19 Apr 2006 16:45:13 +0000 (16:45 +0000)]
    Fix by Mitz Pettel, reviewed by Eric.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8469
          CRASH: WebCore::CSSParser::parseDashboardRegions when attr() is passed

        Test: fast/css/dashboard-regions-attr-crash.html

        * css/cssparser.cpp:
        (WebCore::CSSParser::parseDashboardRegions): Added null check for args.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-04-18 Rob Buis <buis@kde.org>
eseidel [Wed, 19 Apr 2006 11:03:52 +0000 (11:03 +0000)]
2006-04-18  Rob Buis  <buis@kde.org>

        Reviewed by eseidel & darin.  Landed by eseidel.

        No automated tests possible (from javascript).

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6664:
        Inspector does not highlight SVG elements properly

        Make sure RenderObject::absoluteBoundingBoxRect works for
        svg specific render objects by overriding absoluteRects.
        This fixes highlighting in the Inspector of svg shapes, paths,
        images and text.

        * kcanvas/RenderPath.cpp:
        (WebCore::RenderPath::absoluteRects):
        * kcanvas/RenderPath.h:
        * kcanvas/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
        (WebCore::RenderSVGImage::absoluteRects):
        * kcanvas/RenderSVGImage.h:
        * kcanvas/RenderSVGText.cpp:
        (WebCore::RenderSVGText::absoluteRects):
        * kcanvas/RenderSVGText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-04-17 Rob Buis <buis@kde.org>
eseidel [Wed, 19 Apr 2006 10:57:05 +0000 (10:57 +0000)]
2006-04-17  Rob Buis  <buis@kde.org>

        Reviewed by eseidel.  Landed by eseidel.

        Test: svg/custom/tref-update.svg

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6427:
        <tref> element not implemented

        Implementation of <tref> element.

        * WebCore.xcodeproj/project.pbxproj:
        * ksvg2/svg/SVGTRefElement.cpp: Added.
        (SVGTRefElement::SVGTRefElement):
        (SVGTRefElement::~SVGTRefElement):
        (SVGTRefElement::parseMappedAttribute):
        (SVGTRefElement::closeRenderer):
        (SVGTRefElement::childShouldCreateRenderer):
        (SVGTRefElement::createRenderer):
        * ksvg2/svg/SVGTRefElement.h: Added.
        (WebCore::SVGTRefElement::rendererIsNeeded):
        * ksvg2/svg/SVGTSpanElement.cpp:
        (SVGTSpanElement::childShouldCreateRenderer):
        * ksvg2/svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::childShouldCreateRenderer):
        * ksvg2/svg/svgtags.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - attempt to fix Windows buildbot
darin [Wed, 19 Apr 2006 02:03:41 +0000 (02:03 +0000)]
    - attempt to fix Windows buildbot

        * Scripts/install-win-extras: Temporarily changed URLs to fr.rpmfind.net.
        We need a better long-term solution for this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth.
darin [Wed, 19 Apr 2006 00:56:22 +0000 (00:56 +0000)]
    Reviewed by Beth.

        * WebInspector/webInspector/inspector.css: Add "-webkit-" prefixes to the border
        radius properties to make the corners rounded again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth.
darin [Wed, 19 Apr 2006 00:51:42 +0000 (00:51 +0000)]
    Reviewed by Beth.

        - updated some results that were affected by recent changes

        There are some other failures that might be reflecting actual
        bugs; these seem fine though.

        * fast/events/updateLayoutForHitTest-expected.checksum:
        * fast/events/updateLayoutForHitTest-expected.png:
        * fast/events/updateLayoutForHitTest-expected.txt:
        Updated because the 4 clicks done in this test now seem to be
        behaving as a triple-click and selecting some text.

        * fast/forms/input-appearance-maxlength-expected.txt:
        * fast/forms/input-paste-undo-expected.txt:
        * fast/text/attributed-substring-from-range-expected.txt:
        Unimportant changes to the editing delegate calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * rendering/render_form.cpp: (WebCore::RenderSelect::updateFromElement):
darin [Wed, 19 Apr 2006 00:16:47 +0000 (00:16 +0000)]
    * rendering/render_form.cpp: (WebCore::RenderSelect::updateFromElement):
        Roll out accidentally-landed change for bug 8398.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
bdakin [Tue, 18 Apr 2006 23:47:13 +0000 (23:47 +0000)]
    Reviewed by Darin.

        Fix for a leak exposed by background-size and detected by the
        layout tests.

        * css/css_valueimpl.cpp:
        (WebCore::CSSPrimitiveValue::cleanup): We must deref pairs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
bdakin [Tue, 18 Apr 2006 23:10:20 +0000 (23:10 +0000)]
    Reviewed by Eric.

        Build fix for Windows. Just a few typos from background-size patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-04-18 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 18 Apr 2006 22:17:41 +0000 (22:17 +0000)]
2006-04-18  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        Fix "new Function()" to correctly use lexical scoping.
        Add ScopeChain::print() function for debugging.
        <rdar://problem/4067864> REGRESSION (125-407): JavaScript failure on PeopleSoft REN Server

        * kjs/function_object.cpp:
        (FunctionObjectImp::construct):
        * kjs/scope_chain.cpp:
        (KJS::ScopeChain::print):
        * kjs/scope_chain.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
bdakin [Tue, 18 Apr 2006 22:06:33 +0000 (22:06 +0000)]
    Reviewed by Hyatt.

        Implementation of CSS3 background-size property. See
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8353 for details.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded webkit detection scripts and info on how to use them.
jdevalk [Tue, 18 Apr 2006 21:56:31 +0000 (21:56 +0000)]
Added webkit detection scripts and info on how to use them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Tue, 18 Apr 2006 18:14:47 +0000 (18:14 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/pasteboard/merge-end-3-expected.checksum: Added.
        * editing/pasteboard/merge-end-3-expected.png: Added.
        * editing/pasteboard/merge-end-3-expected.txt: Added.
        * editing/pasteboard/merge-end-3.html: Added.

WebCore:

        Reviewed by harrison

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraph): The placeholder that's inserted
        to keep content from collapsing due to pruning was inserted at the position after
        the moved paragraph.  That's only appropriate when moving the paragraph backward
        into the previous paragraph.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): The last paragraph of the incoming
        fragment should be merged with the paragraph after the end of the selection being pasted
        into even if the incoming fragment has only one block.   This fixes a bug and gets
        rid of a use of the info gathered during the test insertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele [Tue, 18 Apr 2006 16:43:35 +0000 (16:43 +0000)]
WebCore:
        Reviewed by Darin.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8407
        REGRESSION (NativeTextField): Leading and trailing spaces trimmed from text field value attribute

        * rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle):
        Use white-space:pre for the inner div to avoid collapsing spaces in the text field.

LayoutTests:
        Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8407
        REGRESSION (NativeTextField): Leading and trailing spaces trimmed from text field value attribute

        * fast/forms/input-spaces-expected.checksum: Added.
        * fast/forms/input-spaces-expected.png: Added.
        * fast/forms/input-spaces-expected.txt: Added.
        * fast/forms/input-spaces.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin [Tue, 18 Apr 2006 16:37:40 +0000 (16:37 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8437
          iExploder(#293): Crash in StringImpl::hash()

        * manual-tests/applet-param-no-name.html: Added.
        * rendering/RenderApplet.cpp:
        (WebCore::RenderApplet::createWidgetIfNecessary): Skip param elements with
        empty name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix bug number in log message.
darin [Tue, 18 Apr 2006 16:30:55 +0000 (16:30 +0000)]
Fix bug number in log message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
darin [Tue, 18 Apr 2006 16:28:07 +0000 (16:28 +0000)]
    Reviewed by Geoff.

        - fix one more part of http://bugzilla.opendarwin.org/show_bug.cgi?id=4508
          Layout tests access an external server
          (patch in http://bugzilla.opendarwin.org/show_bug.cgi?id=8142)

        * fast/block/float/014.html: Use local image
        * fast/block/float/resources: Added.
        * fast/block/float/resources/training_thumb.jpg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix the Windows build
darin [Tue, 18 Apr 2006 16:07:11 +0000 (16:07 +0000)]
    - try to fix the Windows build

        * platform/cairo/GraphicsContextCairo.cpp: (WebCore::setColor):
        Update for changes to getRGBA.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCorrected run-iexploder-tests description in the ChangeLog.
ap [Tue, 18 Apr 2006 05:12:46 +0000 (05:12 +0000)]
Corrected run-iexploder-tests description in the ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13951 268f45cc-cd09-0410-ab3c-d52691b4dbfc