WebKit-https.git
7 years agoUnreviewed gardening.
jer.noble@apple.com [Wed, 18 Jul 2012 23:50:27 +0000 (23:50 +0000)]
Unreviewed gardening.

Correct a path error introduced by r122769 for the fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
test in many Skipped lists.

* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed TestExpectations update for WK90469.
jsbell@chromium.org [Wed, 18 Jul 2012 23:44:25 +0000 (23:44 +0000)]
[chromium] Unreviewed TestExpectations update for WK90469.
Restore a test that was skipped to test a theory.
https://bugs.webkit.org/show_bug.cgi?id=90469

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Add heap profiling tests to Skipped list
commit-queue@webkit.org [Wed, 18 Jul 2012 23:39:27 +0000 (23:39 +0000)]
[EFL][DRT] Add heap profiling tests to Skipped list
https://bugs.webkit.org/show_bug.cgi?id=91684

Unreviewed gardening.

JSC doesn't support heap profiling.

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-18

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove temporary flag override for es52_globals
arv@chromium.org [Wed, 18 Jul 2012 23:38:47 +0000 (23:38 +0000)]
[V8] Remove temporary flag override for es52_globals
https://bugs.webkit.org/show_bug.cgi?id=91681

Reviewed by Adam Barth.

V8 has now changed their default value for the es52_globals so we no longer needs this override.

No new tests. No change in functionality.

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initIsolate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agodumpCallFrame is broken in ToT
oliver@apple.com [Wed, 18 Jul 2012 23:26:06 +0000 (23:26 +0000)]
dumpCallFrame is broken in ToT
https://bugs.webkit.org/show_bug.cgi?id=91444

Reviewed by Gavin Barraclough.

Various changes have been made to the SF calling convention, but
dumpCallFrame has not been updated to reflect these changes.
That resulted in both bogus information, as well as numerous
assertions of sadness.

This patch makes dumpCallFrame actually work again and adds the
wonderful feature of telling you the name of the variable that a
register reflects, or what value it contains.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::nameForRegister):
    A really innefficient mechanism for finding the name of a local register.
    This should only ever be used by debug code so this should be okay.
* bytecode/CodeBlock.h:
(CodeBlock):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
    Debug builds no longer throw away a functions symbol table, this allows
    us to actually perform a register# to name mapping
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
    We weren't propogating the bytecode offset here leading to assertions
    in debug builds when dumping bytecode of DFG compiled code.
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
     Rework to actually be correct.
(JSC::getCallerInfo):
     Return the byteocde offset as well now, given we have to determine it
     anyway.
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::retrieveCallerFromVMCode):
* interpreter/Interpreter.h:
(Interpreter):
* jsc.cpp:
(GlobalObject::finishCreation):
(functionDumpCallFrame):
     Give debug builds of JSC a method for calling dumpCallFrame so we can
     inspect a callframe without requiring us to break in a debugger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add gl_tests to flakiness dashboard.
commit-queue@webkit.org [Wed, 18 Jul 2012 23:23:30 +0000 (23:23 +0000)]
[chromium] Add gl_tests to flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=91680

Patch by Dave Tu <dtu@chromium.org> on 2012-07-18
Reviewed by Dirk Pranke.

* TestResultServer/static-dashboards/builders.js:
(loadBuildersList):
* TestResultServer/static-dashboards/dashboard_base.js:
(currentBuilderGroupCategory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofix python unit tests failing under cygwin
dpranke@chromium.org [Wed, 18 Jul 2012 23:21:15 +0000 (23:21 +0000)]
fix python unit tests failing under cygwin
https://bugs.webkit.org/show_bug.cgi?id=91678

Reviewed by Adam Barth.

Fix a case where executive.kill_process was failing under cygwin
(apple win port) in an unexpected way.

* Scripts/webkitpy/common/system/executive.py:
(Executive.kill_process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r122660-r122663): mathml/presentation/mo.xhtml, mathml/presentation/row...
jer.noble@apple.com [Wed, 18 Jul 2012 22:58:39 +0000 (22:58 +0000)]
REGRESSION (r122660-r122663): mathml/presentation/mo.xhtml, mathml/presentation/row.xhtml failing on Mountain Lion Production Tests
https://bugs.webkit.org/show_bug.cgi?id=91677

Reviewed by Eric Seidel.

Rebaseline after r122663.

* platform/mac/mathml/presentation/mo-expected.txt:
* platform/mac/mathml/presentation/row-expected.txt:
* platform/mac/mathml/presentation/mo-expected.png:
* platform/mac/mathml/presentation/row-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Ubercomp: add id to SharedQuadState
commit-queue@webkit.org [Wed, 18 Jul 2012 22:57:02 +0000 (22:57 +0000)]
[chromium] Ubercomp: add id to SharedQuadState
https://bugs.webkit.org/show_bug.cgi?id=91670

Patch by Alexandre Elias <aelias@google.com> on 2012-07-18
Reviewed by Adrienne Walker.

This assigns an integer ID to SharedQuadState objects and a
corresponding ID to quads.  This ID is unique only within a
RenderPass and currently is just set to the index in the shared quad
state list.  This is redundant with the pointer and exists to
simplify serialization.

I found out that pointer rewriting within a pickler is blocked by
pointers to memory being const there, so the reassignment will have to
be performed in the application layer anyway.  In that case, it's
simplest to add some ID integers.

Source/Platform:

* chromium/public/WebCompositorQuad.h:
(WebKit::WebCompositorQuad::sharedQuadStateId):
(WebCompositorQuad):
* chromium/public/WebCompositorSharedQuadState.h:
(WebCompositorSharedQuadState):

Source/WebCore:

No new tests (will introduce them when making use of the ID).

* platform/chromium/support/WebCompositorQuad.cpp:
(WebKit::WebCompositorQuad::WebCompositorQuad):
(WebKit::WebCompositorQuad::setSharedQuadState):
(WebKit):
* platform/chromium/support/WebCompositorSharedQuadState.cpp:
(WebKit::WebCompositorSharedQuadState::WebCompositorSharedQuadState):
(WebKit::WebCompositorSharedQuadState::create):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::createSharedQuadState):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForLayer):
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
(WebCore::CCRenderPass::appendQuadsToFillScreen):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCQuadCullerTest.cpp:
* tests/CCRenderSurfaceTest.cpp:
* tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
* tests/CCTiledLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Not reviewed. Build fix.
hclam@chromium.org [Wed, 18 Jul 2012 22:41:58 +0000 (22:41 +0000)]
[chromium] Not reviewed. Build fix.

Add CR before bug number to avoid lint error.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [chromium] Ubercomp: clean up CCRenderer interface
commit-queue@webkit.org [Wed, 18 Jul 2012 22:41:02 +0000 (22:41 +0000)]
Source/WebCore: [chromium] Ubercomp: clean up CCRenderer interface
https://bugs.webkit.org/show_bug.cgi?id=91555

Patch by Alexandre Elias <aelias@google.com> on 2012-07-18
Reviewed by Adrienne Walker.

I replaced the one-by-one RenderPass calls with a new drawFrame()
method that directly takes a CCRenderPassList, and moved a small
amount of code from CCLayerTreeHostImpl to implement it.  In ubercomp
mode, we will produce a frame bundle rather than a command-stream, so
the full list is easier to work with.

Also, give empty default implementations for the methods that don't
need to do anything in a non-GL context, and make private
setScissorToRect.

No new tests (no-op refactoring).

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawFrame):
(WebCore):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::drawLayers):
* platform/graphics/chromium/cc/CCRenderer.h:
(WebCore::CCRenderer::viewportChanged):
(WebCore::CCRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCRenderer::haveCachedResourcesForRenderPassId):
(CCRenderer):
(WebCore::CCRenderer::finishDrawingFrame):
(WebCore::CCRenderer::doNoOp):
(WebCore::CCRenderer::isContextLost):

Source/WebKit/chromium: Add WebTextInputType enum values for text areas and
content-editable.
https://bugs.webkit.org/show_bug.cgi?id=91654

Patch by Nate Chapin <japhet@chromium.org> on 2012-07-18
Reviewed by Adam Barth.

No new tests, no behavior change without corresponding chromium.org changes.

* public/WebTextInputType.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agotest-webkitpy: run tests in parallel by default
dpranke@chromium.org [Wed, 18 Jul 2012 22:39:24 +0000 (22:39 +0000)]
test-webkitpy: run tests in parallel by default
https://bugs.webkit.org/show_bug.cgi?id=91422

Reviewed by Adam Barth.

We use multiprocessing.cpu_count() for the default number of
jobs to run; memory overhead should be very low, so this should
be fine.

* Scripts/webkitpy/test/main.py:
(Tester._parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother Chromium Windows build fix attempt after r123014.
rniwa@webkit.org [Wed, 18 Jul 2012 22:36:22 +0000 (22:36 +0000)]
Another Chromium Windows build fix attempt after r123014.

* chromium/public/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Ubercomp: clean up CCRenderer interface
commit-queue@webkit.org [Wed, 18 Jul 2012 22:33:06 +0000 (22:33 +0000)]
[chromium] Ubercomp: clean up CCRenderer interface
https://bugs.webkit.org/show_bug.cgi?id=91555

Patch by Alexandre Elias <aelias@google.com> on 2012-07-18
Reviewed by Adrienne Walker.

I replaced the one-by-one RenderPass calls with a new drawFrame()
method that directly takes a CCRenderPassList, and moved a small
amount of code from CCLayerTreeHostImpl to implement it.  In ubercomp
mode, we will produce a frame bundle rather than a command-stream, so
the full list is easier to work with.

Also, give empty default implementations for the methods that don't
need to do anything in a non-GL context, and make private
setScissorToRect.

Source/WebCore:

No new tests (no-op refactoring).

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawFrame):
(WebCore):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::drawLayers):
* platform/graphics/chromium/cc/CCRenderer.h:
(WebCore::CCRenderer::viewportChanged):
(WebCore::CCRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCRenderer::haveCachedResourcesForRenderPassId):
(CCRenderer):
(WebCore::CCRenderer::finishDrawingFrame):
(WebCore::CCRenderer::doNoOp):
(WebCore::CCRenderer::isContextLost):

Source/WebKit/chromium:

* tests/LayerRendererChromiumTest.cpp:
(FakeCCRendererClient::FakeCCRendererClient):
(FakeCCRendererClient::renderPasses):
(FakeCCRendererClient):
(TEST_F):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Implement currentTime() and monotonicallyIncreasingTime() for OS(QNX)
commit-queue@webkit.org [Wed, 18 Jul 2012 22:28:24 +0000 (22:28 +0000)]
[BlackBerry] Implement currentTime() and monotonicallyIncreasingTime() for OS(QNX)
https://bugs.webkit.org/show_bug.cgi?id=91659

Patch by Yong Li <yoli@rim.com> on 2012-07-18
Reviewed by Rob Buis.

Implement currentTime() and monotonicallyIncreasingTime() for OS(QNX) with clock_gettime().

* wtf/CurrentTime.cpp:
(WTF):
(WTF::currentTime):
(WTF::monotonicallyIncreasingTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoContent size of child having percent height inside a fixed height container having...
commit-queue@webkit.org [Wed, 18 Jul 2012 22:28:21 +0000 (22:28 +0000)]
Content size of child having percent height inside a fixed height container having overflow:auto is wrongly calculated
https://bugs.webkit.org/show_bug.cgi?id=11355

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-18
Reviewed by Julien Chaffraix.

Source/WebCore:

The content height of a child must be container height minus padding, border width and height of horizontal scrollbar(if any).

Tests: fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto.html
       fast/overflow/replaced-child-100percent-height-inside-fixed-container-with-overflow-auto.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
Subtracting the height of the scrollbar from the client height when the client has percentage height.

LayoutTests:

* fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto-expected.txt: Added.
* fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto.html: Added.
* fast/overflow/replaced-child-100percent-height-inside-fixed-container-with-overflow-auto-expected.txt: Added.
* fast/overflow/replaced-child-100percent-height-inside-fixed-container-with-overflow-auto.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd Pravin D to the list of contributors.
rniwa@webkit.org [Wed, 18 Jul 2012 22:22:58 +0000 (22:22 +0000)]
Add Pravin D to the list of contributors.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Ensure that the compositor code which is aware of flipped status of video...
commit-queue@webkit.org [Wed, 18 Jul 2012 22:20:04 +0000 (22:20 +0000)]
[chromium] Ensure that the compositor code which is aware of flipped status of video-textures
per platform sets the flipped bit to false on Windows.
https://bugs.webkit.org/show_bug.cgi?id=91562

Patch by Anantanarayanan G Iyengar <ananta@chromium.org> on 2012-07-18
Reviewed by Adrienne Walker.

No new tests. (HW video decode is still only being tested manually for orientation)

* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG 32-bit PutById transition stub storage reallocation case copies the first pointer...
fpizlo@apple.com [Wed, 18 Jul 2012 22:17:18 +0000 (22:17 +0000)]
DFG 32-bit PutById transition stub storage reallocation case copies the first pointer of each JSValue instead of the whole JSValue
https://bugs.webkit.org/show_bug.cgi?id=91599

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

* dfg/DFGRepatch.cpp:
(JSC::DFG::emitPutTransitionStub):

LayoutTests:

Rubber stamped by Mark Hahnenberg.

It turns out we previously didn't have adequate coverage for this. Now we do.

* fast/js/dfg-put-by-id-allocate-storage-expected.txt: Added.
* fast/js/dfg-put-by-id-allocate-storage-polymorphic-expected.txt: Added.
* fast/js/dfg-put-by-id-allocate-storage-polymorphic.html: Added.
* fast/js/dfg-put-by-id-allocate-storage.html: Added.
* fast/js/dfg-put-by-id-reallocate-storage-expected.txt: Added.
* fast/js/dfg-put-by-id-reallocate-storage-polymorphic-expected.txt: Added.
* fast/js/dfg-put-by-id-reallocate-storage-polymorphic.html: Added.
* fast/js/dfg-put-by-id-reallocate-storage.html: Added.
* fast/js/script-tests/dfg-put-by-id-allocate-storage-polymorphic.js: Added.
(foo):
* fast/js/script-tests/dfg-put-by-id-allocate-storage.js: Added.
(foo):
* fast/js/script-tests/dfg-put-by-id-reallocate-storage-polymorphic.js: Added.
(foo):
* fast/js/script-tests/dfg-put-by-id-reallocate-storage.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOOB read of stack buffer below DoubleToStringConverter::CreateExponentialRepresentati...
tsepez@chromium.org [Wed, 18 Jul 2012 22:16:08 +0000 (22:16 +0000)]
OOB read of stack buffer below DoubleToStringConverter::CreateExponentialRepresentation() in debug builds
https://bugs.webkit.org/show_bug.cgi?id=91642

Reviewed by Abhishek Arya.

* wtf/dtoa/double-conversion.cc:
(DoubleToStringConverter::CreateExponentialRepresentation): NUL-terminate string buffer before passing it to StringBuilder::AddSubstring()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening.
hclam@chromium.org [Wed, 18 Jul 2012 22:14:34 +0000 (22:14 +0000)]
[chromium] Unreviewed gardening.

Updated test expectation for compositing/masks/layer-mask-placement.html.
Updated bug number for fast/js/mozilla/strict/assign-to-callee-name.html after filing webkit bug 91676.

Updated bug number for fast/url/ipv6.html after filing crbug.com/137938.

* platform/chromium-mac-snowleopard/compositing/masks/layer-mask-placement-expected.png: Removed.
* platform/chromium-mac/compositing/masks/layer-mask-placement-expected.png: Added.
* platform/chromium-win/compositing/masks/layer-mask-placement-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace uses of RenderBox::x(), y() in rendering code with with point and size methods
eae@chromium.org [Wed, 18 Jul 2012 22:06:34 +0000 (22:06 +0000)]
Replace uses of RenderBox::x(), y() in rendering code with with point and size methods
https://bugs.webkit.org/show_bug.cgi?id=91549

Reviewed by Eric Seidel.

Replaces uses of RenderBox::x() and RenderBox::y() with
RenderBox::location(), RenderBox::locationOffset() and
RenderBox::frameRect().

No new tests, no change in functionality.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::positionNewFloats):
Use child->frameRect() and child->location() instead of constructing a
rect and size from the x, y, width and height values.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::repaintDuringLayoutIfMoved):
Compare and copy m_frameRect directly instead of comparing and copying
the individual values.

(WebCore::RenderBox::localCaretRect):
Use location() instead of x() and y().

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
Use pixelSnappedIntSize and RenderBox::size() instead of computing and
snapping the width and height separately.

* rendering/RenderImage.cpp:
(WebCore::RenderImage::nodeAtPoint):
USe locationOffset() instead of creating a new LayoutSize object from the
x() and y() values.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::updateHitTestResult):
Move by Size instead of x and y value.

(WebCore::RenderInline::addFocusRingRects):
Move by Size instead of x and y value.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::offsetFromContainer):
Shrink offset by size instead of using x and y values.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::setLogicalPositionForCell):
Use child->frameRect() and child->location() instead of constructing a
rect and size from the x, y, width and height values.

* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeRenderSVGTextBox):
Use location() instead of x() and y().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test expectations update. Added bug ID for fast/filesystem/file-writer...
kbr@google.com [Wed, 18 Jul 2012 21:58:00 +0000 (21:58 +0000)]
Unreviewed test expectations update. Added bug ID for fast/filesystem/file-writer-truncate-extend.html flakiness.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed, try to fix the chromium-win build after r123014.
tony@chromium.org [Wed, 18 Jul 2012 21:51:45 +0000 (21:51 +0000)]
[chromium] Unreviewed, try to fix the chromium-win build after r123014.

* platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening.
tony@chromium.org [Wed, 18 Jul 2012 21:38:55 +0000 (21:38 +0000)]
[chromium] Unreviewed gardening.

svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg flakily crashes on Chromium Win.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] feature detection in orwt/nrwt does not work with force_static_libs_as_shared
kbalazs@webkit.org [Wed, 18 Jul 2012 21:36:29 +0000 (21:36 +0000)]
[Qt] feature detection in orwt/nrwt does not work with force_static_libs_as_shared
https://bugs.webkit.org/show_bug.cgi?id=91514

Reviewed by Dirk Pranke.

Analyzing libQtWebKit.so is not enough in the case of force_static_libs_as_shared.
We need to analyze all the shared library or at least the WebCore one.

* Scripts/webkitdirs.pm:
(builtDylibPathForName):
In orwt it is hard coded to search for symbols in the WebCore library.
While in theory it is possible that symbols for a given feature are not
located in that, it doesn't happen in practice, so returning the path of
the WebCore library for a force_static_libs_as_shared build is enough to
fix the bug and it doesn't require a bigger refactoring. For a default
build we still return the path of the QtWebKit lib.
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._modules_to_search_for_symbols):
Enumerate all dynamic libraries, not just the QtWebKit one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Fix some coding style violations
jsbell@chromium.org [Wed, 18 Jul 2012 21:33:29 +0000 (21:33 +0000)]
IndexedDB: Fix some coding style violations
https://bugs.webkit.org/show_bug.cgi?id=91565

Reviewed by Tony Chang.

Source/WebCore:

In declarations, put the * next to the type not the identifier.
Remove k as a prefix for various constants.

No new tests - no functional changes.

* Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::prefetchContinueInternal):
* Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::computeFileIdentifier):
* Modules/indexeddb/IDBKey.h:
(WebCore::IDBKey::IDBKey):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::getDatabaseNames):
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::getNewObjectStoreId):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::getNewVersionNumber):
(WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
(WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::getNewIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore):
* Modules/indexeddb/IDBLevelDBCoding.cpp:
(IDBLevelDBCoding):
(WebCore::IDBLevelDBCoding::maxIDBKey):
(WebCore::IDBLevelDBCoding::minIDBKey):
(WebCore::IDBLevelDBCoding::decodeVarInt):
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::decodeIDBKey):
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
(WebCore::IDBLevelDBCoding::keyTypeByteToKeyType):
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
(WebCore::IDBLevelDBCoding::encodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::decodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::compare):
(WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
(WebCore::IDBLevelDBCoding::KeyPrefix::encode):
(WebCore::IDBLevelDBCoding::KeyPrefix::compare):
(WebCore::IDBLevelDBCoding::KeyPrefix::type):
(WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
(WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
(WebCore::IDBLevelDBCoding::IndexDataKey::decode):
* Modules/indexeddb/IDBLevelDBCoding.h:
(IDBLevelDBCoding):
(ObjectStoreDataKey):
(ExistsEntryKey):

Source/WebKit/chromium:

* tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EFL should use DownloadSoup instead of defining DownloadEfl
commit-queue@webkit.org [Wed, 18 Jul 2012 21:31:34 +0000 (21:31 +0000)]
[EFL][WK2] EFL should use DownloadSoup instead of defining DownloadEfl
https://bugs.webkit.org/show_bug.cgi?id=91602

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

Reuse WebProcess/Downloads/soup/DownloadSoup.cpp in EFL port
instead of redefining our own DownloadEfl.cpp. The EFL port
is also using libsoup so it is best to avoid code duplication.

* GNUmakefile.am:
* GNUmakefile.list.am:
* PlatformEfl.cmake:
* WebProcess/Downloads/Download.h:
(WebKit):
(Download):
* WebProcess/Downloads/efl/DownloadEfl.cpp: Removed.
* WebProcess/Downloads/efl/DownloadSoupErrorsEfl.cpp: Added.
(WebKit):
(WebKit::platformDownloadNetworkError):
(WebKit::platformDownloadDestinationError):
* WebProcess/Downloads/efl/FileDownloaderEfl.cpp: Removed.
* WebProcess/Downloads/efl/FileDownloaderEfl.h: Removed.
* WebProcess/Downloads/gtk/DownloadSoupErrorsGtk.cpp: Added.
(WebKit):
(WebKit::platformDownloadNetworkError):
(WebKit::platformDownloadDestinationError):
* WebProcess/Downloads/soup/DownloadSoup.cpp: Make the code
compile for other ports than GTK.
(WebKit::DownloadClient::didReceiveResponse):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::didFail):
(WebKit::Download::continueWithoutCredential):
(WebKit):
(WebKit::Download::useCredential):
(WebKit::Download::cancelAuthenticationChallenge):
* WebProcess/Downloads/soup/DownloadSoupErrors.h: Added.
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
tony@chromium.org [Wed, 18 Jul 2012 21:28:05 +0000 (21:28 +0000)]
Unreviewed gardening.
http/tests/loading/307-after-303-after-post.html is flaky on win debug too.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed, fix some MSVC compile warnings.
tony@chromium.org [Wed, 18 Jul 2012 21:26:36 +0000 (21:26 +0000)]
[chromium] Unreviewed, fix some MSVC compile warnings.

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Add C API for Network Information API
commit-queue@webkit.org [Wed, 18 Jul 2012 21:22:00 +0000 (21:22 +0000)]
[WK2] Add C API for Network Information API
https://bugs.webkit.org/show_bug.cgi?id=90762

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

Add C API for WKNetworkInfo and WKNetworkInfoManager
so that they can be used by the client.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* UIProcess/API/C/WKContext.cpp:
(WKContextGetNetworkInfoManager):
* UIProcess/API/C/WKContext.h:
* UIProcess/API/C/WKNetworkInfo.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKNetworkInfoManager.cpp.
(WKNetworkInfoGetTypeID):
(WKNetworkInfoCreate):
* UIProcess/API/C/WKNetworkInfo.h: Copied from Source/WebKit2/UIProcess/API/C/WKNetworkInfoManager.cpp.
* UIProcess/API/C/WKNetworkInfoManager.cpp:
(WKNetworkInfoManagerSetProvider):
(WKNetworkInfoManagerProviderDidChangeNetworkInformation):
* UIProcess/API/C/WKNetworkInfoManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate Chromium test expectations after filing the bug 91666.
rniwa@webkit.org [Wed, 18 Jul 2012 21:13:03 +0000 (21:13 +0000)]
Update Chromium test expectations after filing the bug 91666.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Call SQLiteFileSystem-related functions directly
pilgrim@chromium.org [Wed, 18 Jul 2012 20:51:30 +0000 (20:51 +0000)]
[Chromium] Call SQLiteFileSystem-related functions directly
https://bugs.webkit.org/show_bug.cgi?id=91631

Reviewed by Adam Barth.

Source/Platform:

Part of a refactoring series. See tracking bug 82948.

* chromium/public/Platform.h:
(Platform):
(WebKit::Platform::databaseOpenFile):
(WebKit::Platform::databaseDeleteFile):
(WebKit::Platform::databaseGetFileAttributes):
(WebKit::Platform::databaseGetFileSize):
(WebKit::Platform::databaseGetSpaceAvailableForOrigin):

Source/WebCore:

Part of a refactoring series. See tracking bug 82948.

* Modules/webdatabase/chromium/QuotaTracker.cpp:
(WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/sql/chromium/SQLiteFileSystemChromium.cpp:
(WebCore::SQLiteFileSystem::deleteDatabaseFile):
(WebCore::SQLiteFileSystem::getDatabaseFileSize):
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
* platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:

Source/WebKit/chromium:

Part of a refactoring series. See tracking bug 82948.

* public/platform/WebKitPlatformSupport.h:
(WebKitPlatformSupport):
* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKit provides APIs that make it possible for JSC to attempt to initialise the heap...
oliver@apple.com [Wed, 18 Jul 2012 20:43:40 +0000 (20:43 +0000)]
WebKit provides APIs that make it possible for JSC to attempt to initialise the heap without initialising threading
https://bugs.webkit.org/show_bug.cgi?id=91663

Reviewed by Filip Pizlo.

Initialising a JSGlobalData now requires us to have initialised JSC's threading
logic, as that also initialises the JSC VM runtime options.  WebKit provides a
number of routines that make use of commonJSGlobalData() that can be used before
webcore has called the appropriate initialisation routine.  This patch makes the
minimal change of ensuring that commonJSGlobalData initialises threading before
attempting to create the common heap.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening.
hclam@chromium.org [Wed, 18 Jul 2012 20:40:30 +0000 (20:40 +0000)]
[chromium] Unreviewed gardening.

Remove some test expectations with my name on it, they are currently passing.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake TextCodecUTF8 handle 8 bit data without converting to UChar's
msaboff@apple.com [Wed, 18 Jul 2012 20:28:39 +0000 (20:28 +0000)]
Make TextCodecUTF8 handle 8 bit data without converting to UChar's
https://bugs.webkit.org/show_bug.cgi?id=90320

Reviewed by Oliver Hunt.

Change UTF8 Codec to produce 8-bit strings when data fits in 8-bit range.
First we try decoding the string as all 8-bit and then fall back to 16 bit
when we find the first character that doesn't fit in 8 bits.  Then we take
the already decoded data and copy / convert it to a 16-bit buffer and then
continue process the rest of the stream as 16-bits.

No new tests, no change in functionality.

* platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::handleError):
(WebCore::TextCodecUTF8::decode):
* platform/text/TextCodecUTF8.h:
(TextCodecUTF8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] ewk_cookie_manager_persistent_storage_set is not exported
commit-queue@webkit.org [Wed, 18 Jul 2012 20:27:23 +0000 (20:27 +0000)]
[EFL][WK2] ewk_cookie_manager_persistent_storage_set is not exported
https://bugs.webkit.org/show_bug.cgi?id=91647

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-18
Reviewed by Gustavo Noronha Silva.

Properly export ewk_cookie_manager_persistent_storage_set in
ewk_cookie_manager.h by using EAPI.

* UIProcess/API/efl/ewk_cookie_manager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium Mac: Add TEXTURE_RECTANGLE_ARB support to CCVideoLayerImpl
commit-queue@webkit.org [Wed, 18 Jul 2012 20:25:11 +0000 (20:25 +0000)]
Chromium Mac: Add TEXTURE_RECTANGLE_ARB support to CCVideoLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=91169

Patch by Sailesh Agrawal <sail@chromium.org> on 2012-07-18
Reviewed by Adrienne Walker.

Source/Platform:

Added a "orientation" field to WebCompositorIOSurfaceQuad. This is used at draw time to flip the texture if necessary.

* chromium/public/WebCompositorIOSurfaceQuad.h: Added orientation field to the constructor.
(WebKit::WebCompositorIOSurfaceQuad::orientation):
(WebCompositorIOSurfaceQuad): The new orientation field should be set to Flipped if the texture should be flipped when drawing.

Source/WebCore:

This extends CCVideoLayerImpl to support TEXTURE_RECTANGLE_ARB. This texture target is used by the Mac hardware accelerated video decoder.

No new tests (HW video decode on Mac is being tested manually.).

* platform/chromium/support/WebCompositorIOSurfaceQuad.cpp:
(WebKit::WebCompositorIOSurfaceQuad::create): Added an orientation argument.
(WebKit::WebCompositorIOSurfaceQuad::WebCompositorIOSurfaceQuad): Added an orientation argument.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawIOSurfaceQuad): Added support for non-flipped IOSurface textures.
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium): Changed TextureIOSurfaceProgram to be non-flipped. To draw flipped textures drawIOSurfaceQuad sets a different value for texTransformLocation.
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
(WebCore::CCIOSurfaceLayerImpl::appendQuads): Updated call to CCIOSurfaceDrawQuad constructor.
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads): Added support for drawing TEXTURE_RECTANGLE_ARB textures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake TextCodecLatin1 handle 8 bit data without converting to UChar's
msaboff@apple.com [Wed, 18 Jul 2012 20:22:43 +0000 (20:22 +0000)]
Make TextCodecLatin1 handle 8 bit data without converting to UChar's
https://bugs.webkit.org/show_bug.cgi?id=90319

Reviewed by Oliver Hunt.

Source/WebCore:

Updated codec to create 8 bit strings where possible.
We assume that the incoming stream can all be decoded as 8-bit values.
If we find a 16-bit value, we take the already decoded data and
copy / convert it to a 16-bit buffer and then continue process the rest
of the stream as 16-bits.

No new tests, functionality covered with existing tests.

* platform/text/TextCodecASCIIFastPath.h:
(WebCore::copyASCIIMachineWord):
* platform/text/TextCodecLatin1.cpp:
(WebCore::TextCodecLatin1::decode):

Source/WTF:

* wtf/text/StringImpl.h:
(StringImpl): Exported LChar variant of adopt().
* wtf/text/WTFString.h:
(WTF::String::createUninitialized): Exported LChar variant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed, more compile fixes on Chromium Win.
tony@chromium.org [Wed, 18 Jul 2012 20:21:34 +0000 (20:21 +0000)]
[chromium] Unreviewed, more compile fixes on Chromium Win.

Source/WebKit/chromium:

* tests/WebTransformationMatrixTest.cpp:
(WebKit::TEST):

Tools:

* DumpRenderTree/chromium/TestShellWin.cpp:
(TestShell::waitTestFinished):
* DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix up old name in RuleSet::addRulesFromSheet
dglazkov@chromium.org [Wed, 18 Jul 2012 20:09:57 +0000 (20:09 +0000)]
Fix up old name in RuleSet::addRulesFromSheet
https://bugs.webkit.org/show_bug.cgi?id=91646

Reviewed by Andreas Kling.

Simple parameter rename, no change in functionality.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Renamed styleSelector to resolver to reflect recent rename of the parameter type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnify allowfullscreen logic in Document::webkitFullScreenEnabled and fullScreenIsAllo...
scheib@chromium.org [Wed, 18 Jul 2012 20:06:12 +0000 (20:06 +0000)]
Unify allowfullscreen logic in Document::webkitFullScreenEnabled and fullScreenIsAllowedForElement.
https://bugs.webkit.org/show_bug.cgi?id=91448

Reviewed by Adrienne Walker.

Unifies redundant traversal logic and static cast previously used
to determine if an element or document can be made fullscreen.
This clean up prepares for pointer lock, which will use the same logic.

Added a test to detect an edge case of an owning document with
fullscreen permision moving an iframe to fullscreen, while that iframe
does not have permision for its contents to be made fullscreen.

Source/WebCore:

Test: fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html

* dom/Document.cpp:
(WebCore::isAttributeOnAllOwners):
(WebCore::Document::fullScreenIsAllowedForElement):
(WebCore::Document::webkitFullscreenEnabled):

LayoutTests:

* fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent-expected.txt: Added.
* fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add central error management to EFL port
commit-queue@webkit.org [Wed, 18 Jul 2012 20:01:46 +0000 (20:01 +0000)]
[EFL] Add central error management to EFL port
https://bugs.webkit.org/show_bug.cgi?id=91598

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Define possible error types in ErrorsEfl so
that we can reuse the header in both WebKit1
and WebKit2. This is inspired from the GTK
port.

No new tests, no behavior change.

* PlatformEfl.cmake:
* platform/efl/ErrorsEfl.cpp: Added.
(WebCore):
(WebCore::cancelledError):
(WebCore::blockedError):
(WebCore::cannotShowURLError):
(WebCore::interruptedForPolicyChangeError):
(WebCore::cannotShowMIMETypeError):
(WebCore::fileDoesNotExistError):
(WebCore::pluginWillHandleLoadError):
(WebCore::downloadNetworkError):
(WebCore::downloadCancelledByUserError):
(WebCore::downloadDestinationError):
(WebCore::printError):
(WebCore::printerNotFoundError):
(WebCore::invalidPageRangeToPrint):
* platform/efl/ErrorsEfl.h: Added.
(WebCore):

Source/WebKit/efl:

Make use of ErrorsEfl header from WebCore in
EFL's FrameLoaderClient now that we have
a central place for errors.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::cancelledError):
(WebCore::FrameLoaderClientEfl::blockedError):
(WebCore::FrameLoaderClientEfl::cannotShowURLError):
(WebCore::FrameLoaderClientEfl::interruptedForPolicyChangeError):
(WebCore::FrameLoaderClientEfl::cannotShowMIMETypeError):
(WebCore::FrameLoaderClientEfl::fileDoesNotExistError):
(WebCore::FrameLoaderClientEfl::pluginWillHandleLoadError):
(WebCore::FrameLoaderClientEfl::shouldFallBack):

Source/WebKit2:

Make use of ErrorsEfl header from WebCore in
WebKit2, for Ewk_Web_Error and WebErrorsEfl.

* UIProcess/API/efl/ewk_web_error.cpp:
(ewk_web_error_type_get):
* UIProcess/API/efl/ewk_web_error.h:
* WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:
(WebKit::cancelledError):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptedForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
(WebKit::fileDoesNotExistError):
(WebKit::pluginWillHandleLoadError):

Tools:

Map WebKitNetworkError to NSURLErrorDomain when
printing in DumpRenderTree so that the output
matches the expected one.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(descriptionSuitableForTestResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix compile on Windows.
tony@chromium.org [Wed, 18 Jul 2012 19:59:24 +0000 (19:59 +0000)]
[chromium] Fix compile on Windows.

148>tests\LayerChromiumTest.cpp(510): warning C4305: 'argument' : truncation from 'double' to 'float'

* tests/LayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: start merging port/webkit.py into port/base.py
dpranke@chromium.org [Wed, 18 Jul 2012 19:59:02 +0000 (19:59 +0000)]
nrwt: start merging port/webkit.py into port/base.py
https://bugs.webkit.org/show_bug.cgi?id=91559

Reviewed by Ojan Vafai.

Since all the non-test port implementations now derive from
WebKitPort, there's no real point in keeping WebKitPort distinct
from Port. This patch starts merging the two by moving nearly
all of the webkit implementations of routines with no default
behavior into base.py. The few that didn't move rely on
additional infrastructure that should be refactored differently
(like the image diffing, which should probably be its own
class) and deserve their own patches.

This patch should just be moving code around, and require no
additional tests; in fact, we can delete the tests that were
asserting virtual methods in the base class.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.baseline_search_path):
(Port.check_build):
(Port):
(Port._check_driver):
(Port._check_port_build):
(Port.check_image_diff):
(Port.driver_name):
(Port.default_results_directory):
(Port.to.setup_environ_for_server):
(Port._path_to_apache):
(Port._is_redhat_based):
(Port._is_debian_based):
(Port._apache_config_file_name_for_platform):
(Port._path_to_apache_config_file):
(Port._build_path):
(Port._path_to_driver):
(Port._path_to_webcore_library):
(Port._path_to_helper):
(Port._path_to_image_diff):
(Port._path_to_wdiff):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_httpd_returns_error_code):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort):
(WebKitPort._build_driver_flags):
(WebKitPort._read_image_diff):
(WebKitPort.skipped_layout_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix crash in DragImageTest caused by r122996
tony@chromium.org [Wed, 18 Jul 2012 19:51:12 +0000 (19:51 +0000)]
[chromium] Fix crash in DragImageTest caused by r122996
https://bugs.webkit.org/show_bug.cgi?id=91653

Patch by Varun Jain <varunjain@chromium.org> on 2012-07-18
Reviewed by Tony Chang.

Covered by existing DragImageTest.

* platform/chromium/DragImageChromiumSkia.cpp:
(WebCore::deleteDragImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Set a theme for EFL WebKit2 unit test fixture
commit-queue@webkit.org [Wed, 18 Jul 2012 19:31:24 +0000 (19:31 +0000)]
[EFL] Set a theme for EFL WebKit2 unit test fixture
https://bugs.webkit.org/show_bug.cgi?id=91618

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

The test fixture should load the theme generated by the build
instead of trying to load the system theme.

* PlatformEfl.cmake:
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:
(EWK2UnitTest::EWK2UnitTestEnvironment::defaultTheme):
(EWK2UnitTest):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
(EWK2UnitTestEnvironment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement putIndexKeys in WebIDBObjectStoreImpl
commit-queue@webkit.org [Wed, 18 Jul 2012 19:26:56 +0000 (19:26 +0000)]
Implement putIndexKeys in WebIDBObjectStoreImpl
https://bugs.webkit.org/show_bug.cgi?id=91546

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-18
Reviewed by Darin Fisher.

Implement putIndexKeys in the chromium API, so it is callable
from chromium.

* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::putWithIndexKeys):
(WebKit):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed compile fix for Android.
tony@chromium.org [Wed, 18 Jul 2012 19:23:19 +0000 (19:23 +0000)]
[chromium] Unreviewed compile fix for Android.

More sqrt fixes.

* tests/CCLayerTreeHostCommonTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed compile fix for Android.
tony@chromium.org [Wed, 18 Jul 2012 18:55:32 +0000 (18:55 +0000)]
[chromium] Unreviewed compile fix for Android.

Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp: In member function 'virtual void<unnamed>::CCDamageTrackerTest_verifyDamageForTransformedLayer_Test::TestBody()':
Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp:332: error: call of overloaded 'sqrt(int)' is ambiguous

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Drag image for image elements should be scaled with device scale factor.
commit-queue@webkit.org [Wed, 18 Jul 2012 18:43:13 +0000 (18:43 +0000)]
[chromium] Drag image for image elements should be scaled with device scale factor.
https://bugs.webkit.org/show_bug.cgi?id=89688

Patch by Varun Jain <varunjain@chromium.org> on 2012-07-18
Reviewed by Adam Barth.

.:

* ManualTests/chromium/drag-image-accounts-for-device-scale.html:

Source/WebCore:

Modified ManualTest: ManualTests/chromium/drag-image-accounts-for-device-scale.html

* page/Frame.cpp:
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
* platform/chromium/DragImageChromiumSkia.cpp:
(WebCore::dragImageSize):
(WebCore::deleteDragImage):
(WebCore::scaleDragImage):
(WebCore::dissolveDragImageToFraction):
(WebCore::createDragImageFromImage):
* platform/chromium/DragImageRef.h:
(DragImageChromium):
(WebCore):
* platform/graphics/skia/BitmapImageSingleFrameSkia.h:
(BitmapImageSingleFrameSkia):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImageSingleFrameSkia::BitmapImageSingleFrameSkia):
(WebCore::BitmapImageSingleFrameSkia::create):
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::NativeImageSkia):
* platform/graphics/skia/NativeImageSkia.h:
(NativeImageSkia):
(WebCore::NativeImageSkia::resolutionScale):

Source/WebKit/chromium:

* src/DragClientImpl.cpp:
(WebKit::DragClientImpl::startDrag):
* tests/DragImageTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] MediaStream API: Moving the mock create* WebRTC calls into a shadow Platfo...
tommyw@google.com [Wed, 18 Jul 2012 18:34:16 +0000 (18:34 +0000)]
[chromium] MediaStream API: Moving the mock create* WebRTC calls into a shadow Platform class
https://bugs.webkit.org/show_bug.cgi?id=86215

Reviewed by Adam Barth.

Adding a shadow Platform object that is used to override some WebKit::Platform funtions to
instead create mock objects. No actual mock objects created yet.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
* DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Copied from Tools/DumpRenderTree/chromium/config.h.
(MockWebKitPlatformSupport::create):
(MockWebKitPlatformSupport::MockWebKitPlatformSupport):
(MockWebKitPlatformSupport::cryptographicallyRandomValues):
(MockWebKitPlatformSupport::createMediaStreamCenter):
* DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Copied from Tools/DumpRenderTree/chromium/config.h.
(MockWebKitPlatformSupport):
* DumpRenderTree/chromium/config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening. Rebaseline 2 tests due to minor changes from r122980.
tony@chromium.org [Wed, 18 Jul 2012 18:32:24 +0000 (18:32 +0000)]
[chromium] Unreviewed gardening. Rebaseline 2 tests due to minor changes from r122980.

* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix style for numeric literals in chromium unit test code
shawnsingh@chromium.org [Wed, 18 Jul 2012 18:25:54 +0000 (18:25 +0000)]
[chromium] Fix style for numeric literals in chromium unit test code
https://bugs.webkit.org/show_bug.cgi?id=91635

Reviewed by Adrienne Walker.

Where possible, removed ".0" and "f" suffixes on numeric literals,
to be more consistent with WebKit style rules.

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
* tests/CCLayerQuadTest.cpp:
(WebCore::TEST):
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCQuadCullerTest.cpp:
* tests/LayerChromiumTest.cpp:
* tests/WebTransformationMatrixTest.cpp:
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Move about: URL handling out of WebCore
commit-queue@webkit.org [Wed, 18 Jul 2012 18:25:07 +0000 (18:25 +0000)]
[BlackBerry] Move about: URL handling out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=91541

Patch by Yong Li <yoli@rim.com> on 2012-07-18
Reviewed by Rob Buis.

Source/WebCore:

Remove about URL handling from our NetworkJob.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::cancelJob):
(WebCore::NetworkJob::sendResponseIfNeeded):
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):
* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):

Source/WebKit:

AboutData.cpp is moved from WebCoreSupport to WebKitSupport.

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Move about URL handling code to WebKit/blackberry. Now when WebPage is asked to load an about URL,
it directly calls loadString() with the generated source.

Also move AboutData.h/cpp from WebCoreSupport to WebKitSupport and change their namespace from WebCore
to BlackBerry::WebKit.

The change is very mechanical except "procss total memory usage" in about:memory now only accounts used
bytes and ignore free spaces in malloc.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::loadAbout):
(WebKit):
(BlackBerry::WebKit::WebPage::load):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/AboutData.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp.
(WebKit):
(BlackBerry::WebKit::writeFeatures):
(BlackBerry::WebKit::numberToHTMLTr):
(BlackBerry::WebKit::bool):
(BlackBerry::WebKit::configPage):
(BlackBerry::WebKit::cacheTypeStatisticToHTMLTr):
(BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
(BlackBerry::WebKit::memoryPage):
* WebKitSupport/AboutData.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/AboutData.h.
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r122984.
tony@chromium.org [Wed, 18 Jul 2012 18:21:33 +0000 (18:21 +0000)]
Unreviewed, rolling out r122984.
http://trac.webkit.org/changeset/122984
https://bugs.webkit.org/show_bug.cgi?id=91171

Broken the shared build, need to export a SkData in skia

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setURLForRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Alignment crash in MIMESniffer
rwlbuis@webkit.org [Wed, 18 Jul 2012 18:09:56 +0000 (18:09 +0000)]
Source/WebCore: Alignment crash in MIMESniffer
https://bugs.webkit.org/show_bug.cgi?id=89787

Reviewed by Yong Li.

PR 169064

Prevent ASSERT on unaligned data. Special-case handling of unaligned data
to maskedCompareSlowCase.

No test, too hard to reproduce.

* platform/network/MIMESniffing.cpp:
(std::maskedCompareSlowCase):
(std):
(std::maskedCompare):

Source/WTF: Alignment crash in MIMESniffer
https://bugs.webkit.org/show_bug.cgi?id=89787

Reviewed by Yong Li.

PR 169064

Change isPointerTypeAlignmentOkay so calling it does not require ifdefs.

* wtf/StdLibExtras.h:
(isPointerTypeAlignmentOkay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert svg/css/scientific-numbers.html to a text only test
tony@chromium.org [Wed, 18 Jul 2012 17:58:59 +0000 (17:58 +0000)]
Convert svg/css/scientific-numbers.html to a text only test
https://bugs.webkit.org/show_bug.cgi?id=91641

Reviewed by Dirk Schulze.

This is a JS test so we don't need the pixel dump.

* svg/css/script-tests/scientific-numbers.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] platform/qt/http tests needs update after rebaseline and new testfonts
commit-queue@webkit.org [Wed, 18 Jul 2012 17:57:21 +0000 (17:57 +0000)]
[Qt] platform/qt/http tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91119

Patch by Alex Bravo <alex.bravo@nokia.com> on 2012-07-18
Reviewed by Noam Rosenthal.

Rebased platform/qt/http tests and unskipped them from qt-5.0

* platform/qt/http/tests/loading/simple-subframe-expected.png: Added.
* platform/qt/http/tests/loading/simple-subframe-expected.txt:
* platform/qt/http/tests/local/file-url-sent-as-referer-expected.png:
* platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt:
* platform/qt/http/tests/misc/acid2-expected.png:
* platform/qt/http/tests/misc/acid2-expected.txt:
* platform/qt/http/tests/misc/acid2-pixel-expected.png:
* platform/qt/http/tests/misc/acid2-pixel-expected.txt:
* platform/qt/http/tests/misc/error404-expected.png:
* platform/qt/http/tests/misc/error404-expected.txt:
* platform/qt/http/tests/misc/favicon-as-image-expected.png:
* platform/qt/http/tests/misc/favicon-as-image-expected.txt:
* platform/qt/http/tests/misc/frame-access-during-load-expected.png:
* platform/qt/http/tests/misc/frame-access-during-load-expected.txt:
* platform/qt/http/tests/misc/generated-content-inside-table-expected.png:
* platform/qt/http/tests/misc/generated-content-inside-table-expected.txt:
* platform/qt/http/tests/misc/iframe404-expected.png:
* platform/qt/http/tests/misc/iframe404-expected.txt:
* platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.png:
* platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
* platform/qt/http/tests/misc/slow-loading-mask-expected.png:
* platform/qt/http/tests/misc/slow-loading-mask-expected.txt:
* platform/qt/http/tests/navigation/error404-basic-expected.png: Added.
* platform/qt/http/tests/navigation/error404-basic-expected.txt:
* platform/qt/http/tests/navigation/error404-goback-expected.png: Added.
* platform/qt/http/tests/navigation/error404-goback-expected.txt:
* platform/qt/http/tests/navigation/error404-subframeload-expected.png: Added.
* platform/qt/http/tests/navigation/error404-subframeload-expected.txt:
* platform/qt/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/qt/http/tests/navigation/postredirect-basic-expected.png: Added.
* platform/qt/http/tests/navigation/postredirect-basic-expected.txt:
* platform/qt/http/tests/navigation/postredirect-goback1-expected.png: Added.
* platform/qt/http/tests/navigation/postredirect-goback1-expected.txt:
* platform/qt/http/tests/uri/css-href-expected.png:
* platform/qt/http/tests/uri/css-href-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] QQuickWebView shouldn't recieve mouse events while dialogs are active
pierre.rossi@gmail.com [Wed, 18 Jul 2012 17:43:36 +0000 (17:43 +0000)]
[Qt] QQuickWebView shouldn't recieve mouse events while dialogs are active
https://bugs.webkit.org/show_bug.cgi?id=91634

Reviewed by Alexis Menard.

One side-effect of reimplementing childMouseEventFilter() in r122438 is that it can end up
bypassing the mouseArea mechanism used in QML dialogs and still forward some mouse events
over to the web process. We can rely on the same m_dialogActive mechanism already used for
touch events in there as well.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::childMouseEventFilter): ignore events and return early if a dialog is active.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Build fix for ENABLE_TOUCH_EVENTS=0
pierre.rossi@gmail.com [Wed, 18 Jul 2012 17:37:29 +0000 (17:37 +0000)]
[Qt] Build fix for ENABLE_TOUCH_EVENTS=0

Rubber-stamped by No'am Rosenthal.

Add the appropriate ENABLE(TOUCH_EVENTS) where they're needed.

* UIProcess/API/qt/raw/qrawwebview.cpp:
* UIProcess/API/qt/raw/qrawwebview_p.h: include Platform.h so we can use the ENABLE macro.
* UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp: Also add the missing QFile include.
* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::deactivateTapHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] fast/table tests needs update after rebaseline and new testfonts
commit-queue@webkit.org [Wed, 18 Jul 2012 17:22:40 +0000 (17:22 +0000)]
[Qt] fast/table tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91621

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-18
Reviewed by Alexis Menard.

After the rebaseline from changeset 121971 - [Qt] DumpRenderTree does not use
'monospace' font when directed, fast/table tests directory needs to be updated.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt-5.0/fast/table/003-expected.png:
* platform/qt-5.0/fast/table/003-expected.txt:
* platform/qt-5.0/fast/table/border-collapsing/004-expected.txt:
* platform/qt/fast/table/001-expected.png:
* platform/qt/fast/table/001-expected.txt:
* platform/qt/fast/table/002-expected.png:
* platform/qt/fast/table/002-expected.txt:
* platform/qt/fast/table/004-expected.png:
* platform/qt/fast/table/004-expected.txt:
* platform/qt/fast/table/005-expected.png:
* platform/qt/fast/table/005-expected.txt:
* platform/qt/fast/table/006-expected.png:
* platform/qt/fast/table/006-expected.txt:
* platform/qt/fast/table/007-expected.png:
* platform/qt/fast/table/007-expected.txt:
* platform/qt/fast/table/009-expected.png:
* platform/qt/fast/table/009-expected.txt:
* platform/qt/fast/table/010-expected.png:
* platform/qt/fast/table/010-expected.txt:
* platform/qt/fast/table/011-expected.png:
* platform/qt/fast/table/011-expected.txt:
* platform/qt/fast/table/012-expected.png:
* platform/qt/fast/table/012-expected.txt:
* platform/qt/fast/table/013-expected.png:
* platform/qt/fast/table/013-expected.txt:
* platform/qt/fast/table/014-expected.png:
* platform/qt/fast/table/014-expected.txt:
* platform/qt/fast/table/015-expected.png:
* platform/qt/fast/table/015-expected.txt:
* platform/qt/fast/table/016-expected.png:
* platform/qt/fast/table/016-expected.txt:
* platform/qt/fast/table/017-expected.png:
* platform/qt/fast/table/017-expected.txt:
* platform/qt/fast/table/018-expected.png:
* platform/qt/fast/table/018-expected.txt:
* platform/qt/fast/table/020-expected.png:
* platform/qt/fast/table/020-expected.txt:
* platform/qt/fast/table/021-expected.png:
* platform/qt/fast/table/021-expected.txt:
* platform/qt/fast/table/022-expected.png:
* platform/qt/fast/table/022-expected.txt:
* platform/qt/fast/table/023-expected.png:
* platform/qt/fast/table/023-expected.txt:
* platform/qt/fast/table/025-expected.png:
* platform/qt/fast/table/025-expected.txt:
* platform/qt/fast/table/026-expected.png:
* platform/qt/fast/table/026-expected.txt:
* platform/qt/fast/table/027-expected.png:
* platform/qt/fast/table/027-expected.txt:
* platform/qt/fast/table/027-vertical-expected.png:
* platform/qt/fast/table/027-vertical-expected.txt:
* platform/qt/fast/table/028-expected.png:
* platform/qt/fast/table/028-expected.txt:
* platform/qt/fast/table/028-vertical-expected.png:
* platform/qt/fast/table/028-vertical-expected.txt:
* platform/qt/fast/table/029-expected.png:
* platform/qt/fast/table/029-expected.txt:
* platform/qt/fast/table/030-expected.png:
* platform/qt/fast/table/030-expected.txt:
* platform/qt/fast/table/033-expected.png:
* platform/qt/fast/table/033-expected.txt:
* platform/qt/fast/table/034-expected.png:
* platform/qt/fast/table/034-expected.txt:
* platform/qt/fast/table/035-expected.png:
* platform/qt/fast/table/035-expected.txt:
* platform/qt/fast/table/035-vertical-expected.png:
* platform/qt/fast/table/035-vertical-expected.txt:
* platform/qt/fast/table/036-expected.png:
* platform/qt/fast/table/036-expected.txt:
* platform/qt/fast/table/037-expected.png:
* platform/qt/fast/table/037-expected.txt:
* platform/qt/fast/table/038-expected.png:
* platform/qt/fast/table/038-expected.txt:
* platform/qt/fast/table/038-vertical-expected.png:
* platform/qt/fast/table/038-vertical-expected.txt:
* platform/qt/fast/table/039-expected.png:
* platform/qt/fast/table/039-expected.txt:
* platform/qt/fast/table/040-expected.png:
* platform/qt/fast/table/040-expected.txt:
* platform/qt/fast/table/040-vertical-expected.png:
* platform/qt/fast/table/040-vertical-expected.txt:
* platform/qt/fast/table/041-expected.png:
* platform/qt/fast/table/041-expected.txt:
* platform/qt/fast/table/100-percent-cell-width-expected.png:
* platform/qt/fast/table/100-percent-cell-width-expected.txt:
* platform/qt/fast/table/absolute-table-at-bottom-expected.png:
* platform/qt/fast/table/absolute-table-at-bottom-expected.txt:
* platform/qt/fast/table/add-before-anonymous-child-expected.png:
* platform/qt/fast/table/add-before-anonymous-child-expected.txt:
* platform/qt/fast/table/align-right-within-left-aligned-div-expected.txt:
* platform/qt/fast/table/append-cells-expected.png:
* platform/qt/fast/table/append-cells-expected.txt:
* platform/qt/fast/table/append-cells2-expected.png:
* platform/qt/fast/table/append-cells2-expected.txt:
* platform/qt/fast/table/auto-with-percent-height-expected.png:
* platform/qt/fast/table/auto-with-percent-height-expected.txt:
* platform/qt/fast/table/auto-with-percent-height-vertical-expected.png:
* platform/qt/fast/table/auto-with-percent-height-vertical-expected.txt:
* platform/qt/fast/table/border-collapsing/001-expected.png:
* platform/qt/fast/table/border-collapsing/001-expected.txt:
* platform/qt/fast/table/border-collapsing/001-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/001-vertical-expected.txt:
* platform/qt/fast/table/border-collapsing/002-expected.png:
* platform/qt/fast/table/border-collapsing/002-expected.txt:
* platform/qt/fast/table/border-collapsing/002-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/002-vertical-expected.txt:
* platform/qt/fast/table/border-collapsing/003-expected.png:
* platform/qt/fast/table/border-collapsing/003-expected.txt:
* platform/qt/fast/table/border-collapsing/003-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/003-vertical-expected.txt:
* platform/qt/fast/table/border-collapsing/004-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/004-vertical-expected.txt:
* platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-expected.png:
* platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-expected.txt:
* platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt:
* platform/qt/fast/table/border-collapsing/rtl-border-collapsing-expected.png:
* platform/qt/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
* platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt:
* platform/qt/fast/table/cell-absolute-child-expected.png:
* platform/qt/fast/table/cell-absolute-child-expected.txt:
* platform/qt/fast/table/cell-coalescing-expected.png:
* platform/qt/fast/table/cell-coalescing-expected.txt:
* platform/qt/fast/table/cell-pref-width-invalidation-expected.png:
* platform/qt/fast/table/cell-pref-width-invalidation-expected.txt:
* platform/qt/fast/table/cell-width-auto-expected.png:
* platform/qt/fast/table/cell-width-auto-expected.txt:
* platform/qt/fast/table/cellindex-expected.png:
* platform/qt/fast/table/cellindex-expected.txt:
* platform/qt/fast/table/click-near-anonymous-table-expected.png:
* platform/qt/fast/table/click-near-anonymous-table-expected.txt:
* platform/qt/fast/table/colgroup-preceded-by-caption-expected.png:
* platform/qt/fast/table/colgroup-preceded-by-caption-expected.txt:
* platform/qt/fast/table/colgroup-spanning-groups-rules-expected.png:
* platform/qt/fast/table/colgroup-spanning-groups-rules-expected.txt:
* platform/qt/fast/table/colspanMinWidth-expected.png:
* platform/qt/fast/table/colspanMinWidth-expected.txt:
* platform/qt/fast/table/dynamic-caption-add-before-child-expected.png:
* platform/qt/fast/table/dynamic-caption-add-before-child-expected.txt:
* platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.png:
* platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.txt:
* platform/qt/fast/table/dynamic-cellpadding-expected.png:
* platform/qt/fast/table/dynamic-cellpadding-expected.txt:
* platform/qt/fast/table/dynamic-descendant-percentage-height-expected.png:
* platform/qt/fast/table/dynamic-descendant-percentage-height-expected.txt:
* platform/qt/fast/table/early-table-layout-expected.png:
* platform/qt/fast/table/early-table-layout-expected.txt:
* platform/qt/fast/table/edge-offsets-expected.png:
* platform/qt/fast/table/edge-offsets-expected.txt:
* platform/qt/fast/table/empty-cells-expected.png:
* platform/qt/fast/table/empty-cells-expected.txt:
* platform/qt/fast/table/empty-row-crash-expected.png:
* platform/qt/fast/table/empty-row-crash-expected.txt:
* platform/qt/fast/table/empty-table-percent-height-expected.png:
* platform/qt/fast/table/empty-table-percent-height-expected.txt:
* platform/qt/fast/table/fixed-nested-expected.png:
* platform/qt/fast/table/fixed-nested-expected.txt:
* platform/qt/fast/table/fixed-table-non-cell-in-row-expected.png:
* platform/qt/fast/table/fixed-table-non-cell-in-row-expected.txt:
* platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt:
* platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt:
* platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.txt:
* platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt:
* platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt:
* platform/qt/fast/table/fixed-table-with-small-percent-width-expected.txt:
* platform/qt/fast/table/floating-th-expected.png:
* platform/qt/fast/table/floating-th-expected.txt:
* platform/qt/fast/table/floatingTablePaintBackground-expected.png:
* platform/qt/fast/table/floatingTablePaintBackground-expected.txt:
* platform/qt/fast/table/form-with-table-style-expected.png:
* platform/qt/fast/table/form-with-table-style-expected.txt:
* platform/qt/fast/table/frame-and-rules-expected.png:
* platform/qt/fast/table/frame-and-rules-expected.txt:
* platform/qt/fast/table/generated-caption-expected.png:
* platform/qt/fast/table/generated-caption-expected.txt:
* platform/qt/fast/table/giantRowspan2-expected.png:
* platform/qt/fast/table/giantRowspan2-expected.txt:
* platform/qt/fast/table/inline-form-assert-expected.png:
* platform/qt/fast/table/inline-form-assert-expected.txt:
* platform/qt/fast/table/insert-before-anonymous-ancestors-expected.png:
* platform/qt/fast/table/insert-before-anonymous-ancestors-expected.txt:
* platform/qt/fast/table/insert-cell-before-form-expected.png:
* platform/qt/fast/table/insert-cell-before-form-expected.txt:
* platform/qt/fast/table/insert-row-before-form-expected.png:
* platform/qt/fast/table/insert-row-before-form-expected.txt:
* platform/qt/fast/table/invisible-cell-background-expected.png:
* platform/qt/fast/table/invisible-cell-background-expected.txt:
* platform/qt/fast/table/large-width-expected.png:
* platform/qt/fast/table/large-width-expected.txt:
* platform/qt/fast/table/multiple-captions-display-expected.png:
* platform/qt/fast/table/multiple-captions-display-expected.txt:
* platform/qt/fast/table/multiple-percent-height-rows-expected.png:
* platform/qt/fast/table/multiple-percent-height-rows-expected.txt:
* platform/qt/fast/table/nested-percent-height-table-expected.png:
* platform/qt/fast/table/nested-percent-height-table-expected.txt:
* platform/qt/fast/table/nobr-expected.png:
* platform/qt/fast/table/nobr-expected.txt:
* platform/qt/fast/table/overflowHidden-expected.png:
* platform/qt/fast/table/overflowHidden-expected.txt:
* platform/qt/fast/table/percent-heights-expected.png:
* platform/qt/fast/table/percent-heights-expected.txt:
* platform/qt/fast/table/prepend-in-anonymous-table-expected.png:
* platform/qt/fast/table/prepend-in-anonymous-table-expected.txt:
* platform/qt/fast/table/quote-text-around-iframe-expected.png:
* platform/qt/fast/table/quote-text-around-iframe-expected.txt:
* platform/qt/fast/table/relative-position-containment-expected.png:
* platform/qt/fast/table/relative-position-containment-expected.txt:
* platform/qt/fast/table/relative-position-offsets-expected.png:
* platform/qt/fast/table/relative-position-offsets-expected.txt:
* platform/qt/fast/table/relative-position-stacking-expected.png:
* platform/qt/fast/table/relative-position-stacking-expected.txt:
* platform/qt/fast/table/remove-td-display-none-expected.png:
* platform/qt/fast/table/remove-td-display-none-expected.txt:
* platform/qt/fast/table/replaced-percent-height-expected.png:
* platform/qt/fast/table/replaced-percent-height-expected.txt:
* platform/qt/fast/table/row-height-recalc-expected.png:
* platform/qt/fast/table/row-height-recalc-expected.txt:
* platform/qt/fast/table/rowindex-expected.png:
* platform/qt/fast/table/rowindex-expected.txt:
* platform/qt/fast/table/rowspan-paint-order-expected.png:
* platform/qt/fast/table/rowspan-paint-order-expected.txt:
* platform/qt/fast/table/rowspan-paint-order-vertical-expected.png:
* platform/qt/fast/table/rowspan-paint-order-vertical-expected.txt:
* platform/qt/fast/table/rtl-cell-display-none-assert-expected.png:
* platform/qt/fast/table/rtl-cell-display-none-assert-expected.txt:
* platform/qt/fast/table/rules-attr-dynchange1-expected.png:
* platform/qt/fast/table/rules-attr-dynchange1-expected.txt:
* platform/qt/fast/table/rules-attr-dynchange2-expected.png:
* platform/qt/fast/table/rules-attr-dynchange2-expected.txt:
* platform/qt/fast/table/spanOverlapRepaint-expected.png:
* platform/qt/fast/table/spanOverlapRepaint-expected.txt:
* platform/qt/fast/table/stale-grid-crash-expected.png:
* platform/qt/fast/table/stale-grid-crash-expected.txt:
* platform/qt/fast/table/table-after-child-in-table-expected.png:
* platform/qt/fast/table/table-after-child-in-table-expected.txt:
* platform/qt/fast/table/table-and-parts-outline-expected.png:
* platform/qt/fast/table/table-and-parts-outline-expected.txt:
* platform/qt/fast/table/table-before-child-in-table-expected.png:
* platform/qt/fast/table/table-before-child-in-table-expected.txt:
* platform/qt/fast/table/table-cell-after-child-in-block-expected.png:
* platform/qt/fast/table/table-cell-after-child-in-block-expected.txt:
* platform/qt/fast/table/table-cell-after-child-in-table-expected.png:
* platform/qt/fast/table/table-cell-after-child-in-table-expected.txt:
* platform/qt/fast/table/table-cell-before-child-in-block-expected.png:
* platform/qt/fast/table/table-cell-before-child-in-block-expected.txt:
* platform/qt/fast/table/table-cell-before-child-in-table-expected.png:
* platform/qt/fast/table/table-cell-before-child-in-table-expected.txt:
* platform/qt/fast/table/table-continuation-outline-paint-crash-expected.png:
* platform/qt/fast/table/table-continuation-outline-paint-crash-expected.txt:
* platform/qt/fast/table/table-display-types-expected.png:
* platform/qt/fast/table/table-display-types-expected.txt:
* platform/qt/fast/table/table-display-types-strict-expected.png:
* platform/qt/fast/table/table-display-types-strict-expected.txt:
* platform/qt/fast/table/table-display-types-vertical-expected.png:
* platform/qt/fast/table/table-display-types-vertical-expected.txt:
* platform/qt/fast/table/table-hspace-align-center-expected.png:
* platform/qt/fast/table/table-hspace-align-center-expected.txt:
* platform/qt/fast/table/table-row-after-child-in-block-expected.png:
* platform/qt/fast/table/table-row-after-child-in-block-expected.txt:
* platform/qt/fast/table/table-row-after-child-in-table-expected.png:
* platform/qt/fast/table/table-row-after-child-in-table-expected.txt:
* platform/qt/fast/table/table-row-before-child-in-block-expected.png:
* platform/qt/fast/table/table-row-before-child-in-block-expected.txt:
* platform/qt/fast/table/table-row-before-child-in-table-expected.png:
* platform/qt/fast/table/table-row-before-child-in-table-expected.txt:
* platform/qt/fast/table/tableInsideCaption-expected.png:
* platform/qt/fast/table/tableInsideCaption-expected.txt:
* platform/qt/fast/table/text-field-baseline-expected.png:
* platform/qt/fast/table/text-field-baseline-expected.txt:
* platform/qt/fast/table/unbreakable-images-quirk-expected.png:
* platform/qt/fast/table/unbreakable-images-quirk-expected.txt:
* platform/qt/fast/table/unused-percent-heights-expected.png:
* platform/qt/fast/table/unused-percent-heights-expected.txt:
* platform/qt/fast/table/vertical-align-baseline-expected.png:
* platform/qt/fast/table/vertical-align-baseline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChrome/Skia: PDF print output does not have clickable links.
commit-queue@webkit.org [Wed, 18 Jul 2012 17:10:40 +0000 (17:10 +0000)]
Chrome/Skia: PDF print output does not have clickable links.
https://bugs.webkit.org/show_bug.cgi?id=91171

Patch by Steve VanDeBogart <vandebo@chromium.org> on 2012-07-18
Reviewed by Stephen White.

Connect GraphicsContext::setURLForRect to Skia's new API for annotations.

Printing is not generally testable.

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setURLForRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] 0.11 build broken
commit-queue@webkit.org [Wed, 18 Jul 2012 16:51:13 +0000 (16:51 +0000)]
[GStreamer] 0.11 build broken
https://bugs.webkit.org/show_bug.cgi?id=91629

Patch by Philippe Normand <pnormand@igalia.com> on 2012-07-18
Reviewed by Alexis Menard.

* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkProposeAllocation): Pass null GstStructure to
gst_query_add_allocation_meta(). Our propose-allocation method
is simple enough to not need to set it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed TestExpectations update for WK90469.
jsbell@chromium.org [Wed, 18 Jul 2012 16:46:12 +0000 (16:46 +0000)]
[chromium] Unreviewed TestExpectations update for WK90469.
Coalesce entries for windows flaky crashes related to 90469, and try
skipping a particularly impacted test to see if fails shift elsewhere.
https://bugs.webkit.org/show_bug.cgi?id=90469

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: <input type="submit"> unlabelled.
cfleizach@apple.com [Wed, 18 Jul 2012 16:36:47 +0000 (16:36 +0000)]
AX: <input type="submit"> unlabelled.
https://bugs.webkit.org/show_bug.cgi?id=91563

Reviewed by Adele Peterson.

Source/WebCore:

Make sure the default value is returned if there is no other value specified.

Test: platform/mac/accessibility/submit-button-default-value.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::title):

LayoutTests:

* platform/mac/accessibility/submit-button-default-value-expected.txt: Added.
* platform/mac/accessibility/submit-button-default-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove awkward anchorPoint usage that implicity affects layer position
shawnsingh@chromium.org [Wed, 18 Jul 2012 16:34:11 +0000 (16:34 +0000)]
[chromium] Remove awkward anchorPoint usage that implicity affects layer position
https://bugs.webkit.org/show_bug.cgi?id=91472

Reviewed by Adrienne Walker.

Source/WebCore:

Covered by existing layout tests and unit tests, several existing unit tests updated.

In GraphicsLayerChromium, anchorPoint() implicity affects
position(). Therefore, unit tests needed to remember to set
anchorPoint correctly when trying to position layers for
testing. However, it's easy to forget that initialization, and
probably shouldn't be necessary anyway since conceptually
anchorPoint does not affect layer position.

This patch removes the "actualPosition + anchorPoint" quirk in
GraphicsLayerChromium, so that this problem is avoided.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateLayerPosition): No longer computes position + anchorPoint. Instead this is done in calcDrawTransformsInternal.
(WebCore::GraphicsLayerChromium::updateLayerSize): No longer affects computation of position.
(WebCore::GraphicsLayerChromium::updateAnchorPoint): No longer affects computation of position
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D): Position is initialized to zero instead of relative to anchorPoint
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsInternal): explicitly use position + anchorPoint in this code, for both layer and replica.
    Note that replicaLayer now uses its own anchorPoint, which seems to be more consistent with Safari behavior.

Source/WebKit/chromium:

Unit tests were updated to account for the fact that anchorPoint
and position are now separated.

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/TiledLayerChromiumTest.cpp:

LayoutTests:

* platform/chromium/TestExpectations: marked compositing/reflections/nested-reflection-anchor-point.html as needing
                                      rebaselining.  Its behavior should now be similar to Safari.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Regression] Save as file is missing in Network panel preview/response...
pfeldman@chromium.org [Wed, 18 Jul 2012 16:10:35 +0000 (16:10 +0000)]
Web Inspector: [Regression] Save as file is missing in Network panel preview/response tabs.
https://bugs.webkit.org/show_bug.cgi?id=91625

Reviewed by Vsevolod Vlasov.

* inspector/front-end/HandlerRegistry.js:
* inspector/front-end/NetworkPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSVG CSS property types with <number> don't support exponents
krit@webkit.org [Wed, 18 Jul 2012 15:42:40 +0000 (15:42 +0000)]
SVG CSS property types with <number> don't support exponents
https://bugs.webkit.org/show_bug.cgi?id=52542

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Parse numbers in SVG presentation attributes with SVG parser to support scientific notations.
The SVG parser is already well tested and has some extra checks for edge like protection from
overflow.

The patch is based upon a patch of Bear Travis.

Test: svg/css/scientific-numbers.html

* css/CSSParser.cpp:
(WebCore::CSSParser::lex): Use SVG parser to parse numbers of SVG attributes.
* svg/SVGParserUtilities.cpp:
(WebCore::parseSVGNumber): Added accessor to call from CSSParser with double value.
(WebCore):
* svg/SVGParserUtilities.h:
(WebCore):

LayoutTests:

Test scientific number values on SVG presentation attributes.

* svg/css/scientific-numbers-expected.txt: Added.
* svg/css/scientific-numbers.html: Added.
* svg/css/script-tests/scientific-numbers.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: beautify the paused in debugger message, make it configurable from...
pfeldman@chromium.org [Wed, 18 Jul 2012 15:39:19 +0000 (15:39 +0000)]
Web Inspector: beautify the paused in debugger message, make it configurable from the front-end.
https://bugs.webkit.org/show_bug.cgi?id=91628

Reviewed by Vsevolod Vlasov.

Made message smaller, using consistent font;
Made message configurable from the front-end.

* English.lproj/localizedStrings.js:
* inspector/DOMNodeHighlighter.cpp:
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::setPausedInDebuggerMessage):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawPausedInDebugger):
* inspector/DOMNodeHighlighter.h:
(InspectorOverlay):
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setOverlayMessage):
(WebCore):
(WebCore::InspectorDebuggerAgent::clear):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::setOverlayMessage):
* inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._setDebuggerPausedDetails):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebCore::StylePropertySet::addParsedProperties - crash
commit-queue@webkit.org [Wed, 18 Jul 2012 15:15:22 +0000 (15:15 +0000)]
WebCore::StylePropertySet::addParsedProperties - crash
https://bugs.webkit.org/show_bug.cgi?id=91153

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-07-18
Reviewed by Andreas Kling.

Source/WebCore:

WebKitCSSKeyframeRule::style exposed an immutable StylePropertySet.
Modified to create a mutable copy on demand.

Test: fast/css/css-keyframe-style-mutate-crash.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::mutableProperties): Added, creates a mutable copy of properties as required.
(WebCore::WebKitCSSKeyframeRule::style):
* css/WebKitCSSKeyframeRule.h:
(WebCore::StyleKeyframe::properties): Made const, use mutableProperties to mutate.

LayoutTests:

* fast/css/css-keyframe-style-mutate-crash-expected.txt: Added.
* fast/css/css-keyframe-style-mutate-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] Make TextureMapperLayer clip m_state.needsDisplayRect with the layerRect.
kseo@webkit.org [Wed, 18 Jul 2012 15:13:34 +0000 (15:13 +0000)]
[Texmap] Make TextureMapperLayer clip m_state.needsDisplayRect with the layerRect.
https://bugs.webkit.org/show_bug.cgi?id=91595

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-18
Reviewed by Noam Rosenthal.

Internal review by Kwang Yul Seo.

Currently, TextureMapperLayer creates an ImageBuffer as big as
m_state.needsDisplayRect if m_state.needsDispaly is false. The size of
m_state.needsDisplayRect can be bigger than the size of the layerRect, so we may
consume more memory than the size of the layerRect. It even can cause crash if
m_state.needsDisplayRect is too big.

No new tests, covered by existing tests.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::updateBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
kbalazs@webkit.org [Wed, 18 Jul 2012 15:12:26 +0000 (15:12 +0000)]
Unreviewed gardening.
More pixel rebaseline in compositing for qt-5.0-wk2.

Added baselines, mark failing tests.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-expected.png: Added.
* platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
* platform/qt-5.0-wk2/compositing/fixed-position-scroll-offset-history-restore-expected.png: Added.
* platform/qt-5.0-wk2/compositing/flat-with-transformed-child-expected.png: Added.
* platform/qt-5.0-wk2/compositing/images/content-image-change-expected.png: Added.
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake][EFL] Build and run TestWebKitAPI unit tests
commit-queue@webkit.org [Wed, 18 Jul 2012 15:07:34 +0000 (15:07 +0000)]
[CMake][EFL] Build and run TestWebKitAPI unit tests
https://bugs.webkit.org/show_bug.cgi?id=90671

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-18
Reviewed by Daniel Bates.

This patch enables almost for free a significant amount of test for the
WebKit C API, WTF and KURL. It makes easy for CMake based ports to
enable TestWebKitAPI since the missing bits to implement are
relatively simple.

* CMakeLists.txt:
* TestWebKitAPI/CMakeLists.txt: Added.
* TestWebKitAPI/PlatformEfl.cmake: Added.
* TestWebKitAPI/PlatformWebView.h:
* TestWebKitAPI/config.h:
* TestWebKitAPI/efl/InjectedBundleController.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::InjectedBundleController::platformInitialize):
* TestWebKitAPI/efl/PlatformUtilities.cpp: Added.
(TestWebKitAPI):
(Util):
(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::URLForNonExistentResource):
* TestWebKitAPI/efl/PlatformWebView.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::initEcoreEvas):
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
* TestWebKitAPI/efl/main.cpp: Added.
(checkForUseX11WindowArgument):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] We should update the status in NetworkJob if there is a new one from...
jason.liu@torchmobile.com.cn [Wed, 18 Jul 2012 15:04:17 +0000 (15:04 +0000)]
[BlackBerry] We should update the status in NetworkJob if there is a new one from libcurl.
https://bugs.webkit.org/show_bug.cgi?id=91475

Reviewed by Yong Li.

Libcurl sometimes sends multiple status messages, we need to keep the last
one in NetworkJob.
We originally had the m_statusReceived check, then we found out that libcurl
sometimes sent additional 401 codes and added the 401 exception to the check,
and now we're removing the whole check(so we don't need the exception either).

RIM PR# 163172
Reviewed internally by Joe Mason.

No new tests. This is caused by libcurl's multiple status messages.
So we don't need to write a test case for webkit.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyStatusReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] fast/text tests needs update after rebaseline and new testfonts
commit-queue@webkit.org [Wed, 18 Jul 2012 14:52:05 +0000 (14:52 +0000)]
[Qt] fast/text tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91570

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-18
Reviewed by Simon Hausmann.

After the rebaseline from changeset 121971 - [Qt] DumpRenderTree does not use
'monospace' font when directed, fast/text tests directory needs to be updated.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fast/text/large-text-composed-char-expected.png:
* platform/qt-5.0-wk2/fast/text/large-text-composed-char-expected.txt:
* platform/qt-5.0/Skipped:
* platform/qt-5.0/fast/text/backslash-to-yen-sign-euc-expected.txt:
* platform/qt-5.0/fast/text/backslash-to-yen-sign-expected.txt:
* platform/qt-5.0/fast/text/basic/003-expected.png:
* platform/qt-5.0/fast/text/basic/003-expected.txt:
* platform/qt-5.0/fast/text/fallback-traits-fixup-expected.txt:
* platform/qt-5.0/fast/text/international/hindi-whitespace-expected.txt:
* platform/qt-5.0/fast/text/international/text-spliced-font-expected.png:
* platform/qt-5.0/fast/text/international/text-spliced-font-expected.txt:
* platform/qt-5.0/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
* platform/qt-5.0/fast/text/large-text-composed-char-expected.png:
* platform/qt-5.0/fast/text/large-text-composed-char-expected.txt:
* platform/qt-5.0/fast/text/letter-spacing-negative-opacity-expected.png:
* platform/qt-5.0/fast/text/letter-spacing-negative-opacity-expected.txt:
* platform/qt-5.0/fast/text/softHyphen-expected.txt:
* platform/qt-5.0/fast/text/text-letter-spacing-expected.txt:
* platform/qt/fast/text/atsui-kerning-and-ligatures-expected.txt:
* platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.png:
* platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.txt:
* platform/qt/fast/text/backslash-to-yen-sign-dynamic-expected.png:
* platform/qt/fast/text/backslash-to-yen-sign-dynamic-expected.txt:
* platform/qt/fast/text/basic/001-expected.png:
* platform/qt/fast/text/basic/001-expected.txt:
* platform/qt/fast/text/basic/002-expected.txt:
* platform/qt/fast/text/basic/004-expected.txt:
* platform/qt/fast/text/basic/005-expected.txt:
* platform/qt/fast/text/basic/006-expected.txt:
* platform/qt/fast/text/basic/007-expected.txt:
* platform/qt/fast/text/basic/008-expected.txt:
* platform/qt/fast/text/basic/009-expected.png:
* platform/qt/fast/text/basic/009-expected.txt:
* platform/qt/fast/text/basic/011-expected.txt:
* platform/qt/fast/text/basic/012-expected.txt:
* platform/qt/fast/text/basic/generic-family-changes-expected.png:
* platform/qt/fast/text/basic/generic-family-changes-expected.txt:
* platform/qt/fast/text/basic/generic-family-reset-expected.png:
* platform/qt/fast/text/basic/generic-family-reset-expected.txt:
* platform/qt/fast/text/break-word-expected.png:
* platform/qt/fast/text/break-word-expected.txt:
* platform/qt/fast/text/capitalize-empty-generated-string-expected.txt:
* platform/qt/fast/text/capitalize-preserve-nbsp-expected.txt:
* platform/qt/fast/text/cg-vs-atsui-expected.png:
* platform/qt/fast/text/cg-vs-atsui-expected.txt:
* platform/qt/fast/text/complex-preferred-logical-widths-expected.png:
* platform/qt/fast/text/complex-preferred-logical-widths-expected.txt:
* platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png:
* platform/qt/fast/text/complex-synthetic-bold-space-width-expected.txt:
* platform/qt/fast/text/delete-hard-break-character-expected.txt:
* platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.png:
* platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
* platform/qt/fast/text/fake-italic-expected.txt:
* platform/qt/fast/text/firstline/001-expected.txt:
* platform/qt/fast/text/firstline/002-expected.txt:
* platform/qt/fast/text/firstline/003-expected.txt:
* platform/qt/fast/text/font-initial-expected.txt:
* platform/qt/fast/text/hyphenate-limit-before-after-expected.png:
* platform/qt/fast/text/hyphenate-limit-before-after-expected.txt:
* platform/qt/fast/text/hyphenate-limit-lines-expected.png:
* platform/qt/fast/text/hyphenate-limit-lines-expected.txt:
* platform/qt/fast/text/justified-selection-at-edge-expected.txt:
* platform/qt/fast/text/justified-selection-expected.txt:
* platform/qt/fast/text/line-breaks-after-white-space-expected.png:
* platform/qt/fast/text/line-breaks-after-white-space-expected.txt:
* platform/qt/fast/text/midword-break-before-surrogate-pair-2-expected.txt:
* platform/qt/fast/text/midword-break-hang-expected.txt:
* platform/qt/fast/text/reset-emptyRun-expected.txt:
* platform/qt/fast/text/selection-hard-linebreak-expected.png:
* platform/qt/fast/text/selection-hard-linebreak-expected.txt:
* platform/qt/fast/text/shadow-no-blur-expected.png:
* platform/qt/fast/text/shadow-no-blur-expected.txt:
* platform/qt/fast/text/shadow-translucent-fill-expected.txt:
* platform/qt/fast/text/should-use-atsui-expected.txt:
* platform/qt/fast/text/stroking-decorations-expected.txt:
* platform/qt/fast/text/stroking-expected.txt:
* platform/qt/fast/text/text-shadow-no-default-color-expected.txt:
* platform/qt/fast/text/textIteratorNilRenderer-expected.png:
* platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
* platform/qt/fast/text/unicode-variation-selector-expected.png:
* platform/qt/fast/text/unicode-variation-selector-expected.txt:
* platform/qt/fast/text/updateNewFont-expected.txt:
* platform/qt/fast/text/wbr-expected.txt:
* platform/qt/fast/text/wbr-in-pre-crash-expected.txt:
* platform/qt/fast/text/wbr-pre-expected.png:
* platform/qt/fast/text/wbr-pre-expected.txt:
* platform/qt/fast/text/wbr-styled-expected.png:
* platform/qt/fast/text/wbr-styled-expected.txt:
* platform/qt/fast/text/whitespace/002-expected.png:
* platform/qt/fast/text/whitespace/002-expected.txt:
* platform/qt/fast/text/whitespace/003-expected.png:
* platform/qt/fast/text/whitespace/003-expected.txt:
* platform/qt/fast/text/whitespace/006-expected.txt:
* platform/qt/fast/text/whitespace/007-expected.txt:
* platform/qt/fast/text/whitespace/008-expected.txt:
* platform/qt/fast/text/whitespace/009-expected.txt:
* platform/qt/fast/text/whitespace/012-expected.png:
* platform/qt/fast/text/whitespace/012-expected.txt:
* platform/qt/fast/text/whitespace/013-expected.txt:
* platform/qt/fast/text/whitespace/014-expected.txt:
* platform/qt/fast/text/whitespace/018-expected.txt:
* platform/qt/fast/text/whitespace/019-expected.png:
* platform/qt/fast/text/whitespace/019-expected.txt:
* platform/qt/fast/text/whitespace/020-expected.txt:
* platform/qt/fast/text/whitespace/021-expected.txt:
* platform/qt/fast/text/whitespace/022-expected.png:
* platform/qt/fast/text/whitespace/022-expected.txt:
* platform/qt/fast/text/whitespace/023-expected.png:
* platform/qt/fast/text/whitespace/023-expected.txt:
* platform/qt/fast/text/whitespace/025-expected.txt:
* platform/qt/fast/text/whitespace/026-expected.txt:
* platform/qt/fast/text/whitespace/027-expected.txt:
* platform/qt/fast/text/whitespace/029-expected.png:
* platform/qt/fast/text/whitespace/029-expected.txt:
* platform/qt/fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt:
* platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
* platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
* platform/qt/fast/text/whitespace/nowrap-clear-float-expected.txt:
* platform/qt/fast/text/whitespace/pre-break-word-expected.png:
* platform/qt/fast/text/whitespace/pre-break-word-expected.txt:
* platform/qt/fast/text/whitespace/pre-newline-box-test-expected.png:
* platform/qt/fast/text/whitespace/pre-newline-box-test-expected.txt:
* platform/qt/fast/text/whitespace/pre-wrap-last-char-expected.txt:
* platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.png:
* platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.txt:
* platform/qt/fast/text/whitespace/span-in-word-space-causes-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTOUCH_ADJUSTMENT is too aggressive when snapping to large elements.
commit-queue@webkit.org [Wed, 18 Jul 2012 14:47:40 +0000 (14:47 +0000)]
TOUCH_ADJUSTMENT is too aggressive when snapping to large elements.
https://bugs.webkit.org/show_bug.cgi?id=91262

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-18
Reviewed by Antonio Gomes.

Source/WebCore:

Constrains the extent to which the touch point can be adjusted when
generating synthetic mouse events when TOUCH_ADJUSTEMNT is enabled.
Previously, the target position snapped to the center of the target
element, which can be far removed from the touch position when tapping
on or near a large element.  The refined strategy is to leave the
adjusted position unchanged if tapping within the element or to snap
to the center of the overlap region if the touch point lies outside the
bounds of the element, but the touch area and element bounds overlap.
For non-rectilineary bounds, a point lying outside the element boundary
is pulled towards the center of the element, by an amount limited by
the radius of the touch area.

Tests: touchadjustment/big-div.html
       touchadjustment/rotated-node.html

* page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::contentsToWindow):
(TouchAdjustment):
(WebCore::TouchAdjustment::snapTo):
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):

LayoutTests:

Adding a test case to ensure that the adjusted touch position is
within the bounds of the target element and the touch area.
Previously, the target position snapped to the center of the target
element, which can be far removed from the touch area.

The second test is for non-rectilinear elements, and verifies that
the touch area must overlap the true bounds of the element for an
adjustment to occur.

* touchadjustment/big-div-expected.txt: Added.
* touchadjustment/big-div.html: Added.
* touchadjustment/rotated-node-expected.txt: Added.
* touchadjustment/rotated-node.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add Ewk class for cookie manager
commit-queue@webkit.org [Wed, 18 Jul 2012 14:41:22 +0000 (14:41 +0000)]
[EFL][WK2] Add Ewk class for cookie manager
https://bugs.webkit.org/show_bug.cgi?id=91053

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-18
Reviewed by Gustavo Noronha Silva.

Add new Ewk_Cookie_Manager class to allow the client
to set/get the cookie acceptance policy, support
persistent cookie storage and clear cookies.

The Ewk_Cookie_Manager instance can be retrieved
from the Ewk_Context API.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(_Ewk_Context::~_Ewk_Context):
(ewk_context_cookie_manager_get):
* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/ewk_cookie_manager.cpp: Added.
(_Ewk_Cookie_Manager):
(_Ewk_Cookie_Manager::_Ewk_Cookie_Manager):
(ewk_cookie_manager_persistent_storage_set):
(ewk_cookie_manager_accept_policy_set):
(Get_Policy_Async_Data):
(getAcceptPolicyCallback):
(ewk_cookie_manager_async_accept_policy_get):
(Get_Hostnames_Async_Data):
(getHostnamesWithCookiesCallback):
(ewk_cookie_manager_async_hostnames_with_cookies_get):
(ewk_cookie_manager_hostname_cookies_clear):
(ewk_cookie_manager_cookies_clear):
(ewk_cookie_manager_free):
(ewk_cookie_manager_new):
* UIProcess/API/efl/ewk_cookie_manager.h: Added.
* UIProcess/API/efl/ewk_cookie_manager_private.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium gardening, unskipped tests.
vsevik@chromium.org [Wed, 18 Jul 2012 14:38:32 +0000 (14:38 +0000)]
Unreviewed chromium gardening, unskipped tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] editing/input and editing/unsupported-content tests needs update after rebaselin...
kbalazs@webkit.org [Wed, 18 Jul 2012 14:06:11 +0000 (14:06 +0000)]
[Qt] editing/input and editing/unsupported-content tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91400

Unreviewed rebaseline.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-18

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/editing/input/caret-at-the-edge-of-contenteditable-expected.png: Added.
* platform/qt/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
* platform/qt/editing/input/emacs-ctrl-o-expected.png:
* platform/qt/editing/input/emacs-ctrl-o-expected.txt:
* platform/qt/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
* platform/qt/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
* platform/qt/editing/input/reveal-caret-of-multiline-input-expected.png: Added.
* platform/qt/editing/unsupported-content/list-delete-001-expected.png:
* platform/qt/editing/unsupported-content/list-delete-001-expected.txt:
* platform/qt/editing/unsupported-content/list-delete-003-expected.png:
* platform/qt/editing/unsupported-content/list-delete-003-expected.txt:
* platform/qt/editing/unsupported-content/list-type-after-expected.png:
* platform/qt/editing/unsupported-content/list-type-after-expected.txt:
* platform/qt/editing/unsupported-content/list-type-before-expected.png:
* platform/qt/editing/unsupported-content/list-type-before-expected.txt:
* platform/qt/editing/unsupported-content/table-delete-001-expected.png:
* platform/qt/editing/unsupported-content/table-delete-001-expected.txt:
* platform/qt/editing/unsupported-content/table-delete-002-expected.png:
* platform/qt/editing/unsupported-content/table-delete-002-expected.txt:
* platform/qt/editing/unsupported-content/table-delete-003-expected.png:
* platform/qt/editing/unsupported-content/table-delete-003-expected.txt:
* platform/qt/editing/unsupported-content/table-type-after-expected.png:
* platform/qt/editing/unsupported-content/table-type-after-expected.txt:
* platform/qt/editing/unsupported-content/table-type-before-expected.png:
* platform/qt/editing/unsupported-content/table-type-before-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: adding pause icon for JavaScript debugging
caseq@chromium.org [Wed, 18 Jul 2012 14:04:58 +0000 (14:04 +0000)]
Web Inspector: adding pause icon for JavaScript debugging
https://bugs.webkit.org/show_bug.cgi?id=90880

Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-07-18
Reviewed by Pavel Feldman.

Refactored DOMNodeHighlighter into InspectorOverlay class and added a feature to show a "pause" screen when
the Javascript debugger is paused.

* inspector/DOMNodeHighlighter.cpp:
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::drawOutline):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::setPausedInDebugger):
(WebCore::InspectorOverlay::hideHighlight):
(WebCore):
(WebCore::InspectorOverlay::highlightNode):
(WebCore::InspectorOverlay::setHighlightData):
(WebCore::InspectorOverlay::clearHighlightData):
(WebCore::InspectorOverlay::highlightedNode):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawHighlight):
(WebCore::InspectorOverlay::drawPausedInDebugger):
* inspector/DOMNodeHighlighter.h:
(WebCore):
(InspectorOverlay):
(WebCore::InspectorOverlay::create):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::drawHighlight):
(WebCore::InspectorController::getHighlight):
(WebCore::InspectorController::highlightedNode):
* inspector/InspectorController.h:
(WebCore):
(InspectorController):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::~InspectorDOMAgent):
(WebCore::InspectorDOMAgent::handleMousePress):
(WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::setHighlightDataFromConfig):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightFrame):
(WebCore::InspectorDOMAgent::hideHighlight):
* inspector/InspectorDOMAgent.h:
(WebCore):
(WebCore::InspectorDOMAgent::create):
(InspectorDOMAgent):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::didPaint):
* inspector/InspectorPageAgent.h:
(WebCore):
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::create):
(WebCore::PageDebuggerAgent::PageDebuggerAgent):
(WebCore::PageDebuggerAgent::disable):
(WebCore):
(WebCore::PageDebuggerAgent::didPause):
(WebCore::PageDebuggerAgent::didContinue):
* inspector/PageDebuggerAgent.h:
(WebCore):
(PageDebuggerAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium gardening, updated test expectations.
vsevik@chromium.org [Wed, 18 Jul 2012 13:51:45 +0000 (13:51 +0000)]
Unreviewed chromium gardening, updated test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: intern strings when processing timeline records
caseq@chromium.org [Wed, 18 Jul 2012 13:46:22 +0000 (13:46 +0000)]
Web Inspector: intern strings when processing timeline records
https://bugs.webkit.org/show_bug.cgi?id=91531

Reviewed by Pavel Feldman.

- added StringPool that is capable of interning strings;
- used it in TimelineModel to process all incoming records;

* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype.reset):
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse cl to preprocess IDL for Chromium Windows generate_supplemental_dependency
commit-queue@webkit.org [Wed, 18 Jul 2012 13:42:57 +0000 (13:42 +0000)]
Use cl to preprocess IDL for Chromium Windows generate_supplemental_dependency
https://bugs.webkit.org/show_bug.cgi?id=91548

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-18
Reviewed by Kentaro Hara.

Use cl.exe as preprocessor for IDL files rather than cygwin gcc. Cuts
two minute execution time on Windows by a bit better than 50%.

No new tests.

* WebCore.gyp/WebCore.gyp:
* bindings/scripts/preprocessor.pm:
(applyPreprocessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove search replace from behind experiment, polish the behavior
pfeldman@chromium.org [Wed, 18 Jul 2012 13:41:07 +0000 (13:41 +0000)]
Web Inspector: remove search replace from behind experiment, polish the behavior
https://bugs.webkit.org/show_bug.cgi?id=91519

Reviewed by Vsevolod Vlasov.

- This change makes replace loop with no boundary, removes the loop parameter
  from jumpToNext/Previous;
- Lays out replace as a second row
- Fixes replace all with no search matches
- Splits Search and Search and Replace
- Introduces explicit Next / Previous buttons in the search mode
- Introduces editRange on the TextEditor so that it was preserving the undo stack
  (we'll need to fix editor so that it does not require it).

* English.lproj/localizedStrings.js:
* inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype.performSearch):
(WebInspector.ConsolePanel.prototype.jumpToNextSearchResult):
(WebInspector.ConsolePanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel.prototype.performSearch):
(WebInspector.ExtensionPanel.prototype.jumpToNextSearchResult):
(WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkLogView.prototype.jumpToNextSearchResult):
(WebInspector.NetworkPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkPanel.prototype.jumpToNextSearchResult):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.performSearch):
(WebInspector.Panel.prototype.jumpToNextSearchResult):
(WebInspector.Panel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ProfilesPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ResourcesPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ScriptsPanel.prototype.replaceSelectionWith):
(WebInspector.ScriptsPanel.prototype.replaceAllWith):
* inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype.cancelSearch):
(WebInspector.SearchController.prototype.resetSearch):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._updateReplaceVisibility):
(WebInspector.SearchController.prototype._onKeyDown):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):
(WebInspector.SearchController.prototype._updateReplaceDetailsVisibility):
(WebInspector.SearchController.prototype._replace):
(WebInspector.SearchController.prototype._replaceAll):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):
(WebInspector.SourceFrame.prototype.replaceSearchMatchWith):
(WebInspector.SourceFrame.prototype.replaceAllWith):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.beforeTextChanged):
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.editRange):
* inspector/front-end/inspector.css:
(.toolbar-search-replace .search-replace):
(.toolbar-search):
(.toolbar-search-replace):
(.toolbar-search-close-button):
(.toolbar-search-close-button:hover):
(.toolbar-search-close-button:active):
(.toolbar-search input[type="checkbox"]):
(.toolbar-search-replace .toolbar-replace-control):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add WebKitWebView::submit-form signal to WebKit2 GTK+ API
carlosgc@webkit.org [Wed, 18 Jul 2012 13:39:26 +0000 (13:39 +0000)]
[GTK] Add WebKitWebView::submit-form signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=91605

Reviewed by Gustavo Noronha Silva.

The signal is emitted when a form is about to submitted, with a
form submission request that can be used to get the text fields
and to continue the form submission wheh done.

* GNUmakefile.list.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitFormClient.cpp: Added.
(willSubmitForm): Create a WebKitFormSubmissionRequest and call
webkitWebViewSubmitFormRequest() with the request.
(attachFormClientToView): Add impementation for willSubmitForm
callback.
* UIProcess/API/gtk/WebKitFormClient.h: Added.
* UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp: Added.
(webkit_form_submission_request_init):
(webkitFormSubmissionRequestFinalize):
(webkit_form_submission_request_class_init):
(webkitFormSubmissionRequestCreate): Create a new
WebKitFormSubmissionRequest for the given values dictionary and
submission listener.
(webkit_form_submission_request_get_text_fields): Create a
GHashTable with the text fields values and return it.
(webkit_form_submission_request_submit): Continue the form
submission.
* UIProcess/API/gtk/WebKitFormSubmissionRequest.h: Added.
* UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Attach web view to form client.
(webkit_web_view_class_init): Add WebKitWebView::submit-form
signal.
(webkitWebViewSubmitFormRequest): Emit WebKitWebView::submit-form
signal.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/WebKitWebViewPrivate.h:
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
WebKitFormSubmissionRequest.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSubmitForm):
(beforeAll):
* UIProcess/API/gtk/webkit2.h: Include
WebKitFormSubmissionRequest.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] No main resource in WebView when page has been loaded from history cache
carlosgc@webkit.org [Wed, 18 Jul 2012 13:27:12 +0000 (13:27 +0000)]
[GTK] No main resource in WebView when page has been loaded from history cache
https://bugs.webkit.org/show_bug.cgi?id=91478

Reviewed by Gustavo Noronha Silva.

We are assuming that a resource loaded for the main frame that is
provisionally loading is the main resource of the web view. However
that's not true for pages loaded from history cache, so when you
go back/forward webkit_web_view_get_main_resource() always returns
NULL. We can assume that the first resource loaded for the main
frame is the main resource of the web view when
pageIsProvisionallyLoading is false.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewResourceLoadStarted): Make sure we always have a
main resource for the web view.
* UIProcess/API/gtk/tests/TestResources.cpp:
(testWebViewResourcesHistoryCache): Test we always have a main
resource even after going back/forward.
(beforeAll): Add new test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] editing/style and editing/undo tests needs update after rebaseline and new testfonts
kbalazs@webkit.org [Wed, 18 Jul 2012 13:19:21 +0000 (13:19 +0000)]
[Qt] editing/style and editing/undo tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91385

Unreviewed rebaseline.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-18

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/editing/style/4916887-expected.png:
* platform/qt/editing/style/4916887-expected.txt:
* platform/qt/editing/style/5017613-1-expected.png:
* platform/qt/editing/style/5017613-1-expected.txt:
* platform/qt/editing/style/5017613-2-expected.png:
* platform/qt/editing/style/5017613-2-expected.txt:
* platform/qt/editing/style/5046875-1-expected.png:
* platform/qt/editing/style/5046875-1-expected.txt:
* platform/qt/editing/style/5046875-2-expected.png:
* platform/qt/editing/style/5046875-2-expected.txt:
* platform/qt/editing/style/5065910-expected.png:
* platform/qt/editing/style/5065910-expected.txt:
* platform/qt/editing/style/5084241-expected.png:
* platform/qt/editing/style/5084241-expected.txt:
* platform/qt/editing/style/5228141-expected.png:
* platform/qt/editing/style/5228141-expected.txt:
* platform/qt/editing/style/5279521-expected.png:
* platform/qt/editing/style/5279521-expected.txt:
* platform/qt/editing/style/apple-style-editable-mix-expected.png:
* platform/qt/editing/style/apple-style-editable-mix-expected.txt:
* platform/qt/editing/style/block-style-001-expected.png:
* platform/qt/editing/style/block-style-001-expected.txt:
* platform/qt/editing/style/block-style-002-expected.png:
* platform/qt/editing/style/block-style-002-expected.txt:
* platform/qt/editing/style/block-style-003-expected.png:
* platform/qt/editing/style/block-style-003-expected.txt:
* platform/qt/editing/style/block-styles-007-expected.png:
* platform/qt/editing/style/block-styles-007-expected.txt:
* platform/qt/editing/style/create-block-for-style-001-expected.png:
* platform/qt/editing/style/create-block-for-style-001-expected.txt:
* platform/qt/editing/style/create-block-for-style-002-expected.png:
* platform/qt/editing/style/create-block-for-style-002-expected.txt:
* platform/qt/editing/style/create-block-for-style-003-expected.png:
* platform/qt/editing/style/create-block-for-style-003-expected.txt:
* platform/qt/editing/style/create-block-for-style-004-expected.png:
* platform/qt/editing/style/create-block-for-style-004-expected.txt:
* platform/qt/editing/style/create-block-for-style-005-expected.png:
* platform/qt/editing/style/create-block-for-style-005-expected.txt:
* platform/qt/editing/style/create-block-for-style-006-expected.png:
* platform/qt/editing/style/create-block-for-style-006-expected.txt:
* platform/qt/editing/style/create-block-for-style-007-expected.png:
* platform/qt/editing/style/create-block-for-style-007-expected.txt:
* platform/qt/editing/style/create-block-for-style-008-expected.png:
* platform/qt/editing/style/create-block-for-style-008-expected.txt:
* platform/qt/editing/style/create-block-for-style-009-expected.png:
* platform/qt/editing/style/create-block-for-style-009-expected.txt:
* platform/qt/editing/style/create-block-for-style-010-expected.png:
* platform/qt/editing/style/create-block-for-style-010-expected.txt:
* platform/qt/editing/style/create-block-for-style-011-expected.png:
* platform/qt/editing/style/create-block-for-style-011-expected.txt:
* platform/qt/editing/style/create-block-for-style-012-expected.png:
* platform/qt/editing/style/create-block-for-style-012-expected.txt:
* platform/qt/editing/style/create-block-for-style-013-expected.png:
* platform/qt/editing/style/create-block-for-style-013-expected.txt:
* platform/qt/editing/style/designmode-expected.png:
* platform/qt/editing/style/designmode-expected.txt:
* platform/qt/editing/style/font-family-with-space-expected.png:
* platform/qt/editing/style/font-family-with-space-expected.txt:
* platform/qt/editing/style/highlight-expected.png:
* platform/qt/editing/style/highlight-expected.txt:
* platform/qt/editing/style/relative-font-size-change-001-expected.png:
* platform/qt/editing/style/relative-font-size-change-001-expected.txt:
* platform/qt/editing/style/relative-font-size-change-002-expected.png:
* platform/qt/editing/style/relative-font-size-change-002-expected.txt:
* platform/qt/editing/style/relative-font-size-change-003-expected.png:
* platform/qt/editing/style/relative-font-size-change-003-expected.txt:
* platform/qt/editing/style/relative-font-size-change-004-expected.png:
* platform/qt/editing/style/relative-font-size-change-004-expected.txt:
* platform/qt/editing/style/smoosh-styles-001-expected.png:
* platform/qt/editing/style/smoosh-styles-001-expected.txt:
* platform/qt/editing/style/smoosh-styles-003-expected.png:
* platform/qt/editing/style/smoosh-styles-003-expected.txt:
* platform/qt/editing/style/style-3681552-fix-001-expected.png:
* platform/qt/editing/style/style-3681552-fix-001-expected.txt:
* platform/qt/editing/style/style-3681552-fix-002-expected.png:
* platform/qt/editing/style/style-3681552-fix-002-expected.txt:
* platform/qt/editing/style/style-3998892-fix-expected.png:
* platform/qt/editing/style/style-3998892-fix-expected.txt:
* platform/qt/editing/style/style-boundary-001-expected.png:
* platform/qt/editing/style/style-boundary-001-expected.txt:
* platform/qt/editing/style/style-boundary-002-expected.png:
* platform/qt/editing/style/style-boundary-002-expected.txt:
* platform/qt/editing/style/style-boundary-003-expected.png:
* platform/qt/editing/style/style-boundary-003-expected.txt:
* platform/qt/editing/style/style-boundary-004-expected.png:
* platform/qt/editing/style/style-boundary-004-expected.txt:
* platform/qt/editing/style/style-boundary-005-expected.png:
* platform/qt/editing/style/style-boundary-005-expected.txt:
* platform/qt/editing/style/table-selection-expected.png:
* platform/qt/editing/style/table-selection-expected.txt:
* platform/qt/editing/style/typing-style-001-expected.png:
* platform/qt/editing/style/typing-style-001-expected.txt:
* platform/qt/editing/style/typing-style-002-expected.png:
* platform/qt/editing/style/typing-style-002-expected.txt:
* platform/qt/editing/style/unbold-in-bold-expected.png:
* platform/qt/editing/style/unbold-in-bold-expected.txt:
* platform/qt/editing/undo/4063751-expected.png:
* platform/qt/editing/undo/4063751-expected.txt:
* platform/qt/editing/undo/redo-typing-001-expected.png:
* platform/qt/editing/undo/redo-typing-001-expected.txt:
* platform/qt/editing/undo/undo-combined-delete-boundary-expected.png:
* platform/qt/editing/undo/undo-combined-delete-boundary-expected.txt:
* platform/qt/editing/undo/undo-combined-delete-expected.png:
* platform/qt/editing/undo/undo-combined-delete-expected.txt:
* platform/qt/editing/undo/undo-delete-boundary-expected.png:
* platform/qt/editing/undo/undo-delete-boundary-expected.txt:
* platform/qt/editing/undo/undo-delete-expected.png:
* platform/qt/editing/undo/undo-delete-expected.txt:
* platform/qt/editing/undo/undo-forward-delete-boundary-expected.png:
* platform/qt/editing/undo/undo-forward-delete-boundary-expected.txt:
* platform/qt/editing/undo/undo-forward-delete-expected.png:
* platform/qt/editing/undo/undo-forward-delete-expected.txt:
* platform/qt/editing/undo/undo-typing-001-expected.png:
* platform/qt/editing/undo/undo-typing-001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Divide ENABLE(WEBGL) into ENABLE(WEBGL) and USE(3D_GRAPHICS) in CMakeLists.txt
commit-queue@webkit.org [Wed, 18 Jul 2012 13:19:13 +0000 (13:19 +0000)]
[WK2][EFL] Divide ENABLE(WEBGL) into ENABLE(WEBGL) and USE(3D_GRAPHICS) in CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=91584

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-18
Reviewed by Noam Rosenthal.

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
Modified CMakeLists.txt so that the basic 3D-graphics sources can be compiled even when WebGL is disabled.

* CMakeLists.txt:
* PlatformEfl.cmake:
* platform/graphics/GraphicsContext3D.h:
(GraphicsContext3D):
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::platformGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaseline of compositing tests on Qt-WebKit2.
kbalazs@webkit.org [Wed, 18 Jul 2012 13:11:01 +0000 (13:11 +0000)]
Unreviewed rebaseline of compositing tests on Qt-WebKit2.

Mark pixel tests with wrong output as failing (IMAGE) Rebaseline some pixel
results where only scrollbar theme or antialiasing was the difference
between actual and expected.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/compositing/color-matching/image-color-matching-expected.png: Added.
* platform/qt-5.0-wk2/compositing/culling/clear-fixed-iframe-expected.png: Added.
* platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png: Added.
* platform/qt-5.0-wk2/compositing/geometry/fixed-in-composited-expected.png: Added.
* platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.png: Added.
* platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.png: Added.
* platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.png: Added.
* platform/qt-5.0-wk2/compositing/self-painting-layers-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake][EFL] Building jsc causes reconfiguration
commit-queue@webkit.org [Wed, 18 Jul 2012 12:59:23 +0000 (12:59 +0000)]
[CMake][EFL] Building jsc causes reconfiguration
https://bugs.webkit.org/show_bug.cgi?id=91387

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-18
Reviewed by Daniel Bates.

We should remove CMakeCache only when running build-webkit script,
otherwise it will cause a reconfiguration every time someone calls
generateBuildSystemFromCMakeProject(). We were re-building "jsc" and
not running WebKit2 unit tests on the bots because the project was
reconfigured with default values by the scripts that run these tests.

* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(removeCMakeCache):
(generateBuildSystemFromCMakeProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp
commit-queue@webkit.org [Wed, 18 Jul 2012 12:59:21 +0000 (12:59 +0000)]
[EFL] Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=91585

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-18
Reviewed by Andreas Kling.

Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp
since it implements the platform specific methods of WebInspectorProxy.

* PlatformEfl.cmake:
* UIProcess/efl/WebInspectorProxyEfl.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebInspectorEfl.cpp.
(WebKit):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformOpen):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::platformBringToFront):
(WebKit::WebInspectorProxy::platformIsFront):
(WebKit::WebInspectorProxy::platformInspectedURLChanged):
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):
(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium gardening, updated test expectations.
vsevik@chromium.org [Wed, 18 Jul 2012 12:53:02 +0000 (12:53 +0000)]
Unreviewed chromium gardening, updated test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Modify the using of the QImage::Format enum to the appropriate functions from...
zoltan@webkit.org [Wed, 18 Jul 2012 12:50:36 +0000 (12:50 +0000)]
[Qt] Modify the using of the QImage::Format enum to the appropriate functions from NativeImageQt
https://bugs.webkit.org/show_bug.cgi?id=91600

Reviewed by Andreas Kling.

Use NativeImageQt::defaultFormatForAlphaEnabledImages() and NativeImageQt::defaultFormatForOpaqueImages()
instead of the direct imagetypes at the appropriate places.

Source/WebCore:

Covered by existing tests.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::paintToCanvas):
* platform/graphics/qt/PathQt.cpp:
(WebCore::scratchContext):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawRepaintCounter):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::updateContents):

Source/WebKit2:

* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::createQImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
commit-queue@webkit.org [Wed, 18 Jul 2012 12:50:15 +0000 (12:50 +0000)]
[EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
https://bugs.webkit.org/show_bug.cgi?id=87935

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-18
Reviewed by Andreas Kling.

Source/WebKit/efl:

Add implementation of DumpRenderTreeSupportEfl::evaluateInWebInspector().
Some scripts for test should be evaluated in frontend.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateInWebInspector):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Web Inspector will be shown when path or url contains "inspector/".
Dumprendertree should wait util web inspector resources are loaded totally
and handle the signals for creating or removing a view of web inspector.
("inspector,view,create" and "inspector,view,close")

* DumpRenderTree/efl/DumpRenderTree.cpp:
(shouldOpenWebInspector):
(createLayoutTestController):
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::createWebInspectorView):
(DumpRenderTreeChrome::removeWebInspectorView):
(DumpRenderTreeChrome::waitInspectorLoadFinished):
(DumpRenderTreeChrome::onInspectorViewCreate):
(DumpRenderTreeChrome::onInspectorViewClose):
(DumpRenderTreeChrome::onInspectorFrameLoadFinished):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onConsoleMessage):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::showWebInspector):
(LayoutTestController::closeWebInspector):
(LayoutTestController::evaluateInWebInspector):

LayoutTests:

Remove the following tests from Skipped list.
LayoutTests/inspector
LayoutTests/http/test/inspector
LayoutTests/http/test/inspector-enabled
LayoutTests/http/tests/inspector/network/ping.html

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium gardening, unskipped tests.
vsevik@chromium.org [Wed, 18 Jul 2012 12:43:45 +0000 (12:43 +0000)]
Unreviewed chromium gardening, unskipped tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: create timeline detail records lazily
caseq@chromium.org [Wed, 18 Jul 2012 12:38:44 +0000 (12:38 +0000)]
Web Inspector: create timeline detail records lazily
https://bugs.webkit.org/show_bug.cgi?id=91513

Reviewed by Pavel Feldman.

- only create timeline record details when these are used;

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelineRecordListRow.prototype.update):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
(WebInspector.TimelinePresentationModel.Record.prototype._refreshDetails):
(WebInspector.TimelinePresentationModel.Record.prototype.details):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium gardening, unskipped tests.
vsevik@chromium.org [Wed, 18 Jul 2012 12:16:05 +0000 (12:16 +0000)]
Unreviewed chromium gardening, unskipped tests.
https://bugs.webkit.org/show_bug.cgi?id=84764
https://bugs.webkit.org/show_bug.cgi?id=84767
https://bugs.webkit.org/show_bug.cgi?id=84768
https://bugs.webkit.org/show_bug.cgi?id=84769
https://bugs.webkit.org/show_bug.cgi?id=84775
https://bugs.webkit.org/show_bug.cgi?id=84776

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Caching of ShareableSurfaces breaks tiling.
zeno.albisser@nokia.com [Wed, 18 Jul 2012 11:53:47 +0000 (11:53 +0000)]
[Qt][WK2] Caching of ShareableSurfaces breaks tiling.
https://bugs.webkit.org/show_bug.cgi?id=91609

A ShareableSurface should only be cached,
when it is GraphicsSurface based.

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):
* UIProcess/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[ANGLE] On QT, use Bison and Flex during ANGLE build
hausmann@webkit.org [Wed, 18 Jul 2012 11:41:33 +0000 (11:41 +0000)]
[ANGLE] On QT, use Bison and Flex during ANGLE build
https://bugs.webkit.org/show_bug.cgi?id=91108

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add derived source generators for the two angle bison parsers and flex based lexers.

* DerivedSources.pri:
* Target.pri:

Tools:

* qmake/mkspecs/features/default_post.prf: Add support for variable_out to our generators, to allow
generating not only for SOURCES but also ANGLE_SOURCES (in this bug)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122947 268f45cc-cd09-0410-ab3c-d52691b4dbfc