12 years ago<rdar://problem/6150322> In Gmail, a crash occurs at KJS::Machine::privateExecute...
oliver@apple.com [Sun, 17 Aug 2008 23:38:36 +0000 (23:38 +0000)]
<rdar://problem/6150322> In Gmail, a crash occurs at KJS::Machine::privateExecute() when applying list styling to text after a quote had been removed

Reviewed by Cameron Zwarich.

This crash was caused by "depth()" incorrectly determining the scope depth
of a 0 depth function without a full scope chain.  Because such a function
would not have an activation the depth function would return the scope depth
of the parent frame, thus triggering an incorrect unwind.  Any subsequent
look up that walked the scope chain would result in incorrect behaviour,
leading to a crash or incorrect variable resolution.  This can only actually
happen in try...finally statements as that's the only path that can result in
the need to unwind the scope chain, but not force the function to need a
full scope chain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 17 Aug 2008 21:34:46 +0000 (21:34 +0000)]
2008-08-17  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Not reviewed.

        Speculative Qt build fix.

        * bridge/qt/qt_runtime.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 17 Aug 2008 21:27:56 +0000 (21:27 +0000)]
2008-08-17  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej.

        Bug 20419: Remove op_jless

        Remove op_jless, which is rarely used now that we have op_loop_if_less.

        * VM/CodeBlock.cpp:
        * VM/CodeGenerator.cpp:
        * VM/Machine.cpp:
        * VM/Opcode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 17 Aug 2008 21:18:42 +0000 (21:18 +0000)]
2008-08-17  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Dan Bernstein.

        Fix a typo in r35807 that is also causing build failures for
        non-AllInOne builds.

        * kjs/NumberConstructor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptGlue:
ggaren@apple.com [Sun, 17 Aug 2008 20:28:37 +0000 (20:28 +0000)]

2008-08-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Updated project files to XCode 3.1.

        * JavaScriptGlue.xcodeproj/project.pbxproj:


2008-08-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Updated project files to XCode 3.1.

        * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:


2008-08-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Updated project files to XCode 3.1.

        * WebKit.xcodeproj/project.pbxproj:


2008-08-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Updated project files to XCode 3.1.

        * DrawTest/DrawTest.xcodeproj/project.pbxproj:
        * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
ggaren@apple.com [Sun, 17 Aug 2008 20:23:49 +0000 (20:23 +0000)]

2008-08-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Made room for a free word in JSCell.

        SunSpider says no change.

        I changed JSCallbackObjectData, Arguments, JSArray, and RegExpObject to
        store auxiliary data in a secondary structure.

        I changed InternalFunction to store the function's name in the property

        I changed JSGlobalObjectData to use a virtual destructor, so WebCore's
        JSDOMWindowBaseData could inherit from it safely. (It's a strange design
        for JSDOMWindowBase to allocate an object that JSGlobalObject deletes,
        but that's really our only option, given the size constraint.)

        I also added a bunch of compile-time ASSERTs, and removed lots of comments
        in JSObject.h because they were often out of date, and they got in the
        way of reading what was actually going on.

        Also renamed JSArray::getLength to JSArray::length, to match our style


2008-08-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Made room for a free word in JSCell.

        Changed JSDOMWindowBase to store its auxiliary data in a subclass of
        JSGlobalData, so the two could share a pointer.

        Added a bunch of ASSERTs, to help catch over-sized objects.


2008-08-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Made room for a free word in JSCell.

        (Updated for JavaScriptCore changes.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-08-16 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 17 Aug 2008 07:57:39 +0000 (07:57 +0000)]
2007-08-16  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Sped up property access for array.length and string.length by adding a
        mechanism for returning a temporary value directly instead of returning
        a pointer to a function that retrieves the value.

        Also removed some unused cruft from PropertySlot.

        SunSpider says 0.5% - 1.2% faster.

        NOTE: This optimization is not a good idea in general, because it's
        actually a pessimization in the case of resolve for assignment,
        and it may get in the way of other optimizations in the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoffrey Garen.
mitz@apple.com [Sun, 17 Aug 2008 05:06:18 +0000 (05:06 +0000)]
    Reviewed by Geoffrey Garen.

        Disable dead code stripping in debug builds.

        * Configurations/Base.xcconfig:
        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-15 Mark Rowe <mrowe@apple.com>
mitz@apple.com [Sun, 17 Aug 2008 03:28:52 +0000 (03:28 +0000)]
2008-08-15  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        Disable dead code stripping in debug builds.

        * Configurations/Base.xcconfig:
        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6143072> FastMallocZone's enumeration code makes assumptions about...
mrowe@apple.com [Sat, 16 Aug 2008 06:53:44 +0000 (06:53 +0000)]
<rdar://problem/6143072> FastMallocZone's enumeration code makes assumptions about handling of remote memory regions that overlap

Reviewed by Oliver Hunt.

* wtf/FastMalloc.cpp:
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects): Don't directly compare pointers mapped into the local process with
a pointer that has not been mapped.  Instead, calculate a local address for the pointer and compare with that.
(WTF::TCMallocStats::FreeObjectFinder::findFreeObjects): Pass in the remote address of the central free list so that it can
be used when calculating local addresses.
(WTF::TCMallocStats::FastMallocZone::enumerate): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
mrowe@apple.com [Sat, 16 Aug 2008 06:48:10 +0000 (06:48 +0000)]
<rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework

Rubber-stamped by Geoff Garen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-15 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 15 Aug 2008 22:58:06 +0000 (22:58 +0000)]
2008-08-15  Antti Koivisto  <antti@apple.com>

        Reviewed by Anders.

        Don't start preloading body resources before the head is complete. This prevents
        body preloads from slowing down initial display when there is limited amount
        of bandwidth available.

        Works by queuing up found body preloads to DocLoader and only issuing them
        after document has rendering.

        With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
        without affecting complete load time.

        * html/PreloadScanner.cpp:
        * html/PreloadScanner.h:
        * loader/DocLoader.cpp:
        * loader/DocLoader.h:
        * loader/loader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Use item's computed style if the render style is 0 before falling back to...
adachan@apple.com [Fri, 15 Aug 2008 21:08:40 +0000 (21:08 +0000)]
    Use item's computed style if the render style is 0 before falling back to the <select>'s style.
        This way style set on an <hr> within a <select> will be honored.

        Reviewed by Dave Hyatt and Dan Bernstein.

        * rendering/RenderMenuList.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-15 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 15 Aug 2008 20:48:06 +0000 (20:48 +0000)]
2008-08-15  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver.

        Some loader performance tweaks:
        - Make stylesheets highest priority instead of scripts. We block script execution on stylesheets.
          Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue
          to not delay rendering.
        - Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup
          can take long time when latency is high so it is good to get started early.
        - When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the
          load queues. Issue remaining loads to the network layer.

        * loader/loader.cpp:
        * loader/loader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Detach the script debugger when the Web Inspector's window closes.
timothy@apple.com [Fri, 15 Aug 2008 18:35:39 +0000 (18:35 +0000)]
    Detach the script debugger when the Web Inspector's window closes.
        This has always been the intended design, but never fully implemented.


        Reviewed by Adam Roben.

        * page/InspectorController.cpp:
        (WebCore::InspectorController::setWindowVisible): Call stopDebugging()
        if the window is no longer visible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Tim Hatcher.
mitz@apple.com [Fri, 15 Aug 2008 18:27:12 +0000 (18:27 +0000)]
    Rubber-stamped by Tim Hatcher.

        - update results for console.dir

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-15 Håvard Wall <hwall@trolltech.com>
hausmann@webkit.org [Fri, 15 Aug 2008 18:12:55 +0000 (18:12 +0000)]
2008-08-15  Håvard Wall  <hwall@trolltech.com>

        Reviewed by Simon.

        Fixes: compile with QT_NO_UNDOCOMMAND/STACK

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-15 Håvard Wall <hwall@trolltech.com>
hausmann@webkit.org [Fri, 15 Aug 2008 18:12:34 +0000 (18:12 +0000)]
2008-08-15  Håvard Wall  <hwall@trolltech.com>

        Reviewed by Simon.

        Fixes: compile with QT_NO_STYLE_STYLESHEET

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHåvard Wall <hwall@trolltech.com>
hausmann@webkit.org [Fri, 15 Aug 2008 18:12:21 +0000 (18:12 +0000)]
Håvard Wall <hwall@trolltech.com>

Fixes: compile with QT_NO_SHORTCUT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-15 Håvard Wall <hwall@trolltech.com>
hausmann@webkit.org [Fri, 15 Aug 2008 18:12:08 +0000 (18:12 +0000)]
2008-08-15  Håvard Wall  <hwall@trolltech.com>

        Reviewed by Simon.

        Fixes:    compile with QT_NO_CONTEXTMENU

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-15 Håvard Wall <hwall@trolltech.com>
hausmann@webkit.org [Fri, 15 Aug 2008 18:11:34 +0000 (18:11 +0000)]
2008-08-15  Håvard Wall  <hwall@trolltech.com>

        Reviewed by Simon.

        Fixes: compile with QT_NO_WHEELEVENT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHåvard Wall <hwall@trolltech.com>
hausmann@webkit.org [Fri, 15 Aug 2008 18:11:11 +0000 (18:11 +0000)]
Håvard Wall <hwall@trolltech.com>

Fixes: compile with QT_NO_PRINTER

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-15 David Boddie <dboddie@trolltech.com>
hausmann@webkit.org [Fri, 15 Aug 2008 18:10:57 +0000 (18:10 +0000)]
2008-08-15  David Boddie  <dboddie@trolltech.com>

        Reviewed by Simon.

        Doc: Added documentation for default property values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDavid Boddie <dboddie@trolltech.com>
hausmann@webkit.org [Fri, 15 Aug 2008 18:10:42 +0000 (18:10 +0000)]
David Boddie <dboddie@trolltech.com>

Doc: Renamed snippets that appear in the code directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixed Bug 20210: Console groups are incorrect when closing and reopening...
timothy@apple.com [Fri, 15 Aug 2008 17:48:36 +0000 (17:48 +0000)]
    Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector


        Reviewed by Tim Hatcher.

        * page/Console.cpp:
        * page/Console.h:
        (WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel.
        * page/InspectorController.cpp:
        (WebCore::InspectorController::startGroup): Increments group level by
        one and adds console message with StartGroupMessaageLevel.
        (WebCore::InspectorController::endGroup): Decrements group level by one
        and adds console message with EndGroupMessaageLevel.
        * page/InspectorController.h:
        * page/inspector/Console.js:
        (WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup
        if the message is StartGroupMessaageLevel.
        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Adds support for console.dir to the Inspector
timothy@apple.com [Fri, 15 Aug 2008 17:35:22 +0000 (17:35 +0000)]
    Adds support for console.dir to the Inspector


        Reviewed by Tim Hatcher.

        * bindings/js/JSConsoleCustom.cpp:
        * page/Console.cpp:
        * page/Console.h: Added ObjectMessageLevel.
        * page/Console.idl: Added console.dir.
        * page/inspector/Console.js:
        (WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an
        ObjectPropertiesSection if the MessageLevel is Object.
        * page/inspector/ObjectPropertiesSection.js: "in" operator can't be
        used on primitive data types.
        * page/inspector/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Adds support for clear() in the Inspector console.
timothy@apple.com [Fri, 15 Aug 2008 17:06:14 +0000 (17:06 +0000)]
    Adds support for clear() in the Inspector console.


        Reviewed by Tim Hatcher.

        * page/inspector/Console.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.
timothy@apple.com [Fri, 15 Aug 2008 17:02:44 +0000 (17:02 +0000)]
    Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.

        Platform distinction and modifier key matching adjusted
        by Daniel Jalkut <jalkut@red-sweater.com>

        Bug 16313: text search (find) keybindings should work in the Web Inspector

        Reviewed by Tim Hatcher.

        * page/inspector/inspector.js: Added a case for the F key

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix for error when the string doesn't contain a webkit-profile link.
timothy@apple.com [Fri, 15 Aug 2008 16:50:26 +0000 (16:50 +0000)]
    Fix for error when the string doesn't contain a webkit-profile link.


        Reviewed by Tim Hatcher.

        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixes two bugs where JavaScript could be executed from the page
timothy@apple.com [Fri, 15 Aug 2008 16:33:27 +0000 (16:33 +0000)]
    Fixes two bugs where JavaScript could be executed from the page
        while the debugger is paused.

        The first issue was JSLazyEventListener not checking the paused
        state before parsing the code.

        The second issue was with the PageGroup version of
        JavaScriptDebugServer::setJavaScriptPaused always passing false
        to the Page version of JavaScriptDebugServer::setJavaScriptPaused,
        and not the paused argument.


        Reviewed by Adam Roben.

        * bindings/js/JSEventListener.cpp:
        (WebCore::JSLazyEventListener::parseCode): Check the paused
        state of the ScriptController. Return early if paused.
        * manual-tests/inspector/debugger-execution-while-paused.html: Added.
        * page/JavaScriptDebugServer.cpp:
        Pass the paused argument to the Page version of setJavaScriptPaused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the 64-bit build.
mrowe@apple.com [Fri, 15 Aug 2008 14:55:46 +0000 (14:55 +0000)]
Fix the 64-bit build.

Add extra cast to avoid warnings about loss of precision when casting from
JSValue* to an integer type.

* kjs/JSImmediate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Still fixing Windows build.
ap@webkit.org [Fri, 15 Aug 2008 11:59:39 +0000 (11:59 +0000)]
    Still fixing Windows build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Added OpaqueJSString
        to yet another place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows build fix
barraclough@apple.com [Fri, 15 Aug 2008 11:41:18 +0000 (11:41 +0000)]
Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Trying to fix non-Apple builds.
ap@webkit.org [Fri, 15 Aug 2008 11:14:17 +0000 (11:14 +0000)]
    Trying to fix non-Apple builds.

        * ForwardingHeaders/JavaScriptCore/OpaqueJSString.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-15 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 15 Aug 2008 10:42:26 +0000 (10:42 +0000)]
2008-08-15  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Allow JSImmediate to hold 31 bit signed integer immediate values.  The low two bits of a
        JSValue* are a tag, with the tag value 00 indicating the JSValue* is a pointer to a
        JSCell.  Non-zero tag values used to indicate that the JSValue* is not a real pointer,
        but instead holds an immediate value encoded within the pointer.  This patch changes the
        encoding so both the tag values 01 and 11 indicate the value is a signed integer, allowing
        a 31 bit value to be stored.  All other immediates are tagged with the value 10, and
        distinguished by a secondary tag.

        Roughly +2% on SunSpider.

        * kjs/JSImmediate.h: Encoding of JSImmediates has changed - see comment at head of file for
                             descption of new layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago More build fixes.
ap@webkit.org [Fri, 15 Aug 2008 10:18:06 +0000 (10:18 +0000)]
    More build fixes.

        * API/OpaqueJSString.h: Add a namespace to friend declaration to appease MSVC.
        * API/JSStringRefCF.h: (JSStringCreateWithCFString) Cast UniChar* to UChar* explicitly.
        * JavaScriptCore.exp: Added OpaqueJSString::create(const KJS::UString&) to fix WebCore build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
ap@webkit.org [Fri, 15 Aug 2008 08:32:01 +0000 (08:32 +0000)]
    Build fix.

        * JavaScriptCore.xcodeproj/project.pbxproj: Marked OpaqueJSString as private

        * kjs/identifier.cpp:
        * kjs/identifier.h:
        Since checkSameIdentifierTable is exported for debug build's sake, gcc wants it to be
        non-inline in release builds, too.

        * JavaScriptCore.exp: Don't export inline OpaqueJSString destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff Garen.
ap@webkit.org [Fri, 15 Aug 2008 07:43:48 +0000 (07:43 +0000)]
    Reviewed by Geoff Garen.

        JSStringRef is created context-free, but can get linked to one via an identifier table,
        breaking an implicit API contract.

        Made JSStringRef point to OpaqueJSString, which is a new string object separate from UString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Update cache capacities to match values used on Mac.
sfalken@apple.com [Fri, 15 Aug 2008 06:15:14 +0000 (06:15 +0000)]
    Update cache capacities to match values used on Mac.

        Reviewed by Dan Bernstein.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with...
kevino@webkit.org [Fri, 15 Aug 2008 05:10:57 +0000 (05:10 +0000)]
wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with an alternative that performs reasonably well. (GDI+ is too slow in many cases.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-14 Eric Carlson <eric.carlson@apple.com>
adele@apple.com [Fri, 15 Aug 2008 00:53:36 +0000 (00:53 +0000)]
2008-08-14  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=20388
        <video> elements on Windows never becomes visible when a page is restored from the cache

        Always pass "set" calls down to MediaPlayerPrivate instead of only when the
        value is different from the cached value. Let the implementation decide when
        to avoid work because nothing has changed.

        * platform/graphics/MediaPlayer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-14 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 15 Aug 2008 00:44:42 +0000 (00:44 +0000)]
2008-08-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Jon Honeycutt.

        Add WebView SPI to set HTMLTokenizer yielding parameters.

        * Interfaces/IWebViewPrivate.idl:
        * WebView.cpp:
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd the bug URL to the ChangeLog.
timothy@apple.com [Thu, 14 Aug 2008 23:58:19 +0000 (23:58 +0000)]
Add the bug URL to the ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make Firebug command line API respect predefined variables.
timothy@apple.com [Thu, 14 Aug 2008 23:57:14 +0000 (23:57 +0000)]
    Make Firebug command line API respect predefined variables.

        Reviewed by Tim Hatcher.

        * page/inspector/Console.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 14 Aug 2008 23:45:33 +0000 (23:45 +0000)]
2008-08-14  Simon Fraser  <simon.fraser@apple.com>

        Fix testcase and add pixel results for testcase in

        * platform/mac/fast/css/font-face-in-media-rule-expected.checksum: Added.
        * platform/mac/fast/css/font-face-in-media-rule-expected.png: Added.
        * platform/mac/fast/css/font-face-in-media-rule-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Thu, 14 Aug 2008 23:33:22 +0000 (23:33 +0000)]

2008-08-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen and Timothy Hatcher.

        Allow programatically setting the HTMLTokenizers time delay and chunk size
        which are used for determining how aggressively we yield.

        * WebCore.base.exp:
        * html/HTMLTokenizer.cpp:
        * html/HTMLTokenizer.h:
        * page/Page.cpp:
        * page/Page.h:


2008-08-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen and Timothy Hatcher.

        Add WebView SPI to set HTMLTokenizer yielding parameters.

        * WebView/WebView.mm:
        (-[WebView _setCustomHTMLTokenizerTimeDelay:]):
        (-[WebView _setCustomHTMLTokenizerChunkSize:]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Beth.
eric@webkit.org [Thu, 14 Aug 2008 23:20:00 +0000 (23:20 +0000)]
    Reviewed by Beth.

        Move us one step closer to cross-platform svg/graphics code

        * WebCore.xcodeproj/project.pbxproj:
        * html/CanvasStyle.cpp:
        * platform/graphics/Color.cpp:
        * platform/graphics/Color.h:
        * svg/graphics/cg/CgSupport.cpp:
        * svg/graphics/cg/SVGPaintServerSolidCg.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Alexey.
eric@webkit.org [Thu, 14 Aug 2008 23:19:44 +0000 (23:19 +0000)]
    Reviewed by Alexey.

        Remove un-need includes from HTMLCanvas and use the
        Gradient platform abstraction in one place in CanvasStyle

        * html/CanvasRenderingContext2D.cpp:
        * html/CanvasStyle.cpp:
        * html/HTMLCanvasElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Alexey.
eric@webkit.org [Thu, 14 Aug 2008 23:19:31 +0000 (23:19 +0000)]
    Reviewed by Alexey.

        Clean up GlyphBuffer.h, removing more #ifdefs

        * platform/graphics/GlyphBuffer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam.
eric@webkit.org [Thu, 14 Aug 2008 23:19:17 +0000 (23:19 +0000)]
    Reviewed by Sam.

        Clean up AffineTransform.h, removing #ifdefs

        * platform/graphics/AffineTransform.h:
        * platform/graphics/cairo/AffineTransformCairo.cpp:
        * platform/graphics/cg/AffineTransformCG.cpp:
        * platform/graphics/qt/AffineTransformQt.cpp:
        * platform/graphics/wx/AffineTransformWx.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-14 Dan Bernstein <mitz@apple.com>
mitz@apple.com [Thu, 14 Aug 2008 23:12:34 +0000 (23:12 +0000)]
2008-08-14  Dan Bernstein  <mitz@apple.com>

        - fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size().

        * platform/graphics/cairo/ImageSourceCairo.cpp:
        * platform/graphics/qt/ImageSourceQt.cpp:
        * platform/graphics/wx/ImageSourceWx.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-14 Dan Bernstein <mitz@apple.com>
mitz@apple.com [Thu, 14 Aug 2008 23:08:09 +0000 (23:08 +0000)]
2008-08-14  Dan Bernstein  <mitz@apple.com>

        Reviewed by Brady Eidson.

        - fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped

        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::BitmapImage): Added initialization of
        (WebCore::BitmapImage::cacheFrame): Added code to get the size of the
        cached frame for use in decoded size computation and for setting
        (WebCore::BitmapImage::currentFrameSize): Added.
        (WebCore::BitmapImage::dataChanged): Added code to reset
        * platform/graphics/BitmapImage.h: Added currentFrameSize() and
        * platform/graphics/ImageSource.h: Added frameSizeAtIndex().
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This
        fixes the bug, which resulted from assuming that the frame being drawn
        was the same size as the first frame.
        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and
        changed to get the size of the frame at the given index.
        (WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 14 Aug 2008 23:04:41 +0000 (23:04 +0000)]
2008-08-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel

        Fix @font-face inside @media rule crash.

        Test: fast/css/font-face-in-media-rule.html

        * css/CSSStyleSelector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fixes after recent changes to Canvas and Image classes.
kevino@webkit.org [Thu, 14 Aug 2008 22:52:55 +0000 (22:52 +0000)]
wx build fixes after recent changes to Canvas and Image classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-14 Maxime Britto <britto@apple.com>
britto@apple.com [Thu, 14 Aug 2008 19:26:02 +0000 (19:26 +0000)]
2008-08-14  Maxime Britto  <britto@apple.com>

        Reviewed by Sam Weinig.

        When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored
        IE and FF are both preventing the keyboard event to interact with the page while scrolling.
        Some differences exist between them concerning the kind of key which is pressed :
        IE7 : every key leads to a stop of the panning
        FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive.
        For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGtk+/ Cairo build fix, patch by Dirk Schulze.
christian@webkit.org [Thu, 14 Aug 2008 19:14:47 +0000 (19:14 +0000)]
Gtk+/ Cairo build fix, patch by Dirk Schulze.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
kmccullough@apple.com [Thu, 14 Aug 2008 18:11:20 +0000 (18:11 +0000)]

2008-08-14  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/6115819> Notify of profile in console
        - Profiles now have a unique ID so that they can be linked to the
        console message that announces that a profile completed.

        * profiler/HeavyProfile.cpp:
        * profiler/Profile.cpp:
        * profiler/Profile.h:
        * profiler/ProfileGenerator.cpp:
        * profiler/ProfileGenerator.h:
        * profiler/Profiler.cpp:
        * profiler/TreeProfile.cpp:
        * profiler/TreeProfile.h:


2008-08-14  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/6115819> Notify of profile in console

        * page/InspectorController.cpp:
        (WebCore::InspectorController::addProfileMessageToConsole): Called by
        addProfile this is the function that adds a message to the console that
        a profile finished.
        * page/InspectorController.h:
        * page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match
        the console log to the profile in the web inspector.
        * page/inspector/ProfilesPanel.js: Created a map of all the profiles by
        Id to bring up the requested profile.  Also select and reveal the
        profile in the profile panel.  And created displayTitleForProfileLink()
        which formats a title taking into account if it's user initiated or if
        there are multiples. Lasty, I put the user initiated profile in a
        * page/inspector/inspector.js: Make the profile title be a clickable
        link that will take the user to the identified profile.  Also expose
        the count of user initiated profiles so they can be displayed in the
        console with the correct count.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Avoid formating ConsoleMessages twice unless the message will be
timothy@apple.com [Thu, 14 Aug 2008 17:41:05 +0000 (17:41 +0000)]
    Avoid formating ConsoleMessages twice unless the message will be
        displayed in bubbles of a SourceFrame.

        Reviewed by Kevin McCullough.

        * page/inspector/Console.js:
        (WebInspector.ConsoleMessage): Only format the plain text message
        if the URL and line are valid and the level is error or warning.
        (WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added.
        Helper to test for error or warning level.
        * page/inspector/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.addMessage): Don't add the
        message if there is no message or valid line or if the msg
        isn't an error or warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixes a bug where Safari's find banner would be permanently hidden
timothy@apple.com [Thu, 14 Aug 2008 16:12:43 +0000 (16:12 +0000)]
    Fixes a bug where Safari's find banner would be permanently hidden
        when attaching or closing the Web Inspector while attached.


        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController close]):
        Carefully manipulate the WebFrameView's frame when closing to
        not assume the WebFrameView's frame fills the inspected WebView.
        (-[WebInspectorWindowController setAttachedWindowHeight:]):
        Carefully manipulate the WebFrameView's frame when docking to
        not assume the WebFrameView plus the Web Inspector WebViews fills
        the full inspected WebView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Thu, 14 Aug 2008 15:07:41 +0000 (15:07 +0000)]
2008-08-14  Jan Michael Alonzo  <jmalonzo@webkit.org>

        partial Gtk build fix, not reviewed

        * platform/graphics/cairo/PatternCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-13 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 14 Aug 2008 04:49:30 +0000 (04:49 +0000)]
2008-08-13  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlson.

        Fix style issue.

        * html/HTMLMediaElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-13 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Thu, 14 Aug 2008 04:26:18 +0000 (04:26 +0000)]
2008-08-13  Stephanie Lewis  <slewis@apple.com>

        fix 64bit build

        * WebCoreSupport/WebInspectorClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-08-13 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 14 Aug 2008 03:43:57 +0000 (03:43 +0000)]
2007-08-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Nixed a PIC branch from JSObject::getOwnPropertySlot, by forcing
        fillGetterProperty, which references a global function pointer,

        .2% SunSpider speedup, 4.3% access-nbody speedup, 8.7% speedup on a
        custom property access benchmark for objects with one property.

        * kjs/JSObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning.
mrowe@apple.com [Thu, 14 Aug 2008 03:16:01 +0000 (03:16 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for Cairo, not reviewed. (exposed by gtk build slave)
zimmermann@webkit.org [Thu, 14 Aug 2008 03:06:01 +0000 (03:06 +0000)]
Build fix for Cairo, not reviewed. (exposed by gtk build slave)
Continue Erics build fixes, after the Image cleanup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for Qt, not reviewed.
zimmermann@webkit.org [Thu, 14 Aug 2008 02:38:16 +0000 (02:38 +0000)]
Build fix for Qt, not reviewed.
Don't declare eventuallyMarkAsParserCreated in a block wrapped by !USE_QXMLSTREAM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix, not reviewed.
zimmermann@webkit.org [Thu, 14 Aug 2008 02:26:00 +0000 (02:26 +0000)]
Build fix, not reviewed.
Add ScriptElement.cpp to Gtk build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Eric.
zimmermann@webkit.org [Thu, 14 Aug 2008 02:22:35 +0000 (02:22 +0000)]
Reviewed by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372

Refactor HTMLScriptElement's code into a common base class: ScriptElement.
SVGScriptElement will be converted to use ScriptElement in a follow-up patch.

This resolves code duplications and allows us to completly replace the old
SVGScriptElement (which doesn't use CachedScript, no dynamic injected scripts etc..)

As ScriptElement, doesn't actually inherit from Element, we may want to rename
it, though StyleElement uses the same naming convention, so I left it as is for now.
Eventually we'll rename both files in future.

No functional changes yet, as SVGScriptElement doesn't yet use the new base class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Attempt to fix the Gtk build, no review.
eric@webkit.org [Thu, 14 Aug 2008 02:17:29 +0000 (02:17 +0000)]
    Attempt to fix the Gtk build, no review.

        I removed the bogus GraphicsContext::translatePoint() hack for Gtk in the process.

        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/qt/GradientQt.cpp:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        * platform/gtk/RenderThemeGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Attempt to fix the windows build, not review.
eric@webkit.org [Thu, 14 Aug 2008 02:06:29 +0000 (02:06 +0000)]
    Attempt to fix the windows build, not review.

        * WebIconDatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Attempt to fix the Windows build, no review.
eric@webkit.org [Thu, 14 Aug 2008 02:03:09 +0000 (02:03 +0000)]
    Attempt to fix the Windows build, no review.

        * platform/win/CursorWin.cpp:
        * platform/win/ScrollViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Attempt to fix the Windows build, no review.
eric@webkit.org [Thu, 14 Aug 2008 01:29:34 +0000 (01:29 +0000)]
    Attempt to fix the Windows build, no review.

        * platform/win/CursorWin.cpp:
        * platform/win/ScrollViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Attempt to fix the Qt build, no review.
eric@webkit.org [Thu, 14 Aug 2008 01:24:15 +0000 (01:24 +0000)]
    Attempt to fix the Qt build, no review.

        * platform/graphics/qt/ImageBufferQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Attempt to fix the Windows build, no review.
eric@webkit.org [Thu, 14 Aug 2008 01:21:34 +0000 (01:21 +0000)]
    Attempt to fix the Windows build, no review.

        * platform/graphics/win/ImageWin.cpp:
        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Another attempt to fix the Qt build, no review.
eric@webkit.org [Thu, 14 Aug 2008 01:15:50 +0000 (01:15 +0000)]
    Another attempt to fix the Qt build, no review.

        * platform/graphics/qt/ImageQt.cpp:
        * platform/graphics/qt/StillImageQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago No review, build fix only.
eric@webkit.org [Thu, 14 Aug 2008 01:05:42 +0000 (01:05 +0000)]
    No review, build fix only.

        Fix mac build, due to change in new code since my patch was written.

        * svg/graphics/cg/SVGResourceMaskerCg.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix only, no review.
eric@webkit.org [Thu, 14 Aug 2008 00:59:20 +0000 (00:59 +0000)]
    Build fix only, no review.

        Attempt to fix the Qt build.

        * platform/graphics/qt/ImageBufferQt.cpp:
        * platform/graphics/qt/StillImageQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix only, no review.
eric@webkit.org [Thu, 14 Aug 2008 00:42:54 +0000 (00:42 +0000)]
    Build fix only, no review.

        Attempt to fix the Qt build.

        * html/CanvasStyle.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam.
eric@webkit.org [Thu, 14 Aug 2008 00:30:04 +0000 (00:30 +0000)]
    Reviewed by Sam.

        Match HTML5 spec by throwing INVALID_STATE_ERR when
        createPattern is called and the HTMLImageElement is not
        yet done loading the image (!isComplete)

        Test: http/misc/canvas-pattern-from-incremental-image.html

        * html/CanvasRenderingContext2D.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Niko.
eric@webkit.org [Thu, 14 Aug 2008 00:29:50 +0000 (00:29 +0000)]
    Reviewed by Niko.

        Split out a Pattern class from CanvasPattern
        and remove all the Pattern-related #ifdefs
        (This will break non-mac platforms!  I will fix them.)

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * html/CanvasPattern.cpp:
        * html/CanvasPattern.h:
        * html/CanvasRenderingContext2D.cpp:
        * html/CanvasRenderingContext2D.h:
        * html/HTMLCanvasElement.cpp:
        * html/HTMLCanvasElement.h:
        * loader/FrameLoader.cpp:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/cg/GraphicsContextCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Niko.
eric@webkit.org [Thu, 14 Aug 2008 00:29:26 +0000 (00:29 +0000)]
    Reviewed by Niko.

        Make Images RefCounted (and clean up callers)

        * editing/DeleteButtonController.cpp:
        * loader/CachedImage.cpp:
        * loader/CachedImage.h:
        * loader/icon/IconRecord.cpp:
        * loader/icon/IconRecord.h:
        * platform/graphics/BitmapImage.h:
        * platform/graphics/GeneratedImage.h:
        * platform/graphics/Gradient.cpp:
        * platform/graphics/Gradient.h:
        * platform/graphics/Image.cpp:
        * platform/graphics/Image.h:
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        * platform/graphics/cg/ImageBufferCG.cpp:
        * platform/graphics/cg/PDFDocumentImage.h:
        * platform/graphics/gtk/ImageGtk.cpp:
        * platform/graphics/mac/ImageMac.mm:
        * rendering/RenderImage.cpp:
        * rendering/RenderLayer.cpp:
        * svg/graphics/SVGImage.cpp:
        * svg/graphics/SVGImage.h:
        * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
        * svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
        * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
        * svg/graphics/cg/SVGResourceMaskerCg.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam.
eric@webkit.org [Thu, 14 Aug 2008 00:28:51 +0000 (00:28 +0000)]
    Reviewed by Sam.

        Remove #ifdefs from CanvasStyle by using platform/Color.h

        There are some down-sides to this commit.
        This commit limits us to 255 levels of grey for calls like:
        context.setStrokeStyle(.37, 1.0)
        previously CG might have used up to 32bits to store the grey level
        Since setStrokeStyle is not part of HTML5, I don't suspect the web will notice.

        Likewise, setStrokeStyle/setFillStyle calls which used float colors are now limited
        to RGBA32 (like all the rest of colors in WebCore), thus:
        context.setStrokStyle(.37, .24, .456, .99) will now have the same precision as:
        context.strokeStyle = "rgba(.37, .24, .456, .99)", which is to say RGBA32

        If this is a problem for Dashboard, we can either roll out this commit
        or add a beefier Color abstraction, which can be used internally by GraphicsContext
        when keeping state, and then GraphicsContext can grow some additional set* routines
        for setting the a grey/float/whatever fill and stroke.

        * html/CanvasRenderingContext2D.cpp:
        * html/CanvasStyle.cpp:
        * html/CanvasStyle.h:
        * platform/graphics/Color.cpp:
        * platform/graphics/Color.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
adele@apple.com [Wed, 13 Aug 2008 23:50:41 +0000 (23:50 +0000)]

2008-08-13  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele Peterson.

        Fix for <rdar://problem/6137931>
        Remove all parameters from the MIME type before checking with the MIME type registry

        Tests: media/video-source-type-params.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::pickMedia): only pass the portion before the first ';'
        to isSupportedMediaMIMEType()


2008-08-13  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele Peterson.

        Add test case for parameters on a <source> element 'type' attribute.

        * media/video-source-type-params-expected.txt: Added.
        * media/video-source-type-params.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-13 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Wed, 13 Aug 2008 21:36:15 +0000 (21:36 +0000)]
2008-08-13  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        Fix for <rdar://problem/6141345>

        This patch refines findString and markAllMatchesForText functions'
        interactions with disconnected frames. They no longer rely on
        knowing where a range is relative to the visible region and work
        with disconnected frames that contain frames.

        * editing/Editor.cpp:
        (WebCore::Editor::insideVisibleArea): Now returns a bool instead of
        the visiblity enum.
        (WebCore::Editor::firstVisibleRange): This now returns the very
        first visible range in the document. It's no longer dependent on
        searching forward.
        (WebCore::Editor::lastVisibleRange): This now returns the very last
        visible range in the document. It's no longer dependent on
        searching backwards.
        (WebCore::Editor::nextVisibleRange): This returns the next visible
        range in the appropriate direction from the current range.
        * editing/Editor.h:
        * page/Frame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix for case-sensitive platforms, like Linux.
kevino@webkit.org [Wed, 13 Aug 2008 20:07:16 +0000 (20:07 +0000)]
wx build fix for case-sensitive platforms, like Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-13 Alp Toker <alp@nuanti.com>
jmalonzo@webkit.org [Wed, 13 Aug 2008 20:00:51 +0000 (20:00 +0000)]
2008-08-13  Alp Toker  <alp@nuanti.com>

        Reviewed by Eric Seidel.

        WTF::initializeThreading() fails if threading is already initialized

        Fix threading initialization logic to support cases where
        g_thread_init() has already been called elsewhere.

        Resolves database-related crashers reported in several applications.

        * wtf/ThreadingGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-13 Marco Barisione <marco.barisione@collabora.co.uk>
jmalonzo@webkit.org [Wed, 13 Aug 2008 19:56:20 +0000 (19:56 +0000)]
2008-08-13  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Holger Freyther.

        [GTK] PlatformScreenGtk is unimplemented

        Original patch by Christian Dywan.

        * platform/gtk/PlatformScreenGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-13 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 13 Aug 2008 19:42:08 +0000 (19:42 +0000)]
2008-08-13  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add

        g_idle_add is the same as g_idle_add_full with a priority of
        G_PRIORITY_DEFAULT_IDLE, so we can safely use that.

        * platform/gtk/SharedTimerGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Implemented DOMHTMLElement::idName() and WebFrame::frameElement().
adachan@apple.com [Wed, 13 Aug 2008 19:03:27 +0000 (19:03 +0000)]
    Implemented DOMHTMLElement::idName() and WebFrame::frameElement().
        Added IWebFrame::paintDocumentRectToContext() so we can paint a frame's
        content into a device context.  Changed WebView::paintDocumentRectToContext()
        to call that WebFrame method.

        Reviewed by Adam Roben.

        * DOMHTMLClasses.cpp:
        * Interfaces/IWebFramePrivate.idl:
        * WebFrame.cpp:
        * WebFrame.h:
        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemember the docked state of the Web Inspector, so it can be reopened docked if it...
timothy@apple.com [Wed, 13 Aug 2008 18:11:01 +0000 (18:11 +0000)]
Remember the docked state of the Web Inspector, so it can be reopened docked if it was last docked.


2008-08-13  Timothy Hatcher  <timothy@apple.com>

        Changed the InspectorController so it can be notified when the
        attached state of the Inspector changes in WebKit.

        Reviewed by Kevin McCullough.

        * WebCore.base.exp: Updated the symbol for setWindowVisible.
        * page/InspectorController.cpp:
        (WebCore::InspectorController::setWindowVisible): Added an attached argument,
        that defaults to false.Call setAttachedWindow with the attached argument.
        (WebCore::InspectorController::setAttachedWindow): Call the script version
        of setAttachedWindow.
        * page/InspectorController.h:
        * page/inspector/inspector.js:
        (WebInspector.setAttachedWindow): Set the attached property.


2008-08-13  Timothy Hatcher  <timothy@apple.com>

        Remember the docked state of the Web Inspector, so it can be
        reopened docked if it was last docked.


        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController init]): Initialize _shouldAttach
        to the value stored in the user defaults. If there has never
        been a value stored, default to being attached.
        (-[WebInspectorWindowController showWindow:]): Pass the attached
        state to InspectorController::setWindowVisible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Remove the Inspector's WebView for the view hierarchy when closed
timothy@apple.com [Wed, 13 Aug 2008 18:10:53 +0000 (18:10 +0000)]
    Remove the Inspector's WebView for the view hierarchy when closed
        while attached. This prevents it from showing in the background
        while the page changes.

        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController close:]): Call removeFromSuperview
        on the Inspector's WebView if it isn't attached, so it will not
        be visible when navigating pages while closed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added a close button to the Inspector's toolbar when docked.
timothy@apple.com [Wed, 13 Aug 2008 18:10:45 +0000 (18:10 +0000)]
    Added a close button to the Inspector's toolbar when docked.


        Reviewed by Kevin McCullough.

        * page/InspectorController.cpp:
        (WebCore::closeWindow): Call InspectorController::closeWindow.
        Added closeWindow to the script class.
        * page/InspectorController.h:
        * page/inspector/Images/closeButtons.png: Added.
        * page/inspector/inspector.css: Added and changed styles.
        * page/inspector/inspector.html: Added the close button.
        * page/inspector/inspector.js:
        (WebInspector.loaded): Added click event listener to the close button.
        (WebInspector.close): Call InspectorController.closeWindow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake the docked Web Inspector resizable.
timothy@apple.com [Wed, 13 Aug 2008 18:10:36 +0000 (18:10 +0000)]
Make the docked Web Inspector resizable.


2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Make the docked Web Inspector resizable. This is the cross platform
        portion of the code. Each InspectorClient needs to implement the
        real resize code.


        Reviewed by Kevin McCullough.

        * loader/EmptyClients.h: Added an empty setAttachedWindowHeight.
        * page/InspectorClient.h: Added setAttachedWindowHeight.
        * page/InspectorController.cpp:
        (WebCore::setAttachedWindowHeight): Call setAttachedWindowHeight
        on the InspectorController.
        (WebCore::InspectorController::setAttachedWindowHeight): Call
        setAttachedWindowHeight on the client.
        Added setAttachedWindowHeight to the script class.
        * page/InspectorController.h:
        * page/inspector/inspector.css: Make the cursor on the toolbar be
        row-resize when docked.
        * page/inspector/inspector.js:
        (WebInspector.loaded): Always add the toolbarDragStart event listener.
        (WebInspector.toolbarDragStart): Return early if we are not attached
        and not on Leopard. Call WebInspector.elementDragStart.
        (WebInspector.toolbarDragEnd): Call WebInspector.elementDragEnd.
        (WebInspector.toolbarDrag): When attached call setAttachedWindowHeight,
        otherwise call moveByUnrestricted.


2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Add a stub for InspectorClient::setAttachedWindowHeight.

        * WebCoreSupport/InspectorClientGtk.cpp:
        Call notImplemented().
        * WebCoreSupport/InspectorClientGtk.h:


2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Make the docked Web Inspector resizable.


        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.h:
        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::setAttachedWindowHeight): Call setAttachedWindowHeight:
        on the WebInspectorWindowController.
        (-[WebInspectorWindowController showWindow:]): Call setAttachedWindowHeight:.
        (-[WebInspectorWindowController setAttachedWindowHeight:]): Moved code
        from showWindow: and generalized to allow being called multiple times.
        Remembers the last height passed, which is used by showWindow: the next
        time the Inspector attaches.


2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Add a stub for InspectorClient::setAttachedWindowHeight.

        * WebCoreSupport/InspectorClientQt.cpp:
        Call notImplemented().
        * WebCoreSupport/InspectorClientQt.h:


2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Add a stub for InspectorClient::setAttachedWindowHeight.

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::setAttachedWindowHeight): Add a FIXME to implement this.
        * WebCoreSupport/WebInspectorClient.h:


2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Add a stub for InspectorClient::setAttachedWindowHeight.

        * WebKitSupport/InspectorClientWx.cpp:
        Call notImplemented().
        * WebKitSupport/InspectorClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 13 Aug 2008 14:32:16 +0000 (14:32 +0000)]
2008-08-13  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Use full-page zoom in QtLauncher.

        * QtLauncher/main.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 13 Aug 2008 14:32:02 +0000 (14:32 +0000)]
2008-08-13  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Fix linking with QtWebKit.

        * Api/qwebframe.h: remove non-existing function/property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hausmann@webkit.org [Wed, 13 Aug 2008 13:43:34 +0000 (13:43 +0000)]

    2008-08-13  Simon Hausmann  <hausmann@webkit.org>

            Reviewed by Holger.

            Initialize m_zoomsTextOnly in the Settings constructor.


    2008-08-13  Simon Hausmann  <hausmann@webkit.org>

            Reviewed by Holger.

            Based on patch by Siraj razick <siraj.razick@collabora.co.uk>


            Added functions to get/set the zoom factor.

            Added a QWebFrame/QWebView::zoomFactor as well as a boolean
            ZoomTextOnly attribute in QWebSettings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Removing http/tests/xmlhttprequest/readystatechange.html from Windows skipped...
ap@webkit.org [Wed, 13 Aug 2008 13:33:03 +0000 (13:33 +0000)]
    Removing http/tests/xmlhttprequest/readystatechange.html from Windows skipped list -
        this test hasn't been failing locally for a long time.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-13 Brad Hughes <bhughes@trolltech.com>
hausmann@webkit.org [Wed, 13 Aug 2008 13:31:11 +0000 (13:31 +0000)]
2008-08-13  Brad Hughes <bhughes@trolltech.com>

        Reviewed by Simon.

        Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux

        The latest upgrade of the intel compiler allows us to compile all of
        Qt with optimizations enabled (yay!).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-13 Prasanth Ullattil <prasanth.ullattil@trolltech.com>
hausmann@webkit.org [Wed, 13 Aug 2008 13:24:56 +0000 (13:24 +0000)]
2008-08-13  Prasanth Ullattil  <prasanth.ullattil@trolltech.com>

        Reviewed by Simon.

        Fix QtWebKit not displaying content on 403 HTTP responses

        Just like with 404 responses also display content with 403, as
        used by http://audiio.ejamming.proteus-tech.com/audiio/profile/original_signup/

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hausmann@webkit.org [Wed, 13 Aug 2008 13:16:15 +0000 (13:16 +0000)]

    2008-08-13  Simon Hausmann  <hausmann@webkit.org>

            Reviewed by Holger.

            Qt part of https://bugs.webkit.org/show_bug.cgi?id=18994

            Make the formatting of String::format() locale independent through the use of QString::vsprintf.


    2008-08-13  Simon Hausmann  <hausmann@webkit.org>

            Reviewed by Holger.

            Adjusted the length-list-parser layout test to compensate for the subtle difference of
            dropping a sign for a "negative zero" as a result of the QString::vsprintf use.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35712 268f45cc-cd09-0410-ab3c-d52691b4dbfc