WebKit-https.git
12 years ago Fixed an ASSERT(m_actualSelfTime <= m_actualTotalTime) when starting
timothy@apple.com [Sat, 21 Jun 2008 04:39:23 +0000 (04:39 +0000)]
    Fixed an ASSERT(m_actualSelfTime <= m_actualTotalTime) when starting
        and stopping a profile from the Develop menu. Also prevents
        inserting an incorrect parent node as the new head after profiling
        is stopped from the Develop menu.

        Reviewed by Dan Bernstein.

        * profiler/Profile.cpp:
        (KJS::Profile::stopProfiling): If the current node is already the head
        then there is no more need to record future nodes in didExecute.
        (KJS::Profile::didExecute): Move the code of setupCurrentNodeAsStopped
        into here since this was the only caller. When setting the total time
        keep any current total time while adding the self time of the head.
        (KJS::Profile::setupCurrentNodeAsStopped): Removed.
        * profiler/Profile.h: Removed setupCurrentNodeAsStopped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-20 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 21 Jun 2008 01:22:37 +0000 (01:22 +0000)]
2008-06-20  Sam Weinig  <sam@webkit.org>

        Fix Windows build.

        * bindings/scripts/CodeGeneratorCOM.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 20 Jun 2008 22:59:15 +0000 (22:59 +0000)]
2008-06-20  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix: Add files missing in the previous fix (r34705)

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
mitz@apple.com [Fri, 20 Jun 2008 22:29:20 +0000 (22:29 +0000)]
    Reviewed by Sam Weinig.

        - fix leak of mask images

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::arenaDelete): Added a call to removeClient() on
        the mask box image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-20 Brent Fulgham <bfulgham@gmail.com>
pewtermoose@webkit.org [Fri, 20 Jun 2008 22:27:26 +0000 (22:27 +0000)]
2008-06-20  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Darin.

        Extend the build-webkit (and set-webkit-configuration) script to
        support Cairo-based webkit builds.  (see http://bugs.webkit.org/show_bug.cgi?17952)

        * Scripts/build-webkit:  Add --cairo-win32 to the help message
        * Scripts/webkitdirs.pm:  Extend the 'determinePassedConfiguration
          subroutine to recognize the --cairo-win32 flag.  When present,
          the build configuration is changed from Debug/Release to
          Debug_Cairo/Release_Cairo.  This flag is only active when the
          isCygwin() test is true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 20 Jun 2008 22:23:39 +0000 (22:23 +0000)]
2008-06-20  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix for r34702, r34700 and r34693
        Qt build fix for r34700 and r34693

        * GNUmakefile.am:
        * WebCore.pro:
        * platform/gtk/RenderThemeGtk.cpp:
        * platform/gtk/RenderThemeGtk.h:
        * platform/qt/RenderThemeQt.cpp:
        * platform/qt/RenderThemeQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago!USE(MULTIPLE_THREADS) on Darwin build fix
kevino@webkit.org [Fri, 20 Jun 2008 22:14:12 +0000 (22:14 +0000)]
!USE(MULTIPLE_THREADS) on Darwin build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-20 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 20 Jun 2008 21:51:31 +0000 (21:51 +0000)]
2008-06-20  Kevin McCullough  <kmccullough@apple.com>

        -Leopard Build Fix.

        * profiler/Profile.cpp:
        (KJS::Profile::removeProfileStart):
        (KJS::Profile::removeProfileEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-20 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 20 Jun 2008 21:43:11 +0000 (21:43 +0000)]
2008-06-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Adele Peterson.

        Add 'files' property to the HTMLInputElement, which returns a FileList object
        (when type=file, null otherwise) containing a list of all the files selected.
        It currently always contains only 0 or 1 files as multifile input is not supported
        yet.  The list contains File objects which contains the name and size of the file.
        The inspiration for these interfaces is from:
            - http://developer.mozilla.org/en/docs/nsIDOMFileList
            - http://developer.mozilla.org/en/docs/nsIDOMFile

        Also fixes <rdar://problem/6022802>

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/objc/DOMInternal.h:
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/IDLStructure.pm:
        * html/File.cpp: Added.
        (WebCore::File::File):
        (WebCore::File::fileSize):
        * html/File.h: Added.
        (WebCore::File::create):
        (WebCore::File::fileName):
        (WebCore::File::path):
        * html/File.idl: Added.
        * html/FileList.cpp: Added.
        (WebCore::FileList::FileList):
        (WebCore::FileList::item):
        * html/FileList.h: Added.
        (WebCore::FileList::create):
        (WebCore::FileList::length):
        (WebCore::FileList::isEmpty):
        (WebCore::FileList::clear):
        (WebCore::FileList::append):
        * html/FileList.idl: Added.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType):
        (WebCore::HTMLInputElement::appendFormData):
        (WebCore::HTMLInputElement::value):
        (WebCore::HTMLInputElement::setValue):
        (WebCore::HTMLInputElement::setValueFromRenderer):
        (WebCore::HTMLInputElement::files):
        * html/HTMLInputElement.h:
        * html/HTMLInputElement.idl:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Fri, 20 Jun 2008 21:19:46 +0000 (21:19 +0000)]
WebCore:

2008-06-20  David Hyatt  <hyatt@apple.com>

        Make sure CSS variables work inside the inline style attribute.

        Reviewed by Beth

        Added fast/css/variables/inline-style-test.html

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::removeProperty):
        (WebCore::CSSMutableStyleDeclaration::addParsedProperties):

LayoutTests:

2008-06-20  David Hyatt  <hyatt@apple.com>

        Make sure CSS variables work inside the inline style attribute.

        Reviewed by Beth

        * fast/css/variables/inline-style-test.html: Added.
        * platform/mac/fast/css/variables/inline-style-test-expected.checksum: Added.
        * platform/mac/fast/css/variables/inline-style-test-expected.png: Added.
        * platform/mac/fast/css/variables/inline-style-test-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Fri, 20 Jun 2008 20:47:33 +0000 (20:47 +0000)]
WebCore:

2008-06-20  David Hyatt  <hyatt@apple.com>

        Add support for the CSSVariablesRule and CSSVariablesDeclaration DOM APIs.  These allow querying of
        variables names and values, as well as iteration, setting and removal.

        Reviewed by Sam

        Added multiple new tests to fast/css/variables/

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSCSSRuleCustom.cpp:
        (WebCore::toJS):
        * bindings/objc/DOMInternal.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::parserValue):
        * css/CSSVariablesDeclaration.cpp:
        (WebCore::CSSVariablesDeclaration::removeVariable):
        (WebCore::CSSVariablesDeclaration::setVariable):
        (WebCore::CSSVariablesDeclaration::setCssText):
        (WebCore::CSSVariablesDeclaration::setChanged):
        * css/CSSVariablesDeclaration.h:
        * css/CSSVariablesDeclaration.idl: Added.
        * css/CSSVariablesRule.h:
        * css/CSSVariablesRule.idl: Added.

LayoutTests:

2008-06-20  David Hyatt  <hyatt@apple.com>

        Add tests of the DOM APIs for addition, removal and iteration.

        Reviewed by Sam

        * fast/css/variables/remove-variable-test.html: Added.
        * fast/css/variables/set-variable-test.html: Added.
        * fast/css/variables/variable-iteration-test.html: Added.
        * platform/mac/fast/css/variables/remove-variable-test-expected.checksum: Added.
        * platform/mac/fast/css/variables/remove-variable-test-expected.png: Added.
        * platform/mac/fast/css/variables/remove-variable-test-expected.txt: Added.
        * platform/mac/fast/css/variables/set-variable-test-expected.checksum: Added.
        * platform/mac/fast/css/variables/set-variable-test-expected.png: Added.
        * platform/mac/fast/css/variables/set-variable-test-expected.txt: Added.
        * platform/mac/fast/css/variables/variable-iteration-test-expected.checksum: Added.
        * platform/mac/fast/css/variables/variable-iteration-test-expected.png: Added.
        * platform/mac/fast/css/variables/variable-iteration-test-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-20 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 20 Jun 2008 20:47:02 +0000 (20:47 +0000)]
2008-06-20  Kevin McCullough  <kmccullough@apple.com>

        Just giving credit.

        * ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-20 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 20 Jun 2008 19:47:27 +0000 (19:47 +0000)]
2008-06-20  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/6024846> JSProfiler: ASSERT hit in Profiler.
        - Because InspectorController can call startProfiling() and
        stopProfiling() we cannot assert that console.profile() and
        console.profileEnd() will be in the profile tree.

        * profiler/Profile.cpp:
        (KJS::Profile::removeProfileStart):
        (KJS::Profile::removeProfileEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-20 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 20 Jun 2008 19:38:15 +0000 (19:38 +0000)]
2008-06-20  Kevin McCullough  <kmccullough@apple.com>

        Rubber stamped by Adele.

        * manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
kmccullough@apple.com [Fri, 20 Jun 2008 19:36:10 +0000 (19:36 +0000)]
JavaScriptCore:

2008-06-20  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/5958770> JSProfiler: Time incorrectly given to (idle)
        if profiling is started and finished within the same function. (19230)
        - Now we profile one more stack frame up from the last frame to allocate
        the time spent in it, if it exists.

        * JavaScriptCore.exp:
        * VM/Machine.cpp: We need to let the profiler know when the JS program
        has finished since that is what will actually stop the profiler instead
        of just calling stopProfiling().
        (KJS::Machine::execute):
        * profiler/Profile.cpp:
        (KJS::Profile::create): Moved from Profile.h since it was getting pretty
        long.
        (KJS::Profile::Profile): We now have a client, which is a listener who
        we will return this profile to, once it has actually finished.
        (KJS::Profile::stopProfiling): Instead of fully stopping the profiler
        here, we set the flag and keep it profiling in the background.
        (KJS::Profile::didFinishAllExecution): This is where the profiler
        actually finishes and creates the (idle) node if one should be made.
        (KJS::Profile::removeProfileStart): Don't use m_currentNode since it is
        needed by the profiler as it runs silently in the background.
        (KJS::Profile::removeProfileEnd): Ditto.
        (KJS::Profile::willExecute): Don't profile new functions if we have
        stopped profiling.
        (KJS::Profile::didExecute): Only record one more return as all the
        remaining time will be attributed to that function.
        (KJS::Profile::setupCurrentNodeAsStopped): Sets the current node's time.
        * profiler/Profile.h: Added functions and variables for the above
        changes.
        (KJS::Profile::client):
        * profiler/ProfileNode.h:
        (KJS::CallIdentifier::toString): Debug method.
        * profiler/Profiler.cpp: Added support for the ProfilerClient.
        (KJS::Profiler::startProfiling):
        (KJS::Profiler::stopProfiling): No longer return sthe profile.
        (KJS::Profiler::didFinishAllExecution): Now returns the profile to the
        client instead of stopProfiling.
        * profiler/Profiler.h:
        (KJS::ProfilerClient::~ProfilerClient): Clients will implement this
        interface.

WebCore:

2008-06-20  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/5958770> JSProfiler: Time incorrectly given to (idle)
        if profiling is started and finished within the same function. (19230)
        - Now we profile one more stack frame up from the last frame to allocate
        the time spent in it, if it exists.

        * page/Console.cpp:
        * manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html: Added.
        (WebCore::Console::profile): When stating the profiler give a client for
        the callback of when the profile actually finishes.
        (WebCore::Console::profileEnd): No longer needs to handle the return of
        the profile object since it will be retruned in the client's callback.
        (WebCore::Console::finishedProfiling): Implemenet the ProfileClient
        callback method.
        * page/Console.h: Inherit from the ProfileClient.
        * page/InspectorController.cpp:
        (WebCore::InspectorController::startUserInitiatedProfiling): Use the
        client callback.
        (WebCore::InspectorController::stopUserInitiatedProfiling): Does not
        need to handle the profile being returned as it is now handled by the
        client callback.
        (WebCore::InspectorController::finishedProfiling): Implement the
        ProfileClient callback method.
        * page/InspectorController.h: Inherit from the ProfileClient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Makes the JavaScript syntax highlighter process lines in chunks
timothy@apple.com [Fri, 20 Jun 2008 19:26:52 +0000 (19:26 +0000)]
    Makes the JavaScript syntax highlighter process lines in chunks
        so the user interface isn't blocked for large script files.

        https://bugs.webkit.org/show_bug.cgi?id=19677

        Reviewed by Adam Roben.

        * page/inspector/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._addMessageToSource): Use the cells
        property on the row instead of getElementsByTagName.
        (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): Use the
        cells property on the row instead of getElementsByTagName. Added
        a nested processChunk function that highlights 10 lines at a time
        This processChunk function is called at an interval of 25ms. The
        code is still highlighted quickly, and the user can't tell it wasn't
        highlighted all at once.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixes a bug where the source view in the Resources panel had a
timothy@apple.com [Fri, 20 Jun 2008 19:26:42 +0000 (19:26 +0000)]
    Fixes a bug where the source view in the Resources panel had a
        couple of extra pixels at the bottom when fully scrolled.

        Reviewed by Adam Roben.

        * page/inspector/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.set autoSizesToFitContentHeight):
        Call removeStyleClass instead of addStyleClass for "webkit-height-sized-to-fit"
        when sizing to fit is being disabled.
        * page/inspector/inspector.css:
        (.resource-view.headers-visible .source-view-frame): Added the
        vertical-align: top property to prevent line alignment from adding extra
        pixels on the bottom.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes: Bug 19679: iframes with a height of 32,768px or greater do not layout correctly
timothy@apple.com [Fri, 20 Jun 2008 19:26:31 +0000 (19:26 +0000)]
Fixes: Bug 19679: iframes with a height of 32,768px or greater do not layout correctly

WebCore:

2008-06-19  Timothy Hatcher  <timothy@apple.com>

        Changed all lineHeight, baselinePosition and verticalPositionHint
        calls to return int instead of short. The short was overflowing
        when a value greater than 32,767 was encountered.

        Fixes: iframes with a height of 32,768px or greater do not layout correctly
        https://bugs.webkit.org/show_bug.cgi?id=19679

        Reviewed by Dave Hyatt.

        Test: fast/css/line-height-overflow.html

        * rendering/RenderBR.cpp:
        (WebCore::RenderBR::baselinePosition):
        * rendering/RenderBR.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::lineHeight):
        * rendering/RenderBlock.h:
        * rendering/RenderFlow.cpp:
        * rendering/RenderFlow.h:
        * rendering/RenderListBox.cpp:
        * rendering/RenderListBox.h:
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::lineHeight):
        * rendering/RenderListMarker.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::verticalPositionHint):
        * rendering/RenderObject.h:
        (WebCore::):
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::lineHeight):
        * rendering/RenderPath.h:
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::lineHeight):
        * rendering/RenderReplaced.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::lineHeight):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGHiddenContainer.cpp:
        (WebCore::RenderSVGHiddenContainer::lineHeight):
        * rendering/RenderSVGHiddenContainer.h:
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::lineHeight):
        * rendering/RenderSVGRoot.h:
        * rendering/RenderSlider.cpp:
        * rendering/RenderSlider.h:
        * rendering/RenderTableCell.cpp:
        * rendering/RenderTableCell.h:
        * rendering/RenderTableCol.h:
        * rendering/RenderTableRow.h:
        * rendering/RenderTableSection.h:
        * rendering/RenderText.cpp:
        * rendering/RenderText.h:
        * rendering/RenderTextControl.cpp:
        * rendering/RenderTextControl.h:
        * rendering/RenderTheme.cpp:
        * rendering/RenderTheme.h:
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        * rendering/RenderThemeSafari.cpp:
        * rendering/RenderThemeSafari.h:

LayoutTests:

2008-06-19  Timothy Hatcher  <timothy@apple.com>

        Test for: iframes with a height of 32,768px or greater do not layout correctly
        https://bugs.webkit.org/show_bug.cgi?id=19679

        Reviewed by Dave Hyatt.

        * fast/css/line-height-overflow.html: Added.
        * platform/mac/fast/css/line-height-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Fri, 20 Jun 2008 19:19:18 +0000 (19:19 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19519
          <rdar://problem/6007345> DOM modification causes stack exhaustion (BUTTON OBJECT COLGROUP)

        Test: fast/table/prepend-in-anonymous-table.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addChildToFlow): Added code to handle the case
        of inserting before a child that has been wrapped by an anonymous table,
        in which case if the new child is the type that needs to be in a table,
        it is inserted into the table, and otherwise it is inserted before the
        table.
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::addChild): Added table-column-group alongside
        table-caption as content that can exist inside an anonymous table
        without being wrapped in a table section.

LayoutTests:

        Reviewed by Darin Adler.

        - test for https://bugs.webkit.org/show_bug.cgi?id=19519
          <rdar://problem/6007345> DOM modification causes stack exhaustion (BUTTON OBJECT COLGROUP)

        * fast/table/prepend-in-anonymous-table.html: Added.
        * platform/mac/fast/table/prepend-in-anonymous-table-expected.checksum: Added.
        * platform/mac/fast/table/prepend-in-anonymous-table-expected.png: Added.
        * platform/mac/fast/table/prepend-in-anonymous-table-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Fri, 20 Jun 2008 18:36:19 +0000 (18:36 +0000)]
WebCore:

2008-06-20  David Hyatt  <hyatt@apple.com>

        Allow CSS variables to support arbitrary expressions as values instead of just a single term.

        Reviewed by Sam

        Removed fast/css/variables/single-term-test.html and replaced with multiple-term-test.html

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::addVariable):
        * css/CSSParser.h:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::addMatchedDeclaration):
        * css/CSSVariablesDeclaration.cpp:
        (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration):
        (WebCore::CSSVariablesDeclaration::getVariableValue):
        (WebCore::CSSVariablesDeclaration::addParsedVariable):
        (WebCore::CSSVariablesDeclaration::getParsedVariable):
        * css/CSSVariablesDeclaration.h:
        (WebCore::CSSVariablesDeclaration::create):

LayoutTests:

2008-06-20  David Hyatt  <hyatt@apple.com>

        Allow CSS variables to support arbitrary expressions as values instead of just a single term.

        Reviewed by Sam

        * fast/css/variables/single-term-test.html: Removed.
        * fast/css/variables/multiple-term-test.html: Added.
        * platform/mac/fast/css/variables/multiple-term-test-expected.checksum: Added.
        * platform/mac/fast/css/variables/multiple-term-test-expected.png: Added.
        * platform/mac/fast/css/variables/multiple-term-test-expected.txt: Added.
        * platform/mac/fast/css/variables/single-term-test-expected.checksum: Removed.
        * platform/mac/fast/css/variables/single-term-test-expected.png: Removed.
        * platform/mac/fast/css/variables/single-term-test-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-20 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 20 Jun 2008 17:17:06 +0000 (17:17 +0000)]
2008-06-20  Darin Adler  <darin@apple.com>

        - updated results for some recent changes

        * fast/dom/Window/window-properties-expected.txt: Updated results to reflect the
        new rule type, VARIABLES_RULE (Hyatt's CSS variables patch).

        * fast/forms/plaintext-mode-1-expected.txt: Updated test and results to expect
        ForeColor to be disabled when the region is plain-text-only. Justin's execCommand
        patch for https://bugs.webkit.org/show_bug.cgi?id=16049.
        * fast/forms/plaintext-mode-1.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 20 Jun 2008 15:22:15 +0000 (15:22 +0000)]
2008-06-19  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Surpress compiler warning (int vs unsigned comparison).

        * wtf/unicode/qt4/UnicodeQt4.h:
        (WTF::Unicode::toLower):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-20 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk>
hausmann@webkit.org [Fri, 20 Jun 2008 10:03:44 +0000 (10:03 +0000)]
2008-06-20  Marc Ordinas i Llopis  <marc.ordinasillopis@collabora.co.uk>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=19082
        [Qt] Full-page plugins not activated

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-20 Marco Barisione <marco.barisione@collabora.co.uk>
hausmann@webkit.org [Fri, 20 Jun 2008 10:03:30 +0000 (10:03 +0000)]
2008-06-20  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=19082
        [Qt] Full-page plugins not activated

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 20 Jun 2008 09:06:11 +0000 (09:06 +0000)]
2008-06-19  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Timothy Hatcher.

        Introduce compiler define for MinGW, to have COMPILER(MINGW).

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
mitz@apple.com [Fri, 20 Jun 2008 05:43:16 +0000 (05:43 +0000)]
    Reviewed by Sam Weinig.

        - two more updated results for the last patch

        * platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
        * platform/mac/fast/invalid/020-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff.
ap@webkit.org [Fri, 20 Jun 2008 03:30:09 +0000 (03:30 +0000)]
    Reviewed by Geoff.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Fri, 20 Jun 2008 02:53:12 +0000 (02:53 +0000)]
WebCore:

        Reviewed by John Sullivan.

        - fix a bug where anonymous tables were inserted in the wrong place

        Tests: tables/mozilla/bugs/bug2479-2.html
               tables/mozilla/bugs/bug278266.html
               tables/mozilla/bugs/bug8411.xml

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::addChild): Changed to create an anonymous
        table and insert it before beforeChild unless the insertion point is
        right after an existing anonymous table, in which case the existing
        table is used.

LayoutTests:

        Reviewed by John Sullivan.

        - updated tests and results after fixing a bug where anonymous tables were inserted in the wrong place

        * fast/forms/form-hides-table.html: Wrapped every case in a block in
        order to prevent cross-talk.
        * platform/mac/fast/forms/form-hides-table-expected.checksum:
        * platform/mac/fast/forms/form-hides-table-expected.png:
        * platform/mac/fast/forms/form-hides-table-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum: Added.
        * platform/mac/tables/mozilla/bugs/bug2479-2-expected.png: Added.
        * platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
        * platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug278266-expected.checksum: Added.
        * platform/mac/tables/mozilla/bugs/bug278266-expected.png: Added.
        * platform/mac/tables/mozilla/bugs/bug278266-expected.txt: Added.
        * platform/mac/tables/mozilla/bugs/bug8411-expected.checksum: Added.
        * platform/mac/tables/mozilla/bugs/bug8411-expected.png: Added.
        * platform/mac/tables/mozilla/bugs/bug8411-expected.txt: Added.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-2-expected.checksum: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-2-expected.png: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug278266-expected.checksum: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug278266-expected.png: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug278266-expected.txt: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug8411-expected.checksum: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug8411-expected.png: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug8411-expected.txt: Removed.
        * platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
        * tables/mozilla/bugs/bug2479-2.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug2479-2.html.
        * tables/mozilla/bugs/bug278266.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug278266.html.
        * tables/mozilla/bugs/bug8411.xml: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug8411.xml.
        * tables/mozilla_expected_failures/bugs/bug2479-2.html: Removed.
        * tables/mozilla_expected_failures/bugs/bug278266.html: Removed.
        * tables/mozilla_expected_failures/bugs/bug8411.xml: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Fri, 20 Jun 2008 01:19:23 +0000 (01:19 +0000)]
WebCore:

2008-06-19  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver.

        <https://bugs.webkit.org/show_bug.cgi?id=16049>
        execCommand('backColor') fails on collapsed selections

        * editing/EditorCommand.cpp:
        (WebCore::CommandEntry::): Enable BackColor for caret selections, and
        disable ForeColor in plaintext-only regions.

LayoutTests:

2008-06-19  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver.

        <https://bugs.webkit.org/show_bug.cgi?id=16049>
        execCommand('backColor') fails on collapsed selections

        * editing/execCommand/16049-expected.txt: Added.
        * editing/execCommand/16049.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Fri, 20 Jun 2008 00:24:13 +0000 (00:24 +0000)]
WebCore:

2008-06-19  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <https://bugs.webkit.org/show_bug.cgi?id=19653>
        Typing style lost when creating list from, indenting or outdenting an empty paragraph

        There were two problems.  First, moveParagraphs didn't preserve the style of empty paragraphs.
        Second, indent, outdent and list creation returned false from preservesTypingStyle.
        The second problem couldn't be fixed by just adding preservesTypingStyle() { return true; }
        to those commands, though, because of other bugs.

        Cleaned up the implementation of typing style enough to remove FIXMEs for:

        <rdar://problem/3769899> Implementation of typing style needs improvement

        which has actually been closed for some time now anyway.

        * dom/Document.cpp: Removed an unused header.
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs): Preserve the style of an empty paragraph, too.
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::saveTypingStyleState): Removed FIXME.
        (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
        Removed FIXME.
        If there is a typing style to apply after a delete, apply it to any line break that acts as a paragraph
        placeholder, not only one that was inserted by deletion.  This fixes a bug where deleting
        <div><b>Bold</b><br></div>, changing the selection and then coming back and typing wouldn't
        produce bold text.
        Don't set the EditCommand's typingStyle, it has been removed (more on that later).
        (WebCore::DeleteSelectionCommand::doApply): We don't need to pass calculateTypingStyleAfterDelete
        the inserted placeholder because it will find it.
        (WebCore::DeleteSelectionCommand::preservesTypingStyle): Normally deletion doesn't preserve the
        typing style that was present before it.  For example, type a character, Bold, then delete the
        character and start typing.  The Bold typing style shouldn't stick around.  We got this right before
        purely by chance. Deletion should preserve a typing style that *it* sets, however.
        * editing/DeleteSelectionCommand.h: No longer need to pass calculateTypingStyleAfterDelete
        the inserted placeholder.
        * editing/EditCommand.cpp:
        (WebCore::EditCommand::apply):
        Clearing or not clearing a removed anchor should not be determined by whether or not a command
        preservesTypingStyle().  For example, the deletion that removed an anchor (and stored it), may
        not preserve the typing style, but that doesn't mean that it should then go and clear the removed
        anchor.  All high level commands, and all commands that a TypingCommand spawns, except for
        text insertions, which should restore a removed anchor, should clear it.
        There is no longer a typing style on EditCommand, removed code that cleared it.  Code that clears the
        *actual* typing style is now in Editor::appliedEditing, just like before.
        There is no longer a typing style on EditCommand, removed code to set one.
        (WebCore::EditCommand::styleAtPosition): Removed FIXME.
        * editing/EditCommand.h:
        Removed code assosiated with m_typingStyle.
        Made preservesTypingStyle() public, so that we can call it from Editor::appliedEditing().
        * editing/Editor.cpp:
        (WebCore::Editor::appliedEditing):
        Removed code to preserve the removedAnchor during the call to setSelection, because we no longer
        request to clear the typing style with that call.  Also removed the FIXME about this.
        Before, a command would set the Frame's typing style by setting its own typingStyle, and then
        letting code here, in appliedEditing pick that up and set it on the Frame.  Now, the command
        itself sets the Frame's typing style.  Deletion is the only command that does this right now.
        * editing/IndentOutdentCommand.h:
        (WebCore::IndentOutdentCommand::preservesTypingStyle): Added, returns true.
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply): Removed FIXME.
        * editing/InsertListCommand.h:
        (WebCore::InsertListCommand::preservesTypingStyle): Added.
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Removed FIXME.
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input): Removed FIXME.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Removed FIXME and also added one about clearing
        the typing style here.  It seems like it's something that could wait until after the command
        has been performed, since there is no code between this point and the end of the operation
        that queries or uses the typing style.

LayoutTests:

2008-06-19  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        https://bugs.webkit.org/show_bug.cgi?id=19653
        Typing style lost when creating list from, indenting or outdenting an empty paragraph

        These demonstrate fixes:
        * editing/execCommand/19653-1-expected.txt: Added.
        * editing/execCommand/19653-1.html: Added.
        * editing/execCommand/19653-2-expected.txt: Added.
        * editing/execCommand/19653-2.html: Added.
        * editing/execCommand/19653-3-expected.txt: Added.
        * editing/execCommand/19653-3.html: Added.
        * editing/execCommand/19653-4-expected.txt: Added.
        * editing/execCommand/19653-4.html: Added.
        Changed to an equivalent but more bloated DOM because of a pre-existing bug in ApplyStyleCommand:
        * platform/mac/editing/deleting/delete-br-011-expected.txt:
        Fixed a bug where the typing style wasn't applied to the placeholder in an empty paragraph,
        so typing would create text with the right style, but if you were to change the selection
        and then come back and start typing, the style would be wrong.  The size of the caret was
        also wrong as a result:
        * platform/mac/editing/deleting/delete-br-012-expected.txt:
        * platform/mac/editing/deleting/delete-br-012-expected.png:
        * platform/mac/editing/deleting/delete-br-012-expected.checksum:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-19 Dan Bernstein <mitz@apple.com>
mitz@apple.com [Fri, 20 Jun 2008 00:09:19 +0000 (00:09 +0000)]
2008-06-19  Dan Bernstein  <mitz@apple.com>

        Reviewed by Alexey Proskuryakov.

        - fix crash in CSSStyleDeclaration::copyPropertiesInSet()

        Covered by many editing tests

        * css/CSSStyleDeclaration.cpp:
        (WebCore::CSSStyleDeclaration::copyPropertiesInSet): Re-ordered to avoid
        null pointer deref.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-19 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 20 Jun 2008 00:06:28 +0000 (00:06 +0000)]
2008-06-19  David Hyatt  <hyatt@apple.com>

        Fix out of bounds bug in CSSVariablesDeclaration's item() method.

        Reviewed by Sam, Darin

        * css/CSSVariablesDeclaration.cpp:
        (WebCore::CSSVariablesDeclaration::item):
        * css/CSSVariablesDeclaration.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-19 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Thu, 19 Jun 2008 23:42:26 +0000 (23:42 +0000)]
2008-06-19  John Sullivan  <sullivan@apple.com>

        Reviewed by Darin

        Tweak to previous checkin

        * page/FrameView.cpp:
        (WebCore::FrameView::performPostLayoutTasks):
        clear m_firstLayoutCallbackPending before performing callback, to avoid recursion

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-19 Alp Toker <alp@nuanti.com>
alp@webkit.org [Thu, 19 Jun 2008 23:20:52 +0000 (23:20 +0000)]
2008-06-19  Alp Toker  <alp@nuanti.com>

        GTK+/autotools build fix. JSGlobalObject.cpp in now in
        AllInOneFile.cpp and shouldn't be built separately.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-19 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Thu, 19 Jun 2008 23:15:47 +0000 (23:15 +0000)]
2008-06-19  John Sullivan  <sullivan@apple.com>

        Reviewed by Darin

        - fixed <rdar://problem/6021353> Assertion failure (!root->needsLayout()) after certain steps

        The didFirstLayout callback was called in a place where trouble would ensue if the client
        did any work that would cause the layout to be dirtied. Fixed by delaying the callback
        until performPostLayoutTasks.

        * page/FrameView.cpp:
        new m_firstLayoutCallbackPending instance member variable in FrameViewPrivate
        (WebCore::FrameViewPrivate::reset):
        set m_firstLayoutCallbackPending to false
        (WebCore::FrameView::layout):
        set m_firstLayoutCallbackPending instead of a local variable; don't do didFirstLayout callback here
        (WebCore::FrameView::performPostLayoutTasks):
        if m_firstLayoutCallbackPending is set, do didFirstLayout callback here, then clear m_firstLayoutCallbackPending

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-19 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 19 Jun 2008 22:39:23 +0000 (22:39 +0000)]
2008-06-19  David Hyatt  <hyatt@apple.com>

        Implement some cleanup of CSS variables based off Darin's review comments.

        Reviewed by darin

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseVariable):
        (WebCore::CSSParser::checkForVariables):
        (WebCore::CSSParser::addUnresolvedProperty):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::addMatchedDeclaration):
        * css/CSSVariableDependentValue.h:
        * css/CSSVariablesRule.cpp:
        (WebCore::CSSVariablesRule::CSSVariablesRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-19 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Thu, 19 Jun 2008 22:34:57 +0000 (22:34 +0000)]
2008-06-19  John Sullivan  <sullivan@apple.com>

        Rubber-stamped by Dan

        Prepended all FrameViewPrivate instance member variables with "m_" (in preparation
        for adding a new one in a future patch)

        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::FrameViewPrivate):
        (WebCore::FrameViewPrivate::reset):
        (WebCore::FrameView::~FrameView):
        (WebCore::FrameView::resetScrollbars):
        (WebCore::FrameView::didFirstLayout):
        (WebCore::FrameView::initScrollbars):
        (WebCore::FrameView::layoutCount):
        (WebCore::FrameView::needsFullRepaint):
        (WebCore::FrameView::layoutRoot):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::scrollTo):
        (WebCore::FrameView::useSlowRepaints):
        (WebCore::FrameView::setUseSlowRepaints):
        (WebCore::FrameView::removeSlowRepaintObject):
        (WebCore::FrameView::setScrollbarsMode):
        (WebCore::FrameView::setVScrollbarMode):
        (WebCore::FrameView::setHScrollbarMode):
        (WebCore::FrameView::scheduleRelayout):
        (WebCore::FrameView::scheduleRelayoutOfSubtree):
        (WebCore::FrameView::layoutPending):
        (WebCore::FrameView::needsLayout):
        (WebCore::FrameView::unscheduleRelayout):
        (WebCore::FrameView::isTransparent):
        (WebCore::FrameView::setTransparent):
        (WebCore::FrameView::baseBackgroundColor):
        (WebCore::FrameView::setBaseBackgroundColor):
        (WebCore::FrameView::performPostLayoutTasks):
        (WebCore::FrameView::updateOverflowStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Thu, 19 Jun 2008 22:23:11 +0000 (22:23 +0000)]
    Reviewed by Darin.

        Get rid of some threadInstance calls.

        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::init):
        * kjs/Parser.cpp:
        (KJS::Parser::parse):
        * kjs/Shell.cpp:
        (jscmain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix.
ap@webkit.org [Thu, 19 Jun 2008 22:13:59 +0000 (22:13 +0000)]
    Windows build fix.

        * WebJavaScriptCollector.cpp: Added a missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd CSS variables files for wx port.
hyatt@apple.com [Thu, 19 Jun 2008 22:08:29 +0000 (22:08 +0000)]
Add CSS variables files for wx port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd CSS variables files to .am makefile.
hyatt@apple.com [Thu, 19 Jun 2008 22:06:43 +0000 (22:06 +0000)]
Add CSS variables files to .am makefile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd CSS variables files to .pro makefile.
hyatt@apple.com [Thu, 19 Jun 2008 22:05:04 +0000 (22:05 +0000)]
Add CSS variables files to .pro makefile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd CSS Variables files to visual studio project.
hyatt@apple.com [Thu, 19 Jun 2008 21:59:56 +0000 (21:59 +0000)]
Add CSS Variables files to visual studio project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd layout test results for new variables test cases.
hyatt@apple.com [Thu, 19 Jun 2008 21:53:52 +0000 (21:53 +0000)]
Add layout test results for new variables test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Thu, 19 Jun 2008 21:49:52 +0000 (21:49 +0000)]
WebCore:

2008-06-19  David Hyatt  <hyatt@apple.com>

        Add initial support for CSS variables.  Non-dynamic cases should (hopefully) all work.  Things will get
        confused if you use the CSS OM to remove variables/inject variables, etc.  In addition no DOM APIs are
        exposed yet for the new variable interfaces.

        Reviewed by Beth

        Added many tests to fast/css/variables/

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSFunctionValue.cpp: Added.
        (WebCore::CSSFunctionValue::CSSFunctionValue):
        (WebCore::CSSFunctionValue::~CSSFunctionValue):
        (WebCore::CSSFunctionValue::cssText):
        (WebCore::CSSFunctionValue::parserValue):
        * css/CSSFunctionValue.h: Added.
        (WebCore::CSSFunctionValue::create):
        * css/CSSGrammar.y:
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
        (WebCore::CSSMutableStyleDeclaration::copy):
        * css/CSSMutableStyleDeclaration.h:
        (WebCore::CSSMutableStyleDeclaration::create):
        (WebCore::CSSMutableStyleDeclaration::hasVariableDependentValue):
        * css/CSSParser.cpp:
        (WebCore::equal):
        (WebCore::equalIgnoringCase):
        (WebCore::CSSParser::~CSSParser):
        (WebCore::CSSParserString::lower):
        (WebCore::CSSParser::document):
        (WebCore::CSSParser::validUnit):
        (WebCore::unitFromString):
        (WebCore::CSSParser::checkForOrphanedUnits):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFillShorthand):
        (WebCore::CSSParser::parseTransitionShorthand):
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseFillImage):
        (WebCore::CSSParser::parseFillPosition):
        (WebCore::CSSParser::parseFillSize):
        (WebCore::CSSParser::parseFillProperty):
        (WebCore::CSSParser::parseTransitionDuration):
        (WebCore::CSSParser::parseTransitionRepeatCount):
        (WebCore::CSSParser::parseTimingFunctionValue):
        (WebCore::CSSParser::parseTransitionTimingFunction):
        (WebCore::CSSParser::parseTransitionProperty):
        (WebCore::skipCommaInDashboardRegion):
        (WebCore::CSSParser::parseDashboardRegions):
        (WebCore::CSSParser::parseCounterContent):
        (WebCore::CSSParser::parseShape):
        (WebCore::CSSParser::parseFont):
        (WebCore::CSSParser::parseFontFamily):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseFontFaceUnicodeRange):
        (WebCore::CSSParser::parseColorParameters):
        (WebCore::CSSParser::parseHSLParameters):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseColorFromValue):
        (WebCore::ShadowParseContext::commitLength):
        (WebCore::CSSParser::parseShadow):
        (WebCore::CSSParser::parseReflect):
        (WebCore::BorderImageParseContext::commitNumber):
        (WebCore::BorderImageParseContext::commitWidth):
        (WebCore::BorderImageParseContext::commitBorderImage):
        (WebCore::CSSParser::parseBorderImage):
        (WebCore::CSSParser::parseCounter):
        (WebCore::parseGradientPoint):
        (WebCore::parseGradientColorStop):
        (WebCore::CSSParser::parseGradient):
        (WebCore::CSSParser::parseCanvas):
        (WebCore::TransformOperationInfo::TransformOperationInfo):
        (WebCore::CSSParser::parseTransform):
        (WebCore::CSSParser::lex):
        (WebCore::CSSParser::text):
        (WebCore::CSSParser::createFloatingValueList):
        (WebCore::CSSParser::sinkFloatingValueList):
        (WebCore::CSSParser::createFloatingFunction):
        (WebCore::CSSParser::sinkFloatingFunction):
        (WebCore::CSSParser::sinkFloatingValue):
        (WebCore::CSSParser::createFloatingMediaQueryExp):
        (WebCore::CSSParser::createCharsetRule):
        (WebCore::CSSParser::createImportRule):
        (WebCore::CSSParser::createVariablesRule):
        (WebCore::CSSParser::addVariable):
        (WebCore::CSSParser::clearVariables):
        (WebCore::CSSParser::parseVariable):
        (WebCore::CSSParser::parsePropertyWithResolvedVariables):
        (WebCore::CSSParser::checkForVariables):
        (WebCore::CSSParser::addUnresolvedProperty):
        (WebCore::cssPropertyID):
        (WebCore::cssValueKeywordID):
        * css/CSSParser.h:
        * css/CSSParserValues.cpp: Added.
        (WebCore::CSSParserValueList::~CSSParserValueList):
        (WebCore::CSSParserValueList::addValue):
        (WebCore::CSSParserValueList::deleteValueAt):
        (WebCore::CSSParserValue::createCSSValue):
        * css/CSSParserValues.h: Added.
        (WebCore::CSSParserString::operator String):
        (WebCore::CSSParserString::operator AtomicString):
        (WebCore::CSSParserValue::):
        (WebCore::CSSParserValueList::CSSParserValueList):
        (WebCore::CSSParserValueList::size):
        (WebCore::CSSParserValueList::current):
        (WebCore::CSSParserValueList::next):
        (WebCore::CSSParserValueList::valueAt):
        (WebCore::CSSParserValueList::clear):
        (WebCore::CSSParserValueList::containsVariables):
        (WebCore::CSSParserFunction::~CSSParserFunction):
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::getStringValue):
        (WebCore::CSSPrimitiveValue::cssText):
        (WebCore::CSSPrimitiveValue::parserValue):
        * css/CSSPrimitiveValue.h:
        (WebCore::CSSPrimitiveValue::):
        (WebCore::CSSPrimitiveValue::setPrimitiveType):
        * css/CSSRule.h:
        (WebCore::CSSRule::):
        * css/CSSRule.idl:
        * css/CSSStyleDeclaration.cpp:
        (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::addMatchedDeclaration):
        (WebCore::CSSStyleSelector::addVariables):
        (WebCore::CSSStyleSelector::resolveVariableDependentValue):
        (WebCore::CSSRuleSet::addRulesFromSheet):
        (WebCore::CSSStyleSelector::applyDeclarations):
        * css/CSSStyleSelector.h:
        * css/CSSValue.h:
        (WebCore::CSSValue::isVariableDependentValue):
        (WebCore::CSSValue::parserValue):
        * css/CSSValueList.cpp:
        (WebCore::CSSValueList::CSSValueList):
        (WebCore::CSSValueList::createParserValueList):
        * css/CSSValueList.h:
        (WebCore::CSSValueList::createFromParserValueList):
        * css/CSSVariableDependentValue.cpp: Added.
        (WebCore::CSSVariableDependentValue::CSSVariableDependentValue):
        (WebCore::CSSVariableDependentValue::~CSSVariableDependentValue):
        (WebCore::CSSVariableDependentValue::cssText):
        * css/CSSVariableDependentValue.h: Added.
        (WebCore::CSSVariableDependentValue::create):
        (WebCore::CSSVariableDependentValue::isVariableDependentValue):
        (WebCore::CSSVariableDependentValue::valueList):
        * css/CSSVariablesDeclaration.cpp: Added.
        (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration):
        (WebCore::CSSVariablesDeclaration::~CSSVariablesDeclaration):
        (WebCore::CSSVariablesDeclaration::getVariableValue):
        (WebCore::CSSVariablesDeclaration::removeVariable):
        (WebCore::CSSVariablesDeclaration::setVariable):
        (WebCore::CSSVariablesDeclaration::addParsedVariable):
        (WebCore::CSSVariablesDeclaration::getParsedVariable):
        (WebCore::CSSVariablesDeclaration::length):
        (WebCore::CSSVariablesDeclaration::item):
        (WebCore::CSSVariablesDeclaration::parentRule):
        (WebCore::CSSVariablesDeclaration::cssText):
        * css/CSSVariablesDeclaration.h: Added.
        (WebCore::CSSVariablesDeclaration::create):
        * css/CSSVariablesRule.cpp: Added.
        (WebCore::CSSVariablesRule::CSSVariablesRule):
        (WebCore::CSSVariablesRule::~CSSVariablesRule):
        (WebCore::CSSVariablesRule::cssText):
        * css/CSSVariablesRule.h: Added.
        (WebCore::CSSVariablesRule::media):
        (WebCore::CSSVariablesRule::variables):
        (WebCore::CSSVariablesRule::type):
        (WebCore::CSSVariablesRule::isVariablesRule):
        (WebCore::CSSVariablesRule::setDeclaration):
        * css/MediaQueryExp.cpp:
        (WebCore::MediaQueryExp::MediaQueryExp):
        * css/MediaQueryExp.h:
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):
        (WebCore::CSSParser::parseSVGStrokeDasharray):
        * css/StyleBase.h:
        (WebCore::StyleBase::isVariablesRule):
        * css/tokenizer.flex:

LayoutTests:

2008-06-19  David Hyatt  <hyatt@apple.com>

        Add layout tests for CSS variables.

        Reviewed by Beth

        * fast/css/variables: Added.
        * fast/css/variables/colors-test.html: Added.
        * fast/css/variables/font-test.html: Added.
        * fast/css/variables/image-test.html: Added.
        * fast/css/variables/import-test.html: Added.
        * fast/css/variables/invalid-variable-test.html: Added.
        * fast/css/variables/margin-test.html: Added.
        * fast/css/variables/misplaced-import-test.html: Added.
        * fast/css/variables/misplaced-variables-test.html: Added.
        * fast/css/variables/override-test.html: Added.
        * fast/css/variables/print-test.html: Added.
        * fast/css/variables/resources: Added.
        * fast/css/variables/resources/bad.css: Added.
        * fast/css/variables/resources/good.css: Added.
        * fast/css/variables/resources/listmark.gif: Added.
        * fast/css/variables/shorthand-test.html: Added.
        * fast/css/variables/single-term-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
jchaffraix@webkit.org [Thu, 19 Jun 2008 21:28:35 +0000 (21:28 +0000)]
WebCore:

2008-06-19  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin.

        Bug 19529 : Empty clients need to be refactored
        https://bugs.webkit.org/show_bug.cgi?id=19529

        - SVGImageEmptyClients' refactoring in order to be able to use them for other
        elements.

        - Trimmed empty spaces that were pointed out by git.

        * WebCore.xcodeproj/project.pbxproj:
        * loader/EmptyClients.h: Copied from WebCore/svg/graphics/SVGImageEmptyClients.h.

        (WebCore::EmptyChromeClient::~EmptyChromeClient):
        (WebCore::EmptyFrameLoaderClient::~EmptyFrameLoaderClient):
        (WebCore::EmptyEditorClient::~EmptyEditorClient):
        (WebCore::EmptyEditorClient::smartInsertDeleteEnabled):
        (WebCore::EmptyContextMenuClient::~EmptyContextMenuClient):
        (WebCore::EmptyDragClient::~EmptyDragClient):
        (WebCore::EmptyDragClient::createDragImageForLink):
        (WebCore::EmptyInspectorClient::~EmptyInspectorClient):
        Renamed SVGImageEmpty*Client classes to Empty*Client.

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):
        * svg/graphics/SVGImageEmptyClients.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam.
ap@webkit.org [Thu, 19 Jun 2008 21:13:41 +0000 (21:13 +0000)]
    Reviewed by Sam.

        Fix an assertion failure at startup.

        * kjs/JSObject.h: (KJS::JSObject::JSObject): Allow jsNull prototype in an assertion (I had
        it fixed in a wrong copy of the file, so I wasn't getting the failure).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 19 Jun 2008 20:42:09 +0000 (20:42 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix <rdar://problem/6008098> REGRESSION: Crash at FontFallbackList::fontDataAt()

        Test: fast/css/font-face-multiple-families.html

        Made changes to reflect the fact that the relationship between
        CSSFontFace and CSSSegmentedFontFace is in fact many-to-many.

        * css/CSSFontFace.cpp:
        (WebCore::CSSFontFace::addedToSegmentedFontFace): Added.
        (WebCore::CSSFontFace::removedFromSegmentedFontFace): Added.
        (WebCore::CSSFontFace::fontLoaded): Changed to notify all segmented font
        faces that include this font face.
        (WebCore::CSSFontFace::getFontData): Updated to get the font selector
        from one of the segmented font faces.
        * css/CSSFontFace.h:
        (WebCore::CSSFontFace::CSSFontFace):
        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule): Fixed the direct cause of
        the crash, namely releasing the font face when adding it to the first
        family that uses it, making it impossible to add it to the second and
        onwards families.
        * css/CSSSegmentedFontFace.cpp:
        (WebCore::CSSSegmentedFontFace::~CSSSegmentedFontFace): Added code to
        call CSSFontFace::removedFromSegmentedFontFace().
        (WebCore::CSSSegmentedFontFace::overlayRange): Added code to call
        CSSFontFace::{addedTo, removedFrom}SegmentedFontFace().

LayoutTests:

        Reviewed by Darin Adler.

        - test for <rdar://problem/6008098> REGRESSION: Crash at FontFallbackList::fontDataAt()

        * fast/css/font-face-multiple-families-expected.txt: Added.
        * fast/css/font-face-multiple-families.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Qt build fix.
ap@webkit.org [Thu, 19 Jun 2008 18:32:55 +0000 (18:32 +0000)]
    Qt build fix.

        * bridge/qt/qt_runtime.h: Include completion.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
ap@webkit.org [Thu, 19 Jun 2008 18:18:30 +0000 (18:18 +0000)]
    Build fix.

        * kjs/collector.cpp:
        (KJS::Heap::Heap):
        (KJS::allocateBlock):
        * kjs/collector.h:
        No, #if PLATFORM(UNIX) was not right. I've just moved the unsafe initialization back for now,
        as the platforms that use that code path do not use multiple threads yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows and Qt build fixes.
ap@webkit.org [Thu, 19 Jun 2008 18:03:23 +0000 (18:03 +0000)]
    Windows and Qt build fixes.

        * kjs/collector.h:
        * kjs/collector.cpp:
        (KJS::Heap::Heap):
        Wrapped m_pagesize in #if PLATFORM(UNIX), which should better match the sequence of #elifs
        in allocateBlock(). Changed MIN_ARRAY_SIZE to be explicitly size_t, as this type is different
        on different platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Thu, 19 Jun 2008 17:29:29 +0000 (17:29 +0000)]
    Reviewed by Darin.

        Prepare JavaScript heap for being per-thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Update the JavaScript syntax highlight colors to match Xcode.
timothy@apple.com [Thu, 19 Jun 2008 17:24:39 +0000 (17:24 +0000)]
    Update the JavaScript syntax highlight colors to match Xcode.
        This matches the other Xcode colors we are using for HTML.

        Reviewed by Dan Bernstein.

        * page/inspector/SourceFrame.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added JavaScript syntax highlighting to the Web Inspector.
timothy@apple.com [Thu, 19 Jun 2008 17:01:29 +0000 (17:01 +0000)]
    Added JavaScript syntax highlighting to the Web Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=14360

        Reviewed by Tim Hatcher and Adam Roben.

        * page/inspector/ScriptView.js: Added a call to syntaxHighlightJavascript.
        * page/inspector/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine): Added.
        Modifies a line content element.
        (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): Added.
        Syntax highlights the entire script.
        * page/inspector/SourceView.js: Added a call to syntaxHighlightJavascript.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoStarting to clean up the SVG Filter code. Mostly adding 'create' wrapper
oliver@apple.com [Thu, 19 Jun 2008 09:57:26 +0000 (09:57 +0000)]
Starting to clean up the SVG Filter code. Mostly adding 'create' wrapper
functions and changing raw pointer fields to RefPtrs.

Patch by Alex Mathews

Reviewed by Oliver

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-18 Adele Peterson <adele@apple.com>
adele@apple.com [Thu, 19 Jun 2008 03:41:49 +0000 (03:41 +0000)]
2008-06-18  Adele Peterson  <adele@apple.com>

        Reviewed by Dan Bernstein.

        Fix assertion in fast/dom/ImageDocument-image-deletion.html caused by new media document creation.

        * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
          Create the media document after we're done processing pdfs and images.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 19 Jun 2008 03:05:42 +0000 (03:05 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19598
          Crash in WebCore::RenderBlock::determineStartPosition

        Test: fast/dynamic/floating-to-positioned-2.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle): Changed to also remove relatively
        positioned floats from object lists when they become positioned, because
        then they cease to be floating.

LayoutTests:

        Reviewed by Darin Adler.

        - test for https://bugs.webkit.org/show_bug.cgi?id=19598
          Crash in WebCore::RenderBlock::determineStartPosition

        * fast/dynamic/floating-to-positioned-2.html: Copied from fast/dynamic/floating-to-positioned.html.
        * platform/mac/fast/dynamic/floating-to-positioned-2-expected.checksum: Added.
        * platform/mac/fast/dynamic/floating-to-positioned-2-expected.png: Added.
        * platform/mac/fast/dynamic/floating-to-positioned-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-18 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 19 Jun 2008 02:44:57 +0000 (02:44 +0000)]
2008-06-18  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        - fix storage leak

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::copy): Added an adoptRef that
        I missed when changing these objects to start with a refcount of 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add a script build phase to remove the WebKit.qrc file from
timothy@apple.com [Wed, 18 Jun 2008 22:58:21 +0000 (22:58 +0000)]
    Add a script build phase to remove the WebKit.qrc file from
        WebCore's resources. This file is used for the Qt port, but we
        copy the whole inspector folder for connivence and get this file.

        Reviewed by Adam Roben.

        * WebCore.xcodeproj/project.pbxproj: New script phase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Combine the Web Inspector's JavaScript resources into one large
timothy@apple.com [Wed, 18 Jun 2008 21:33:07 +0000 (21:33 +0000)]
    Combine the Web Inspector's JavaScript resources into one large
        script file to speed up loading of the Inspector.

        Reviewed by Adam Roben.

        * WebCore.xcodeproj/project.pbxproj: Added a Streamline Inspector Source
        script build phase that calls combine-javascript-resources and
        moves files around in the build directory.
        * combine-javascript-resources: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-18 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Wed, 18 Jun 2008 20:50:43 +0000 (20:50 +0000)]
2008-06-18  Julien Chaffraix  <jchaffraix@webkit.org>

        Qt Build fix after r34627.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-18 Marco Barisione <marco.barisione@collabora.co.uk>
jmalonzo@webkit.org [Wed, 18 Jun 2008 20:04:18 +0000 (20:04 +0000)]
2008-06-18  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=19171
        [GTK] GTypes for enumerations

        Generate GTypes for public enumerations so they can be used as
        properties.

        (This is a recommit of r34646, w/ additional build fix)

        * GNUmakefile.am: Generate webkit-enum-types.cpp and
        webkit-enum-types.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
rwlbuis@webkit.org [Wed, 18 Jun 2008 19:50:33 +0000 (19:50 +0000)]
    Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=18786
        Once rendered, SVG text elements removed from DOM continue to be displayed

        Repaint the text visual rect before removing it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRevert "2008-06-18 Marco Barisione <marco.barisione@collabora.co.uk>"
jmalonzo@webkit.org [Wed, 18 Jun 2008 17:16:12 +0000 (17:16 +0000)]
Revert "2008-06-18  Marco Barisione  <marco.barisione@collabora.co.uk>"

This reverts commit c6c3f8ca4996a96a1c7e9d1ddb9c6e3bd05daed9.

This patch breaks the build. Reverting for now

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-18 Marco Barisione <marco.barisione@collabora.co.uk>
jmalonzo@webkit.org [Wed, 18 Jun 2008 11:35:44 +0000 (11:35 +0000)]
2008-06-18  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=19171
        [GTK] GTypes for enumerations

        * webkit/webkit.h: Include webkit-enum-types.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGtk build fix, brought up by Dirk Schulze.
christian@webkit.org [Wed, 18 Jun 2008 09:54:25 +0000 (09:54 +0000)]
Gtk build fix, brought up by Dirk Schulze.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-17 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Wed, 18 Jun 2008 04:44:07 +0000 (04:44 +0000)]
2008-06-17  Beth Dakin  <bdakin@apple.com>

        Reviewed by Tim.

        This patch removes all instances of the phrase "TextMarker" from
        function names in the C++ accessibility code. TextMarkers only
        exists in the Objective-C code.

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::visiblePositionRangeForLine):
        (WebCore::AccessibilityObject::visiblePositionRangeForUnorderedPositions):
        (WebCore::AccessibilityObject::positionOfLeftWord):
        (WebCore::AccessibilityObject::positionOfRightWord):
        (WebCore::AccessibilityObject::leftLineVisiblePositionRange):
        (WebCore::AccessibilityObject::rightLineVisiblePositionRange):
        (WebCore::AccessibilityObject::sentenceForPosition):
        (WebCore::AccessibilityObject::paragraphForPosition):
        (WebCore::AccessibilityObject::styleRangeForPosition):
        (WebCore::AccessibilityObject::visiblePositionRangeForRange):
        (WebCore::AccessibilityObject::stringForVisiblePositionRange):
        (WebCore::AccessibilityObject::boundsForVisiblePositionRange):
        (WebCore::AccessibilityObject::lengthForVisiblePositionRange):
        (WebCore::AccessibilityObject::setSelectedVisiblePositionRange):
        (WebCore::AccessibilityObject::visiblePositionForPoint):
        (WebCore::AccessibilityObject::nextVisiblePosition):
        (WebCore::AccessibilityObject::previousVisiblePosition):
        (WebCore::AccessibilityObject::nextWordEnd):
        (WebCore::AccessibilityObject::previousWordStart):
        (WebCore::AccessibilityObject::nextLineEndPosition):
        (WebCore::AccessibilityObject::previousLineStartPosition):
        (WebCore::AccessibilityObject::nextSentenceEndPosition):
        (WebCore::AccessibilityObject::previousSentenceStartPosition):
        (WebCore::AccessibilityObject::nextParagraphEndPosition):
        (WebCore::AccessibilityObject::previousParagraphStartPosition):
        (WebCore::AccessibilityObject::visiblePositionForIndex):
        (WebCore::AccessibilityObject::accessibilityObjectForPosition):
        (WebCore::AccessibilityObject::lineForPosition):
        (WebCore::AccessibilityObject::plainTextRangeForVisiblePositionRange):
        (WebCore::AccessibilityObject::index):
        (WebCore::AccessibilityObject::doAXRangeForPosition):
        (WebCore::AccessibilityObject::doAXStyleRangeForIndex):
        (WebCore::AccessibilityObject::doAXLineForIndex):
        * page/AccessibilityObject.h:
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
        (WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
        (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
        (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
        (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
        (WebCore::AccessibilityRenderObject::index):
        (WebCore::AccessibilityRenderObject::doAXBoundsForRange):
        * page/AccessibilityRenderObject.h:
        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
        (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
        (-[AccessibilityObjectWrapper doAXAttributedStringForRange:]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Justin Garcia.
mitz@apple.com [Wed, 18 Jun 2008 03:04:42 +0000 (03:04 +0000)]
    Reviewed by Justin Garcia.

        - prefer Leopard results when running on Snow Leopard.

        * Scripts/run-webkit-tests: Added a mapping of Snow Leopard to
          mac-leopard.
        * Scripts/webkitdirs.pm: Added isSnowLeopard().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5775802> JavaScriptGlue, WebCore and WebKit should not force use...
mrowe@apple.com [Wed, 18 Jun 2008 01:34:40 +0000 (01:34 +0000)]
<rdar://problem/5775802> JavaScriptGlue, WebCore and WebKit should not force use of GCC 4.0.

Reviewed by Darin Adler.

* JavaScriptGlue.xcodeproj/project.pbxproj:
* WebCore.xcodeproj/project.pbxproj:
* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-17 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 18 Jun 2008 01:32:18 +0000 (01:32 +0000)]
2008-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - eliminate the last RefCounted client that needs the "start at 0" behavior, NodeFilter

        - move handling of non-Attr arguments from the code generation script to the DOM
          itself (as with every other type of argument)

        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::toNodeFilter): Changed return type to PassRefPtr. Use create instead of new.

        * bindings/objc/DOM.mm:
        (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
        Use create instead of new.
        (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
        Ditto.

        * bindings/scripts/CodeGeneratorJS.pm: Use PassRefPtr and RefPtr for toNodeFilter and
        the local variable for NodeFilter arguments. Remove the TypeCanFailConversion mechanism:
        It's no longer needed for Attr, was not having any effect for VoidCallback, and was
        returning false for all other types.

        * dom/Element.cpp:
        (WebCore::Element::setAttributeNode): Added code to return TYPE_MISMATCH_ERR when
        the attr is 0 -- this matches what the autogenerated bindings did before.
        (WebCore::Element::setAttributeNodeNS): Ditto.
        (WebCore::Element::removeAttributeNode): Ditto.

        * dom/NodeFilter.h: Added create, made constructor private, and got rid of code to
        initialize the refcount to 0.

        * html/CanvasPattern.h: Made CachedResourceClient base class private in a
        more-explicit way.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix <rdar://6016755> Assertion failure when WebView is child of message-only...
aroben@apple.com [Wed, 18 Jun 2008 01:14:02 +0000 (01:14 +0000)]
    Fix <rdar://6016755> Assertion failure when WebView is child of message-only window

        Reviewed by Ada Chan.

        No test possible.

        * platform/win/WindowMessageBroadcaster.cpp:
        (WebCore::WindowMessageBroadcaster::addListener): Only subclass the
        window when we're adding our first listener. Removed an assertion that
        an old WNDPROC was returned -- this will be 0 in the case of a
        message-only window. Added an assertion to help catch cases where we
        try to subclass the window twice.
        (WebCore::WindowMessageBroadcaster::unsubclassWindow): Removed an
        assertion that is not correct in the message-only window case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-17 Adele Peterson <adele@apple.com>
adele@apple.com [Wed, 18 Jun 2008 01:00:33 +0000 (01:00 +0000)]
2008-06-17  Adele Peterson  <adele@apple.com>

        Attempt to fix builds by wrapping new code in #if ENABLE(VIDEO)

        * loader/MediaDocument.cpp:
        * loader/MediaDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-17 Adele Peterson <adele@apple.com>
adele@apple.com [Wed, 18 Jun 2008 00:45:09 +0000 (00:45 +0000)]
2008-06-17  Adele Peterson  <adele@apple.com>

        Attempt to fix builds by wrapping new code in #if ENABLE(VIDEO)

        * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-17 Adele Peterson <adele@apple.com>
adele@apple.com [Wed, 18 Jun 2008 00:07:34 +0000 (00:07 +0000)]
2008-06-17  Adele Peterson  <adele@apple.com>

        Reviewed by Brady.

        Fix for <rdar://problem/5605768> Render full-page video/audio with <video>/<audio> instead of QuickTime plug-in

        * WebCore.xcodeproj/project.pbxproj: Added MediaDocument class.
        * GNUmakefile.am: ditto.
        * WebCore.pro: ditto.
        * WebCore.vcproj/WebCore.vcproj: ditto.
        * WebCoreSources.bkl: ditto.

        * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
          Check to see if the type can be played by our MediaPlayer, if so create a MediaDocument
        * dom/Document.h: (WebCore::Document::isMediaDocument): Added.

        * loader/MediaDocument.cpp: Added.
        (WebCore::MediaTokenizer::MediaTokenizer):
        (WebCore::MediaTokenizer::wantsRawData):
        (WebCore::MediaTokenizer::write):
        (WebCore::MediaTokenizer::createDocumentStructure):
        (WebCore::MediaTokenizer::writeRawData):
        (WebCore::MediaTokenizer::stopParsing):
        (WebCore::MediaTokenizer::finish):
        (WebCore::MediaTokenizer::isWaitingForScripts):
        (WebCore::MediaDocument::MediaDocument):
        (WebCore::MediaDocument::createTokenizer):
        * loader/MediaDocument.h: Added.
        (WebCore::MediaDocument::create):
        (WebCore::MediaDocument::isMediaDocument):

        * page/InspectorController.cpp: (WebCore::getResourceDocumentNode):
          Added MediaDocument case so it is handled the same as a PluginDocument or ImageDocument.
        * platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::supportsType): Added.
        * platform/graphics/MediaPlayer.h:
        * rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControlVisibility):
          Instead of checking the html element to decide if the media is audio, check the player.
          This means that if a video element actually only contains audio, then we will still avoid fading the controls in and out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] WebKitWebHistoryItem needs properties
christian@webkit.org [Tue, 17 Jun 2008 22:53:05 +0000 (22:53 +0000)]
[GTK] WebKitWebHistoryItem needs properties

https://bugs.webkit.org/show_bug.cgi?id=19558

Implement properties matching the existing accessors.

Reviewed by Alp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Adds the file name and line number for call frames next to
timothy@apple.com [Tue, 17 Jun 2008 22:33:18 +0000 (22:33 +0000)]
    Adds the file name and line number for call frames next to
        the function name in the Call Stack pane.

        https://bugs.webkit.org/show_bug.cgi?id=19586

        Reviewed by Adam Roben.

        * English.lproj/localizedStrings.js: Updated strings.
        * page/inspector/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane.prototype.update): Create a subtitle
        based on the URL and line number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse accurate call frame title's based on the call frame type.
timothy@apple.com [Tue, 17 Jun 2008 22:33:07 +0000 (22:33 +0000)]
Use accurate call frame title's based on the call frame type.
Added a type to DebuggerCallFrame so the under interface can
distinguish anonymous functions and program call frames.

JavaScriptCore:

2008-06-16  Timothy Hatcher  <timothy@apple.com>

        Added a type to DebuggerCallFrame so the under interface can
        distinguish anonymous functions and program call frames.

        https://bugs.webkit.org/show_bug.cgi?id=19585

        Reviewed by Geoff Garen.

        * JavaScriptCore.exp: Export the DebuggerCallFrame::type symbol.
        * kjs/DebuggerCallFrame.cpp:
        (KJS::DebuggerCallFrame::type): Added.
        * kjs/DebuggerCallFrame.h:

WebCore:

2008-06-16  Timothy Hatcher  <timothy@apple.com>

        Use accurate call frame title's based on the call frame type.

        https://bugs.webkit.org/show_bug.cgi?id=19585

        Reviewed by Geoff Garen.

        * English.lproj/localizedStrings.js: Updated strings.
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::evaluate): Removed the isValid()
        check since the evaluate() functiondoes the check already.
        (WebCore::JSJavaScriptCallFrame::thisObject): Removed the isValid()
        check, since thisObject() does the check and returns null if invalid.
        (WebCore::JSJavaScriptCallFrame::type): Return a string
        based on the enum value of the type.
        (WebCore::JSJavaScriptCallFrame::scopeChain): Removed the isValid()
        check, since scopeChain() does the check and returns null if invalid.
        So just null check scopeChain().
        * page/JavaScriptCallFrame.cpp:
        (WebCore::JavaScriptCallFrame::type): Return the DebuggerCallFrame::Type.
        Return DebuggerCallFrame::UnknownType if the call frame is invalid.
        * page/JavaScriptCallFrame.h:
        * page/JavaScriptCallFrame.idl: Add the type property.
        * page/inspector/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane.prototype.update): Check the type
        of the call frame to create the correct title.
        * page/inspector/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): Use the
        "(program)" title for the file menu to match the call frames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Remember the expanded state of objects in the Scope Variables pane when stepping.
timothy@apple.com [Tue, 17 Jun 2008 22:32:56 +0000 (22:32 +0000)]
    Remember the expanded state of objects in the Scope Variables pane when stepping.
        https://bugs.webkit.org/show_bug.cgi?id=19584

        Reviewed by Adam Roben.

        * page/inspector/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertiesSection): Add an optional argument
        that is the treeElementConstructor to use when making TreeElements.
        (WebInspector.ObjectPropertiesSection.prototype.onpopulate): Use
        the treeElementConstructor to create TreeElements.
        (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Use
        the treeElementConstructor to create TreeElements.
        * page/inspector/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane.prototype.update): Create an
        _expandedProperties object on the callframe if one doesn't exist yet.
        Pass WebInspector.ScopeVariableTreeElement to the ObjectPropertiesSection
        as the TreeElement constructor we want to use.
        (WebInspector.ScopeVariableTreeElement): Added.
        (WebInspector.ScopeVariableTreeElement.prototype.onattach): Expand if the
        propertyIdentifier is in the pane's _expandedProperties.
        (WebInspector.ScopeVariableTreeElement.prototype.onexpand): Add the
        propertyIdentifier to the pane's _expandedProperties.
        (WebInspector.ScopeVariableTreeElement.prototype.oncollapse): Remove the
        propertyIdentifier from the pane's _expandedProperties.
        (WebInspector.ScopeVariableTreeElement.prototype.get propertyIdentifier):
        Return an identifier that has the section title, subtile and propertyPath concatenated.
        (WebInspector.ScopeVariableTreeElement.prototype.get propertyPath): Return a string
        that has the propertyNames up to the root ancestor concatenated with a period.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Focus the mainPanelsElement in a timeout so it happens after the
timothy@apple.com [Tue, 17 Jun 2008 22:32:45 +0000 (22:32 +0000)]
    Focus the mainPanelsElement in a timeout so it happens after the
        initial focus, so it doesn't get reset to the first toolbar button.
        This initial focus happens on Mac when the window is made key and
        the WebHTMLView becomes the first responder.

        https://bugs.webkit.org/show_bug.cgi?id=19587

        Reviewed by Adele Peterson.

        * page/inspector/inspector.js:
        (WebInspector.loaded): Focus the mainPanelsElement in a timeout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Use tabIndex in the Web Inspector for focusable areas.
timothy@apple.com [Tue, 17 Jun 2008 22:32:34 +0000 (22:32 +0000)]
    Use tabIndex in the Web Inspector for focusable areas.
        https://bugs.webkit.org/show_bug.cgi?id=19583

        Reviewed by Adam Roben.

        * page/inspector/Console.js:
        (WebInspector.Console): No longer make the messagesElement
        focusable since the engine handles the case for us. The promptElement
        now handles the key events.
        (WebInspector.Console.prototype.show): Set the current focus element
        to the prompt element.
        (WebInspector.Console.prototype.hide): Set the current focus element
        to WebInspector.previousFocusElement.
        (WebInspector.Console.prototype._messagesFocused): Removed.
        * page/inspector/DataGrid.js:
        (WebInspector.DataGrid): Remove the focusable class.
        * page/inspector/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView): Remove the focusable class. Set
        tabIndex to 0. The promptElement now handles the key events.
        (WebInspector.DatabaseQueryView.prototype._focused): Removed.
        * page/inspector/inspector.css: Updated selectors to use :focus
        instead of .focused and .blurred.
        * page/inspector/inspector.html: Removed focusable, focused and blurred
        classes and added tabindex attributes.
        * page/inspector/inspector.js:
        (WebInspector.get previousFocusElement): Added. Returns _previousFocusElement.
        (WebInspector.set currentFocusElement): Simplified. Stores the previous element
        in _previousFocusElement for clients that need it. Calls focus on the passed
        in element or blur on the previous element.
        (WebInspector.loaded): Removed the event listener for mousedown. Renamed
        changeFocus to focusChanged.
        (WebInspector.focusChanged): Renamed from changeFocus. Just sets the
        currentFocusElement to the event target.
        (WebInspector.startEditing): Changed to use tabIndex and blur events.
        Add a more robust check for restoring focus to the previous element
        when editing finishes that catches focused descendants.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Removed redundant if statements and early returns from
timothy@apple.com [Tue, 17 Jun 2008 22:32:23 +0000 (22:32 +0000)]
    Removed redundant if statements and early returns from
        AccessibilityRenderObject::ariaRoleAttribute.

        Reviewed by Sam Wenig.

        * page/AccessibilityRenderObject.cpp:
        (AccessibilityRenderObject::ariaRoleAttribute): Removed redundant if
        statements and early returns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Removed duplicate implementations of setTabIndex. They all matched
timothy@apple.com [Tue, 17 Jun 2008 22:32:15 +0000 (22:32 +0000)]
    Removed duplicate implementations of setTabIndex. They all matched
        the HTMLElement::setTabIndex implementation.

        Reviewed by Sam Wenig.

        * html/HTMLAnchorElement.cpp: Removed setTabIndex.
        * html/HTMLAreaElement.cpp: Ditto.
        * html/HTMLFormControlElement.cpp: Ditto.
        * html/HTMLFormControlElement.h: Ditto.
        * html/HTMLObjectElement.cpp: Ditto.
        * html/HTMLObjectElement.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Tim H.
eric@webkit.org [Tue, 17 Jun 2008 20:28:57 +0000 (20:28 +0000)]
    Reviewed by Tim H.

        Remove bogus ASSERT which tripped every time for those who use PAC files.

        * kjs/Parser.cpp:
        (KJS::Parser::parse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Tue, 17 Jun 2008 19:16:22 +0000 (19:16 +0000)]
WebCore:

2008-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - more of https://bugs.webkit.org/show_bug.cgi?id=17257
          start ref counts at 1 instead of 0 for speed

        Change StyleBase and all classes derived from it.

        * bindings/js/JSRGBColor.cpp:
        (WebCore::JSRGBColor::getValueProperty):
        * bindings/objc/DOMRGBColor.mm:
        (-[DOMRGBColor red]):
        (-[DOMRGBColor green]):
        (-[DOMRGBColor blue]):
        (-[DOMRGBColor alpha]):
        * css/CSSBorderImageValue.cpp:
        (WebCore::CSSBorderImageValue::cssText):
        * css/CSSBorderImageValue.h:
        (WebCore::CSSBorderImageValue::create):
        * css/CSSCanvasValue.h:
        (WebCore::CSSCanvasValue::create):
        (WebCore::CSSCanvasValue::setName):
        (WebCore::CSSCanvasValue::CSSCanvasValue):
        * css/CSSCharsetRule.cpp:
        (WebCore::CSSCharsetRule::CSSCharsetRule):
        * css/CSSCharsetRule.h:
        (WebCore::CSSCharsetRule::create):
        (WebCore::CSSCharsetRule::encoding):
        (WebCore::CSSCharsetRule::isCharsetRule):
        (WebCore::CSSCharsetRule::type):
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForShadow):
        (WebCore::valueForNinePieceImage):
        (WebCore::valueForReflection):
        (WebCore::getPositionOffsetValue):
        (WebCore::currentColorOrValidColor):
        (WebCore::getBorderRadiusCornerValue):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSComputedStyleDeclaration.h:
        (WebCore::computedStyle):
        * css/CSSCursorImageValue.h:
        (WebCore::CSSCursorImageValue::create):
        * css/CSSFontFaceRule.cpp:
        (WebCore::CSSFontFaceRule::CSSFontFaceRule):
        * css/CSSFontFaceRule.h:
        (WebCore::CSSFontFaceRule::create):
        (WebCore::CSSFontFaceRule::isFontFaceRule):
        (WebCore::CSSFontFaceRule::type):
        * css/CSSFontFaceSrcValue.h:
        (WebCore::CSSFontFaceSrcValue::create):
        (WebCore::CSSFontFaceSrcValue::createLocal):
        (WebCore::CSSFontFaceSrcValue::~CSSFontFaceSrcValue):
        (WebCore::CSSFontFaceSrcValue::CSSFontFaceSrcValue):
        * css/CSSGradientValue.h:
        (WebCore::CSSGradientColorStop::CSSGradientColorStop):
        (WebCore::CSSGradientValue::create):
        (WebCore::CSSGradientValue::CSSGradientValue):
        * css/CSSImageGeneratorValue.h:
        (WebCore::CSSImageGeneratorValue::isImageGeneratorValue):
        * css/CSSImageValue.h:
        (WebCore::CSSImageValue::create):
        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::CSSImportRule):
        (WebCore::CSSImportRule::setCSSStyleSheet):
        * css/CSSImportRule.h:
        (WebCore::CSSImportRule::create):
        (WebCore::CSSImportRule::isImportRule):
        (WebCore::CSSImportRule::type):
        * css/CSSInheritedValue.h:
        (WebCore::CSSInheritedValue::create):
        (WebCore::CSSInheritedValue::CSSInheritedValue):
        * css/CSSInitialValue.h:
        (WebCore::CSSInitialValue::createExplicit):
        (WebCore::CSSInitialValue::createImplicit):
        (WebCore::CSSInitialValue::CSSInitialValue):
        * css/CSSMediaRule.cpp:
        (WebCore::CSSMediaRule::CSSMediaRule):
        * css/CSSMediaRule.h:
        (WebCore::CSSMediaRule::create):
        (WebCore::CSSMediaRule::isMediaRule):
        (WebCore::CSSMediaRule::type):
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::setProperty):
        (WebCore::CSSMutableStyleDeclaration::setStringProperty):
        * css/CSSMutableStyleDeclaration.h:
        (WebCore::CSSMutableStyleDeclaration::create):
        * css/CSSPageRule.cpp:
        (WebCore::CSSPageRule::CSSPageRule):
        * css/CSSPageRule.h:
        (WebCore::CSSPageRule::create):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::addFillValue):
        (WebCore::CSSParser::parseFillShorthand):
        (WebCore::CSSParser::addTransitionValue):
        (WebCore::CSSParser::parseTransitionShorthand):
        (WebCore::CSSParser::parseShorthand):
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseBackgroundColor):
        (WebCore::CSSParser::parseFillPositionXY):
        (WebCore::CSSParser::parseFillPosition):
        (WebCore::CSSParser::parseFillSize):
        (WebCore::CSSParser::parseFillProperty):
        (WebCore::CSSParser::parseTransitionDuration):
        (WebCore::CSSParser::parseTransitionRepeatCount):
        (WebCore::CSSParser::parseTransitionTimingFunction):
        (WebCore::CSSParser::parseTransitionProperty):
        (WebCore::CSSParser::parseDashboardRegions):
        (WebCore::CSSParser::parseCounterContent):
        (WebCore::CSSParser::parseShape):
        (WebCore::CSSParser::parseFont):
        (WebCore::CSSParser::parseFontFamily):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseFontFaceUnicodeRange):
        (WebCore::ShadowParseContext::commitValue):
        (WebCore::ShadowParseContext::commitLength):
        (WebCore::CSSParser::parseShadow):
        (WebCore::CSSParser::parseReflect):
        (WebCore::BorderImageParseContext::commitNumber):
        (WebCore::BorderImageParseContext::commitBorderImage):
        (WebCore::CSSParser::parseBorderImage):
        (WebCore::CSSParser::parseCounter):
        (WebCore::parseGradientPoint):
        (WebCore::parseGradientColorStop):
        (WebCore::CSSParser::parseGradient):
        (WebCore::CSSParser::parseCanvas):
        (WebCore::CSSParser::parseTransform):
        (WebCore::CSSParser::createMediaList):
        (WebCore::CSSParser::createCharsetRule):
        (WebCore::CSSParser::createImportRule):
        (WebCore::CSSParser::createMediaRule):
        (WebCore::CSSParser::createStyleRule):
        (WebCore::CSSParser::createFontFaceRule):
        * css/CSSPrimitiveValue.h:
        (WebCore::CSSPrimitiveValue::):
        (WebCore::CSSPrimitiveValue::createIdentifier):
        (WebCore::CSSPrimitiveValue::createColor):
        (WebCore::CSSPrimitiveValue::create):
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::isPrimitiveValue):
        * css/CSSQuirkPrimitiveValue.h:
        (WebCore::CSSQuirkPrimitiveValue::create):
        * css/CSSReflectValue.h:
        (WebCore::CSSReflectValue::create):
        * css/CSSRule.cpp:
        (WebCore::CSSRule::parentRule):
        (WebCore::CSSRule::setCssText):
        * css/CSSRule.h:
        (WebCore::CSSRule::CSSRule):
        (WebCore::CSSRule::isRule):
        * css/CSSStyleDeclaration.cpp:
        (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
        * css/CSSStyleDeclaration.h:
        * css/CSSStyleRule.cpp:
        (WebCore::CSSStyleRule::CSSStyleRule):
        * css/CSSStyleRule.h:
        (WebCore::CSSStyleRule::create):
        (WebCore::CSSStyleRule::isStyleRule):
        (WebCore::CSSStyleRule::type):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::parseUASheet):
        (WebCore::CSSRuleSet::addRulesFromSheet):
        (WebCore::CSSStyleSelector::applyProperty):
        * css/CSSStyleSheet.cpp:
        (WebCore::CSSStyleSheet::checkLoaded):
        * css/CSSStyleSheet.h:
        (WebCore::CSSStyleSheet::create):
        (WebCore::CSSStyleSheet::isCSSStyleSheet):
        (WebCore::CSSStyleSheet::type):
        * css/CSSTimingFunctionValue.h:
        (WebCore::CSSTimingFunctionValue::create):
        (WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue):
        (WebCore::CSSTimingFunctionValue::isTransitionTimingFunctionValue):
        * css/CSSTransformValue.cpp:
        (WebCore::CSSTransformValue::CSSTransformValue):
        (WebCore::CSSTransformValue::~CSSTransformValue):
        (WebCore::CSSTransformValue::addValue):
        (WebCore::CSSTransformValue::cssText):
        * css/CSSTransformValue.h:
        (WebCore::CSSTransformValue::create):
        * css/CSSUnicodeRangeValue.h:
        (WebCore::CSSUnicodeRangeValue::create):
        (WebCore::CSSUnicodeRangeValue::CSSUnicodeRangeValue):
        * css/CSSUnknownRule.h:
        * css/CSSValue.h:
        (WebCore::CSSValue::isImageGeneratorValue):
        (WebCore::CSSValue::isImageValue):
        (WebCore::CSSValue::isPrimitiveValue):
        (WebCore::CSSValue::isValueList):
        (WebCore::CSSValue::isSVGColor):
        (WebCore::CSSValue::isSVGPaint):
        (WebCore::CSSValue::CSSValue):
        * css/CSSValueList.h:
        (WebCore::CSSValueList::createCommaSeparated):
        (WebCore::CSSValueList::createSpaceSeparated):
        (WebCore::CSSValueList::isValueList):
        * css/FontFamilyValue.h:
        (WebCore::FontFamilyValue::create):
        * css/FontValue.h:
        (WebCore::FontValue::create):
        (WebCore::FontValue::FontValue):
        (WebCore::FontValue::isFontValue):
        * css/MediaList.cpp:
        (WebCore::MediaList::MediaList):
        (WebCore::MediaList::deleteMedium):
        (WebCore::MediaList::setMediaText):
        * css/MediaList.h:
        (WebCore::MediaList::create):
        (WebCore::MediaList::createAllowingDescriptionSyntax):
        (WebCore::MediaList::length):
        (WebCore::MediaList::mediaQueries):
        * css/MediaQueryEvaluator.cpp:
        (WebCore::MediaQueryEvaluator::eval):
        * css/MediaQueryExp.cpp:
        (WebCore::MediaQueryExp::MediaQueryExp):
        * css/SVGCSSComputedStyleDeclaration.cpp:
        (WebCore::glyphOrientationToCSSPrimitiveValue):
        (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):
        (WebCore::CSSParser::parseSVGStrokeDasharray):
        (WebCore::CSSParser::parseSVGPaint):
        (WebCore::CSSParser::parseSVGColor):
        * css/ShadowValue.h:
        (WebCore::ShadowValue::create):
        * css/StyleBase.h:
        (WebCore::StyleBase::isCSSStyleSheet):
        (WebCore::StyleBase::isFontFaceRule):
        (WebCore::StyleBase::isRule):
        (WebCore::StyleBase::isStyleRule):
        (WebCore::StyleBase::isStyleSheet):
        (WebCore::StyleBase::isXSLStyleSheet):
        (WebCore::StyleBase::StyleBase):
        * css/StyleList.cpp:
        * css/StyleList.h:
        (WebCore::StyleList::StyleList):
        * css/StyleSheet.h:
        (WebCore::StyleSheet::styleSheetChanged):
        (WebCore::StyleSheet::isStyleSheet):
        * dom/CSSMappedAttributeDeclaration.h:
        (WebCore::CSSMappedAttributeDeclaration::create):
        (WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createCSSStyleSheet):
        * dom/Document.cpp:
        (WebCore::Document::createCSSStyleDeclaration):
        (WebCore::Document::setCSSStyleSheet):
        (WebCore::Document::elementSheet):
        (WebCore::Document::mappedElementSheet):
        (WebCore::Document::recalcStyleSelector):
        * dom/Node.cpp:
        (WebCore::Node::querySelector):
        (WebCore::Node::querySelectorAll):
        * dom/Position.cpp:
        (WebCore::Position::computedStyle):
        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet):
        (WebCore::ProcessingInstruction::setCSSStyleSheet):
        (WebCore::ProcessingInstruction::setXSLStyleSheet):
        * dom/ProcessingInstruction.h:
        * dom/StyleElement.cpp:
        (WebCore::StyleElement::createSheet):
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::createInlineStyleDecl):
        (WebCore::StyledElement::createMappedDecl):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::ApplyStyleCommand):
        (WebCore::hasTextDecorationProperty):
        (WebCore::ApplyStyleCommand::extractAndNegateTextDecorationStyle):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
        * editing/Editor.cpp:
        (WebCore::Editor::selectionHasStyle):
        (WebCore::Editor::setBaseWritingDirection):
        * editing/EditorCommand.cpp:
        (WebCore::executeApplyStyle):
        (WebCore::executeToggleStyle):
        (WebCore::executeApplyParagraphStyle):
        (WebCore::stateStyle):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion):
        * editing/RemoveFormatCommand.cpp:
        (WebCore::RemoveFormatCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::insertFragmentForTestRendering):
        * editing/markup.cpp:
        (WebCore::styleFromMatchedRulesForElement):
        (WebCore::appendStartMarkup):
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::createLinkDecl):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
        (WebCore::HTMLLinkElement::setCSSStyleSheet):
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::pickMedia):
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::additionalAttributeStyleDecls):
        (WebCore::HTMLTableElement::addSharedCellBordersDecl):
        (WebCore::HTMLTableElement::addSharedCellPaddingDecl):
        (WebCore::HTMLTableElement::addSharedGroupDecls):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::getComputedStyle):
        * page/Frame.cpp:
        (WebCore::Frame::computeAndSetTypingStyle):
        (WebCore::Frame::selectionComputedStyle):
        * page/Frame.h:
        * rendering/style/RenderStyle.cpp:
        (WebCore::StyleCachedImage::cssValue):
        * rendering/style/RenderStyle.h:
        * svg/SVGColor.h:
        (WebCore::SVGColor::create):
        (WebCore::SVGColor::isSVGColor):
        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::SVGFontFaceElement):
        (WebCore::SVGFontFaceElement::rebuildFontFace):
        * svg/SVGFontFaceNameElement.cpp:
        (WebCore::SVGFontFaceNameElement::srcValue):
        * svg/SVGFontFaceSrcElement.cpp:
        (WebCore::SVGFontFaceSrcElement::srcValue):
        * svg/SVGFontFaceUriElement.cpp:
        (WebCore::SVGFontFaceUriElement::srcValue):
        * svg/SVGPaint.cpp:
        (WebCore::SVGPaint::SVGPaint):
        * svg/SVGPaint.h:
        (WebCore::SVGPaint::create):
        (WebCore::SVGPaint::isSVGPaint):
        * svg/animation/SMILTimeContainer.cpp:
        (WebCore::SMILTimeContainer::baseValueFor):
        * xml/XSLImportRule.cpp:
        (WebCore::XSLImportRule::XSLImportRule):
        (WebCore::XSLImportRule::setXSLStyleSheet):
        * xml/XSLImportRule.h:
        (WebCore::XSLImportRule::create):
        (WebCore::XSLImportRule::href):
        (WebCore::XSLImportRule::isImportRule):
        * xml/XSLStyleSheet.cpp:
        (WebCore::XSLStyleSheet::checkLoaded):
        (WebCore::XSLStyleSheet::loadChildSheet):
        * xml/XSLStyleSheet.h:
        (WebCore::XSLStyleSheet::create):
        (WebCore::XSLStyleSheet::createEmbedded):
        * xml/XSLTProcessor.cpp:
        (WebCore::xsltStylesheetPointer):

WebKit/mac:

2008-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Use create instead of new
        to create a CSSMutableStyleDeclaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
adele@apple.com [Tue, 17 Jun 2008 18:45:06 +0000 (18:45 +0000)]
WebCore:

2008-06-17  Michelangelo De Simone  <m.des@mac.com>

        Reviewed by Adele.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18887
        Added support for autofocus controls.

        When authors specify the "autofocus" attribute on form controls these
        acquire focus automatically as the document is rendered.

        Tests: fast/forms/autofocus-attribute.html
               fast/forms/autofocus-opera-001.html
               fast/forms/autofocus-opera-002.html
               fast/forms/autofocus-opera-003.html
               fast/forms/autofocus-opera-004.html
               fast/forms/autofocus-opera-005.html
               fast/forms/autofocus-opera-006.html
               fast/forms/autofocus-opera-007.html
               fast/forms/autofocus-opera-008.html

        * dom/Document.cpp: (WebCore::Document::Document): Initialize the flag to ignore autofocus.
        * dom/Document.h:
        * html/HTMLAttributeNames.in:
        * html/HTMLButtonElement.idl:
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::attach): Sets focus onto the appropriate "autofocus" control
        (WebCore::HTMLFormControlElement::autofocus): Autofocus attribute getter
        (WebCore::HTMLFormControlElement::setAutofocus): Autofocus attribute setter
        * html/HTMLFormControlElement.h:
        * html/HTMLInputElement.idl:
        * html/HTMLSelectElement.idl:
        * html/HTMLTextAreaElement.idl:
        * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setUserEdited):
          Sets the "ignore autofocus" flag on document if the user edited the control.
        * rendering/RenderTextControl.h:

LayoutTests:

2008-06-17  Michelangelo De Simone  <m.des@mac.com>

        Reviewed by Adele.

        Tests for https://bugs.webkit.org/show_bug.cgi?id=18887
        Added support for autofocus controls.

        Test cases "autofocus-opera*" have been imported from the Opera test suite
        originally located at:
        http://tc.labs.opera.com/html/forms/input/common-attributes/autofocus/

        * fast/dom/domListEnumeration-expected.txt:
        * fast/dom/resources/domListEnumeration.js:
        * fast/forms/autofocus-attribute-expected.txt: Added.
        * fast/forms/autofocus-attribute.html: Added.
        * fast/forms/autofocus-opera-001-expected.txt: Added.
        * fast/forms/autofocus-opera-001.html: Added.
        * fast/forms/autofocus-opera-002-expected.txt: Added.
        * fast/forms/autofocus-opera-002.html: Added.
        * fast/forms/autofocus-opera-003-expected.txt: Added.
        * fast/forms/autofocus-opera-003.html: Added.
        * fast/forms/autofocus-opera-004-expected.txt: Added.
        * fast/forms/autofocus-opera-004.html: Added.
        * fast/forms/autofocus-opera-005-expected.txt: Added.
        * fast/forms/autofocus-opera-005.html: Added.
        * fast/forms/autofocus-opera-006-expected.txt: Added.
        * fast/forms/autofocus-opera-006.html: Added.
        * fast/forms/autofocus-opera-007-expected.txt: Added.
        * fast/forms/autofocus-opera-007.html: Added.
        * fast/forms/autofocus-opera-008-expected.txt: Added.
        * fast/forms/autofocus-opera-008.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-17 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 17 Jun 2008 17:59:22 +0000 (17:59 +0000)]
2008-06-17  Alp Toker  <alp@nuanti.com>

        Reviewed by Dave Hyatt and Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=19190
        [CAIRO] Canvas rendered as black

        Make sure the frame alpha transparency flag is set to true unless
        we're certain the image data is solid and can be blitted, since the
        Cairo backend implements a fast-path for blittable BitmapImages.

        Thanks to Dirk Schulze for helping to track down this problem.

        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::frameHasAlphaAtIndex):
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::BitmapImage):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::BitmapImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-17 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 17 Jun 2008 16:16:48 +0000 (16:16 +0000)]
2008-06-17  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff.

        <rdar://problem/5951534> JSProfiler: Don't profile console.profile()
        or console.profileEnd()

        * profiler/Profile.cpp:
        (KJS::Profile::stopProfiling): Moved the creation of the (idle) node to
        the Profile (not ProfileNode).  This makes sense since the Profile
        should be the one to modify the profile tree.  Also each stopProfiling()
        does not need to check if it's the head node anymore.  Also fixed an
        oddity where I was using willExecute to create the node.
        (KJS::Profile::removeProfileStart): Removes the call to console.profile
        that started this profile.
        (KJS::Profile::removeProfileEnd): Removes the call to console.profileEnd
        that ended this profile.
        * profiler/Profile.h:
        * profiler/ProfileNode.cpp: Moved the creation of the (idle) node to
        the Profile object.
        (KJS::ProfileNode::stopProfiling):
        * profiler/ProfileNode.h: Added some helper functions and whitespace to
        facilitate readability and the removal of profile() and profileEnd()
        from the Profile tree.
        (KJS::CallIdentifier::operator const char* ):
        (KJS::ProfileNode::firstChild):
        (KJS::ProfileNode::lastChild):
        (KJS::ProfileNode::removeChild):
        (KJS::ProfileNode::toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTypo fix.
mitz@apple.com [Tue, 17 Jun 2008 16:07:07 +0000 (16:07 +0000)]
Typo fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-17 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Tue, 17 Jun 2008 14:59:19 +0000 (14:59 +0000)]
2008-06-17  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber stamped by Adam Robben.

        Include JSGlobalObject.h to fix the build.

        * kjs/ScopeChain.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-17 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Tue, 17 Jun 2008 14:45:54 +0000 (14:45 +0000)]
2008-06-17  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Fix the Qt port by adding ExecState when necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 17 Jun 2008 09:33:26 +0000 (09:33 +0000)]
2008-06-17  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Reduce code duplication in emitReadModifyAssignment().

        * kjs/nodes.cpp:
        (KJS::emitReadModifyAssignment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 17 Jun 2008 08:45:03 +0000 (08:45 +0000)]
2008-06-17  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Sort includes alphabetically.

        * kjs/nodes.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-17 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 17 Jun 2008 08:29:31 +0000 (08:29 +0000)]
2008-06-17  David Hyatt  <hyatt@apple.com>

        Fix for slow performance on CSS selector tests at:

        http://jpsykes.com/153/more-css-performance-testing-pt-2

        Fix <style> element processing so that we don't reparse the entire stylesheet as chunks come in from
        the network (since this is O(n^2)).   Wait for the parser to deliver all of the data before we
        process the sheet for the first time.

        Reviewed by olliej

        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::finishParsingChildren):
        (WebCore::HTMLStyleElement::childrenChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-16 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 17 Jun 2008 06:22:46 +0000 (06:22 +0000)]
2008-06-16  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej.

        Bug 19596: LEAK: Gmail leaks SegmentedVector<RegisterID>
        <https://bugs.webkit.org/show_bug.cgi?id=19596>

        When growing SegmentedVector, we start adding segments at the position
        of the last segment, overwriting it. The destructor frees allocated
        segments starting at the segment of index 1, because the segment of
        index 0 is assumed to be the initial inline segment. This causes a leak
        of the segment that is referenced by index 0. Modifying grow() so that
        it starts adding segments at the position after the last segment fixes
        the leak.

        Since the initial segment is a special case in the lookup code, this
        bug never manifested itself via incorrect results.

        * VM/SegmentedVector.h:
        (KJS::SegmentedVector::grow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-16 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 17 Jun 2008 05:59:09 +0000 (05:59 +0000)]
2008-06-16  Maciej Stachowiak  <mjs@apple.com>

        A handy reference image.

        * blog-files/acid3-timing.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
mjs@apple.com [Tue, 17 Jun 2008 05:31:35 +0000 (05:31 +0000)]
JavaScriptCore:

2008-06-16  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Alexey.

        - removed nearly unused types.h and LocalStorageEntry.h headers

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/ExecState.h:
        * kjs/LocalStorageEntry.h: Removed.
        * kjs/RegExpObject.cpp:
        * kjs/error_object.cpp:
        * kjs/grammar.y:
        * kjs/nodes.cpp:
        * kjs/types.h: Removed.

JavaScriptGlue:

2008-06-16  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Alexey.

        - removed nearly unused types.h and LocalStorageEntry.h headers

        * JSUtils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Tue, 17 Jun 2008 05:07:17 +0000 (05:07 +0000)]
WebCore:

        Reviewed by Justin Garcia.

        - fix <rdar://problem/5973313> REGRESSION (r32508): Down arrow doesn't change caret with non-user entered newlines in textareas

        Test: editing/selection/after-line-break.html

        * dom/Position.cpp:
        (WebCore::Position::getInlineBoxAndOffset): Changed to not include the
        position after a line break in its line box, because that position is
        actually on the next line.

LayoutTests:

        Reviewed by Justin Garcia.

        - test and updated results for <rdar://problem/5973313> REGRESSION (r32508): Down arrow doesn't change caret with non-user entered newlines in textareas

        * editing/selection/after-line-break-expected.txt: Added.
        * editing/selection/after-line-break.html: Added.
        * platform/mac/editing/selection/move-left-right-expected.txt: More bogus warnings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Trying to fix Windows build.
ap@webkit.org [Tue, 17 Jun 2008 04:49:45 +0000 (04:49 +0000)]
    Trying to fix Windows build.

        * WebScriptCallFrame.cpp:
        (WebScriptCallFrame::variableNames):
        (WebScriptCallFrame::valueForVariable):
        Give ExecState to functions that now take it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-16 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 17 Jun 2008 03:49:28 +0000 (03:49 +0000)]
2008-06-16  Alp Toker  <alp@nuanti.com>

        Rubber-stamped by Geoff.

        Change c++ to c in minidom and testapi emacs mode line comments.

        * API/Node.h:
        * API/NodeList.c:
        * API/NodeList.h:
        * API/testapi.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Trying to fix Windows build.
ap@webkit.org [Tue, 17 Jun 2008 03:45:51 +0000 (03:45 +0000)]
    Trying to fix Windows build.

        * kjs/PropertyNameArray.h:
        * kjs/identifier.cpp:
        Include ExecState.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34611 268f45cc-cd09-0410-ab3c-d52691b4dbfc