WebKit-https.git
11 years ago2009-04-21 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 21 Apr 2009 07:02:17 +0000 (07:02 +0000)]
2009-04-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=21546
        [GTK] ATK accessibility enhancements

        Based on a patch by Alp Toker.

        Implement AtkComponent interface.

        * page/gtk/AccessibilityObjectWrapperAtk.cpp:
        (core):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-21 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 21 Apr 2009 07:01:53 +0000 (07:01 +0000)]
2009-04-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=21546
        [GTK] ATK accessibility enhancements

        Implement window<->screen coordinate transformation functions.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::widgetScreenPosition):
        (WebKit::ChromeClient::windowToScreen):
        (WebKit::ChromeClient::screenToWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-21 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 21 Apr 2009 07:01:27 +0000 (07:01 +0000)]
2009-04-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=21546
        [GTK] ATK accessibility enhancements

        Only implement AtkAction interface if we actually have an action.

        * page/gtk/AccessibilityObjectWrapperAtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix
sfalken@apple.com [Tue, 21 Apr 2009 06:41:27 +0000 (06:41 +0000)]
Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 21 Apr 2009 06:34:01 +0000 (06:34 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25290
        REGRESSION(r41732): Crash when constructing XMLHttpRequest in a detached document

        Test: fast/dom/xmlhttprequest-constructor-in-detached-document.html

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::JSAudioConstructor::JSAudioConstructor):
        * bindings/js/JSAudioConstructor.h:
        * bindings/js/JSDOMGlobalObject.h:
        (WebCore::getDOMConstructor):
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::JSImageConstructor::JSImageConstructor):
        * bindings/js/JSImageConstructor.h:
        * bindings/js/JSMessageChannelConstructor.cpp:
        (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
        * bindings/js/JSMessageChannelConstructor.h:
        * bindings/js/JSOptionConstructor.cpp:
        (WebCore::JSOptionConstructor::JSOptionConstructor):
        * bindings/js/JSOptionConstructor.h:
        * bindings/js/JSXMLHttpRequestConstructor.cpp:
        (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
        * bindings/js/JSXMLHttpRequestConstructor.h:
        Avoid accessing JSDOMGlobalObject via ScriptExecutionContext, since it may not
        work during frame teardown.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-20 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 21 Apr 2009 05:58:59 +0000 (05:58 +0000)]
2009-04-20  Geoffrey Garen  <ggaren@apple.com>

        Rubber stamped by Darin Adler and Sam Weinig.

        Renamed "*InlineEventListener*" => "*AttributeEventListener*", and
        "isInline" => "isAttribute".

        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::JSEventListener):
        (WebCore::JSEventListener::~JSEventListener):
        (WebCore::JSEventListener::handleEvent):
        (WebCore::JSEventListener::virtualisAttribute):
        * bindings/js/JSEventListener.h:
        (WebCore::JSEventListener::create):
        (WebCore::JSEventListener::isAttribute):
        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::createAttributeEventListener):
        * bindings/js/JSLazyEventListener.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Element.cpp:
        (WebCore::Element::setWindowAttributeEventListener):
        * dom/Element.h:
        * dom/EventListener.h:
        (WebCore::EventListener::isAttribute):
        (WebCore::EventListener::virtualisAttribute):
        * dom/Node.cpp:
        (WebCore::Node::clearAttributeEventListener):
        (WebCore::Node::setAttributeEventListener):
        (WebCore::Node::getAttributeEventListener):
        (WebCore::Node::onabort):
        (WebCore::Node::setOnabort):
        (WebCore::Node::onblur):
        (WebCore::Node::setOnblur):
        (WebCore::Node::onchange):
        (WebCore::Node::setOnchange):
        (WebCore::Node::onclick):
        (WebCore::Node::setOnclick):
        (WebCore::Node::oncontextmenu):
        (WebCore::Node::setOncontextmenu):
        (WebCore::Node::ondblclick):
        (WebCore::Node::setOndblclick):
        (WebCore::Node::onerror):
        (WebCore::Node::setOnerror):
        (WebCore::Node::onfocus):
        (WebCore::Node::setOnfocus):
        (WebCore::Node::oninput):
        (WebCore::Node::setOninput):
        (WebCore::Node::onkeydown):
        (WebCore::Node::setOnkeydown):
        (WebCore::Node::onkeypress):
        (WebCore::Node::setOnkeypress):
        (WebCore::Node::onkeyup):
        (WebCore::Node::setOnkeyup):
        (WebCore::Node::onload):
        (WebCore::Node::setOnload):
        (WebCore::Node::onmousedown):
        (WebCore::Node::setOnmousedown):
        (WebCore::Node::onmousemove):
        (WebCore::Node::setOnmousemove):
        (WebCore::Node::onmouseout):
        (WebCore::Node::setOnmouseout):
        (WebCore::Node::onmouseover):
        (WebCore::Node::setOnmouseover):
        (WebCore::Node::onmouseup):
        (WebCore::Node::setOnmouseup):
        (WebCore::Node::onmousewheel):
        (WebCore::Node::setOnmousewheel):
        (WebCore::Node::onbeforecut):
        (WebCore::Node::setOnbeforecut):
        (WebCore::Node::oncut):
        (WebCore::Node::setOncut):
        (WebCore::Node::onbeforecopy):
        (WebCore::Node::setOnbeforecopy):
        (WebCore::Node::oncopy):
        (WebCore::Node::setOncopy):
        (WebCore::Node::onbeforepaste):
        (WebCore::Node::setOnbeforepaste):
        (WebCore::Node::onpaste):
        (WebCore::Node::setOnpaste):
        (WebCore::Node::ondragenter):
        (WebCore::Node::setOndragenter):
        (WebCore::Node::ondragover):
        (WebCore::Node::setOndragover):
        (WebCore::Node::ondragleave):
        (WebCore::Node::setOndragleave):
        (WebCore::Node::ondrop):
        (WebCore::Node::setOndrop):
        (WebCore::Node::ondragstart):
        (WebCore::Node::setOndragstart):
        (WebCore::Node::ondrag):
        (WebCore::Node::setOndrag):
        (WebCore::Node::ondragend):
        (WebCore::Node::setOndragend):
        (WebCore::Node::onreset):
        (WebCore::Node::setOnreset):
        (WebCore::Node::onresize):
        (WebCore::Node::setOnresize):
        (WebCore::Node::onscroll):
        (WebCore::Node::setOnscroll):
        (WebCore::Node::onsearch):
        (WebCore::Node::setOnsearch):
        (WebCore::Node::onselect):
        (WebCore::Node::setOnselect):
        (WebCore::Node::onselectstart):
        (WebCore::Node::setOnselectstart):
        (WebCore::Node::onsubmit):
        (WebCore::Node::setOnsubmit):
        (WebCore::Node::onunload):
        (WebCore::Node::setOnunload):
        * dom/Node.h:
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::parseMappedAttribute):
        * html/HTMLButtonElement.cpp:
        (WebCore::HTMLButtonElement::parseMappedAttribute):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::parseMappedAttribute):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::parseMappedAttribute):
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::parseMappedAttribute):
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::parseMappedAttribute):
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::parseMappedAttribute):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseMappedAttribute):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::parseMappedAttribute):
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::parseMappedAttribute):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::parseMappedAttribute):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::parseMappedAttribute):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::mouseButtonListener):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::setAttributeEventListener):
        (WebCore::DOMWindow::clearAttributeEventListener):
        (WebCore::DOMWindow::getAttributeEventListener):
        (WebCore::DOMWindow::onabort):
        (WebCore::DOMWindow::setOnabort):
        (WebCore::DOMWindow::onblur):
        (WebCore::DOMWindow::setOnblur):
        (WebCore::DOMWindow::onchange):
        (WebCore::DOMWindow::setOnchange):
        (WebCore::DOMWindow::onclick):
        (WebCore::DOMWindow::setOnclick):
        (WebCore::DOMWindow::ondblclick):
        (WebCore::DOMWindow::setOndblclick):
        (WebCore::DOMWindow::onerror):
        (WebCore::DOMWindow::setOnerror):
        (WebCore::DOMWindow::onfocus):
        (WebCore::DOMWindow::setOnfocus):
        (WebCore::DOMWindow::onkeydown):
        (WebCore::DOMWindow::setOnkeydown):
        (WebCore::DOMWindow::onkeypress):
        (WebCore::DOMWindow::setOnkeypress):
        (WebCore::DOMWindow::onkeyup):
        (WebCore::DOMWindow::setOnkeyup):
        (WebCore::DOMWindow::onload):
        (WebCore::DOMWindow::setOnload):
        (WebCore::DOMWindow::onmousedown):
        (WebCore::DOMWindow::setOnmousedown):
        (WebCore::DOMWindow::onmousemove):
        (WebCore::DOMWindow::setOnmousemove):
        (WebCore::DOMWindow::onmouseout):
        (WebCore::DOMWindow::setOnmouseout):
        (WebCore::DOMWindow::onmouseover):
        (WebCore::DOMWindow::setOnmouseover):
        (WebCore::DOMWindow::onmouseup):
        (WebCore::DOMWindow::setOnmouseup):
        (WebCore::DOMWindow::onmousewheel):
        (WebCore::DOMWindow::setOnmousewheel):
        (WebCore::DOMWindow::onreset):
        (WebCore::DOMWindow::setOnreset):
        (WebCore::DOMWindow::onresize):
        (WebCore::DOMWindow::setOnresize):
        (WebCore::DOMWindow::onscroll):
        (WebCore::DOMWindow::setOnscroll):
        (WebCore::DOMWindow::onsearch):
        (WebCore::DOMWindow::setOnsearch):
        (WebCore::DOMWindow::onselect):
        (WebCore::DOMWindow::setOnselect):
        (WebCore::DOMWindow::onsubmit):
        (WebCore::DOMWindow::setOnsubmit):
        (WebCore::DOMWindow::onunload):
        (WebCore::DOMWindow::setOnunload):
        (WebCore::DOMWindow::onbeforeunload):
        (WebCore::DOMWindow::setOnbeforeunload):
        (WebCore::DOMWindow::onwebkitanimationstart):
        (WebCore::DOMWindow::setOnwebkitanimationstart):
        (WebCore::DOMWindow::onwebkitanimationiteration):
        (WebCore::DOMWindow::setOnwebkitanimationiteration):
        (WebCore::DOMWindow::onwebkitanimationend):
        (WebCore::DOMWindow::setOnwebkitanimationend):
        (WebCore::DOMWindow::onwebkittransitionend):
        (WebCore::DOMWindow::setOnwebkittransitionend):
        * page/DOMWindow.h:
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::parseMappedAttribute):
        * svg/SVGElementInstance.cpp:
        (WebCore::SVGElementInstance::onabort):
        (WebCore::SVGElementInstance::setOnabort):
        (WebCore::SVGElementInstance::onblur):
        (WebCore::SVGElementInstance::setOnblur):
        (WebCore::SVGElementInstance::onchange):
        (WebCore::SVGElementInstance::setOnchange):
        (WebCore::SVGElementInstance::onclick):
        (WebCore::SVGElementInstance::setOnclick):
        (WebCore::SVGElementInstance::oncontextmenu):
        (WebCore::SVGElementInstance::setOncontextmenu):
        (WebCore::SVGElementInstance::ondblclick):
        (WebCore::SVGElementInstance::setOndblclick):
        (WebCore::SVGElementInstance::onerror):
        (WebCore::SVGElementInstance::setOnerror):
        (WebCore::SVGElementInstance::onfocus):
        (WebCore::SVGElementInstance::setOnfocus):
        (WebCore::SVGElementInstance::oninput):
        (WebCore::SVGElementInstance::setOninput):
        (WebCore::SVGElementInstance::onkeydown):
        (WebCore::SVGElementInstance::setOnkeydown):
        (WebCore::SVGElementInstance::onkeypress):
        (WebCore::SVGElementInstance::setOnkeypress):
        (WebCore::SVGElementInstance::onkeyup):
        (WebCore::SVGElementInstance::setOnkeyup):
        (WebCore::SVGElementInstance::onload):
        (WebCore::SVGElementInstance::setOnload):
        (WebCore::SVGElementInstance::onmousedown):
        (WebCore::SVGElementInstance::setOnmousedown):
        (WebCore::SVGElementInstance::onmousemove):
        (WebCore::SVGElementInstance::setOnmousemove):
        (WebCore::SVGElementInstance::onmouseout):
        (WebCore::SVGElementInstance::setOnmouseout):
        (WebCore::SVGElementInstance::onmouseover):
        (WebCore::SVGElementInstance::setOnmouseover):
        (WebCore::SVGElementInstance::onmouseup):
        (WebCore::SVGElementInstance::setOnmouseup):
        (WebCore::SVGElementInstance::onmousewheel):
        (WebCore::SVGElementInstance::setOnmousewheel):
        (WebCore::SVGElementInstance::onbeforecut):
        (WebCore::SVGElementInstance::setOnbeforecut):
        (WebCore::SVGElementInstance::oncut):
        (WebCore::SVGElementInstance::setOncut):
        (WebCore::SVGElementInstance::onbeforecopy):
        (WebCore::SVGElementInstance::setOnbeforecopy):
        (WebCore::SVGElementInstance::oncopy):
        (WebCore::SVGElementInstance::setOncopy):
        (WebCore::SVGElementInstance::onbeforepaste):
        (WebCore::SVGElementInstance::setOnbeforepaste):
        (WebCore::SVGElementInstance::onpaste):
        (WebCore::SVGElementInstance::setOnpaste):
        (WebCore::SVGElementInstance::ondragenter):
        (WebCore::SVGElementInstance::setOndragenter):
        (WebCore::SVGElementInstance::ondragover):
        (WebCore::SVGElementInstance::setOndragover):
        (WebCore::SVGElementInstance::ondragleave):
        (WebCore::SVGElementInstance::setOndragleave):
        (WebCore::SVGElementInstance::ondrop):
        (WebCore::SVGElementInstance::setOndrop):
        (WebCore::SVGElementInstance::ondragstart):
        (WebCore::SVGElementInstance::setOndragstart):
        (WebCore::SVGElementInstance::ondrag):
        (WebCore::SVGElementInstance::setOndrag):
        (WebCore::SVGElementInstance::ondragend):
        (WebCore::SVGElementInstance::setOndragend):
        (WebCore::SVGElementInstance::onreset):
        (WebCore::SVGElementInstance::setOnreset):
        (WebCore::SVGElementInstance::onresize):
        (WebCore::SVGElementInstance::setOnresize):
        (WebCore::SVGElementInstance::onscroll):
        (WebCore::SVGElementInstance::setOnscroll):
        (WebCore::SVGElementInstance::onsearch):
        (WebCore::SVGElementInstance::setOnsearch):
        (WebCore::SVGElementInstance::onselect):
        (WebCore::SVGElementInstance::setOnselect):
        (WebCore::SVGElementInstance::onselectstart):
        (WebCore::SVGElementInstance::setOnselectstart):
        (WebCore::SVGElementInstance::onsubmit):
        (WebCore::SVGElementInstance::setOnsubmit):
        (WebCore::SVGElementInstance::onunload):
        (WebCore::SVGElementInstance::setOnunload):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
ggaren@apple.com [Tue, 21 Apr 2009 05:17:28 +0000 (05:17 +0000)]
WebCore:

2009-04-20  Geoffrey Garen  <ggaren@apple.com>

        Approved by Mark Rowe, Cameron Zwarich, Oliver Hunt, and Ojan Vafai.

        Used svn merge to roll out revisions 42678, 42690, 42694, 42697 because
        they broke the Tiger and Windows buildbots.

        * css/html4.css:
        * css/themeWin.css:
        * platform/graphics/SimpleFontData.cpp:
        * platform/graphics/SimpleFontData.h:
        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        * platform/graphics/gtk/SimpleFontDataPango.cpp:
        * platform/graphics/mac/SimpleFontDataMac.mm:
        * platform/graphics/qt/SimpleFontDataQt.cpp:
        * platform/graphics/win/SimpleFontDataCGWin.cpp:
        * platform/graphics/win/SimpleFontDataCairoWin.cpp:
        * platform/graphics/win/SimpleFontDataWin.cpp:
        * platform/graphics/wx/SimpleFontDataWx.cpp:
        * rendering/RenderTextControl.cpp:
        * rendering/RenderTextControlMultiLine.cpp:
        * rendering/RenderTextControlSingleLine.cpp:

LayoutTests:

2009-04-20  Geoffrey Garen  <ggaren@apple.com>

        Approved by Mark Rowe, Cameron Zwarich, Oliver Hunt, and Ojan Vafai.

        Used svn merge to roll out revisions 42678, 42690, 42694, 42697 because
        they broke the Tiger and Windows buildbots.

        * fast/forms/drag-out-of-textarea.html:
        * fast/forms/resources/TEMPLATE.html: Removed.
        * fast/forms/resources/text-control-intrinsic-widths.js: Removed.
        * fast/forms/resources/textarea-metrics.js: Removed.
        * fast/forms/search-abs-pos-cancel-button.html:
        * fast/forms/text-control-intrinsic-widths-expected.txt: Removed.
        * fast/forms/text-control-intrinsic-widths.html: Removed.
        * fast/forms/textarea-metrics-expected.txt: Removed.
        * fast/forms/textarea-metrics.html: Removed.
        * fast/forms/textarea-width.html:
        * fast/replaced/table-percent-height-expected.txt:
        * fast/replaced/table-percent-height.html:
        * platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum:
        * platform/mac-leopard/fast/forms/input-text-maxlength-expected.png:
        * platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt:
        * platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum:
        * platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png:
        * platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt:
        * platform/mac/editing/deleting/5168598-expected.checksum:
        * platform/mac/editing/deleting/5168598-expected.png:
        * platform/mac/editing/deleting/5168598-expected.txt:
        * platform/mac/editing/inserting/4960120-1-expected.checksum:
        * platform/mac/editing/inserting/4960120-1-expected.png:
        * platform/mac/editing/inserting/4960120-1-expected.txt:
        * platform/mac/editing/inserting/5607069-2-expected.checksum:
        * platform/mac/editing/inserting/5607069-2-expected.png:
        * platform/mac/editing/inserting/5607069-2-expected.txt:
        * platform/mac/editing/inserting/5607069-3-expected.checksum:
        * platform/mac/editing/inserting/5607069-3-expected.png:
        * platform/mac/editing/inserting/5607069-3-expected.txt:
        * platform/mac/editing/inserting/before-after-input-element-expected.checksum:
        * platform/mac/editing/inserting/before-after-input-element-expected.png:
        * platform/mac/editing/inserting/before-after-input-element-expected.txt:
        * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.checksum:
        * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.png:
        * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
        * platform/mac/editing/pasteboard/4806874-expected.checksum:
        * platform/mac/editing/pasteboard/4806874-expected.png:
        * platform/mac/editing/pasteboard/4806874-expected.txt:
        * platform/mac/editing/pasteboard/drop-text-without-selection-expected.checksum:
        * platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
        * platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
        * platform/mac/editing/pasteboard/input-field-1-expected.checksum:
        * platform/mac/editing/pasteboard/input-field-1-expected.png:
        * platform/mac/editing/pasteboard/input-field-1-expected.txt:
        * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
        * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png:
        * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
        * platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
        * platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png:
        * platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
        * platform/mac/editing/pasteboard/pasting-tabs-expected.checksum:
        * platform/mac/editing/pasteboard/pasting-tabs-expected.png:
        * platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
        * platform/mac/editing/selection/3690703-2-expected.checksum:
        * platform/mac/editing/selection/3690703-2-expected.png:
        * platform/mac/editing/selection/3690703-2-expected.txt:
        * platform/mac/editing/selection/3690703-expected.checksum:
        * platform/mac/editing/selection/3690703-expected.png:
        * platform/mac/editing/selection/3690703-expected.txt:
        * platform/mac/editing/selection/3690719-expected.checksum:
        * platform/mac/editing/selection/3690719-expected.png:
        * platform/mac/editing/selection/3690719-expected.txt:
        * platform/mac/editing/selection/4895428-3-expected.checksum:
        * platform/mac/editing/selection/4895428-3-expected.png:
        * platform/mac/editing/selection/4895428-3-expected.txt:
        * platform/mac/editing/selection/4975120-expected.checksum:
        * platform/mac/editing/selection/4975120-expected.png:
        * platform/mac/editing/selection/4975120-expected.txt:
        * platform/mac/editing/selection/5136696-expected.checksum:
        * platform/mac/editing/selection/5136696-expected.png:
        * platform/mac/editing/selection/5136696-expected.txt:
        * platform/mac/editing/selection/5213963-expected.checksum:
        * platform/mac/editing/selection/5213963-expected.png:
        * platform/mac/editing/selection/5213963-expected.txt:
        * platform/mac/editing/selection/drag-select-1-expected.checksum:
        * platform/mac/editing/selection/drag-select-1-expected.png:
        * platform/mac/editing/selection/drag-select-1-expected.txt:
        * platform/mac/editing/selection/drag-text-delay-expected.checksum:
        * platform/mac/editing/selection/drag-text-delay-expected.png:
        * platform/mac/editing/selection/drag-text-delay-expected.txt:
        * platform/mac/editing/selection/select-from-textfield-outwards-expected.checksum:
        * platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
        * platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
        * platform/mac/fast/block/margin-collapse/103-expected.txt:
        * platform/mac/fast/css/line-height-expected.checksum:
        * platform/mac/fast/css/line-height-expected.png:
        * platform/mac/fast/css/line-height-expected.txt:
        * platform/mac/fast/css/resize-corner-tracking-expected.checksum:
        * platform/mac/fast/css/resize-corner-tracking-expected.png:
        * platform/mac/fast/css/resize-corner-tracking-expected.txt:
        * platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum:
        * platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
        * platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
        * platform/mac/fast/dom/isindex-002-expected.checksum:
        * platform/mac/fast/dom/isindex-002-expected.png:
        * platform/mac/fast/dom/isindex-002-expected.txt:
        * platform/mac/fast/dynamic/008-expected.checksum:
        * platform/mac/fast/dynamic/008-expected.png:
        * platform/mac/fast/dynamic/008-expected.txt:
        * platform/mac/fast/events/autoscroll-expected.checksum:
        * platform/mac/fast/events/autoscroll-expected.png:
        * platform/mac/fast/events/autoscroll-expected.txt:
        * platform/mac/fast/events/context-no-deselect-expected.checksum:
        * platform/mac/fast/events/context-no-deselect-expected.png:
        * platform/mac/fast/events/context-no-deselect-expected.txt:
        * platform/mac/fast/events/label-focus-expected.checksum:
        * platform/mac/fast/events/label-focus-expected.png:
        * platform/mac/fast/events/label-focus-expected.txt:
        * platform/mac/fast/forms/basic-textareas-expected.checksum:
        * platform/mac/fast/forms/basic-textareas-expected.png:
        * platform/mac/fast/forms/basic-textareas-expected.txt:
        * platform/mac/fast/forms/box-shadow-override-expected.checksum:
        * platform/mac/fast/forms/box-shadow-override-expected.png:
        * platform/mac/fast/forms/box-shadow-override-expected.txt:
        * platform/mac/fast/forms/control-restrict-line-height-expected.checksum:
        * platform/mac/fast/forms/control-restrict-line-height-expected.png:
        * platform/mac/fast/forms/control-restrict-line-height-expected.txt:
        * platform/mac/fast/forms/encoding-test-expected.checksum:
        * platform/mac/fast/forms/encoding-test-expected.png:
        * platform/mac/fast/forms/encoding-test-expected.txt:
        * platform/mac/fast/forms/fieldset-align-expected.checksum:
        * platform/mac/fast/forms/fieldset-align-expected.png:
        * platform/mac/fast/forms/fieldset-align-expected.txt:
        * platform/mac/fast/forms/form-element-geometry-expected.checksum:
        * platform/mac/fast/forms/form-element-geometry-expected.png:
        * platform/mac/fast/forms/form-element-geometry-expected.txt:
        * platform/mac/fast/forms/input-align-expected.checksum:
        * platform/mac/fast/forms/input-align-expected.png:
        * platform/mac/fast/forms/input-align-expected.txt:
        * platform/mac/fast/forms/input-appearance-bkcolor-expected.checksum:
        * platform/mac/fast/forms/input-appearance-bkcolor-expected.png:
        * platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
        * platform/mac/fast/forms/input-appearance-default-bkcolor-expected.checksum:
        * platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
        * platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
        * platform/mac/fast/forms/input-appearance-disabled-expected.checksum:
        * platform/mac/fast/forms/input-appearance-disabled-expected.png:
        * platform/mac/fast/forms/input-appearance-disabled-expected.txt:
        * platform/mac/fast/forms/input-appearance-focus-expected.checksum:
        * platform/mac/fast/forms/input-appearance-focus-expected.png:
        * platform/mac/fast/forms/input-appearance-focus-expected.txt:
        * platform/mac/fast/forms/input-appearance-height-expected.checksum:
        * platform/mac/fast/forms/input-appearance-height-expected.png:
        * platform/mac/fast/forms/input-appearance-height-expected.txt:
        * platform/mac/fast/forms/input-appearance-preventDefault-expected.checksum:
        * platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
        * platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
        * platform/mac/fast/forms/input-appearance-readonly-expected.checksum:
        * platform/mac/fast/forms/input-appearance-readonly-expected.png:
        * platform/mac/fast/forms/input-appearance-readonly-expected.txt:
        * platform/mac/fast/forms/input-appearance-selection-expected.checksum:
        * platform/mac/fast/forms/input-appearance-selection-expected.png:
        * platform/mac/fast/forms/input-appearance-selection-expected.txt:
        * platform/mac/fast/forms/input-appearance-visibility-expected.checksum:
        * platform/mac/fast/forms/input-appearance-visibility-expected.png:
        * platform/mac/fast/forms/input-appearance-visibility-expected.txt:
        * platform/mac/fast/forms/input-appearance-width-expected.checksum:
        * platform/mac/fast/forms/input-appearance-width-expected.png:
        * platform/mac/fast/forms/input-appearance-width-expected.txt:
        * platform/mac/fast/forms/input-baseline-expected.checksum:
        * platform/mac/fast/forms/input-baseline-expected.png:
        * platform/mac/fast/forms/input-baseline-expected.txt:
        * platform/mac/fast/forms/input-disabled-color-expected.checksum:
        * platform/mac/fast/forms/input-disabled-color-expected.png:
        * platform/mac/fast/forms/input-disabled-color-expected.txt:
        * platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.checksum:
        * platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
        * platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
        * platform/mac/fast/forms/input-paste-undo-expected.checksum:
        * platform/mac/fast/forms/input-paste-undo-expected.png:
        * platform/mac/fast/forms/input-paste-undo-expected.txt:
        * platform/mac/fast/forms/input-readonly-autoscroll-expected.checksum:
        * platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
        * platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
        * platform/mac/fast/forms/input-readonly-dimmed-expected.checksum:
        * platform/mac/fast/forms/input-readonly-dimmed-expected.png:
        * platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
        * platform/mac/fast/forms/input-readonly-empty-expected.checksum:
        * platform/mac/fast/forms/input-readonly-empty-expected.png:
        * platform/mac/fast/forms/input-readonly-empty-expected.txt:
        * platform/mac/fast/forms/input-spaces-expected.checksum:
        * platform/mac/fast/forms/input-spaces-expected.png:
        * platform/mac/fast/forms/input-spaces-expected.txt:
        * platform/mac/fast/forms/input-table-expected.txt:
        * platform/mac/fast/forms/input-text-click-inside-expected.checksum:
        * platform/mac/fast/forms/input-text-click-inside-expected.png:
        * platform/mac/fast/forms/input-text-click-inside-expected.txt:
        * platform/mac/fast/forms/input-text-click-outside-expected.checksum:
        * platform/mac/fast/forms/input-text-click-outside-expected.png:
        * platform/mac/fast/forms/input-text-click-outside-expected.txt:
        * platform/mac/fast/forms/input-text-double-click-expected.checksum:
        * platform/mac/fast/forms/input-text-double-click-expected.png:
        * platform/mac/fast/forms/input-text-double-click-expected.txt:
        * platform/mac/fast/forms/input-text-drag-down-expected.checksum:
        * platform/mac/fast/forms/input-text-drag-down-expected.png:
        * platform/mac/fast/forms/input-text-drag-down-expected.txt:
        * platform/mac/fast/forms/input-text-option-delete-expected.checksum:
        * platform/mac/fast/forms/input-text-option-delete-expected.png:
        * platform/mac/fast/forms/input-text-option-delete-expected.txt:
        * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.checksum:
        * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
        * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
        * platform/mac/fast/forms/input-text-self-emptying-click-expected.checksum:
        * platform/mac/fast/forms/input-text-self-emptying-click-expected.png:
        * platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
        * platform/mac/fast/forms/input-text-word-wrap-expected.checksum:
        * platform/mac/fast/forms/input-text-word-wrap-expected.png:
        * platform/mac/fast/forms/input-text-word-wrap-expected.txt:
        * platform/mac/fast/forms/input-type-change2-expected.checksum:
        * platform/mac/fast/forms/input-type-change2-expected.png:
        * platform/mac/fast/forms/input-type-change2-expected.txt:
        * platform/mac/fast/forms/input-type-text-min-width-expected.checksum:
        * platform/mac/fast/forms/input-type-text-min-width-expected.png:
        * platform/mac/fast/forms/input-type-text-min-width-expected.txt:
        * platform/mac/fast/forms/input-value-expected.checksum:
        * platform/mac/fast/forms/input-value-expected.png:
        * platform/mac/fast/forms/input-value-expected.txt:
        * platform/mac/fast/forms/input-width-expected.checksum:
        * platform/mac/fast/forms/input-width-expected.png:
        * platform/mac/fast/forms/input-width-expected.txt:
        * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
        * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
        * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
        * platform/mac/fast/forms/negativeLineHeight-expected.checksum:
        * platform/mac/fast/forms/negativeLineHeight-expected.png:
        * platform/mac/fast/forms/negativeLineHeight-expected.txt:
        * platform/mac/fast/forms/password-placeholder-expected.checksum:
        * platform/mac/fast/forms/password-placeholder-expected.png:
        * platform/mac/fast/forms/password-placeholder-expected.txt:
        * platform/mac/fast/forms/password-placeholder-text-security-expected.checksum:
        * platform/mac/fast/forms/password-placeholder-text-security-expected.png:
        * platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
        * platform/mac/fast/forms/placeholder-pseudo-style-expected.checksum:
        * platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
        * platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
        * platform/mac/fast/forms/placeholder-set-attribute-expected.checksum:
        * platform/mac/fast/forms/placeholder-set-attribute-expected.png:
        * platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
        * platform/mac/fast/forms/placeholder-set-value-expected.checksum:
        * platform/mac/fast/forms/placeholder-set-value-expected.png:
        * platform/mac/fast/forms/placeholder-set-value-expected.txt:
        * platform/mac/fast/forms/search-cancel-button-style-sharing-expected.checksum:
        * platform/mac/fast/forms/search-cancel-button-style-sharing-expected.png:
        * platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/mac/fast/forms/search-display-none-cancel-button-expected.checksum:
        * platform/mac/fast/forms/search-display-none-cancel-button-expected.png:
        * platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
        * platform/mac/fast/forms/search-placeholder-value-changed-expected.checksum:
        * platform/mac/fast/forms/search-placeholder-value-changed-expected.png:
        * platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/mac/fast/forms/search-rtl-expected.checksum:
        * platform/mac/fast/forms/search-rtl-expected.png:
        * platform/mac/fast/forms/search-rtl-expected.txt:
        * platform/mac/fast/forms/search-transformed-expected.checksum:
        * platform/mac/fast/forms/search-transformed-expected.png:
        * platform/mac/fast/forms/search-transformed-expected.txt:
        * platform/mac/fast/forms/search-zoomed-expected.checksum:
        * platform/mac/fast/forms/search-zoomed-expected.png:
        * platform/mac/fast/forms/search-zoomed-expected.txt:
        * platform/mac/fast/forms/searchfield-heights-expected.checksum:
        * platform/mac/fast/forms/searchfield-heights-expected.png:
        * platform/mac/fast/forms/searchfield-heights-expected.txt:
        * platform/mac/fast/forms/tabbing-input-iframe-expected.checksum:
        * platform/mac/fast/forms/tabbing-input-iframe-expected.png:
        * platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
        * platform/mac/fast/forms/textAreaLineHeight-expected.checksum:
        * platform/mac/fast/forms/textAreaLineHeight-expected.png:
        * platform/mac/fast/forms/textAreaLineHeight-expected.txt:
        * platform/mac/fast/forms/textarea-align-expected.checksum:
        * platform/mac/fast/forms/textarea-align-expected.png:
        * platform/mac/fast/forms/textarea-align-expected.txt:
        * platform/mac/fast/forms/textarea-rows-cols-expected.checksum:
        * platform/mac/fast/forms/textarea-rows-cols-expected.png:
        * platform/mac/fast/forms/textarea-rows-cols-expected.txt:
        * platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
        * platform/mac/fast/forms/textarea-scroll-height-expected.png:
        * platform/mac/fast/forms/textarea-scroll-height-expected.txt:
        * platform/mac/fast/forms/textarea-scrollbar-expected.checksum:
        * platform/mac/fast/forms/textarea-scrollbar-expected.png:
        * platform/mac/fast/forms/textarea-scrollbar-expected.txt:
        * platform/mac/fast/forms/textarea-scrolled-type-expected.checksum:
        * platform/mac/fast/forms/textarea-scrolled-type-expected.png:
        * platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
        * platform/mac/fast/forms/textarea-setinnerhtml-expected.checksum:
        * platform/mac/fast/forms/textarea-setinnerhtml-expected.png:
        * platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
        * platform/mac/fast/forms/textarea-width-expected.checksum:
        * platform/mac/fast/forms/textarea-width-expected.png:
        * platform/mac/fast/forms/textarea-width-expected.txt:
        * platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum:
        * platform/mac/fast/forms/textfield-drag-into-disabled-expected.png:
        * platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
        * platform/mac/fast/forms/textfield-outline-expected.checksum:
        * platform/mac/fast/forms/textfield-outline-expected.png:
        * platform/mac/fast/forms/textfield-outline-expected.txt:
        * platform/mac/fast/forms/textfield-overflow-expected.checksum:
        * platform/mac/fast/forms/textfield-overflow-expected.png:
        * platform/mac/fast/forms/textfield-overflow-expected.txt:
        * platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
        * platform/mac/fast/invalid/residual-style-expected.txt:
        * platform/mac/fast/lists/dynamic-marker-crash-expected.checksum:
        * platform/mac/fast/lists/dynamic-marker-crash-expected.png:
        * platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
        * platform/mac/fast/overflow/overflow-x-y-expected.checksum:
        * platform/mac/fast/overflow/overflow-x-y-expected.png:
        * platform/mac/fast/overflow/overflow-x-y-expected.txt:
        * platform/mac/fast/parser/comment-in-textarea-expected.checksum:
        * platform/mac/fast/parser/comment-in-textarea-expected.png:
        * platform/mac/fast/parser/comment-in-textarea-expected.txt:
        * platform/mac/fast/parser/entity-comment-in-textarea-expected.checksum:
        * platform/mac/fast/parser/entity-comment-in-textarea-expected.png:
        * platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
        * platform/mac/fast/parser/open-comment-in-textarea-expected.checksum:
        * platform/mac/fast/parser/open-comment-in-textarea-expected.png:
        * platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
        * platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
        * platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
        * platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
        * platform/mac/fast/repaint/search-field-cancel-expected.checksum:
        * platform/mac/fast/repaint/search-field-cancel-expected.png:
        * platform/mac/fast/repaint/search-field-cancel-expected.txt:
        * platform/mac/fast/repaint/subtree-root-skipped-expected.checksum:
        * platform/mac/fast/repaint/subtree-root-skipped-expected.png:
        * platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
        * platform/mac/fast/replaced/replaced-breaking-expected.checksum:
        * platform/mac/fast/replaced/replaced-breaking-expected.png:
        * platform/mac/fast/replaced/replaced-breaking-expected.txt:
        * platform/mac/fast/replaced/replaced-breaking-mixture-expected.checksum:
        * platform/mac/fast/replaced/replaced-breaking-mixture-expected.png:
        * platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
        * platform/mac/fast/replaced/width100percent-searchfield-expected.checksum:
        * platform/mac/fast/replaced/width100percent-searchfield-expected.png:
        * platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
        * platform/mac/fast/replaced/width100percent-textarea-expected.checksum:
        * platform/mac/fast/replaced/width100percent-textarea-expected.png:
        * platform/mac/fast/replaced/width100percent-textarea-expected.txt:
        * platform/mac/fast/replaced/width100percent-textfield-expected.checksum:
        * platform/mac/fast/replaced/width100percent-textfield-expected.png:
        * platform/mac/fast/replaced/width100percent-textfield-expected.txt:
        * platform/mac/fast/table/003-expected.checksum:
        * platform/mac/fast/table/003-expected.png:
        * platform/mac/fast/table/003-expected.txt:
        * platform/mac/fast/table/colspanMinWidth-expected.checksum:
        * platform/mac/fast/table/colspanMinWidth-expected.png:
        * platform/mac/fast/table/colspanMinWidth-expected.txt:
        * platform/mac/fast/table/spanOverlapRepaint-expected.checksum:
        * platform/mac/fast/table/spanOverlapRepaint-expected.png:
        * platform/mac/fast/table/spanOverlapRepaint-expected.txt:
        * platform/mac/fast/table/text-field-baseline-expected.checksum:
        * platform/mac/fast/table/text-field-baseline-expected.png:
        * platform/mac/fast/table/text-field-baseline-expected.txt:
        * platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.checksum:
        * platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.png:
        * platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
        * platform/mac/fast/text/textIteratorNilRenderer-expected.checksum:
        * platform/mac/fast/text/textIteratorNilRenderer-expected.png:
        * platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
        * platform/mac/fast/transforms/transformed-focused-text-input-expected.checksum:
        * platform/mac/fast/transforms/transformed-focused-text-input-expected.png:
        * platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
        * platform/mac/http/tests/navigation/anchor-basic-expected.checksum:
        * platform/mac/http/tests/navigation/anchor-basic-expected.png:
        * platform/mac/http/tests/navigation/anchor-basic-expected.txt:
        * platform/mac/http/tests/navigation/anchor-frames-expected.txt:
        * platform/mac/http/tests/navigation/anchor-goback-expected.checksum:
        * platform/mac/http/tests/navigation/anchor-goback-expected.png:
        * platform/mac/http/tests/navigation/anchor-goback-expected.txt:
        * platform/mac/http/tests/navigation/anchor-subframeload-expected.txt:
        * platform/mac/http/tests/navigation/javascriptlink-basic-expected.checksum:
        * platform/mac/http/tests/navigation/javascriptlink-basic-expected.png:
        * platform/mac/http/tests/navigation/javascriptlink-basic-expected.txt:
        * platform/mac/http/tests/navigation/javascriptlink-frames-expected.checksum:
        * platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
        * platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
        * platform/mac/http/tests/navigation/javascriptlink-goback-expected.checksum:
        * platform/mac/http/tests/navigation/javascriptlink-goback-expected.png:
        * platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt:
        * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.checksum:
        * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.png:
        * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.txt:
        * platform/mac/http/tests/navigation/metaredirect-basic-expected.checksum:
        * platform/mac/http/tests/navigation/metaredirect-basic-expected.png:
        * platform/mac/http/tests/navigation/metaredirect-basic-expected.txt:
        * platform/mac/http/tests/navigation/metaredirect-frames-expected.checksum:
        * platform/mac/http/tests/navigation/metaredirect-frames-expected.png:
        * platform/mac/http/tests/navigation/metaredirect-frames-expected.txt:
        * platform/mac/http/tests/navigation/metaredirect-goback-expected.checksum:
        * platform/mac/http/tests/navigation/metaredirect-goback-expected.png:
        * platform/mac/http/tests/navigation/metaredirect-goback-expected.txt:
        * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.checksum:
        * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.png:
        * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.txt:
        * platform/mac/http/tests/navigation/post-goback2-expected.checksum:
        * platform/mac/http/tests/navigation/post-goback2-expected.png:
        * platform/mac/http/tests/navigation/post-goback2-expected.txt:
        * platform/mac/http/tests/navigation/postredirect-goback2-expected.checksum:
        * platform/mac/http/tests/navigation/postredirect-goback2-expected.png:
        * platform/mac/http/tests/navigation/postredirect-goback2-expected.txt:
        * platform/mac/http/tests/navigation/redirect302-basic-expected.checksum:
        * platform/mac/http/tests/navigation/redirect302-basic-expected.png:
        * platform/mac/http/tests/navigation/redirect302-basic-expected.txt:
        * platform/mac/http/tests/navigation/redirect302-frames-expected.checksum:
        * platform/mac/http/tests/navigation/redirect302-frames-expected.png:
        * platform/mac/http/tests/navigation/redirect302-frames-expected.txt:
        * platform/mac/http/tests/navigation/redirect302-goback-expected.checksum:
        * platform/mac/http/tests/navigation/redirect302-goback-expected.png:
        * platform/mac/http/tests/navigation/redirect302-goback-expected.txt:
        * platform/mac/http/tests/navigation/redirect302-subframeload-expected.checksum:
        * platform/mac/http/tests/navigation/redirect302-subframeload-expected.png:
        * platform/mac/http/tests/navigation/redirect302-subframeload-expected.txt:
        * platform/mac/http/tests/navigation/relativeanchor-basic-expected.checksum:
        * platform/mac/http/tests/navigation/relativeanchor-basic-expected.png:
        * platform/mac/http/tests/navigation/relativeanchor-basic-expected.txt:
        * platform/mac/http/tests/navigation/relativeanchor-frames-expected.txt:
        * platform/mac/http/tests/navigation/relativeanchor-goback-expected.checksum:
        * platform/mac/http/tests/navigation/relativeanchor-goback-expected.png:
        * platform/mac/http/tests/navigation/relativeanchor-goback-expected.txt:
        * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.checksum:
        * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.png:
        * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.txt:
        * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.checksum:
        * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.png:
        * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.txt:
        * platform/mac/http/tests/navigation/success200-basic-expected.checksum:
        * platform/mac/http/tests/navigation/success200-basic-expected.png:
        * platform/mac/http/tests/navigation/success200-basic-expected.txt:
        * platform/mac/http/tests/navigation/success200-frames-expected.checksum:
        * platform/mac/http/tests/navigation/success200-frames-expected.png:
        * platform/mac/http/tests/navigation/success200-frames-expected.txt:
        * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.checksum:
        * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.png:
        * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt:
        * platform/mac/http/tests/navigation/success200-goback-expected.checksum:
        * platform/mac/http/tests/navigation/success200-goback-expected.png:
        * platform/mac/http/tests/navigation/success200-goback-expected.txt:
        * platform/mac/http/tests/navigation/success200-loadsame-expected.checksum:
        * platform/mac/http/tests/navigation/success200-loadsame-expected.png:
        * platform/mac/http/tests/navigation/success200-loadsame-expected.txt:
        * platform/mac/http/tests/navigation/success200-reload-expected.checksum:
        * platform/mac/http/tests/navigation/success200-reload-expected.png:
        * platform/mac/http/tests/navigation/success200-reload-expected.txt:
        * platform/mac/http/tests/navigation/success200-subframeload-expected.checksum:
        * platform/mac/http/tests/navigation/success200-subframeload-expected.png:
        * platform/mac/http/tests/navigation/success200-subframeload-expected.txt:
        * platform/mac/http/tests/navigation/timerredirect-basic-expected.checksum:
        * platform/mac/http/tests/navigation/timerredirect-basic-expected.png:
        * platform/mac/http/tests/navigation/timerredirect-basic-expected.txt:
        * platform/mac/http/tests/navigation/timerredirect-frames-expected.checksum:
        * platform/mac/http/tests/navigation/timerredirect-frames-expected.png:
        * platform/mac/http/tests/navigation/timerredirect-frames-expected.txt:
        * platform/mac/http/tests/navigation/timerredirect-goback-expected.checksum:
        * platform/mac/http/tests/navigation/timerredirect-goback-expected.png:
        * platform/mac/http/tests/navigation/timerredirect-goback-expected.txt:
        * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.checksum:
        * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.png:
        * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.txt:
        * platform/mac/svg/custom/inline-svg-in-xhtml-expected.checksum:
        * platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
        * platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
        * platform/mac/svg/hixie/mixed/003-expected.checksum:
        * platform/mac/svg/hixie/mixed/003-expected.png:
        * platform/mac/svg/hixie/mixed/003-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug1188-expected.png:
        * platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug12384-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug12384-expected.png:
        * platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug18359-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug18359-expected.png:
        * platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug194024-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug194024-expected.png:
        * platform/mac/tables/mozilla/bugs/bug194024-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug24200-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug24200-expected.png:
        * platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug2479-2-expected.png:
        * platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug2479-3-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug2479-3-expected.png:
        * platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug28928-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug28928-expected.png:
        * platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug30559-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug30559-expected.png:
        * platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug30692-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug30692-expected.png:
        * platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug4382-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug4382-expected.png:
        * platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug4527-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug4527-expected.png:
        * platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug46368-1-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug46368-1-expected.png:
        * platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug46368-2-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug46368-2-expected.png:
        * platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug51037-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug51037-expected.png:
        * platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug55545-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug55545-expected.png:
        * platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug59354-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug59354-expected.png:
        * platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug7342-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug7342-expected.png:
        * platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug96334-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug96334-expected.png:
        * platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug99948-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug99948-expected.png:
        * platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
        * platform/mac/tables/mozilla/dom/tableDom-expected.checksum:
        * platform/mac/tables/mozilla/dom/tableDom-expected.png:
        * platform/mac/tables/mozilla/dom/tableDom-expected.txt:
        * platform/mac/tables/mozilla/other/move_row-expected.checksum:
        * platform/mac/tables/mozilla/other/move_row-expected.png:
        * platform/mac/tables/mozilla/other/move_row-expected.txt:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.checksum:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
        * platform/win/Skipped:
        * svg/custom/resources/svg-fonts-in-text-controls.js:
        * svg/custom/svg-fonts-in-text-controls-expected.txt:
        * svg/custom/svg-fonts-in-text-controls.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-20 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 21 Apr 2009 04:26:15 +0000 (04:26 +0000)]
2009-04-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Not reviewed, typo fix.

        Rename erroneous lines in Skipped to actual test URLs.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix
aroben@apple.com [Tue, 21 Apr 2009 03:50:23 +0000 (03:50 +0000)]
    Build fix

        * MemoryStream.cpp:
        (MemoryStream::Clone): Fix typo introduced when implementing
        suggestions from patch review.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-20 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 21 Apr 2009 03:48:24 +0000 (03:48 +0000)]
2009-04-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Adam Roben.

        One last loose end, discovered using COLLECT_ON_EVERY_ALLOCATION, for
        https://bugs.webkit.org/show_bug.cgi?id=21260
        Unbounded memory growth when churning elements with anonymous event handler functions

        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::mark): Don't ASSERT that an ElementInstance's
        correspondingElement has a JS wrapper. If a GC falls exactly between the
        allocation of the ElementInstance wrapper and the correspondingElement
        wrapper, the correspondingElement won't have a wrapper at the time we
        mark the ElementInstance's wrapper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-20 Ojan Vafai <ojan@chromium.org>
dglazkov@chromium.org [Tue, 21 Apr 2009 03:45:03 +0000 (03:45 +0000)]
2009-04-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Roben.

        Add Windows failures temporarily to the Skipped list after r42678.
        See https://bugs.webkit.org/show_bug.cgi?id=25306 for more
        information. This is just to get the tree green while the tests
        are fixed.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago First part of <rdar://6395825> It takes over 20 sec to launch Safari with...
aroben@apple.com [Tue, 21 Apr 2009 03:42:59 +0000 (03:42 +0000)]
    First part of <rdar://6395825> It takes over 20 sec to launch Safari with 500KB history file

        This ports the changes that were made to WebKit/mac's WebHistory
        implementation in r25275 to WebKit/win. WebHistory now stores a
        HashMap from CFAbsoluteTime (stored as int64_t) to CFArray of
        IWebHistoryItem*. The HashMap lets us look up the CFArray for a
        particular day's history in constant time rather than linear time. The
        precise reasons why we store the CFAbsoluteTime as an int64_t are lost
        to the mists of time, but it is likely because these CFAbsoluteTimes
        never have a decimal part, and integer comparisons are faster than
        floating-point comparisons, so storing them as int64_t should improve
        performance without losing precision. We also now use a binary search
        instead of a linear search when determining the index at which to
        insert a WebHistoryItem into its day's CFArray.

        This patch reduces the time needed to load a 100,000-item
        History.plist from ~15 seconds to ~7.5 seconds. Further improvements
        could likely be made by reducing the number of string conversions,
        reducing calls to CFTimeZone functions, and removing all the
        WebHistoryItemsAdded notifications that are sent (Mac doesn't send any
        while loading history).

        Reviewed by Darin Adler.

        * WebHistory.cpp:
        (WebHistoryWriter::WebHistoryWriter): Changed to take a
        DateToEntriesMap instead of a CFArrayRef. Initialize m_dateKeys to
        contain the keys from m_entriesByDate in ascending order.
        (WebHistoryWriter::writeHistoryItems): Now loops through m_dateKeys in
        reverse order and gets the entries array from the DateToEntriesMap.
        (WebHistory::WebHistory): Removed code to initialize
        m_datesWithEntries (which has been removed) and m_entriesByDate (which
        has been converted to a HashMap).
        (WebHistory::removeAllItems): Clear out m_entriesByDate and
        m_orderedLastVisitedDays.
        (WebHistory::orderedLastVisitedDays): If we don't already have a
        cached m_orderedLastVisitedDays array, create one by converting the
        keys from m_entriesByDate to DATEs and sorting them in descending
        order. Then copy m_orderedLastVisitedDays to the output buffer.
        (WebHistory::orderedItemsLastVisitedOnDay): Updated to use findKey
        instead of findIndex and to treat m_entriesByDate as a HashMap.
        Now that the items in each day's CFArray are stored in descending
        order (newest to oldest), we don't have to reverse them when filling
        in the output buffer. (The old comment about putting the items in
        oldest-to-newest order was incorrect -- it was putting them in
        newest-to-oldest order.)

        (WebHistory::addItemToDateCaches):
        (WebHistory::removeItemFromDateCaches):
        Changed to use findKey instead of findIndex and to treat
        m_entriesByDate as a HashMap. If we're adding a key to or removing a
        key from m_entriesByDate, also clear m_orderedLastVisitedDays so that
        we will regenerate it for the current set of keys the next time it is
        needed.

        (timeIntervalForBeginningOfDay): Added. Returns the CFAbsoluteTime
        that corresponds to the beginning of the day in which the passed-in
        DATE occurs.
        (WebHistory::findKey): Returns the key used in m_entriesByDate to
        store the CFArray that should contain the IWebHistoryItem that
        corresponds to the passed-in DATE. Replaces findIndex.
        (WebHistory::insertItem): Changed to treat m_entriesByDate as a
        HashMap rather than a CFArray. We now optimize for inserting at the
        beginning and end of the array, and use a binary rather than linear
        search when inserting into the middle of the array.
        (WebHistory::data): Changed to treat m_entriesByDate as a HashMap.

        * WebHistory.h: Changed m_entriesByDate to a DateToEntriesMap, removed
        m_datesWithEntries, added m_orderedLastVisitedDays.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Change MemoryStream::createInstance to return a COMPtr
aroben@apple.com [Tue, 21 Apr 2009 03:42:44 +0000 (03:42 +0000)]
    Change MemoryStream::createInstance to return a COMPtr

        Part of Bug 25294: All WebKit/win classes should return COMPtrs from
        their static constructor members
        <https://bugs.webkit.org/show_bug.cgi?id=25294>

        Reviewed by Darin Adler.

        * MemoryStream.cpp:
        (MemoryStream::createInstance): Changed to return a COMPtr.
        (MemoryStream::Clone): Updated for createInstance change.
        * MemoryStream.h: Changed createInstance to return a COMPtr.

        * WebArchive.cpp:
        (WebArchive::data):
        * WebCoreSupport/EmbeddedWidget.cpp:
        (EmbeddedWidget::didReceiveData):
        * WebDataSource.cpp:
        (WebDataSource::data):
        * WebHistory.cpp:
        (WebHistory::data):
        * WebIconFetcher.cpp:
        (WebIconFetcherClient::finishedFetchingIcon):
        * WebResource.cpp:
        (WebResource::createInstance):
        Updated for changes to MemoryStream::createInstance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix Bug 25295: Remove WebKit/win code that was used for Drosera support
aroben@apple.com [Tue, 21 Apr 2009 03:42:26 +0000 (03:42 +0000)]
    Fix Bug 25295: Remove WebKit/win code that was used for Drosera support

        <https://bugs.webkit.org/show_bug.cgi?id=25295>

        Reviewed by Sam Weinig.

        * ForEachCoClass.h: Removed WebScriptDebugServer.

        * Interfaces/WebKit.idl: Removed WebScriptDebugServer and references
        to removed IDL files.

        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/WebKit.vcproj:
        Removed IDL and source files for IWebScriptCallFrame,
        IWebScriptDebugListener, IWebScriptDebugServer, WebScriptCallFrame,
        and WebScriptDebugServer.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        * WebKitClassFactory.cpp:
        * WebKitDLL.cpp:
        Removed #includes of WebScriptDebugServer.h.

        * Interfaces/IWebScriptCallFrame.idl: Removed.
        * Interfaces/IWebScriptDebugListener.idl: Removed.
        * Interfaces/IWebScriptDebugServer.idl: Removed.
        * WebScriptCallFrame.cpp: Removed.
        * WebScriptCallFrame.h: Removed.
        * WebScriptDebugServer.cpp: Removed.
        * WebScriptDebugServer.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-20 Ojan Vafai <ojan@chromium.org>
levin@chromium.org [Tue, 21 Apr 2009 00:57:04 +0000 (00:57 +0000)]
2009-04-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel

        Fix svg-fonts-in-text-controls.js to measure the
        widths after the SVG font has loaded.

        For now the expected results have the success line
        printed before the metrics being measured. I'll fix
        this in a following commit. See
        https://bugs.webkit.org/show_bug.cgi?id=25302
        for more details.

        * svg/custom/resources/svg-fonts-in-text-controls.js:
        * svg/custom/svg-fonts-in-text-controls-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago More Windows build fixes.
sfalken@apple.com [Mon, 20 Apr 2009 23:36:43 +0000 (23:36 +0000)]
    More Windows build fixes.

        * JavaScriptCore.vcproj/JavaScriptCore.make: Copy DLLs, PDBs.
        * JavaScriptCore.vcproj/JavaScriptCore.resources: Added.
        * JavaScriptCore.vcproj/JavaScriptCore.resources/Info.plist: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add version stamping, resource copying.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-20 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 20 Apr 2009 22:32:24 +0000 (22:32 +0000)]
2009-04-20  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Mark Rowe

        Clean builds are broken on case-sensitive filesystems.  Let's fix, shall we?

        * platform/graphics/SimpleFontData.cpp: Remove "String.h" include.  Ojan probably intended to include
          "PlatformString.h" which was unnecessary because it is pulled in through other headers.  This wasn't a
          build failure on case-insensitive file systems because those systems would find the system <string.h>, averting
          the warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-20 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 20 Apr 2009 22:32:06 +0000 (22:32 +0000)]
2009-04-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Last patch for https://bugs.webkit.org/show_bug.cgi?id=21260
        Unbounded memory growth when churning elements with anonymous event handler functions

        Converted "lazy" event listeners to be unprotected, just like all the others.

        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::JSEventListener):
        (WebCore::JSEventListener::~JSEventListener):
        (WebCore::JSEventListener::jsFunction):
        (WebCore::JSEventListener::markJSFunction):
        (WebCore::JSEventListener::handleEvent):
        (WebCore::JSEventListener::virtualIsInline):
        * bindings/js/JSEventListener.h:
        (WebCore::JSEventListener::isInline): Merged JSAbstractEventListener
        into JSEventListener. Now that the only difference between JSEventListener
        and JSLazyEventListener is that JSLazyEventListener compiles lazily,
        there's no need for an abstract base class.

        * bindings/js/JSLazyEventListener.cpp: Converted JSLazyEventListener to
        inherit from JSEventListener and match its un-GC-protected behavior.
        (WebCore::JSLazyEventListener::JSLazyEventListener): ditto
        (WebCore::JSLazyEventListener::parseCode): ditto
        (WebCore::createInlineEventListener): When creating a lazy event listener,
        ensure that the related node has a JS wrapper to mark the listener. Since
        the parser makes these listeners, it's possible that no JS reference has
        been made to the node yet.
        * bindings/js/JSLazyEventListener.h: ditto

        * dom/EventListener.h:
        (WebCore::EventListener::clearJSFunction): Removed an usused function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFixed typo.
justin.garcia@apple.com [Mon, 20 Apr 2009 22:30:50 +0000 (22:30 +0000)]
Fixed typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-20 Justin Garcia <justin.garcia@apple.com>
justin.garcia@apple.com [Mon, 20 Apr 2009 22:28:38 +0000 (22:28 +0000)]
2009-04-20  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=25299
        Don't bound caret to root line box if it is still inside its containing block

        Can't yet write tests for behavior of non-standard caret widths.

        * rendering/RenderText.cpp:
        (WebCore::RenderText::localCaretRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix
sfalken@apple.com [Mon, 20 Apr 2009 21:47:27 +0000 (21:47 +0000)]
Build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix
sfalken@apple.com [Mon, 20 Apr 2009 21:47:02 +0000 (21:47 +0000)]
Build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix
sfalken@apple.com [Mon, 20 Apr 2009 21:46:06 +0000 (21:46 +0000)]
Build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKitTools:
darin@apple.com [Mon, 20 Apr 2009 21:36:56 +0000 (21:36 +0000)]
WebKitTools:

2009-04-20  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added PlainTextController.h
        and PlainTextController.mm.

        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): Added PlainTextController
        as "window.plainText".

        * DumpRenderTree/mac/PlainTextController.h: Added.
        * DumpRenderTree/mac/PlainTextController.mm: Added.

LayoutTests:

2009-04-20  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        * fast/dom/Window/window-properties.html: Added a new DumpRenderTree window
        object property, plainText.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
sfalken@apple.com [Mon, 20 Apr 2009 21:25:37 +0000 (21:25 +0000)]
JavaScriptCore:

2009-04-20  Steve Falkenburg  <sfalken@apple.com>

        Separate JavaScriptCore.dll from WebKit.dll.
        Slight performance improvement or no change on benchmarks.

        Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
        and simplifies standalone JavaScriptCore builds.

        Reviewed by Oliver Hunt.

        * API/JSBase.h: Export symbols with JS_EXPORT when using MSVC.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj: Build JavaScriptCore as a DLL instead of a static library.
        * config.h: Specify __declspec(dllexport/dllimport) appropriately when exporting data.
        * runtime/InternalFunction.h: Specify JS_EXPORTDATA on exported data.
        * runtime/JSArray.h: Specify JS_EXPORTDATA on exported data.
        * runtime/JSFunction.h: Specify JS_EXPORTDATA on exported data.
        * runtime/StringObject.h: Specify JS_EXPORTDATA on exported data.
        * runtime/UString.h: Specify JS_EXPORTDATA on exported data.

WebCore:

2009-04-20  Steve Falkenburg  <sfalken@apple.com>

        Separate JavaScriptCore.dll from WebKit.dll.
        Slight performance improvement or no change on benchmarks.

        Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
        and simplifies standalone JavaScriptCore builds.

        Reviewed by Oliver Hunt.

        * config.h: Specify __declspec(dllexport/dllimport) appropriately when exporting data.

WebKit/cf:

2009-04-20  Steve Falkenburg  <sfalken@apple.com>

        Separate JavaScriptCore.dll from WebKit.dll.
        Slight performance improvement or no change on benchmarks.

        Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
        and simplifies standalone JavaScriptCore builds.

        Reviewed by Oliver Hunt.

        * WebCoreSupport/WebInspectorClientCF.cpp: Workaround for lack of config.h in shared WebKit file (WebKit/win uses config.h from WebCore).

WebKit/win:

2009-04-20  Steve Falkenburg  <sfalken@apple.com>

        Separate JavaScriptCore.dll from WebKit.dll.
        Slight performance improvement or no change on benchmarks.

        Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
        and simplifies standalone JavaScriptCore builds.

        Reviewed by Oliver Hunt.

        * WebKit.vcproj/WebKit.def: Mark JavaScriptCore re-exports as deprecated.
        * WebKit.vcproj/WebKit.vcproj: Link against JavaScriptCore.dll
        * WebKit.vcproj/WebKit_debug.def: Mark JavaScriptCore re-exports as deprecated.

WebKitLibraries:

2009-04-20  Steve Falkenburg  <sfalken@apple.com>

        Separate JavaScriptCore.dll from WebKit.dll.
        Slight performance improvement or no change on benchmarks.

        Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
        and simplifies standalone JavaScriptCore builds.

        Reviewed by Oliver Hunt.

        * win/tools/vsprops/common.vsprops: Add BUILDING_{project} preprocessor define.

WebKitTools:

2009-04-20  Steve Falkenburg  <sfalken@apple.com>

        Separate JavaScriptCore.dll from WebKit.dll.
        Slight performance improvement or no change on benchmarks.

        Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
        and simplifies standalone JavaScriptCore builds.

        Reviewed by Oliver Hunt.

        * DumpRenderTree/config.h: Specify JS, WebKit exported data as __declspec(dllimport)
        * DumpRenderTree/win/DumpRenderTree.vcproj: Link against JavaScriptCore.dll

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
andersca@apple.com [Mon, 20 Apr 2009 20:41:39 +0000 (20:41 +0000)]
WebCore:

2009-04-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/6722845> In the Cocoa event model, NPWindow's window field should be null

        * bridge/npapi.h:
        (_NPCocoaEvent::):
        Add a CGContextRef member to the draw struct. Add an NPCoordinateSpace enum.

        * plugins/npfunctions.h:
        Add a prototype for NPN_ConvertPoint.

WebKit/mac:

2009-04-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/6722845>
        In the Cocoa event model, NPWindow's window field should be null

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCConvertPoint):
        Get the instance proxy and call it's convertPoint function.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::convertPoint):
        Call convertPoint on the plug-in view.

        * Plugins/Hosted/WebKitPluginClient.defs:
        Add PCConvertPoint.

        * Plugins/WebBaseNetscapePluginView.h:
        Add a declaration for convertFromX:andY:space:toX:andY:space:.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
        Convert a point from one coordinate system to another.

        * Plugins/WebNetscapePluginEventHandler.h:
        * Plugins/WebNetscapePluginEventHandlerCarbon.h:
        * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
        (WebNetscapePluginEventHandlerCarbon::drawRect):
        * Plugins/WebNetscapePluginEventHandlerCocoa.h:
        Add CGContextRef to drawRect.

        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::drawRect):
        Set the passed in context.

        * Plugins/WebNetscapePluginPackage.mm:
        (-[WebNetscapePluginPackage _tryLoad]):
        Add NPN_ConvertPoint to the browserFuncs vtable.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        Only set the window for the Carbon event model.

        (-[WebNetscapePluginView restorePortState:]):
        It's OK for the window context to be null.

        (-[WebNetscapePluginView sendDrawRectEvent:]):
        Pass the CGContextRef to drawRect.

        * Plugins/npapi.mm:
        (NPN_ConvertPoint):
        Call the plug-in view method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Dan Bernstein.
eric@webkit.org [Mon, 20 Apr 2009 19:49:56 +0000 (19:49 +0000)]
    Reviewed by Dan Bernstein.

        Make textarea and text input metrics more closely match IEs.
        https://bugs.webkit.org/show_bug.cgi?id=15312

        This involves:
        -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
        -set textarea width to cols*avgCharWidth
        -Make default CSS match IEs
        -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.

        Those values for textarea and inputs were derived by doing a ton of manual
        testing of IE's width values for various textareas and fonts.

        To get the average and max character width of a font, we do the following
        for each platform:
        -Win: TextMetrics expose avgCharWidth and maxCharWidth
        -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
            maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
        -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
            maxCharWidth = max of avgCharWidth and m_ascent
        -Mac: look in the OS/2 table for avgCharWidth and grab the maxCharWidth off the font.
            If either one is not there, then calculate the value using the Linux approach.

        Linux ports could probably dig into the OS/2 table as well, but I'll leave
        that up to them to implement.

        Tests: fast/forms/text-control-intrinsic-widths.html
               fast/forms/textarea-metrics.html
               svg/custom/svg-fonts-in-text-controls.html

        * css/html4.css:
        * css/themeWin.css:
        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::SimpleFontData):
        (WebCore::SimpleFontData::initCharWidths):
        * platform/graphics/SimpleFontData.h:
        (WebCore::SimpleFontData::maxCharWidth):
        (WebCore::SimpleFontData::avgCharWidth):
        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/gtk/SimpleFontDataPango.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/qt/SimpleFontDataQt.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/win/SimpleFontDataCGWin.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/win/SimpleFontDataCairoWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/win/SimpleFontDataWin.cpp:
        (WebCore::SimpleFontData::initGDIFont):
        * platform/graphics/wx/SimpleFontDataWx.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::calcPrefWidths):
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::preferredContentWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Mon, 20 Apr 2009 19:10:27 +0000 (19:10 +0000)]
    Reviewed by Simon Fraser.

        Remove m_absoluteBounds hack from SVG renderers and move outlineBoundsForRepaint into RenderSVGModelObject
        https://bugs.webkit.org/show_bug.cgi?id=25276

        This also exposed a buggy paint check in RenderSVGContainer::layout()
        we should repaint if we are self painting OR if our kids changed, not AND.

        Writing real outlineBoundsForRepaint required writing a mapLocalToContainer() function

        No functional changes, thus no tests.

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::localToParentTransform):
        (WebCore::RenderPath::layout):
        * rendering/RenderPath.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::layout):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::mapLocalToContainer):
        (WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
        * rendering/RenderSVGModelObject.h:
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::layout):
        (WebCore::RenderSVGRoot::paint):
        (WebCore::RenderSVGRoot::localToParentTransformWithoutCSSParentOffset):
        (WebCore::RenderSVGRoot::localToParentTransform):
        (WebCore::RenderSVGRoot::computeRectForRepaint):
        * rendering/RenderSVGRoot.h:
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-20 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 20 Apr 2009 18:12:39 +0000 (18:12 +0000)]
2009-04-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Kevin McCullough.

        Always tag mmaped memory on darwin and clean up #defines
        now that they are a little bigger.

        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::RegisterFile):
        * jit/ExecutableAllocatorFixedVMPool.cpp:
        (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
        * jit/ExecutableAllocatorPosix.cpp:
        (JSC::ExecutablePool::systemAlloc):
        * runtime/Collector.cpp:
        (JSC::allocateBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 20 Apr 2009 18:11:41 +0000 (18:11 +0000)]
2009-04-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel

        https://bugs.webkit.org/show_bug.cgi?id=25282

        outlineBoundsForRepaint() should compute a quad relative to the
        repaintContainer. This fixes the repaint issues originally fixed in
        https://bugs.webkit.org/show_bug.cgi?id=12885 for elements in compositing layers.
        Failure was only apparent when building with ACCELERATED_COMPOSITING enabled.

        Tests: compositing/repaint/content-into-overflow.html
               compositing/repaint/overflow-into-content.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::outlineBoundsForRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
weinig@apple.com [Mon, 20 Apr 2009 18:06:07 +0000 (18:06 +0000)]
JavaScriptCore:

2009-04-20  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Tim Hatcher.

        Add licenses for xcconfig files.

        * Configurations/Base.xcconfig:
        * Configurations/DebugRelease.xcconfig:
        * Configurations/FeatureDefines.xcconfig:
        * Configurations/JavaScriptCore.xcconfig:
        * Configurations/Version.xcconfig:

JavaScriptGlue:

2009-04-20  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Tim Hatcher.

        Add licenses for xcconfig files.

        * Configurations/Base.xcconfig:
        * Configurations/DebugRelease.xcconfig:
        * Configurations/JavaScriptGlue.xcconfig:
        * Configurations/Version.xcconfig:

WebCore:

2009-04-20  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Tim Hatcher.

        Add licenses for xcconfig files.

        * Configurations/Base.xcconfig:
        * Configurations/DebugRelease.xcconfig:
        * Configurations/FeatureDefines.xcconfig:
        * Configurations/Version.xcconfig:
        * Configurations/WebCore.xcconfig:

WebKit/mac:

2009-04-20  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Tim Hatcher.

        Add licenses for xcconfig files.

        * Configurations/Base.xcconfig:
        * Configurations/DebugRelease.xcconfig:
        * Configurations/FeatureDefines.xcconfig:
        * Configurations/Version.xcconfig:
        * Configurations/WebKit.xcconfig:

WebKitTools:

2009-04-20  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Tim Hatcher.

        Add licenses for xcconfig files.

        * DumpRenderTree/mac/Configurations/Base.xcconfig:
        * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
        * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
        * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
        * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 20 Apr 2009 17:31:39 +0000 (17:31 +0000)]
2009-04-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        WebKit side of <rdar://problem/6781302>

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::keyEvent):
        Pass the event keyChar.

        (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
        Ditto.

        (WebKit::NetscapePluginInstanceProxy::flagsChanged):
        Pass a 0 keyChar.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView flagsChanged:]):
        Call NetscapePluginInstanceProxy::flagsChanged.

        * Plugins/Hosted/WebKitPluginHost.defs:
        Add a keyChar argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 20 Apr 2009 17:16:20 +0000 (17:16 +0000)]
2009-04-20  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=24786
        WebKitDownload sometimes suggests peculiar filenames

        Remove query and ref from the URI that is to be downloaded when
        using it to provide a file name suggestion.

        * webkit/webkitdownload.cpp:
        (_WebKitDownloadPrivate::webkit_download_set_property):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-20 Eric Roman <eroman@chromium.org>
dglazkov@chromium.org [Mon, 20 Apr 2009 15:27:03 +0000 (15:27 +0000)]
2009-04-20  Eric Roman  <eroman@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25261
        Implement the V8 binding for DOMWindow.event similarly to JSC, by using
        the custom getter boilerplate from the IDL file.
        Also, stub out DOMWindow.crypto which is defined by the idl.

        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::invokeEventHandler):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::ACCESSOR_GETTER):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore
kov@webkit.org [Mon, 20 Apr 2009 15:23:58 +0000 (15:23 +0000)]
WebCore

2009-04-20  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25243
        Crash when data:// loads are cancelled

        Properly handle cancellation of the load for data:// loads. This
        fixes crashing in the followin test:

        plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::parseDataUrl):

WebKit/gtk

2009-04-20  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Handle the case when the plugin view is destroyed during
        didReceiveResponse, to avoid crashing.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::committedLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-20 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Mon, 20 Apr 2009 09:27:14 +0000 (09:27 +0000)]
2009-04-20  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Build fix for Qt port (after r42646). Not reviewed.

        * wtf/unicode/qt4/UnicodeQt4.h: Added U16_PREV.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-19 Adele Peterson <adele@apple.com>
adele@apple.com [Mon, 20 Apr 2009 06:25:49 +0000 (06:25 +0000)]
2009-04-19  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/6804809> REGRESSION: In Mail, Home and End do not scroll message

        If no scrolling occurs, call tryToPerform on the next responder.  Then our WebResponderChainSink
        will correctly detect if no responders handle the selector.

        * WebView/WebFrameView.mm:
        (-[WebFrameView _scrollToBeginningOfDocument]):
        (-[WebFrameView _scrollToEndOfDocument]):
        (-[WebFrameView scrollToBeginningOfDocument:]):
        (-[WebFrameView scrollToEndOfDocument:]):
        (-[WebFrameView scrollLineUp:]):
        (-[WebFrameView scrollLineDown:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - maybe fix release builds
mitz@apple.com [Mon, 20 Apr 2009 05:47:15 +0000 (05:47 +0000)]
    - maybe fix release builds

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElementData::notifyFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - fix release builds
mitz@apple.com [Mon, 20 Apr 2009 05:27:00 +0000 (05:27 +0000)]
    - fix release builds

        * dom/Document.cpp:
        (WebCore::Document::executeScriptSoonTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Mon, 20 Apr 2009 04:20:08 +0000 (04:20 +0000)]
WebCore:

        Reviewed by Mark Rowe.

        - fix <rdar://problem/6734365> REGRESSION eBay "Save this search" link
          does nothing the second time search results are opened

        Test: fast/dom/HTMLScriptElement/nested-execution.html

        Instead of executing scripts as soon as they finish loading, which may
        happen synchronously during execution of another script, defer their
        execution until the next run loop iteration, using a queue that is
        similar to the HTML5 notion of the "list of scripts that will execute as
        soon as possible", and in my testing was consistent with how Firefox
        behaved.

        * dom/Document.cpp:
        (WebCore::Document::Document): Initialize m_executeScriptSoonTimer.
        (WebCore::Document::~Document): deref() script elements in
        m_scriptsToExecuteSoon.
        (WebCore::Document::executeScriptSoonTimerFired): Added. Executes the
        scripts in m_scriptsToExecuteSoon and deref()s them.
        (WebCore::Document::executeScriptSoon): Added. Appends to
        m_scriptsToExecuteSoon and ref()s the script element, which keeps the
        ScriptElementData alive as well.
        * dom/Document.h:
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElementData::ScriptElementData): Initialize m_requested.
        (WebCore::ScriptElementData::requestScript): Set m_requested to true, to
        prevent further load requests.
        (WebCore::ScriptElementData::execute): Added. Moved the code from
        notifyFinished() which should not execute synchronously here, to be
        called by the Document on a 0-interval timer.
        (WebCore::ScriptElementData::notifyFinished): Moved the code to
        dispatch events and evaluate the script, which should not execute
        synchronously, out of here.
        (WebCore::ScriptElementData::ignoresLoadRequest): Changed to test for
        m_requested instead of m_cachedScript, because the latter is cleared
        before the script is evaluated.
        * dom/ScriptElement.h:

LayoutTests:

        Reviewed by Mark Rowe.

        - test and updated tests for <rdar://problem/6734365> eBay "Save this
          search" link does nothing the second time search results are opened

        * fast/dom/HTMLScriptElement/nested-execution-expected.txt: Added.
        * fast/dom/HTMLScriptElement/nested-execution.html: Added.
        * fast/dom/HTMLScriptElement/resources/nested-execution.js: Added.
        * fast/dom/HTMLScriptElement/script-reexecution.html:
        * fast/dom/HTMLScriptElement/script-set-src.html:
        * fast/dom/script-element-gc.html:
        * fast/loader/local-JavaScript-from-local.html:
        * svg/dom/SVGScriptElement/script-reexecution.svg:
        * svg/dom/SVGScriptElement/script-set-href.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6127705> Excessive memory consumption on image load failure
oliver@apple.com [Mon, 20 Apr 2009 01:31:11 +0000 (01:31 +0000)]
<rdar://problem/6127705> Excessive memory consumption on image load failure

Reviewed by Antti Koivisto and Darin Adler

When we fail to decode an image we clear most of the image data, but not the
input data itself, which can be backed by a CFData object that itself holds onto
a few hundred Kbs of memory.  This patch merely ensures that this buffer gets
cleared.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-19 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 19 Apr 2009 23:38:48 +0000 (23:38 +0000)]
2009-04-19  Darin Adler  <darin@apple.com>

        * StringsNotToBeLocalized.txt: Updated for recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-19 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 19 Apr 2009 22:54:39 +0000 (22:54 +0000)]
2009-04-19  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Better fix for JSStringCreateWithCFString hardening.

        * API/JSStringRefCF.cpp:
        (JSStringCreateWithCFString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoooo
darin@apple.com [Sun, 19 Apr 2009 22:48:15 +0000 (22:48 +0000)]
ooo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-19 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 19 Apr 2009 22:47:19 +0000 (22:47 +0000)]
2009-04-19  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Add hoooks so sudden termination will not cause loss of icons or local storage.
        rdar://problem/5951701

        * loader/icon/IconDatabase.cpp: Marked various constants static to give them
        internal linkage.
        (WebCore::IconDatabase::IconDatabase): Added initial value for m_syncTimer.
        Removed unneeded initial value for m_defaultIconRecord. Changed assertion to
        work cross-platform.
        (WebCore::IconDatabase::wakeSyncThread): Added disableSuddenTermination, so
        we won't terminate until the sync thread has done its thing.
        (WebCore::IconDatabase::scheduleOrDeferSyncTimer): Added disableSuddenTermination,
        so we won't terminate if we have an outstanding sync timer.
        (WebCore::IconDatabase::syncTimerFired): Added enableSuddenTermination, to
        balance the one in scheduleOrDeferSyncTimer.
        (WebCore::IconDatabase::syncThreadMainLoop): Added enableSuddenTermination, to
        balance the one in wakeSyncThread.
        (WebCore::IconDatabase::deleteAllPreparedStatements): Use clear() instead of set(0).

        * loader/icon/IconDatabase.h: Use a Timer instead of an OwnPtr<Timer>.

        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::scheduleFinalSync): Added disableSuddenTermination.
        (WebCore::LocalStorageArea::scheduleItemForSync): Ditto.
        (WebCore::LocalStorageArea::scheduleClear): Ditto.
        (WebCore::LocalStorageArea::syncTimerFired): Added a disableSuddenTermination if
        we schedule a performSync callback for later and an unconditional
        enableSuddenTermination to balance the ones in the schedule calls above.
        (WebCore::LocalStorageArea::sync): Factored out the work of the sync function so it
        can continue to use early return idiom.
        (WebCore::LocalStorageArea::performSync): Added a call to enableSuddenTermination.

        * storage/LocalStorageArea.h: Added declaration of the sync function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-19 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 19 Apr 2009 22:26:00 +0000 (22:26 +0000)]
2009-04-19  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Fix for <rdar://problem/5860954>
        Harden JSStringCreateWithCFString against malformed CFStringRefs.

        * API/JSStringRefCF.cpp:
        (JSStringCreateWithCFString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Make FEATURE_DEFINES completely dynamic
ddkilzer@apple.com [Sun, 19 Apr 2009 17:05:52 +0000 (17:05 +0000)]
    Make FEATURE_DEFINES completely dynamic

        Reviewed by Darin Adler.

        Make FEATURE_DEFINES depend on individual ENABLE_FEATURE_NAME
        variables for each feature, making it possible to remove all
        knowledge of FEATURE_DEFINES from build-webkit.

JavaScriptCore:

        * Configurations/FeatureDefines.xcconfig: Extract a variable
        from FEATURE_DEFINES for each feature setting.

WebCore:

        * Configurations/FeatureDefines.xcconfig: Extract a variable
        from FEATURE_DEFINES for each feature setting.

WebKit/mac:

        * Configurations/FeatureDefines.xcconfig: Extract a variable
        from FEATURE_DEFINES for each feature setting.

WebKitTools:

        * Scripts/build-webkit: Define individual ENABLE_FEATURE_NAME
        variables instead of the whole FEATURE_DEFINES string when
        building with Xcode.  Miscellaneous clean up:
        - Reordered/sorted command-line switch variables.
        - Reordered/sorted command-line switches in $usage.
        - Reordered/sorted command-line switches in GetOptions().
        - Defined $svgSupport to true if any --svg-feature switch is
          set in order to match "Implies SVG Support" claim.
        - Build JavaScriptGlue after JavaScriptCore again!
        - Fixed --[no-]geolocation for GTK+ port and sorted GTK+
          command-line switches.
        - Added "exit 0" statement at the end of the script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-18 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 19 Apr 2009 07:38:26 +0000 (07:38 +0000)]
2009-04-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Alexey Proskuryakov.

        More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
        Unbounded memory growth when churning elements with anonymous event handler functions

        Removed a little more complexity from event handler creation and destruction.

        Removed the jsProtectedEventListeners, jsProtectedInlineEventListeners,
        and jsInlineEventListeners maps, and all the code for managing them.

        ProtectedEventListeners don't exist anymore, so they're easy to nix.

        Inline EventListeners do still exist, but there's no reason to track
        them in a map. The map exists to enable 'removeEventListener' to associate
        a unique JSEventListener with a given JavaScript function. But the
        'removeEventListener' API only works with non-inline event listeners!

        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
        (WebCore::JSDOMGlobalObject::findJSEventListener):
        (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
        (WebCore::JSDOMGlobalObject::createJSInlineEventListener):
        * bindings/js/JSDOMGlobalObject.h:
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::JSEventListener):
        (WebCore::JSEventListener::clearJSFunctionInline):
        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::JSLazyEventListener::~JSLazyEventListener):
        (WebCore::JSLazyEventListener::parseCode):
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-18 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 19 Apr 2009 06:42:21 +0000 (06:42 +0000)]
2009-04-18  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Fix typo.  s/VM_MEMORY_JAVASCRIPT_JIT_REGISTER_FILE/VM_MEMORY_JAVASCRIPT_CORE/

        * runtime/Collector.cpp:
        (JSC::allocateBlock): Fix bozo typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - try to fix the Windows build
mitz@apple.com [Sun, 19 Apr 2009 06:39:32 +0000 (06:39 +0000)]
    - try to fix the Windows build

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::characterAfter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - revert the previous change, which was to a file that the Windows
mitz@apple.com [Sun, 19 Apr 2009 06:29:51 +0000 (06:29 +0000)]
    - revert the previous change, which was to a file that the Windows
          port does not even use

        * icu/unicode/utf16.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the dates in my Changelog entries
simon.fraser@apple.com [Sun, 19 Apr 2009 06:17:13 +0000 (06:17 +0000)]
Fix the dates in my Changelog entries

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Geoffrey Garen.
mitz@apple.com [Sun, 19 Apr 2009 05:28:57 +0000 (05:28 +0000)]
    Reviewed by Geoffrey Garen.

        - try to fix the Windows build

        * icu/unicode/utf16.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 19 Apr 2009 05:00:39 +0000 (05:00 +0000)]
2009-04-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Antti Koivisto.

        https://bugs.webkit.org/show_bug.cgi?id=25066

        When a <video> element gained a RenderLayer via opacity, reflection etc., the
        layer hierarchy was not correctly updated because RenderMedia skipped a level
        when asked for its children; it skipped m_controlsShadowRoot's renderer, which
        actually has a layer.

        Test: fast/layers/video-layer.html

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
        Don't manually call setParent() on the renderer. It will happen later
        as a result of addChild().

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::createControlsShadowRoot):
        Add m_controlsShadowRoot's renderer as a child.

        * rendering/RenderMedia.h:
        (WebCore::RenderMedia::children):
        Now maintain a RenderObjectChildList, m_children, and remove the unneeded
        removeChild() method. Make the two children() methods inline.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::moveLayers):
        Assert if moveLayers() is called with an oldParent that is not the
        layer's actual parent (which would have revealed this bug).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-18 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 19 Apr 2009 04:58:05 +0000 (04:58 +0000)]
2009-04-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Fixed a layout test failure, caused by my last check-in
        (fast/dom/script-element-gc.html).

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::isObservableThroughDOM):
        * html/HTMLScriptElement.h:
        (WebCore::HTMLScriptElement::haveFiredLoadEvent): Treat script elements
        just like image elements: if a script element is loading, mark its JS
        wrapper, even if the element is not in the document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-18 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 19 Apr 2009 02:14:58 +0000 (02:14 +0000)]
2009-04-18  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Fix for <rdar://problem/6801555> Tag JavaScript memory on SnowLeopard

        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::RegisterFile):
        * jit/ExecutableAllocatorFixedVMPool.cpp:
        (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
        * jit/ExecutableAllocatorPosix.cpp:
        (JSC::ExecutablePool::systemAlloc):
        * runtime/Collector.cpp:
        (JSC::allocateBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-18 Jian Li <jianli@chromium.org>
dimich@chromium.org [Sun, 19 Apr 2009 01:40:40 +0000 (01:40 +0000)]
2009-04-18  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25170
        Upstream V8WorkerCustom.cpp and V8WorkerContextCustom.cpp for V8 bindings.

        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
        * bindings/v8/WorkerContextExecutionProxy.h:
        * bindings/v8/custom/V8WorkerContextCustom.cpp: Added.
        * bindings/v8/custom/V8WorkerCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-18 Jian Li <jianli@chromium.org>
dimich@chromium.org [Sun, 19 Apr 2009 01:40:21 +0000 (01:40 +0000)]
2009-04-18  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/post_bug.cg://bugs.webkit.org/show_bug.cgi?id=25167
        Change createHiddenXHRDependency and removeHiddenXHRDependency so that they can be used by other custom code in V8 bindings.

        * bindings/v8/V8Utilities.cpp: Renamed from WebCore/bindings/v8/V8XMLHttpRequestUtilities.cpp.
        (WebCore::createHiddenDependency):
        (WebCore::removeHiddenDependency):
        * bindings/v8/V8Utilities.h: Renamed from WebCore/bindings/v8/V8XMLHttpRequestUtilities.h.
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::ACCESSOR_SETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
        (WebCore::ACCESSOR_SETTER):
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-18 Drew Wilson <amw@apple.com>
ddkilzer@apple.com [Sun, 19 Apr 2009 01:19:15 +0000 (01:19 +0000)]
2009-04-18  Drew Wilson  <amw@apple.com>

        <rdar://problem/6781407> VisiblePosition.characterAfter should return UChar32

        Reviewed by Dan Bernstein.

JavaScriptCore:

        * wtf/unicode/icu/UnicodeIcu.h:
        (WTF::Unicode::hasLineBreakingPropertyComplexContextOrIdeographic): Added.

WebCore:

        No test case since there is no change in behavior.

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::characterAfter): Now handles surrogate
        pairs correctly and returns a UChar32.
        * editing/VisiblePosition.h:
        (WebCore::VisiblePosition::characterBefore): Now returns a UChar32.
        * editing/visible_units.cpp:
        (WebCore::endOfFirstWordBoundaryContext): Renamed
        firstNonComplexContextLineBreak() to this. Changed it to use the
        generic requiresContextForWordBoundary() instead of
        hasLineBreakingPropertyComplexContext().
        (WebCore::startOfLastWordBoundaryContext): Replaces
        lastNonComplexContextLineBreak(), but returns the offset of
        the character after the last character that does not require
        context for word breaking. Also changed to use
        requiresContextForWordBoundary().
        (WebCore::previousBoundary): Updated for the above changes in
        names and semantics, and changed to use
        requiresContextForWordBoundary().
        (WebCore::nextBoundary): Ditto.
        (WebCore::startWordBoundary): Ditto.
        (WebCore::endWordBoundary): Ditto.
        (WebCore::previousWordPositionBoundary): Ditto.
        (WebCore::nextWordPositionBoundary): Ditto.
        * platform/text/TextBoundaries.h:
        (WebCore::requiresContextForWordBoundary): Added.
        * platform/text/mac/TextBoundaries.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
ggaren@apple.com [Sun, 19 Apr 2009 01:00:36 +0000 (01:00 +0000)]
WebCore:

2009-04-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Fixed <rdar://problem/6797442> | https://bugs.webkit.org/show_bug.cgi?id=25285
        REGRESSION (r42569): Profiles cannot be selected in inspector profiler

        EventListeners are shared; RegisteredEventListeners are not. Therefore,
        when a node wrapper needs to invalidate the node's JS event listeners,
        it should invalidate its RegisteredEventListeners, not its EventListeners.
        Otherwise, it might invalidate an EventListener shared by another node.

        * dom/RegisteredEventListener.h:
        (WebCore::invalidateEventListeners): ditto

LayoutTests:

2009-04-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Test for <rdar://problem/6797442> | https://bugs.webkit.org/show_bug.cgi?id=25285
        REGRESSION (r42569): Profiles cannot be selected in inspector profiler

        * fast/events/event-listener-sharing-expected.txt: Added.
        * fast/events/event-listener-sharing.html: Added.
        * fast/events/resources/event-listener-sharing.js: Added.
        (gc):
        (clickHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-18 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 18 Apr 2009 23:50:03 +0000 (23:50 +0000)]
2009-04-18  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Fix for <rdar://problem/5861045>
        A little bit of hardening for UString.

        * runtime/UString.cpp:
        (JSC::concatenate):
        (JSC::UString::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-18 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 18 Apr 2009 22:50:10 +0000 (22:50 +0000)]
2009-04-18  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe and Dan Bernstein.

        Fix for <rdar://problem/5861188>
        A little bit of hardening for Vector.

        * wtf/Vector.h:
        (WTF::Vector<T, inlineCapacity>::append):
        (WTF::Vector<T, inlineCapacity>::insert):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-18 Pierre d'Herbemont <pdherbemont@apple.com>
eric.carlson@apple.com [Sat, 18 Apr 2009 20:29:38 +0000 (20:29 +0000)]
2009-04-18  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Mark Rowe.

        <rdar://problem/6781295> video.buffered and video.seekable are not
        the same.

        * WebCore.base.exp: Added wkQTMovieMaxTimeSeekable.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::maxTimeSeekable): Return wkQTMovieMaxTimeSeekable.

        * platform/mac/WebCoreSystemInterface.h: Add wkQTMovieMaxTimeSeekable.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.

2009-04-18  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Mark Rowe.

        <rdar://problem/6781295> video.buffered and video.seekable are not
        the same.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Add wkQTMovieMaxTimeSeekable.

2009-04-18  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Mark Rowe.

        <rdar://problem/6781295> video.buffered and video.seekable are not
        the same.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-18 Pierre d'Herbemont <pdherbemont@apple.com>
eric.carlson@apple.com [Sat, 18 Apr 2009 19:11:29 +0000 (19:11 +0000)]
2009-04-18  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Mark Rowe.

        <rdar://problem/6747241> work around QTKit no longer reaching
        QTMovieLoadStateComplete

        * WebCore.base.exp: Export wkQTMovieMaxTimeLoadedChangeNotification.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovie): observe QTMovieMaxTimeLoadedChangeNotification.
        (WebCore::MediaPlayerPrivate::updateStates): compare duuration() with maxTimeLoaded() instead of
        using QTMovieLoadStateComplete to determine if a movie are fully loaded.

        * platform/mac/WebCoreSystemInterface.h: Add wkQTMovieMaxTimeLoadedChangeNotification.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.

2009-04-18  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Mark Rowe.

        <rdar://problem/6747241> work around QTKit no longer reaching
        QTMovieLoadStateComplete

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Init the new WKSI exported symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-18 Justin Garcia <justin.garcia@apple.com>
justin.garcia@apple.com [Sat, 18 Apr 2009 18:49:14 +0000 (18:49 +0000)]
2009-04-18  Justin Garcia  <justin.garcia@apple.com>

        Updated test results for https://bugs.webkit.org/show_bug.cgi?id=25277

        * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.checksum:
        * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
        * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-18 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
staikos@webkit.org [Sat, 18 Apr 2009 11:49:09 +0000 (11:49 +0000)]
2009-04-18  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

        Make WML work again, most regressions test were failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-17 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Sat, 18 Apr 2009 04:44:22 +0000 (04:44 +0000)]
2009-04-17  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        On x86_64, make all JIT-code allocations from a new heap, managed
        by FixedVMPoolAllocator.  This class allocates a single large (2Gb)
        pool of virtual memory from which all further allocations take place.
        Since all JIT code is allocated from this pool, we can continue to
        safely assume (as is already asserted) that it will always be possible
        to link any JIT-code to JIT-code jumps and calls.

        * JavaScriptCore.xcodeproj/project.pbxproj:
            Add new file.
        * jit/ExecutableAllocatorFixedVMPool.cpp: Added.
        (JSC::FreeListEntry::FreeListEntry):
        (JSC::AVLTreeAbstractorForFreeList::get_less):
        (JSC::AVLTreeAbstractorForFreeList::set_less):
        (JSC::AVLTreeAbstractorForFreeList::get_greater):
        (JSC::AVLTreeAbstractorForFreeList::set_greater):
        (JSC::AVLTreeAbstractorForFreeList::get_balance_factor):
        (JSC::AVLTreeAbstractorForFreeList::set_balance_factor):
        (JSC::AVLTreeAbstractorForFreeList::null):
        (JSC::AVLTreeAbstractorForFreeList::compare_key_key):
        (JSC::AVLTreeAbstractorForFreeList::compare_key_node):
        (JSC::AVLTreeAbstractorForFreeList::compare_node_node):
        (JSC::sortFreeListEntriesByPointer):
        (JSC::sortCommonSizedAllocations):
        (JSC::FixedVMPoolAllocator::release):
        (JSC::FixedVMPoolAllocator::reuse):
        (JSC::FixedVMPoolAllocator::addToFreeList):
        (JSC::FixedVMPoolAllocator::coalesceFreeSpace):
        (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
        (JSC::FixedVMPoolAllocator::alloc):
        (JSC::FixedVMPoolAllocator::free):
        (JSC::ExecutableAllocator::intializePageSize):
        (JSC::ExecutablePool::systemAlloc):
        (JSC::ExecutablePool::systemRelease):
            The new 2Gb heap class!
        * jit/ExecutableAllocatorPosix.cpp:
            Disable use of this implementation on x86_64.
        * wtf/AVLTree.h:
            Add missing variable initialization.
        (WTF::::remove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAccidently checked in outdated pixel results.
justin.garcia@apple.com [Sat, 18 Apr 2009 02:23:48 +0000 (02:23 +0000)]
Accidently checked in outdated pixel results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix bug where the VM reentry cache would not correctly unroll the cached callframe
oliver@apple.com [Sat, 18 Apr 2009 02:04:50 +0000 (02:04 +0000)]
Fix bug where the VM reentry cache would not correctly unroll the cached callframe

Reviewed by Darin Adler

Fix a check that was intended to mark a cached call as invalid when the callframe could
not be constructed.  Instead it was just checking that there was a place to put the
exception.  This eventually results in a non-recoverable RegisterFile starvation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoForgot to uncomment some code before checking in.
justin.garcia@apple.com [Sat, 18 Apr 2009 01:59:51 +0000 (01:59 +0000)]
Forgot to uncomment some code before checking in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
justin.garcia@apple.com [Sat, 18 Apr 2009 01:53:51 +0000 (01:53 +0000)]
WebCore:

2009-04-17  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=25277
        If there is no line wrapping, a caret can leave its containing block but it shouldn't leave its root line box

        Also added code to handle a caret wider than one pixel.

        Added fast/inline/25277.html and fast/inline/25277-2.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::localCaretRect): Distribute a caret's width to either side of the offset,
        so that a caret between two characters doesn't hang over one character more than the other.
        If there is no wrapping, the caret can leave its containing block, but not its root line box.

LayoutTests:

2009-04-17  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=25277
        If there is no line wrapping, a caret can leave its containing block but it shouldn't leave its root line box

        * fast/inline/25277-2.html: Added.
        * fast/inline/25277.html: Added.
        * platform/mac/fast/inline/25277-2-expected.checksum: Added.
        * platform/mac/fast/inline/25277-2-expected.png: Added.
        * platform/mac/fast/inline/25277-2-expected.txt: Added.
        * platform/mac/fast/inline/25277-expected.checksum: Added.
        * platform/mac/fast/inline/25277-expected.png: Added.
        * platform/mac/fast/inline/25277-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-17 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 18 Apr 2009 01:31:50 +0000 (01:31 +0000)]
2009-04-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
        Unbounded memory growth when churning elements with anonymous event handler functions

        Some refactoring of "inline" event listeners.

        Renames:
            dispatchEventForType => dispatchEvent
            setWindowInlineEventListenerForTypeAndAttribute => setWindowInlineEventListener
            removeInlineEventListenerForType => clearInlineEventListener
            setInlineEventListenerForType => setInlineEventListener
            inlineEventListenerForType => getInlineEventListener

        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::eventParameterName):
        (WebCore::JSLazyEventListener::JSLazyEventListener):
        (WebCore::createInlineEventListener):
        * bindings/js/JSLazyEventListener.h: Added two helper functions for
        creating "inline" event listeners. These replace Document::createEventListener,
        and abstract the creation of JS event listeners for DOM attributes out
        of the DOM. Removed legacy JSProtectedEventListener constructor code for
        adding the event listener's function to a map, since lazy event listeners
        don't have functions at construction time.

        * dom/Document.cpp:
        (WebCore::Document::setFocusedNode):
        * dom/Document.h:
        (WebCore::Document::isSVGDocument):
        * dom/Element.cpp:
        (WebCore::Element::setWindowInlineEventListener):
        * dom/Element.h: Updated for renames. Nixed Document::createEventListener,
        mentioned above. Moved setWindowInlineEventListenerForTypeAndAttribute
        to Element, for simplicity.

        * dom/InputElement.cpp:
        (WebCore::InputElement::setValueFromRenderer):
        * dom/Node.cpp:
        (WebCore::Node::dispatchFocusEvent):
        (WebCore::Node::dispatchBlurEvent):
        (WebCore::Node::dispatchEvent):
        (WebCore::Node::clearInlineEventListener):
        (WebCore::Node::setInlineEventListener):
        (WebCore::Node::getInlineEventListener):
        (WebCore::Node::onabort):
        (WebCore::Node::setOnabort):
        (WebCore::Node::etc.):
        * dom/Node.h: Updated for renames.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment): Updated for renames.

        Updated these files for renames, and to use the new createInlineEventListener
        helper function:

        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::parseMappedAttribute):
        * html/HTMLButtonElement.cpp:
        (WebCore::HTMLButtonElement::parseMappedAttribute):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::parseMappedAttribute):
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::onChange):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::prepareSubmit):
        (WebCore::HTMLFormElement::reset):
        (WebCore::HTMLFormElement::parseMappedAttribute):
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::parseMappedAttribute):
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::parseMappedAttribute):
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::parseMappedAttribute):
        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::dispatchLoadEvent):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseMappedAttribute):
        (WebCore::HTMLInputElement::onSearch):
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::loadInternal):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::parseMappedAttribute):
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::parseMappedAttribute):
        (WebCore::HTMLScriptElement::dispatchLoadEvent):
        (WebCore::HTMLScriptElement::dispatchErrorEvent):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::parseMappedAttribute):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::parseMappedAttribute):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::notifyFinished):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::mouseButtonListener):
        * page/DOMWindow.cpp:
        * page/DOMWindow.h:
        (WebCore::DOMWindow::eventListeners):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::canMouseDownStartSelect):
        (WebCore::EventHandler::canMouseDragExtendSelect):
        (WebCore::EventHandler::sendScrollEvent):
        * page/Page.cpp:
        (WebCore::networkStateChanged):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::valueChanged):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::selectionChanged):
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::parseMappedAttribute):
        * svg/SVGElementInstance.cpp:
        * svg/SVGImageLoader.cpp:
        (WebCore::SVGImageLoader::dispatchLoadEvent):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::parseMappedAttribute):
        * svg/SVGScriptElement.cpp:
        (WebCore::SVGScriptElement::dispatchErrorEvent):
        * wml/WMLInputElement.cpp:
        (WebCore::WMLInputElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 17 Apr 2009 23:52:29 +0000 (23:52 +0000)]
2009-04-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6714488>
        REGRESSION (Safari 3-4): Edit menu commands (cut/copy/paste/select all) do not work on Flash content

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
        Send a keyDown event to the plug-in host.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView sendModifierEventWithKeyCode:character:]):
        Call the plug-in instance proxy.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView sendModifierEventWithKeyCode:character:]):
        Add this. Subclasses are required to override it.

        (-[WebBaseNetscapePluginView cut:]):
        (-[WebBaseNetscapePluginView copy:]):
        (-[WebBaseNetscapePluginView paste:]):
        (-[WebBaseNetscapePluginView selectAll:]):
        Call sendModifierEventWithKeyCode.

        * Plugins/WebNetscapePluginEventHandler.h:
        Add syntheticKeyDownWithCommandModifier.

        * Plugins/WebNetscapePluginEventHandlerCarbon.h:
        * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
        (WebNetscapePluginEventHandlerCarbon::syntheticKeyDownWithCommandModifier):
        Send the synthetic event.

        * Plugins/WebNetscapePluginEventHandlerCocoa.h:
        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
        Send the synthetic event.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView sendModifierEventWithKeyCode:character:]):
        Call the event handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Simplify FEATURE_DEFINES definition
ddkilzer@apple.com [Fri, 17 Apr 2009 23:11:46 +0000 (23:11 +0000)]
    Simplify FEATURE_DEFINES definition

        Reviewed by Darin Adler.

        This moves FEATURE_DEFINES and its related ENABLE_FEATURE_NAME
        variables to their own FeatureDefines.xcconfig file.  It also
        extracts a new ENABLE_GEOLOCATION variable so that
        FEATURE_DEFINES only needs to be defined once.

JavaScriptCore:

        * Configurations/FeatureDefines.xcconfig: Added.
        * Configurations/JavaScriptCore.xcconfig: Removed definition of
        ENABLE_SVG_DOM_OBJC_BINDINGS and FEATURE_DEFINES.  Added include
        of FeatureDefines.xcconfig.
        * JavaScriptCore.xcodeproj/project.pbxproj: Added
        FeatureDefines.xcconfig file.

WebCore:

        * Configurations/FeatureDefines.xcconfig: Added.
        * Configurations/WebCore.xcconfig: Removed definition of
        ENABLE_SVG_DOM_OBJC_BINDINGS and FEATURE_DEFINES.  Added include
        of FeatureDefines.xcconfig.
        * WebCore.xcodeproj/project.pbxproj: Added
        FeatureDefines.xcconfig file.
        * bindings/scripts/CodeGeneratorObjC.pm: When creating a list of
        command-line macro definitions, split on one-or-more spaces
        instead of a single space since the FEATURE_DEFINES macro may
        now contain more than one space between macros if some macros
        aren't defined.

WebKit:

        * WebKit.xcodeproj/project.pbxproj: Added
        FeatureDefines.xcconfig file.

WebKit/mac:

        * Configurations/FeatureDefines.xcconfig: Added.
        * Configurations/WebKit.xcconfig: Removed definition of
        ENABLE_SVG_DOM_OBJC_BINDINGS and FEATURE_DEFINES.  Added include
        of FeatureDefines.xcconfig.

WebKitTools:

        * Scripts/build-webkit: Realphabetized code related to enabling
        Geolation features for WebKit.  Also set ENABLE_GEOLOCATION
        variable for xcodebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <rdar://problem/6803905> Lots of ASSERTs firing when trying to clear history
adachan@apple.com [Fri, 17 Apr 2009 22:54:05 +0000 (22:54 +0000)]
    <rdar://problem/6803905> Lots of ASSERTs firing when trying to clear history

        Reviewed by Steve Falkenburg.

        * WebHistory.cpp:
        (WebHistory::data): Return null if there are no history items.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 17 Apr 2009 22:29:02 +0000 (22:29 +0000)]
2009-04-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Steve Falkenburg

        Fix the link for setting the Platform SDK paths in the Windows instructions.

        * building/build.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
beidson@apple.com [Fri, 17 Apr 2009 21:49:26 +0000 (21:49 +0000)]
WebCore:

2009-04-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe

        <rdar://problem/6786999> Tiger WebKit shouldn't try to POST on back/forward without nagging.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::willLoadFromCache):

LayoutTests:

2009-04-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe

        <rdar://problem/6778137> - Disable post-goback-repost-policy.html until the networking layer allows it to be useful.

        * http/tests/navigation/post-goback-repost-policy.html: Removed.
        * http/tests/navigation/post-goback-repost-policy.html-disabled: Copied from http/tests/navigation/post-goback-repost-policy.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-17 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 17 Apr 2009 20:50:28 +0000 (20:50 +0000)]
2009-04-17  Darin Adler  <darin@apple.com>

        Reviewed by Timothy Hatcher.

        Added sudden termination functions that can be called without involving
        the page or client.

        * GNUmakefile.am: Added SuddenTermination.h.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto. Also added SuddenTermination.mm.

        * platform/SuddenTermination.h: Added.
        * platform/mac/SuddenTermination.mm: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Fri, 17 Apr 2009 20:45:28 +0000 (20:45 +0000)]
    Reviewed by Simon Fraser.

        Move more code into RenderSVGModelObject

        needsLayer() already returns false from RenderSVGModelObject
        lineHeight and baselinePosition are from days of RenderPath having RenderBox parents.

        I also added comments to explain how focus rings work (now that I understand)
        I got rid of two more uses of m_absoluteBounds (nearly dead!)

        * rendering/RenderPath.cpp:
        * rendering/RenderPath.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):
        (WebCore::RenderSVGContainer::addFocusRingRects):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::absoluteRects):
        (WebCore::RenderSVGModelObject::absoluteQuads):
        * rendering/RenderSVGModelObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - Fix a leak in WebHistoryItem::children() by adopting the created instance...
adachan@apple.com [Fri, 17 Apr 2009 20:44:17 +0000 (20:44 +0000)]
    - Fix a leak in WebHistoryItem::children() by adopting the created instance of WebHistoryItem.
        - Remove the unnecessary call to QueryInterface() which is not related to the leak.

        Reviewed by Adam Roben.

        * WebHistoryItem.cpp:
        (WebHistoryItem::children):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-16 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 17 Apr 2009 20:42:12 +0000 (20:42 +0000)]
2009-04-16  Peter Kasting  <pkasting@google.com>

        Reviewed by Adele Peterson.

        https://bugs.webkit.org/show_bug.cgi?id=25238
        Invalidate the hovered scrollbar part when resetting the pressed part,
        since once there is no pressed part we can draw a hovered state.

        * platform/Scrollbar.cpp:
        (WebCore::Scrollbar::setHoveredPart):
        (WebCore::Scrollbar::setPressedPart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-16 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 17 Apr 2009 20:31:17 +0000 (20:31 +0000)]
2009-04-16  Darin Fisher  <darin@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25223
        REGRESSION: Back button after form submission to the same URL fails to navigate.

        Test: http/tests/navigation/post-goback-same-url.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadItem): Check if the page we are leaving has
        FormData.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Fix WML enabled builds.
zimmermann@webkit.org [Fri, 17 Apr 2009 20:09:00 +0000 (20:09 +0000)]
Not reviewed. Fix WML enabled builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Fri, 17 Apr 2009 19:53:34 +0000 (19:53 +0000)]
2009-04-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed build fix to generate all .mo files at the correct
        location.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-17 Anders Carlsson <andersca@apple.com>
darin@apple.com [Fri, 17 Apr 2009 19:53:31 +0000 (19:53 +0000)]
2009-04-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Fix crashes seen in regression tests with hosted plug-ins.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::cancelStreamLoad): Check the stream for 0,
        not the stream ID.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-17 Pierre d'Herbemont <pdherbemont@apple.com>
eric.carlson@apple.com [Fri, 17 Apr 2009 19:35:17 +0000 (19:35 +0000)]
2009-04-17  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        Add support for the media element 'played' attribute.
        This involves support of "normalized TimeRanges" as described by
        the spec.

        Test: media/video-played.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Renamed
        m_currentTimeDuringSeek->m_lastSeekTime. Added m_playing and m_playedTimeRanges.
        (WebCore::HTMLMediaElement::loadInternal): Reset m_playing, m_lastSeekTime, and
        m_playedTimeRanges
        (WebCore::HTMLMediaElement::seek): Set current time to m_playedTimeRanges
        (WebCore::HTMLMediaElement::currentTime): m_currentTimeDuringSeek -> m_lastSeekTime
        (WebCore::HTMLMediaElement::played): Returns m_playedTimeRanges.
        (WebCore::HTMLMediaElement::updatePlayState): Add the new played time ranges when pausing.
        Set the m_playing flag.
        * html/HTMLMediaElement.h:

        * html/TimeRanges.cpp:
        (TimeRanges::add): Merge range(s) if overlap.
        * html/TimeRanges.h: Add various helpers (below).
        (WebCore::TimeRanges::Range::isPointInRange): Added.
        (WebCore::TimeRanges::Range::isOverlappingRange): Ditto.
        (WebCore::TimeRanges::Range::unionWithOverlappingRange): Ditto.
        (WebCore::TimeRanges::Range::isBeforeRange): Ditto.

2009-04-17  Pierre d'Herbemont <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        Add test for media element 'played' attribute.

        * media/video-played-expected.txt: Added.
        * media/video-played.html: Added.
        * media/video-test.js:
        (disableFullTestDetailsPrinting): New, include less information in 'reportExpected' output
        to accomodate tests with values that are expected to change from run to run.
        (reportExpected): Don't log expected and observed values when printFullTestDetails is false.
        (runSilently): New, same as run() but without logging.
        (run): Call runSilently to run command.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Fri, 17 Apr 2009 19:16:19 +0000 (19:16 +0000)]
WebCore:

2009-04-17  Darin Adler  <darin@apple.com>

        Reviewed by Antti Koivisto.

        Bug 25210: don't use ObjC methods to wrap/unwrap DOM objects with ObjC
        https://bugs.webkit.org/show_bug.cgi?id=25210

        * WebCore.base.exp: Export the core and kit function overloads that are used
        in WebKit. Also resorted this file.

        * WebCore.xcodeproj/project.pbxproj: Re-added DOMHTMLCanvasElement.h to fix
        a strange problem with the file type.

        * bindings/objc/DOM.mm: Removed the many extraneous includes. Added new includes
        so we can use and implement the new core and kit functions. Import DOMInternal.h
        first so it can do its public/private magic.
        (-[DOMNode _rootObject]): Changed to use early-return style.
        (kitClass): Added. Tells the wrapper generator what kind of node class to create
        to wrap DOM nodes. This has the code that used to be in the _wrapNode method.
        (kit): Added. Takes an EventTarget and makes the appropriate type of wrapper,
        dpending on whether it's a Node or an SVGElementInstance. This replace methods
        that used to be on both of those classes.
        (-[DOMNode boundingBox]): Changed to use early return, and the core function.
        (-[DOMNode lineBoxRects]): Ditto.
        (-[DOMNode renderedImage]): Ditto.
        (-[DOMRange boundingBox]): Ditto.
        (-[DOMRange lineBoxRects]): Ditto.
        (-[DOMElement image]): Ditto.
        (-[DOMElement _font]): Ditto.
        (-[DOMElement _imageTIFFRepresentation]): Ditto.
        (-[DOMElement _getURLAttribute:]): Ditto.
        (-[DOMElement isFocused]): Ditto.
        (kit): Hand-wrote the version of this for NodeFilter, since it's a protocol,
        not a class in the binding.
        (core): Ditto.
        (-[DOMNodeFilter acceptNode:]): Use core.

        * bindings/objc/DOMAbstractView.mm:
        (-[DOMAbstractView document]): Use kit.
        (-[DOMAbstractView _disconnectFrame]): Call removeDOMWrapper, which is no longer
        in the WebCore namespace, since it's headed for WebKit in the future.
        (core): Hand-wrote the version of this for DOMAbstractView.mm, since we store
        a pointer to the Frame, not the DMWindow.
        (kit): Ditto.

        * bindings/objc/DOMCSS.mm:
        (kitClass): Added. Tells the wrapper generator what kind of node class to create
        to wrap CSS objects. This has the code that used to be in the _wrapStyleSheet,
        _wrapCSSRule, and _wrapCSSValue methods.

        * bindings/objc/DOMEvents.mm:
        (kitClass): Added. Tells the wrapper generator what kind of node class to create
        to wrap event objects. This has the code that used to be in the _wrapEvent methods.

        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]): Use kit and core.
        (-[DOMHTMLDocument createDocumentFragmentWithText:]): Ditto.
        (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): Ditto.
        (-[DOMHTMLInputElement _rectOnScreen]): Ditto.
        (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): Ditto.
        (-[DOMHTMLInputElement _selectedRange]): Ditto.
        (-[DOMHTMLInputElement _setAutofilled:]): Ditto.
        (-[DOMHTMLSelectElement _activateItemAtIndex:]): Ditto.
        (-[DOMHTMLInputElement _isEdited]): Ditto.
        (-[DOMHTMLTextAreaElement _isEdited]): Ditto.
        (kitClass): Added. Gives HTMLOptionCollection objects an appropriate wrapper.

        * bindings/objc/DOMInternal.h: Removed most of the imports. There's no reason
        to have this header include all the other internal DOM headers. Removed unneeded
        interfaces, including the redeclaration of _init in DOMObject, since it's already
        inherited from WebScriptObject. Moved all the functions out of the WebCore
        namespace since this code is destined for WebKit, which doesn't use a namespace.
        Added kit and core functions for the two classes that live in this header.

        * bindings/objc/DOMInternal.mm:
        (-[WebScriptObject _initializeScriptDOMNodeImp]): Use core.

        * bindings/objc/DOMObject.h: Made the _internal field be private instead of
        protected. This also allows the "#define private public" trick to be used to
        make the field accessible inside the bindings code.

        * bindings/objc/DOMObject.mm:
        (-[DOMObject dealloc]): Updated for namespace change.
        (-[DOMObject sheet]): Use core and kit functions.

        * bindings/objc/DOMRGBColor.mm:
        (-[DOMRGBColor dealloc]): Updated for namespace change.
        (-[DOMRGBColor red]): Use kit function.
        (-[DOMRGBColor green]): Ditto.
        (-[DOMRGBColor blue]): Ditto.
        (-[DOMRGBColor alpha]): Ditto.
        (core): Added. Replaces the _RGBColor method.
        (kit): Added. Replaces the _wrapRGBColor method.

        * bindings/objc/DOMSVGPathSegInternal.mm:
        (kitClass): Added. Replaces the _wrapSVGPathSeg method.

        * bindings/objc/DOMUtility.mm:
        (JSC::createDOMWrapper): Use kit function.
        (createDOMWrapper): Ditto.

        * bindings/objc/DOMXPath.mm:
        (core): Added. Replaces the _xpathNSResolver method.
        (kit): Added. Replaces the _wrapXPathNSResolver method.

        * bindings/objc/ObjCEventListener.mm:
        (WebCore::ObjCEventListener::find): Changed to use early return.
        (WebCore::ObjCEventListener::handleEvent): Use kit function.

        * bindings/objc/ObjCNodeFilterCondition.mm:
        (WebCore::ObjCNodeFilterCondition::acceptNode): Use kit function.

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject scriptObjectForJSObject:originRootObject:rootObject:]):
        Updated for namespace change.

        * bindings/scripts/CodeGeneratorObjC.pm: Changed spelling of "license"
        to U.S. spelling. Removed GetObjCTypeMaker, GetObjCTypeGetterName,
        GetInternalTypeGetterSignature, and GetInternalTypeMakerSignature.
        Changed includes to conform to new scheme. Generate core and kit
        functions instead of methods and calls to those functions. Added a new
        attribute, Polymorphic, to indicate classes that have derived subclasses.
        Removed the old ObjCCustomInternalImpl attribute.

        * css/CSSRule.idl: Use Polymorphic attribute, so core and kit functions
        will be generated, with kit calling kitClass. This requires less hand-
        written code than the old ObjCCustomInternalImpl.
        * css/CSSValue.idl: Ditto.
        * css/StyleSheet.idl: Ditto.
        * dom/Event.idl: Ditto.
        * dom/Node.idl: Ditto.
        * html/HTMLCollection.idl: Ditto.
        * svg/SVGPathSeg.idl: Ditto.

        * editing/TextAffinity.h: Moved kit and core functions out of the
        WebCore namespace since this code is destined for WebKit, which
        doesn't use a namespace

        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::declareAndWriteDragImage): Use kit function.

        * platform/mac/DragDataMac.mm:
        (WebCore::DragData::asFragment): Use core function.

        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeSelection): Use kit function.

        * svg/SVGElementInstance.idl: Removed now-unneeded ObjCCustomInternalImpl
        function. This can be generated in a standard way now.
        * svg/SVGViewSpec.idl: Ditto.

WebKit/mac:

2009-04-17  Darin Adler  <darin@apple.com>

        Reviewed by Antti Koivisto.

        Bug 25210: don't use ObjC methods to wrap/unwrap DOM objects with ObjC
        https://bugs.webkit.org/show_bug.cgi?id=25210

        * DOM/WebDOMOperations.mm:
        (-[DOMNode markupString]): Use the core function instead of an Objective-C method.
        (-[DOMNode _subresourceURLs]): Ditto.
        (-[DOMDocument _focusableNodes]): Ditto.
        (-[DOMRange webArchive]): Ditto.
        (-[DOMRange markupString]): Ditto.

        * Misc/WebElementDictionary.mm: Added now-needed include since the core and kit
        functions now come from the internal headers from DOM bindings.
        * Misc/WebNSPasteboardExtras.mm: Ditto.
        * Plugins/WebNullPluginView.mm: Ditto.
        * Plugins/WebPluginController.mm: Ditto.
        * WebCoreSupport/WebChromeClient.mm: Ditto.
        * WebCoreSupport/WebInspectorClient.mm: Ditto.
        * WebCoreSupport/WebPasteboardHelper.mm: Ditto.
        * WebView/WebHTMLView.mm: Ditto.

        * WebCoreSupport/WebEditorClient.mm: Made kit function have internal linkage
        since it's only used in this file. Someone had instead added a declaration to
        suppress the warning you would otherwise get. Removed the core function.
        (WebEditorClient::textFieldDidBeginEditing): Added correct type checking.
        Previously the function would check only that something was an HTMLElement,
        but then cast it to HTMLInputElement. Also call kit instead of old wrap method.
        (WebEditorClient::textFieldDidEndEditing): Ditto.
        (WebEditorClient::textDidChangeInTextField): Ditto.
        (WebEditorClient::doTextFieldCommandFromEvent): Ditto.
        (WebEditorClient::textWillBeDeletedInTextField): Ditto.
        (WebEditorClient::textDidChangeInTextArea): Ditto, but for HTMLTextAreaElement.

        * WebView/WebFrame.mm: Removed the core and kit functions here which are no longer
        needed since they're automatically generated now.
        (-[WebFrame _nodesFromList:]): Use kit.
        (-[WebFrame _markupStringFromRange:nodes:]): Use core.
        (-[WebFrame _stringForRange:]): More of the same.
        (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
        (-[WebFrame _firstRectForDOMRange:]): Ditto.
        (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
        (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
        Ditto.
        (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
        (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
        (-[WebFrame _markDOMRange]): Ditto.
        (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
        (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
        (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
        (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
        (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
        (-[WebFrame _characterRangeAtPoint:]): Ditto.
        (-[WebFrame _typingStyle]): Ditto.
        (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
        (-[WebFrame _pauseAnimation:onNode:atTime:]): Ditto.
        (-[WebFrame _pauseTransitionOfProperty:onNode:atTime:]): Ditto.
        (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.

        * WebView/WebFrameInternal.h: Removed the core and kit functions here which are no longer
        needed since they're automatically generated now.

        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]): Use core.
        (formElementFromDOMElement): Ditto.
        (inputElementFromDOMElement): Ditto.
        * WebView/WebTextIterator.mm:
        (-[WebTextIterator initWithRange:]): Ditto.
        (-[WebTextIterator currentRange]): Ditto.
        (-[WebTextIterator currentNode]): Ditto.
        * WebView/WebView.mm:
        (-[WebView textIteratorForRect:]): Ditto.
        (-[WebView setSelectedDOMRange:affinity:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Fri, 17 Apr 2009 18:46:38 +0000 (18:46 +0000)]
2009-04-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=25251
        Crash when frame creation removes it from the parent

        This brings us up-to-date with the expectations of sub-frame
        creation, following what Mac has done. It fixes crashes when
        calling init on the child frame removes it from the page.

        This makes the following test pass instead of crash:

          fast/loader/frame-creation-removal.html

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::createFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
beidson@apple.com [Fri, 17 Apr 2009 18:03:18 +0000 (18:03 +0000)]
WebCore:

2009-04-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Maciej Stachowiak

        <rdar://problem/5753299> "Private Browsing" doesn't affect HTML 5 Database storage

        If the Page is in private browsing mode when a statement is queued up, flag that
        statement as read-only.

        It would be better to set the read-only flag on the database thread when it actually
        executes, but that would either require making Settings access a lock-protected operation
        or involve a synchronous callback to the WebCore thread, neither of which seem worth it.
        If it becomes an issue in practice, we can revisit this later.

        Test: storage/private-browsing-readonly.html

        * storage/Database.cpp:
        (WebCore::Database::setAuthorizerReadOnly):
        * storage/Database.h:

        * storage/DatabaseAuthorizer.cpp:  For all action types that would alter the database,
          deny when in read-only mode.
        (WebCore::DatabaseAuthorizer::reset):
        (WebCore::DatabaseAuthorizer::createTable):
        (WebCore::DatabaseAuthorizer::dropTable):
        (WebCore::DatabaseAuthorizer::allowAlterTable):
        (WebCore::DatabaseAuthorizer::createIndex):
        (WebCore::DatabaseAuthorizer::dropIndex):
        (WebCore::DatabaseAuthorizer::createTrigger):
        (WebCore::DatabaseAuthorizer::dropTrigger):
        (WebCore::DatabaseAuthorizer::createVTable):
        (WebCore::DatabaseAuthorizer::dropVTable):
        (WebCore::DatabaseAuthorizer::allowDelete):
        (WebCore::DatabaseAuthorizer::allowInsert):
        (WebCore::DatabaseAuthorizer::allowUpdate):
        (WebCore::DatabaseAuthorizer::setReadOnly):
        * storage/DatabaseAuthorizer.h:

        * storage/SQLStatement.cpp:
        (WebCore::SQLStatement::create): Add a m_readOnly flag.
        (WebCore::SQLStatement::SQLStatement): Ditto.
        (WebCore::SQLStatement::execute): If m_readOnly is set, tell the authorizer to change
          to read-only mode.
        * storage/SQLStatement.h:

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::executeSQL): Flag the statement as read-only if the Page is
          currently in private browsing mode.

LayoutTests:

2009-04-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Maciej Stachowiak

        <rdar://problem/5753299> "Private Browsing" doesn't affect HTML 5 Database storage

        * storage/private-browsing-readonly-expected.txt: Added.
        * storage/private-browsing-readonly.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 17 Apr 2009 17:46:44 +0000 (17:46 +0000)]
2009-04-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        WebKit side of <rdar://problem/6449642>.

        * Plugins/Hosted/HostedNetscapePluginStream.h:
        (WebKit::HostedNetscapePluginStream::create):
        New function that creates a stream from a frame loader.

        * Plugins/Hosted/HostedNetscapePluginStream.mm:
        (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
        Add the constructor that takes a frame loader.

        * Plugins/Hosted/NetscapePluginHostManager.h:
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        Pass "fullFrame" to the plug-in host.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCCancelLoadURL):
        Call NetscapePluginInstanceProxy::cancelStreamLoad.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::create):
        Pass "fullFrame" to the constructor.

        (WebKit::NetscapePluginInstanceProxy::manualStream):
        New getter for the manual stream.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
        Take the implicit request into account if we have a full frame plug-in.

        (WebKit::NetscapePluginInstanceProxy::setManualStream):
        Setter for the manual stream.

        (WebKit::NetscapePluginInstanceProxy::cancelStreamLoad):
        Cancel the manual stream if necessary.

        * Plugins/Hosted/WebHostedNetscapePluginView.h:
        WebHostedNetscapePluginView now conforms to the WebPluginManualLoader protocol.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView createPlugin]):
        Pass "fullFrame" to instantiatePlugin.

        (-[WebHostedNetscapePluginView pluginView:receivedResponse:]):
        (-[WebHostedNetscapePluginView pluginView:receivedData:]):
        (-[WebHostedNetscapePluginView pluginView:receivedError:]):
        (-[WebHostedNetscapePluginView pluginViewFinishedLoading:]):
        Call the equivalent manual stream functions.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createPlugin):
        Use a macro for getting the plug-in view type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix a leak in WebHistory::data().
adachan@apple.com [Fri, 17 Apr 2009 17:44:57 +0000 (17:44 +0000)]
    Fix a leak in WebHistory::data().

        Reviewed by Adam Roben.

        * WebHistory.cpp:
        (WebHistory::data):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Antti Koivisto.
eric@webkit.org [Fri, 17 Apr 2009 17:42:26 +0000 (17:42 +0000)]
    Reviewed by Antti Koivisto.

        Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint
        https://bugs.webkit.org/show_bug.cgi?id=25268

        Lots of minus lines.  Now we're sharing more sane code
        (which will respect -webkit-transforms! and scroll offsets correctly)

        Which means this fixes:
        https://bugs.webkit.org/show_bug.cgi?id=20769 too!

        We're no longer expanding the paint rect "for anti-aliasing", since
        I can't find a case where that's required.  If it is, repaintRectInLocalCoordinates()
        should be fixed to handle those cases instead of here.

        This fixes svg/custom/scroll-hit-test (now that we respect scroll offsets when repainting)
        as well as improves our focus ring drawing seen in svg/custom/focus-ring
        focus rings are now closer to transformed content by a couple pixels (they were needlessly outset by the antialiasing hack)
        Also, it fixes the dumped rects for markers, causing a progression in svg/custom/marker-overflow-clip

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::repaintRectInLocalCoordinates):
        (WebCore::RenderPath::setPath):
        * rendering/RenderPath.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
        (WebCore::RenderSVGModelObject::computeRectForRepaint):
        * rendering/RenderSVGModelObject.h:
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::computeRectForRepaint):
        * rendering/RenderSVGRoot.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Rubber-stamped by Anders Carlsson.
mitz@apple.com [Fri, 17 Apr 2009 16:53:59 +0000 (16:53 +0000)]
    Rubber-stamped by Anders Carlsson.

        - remove tests affected by <rdar://problem/6661401> from the skip list,
          now that it is fixed.

        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 25259: AX: VoiceOver cmd-cntl-space does not follow the google.com->more link
cfleizach@apple.com [Fri, 17 Apr 2009 16:00:16 +0000 (16:00 +0000)]
Bug 25259: AX: VoiceOver cmd-cntl-space does not follow the google.com->more link
https://bugs.webkit.org/show_bug.cgi?id=25259

When a node becomes visible or hidden, accessibility needs to be told to update.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix, added missing header.
kevino@webkit.org [Fri, 17 Apr 2009 15:52:39 +0000 (15:52 +0000)]
wx build fix, added missing header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-17 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Fri, 17 Apr 2009 09:20:35 +0000 (09:20 +0000)]
2009-04-17  Simon Hausmann  <simon.hausmann@nokia.com>

        Unreviewed build fix.

        Fix the build with enabled SVG filters

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Fri, 17 Apr 2009 08:49:29 +0000 (08:49 +0000)]
2009-04-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=25242

        Remove QtCore 4.5 dependency from QWebElement test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 25027: JavaScript parseInt wrong on negative numbers
oliver@apple.com [Fri, 17 Apr 2009 07:34:25 +0000 (07:34 +0000)]
Bug 25027: JavaScript parseInt wrong on negative numbers
<https://bugs.webkit.org/show_bug.cgi?id=25027>

Contributed by Mihnea Ovidenie
Reviewed by Oliver Hunt

When dealing with negative numbers, parseInt should use ceil instead of floor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-16 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Fri, 17 Apr 2009 06:20:32 +0000 (06:20 +0000)]
2009-04-16  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/6744652> 32-bit to 64-bit: Javascript hash tables double in size

        Remove perfect hash optimization which removes 1 MB of overhead on 32-bit and almost 2 MB on 64-bit.  Removing the optimization was not a regression on SunSpider and the acid 3 test still passes.

        * create_hash_table:
        * runtime/Lookup.cpp:
        (JSC::HashTable::createTable):
        (JSC::HashTable::deleteTable):
        * runtime/Lookup.h:
        (JSC::HashEntry::initialize):
        (JSC::HashEntry::next):
        (JSC::HashTable::entry):
        * runtime/Structure.cpp:
        (JSC::Structure::getEnumerableNamesFromClassInfoTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix subtle error in optimised VM reentry in Array.sort
oliver@apple.com [Fri, 17 Apr 2009 04:41:29 +0000 (04:41 +0000)]
Fix subtle error in optimised VM reentry in Array.sort

Reviewed by Gavin Barraclough

Basically to ensure we don't accidentally invalidate the cached callframe
we should be using the cached callframe rather than our own exec state.
While the old behaviour was wrong i have been unable to actually create a
test case where anything actually ends up going wrong.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42605 268f45cc-cd09-0410-ab3c-d52691b4dbfc