WebKit-https.git
7 years ago[Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
vestbo@webkit.org [Thu, 31 May 2012 14:00:53 +0000 (14:00 +0000)]
[Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
https://bugs.webkit.org/show_bug.cgi?id=87955

Reviewed by Simon Hausmann.

Source/WebCore:

* bridge/qt/qt_class.cpp:
* bridge/qt/qt_instance.cpp:
* bridge/qt/qt_runtime.h:
* page/qt/EventHandlerQt.cpp:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/OpenGLShims.cpp:
* platform/graphics/OpenGLShims.h:
* platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
* platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
* platform/graphics/qt/GraphicsContext3DQt.cpp:
* platform/graphics/qt/SimpleFontDataQt.cpp:
* platform/graphics/texmap/TextureMapper.h:
* platform/graphics/texmap/TextureMapperGL.cpp:
* platform/qt/DeviceMotionProviderQt.h:
* platform/qt/DeviceOrientationProviderQt.h:
* platform/qt/KURLQt.cpp:
* platform/qt/PlatformScreenQt.cpp:
* platform/qt/QWebPageClient.h:
* plugins/qt/PluginPackageQt.cpp:
* plugins/qt/PluginViewQt.cpp:

Source/WebKit/qt:

* Api/qgraphicswebview.cpp:
* Api/qgraphicswebview.h:
* Api/qwebframe.cpp:
* Api/qwebframe_p.h:
* Api/qwebpage.cpp:
* Api/qwebpage.h:
* Api/qwebsettings.cpp:
* Api/qwebview.cpp:
* Api/qwebview.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
* WebCoreSupport/GeolocationClientQt.cpp:
* WebCoreSupport/GeolocationClientQt.h:
* WebCoreSupport/PageClientQt.cpp:
* WebCoreSupport/WebEventConversion.cpp:
* declarative/plugin.cpp:
* tests/qwebframe/tst_qwebframe.cpp:
* tests/util.h:

Source/WebKit2:

* UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:

Source/WTF:

* wtf/qt/UtilsQt.h:

Tools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
* DumpRenderTree/qt/EventSenderQt.cpp:
* DumpRenderTree/qt/QtInitializeTestFonts.cpp:
* DumpRenderTree/qt/main.cpp:
* QtTestBrowser/cookiejar.cpp:
* QtTestBrowser/launcherwindow.cpp:
* WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
* qmake/mkspecs/features/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHave StylePropertySet constructor take array/length instead of vector.
kling@webkit.org [Thu, 31 May 2012 13:38:47 +0000 (13:38 +0000)]
Have StylePropertySet constructor take array/length instead of vector.
<http://webkit.org/b/87876>

Reviewed by Antti Koivisto.

Remove the StylePropertyVector typedef and have StylePropertySet constructors
take CSSProperty*/length since we are copying the data into a tightly packed
array anyway. This frees up the call sites to use whatever storage they please
rather than being restricted to a vector with inlineCapacity=4.

Change said call sites to use an arbitrary high inline capacity (256) for their
stack-allocated temporary vectors.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
* css/CSSParser.cpp:
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copyPropertiesInSet):
* css/StylePropertySet.h:
(WebCore::StylePropertySet::create):
(StylePropertySet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r118989
commit-queue@webkit.org [Thu, 31 May 2012 13:24:13 +0000 (13:24 +0000)]
[EFL] Gardening after r118989
https://bugs.webkit.org/show_bug.cgi?id=87958

Unreviewed gardening.

fast/css/font-face-download-error.html is skipped as bug85977 is not fixed yet.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Add missing ViewportUpdateDeferrer guarding to setPageItemRectVisible(...
commit-queue@webkit.org [Thu, 31 May 2012 13:07:36 +0000 (13:07 +0000)]
[Qt][WK2] Add missing ViewportUpdateDeferrer guarding to setPageItemRectVisible() calls.
https://bugs.webkit.org/show_bug.cgi?id=87936

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-31
Reviewed by Kenneth Rohde Christiansen.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::viewportAttributesChanged):
(WebKit::QtViewportInteractionEngine::pageContentsSizeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixing compilation with SVG disabled.
commit-queue@webkit.org [Thu, 31 May 2012 12:41:11 +0000 (12:41 +0000)]
Fixing compilation with SVG disabled.
https://bugs.webkit.org/show_bug.cgi?id=87944

This patch adds the missing enumeration value
'CSSPropertyWebkitBoxDecorationBreak' into switch statements to make
clang happy.

Patch by Mike West <mkwst@chromium.org> on 2012-05-31
Reviewed by Alexis Menard.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed, update Mac Leopard baselines for fast/muticol/span/span-as...
apavlov@chromium.org [Thu, 31 May 2012 12:33:17 +0000 (12:33 +0000)]
[Chromium] Unreviewed, update Mac Leopard baselines for fast/muticol/span/span-as-immediate-columns-child.html.

* platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add WKURLRequestEfl and WKURLResponseEfl
commit-queue@webkit.org [Thu, 31 May 2012 12:30:02 +0000 (12:30 +0000)]
[EFL][WK2] Add WKURLRequestEfl and WKURLResponseEfl
https://bugs.webkit.org/show_bug.cgi?id=70231

Patch by Keunsoon Lee <keunsoon.lee@samsung.com> on 2012-05-31
Reviewed by Chang Shu.

These codes can be used for WKPageDecidePolicyForResponseCallback on page policy callbacks.
The callback conveys WKURLResponseRef and WKURLRequestRef as parameter.

By the way, EFL browser needs content type from response to decide correct policy.
Another information, cookie, is necessary with similar reason.
But, there is no way to obtain such information on WebKit2 main stream, except for WKURLRequestCopyURL().

So, EFL port created those files to extract necessary information from WKURLResponseRef and WKURLRequestRef,
and not to desturb WebKit2 main stream.

* Shared/API/c/efl/WKURLRequestEfl.cpp: Added.
(WKURLRequestEflCopyCookies): extracting cookie information from WKURLRequestRef.
* Shared/API/c/efl/WKURLRequestEfl.h: Added.
* Shared/API/c/efl/WKURLResponseEfl.cpp: Added.
(WKURLResponseEflCopyContentType): extracting content type (i.e. MIME type) from WKURLResponseRef.
* Shared/API/c/efl/WKURLResponseEfl.h: Added.
* Shared/efl/WebCoreArgumentCodersEfl.cpp: Added.
(CoreIPC):
(CoreIPC::::encode):
(CoreIPC::::decode):
* Shared/efl/WebURLRequestEfl.cpp: Added.
(WebKit):
(WebKit::WebURLRequestEfl::WebURLRequestEfl):
(WebKit::WebURLRequestEfl::cookies): obtaining cookie information from ResourceRequest.
* Shared/efl/WebURLRequestEfl.h: Added.
(WebKit):
(WebURLRequestEfl):
(WebKit::WebURLRequestEfl::create):
* Shared/efl/WebURLResponseEfl.cpp: Added.
(WebKit):
(WebKit::WebURLResponseEfl::WebURLResponseEfl):
(WebKit::WebURLResponseEfl::contentType): obtaining content type (i.e. MIME type) from ResourceResponse.
* Shared/efl/WebURLResponseEfl.h: Added.
(WebKit):
(WebURLResponseEfl):
(WebKit::WebURLResponseEfl::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip new failing tests, unskip a now passing test.
ossy@webkit.org [Thu, 31 May 2012 12:06:32 +0000 (12:06 +0000)]
[Qt] Unreviewed gardening, skip new failing tests, unskip a now passing test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Added new baselines for GTK after r117815.
mario@webkit.org [Thu, 31 May 2012 11:57:51 +0000 (11:57 +0000)]
Unreviewed. Added new baselines for GTK after r117815.

* platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
* platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
* platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Updated.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Added new baselines for GTK after r118891.
mario@webkit.org [Thu, 31 May 2012 11:57:31 +0000 (11:57 +0000)]
Unreviewed. Added new baselines for GTK after r118891.

* platform/gtk/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/gtk/fast/forms/select/optgroup-rendering-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Platform] Implementation of Decimal(int32_t) isn't portable.
yosin@chromium.org [Thu, 31 May 2012 11:54:18 +0000 (11:54 +0000)]
[Platform] Implementation of Decimal(int32_t) isn't portable.
https://bugs.webkit.org/show_bug.cgi?id=87941

Reviewed by Kent Tamura.

This patch changes negation of integer to make unsigned integer
in portable way.

No new tests. This patch doesn't change behavior.

* platform/Decimal.cpp:
(WebCore::Decimal::Decimal): Use uint64_t(-int64_t(i32)) instead of uint64_t(-i32)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/events/message-port-multi.html needs new baseline after r119027
ossy@webkit.org [Thu, 31 May 2012 11:48:03 +0000 (11:48 +0000)]
fast/events/message-port-multi.html needs new baseline after r119027
https://bugs.webkit.org/show_bug.cgi?id=87949

Unreviewed gardening.

Update baseline for fast/events/message-port-multi.html after r119027.
Now all the checks are passing and we can get rid of the FAIL lines in
the expected result.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-31

* fast/events/message-port-multi-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Rename ewk_private.h to ewk_view_private.h
gyuyoung.kim@samsung.com [Thu, 31 May 2012 11:35:18 +0000 (11:35 +0000)]
[EFL][WK2] Rename ewk_private.h to ewk_view_private.h
https://bugs.webkit.org/show_bug.cgi?id=87923

Reviewed by Kenneth Rohde Christiansen.

EFL WK1 decided to divide up ewk_private.h into each file's XXX_private.h file in order to maintain
internal functions more easily. EFL WK2 needs to adjust this as well.

* UIProcess/API/efl/PageClientImpl.cpp:
* UIProcess/API/efl/ewk_view_private.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_private.h.
(WebCore):
* UIProcess/cairo/BackingStoreCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Chromium] Cannot bring Inspector to front when paused on breakpoint
apavlov@chromium.org [Thu, 31 May 2012 11:28:40 +0000 (11:28 +0000)]
Web Inspector: [Chromium] Cannot bring Inspector to front when paused on breakpoint
https://bugs.webkit.org/show_bug.cgi?id=87871

Reviewed by Yury Semikhatsky.

When input events handling is suppressed (due to the JS being paused on a breakpoint), we should report
these events as NOT handled by the WebKit, so that the browser can handle them appropriately
(on MacOS, switching between the application windows is done through the default key event handler, so if you run
event.preventDefault() for all keydown events in a handler, the Chromium window switch will not occur on Cmd+`).

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r118993
commit-queue@webkit.org [Thu, 31 May 2012 11:22:29 +0000 (11:22 +0000)]
[EFL] Gardening after r118993
https://bugs.webkit.org/show_bug.cgi?id=87946

Unreviewed gardening.

Test fast/forms/file/input-file-write-files.html that was added at r118993 relies on
unsupported EventSender.beginDragWithFiles and hence should be skipped.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Unskipping tests for GTK now passing in all the bots.
mario@webkit.org [Thu, 31 May 2012 11:14:42 +0000 (11:14 +0000)]
Unreviewed. Unskipping tests for GTK now passing in all the bots.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/dom/Window/mozilla-focus-blur.html failing after r118916
mario@webkit.org [Thu, 31 May 2012 10:42:17 +0000 (10:42 +0000)]
fast/dom/Window/mozilla-focus-blur.html failing after r118916
https://bugs.webkit.org/show_bug.cgi?id=87951

Unreviewed. Added FAIL expectation for GTK after r118916.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTest expectation pngs missing checksums
abecsi@webkit.org [Thu, 31 May 2012 10:10:38 +0000 (10:10 +0000)]
Test expectation pngs missing checksums
https://bugs.webkit.org/show_bug.cgi?id=87947

Reviewed by Ojan Vafai.

Add proper platform independent png expectation with checksum and revert chromium
expectations since layoutTestController.keepWebHistory() seems to have no effect
on chromium, and the test is still failing (See bug 87839).

* http/tests/misc/acid3-expected.png: Add png with embedded checksum.
* platform/chromium-mac-leopard/http/tests/misc/acid3-expected.png: Revert to prior r118566.
* platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png: Revert to prior r118566.
* platform/chromium-mac/http/tests/misc/acid3-expected.png: Revert to prior r118566.
* platform/chromium-mac/http/tests/misc/acid3-expected.txt: Revert to prior r118566.
* platform/chromium/test_expectations.txt: Revert to prior r118566.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [CMAKE][EFL] Remove unneeded include path
gyuyoung.kim@samsung.com [Thu, 31 May 2012 10:02:14 +0000 (10:02 +0000)]
Source/WebCore: [CMAKE][EFL] Remove unneeded include path
https://bugs.webkit.org/show_bug.cgi?id=87927

Reviewed by Kenneth Rohde Christiansen.

Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including the previous
path. In addition, files on EFL port are using "<wtf/gobject/XXX>" directly in #include line.
So, EFL port doesn't need to include ${JAVASCRIPTCORE_DIR}/wtf/gobject path anymore.

* PlatformEfl.cmake: Remove '${JAVASCRIPTCORE_DIR}/wtf/gobject' path from include path list.

Source/WebKit: [CMAKE][EFL] Remove unneeded include path
https://bugs.webkit.org/show_bug.cgi?id=87927

Reviewed by Kenneth Rohde Christiansen.

Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including the previous
path. In addition, files on EFL port are using <wtf/gobject/XXX> directly in #include line.
So, EFL port doesn't need to include ${JAVASCRIPTCORE_DIR}/wtf/gobject path anymore.

* PlatformEfl.cmake: Remove '${JAVASCRIPTCORE_DIR}/wtf/gobject' path from include path list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Thu, 31 May 2012 09:50:29 +0000 (09:50 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Don't enforce the version of libpng for the config test when passing the option...
zoltan@webkit.org [Thu, 31 May 2012 09:47:14 +0000 (09:47 +0000)]
[Qt] Don't enforce the version of libpng for the config test when passing the option to the linker

Rubber-stamped by Kenneth Rohde Christiansen.

* qmake/config.tests/libpng/libpng.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Automatically install 64-bit linker for Android
peter@chromium.org [Thu, 31 May 2012 09:22:45 +0000 (09:22 +0000)]
[Chromium] Automatically install 64-bit linker for Android
https://bugs.webkit.org/show_bug.cgi?id=79780

Reviewed by Adam Barth.

Source/WebKit/chromium:

Change the Android-specific dependencies to inherit their revision from
Chromium's DEPS file, like many other dependencies do, solving the
versioning problem that we're running in to right now. These are listed
in Chromium's main DEPS file starting Chromium r139529.

* DEPS:

Tools:

Change the update-webkit-chromium script to check whether the 64-bit
linker needs to be installed as part of the update process. The actual
code for doing these checks and "installing" it has been added to the
webkitdirs.pm script.

The linker itself is part of the third_party/aosp repository, which
will be pulled in through the DEPS change.

* Scripts/update-webkit-chromium:
* Scripts/webkitdirs.pm:
(chromiumInstall64BitAndroidLinkerIfNeeded):
(chromiumReplaceAndroidLinkerIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r118957
commit-queue@webkit.org [Thu, 31 May 2012 09:02:02 +0000 (09:02 +0000)]
[EFL] Gardening after r118957
https://bugs.webkit.org/show_bug.cgi?id=87937

Unreviewed gardening.

compositing/layer-creation/fixed-position-and-transform.html and compositing/layer-creation/fixed-position-under-transform.html
added with r118957 were skipped in EFL port as EFL's LayoutTestController does not implement layerTreeAsText.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for Chromium Linux (Tests) after r119073.
yosin@chromium.org [Thu, 31 May 2012 08:55:10 +0000 (08:55 +0000)]
Build fix for Chromium Linux (Tests) after r119073.

* tests/DecimalTest.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Rebase xss test, skip failing tests.
kkristof@inf.u-szeged.hu [Thu, 31 May 2012 08:42:35 +0000 (08:42 +0000)]
[Qt] Unreviewed gardening. Rebase xss test, skip failing tests.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-31

* platform/qt/Skipped:
* platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
* platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
* platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Platform] Introduce Decimal class for Number/Range input type.
yosin@chromium.org [Thu, 31 May 2012 08:28:29 +0000 (08:28 +0000)]
[Platform] Introduce Decimal class for Number/Range input type.
https://bugs.webkit.org/show_bug.cgi?id=87360

Reviewed by Kent Tamura.

Source/WebCore:

This patch added new class Decimal for decimal arithmatic in two
files: platform/Decimal.cpp and Decimal.h with unit test.

Test: WebKit/chromium/tests/DecimalTest.cpp

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/Decimal.cpp: Added.
(WebCore):
(DecimalPrivate):
(SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::handle):
(WebCore::DecimalPrivate::SpecialValueHandler::value):
(UInt128):
(WebCore::DecimalPrivate::UInt128::UInt128):
(WebCore::DecimalPrivate::UInt128::high):
(WebCore::DecimalPrivate::UInt128::low):
(WebCore::DecimalPrivate::UInt128::multiply):
(WebCore::DecimalPrivate::UInt128::highUInt32):
(WebCore::DecimalPrivate::UInt128::lowUInt32):
(WebCore::DecimalPrivate::UInt128::isZero):
(WebCore::DecimalPrivate::UInt128::makeUInt64):
(WebCore::DecimalPrivate::UInt128::operator/=):
(WebCore::DecimalPrivate::UInt128::multiplyHigh):
(WebCore::DecimalPrivate::countDigits):
(WebCore::DecimalPrivate::scaleDown):
(WebCore::DecimalPrivate::scaleUp):
(WebCore::Decimal::EncodedData::EncodedData):
(WebCore::Decimal::EncodedData::operator==):
(WebCore::Decimal::Decimal):
(WebCore::Decimal::operator=):
(WebCore::Decimal::operator+=):
(WebCore::Decimal::operator-=):
(WebCore::Decimal::operator*=):
(WebCore::Decimal::operator/=):
(WebCore::Decimal::operator-):
(WebCore::Decimal::operator+):
(WebCore::Decimal::operator*):
(WebCore::Decimal::operator/):
(WebCore::Decimal::operator==):
(WebCore::Decimal::operator!=):
(WebCore::Decimal::operator<):
(WebCore::Decimal::operator<=):
(WebCore::Decimal::operator>):
(WebCore::Decimal::operator>=):
(WebCore::Decimal::abs):
(WebCore::Decimal::alignOperands):
(WebCore::Decimal::ceiling):
(WebCore::Decimal::compareTo):
(WebCore::Decimal::floor):
(WebCore::Decimal::fromString):
(WebCore::Decimal::infinity):
(WebCore::Decimal::nan):
(WebCore::Decimal::remainder):
(WebCore::Decimal::round):
(WebCore::Decimal::toString):
(WebCore::Decimal::zero):
* platform/Decimal.h: Added.
(WebCore):
(DecimalPrivate):
(Decimal):
(EncodedData):
(WebCore::Decimal::EncodedData::operator!=):
(WebCore::Decimal::EncodedData::coefficient):
(WebCore::Decimal::EncodedData::exponent):
(WebCore::Decimal::EncodedData::isFinite):
(WebCore::Decimal::EncodedData::isNaN):
(WebCore::Decimal::EncodedData::isSpecial):
(WebCore::Decimal::EncodedData::isZero):
(WebCore::Decimal::EncodedData::sign):
(WebCore::Decimal::EncodedData::setSign):
(WebCore::Decimal::EncodedData::formatClass):
(WebCore::Decimal::isFinite):
(WebCore::Decimal::isNaN):
(WebCore::Decimal::isNegative):
(WebCore::Decimal::isPositive):
(WebCore::Decimal::isSpecial):
(WebCore::Decimal::isZero):
(WebCore::Decimal::value):
(AlignedOperands):
(WebCore::Decimal::invertSign):
(WebCore::Decimal::exponent):
(WebCore::Decimal::sign):

Source/WebKit/chromium:

This patch added unit test for Decimal class.

* WebKit.gypi:
* tests/DecimalTest.cpp: Added.
(WebCore):
(WebCore::operator<<): Output Decimal for unit test debugging
(DecimalStepRange):
(DecimalStepRange::DecimalStepRange):
(DecimalStepRange::clampValue):
(DecimalTest):
(DecimalTest::encode):
(DecimalTest::fromString):
(DecimalTest::stepDown):
(DecimalTest::stepUp):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Gardening after r118920
commit-queue@webkit.org [Thu, 31 May 2012 08:22:54 +0000 (08:22 +0000)]
[EFL][DRT] Gardening after r118920
https://bugs.webkit.org/show_bug.cgi?id=87934

Unreviewed, gardening of http/tests/local/fileapi/file-last-modified-after-delete.html which
relies on unsupported drag'n'drop feature.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Retainers are missing for all objects
commit-queue@webkit.org [Thu, 31 May 2012 08:05:10 +0000 (08:05 +0000)]
Web Inspector: Retainers are missing for all objects
https://bugs.webkit.org/show_bug.cgi?id=87655

Skip the test on wincairo platform.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-31
Reviewed by Yury Semikhatsky.

* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to v8String() in custom bindings
haraken@chromium.org [Thu, 31 May 2012 08:00:35 +0000 (08:00 +0000)]
[V8] Pass Isolate to v8String() in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=87825

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to v8String() in custom bindings.

No tests. No change in behavior.

* bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
(WebCore::installFastSet):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore):
(WebCore::setWebGLArrayHelper):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::V8CSSStyleDeclaration::namedPropertyEnumerator):
(WebCore::V8CSSStyleDeclaration::namedPropertyGetter):
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toV8Object):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAccessorGetter):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertyGetter):
(WebCore::V8DOMStringMap::namedPropertyEnumerator):
* bindings/v8/custom/V8FileReaderCustom.cpp:
(WebCore::V8FileReader::resultAccessorGetter):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::toDataURLCallback):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8Object):
* bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::databaseIdCallback):
(WebCore::V8InjectedScriptHost::storageIdCallback):
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::V8InspectorFrontendHost::platformCallback):
* bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::typeAccessorGetter):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::toStringCallback):
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallback):
* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::V8Storage::namedPropertyEnumerator):
(WebCore::storageGetter):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
* bindings/v8/custom/V8XSLTProcessorCustom.cpp:
(WebCore::V8XSLTProcessor::getParameterCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoComposedShadowTreeWalker should support traversing nodes in an orphaned shadow subtree.
hayato@chromium.org [Thu, 31 May 2012 07:55:29 +0000 (07:55 +0000)]
ComposedShadowTreeWalker should support traversing nodes in an orphaned shadow subtree.
https://bugs.webkit.org/show_bug.cgi?id=87493

Reviewed by Dimitri Glazkov.

Source/WebCore:

ComposedShadowTreeWalker assumed that a visited shadow root is
always assigned to a shadow insertion point since it only
traverses nodes which are rendered.  But there is an exceptional
use case such as an event dispatching. Some events, such as a
'click' event, may happen in an orphaned shadow subtree.  In such
cases, traversal might start with a node in an orphaned shadow
subtree.  So ComposedShadowTreeWalker can not assume that visited
shadow root is always assigned to a shadow insertion point.

This patch only fixes ComposedShadowTreeWalker.
ComposedShadowTreeParentWalker will be fixed in another patch with
an event dispatching test.

Test: fast/dom/shadow/composed-shadow-tree-walker.html

* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):

LayoutTests:

* fast/dom/shadow/composed-shadow-tree-walker.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: add MemoryUsageSupport::processMemorySizesInBytes
yurys@chromium.org [Thu, 31 May 2012 07:33:16 +0000 (07:33 +0000)]
Web Inspector: add MemoryUsageSupport::processMemorySizesInBytes
https://bugs.webkit.org/show_bug.cgi?id=87830

Reviewed by James Robinson.

Source/Platform:

* chromium/public/Platform.h:
(Platform):
(WebKit::Platform::processMemorySizesInBytes): moved this method from
Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h, also
removed 'get' prefix.

Source/WebCore:

Added a method for getting process memory usage in bytes. It is
used in the inspector memory instrumentation to get process total
memory usage.

* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
* platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::processMemorySizesInBytes):
(WebCore):
* platform/MemoryUsageSupport.h:
(MemoryUsageSupport): provided embedders with a way to report WebKit process
memory usage.
* platform/chromium/MemoryUsageSupportChromium.cpp:
(WebCore::MemoryUsageSupport::processMemorySizesInBytes):
(WebCore):

Source/WebKit/chromium:

* public/platform/WebKitPlatformSupport.h: pulled getProcessMemorySize up
to the Source/Platform/chromium/public/Platform.h
* src/PlatformSupport.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r119062 and r119064.
tkent@chromium.org [Thu, 31 May 2012 07:22:58 +0000 (07:22 +0000)]
Unreviewed, rolling out r119062 and r119064.
http://trac.webkit.org/changeset/119062
http://trac.webkit.org/changeset/119064
https://bugs.webkit.org/show_bug.cgi?id=87360

Broke build on Lion, SnowLoepard, Chromium Windows, and
Chromium Linux 32

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/Decimal.cpp: Removed.
* platform/Decimal.h: Removed.

Source/WebKit/chromium:

* WebKit.gypi:
* tests/DecimalTest.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove the specification of framework and library linking out of WebKit2.xcodeproj...
aestes@apple.com [Thu, 31 May 2012 07:18:32 +0000 (07:18 +0000)]
Move the specification of framework and library linking out of WebKit2.xcodeproj and into WebKit2.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=87932

Reviewed by Dan Bernstein.

Doing this makes it easier to vary linking based on SDK or other factors.

* Configurations/WebKit2.xcconfig: Create FRAMEWORK_AND_LIBRARY_LDFLAGS,
which specifies the same list of frameworks and libraries that were
previously in WebKit2's 'Link Binary With Libraries' build phase, and
append it to $(OTHER_LDFLAGS).
* WebKit2.xcodeproj/project.pbxproj: Remove all frameworks and
libraries from the 'Link Binary With Libraries' build phase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agotext-decoration should not be propagated through absolutely positioned elements to...
commit-queue@webkit.org [Thu, 31 May 2012 07:12:48 +0000 (07:12 +0000)]
text-decoration should not be propagated through absolutely positioned elements to <a> tags
https://bugs.webkit.org/show_bug.cgi?id=86517

Source/WebCore:

Patch by Shane Stephens <shanestephens@google.com> on 2012-05-31
Reviewed by Darin Adler.

Test: fast/css/text-decoration-in-second-order-descendants.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::getTextDecorationColors):
Remove fix from 18611 as it doesn't work on second order descendants.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
Add floating and positioned checks when deciding whether to avoid propagating text decoration. Move all checks into new method to improve readability.
(WebCore::doesNotInheritTextDecoration): Added

LayoutTests:

Added layout test to check no propagation of text-decoration to second-order descendants
(i.e. descendants of descendants), where the first-order descendant is positioned.

Tightened up existing descendants test to fail when text-decoration is incorrectly propagated
to first-order descendant.

Patch by Shane Stephens <shanestephens@google.com> on 2012-05-31
Reviewed by Darin Adler.

* fast/css/text-decoration-in-descendants-expected.html:
* fast/css/text-decoration-in-second-order-descendants-expected.html: Added.
* fast/css/text-decoration-in-second-order-descendants.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for Linon/SnowLeopard after r119062
yosin@chromium.org [Thu, 31 May 2012 06:58:10 +0000 (06:58 +0000)]
Build fix for Linon/SnowLeopard after r119062

* platform/Decimal.cpp:
(WebCore::Decimal::Decimal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] [WK2] Memory leak in webkitWebViewBaseStartDrag
commit-queue@webkit.org [Thu, 31 May 2012 06:46:16 +0000 (06:46 +0000)]
[GTK] [WK2] Memory leak in webkitWebViewBaseStartDrag
https://bugs.webkit.org/show_bug.cgi?id=87756

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-30
Reviewed by Carlos Garcia Campos.

Source/WebKit/gtk:

Fixed a memory leak in drag and drop by using adoptRef instead
of just getting a new reference of targetList.

* WebCoreSupport/DragClientGtk.cpp:
(WebKit::DragClient::startDrag):

Source/WebKit2:

Fixed memory leaks in drag and drop by using adoptRef instead
of just getting new references.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseStartDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Platform] Introduce Decimal class for Number/Range input type.
yosin@chromium.org [Thu, 31 May 2012 06:36:42 +0000 (06:36 +0000)]
[Platform] Introduce Decimal class for Number/Range input type.
https://bugs.webkit.org/show_bug.cgi?id=87360

Reviewed by Kent Tamura.

Source/WebCore:

This patch added new class Decimal for decimal arithmatic in two
files: platform/Decimal.cpp and Decimal.h with unit test.

Test: WebKit/chromium/tests/DecimalTest.cpp

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/Decimal.cpp: Added.
(WebCore):
(DecimalPrivate):
(SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::handle):
(WebCore::DecimalPrivate::SpecialValueHandler::value):
(UInt128):
(WebCore::DecimalPrivate::UInt128::UInt128):
(WebCore::DecimalPrivate::UInt128::high):
(WebCore::DecimalPrivate::UInt128::low):
(WebCore::DecimalPrivate::UInt128::multiply):
(WebCore::DecimalPrivate::UInt128::highUInt32):
(WebCore::DecimalPrivate::UInt128::lowUInt32):
(WebCore::DecimalPrivate::UInt128::isZero):
(WebCore::DecimalPrivate::UInt128::makeUInt64):
(WebCore::DecimalPrivate::UInt128::operator/=):
(WebCore::DecimalPrivate::UInt128::multiplyHigh):
(WebCore::DecimalPrivate::countDigits):
(WebCore::DecimalPrivate::scaleDown):
(WebCore::DecimalPrivate::scaleUp):
(WebCore::Decimal::EncodedData::EncodedData):
(WebCore::Decimal::EncodedData::operator==):
(WebCore::Decimal::Decimal):
(WebCore::Decimal::operator=):
(WebCore::Decimal::operator+=):
(WebCore::Decimal::operator-=):
(WebCore::Decimal::operator*=):
(WebCore::Decimal::operator/=):
(WebCore::Decimal::operator-):
(WebCore::Decimal::operator+):
(WebCore::Decimal::operator*):
(WebCore::Decimal::operator/):
(WebCore::Decimal::operator==):
(WebCore::Decimal::operator!=):
(WebCore::Decimal::operator<):
(WebCore::Decimal::operator<=):
(WebCore::Decimal::operator>):
(WebCore::Decimal::operator>=):
(WebCore::Decimal::abs):
(WebCore::Decimal::alignOperands):
(WebCore::Decimal::ceiling):
(WebCore::Decimal::compareTo):
(WebCore::Decimal::floor):
(WebCore::Decimal::fromString):
(WebCore::Decimal::infinity):
(WebCore::Decimal::nan):
(WebCore::Decimal::remainder):
(WebCore::Decimal::round):
(WebCore::Decimal::toString):
(WebCore::Decimal::zero):
* platform/Decimal.h: Added.
(WebCore):
(DecimalPrivate):
(Decimal):
(EncodedData):
(WebCore::Decimal::EncodedData::operator!=):
(WebCore::Decimal::EncodedData::coefficient):
(WebCore::Decimal::EncodedData::exponent):
(WebCore::Decimal::EncodedData::isFinite):
(WebCore::Decimal::EncodedData::isNaN):
(WebCore::Decimal::EncodedData::isSpecial):
(WebCore::Decimal::EncodedData::isZero):
(WebCore::Decimal::EncodedData::sign):
(WebCore::Decimal::EncodedData::setSign):
(WebCore::Decimal::EncodedData::formatClass):
(WebCore::Decimal::isFinite):
(WebCore::Decimal::isNaN):
(WebCore::Decimal::isNegative):
(WebCore::Decimal::isPositive):
(WebCore::Decimal::isSpecial):
(WebCore::Decimal::isZero):
(WebCore::Decimal::value):
(AlignedOperands):
(WebCore::Decimal::invertSign):
(WebCore::Decimal::exponent):
(WebCore::Decimal::sign):

Source/WebKit/chromium:

This patch added unit test for Decimal class.

* WebKit.gypi:
* tests/DecimalTest.cpp: Added.
(WebCore):
(WebCore::operator<<): Output Decimal for unit test debugging
(DecimalStepRange):
(DecimalStepRange::DecimalStepRange):
(DecimalStepRange::clampValue):
(DecimalTest):
(DecimalTest::encode):
(DecimalTest::fromString):
(DecimalTest::stepDown):
(DecimalTest::stepUp):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r116723.
paroga@webkit.org [Thu, 31 May 2012 06:30:03 +0000 (06:30 +0000)]
Build fix for WinCE after r116723.

* platform/graphics/wince/FontWinCE.cpp:
(WebCore::TextRunComponent::TextRunComponent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement CSSParser::determineNameInNamespace() as a helper function for CSSGrammar.y
haraken@chromium.org [Thu, 31 May 2012 06:23:53 +0000 (06:23 +0000)]
Implement CSSParser::determineNameInNamespace() as a helper function for CSSGrammar.y
https://bugs.webkit.org/show_bug.cgi?id=87799

Reviewed by Darin Adler.

As pointed out by darin@ in https://bugs.webkit.org/show_bug.cgi?id=87627#c12,
we should avoid repeating the following code in CSSGrammar.y:

    if (p->m_styleSheet)
        $$->setTag(QualifiedName(namespacePrefix, $2, p->m_styleSheet->determineNamespace(namespacePrefix)));
    else
        $$->setTag(QualifiedName(namespacePrefix, $2, p->m_defaultNamespace));

This patch implements CSSParser::determineNameInNamespace() as a helper function
and replaces the above code.

Tests: fast/dom/SelectorAPI/*. No change in test results.

* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::determineNameInNamespace):
(WebCore):
* css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r117697.
paroga@webkit.org [Thu, 31 May 2012 06:15:17 +0000 (06:15 +0000)]
Build fix for WinCE after r117697.

* page/wince/FrameWinCE.cpp:
(WebCore::computePageRectsForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix min/max bounds error in CCMathUtil.cpp
shawnsingh@chromium.org [Thu, 31 May 2012 06:05:30 +0000 (06:05 +0000)]
[chromium] Fix min/max bounds error in CCMathUtil.cpp
https://bugs.webkit.org/show_bug.cgi?id=87915

Reviewed by James Robinson.

Source/WebCore:

Two unit tests added to CCMathUtilTest:
    CCMathUtilTest.verifyEnclosingClippedRectUsesCorrectInitialBounds
    CCMathUtilTest.verifyEnclosingRectOfVerticesUsesCorrectInitialBounds

While computing bounds, the initial values for xmax and ymax are
intended to be set to -float_max. It turns out that
std::numeric_limits<float>::min() actually returns the smallest
positive value close to zero, which is not what was intended. This
patch fixes the code to use -float_max instead, which is the
intended value.

* platform/graphics/chromium/cc/CCMathUtil.cpp:
(WebCore::CCMathUtil::mapClippedRect):
(WebCore::CCMathUtil::projectClippedRect):
(WebCore::CCMathUtil::computeEnclosingRectOfVertices):
(WebCore::CCMathUtil::computeEnclosingClippedRect):
(WebCore):
* platform/graphics/chromium/cc/CCMathUtil.h:
(WebCore::HomogeneousCoordinate::HomogeneousCoordinate):
(HomogeneousCoordinate):
(WebCore::HomogeneousCoordinate::shouldBeClipped):
(WebCore::HomogeneousCoordinate::cartesianPoint2d):
(WebCore):
(CCMathUtil):

Source/WebKit/chromium:

* tests/CCMathUtilTest.cpp:
(WebCore::TEST):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r118568.
paroga@webkit.org [Thu, 31 May 2012 05:58:45 +0000 (05:58 +0000)]
Build fix for WinCE after r118568.

* platform/text/wince/TextBreakIteratorWinCE.cpp:
(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRoll chromium DEPS from r139300 to r139542. Unreviewed.
fischman@chromium.org [Thu, 31 May 2012 05:50:23 +0000 (05:50 +0000)]
Roll chromium DEPS from r139300 to r139542.  Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=87868

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in ContainerNode::parserAddChild.
inferno@chromium.org [Thu, 31 May 2012 04:25:01 +0000 (04:25 +0000)]
Crash in ContainerNode::parserAddChild.
https://bugs.webkit.org/show_bug.cgi?id=87903

Reviewed by Ryosuke Niwa.

Source/WebCore:

Call the ChildNodeInsertionNotifier.notify call at the end since
it can destroy |this| and some of the local pointers like |last|.
This also matches the order of calls - childrenChanged precedes
ChildNodeInsertionNotifier.notify in updateTreeAfterInsertion and
ContainerNode::parserInsertBefore.

Also remove a FIXME since we use ChildNodeInsertionNotifier.notify
instead of ChildNodeInsertionNotifier.notifyInsertedIntoDocument
(as recommended in the FIXME).

Test: fast/dom/child-insertion-notify-crash.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserAddChild):

LayoutTests:

* fast/dom/child-insertion-notify-crash-expected.txt: Added.
* fast/dom/child-insertion-notify-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add an Accelerated Compositing layer for Web Inspector DOM highlight.
commit-queue@webkit.org [Thu, 31 May 2012 03:59:39 +0000 (03:59 +0000)]
[BlackBerry] Add an Accelerated Compositing layer for Web Inspector DOM highlight.
https://bugs.webkit.org/show_bug.cgi?id=81001

Source/WebKit:

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-05-30
Reviewed by Antonio Gomes

Added new InspectorOverlay class

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-05-30
Reviewed by Antonio Gomes.

Implemented InspectorOverlay using WebOverlayAPI.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::setInspectorOverlayClient):
(WebKit):
* Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
* WebCoreSupport/InspectorClientBlackBerry.cpp:
(WebCore::InspectorClientBlackBerry::highlight):
(WebCore::InspectorClientBlackBerry::hideHighlight):
(WebCore::InspectorClientBlackBerry::paintInspectorOverlay):
(WebCore):
* WebCoreSupport/InspectorClientBlackBerry.h:
(InspectorClientBlackBerry):
* WebCoreSupport/InspectorOverlay.cpp: Added.
(WebCore):
(WebCore::InspectorOverlay::create):
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::notifySyncRequired):
(WebCore::InspectorOverlay::paintContents):
(WebCore::InspectorOverlay::showDebugBorders):
(WebCore::InspectorOverlay::showRepaintCounter):
(WebCore::InspectorOverlay::contentsVisible):
(WebCore::InspectorOverlay::~InspectorOverlay):
(WebCore::InspectorOverlay::clear):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::paintWebFrame):
(WebCore::InspectorOverlay::invalidateWebFrame):
* WebCoreSupport/InspectorOverlay.h: Added.
(WebKit):
(WebCore):
(InspectorOverlay):
(InspectorOverlayClient):
(WebCore::InspectorOverlay::setClient):
(WebCore::InspectorOverlay::notifyAnimationStarted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Implement pointer and hover CSS media features
commit-queue@webkit.org [Thu, 31 May 2012 03:56:21 +0000 (03:56 +0000)]
[chromium] Implement pointer and hover CSS media features
https://bugs.webkit.org/show_bug.cgi?id=87403

Patch by Rick Byers <rbyers@chromium.org> on 2012-05-30
Reviewed by Adam Barth.

Source/WebCore:

Add initial support for the pointer and hover media features as defined
here:
http://dev.w3.org/csswg/css4-mediaqueries/#pointer
http://dev.w3.org/csswg/css4-mediaqueries/#hover

For now this only supports the case where we know a touch screen is
available (currently known only for the chromium port on certain
platforms).  All other cases continue to behave exactly as if the media
feature isn't supported.

Tests: fast/media/mq-pointer.html

* css/CSSValueKeywords.in:
* css/MediaFeatureNames.h:
(MediaFeatureNames):
* css/MediaQueryEvaluator.cpp:
(WebCore::getLeastCapablePrimaryPointerDeviceType):
(WebCore):
(WebCore::hoverMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setDeviceSupportsTouch):
(WebCore):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:

LayoutTests:

Adds tests for pointer and hover media features, for the initial cases
with and without a touch screen.

* fast/media/mq-pointer-expected.txt: Added.
* fast/media/mq-pointer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] Need implementation of layoutTestController.setBackingScaleFactor
jberlin@webkit.org [Thu, 31 May 2012 03:26:15 +0000 (03:26 +0000)]
[Win] Need implementation of layoutTestController.setBackingScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=87919

Add tests that use setBackingScaleFactor to the Windows Skipped list.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd an helper function to get the style for a cell's flow computation
jchaffraix@webkit.org [Thu, 31 May 2012 03:15:06 +0000 (03:15 +0000)]
Add an helper function to get the style for a cell's flow computation
https://bugs.webkit.org/show_bug.cgi?id=87902

Reviewed by Ojan Vafai.

No expected change in behavior.

This change introduces styleForCellFlow that unify which function we use
to determine a cell's direction and writing mode.

This unification will make it easier to support direction on table row
group (section in WebKit land).

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::styleForCellFlow):
Added the new function along with a comment as to its purpose.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
(WebCore::RenderTableCell::borderHalfLeft):
(WebCore::RenderTableCell::borderHalfRight):
(WebCore::RenderTableCell::borderHalfTop):
(WebCore::RenderTableCell::borderHalfBottom):
(WebCore::RenderTableCell::borderHalfStart):
(WebCore::RenderTableCell::borderHalfEnd):
(WebCore::RenderTableCell::borderHalfBefore):
(WebCore::RenderTableCell::borderHalfAfter):
(WebCore::RenderTableCell::paintCollapsedBorders):
Mostly mechanical replacement.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::cachedCollapsedLeftBorder):
(WebCore::RenderTableCell::cachedCollapsedRightBorder):
(WebCore::RenderTableCell::cachedCollapsedTopBorder):
(WebCore::RenderTableCell::cachedCollapsedBottomBorder):
Made the argument 'const' now.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
Added a FIXME to unify with the rest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=87803
slewis@apple.com [Thu, 31 May 2012 03:05:34 +0000 (03:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=87803
Layout tests often fail trying to stat nonexistent logs

Reviewed by Dirk Pranke.

CrashReporter removes logs using a heuristic to conserve space.  Wrap a
try/catch block around accessing the logs as a precaution.

* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs._find_newest_log_darwin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHeap should sweep incrementally
mhahnenberg@apple.com [Thu, 31 May 2012 03:04:00 +0000 (03:04 +0000)]
Heap should sweep incrementally
https://bugs.webkit.org/show_bug.cgi?id=85429

We shouldn't have to wait for the opportunistic GC timer to fire in order
to call object destructors. Instead, we should incrementally sweep some
subset of the blocks requiring sweeping periodically. We tie this sweeping
to a timer rather than to collections because we want to reclaim this memory
even if we stop allocating. This way, our memory usage scales smoothly with
actual use, regardless of whether we've recently done an opportunistic GC or not.

Reviewed by Geoffrey Garen.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::collect): We no longer sweep during a full sweep. We only shrink now,
which we will switch over to being done during incremental sweeping too as soon as
all finalizers can be run lazily (and, by extension, incrementally).
(JSC::Heap::sweeper):
(JSC):
* heap/Heap.h:
(JSC):
(Heap):
* heap/IncrementalSweeper.cpp: Added.
(JSC):
(JSC::IncrementalSweeper::timerDidFire): The IncrementalSweeper works very similarly to
GCActivityCallback. It is tied to a run-loop based timer that fires periodically based
on how long the previous sweep increment took to run. The IncrementalSweeper doesn't do
anything if the platform doesn't support CoreFoundation.
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC::IncrementalSweeper::~IncrementalSweeper):
(JSC::IncrementalSweeper::create):
(JSC::IncrementalSweeper::scheduleTimer):
(JSC::IncrementalSweeper::cancelTimer):
(JSC::IncrementalSweeper::doSweep): Iterates over the snapshot of the MarkedSpace taken
during the last collection, checking to see which blocks need sweeping. If it successfully
gets to the end of the blocks that need sweeping then it cancels the timer.
(JSC::IncrementalSweeper::startSweeping): We take a snapshot of the Heap and store it in
a Vector that the incremental sweep will iterate over. We also reset our index into this Vector.
* heap/IncrementalSweeper.h: Added.
(JSC):
(IncrementalSweeper):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::needsSweeping): If a block is in the Marked state it needs sweeping
to be usable and to run any destructors that need to be run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[JSC] SerializedScriptValue.create() succeeds even if MessagePort object cannot be...
commit-queue@webkit.org [Thu, 31 May 2012 02:58:48 +0000 (02:58 +0000)]
[JSC] SerializedScriptValue.create() succeeds even if MessagePort object cannot be found in transferred ports
https://bugs.webkit.org/show_bug.cgi?id=87118

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-30
Reviewed by Adam Barth.

Source/WebCore:

Make SerializedScriptValue.create() throw an exception if one of the
MessagePort objects cannot be found in the transferred ports. This
matches the behavior of the V8 implementation.

Test: webintents/web-intents-obj-constructor.html

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpIfTerminal):

LayoutTests:

Unskip webintents/web-intents-obj-constructor.html now that
SerializedScriptValue.create() throws an exception if one of the
MessagePort objects cannot be found in the transferred ports.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] Need results for ietestcenter CSS3 tests
jberlin@webkit.org [Thu, 31 May 2012 02:53:48 +0000 (02:53 +0000)]
[Win] Need results for ietestcenter CSS3 tests
https://bugs.webkit.org/show_bug.cgi?id=87916

Add expected (failing?) results to get the bots greener.

* platform/win/ietestcenter/css3/flexbox/flexbox-align-baseline-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-baseline-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-center-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-center-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-center-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-center-002-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-end-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-end-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-start-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-start-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-stretch-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-stretch-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-direction-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-direction-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-002-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-003-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-004-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-004-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-005-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-005-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-002-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-003-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-004-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-004-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-layout-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-layout-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-layout-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-layout-002-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-layout-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-layout-003-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-ordinal-group-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-center-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-center-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-end-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-end-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-start-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-start-001-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/display-grid-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/display-grid-001-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/display-grid-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/display-grid-002-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-column-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-column-001-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-column-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-column-002-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-column-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-column-003-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-columns-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-columns-001-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-001-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-002-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-003-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-004-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-004-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-005-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-005-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-block-formatting-context-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-block-formatting-context-001-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-containing-block-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-containing-block-001-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-containing-block-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-containing-block-002-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-containing-block-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-containing-block-003-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-filling-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-filling-001-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-001-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-002-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-003-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-004-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-004-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-005-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-005-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-006-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-006-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-007-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-007-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-008-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-008-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-009-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-009-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-010-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-010-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-012-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-012-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-013-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-013-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-014-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-014-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-015-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-015-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-negative-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-negative-001-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-percentage-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-percentage-001-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/declaring-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/declaring-001-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-007-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-007-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-008-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-008-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-009-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-009-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-010-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-010-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-011-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-011-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/qualifiedNames-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/qualifiedNames-001-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/scope-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/scope-003-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-016-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-016-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-017-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-017-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-018-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-018-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-019-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-019-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-020-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-020-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-021-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-021-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-022-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-022-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-023-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-023-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/terminology-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/terminology-001-expected.txt: Added.
* platform/win/ietestcenter/css3/valuesandunits/units-000-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/valuesandunits/units-010-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/valuesandunits/units-010-expected.txt: Added.
* platform/win/ietestcenter/css3/valuesandunits/units-020-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/valuesandunits/units-020-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Call fileUtilities methods directly
pilgrim@chromium.org [Thu, 31 May 2012 02:31:36 +0000 (02:31 +0000)]
[Chromium] Call fileUtilities methods directly
https://bugs.webkit.org/show_bug.cgi?id=87852

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
* platform/chromium/FileSystemChromium.cpp:
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::getFileMetadata):
(WebCore::directoryName):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::openFile):
(WebCore::closeFile):
(WebCore::seekFile):
(WebCore::truncateFile):
(WebCore::readFromFile):
(WebCore::writeToFile):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoForm controls in <fieldset disabled> should not be focusable.
tkent@chromium.org [Thu, 31 May 2012 02:24:22 +0000 (02:24 +0000)]
Form controls in <fieldset disabled> should not be focusable.
https://bugs.webkit.org/show_bug.cgi?id=87380

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/fieldset/focus-in-fieldset-disabled.html

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::supportsFocus):
Refer to disabled() instead of m_disabled to take account of wrapping
fieldset elements.

LayoutTests:

* fast/forms/fieldset/fieldset-disabled-expected.txt:
* fast/forms/fieldset/fieldset-disabled.html:
Updated because disabled controls are not focusable.
Also, remove testing elements to remove unnecessary blank lines.
* fast/forms/fieldset/focus-in-fieldset-disabled-expected.txt: Added.
* fast/forms/fieldset/focus-in-fieldset-disabled.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix a composed-shadow-tree-walker.html so that it uses correct selectors.
hayato@chromium.org [Thu, 31 May 2012 02:17:42 +0000 (02:17 +0000)]
Fix a composed-shadow-tree-walker.html so that it uses correct selectors.
https://bugs.webkit.org/show_bug.cgi?id=87500

Reviewed by Dimitri Glazkov.

Fix a test and an expectation for composed-shadow-tree-walker.html.
A current composed-shadow-tree-walker.html uses class selector
(.class).  That's not the test author's intention and the expected
text was wrongly generated based on wrong tests.

* fast/dom/shadow/composed-shadow-tree-walker-expected.txt:
* fast/dom/shadow/composed-shadow-tree-walker.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wx] Implement HTML clipboard support.
kevino@webkit.org [Thu, 31 May 2012 02:03:00 +0000 (02:03 +0000)]
[wx] Implement HTML clipboard support.
https://bugs.webkit.org/show_bug.cgi?id=87883

Reviewed by Kevin Ollivier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTextFieldDecorationElement should respect style attribute
commit-queue@webkit.org [Thu, 31 May 2012 02:01:50 +0000 (02:01 +0000)]
TextFieldDecorationElement should respect style attribute
https://bugs.webkit.org/show_bug.cgi?id=87762

Patch by Garrett Casto <gcasto@chromium.org> on 2012-05-30
Reviewed by Kent Tamura.

* html/shadow/TextFieldDecorationElement.cpp: Use style set on the
Element when creating rendering style.
(WebCore::TextFieldDecorationElement::customStyleForRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a LayoutTest for prerender remove after stop.
gavinp@chromium.org [Thu, 31 May 2012 01:54:50 +0000 (01:54 +0000)]
Add a LayoutTest for prerender remove after stop.
https://bugs.webkit.org/show_bug.cgi?id=87860

Tools:

These very boring mocks in DumpRenderTree mean that the basic Prerendering API
can be tested by LayoutTests now.

Reviewed by Adam Barth.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
(MockWebPrerenderingSupport::MockWebPrerenderingSupport):
(MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
(MockWebPrerenderingSupport::add):
(MockWebPrerenderingSupport::cancel):
(MockWebPrerenderingSupport::abandon):
* DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
(MockWebPrerenderingSupport):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::willAddPrerender):
(WebViewHost::setWebWidget):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

LayoutTests:

Bug 87746 was uploaded without a LayoutTest because I originally thought
it would only be testable in Chrome with a browser test.  However, that was
wrong.

Note that this test doesn't need to be disabled based on if the platform
uses Prerendering, since the test is for a crash, which won't happen on
platforms without prerendering, either.

Reviewed by Adam Barth.

* fast/dom/HTMLLinkElement/prerender-remove-after-stop-expected.txt: Added.
* fast/dom/HTMLLinkElement/prerender-remove-after-stop.html: Added.
* fast/dom/HTMLLinkElement/resources/empty.html: Added.
* fast/dom/HTMLLinkElement/resources/simple-prerender.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=87717
slewis@apple.com [Thu, 31 May 2012 01:51:50 +0000 (01:51 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=87717
Unresponsive WebProcesses can be mistaken for WebProcess crashes.

Reviewed by Dirk Pranke.

Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
If there isn't a crash log found for the process add a message saying
the process was unresponsive.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.__init__):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(WebKitDriverTest.test_check_for_driver_crash.assert_crash):
(WebKitDriverTest):
(WebKitDriverTest.test_check_for_driver_crash):
* WebKitTestRunner/TestController.cpp:
(WTR):
(WTR::TestController::runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=87714
slewis@apple.com [Thu, 31 May 2012 01:51:26 +0000 (01:51 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=87714
Mac crash logs can take a really long time to be written out.

Reviewed by Dirk Pranke.

Make a second pass looking for crash logs after the tests have completed running.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(use_trac_links_in_results_html):
(Manager.run):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.repository_paths):
(Port.look_for_new_crash_logs):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.look_for_new_crash_logs):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_get_crash_log):
(test_look_for_new_crash_logs):
(test_look_for_new_crash_logs.fake_time_cb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WINCE] Fix JSString after r115516.
paroga@webkit.org [Thu, 31 May 2012 01:38:17 +0000 (01:38 +0000)]
[WINCE] Fix JSString after r115516.
https://bugs.webkit.org/show_bug.cgi?id=87892

Reviewed by Geoffrey Garen.

r115516 splitted JSString into two classes, with addition nested classes.
Add a workaround for the WinCE compiler since it can't resolve the friend class
declerations corretly and denies the access to protected members of JSString.

* runtime/JSString.h:
(JSC::JSRopeString::RopeBuilder::append):
(JSC::JSRopeString::append):
(JSRopeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAvoid second layout for flex-direction:row, flex-basis:auto flex items
ojan@chromium.org [Thu, 31 May 2012 01:37:04 +0000 (01:37 +0000)]
Avoid second layout for flex-direction:row, flex-basis:auto flex items
https://bugs.webkit.org/show_bug.cgi?id=87901

Reviewed by Tony Chang.

No new tests. This is strictly a performance optimization and has no other
web visible changes.

Also, add FIXMEs for other cases where we could avoid doing layouts.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKit incorrectly clears the alpha channel on readPixels, even for Framebuffers
zmo@google.com [Thu, 31 May 2012 01:31:46 +0000 (01:31 +0000)]
WebKit incorrectly clears the alpha channel on readPixels, even for Framebuffers
https://bugs.webkit.org/show_bug.cgi?id=87310

Reviewed by Kenneth Russell.

Source/WebCore:

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::getParameter): set DEPTH_BITS/STENCIL_BITS to 0 if related channels are not requested.
(WebCore::WebGLRenderingContext::readPixels): don't do the alpha value fix if the current bound is not the internal drawing buffer.

LayoutTests:

* fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
* fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: synced with khronos

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r118986.
rafaelw@chromium.org [Thu, 31 May 2012 01:21:39 +0000 (01:21 +0000)]
Unreviewed, rolling out r118986.
http://trac.webkit.org/changeset/118986
https://bugs.webkit.org/show_bug.cgi?id=87914

Caused several IndexedDB browser_test failures on Chromium
canary builders (Requested by rafaelw_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-30

Source/WebCore:

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::advance):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setVersion):
* Modules/indexeddb/IDBDatabaseError.h:
(WebCore::IDBDatabaseError::create):
(IDBDatabaseError):
(WebCore::IDBDatabaseError::createWithoutOffset):
(WebCore::IDBDatabaseError::code):
(WebCore::IDBDatabaseError::setCode):
(WebCore::IDBDatabaseError::setMessage):
(WebCore::IDBDatabaseError::IDBDatabaseError):
* Modules/indexeddb/IDBDatabaseException.cpp:
(WebCore):
(WebCore::IDBDatabaseException::initializeDescription):
* Modules/indexeddb/IDBDatabaseException.h:
(IDBDatabaseException):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::dispatchEvent):
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
* Modules/indexeddb/IDBRequest.idl:
* Modules/indexeddb/IDBTransaction.cpp:
* Modules/indexeddb/IDBTransaction.h:
(IDBTransaction):
* Modules/indexeddb/IDBTransaction.idl:

Source/WebKit/chromium:

* src/WebIDBDatabaseError.cpp:
(WebKit::WebIDBDatabaseError::assign):

LayoutTests:

* storage/indexeddb/basics-expected.txt:
* storage/indexeddb/basics-workers-expected.txt:
* storage/indexeddb/create-and-remove-object-store-expected.txt:
* storage/indexeddb/cursor-continue-expected.txt:
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/database-basics-expected.txt:
* storage/indexeddb/deleteIndex-expected.txt:
* storage/indexeddb/factory-cmp-expected.txt:
* storage/indexeddb/get-keyrange-expected.txt:
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics-workers-expected.txt:
* storage/indexeddb/index-count-expected.txt:
* storage/indexeddb/index-unique-expected.txt:
* storage/indexeddb/invalid-keys-expected.txt:
* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/keypath-edges-expected.txt:
* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/objectstore-count-expected.txt:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/readonly-expected.txt:
* storage/indexeddb/resources/basics.js:
(test):
(openCallback):
* storage/indexeddb/resources/create-and-remove-object-store.js:
(testCreateAndRemove):
(cleanDatabase):
(tryOnceMore):
* storage/indexeddb/resources/cursor-continue.js:
(ascendingErrorTestLessThan.request.onsuccess):
(ascendingErrorTestLessThan):
(ascendingErrorTestEqual.request.onsuccess):
(ascendingErrorTestEqual):
(descendingErrorTestGreaterThan.request.onsuccess):
(descendingErrorTestGreaterThan):
(descendingErrorTestEqual.request.onsuccess):
(descendingErrorTestEqual):
(onTransactionComplete):
* storage/indexeddb/resources/cursor-update.js:
(keyCursor):
* storage/indexeddb/resources/database-basics.js:
(testClose):
* storage/indexeddb/resources/database-quota.js:
(logError):
* storage/indexeddb/resources/deleteIndex.js:
(twiddleIndexes):
(postTwiddling):
* storage/indexeddb/resources/factory-cmp.js:
(testValidKeys):
(testInvalidKeys):
* storage/indexeddb/resources/get-keyrange.js:
(getNullTest):
* storage/indexeddb/resources/index-basics.js:
(index3Count):
* storage/indexeddb/resources/index-count.js:
* storage/indexeddb/resources/index-unique.js:
(addMoreDataFailed):
* storage/indexeddb/resources/invalid-keys.js:
* storage/indexeddb/resources/key-generator.js:
* storage/indexeddb/resources/key-type-array.js:
(testDepthLimits):
* storage/indexeddb/resources/keypath-edges.js:
* storage/indexeddb/resources/keyrange.js:
(test):
* storage/indexeddb/resources/objectstore-autoincrement.js:
(getAbrahamSuccess):
* storage/indexeddb/resources/objectstore-basics.js:
(setVersionSuccess):
(createIndex):
(addAgainFailure):
(removeSuccessButNotThere):
(testPreConditions.request.onsuccess):
(testPreConditions):
* storage/indexeddb/resources/objectstore-count.js:
* storage/indexeddb/resources/open-cursor.js:
(cursorWithKeySuccess):
(cursorSuccess):
* storage/indexeddb/resources/readonly.js:
(openSuccess):
* storage/indexeddb/resources/set_version_queue.js:
(connectionError):
* storage/indexeddb/resources/shared.js:
(unexpectedErrorCallback):
(evalAndExpectException):
* storage/indexeddb/resources/transaction-abort-workers.js:
(transactionAborted):
(transactionCompleted):
(timeoutTest.transaction.onabort):
(timeoutTest):
(errorTransactionAborted):
* storage/indexeddb/resources/transaction-abort.js:
(firstAdd):
(secondAdd):
(transactionAborted):
* storage/indexeddb/resources/transaction-after-close.js:
(firstTransactionComplete):
* storage/indexeddb/resources/transaction-and-objectstore-calls.js:
(created):
(afterComplete):
* storage/indexeddb/resources/transaction-basics.js:
(testInactiveAbortedTransaction):
(testInactiveCompletedTransaction):
(testInvalidMode):
* storage/indexeddb/resources/transaction-read-only.js:
(setVersionDone):
(gotCursor):
* storage/indexeddb/set_version_queue-expected.txt:
* storage/indexeddb/transaction-abort-expected.txt:
* storage/indexeddb/transaction-abort-workers-expected.txt:
* storage/indexeddb/transaction-after-close-expected.txt:
* storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-read-only-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [Chromium] AX: WebAccessibilityObject should check if an Accessibilit...
commit-queue@webkit.org [Thu, 31 May 2012 01:14:18 +0000 (01:14 +0000)]
Source/WebCore: [Chromium] AX: WebAccessibilityObject should check if an AccessibilityObject is detached
https://bugs.webkit.org/show_bug.cgi?id=87778

Patch by Dominic Mazzoni <dmazzoni@chromium.org> on 2012-05-30
Reviewed by Adam Barth.

Chromium was never actually using AccessibilityObjectWrapper, so
this change deletes it. Instead, it's replaced with a simple bool
that keeps track of whether an AccessibilityObject was detached or
not. WebKit/chromium/public/WebAccessibilityObject can then use this
to determine if an object is still valid.

Test: accessibility/accessibility-object-detached.html

* WebCore.gypi:
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::AccessibilityObject):
(WebCore::AccessibilityObject::detach):
(WebCore::AccessibilityObject::isDetached):
(WebCore):
* accessibility/AccessibilityObject.h:
(AccessibilityObject):
* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore):
(WebCore::AXObjectCache::detachWrapper):
(WebCore::AXObjectCache::attachWrapper):
* accessibility/chromium/AccessibilityObjectWrapper.h: Removed.

Source/WebKit/chromium: AX: Chromium WebAccessibilityObject should check if an AccessibilityObject is detached
https://bugs.webkit.org/show_bug.cgi?id=87778

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2012-05-30
Reviewed by Adam Barth.

Pretty simple - all places that previously just checked for null
now also check if the wrapped AccessibilityObject is detached.

* public/WebAccessibilityObject.h:
(WebAccessibilityObject):
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::isDetached):
(WebKit):
(WebKit::WebAccessibilityObject::axID):
(WebKit::WebAccessibilityObject::accessibilityDescription):
(WebKit::WebAccessibilityObject::actionVerb):
(WebKit::WebAccessibilityObject::canSetFocusAttribute):
(WebKit::WebAccessibilityObject::canSetValueAttribute):
(WebKit::WebAccessibilityObject::isValid):
(WebKit::WebAccessibilityObject::childCount):
(WebKit::WebAccessibilityObject::childAt):
(WebKit::WebAccessibilityObject::firstChild):
(WebKit::WebAccessibilityObject::focusedChild):
(WebKit::WebAccessibilityObject::lastChild):
(WebKit::WebAccessibilityObject::nextSibling):
(WebKit::WebAccessibilityObject::parentObject):
(WebKit::WebAccessibilityObject::previousSibling):
(WebKit::WebAccessibilityObject::canSetSelectedAttribute):
(WebKit::WebAccessibilityObject::isAnchor):
(WebKit::WebAccessibilityObject::isAriaReadOnly):
(WebKit::WebAccessibilityObject::isButtonStateMixed):
(WebKit::WebAccessibilityObject::isChecked):
(WebKit::WebAccessibilityObject::isCollapsed):
(WebKit::WebAccessibilityObject::isControl):
(WebKit::WebAccessibilityObject::isEnabled):
(WebKit::WebAccessibilityObject::isFocused):
(WebKit::WebAccessibilityObject::isHovered):
(WebKit::WebAccessibilityObject::isIndeterminate):
(WebKit::WebAccessibilityObject::isLinked):
(WebKit::WebAccessibilityObject::isLoaded):
(WebKit::WebAccessibilityObject::isMultiSelectable):
(WebKit::WebAccessibilityObject::isOffScreen):
(WebKit::WebAccessibilityObject::isPasswordField):
(WebKit::WebAccessibilityObject::isPressed):
(WebKit::WebAccessibilityObject::isReadOnly):
(WebKit::WebAccessibilityObject::isRequired):
(WebKit::WebAccessibilityObject::isSelected):
(WebKit::WebAccessibilityObject::isSelectedOptionActive):
(WebKit::WebAccessibilityObject::isVertical):
(WebKit::WebAccessibilityObject::isVisible):
(WebKit::WebAccessibilityObject::isVisited):
(WebKit::WebAccessibilityObject::accessKey):
(WebKit::WebAccessibilityObject::ariaHasPopup):
(WebKit::WebAccessibilityObject::ariaLiveRegionAtomic):
(WebKit::WebAccessibilityObject::ariaLiveRegionBusy):
(WebKit::WebAccessibilityObject::ariaLiveRegionRelevant):
(WebKit::WebAccessibilityObject::ariaLiveRegionStatus):
(WebKit::WebAccessibilityObject::boundingBoxRect):
(WebKit::WebAccessibilityObject::estimatedLoadingProgress):
(WebKit::WebAccessibilityObject::helpText):
(WebKit::WebAccessibilityObject::headingLevel):
(WebKit::WebAccessibilityObject::hierarchicalLevel):
(WebKit::WebAccessibilityObject::hitTest):
(WebKit::WebAccessibilityObject::keyboardShortcut):
(WebKit::WebAccessibilityObject::performDefaultAction):
(WebKit::WebAccessibilityObject::roleValue):
(WebKit::WebAccessibilityObject::selectionEnd):
(WebKit::WebAccessibilityObject::selectionStart):
(WebKit::WebAccessibilityObject::setFocused):
(WebKit::WebAccessibilityObject::stringValue):
(WebKit::WebAccessibilityObject::title):
(WebKit::WebAccessibilityObject::titleUIElement):
(WebKit::WebAccessibilityObject::url):
(WebKit::WebAccessibilityObject::valueDescription):
(WebKit::WebAccessibilityObject::valueForRange):
(WebKit::WebAccessibilityObject::maxValueForRange):
(WebKit::WebAccessibilityObject::minValueForRange):
(WebKit::WebAccessibilityObject::node):
(WebKit::WebAccessibilityObject::document):
(WebKit::WebAccessibilityObject::hasComputedStyle):
(WebKit::WebAccessibilityObject::computedStyleDisplay):
(WebKit::WebAccessibilityObject::accessibilityIsIgnored):
(WebKit::WebAccessibilityObject::lineBreaks):
(WebKit::WebAccessibilityObject::columnCount):
(WebKit::WebAccessibilityObject::rowCount):

LayoutTests: AX: Chromium WebAccessibilityObject should check if an AccessibilityObject is detached
https://bugs.webkit.org/show_bug.cgi?id=87778

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2012-05-30
Reviewed by Adam Barth.

* accessibility/accessibility-object-detached-expected.txt: Added.
* accessibility/accessibility-object-detached.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wx] Unreviewed build fix. Fix 2.9 issues with c_str() type errors by using the wx...
kevino@webkit.org [Thu, 31 May 2012 01:03:42 +0000 (01:03 +0000)]
[wx] Unreviewed build fix. Fix 2.9 issues with c_str() type errors by using the wx fprintf wrapper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOnly include the image checksum error in pretty-diffs for -expected.png files.
ojan@chromium.org [Thu, 31 May 2012 01:01:16 +0000 (01:01 +0000)]
Only include the image checksum error in pretty-diffs for -expected.png files.
https://bugs.webkit.org/show_bug.cgi?id=87881

Reviewed by Tony Chang.

* PrettyPatch/PrettyPatch.rb:
* PrettyPatch/PrettyPatch_test.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnhance Windows DRT implementation to support platform scroll wheel events
jberlin@webkit.org [Thu, 31 May 2012 00:49:06 +0000 (00:49 +0000)]
Enhance Windows DRT implementation to support platform scroll wheel events
https://bugs.webkit.org/show_bug.cgi?id=36002

Skip more tests that use eventSender.mouseScrollBy on Windows.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify TransformationMatrix rotation code to improve precision
shawnsingh@chromium.org [Thu, 31 May 2012 00:48:54 +0000 (00:48 +0000)]
Simplify TransformationMatrix rotation code to improve precision
https://bugs.webkit.org/show_bug.cgi?id=86666

Reviewed by Adrienne Walker.

Source/WebCore:

Change covered by existing layout tests;
Additional unit tests added.

The original rotation code for WebCore::TransformationMatrix was
using indirect trig identities to compute basic rotation
matrices. As far as I can imagine, this is unnecessary, and brief
informal experiments showed that we can gain a few extra bits of
precision by avoiding that indirection.

Indeed, precision improved such that it revealed a mistake on one
of the unit tests, where the test was actually degenerate so that
the layer was aligned with a viewport boundary. When it was
imprecise, it didnt appear to be aligned. Putting an additional
translation on that test fixes it so it is no longer a degenerate
test.

This patch also revealed a few chinks in the unit testing armor of
this code, an error that should have been caught in unit tests was
luckily caught by SVG layout tests. This chink is fixed by adding
2 extra unit tests.

* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::rotate3d):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:
(WebKitTests::TEST):
* tests/WebTransformationMatrixTest.cpp:
(WebKit::TEST):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKitTestRunner needs an implementation of eventSender
timothy_horton@apple.com [Thu, 31 May 2012 00:47:37 +0000 (00:47 +0000)]
WebKitTestRunner needs an implementation of eventSender
<https://bugs.webkit.org/show_bug.cgi?id=42194>

Unreviewed mac-wk2 skip of fast/forms/file/input-file-write-files.html, which depends on eventSender.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Remove old get/getKey implementations
commit-queue@webkit.org [Thu, 31 May 2012 00:46:53 +0000 (00:46 +0000)]
IndexedDB: Remove old get/getKey implementations
https://bugs.webkit.org/show_bug.cgi?id=87879

Patch by Alec Flett <alecflett@chromium.org> on 2012-05-30
Reviewed by Ojan Vafai.

Removal of dead code, was scaffolding for a complicated
Chromium landing.

* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):
* Modules/indexeddb/IDBIndexBackendImpl.h:
(IDBIndexBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fix assertion fail on redirect due to multiple jobs per handle
commit-queue@webkit.org [Thu, 31 May 2012 00:39:18 +0000 (00:39 +0000)]
[BlackBerry] Fix assertion fail on redirect due to multiple jobs per handle
https://bugs.webkit.org/show_bug.cgi?id=87579

Patch by Joe Mason <jmason@rim.com> on 2012-05-30
Reviewed by George Staikos.

RIM PR #158892:

When we start a redirect, we now call cancelJob instead of just deleting it immediately to make sure
that all cleanup is performed. However, we also reassign the ResourceHandle to the new job, and
since cancelJob is asynchronous it is now assigned to two jobs simultaneously.

Work around this by only returning handles that have not been cancelled from findJobForHandle.
Cancelled jobs still technically exist in the jobs list, but they're invisible to callers. This is
safe because there is literally nothing that can be done with a cancelled job - it is supposed to
merely consume any notifications that are already in progress and then kill itself off - so no
callers of findJobForHandle are expecting a cancelled job. (All existing callers call methods on the
returned job which are no-ops for cancelled jobs, so there is no behaviour change.)

No new tests because there is no behaviour change (fixes a regression).

* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::findJobForHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8][Performance] Optimize DOM attribute getters that return an empty string
haraken@chromium.org [Thu, 31 May 2012 00:30:10 +0000 (00:30 +0000)]
[V8][Performance] Optimize DOM attribute getters that return an empty string
https://bugs.webkit.org/show_bug.cgi?id=87820

Reviewed by Adam Barth.

This patch optimizes the performance of DOM attribute getters that return an
empty string by 65.8% (e.g. div.id, div.className, div.title, div.lang ...etc)

Performance test: Bindings/undefined-id-getter.html

[Without the patch]
RESULT Bindings: undefined-id-getter= 441.984669644 runs/s
median= 445.544554455 runs/s, stdev= 11.8406070959 runs/s, min= 405.063291139 runs/s, max= 447.204968944 runs/s

[With the patch]
RESULT Bindings: undefined-id-getter= 738.840460474 runs/s
median= 738.786279683 runs/s, stdev= 2.00249797161 runs/s, min= 733.944954128 runs/s, max= 741.721854305 runs/s

- This patch passes Isolate to v8::String::Empty(), which removes Isolate
look-up inside v8::String::Empty().

- This patch inlines V8Binding::getElementStringAttr() and
V8Binding::setElementStringAttr().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
* bindings/v8/V8Binding.cpp:
(WebCore::StringCache::v8ExternalStringSlow):
* bindings/v8/V8Binding.h:
(WebCore::StringCache::v8ExternalString):
(StringCache):
(WebCore::v8ExternalString):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Implement V8Binding::v8BooleanWithCheck(isolate)
haraken@chromium.org [Thu, 31 May 2012 00:28:00 +0000 (00:28 +0000)]
[V8] Implement V8Binding::v8BooleanWithCheck(isolate)
https://bugs.webkit.org/show_bug.cgi?id=87814

Reviewed by Adam Barth.

The objective is to pass Isolate to v8::True() and v8::False().
Similarly to v8NullWithCheck() (bug 87713), this patch implements
V8Binding::v8BooleanWithCheck(isolate), which calls v8::True()/v8::False()
or v8::True(isolate)/v8::False(isolate) depending on whether the
passed isolate is null or not.

This patch also passes Isolate to v8Boolean() in CodeGeneratorV8.pm.

No tests. No behavior change.

* bindings/scripts/CodeGeneratorV8.pm:
(NativeToJSValue):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::createAttrGetter):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetter):
* bindings/v8/V8Binding.h:
(WebCore::v8Boolean):
(WebCore):
(WebCore::v8BooleanWithCheck):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Replace v8::True() and v8::False() with v8Boolean()
haraken@chromium.org [Thu, 31 May 2012 00:16:11 +0000 (00:16 +0000)]
[V8] Replace v8::True() and v8::False() with v8Boolean()
https://bugs.webkit.org/show_bug.cgi?id=87812

Reviewed by Adam Barth.

To avoid implementing all of v8TrueWithCheck(isolate), v8FalseWithCheck(isolate)
and v8BooleanWithCheck(isolate), we can first replace v8::True() and v8::False()
with v8Boolean(). Then we can just implement v8BooleanWithCheck(isolate).

No tests. No change in behavior.

* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/V8Binding.h:
(WebCore::v8StringOrFalse):
* bindings/v8/V8NPUtils.cpp:
(WebCore::convertNPVariantToV8Object):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertyDeleter):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageDeleter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Replace v8::Null() with v8NullWithCheck(isolate) in custom bindings where isolat...
haraken@chromium.org [Thu, 31 May 2012 00:13:23 +0000 (00:13 +0000)]
[V8] Replace v8::Null() with v8NullWithCheck(isolate) in custom bindings where isolate can be 0
https://bugs.webkit.org/show_bug.cgi?id=87807

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch replaces v8::Null() with v8NullWithCheck(isolate)
in custom bindings where isolate can be 0.

'where isolate can be 0' means all the places where we cannot
retrieve Isolate directly from AccessorInfo or Arguments.

No tests. No behavior change.

* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Float32ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Float64ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Int16ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Int32ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Int8ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ScriptProfileCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint16ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint32ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint8ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] 8 accessibility tests failing
jberlin@webkit.org [Thu, 31 May 2012 00:12:26 +0000 (00:12 +0000)]
[Win] 8 accessibility tests failing
https://bugs.webkit.org/show_bug.cgi?id=87909

Add expected (failing?) results for Windows to get the bots greener.

* platform/win/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
* platform/win/accessibility/disabled-controls-not-focusable-expected.txt: Added.
* platform/win/accessibility/focus-events-expected.txt:
* platform/win/accessibility/img-alt-tag-only-whitespace-expected.txt: Added.
* platform/win/accessibility/option-element-selection-and-focus-events-expected.txt:
* platform/win/accessibility/select-element-valuechange-event-expected.txt:
* platform/win/accessibility/textbox-role-reports-line-number-expected.txt: Added.
* platform/win/accessibility/textbox-role-reports-selection-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Replace v8::Null() with v8::Null(isolate) or v8NullWithCheck(isolate) in non...
haraken@chromium.org [Thu, 31 May 2012 00:11:19 +0000 (00:11 +0000)]
[V8] Replace v8::Null() with v8::Null(isolate) or v8NullWithCheck(isolate) in non-custom bindings
https://bugs.webkit.org/show_bug.cgi?id=87810

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
For non-custom bindings, we replace v8::Null() with v8::Null(isolate)
where isolate cannot be 0, and replace v8::Null() with v8NullWithCheck(isolate)
where isolate can be 0.

This will be the final patch for passing Isolate to v8::Null().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserialize):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Replace v8::Null() with v8::Null(isolate) in custom bindings where isolate shoul...
haraken@chromium.org [Thu, 31 May 2012 00:02:42 +0000 (00:02 +0000)]
[V8] Replace v8::Null() with v8::Null(isolate) in custom bindings where isolate shouldn't be 0
https://bugs.webkit.org/show_bug.cgi?id=87809

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch replaces v8::Null() with v8::Null(isolate) in custom bindings
where isolate shouldn't be 0. 'where isolate shouldn't be 0' is the place
where isolate is retrieved directly from AccessorInfo and Arguments.

This patch includes a couple of refactorings:

- Makes V8DeviceMotionEvent::createAccelerationObject() and
V8DeviceMotionEvent::createRotationRateObject() static

- Moves V8HTMLElement::toV8Object() into the existing ENABLE(MICRODATA) flag.

No tests. No change in behavior.

* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAccessorGetter):
* bindings/v8/custom/V8CoordinatesCustom.cpp:
(WebCore::V8Coordinates::altitudeAccessorGetter):
(WebCore::V8Coordinates::altitudeAccuracyAccessorGetter):
(WebCore::V8Coordinates::headingAccessorGetter):
(WebCore::V8Coordinates::speedAccessorGetter):
* bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
(WebCore::V8DeviceMotionEvent::accelerationAccessorGetter):
(WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter):
(WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter):
(WebCore::V8DeviceMotionEvent::intervalAccessorGetter):
* bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
(WebCore::V8DeviceOrientationEvent::alphaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::betaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::gammaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::absoluteAccessorGetter):
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorGetter):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
(WebCore):
(WebCore::toV8Object):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAccessorGetter):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):
* bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallback):
* bindings/v8/custom/V8TrackEventCustom.cpp:
(WebCore::V8TrackEvent::trackAccessorGetter):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] handled touchmove events should not cancel tap gesture recognition
commit-queue@webkit.org [Wed, 30 May 2012 23:56:24 +0000 (23:56 +0000)]
[Qt] handled touchmove events should not cancel tap gesture recognition
https://bugs.webkit.org/show_bug.cgi?id=87808

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-05-30
Reviewed by Kenneth Rohde Christiansen.

Tap gesture recognition should not be canceled if a touchmove event is handled
by the web process.

* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::doneWithTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOnly give lint errors for -expected.png png files that lack a checksum
ojan@chromium.org [Wed, 30 May 2012 23:55:44 +0000 (23:55 +0000)]
Only give lint errors for -expected.png png files that lack a checksum
https://bugs.webkit.org/show_bug.cgi?id=87875

Reviewed by Tony Chang.

We have other pngs in the tree, e.g. for the inspector, that legitimately
lack a checksum.

* Scripts/webkitpy/style/checkers/png.py:
(PNGChecker.check):
* Scripts/webkitpy/style/checkers/png_unittest.py:
(PNGCheckerTest.test_check):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReally provide error information with the inspector disabled
oliver@apple.com [Wed, 30 May 2012 23:47:27 +0000 (23:47 +0000)]
Really provide error information with the inspector disabled
https://bugs.webkit.org/show_bug.cgi?id=87910

Reviewed by Filip Pizlo.

Don't bother checking for anything other than pre-existing error info.
In the absence of complete line number information you'll only get the
line a function starts on, but at least it's something.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test expectations updates for window and mac now that we no longer skip...
eae@chromium.org [Wed, 30 May 2012 23:35:34 +0000 (23:35 +0000)]
Unreviewed test expectations updates for window and mac now that we no longer skip a couple of tests on those platforms.

* platform/chromium-mac-leopard/fast/backgrounds/background-position-parsing-expected.png:
* platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png:
* platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt:
* platform/chromium-win/fast/block/margin-collapse/103-expected.png:
* platform/chromium-win/fast/block/margin-collapse/103-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake the files attribute of HTMLInputElement writable
thakis@chromium.org [Wed, 30 May 2012 23:10:40 +0000 (23:10 +0000)]
Make the files attribute of HTMLInputElement writable
https://bugs.webkit.org/show_bug.cgi?id=87154

Reviewed by Adam Barth.

whatwg thread:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-May/036140.html

* bindings/objc/PublicDOMInterfaces.h:
    Remove readonly on files property.
* html/FileInputType.cpp:
(FileInputType):
    Add a NULL check to setFiles().
* html/FileInputType.h:
(FileInputType):
    Let setFiles() overwrite the base  class's method.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setFiles):
    Add setFiles() implementation, delegate to input type.
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/HTMLInputElement.idl:
* html/InputType.cpp:
(WebCore::InputType::setFiles):
    setFiles() does nothing by default.
* html/InputType.h:
(InputType):
    Add a virtual setFiles() method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLLInt broken on x86-32 with JIT turned off
fpizlo@apple.com [Wed, 30 May 2012 23:09:45 +0000 (23:09 +0000)]
LLInt broken on x86-32 with JIT turned off
https://bugs.webkit.org/show_bug.cgi?id=87906

Reviewed by Geoffrey Garen.

Fixed the code to not clobber registers that contain important things, like the call frame.

* llint/LowLevelInterpreter32_64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Remove useless string->char*->string conversion in NetworkJob.
commit-queue@webkit.org [Wed, 30 May 2012 23:07:22 +0000 (23:07 +0000)]
[BlackBerry] Remove useless string->char*->string conversion in NetworkJob.
https://bugs.webkit.org/show_bug.cgi?id=87861

Patch by Joe Mason <jmason@rim.com> on 2012-05-30
Reviewed by Antonio Gomes.

RIM PR #152383: username is a WTF::String.  ResourceHandleInternal::m_user is a string.  Yet they're
assigned with "username = m_user.utf8().data()".  Pointless: "username = m_user" will do.

No new tests since there is no behaviour change.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION(r118568): It broke fast/forms/textarea-maxlength.html on Qt 4.8
mitz@apple.com [Wed, 30 May 2012 22:58:54 +0000 (22:58 +0000)]
[Qt] REGRESSION(r118568): It broke fast/forms/textarea-maxlength.html on Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=87740

Reviewed by Darin Adler.

Source/WebCore:

* platform/text/qt/TextBreakIteratorQt.cpp:
(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator): Changed to use
the return value of setUpIterator.

LayoutTests:

* platform/qt-4.8/Skipped: Removed fast/forms/textarea-maxlength.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening. Unskip test that is now passing.
rakuco@webkit.org [Wed, 30 May 2012 22:50:31 +0000 (22:50 +0000)]
[EFL] Gardening. Unskip test that is now passing.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium snowleopard rebaseline for background-position-parsing test follo...
eae@chromium.org [Wed, 30 May 2012 22:49:07 +0000 (22:49 +0000)]
Unreviewed chromium snowleopard rebaseline for background-position-parsing test following r118978.

* platform/chromium-mac-snowleopard/fast/backgrounds/background-position-parsing-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGraphicsSurface: allow importing and exporting of textures directly on GPU side.
zeno.albisser@nokia.com [Wed, 30 May 2012 22:43:48 +0000 (22:43 +0000)]
GraphicsSurface: allow importing and exporting of textures directly on GPU side.
https://bugs.webkit.org/show_bug.cgi?id=87725

Add copyFromFramebuffer function to copy a texture from an FBO
onto the GraphicsSurface.
Add getTextureID function to export the texture ID.
This allows binding/blitting the texture directly on the GPU.

Reviewed by Noam Rosenthal.

* platform/graphics/surfaces/GraphicsSurface.cpp:
(WebCore::GraphicsSurface::getTextureID):
(WebCore):
(WebCore::GraphicsSurface::copyFromFramebuffer):
* platform/graphics/surfaces/GraphicsSurface.h:
(GraphicsSurface):
* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore):
(WebCore::GraphicsSurface::platformCopyFromFramebuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Implement IDBTransaction.error and IDBRequest.error
commit-queue@webkit.org [Wed, 30 May 2012 22:39:23 +0000 (22:39 +0000)]
IndexedDB: Implement IDBTransaction.error and IDBRequest.error
https://bugs.webkit.org/show_bug.cgi?id=87865

Patch by Alec Flett <alecflett@chromium.org> on 2012-05-30
Reviewed by Tony Chang.

Source/WebCore:

Added "error" attribute to IDBRequest and IDBTransaction. Update
IDBDatabaseError to honor the IDBDatabaseException behavior
of dealing with IDB-specific throws of DOMException codes,
as per the spec.

Existing tests which previously tested 'errorCode' and
'webkitErrorMessage' have been updated to use the new attribute.

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::advance):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setVersion):
* Modules/indexeddb/IDBDatabaseError.h:
(WebCore::IDBDatabaseError::create):
(WebCore::IDBDatabaseError::code):
(WebCore::IDBDatabaseError::idbCode):
(WebCore::IDBDatabaseError::name):
(WebCore::IDBDatabaseError::IDBDatabaseError):
(IDBDatabaseError):
* Modules/indexeddb/IDBDatabaseException.cpp:
(WebCore):
(WebCore::getErrorEntry):
(WebCore::IDBDatabaseException::initializeDescription):
(WebCore::IDBDatabaseException::getErrorName):
(WebCore::IDBDatabaseException::getLegacyErrorCode):
* Modules/indexeddb/IDBDatabaseException.h:
(IDBDatabaseException):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::error):
(WebCore):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::dispatchEvent):
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
* Modules/indexeddb/IDBRequest.idl:
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::error):
(WebCore):
(WebCore::IDBTransaction::setError):
* Modules/indexeddb/IDBTransaction.h:
(IDBTransaction):
* Modules/indexeddb/IDBTransaction.idl:

Source/WebKit/chromium:

IDBDatabaseError now honors IDB-specific DOMException codes,
so make sure that's how they are passed to/from chromium.

* src/WebIDBDatabaseError.cpp:
(WebKit::WebIDBDatabaseError::assign):

LayoutTests:

* storage/indexeddb/basics-expected.txt:
* storage/indexeddb/basics-workers-expected.txt:
* storage/indexeddb/create-and-remove-object-store-expected.txt:
* storage/indexeddb/cursor-continue-expected.txt:
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/database-basics-expected.txt:
* storage/indexeddb/deleteIndex-expected.txt:
* storage/indexeddb/factory-cmp-expected.txt:
* storage/indexeddb/get-keyrange-expected.txt:
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics-workers-expected.txt:
* storage/indexeddb/index-count-expected.txt:
* storage/indexeddb/index-unique-expected.txt:
* storage/indexeddb/invalid-keys-expected.txt:
* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/keypath-edges-expected.txt:
* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/objectstore-count-expected.txt:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/readonly-expected.txt:
* storage/indexeddb/resources/basics.js:
(test):
(openCallback):
* storage/indexeddb/resources/create-and-remove-object-store.js:
(testCreateAndRemove):
(cleanDatabase):
(tryOnceMore):
* storage/indexeddb/resources/cursor-continue.js:
(ascendingErrorTestLessThan.request.onsuccess):
(ascendingErrorTestLessThan):
(ascendingErrorTestEqual.request.onsuccess):
(ascendingErrorTestEqual):
(descendingErrorTestGreaterThan.request.onsuccess):
(descendingErrorTestGreaterThan):
(descendingErrorTestEqual.request.onsuccess):
(descendingErrorTestEqual):
(onTransactionComplete):
* storage/indexeddb/resources/cursor-update.js:
(keyCursor):
* storage/indexeddb/resources/database-basics.js:
(testClose):
* storage/indexeddb/resources/database-quota.js:
(logError):
* storage/indexeddb/resources/deleteIndex.js:
(twiddleIndexes):
(postTwiddling):
* storage/indexeddb/resources/factory-cmp.js:
(testValidKeys):
(testInvalidKeys):
* storage/indexeddb/resources/get-keyrange.js:
(getNullTest):
* storage/indexeddb/resources/index-basics.js:
(index3Count):
* storage/indexeddb/resources/index-count.js:
* storage/indexeddb/resources/index-unique.js:
(addMoreDataFailed):
* storage/indexeddb/resources/invalid-keys.js:
* storage/indexeddb/resources/key-generator.js:
* storage/indexeddb/resources/key-type-array.js:
(testDepthLimits):
* storage/indexeddb/resources/keypath-edges.js:
* storage/indexeddb/resources/keyrange.js:
(test):
* storage/indexeddb/resources/objectstore-autoincrement.js:
(getAbrahamSuccess):
* storage/indexeddb/resources/objectstore-basics.js:
(setVersionSuccess):
(createIndex):
(addAgainFailure):
(removeSuccessButNotThere):
(testPreConditions.request.onsuccess):
(testPreConditions):
* storage/indexeddb/resources/objectstore-count.js:
* storage/indexeddb/resources/open-cursor.js:
(cursorWithKeySuccess):
(cursorSuccess):
* storage/indexeddb/resources/readonly.js:
(openSuccess):
* storage/indexeddb/resources/set_version_queue.js:
(connectionError):
* storage/indexeddb/resources/shared.js:
(unexpectedErrorCallback):
(evalAndExpectException):
* storage/indexeddb/resources/transaction-abort-workers.js:
(transactionAborted):
(transactionCompleted):
(timeoutTest.transaction.onabort):
(timeoutTest):
(errorTransactionAborted):
* storage/indexeddb/resources/transaction-abort.js:
(firstAdd):
(secondAdd):
(transactionAborted):
* storage/indexeddb/resources/transaction-after-close.js:
(firstTransactionComplete):
* storage/indexeddb/resources/transaction-and-objectstore-calls.js:
(created):
(afterComplete):
* storage/indexeddb/resources/transaction-basics.js:
(testInactiveAbortedTransaction):
(testInactiveCompletedTransaction):
(testInvalidMode):
* storage/indexeddb/resources/transaction-read-only.js:
(setVersionDone):
(gotCursor):
* storage/indexeddb/set_version_queue-expected.txt:
* storage/indexeddb/transaction-abort-expected.txt:
* storage/indexeddb/transaction-abort-workers-expected.txt:
* storage/indexeddb/transaction-after-close-expected.txt:
* storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-read-only-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][WK2] Errors in documentation about webkit_web_view_run_javascript()
commit-queue@webkit.org [Wed, 30 May 2012 22:37:50 +0000 (22:37 +0000)]
[GTK][WK2] Errors in documentation about  webkit_web_view_run_javascript()
https://bugs.webkit.org/show_bug.cgi?id=87866

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-05-30
Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitWebView.cpp: Fix errors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium mac rebaseline for changes in r118978.
eae@chromium.org [Wed, 30 May 2012 22:29:04 +0000 (22:29 +0000)]
Unreviewed chromium mac rebaseline for changes in r118978.

* platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png:
* platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.txt:
* platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.png:
* platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] ImageDecoderQt doesn't support some decoders.
commit-queue@webkit.org [Wed, 30 May 2012 22:08:56 +0000 (22:08 +0000)]
[Qt] ImageDecoderQt doesn't support some decoders.
https://bugs.webkit.org/show_bug.cgi?id=87851

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-30
Reviewed by Kenneth Rohde Christiansen.

If forced to decode GIF and JPEG, ImageDecoderQt show several
artifacts. This is caused by mismatched decoded image-formats.

Convert mismatched color spaces into ARGB color space, and perform
manual mem-copy when the image has been decoded into a new buffer.

This patch also add support for down-scaling in the decoder.

* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::internalDecodeSize):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: seems to leak temp dirs
dpranke@chromium.org [Wed, 30 May 2012 21:58:59 +0000 (21:58 +0000)]
nrwt: seems to leak temp dirs
https://bugs.webkit.org/show_bug.cgi?id=87795

Reviewed by Ojan Vafai.

There appears to be a bug where the chromium bots are creating
temporary directories and not cleaning them up that started
after the switch to WebKitDriver. It's possible that __del__
wasn't getting called in a timely manner (or at all), and it's
generally bad style to rely on __del__ being called, so this
code changes things so that we create a temp dir in
driver.start() and remove it in driver.stop(). We could be
paranoid and leave the __del__ code in, but there doesn't seem
to be much advantage to it. If there are bugs that result in
drivers being started but not stopped, we have other problems.

* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.__init__):
(MockFileSystem._mktemp):
(MockFileSystem.mkdtemp):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.__init__):
(WebKitDriver._start):
(WebKitDriver.stop):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest):
(WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
(WebKitDriverTest.test_stop_cleans_up_properly):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFloats wraps incorrectly when top edge has subpixel precision
eae@chromium.org [Wed, 30 May 2012 21:56:40 +0000 (21:56 +0000)]
Floats wraps incorrectly when top edge has subpixel precision
https://bugs.webkit.org/show_bug.cgi?id=87688

Reviewed by Levi Weintraub.

When computing the logical left and right offsets for a float we
incorrectly floored the logical top when passing it to the float search
adapter. This caused it to return incorrect values where the floored and
pixel snapped values are not the same.

Source/WebCore:

Test: fast/sub-pixel/float-wrap-with-subpixel-top.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

LayoutTests:

* fast/sub-pixel/float-wrap-with-subpixel-top-expected.html: Added.
* fast/sub-pixel/float-wrap-with-subpixel-top.html: Added.
* platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.png:
* platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk-wk2/Skipped:
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] EFL's DRT should print the number of MessagePorts for new each new intent
rakuco@webkit.org [Wed, 30 May 2012 21:44:47 +0000 (21:44 +0000)]
[EFL] EFL's DRT should print the number of MessagePorts for new each new intent
https://bugs.webkit.org/show_bug.cgi?id=86841

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-30
Reviewed by Adam Barth.

Source/WebKit/efl:

Add EWKPrivate method to retrieve the internal WebCore object for a Ewk_Intent.
Add helper function to DumpRenderTreeSupportEfl that returns the MessagePorts
for a Ewk_Intent object so that the DRT can print information about them.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::intentMessagePorts):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
(WebCore):
* ewk/ewk_intent.cpp:
(EWKPrivate):
(EWKPrivate::coreIntent):
* ewk/ewk_intent_private.h:
(EWKPrivate):

Tools:

Print the number of MessagePorts for each new intent in EFL's DRT.
This output is expected by several Web Intents test cases.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onFrameIntentNew):

LayoutTests:

Unskip the test case which requires the DumpRenderTree to print out
the number of MessagePorts for each new intent.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHashTable.h has using directives for std::pair and std::make_pair
caio.oliveira@openbossa.org [Wed, 30 May 2012 21:42:35 +0000 (21:42 +0000)]
HashTable.h has using directives for std::pair and std::make_pair
https://bugs.webkit.org/show_bug.cgi?id=29919

Reviewed by Darin Adler.

* wtf/HashTraits.h:
(WTF): Remove the directives.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInline blocks with margin wrap incorrectly with subpixel layout turned on
eae@chromium.org [Wed, 30 May 2012 21:42:13 +0000 (21:42 +0000)]
Inline blocks with margin wrap incorrectly with subpixel layout turned on
https://bugs.webkit.org/show_bug.cgi?id=87897

Reviewed by Levi Weintraub.

Source/WebCore:

Change WebCore::getBorderPaddingMargin and the helper function
getBPMWidth to return a LayoutUnit rather than an int as the padding and
margin values have subpixel precision. This fixes an issue where we would
incorrectly wrap inline blocks with a subpixel padding or margin.

Test: fast/sub-pixel/inline-block-with-margin.html

* rendering/RenderBlock.cpp:
(WebCore::getBPMWidth):
(WebCore::getBorderPaddingMargin):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

LayoutTests:

Add test for inline blocks with a subpixel margin. Marked as skipped on
all platforms but chromium as subpixel layout has not yet been enabled
for any other platform.

* fast/sub-pixel/inline-block-with-margin-expected.html: Added.
* fast/sub-pixel/inline-block-with-margin.html: Added.
* platform/efl/Skipped:
* platform/gtk-wk2/Skipped:
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][GTK][Mac][Win] New plugins/npruntime/delete-plugin-within-* tests introduced...
jberlin@webkit.org [Wed, 30 May 2012 21:35:48 +0000 (21:35 +0000)]
[Qt][GTK][Mac][Win] New plugins/npruntime/delete-plugin-within-* tests introduced in r117012
fail/crash
https://bugs.webkit.org/show_bug.cgi?id=86443

Skip these tests on Windows because they crash.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118974 268f45cc-cd09-0410-ab3c-d52691b4dbfc