WebKit-https.git
8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 25 Sep 2012 16:39:52 +0000 (16:39 +0000)]
Unreviewed GTK gardening.

Removing failure expectations for a few passing reftests and reclassifying
one reftest as flaky.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago#undef some symbols before redefining them.
mark.lam@apple.com [Tue, 25 Sep 2012 16:39:43 +0000 (16:39 +0000)]
#undef some symbols before redefining them.
https://bugs.webkit.org/show_bug.cgi?id=97568.

Reviewed by Michael Saboff.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API: Update getUserMedia to match the latest specification
tommyw@google.com [Tue, 25 Sep 2012 16:30:09 +0000 (16:30 +0000)]
MediaStream API: Update getUserMedia to match the latest specification
https://bugs.webkit.org/show_bug.cgi?id=97540

Reviewed by Adam Barth.

Source/Platform:

* chromium/public/WebMediaConstraints.h:
(WebMediaConstraints):

Source/WebCore:

http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.

Existing tests expanded to cover the new change.

* Modules/mediastream/MediaConstraintsImpl.cpp:
(WebCore::MediaConstraintsImpl::create):
(WebCore):
* Modules/mediastream/MediaConstraintsImpl.h:
(MediaConstraintsImpl):
* Modules/mediastream/NavigatorMediaStream.cpp:
(WebCore::NavigatorMediaStream::webkitGetUserMedia):
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::parseOptions):
(WebCore):
(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::audio):
(WebCore::UserMediaRequest::video):
(WebCore::UserMediaRequest::audioConstraints):
(WebCore::UserMediaRequest::videoConstraints):
* Modules/mediastream/UserMediaRequest.h:
(WebCore):
(UserMediaRequest):
* platform/chromium/support/WebMediaConstraints.cpp:
(WebKit::WebMediaConstraints::WebMediaConstraints):
(WebKit):

Source/WebKit/chromium:

http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.

* public/WebUserMediaRequest.h:
(WebKit):
(WebUserMediaRequest):
* src/WebUserMediaRequest.cpp:
(WebKit::WebUserMediaRequest::audioConstraints):
(WebKit):
(WebKit::WebUserMediaRequest::videoConstraints):

Tools:

Adding mock support for the enhanced getUserMedia call.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/MockConstraints.cpp: Copied from Source/WebCore/platform/chromium/support/WebMediaConstraints.cpp.
(MockConstraints):
(MockConstraints::isSupported):
(MockConstraints::isValid):
(MockConstraints::verify):
* DumpRenderTree/chromium/MockConstraints.h: Copied from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h.
(WebKit):
(MockConstraints):
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCVoidRequestTask::RTCVoidRequestTask):
(MockWebRTCPeerConnectionHandler::initialize):
* DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(UserMediaRequestTask):
(UserMediaRequestTask::UserMediaRequestTask):
(WebUserMediaClientMock::requestUserMedia):
* DumpRenderTree/chromium/WebUserMediaClientMock.h:
(WebUserMediaClientMock):
(WebUserMediaClientMock::taskList):
* DumpRenderTree/chromium/WebViewHost.h:
(WebKit):
(WebViewHost):

LayoutTests:

Expanding tests to cover the new getUserMedia behaviour.

* fast/mediastream/getusermedia-expected.txt:
* fast/mediastream/getusermedia.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: yellow on-hover pop-up won't go if another pane asynchronously opens
commit-queue@webkit.org [Tue, 25 Sep 2012 16:22:55 +0000 (16:22 +0000)]
Web Inspector: yellow on-hover pop-up won't go if another pane asynchronously opens
https://bugs.webkit.org/show_bug.cgi?id=97120

Patch by mire <mbudaes@adobe.com> on 2012-09-25
Reviewed by Alexander Pavlov.

Add mouseout event listener to popover element so that the pop-up will go when moving to another panel.

No new tests.

* inspector/front-end/Popover.js:
(WebInspector.Popover.prototype.show):
(WebInspector.PopoverHelper.prototype._mouseOut):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unify the PageViewportController<->Client interface regarding positions
commit-queue@webkit.org [Tue, 25 Sep 2012 16:15:12 +0000 (16:15 +0000)]
[Qt] Unify the PageViewportController<->Client interface regarding positions
https://bugs.webkit.org/show_bug.cgi?id=97220

Patch by Jocelyn Turcotte <jocelyn.turcotte@digia.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

- Make sure that css units are used for all position arguments
- Make sure that all positions represent the viewport relatively to the contents
  rather than the other way around
- Delay clamping the viewport to the contents size in the controller rather than in the client

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::updateViewportSize):
* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::didChangeViewportSize):
(WebKit::PageViewportController::didChangeContentsVisibility):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::positionRangeForViewportAtScale):
* UIProcess/PageViewportController.h:
(PageViewportController):
* UIProcess/PageViewportControllerClient.h:
(PageViewportControllerClient):
* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::focusEditableArea):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::nearestValidVisibleContentsRect):
(WebKit::PageViewportControllerClientQt::setViewportPosition):
(WebKit::PageViewportControllerClientQt::updateViewportController):
* UIProcess/qt/PageViewportControllerClientQt.h:
(PageViewportControllerClientQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Make sure that desktop pages honour the devicePixelRatio
commit-queue@webkit.org [Tue, 25 Sep 2012 15:50:14 +0000 (15:50 +0000)]
[Qt] Make sure that desktop pages honour the devicePixelRatio
https://bugs.webkit.org/show_bug.cgi?id=97215

Patch by Jocelyn Turcotte <jocelyn.turcotte@digia.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

The desktopWidth given to computeViewportAttributes is expected to be pixel-ratio adjusted already.
We need to make sure that the viewport size is divided by the pixel ratio to prevent
the equivalent of a 1.0 devicePixelRatio to be in effect once viewportSize.width() is larger
than layoutFallbackWidth.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening.
rakuco@webkit.org [Tue, 25 Sep 2012 15:37:32 +0000 (15:37 +0000)]
[EFL] Gardening.

Use the right bug number related to
fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening, skip test that has started showing some flakiness.
rakuco@webkit.org [Tue, 25 Sep 2012 15:23:15 +0000 (15:23 +0000)]
[EFL] Gardening, skip test that has started showing some flakiness.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] adding a page overlay causes endless update loop when accelerated composit...
caseq@chromium.org [Tue, 25 Sep 2012 15:22:54 +0000 (15:22 +0000)]
[chromium] adding a page overlay causes endless update loop when accelerated compositing is used
https://bugs.webkit.org/show_bug.cgi?id=97466

Reviewed by James Robinson.

Do not update overlays in composite() -- doing so ultimately causes invalidation
of the view, hence another update and another call do composite(). Overlays should be
updated only when their content changes.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add Undo / Redo method to WebKit2 GTK+ API
commit-queue@webkit.org [Tue, 25 Sep 2012 15:18:44 +0000 (15:18 +0000)]
[GTK] Add Undo / Redo method to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=97553

Patch by Simon Pena <spena@igalia.com> on 2012-09-25
Reviewed by Martin Robinson.

Add the macros for Undo / Redo support, and include them
in the documentation.

* UIProcess/API/gtk/WebKitEditingCommands.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Skip another test after r129479.
rakuco@webkit.org [Tue, 25 Sep 2012 15:17:43 +0000 (15:17 +0000)]
[EFL] Skip another test after r129479.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Abstract as much devicePixelRatio logic as possible behind PageViewportController
commit-queue@webkit.org [Tue, 25 Sep 2012 15:05:57 +0000 (15:05 +0000)]
[Qt] Abstract as much devicePixelRatio logic as possible behind PageViewportController
https://bugs.webkit.org/show_bug.cgi?id=97214

Patch by Jocelyn Turcotte <jocelyn.turcotte@digia.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

Currently the client is required to multiply the scales it receives each bime by the
devicePixelRatio. This shouldn't be required since essentially, the only places that the
devicePixelRatio should be in use, is to adjust the layout size, multiply the base scale
and for scale constants.

Other related changes:
- Make sure that the controller and it's client are only exchanging effective scales
 (cssScale * devicePixelRatio)
- Remove members duplicating m_rawAttributes values
- Use a separate member for the minimum scale to fit the page, separate from the viewport arguments
- Make sure that the minimum scale to fit is adjusted if the contents size isn't
  updated after the viewport attributes changed
- Make the scale conversion functions private to discourage this logic from spreading in the client

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::innerBoundedViewportScale):
(WebKit::PageViewportController::outerBoundedViewportScale):
(WebKit):
(WebKit::PageViewportController::devicePixelRatio):
(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::didChangeViewportAttributes):
(WebKit::PageViewportController::resumeContent):
(WebKit::PageViewportController::updateMinimumScaleToFit):
* UIProcess/PageViewportController.h:
(PageViewportController):
(WebKit::PageViewportController::minimumContentsScale):
(WebKit::PageViewportController::maximumContentsScale):
(WebKit::PageViewportController::currentContentsScale):
(WebKit::PageViewportController::fromViewportScale):
(WebKit::PageViewportController::toViewportScale):
* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::focusEditableArea):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::nearestValidVisibleContentsRect):
(WebKit::PageViewportControllerClientQt::setContentsRectToNearestValidBounds):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Fix typo in accessing union field in a GdkEvent in a WebKit2 unit test
commit-queue@webkit.org [Tue, 25 Sep 2012 14:56:51 +0000 (14:56 +0000)]
[GTK] Fix typo in accessing union field in a GdkEvent in a WebKit2 unit test
https://bugs.webkit.org/show_bug.cgi?id=97564

Patch by Simon Pena <spena@igalia.com> on 2012-09-25
Reviewed by Martin Robinson.

In the WebViewTest::moveMouseTo method, the wrong field in
a union was being accessed in a GdkEvent: instead of the button
field, we were supposed to act on the motion one. This patch
fixes the typo.

* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::mouseMoveTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix failing assertion when calling QWebSettings::setIconDatabasePath multiple...
hausmann@webkit.org [Tue, 25 Sep 2012 14:37:05 +0000 (14:37 +0000)]
[Qt] Fix failing assertion when calling QWebSettings::setIconDatabasePath multiple times

Reviewed by Jocelyn Turcotte.

This happens in various auto-tests. We can implement this by closing the database before
opening it with the new path.

* Api/qwebsettings.cpp:
(QWebSettings::setIconDatabasePath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Skip crashing test after r129479.
rakuco@webkit.org [Tue, 25 Sep 2012 14:36:45 +0000 (14:36 +0000)]
[EFL] Skip crashing test after r129479.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Reverting implementation for 407 error pages
commit-queue@webkit.org [Tue, 25 Sep 2012 14:23:47 +0000 (14:23 +0000)]
[BlackBerry] Reverting implementation for 407 error pages
https://bugs.webkit.org/show_bug.cgi?id=97455

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-25
Reviewed by Rob Buis.

Revert "[BlackBerry] Show custom error page when 407 is received"
This reverts commit f6fe97ec3f1841a151e4ebdde21f710a6185f9d6.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::sendRequestWithCredentials):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Don't use the C API internally in WebKitFindController
carlosgc@webkit.org [Tue, 25 Sep 2012 14:15:19 +0000 (14:15 +0000)]
[GTK] Don't use the C API internally in WebKitFindController
https://bugs.webkit.org/show_bug.cgi?id=96775

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

* UIProcess/API/gtk/WebKitFindController.cpp:
(getPage):
(webkitFindControllerConstructed):
(webKitFindControllerPerform):
(webkit_find_controller_search_next):
(webkit_find_controller_search_previous):
(webkit_find_controller_search_finish):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Cookie info in Network Resources Cookies tab shows "Invalid Date"
commit-queue@webkit.org [Tue, 25 Sep 2012 14:07:08 +0000 (14:07 +0000)]
Web Inspector: Cookie info in Network Resources Cookies tab shows "Invalid Date"
https://bugs.webkit.org/show_bug.cgi?id=97471

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-25
Reviewed by Yury Semikhatsky.

The original implementation is trying to create a new Date object
using another Date object, which is invalid. Also, Date.toGMTString is
deprecated.

The fix replaces toGMTString with toUTCString and fixes cookie.expire
so it won't crash when an empty requestDate is passed in.

Following RFC 6265, Max-age attributes now take precedence over expiresi
attribute in CookieParser.

Manual testing on inspector to make sure the CookiesTable is properly generated.

* inspector/front-end/CookieParser.js:
(WebInspector.Cookie.prototype.expires):
* inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable.prototype._createGridNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Mark some newly-skipped inspector tests as flaky.
rakuco@webkit.org [Tue, 25 Sep 2012 14:00:40 +0000 (14:00 +0000)]
[EFL] Mark some newly-skipped inspector tests as flaky.

I thought they were just timing out, but it turns out they work
after the first run, so they are just flaky like the others on the
list.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Apply the devicePixelRatio as soon as possible
commit-queue@webkit.org [Tue, 25 Sep 2012 13:58:10 +0000 (13:58 +0000)]
[Qt] Apply the devicePixelRatio as soon as possible
https://bugs.webkit.org/show_bug.cgi?id=97211

Patch by Jocelyn Turcotte <jocelyn.turcotte@digia.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

Having to wait for the contents size to apply the devicePixelRatio can
be problematic since the devicePixelRatio affects the layout width, which
then affects the contents size.

Fix the initial issue that this was working around by preventing the
early return if useFixedLayout() is true.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):
(QQuickWebViewExperimental::devicePixelRatio):
(QQuickWebViewExperimental::setDevicePixelRatio):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Enable datalist UI for input type=date
keishi@webkit.org [Tue, 25 Sep 2012 13:55:30 +0000 (13:55 +0000)]
[Chromium] Enable datalist UI for input type=date
https://bugs.webkit.org/show_bug.cgi?id=97541

Reviewed by Kent Tamura.

Source/WebCore:

This enables datalist UI for input type=date on Chromium.

No new tests. Adding tests in Bug 97551.

* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI):

LayoutTests:

* platform/chromium/fast/forms/datalist/input-list-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening after r129494.
rakuco@webkit.org [Tue, 25 Sep 2012 13:42:49 +0000 (13:42 +0000)]
[EFL] Gardening after r129494.

* platform/efl/TestExpectations: Skip a few tests which depend on
V8-only features.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Don't render at scale 1.0 when doing a pinch-zoom out
commit-queue@webkit.org [Tue, 25 Sep 2012 13:33:21 +0000 (13:33 +0000)]
[Qt] Don't render at scale 1.0 when doing a pinch-zoom out
https://bugs.webkit.org/show_bug.cgi?id=97212

Patch by Jocelyn Turcotte <jocelyn.turcotte@digia.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

When the user starts pinching this creates extra rendering that is bound to the
page size and can be considerably big, reducing performance and peaking the tile
memory usage.

Fixing this might require a different approach that we could experiment with.

* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Focus out is not handled properly
commit-queue@webkit.org [Tue, 25 Sep 2012 13:16:23 +0000 (13:16 +0000)]
[Qt][WK2] Focus out is not handled properly
https://bugs.webkit.org/show_bug.cgi?id=96997

Patch by Michael Brüning <michael.bruning@digia.com> on 2012-09-25
Reviewed by Simon Hausmann.

Adds a handler for QQuickWebView::itemChange event that is sent to
QQuickItems when their focus has been changed to replace focusOutEvent.

This fixes the problem because the focus has been updated when
itemChange is called, while it is not yet update when focusOutEvent
is called.

* UIProcess/API/qt/qquickwebview.cpp: Removed focusOutEvent.
(QQuickWebView::itemChange): Added in place of focusOutEvent.
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::handleFocusLost): Renamed from handleFocusOutEvent, parameter removed.
* UIProcess/qt/QtWebPageEventHandler.h:
(QtWebPageEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Generate results for test.
rakuco@webkit.org [Tue, 25 Sep 2012 13:14:22 +0000 (13:14 +0000)]
[EFL] Generate results for test.

* platform/efl-wk2/TestExpectations: Add a proper bug number for
this test.
* platform/efl/fast/history/visited-link-background-color-expected.png: Added.
* platform/efl/fast/history/visited-link-background-color-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Do not dump inspector output in DRT
commit-queue@webkit.org [Tue, 25 Sep 2012 12:56:53 +0000 (12:56 +0000)]
[EFL] Do not dump inspector output in DRT
https://bugs.webkit.org/show_bug.cgi?id=97018

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

Tools:

Some inspector-related layout tests expect console output from the
inspector view to be suppressed. Do that by setting a property in
the inspector view that makes the onConsoleMessage callback return
early and not output anything.

Using evas_object_data_{get,set} is not very beautiful, but it is
still better than properly subclassing Ewk_View and having to
implement something similar to drt_view_console_message_enable_set().

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createWebInspectorView):
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onConsoleMessage):

LayoutTests:

* platform/efl-wk2/TestExpectations: Skip some tests which still
fail on WK2.
* platform/efl/Skipped: Unskip a few inspector tests that now
pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Supported media MIME types are not included to the list of shown MIME types.
commit-queue@webkit.org [Tue, 25 Sep 2012 12:49:37 +0000 (12:49 +0000)]
[WK2] Supported media MIME types are not included to the list of shown MIME types.
https://bugs.webkit.org/show_bug.cgi?id=97552

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Exported WebCore::MIMETypeRegistry::isSupportedMediaMIMEType() for MAC.

No new tests. No new functionality.

* WebCore.exp.in:

Source/WebKit2:

Added supported media MIME types to the list of shown MIME types in order to fix
media tests regression after r129479.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::canShowMIMEType):
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCanShowMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Partial Skipped file clean up
commit-queue@webkit.org [Tue, 25 Sep 2012 12:31:23 +0000 (12:31 +0000)]
[EFL] Partial Skipped file clean up
https://bugs.webkit.org/show_bug.cgi?id=97554

Unreviewed EFL rebaseline.

Rebaseline several EFL test cases and unskip them.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-25

* platform/efl-wk1/TestExpectations:
* platform/efl/Skipped:
* platform/efl/TestExpectations:
* platform/efl/fast/forms/basic-textareas-expected.png:
* platform/efl/fast/forms/basic-textareas-expected.txt: Added.
* platform/efl/fast/forms/basic-textareas-quirks-expected.png:
* platform/efl/fast/forms/basic-textareas-quirks-expected.txt: Added.
* platform/efl/fast/text/complex-text-opacity-expected.png: Added.
* platform/efl/fast/text/complex-text-opacity-expected.txt: Added.
* platform/efl/fast/text/international/bidi-AN-after-L-expected.png: Added.
* platform/efl/fast/text/international/bidi-AN-after-L-expected.txt: Added.
* platform/efl/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
* platform/efl/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
* platform/efl/fast/text/international/bidi-CS-after-AN-expected.png: Added.
* platform/efl/fast/text/international/bidi-CS-after-AN-expected.txt: Added.
* platform/efl/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Added.
* platform/efl/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
* platform/efl/fast/text/international/bidi-listbox-atsui-expected.png: Added.
* platform/efl/fast/text/international/bidi-listbox-atsui-expected.txt: Added.
* platform/efl/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
* platform/efl/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
* platform/efl/fast/text/international/bidi-neutral-run-expected.png: Added.
* platform/efl/fast/text/international/bidi-neutral-run-expected.txt: Added.
* platform/efl/fast/text/international/hebrew-vowels-expected.png: Added.
* platform/efl/fast/text/international/hebrew-vowels-expected.txt: Added.
* platform/efl/fast/text/international/text-combine-image-test-expected.png: Added.
* platform/efl/fast/text/international/text-combine-image-test-expected.txt: Added.
* platform/efl/fast/text/international/vertical-text-glyph-test-expected.png: Added.
* platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
* platform/efl/fast/text/justify-ideograph-complex-expected.png: Added.
* platform/efl/fast/text/justify-ideograph-complex-expected.txt: Added.
* platform/efl/fast/text/large-text-composed-char-expected.png: Added.
* platform/efl/fast/text/large-text-composed-char-expected.txt: Added.
* platform/efl/fast/writing-mode/japanese-rl-selection-expected.png: Added.
* platform/efl/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
* platform/efl/fast/writing-mode/japanese-rl-text-expected.png: Added.
* platform/efl/fast/writing-mode/japanese-rl-text-expected.txt: Added.
* platform/efl/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Added.
* platform/efl/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Added.
* platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Added.
* platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening.
rakuco@webkit.org [Tue, 25 Sep 2012 12:20:14 +0000 (12:20 +0000)]
[EFL] Gardening.

Move test that is only failing for WK1 to the specific
TestExpectations file.

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Added hideColorPicker test case
commit-queue@webkit.org [Tue, 25 Sep 2012 12:19:22 +0000 (12:19 +0000)]
[EFL][WK2] Added hideColorPicker test case
https://bugs.webkit.org/show_bug.cgi?id=97522

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

Added a test case for removing input element during color picker is shown.

* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(setColorPickerColor):
(showColorPicker):
(hideColorPicker):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Unskip several test cases that are now passing
commit-queue@webkit.org [Tue, 25 Sep 2012 11:49:28 +0000 (11:49 +0000)]
[WK2] Unskip several test cases that are now passing
https://bugs.webkit.org/show_bug.cgi?id=97550

Unreviewed gardening.

Unskip several test cases that are now passing for
WebKit2.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-25

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] unskip toDataURL tests
commit-queue@webkit.org [Tue, 25 Sep 2012 11:44:35 +0000 (11:44 +0000)]
[EFL] unskip toDataURL tests
https://bugs.webkit.org/show_bug.cgi?id=97549

Unreviewed EFL gardening.

EFL port only supports "image/png" at the moment but only png is actually required
by spec and not testing required support is bad.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-09-25

* platform/efl/Skipped:
* platform/efl/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
* platform/efl/fast/canvas/toDataURL-supportedTypes-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2][WKTR] TestRunner needs support for setWillSendRequestReturnsNullOnRedirect
commit-queue@webkit.org [Tue, 25 Sep 2012 11:23:54 +0000 (11:23 +0000)]
[WK2][WKTR] TestRunner needs support for setWillSendRequestReturnsNullOnRedirect
https://bugs.webkit.org/show_bug.cgi?id=97542

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

Tools:

Implement support for setWillSendRequestReturnsNullOnRedirect
in WebKitTestRunner.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::willSendRequestForFrame):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::TestRunner):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
(WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
(TestRunner):

LayoutTests:

Unskip http/tests/misc/will-send-request-returns-null-on-redirect.html
for WebKit2 now that WebKitTestRunner supports
setWillSendRequestReturnsNullOnRedirect.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Remove passing tests from Skipped list
commit-queue@webkit.org [Tue, 25 Sep 2012 11:06:08 +0000 (11:06 +0000)]
[WK2] Remove passing tests from Skipped list
https://bugs.webkit.org/show_bug.cgi?id=97546

Unreviewed gardening.

Unskip several unclassified test cases as they appear
to now pass for WebKit2. A few remaining failures
were classified as well.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-25

* platform/efl/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: ResourceScriptMapping should no steal scripts from other mappings.
vsevik@chromium.org [Tue, 25 Sep 2012 10:58:51 +0000 (10:58 +0000)]
Web Inspector: ResourceScriptMapping should no steal scripts from other mappings.
https://bugs.webkit.org/show_bug.cgi?id=97453

Reviewed by Pavel Feldman.

Source/WebCore:

Exposed sourceMapping getter on Script so that resource mapping could check it.

* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
(WebInspector.ResourceScriptMapping.prototype._reset):

LayoutTests:

* http/tests/inspector/compiler-script-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] More gardening.
rakuco@webkit.org [Tue, 25 Sep 2012 10:48:57 +0000 (10:48 +0000)]
[EFL] More gardening.

Skip inspector/styles/variables/css-variables.html on WK2, specify
all CSS Sticky-related tests that are currently failing because
some are passing regardless of whether ENABLE_CSS_STICKY_POSITION
is enabled or not and update the way
http/tests/loading/307-after-303-after-post.html is being flaky.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Daily gardening. Skip a few failing tests.
rakuco@webkit.org [Tue, 25 Sep 2012 10:01:34 +0000 (10:01 +0000)]
[EFL] Daily gardening. Skip a few failing tests.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] [DRT] fast/forms/textarea-live-pseudo-selectors.html failed
commit-queue@webkit.org [Tue, 25 Sep 2012 09:58:41 +0000 (09:58 +0000)]
[BlackBerry] [DRT] fast/forms/textarea-live-pseudo-selectors.html failed
https://bugs.webkit.org/show_bug.cgi?id=97189

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-09-25
Reviewed by Rob Buis.

Translate ASCII key code to BlackBerry key code for BACKSPACE and DELETE key.

* DumpRenderTree/blackberry/EventSender.cpp:
(keyDownCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, skip a new failing test.
ossy@webkit.org [Tue, 25 Sep 2012 09:49:55 +0000 (09:49 +0000)]
[Qt] Unreviewed gardening, skip a new failing test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r129448): multiple fields time input UI doesn't use system time format...
keishi@webkit.org [Tue, 25 Sep 2012 09:39:31 +0000 (09:39 +0000)]
REGRESSION(r129448): multiple fields time input UI doesn't use system time format settings on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=97517

Reviewed by Kent Tamura.

We need to locale [NSLocale currentLocale] if browser language/@lang equals [[NSLocal currentLocale] localeIdentifier]. Otherwise it won't use the custom time format that the user has set.

No new tests. Unable to test because we need to change system locale settings.

* platform/text/mac/LocaleMac.h:
(LocaleMac):
* platform/text/mac/LocaleMac.mm:
(WebCore::languageFromLocale): Moved to top.
(WebCore):
(WebCore::determineLocale): Modified so it takes a locale as an argument.
(WebCore::Localizer::create):
(WebCore::LocaleMac::LocaleMac): Added checks for invalid locales to this constructor and removed the other one so we don't have duplicated code.
(WebCore::LocaleMac::create):
(WebCore::LocaleMac::currentLocale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2][WTR] WTR bundle client loads binary data as text
commit-queue@webkit.org [Tue, 25 Sep 2012 09:19:57 +0000 (09:19 +0000)]
[WK2][WTR] WTR bundle client loads binary data as text
https://bugs.webkit.org/show_bug.cgi?id=97532

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Added WKBundlePageCanShowMIMEType() function to WKBundlePage private API.
This function is put to WKBundlePage to keep consistency with WebKit::WebPageProxy::canShowMIMEType().
Actually it does not need anything from page.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCanShowMIMEType):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Tools:

WTR::InjectedBundlePage::decidePolicyForResponse now checks response MIME type
and returns WKBundlePagePolicyActionPassThrough if it cannot be shown.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::decidePolicyForResponse):

LayoutTests:

Unskipped http/tests/loading/text-content-type-with-binary-extension.html for WK2.

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, another test case adjustment after r129459. Python 2.7 doesn't
zandobersek@gmail.com [Tue, 25 Sep 2012 09:09:58 +0000 (09:09 +0000)]
Unreviewed, another test case adjustment after r129459. Python 2.7 doesn't
seem to be a requirement yet so the assertDictEqual method is not yet available
on all builders. Assert that the empty dictionary length equals 0 instead.

* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.test_interpret_test_failures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Relative URL Link Tooltips do not respect <base>
apavlov@chromium.org [Tue, 25 Sep 2012 09:01:54 +0000 (09:01 +0000)]
Web Inspector: Relative URL Link Tooltips do not respect <base>
https://bugs.webkit.org/show_bug.cgi?id=43434

Reviewed by Pavel Feldman.

Source/WebCore:

New "baseURL" field added into the DOM.Node payload for document nodes and is made use of while resolving and completing URLs.

* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::documentBaseURLString):
(WebCore):
(WebCore::InspectorDOMAgent::buildObjectForNode):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.resolveURL):
(WebInspector.DOMDocument):

LayoutTests:

Added an iframe containing the <base> tag to test DOMNode.prototype.resolveURL() with a non-trivial baseURL.

* inspector/elements/elements-panel-rewrite-href.html:
* inspector/elements/elements-panel-rewrite-href-expected.txt:
* inspector/elements/resources/elements-panel-rewrite-href-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: The JS code injected by worker inspector shouldn't be evaluated throu...
commit-queue@webkit.org [Tue, 25 Sep 2012 08:39:41 +0000 (08:39 +0000)]
Web Inspector:  The JS code injected by worker inspector shouldn't be evaluated through JSMainThreadExecState
https://bugs.webkit.org/show_bug.cgi?id=95341

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-09-25
Reviewed by Yury Semikhatsky.

Add extra code to "JSC::InjectedScriptManager" and "JSC::ScriptFunctionCall" to make sure the
interfaces of JSMainThreadExecState are invoked only in main thread.

No new test case for this bug. Without this patch, opening worker inspector will meet failed assert statements.

* bindings/js/JSInjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createInjectedScript):
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Don't use the C API internally in WebKitWebView
carlosgc@webkit.org [Tue, 25 Sep 2012 08:34:22 +0000 (08:34 +0000)]
[GTK] Don't use the C API internally in WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=96767

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

* UIProcess/API/gtk/WebKitContextMenuClient.cpp:
(getContextMenuFromProposedMenu):
* UIProcess/API/gtk/WebKitResourceLoadClient.cpp:
(didInitiateLoadForResource):
* UIProcess/API/gtk/WebKitUIClient.cpp:
(createNewPage):
(runJavaScriptPrompt):
(mouseDidMoveOverElement):
(printFrame):
* UIProcess/API/gtk/WebKitURIRequest.cpp:
(webkitURIRequestCreateForResourceRequest):
(webkitURIRequestGetResourceRequest):
* UIProcess/API/gtk/WebKitURIRequestPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(allowModalDialogsChanged):
(zoomTextOnlyChanged):
(webkitWebViewSetSettings):
(webkitWebViewConstructed):
(webkitWebViewUpdateURI):
(webkitWebViewCreateNewPage):
(webkitWebViewRunJavaScriptPrompt):
(webkitWebViewMouseTargetChanged):
(webkitWebViewPrintFrame):
(webkitWebViewResourceLoadStarted):
(webkitWebViewPopulateContextMenu):
(webkit_web_view_load_uri):
(webkit_web_view_load_html):
(webkit_web_view_load_alternate_html):
(webkit_web_view_load_plain_text):
(webkit_web_view_load_request):
(webkit_web_view_reload):
(webkit_web_view_reload_bypass_cache):
(webkit_web_view_stop_loading):
(webkit_web_view_go_back):
(webkit_web_view_can_go_back):
(webkit_web_view_go_forward):
(webkit_web_view_can_go_forward):
(webkit_web_view_get_custom_charset):
(webkit_web_view_set_custom_charset):
(webkit_web_view_go_to_back_forward_list_item):
(webkit_web_view_set_settings):
(webkit_web_view_set_zoom_level):
(webkit_web_view_get_zoom_level):
(webkit_web_view_can_execute_editing_command):
(webkit_web_view_execute_editing_command):
(webkit_web_view_run_javascript):
(webkit_web_view_get_inspector):
(webkit_web_view_can_show_mime_type):
(ViewSaveAsyncData):
(getContentsAsMHTMLDataCallback):
(webkit_web_view_save):
(webkit_web_view_save_finish):
(webkit_web_view_save_to_file):
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreate):
(webkitWebViewBaseCreateWebPage):
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
* UIProcess/API/gtk/WebKitWebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSSParserString: Avoid pointless String refcount churn in init().
kling@webkit.org [Tue, 25 Sep 2012 08:15:17 +0000 (08:15 +0000)]
CSSParserString: Avoid pointless String refcount churn in init().
<http://webkit.org/b/94748>

Reviewed by Sam Weinig.

Have CSSParserString::init() take a const String& instead of a String.

* css/CSSParserValues.h:
(WebCore::CSSParserString::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Update minimal required versions for dependencies
commit-queue@webkit.org [Tue, 25 Sep 2012 08:14:53 +0000 (08:14 +0000)]
[EFL] Update minimal required versions for dependencies
https://bugs.webkit.org/show_bug.cgi?id=97523

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-09-25
Reviewed by Gyuyoung Kim.

Use the same versions numbers for dependencies as in Tools/efl/jhbuild.modules.

* Source/cmake/OptionsEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix build with latest Qt 5
hausmann@webkit.org [Tue, 25 Sep 2012 08:08:17 +0000 (08:08 +0000)]
[Qt] Fix build with latest Qt 5
https://bugs.webkit.org/show_bug.cgi?id=97479

Reviewed by Tor Arne Vestbø.

.:

Define MODULE_BASE_DIR before loading qt_module.prf, which now calls syncqt. MODULE_BASE_DIR is
passed as last parameter (source dir) to syncqt now, so set it to the directory that contains
sync.profile.

* Source/api.pri:

Tools:

The variables for syncqt handling are now set in api.pri, but let's add a comment here that we can
remove them from default_pre.prf once we're past Qt 5 beta2.

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Styles] For group selectors, transmit their segments with the "matche...
apavlov@chromium.org [Tue, 25 Sep 2012 08:05:18 +0000 (08:05 +0000)]
Web Inspector: [Styles] For group selectors, transmit their segments with the "matches" flag
https://bugs.webkit.org/show_bug.cgi?id=96999

Reviewed by Pavel Feldman.

Source/WebCore:

The CSSRule protocol object has been modified to include a SelectorList object that contains selector-related data.
CSSAgent methods that return CSS rule matches will return RuleMatch objects that encapsulate matching CSSRules
with indices of matching selectors on the associated selector list, so the additional backend roundtrips
from StylesSidebarPane are no longer necessary.

* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildObjectForRule):
(WebCore):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
(WebCore):
(WebCore::InspectorStyleSheet::buildObjectForRule):
* inspector/InspectorStyleSheet.h:
(InspectorStyleSheet):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.parseRuleMatchArrayPayload):
(WebInspector.CSSStyleModel.prototype.getMatchedStylesAsync):
(WebInspector.CSSRule):
(WebInspector.CSSRule.parsePayload):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
(WebInspector.StylePropertiesSection.prototype._markSelectorMatches):
(WebInspector.StylePropertiesSection.prototype._moveEditorFromSelector):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled):

LayoutTests:

* inspector/styles/get-set-stylesheet-text.html:
* inspector/styles/styles-new-API.html:
* inspector/styles/styles-source-offsets.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoadoptNode() shouldn't reset ownerDocument if the source node failed to remove itself
morrita@google.com [Tue, 25 Sep 2012 08:01:17 +0000 (08:01 +0000)]
adoptNode() shouldn't reset ownerDocument if the source node failed to remove itself
https://bugs.webkit.org/show_bug.cgi?id=97527

Reviewed by Ryosuke Niwa.

Source/WebCore:

Document::adoptNode() overlooked an error which can happen in Node::removeChild().
Which results an assertion failure. This change adds an error check for that code path.

Test: fast/dom/adopt-node-prevented.html

* dom/Document.cpp:
(WebCore::Document::adoptNode):

LayoutTests:

* fast/dom/adopt-node-prevented-expected.txt: Added.
* fast/dom/adopt-node-prevented.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviwed gardening. Greening bots.
ossy@webkit.org [Tue, 25 Sep 2012 07:59:27 +0000 (07:59 +0000)]
[Qt] Unreviwed gardening. Greening bots.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-09-25

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Partial Skipped file clean up
commit-queue@webkit.org [Tue, 25 Sep 2012 07:55:00 +0000 (07:55 +0000)]
[EFL] Partial Skipped file clean up
https://bugs.webkit.org/show_bug.cgi?id=97531

Unreviewed EFL gardening.

Move part of the test cases from Skipped file
to TestExpectations since we want to get rid
of the Skipped list soon.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-25

* platform/efl-wk2/TestExpectations:
* platform/efl/Skipped:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: extract Vector instrumentation from core NMI code into MemoryInstrumen...
loislo@chromium.org [Tue, 25 Sep 2012 07:54:44 +0000 (07:54 +0000)]
Web Inspector: extract Vector instrumentation from core NMI code into MemoryInstrumentationVector.h header.
https://bugs.webkit.org/show_bug.cgi?id=96650

Reviewed by Vsevolod Vlasov.

Source/WebCore:

addInstrumentedVector and addInstrumentedVectorPtr were replaced with addMember.
The same thing happens with addVector and addVectorPtr.

* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::reportDescendantMemoryUsage):
* css/CSSRuleList.cpp:
(WebCore::StaticCSSRuleList::reportMemoryUsage):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::reportDescendantMemoryUsage):
* css/MediaList.cpp:
(WebCore::MediaQuerySet::reportMemoryUsage):
* css/MediaQuery.cpp:
(WebCore::MediaQuery::reportMemoryUsage):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleRule.cpp:
(WebCore::StyleRuleBlock::reportDescendantMemoryUsage):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
(WebCore::WebKitCSSKeyframesRule::reportDescendantMemoryUsage):
* css/WebKitCSSRegionRule.cpp:
(WebCore::WebKitCSSRegionRule::reportDescendantMemoryUsage):
* dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsage):

Source/WebKit/chromium:

Test for instrumented vector.

* tests/MemoryInstrumentationTest.cpp:
(WebCore::InstrumentedOwner::InstrumentedOwner):
(WebCore::TEST):
(WebCore):

Source/WTF:

Added reportMemoryUsage free template function with default body to core NMI code
and add custom version of reportMemoryUsage function for Vectors.

* GNUmakefile.list.am:
* WTF.gypi:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/MemoryInstrumentation.h:
(WTF):
(MemoryInstrumentation):
(WTF::MemoryInstrumentation::addObjectImpl):
* wtf/MemoryInstrumentationVector.h: Added.
(WTF):
(WTF::instrumentVectorValues):
(WTF::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, adjusting the test cases after r129459. The JSON data
zandobersek@gmail.com [Tue, 25 Sep 2012 07:53:45 +0000 (07:53 +0000)]
Unreviewed, adjusting the test cases after r129459. The JSON data
for reftests now contains the 'reftest_type' key and no more 'is_reftest'
or 'is_mismatch_reftest' keys.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(EndToEndTest.test_reftest_with_two_notrefs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r129346): It broke !ENABLE(INSPECTOR) build
ossy@webkit.org [Tue, 25 Sep 2012 07:33:33 +0000 (07:33 +0000)]
REGRESSION(r129346): It broke !ENABLE(INSPECTOR) build
https://bugs.webkit.org/show_bug.cgi?id=97490

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-09-25
Reviewed by Csaba Osztrogonác.

The dummy class implementation must be under the ENABLE(INSPECTOR)
guard. Added them to prevent from braking the build with --minimal
option for build-webkit

No new tests as caused by missing compile guard.

* testing/Internals.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReland "Add in-place reload behavior to ImagesEnabled setting" with optimizations
commit-queue@webkit.org [Tue, 25 Sep 2012 06:51:39 +0000 (06:51 +0000)]
Reland "Add in-place reload behavior to ImagesEnabled setting" with optimizations
https://bugs.webkit.org/show_bug.cgi?id=97055

Patch by Bo Liu <boliu@chromium.org> on 2012-09-24
Reviewed by Adam Barth.

Relanding 128780, 128676, 128645. Was reverted in 128914 due to
performance regression in Chromium.

New changes in addition to previously reverted patches:

Refactored CachedResource::requestResource, loadResource, and
revalidateResource. Moved CachedResource::load method to end of
requestResource so there is one place where load is called for all
resources.

Added a enum parameter for requestResource and
determineRevalidationPolicy so that FrameLoaderClient::allowImage call
do not need to be called multiple times.

Removed CachedImage::load call in requestImage so it is not called
twice.

Removed unnecessary Frame.h includes in CachedResource and
CachedImage.

Removed dead load() method declaration in CachedImage.

Updated text expectation for two image-permissions tests to reflect
the removed calls to allowImage.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

Tests: fast/loader/display-image-unset-allows-cached-image-load.html
       fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
       fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html

* WebCore.exp.in:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
* loader/cache/CachedImage.cpp:
* loader/cache/CachedImage.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::didAddClient):
* loader/cache/CachedResource.h:
(WebCore):
(WebCore::CachedResource::stillNeedsLoad):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore):
(WebCore::CachedResourceLoader::setImagesEnabled):
(WebCore::CachedResourceLoader::clientDefersImage):
(WebCore::CachedResourceLoader::shouldDeferImageLoad):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):
* loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
* page/Settings.cpp:
(WebCore::setImageLoadingSettings):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::imageLoadingSettingsTimerFired):
(WebCore::Settings::setImagesEnabled):
* page/Settings.h:
(Settings):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setImagesEnabled):
(WebCore):
* testing/InternalSettings.h:
(Backup):
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit2:

* win/WebKit2.def:

LayoutTests:

* fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Added.
* fast/loader/display-image-unset-allows-cached-image-load.html: Added.
* fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
* fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Added.
* fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
* fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Added.
* fast/loader/resources/image1.html: Added.
* fast/loader/resources/image2.html: Added.
* platform/chromium/permissionclient/image-permissions-expected.txt:
* platform/chromium/permissionclient/image-permissions.html:
* platform/chromium/permissionclient/resources/image.html:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=97530
barraclough@apple.com [Tue, 25 Sep 2012 06:48:35 +0000 (06:48 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=97530
Regression, freeze applied to numeric properties of non-array objects

Reviewed by Filip Pizlo.

Object.freeze has a fast implementation in JSObject, but this hasn't been updated to take into account numeric properties in butterflies.
For now, just fall back to the generic implementation if the object has numeric properties.

Source/JavaScriptCore:

* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorFreeze):
    - fallback if the object has a non-zero indexed property vector length.

LayoutTests:

* fast/js/preventExtensions-expected.txt:
* fast/js/script-tests/preventExtensions.js:
    - Added a test case for freezing an object with a numeric property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 25 Sep 2012 06:32:23 +0000 (06:32 +0000)]
Unreviewed GTK gardening.

Adding failure expectation for http/tests/security/xss-eval.html as the
test started failing after r129456.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnexpected reftest passes are only reported when pixel testing is enabled in results...
zandobersek@gmail.com [Tue, 25 Sep 2012 06:17:58 +0000 (06:17 +0000)]
Unexpected reftest passes are only reported when pixel testing is enabled in results.html as well
https://bugs.webkit.org/show_bug.cgi?id=97426

Reviewed by Ojan Vafai.

Tools:

The 'is_reftest' member of the TestResult class has been replaced by the reftest_type
member which is a set containing either '!=', '==', both or none if the test represented
by the object is not a reftest.

When summarizing results, the test dictionary is updated to contain the 'reftest_type' key
if the test is a reftest. The value of this key is a list of all the reftest types of this test.

The test failure interpretation method has been refactored, it now reports only
missing results of various formats and image diff percent in case of image or
reftest mismatch.

Unit tests have been modified accordingly.

* Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner._update_summary_with_result):
* Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(LayoutTestRunnerTests.test_update_summary_with_result):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(interpret_test_failures):
(summarize_results):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.test_interpret_test_failures):
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.run):
(SingleTestRunner._run_reftest):
* Scripts/webkitpy/layout_tests/models/test_results.py:
(TestResult.__init__):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(EndToEndTest.test_reftest_with_two_notrefs):

LayoutTests:

Report unexpectedly passing reftests as well. Test cases included.

* fast/harness/resources/results-test.js:
* fast/harness/results-expected.txt:
* fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBug in numeric accessors on global environment
barraclough@apple.com [Tue, 25 Sep 2012 06:12:11 +0000 (06:12 +0000)]
Bug in numeric accessors on global environment
https://bugs.webkit.org/show_bug.cgi?id=97526

Reviewed by Geoff Garen.

I've hit this assert in test262 in browser, but haven't yet worked out how to repro in a test case :-/
The sparsemap is failing to map back from the global object to the window shell.
A test case would need to resolve a numeric property name against the global environment.

(JSC::SparseArrayEntry::get):
(JSC::SparseArrayEntry::put):
    - Add missing toThisObject calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSerializedScriptValue isn't aware of indexed storage, but should be
fpizlo@apple.com [Tue, 25 Sep 2012 05:27:33 +0000 (05:27 +0000)]
SerializedScriptValue isn't aware of indexed storage, but should be
https://bugs.webkit.org/show_bug.cgi?id=97515
<rdar://problem/12361874>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Export a method that WebCore now uses.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSObject.h:
(JSObject):

Source/WebCore:

New test: fast/js/post-message-numeric-property.html

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::putProperty):

LayoutTests:

* fast/js/post-message-numeric-property-expected.txt: Added.
* fast/js/post-message-numeric-property.html: Added.
* fast/js/script-tests/post-message-numeric-property.js: Added.
(window.onmessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove JSObject::unwrappedGlobalObject(), JSObject::unwrappedObject()
barraclough@apple.com [Tue, 25 Sep 2012 04:52:26 +0000 (04:52 +0000)]
Remove JSObject::unwrappedGlobalObject(), JSObject::unwrappedObject()
https://bugs.webkit.org/show_bug.cgi?id=97519

Reviewed by Geoff Garen.

../JavaScriptCore:

unwrappedGlobalObject() was only needed because globalObject() doesn't always return a helpful result -
specifically for WebCore's window shell the structure's globalObject is set to null. We can fix this by
simply keeping the structure up to date as the window navigates, obviating the need for this function.

The only other use of unwrappedObject() came from globalFuncEval(), and this can be trivially removed
by flipping the way we perform this globalObject check (which we may also be able to remove!) - instead
of getting the globalObject from the provided this value & comparing to the expected globalObject, we
can get the this value from the expected globalObject, and compare to that provided.

* runtime/JSGlobalObject.cpp:
    - Call globalObject() instead of unwrappedGlobalObject().
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
    - Changed to compare this object values, instead of globalObjects -
      this means we only need to be able to map globalObject -> this,
      and not vice versa.
* runtime/JSObject.cpp:
(JSC::JSObject::allowsAccessFrom):
(JSC::JSObject::createInheritorID):
    - Call globalObject() instead of unwrappedGlobalObject().
* runtime/JSObject.h:
(JSObject):
    - Removed unwrappedGlobalObject(), unwrappedObject().

../WebCore:

JSDOMWindowShell::setWindow should update the structure's globalObject.

* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::setWindow):
    - Update the JSDOMWindowShell's structure's globalObject when the
      window changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] We should remove DateTimeEditElement::valueAsDouble()
yosin@chromium.org [Tue, 25 Sep 2012 04:40:48 +0000 (04:40 +0000)]
[Forms] We should remove DateTimeEditElement::valueAsDouble()
https://bugs.webkit.org/show_bug.cgi?id=97327

Reviewed by Kent Tamura.

This patch removes unused function DateTimeEditElement::valueAsDouble()
and related functions in DateTimeFieldElement.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

* html/shadow/DateTimeEditElement.cpp: Removed valueAsDouble() implementation.
* html/shadow/DateTimeEditElement.h: Removed valueAsDouble() declaration.
(DateTimeEditElement):
* html/shadow/DateTimeFieldElement.cpp: Removed valueAsDouble() implementation.
* html/shadow/DateTimeFieldElement.h: Removed unitInMillisecond() and valueAsDouble() declarations.
(DateTimeFieldElement):
* html/shadow/DateTimeFieldElements.cpp: Removed unitInMillisecond() implementations.
* html/shadow/DateTimeFieldElements.h:
(DateTimeAMPMFieldElement): Removed unitInMillisecond() declaration.
(DateTimeHourFieldElement): ditto.
(DateTimeMillisecondFieldElement): ditto.
(DateTimeMinuteFieldElement): ditto.
(DateTimeSecondFieldElement): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWKProcessGroup can't load injected bundle with file URL
weinig@apple.com [Tue, 25 Sep 2012 04:33:25 +0000 (04:33 +0000)]
WKProcessGroup can't load injected bundle with file URL
<rdar://problem/12322774>
https://bugs.webkit.org/show_bug.cgi?id=97520

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKProcessGroup.mm:
(-[WKProcessGroup initWithInjectedBundleURL:]):
Fix typo. We need to pass the string as path, not as a URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDeleting the classic interpreter and cleaning up some build options.
mark.lam@apple.com [Tue, 25 Sep 2012 04:30:20 +0000 (04:30 +0000)]
Deleting the classic interpreter and cleaning up some build options.
https://bugs.webkit.org/show_bug.cgi?id=96969.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):
* bytecode/Instruction.h:
(JSC::Instruction::Instruction):
* interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
* interpreter/AbstractPC.h:
(AbstractPC):
* interpreter/CallFrame.h:
(ExecState):
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::~Interpreter):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
(JSC::getSourceURLFromCallFrame):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::retrieveArgumentsFromVMCode):
(JSC::Interpreter::retrieveCallerFromVMCode):
(JSC::Interpreter::retrieveLastCaller):
* interpreter/Interpreter.h:
(JSC::Interpreter::getOpcodeID):
(Interpreter):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
* offlineasm/asm.rb:
* offlineasm/offsets.rb:
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(NativeExecutable):
(JSC::NativeExecutable::finishCreation):
* runtime/JSGlobalData.cpp:
(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
(JSGlobalData):
(JSC::JSGlobalData::canUseJIT):
(JSC::JSGlobalData::canUseRegExpJIT):
* runtime/Options.cpp:
(JSC::Options::initialize):

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataEnableFeatures.in:

Source/WTF:

* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't use StyleSheetList internally.
antti@apple.com [Tue, 25 Sep 2012 04:25:35 +0000 (04:25 +0000)]
Don't use StyleSheetList internally.
https://bugs.webkit.org/show_bug.cgi?id=97504

Reviewed by Ryosuke Niwa.

StyleSheetList is a DOM type and should not be used internally. Use plain Vector instead and construct StyleSheetList on DOM access only.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addStylesheetsFromSeamlessParents):
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleSheetList.cpp:
(WebCore::StyleSheetList::StyleSheetList):
(WebCore::StyleSheetList::styleSheets):
(WebCore):
(WebCore::StyleSheetList::detachFromDocument):

    Use live stylesheet vector of the documents stylesheet collection as long as we are attached to a document.
    When detached copy the stylesheet vector to a member field and use that instead.

(WebCore::StyleSheetList::length):
(WebCore::StyleSheetList::item):
(WebCore::StyleSheetList::getNamedItem):
* css/StyleSheetList.h:

    Removed StyleSheetVector typedef as Vector<RefPtr<StyleSheet> > is less opaque and not much longer.

(WebCore):
(WebCore::StyleSheetList::create):
(StyleSheetList):
(WebCore::StyleSheetList::document):
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::styleSheets):
* dom/Document.h:
(Document):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
* dom/DocumentStyleSheetCollection.h:
(WebCore::DocumentStyleSheetCollec

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse NSUserDefaults rather than an environment variable to control whether to use...
weinig@apple.com [Tue, 25 Sep 2012 04:09:02 +0000 (04:09 +0000)]
Use NSUserDefaults rather than an environment variable to control whether to use an XPC Service for the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=97514

Reviewed by Anders Carlsson.

Source/WebKit2:

* GNUmakefile.list.am:
* PlatformEfl.cmake:
* Target.pri:
Add new files.

* UIProcess/Launcher/ProcessLauncher.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connect):
Move platform specific launch options to a new function, platformConnect.

* UIProcess/WebProcessProxy.h:
* UIProcess/efl/WebProcessProxyEfl.cpp: Added.
Move Efl specific launch options here.

(WebKit::WebProcessProxy::platformConnect):
* UIProcess/gtk/WebProcessProxyGtk.cpp: Added.
Add stub.

(WebKit::WebProcessProxy::platformConnect):
* UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::platformConnect):
Move Mac specific launch option setting here, and switch from
using an environment variable to NSUserDefaults.

* UIProcess/qt/WebProcessProxyQt.cpp: Added.
(WebKit::WebProcessProxy::platformConnect):
Add stub.

* UIProcess/win/WebProcessProxyWin.cpp:
(WebKit::WebProcessProxy::platformConnect):
Add stub.

Tools:

* Scripts/webkitdirs.pm:
(argumentsForRunAndDebugMacWebKitApp):
Push "-WebKit2UseXPCServiceForWebProcess YES" as arguments when --use-web-process-xpc-service
is provided to set the user default. Move adding of @ARGV to after custom additions as calling
shouldUseXPCServiceForWebProcess() can change @ARGV.

(runMacWebKitApp):
(execMacWebKitAppForDebugging):
Stop setting the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: [GTK][EFL] Remove cairo prefix from include statements
commit-queue@webkit.org [Tue, 25 Sep 2012 03:55:25 +0000 (03:55 +0000)]
Source/WebCore: [GTK][EFL] Remove cairo prefix from include statements
https://bugs.webkit.org/show_bug.cgi?id=97509

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-09-24
Reviewed by Gyuyoung Kim.

Make the build system consistent by always assuming that directory
that includes the cairo headers is included in the include path.

No new tests as there is no new functionality.

* platform/cairo/WidgetBackingStoreCairo.cpp:
* platform/gtk/GtkWidgetBackingStoreX11.cpp:
* plugins/gtk/PluginViewGtk.cpp:

Source/WebKit2: [GTK][EFL] Remove cairo prefix from include statements
https://bugs.webkit.org/show_bug.cgi?id=97509

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-09-24
Reviewed by Gyuyoung Kim.

Make the build system consistent by always assuming that directory
that includes the cairo headers is included in the include path.

* UIProcess/cairo/BackingStoreCairo.cpp:
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK][EFL] Make sure cairo is built with fontconfig support
commit-queue@webkit.org [Tue, 25 Sep 2012 03:53:12 +0000 (03:53 +0000)]
[GTK][EFL] Make sure cairo is built with fontconfig support
https://bugs.webkit.org/show_bug.cgi?id=97513

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-09-24
Reviewed by Martin Robinson.

The GTK and EFL port of WebKit requires a version of cairo that is built with fontconfig support.

* efl/jhbuild.modules:
* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDocument::adoptNode for multiple fields time input UI should not crash
yosin@chromium.org [Tue, 25 Sep 2012 03:26:31 +0000 (03:26 +0000)]
Document::adoptNode for multiple fields time input UI should not crash
https://bugs.webkit.org/show_bug.cgi?id=97428

Reviewed by Dimitri Glazkov.

Source/WebCore:

This patch changes Document::removeFocusedNodeOfSubtree() to check
focused node in shadow DOM tree for avoiding Document::m_focusedNode
not to have dangling pointer to field owner in DateTimeFieldElement.

Test:
 - fast/dom/shadow/shadow-removechild-and-blur-event.html: test for removeChild dispatches blur event.
 - fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: test for adoptNode not to crash.
 - fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur.html: removeChild of input type "time" dispatches blur event, existing test.

* dom/Document.cpp:
(WebCore::Document::removeFocusedNodeOfSubtree): Changed to check
focused node in shadow DOM tree in addition to descendant node.

LayoutTests:

This patch adds a test for checking removeChild() of shadow host
dispatches blur event if focused node in shadow tree, a test for
checking adoptNode() doesn't causes crash and dispatches blur event
during document.adoptNode() and updates expectation for focus/blur event test.

* fast/dom/shadow/shadow-removechild-and-blur-event-expectation.txt: Added.
* fast/dom/shadow/shadow-removechild-and-blur-event.html: Added for checking removeChild of shadow host dispatchs blur event when focused node in shadow tree.
* fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur-expected.txt: Updated to expectation to have output from blur event handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Change hardcoded 'lib' and 'bin' in CMakeLists.txt to 'LIB_INSTALL_DIR' and...
commit-queue@webkit.org [Tue, 25 Sep 2012 03:22:13 +0000 (03:22 +0000)]
[CMake] Change hardcoded 'lib' and 'bin' in CMakeLists.txt to 'LIB_INSTALL_DIR' and 'EXEC_INSTALL_DIR'.
https://bugs.webkit.org/show_bug.cgi?id=97419

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-24
Reviewed by Gyuyoung Kim.

Use the value of LIB_INSTALL_DIR and EXEC_INSTALL_DIR instead of
hardcoding 'lib' and 'bin' for CMAKE_{ARCHIVE,LIBRARY,RUNTIME}_OUTPUT_DIRECTORY.

* CMakeLists.txt:
Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
Use ${EXEC_INSTALL_DIR} instead of hardcoding "bin".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Blackberry] Add a software rendering path for media player
commit-queue@webkit.org [Tue, 25 Sep 2012 03:13:21 +0000 (03:13 +0000)]
[Blackberry] Add a software rendering path for media player
https://bugs.webkit.org/show_bug.cgi?id=97443

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-09-24
Reviewed by Yong Li.

This patch adds a software rendering path for media player. When accelerated rendering
is not supported by the media engine for the current media, the rendering will fallback
to this software path.

PR #212386
Reviewed internally by Max Feil.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
(WebCore):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWe should not expect percent-escaped hostname for invalid URLs
benjamin@webkit.org [Tue, 25 Sep 2012 02:56:35 +0000 (02:56 +0000)]
We should not expect percent-escaped hostname for invalid URLs
https://bugs.webkit.org/show_bug.cgi?id=97415

Reviewed by Adam Barth.

The URL layout tests encode some Chromium specific behavior.
Chromium does a partial canonicalization of invalid URLs. Neither Safari, nor Firefox nor Opera
do that.

This patch fix the tests and expectations for the IP tests.

* fast/url/invalid-urls-utf8-expected.txt:
* fast/url/invalid-urls-utf8.html:
Move the "empty authority" check from both IP tests to the invalid URLs test. An empty authority
for a standard URL causes an invalid URL, it should be kept as is.

* fast/url/ipv4-expected.txt:
* fast/url/ipv6-expected.txt:
* fast/url/script-tests/ipv4.js:
* fast/url/script-tests/ipv6.js: Extend a comment to clarify the rule.
Invalid URLs should not be escaped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix Geolocation error reporting in the test support
benjamin@webkit.org [Tue, 25 Sep 2012 02:30:01 +0000 (02:30 +0000)]
Fix Geolocation error reporting in the test support
https://bugs.webkit.org/show_bug.cgi?id=97386

Source/WebCore:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

GeolocationController currently expose GeolocationError which can be either
PermissionDenied or PositionUnavailable.

In practice, only PositionUnavailable is supported and tested, only Chrome
somewhat expose PermissionDenied.
The correct way to deny the permission is through Geolocation::setIsAllowed().

This patch does some of the initial cleanup toward that goal, reducing how
far GeolocationError is spread.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
Mac does not use GeolocationClientMock, it should not be compiled in WebCore.

* platform/mock/GeolocationClientMock.cpp:
(WebCore::GeolocationClientMock::GeolocationClientMock):
(WebCore::GeolocationClientMock::setPosition):
(WebCore::GeolocationClientMock::setPositionUnavailableError):
This method replace setError(). It is limited to PositionUnavailable errors.

(WebCore::GeolocationClientMock::reset):
(WebCore::GeolocationClientMock::controllerTimerFired):
(WebCore):
(WebCore::GeolocationClientMock::clearError):
* platform/mock/GeolocationClientMock.h:
(WebCore):
(GeolocationClientMock):

Source/WebKit/blackberry:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

* WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::setMockGeolocationPositionUnavailableError):
* WebKitSupport/DumpRenderTreeSupport.h:
(DumpRenderTreeSupport):

Source/WebKit/chromium:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

* public/WebGeolocationClientMock.h:
(WebGeolocationClientMock):
* src/WebGeolocationClientMock.cpp:
(WebKit::WebGeolocationClientMock::setMockGeolocationPositionUnavailableError):

Source/WebKit/gtk:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setMockGeolocationPositionUnavailableError):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

* WebView/WebView.mm:
(-[WebView _geolocationDidFailWithMessage:]):
* WebView/WebViewPrivate.h:

Source/WebKit/qt:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setMockGeolocationPositionUnavailableError):
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.
The TestRunner was exposing internal implementation details of
the Geolocation object through setMockGeolocationError().

In practice, only the error code PositionUnavailable is supported
or even implemented.

Exposing setMockGeolocationError() does not make sense for WebKit2 as
passing generic errors from the UIProcess is a bad idea. This is the
opportunity to clean TestRunner and prepare and interface suitable for WebKit2.

* DumpRenderTree/TestRunner.cpp:
(setMockGeolocationPositionUnavailableErrorCallback):
(TestRunner::staticFunctions):
* DumpRenderTree/TestRunner.h:
(TestRunner):
* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::setMockGeolocationPositionUnavailableError):
* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::setMockGeolocationPositionUnavailableError):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::setMockGeolocationPositionUnavailableError):
* DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::setMockGeolocationPositionUnavailableError):
* DumpRenderTree/mac/MockGeolocationProvider.h:
* DumpRenderTree/mac/MockGeolocationProvider.mm:
(-[MockGeolocationProvider dealloc]):
(-[MockGeolocationProvider resetError]):
(-[MockGeolocationProvider setPosition:]):
(-[MockGeolocationProvider setPositionUnavailableErrorWithMessage:]):
(-[MockGeolocationProvider lastPosition]):
(-[MockGeolocationProvider timerFired]):
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setMockGeolocationPositionUnavailableError):
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::setMockGeolocationPositionUnavailableError):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::setMockGeolocationPositionUnavailableError):
* DumpRenderTree/wx/TestRunnerWx.cpp:
(TestRunner::setMockGeolocationPositionUnavailableError):

LayoutTests:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

Update the tests to use setMockGeolocationPositionUnavailableError() instead
of setMockGeolocationError().

Only PositionError.POSITION_UNAVAILABLE was supported, so this not change
anything for the test coverage.

* fast/dom/Geolocation/error-clear-watch.html:
* fast/dom/Geolocation/error-expected.txt:
* fast/dom/Geolocation/maximum-age-expected.txt:
* fast/dom/Geolocation/reentrant-error-expected.txt:
* fast/dom/Geolocation/script-tests/error.js:
* fast/dom/Geolocation/script-tests/maximum-age.js:
(checkError):
(testNonZeroMaximumAge):
* fast/dom/Geolocation/script-tests/permission-denied-already-error.js:
* fast/dom/Geolocation/script-tests/reentrant-error.js:
* fast/dom/Geolocation/script-tests/watch.js:
(checkError):
* fast/dom/Geolocation/watch-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Implement ValidationMessageClient for Chromium
tkent@chromium.org [Tue, 25 Sep 2012 02:16:07 +0000 (02:16 +0000)]
[Chromium] Implement ValidationMessageClient for Chromium
https://bugs.webkit.org/show_bug.cgi?id=97167

Reviewed by Hajime Morita.

Source/WebCore:

* page/ValidationMessageClient.h:
Add forward declaration for WTF::String.

Source/WebKit/chromium:

Introduce ValidationMessageClientImpl. However actual popup
implementation should be done in WebViewClient.

* WebKit.gyp: Add ValidationMessageClientImpl.{cpp,h}.
* public/WebViewClient.h:
(WebKit::WebViewClient::showValidationMessage): Added.
(WebKit::WebViewClient::hideValidationMessage): Added.
* src/ValidationMessageClientImpl.cpp: Added.
(WebKit::ValidationMessageClientImpl::ValidationMessageClientImpl):
(WebKit::ValidationMessageClientImpl::create):
(WebKit::ValidationMessageClientImpl::~ValidationMessageClientImpl):
Make sure that a popup is closed.
(WebKit::ValidationMessageClientImpl::showValidationMessage):
Implementataion of ValidationMessageClient::showValidationMessage.
minimumSecondToShowValidationMessage and secondPerCharacter are same as
the corresponding values in the current Shadow DOM implementation.
(WebKit::ValidationMessageClientImpl::hideValidationMessage):
Implementataion of ValidationMessageClient::hideValidationMessage.
(WebKit::ValidationMessageClientImpl::isValidationMessageVisible):
Implementataion of ValidationMessageClient::isValidationMessageVisible.
(WebKit::ValidationMessageClientImpl::hideCurrentValidationMessage):
This is a callback function for the timer.
* src/ValidationMessageClientImpl.h: Added.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
 - Initialize m_validationMessage.
 - Add a comment for PageClients.
* src/WebViewImpl.h:
Add m_validationMessage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove WebRuntimeFeatures::{enablePushState,isPushStateEnabled}
mihaip@chromium.org [Tue, 25 Sep 2012 02:07:14 +0000 (02:07 +0000)]
[Chromium] Remove WebRuntimeFeatures::{enablePushState,isPushStateEnabled}
https://bugs.webkit.org/show_bug.cgi?id=97506

Reviewed by Adam Barth.

These methods have been no-ops since r127674. All Chromium code that
called them was removed with http://crrev.com/155205.

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] DateTimeEditElement should return string value for ease of implementing other...
yosin@chromium.org [Tue, 25 Sep 2012 01:48:49 +0000 (01:48 +0000)]
[Forms] DateTimeEditElement should return string value for ease of implementing other date/time input types.
https://bugs.webkit.org/show_bug.cgi?id=97303

Reviewed by Kent Tamura.

This patch introduces a function DateTimeEditElement::value() for
setting internal text value of TimeInputType with new function
EditControlOwner::formatDateTimeFieldsState() to utilize this protocl
in other date time input types.

We used DateTimeEditElement::valueAsDouble() and and BaseDateAndTimeInputType::serialize()
to make string value then setting internal text value of multiple
fields time input UI. Although, this steps doesn't work well for
other date/time input types.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

* html/DateTimeFieldsState.cpp:
(WebCore::DateTimeFieldsState::hour23): Added to convert 1 to 12 hour value to 0 to 23 hour.
* html/DateTimeFieldsState.h:
(DateTimeFieldsState): Added declaration of hour23().
* html/TimeInputType.cpp:
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged): Changed to use DateTimeEditElement::value() instead of DateTimeEditElement::valueAsDouble().
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::formatDateTimeFieldsState): Added to format time.
(WebCore::TimeInputType::restoreFormControlState): Changed to use DateTimeEditElement::value() instead of DateTimeEditElement::valueAsDouble().
* html/TimeInputType.h:
(DateTimeEditControlOwnerImpl): Added a declaration of formatDateTimeFieldsState().
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::value): Added.
* html/shadow/DateTimeEditElement.h:
(EditControlOwner): Added a declaration of formatDateTimeFieldsState().
(DateTimeEditElement): Added a declaration of value().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNested try/finally should not confuse the finally unpopper in BytecodeGenerator:...
fpizlo@apple.com [Tue, 25 Sep 2012 01:26:28 +0000 (01:26 +0000)]
Nested try/finally should not confuse the finally unpopper in BytecodeGenerator::emitComplexJumpScopes
https://bugs.webkit.org/show_bug.cgi?id=97508
<rdar://problem/12361132>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

We're reusing some vector for multiple iterations of a loop, but we were forgetting to clear its
contents from one iteration to the next. Hence if you did multiple iterations of finally unpopping
(like in a nested try/finally and a jump out of both of them) then you'd get a corrupted try
context stack afterwards.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitComplexJumpScopes):

LayoutTests:

* fast/js/jsc-test-list:
* fast/js/script-tests/try-try-return-finally-finally.js: Added.
(foo):
* fast/js/try-try-return-finally-finally-expected.txt: Added.
* fast/js/try-try-return-finally-finally.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebGL] Intel Mac needs built-in function emulation
dino@apple.com [Tue, 25 Sep 2012 01:14:48 +0000 (01:14 +0000)]
[WebGL] Intel Mac needs built-in function emulation
https://bugs.webkit.org/show_bug.cgi?id=96140

Reviewed by Sam Weinig.

Temporarily turn on built-in function emulation for Intel GPUs
on OS X. This is a work-around for a driver bug, and
will be removed once the driver is updated:
https://bugs.webkit.org/show_bug.cgi?id=97503

This can be tested using the Khronos WebGL conformance
suite, in particular:

conformance/glsl/functions/glsl-function-dot.html
conformance/glsl/functions/glsl-function-length.html
conformance/glsl/functions/glsl-function-normalize.html
conformance/glsl/functions/glsl-function-reflect.html

Note that the faceforward built-in will still cause
problems on Intel GPUs, but this would require an unnecessary
change in the ANGLE project (remember, we're going to
remove this code once the driver is fixed).

* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
    Temporarily add "Intel" to the list of GPUs we do translation
    for in the shader compiler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThere is a mistake in InspectorProfilerAgent::enable(bool skipRecompile)
commit-queue@webkit.org [Tue, 25 Sep 2012 01:05:43 +0000 (01:05 +0000)]
There is a mistake in InspectorProfilerAgent::enable(bool skipRecompile)
https://bugs.webkit.org/show_bug.cgi?id=97450

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-09-24
Reviewed by Yury Semikhatsky.

The "InspectorProfilerAgent::enable()" should invokes "PageScriptDebugServer" in
no-worker thread.

No new test case.

* inspector/InspectorProfilerAgent.cpp:
(WebCore::PageProfilerAgent::recompileScript):
(PageProfilerAgent):
(WebCore::WorkerProfilerAgent::recompileScript):
(WorkerProfilerAgent):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::enable):
* inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] TestRunner needs touch events support.
commit-queue@webkit.org [Tue, 25 Sep 2012 00:54:11 +0000 (00:54 +0000)]
[EFL][WK2] TestRunner needs touch events support.
https://bugs.webkit.org/show_bug.cgi?id=96465

Patch by Nikhil Bansal <n.bansal@samsung.com> on 2012-09-24
Reviewed by Kenneth Rohde Christiansen.

Tools:

Simulate touch events in WebkitTestRunner for touch related
layout tests. This patch uses ewk_view_feed_touch_event() to
generate touch events.

* WebKitTestRunner/EventSenderProxy.h:
(EventSenderProxy):
* WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR):
(WTR::setEvasModifiers):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::~EventSenderProxy):
(WTR::EventSenderProxy::sendTouchEvent):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchModifier):
(WTR::EventSenderProxy::touchStart):
(WTR::EventSenderProxy::touchMove):
(WTR::EventSenderProxy::touchEnd):
(WTR::EventSenderProxy::touchCancel):
(WTR::EventSenderProxy::clearTouchPoints):
(WTR::EventSenderProxy::releaseTouchPoint):
(WTR::EventSenderProxy::cancelTouchPoint):

LayoutTests:

Touch events support added in WebKitTestRunner for layout tests.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoValueToInt32 bool case does bad things to registers
fpizlo@apple.com [Tue, 25 Sep 2012 00:46:45 +0000 (00:46 +0000)]
ValueToInt32 bool case does bad things to registers
https://bugs.webkit.org/show_bug.cgi?id=97505
<rdar://problem/12356331>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueToInt32):

LayoutTests:

* fast/js/dfg-bool-to-int32-reuse-expected.txt: Added.
* fast/js/dfg-bool-to-int32-reuse.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-bool-to-int32-reuse.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd cloopDo instruction for debugging the llint C++ backend.
mark.lam@apple.com [Tue, 25 Sep 2012 00:38:51 +0000 (00:38 +0000)]
Add cloopDo instruction for debugging the llint C++ backend.
https://bugs.webkit.org/show_bug.cgi?id=97502.

Reviewed by Geoffrey Garen.

* offlineasm/cloop.rb:
* offlineasm/instructions.rb:
* offlineasm/parser.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove String::operator+=()
paroga@webkit.org [Tue, 25 Sep 2012 00:28:51 +0000 (00:28 +0000)]
Remove String::operator+=()
https://bugs.webkit.org/show_bug.cgi?id=96172

Reviewed by Benjamin Poulain.

Source/WebCore:

Replace the last usage with String::append() in Gtk.

* platform/gtk/GtkInputMethodFilter.cpp:
(WebCore::GtkInputMethodFilter::handleCommit):

Source/WTF:

* wtf/Platform.h:
* wtf/text/WTFString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSArray::putByIndex asserts with readonly property on prototype
fpizlo@apple.com [Tue, 25 Sep 2012 00:20:13 +0000 (00:20 +0000)]
JSArray::putByIndex asserts with readonly property on prototype
https://bugs.webkit.org/show_bug.cgi?id=97435
<rdar://problem/12357084>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Boy, there were some problems:

- putDirectIndex() should know that it can set the index quickly even if it's a hole and we're
  in SlowPut mode, since that's the whole point of PutDirect.

- We should have a fast path for putByIndex().

- The LiteralParser should not use push(), since that may throw if we're having a bad time.

* interpreter/Interpreter.cpp:
(JSC::eval):
* runtime/JSObject.h:
(JSC::JSObject::putByIndexInline):
(JSObject):
(JSC::JSObject::putDirectIndex):
* runtime/LiteralParser.cpp:
(JSC::::parse):

LayoutTests:

* fast/js/concat-while-having-a-bad-time.html: Added.
* fast/js/concat-while-having-a-bad-time-expected.txt: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/concat-while-having-a-bad-time.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Skip flaky http/tests/security/cookies/xmlhttprequest.html test on Windows.
roger_fong@apple.com [Tue, 25 Sep 2012 00:12:22 +0000 (00:12 +0000)]
Unreviewed. Skip flaky http/tests/security/cookies/xmlhttprequest.html test on Windows.
https://bugs.webkit.org/show_bug.cgi?id=95803

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] TestRunner does not support overridePreference with value "0"
commit-queue@webkit.org [Tue, 25 Sep 2012 00:05:03 +0000 (00:05 +0000)]
[WK2] TestRunner does not support overridePreference with value "0"
https://bugs.webkit.org/show_bug.cgi?id=97457

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-24
Reviewed by Alexey Proskuryakov.

Tools:

testRunner.overridePreference() was marked as taking a boolean
in argument in testRunner.idl even though the test cases are
passing strings to it. The current code works if the test
case wants to enable a setting and therefore passes "1" string.
However, if the test wants to disable a setting and passes "0"
string, the current code also evaluates this to true causing
certain test cases to fail.

The argument to testRunner.overridePreference() is now of string
type and a function has been added to convert the string passed
by the test to a boolean value.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::toBool):
(WTR):
(WTR::TestRunner::overridePreference):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):

LayoutTests:

Unskip fast/regions/css-regions-disabled.html test case for
WebKit2 now that WebKitTestRunner actually supports overriding
a boolean preference with "0" value (to disable it).

* platform/efl-wk2/TestExpectations:
* platform/gtk-wk2/TestExpectations:
* platform/mac-wk2/Skipped:
* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium][Mac] Remove loadFont from PlatformSupport
pilgrim@chromium.org [Mon, 24 Sep 2012 23:57:24 +0000 (23:57 +0000)]
[Chromium][Mac] Remove loadFont from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97360

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/graphics/chromium/CrossProcessFontLoading.mm:

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded a missing "if VALUE_PROFILER" around an access to ArrayProfile record.
mark.lam@apple.com [Mon, 24 Sep 2012 23:53:11 +0000 (23:53 +0000)]
Added a missing "if VALUE_PROFILER" around an access to ArrayProfile record.
https://bugs.webkit.org/show_bug.cgi?id=97496.

Reviewed by Filip Pizlo.

* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace 2 uses of updateLogicalHeight with computeLogicalHeight
tony@chromium.org [Mon, 24 Sep 2012 23:43:28 +0000 (23:43 +0000)]
Replace 2 uses of updateLogicalHeight with computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=97486

Reviewed by Ojan Vafai.

More work for bug 96804.  This is just a refactoring.

No new tests, behavior should be the same as before.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeLogicalHeight):
* rendering/RenderFlowThread.h:
* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::computeLogicalHeight):
(WebCore):
* rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInlined activation tear-off in the DFG
ggaren@apple.com [Mon, 24 Sep 2012 23:12:00 +0000 (23:12 +0000)]
Inlined activation tear-off in the DFG
https://bugs.webkit.org/show_bug.cgi?id=97487

Reviewed by Filip Pizlo.

* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h: Activation tear-off is always inlined now, so I
removed its out-of-line implementation.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Inlined the variable copy and update
of JSVariableObject::m_registers. This usually turns into < 10 instructions,
which is close to pure win as compared to the operation function call.

* runtime/JSActivation.h:
(JSActivation):
(JSC::JSActivation::registersOffset):
(JSC::JSActivation::tearOff):
(JSC::JSActivation::isTornOff):
(JSC):
(JSC::JSActivation::storageOffset):
(JSC::JSActivation::storage): Tiny bit of refactoring so the JIT can
share the pointer math helper functions we use internally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Mark http/tests/security/inactive-document-with-empty-security-origin...
roger_fong@apple.com [Mon, 24 Sep 2012 22:23:38 +0000 (22:23 +0000)]
Unreviewed. Mark http/tests/security/inactive-document-with-empty-security-origin.html while Geoff Garen
investigates in https://bugs.webkit.org/show_bug.cgi?id=95530 in order to get the bots green.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] ArrayBuffer code should not pass a negative length to SetIndexedPropertiesToExte...
kbr@google.com [Mon, 24 Sep 2012 22:18:04 +0000 (22:18 +0000)]
[V8] ArrayBuffer code should not pass a negative length to SetIndexedPropertiesToExternalArrayData()
https://bugs.webkit.org/show_bug.cgi?id=96703

Reviewed by Adam Barth.

Check length arguments that may be passed to SetIndexedPropertiesToExternalArrayData.

No tests because it is not guaranteed that buffers this large can actually be allocated.

* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSplit stylesheet related code out from Document
antti@apple.com [Mon, 24 Sep 2012 22:14:47 +0000 (22:14 +0000)]
Split stylesheet related code out from Document
https://bugs.webkit.org/show_bug.cgi?id=97353

Reviewed by Andreas Kling.

Document is big and unwieldy. The code related to tracking active stylesheets can be factored out.

The patch moves stylesheet upkeep, collection and invalidation code from Document to a separate
DocumentStyleSheetCollection class. There are no functional changes.

The usesLinkRules stylesheet feature bit and the related code is removed as no one was using it.

* WebCore.xcodeproj/project.pbxproj:
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::Features::Features):
(WebCore::StyleResolver::Features::add):
(WebCore::StyleResolver::Features::clear):
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:
(WebCore::StyleResolver::usesBeforeAfterRules):
(Features):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::recalcStyle):
(WebCore):
(WebCore::Document::createStyleResolver):
(WebCore::Document::seamlessParentUpdatedStylesheets):
(WebCore::Document::didRemoveAllPendingStylesheet):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::styleSheets):
(WebCore::Document::preferredStylesheetSet):
(WebCore::Document::selectedStylesheetSet):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::reportMemoryUsage):
(WebCore::Document::haveStylesheetsLoaded):
* dom/Document.h:
(WebCore):
(Document):
(WebCore::Document::styleSheetCollection):
(WebCore::Document::hasNodesWithPlaceholderStyle):
(WebCore::Document::setNeedsNotifyRemoveAllPendingStylesheet):
(WebCore::Document::inStyleRecalc):
* dom/DocumentStyleSheetCollection.cpp: Added.
(WebCore):
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::pageUserSheet):
(WebCore::DocumentStyleSheetCollection::clearPageUserSheet):
(WebCore::DocumentStyleSheetCollection::updatePageUserSheet):
(WebCore::DocumentStyleSheetCollection::pageGroupUserSheets):
(WebCore::DocumentStyleSheetCollection::clearPageGroupUserSheets):
(WebCore::DocumentStyleSheetCollection::updatePageGroupUserSheets):
(WebCore::DocumentStyleSheetCollection::addUserSheet):
(WebCore::DocumentStyleSheetCollection::removePendingSheet):
(WebCore::DocumentStyleSheetCollection::addStyleSheetCandidateNode):
(WebCore::DocumentStyleSheetCollection::removeStyleSheetCandidateNode):
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::testAddedStyleSheetRequiresStyleRecalc):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::styleSheetsUseRemUnits):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):
* dom/DocumentStyleSheetCollection.h: Added.
(WebCore):
(DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::authorStyleSheets):
(WebCore::DocumentStyleSheetCollection::documentUserSheets):
(WebCore::DocumentStyleSheetCollection::needsUpdateActiveStylesheetsOnStyleRecalc):
(WebCore::DocumentStyleSheetCollection::preferredStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::selectedStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::setPreferredStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::setSelectedStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::addPendingSheet):
(WebCore::DocumentStyleSheetCollection::hasPendingSheets):
(WebCore::DocumentStyleSheetCollection::usesSiblingRules):
(WebCore::DocumentStyleSheetCollection::setUsesSiblingRulesOverride):
(WebCore::DocumentStyleSheetCollection::usesFirstLineRules):
(WebCore::DocumentStyleSheetCollection::usesFirstLetterRules):
(WebCore::DocumentStyleSheetCollection::setUsesFirstLetterRules):
(WebCore::DocumentStyleSheetCollection::usesBeforeAfterRules):
(WebCore::DocumentStyleSheetCollection::setUsesBeforeAfterRulesOverride):
(WebCore::DocumentStyleSheetCollection::usesRemUnits):
(WebCore::DocumentStyleSheetCollection::setUsesRemUnit):
* dom/Element.cpp:
(WebCore::Element::recalcStyle):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::~ProcessingInstruction):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):
* dom/StyleElement.cpp:
(WebCore::StyleElement::insertedIntoDocument):
(WebCore::StyleElement::removedFromDocument):
(WebCore::StyleElement::clearDocumentData):
(WebCore::StyleElement::createSheet):
(WebCore::StyleElement::sheetLoaded):
(WebCore::StyleElement::startLoadingDynamicSheet):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):
* html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::insertedInto):
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
* mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::insertedInto):
* page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
* page/PageGroup.cpp:
(WebCore::PageGroup::resetUserStyleCacheInAllFrames):
* rendering/RenderBR.cpp:
(WebCore::RenderBR::lineHeight):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::updateFirstLetter):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::lineHeight):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::uncachedFirstLineStyle):
(WebCore::RenderObject::firstLineStyleSlowCase):
* rendering/RenderObject.h:
(WebCore::RenderObject::firstLineStyle):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::updateBeforeAndAfterContent):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. http/tests/security/sandboxed-iframe-form-top.html fails on Windows.
roger_fong@apple.com [Mon, 24 Sep 2012 22:06:29 +0000 (22:06 +0000)]
Unreviewed. http/tests/security/sandboxed-iframe-form-top.html fails on Windows.
https://bugs.webkit.org/show_bug.cgi?id=97485

This test actually "passes" but is producing wrong output in whichever test proceeds it, thus causing that test to fail.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Reverting implementation for 407 error pages
commit-queue@webkit.org [Mon, 24 Sep 2012 21:59:03 +0000 (21:59 +0000)]
[BlackBerry] Reverting implementation for 407 error pages
https://bugs.webkit.org/show_bug.cgi?id=97455

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-24
Reviewed by Rob Buis.

Source/WebCore:

Revert "[BlackBerry] Reverting implementation for 407 error pages"
This reverts commit fda0a1b6ac40c06c03bb6293b4a7d7353c3ca238.

This revert also reverts commit 0cffe01961fb80204138505bcec29a83818efb73
due to dependency issues.

* PlatformBlackBerry.cmake:
* platform/blackberry/AuthenticationChallengeManager.cpp: Removed.
* platform/blackberry/AuthenticationChallengeManager.h:
* platform/blackberry/PageClientBlackBerry.h:
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::notifyChallengeResult):
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):

Source/WebKit/blackberry:

Revert "[BlackBerry] Really fix bug 95488 that user can get the
authentication challenge dialog while the other tab has focus."
https://bugs.webkit.org/show_bug.cgi?id=97348

This reverts commit 0cffe01961fb80204138505bcec29a83818efb73.

* Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
(BlackBerry::WebKit::WebPage::setVisible):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[REGRESSION] Layout Test webaudio/biquad-getFrequencyResponse.html is failing
crogers@google.com [Mon, 24 Sep 2012 21:55:42 +0000 (21:55 +0000)]
[REGRESSION] Layout Test webaudio/biquad-getFrequencyResponse.html is failing
https://bugs.webkit.org/show_bug.cgi?id=97439

Reviewed by Kenneth Russell.

Fixes uninitialized member variable.

This should fix flaky failing test: webaudio/biquad-getFrequencyResponse.html

* Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::BiquadProcessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNarrow Chromium TestExpectations for some hidpi failures to be Linux-only.
dpranke@chromium.org [Mon, 24 Sep 2012 21:52:06 +0000 (21:52 +0000)]
Narrow Chromium TestExpectations for some hidpi failures to be Linux-only.
crbug.com/150682

Unreviewed, expectations change.

Also remove a no-longer-failing Mac expectation for
compositing/overflow/overflow-scaled-descendant-overlapping.html

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoflex-grow should be 1 when omitted from flex shorthand
tony@chromium.org [Mon, 24 Sep 2012 21:35:13 +0000 (21:35 +0000)]
flex-grow should be 1 when omitted from flex shorthand
https://bugs.webkit.org/show_bug.cgi?id=97480

Reviewed by Ojan Vafai.

Source/WebCore:

We were using 0, based on an outdated version of the spec.

Tests: css3/flexbox/flex-property-parsing.html
       css3/flexbox/flex-algorithm.html: New test case.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFlex):

LayoutTests:

Update tests due to default CSS value changes.

* css3/flexbox/flex-algorithm-expected.txt:
* css3/flexbox/flex-algorithm.html: Add test case using -webkit-flex: auto.
* css3/flexbox/flex-property-parsing-expected.txt:
* css3/flexbox/flex-property-parsing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd support for query encoding to WTFURL
benjamin@webkit.org [Mon, 24 Sep 2012 21:32:45 +0000 (21:32 +0000)]
Add support for query encoding to WTFURL
https://bugs.webkit.org/show_bug.cgi?id=97422

Reviewed by Adam Barth.

Source/WebCore:

Add the Charset conversion on WebCore side.

* platform/KURLWTFURL.cpp:
(WebCore::KURL::KURL):
(CharsetConverter):
(WebCore::CharsetConverter::CharsetConverter):
* platform/mac/KURLMac.mm:
(WebCore::KURL::KURL):

Source/WTF:

Expose character conversion through the new abstract class URLQueryCharsetConverter.
URLQueryCharsetConverter is implemented by WebCore to expose the TextEncoding classes.

Unfortunatelly that forces us to bring over URLBuffer in the public API. We may be able
to mitigate that later when moving WTFURL to more templates.

The change fixes 2 of the URL layout tests.

* WTF.xcodeproj/project.pbxproj:
* wtf/url/api/ParsedURL.cpp:
(WTF::ParsedURL::ParsedURL):
* wtf/url/api/ParsedURL.h:
(ParsedURL):
ParsedURL was using the same constructor for ParsedURLString, and URL without a base.
That was a mistake on my part, I did not intend that, fixed it now :)

* wtf/url/api/URLBuffer.h: Renamed from Source/WTF/wtf/url/src/URLBuffer.h.
(URLBuffer):
(WTF::URLBuffer::URLBuffer):
(WTF::URLBuffer::~URLBuffer):
(WTF::URLBuffer::at):
(WTF::URLBuffer::set):
(WTF::URLBuffer::capacity):
(WTF::URLBuffer::length):
(WTF::URLBuffer::data):
(WTF::URLBuffer::setLength):
(WTF::URLBuffer::append):
(WTF::URLBuffer::grow):
* wtf/url/api/URLQueryCharsetConverter.h: Added.
(URLQueryCharsetConverter):
(WTF::URLQueryCharsetConverter::URLQueryCharsetConverter):
(WTF::URLQueryCharsetConverter::~URLQueryCharsetConverter):
* wtf/url/src/URLCanon.h:
(URLCanonicalizer):
* wtf/url/src/URLCanonFilesystemurl.cpp:
(WTF::URLCanonicalizer::canonicalizeFileSystemURL):
(WTF::URLCanonicalizer::ReplaceFileSystemURL):
* wtf/url/src/URLCanonFileurl.cpp:
(WTF::URLCanonicalizer::CanonicalizeFileURL):
(WTF::URLCanonicalizer::ReplaceFileURL):
* wtf/url/src/URLCanonInternal.h:
(URLCanonicalizer):
* wtf/url/src/URLCanonQuery.cpp:
(WTF::URLCanonicalizer::CanonicalizeQuery):
(WTF::URLCanonicalizer::ConvertUTF16ToQueryEncoding):
* wtf/url/src/URLCanonRelative.cpp:
(WTF::URLCanonicalizer::resolveRelativeURL):
* wtf/url/src/URLCanonStdURL.cpp:
(WTF::URLCanonicalizer::CanonicalizeStandardURL):
(WTF::URLCanonicalizer::ReplaceStandardURL):
* wtf/url/src/URLUtil.cpp:
(URLUtilities):
(WTF::URLUtilities::canonicalize):
(WTF::URLUtilities::resolveRelative):
(WTF::URLUtilities::ReplaceComponents):
* wtf/url/src/URLUtil.h:
(URLUtilities):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129413 268f45cc-cd09-0410-ab3c-d52691b4dbfc