WebKit-https.git
7 years agoAutoTableLayout applies min-width redundantly with RenderTable
ojan@chromium.org [Thu, 21 Feb 2013 03:26:10 +0000 (03:26 +0000)]
AutoTableLayout applies min-width redundantly with RenderTable
https://bugs.webkit.org/show_bug.cgi?id=110426

Reviewed by Emil A Eklund.

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
This code used to do something, but has since been superceded by
code in RenderTable::computePreferredLogicalWidths.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable CANVAS_PATH flag
krit@webkit.org [Thu, 21 Feb 2013 03:22:31 +0000 (03:22 +0000)]
Enable CANVAS_PATH flag
https://bugs.webkit.org/show_bug.cgi?id=108508

Source/WebCore:

Uneviewed attempt to fix Qt minimal build.

* html/canvas/DOMPath.h:
(WebCore::DOMPath::DOMPath):

LayoutTests:

Reviewed by Simon Fraser.

Unreviewed rebaseline after landing patch.

* fast/dom/constructed-objects-prototypes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG inlines Resolves that it doesn't know how to handle correctly
fpizlo@apple.com [Thu, 21 Feb 2013 02:43:36 +0000 (02:43 +0000)]
DFG inlines Resolves that it doesn't know how to handle correctly
https://bugs.webkit.org/show_bug.cgi?id=110405

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Don't try to be clever: if there's a failing resolve, we can't inline it, period.

* dfg/DFGCapabilities.h:
(JSC::DFG::canInlineResolveOperations):
(JSC::DFG::canInlineOpcode):

LayoutTests:

Reviewed by Geoffrey Garen.

* fast/js/dfg-inline-resolve-expected.txt: Added.
* fast/js/dfg-inline-resolve.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable window occlusion notifications for App Store on Mac.
commit-queue@webkit.org [Thu, 21 Feb 2013 02:41:56 +0000 (02:41 +0000)]
Disable window occlusion notifications for App Store on Mac.
https://bugs.webkit.org/show_bug.cgi?id=110417

Patch by Kiran Muppala <cmuppala@apple.com> on 2013-02-20
Reviewed by Simon Fraser.

Temporary fix to workaround issues with window occlusion notifications
in App Store.

* UIProcess/API/mac/WKView.mm:
(+[WKView _registerWindowOcclusionNotificationHandlers]): Return early
if the main bundle identifier matches that of App Store.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago\2013-02-20 Mark Lam <mark.lam@apple.com>
mark.lam@apple.com [Thu, 21 Feb 2013 02:36:26 +0000 (02:36 +0000)]
\2013-02-20  Mark Lam  <mark.lam@apple.com>

Rename DatabaseBackendAsync to DatabaseBackend.
https://bugs.webkit.org/show_bug.cgi?id=110422.

Reviewed by Geoffrey Garen.

This is a purely cosmetic change to make the naming consistent with
the front-end Database.

No new tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/webdatabase/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):
* Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::from):
(WebCore::Database::backend):
* Modules/webdatabase/Database.h:
* Modules/webdatabase/DatabaseBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackendAsync.cpp.
(WebCore::DatabaseBackend::DatabaseBackend):
(WebCore::DatabaseBackend::openAndVerifyVersion):
(WebCore::DatabaseBackend::performOpenAndVerify):
(WebCore::DatabaseBackend::close):
(WebCore::DatabaseBackend::runTransaction):
(WebCore::DatabaseBackend::inProgressTransactionCompleted):
(WebCore::DatabaseBackend::scheduleTransaction):
(WebCore::DatabaseBackend::scheduleTransactionStep):
(WebCore::DatabaseBackend::transactionClient):
(WebCore::DatabaseBackend::transactionCoordinator):
* Modules/webdatabase/DatabaseBackend.h: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackendAsync.h.
* Modules/webdatabase/DatabaseBackendAsync.cpp: Removed.
* Modules/webdatabase/DatabaseBackendAsync.h: Removed.
* Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::DatabaseBackendBase::~DatabaseBackendBase):
* Modules/webdatabase/DatabaseManager.cpp:
* Modules/webdatabase/DatabaseServer.cpp:
* Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseTask::DatabaseTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::~DatabaseTransactionTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::debugTaskName):
* Modules/webdatabase/DatabaseTask.h:
(WebCore::DatabaseTask::database):
(DatabaseTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::create):
(DatabaseBackend::DatabaseOpenTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::create):
(DatabaseBackend::DatabaseCloseTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::create):
(DatabaseBackend::DatabaseTableNamesTask):
* Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::recordDatabaseOpen):
(WebCore::DatabaseThread::recordDatabaseClosed):
(WebCore::SameDatabasePredicate::SameDatabasePredicate):
(SameDatabasePredicate):
(WebCore::DatabaseThread::unscheduleDatabaseTasks):
* Modules/webdatabase/DatabaseThread.h:
* Modules/webdatabase/SQLStatementBackend.cpp:
(WebCore::SQLStatementBackend::execute):
(WebCore::SQLStatementBackend::setDatabaseDeletedError):
(WebCore::SQLStatementBackend::setVersionMismatchedError):
(WebCore::SQLStatementBackend::setFailureDueToQuota):
* Modules/webdatabase/SQLStatementBackend.h:
* Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
* Modules/webdatabase/SQLTransactionBackend.h:
(WebCore::SQLTransactionBackend::database):
* Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::getDatabaseIdentifier):
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpstream SharedTimerIOS.mm
ddkilzer@apple.com [Thu, 21 Feb 2013 02:25:54 +0000 (02:25 +0000)]
Upstream SharedTimerIOS.mm
<http://webkit.org/b/110161>

Reviewed by Benjamin Poulain.

* Configurations/WebCore.xcconfig:
(EXCLUDED_SOURCE_FILE_NAMES_iphoneos): Add SharedTimerMac.mm.
* WebCore.xcodeproj/project.pbxproj: Add SharedTimerIOS.mm.
* platform/ios/SharedTimerIOS.mm: Add.
(WebCore):
(-[WebCoreResumeNotifierIOS init]):
(-[WebCoreResumeNotifierIOS dealloc]):
(-[WebCoreResumeNotifierIOS didWake]):
(WebCore::setSharedTimerFiredFunction):
(WebCore::timerFired):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeculative fix for EFL and Windows compilers not realizing
ojan@chromium.org [Thu, 21 Feb 2013 02:24:46 +0000 (02:24 +0000)]
Speculative fix for EFL and Windows compilers not realizing
that all possible cases have a return value from this switch.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert residual-style.html test to a reftest (and fix typos)
commit-queue@webkit.org [Thu, 21 Feb 2013 02:20:08 +0000 (02:20 +0000)]
Convert residual-style.html test to a reftest (and fix typos)
https://bugs.webkit.org/show_bug.cgi?id=109981

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-20
Reviewed by Darin Adler.

* fast/flexbox/box-orient-button.html: clsas->class
* fast/flexbox/resources/box-orient-button.js: DTR->DRT
* fast/invalid/residual-style-expected.html: Added. New reftest
version. Note that some lines are red, which is
https://bugs.webkit.org/show_bug.cgi?id=109984
* fast/invalid/residual-style.html: Add missing semicolon in <style>.
Also close a few more <font> tags, so that the descriptive text is
in black as it should be.

* platform/chromium-android/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-android/fast/invalid/residual-style-expected.txt: Removed.
* platform/chromium-linux/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-linux/fast/invalid/residual-style-expected.txt: Removed.
* platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
* platform/chromium-win/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-win/fast/invalid/residual-style-expected.txt: Removed.
* platform/efl/fast/invalid/residual-style-expected.png: Removed.
* platform/efl/fast/invalid/residual-style-expected.txt: Removed.
* platform/gtk/fast/invalid/residual-style-expected.png: Removed.
* platform/gtk/fast/invalid/residual-style-expected.txt: Removed.
* platform/mac/fast/invalid/residual-style-expected.png: Removed.
* platform/mac/fast/invalid/residual-style-expected.txt: Removed.
Removed old expectation files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
jamesr@google.com [Thu, 21 Feb 2013 02:09:53 +0000 (02:09 +0000)]
[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
https://bugs.webkit.org/show_bug.cgi?id=109634

Reviewed by Adrienne Walker.

Source/Platform:

* chromium/public/WebUnitTestSupport.h:

Tools:

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createOutputSurface):
(WebViewHost::initializeLayerTreeView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] Fix overflow computation for column blocks.
hyatt@apple.com [Thu, 21 Feb 2013 02:02:24 +0000 (02:02 +0000)]
[New Multicolumn] Fix overflow computation for column blocks.
https://bugs.webkit.org/show_bug.cgi?id=110392.

Reviewed by Simon Fraser.

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::addOverflowFromChild):
Exclude in-flow RenderFlowThreads from overflow propagation.

* rendering/RenderMultiColumnSet.h:
* rendering/RenderRegion.h:
(WebCore::RenderRegion::shouldHaveAutoLogicalHeight):
 * rendering/RenderRegionSet.h:
(RenderRegionSet):
Override shouldHaveAutoLogicalHeight to always be false
for region sets and for columns. Eventually we're going to try
to leverage this code to do column balancing, and that's why
RenderMultiColumnSet has a unique override.

LayoutTests:

* fast/multicol/newmulticol/column-rules-fixed-height-expected.html:
* fast/multicol/newmulticol/column-rules-fixed-height.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrinting WebGL canvases in Chrome uses stale data after first print
commit-queue@webkit.org [Thu, 21 Feb 2013 01:35:01 +0000 (01:35 +0000)]
Printing WebGL canvases in Chrome uses stale data after first print
https://bugs.webkit.org/show_bug.cgi?id=110003

Patch by Brandon Jones <bajones@google.com> on 2013-02-20
Reviewed by Kenneth Russell.

Unable to validate printed content automatically. No regression in existing WebGL tests.

 * html/canvas/WebGLRenderingContext.cpp:
 (WebCore):
 (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<https://webkit.org/b/110410> Specify the plug-in process / service entitlements...
mrowe@apple.com [Thu, 21 Feb 2013 01:29:07 +0000 (01:29 +0000)]
<https://webkit.org/b/110410> Specify the plug-in process / service entitlements via the Xcode configuration.

This is the modern mechanism for applying entitlements to production builds,
and it simplifies the maintenance of entitlements going forward. It also allows
us to fix the new XPC PluginServices to have the same entitlements as PluginProcess.

Reviewed by Alexey Proskuryakov.

* Configurations/Base.xcconfig: Ad-hoc sign all WebKit2 components.
* Configurations/PluginProcess.xcconfig: Specify the entitlements to use.
* Configurations/PluginService.32.xcconfig: Ditto.
* Configurations/PluginService.64.xcconfig: Ditto.
* Configurations/PluginService.Development.xcconfig: Ditto.
* Configurations/PluginService.entitlements: Renamed from Source/WebKit2/PluginProcess/mac/PluginProcess.entitlements.
Move the entitlements in to the Configurations directory to make them easier to find.
* PluginProcess/mac/add-entitlements.sh: Removed. In my testing the dependency issue mentioned
in the script is not an issue with current versions of Xcode. If we see it again we can come
up with a workaround that doesn't involve performing the signing via a script phase.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<https://webkit.org/b/110409> Remove duplication between 32- and 64-bit PluginService...
mrowe@apple.com [Thu, 21 Feb 2013 01:29:03 +0000 (01:29 +0000)]
<https://webkit.org/b/110409> Remove duplication between 32- and 64-bit PluginService plists.

Reviewed by Dan Bernstein.

The only difference between the plists was the CFBundleIdentifier. Since the values are the
same as the product name, we can just use the value of the PRODUCT_NAME configuration setting.

* Configurations/PluginService.32.xcconfig:
* Configurations/PluginService.64.xcconfig:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist: Renamed from Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIncorrect rendering for flex boxes with percentage height in a table cell
commit-queue@webkit.org [Thu, 21 Feb 2013 01:22:43 +0000 (01:22 +0000)]
Incorrect rendering for flex boxes with percentage height in a table cell
https://bugs.webkit.org/show_bug.cgi?id=110389

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-20
Reviewed by Tony Chang.

Source/WebCore:

Tests: css3/flexbox/flex-percentage-height-in-table-standards-mode.html
       css3/flexbox/flex-percentage-height-in-table.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
Always update the logical height of the flex box, not just when it is
auto. If necessary, the later updateLogicalHeight() call will adjust
it.

LayoutTests:

* css3/flexbox/flex-percentage-height-in-table-expected.html: Added.
* css3/flexbox/flex-percentage-height-in-table-standards-mode-expected.html: Added.
* css3/flexbox/flex-percentage-height-in-table-standards-mode.html: Added.
* css3/flexbox/flex-percentage-height-in-table.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAccount for transform in SVG background images
pdr@google.com [Thu, 21 Feb 2013 01:19:25 +0000 (01:19 +0000)]
Account for transform in SVG background images
https://bugs.webkit.org/show_bug.cgi?id=110295

Reviewed by Dirk Schulze.

Source/WebCore:

Tiled SVG background images are rendererd by drawing the SVG content into a temporary
image buffer, then stamping out a tiled pattern using this buffer. Previously the
image buffer did not account for CSS transforms which could result in pixelated backgrounds.

This patch takes advantage of the context's transform when sizing the temporary tiling
image buffer. Because the context's transform also includes scale, this patch simplifies
the SVG image code to no longer track scale.

Test: svg/as-background-image/svg-transformed-background.html

* loader/cache/CachedImage.cpp:
(WebCore):
(WebCore::CachedImage::imageForRenderer):

    CachedImage::lookupOrCreateImageForRenderer no longer creates images so it has been
    refactored into just "imageForRenderer". Previously there were two versions of
    lookupOrCreateImageForRenderer; these have been folded into imageForRenderer.

* loader/cache/CachedImage.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):

    To create the temporary tiling image buffer, the final size in screen coordinates is
    needed. This is now computed using the current context's CTM. Because the CTM
    already includes the page scale, all page scale tracking can be removed.

    The adjustments to srcRect and the pattern transform are the same as before, just
    refactored to use imageBufferScale which has x and y components.

* svg/graphics/SVGImage.h:
* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::setContainerSizeForRenderer):

    Because the page scale needed to be cached between calls to
    setContainerSizeForRenderer, this function was written to modify an existing cache
    entry. Because the page scale no longer needs to be tracked, this code has been
    simplified to re-write any existing cache entry.

(WebCore::SVGImageCache::imageSizeForRenderer):

    This function has been simplified by calling SVGImageForContainer::size() instead
    of computing this value manually. The value returned remains the same, containing
    the container size multiplied by zoom.

(WebCore::SVGImageCache::imageForRenderer):

    Previously we set the page scale on every call to imageForRenderer. Because page scale
    no longer needs to be tracked, this function has been simplified to simply return
    the cached SVGImageForContainer.

* svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern):
* svg/graphics/SVGImageForContainer.h:
(WebCore::SVGImageForContainer::create):
(WebCore::SVGImageForContainer::SVGImageForContainer):
(SVGImageForContainer):

LayoutTests:

* svg/as-background-image/svg-transformed-background-expected.html: Added.
* svg/as-background-image/svg-transformed-background.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in com.apple.WebKit2.WebProcessService at com.apple.avfoundation: __73-[AVAsset...
jer.noble@apple.com [Thu, 21 Feb 2013 01:09:37 +0000 (01:09 +0000)]
Crash in com.apple.WebKit2.WebProcessService at com.apple.avfoundation: __73-[AVAssetResourceLoader _attemptDelegateHandlingOfRequestWithDictionary:]_block_invoke + 51
https://bugs.webkit.org/show_bug.cgi?id=110385

Reviewed by Eric Carlson.

Ensure AVFoundation does not attempt to message a dead object by explicitly disassociating
the AVAssetResourceLoaderDelegate on MediaPlayerPrivateAVFoundationObjC destruction.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPositioned, replaced elements with intrinsic width keywords compute the wrong width
ojan@chromium.org [Thu, 21 Feb 2013 01:07:56 +0000 (01:07 +0000)]
Positioned, replaced elements with intrinsic width keywords compute the wrong width
https://bugs.webkit.org/show_bug.cgi?id=110393

Reviewed by Emil A Eklund.

Source/WebCore:

Test: fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
Add the intrinsic size keywords to the switch. Confusingly, we have to
subtract the border and padding since the callers expect the content width.

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
Don't do the intrinsic ratio calculation if the width is an
intrinsic width keyword, as per, http://dev.w3.org/csswg/css3-sizing/#replaced-intrinsic.

(WebCore::RenderReplaced::computeIntrinsicLogicalWidths):
(WebCore::RenderReplaced::computePreferredLogicalWidths):
The old code was trying to apply the intrinsic ratio calculation to
the intrinsic width, which is wrong per spec.

LayoutTests:

* fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes-expected.txt: Added.
* fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLevelDB: Remove excess vector copy
alecflett@chromium.org [Thu, 21 Feb 2013 00:49:57 +0000 (00:49 +0000)]
LevelDB: Remove excess vector copy
https://bugs.webkit.org/show_bug.cgi?id=110399

Reviewed by Tony Chang.

Remove an extra copy introduced by the makeVector function.

No new tests, this is covered by existing tests.

* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::safeGet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoZoomed, slow-scrolling pages keep recreating tiles when scrolled
simon.fraser@apple.com [Thu, 21 Feb 2013 00:48:45 +0000 (00:48 +0000)]
Zoomed, slow-scrolling pages keep recreating tiles when scrolled
https://bugs.webkit.org/show_bug.cgi?id=110379

Source/WebCore:

Reviewed by Tim Horton.

On slow-scrolling pages the TileCache makes the tiles the size of
the visible rect to minimize per-tile painting overhead. If the size
of that rect changes, the TileCache re-creates all the tiles.

This was a problem whem zoomed, because mapping the visible rect
through the scale transform and then rounding it would cause the
size to keep changing, causing lots of tile re-creation.

Fix by carrying the visibleRect around as a FloatRect, and doing
the same for the exposedRect. We then only expand to integers
when computing the tile size. This also fixes an issue where we could
sometimes make extra tiles because of fractional bits of tiles at the edges,
as shown by the test result change.

* platform/graphics/TiledBacking.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateVisibleRect):
* platform/graphics/ca/mac/TileCache.h:
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setVisibleRect):
(WebCore::TileCache::setExposedRect):
(WebCore::TileCache::prepopulateRect):
(WebCore::TileCache::computeTileCoverageRect):
(WebCore::TileCache::tileSizeForCoverageRect):
(WebCore::TileCache::blankPixelCountForTiles):
(WebCore::TileCache::revalidateTiles):
(WebCore::TileCache::ensureTilesForRect):
* platform/graphics/ca/mac/WebTileLayer.mm:
(-[WebTileLayer logFilledFreshTile]):

Source/WebKit2:

Reviewed by Tim Horton.

Make the visible rect and exposed rects passed through
the drawing area to the tile cache FloatRects instead of IntRects.

* UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView enableFrameSizeUpdates]):
(-[WKView setMinimumWidthForAutoLayout:]):
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::viewExposedRectChanged):
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setExposedRect):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewExposedRectChanged):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):

LayoutTests:

Reviewed by Tim Horton.

This test now just has one tile, rather than four. There is an apparent issue
with the integral tile cache coverage rect being smaller than the visible rect.
This is caused by rounding when dumping the tile coverage rect.

* platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Remove references to SAFARI_THEME from Windows Solution.
roger_fong@apple.com [Thu, 21 Feb 2013 00:45:36 +0000 (00:45 +0000)]
Unreviewed. Remove references to SAFARI_THEME from Windows Solution.
<rdar://problem/13258710>

* config.h:
* page/Settings.cpp:
* page/Settings.h:
* platform/win/ScrollbarThemeWin.cpp:
* rendering/RenderThemeWin.cpp:
* WebKitClassFactory.cpp:
* WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Implement the auto-placement algorithm without grid growth
jchaffraix@webkit.org [Thu, 21 Feb 2013 00:33:49 +0000 (00:33 +0000)]
[CSS Grid Layout] Implement the auto-placement algorithm without grid growth
https://bugs.webkit.org/show_bug.cgi?id=110277

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-grid-layout/grid-item-addition-auto-placement-update.html
       fast/css-grid-layout/grid-item-removal-auto-placement-update.html
       fast/css-grid-layout/grid-auto-flow-resolution.html (extended to cover more cases)

This change implements most of the auto-placement algorithm per
http://dev.w3.org/csswg/css3-grid-layout/#auto-placement-algo

To limit the size of the code change, it doesn't implement growing the grid if there
are no empty grid areas. If we don't find any empty grid areas, we just insert in the first
one, like what grid-auto-flow: none would do (which explains the test failures).

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridIterator::nextEmptyGridArea):
Added this function to return the GridCoordinate of the next empty grid area along
the iterator's direction.

(WebCore::RenderGrid::placeItemsOnGrid):
Split this function into the different steps below. For efficiency, collect the auto vs specified
major axis grid items in different Vectors.

(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
Added this function that implements part of step 1 of the algorithm (the grid items without
auto row / column are already handled in placeItemsOnGrid).

(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid):
Added this function that iterates over the auto grid items and call placeAutoMajorAxisItemOnGrid.

(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
Added this method to handle the step 4 of the algorithm. Based on the minor axis's position,
it either walks along the major axis once or several times until it finds an empty grid area
for the grid item.

(WebCore::RenderGrid::autoPlacementMajorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMinorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMajorAxisDirection):
(WebCore::RenderGrid::autoPlacementMinorAxisDirection):
Added these helper functions that return minor / major axis positions & direction.

* rendering/RenderGrid.h:
Added the previous new RenderGrid functions.

LayoutTests:

* fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
* fast/css-grid-layout/grid-auto-flow-resolution.html:

* fast/css-grid-layout/grid-item-addition-auto-placement-update-expected.txt: Added.
* fast/css-grid-layout/grid-item-addition-auto-placement-update.html: Added.
* fast/css-grid-layout/grid-item-removal-auto-placement-update-expected.txt: Added.
* fast/css-grid-layout/grid-item-removal-auto-placement-update.html: Added.
The current algorithm doesn't grow the grid but falls back to inserting the element at
position (1, 1). The failures in these tests are due to that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAccept 'allowfullscreen' in addition to 'webkitallowfullscreen'.
scheib@chromium.org [Thu, 21 Feb 2013 00:32:26 +0000 (00:32 +0000)]
Accept 'allowfullscreen' in addition to 'webkitallowfullscreen'.
https://bugs.webkit.org/show_bug.cgi?id=110374

Reviewed by Adam Barth.

Source/WebCore:

The fullscreen API also includes a new HTML attribute for iframes
which permits its use. That attribute, 'allowfullcreen' is now
included in the HTML specification [1] and is stable enough
to remove the webkit prefix.

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-allowfullscreen

Tests: fullscreen/full-screen-enabled-prefixed.html
       fullscreen/full-screen-iframe-allowed-prefixed.html
       fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute.html

* dom/Document.cpp:
(WebCore::isAttributeOnAllOwners):
(WebCore::Document::fullScreenIsAllowedForElement):
(WebCore::Document::webkitFullscreenEnabled):
* html/HTMLAttributeNames.in:

LayoutTests:

Two previous tests duplicated to preserve testing webkitallowfullscreen
and then modified to test allowfullscreen.

A new test 'full-screen-iframe-with-mixed-allow-webkitallow-attribute.html'
added to test a mixed nesting of iframs with both allowfullscreen and
webkitallowfullscreen.

* fullscreen/full-screen-enabled-prefixed-expected.txt: Added.
* fullscreen/full-screen-enabled-prefixed.html: Copied from LayoutTests/fullscreen/full-screen-enabled.html.
* fullscreen/full-screen-enabled.html:
* fullscreen/full-screen-iframe-allowed-prefixed-expected.txt: Added.
* fullscreen/full-screen-iframe-allowed-prefixed.html: Copied from LayoutTests/fullscreen/full-screen-iframe-allowed.html.
* fullscreen/full-screen-iframe-allowed.html:
* fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute-expected.txt:
* fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute.html: Added.
* fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe1.html: Added.
* fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Re-enable 3D CSS transforms when using build-webkit
commit-queue@webkit.org [Thu, 21 Feb 2013 00:31:58 +0000 (00:31 +0000)]
[GTK] Re-enable 3D CSS transforms when using build-webkit
https://bugs.webkit.org/show_bug.cgi?id=110402

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-20
Reviewed by Xan Lopez.

* Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default
when building WebKitGTK+.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet VS2010 Solution B&I ready.
roger_fong@apple.com [Thu, 21 Feb 2013 00:07:29 +0000 (00:07 +0000)]
Get VS2010 Solution B&I ready.
<rdar://problem/1322988>

Rubberstamped by Timothy Horton.

Add Production configuration.
Add a submit solutions with a DebugSuffix configuration.
Modify B&I make files as necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[v8] Fix an erroneous WrapperGrouper call in preparation for refactoring
adamk@chromium.org [Thu, 21 Feb 2013 00:00:33 +0000 (00:00 +0000)]
[v8] Fix an erroneous WrapperGrouper call in preparation for refactoring
https://bugs.webkit.org/show_bug.cgi?id=110396

Reviewed by Kentaro Hara.

This is in preparation for a refactor to expose a simplified
WrapperGrouper interface to V8 wrapper classes enabling them to
specify multiple roots per wrapper object.

* bindings/v8/V8GCController.cpp: Since MutationObservers are not Nodes, the correct call here is addObjectToGroup, as it is for all other non-Node wrappers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLine layout (but not pref widths) double-counts word spacing when between inlines
leviw@chromium.org [Wed, 20 Feb 2013 23:44:21 +0000 (23:44 +0000)]
Line layout (but not pref widths) double-counts word spacing when between inlines
https://bugs.webkit.org/show_bug.cgi?id=110381

Reviewed by Emil A Eklund.

Source/WebCore:

When a word break with a space occurs between inlines and word-spacing is non-zero,
line layout incorrectly committed the word-spacing value to the line twice, causing
wrapping in inline-blocks. To fix this, clear the word-spacing value when between
words and ignoring spaces, as we will already have added the word-spacing to the
line.

Test: fast/text/word-space-between-inlines.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

* fast/text/word-space-between-inlines-expected.html: Added.
* fast/text/word-space-between-inlines.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Check offset for initialized value
nghanavatian@rim.com [Wed, 20 Feb 2013 23:31:31 +0000 (23:31 +0000)]
[BlackBerry] Check offset for initialized value
https://bugs.webkit.org/show_bug.cgi?id=110390

Reviewed by Rob Buis.

Instead of checking isEmpty, which checks for either point being <= 0, we want to explicitly check
for the initialized value of (-1, -1). This would be set in redrawSpellCheckDialogIfRequired, and
triggers the restore from cache in requestSpellingCheckingOptions.

Internally reviewed by Gen Mak.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Crash in WebCore::FrameLoader::checkCompleted()
japhet@chromium.org [Wed, 20 Feb 2013 23:13:53 +0000 (23:13 +0000)]
Source/WebCore: Crash in WebCore::FrameLoader::checkCompleted()
https://bugs.webkit.org/show_bug.cgi?id=110237

Reviewed by Abhishek Arya.

Test: http/tests/misc/delete-frame-during-readystatechange.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted): Protect before setReadyState() is called.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=110237

Reviewed by Abhishek Arya.

* http/tests/misc/delete-frame-during-readystatechange-expected.txt: Added.
* http/tests/misc/delete-frame-during-readystatechange.html: Added.
* http/tests/misc/resources/delete-frame-during-readystatechange-frame.html: Added.
* http/tests/misc/resources/empty.ogv: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Limit LevelDB's max open files
dgrogan@chromium.org [Wed, 20 Feb 2013 23:00:43 +0000 (23:00 +0000)]
IndexedDB: Limit LevelDB's max open files
https://bugs.webkit.org/show_bug.cgi?id=109993

Reviewed by Tony Chang.

LevelDB keeps up to 1000 (by default) data files open at a time to
avoid having to open() them. This has caused chromium to hit the
process-wide open file limit. This patch changes max_open_files to 20,
as that's the minimum permitted by LevelDB and we have no reason to
think that performance will suffer because of the extra open calls.

No new tests - a chromium browser test that tracks the open LevelDB
files is plausible but is blocked on http://crbug.com/177249/.

* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::openDB):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd gyp option to switch ENABLE(SQL_DATABASE)
commit-queue@webkit.org [Wed, 20 Feb 2013 22:56:54 +0000 (22:56 +0000)]
Add gyp option to switch ENABLE(SQL_DATABASE)
https://bugs.webkit.org/show_bug.cgi?id=109303
http://code.google.com/p/chromium/issues/detail?id=22208

Patch by Paweł Hajdan, Jr. <phajdan.jr@chromium.org> on 2013-02-20
Reviewed by Tony Chang.

This will be useful to implement build with system sqlite.

* features.gypi:
* src/ChromeClientImpl.cpp:
(WebKit):
* src/ChromeClientImpl.h:
(ChromeClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEME: Enable both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 until clients transition...
jer.noble@apple.com [Wed, 20 Feb 2013 22:49:41 +0000 (22:49 +0000)]
EME: Enable both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 until clients transition to the new API.
https://bugs.webkit.org/show_bug.cgi?id=110284

Reviewed by Eric Carlson.

Re-enable the ENCRYPTED_MEDIA flag.

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] Resize RenderMultiColumnSets around their columns.
hyatt@apple.com [Wed, 20 Feb 2013 22:16:55 +0000 (22:16 +0000)]
[New Multicolumn] Resize RenderMultiColumnSets around their columns.
https://bugs.webkit.org/show_bug.cgi?id=110378.

Reviewed by Dirk Schulze.

Source/WebCore:

Test: fast/multicol/newmulticol/positioned-with-constrained-height.html.

* rendering/RenderBlock.h:
(RenderBlock):
Make computeOverflow public so that RenderMultiColumnFlowThread can
access it.

* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::layout):
Subclass layout to recompute the overflow for RenderMultiColumnBlock
after the flow thread has finished layout. This way it can account
for changes in RenderMultiColumnSets without having to do a second
layout pass.

* rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):
Override layout().

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnCount):
Clean up a comment that referred to portions as region rects still.

(WebCore::RenderMultiColumnSet::setFlowThreadPortionRect):
* rendering/RenderMultiColumnSet.h:
* rendering/RenderRegion.h:
(WebCore::RenderRegion::setFlowThreadPortionRect):
Make setFlowThreadPortionRect virtual and actually mutate the size
and position of RenderMultiColumnSets so that they enclose their
column rects.

LayoutTests:

* fast/multicol/newmulticol/positioned-with-constrained-height-expected.html: Added.
* fast/multicol/newmulticol/positioned-with-constrained-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable CANVAS_PATH flag
krit@webkit.org [Wed, 20 Feb 2013 22:14:04 +0000 (22:14 +0000)]
Enable CANVAS_PATH flag
https://bugs.webkit.org/show_bug.cgi?id=108508

Reviewed by Simon Fraser.

Enable CANVAS_PATH flag on trunk.

.:

Existing tests cover the feature.

* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

Existing tests cover the feature.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Existing tests cover the feature.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Existing tests cover the feature.

* fast/canvas/canvas-path-object-expected.txt:
* inspector/profiler/canvas2d/canvas2d-api-changes.html:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoParse author names with commas in ChangeLogs
tony@chromium.org [Wed, 20 Feb 2013 22:03:49 +0000 (22:03 +0000)]
Parse author names with commas in ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=110356

Reviewed by Dirk Pranke.

Paweł's name has a comma in it, which was confusing the ChangeLog parser.

* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry): Move name splitting regexp into a constant.
(ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
(ChangeLogEntry._split_reviewer_names): Rename to be more specific.
(ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
(ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_parse_authors): Test case with Paweł's name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r143441.
commit-queue@webkit.org [Wed, 20 Feb 2013 21:56:27 +0000 (21:56 +0000)]
Unreviewed, rolling out r143441.
http://trac.webkit.org/changeset/143441
https://bugs.webkit.org/show_bug.cgi?id=110376

May be causing chromium content_browsertests failures.
(Requested by vollick on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-20

* bindings/v8/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):
(WebCore::ScriptValue::toInspectorValue):
* bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::operator=):
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::isEqual):
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):
(WebCore::ScriptValue::clear):
(WebCore::ScriptValue::v8Value):
(ScriptValue):
* bindings/v8/SharedPersistent.h:
(WebCore):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::scriptValueAsNode):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAttrGetterCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Add runtime flag for CanvasPath
krit@webkit.org [Wed, 20 Feb 2013 21:53:27 +0000 (21:53 +0000)]
[Chromium] Add runtime flag for CanvasPath
https://bugs.webkit.org/show_bug.cgi?id=109997

Reviewed by Adam Barth.

Source/WebCore:

Add runtime flag for Chromium.

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setCanvasPathEnabled):
(WebCore::RuntimeEnabledFeatures::canvasPathEnabled):
* html/canvas/DOMPath.idl:
* page/DOMWindow.idl:

Source/WebKit/chromium:

Add runtime flag for Chromium.

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableCanvasPath):
(WebKit):
(WebKit::WebRuntimeFeatures::isCanvasPathEnabled):

Tools:

Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
the constructor for Path on DOMWindow would never be activatable, since the script
is running after creating the DOMWindow object.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening.
wjmaclean@chromium.org [Wed, 20 Feb 2013 21:48:25 +0000 (21:48 +0000)]
[chromium] Unreviewed gardening.

Patch by Ian Vollick <vollick@chromium.org> on 2013-02-20

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unnecessary includes for Platform.h from headers
commit-queue@webkit.org [Wed, 20 Feb 2013 21:45:56 +0000 (21:45 +0000)]
Remove unnecessary includes for Platform.h from headers
https://bugs.webkit.org/show_bug.cgi?id=110300

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-20
Reviewed by Alexey Proskuryakov.

Source/WebCore:

wtf/Platform.h only need to be included in a few places directly
as it is included in config.h. Remove the unnecessay duplicate as
it can be confusing.

No new tests, no change in functionality.

* platform/SecureTextInput.h:
* platform/audio/Biquad.h:
* platform/audio/FFTFrame.h:
* platform/graphics/cpu/arm/filters/FEBlendNEON.h:
* platform/graphics/cpu/arm/filters/NEONHelpers.h:
* platform/graphics/filters/FELighting.h:

Source/WebKit2:

wtf/Platform.h only need to be included in a few places directly
as it is included in config.h. Remove the unnecessay duplicate as
it can be confusing.

* Shared/PrintInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SVG] Update of element referenced by multiple 'use' nodes is absurdly slow
fmalita@chromium.org [Wed, 20 Feb 2013 21:43:29 +0000 (21:43 +0000)]
[SVG] Update of element referenced by multiple 'use' nodes is absurdly slow
https://bugs.webkit.org/show_bug.cgi?id=97905

Reviewed by Dirk Schulze.

Rebuilding the shadow and instance trees of dependent use nodes recursively can be
extremely inefficient with non-trivial dependency graphs (the trees are not constructed
in topological order).

To avoid redundant buildShadowAndInstanceTree() invokations, separate the invalidation
phase from the actual tree (re)building phase, and only descend into the dependency DAG
during the invalidation phase (recursion also stops at nodes that have been previously
invalidated).

No new tests: functional coverage provided by existing tests, perfomance tracked by
PerformanceTests/SVG/SvgNestedUse.html.

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::invalidateShadowTree):
(WebCore):
(WebCore::SVGUseElement::invalidateDependentShadowTrees):
* svg/SVGUseElement.h:
(SVGUseElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening.
wjmaclean@chromium.org [Wed, 20 Feb 2013 21:34:19 +0000 (21:34 +0000)]
[chromium] Unreviewed gardening.

Patch by Ian Vollick <vollick@chromium.org> on 2013-02-20

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Move WebKitPlatformSupport declaration to Platform.h
pilgrim@chromium.org [Wed, 20 Feb 2013 21:31:15 +0000 (21:31 +0000)]
[Chromium] Move WebKitPlatformSupport declaration to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=110262

Reviewed by Adam Barth.

In preparation for removing WebKitPlatformSupport.h entirely (once
downstream references to that file have been updated). Part of a
larger refactoring series; see tracking bug 82948.

Source/Platform:

* chromium/public/Platform.h:
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
(WebKit):

Source/WebKit/chromium:

* public/platform/WebKitPlatformSupport.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake the test land in r143482 less platform-specific
robert@webkit.org [Wed, 20 Feb 2013 21:28:08 +0000 (21:28 +0000)]
Make the test land in r143482 less platform-specific

Add outline:none to the test so platform-specific outlines don't kick in and
make us require separate results for Mac and Linux.

Unreviewed, gardening.

* fast/repaint/paint-caret-in-div-with-negative-indent-expected.png:
* fast/repaint/paint-caret-in-div-with-negative-indent.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderLayerBacking should initialize TiledBacking's isInWindow state with Page's...
timothy_horton@apple.com [Wed, 20 Feb 2013 21:15:09 +0000 (21:15 +0000)]
RenderLayerBacking should initialize TiledBacking's isInWindow state with Page's isInWindow, not isOnscreen
https://bugs.webkit.org/show_bug.cgi?id=110370
<rdar://problem/13254006>

Reviewed by Simon Fraser.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCleanup the SQLTransaction and SQLTransactionBackend state dispatch
mark.lam@apple.com [Wed, 20 Feb 2013 21:10:18 +0000 (21:10 +0000)]
Cleanup the SQLTransaction and SQLTransactionBackend state dispatch
to only honor a state transition request if the associated database
hasn't been interrupted.
https://bugs.webkit.org/show_bug.cgi?id=110247.

Reviewed by Antti Koivisto.

No new tests.

* Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::performPendingCallback):
(WebCore::SQLTransaction::computeNextStateAndCleanupIfNeeded):
* Modules/webdatabase/SQLTransaction.h:
* Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::computeNextStateAndCleanupIfNeeded):
(WebCore::SQLTransactionBackend::performNextStep):
* Modules/webdatabase/SQLTransactionBackend.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMoar hardening
oliver@apple.com [Wed, 20 Feb 2013 21:09:16 +0000 (21:09 +0000)]
Moar hardening
https://bugs.webkit.org/show_bug.cgi?id=110275

Reviewed by Mark Hahnenberg.

We now poison objects when they get freed, and verify that
any object that is being freed is not poisoned.  If the
object looks like it's poisoned we validate the freelist,
and ensure the object is not already present.  If it is
we crash.

On allocation, we ensure that the object being allocated
is poisoned, then clear the poisoning fields.

* wtf/FastMalloc.cpp:
(WTF::internalEntropyValue):
(WTF):
(WTF::freedObjectStartPoison):
(WTF::freedObjectEndPoison):
(TCMalloc_ThreadCache_FreeList):
(WTF::TCMalloc_ThreadCache_FreeList::Validate):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago ResourceHandle::loadResourceSynchronously should have blob support in cross...
ap@apple.com [Wed, 20 Feb 2013 21:02:36 +0000 (21:02 +0000)]
    ResourceHandle::loadResourceSynchronously should have blob support in cross-platform code
        https://bugs.webkit.org/show_bug.cgi?id=110364

        Reviewed by Anders Carlsson.

        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::loadResourceSynchronously):
        Added a cross-platform version to keep blob-related logic in one place.

        * platform/network/blackberry/ResourceHandleBlackBerry.cpp:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        * platform/network/win/ResourceHandleWin.cpp:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        Renamed loadResourceSynchronously to platformLoadResourceSynchronously,
        removed blob handling from platforms that had it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] RenderMultiColumnFlowThreads should establish a BFC.
hyatt@apple.com [Wed, 20 Feb 2013 21:00:24 +0000 (21:00 +0000)]
[New Multicolumn] RenderMultiColumnFlowThreads should establish a BFC.
https://bugs.webkit.org/show_bug.cgi?id=110366.

Reviewed by Antti Koivisto.

Source/WebCore:

RenderFlowThreads should establish a block formatting context always.
CSS Regions have named flow thread that they absolutely position, and so
they got this for free by being absolutely positioned.

RenderMultiColumnFlowThreads, however, are relative positioned, so we need
to just add an isRenderFlowThread case specifically so we're not dependent
on the positioning scheme used for the flow thread to establish the BFC.

Test: fast/multicol/newmulticol/float-*.html.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):

LayoutTests:

* fast/multicol/newmulticol/float-avoidance-expected.html: Added.
* fast/multicol/newmulticol/float-avoidance.html: Added.
* fast/multicol/newmulticol/float-multicol-expected.html: Added.
* fast/multicol/newmulticol/float-multicol.html: Added.
* fast/multicol/newmulticol/float-paginate-complex-expected.html: Added.
* fast/multicol/newmulticol/float-paginate-complex.html: Added.
* fast/multicol/newmulticol/float-paginate-empty-lines-expected.html: Added.
* fast/multicol/newmulticol/float-paginate-empty-lines.html: Added.
* fast/multicol/newmulticol/float-paginate-expected.html: Added.
* fast/multicol/newmulticol/float-paginate.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] Column gap is computed incorrectly.
hyatt@apple.com [Wed, 20 Feb 2013 19:58:16 +0000 (19:58 +0000)]
[New Multicolumn] Column gap is computed incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=110360.

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/multicol/newmulticol/layers-split-across-columns.html.

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnGap):
Make sure we ask the RenderMultiColumnBlock for the gap rather than our
own style, since we don't actually have the gap value in our style.

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
* rendering/RenderMultiColumnSet.h:
Fix another spot where the columnGap was an int. It should be a LayoutUnit.

LayoutTests:

* fast/multicol/newmulticol/layers-split-across-columns-expected.html: Added.
* fast/multicol/newmulticol/layers-split-across-columns.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNo caret on empty contenteditable element with negative text-indent
robert@webkit.org [Wed, 20 Feb 2013 19:51:03 +0000 (19:51 +0000)]
No caret on empty contenteditable element with negative text-indent
https://bugs.webkit.org/show_bug.cgi?id=108633

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/repaint/paint-caret-in-div-with-negative-indent.html

When an editable element has a negative text indent we won't paint the caret when the
element is empty because it falls outside the element's border box. To ensure the caret is painted,
account for any negative indent with our overflow.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):

LayoutTests:

* fast/repaint/paint-caret-in-div-with-negative-indent-expected.png: Added.
* fast/repaint/paint-caret-in-div-with-negative-indent-expected.txt: Added.
* fast/repaint/paint-caret-in-div-with-negative-indent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] use a WebTestProxyBase pointer to identify the window we need the history for
jochen@chromium.org [Wed, 20 Feb 2013 18:45:45 +0000 (18:45 +0000)]
[chromium] use a WebTestProxyBase pointer to identify the window we need the history for
https://bugs.webkit.org/show_bug.cgi?id=110346

Reviewed by Adam Barth.

Using an index is very brittle, as the TestRunner API does not define
any ordering of windows.

Also, make TestRunner::shouldDumpBackForwardList() so content shell can
trigger the capturing in the browser process before generating the
text dump.

* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner):
(WebTestRunner::WebTestDelegate::captureHistoryForWindow):
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::captureTree):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::captureHistoryForWindow):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove stretchesToMinIntrinsicLogicalWidth
ojan@chromium.org [Wed, 20 Feb 2013 18:45:22 +0000 (18:45 +0000)]
Remove stretchesToMinIntrinsicLogicalWidth
https://bugs.webkit.org/show_bug.cgi?id=110266

Reviewed by Emil Eklund.

This was only used by fieldsets and now we have a way to express this
concept in CSS.

* WebCore.order:
* css/html.css:
Make fieldsets min-width: -webkit-min-content.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computePositionedLogicalWidth):
* rendering/RenderBox.h:
Remove all calls to stretchesToMinIntrinsicLogicalWidth.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake intrinsic width values work for positioned elements
ojan@chromium.org [Wed, 20 Feb 2013 18:37:06 +0000 (18:37 +0000)]
Make intrinsic width values work for positioned elements
https://bugs.webkit.org/show_bug.cgi?id=110264

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-intrinsic-dimensions/intrinsic-sized-absolutes.html
       fast/css-intrinsic-dimensions/width-shrinks-avoid-floats.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeIntrinsicLogicalWidthUsing):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
Move the computation of intrinsic widths out into a helper function so that
computePositionedLogicalWidthUsing can use it. As per the current spec,
fill-available measures shrink to avoid floats. http://dev.w3.org/csswg/css3-sizing/

(WebCore::RenderBox::computePositionedLogicalWidth):
Compute intrinsic min-widths in addition to non-zero ones. Intrinsic widths
return true for isZero. width and max-width don't need modifying since they already
call computePositionedLogicalWidthUsing for intrinsic widths.

(WebCore::RenderBox::computePositionedLogicalWidthUsing):
Compute intrinsic widths and use a Fixed length for the rest of the positioned width
computation. Doesn't include bordersPlusPadding because the caller, expected the content
width and adds in the bordersPlusPadding later.

* rendering/RenderBox.h:

LayoutTests:

* fast/css-intrinsic-dimensions/intrinsic-sized-absolutes-expected.txt: Added.
* fast/css-intrinsic-dimensions/intrinsic-sized-absolutes.html: Added.
* fast/css-intrinsic-dimensions/width-shrinks-avoid-floats-expected.txt: Added.
* fast/css-intrinsic-dimensions/width-shrinks-avoid-floats.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoinput element with placeholder text and width set to 100% on focus causes overflow...
robert@webkit.org [Wed, 20 Feb 2013 18:27:03 +0000 (18:27 +0000)]
input element with placeholder text and width set to 100% on focus causes overflow even after losing focus
https://bugs.webkit.org/show_bug.cgi?id=109020

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/forms/input-placeholder-layout-view.html
       fast/forms/textarea-placeholder-layout-view.html

Placeholder elements don't affect layout so shouldn't contribute overflow either.

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):

LayoutTests:

* fast/forms/input-placeholder-layout-view-expected.html: Added.
* fast/forms/input-placeholder-layout-view.html: Added.
* fast/forms/textarea-placeholder-layout-view-expected.html: Added.
* fast/forms/textarea-placeholder-layout-view.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Remove m_viewportSize in WebPage.
commit-queue@webkit.org [Wed, 20 Feb 2013 18:23:42 +0000 (18:23 +0000)]
[WK2] Remove m_viewportSize in WebPage.
https://bugs.webkit.org/show_bug.cgi?id=110311

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-20
Reviewed by Anders Carlsson.

EFL and Qt use m_viewSize as a contents size while Apple use it as a viewport
size, so EFL and Qt introduced m_viewportSize to make WebPage know a viewport
size.

EFL and Qt use m_viewSize as a contents size because the size of non compositing
layer is contents size, and EFL and Qt mark whole non compositing layer as dirty
using m_viewSize. Bug 110299 (http://webkit.org/b/110299) changes that it is not
necessary to know m_viewSize when marking whole non compositing layer as dirty.
So we can make EFL and Qt use m_viewSize as a viewport size also.

This patch removes m_viewportSize and related methods to increase readability.

* UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebView::setSize):
* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::didChangeViewportSize):
* UIProcess/WebPageProxy.cpp:
(WebKit):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::pageRect):
(WebKit::WebChromeClient::contentsSizeChanged):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updateBackingStoreState):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setSize):
(WebKit::WebPage::sendViewportAttributesChanged):
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove idbFactory from WebKitPlatformSupport
pilgrim@chromium.org [Wed, 20 Feb 2013 18:21:39 +0000 (18:21 +0000)]
[Chromium] Remove idbFactory from WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=106457

Reviewed by Adam Barth.

Now that https://codereview.chromium.org/12230054 has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.

* public/platform/WebKitPlatformSupport.h:
(WebKit):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] add setNeedsDisplay in DrawingArea to mark whole layer as dirty.
commit-queue@webkit.org [Wed, 20 Feb 2013 18:10:22 +0000 (18:10 +0000)]
[WK2] add setNeedsDisplay in DrawingArea to mark whole layer as dirty.
https://bugs.webkit.org/show_bug.cgi?id=110299

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-20
Reviewed by Anders Carlsson.

Currently, we call setNeedsDisplay with the size of WebPage to mark whole
backing store as dirty. However, the size of non compositing layer can be
inconsistent with the size of WebPage. For example, in Coordinated Graphics, the
size of non compositing layer is contents size.

So, WebPage should not assume the size of non compositing layer, and should just
call setNeedsDisplay when marking whole layer as dirty.

In addition, this patch renames from setNeedsDisplay() with a rect argument to
setNeedsDisplayInRect(), which matches to the terms of GraphicsLayer.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::invalidateContentsAndRootView):
(WebKit::WebChromeClient::invalidateContentsForSlowScroll):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::restoreViewState):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::setNonCompositedContentsNeedDisplay):
(WebKit):
(WebKit::CoordinatedLayerTreeHost::setNonCompositedContentsNeedDisplayInRect):
(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):
* WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setNeedsDisplay):
(WebKit):
(WebKit::DrawingAreaImpl::setNeedsDisplayInRect):
(WebKit::DrawingAreaImpl::scroll):
(WebKit::DrawingAreaImpl::forceRepaint):
(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
(WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
(WebKit::DrawingAreaImpl::resumePainting):
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
* WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setSize):
(WebKit::WebPage::setDrawsBackground):
(WebKit::WebPage::setDrawsTransparentBackground):
(WebKit::WebPage::resumeActiveDOMObjectsAndAnimations):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplay):
(WebKit):
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostGtk::scrollNonCompositedContents):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk):
* WebProcess/WebPage/mac/LayerTreeHostMac.h:
(LayerTreeHostMac):
* WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
(WebKit):
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostMac::scrollNonCompositedContents):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
(RemoteLayerTreeDrawingArea):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::setNeedsDisplay):
(WebKit):
(WebKit::RemoteLayerTreeDrawingArea::setNeedsDisplayInRect):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplay):
(WebKit):
(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplayInRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename DatabaseBackend to DatabaseBackendBase.
mark.lam@apple.com [Wed, 20 Feb 2013 17:56:55 +0000 (17:56 +0000)]
Rename DatabaseBackend to DatabaseBackendBase.
https://bugs.webkit.org/show_bug.cgi?id=110303.

Rubber stamped by Alexey Proskuryakov.

Source/WebCore:

This is a purely cosmetic change to make the naming consistent with
the front-end DatabaseBase.

No new tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/webdatabase/AbstractDatabaseServer.h:
* Modules/webdatabase/Database.cpp:
(WebCore::Database::create):
(WebCore::Database::version):
* Modules/webdatabase/Database.h:
(Database):
* Modules/webdatabase/DatabaseBackend.cpp: Removed.
* Modules/webdatabase/DatabaseBackend.h: Removed.
* Modules/webdatabase/DatabaseBackendAsync.cpp:
(WebCore::DatabaseBackendAsync::DatabaseBackendAsync):
(WebCore::DatabaseBackendAsync::performOpenAndVerify):
* Modules/webdatabase/DatabaseBackendAsync.h:
* Modules/webdatabase/DatabaseBackendBase.cpp: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackend.cpp.
(WebCore::DatabaseBackendBase::databaseInfoTableName):
(WebCore::DatabaseBackendBase::DatabaseBackendBase):
(WebCore::DatabaseBackendBase::~DatabaseBackendBase):
(WebCore::DatabaseBackendBase::closeDatabase):
(WebCore::DatabaseBackendBase::version):
(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(DoneCreatingDatabaseOnExitCaller):
(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::securityOrigin):
(WebCore::DatabaseBackendBase::stringIdentifier):
(WebCore::DatabaseBackendBase::displayName):
(WebCore::DatabaseBackendBase::estimatedSize):
(WebCore::DatabaseBackendBase::fileName):
(WebCore::DatabaseBackendBase::details):
(WebCore::DatabaseBackendBase::getVersionFromDatabase):
(WebCore::DatabaseBackendBase::setVersionInDatabase):
(WebCore::DatabaseBackendBase::setExpectedVersion):
(WebCore::DatabaseBackendBase::getCachedVersion):
(WebCore::DatabaseBackendBase::setCachedVersion):
(WebCore::DatabaseBackendBase::getActualVersionForTransaction):
(WebCore::DatabaseBackendBase::disableAuthorizer):
(WebCore::DatabaseBackendBase::enableAuthorizer):
(WebCore::DatabaseBackendBase::setAuthorizerReadOnly):
(WebCore::DatabaseBackendBase::setAuthorizerPermissions):
(WebCore::DatabaseBackendBase::lastActionChangedDatabase):
(WebCore::DatabaseBackendBase::lastActionWasInsert):
(WebCore::DatabaseBackendBase::resetDeletes):
(WebCore::DatabaseBackendBase::hadDeletes):
(WebCore::DatabaseBackendBase::resetAuthorizer):
(WebCore::DatabaseBackendBase::maximumSize):
(WebCore::DatabaseBackendBase::incrementalVacuumIfNeeded):
(WebCore::DatabaseBackendBase::interrupt):
(WebCore::DatabaseBackendBase::isInterrupted):
(WebCore::DatabaseBackendBase::reportOpenDatabaseResult):
(WebCore::DatabaseBackendBase::reportChangeVersionResult):
(WebCore::DatabaseBackendBase::reportStartTransactionResult):
(WebCore::DatabaseBackendBase::reportCommitTransactionResult):
(WebCore::DatabaseBackendBase::reportExecuteStatementResult):
(WebCore::DatabaseBackendBase::reportVacuumDatabaseResult):
* Modules/webdatabase/DatabaseBackendBase.h: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackend.h.
(DatabaseBackendBase):
* Modules/webdatabase/DatabaseBackendSync.cpp:
(WebCore::DatabaseBackendSync::DatabaseBackendSync):
* Modules/webdatabase/DatabaseBackendSync.h:
* Modules/webdatabase/DatabaseBase.h:
* Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
(WebCore::DatabaseManager::getMaxSizeForDatabase):
* Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
* Modules/webdatabase/DatabaseServer.cpp:
(WebCore::DatabaseServer::openDatabase):
(WebCore::DatabaseServer::createDatabase):
(WebCore::DatabaseServer::getMaxSizeForDatabase):
* Modules/webdatabase/DatabaseServer.h:
* Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::create):
* Modules/webdatabase/DatabaseSync.h:
(DatabaseSync):
* Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFile):
* Modules/webdatabase/DatabaseTracker.h:
(DatabaseTracker):
* Modules/webdatabase/OriginQuotaManager.cpp:
(WebCore::OriginQuotaManager::markDatabase):
* Modules/webdatabase/OriginQuotaManager.h:
(OriginQuotaManager):
* Modules/webdatabase/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
(WebCore::SQLTransactionClient::didExceedQuota):
* Modules/webdatabase/SQLTransactionClient.h:
(SQLTransactionClient):
* Modules/webdatabase/chromium/DatabaseObserver.h:
(DatabaseObserver):
* Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::NotifyDatabaseObserverOnCloseTask::create):
(WebCore::NotifyDatabaseObserverOnCloseTask::NotifyDatabaseObserverOnCloseTask):
(NotifyDatabaseObserverOnCloseTask):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::prepareToOpenDatabase):
(WebCore::DatabaseTracker::failedToOpenDatabase):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::create):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::CloseOneDatabaseImmediatelyTask):
(DatabaseTracker::CloseOneDatabaseImmediatelyTask):
(WebCore::DatabaseTracker::closeOneDatabaseImmediately):
* Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp:
(WebCore::NotifyDatabaseChangedTask::create):
(WebCore::NotifyDatabaseChangedTask::NotifyDatabaseChangedTask):
(NotifyDatabaseChangedTask):
(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
(WebCore::SQLTransactionClient::didExceedQuota):
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

* public/WebDatabase.h:
(WebDatabase):
* src/DatabaseObserver.cpp:
(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):
(WebCore::DatabaseObserver::reportOpenDatabaseResult):
(WebCore::DatabaseObserver::reportChangeVersionResult):
(WebCore::DatabaseObserver::reportStartTransactionResult):
(WebCore::DatabaseObserver::reportCommitTransactionResult):
(WebCore::DatabaseObserver::reportExecuteStatementResult):
(WebCore::DatabaseObserver::reportVacuumDatabaseResult):
* src/WebDatabase.cpp:
(WebKit::WebDatabase::WebDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit/chromium: Fix use after free in ContextMenuClientImpl.cpp
tony@chromium.org [Wed, 20 Feb 2013 17:48:41 +0000 (17:48 +0000)]
Source/WebKit/chromium: Fix use after free in ContextMenuClientImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=109220

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-20
Reviewed by Tony Chang.

ContextMenuClientImpl can use a DocumentMarker after it is freed. The DocumentMarker is originally allocated
by the spell checker. When the user context-clicks on a misspelling, ContextMenuClientImpl saves a reference
to the clicked DocumentMarker, changes the selection, and then uses the DocumentMarker. Changing the selection
causes re-check of spelling. If the spell check client serves the spellcheck request from cache, then re-checking
spelling will delete the DocumentMarker and add a new one. This invalidates the DocumentMarker reference held by
ContextMenuClientImpl. When ContextMenuClientImpl attempts to use the DocumentMarker, Address Sanitizer detects
use after free. The fix is to save a copy of the DocumentMarker before changing selection.

* src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspellingAsync): Save a copy of DocumentMarker before changing selection.
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Use DocumentMarker instead of Vector<DocumentMarker*>.

Tools: [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache
https://bugs.webkit.org/show_bug.cgi?id=109220

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-19
Reviewed by Tony Chang.

* DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(WebTestRunner::MockSpellCheck::hasInCache): Added a method to detect whether spellcheck results can be served from cache.
(WebTestRunner):
(WebTestRunner::MockSpellCheck::fillSuggestionList): Modified to suggest "checker" for the word "cheher".
(WebTestRunner::MockSpellCheck::initializeIfNeeded): Modified to mark "cheher" as misspelling.
* DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck):
* DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
(WebTestRunner::SpellCheckClient::requestCheckingOfText): Modified to serve spellcheck suggestions from cache when possible.

LayoutTests: Spellchecker should not crash after text has changed and spellcheck results are served from cache
https://bugs.webkit.org/show_bug.cgi?id=109220

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-20
Reviewed by Tony Chang.

* editing/spelling/spelling-changed-text-expected.txt: Added the expected output for serving spellcheck results from cache for edited text.
* editing/spelling/spelling-changed-text.html: Added a test for serving spellcheck results from cache for edited text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoiOS does not use CaptionUserPreferencesMac
eric.carlson@apple.com [Wed, 20 Feb 2013 17:23:48 +0000 (17:23 +0000)]
iOS does not use CaptionUserPreferencesMac
https://bugs.webkit.org/show_bug.cgi?id=110259

Reviewed by Dean Jackson.

* page/CaptionUserPreferencesMac.h: Add PLATFORM(IOS) guard
* page/CaptionUserPreferencesMac.mm: Ditto.

* page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferences): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled Chromium DEPS to r183552. Requested by
commit-queue@webkit.org [Wed, 20 Feb 2013 17:15:15 +0000 (17:15 +0000)]
Unreviewed.  Rolled Chromium DEPS to r183552.  Requested by
"Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-20

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] Make layers paint properly in columns.
hyatt@apple.com [Wed, 20 Feb 2013 16:59:53 +0000 (16:59 +0000)]
[New Multicolumn] Make layers paint properly in columns.
https://bugs.webkit.org/show_bug.cgi?id=110296.

Reviewed by Sam Weinig.

Source/WebCore:

Construct the style for the RenderMultiColumnFlowThread such that it
establishes a stacking context (by being position:relative
with a z-index of 0). This causes the layer collection code
to correctly ignore the RenderFlowThread layers during normal
painting.

Fix more clipping bugs to eliminate subpixel layout differences
between old and new multicolumn.

Test: fast/multicol/newmulticol/layers-in-multicol.html

* rendering/RenderMultiColumnBlock.cpp:
(WebCore::createMultiColumnFlowThreadStyle):
(WebCore):
(WebCore::RenderMultiColumnBlock::addChild):
Use a custom style (similar to what normal RenderFlowThreads do)
for the RenderMultiColumnFlowThread that makes it a stacking
context.

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
Fix the overflow calculations out the leftmost and rightmost
columns to actually look at the physical placement of the columns.
The old code was backwards for RTL.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
Fix the clipping done by overflowRectForFlowThreadPortion to min
and max with the passed-in portion rect so that subclasses that
inflate the rect prior to passing it into the method don't have that
inflation discarded.

LayoutTests:

* fast/multicol/newmulticol/layers-in-multicol-expected.html: Added.
* fast/multicol/newmulticol/layers-in-multicol.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Make sure to always sync before reusing backingstore tiles.
jpetsovits@rim.com [Wed, 20 Feb 2013 16:43:33 +0000 (16:43 +0000)]
[BlackBerry] Make sure to always sync before reusing backingstore tiles.
https://bugs.webkit.org/show_bug.cgi?id=109863
PR 296118

Reviewed by Rob Buis.
Internally reviewed by Mike Lattanzio and Konrad Piascik.

In SVN r142137, I replaced a syncToCurrentMessage() call
with updateSuspendScreenUpdateState() in some cases,
which internally calls the same function.

Unfortunately, when I optimized updateSuspendScreenUpdateState()
to only sync when the state is actually being changed,
I omitted an adaptation of adoptAsFrontState() which would
rely on this sync but now didn't always perform it.

This caused a bad race condition as tile buffers could now
be accessed from the WebKit thread and the UI thread at
the same time. Fix it by (optionally) letting the caller
of updateSuspendScreenUpdateState() know whether a sync
was performed, and adapt adoptAsFrontState() accordingly.

Also fixes some excessive flicker caused by the same
race condition.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
(BlackBerry::WebKit::BackingStorePrivate::adoptAsFrontState):
* Api/BackingStore_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: CSSProperty.status defaults to "style" not "active"
apavlov@chromium.org [Wed, 20 Feb 2013 16:08:23 +0000 (16:08 +0000)]
Web Inspector: CSSProperty.status defaults to "style" not "active"
https://bugs.webkit.org/show_bug.cgi?id=110348

Reviewed by Timothy Hatcher.

* inspector/Inspector.json: Fix the default property status to be "style" in the description.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[v8] potentially disposed handle returned for npapi object
commit-queue@webkit.org [Wed, 20 Feb 2013 15:38:57 +0000 (15:38 +0000)]
[v8] potentially disposed handle returned for npapi object
https://bugs.webkit.org/show_bug.cgi?id=110331

Patch by Dan Carney <dcarney@google.com> on 2013-02-20
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

* bindings/v8/V8NPUtils.cpp:
(WebCore::convertNPVariantToV8Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] HTML5 Media controls require a design refresh
commit-queue@webkit.org [Wed, 20 Feb 2013 15:30:15 +0000 (15:30 +0000)]
[Gtk] HTML5 Media controls require a design refresh
https://bugs.webkit.org/show_bug.cgi?id=83869

Source/WebCore:

Created new controls that depend less on Gtk and more in CSS.

Patch by Xabier Rodriguez Calvar  <calvaris@igalia.com>  and  Martin Robinson <mrobinson@igalia.com> on 2013-02-20
Reviewed by Philippe Normand.

* GNUmakefile.list.am: Added compilation for MediaControlsGtk.cpp
and MediaControlsGtk.h
* css/mediaControlsGtk.css: Taken from Chromium and adapted for
WebKitGtk+.
* html/shadow/MediaControlsGtk.cpp: Added.
(WebCore): Added MediaControlsGtk class.
(WebCore::MediaControlsGtk::MediaControlsGtk): Class constructor
(WebCore::MediaControls::create): Creates the Gtk+ controls
components.
(WebCore::MediaControlsGtk::createControls): Creates the Gtk+
controls components.
(WebCore::MediaControlsGtk::initializeControls): Initializes all
media controls.
(WebCore::MediaControlsGtk::setMediaController): Sets the media
controller.
(WebCore::MediaControlsGtk::reset): Resets the controllers.
(WebCore::MediaControlsGtk::playbackStarted): Invoked when the
playback starts
(WebCore::MediaControlsGtk::updateCurrentTimeDisplay): Updates the
controls when the current time shall be updated.
(WebCore::MediaControlsGtk::changedMute): Updates the controls
then the mute changes.
(WebCore::MediaControlsGtk::showVolumeSlider): Invoked when the
volume slider is meant to be shown.
(WebCore::MediaControlsGtk::createTextTrackDisplay): Creates the
track display. Though it is not used by us, it needs to be created
to prevent immediate crashes when loading a video.
* html/shadow/MediaControlsGtk.h: Added.
(WebCore): Added the MediaControlsGtk class.
(MediaControlsGtk): Added the MediaControlsGtk class.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore): Added getStockSymbolicIconForWidgetType function
signature to load symbolic icons.
(WebCore::supportsFocus): Added media control widgets to support
focus so that the focus ring is not painted by WebCore.
(WebCore::RenderThemeGtk::paintMediaButton): Added the symbolic
icon support. It supports now normal and symbolic icons at the
same time.
(WebCore::RenderThemeGtk::paintMediaFullscreenButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaMuteButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaPlayButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaSeekBackButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaSeekForwardButton): Added the
symbolic icon support.
(WebCore::borderRadiiFromStyle): Created the radii info from the
style.
(WebCore::RenderThemeGtk::paintMediaSliderTrack): Removed the
background and the Gtk widget support as it is painted with
CSS. Also paint the time ranges with the CSS style.
(WebCore::RenderThemeGtk::paintMediaSliderThumb): Paint slider
thumb according to the CSS parameters.
(WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer):
Delegates in the CSS.
(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Fills the
track up to the volume level and delegates the border in the CSS.
(WebCore::RenderThemeGtk::paintMediaVolumeSliderThumb): Delegates
in the paintMediaSliderThumb method so the thumb is painted the
same with the CSS parameters.
(WebCore::RenderThemeGtk::paintMediaCurrentTime): Removed the Gtk
background to use only CSS.
* platform/gtk/RenderThemeGtk.h:
(RenderThemeGtk): Changed paintMediaButton to support the symbolic
and normal icons at the same time.
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::adjustSliderThumbSize): Not adjusting
the thumb size and letting the CSS decide that for media slider.
(WebCore::getStockSymbolicIconForWidgetType): Implemented as a
fallback to the normal stock icons.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore):
(WebCore::RenderThemeGtk::adjustSliderThumbSize): Not adjusting
the thumb size and letting the CSS decide that for the media
sliders.
(WebCore::getStockSymbolicIconForWidgetType): Added this function
to load symbolic icons. It falls back to normal icons if the
symbolic is not found.

Tools:

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-02-20
Reviewed by Philippe Normand.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeGtkFontSettings): Added gnome as default icon theme for
the DRT.
* WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::initializeGtkSettings): Added gnome as default icon theme for
the WTR.
* gtk/jhbuild.modules: Added gnome-icon-theme-symbolic as external
dependency.

LayoutTests:

Tests flagged and rebaselines.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-02-20
Reviewed by Philippe Normand.

* platform/gtk/TestExpectations: Tests flagged and removed some
other flags.
* platform/gtk/accessibility/media-element-expected.txt: Rebaseline
* platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt: Rebaseline
* platform/gtk/fast/layers/video-layer-expected.png: Rebaseline
* platform/gtk/fast/layers/video-layer-expected.txt: Rebaseline
* platform/gtk/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Rebaseline
* platform/gtk/media/audio-repaint-expected.png: Rebaseline
* platform/gtk/media/audio-repaint-expected.txt: Rebaseline
* platform/gtk/media/controls-styling-strict-expected.png: Rebaseline
* platform/gtk/media/video-controls-rendering-expected.png: Rebaseline
* platform/gtk/media/video-empty-source-expected.txt: Rebaseline
* platform/gtk/media/video-no-audio-expected.txt: Rebaseline
* platform/gtk/media/video-volume-slider-expected.txt: Rebaseline
* platform/gtk/media/video-zoom-controls-expected.txt: Rebaseline
* platform/gtk/media/video-zoom-expected.png: Rebaseline

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Rename AncestorChainWalker.h to EventPathWalker.h in the project file.
abecsi@webkit.org [Wed, 20 Feb 2013 15:27:22 +0000 (15:27 +0000)]
[Qt] Rename AncestorChainWalker.h to EventPathWalker.h in the project file.

Unreviewed gardening.

AncestorChainWalker has been renamed to EventPathWalker in r143422.
Rename the header in the project file as well so that it shows up in QtCreator.

No new tests needed.

* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Read "data-blackberry-text-selection-handle-position" attribute from...
commit-queue@webkit.org [Wed, 20 Feb 2013 15:24:26 +0000 (15:24 +0000)]
[BlackBerry] Read "data-blackberry-text-selection-handle-position" attribute from element
https://bugs.webkit.org/show_bug.cgi?id=110235

Patch by Yongxin Dai <yodai@rim.com> on 2013-02-20
Reviewed by Yong Li.

PR #257207.

Read "data-blackberry-text-selection-handle-position" attribute from element and pass it along
with notifySelectionDetailsChanged(). If "data-blackberry-text-selection-handle-position" attribute
is specified in the element, the selection handle is always flipped to the required position.
along with selected text within element.

Reviewed Internally by Mike Fenton.

* Api/WebPageClient.h:
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::selectionContainerElement):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::elementHandlePositionAttribute):
* WebKitSupport/DOMSupport.h:
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::requestedSelectionHandlePosition):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
* WebKitSupport/SelectionHandler.h:
(SelectionHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fix usage of HitTestRequest::RequestType
commit-queue@webkit.org [Wed, 20 Feb 2013 15:04:51 +0000 (15:04 +0000)]
[BlackBerry] Fix usage of HitTestRequest::RequestType
https://bugs.webkit.org/show_bug.cgi?id=110342

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-20
Reviewed by Carlos Garcia Campos.

Rename HitTestResult::* -> HitTestRequest::*
This was introduced by mistake in r142977.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::hitTestResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 20 Feb 2013 14:24:57 +0000 (14:24 +0000)]
[EFL] Unreviewed gardening.

* platform/efl/TestExpectations: Marked touch event emulation test as failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] move most of the remaining mocks to TestRunner library
jochen@chromium.org [Wed, 20 Feb 2013 14:10:05 +0000 (14:10 +0000)]
[chromium] move most of the remaining mocks to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=110217

Reviewed by Nico Weber.

While most of the functionality provided by these mocks is also
available in the content module, there is no straight forward way to
inject the mock results required for layout tests.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestRunner):
(WebTestRunner::WebTestProxy::geolocationClient):
(WebTestRunner::WebTestProxy::speechInputController):
(WebTestRunner::WebTestProxy::speechRecognizer):
(WebTestRunner::WebTestProxy::deviceOrientationClient):
(WebTestRunner::WebTestProxy::requestPointerLock):
(WebTestRunner::WebTestProxy::requestPointerUnlock):
(WebTestRunner::WebTestProxy::isPointerLocked):
* DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.
(WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
(WebTestRunner):
(WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
(WebTestRunner::MockWebSpeechInputController::setDelegate):
(WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
(WebTestRunner::MockWebSpeechInputController::setDumpRect):
(WebTestRunner::MockWebSpeechInputController::clearResults):
(WebTestRunner::MockWebSpeechInputController::startRecognition):
(WebTestRunner::MockWebSpeechInputController::cancelRecognition):
(WebTestRunner::MockWebSpeechInputController::stopRecording):
(WebTestRunner::MockWebSpeechInputController::speechTaskFired):
(WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
(WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
(WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):
* DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.
(WebKit):
(WebTestRunner):
(MockWebSpeechInputController):
(WebTestRunner::MockWebSpeechInputController::taskList):
(SpeechTask):
* DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.
(WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
(WebTestRunner):
(WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
(WebTestRunner::MockWebSpeechRecognizer::setDelegate):
(WebTestRunner::MockWebSpeechRecognizer::start):
(WebTestRunner::MockWebSpeechRecognizer::stop):
(WebTestRunner::MockWebSpeechRecognizer::abort):
(WebTestRunner::MockWebSpeechRecognizer::addMockResult):
(WebTestRunner::MockWebSpeechRecognizer::setError):
(WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
(WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
(WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):
* DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.
(WebKit):
(WebTestRunner):
(MockWebSpeechRecognizer):
(WebTestRunner::MockWebSpeechRecognizer::wasAborted):
(WebTestRunner::MockWebSpeechRecognizer::client):
(WebTestRunner::MockWebSpeechRecognizer::handle):
(WebTestRunner::MockWebSpeechRecognizer::taskList):
(Task):
(WebTestRunner::MockWebSpeechRecognizer::Task::Task):
(WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
(StepTask):
(WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::windowOpened):
(WebTestRunner):
(WebTestRunner::TestInterfaces::windowClosed):
(WebTestRunner::TestInterfaces::windowList):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::requestPointerLock):
(WebTestRunner):
(WebTestRunner::TestRunner::requestPointerUnlock):
(WebTestRunner::TestRunner::isPointerLocked):
(WebTestRunner::TestRunner::didAcquirePointerLockInternal):
(WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
(WebTestRunner::TestRunner::didLosePointerLockInternal):
(WebTestRunner::TestRunner::windowCount):
(WebTestRunner::TestRunner::setMockDeviceOrientation):
(WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
(WebTestRunner::TestRunner::setGeolocationPermission):
(WebTestRunner::TestRunner::setMockGeolocationPosition):
(WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
(WebTestRunner::TestRunner::addMockSpeechInputResult):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
(WebTestRunner::TestRunner::setMockSpeechRecognitionError):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::didAcquirePointerLock):
(WebTestRunner::TestRunner::didNotAcquirePointerLock):
(WebTestRunner::TestRunner::didLosePointerLock):
(WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner):
(TestRunner):
(HostMethodTask):
(WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
(WebTestRunner::TestRunner::HostMethodTask::runIfValid):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::setInterfaces):
(WebTestRunner::WebTestProxyBase::setDelegate):
(WebTestRunner::WebTestProxyBase::reset):
(WebTestRunner::WebTestProxyBase::captureTree):
(WebTestRunner::WebTestProxyBase::geolocationClientMock):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
(WebTestRunner::WebTestProxyBase::speechInputControllerMock):
(WebTestRunner::WebTestProxyBase::speechRecognizerMock):
(WebTestRunner::WebTestProxyBase::geolocationClient):
(WebTestRunner::WebTestProxyBase::speechInputController):
(WebTestRunner::WebTestProxyBase::speechRecognizer):
(WebTestRunner::WebTestProxyBase::deviceOrientationClient):
(WebTestRunner::WebTestProxyBase::requestPointerLock):
(WebTestRunner::WebTestProxyBase::requestPointerUnlock):
(WebTestRunner::WebTestProxyBase::isPointerLocked):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::reset):
* DumpRenderTree/chromium/WebViewHost.h:
(WebKit):
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed. Correcting gardening after r143436.
zarvai@inf.u-szeged.hu [Wed, 20 Feb 2013 13:42:20 +0000 (13:42 +0000)]
[Qt] Unreviewed. Correcting gardening after r143436.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix for frontend closure compile errors.
loislo@chromium.org [Wed, 20 Feb 2013 13:40:19 +0000 (13:40 +0000)]
Web Inspector: fix for frontend closure compile errors.
https://bugs.webkit.org/show_bug.cgi?id=110329

Reviewed by Vsevolod Vlasov.

It has no tests because it has no code changes.

* inspector/front-end/HeapSnapshot.js:
(HeapSnapshotMetainfo):
* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClear SVGPathSeg role on removal.
fmalita@chromium.org [Wed, 20 Feb 2013 13:38:02 +0000 (13:38 +0000)]
Clear SVGPathSeg role on removal.
https://bugs.webkit.org/show_bug.cgi?id=110058

Reviewed by Dirk Schulze.

Source/WebCore:

SVGPathSegListPropertyTearOff::initialize() and SVGPathSegListPropertyTearOff::replaceItem()
need to clear the context and role for segments being expunged from the list, similarly to
removeItem(). Otherwise, processIncomingListItemValue() can get confused and attempt to
remove stale segments.

Test: svg/dom/SVGPathSegList-crash.html

* svg/properties/SVGPathSegListPropertyTearOff.cpp:
(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):
(WebCore::SVGPathSegListPropertyTearOff::clear):
(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
(WebCore):
* svg/properties/SVGPathSegListPropertyTearOff.h:
(WebCore::SVGPathSegListPropertyTearOff::initialize):
(SVGPathSegListPropertyTearOff):

LayoutTests:

* svg/dom/SVGPathSegList-crash-expected.txt: Added.
* svg/dom/SVGPathSegList-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r143434.
commit-queue@webkit.org [Wed, 20 Feb 2013 12:45:58 +0000 (12:45 +0000)]
Unreviewed, rolling out r143434.
http://trac.webkit.org/changeset/143434
https://bugs.webkit.org/show_bug.cgi?id=110326

added reftest fails on chromium mac 10.6 (Requested by
toyoshim on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-20

Source/WebCore:

* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):

LayoutTests:

* fast/forms/file/file-vertical-padding-border-expected.html: Removed.
* fast/forms/file/file-vertical-padding-border.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make debug builds possible on 32bit Linux
abecsi@webkit.org [Wed, 20 Feb 2013 12:36:45 +0000 (12:36 +0000)]
[Qt] Make debug builds possible on 32bit Linux
https://bugs.webkit.org/show_bug.cgi?id=110231

Reviewed by Tor Arne Vestbø.

Use the stabs format for debug builds to make the object files
a bit smaller so that they can be linked on a 32bit system.

* qmake/mkspecs/features/unix/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Make UISourceCode.path() an array of path segments.
vsevik@chromium.org [Wed, 20 Feb 2013 12:33:20 +0000 (12:33 +0000)]
Web Inspector: Make UISourceCode.path() an array of path segments.
https://bugs.webkit.org/show_bug.cgi?id=110229

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.prototype._filePathForPath):
(WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
(WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._contentTypeForPath):
(WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):
* inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate.prototype.requestFileContent):
(WebInspector.SimpleProjectDelegate.prototype.searchInFileContent):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleProjectDelegate.prototype._ensureUniquePath):
(WebInspector.SimpleProjectDelegate.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFileByName):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.uri):
* inspector/front-end/Workspace.js:
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCode):
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
(WebInspector.Workspace.prototype.urlForPath):

LayoutTests:

* inspector/workspace-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, update expectation for chromium gardening.
toyoshim@chromium.org [Wed, 20 Feb 2013 12:17:24 +0000 (12:17 +0000)]
Unreviewed, update expectation for chromium gardening.
https://bugs.webkit.org/show_bug.cgi?id=110324

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix message for non-existent domain warning
yurys@chromium.org [Wed, 20 Feb 2013 12:15:51 +0000 (12:15 +0000)]
Web Inspector: fix message for non-existent domain warning
https://bugs.webkit.org/show_bug.cgi?id=110315

Reviewed by Alexander Pavlov.

Only send (Heap)Profiler.resetProfiles event if the client has
requested profile headers before.

* inspector/InspectorHeapProfilerAgent.cpp:
(HeapProfilerAgentState):
(WebCore):
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorHeapProfilerAgent::clearFrontend):
(WebCore::InspectorHeapProfilerAgent::restore):
(WebCore::InspectorHeapProfilerAgent::getProfileHeaders):
* inspector/InspectorHeapProfilerAgent.h:
(InspectorHeapProfilerAgent):
* inspector/InspectorProfilerAgent.cpp:
(ProfilerAgentState):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::addProfile):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorProfilerAgent::restore):
* inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Move workspace specific code from FileMapping to workspace.
vsevik@chromium.org [Wed, 20 Feb 2013 12:06:43 +0000 (12:06 +0000)]
Web Inspector: Move workspace specific code from FileMapping to workspace.
https://bugs.webkit.org/show_bug.cgi?id=110219

Reviewed by Pavel Feldman.

Source/WebCore:

Extracted workspace specific code from FileMapping to Workspace.
This allows to reduce usage of uri and eventually make UISourceCode.path an array of path segments.

Test: inspector/workspace-mapping.html

* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.rawLocationToUILocation):
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.get addScript.get this):
(WebInspector.CompilerScriptMapping.prototype.get addScript):
* inspector/front-end/FileMapping.js:
(WebInspector.FileMapping):
(WebInspector.FileMapping.prototype.mappingEntryForURL):
(WebInspector.FileMapping.prototype.mappingEntryForPath):
* inspector/front-end/FileSystemMapping.js:
(WebInspector.FileSystemMapping.prototype.fileSystemPathForPrefix):
(WebInspector.FileSystemMappingImpl.prototype.addFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.removeFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPathForPrefix):
* inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):
(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):
* inspector/front-end/IsolatedFileSystemManager.js:
(WebInspector.IsolatedFileSystemManager):
* inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._addFile):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._workspaceUISourceCodeForScript):
* inspector/front-end/ResourceUtils.js:
(WebInspector.displayNameForURL):
* inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping.prototype._reloadCSS):
(WebInspector.SASSSourceMapping.prototype._bindUISourceCode):
(WebInspector.SASSSourceMapping.prototype.rawLocationToUILocation):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
* inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleWorkspaceProvider.pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
* inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.StylesSourceMapping.prototype._resourceAdded):
(WebInspector.StylesSourceMapping.prototype._mainFrameCreatedOrNavigated):
(WebInspector.StyleContentBinding):
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):
* inspector/front-end/Workspace.js:
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.hasMappingForURL):
(WebInspector.Workspace.prototype._fileSystemPathForEntry):
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
(WebInspector.Workspace.prototype.urlForPath):
* inspector/front-end/inspector.js:

LayoutTests:

* http/tests/inspector/compiler-script-mapping.html:
* http/tests/inspector/workspace-test.js:
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
* inspector/debugger/network-uisourcecode-provider.html:
* inspector/file-mapping-expected.txt:
* inspector/file-mapping.html:
* inspector/file-system-mapping-expected.txt:
* inspector/file-system-mapping.html:
* inspector/file-system-project.html:
* inspector/workspace-mapping-expected.txt: Added.
* inspector/workspace-mapping.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Add myself to watch lists.
toyoshim@chromium.org [Wed, 20 Feb 2013 11:48:18 +0000 (11:48 +0000)]
Unreviewed. Add myself to watch lists.

* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed BlackBerry build fix.
carlosgc@webkit.org [Wed, 20 Feb 2013 11:25:16 +0000 (11:25 +0000)]
Unreviewed BlackBerry build fix.

WebPage::download was renamed in the header by mistake to
convertMainResourceLoadToDownload in r137845.

* Api/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 20 Feb 2013 11:18:46 +0000 (11:18 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Adding failure expectations for tests added in r143395, r143420 and r143439.
* platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r143386.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Port EwkPopupMenuItem to the C API
ch.dumez@sisa.samsung.com [Wed, 20 Feb 2013 11:08:29 +0000 (11:08 +0000)]
[EFL][WK2] Port EwkPopupMenuItem to the C API
https://bugs.webkit.org/show_bug.cgi?id=108798

Reviewed by Kenneth Rohde Christiansen.

Make use of the new WKPopupItem C API inside EwkPopupMenuItem to remove
dependency on internal WebPopupItem type. Eina shared string members
are now lazily initialized to make the object cheaper to construct.

* UIProcess/API/efl/ewk_popup_menu.cpp:
(EwkPopupMenu::EwkPopupMenu):
* UIProcess/API/efl/ewk_popup_menu_item.cpp:
(EwkPopupMenuItem::EwkPopupMenuItem):
(EwkPopupMenuItem::type):
(EwkPopupMenuItem::textDirection):
(EwkPopupMenuItem::text):
(EwkPopupMenuItem::tooltipText):
(EwkPopupMenuItem::accessibilityText):
(EwkPopupMenuItem::hasTextDirectionOverride):
(EwkPopupMenuItem::isEnabled):
(EwkPopupMenuItem::isLabel):
(EwkPopupMenuItem::isSelected):
* UIProcess/API/efl/ewk_popup_menu_item_private.h:
(EwkPopupMenuItem::create):
(EwkPopupMenuItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Introduce SecurityOriginAdded and SecurityOriginRemoved events into...
apavlov@chromium.org [Wed, 20 Feb 2013 11:01:27 +0000 (11:01 +0000)]
Web Inspector: Introduce SecurityOriginAdded and SecurityOriginRemoved events into ResourceTreeModel
https://bugs.webkit.org/show_bug.cgi?id=110232

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._addSecurityOrigin): Added.
(WebInspector.ResourceTreeModel.prototype._removeSecurityOrigin): Added.
(WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached): Added.
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):

LayoutTests:

* http/tests/inspector/resource-tree/resource-tree-events-expected.txt:
* http/tests/inspector/resource-tree/resource-tree-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 20 Feb 2013 10:01:33 +0000 (10:01 +0000)]
[EFL] Unreviewed gardening.

* platform/efl/TestExpectations: Marked new failing ref test svg/as-background-image/tiled-background-image.html.
* platform/efl/fast/js/global-constructors-expected.txt: Rebaselined, MutationObserver constructor now found.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[v8] ScriptValue has dangerous copy semantics
commit-queue@webkit.org [Wed, 20 Feb 2013 09:58:37 +0000 (09:58 +0000)]
[v8] ScriptValue has dangerous copy semantics
https://bugs.webkit.org/show_bug.cgi?id=110206

Patch by Dan Carney <dcarney@google.com> on 2013-02-20
Reviewed by Kentaro Hara.

Update ScriptValue to used a SharedPersistent,
making it impossible to return dead references.

No new tests. No change in functionality.

* bindings/v8/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):
(WebCore::ScriptValue::toInspectorValue):
* bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::operator=):
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::isEqual):
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):
(WebCore::ScriptValue::clear):
(ScriptValue):
(WebCore::ScriptValue::v8Value):
(WebCore::ScriptValue::v8ValueRaw):
* bindings/v8/SharedPersistent.h:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::scriptValueAsNode):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAttrGetterCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: highlight undefined word in JavaScript
commit-queue@webkit.org [Wed, 20 Feb 2013 09:44:37 +0000 (09:44 +0000)]
Web Inspector: highlight undefined word in JavaScript
https://bugs.webkit.org/show_bug.cgi?id=109585

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-20
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test enhancement: inspector/syntax-highlight-javascript.html

Add global object value properties to tokenizer and add a css style
class to highlight "undefined" with gray color.

* inspector/front-end/SourceJavaScriptTokenizer.js:
(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
* inspector/front-end/SourceJavaScriptTokenizer.re2js:
* inspector/front-end/inspectorSyntaxHighlight.css:
(.webkit-javascript-undef):

LayoutTests:

Enhance layout test to verify highlighting of global object value properties.

* inspector/syntax-highlight-javascript-expected.txt:
* inspector/syntax-highlight-javascript.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse EventPathWalker rather than parentNode() to normalize event targets in EventHandler.
mkwst@chromium.org [Wed, 20 Feb 2013 09:43:11 +0000 (09:43 +0000)]
Use EventPathWalker rather than parentNode() to normalize event targets in EventHandler.
https://bugs.webkit.org/show_bug.cgi?id=110037

Reviewed by Ryosuke Niwa.

Source/WebCore:

We need to teach EventHandler about Shadow DOM in a few places in order
to ensure that we properly target events dispatched upon text nodes.
Rather than naively grabbing the text node's direct parent via
parentNode(), we need to account for the case in which the text node is
distributed[1] to an insertion point inside a shadow host.
EventPathWalker::parent understands these relationships, and should
be used when dealing with mouse, drag, and touch events.

[1]: http://www.w3.org/TR/shadow-dom/#dfn-distribution

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::passGestureEventToWidgetIfPossible):
(WebCore::EventHandler::updateDragAndDrop):
    Refactor parentNode callsites to use EventPathWalker::parent().

LayoutTests:

* fast/dom/shadow/resources/event-dispatching.js:
(scrollMouseWheel):
(addEventListeners):
    Add MouseWheel, Drag, and Touch support to the event-dispatching
    tests in Shadow DOM.
* fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node.html:
* fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root.html:
    Scroll the mouse wheel, drag a bit, and touch before leaving the
    text node, and record the generated events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Regression] Search in ProfilesPanel is broken
vsevik@chromium.org [Wed, 20 Feb 2013 09:24:00 +0000 (09:24 +0000)]
Web Inspector: [Regression] Search in ProfilesPanel is broken
https://bugs.webkit.org/show_bug.cgi?id=110312

Reviewed by Pavel Feldman.

* inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype.matchesQuery):
(WebInspector.CPUProfileView.prototype.performSearch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: View.markAsRoot should never be invoked on attached view.
eustas@chromium.org [Wed, 20 Feb 2013 09:21:09 +0000 (09:21 +0000)]
Web Inspector: View.markAsRoot should never be invoked on attached view.
https://bugs.webkit.org/show_bug.cgi?id=110224

Reviewed by Pavel Feldman.

This will cause CSS loading problems after "show".

* inspector/front-end/Drawer.js:
Ensure child view is detached before marked as root.
* inspector/front-end/View.js:
(WebInspector.View.prototype.markAsRoot): Added assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Wed, 20 Feb 2013 09:17:34 +0000 (09:17 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/TestExpectations:
* platform/qt/fast/js/global-constructors-expected.txt: Rebaseline after r143420.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardenning. Unskip now passing tests.
kadam@inf.u-szeged.hu [Wed, 20 Feb 2013 09:06:08 +0000 (09:06 +0000)]
[Qt] Unreviewed gardenning. Unskip now passing tests.
https://bugs.webkit.org/show_bug.cgi?id=99306

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFile upload control doesn't apply CSS vertical padding or border to file name
commit-queue@webkit.org [Wed, 20 Feb 2013 08:10:10 +0000 (08:10 +0000)]
File upload control doesn't apply CSS vertical padding or border to file name
https://bugs.webkit.org/show_bug.cgi?id=109011

Patch by Nils Barth <nbarth@google.com> on 2013-02-20
Reviewed by Hajime Morrita.

Source/WebCore:

Test: fast/forms/file/file-vertical-padding-border.html

* rendering/RenderFileUploadControl.cpp:
    Add borderTop() and paddingTop() when computing position.
(WebCore::RenderFileUploadControl::paintObject):

LayoutTests:

* fast/forms/file/file-vertical-padding-border.html: Added.
* fast/forms/file/file-vertical-padding-border-expected.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Mark fast/regions/seamless-iframe-flowed-into-regions.html failure
commit-queue@webkit.org [Wed, 20 Feb 2013 07:42:09 +0000 (07:42 +0000)]
[EFL] Mark fast/regions/seamless-iframe-flowed-into-regions.html failure
https://bugs.webkit.org/show_bug.cgi?id=110283

Unreviewed. This test is added by r143256 and it is failing.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-19

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFew methods in WebGLRenderingContext.idl have incorrect signatures
aandrey@chromium.org [Wed, 20 Feb 2013 06:54:23 +0000 (06:54 +0000)]
Few methods in WebGLRenderingContext.idl have incorrect signatures
https://bugs.webkit.org/show_bug.cgi?id=110305

Reviewed by Kentaro Hara.

* html/canvas/WebGLRenderingContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r143393.
commit-queue@webkit.org [Wed, 20 Feb 2013 06:14:19 +0000 (06:14 +0000)]
Unreviewed, rolling out r143393.
http://trac.webkit.org/changeset/143393
https://bugs.webkit.org/show_bug.cgi?id=110302

the converted reftest fails in chromium mac 10.6 and 10.7
(Requested by toyoshim on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19

* fast/flexbox/box-orient-button.html:
* fast/flexbox/resources/box-orient-button.js:
* fast/invalid/residual-style-expected.html: Removed.
* fast/invalid/residual-style.html:
* platform/chromium-android/fast/invalid/residual-style-expected.png: Added.
* platform/chromium-android/fast/invalid/residual-style-expected.txt: Added.
* platform/chromium-linux/fast/invalid/residual-style-expected.png: Added.
* platform/chromium-linux/fast/invalid/residual-style-expected.txt: Added.
* platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Added.
* platform/chromium-mac/fast/invalid/residual-style-expected.png: Added.
* platform/chromium-mac/fast/invalid/residual-style-expected.txt: Added.
* platform/chromium-win/fast/invalid/residual-style-expected.png: Added.
* platform/chromium-win/fast/invalid/residual-style-expected.txt: Added.
* platform/efl/fast/invalid/residual-style-expected.png: Added.
* platform/efl/fast/invalid/residual-style-expected.txt: Added.
* platform/gtk/fast/invalid/residual-style-expected.png: Added.
* platform/gtk/fast/invalid/residual-style-expected.txt: Added.
* platform/mac/fast/invalid/residual-style-expected.png: Added.
* platform/mac/fast/invalid/residual-style-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, uninteresting change to test a theory about bad dependency handling.
mrowe@apple.com [Wed, 20 Feb 2013 06:02:17 +0000 (06:02 +0000)]
Unreviewed, uninteresting change to test a theory about bad dependency handling.

* API/JSStringRefCF.cpp:
(JSStringCreateWithCFString): Remove an unnecessary else clause.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r143338.
commit-queue@webkit.org [Wed, 20 Feb 2013 05:57:29 +0000 (05:57 +0000)]
Unreviewed, rolling out r143338.
http://trac.webkit.org/changeset/143338
https://bugs.webkit.org/show_bug.cgi?id=110301

False alarm, no need to export the symbol (Requested by
aandrey on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19

* WebKit.vcproj/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClarify isInWindow vs. isVisible path through to RenderLayerCompositor
timothy_horton@apple.com [Wed, 20 Feb 2013 05:53:02 +0000 (05:53 +0000)]
Clarify isInWindow vs. isVisible path through to RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=110261
<rdar://problem/13196122>

Reviewed by Simon Fraser.

Remove RenderLayerCompositor::willMoveOffscreen/didMoveOnscreen.
Add RenderLayerCompositor::setIsInWindow, and pipe in-window changes through from Page::setIsInWindow.
Adjust a few Document functions that previously called RenderView::didMoveOnscreen/willMoveOffscreen to use setIsInWindow instead, since in-win$

* WebCore.exp.in: Export Page::setIsInWindow.
* dom/Document.cpp:
(WebCore::Document::attach): Use setIsInWindow instead of didMoveOnscreen.
(WebCore::Document::documentWillBecomeInactive): Use setIsInWindow instead of willMoveOffscreen.
(WebCore::Document::documentDidResumeFromPageCache): Use setIsInWindow instead of didMoveOnscreen.
* page/FrameView.cpp:
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
RenderView doesn't care about moving on/offscreen, just in-window state.
(WebCore::FrameView::setIsInWindow): Added. Forward isInWindow changes to our RenderView.
* page/FrameView.h:
(FrameView): Add setIsInWindow.
* page/Page.cpp:
(WebCore::Page::setIsInWindow): Added. Forward isInWindow changes to the Page's FrameViews.
* page/Page.h:
(Page): Add setIsInWindow.
(WebCore::Page::isInWindow):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::setIsInWindow): Added. Replace willMoveOffscreen/didMoveOnscreen with setIsInWindow,
since that's the only change we actually care about.
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor): Add setIsInWindow.
* rendering/RenderView.cpp:
(WebCore::RenderView::setIsInWindow): Added. Replace willMoveOffscreen/didMoveOnscreen with setIsInWindow,
since that's the only change RenderLayerCompositor actually cares about.
* rendering/RenderView.h:
(RenderView): Add setIsInWindow.

* WebView/WebView.mm:
(-[WebView viewWillMoveToWindow:]):
(-[WebView viewDidMoveToWindow]):
Use Page::setIsInWindow in addition to willMoveOffscreen/didMoveOnscreen.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setIsInWindow):
Use Page::setIsInWindow in addition to willMoveOffscreen/didMoveOnscreen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Cleanup and add JSDocs to SuggestBox
eustas@chromium.org [Wed, 20 Feb 2013 05:24:35 +0000 (05:24 +0000)]
Web Inspector: Cleanup and add JSDocs to SuggestBox
https://bugs.webkit.org/show_bug.cgi?id=110202

Reviewed by Pavel Feldman.

SuggestBox contains some obsolete/unused code and not fully
covered with JSDocs.

* inspector/front-end/SuggestBox.js:
(WebInspector.SuggestBox.prototype.visible):
Replaced getter with function.
(WebInspector.SuggestBox.prototype._onScrollOrResize):
Use camel-case for function names.
(WebInspector.SuggestBox.prototype._onBoxMouseDown): Ditto.
(WebInspector.SuggestBox.prototype.updateSuggestions):
Removed unused code.
(WebInspector.SuggestBox.prototype.hide): Adopt changes.
(WebInspector.SuggestBox.prototype._applySuggestion): Ditto.
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.isSuggestBoxVisible): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143427 268f45cc-cd09-0410-ab3c-d52691b4dbfc