abecsi@webkit.org [Sat, 30 Jan 2010 00:00:04 +0000 (00:00 +0000)]
Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
This fixes a regression introduced in r53559.
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=34336
* Scripts/webkitperl/httpd.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Sat, 30 Jan 2010 00:00:01 +0000 (00:00 +0000)]
WebCore: Drag and Drop: Windows uses "stop" sign as cursor when dragging
https://bugs.webkit.org/show_bug.cgi?id=34305
<rdar://problem/7589672>
Reviewed by Adam Roben.
Add a FIXME for the code that needs to be changed to support full
custom cursors.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag):
WebKit/win: Drag and Drop: Windows uses "stop" sign as cursor when dragging
https://bugs.webkit.org/show_bug.cgi?id=34305
<rdar://problem/7589672>
Reviewed by Adam Roben.
Add a preference in WebKit (that defaults to false), for whether or not
we should show the custom cursors during drag and drop. However, this is
currently only used on Windows, and only used to hide the "drop not allowed"
icon inside the WebView is the preference is set to true.
This will be off by default, so no change in behavior.
* Interfaces/IWebPreferencesPrivate.idl: Added new functions.
* Interfaces/WebKit.idl: Touched to force Interfaces build.
* WebDropSource.cpp:
(WebDropSource::GiveFeedback): Implementation of conditional showing cursor
logic.
* WebPreferenceKeysPrivate.h: Added new preference key.
* WebPreferences.cpp: Added new functions.
(WebPreferences::setCustomDragCursorsEnabled):
(WebPreferences::customDragCursorsEnabled):
* WebPreferences.h: Added new functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54083
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Fri, 29 Jan 2010 23:39:41 +0000 (23:39 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54082
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 29 Jan 2010 22:26:59 +0000 (22:26 +0000)]
Reviewed by Dan Bernstein.
<rdar://problem/7441982> REGRESSION (TOT): Adobe CS4: Installer alerts are displayed as
blank windows
We probably shouldn't be deferring loads below modal dialogs and alerts, because that's not
what being modal means. But making such a change for general Web content would require fixes
in other parts of code, which I'm not ready to implement right now, so making it application
specific.
WebCore:
* page/Page.cpp: (WebCore::Page::setDefersLoading): Do nothing if load deferring is not
enabled in page settings.
* WebCore.base.exp:
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadDeferringEnabled):
* page/Settings.h: (WebCore::Settings::loadDeferringEnabled):
Add the ability for client to disable page deferring (still enabled by default).
* platform/mac/RuntimeApplicationChecks.h:
* platform/mac/RuntimeApplicationChecks.mm: (WebCore::applicationIsAdobeInstaller):
Added a bundle ID test for Adobe installer.
WebKit/mac:
* WebView/WebView.mm:
(shouldEnableLoadDeferring): Load deferring is enabled unless the application is Adobe
Installer.
(-[WebView _preferencesChangedNotification:]): Call setLoadDeferringEnabled().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54081
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 29 Jan 2010 22:16:36 +0000 (22:16 +0000)]
Build fix.
* page/Geolocation.cpp:
(WebCore::Geolocation::startUpdating):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54080
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 29 Jan 2010 22:08:05 +0000 (22:08 +0000)]
2010-01-29 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Client-based Geolocation starts updating before getting consent from the user
https://bugs.webkit.org/show_bug.cgi?id=34343
* page/Geolocation.cpp:
(WebCore::Geolocation::startRequest): Pass notifier instead of options to startUpdating.
(WebCore::Geolocation::setIsAllowed): Add the observer or notify of error for deferred startUpdating.
(WebCore::Geolocation::startUpdating): Pass notifier instead of options, since we may need to call it if we fail to get user consent.
Defer adding the observer if we don't yet have user consent, since this could kick off
server-based wifi Geolocation requests.
* page/Geolocation.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54079
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Fri, 29 Jan 2010 21:55:58 +0000 (21:55 +0000)]
MSAA: Crash when posting a notification for a detached object
https://bugs.webkit.org/show_bug.cgi?id=34309
<rdar://problem/7409759>
Reviewed by Darin Adler.
WebCore:
Test: platform/win/accessibility/detached-object-notification-crash.html
* accessibility/AccessibilityRenderObject.cpp:
(AccessibilityRenderObject::document):
Null check m_renderer. This is the bug fix; the other changes in the
patch are for the test.
* accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
Map AXValueChanged to EVENT_OBJECT_VALUECHANGED, so we'll post a
notification when AXValueChanged is posted. Receiving an event of this
type tells us that the test passed.
WebKit/win:
* AccessibleBase.cpp:
(AccessibleBase::QueryService):
If an unrecognized service ID is passed, return early. Otherwise, return
the result of QueryInterface.
(AccessibleBase::QueryInterface):
Add static_casts. Check for new UUIDs.
(AccessibleBase::isSameObject):
Query the object for AccessibleBase. Return whether the pointers or the
wrapped objects match.
* AccessibleBase.h:
Give the class a UUID so we can query for it in isSameObject(). Inherit
from IAccessibleComparable; inherit from IServiceProvider so clients can
use QueryService to query for a custom interface.
* Interfaces/AccessibleComparable.idl: Added. Declares a function that
can be called to compare to accessible objects.
* Interfaces/WebKit.idl:
Include the new IDL.
* WebKit.vcproj/Interfaces.vcproj:
Add the new IDL to the project.
WebKitTools:
* DumpRenderTree/AccessibilityController.h:
Declare new functions. Add new members to store the event hook and the
mapping of accessibility elements to their JS callbacks.
* DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::notificationReceived):
Stubbed.
(AccessibilityController::addNotificationListener):
Stubbed.
* DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::notificationReceived):
Stubbed.
(AccessibilityController::addNotificationListener):
Stubbed.
* DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::AccessibilityController):
Initialize the event hook.
(AccessibilityController::~AccessibilityController):
Remove the event hook. Unprotect all of the JS functions that are stored
in the map.
(logEventProc):
Clean-up a variable.
(stringEvent):
Return a string description of the MSAA event code.
(notificationListenerProc):
Get the accessible object from the event, and query it for IAccessible.
Call the AccessibilityController's notificationReceived().
(comparableObject):
Use QueryService to obtain the IAccessibleComparable for the
IServiceProvider.
(AccessibilityController::notificationReceived):
Iterate the map of objects that have registered for notification
callbacks. Query each for IServiceProvider, then use comparableObject()
to get an IAccessibleComparable. If we find an object matching the
notified object, call its callback, passing the event that was received.
(AccessibilityController::addNotificationListener):
If we have not created the event hook, create it. Protect the JS
callback function object, and add the object and its callback to our
map.
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::addNotificationListener):
Call through to the AccessibilityController's addNotificationListener().
* DumpRenderTree/win/DumpRenderTreeWin.h:
Add an extern declaration for the shared FrameLoadDelegate extern, so we
can access it from AccessibilityController.
* DumpRenderTree/win/FrameLoadDelegate.h:
(FrameLoadDelegate::accessibilityController):
Return the AccessibilityController.
LayoutTests:
* platform/win/accessibility/detached-object-notification-crash-expected.txt: Added.
* platform/win/accessibility/detached-object-notification-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54078
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Fri, 29 Jan 2010 21:32:27 +0000 (21:32 +0000)]
Rubberstamped by Simon Hausmann.
[Qt] Separate implementation from class definition.
* QtLauncher/main.cpp:
(LauncherWindow::webView):
(LauncherWindow::LauncherWindow):
(LauncherWindow::~LauncherWindow):
(LauncherWindow::keyPressEvent):
(LauncherWindow::grabZoomKeys):
(LauncherWindow::sendTouchEvent):
(LauncherWindow::eventFilter):
(LauncherWindow::loadStarted):
(LauncherWindow::loadFinished):
(LauncherWindow::showLinkHover):
(LauncherWindow::zoomIn):
(LauncherWindow::zoomOut):
(LauncherWindow::resetZoom):
(LauncherWindow::toggleZoomTextOnly):
(LauncherWindow::print):
(LauncherWindow::screenshot):
(LauncherWindow::setEditable):
(LauncherWindow::dumpHtml):
(LauncherWindow::selectElements):
(LauncherWindow::setTouchMocking):
(LauncherWindow::newWindow):
(LauncherWindow::setupUI):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54077
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 21:12:04 +0000 (21:12 +0000)]
2010-01-29 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
prepare-ChangeLog outputs useless messages for a nonexistent bug ID
https://bugs.webkit.org/show_bug.cgi?id=34313
* Scripts/prepare-ChangeLog:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Fri, 29 Jan 2010 20:21:30 +0000 (20:21 +0000)]
2010-01-29 Darin Fisher <darin@chromium.org>
Okayed by Oliver Hunt.
Rollout r53949, r53951 and r54013 due to a Chromium regression that it
causes. Somehow this code change is triggering an endless repaint loop.
https://bugs.webkit.org/show_bug.cgi?id=33808
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawTiledImage):
* platform/graphics/GraphicsContext.h:
* platform/graphics/transforms/TransformationMatrix.h:
(WebCore::TransformationMatrix::isIdentityOrTranslation):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::~RenderBoxModelObject):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderBoxModelObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Fri, 29 Jan 2010 19:47:26 +0000 (19:47 +0000)]
[Qt] On Maemo5, a click/touch in the location bar (when unfocused)
should result in all text selected.
Reviewed by Ariya Hidayat.
* QtLauncher/locationedit.cpp:
(LocationEdit::focusInEvent):
* QtLauncher/locationedit.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 29 Jan 2010 19:46:57 +0000 (19:46 +0000)]
2010-01-29 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321
Remove the unsafe two argument Structure::create method, and correct
the uses of it to propagate the anonymous slot count.
* runtime/JSObject.h:
(JSC::JSObject::setStructure):
* runtime/Structure.cpp:
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
* runtime/Structure.h:
2010-01-29 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321
Add a test for modification of a type with anonymous slots.
* fast/dom/Window/anonymous-slot-with-changes-expected.txt: Added.
* fast/dom/Window/anonymous-slot-with-changes.html: Added.
2010-01-29 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321
Make code generator add assertions for anonymous slot count.
Test: fast/dom/Window/anonymous-slot-with-changes.html
* bindings/scripts/CodeGeneratorJS.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54073
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Fri, 29 Jan 2010 19:46:56 +0000 (19:46 +0000)]
[Qt] Show progress reaching 100% for loads.
Reviewed by Ariya Hidayat.
* QtLauncher/locationedit.cpp:
(LocationEdit::LocationEdit):
(LocationEdit::setProgress):
(LocationEdit::reset):
(LocationEdit::paintEvent):
* QtLauncher/locationedit.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 18:32:33 +0000 (18:32 +0000)]
2010-01-29 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
Add gdb helper methods for Ranges like we have for VisibleSelections.
https://bugs.webkit.org/show_bug.cgi?id=34308
No new tests, these are only for debugging.
* dom/Position.cpp:
(WebCore::Position::showTreeForThis):
* dom/Range.cpp:
(showTree):
* dom/Range.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 18:13:10 +0000 (18:13 +0000)]
2010-01-29 Drew Wilson <atwilson@chromium.org>
Reviewed by Adam Barth.
V8 implementation of MessageEvent.initMessageEvent() does not set source correctly.
https://bugs.webkit.org/show_bug.cgi?id=34292
Test: fast/events/init-events.html will pass in Chrome now.
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::initMessageEventCallback):
Now properly extracts the reference to the DOMWindow object from the passed-in window parameter.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 17:56:44 +0000 (17:56 +0000)]
2010-01-29 Ben Murdoch <benm@google.com>
Reviewed by Dimitri Glazkov.
[Android] Android needs functionality in the ChromeClient to be informed when touch events are and are not needed by the webpage.
https://bugs.webkit.org/show_bug.cgi?id=34215
Add a function on the ChromeClient that WebCore can use to inform the platform when it needs touch events. This way the platform can optimise by not forwarding the events if they are not required.
No new tests as the only implementation is specific to Android.
* dom/Document.cpp:
(WebCore::Document::detach): Check if this is the top level document and if so, stop forwarding touch events.
(WebCore::Document::addListenerTypeIfNeeded): Inform the ChromeClient it should start forwarding touch events and guard touch event code properly.
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore): If the document uses touch events, inform the ChromeClient to start forwarding them.
(WebCore::CachedFrame::CachedFrame): If the document uses touch events, inform the ChromeClient to stop forwarding them, as the document is being put into the page cache.
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::needTouchEvents): Add an empty implementation.
* page/ChromeClient.h: Add the needTouchEvents() function.
2010-01-29 Ben Murdoch <benm@google.com>
Reviewed by Dimitri Glazkov.
[Android] Android needs functionality in the ChromeClient to be informed when touch events are and are not needed by the webpage.
https://bugs.webkit.org/show_bug.cgi?id=34215
Add needTouchEvents() to the ChromeClient which is called when the page decides it needs or no longer needs to be informed of touch events.
* WebCoreSupport/ChromeClientQt.h:
(WebCore::ChromeClientQt::needTouchEvents): Add an empty implementation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 17:38:45 +0000 (17:38 +0000)]
2010-01-29 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Fix toolbar gradient to match the window's titlebar on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=34320
* inspector/front-end/inspector.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54068
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 17:22:23 +0000 (17:22 +0000)]
2010-01-29 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Fix MacOS X version detection
MacOS X version can have 2 or 3 segments.
https://bugs.webkit.org/show_bug.cgi?id=34322
* inspector/front-end/inspector.js:
(WebInspector._detectPlatform):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 17:06:01 +0000 (17:06 +0000)]
2010-01-29 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Disable the QtLauncher statusbar on Maemo
https://bugs.webkit.org/show_bug.cgi?id=34330
* QtLauncher/main.cpp:
(LauncherWindow::showLinkHover):
(LauncherWindow::selectElements):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54066
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 16:49:39 +0000 (16:49 +0000)]
2010-01-29 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Display page loading progress inside the QtLauncher location bar
https://bugs.webkit.org/show_bug.cgi?id=34210
* QtLauncher/QtLauncher.pro:
* QtLauncher/locationedit.cpp: Added.
(LocationEdit::LocationEdit):
(LocationEdit::setProgress):
(LocationEdit::paintEvent):
* QtLauncher/locationedit.h: Added.
* QtLauncher/mainwindow.cpp:
(MainWindow::buildUI):
* QtLauncher/mainwindow.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Fri, 29 Jan 2010 16:25:18 +0000 (16:25 +0000)]
Disable auto-uppercase and predictive text on Maemo5, just like the
build-in MicroB Browser.
Reviewed by Simon Hausmann
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jpetsovits@rim.com [Fri, 29 Jan 2010 15:43:08 +0000 (15:43 +0000)]
2010-01-29 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Nikolas Zimmermann.
[OpenVG] Implement a basic GraphicsContext on top of a new PainterOpenVG class
https://bugs.webkit.org/show_bug.cgi?id=33405
PainterOpenVG provides painter state management that works
on a single (EGL) context, and apart from painter state
implements a single drawing operation (for now), drawRect().
It is a generic painter class that cooperates with
SurfaceOpenVG to enable robust surface/context switching
(given that EGL doesn't notify us if somebody switches
the surface/context behind our backs), and provides
painting operations close to OpenVG's way of working
that GraphicsContext, Path, Image, Font and other WebKit
platform classes can use to draw on.
Initial code for state management and OpenVG scissoring by
Eli Fidler <efidler@rim.com>. VGRect/VGMatrix and the bulk
of the transformations code by Adam Treat <atreat@rim.com>.
Preliminary drawFocusRing() implementation by Yong Li <yoli@rim.com>.
* platform/graphics/FloatRect.h:
* platform/graphics/GraphicsContext.cpp:
* platform/graphics/GraphicsContext.h:
* platform/graphics/openvg/GraphicsContextOpenVG.cpp: Added.
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::platformContext):
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::beginPath):
(WebCore::GraphicsContext::addPath):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clearPlatformShadow):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineDash):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::setMiterLimit):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::setCompositeOperation):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::origin):
(WebCore::GraphicsContext::clipOutEllipseInRect):
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformStrokeStyle):
(WebCore::GraphicsContext::setPlatformStrokeThickness):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformShouldAntialias):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
* platform/graphics/openvg/PainterOpenVG.cpp: Added.
(WebCore::isNonRotatedAffineTransformation):
(WebCore::toVGCapStyle):
(WebCore::toVGJoinStyle):
(WebCore::toVGFillRule):
(WebCore::colorToVGColor):
(WebCore::setVGSolidColor):
(WebCore::PlatformPainterState::PlatformPainterState):
(WebCore::PlatformPainterState::copyPaintState):
(WebCore::PlatformPainterState::applyState):
(WebCore::PlatformPainterState::applyBlending):
(WebCore::PlatformPainterState::applyTransformationMatrix):
(WebCore::PlatformPainterState::applyScissorRect):
(WebCore::PlatformPainterState::applyStrokeStyle):
(WebCore::PlatformPainterState::strokeDisabled):
(WebCore::PlatformPainterState::fillDisabled):
(WebCore::PainterOpenVG::PainterOpenVG):
(WebCore::PainterOpenVG::~PainterOpenVG):
(WebCore::PainterOpenVG::begin):
(WebCore::PainterOpenVG::end):
(WebCore::PainterOpenVG::destroyPainterStates):
(WebCore::PainterOpenVG::applyState):
(WebCore::PainterOpenVG::blitToSurface):
(WebCore::PainterOpenVG::transformationMatrix):
(WebCore::PainterOpenVG::concatTransformationMatrix):
(WebCore::PainterOpenVG::setTransformationMatrix):
(WebCore::PainterOpenVG::compositeOperation):
(WebCore::PainterOpenVG::setCompositeOperation):
(WebCore::PainterOpenVG::opacity):
(WebCore::PainterOpenVG::setOpacity):
(WebCore::PainterOpenVG::strokeThickness):
(WebCore::PainterOpenVG::setStrokeThickness):
(WebCore::PainterOpenVG::strokeStyle):
(WebCore::PainterOpenVG::setStrokeStyle):
(WebCore::PainterOpenVG::setLineDash):
(WebCore::PainterOpenVG::setLineCap):
(WebCore::PainterOpenVG::setLineJoin):
(WebCore::PainterOpenVG::setMiterLimit):
(WebCore::PainterOpenVG::strokeColor):
(WebCore::PainterOpenVG::setStrokeColor):
(WebCore::PainterOpenVG::fillColor):
(WebCore::PainterOpenVG::setFillColor):
(WebCore::PainterOpenVG::antialiasingEnabled):
(WebCore::PainterOpenVG::setAntialiasingEnabled):
(WebCore::PainterOpenVG::scale):
(WebCore::PainterOpenVG::rotate):
(WebCore::PainterOpenVG::translate):
(WebCore::PainterOpenVG::intersectScissorRect):
(WebCore::PainterOpenVG::intersectClipRect):
(WebCore::PainterOpenVG::drawRect):
(WebCore::PainterOpenVG::save):
(WebCore::PainterOpenVG::restore):
* platform/graphics/openvg/PainterOpenVG.h: Added.
(WebCore::PainterOpenVG::):
(WebCore::PainterOpenVG::surface):
* platform/graphics/openvg/SurfaceOpenVG.cpp:
(WebCore::SurfaceOpenVG::SurfaceOpenVG):
(WebCore::SurfaceOpenVG::~SurfaceOpenVG):
(WebCore::SurfaceOpenVG::makeCurrent):
(WebCore::SurfaceOpenVG::makeCompatibleCurrent):
(WebCore::SurfaceOpenVG::setActivePainter):
(WebCore::SurfaceOpenVG::activePainter):
* platform/graphics/openvg/SurfaceOpenVG.h:
(WebCore::SurfaceOpenVG::):
* platform/graphics/openvg/VGUtils.cpp: Added.
(WebCore::VGMatrix::VGMatrix):
(WebCore::VGMatrix::operator TransformationMatrix):
(WebCore::TransformationMatrix::operator VGMatrix):
(WebCore::VGRect::VGRect):
(WebCore::VGRect::operator FloatRect):
(WebCore::FloatRect::operator VGRect):
* platform/graphics/openvg/VGUtils.h:
(WebCore::VGMatrix::toVGfloat):
(WebCore::VGRect::toVGfloat):
* platform/graphics/transforms/TransformationMatrix.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 29 Jan 2010 15:42:27 +0000 (15:42 +0000)]
2010-01-29 Philippe Normand <pnormand@igalia.com>
Unreviewed, build fix.
http/tests/media/video-referer.html fails on mac
https://bugs.webkit.org/show_bug.cgi?id=34331
Skipping the failing test. Requires further investigation.
* platform/mac-leopard/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-tiger/Skipped:
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 29 Jan 2010 15:04:43 +0000 (15:04 +0000)]
2010-01-29 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] Vimeo HTML5 player doesn't work
https://bugs.webkit.org/show_bug.cgi?id=34327
Send Referer when requesting media over HTTP.
Test: http/tests/media/video-referer.html
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateSourceChangedCallback):
2010-01-29 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] Vimeo HTML5 player doesn't work
https://bugs.webkit.org/show_bug.cgi?id=34327
Test for HTTP Referer checking when playing remote media.
* http/tests/media/resources/setCookieAndReferer.cgi: Added.
* http/tests/media/resources/video-referer-check-referer.php: Added.
* http/tests/media/video-referer-expected.txt: Added.
* http/tests/media/video-referer.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54061
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 29 Jan 2010 14:33:13 +0000 (14:33 +0000)]
[Qt] Speed up the WebCore::String -> QString conversion
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-01-29
Reviewed by Simon Hausmann.
Use QString(const QChar *, int len) constructor instead of QString::fromUtf16 to
avoid BOM checks and byteswapping.
* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fieldNamed):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54060
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 29 Jan 2010 14:10:54 +0000 (14:10 +0000)]
2010-01-29 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Source view displays text using wrong fonts
https://bugs.webkit.org/show_bug.cgi?id=34269
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor):
(WebInspector.TextEditor.prototype._initFont):
* inspector/front-end/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54059
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 14:00:29 +0000 (14:00 +0000)]
2010-01-29 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add support for Maemo zoom keys in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=34160
* QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(LauncherWindow::~LauncherWindow):
(LauncherWindow::keyPressEvent):
(LauncherWindow::grabZoomKeys):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 29 Jan 2010 13:41:23 +0000 (13:41 +0000)]
2010-01-29 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Add API methods for loading inspector utility scripts.
https://bugs.webkit.org/show_bug.cgi?id=34326
* public/WebDevToolsAgentClient.h:
(WebKit::WebDevToolsAgentClient::injectedScriptSource):
(WebKit::WebDevToolsAgentClient::injectedScriptDispatcherSource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 13:29:04 +0000 (13:29 +0000)]
2010-01-29 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] Apple trailers don't play anymore
https://bugs.webkit.org/show_bug.cgi?id=34316
Fake QuickTime when accessing movie trailers.
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateSourceChangedCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Fri, 29 Jan 2010 13:02:47 +0000 (13:02 +0000)]
Unreviewed.
[Qt] Remove disabled tests from Skiplist. The tests were disabled in r53701.
* platform/qt/Skipped:
-css2.1/t1204-increment-00-c-o.html
-css2.1/t1204-increment-01-c-o.html
-css2.1/t1204-increment-02-c-o.html
-css2.1/t1204-reset-00-c-o.html
-css2.1/t1204-reset-01-c-o.html
-css2.1/t1204-reset-02-c-o.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 12:17:10 +0000 (12:17 +0000)]
2010-01-29 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement the display() method of the layout test controller
https://bugs.webkit.org/show_bug.cgi?id=34258
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::showPage):
(WebCore::DumpRenderTree::hidePage):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
(LayoutTestController::display):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54054
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 29 Jan 2010 11:04:09 +0000 (11:04 +0000)]
2010-01-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: migrate to tokenizer-based highlighting in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=34273
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/CSSSourceSyntaxHighlighter.js: Removed.
* inspector/front-end/DOMSyntaxHighlighter.js: Added.
(WebInspector.DOMSyntaxHighlighter):
(WebInspector.DOMSyntaxHighlighter.prototype.createSpan):
(WebInspector.DOMSyntaxHighlighter.prototype.syntaxHighlightNode):
* inspector/front-end/ElementsTreeOutline.js:
* inspector/front-end/JavaScriptSourceSyntaxHighlighter.js: Removed.
* inspector/front-end/SourceCSSTokenizer.js:
(WebInspector.SourceCSSTokenizer):
(WebInspector.SourceCSSTokenizer.prototype.nextToken):
* inspector/front-end/SourceCSSTokenizer.re2js:
* inspector/front-end/SourceHTMLTokenizer.js:
(WebInspector.SourceHTMLTokenizer):
(WebInspector.SourceHTMLTokenizer.prototype.nextToken):
* inspector/front-end/SourceHTMLTokenizer.re2js:
* inspector/front-end/SourceJavaScriptTokenizer.js:
(WebInspector.SourceJavaScriptTokenizer):
(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
* inspector/front-end/SourceJavaScriptTokenizer.re2js:
* inspector/front-end/SourceSyntaxHighlighter.js: Removed.
* inspector/front-end/SourceTokenizer.js: Added.
(WebInspector.SourceTokenizer):
(WebInspector.SourceTokenizer.prototype.set line):
(WebInspector.SourceTokenizer.prototype.set condition):
(WebInspector.SourceTokenizer.prototype.get condition):
(WebInspector.SourceTokenizer.prototype.hasCondition):
(WebInspector.SourceTokenizer.prototype.getLexCondition):
(WebInspector.SourceTokenizer.prototype.setLexCondition):
(WebInspector.SourceTokenizer.prototype._charAt):
(WebInspector.SourceTokenizer.Registry):
(WebInspector.SourceTokenizer.Registry.getInstance):
(WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter):
(WebInspector.TextEditorHighlighter.prototype.set mimeType):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
LayoutTests:
* inspector/syntax-highlight-css-expected.txt:
* inspector/syntax-highlight-css.html:
* inspector/syntax-highlight-javascript-expected.txt:
* inspector/syntax-highlight-javascript.html:
* inspector/syntax-highlight.js:
(frontend_dumpSyntaxHighlight):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54053
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 29 Jan 2010 10:38:15 +0000 (10:38 +0000)]
2010-01-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: No need to render background sources
when performing search.
https://bugs.webkit.org/show_bug.cgi?id=34263
* inspector/front-end/ScriptView.js:
(WebInspector.ScriptView):
(WebInspector.ScriptView.prototype.show):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.set visible):
(WebInspector.SourceFrame.prototype.set executionLine):
(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype.clearMessages):
(WebInspector.SourceFrame.prototype.sizeToFitContentHeight):
(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype._createEditorIfNeeded):
(WebInspector.SourceFrame.prototype.setSelection):
(WebInspector.SourceFrame.prototype.clearSelection):
(WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
(WebInspector.SourceFrame.prototype._contextMenu):
(WebInspector.SourceFrame.prototype._toggleBreakpoint):
(WebInspector.SourceFrame.prototype.resize):
(WebInspector.BreakpointLineNumberDecorator):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView):
(WebInspector.SourceView.prototype.show):
(WebInspector.SourceView.prototype.hide):
(WebInspector.SourceView.prototype.resize):
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor):
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel):
(WebInspector.TextEditorModel.prototype.set changeListener):
(WebInspector.TextEditorModel.prototype.setText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54052
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 29 Jan 2010 09:41:33 +0000 (09:41 +0000)]
2010-01-29 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
Remove ScriptState::frame which is only used for reporting exceptions
in some cases in a way that diverges from the regular exception reporting in
v8 bindings.
Cache ScriptState directly on v8::Context instead of providing
implementations specific for isolated worlds and ScriptController.
https://bugs.webkit.org/show_bug.cgi?id=34266
* bindings/js/ScriptController.cpp:
* bindings/js/ScriptController.h:
* bindings/js/ScriptState.cpp:
(WebCore::mainWorldScriptState):
* bindings/js/ScriptState.h:
* bindings/v8/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::ScriptCallStack):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::clearWindowShell):
* bindings/v8/ScriptController.h:
* bindings/v8/ScriptScope.cpp:
(WebCore::ScriptScope::ScriptScope):
(WebCore::ScriptScope::success):
* bindings/v8/ScriptScope.h:
* bindings/v8/ScriptState.cpp:
(WebCore::ScriptState::ScriptState):
(WebCore::ScriptState::forContext):
(WebCore::ScriptState::current):
(WebCore::ScriptState::weakReferenceCallback):
(WebCore::mainWorldScriptState):
(WebCore::scriptStateFromPage):
* bindings/v8/ScriptState.h:
(WebCore::ScriptState::ScriptState):
(WebCore::EmptyScriptState::EmptyScriptState):
(WebCore::EmptyScriptState::~EmptyScriptState):
* bindings/v8/V8HiddenPropertyName.h:
* bindings/v8/V8IsolatedContext.cpp:
* bindings/v8/V8IsolatedContext.h:
* bindings/v8/V8Utilities.cpp:
(WebCore::getScriptExecutionContext):
(WebCore::reportException):
* bindings/v8/custom/V8NodeIteratorCustom.cpp:
(WebCore::V8NodeIterator::nextNodeCallback):
(WebCore::V8NodeIterator::previousNodeCallback):
* bindings/v8/custom/V8TreeWalkerCustom.cpp:
(WebCore::V8TreeWalker::parentNodeCallback):
(WebCore::V8TreeWalker::firstChildCallback):
(WebCore::V8TreeWalker::lastChildCallback):
(WebCore::V8TreeWalker::nextNodeCallback):
(WebCore::V8TreeWalker::previousNodeCallback):
(WebCore::V8TreeWalker::nextSiblingCallback):
(WebCore::V8TreeWalker::previousSiblingCallback):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::injectedScriptForNodeId):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54051
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 29 Jan 2010 09:23:32 +0000 (09:23 +0000)]
Rubber-stamped by Maciej Stachowiak.
Fix the ARM build.
* runtime/JSNumberCell.h:
(JSC::JSNumberCell::createStructure): Call the right Structure::create overload.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54050
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Fri, 29 Jan 2010 08:43:28 +0000 (08:43 +0000)]
2010-01-29 Darin Fisher <darin@chromium.org>
Reviewed by Adam Barth.
Add FrameLoaderClient::allowImages method to allow the client to
overrule image loading policy on a per frame basis.
https://bugs.webkit.org/show_bug.cgi?id=34225
For completeness, this patch also adds Settings::areImagesEnabled.
This is different from loadsImagesAutomatically as is explained in
Settings.h.
* loader/DocLoader.cpp:
(WebCore::DocLoader::requestImage):
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::allowImages):
* loader/ImageDocument.cpp:
(WebCore::ImageTokenizer::writeRawData):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setImagesEnabled):
* page/Settings.h:
(WebCore::Settings::areImagesEnabled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54049
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 07:42:05 +0000 (07:42 +0000)]
2010-01-28 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
Prefer provided video element width/height properties to hard coded
defaults for intrinsic size when natural video size is unavailable.
https://bugs.webkit.org/show_bug.cgi?id=34302
No new tests needed.
* rendering/RenderVideo.cpp: Attempt to use width/height properties
(WebCore::RenderVideo::RenderVideo):
* rendering/RenderVideo.h: More appropriate constructor signature
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 29 Jan 2010 07:16:56 +0000 (07:16 +0000)]
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
MessageEvent.data should not be repeated deserialised
https://bugs.webkit.org/show_bug.cgi?id=34311
Add test to ensure we get the same value back when accessing event.data multiple times
* fast/dom/Window/window-postmessage-clone.html:
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
MessageEvent.data should not be repeated deserialised
https://bugs.webkit.org/show_bug.cgi?id=34311
Cache the result of deserialising the event data
* bindings/scripts/CodeGeneratorJS.pm:
* dom/MessageEvent.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54047
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Fri, 29 Jan 2010 07:15:20 +0000 (07:15 +0000)]
2010-01-28 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
StorageNamespaceProxy::copy() should be a no-op
https://bugs.webkit.org/show_bug.cgi?id=34298
The comment in the code should make clear why.
* public/WebViewClient.h:
* src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespaceProxy::copy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54046
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 07:01:43 +0000 (07:01 +0000)]
2010-01-28 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Change CSS 'page-break-inside' property from inherited one to non-inherited one because CSS specification defines so.
Note: Currently, the 'page-break-inside' property is used only when parsing the CSS. That property is not used when rendering.
https://bugs.webkit.org/show_bug.cgi?id=34195
* fast/css/getComputedStyle/computed-style-page-break-inside-expected.txt: Added.
* fast/css/getComputedStyle/computed-style-page-break-inside.html: Added.
* fast/css/getComputedStyle/script-tests/computed-style-page-break-inside.js: Added.
2010-01-28 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Change CSS 'page-break-inside' property from inherited one to non-inherited one because CSS specification defines so.
Note: Currently, the 'page-break-inside' property is used only when parsing the CSS. That property is not used when rendering.
https://bugs.webkit.org/show_bug.cgi?id=34195
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::NonInheritedFlags::operator==):
(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::pageBreakInside):
(WebCore::InheritedFlags::setPageBreakInside):
* rendering/style/StyleInheritedData.cpp:
(WebCore::StyleInheritedData::StyleInheritedData):
(WebCore::StyleInheritedData::operator==):
* rendering/style/StyleInheritedData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54045
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 06:41:40 +0000 (06:41 +0000)]
2010-01-28 Michael Nordman <michaeln@google.com>
Reviewed by Alexey Proskuryakov.
ApplicationCache events should be deferred until after Document onload has fired.
https://bugs.webkit.org/show_bug.cgi?id=29690
* http/tests/appcache/deferred-events-expected.txt: Added.
* http/tests/appcache/deferred-events.html: Added.
* http/tests/appcache/deferred-events-delete-while-raising-expected.txt: Added.
* http/tests/appcache/deferred-events-delete-while-raising.html: Added.
2010-01-28 Michael Nordman <michaeln@google.com>
Reviewed by Alexey Proskuryakov.
ApplicationCache events should be deferred until after Document onload has fired.
https://bugs.webkit.org/show_bug.cgi?id=29690
Test: http/tests/appcache/deferred-events.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::handledOnloadEvents): Tells the ApplicationCacheHost to stop deferring events.
* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::ApplicationCacheHost): Initialize m_isDeferringEvents to true.
(WebCore::ApplicationCacheHost::notifyDOMApplicationCache): Depending, defer or raise the event.
(WebCore::ApplicationCacheHost::stopDeferringEvents): Raise any deferred events and reset the flag.
* loader/appcache/ApplicationCacheHost.h: Declare new data members and method.
2010-01-28 Michael Nordman <michaeln@google.com>
Reviewed by Alexey Proskuryakov.
ApplicationCache events should be deferred until after Document onload has fired.
https://bugs.webkit.org/show_bug.cgi?id=29690
* src/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::ApplicationCacheHost): Initialize m_isDeferringEvents to true.
(WebCore::ApplicationCacheHost::notifyDOMApplicationCache): Depending, defer or raise the event.
(WebCore::ApplicationCacheHost::stopDeferringEvents): Raise any deferred events and reset the flag.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Fri, 29 Jan 2010 06:11:21 +0000 (06:11 +0000)]
[wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
implements pthread_t in a way that makes it impossible to check its validity,
which is needed by ThreadingPthreads.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 04:49:39 +0000 (04:49 +0000)]
2010-01-28 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Generate header declaration for custom constructor callbacks
https://bugs.webkit.org/show_bug.cgi?id=33680
Added handling of 'CanBeConstructed' and 'OmitConstructor' and a new extended attribute
CustomConstructor'.
Deleted implementation .cpp files for corresponding 'CanBeConstructed'
extended attributes. These are now generated via CodeGeneratorV8.pm
Treating 'OmitConstructor' and 'CustomConstructor' to be the same in
CodeGeneratorJS.pm
Cleaned idls that had 'CustomConstructor' and 'OmitConstructor' together, and
same with CustomConstructor and CanBeConstructed.
* Android.v8bindings.mk:
* WebCore.gypi: Removed deps for classes being generated.
* bindings/scripts/CodeGeneratorJS.pm: OmitConstructor and CustomConstructor have the same behavior in generator.
* bindings/scripts/CodeGeneratorV8.pm: Generating the callbacks for constructors.
* bindings/v8/V8DOMWrapper.cpp: Removed manual calls to SetCallHandler() for constructor callbacks.
(WebCore::V8DOMWrapper::getTemplate):
* bindings/v8/custom/V8CustomBinding.h: Removed manual declarations of constructor callbacks.
* bindings/v8/custom/V8DOMParserConstructor.cpp:
* bindings/v8/custom/V8EventSourceConstructor.cpp:
(WebCore::V8EventSource::constructorCallback):
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::V8MessageChannel::constructorCallback):
* bindings/v8/custom/V8SharedWorkerCustom.cpp:
(WebCore::V8SharedWorker::constructorCallback):
* bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
(WebCore::V8WebGLArrayBuffer::constructorCallback):
* bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
(WebCore::V8WebGLByteArray::constructorCallback):
* bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
(WebCore::V8WebGLFloatArray::constructorCallback):
* bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
(WebCore::V8WebGLIntArray::constructorCallback):
* bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
(WebCore::V8WebGLShortArray::constructorCallback):
* bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
(WebCore::V8WebGLUnsignedByteArray::constructorCallback):
* bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
(WebCore::V8WebGLUnsignedIntArray::constructorCallback):
* bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
(WebCore::V8WebGLUnsignedShortArray::constructorCallback):
* bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:
(WebCore::V8WebKitCSSMatrix::constructorCallback):
* bindings/v8/custom/V8WebKitPointConstructor.cpp:
(WebCore::V8WebKitPoint::constructorCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::V8Worker::constructorCallback):
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):
* bindings/v8/custom/V8XMLSerializerConstructor.cpp:
* bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Deleted the file. Implementation now being generated.
* bindings/v8/custom/V8XSLTProcessorCustom.cpp: Deleted the file. Implementation now being generated.
(WebCore::V8XSLTProcessor::constructorCallback): Deleted the file. Implementation now being generated.
* css/WebKitCSSMatrix.idl: Added CustomConstructor attribute.
* dom/MessageChannel.idl: Added CustomConstructor attribute.
* html/canvas/WebGLArrayBuffer.idl: Added CustomConstructor attribute.
* html/canvas/WebGLByteArray.idl: Added CustomConstructor attribute.
* html/canvas/WebGLFloatArray.idl: Added CustomConstructor attribute.
* html/canvas/WebGLIntArray.idl: Added CustomConstructor attribute.
* html/canvas/WebGLShortArray.idl: Added CustomConstructor attribute.
* html/canvas/WebGLUnsignedByteArray.idl: Added CustomConstructor attribute.
* html/canvas/WebGLUnsignedIntArray.idl: Added CustomConstructor attribute.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 04:27:35 +0000 (04:27 +0000)]
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Add stub for AXObjectCache::contentChanged when HAVE(ACCESSIBILITY) is not defined
https://bugs.webkit.org/show_bug.cgi?id=34271
No new tests, build fix only.
* accessibility/AXObjectCache.cpp: Modified. Added HAVE(ACCESSIBILITY) guards around contentChanged
* accessibility/AXObjectCache.h: Modified.
(WebCore::AXObjectCache::contentChanged): Added stub
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54041
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 29 Jan 2010 04:00:11 +0000 (04:00 +0000)]
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
DOM Objects shouldn't all require custom mark functions
https://bugs.webkit.org/show_bug.cgi?id=34291
Make getAnonymousValue const-friendly
* runtime/JSObject.h:
(JSC::JSObject::getAnonymousValue):
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Use long long rather than int64 in V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=34270
No new tests, build fix only.
* bindings/v8/V8Binding.h: Modified.
(WebCore::toInt64): Returns long long
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54040
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Fri, 29 Jan 2010 03:40:08 +0000 (03:40 +0000)]
Adding myself to the committer list. No review needed.
* Scripts/webkitpy/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 02:57:58 +0000 (02:57 +0000)]
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Use long long rather than int64 in V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=34270
No new tests, build fix only.
* bindings/v8/V8Binding.h: Modified.
(WebCore::toInt64): Returns long long
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 02:41:24 +0000 (02:41 +0000)]
2010-01-28 Avi Drissman <avi@chromium.org>
Reviewed by David Levin.
Unused variable in ThemeMac (followup to change 49103).
https://bugs.webkit.org/show_bug.cgi?id=34274
Covered by existing tests.
* platform/mac/ThemeMac.mm:
(WebCore::setupButtonCell):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Fri, 29 Jan 2010 02:10:55 +0000 (02:10 +0000)]
Huge plain text pastes are slow
<rdar://problem/5195056>
https://bugs.webkit.org/show_bug.cgi?id=34237
Reviewed by Maciej Stachowiak.
WebCore:
No new tests. It is a performance improvement.
The performance of the plain text paste is now linear.
We treat as a special case, a fragment that has been
created from plain text. Finding VisiblePositions and
applying style is greatly simplified, given the nature of
the fragment.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
* editing/markup.cpp:
(WebCore::isPlainTextMarkup):
* editing/markup.h:
WebKit/mac:
Mail is ignoring the fragment created from plain text or HTML that is
passed to the delegate function, that creates a new one.
This fix avoids creating the fragment twice.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Fri, 29 Jan 2010 01:57:59 +0000 (01:57 +0000)]
Initialize DOM Storage's quota's current length parameter when we clone it.
https://bugs.webkit.org/show_bug.cgi?id=34294
Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-28
Reviewed by Adam Barth.
* storage/StorageMap.cpp:
(WebCore::StorageMap::copy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 01:49:18 +0000 (01:49 +0000)]
2010-01-28 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Support kinetic scrolling on Maemo 5
https://bugs.webkit.org/show_bug.cgi?id=34267
Patch by Ralf Engels <ralf.engels@nokia.com> and
Robert Griebl <rgriebl@trolltech.com>
* Api/qwebview.cpp:
(QWebViewKineticScroller::QWebViewKineticScroller):
(QWebViewKineticScroller::eventFilter):
(QWebViewKineticScroller::currentFrame):
(QWebViewKineticScroller::scrollingFrameAt):
(QWebViewKineticScroller::attachToWidget):
(QWebViewKineticScroller::removeFromWidget):
(QWebViewKineticScroller::positionRange):
(QWebViewKineticScroller::position):
(QWebViewKineticScroller::viewportSize):
(QWebViewKineticScroller::setPosition):
(QWebView::QWebView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 01:32:49 +0000 (01:32 +0000)]
2010-01-28 Hayato Ito <hayato@chromium.org>
Reviewed by David Levin.
Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
https://bugs.webkit.org/show_bug.cgi?id=34252
* Scripts/make-script-test-wrappers:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 29 Jan 2010 01:28:05 +0000 (01:28 +0000)]
Unreviewed build fix after r53411 on WinCairo.
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameCount):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54032
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 01:15:07 +0000 (01:15 +0000)]
2010-01-28 Nayan Kumar K <nayankk@gmail.com>
Reviewed by Laszlo Gombos.
Fix for compilation error in WML enabled build introduced because of the changeset 53514.
https://bugs.webkit.org/show_bug.cgi?id=34254
* wml/WMLDocument.cpp:
(WebCore::WMLDocument::WMLDocument):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 29 Jan 2010 00:57:49 +0000 (00:57 +0000)]
2010-01-28 Alex Milowski <alex@milowski.com>
Reviewed by Eric Seidel.
Updates from CSS change for mathml.css
* platform/mac/mathml/presentation/sub-expected.txt:
* platform/mac/mathml/presentation/sup-expected.txt:
* platform/mac/mathml/presentation/tables-expected.checksum:
* platform/mac/mathml/presentation/tables-expected.png:
* platform/mac/mathml/presentation/tables-expected.txt:
2010-01-28 Alex Milowski <alex@milowski.com>
Reviewed by Eric Seidel.
Update to CSS to remove unnecessary line-height settings
* css/mathml.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54029
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Fri, 29 Jan 2010 00:31:22 +0000 (00:31 +0000)]
Add missing includes for HashMap/HashSet
https://bugs.webkit.org/show_bug.cgi?id=34276
Reviewed by David Levin.
No new tests, build fix only.
* platform/KURL.cpp: Modified. Include HashMap.h
* platform/network/CredentialStorage.cpp: Modified. Include HashMap.h and HashSet.h
* platform/network/ProtectionSpaceHash.h: Modified. Include HashTraits.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54028
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Fri, 29 Jan 2010 00:20:51 +0000 (00:20 +0000)]
Add missing svn:executable property on LayoutTests/http/tests/media/resources/setCookie.cgi
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54027
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 28 Jan 2010 23:56:34 +0000 (23:56 +0000)]
2010-01-28 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Pass cookies to the GStreamer HTTP source
https://bugs.webkit.org/show_bug.cgi?id=34003
Test: http/tests/media/video-cookie.html
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateSourceChangedCallback):
When using an appropiate GStreamer HTTP source element, pass
the cookies for the media URI to it. This fixes playback of
the YouTube HTML5 videos.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 28 Jan 2010 23:50:29 +0000 (23:50 +0000)]
[Qt] Unreviewed buildfix after r54022.
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObjectImp::createStructure):
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntimeObjectImp::createStructure):
* bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMethod::createStructure):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54025
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 28 Jan 2010 23:19:47 +0000 (23:19 +0000)]
[Qt] Incorrect small caps vs. normal text handling
https://bugs.webkit.org/show_bug.cgi?id=34286
* platform/qt/Skipped: css2.1/t1505-c524-font-var-00-b.html skipped
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 28 Jan 2010 23:03:10 +0000 (23:03 +0000)]
Fix an assertion beneath SerializedScriptValue::deserialize on 32-bit builds (e.g., on Windows)
Passing a JSValue to toRef on 32-bit builds can perform an allocation,
so we need to make sure we hold a JSLock when that occurs.
Reviewed by Oliver Hunt.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValueData::serialize):
(WebCore::SerializedScriptValueData::deserialize):
Moved JSLocks from here...
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
...to this higher level, from which toRef can be called.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 28 Jan 2010 22:51:06 +0000 (22:51 +0000)]
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Simplify anonymous slot implementation
https://bugs.webkit.org/show_bug.cgi?id=34282
A class must now specify the number of slots it needs at construction time
rather than later on with a transition. This makes many things simpler,
we no longer need to need an additional transition on object creation to
add the anonymous slots, and we remove the need for a number of transition
type checks.
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::createStructure):
* API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::createStructure):
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::createStructure):
* JavaScriptCore.exp:
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::createStructure):
* runtime/Arguments.h:
(JSC::Arguments::createStructure):
* runtime/BooleanObject.h:
(JSC::BooleanObject::createStructure):
* runtime/DateInstance.h:
(JSC::DateInstance::createStructure):
* runtime/DatePrototype.h:
(JSC::DatePrototype::createStructure):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::createStructure):
* runtime/GetterSetter.h:
(JSC::GetterSetter::createStructure):
* runtime/GlobalEvalFunction.h:
(JSC::GlobalEvalFunction::createStructure):
* runtime/InternalFunction.h:
(JSC::InternalFunction::createStructure):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
* runtime/JSActivation.h:
(JSC::JSActivation::createStructure):
* runtime/JSArray.h:
(JSC::JSArray::createStructure):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::createStructure):
* runtime/JSCell.h:
(JSC::JSCell::createDummyStructure):
* runtime/JSFunction.h:
(JSC::JSFunction::createStructure):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::createStructure):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::createStructure):
* runtime/JSONObject.h:
(JSC::JSONObject::createStructure):
* runtime/JSObject.h:
(JSC::JSObject::createStructure):
(JSC::JSObject::putAnonymousValue):
(JSC::JSObject::getAnonymousValue):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::createStructure):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::createStructure):
* runtime/JSString.h:
(JSC::Fiber::createStructure):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::createStructure):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::createStructure):
(JSC::JSWrapperObject::JSWrapperObject):
* runtime/MathObject.h:
(JSC::MathObject::createStructure):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::createStructure):
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::createStructure):
* runtime/RegExpObject.h:
(JSC::RegExpObject::createStructure):
* runtime/StringObject.h:
(JSC::StringObject::createStructure):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
* runtime/Structure.cpp:
(JSC::Structure::~Structure):
(JSC::Structure::materializePropertyMap):
* runtime/Structure.h:
(JSC::Structure::create):
(JSC::Structure::anonymousSlotCount):
* runtime/StructureTransitionTable.h:
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Simplify anonymous slot implementation
https://bugs.webkit.org/show_bug.cgi?id=34282
Update JSGlue Structure usage to pass the anonymous slot count.
* UserObjectImp.h:
(UserObjectImp::createStructure):
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Simplify anonymous slot implementation
https://bugs.webkit.org/show_bug.cgi?id=34282
Update the WebCore JS DOM bindings to correctly pass and
propagate the anonymous slot count information.
* bindings/js/JSDOMBinding.h:
(WebCore::DOMObjectWithGlobalPointer::createStructure):
(WebCore::DOMConstructorObject::createStructure):
* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::createStructure):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/objc/objc_runtime.h:
(JSC::Bindings::ObjcFallbackObjectImp::createStructure):
* bridge/runtime_array.h:
(JSC::RuntimeArray::createStructure):
* bridge/runtime_method.h:
(JSC::RuntimeMethod::createStructure):
* bridge/runtime_object.h:
(JSC::RuntimeObjectImp::createStructure):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 28 Jan 2010 22:26:39 +0000 (22:26 +0000)]
[wx] Build fix after removal of the zlib image decoder.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54021
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
evan@chromium.org [Thu, 28 Jan 2010 22:17:23 +0000 (22:17 +0000)]
2010-01-27 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
[chromium] hebrew vowel marks incorrectly positioned
https://bugs.webkit.org/show_bug.cgi?id=34234
Add a layout test containing some Hebrew vowels.
* fast/text/international/hebrew-vowels.html: Added.
2010-01-27 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
[chromium] hebrew vowel marks incorrectly positioned
https://bugs.webkit.org/show_bug.cgi?id=34234
Fix glyph metrics computation such that the glyph offsets
are correct, so we can now make use of them.
Test: fast/text/international/hebrew-vowels.html
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::TextRunWalker::createGlyphArrays): initialize per-glyph
offset table.
(WebCore::TextRunWalker::setGlyphXPositions): use per-glyph
offsets.
* platform/graphics/chromium/HarfbuzzSkia.cpp:
(WebCore::getGlyphMetrics): fix metrics computation such that
per-glyph offsets are computed correctly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Thu, 28 Jan 2010 22:08:56 +0000 (22:08 +0000)]
2010-01-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed build fix.
[Qt] Build fix if websockets support is turned off after r53947.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 28 Jan 2010 21:44:24 +0000 (21:44 +0000)]
2010-01-28 Dimitri Glazkov <dglazkov@chromium.org>
No review, rolling out r54012.
http://trac.webkit.org/changeset/54012
https://bugs.webkit.org/show_bug.cgi?id=34266
Introduced 33 crashes in V8 traversal/ tests.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::mainWorldScriptState):
* bindings/js/ScriptController.h:
* bindings/js/ScriptState.cpp:
* bindings/js/ScriptState.h:
* bindings/v8/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::ScriptCallStack):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::mainWorldScriptState):
(WebCore::ScriptController::currentScriptState):
(WebCore::ScriptController::clearWindowShell):
* bindings/v8/ScriptController.h:
* bindings/v8/ScriptScope.cpp:
(WebCore::ScriptScope::ScriptScope):
(WebCore::ScriptScope::success):
* bindings/v8/ScriptScope.h:
* bindings/v8/ScriptState.cpp:
(WebCore::ScriptState::ScriptState):
(WebCore::scriptStateFromPage):
* bindings/v8/ScriptState.h:
(WebCore::ScriptState::ScriptState):
(WebCore::ScriptState::frame):
* bindings/v8/V8HiddenPropertyName.h:
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::scriptState):
* bindings/v8/V8IsolatedContext.h:
* bindings/v8/V8Utilities.cpp:
(WebCore::getScriptExecutionContext):
(WebCore::reportException):
* bindings/v8/custom/V8NodeIteratorCustom.cpp:
(WebCore::V8NodeIterator::nextNodeCallback):
(WebCore::V8NodeIterator::previousNodeCallback):
* bindings/v8/custom/V8TreeWalkerCustom.cpp:
(WebCore::V8TreeWalker::parentNodeCallback):
(WebCore::V8TreeWalker::firstChildCallback):
(WebCore::V8TreeWalker::lastChildCallback):
(WebCore::V8TreeWalker::nextNodeCallback):
(WebCore::V8TreeWalker::previousNodeCallback):
(WebCore::V8TreeWalker::nextSiblingCallback):
(WebCore::V8TreeWalker::previousSiblingCallback):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::injectedScriptForNodeId):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aa@chromium.org [Thu, 28 Jan 2010 21:36:35 +0000 (21:36 +0000)]
Reapply 54008: Expand the NotificationPresenter::checkPermission() interface
to send the full URL of the requesting context, as well as a pointer to the
document if that context was a document.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54015
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 28 Jan 2010 21:34:44 +0000 (21:34 +0000)]
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Fix missing forward-declarations and includes in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=34272
No new tests, build fix only.
* bindings/v8/ScriptController.h: Modified. Forward-declare NPObject
* bindings/v8/V8DOMWindowShell.cpp: Modified. Include CString.h and PlatformBridge.h
* bindings/v8/V8DOMWrapper.h: Modified. Forward-declare V8Proxy
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 28 Jan 2010 21:24:51 +0000 (21:24 +0000)]
2010-01-28 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, trivial baseline update.
Update baseline for "Animated scaling of background-image is too slow"
https://bugs.webkit.org/show_bug.cgi?id=33808
* platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize16-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 28 Jan 2010 21:05:51 +0000 (21:05 +0000)]
2010-01-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
Remove ScriptState::frame which is only used for reporting exceptions
in some cases in a way that diverges from the regular exception reporting in
v8 bindings.
Cache ScriptState directly on v8::Context instead of providing
implementations specific for isolated worlds and ScriptController.
https://bugs.webkit.org/show_bug.cgi?id=34266
* bindings/js/ScriptController.cpp:
* bindings/js/ScriptController.h:
* bindings/js/ScriptState.cpp:
(WebCore::mainWorldScriptState):
* bindings/js/ScriptState.h:
* bindings/v8/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::ScriptCallStack):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell):
* bindings/v8/ScriptController.h:
* bindings/v8/ScriptScope.cpp:
(WebCore::ScriptScope::ScriptScope):
(WebCore::ScriptScope::success):
* bindings/v8/ScriptScope.h:
* bindings/v8/ScriptState.cpp:
(WebCore::ScriptState::ScriptState):
(WebCore::ScriptState::forContext):
(WebCore::ScriptState::current):
(WebCore::ScriptState::empty):
(WebCore::ScriptState::weakReferenceCallback):
(WebCore::mainWorldScriptState):
(WebCore::scriptStateFromPage):
* bindings/v8/ScriptState.h:
* bindings/v8/V8HiddenPropertyName.h:
* bindings/v8/V8IsolatedContext.cpp:
* bindings/v8/V8IsolatedContext.h:
* bindings/v8/V8Utilities.cpp:
(WebCore::getScriptExecutionContext):
(WebCore::reportException):
* bindings/v8/custom/V8NodeIteratorCustom.cpp:
(WebCore::V8NodeIterator::nextNodeCallback):
(WebCore::V8NodeIterator::previousNodeCallback):
* bindings/v8/custom/V8TreeWalkerCustom.cpp:
(WebCore::V8TreeWalker::parentNodeCallback):
(WebCore::V8TreeWalker::firstChildCallback):
(WebCore::V8TreeWalker::lastChildCallback):
(WebCore::V8TreeWalker::nextNodeCallback):
(WebCore::V8TreeWalker::previousNodeCallback):
(WebCore::V8TreeWalker::nextSiblingCallback):
(WebCore::V8TreeWalker::previousSiblingCallback):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::injectedScriptForNodeId):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54012
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aa@chromium.org [Thu, 28 Jan 2010 20:38:02 +0000 (20:38 +0000)]
revert
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 28 Jan 2010 20:34:36 +0000 (20:34 +0000)]
2010-01-28 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Remove XSSAuditor false positive for Google Translate
https://bugs.webkit.org/show_bug.cgi?id=34242
Add a test that we allow attackers to inject directly into the href
property of the base tag.
* http/tests/security/xssAuditor/base-href-direct-expected.txt: Added.
* http/tests/security/xssAuditor/base-href-direct.html: Added.
* http/tests/security/xssAuditor/resources/echo-head-base-href-direct.pl: Added.
2010-01-28 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Remove XSSAuditor false positive for Google Translate
https://bugs.webkit.org/show_bug.cgi?id=34242
Google translate takes a base URL as a parameter, causing a false
positive in the XSS filter. This patch removes the false positive by
allowing direct injections into the href property of the base tag.
Test: http/tests/security/xssAuditor/base-href-direct.html
* page/XSSAuditor.cpp:
(WebCore::XSSAuditor::canSetBaseElementURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54010
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 28 Jan 2010 20:27:38 +0000 (20:27 +0000)]
2010-01-28 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Save additional memory in SVG*Element classes, by introducing SVGElementRareData
https://bugs.webkit.org/show_bug.cgi?id=34268
Introduce SVGElementRareData, to remove the need to store any members in SVGElement/SVGStyledElement.
This saves some additional MB for the svg-node-count-vs-scroll.xhtml testcase.
SVGElementRareData works just like NodeRareData. Unlike ElementRareData, we're not inheriting from
NodeRareData in SVG, as we don't need all the rare data stored there, unlike Element.
* GNUmakefile.am: Add SVGElementRareData.h to build.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* dom/Node.cpp: Use Nodes bitfield to keep track wheter a SVGElement has a SVGElementRareData object associated.
(WebCore::Node::Node):
* dom/Node.h: Add m_hasRareSVGData flag, merged with the existing bitfield, 10 bits remaining now.
(WebCore::Node::hasRareSVGData):
* svg/SVGAnimateMotionElement.cpp: SVGElement::instancesForElement() now returns a const-reference to the HashMap instead of copying.
(WebCore::SVGAnimateMotionElement::applyResultsToTarget):
* svg/SVGAnimateTransformElement.cpp: Ditto.
(WebCore::SVGAnimateTransformElement::applyResultsToTarget):
* svg/SVGAnimationElement.cpp: Ditto.
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
* svg/SVGElement.cpp: Move the element instances HashSet and two cursor-related pointers into SVGElementRareData.
(WebCore::SVGElement::SVGElement):
(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::rareSVGData): Modelled just like Node::rareData().
(WebCore::SVGElement::ensureRareSVGData): Dito.
(WebCore::SVGElement::accessDocumentSVGExtensions):
(WebCore::SVGElement::mapInstanceToElement): Route call through SVGElementRareData.
(WebCore::SVGElement::removeInstanceMapping): Ditto.
(WebCore::SVGElement::instancesForElement): Ditto.
(WebCore::SVGElement::setCursorElement): Ditto.
(WebCore::SVGElement::setCursorImageValue): Ditto.
* svg/SVGElement.h:
* svg/SVGElementInstance.cpp: Ditto.
(WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
* svg/SVGElementRareData.h: Added. Based on NodeRareData - works exactly the same.
(WebCore::SVGElementRareData::SVGElementRareData):
(WebCore::SVGElementRareData::rareDataMap):
(WebCore::SVGElementRareData::rareDataFromMap):
(WebCore::SVGElementRareData::elementInstances):
(WebCore::SVGElementRareData::instanceUpdatesBlocked):
(WebCore::SVGElementRareData::setInstanceUpdatesBlocked):
(WebCore::SVGElementRareData::cursorElement):
(WebCore::SVGElementRareData::setCursorElement):
(WebCore::SVGElementRareData::cursorImageValue):
(WebCore::SVGElementRareData::setCursorImageValue):
* svg/SVGStyledElement.cpp: Move m_instancesUpdatesBlocked into SVGElementRareData.
(WebCore::SVGStyledElement::SVGStyledElement):
(WebCore::SVGStyledElement::instanceUpdatesBlocked):
(WebCore::SVGStyledElement::setInstanceUpdatesBlocked):
* svg/SVGStyledElement.h:
* svg/SVGUseElement.cpp: Adapt to element instances changes, now passed as const-reference.
(WebCore::dumpInstanceTree):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aa@chromium.org [Thu, 28 Jan 2010 19:24:08 +0000 (19:24 +0000)]
2010-01-28 Aaron Boodman <aa@chromium.org>
Reviewed by Darin Adler.
Expand the NotificationPresenter::checkPermission() interface to send the full
URL of the requesting context, as well as a pointer to the document if that
context was a document.
https://bugs.webkit.org/show_bug.cgi?id=34238
* notifications/Notification.cpp:
(WebCore::Notification::Notification):
* notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::NotificationCenter):
(WebCore::NotificationCenter::checkPermission):
Pass the full URL and document from the requesting context when calling
NotificationPresenter::checkPermission().
* notifications/NotificationPresenter.h:
(WebCore::NotificationPresenter::):
Expand interface.
2010-01-27 Aaron Boodman <aa@chromium.org>
Reviewed by Darin Adler.
Send full URL and application id of requesting context to Chromium
when checking notification permissions.
https://bugs.webkit.org/show_bug.cgi?id=34238
* public/WebDocument.h:
* src/WebDocument.cpp:
(WebKit::WebDocument::applicationID):
Implement applicationID() method.
* public/WebNotificationPresenter.h:
* src/NotificationPresenterImpl.cpp:
(WebKit::NotificationPresenterImpl::checkPermission):
* src/NotificationPresenterImpl.h:
Send applicationID and full URL through to Chromium.
2010-01-27 Aaron Boodman <aa@chromium.org>
Expand NotificationCenter::checkPermission() interface.
It now passes the full URL instead of just the origin.
https://bugs.webkit.org/show_bug.cgi?id=34238
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::checkPermission):
* WebCoreSupport/WebDesktopNotificationsDelegate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jam@chromium.org [Thu, 28 Jan 2010 18:34:02 +0000 (18:34 +0000)]
Unreviewed, trivial expectations update.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 28 Jan 2010 18:07:14 +0000 (18:07 +0000)]
2010-01-28 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Video can overlap position:fixed element when scrolling
https://bugs.webkit.org/show_bug.cgi?id=32180
When the scroll position changes, and we're using overlap to decide what gets composited,
then we need to re-evaluate what gets compositing when scrolling in case fixed postion elements
overlap composited elements (e.g. video).
Test: compositing/geometry/video-fixed-scrolling.html
* page/FrameView.cpp:
(WebCore::FrameView::updateCompositingLayers):
(WebCore::FrameView::scrollPositionChanged): Annotate the calls to updateCompositingLayers()
with the type of change that occurred.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded): Ditto.
* rendering/RenderLayerCompositor.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers): For scroll changes, check
for hierarchy update if m_compositingConsultsOverlap is true, and do
a geometry update. For other changes, always check for hierarchy updates.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 28 Jan 2010 17:47:30 +0000 (17:47 +0000)]
Fix for user stylesheet bugs where they get parsed using the wrong compatibility mode. This was a regression
caused from Safari 3 -> 4 by the Acid3 fixes to create a real DOCTYPE in the DOM.
Reviewed by Darin Adler.
This patch makes style selector creation lazy, so that the selector isn't built unless someone asks for it.
In order to avoid creating the style selector before the compatibility mode has been determined, document
style is now created without having a dependence on an instantiated style selector. The creation of the style
is now done as a static method on CSSStyleSelector called styleForDocument, and a couple of font-related
functions have been made static as well so that they can be used by this method.
m_styleSelector on Document is now an OwnPtr.
Added userscripts/mixed-case-stylesheet.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::checkForGenericFamilyChange):
(WebCore::CSSStyleSelector::setFontSize):
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
(WebCore::CSSStyleSelector::fontSizeForKeyword):
* css/CSSStyleSelector.h:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleSelector):
(WebCore::Document::attach):
(WebCore::Document::setVisuallyOrdered):
(WebCore::Document::recalcStyleSelector):
* dom/Document.h:
(WebCore::Document::styleSelector):
(WebCore::Document::visuallyOrdered):
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::determineParseMode):
* loader/PlaceholderDocument.cpp:
(WebCore::PlaceholderDocument::attach):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 28 Jan 2010 17:03:50 +0000 (17:03 +0000)]
2010-01-28 Anton Muhin <antonm@google.com>
Reviewed by Alexey Proskuryakov.
Add layout tests to verify assignment to items of NodeList
https://bugs.webkit.org/show_bug.cgi?id=34213
* fast/dom/NodeList/nodelist-item-assignment-expected.txt: Added.
* fast/dom/NodeList/nodelist-item-assignment.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 28 Jan 2010 16:47:04 +0000 (16:47 +0000)]
2010-01-28 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Rename ISODateTime.{cpp,h} to DateComponents.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=34245
No functional changes.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/DateComponents.cpp: Copied from WebCore/html/ISODateTime.cpp.
(WebCore::DateComponents::maxWeekNumberInYear):
(WebCore::DateComponents::parseYear):
(WebCore::DateComponents::addDay):
(WebCore::DateComponents::addMinute):
(WebCore::DateComponents::parseTimeZone):
(WebCore::DateComponents::parseMonth):
(WebCore::DateComponents::parseDate):
(WebCore::DateComponents::parseWeek):
(WebCore::DateComponents::parseTime):
(WebCore::DateComponents::parseDateTimeLocal):
(WebCore::DateComponents::parseDateTime):
(WebCore::DateComponents::setMillisecondsSinceMidnightInternal):
(WebCore::DateComponents::setMillisecondsSinceEpochForDateInternal):
(WebCore::DateComponents::setMillisecondsSinceEpochForDate):
(WebCore::DateComponents::setMillisecondsSinceEpochForDateTime):
(WebCore::DateComponents::setMillisecondsSinceEpochForDateTimeLocal):
(WebCore::DateComponents::setMillisecondsSinceEpochForMonth):
(WebCore::DateComponents::setMillisecondsSinceMidnight):
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek):
(WebCore::DateComponents::millisecondsSinceEpochForTime):
(WebCore::DateComponents::millisecondsSinceEpoch):
(WebCore::DateComponents::toStringForTime):
(WebCore::DateComponents::toString):
* html/DateComponents.h: Copied from WebCore/html/ISODateTime.h.
(WebCore::DateComponents::DateComponents):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseToDouble):
(WebCore::HTMLInputElement::valueAsDate):
(WebCore::HTMLInputElement::setValueAsDate):
(WebCore::HTMLInputElement::setValueAsNumber):
(WebCore::HTMLInputElement::formStringToDateComponents):
* html/HTMLInputElement.h:
* html/ISODateTime.cpp: Removed.
* html/ISODateTime.h: Removed.
* html/ValidityState.cpp:
(WebCore::ValidityState::typeMismatch):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54003
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 28 Jan 2010 16:44:00 +0000 (16:44 +0000)]
[Qt] Unreviewed, roll out r54000.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::display):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 28 Jan 2010 16:28:41 +0000 (16:28 +0000)]
2010-01-28 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Use platform-specific monospace fonts in the Web Inspector
Move the OS version detection code into the frontend,
add custom CSS monospace styles for known platforms.
https://bugs.webkit.org/show_bug.cgi?id=34040
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::platform):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
* inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView):
* inspector/front-end/InspectorBackendStub.js:
(.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup):
(.WebInspector.InspectorBackendStub.prototype.setInjectedScriptSource):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._createConditionElement):
* inspector/front-end/inspector.css:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.URLRegExp.i.get platform):
(WebInspector._detectPlatform):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 28 Jan 2010 14:41:05 +0000 (14:41 +0000)]
2010-01-28 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement the display() method of the layout test controller
https://bugs.webkit.org/show_bug.cgi?id=34258
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::showPage):
(WebCore::DumpRenderTree::hidePage):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
(LayoutTestController::display):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Thu, 28 Jan 2010 13:39:14 +0000 (13:39 +0000)]
Do not set the combobox font on Maemo5 and S60; use the
default instead.
Reviewed by Simon Hausmann.
* WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::populate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cjerdonek@webkit.org [Thu, 28 Jan 2010 13:22:16 +0000 (13:22 +0000)]
Eliminated the filename parameter from functions in
check-webkit-style's cpp.py where it is no longer used.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=34249
* Scripts/webkitpy/style/processors/cpp.py:
- Reduced number of occurrences of "filename" variable from
approximately 200 to 120.
* Scripts/webkitpy/style/processors/cpp_unittest.py:
- Refactored unit tests as necessary to accommodate changes to cpp.py.
- Fixed bug in CppStyleTestBase.perform_include_what_you_use()
where the incorrect file extension was getting passed to
cpp_style.check_language().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 28 Jan 2010 13:06:49 +0000 (13:06 +0000)]
[Qt] Fix for endless print loop when printing web pages
Patch by Trond Kjernåsen <trond@trolltech.com> on 2010-01-28
Reviewed by Simon Hausmann.
* Api/qwebframe.cpp:
(QWebFrame::print):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 28 Jan 2010 12:34:02 +0000 (12:34 +0000)]
2010-01-28 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Simplify views logic in Profiler panel, and fix the problem described in the issue.
Remove image from Welcome view.
Preserve border on status bar-like buttons in Welcome view on window deactivation.
https://bugs.webkit.org/show_bug.cgi?id=34201
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.show):
(WebInspector.ProfilesPanel.prototype.reset):
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype.showView):
(WebInspector.ProfilesPanel.prototype._updateInterface):
* inspector/front-end/WelcomeView.js:
(WebInspector.WelcomeView):
* inspector/front-end/inspector.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Thu, 28 Jan 2010 11:54:12 +0000 (11:54 +0000)]
[Qt] Speed up KURL to QUrl conversion
https://bugs.webkit.org/show_bug.cgi?id=33873
The WebCore::String::utf8 method will use the generic WebCore::TextCodec
and then call the encode method on it. In QtWebKit this class is implemented
around the QTextCodec class. Instead of going the generic codec way we treat
the WebCore::String as a QString (no copying) and then use the built-in
QString::toUtf8 to do the conversion.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benm@google.com [Thu, 28 Jan 2010 11:00:35 +0000 (11:00 +0000)]
[Android] [Qt] Touch event page co-ordinates are incorrect when touch is received in an iframe.
https://bugs.webkit.org/show_bug.cgi?id=34162
Reviewed by Simon Hausmann.
WebCore:
The pageX/pageY co-ordinates of a touch event should be relative to the containing frame, not the main frame. This change implements that and also updates the existing touch-inside-iframe test to also examine the page co-ordinates.
* dom/Touch.cpp:
(WebCore::Touch::Touch): Remove dead code.
* dom/Touch.h: Remove dead code.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Rename framePoint to pagePoint, as it seems a clearer name. Also adjust the pagePoint to be relative to the touch target element's containing frame rather than the main frame.
* platform/PlatformTouchEvent.h: Rename Android specific constructor parameter to better reflect it's contents.
* platform/PlatformTouchPoint.h: Ditto.
* platform/android/PlatformTouchEventAndroid.cpp: Ditto.
* platform/android/PlatformTouchPointAndroid.cpp: Ditto.
LayoutTests:
Update the existing iframe touch event test to also examine the page co-ordinates of the touch that is received.
* fast/events/touch/resources/touch-inside-iframe2.html:
* fast/events/touch/touch-inside-iframe-expected.txt:
* fast/events/touch/touch-inside-iframe.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53994
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 28 Jan 2010 10:46:26 +0000 (10:46 +0000)]
2010-01-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Simplify isActivation method.
https://bugs.webkit.org/show_bug.cgi?id=34161
Test: WebCore/manual-tests/inspector/debugger-scopes-inspection.html
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::isActivation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53993
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Thu, 28 Jan 2010 09:20:10 +0000 (09:20 +0000)]
2010-01-28 Xan Lopez <xlopez@igalia.com>
[GTK] Can DnD files to our filechooser widget (<input type="file">)
https://bugs.webkit.org/show_bug.cgi?id=34246
Skip failing test because of this missing feature.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53992
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 28 Jan 2010 09:10:29 +0000 (09:10 +0000)]
2010-01-28 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
Remove tests for dates later than 275760-09-13T00:00Z.
https://bugs.webkit.org/show_bug.cgi?id=34240
Date.UTC() of V8 doesn't support such dates though Date.UTC() of
JavaScriptCore does.
* fast/forms/input-valueasnumber-date-expected.txt:
* fast/forms/input-valueasnumber-datetime-expected.txt:
* fast/forms/input-valueasnumber-datetimelocal-expected.txt:
* fast/forms/input-valueasnumber-month-expected.txt:
* fast/forms/script-tests/input-valueasnumber-date.js:
* fast/forms/script-tests/input-valueasnumber-datetime.js:
* fast/forms/script-tests/input-valueasnumber-datetimelocal.js:
* fast/forms/script-tests/input-valueasnumber-month.js:
* platform/win/fast/forms/input-valueasnumber-datetime-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53991
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 28 Jan 2010 08:45:32 +0000 (08:45 +0000)]
2010-01-28 Chris Jerdonek <cjerdonek@webkit.org>
Reviewed by Shinichiro Hamaji.
In check-webkit-style, eliminated the dependency of
processors/cpp_unittest.py on checker.py.
https://bugs.webkit.org/show_bug.cgi?id=34205
* Scripts/webkitpy/style/checker.py:
- Addressed FIXME by removing STYLE_CATEGORIES data.
- Added style_categories().
* Scripts/webkitpy/style/checker_unittest.py:
- Minor changes.
* Scripts/webkitpy/style/processors/cpp.py:
- Added categories attribute to CppProcessor class (data
was originally checker.STYLE_CATEGORIES).
* Scripts/webkitpy/style/processors/cpp_unittest.py:
- Addressed FIXME by eliminating "import" from checker.py.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53990
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 28 Jan 2010 08:29:05 +0000 (08:29 +0000)]
2010-01-28 Anton Muhin <antonm@chromium.org>
Reviewed by Shinichiro Hamaji.
Improve treatment of conditions and rest of the line for if, else, switch and alikes
https://bugs.webkit.org/show_bug.cgi?id=34173
* Scripts/webkitpy/style/cpp_style.py:
* Scripts/webkitpy/style/cpp_style_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53989
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 28 Jan 2010 08:12:32 +0000 (08:12 +0000)]
2010-01-28 Joe Mason <jmason@rim.com>
Reviewed by Adam Barth.
Limit login retries to 5
https://bugs.webkit.org/show_bug.cgi?id=34193
* Scripts/webkitpy/bugzilla.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 28 Jan 2010 07:29:39 +0000 (07:29 +0000)]
2010-01-27 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
rangeOverflow/rangeUnderflow support for type=date
https://bugs.webkit.org/show_bug.cgi?id=34209
* fast/forms/ValidityState-rangeOverflow-date-expected.txt: Added.
* fast/forms/ValidityState-rangeOverflow-date.html: Added.
* fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Added.
* fast/forms/ValidityState-rangeUnderflow-date.html: Added.
* fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Added.
* fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Added.
2010-01-27 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
rangeOverflow/rangeUnderflow support for type=date
https://bugs.webkit.org/show_bug.cgi?id=34209
Add DATE type support to rangeUnderflow(), rangeOverflow(),
minimum(), and maximum() of HTMLInputElement.
In order to unify parsing code for value, min, and max strings,
introduce parseToDouble() function and it is called by
valueAsDate() and valueAsNumber() too.
Tests: fast/forms/ValidityState-rangeOverflow-date.html
fast/forms/ValidityState-rangeUnderflow-date.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::rangeUnderflow): Support DATE type, and use parseToDouble().
(WebCore::HTMLInputElement::rangeOverflow): ditto.
(WebCore::HTMLInputElement::minimum): ditto.
(WebCore::HTMLInputElement::maximum): ditto.
(WebCore::HTMLInputElement::doubleValueFor): Added.
(WebCore::HTMLInputElement::valueAsDate): Use parseToDouble().
(WebCore::HTMLInputElement::valueAsNumber): Use parseToDouble().
* html/HTMLInputElement.h: Declare parseToDouble().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Thu, 28 Jan 2010 07:27:09 +0000 (07:27 +0000)]
2010-01-27 Darin Fisher <darin@chromium.org>
Fix chromium build bustage (take 2).
* bindings/scripts/CodeGeneratorV8.pm: Really treat V8CustomGetter like CustomGetter in all cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 28 Jan 2010 07:18:57 +0000 (07:18 +0000)]
[Qt] Skip test introduced in r53972 because of missing eventSender.beginDragWithFiles()
* platform/qt/Skipped: fast/dom/Window/window-postmessage-clone-frames.html skipped.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Thu, 28 Jan 2010 06:50:36 +0000 (06:50 +0000)]
2010-01-27 Darin Fisher <darin@chromium.org>
Fix chromium build bustage.
* bindings/scripts/CodeGeneratorV8.pm: Treat V8CustomGetter like CustomGetter in all cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Thu, 28 Jan 2010 06:36:24 +0000 (06:36 +0000)]
2010-01-27 Darin Fisher <darin@chromium.org>
Reviewed by Pavel Feldman.
Expose HistoryItem::documentSequenceNumber
https://bugs.webkit.org/show_bug.cgi?id=34243
* public/WebHistoryItem.h:
* src/WebHistoryItem.cpp:
(WebKit::WebHistoryItem::documentSequenceNumber):
(WebKit::WebHistoryItem::setDocumentSequenceNumber):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 28 Jan 2010 05:26:54 +0000 (05:26 +0000)]
Windows build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc