WebKit-https.git
12 years ago2008-05-12 Alp Toker <alp@nuanti.com>
alp@webkit.org [Mon, 12 May 2008 22:23:04 +0000 (22:23 +0000)]
2008-05-12  Alp Toker  <alp@nuanti.com>

        GTK+ build fix for breakage in r33056. Include limits.h for INT_MAX.

        * platform/graphics/FontCache.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 12 May 2008 22:22:32 +0000 (22:22 +0000)]
2008-05-12  Anders Carlsson  <andersca@apple.com>

        Update the expected result.

        * http/tests/appcache/simple-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 12 May 2008 22:11:01 +0000 (22:11 +0000)]
2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add user agent to requests when loading/updating the cache.

        * loader/FrameLoader.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::update):
        (WebCore::ApplicationCacheGroup::startLoadingEntry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Mon, 12 May 2008 21:11:07 +0000 (21:11 +0000)]
WebCore:

2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Make it possible to perform synchronous loads from the application cache.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
        Factor out code from scheduleApplicationCacheLoad in its own method.

        (WebCore::DocumentLoader::scheduleApplicationCacheLoad):
        Call shouldLoadResourceFromApplicationCache here instead.

        * loader/DocumentLoader.h:

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadResourceSynchronously):
        Call shouldLoadResourceFromApplicationCache.

WebKitTools:

2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add support for testing application caches.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (dumpRenderTree):
        Empty the cache.

        (resetWebViewToConsistentStateBeforeTesting):
        Turn on support for the application cache.

LayoutTests:

2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add simple appcache test.

        * http/conf/mime.types:
        * http/tests/appcache: Added.
        * http/tests/appcache/resources: Added.
        * http/tests/appcache/resources/not-in-cache.txt: Added.
        * http/tests/appcache/resources/simple.manifest: Added.
        * http/tests/appcache/resources/simple.txt: Added.
        * http/tests/appcache/simple-expected.txt: Added.
        * http/tests/appcache/simple.html: Added.
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Mon, 12 May 2008 21:02:27 +0000 (21:02 +0000)]
WebCore:

        Reviewed by Ada Chan and Sam Weinig.

        - WebCore changes for https://bugs.webkit.org/show_bug.cgi?id=17097
          <rdar://problem/5715471> CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound

        Added a way for clients to let the cache know that they no longer need
        font data, which lets the cache release it. Changed clients to track
        most of the font data they get from the cache so that they can later
        release it. Some instances of font data -- namely, those used for system
        font fallback -- are still not tracked and will therefore remain in the
        cache indefinitely.

        * WebCore.base.exp: Added exports for WebCoreStatistics in WebKit.

        * platform/graphics/Font.cpp:
        (WebCore::Font::Font): Changed to use FontFallbackList::create().
        (WebCore::Font::update): Ditto.

        * platform/graphics/FontCache.cpp:
        (WebCore::FontCache::getCachedFontData): Added code to track the number
        of times a SimpleFontData instance has been requested from the cache,
        remove requested instances from the inactive list, and purge inactive
        font data if the inactive list has grown above its maximum allowed size.
        (WebCore::FontCache::releaseFontData): Added. Called by clients to let
        the cache know that they no longer need the font data. Adds the font
        data to the inactive list if the last client has released it.
        (WebCore::FontCache::purgeInactiveFontData): Added. Removes inactive
        font data from the cache (and the inactive list).
        (WebCore::FontCache::fontDataCount): Added to provide statistics.
        (WebCore::FontCache::inactiveFontDataCount): Ditto.

        * platform/graphics/FontCache.h:

        * platform/graphics/FontData.h:
        (WebCore::FontData::FontData): Added a member variable to store the
        highest glyph page tree level in which there is a node for this FontData.
        This is used to limit the depth of the search when pruning glyph page
        trees.
        (WebCore::FontData::setMaxGlyphPageTreeLevel): Added this accessor.
        (WebCore::FontData::maxGlyphPageTreeLevel): Ditto.

        * platform/graphics/FontFallbackList.cpp:
        (WebCore::FontFallbackList::FontFallbackList): Changed to start with a
        refcount of 1.
        (WebCore::FontFallbackList::invalidate): Added a call to
        releaseFontData().
        (WebCore::FontFallbackList::releaseFontData): Added. Lets the font cache
        know that we no longer need the FontData in our font list.
        (WebCore::FontFallbackList::fontDataAt): Changed to record in the font
        list whether the font data is a custom font data or not.
        (WebCore::FontFallbackList::setPlatformFont): Ditto.

        * platform/graphics/FontFallbackList.h:
        (WebCore::FontFallbackList::create): Added and made the constructor
        private.
        (WebCore::FontFallbackList::~FontFallbackList): Added a call to
        releaseFontData().

        * platform/graphics/GlyphPageTreeNode.cpp:
        (WebCore::GlyphPageTreeNode::treeGlyphPageCount): Added to provide
        statistics.
        (WebCore::GlyphPageTreeNode::pageCount): Ditto.

        (WebCore::GlyphPageTreeNode::pruneTreeFontData): Added.
        (WebCore::GlyphPageTreeNode::getChild): Added code to update the font
        data's maximum glyph page tree level.
        (WebCore::GlyphPageTreeNode::pruneFontData): Added.

        * platform/graphics/GlyphPageTreeNode.h:

        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::~SimpleFontData): Added code to let the font
        cache know that we no longer need the small caps font data and to prune
        the glyph page trees.

WebKit/mac:

        Reviewed by Ada Chan.

        - WebKit/mac changes for https://bugs.webkit.org/show_bug.cgi?id=17097
          <rdar://problem/5715471> CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound

        Added font cache statistics and a function to purge inactive font data.

        * Misc/WebCoreStatistics.h:
        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics cachedFontDataCount]):
        (+[WebCoreStatistics cachedFontDataInactiveCount]):
        (+[WebCoreStatistics purgeInactiveFontData]):
        (+[WebCoreStatistics glyphPageCount]):

WebKit/win:

        Reviewed by Ada Chan.

        - WebKit/win changes for https://bugs.webkit.org/show_bug.cgi?id=17097
          <rdar://problem/5715471> CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound

        Added font cache statistics and a function to purge inactive font data.

        * Interfaces/IWebCoreStatistics.idl:
        * WebCoreStatistics.cpp:
        (WebCoreStatistics::cachedFontDataCount):
        (WebCoreStatistics::cachedFontDataInactiveCount):
        (WebCoreStatistics::purgeInactiveFontData):
        (WebCoreStatistics::glyphPageCount):
        * WebCoreStatistics.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDecorate some deprecated delegate methods with the availability macros.
mrowe@apple.com [Mon, 12 May 2008 21:01:07 +0000 (21:01 +0000)]
Decorate some deprecated delegate methods with the availability macros.

The compiler doesn't appear to warn if a delegate implements these methods, but using the availability
macros is good for consistency and documentation.

Reviewed by Tim Hatcher.

* WebView/WebFrameLoadDelegate.h:
* WebView/WebUIDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5835604> Deprecate HIWebView
mrowe@apple.com [Mon, 12 May 2008 21:01:05 +0000 (21:01 +0000)]
<rdar://problem/5835604> Deprecate HIWebView

Use of HIWebView is deprecated in favor of embedding a WebView in a HICocoaView.

Reviewed by Tim Hatcher.

* Carbon/CarbonUtils.h: Include the availability macro header and decorate the functions appropriately.
* Carbon/HIWebView.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/4859666> WebKit needs availability macros in order to deprecate APIs
mrowe@apple.com [Mon, 12 May 2008 21:01:02 +0000 (21:01 +0000)]
<rdar://problem/4859666> WebKit needs availability macros in order to deprecate APIs

Create WebKit availability macros that key off the Mac OS X version being targeted to
determine the WebKit version being targeted.  Applications can define
WEBKIT_VERSION_MIN_REQUIRED before including WebKit headers in order to target a specific
version of WebKit.

The availability header is being added to JavaScriptCore rather than WebKit as JavaScriptCore
is the lowest-level portion of the public WebKit API.

Reviewed by Tim Hatcher.

* API/WebKitAvailability.h: Added.
* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders.
kdecker@apple.com [Mon, 12 May 2008 20:50:36 +0000 (20:50 +0000)]
    Reviewed by Anders.

        Fixed: <rdar://problem/5840884>_recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined

        Re-added these SPI methods because they are needed by some clients. They were accidentally removed
        in changeset <http://trac.webkit.org/changeset/31028>

        * Plugins/WebBaseNetscapePluginView.h: Added stopTimers, restartTimers to the header.
        * WebView/WebFrame.mm:
        (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): Re-addd.
        (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): Ditto.
        * WebView/WebFrameInternal.h: Ditto.
        * WebView/WebHTMLView.mm: Ditto.
        (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Ditto.
        (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
        * WebView/WebHTMLViewInternal.h: Ditto.
        * WebView/WebHTMLViewPrivate.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Mon, 12 May 2008 20:13:51 +0000 (20:13 +0000)]
WebCore:

2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Alexey.

        Add ApplicationCacheStorage::empty() method which will empty
        the application cache database.

        * WebCore.base.exp:
        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::clearStorageID):
        * loader/appcache/ApplicationCache.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::clearStorageID):
        * loader/appcache/ApplicationCacheGroup.h:
        * loader/appcache/ApplicationCacheResource.h:
        (WebCore::ApplicationCacheResource::clearStorageID):
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::empty):
        * loader/appcache/ApplicationCacheStorage.h:

WebKit/mac:

2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Alexey.

        Empty the application cache when changing the cache model.

        * WebView/WebView.mm:
        (+[WebView _setCacheModel:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 12 May 2008 18:34:36 +0000 (18:34 +0000)]
2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Alexey.

        Add input method test plug-in.

        * NetscapeInputMethodPlugin: Added.
        * NetscapeInputMethodPlugin/English.lproj: Added.
        * NetscapeInputMethodPlugin/English.lproj/InfoPlist.strings: Added.
        * NetscapeInputMethodPlugin/Info.plist: Added.
        * NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Added.
        * NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj/project.pbxproj: Added.
        * NetscapeInputMethodPlugin/main.m: Added.
        (NP_Initialize):
        (NP_GetEntryPoints):
        (NP_Shutdown):
        (NPP_New):
        (NPP_Destroy):
        (NPP_SetWindow):
        (NPP_NewStream):
        (NPP_DestroyStream):
        (NPP_WriteReady):
        (NPP_Write):
        (NPP_StreamAsFile):
        (NPP_Print):
        (handleDraw):
        (invalidatePlugin):
        (handleFocusChanged):
        (handleMouseMoved):
        (handleMouseDown):
        (NPP_HandleEvent):
        (NPP_URLNotify):
        (selectionRange):
        (NPP_InsertText):
        (NPP_DoCommandBySelector):
        (markedTextAttributes):
        (NPP_SetMarkedText):
        (NPP_UnmarkText):
        (NPP_HasMarkedText):
        (NPP_AttributedSubstringFromRange):
        (NPP_MarkedRange):
        (NPP_SelectedRange):
        (NPP_FirstRectForCharacterRange):
        (pluginTextInputFuncs):
        (NPP_GetValue):
        (NPP_SetValue):
        * NetscapeInputMethodPlugin/test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit:
andersca@apple.com [Mon, 12 May 2008 17:41:37 +0000 (17:41 +0000)]
WebKit:

2008-05-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver.

        <rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins

        Add nptextinput.h as a public header.

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver.

        <rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView start]):
        Get the plug-in text input vtable pointer.

        (-[WebBaseNetscapePluginView stop]):
        Set the plug-in text input vtable pointer to 0.

        (-[WebBaseNetscapePluginView inputContext]):
        Return 0 for Carbon plug-ins since we don't want Cocoa to handle text input for them.

        (-[WebBaseNetscapePluginView hasMarkedText]):
        (-[WebBaseNetscapePluginView insertText:]):
        (-[WebBaseNetscapePluginView markedRange]):
        (-[WebBaseNetscapePluginView selectedRange]):
        (-[WebBaseNetscapePluginView setMarkedText:selectedRange:]):
        (-[WebBaseNetscapePluginView unmarkText]):
        (-[WebBaseNetscapePluginView validAttributesForMarkedText]):
        (-[WebBaseNetscapePluginView attributedSubstringFromRange:]):
        (-[WebBaseNetscapePluginView characterIndexForPoint:]):
        (-[WebBaseNetscapePluginView doCommandBySelector:]):
        (-[WebBaseNetscapePluginView firstRectForCharacterRange:]):
        (-[WebBaseNetscapePluginView conversationIdentifier]):
        Implement NSTextInput and call into the plug-in text input vtable.

        (browserTextInputFuncs):
        New method which returns the browser input vtable.

        (-[WebBaseNetscapePluginView getVariable:value:]):
        Support getting the browser input vtable pointer.

        * Plugins/WebNetscapePluginEventHandlerCocoa.h:
        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::keyDown):
        (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
        If the plug-in returns 0 when a NPCocoaEventKeyDown is passed to NPP_HandleEvent,
        it means that the event should be passed on to the input manager.

        * Plugins/npapi.mm:
        (NPN_MarkedTextAbandoned):
        (NPN_MarkedTextSelectionChanged):
        Add implementations of browser input method methods.

        * Plugins/nptextinput.h: Added.
        Add file with new text input API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 12 May 2008 17:29:35 +0000 (17:29 +0000)]
2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by John.

        Don't throw an exception if the string passed in is an invalid URL.

        * loader/appcache/DOMApplicationCache.cpp:
        (WebCore::DOMApplicationCache::remove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 12 May 2008 17:11:56 +0000 (17:11 +0000)]
2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Add the variable enums for getting the input vtables.

        * bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix
aroben@apple.com [Mon, 12 May 2008 16:35:29 +0000 (16:35 +0000)]
    Build fix

        * WebKitPrefix.cpp: Touch this so that it will rebuild after
        ENABLE_CROSS_DOCUMENT_MESSAGING was removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix
aroben@apple.com [Mon, 12 May 2008 16:31:02 +0000 (16:31 +0000)]
    Windows build fix

        * WebCorePrefix.cpp: Touched this so that it will rebuild now that
        ENABLE_CROSS_DOCUMENT_MESSAGING has been removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-12 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 12 May 2008 09:53:12 +0000 (09:53 +0000)]
2008-05-12  Maciej Stachowiak  <mjs@apple.com>

        Ooops, I made some mistakes trying to fix the validation errors. This time for sure.

        * demos/transitions-and-transforms/index.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-12 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 12 May 2008 09:45:54 +0000 (09:45 +0000)]
2008-05-12  Maciej Stachowiak  <mjs@apple.com>

        Make the demo valid HTML5 (according to validator.nu) and add alt text to the images.

        * demos/transitions-and-transforms/index.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-12 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 12 May 2008 09:10:31 +0000 (09:10 +0000)]
2008-05-12  Maciej Stachowiak  <mjs@apple.com>

        Tweaked demo visuals slightly.

        * demos/transitions-and-transforms/leopard.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-12 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 12 May 2008 07:43:22 +0000 (07:43 +0000)]
2008-05-12  Maciej Stachowiak  <mjs@apple.com>

        Tweak CSS to look a little better while loading.

        * demos/transitions-and-transforms/leopard.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-12 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 12 May 2008 07:39:20 +0000 (07:39 +0000)]
2008-05-12  Maciej Stachowiak  <mjs@apple.com>

        Not reviewed - new demo.

        Added a demo of CSS Transforms and Transitions.

        * demos/transitions-and-transforms: Added.
        * demos/transitions-and-transforms/Finder Coverflow.png: Added.
        * demos/transitions-and-transforms/Horsehead.png: Added.
        * demos/transitions-and-transforms/Mail Stationery.png: Added.
        * demos/transitions-and-transforms/Quick Look.png: Added.
        * demos/transitions-and-transforms/Spaces.png: Added.
        * demos/transitions-and-transforms/Stacks.png: Added.
        * demos/transitions-and-transforms/Time Machine.png: Added.
        * demos/transitions-and-transforms/index.html: Added.
        * demos/transitions-and-transforms/leopard.css: Added.
        * demos/transitions-and-transforms/no-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
ap@webkit.org [Mon, 12 May 2008 07:36:05 +0000 (07:36 +0000)]
    Reviewed by Maciej.

        https://bugs.webkit.org/show_bug.cgi?id=18828
        Reproducible crash with PAC file

        Naively moving JavaScriptCore into thread-specific data was inappropriate in the face of
        exiting JavaScriptCore API clients, which expect a different therading model. Temporarily
        disabling ThreadSpecific implementation until this can be sorted out.

        * wtf/ThreadSpecific.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Roll out recent threading changes (r32807, r32810, r32819, r32822) to simplify
ap@webkit.org [Mon, 12 May 2008 07:12:31 +0000 (07:12 +0000)]
    Roll out recent  threading changes (r32807, r32810, r32819, r32822) to simplify
        SquirrelFish merging.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPrevious commit made bdash sad. Restore happiness state by fixing missed style issue.
kevino@webkit.org [Mon, 12 May 2008 05:14:53 +0000 (05:14 +0000)]
Previous commit made bdash sad. Restore happiness state by fixing missed style issue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Mon, 12 May 2008 05:06:50 +0000 (05:06 +0000)]
Reviewed by Kevin Ollivier.

Fix scrolling issues by implementing transitionToCommittedNewPage() so the scroll positions are reset when a new page is loaded, and also maintained so that back and next restore the scroll positions as well. This also simplifies the logic for initializing and managing wxWebView.

https://bugs.webkit.org/show_bug.cgi?id=18992

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Mon, 12 May 2008 04:58:09 +0000 (04:58 +0000)]
Reviewed by Kevin Ollivier.

Since wx popup menus dismiss themselves when an item is selected we need to call hidePopup so webkit's internal state is correct.

https://bugs.webkit.org/show_bug.cgi?id=19000

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-11 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 12 May 2008 00:34:19 +0000 (00:34 +0000)]
2008-05-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Move some generic parsing functions into a new ParserUtilities header so that
        they can be used for non-SVG builds too.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/text/ParserUtilities.h: Added.
        (WebCore::skipString):
        * svg/SVGParserUtilities.h:
        (WebCore::isWhitespace):
        (WebCore::skipOptionalSpaces):
        (WebCore::skipOptionalSpacesOrDelimiter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-11 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 11 May 2008 20:26:28 +0000 (20:26 +0000)]
2008-05-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Add scaffolding for the implementation of Access Control for Cross-site Requests.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * xml/AccessControlList.cpp: Added.
        (WebCore::AccessControlList::AccessControlList):
        (WebCore::AccessControlList::~AccessControlList):
        (WebCore::AccessControlList::parseAccessControlHeader):
        (WebCore::AccessControlList::checkOrigin):
        * xml/AccessControlList.h: Added.
        * xml/AccessItem.cpp: Added.
        (WebCore::AccessItem::AccessItem):
        (WebCore::AccessItem::parseAccessItem):
        (WebCore::AccessItem::matches):
        * xml/AccessItem.h: Added.
        * xml/AccessItemRule.cpp: Added.
        (WebCore::AccessItemRule::AccessItemRule):
        (WebCore::AccessItemRule::parseAccessItemRule):
        * xml/AccessItemRule.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-11 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Sun, 11 May 2008 16:36:23 +0000 (16:36 +0000)]
2008-05-11  Julien Chaffraix  <jchaffraix@webkit.org>

        Debug build fix.

        * loader/appcache/ApplicationCache.cpp: Include stdio.h
        as we are using printf in ApplicationCache::dump().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Jessica Kahn.
mitz@apple.com [Sun, 11 May 2008 02:28:55 +0000 (02:28 +0000)]
    Reviewed by Jessica Kahn.

        - add a copy assignment operator to FontPlatformData on Mac to properly
          retain the m_font data member.

        * platform/graphics/mac/FontPlatformData.h:
        * platform/graphics/mac/FontPlatformDataMac.mm:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::~FontPlatformData):
        (WebCore::FontPlatformData::operator=):
        (WebCore::FontPlatformData::setFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-10 Adele Peterson <adele@apple.com>
adele@apple.com [Sat, 10 May 2008 22:01:34 +0000 (22:01 +0000)]
2008-05-10  Adele Peterson  <adele@apple.com>

        Reviewed by Tim Hatcher.

        Fix crash for WebKit clients that don't set a group name for the WebView/Page.

        * page/PageGroup.cpp: (WebCore::PageGroup::PageGroup): Instead of adding the Page directly to the group,
          call the addPage method, since it does extra work initializing m_localStorage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-10 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Sat, 10 May 2008 13:09:59 +0000 (13:09 +0000)]
2008-05-10  Julien Chaffraix  <jchaffraix@webkit.org>

        Qt & wx build fix.

        * JavaScriptCore.pri: Add profiler/Profile.cpp.
        * JavaScriptCoreSources.bkl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
rwlbuis@webkit.org [Sat, 10 May 2008 09:43:48 +0000 (09:43 +0000)]
    Reviewed by Maciej.

        Gtk+ build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Sat, 10 May 2008 04:44:05 +0000 (04:44 +0000)]
WebCore:

2008-05-09  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18958
        NULL pointer dereference in NamedAttrMap::setNamedItem

        Test: fast/dom/NamedNodeMap-setNamedItem-crash.html

        * dom/NamedAttrMap.cpp:
        (WebCore::NamedAttrMap::setNamedItem): Null check the argument.

LayoutTests:

2008-05-09  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Test for https://bugs.webkit.org/show_bug.cgi?id=18958
        NULL pointer dereference in NamedAttrMap::setNamedItem

        * fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: Added.
        * fast/dom/NamedNodeMap-setNamedItem-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll out r33018 as it broke the builds.
mrowe@apple.com [Sat, 10 May 2008 03:44:46 +0000 (03:44 +0000)]
Roll out r33018 as it broke the builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-09 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 10 May 2008 00:46:50 +0000 (00:46 +0000)]
2008-05-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        Add x86_64 rule.

        * Makefile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate TestNetscapePlugIn to build 64-bit using the Cocoa event model.
mrowe@apple.com [Sat, 10 May 2008 00:44:44 +0000 (00:44 +0000)]
Update TestNetscapePlugIn to build 64-bit using the Cocoa event model.

It currently does not attempt to print events which means that plugins/mouse-events.html
will fail when run 64-bit.  All other tests that use this plugin pass.

Reviewed by Anders Carlsson.

* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(testGetIntIdentifier):
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
(NPP_HandleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit:
andersca@apple.com [Sat, 10 May 2008 00:40:41 +0000 (00:40 +0000)]
WebKit:

2008-05-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver.

        <rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins

        Add nptextinput.h as a public header.

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-05-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver.

        <rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView start]):
        Get the plug-in text input vtable pointer.

        (-[WebBaseNetscapePluginView stop]):
        Set the plug-in text input vtable pointer to 0.

        (-[WebBaseNetscapePluginView inputContext]):
        Return 0 for Carbon plug-ins since we don't want Cocoa to handle text input for them.

        (-[WebBaseNetscapePluginView hasMarkedText]):
        (-[WebBaseNetscapePluginView insertText:]):
        (-[WebBaseNetscapePluginView markedRange]):
        (-[WebBaseNetscapePluginView selectedRange]):
        (-[WebBaseNetscapePluginView setMarkedText:selectedRange:]):
        (-[WebBaseNetscapePluginView unmarkText]):
        (-[WebBaseNetscapePluginView validAttributesForMarkedText]):
        (-[WebBaseNetscapePluginView attributedSubstringFromRange:]):
        (-[WebBaseNetscapePluginView characterIndexForPoint:]):
        (-[WebBaseNetscapePluginView doCommandBySelector:]):
        (-[WebBaseNetscapePluginView firstRectForCharacterRange:]):
        (-[WebBaseNetscapePluginView conversationIdentifier]):
        Implement NSTextInput and call into the plug-in text input vtable.

        (browserTextInputFuncs):
        New method which returns the browser input vtable.

        (-[WebBaseNetscapePluginView getVariable:value:]):
        Support getting the browser input vtable pointer.

        * Plugins/WebNetscapePluginEventHandlerCocoa.h:
        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::keyDown):
        (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
        If the plug-in returns 0 when a NPCocoaEventKeyDown is passed to NPP_HandleEvent,
        it means that the event should be passed on to the input manager.

        * Plugins/npapi.mm:
        (NPN_MarkedTextAbandoned):
        (NPN_MarkedTextSelectionChanged):
        Add implementations of browser input method methods.

        * Plugins/nptextinput.h: Added.
        Add file with new text input API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit/win:
beidson@apple.com [Sat, 10 May 2008 00:26:15 +0000 (00:26 +0000)]
WebKit/win:
        Reviewed by Adam Roben

        Fix a hang-on-quit bug where in the DLL_PROCESS_DETACH DllMain callback, we assummed that
        we could cleanly shutdown WebKit but we couldn't because any background threads have already
        been uncleanly aborted at that point.

        * ForEachCoClass.cpp:
        (shutDownWebKit): Moved from WebKitDLL to here, to be exposed via WebKit.def
        * ForEachCoClass.h:

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_debug.def:

        * WebKitDLL.cpp:
        (DllMain): Don't call shutDownWebKit here

WebKitTools:
        Reviewed by Adam Roben

        Explicitly call shutDownWebKit() before quitting.

        * Drosera/win/Drosera.cpp:
        (_tWinMain):

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoChanged tabs into spaces for VPATH and DOM_CLASSES items.
ddkilzer@apple.com [Sat, 10 May 2008 00:25:03 +0000 (00:25 +0000)]
Changed tabs into spaces for VPATH and DOM_CLASSES items.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Tiger build of Drosera.
mrowe@apple.com [Fri, 9 May 2008 23:47:46 +0000 (23:47 +0000)]
Fix the Tiger build of Drosera.

* Drosera/config.h: Define BUILDING_ON_TIGER when building on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild Fix
beidson@apple.com [Fri, 9 May 2008 21:28:03 +0000 (21:28 +0000)]
Build Fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-09 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 9 May 2008 21:06:33 +0000 (21:06 +0000)]
2008-05-09  Kevin McCullough  <kmccullough@apple.com>

        Build fix.

        * page/Console.cpp:
        (WebCore::Console::profile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Fri, 9 May 2008 20:52:15 +0000 (20:52 +0000)]
WebCore:

2008-05-09  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Mark Rowe.

        Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.

        * Configurations/WebCore.xcconfig:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/build-generated-files.sh:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::customGetOwnPropertySlot):
        (WebCore::JSDOMWindow::postMessage):
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/objc/DOMEvents.mm:
        (+[DOMEvent _wrapEvent:WebCore::]):
        * dom/Document.cpp:
        (WebCore::Document::createEvent):
        * dom/Event.cpp:
        (WebCore::Event::isMessageEvent):
        * dom/Event.h:
        * dom/MessageEvent.cpp:
        * dom/MessageEvent.h:
        * dom/MessageEvent.idl:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::postMessageTimerFired):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

WebKit/win:

2008-05-09  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Mark Rowe.

        Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.

        * WebKit.vcproj/WebKit.vcproj:

WebKitTools:

2008-05-09  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Mark Rowe.

        Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix
aroben@apple.com [Fri, 9 May 2008 20:43:45 +0000 (20:43 +0000)]
    Build fix

        * Interfaces/WebKit.idl: Touched.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-09 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 9 May 2008 20:18:08 +0000 (20:18 +0000)]
2008-05-09  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        -Add Profile class so that all profiles can be stored and retrieved by
        the WebInspector when that time comes.

        * JavaScriptCore.exp: Export the new function signatures.
        * JavaScriptCore.xcodeproj/project.pbxproj: Add the new files to the
        project
        * profiler/Profile.cpp: Added. This class represents a single run of the
        profiler.
        (KJS::Profile::Profile):
        (KJS::Profile::willExecute):
        (KJS::Profile::didExecute):
        (KJS::Profile::printDataInspectorStyle):
        (KJS::functionNameCountPairComparator):
        (KJS::Profile::printDataSampleStyle):
        * profiler/Profile.h: Added. Ditto
        (KJS::Profile::stopProfiling):
        * profiler/Profiler.cpp: Now the profiler keeps track of many profiles
        but only runs one at a time.
        (KJS::Profiler::startProfiling):
        (KJS::Profiler::stopProfiling):
        (KJS::Profiler::willExecute):
        (KJS::Profiler::didExecute):
        (KJS::Profiler::printDataInspectorStyle):
        (KJS::Profiler::printDataSampleStyle):
        * profiler/Profiler.h: Ditto.
        (KJS::Profiler::~Profiler):
        (KJS::Profiler::allProfiles):
        (KJS::Profiler::clearProfiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Fri, 9 May 2008 20:14:29 +0000 (20:14 +0000)]
WebCore:

2008-05-09  Adam Barth  <abarth-webkit@adambarth.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=18771

        Make postMessage generate an event on the window instead of the
        document.

        Test: http/tests/messaging/cross-domain-message-event-dispatch.html

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchWindowEvent):
        * dom/EventTargetNode.h:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

2008-05-09  Adam Barth  <abarth-webkit@adambarth.com>

        Reviewed by Sam Weinig.

        Update tests to listen for message events on the window instead of
        the document.  Also, added a test that the event is sent to the
        window and not to the document.

        * http/tests/messaging/cross-domain-message-event-dispatch-expected.txt: Added.
        * http/tests/messaging/cross-domain-message-event-dispatch.html: Added.
        * http/tests/messaging/cross-domain-message-send.html:
        * http/tests/messaging/resources/cross-domain-message-receive.html:
        * http/tests/security/cross-frame-access-delete.html:
        * http/tests/security/cross-frame-access-history-put.html:
        * http/tests/security/cross-frame-access-location-put.html:
        * http/tests/security/postMessage/delivery-order.html:
        * http/tests/security/postMessage/invalid-origin-throws-exception.html:
        * http/tests/security/postMessage/javascript-page-still-sends-origin.html:
        * http/tests/security/postMessage/origin-unaffected-by-base-tag.html:
        * http/tests/security/postMessage/origin-unaffected-by-document-domain.html:
        * http/tests/security/postMessage/resources/post-message-listener.html:
        * http/tests/security/postMessage/target-origin.html:
        * http/tests/security/resources/cross-frame-iframe-for-delete-test.html:
        * http/tests/security/resources/cross-frame-iframe-for-history-put-test.html:
        * http/tests/security/resources/cross-frame-iframe-for-location-put-test.html:
        * http/tests/security/xss-eval.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Fri, 9 May 2008 13:08:33 +0000 (13:08 +0000)]
Simon Hausmann <hausmann@webkit.org>

Removed explicit linkage against libxml and libxslt on Qt/Mac builds.

This dependency is completely unnecessary here and creates only problems by
propagating through WebCore.pro over libQtWebKit.prl right now customer
applications.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoThiago Macieira <tjmaciei@trolltech.com>
hausmann@webkit.org [Fri, 9 May 2008 11:40:37 +0000 (11:40 +0000)]
Thiago Macieira <tjmaciei@trolltech.com>

Fix bad includes in QtWebKit public headers.

Make sure to include qglobal.h using the QtCore prefix so that an explicit
include/QtCore is not needed in the application's build system. Also make sure
that qwebsettings.h includes the local qwebkitglobal.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-09 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Fri, 9 May 2008 10:21:02 +0000 (10:21 +0000)]
2008-05-09  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Replaced all instances of qDebug() with LOG(Media, ...)
        in MediaPlayerPrivatePhonon.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-09 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Fri, 9 May 2008 09:38:54 +0000 (09:38 +0000)]
2008-05-09  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Fix the Qt/Mac build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk>
hausmann@webkit.org [Fri, 9 May 2008 08:48:52 +0000 (08:48 +0000)]
2008-05-08  Marc Ordinas i Llopis  <marc.ordinasillopis@collabora.co.uk>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=18935

        Based on work by Sriram Neelakandan for the Gtk port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAnother attempt at a Tiger build fix.
mrowe@apple.com [Fri, 9 May 2008 06:16:11 +0000 (06:16 +0000)]
Another attempt at a Tiger build fix.

Use DumpRenderTreeMac.h rather than DumpRenderTree.h as DumpRenderTreePasteboard is not an Obj-C++ file.

* DumpRenderTree/mac/DumpRenderTreePasteboard.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTiger build fix. Include DumpRenderTree.h so that BUILDING_ON_TIGER will be defined.
mrowe@apple.com [Fri, 9 May 2008 06:08:15 +0000 (06:08 +0000)]
Tiger build fix.  Include DumpRenderTree.h so that BUILDING_ON_TIGER will be defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate DumpRenderTree to build 64-bit.
mrowe@apple.com [Fri, 9 May 2008 05:43:20 +0000 (05:43 +0000)]
Update DumpRenderTree to build 64-bit.

The three major changes here are:
1) Use NSInteger in the appropriate places.
2) Use ColorSync API that is available in 64-bit to switch display profiles.
3) Use method-swizzling to achieve similar results to class posing when using the Obj-C 2.0 runtime.

The build of DumpRenderTree will still fail in 64-bit for now as the TestNetscapePlugIn target also
needs updated to successfully build.

Reviewed by Oliver Hunt and Dan Bernstein.

* DumpRenderTree/mac/Configurations/Base.xcconfig: Don't prevent Xcode from building 64-bit.
* DumpRenderTree/mac/DumpRenderTree.mm:
(swizzleAllMethods):
(poseAsClass):
(prepareConsistentTestingEnvironment):
* DumpRenderTree/mac/DumpRenderTreeMac.h:
* DumpRenderTree/mac/DumpRenderTreePasteboard.h:
* DumpRenderTree/mac/DumpRenderTreePasteboard.m:
* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(restoreColorSpace):
(failedGettingCurrentProfile):
(setDefaultColorProfileToRGB):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoClean up Drosera so that it will build 64-bit.
mrowe@apple.com [Fri, 9 May 2008 05:43:17 +0000 (05:43 +0000)]
Clean up Drosera so that it will build 64-bit.

Reviewed by Darin Adler.

* Drosera/mac/DebuggerApplication.mm:
(-[DebuggerApplication numberOfRowsInTableView:]): Use NSInteger rather than int.
(-[DebuggerApplication tableView:objectValueForTableColumn:row:]): Ditto.
* Drosera/mac/Drosera.xcodeproj/project.pbxproj: Use the default value for VALID_ARCHS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 9 May 2008 05:13:31 +0000 (05:13 +0000)]
2008-05-08  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Rename the XMLHttpRequestState enum values to match the spec.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::responseXML):
        (WebCore::XMLHttpRequest::XMLHttpRequest):
        (WebCore::XMLHttpRequest::callReadyStateChangeListener):
        (WebCore::XMLHttpRequest::open):
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::abort):
        (WebCore::XMLHttpRequest::setRequestHeader):
        (WebCore::XMLHttpRequest::getAllResponseHeaders):
        (WebCore::XMLHttpRequest::getResponseHeader):
        (WebCore::XMLHttpRequest::status):
        (WebCore::XMLHttpRequest::statusText):
        (WebCore::XMLHttpRequest::processSyncLoadResults):
        (WebCore::XMLHttpRequest::didFinishLoading):
        (WebCore::XMLHttpRequest::didReceiveData):
        * xml/XMLHttpRequest.h:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Fri, 9 May 2008 05:06:58 +0000 (05:06 +0000)]
WebCore:

        Reviewed by Mark Rowe.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18818
          <rdar://problem/5901544> REGRESSION (3.1.1-TOT): Character order (float:left ordered after the first letter)

        Test: fast/css/first-letter-float-after-float.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter): Changed to add the first
        letter container right before the rest of the text it is taken from,
        instead of at the beginning of the block.

LayoutTests:

        Reviewed by Mark Rowe.

        - test and updated results for https://bugs.webkit.org/show_bug.cgi?id=18818
          <rdar://problem/5901544> REGRESSION (3.1.1-TOT): Character order (float:left ordered after the first letter)

        * ChangeLog:
        * fast/css/first-letter-float-after-float.html: Added.
        * platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.checksum:
        * platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.png:
        * platform/mac/fast/css/first-letter-float-after-float-expected.checksum: Added.
        * platform/mac/fast/css/first-letter-float-after-float-expected.png: Added.
        * platform/mac/fast/css/first-letter-float-after-float-expected.txt: Added.
        * platform/mac/fast/css/first-letter-skip-out-of-flow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5921046> AX: list box options have wrong AXPosition
cfleizach@apple.com [Fri, 9 May 2008 00:02:52 +0000 (00:02 +0000)]
<rdar://problem/5921046> AX: list box options have wrong AXPosition

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Thu, 8 May 2008 23:59:39 +0000 (23:59 +0000)]
2008-05-08  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Bug 18916: make_names.pl --factory needs to support custom c++ guard

        Add --guardFactoryWith to handle the cpp guard around generated factories.

        * DerivedSources.make: Set the guardFactoryWith variable for SVG factory.
        * GNUmakefile.am: Ditto.
        * WebCore.pro: Ditto.
        * dom/make_names.pl: Add guardFactoryWith option.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 8 May 2008 21:36:01 +0000 (21:36 +0000)]
2008-05-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        Enable NPAPI plug-ins on 64-bit.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Thu, 8 May 2008 20:32:17 +0000 (20:32 +0000)]
2008-05-08  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Adam Roben.

        wx & Gtk build fix.

        Should also fix the cURL backend for the Windows port.

        * WebCore.vcproj/WebCore.vcproj: Add FormDataStreamCurl information.
        * platform/network/curl/FormDataStreamCurl.h: Include stdio.h which
        fixes the build on some machine.

        * webcore-wx.bkl: Add FormDataStreamCurl.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Timothy Hatcher <timothy@apple.com>
timothy@apple.com [Thu, 8 May 2008 20:00:17 +0000 (20:00 +0000)]
2008-05-08  Timothy Hatcher  <timothy@apple.com>

        Fixes the bug where the Web Inspector could not
        find any localization strings.

        Reviewed by Mark Rowe.

        * WebCore.xcodeproj/project.pbxproj: Add the localizedStrings.js
        file to the WebCore Copy Resources phase. Also removes an idl from
        the Copy Resources phase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
mitz@apple.com [Thu, 8 May 2008 19:04:54 +0000 (19:04 +0000)]
    Reviewed by Adam Roben.

        - fix <rdar://problem/5697957> "No recent searches" label in a narrow search field's history popup is truncated

        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::calculatePositionAndSize): Changed to use a bold
        font for measuring labels.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoffrey Garen.
mitz@apple.com [Thu, 8 May 2008 18:54:39 +0000 (18:54 +0000)]
    Reviewed by Geoffrey Garen.

        - cross-platform fix for http://bugs.webkit.org/show_bug.cgi?id=17590
          ASSERTION FAILED: subject in jsRegExpExecute()

        * page/Frame.cpp:
        (WebCore::Frame::matchLabelsAgainstElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Thu, 8 May 2008 18:11:43 +0000 (18:11 +0000)]
2008-05-08  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig.

        Add a link to the Mac OS Forge terms of use.

        * nav.inc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Thu, 8 May 2008 14:58:01 +0000 (14:58 +0000)]
2008-05-08  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        Simple ImageBuffer::image implementation.

        In contrast to cg and cairo we do not use a special BitmapImage because
        the ownership of the FrameData inside the BitmapImage is a bit backward
        (actually owned by the ImageDecoderQt...). Further work is needed for image
        and pixmap handling in the qt port...

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Thu, 8 May 2008 14:57:35 +0000 (14:57 +0000)]
2008-05-08  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        Update the WebKit.qrc of the inspector to be functional again

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 8 May 2008 13:53:11 +0000 (13:53 +0000)]
2008-05-08  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Fix the Qt/Mac build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWarwick Allison <warwick@trolltech.com>
hausmann@webkit.org [Thu, 8 May 2008 10:40:09 +0000 (10:40 +0000)]
Warwick Allison <warwick@trolltech.com>

Fixes: WebKit expects initial input method state to be *disabled*.

At least QWS does not need the initial input method state to be forced to
enabled, but other platforms (esp. X11) do. Until fixed/tested on those
platforms, this is specific to QWS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Thu, 8 May 2008 09:39:35 +0000 (09:39 +0000)]
2008-05-08  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Use native Windows library handling (instead of QLibrary)
        for Qt/Win32's PlatformModule.

        * platform/FileSystem.h:
        (WebCore::PlatformModuleVersion::PlatformModuleVersion):
        * platform/qt/FileSystemQt.cpp:
        (WebCore::unloadModule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Thu, 8 May 2008 09:38:24 +0000 (09:38 +0000)]
2008-05-08  Simon Hausmann  <hausmann@webkit.org>

        Reviewed and found by Holger.

        Include .css in the list of extensions for text/css. Fixes
        fast/loader/local-css-allowed-in-strict-mode.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Thu, 8 May 2008 07:45:01 +0000 (07:45 +0000)]
2008-05-08  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt and Wx build when compiling without offline app support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Thu, 8 May 2008 03:28:48 +0000 (03:28 +0000)]
2008-05-07  Stephanie Lewis  <slewis@apple.com>

        fix messed up result

        * fast/events/onunload-not-on-body-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 8 May 2008 02:13:39 +0000 (02:13 +0000)]
2008-05-07  Sam Weinig  <sam@webkit.org>

        Reviewed by Adele Peterson

        Update MessageEvent to match the latest version of the HTML5 spec,
        adding the lastEventId attribute.

        * dom/MessageEvent.cpp:
        (WebCore::MessageEvent::MessageEvent):
        (WebCore::MessageEvent::initMessageEvent):
        * dom/MessageEvent.h:
        (WebCore::MessageEvent::lastEventId):
        * dom/MessageEvent.idl:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::postMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Thu, 8 May 2008 01:05:19 +0000 (01:05 +0000)]
2008-05-07  Stephanie Lewis <slewis@apple.com>

        Reviewed by Maciej.

        remove non-functioning code.  If onunload should be fired from these nodes then
        a WindowEventListener needs to be set.  However, Firefox and IE also do not
        fire onunload events for these cases.

        Test: fast/events/onunload-not-on-body.html

        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::parseMappedAttribute):
        * html/HTMLObjectElement.cpp
        (WebCore::HTMLObjectElement::parseMappedAttribute):

        Test onunload attr on a frame does not call onunload, but that an onunload attr on the body of
        a frame does.  Also test that onunloads on object elements are not called.

        * fast/events/onunload-not-on-body-expected.txt: Added.
        * fast/events/onunload-not-on-body.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Wed, 7 May 2008 20:44:42 +0000 (20:44 +0000)]
WebCore:

        Reviewed by John Sullivan.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18909
          <rdar://problem/5914165> REGRESSION (r31872-r31878): Viewed photos not closing completely at indycar.com

        Test: fast/dynamic/positioned-movement-with-positioned-children.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutOnlyPositionedObjects): Cover the case of
        a positioned object that has only moved and has only positioned children
        that have changed.
        * rendering/RenderObject.h:
        (WebCore::RenderObject::needsPositionedMovementLayout): Added this
        accessor.

LayoutTests:

        Reviewed by John Sullivan.

        - test for https://bugs.webkit.org/show_bug.cgi?id=18909
          <rdar://problem/5914165> REGRESSION (r31872-r31878): Viewed photos not closing completely at indycar.com

        * fast/dynamic/positioned-movement-with-positioned-children.html: Added.
        * platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.checksum: Added.
        * platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.png: Added.
        * platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 7 May 2008 20:41:34 +0000 (20:41 +0000)]
2008-05-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by John.

        When no document loaders are associated with an application cache group,
        release the reference to the newest cache group. This prevents reference cycles.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
        (WebCore::ApplicationCacheGroup::documentLoaderDestroyed):
        (WebCore::ApplicationCacheGroup::cacheDestroyed):
        * loader/appcache/ApplicationCacheGroup.h:

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::cacheGroupForURL):
        Return early if the datbase wasn't open.

        (WebCore::ApplicationCacheStorage::loadCache):
        Add error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 7 May 2008 19:42:34 +0000 (19:42 +0000)]
2008-05-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Don't put pages with an application cache in the BF cache.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::canCachePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Wed, 7 May 2008 18:59:37 +0000 (18:59 +0000)]
WebCore:

2008-05-07  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/5666354> Crashes in Mail at WebCore::RemoveNodeCommand::doApply

        When a single tab or series of tabs was copied, we weren't putting them into a
        tab span.  On Paste, we would be given a text node with a single tab or series
        of tabs in it, and we would crash when inserting it at the start of a block
        (where that kind of text becomes completely unrendered).

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Clean
        up correctly and early return if we removed everything that was inserted.
        * editing/markup.cpp:
        (WebCore::createMarkup):  Include the tab span when the only thing copied
        was a tab or a series of tabs.

LayoutTests:

2008-05-07  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/5666354> Crashes in Mail at WebCore::RemoveNodeCommand::doApply

        * editing/pasteboard/5761530-1-expected.txt: Added.
        * editing/pasteboard/5761530-1.html: Added.
        * editing/pasteboard/5761530-2-expected.txt: Added.
        * editing/pasteboard/5761530-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 7 May 2008 18:02:46 +0000 (18:02 +0000)]
2008-05-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        REGRESSION (3.1.1-TOT): Arrow keys are sticky in Google Maps street view
        https://bugs.webkit.org/show_bug.cgi?id=18880
        <rdar://problem/5909513>

        Stop suspending key up events before calling handleEvent.

        * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
        (WebNetscapePluginEventHandlerCarbon::sendEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded radar to changelog for r32959.
ddkilzer@apple.com [Wed, 7 May 2008 17:33:19 +0000 (17:33 +0000)]
Added radar to changelog for r32959.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Wed, 7 May 2008 17:16:03 +0000 (17:16 +0000)]
2008-05-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Adam Roben.

        wx & Gtk build fix.

        Add SIZE_MAX definition for the wx port.

        * os-win32/stdint.h:

2008-05-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Adam Roben.

        wx & Gtk build fix.

        * platform/network/curl/FormDataStreamCurl.cpp: Added stdint.h include. We need to define
        __STDC_LIMIT_MACROS to have SIZE_MAX exported.
        * platform/network/curl/FormDataStreamCurl.h: Removed cstdint include (replaced by stdint.h)
        as it is not present on the build bots.
        * plugins/gtk/PluginDatabaseGtk.cpp: Added missing #endif.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
ddkilzer@apple.com [Wed, 7 May 2008 17:11:46 +0000 (17:11 +0000)]
WebCore:

        Bug 18900: Password field has focus but can't type text (i.rememberthemilk.com)
        <https://bugs.webkit.org/show_bug.cgi?id=18900>

        Original patch by Aaron Golden and Tim Omernick.  Reviewed by Adele.

        Test: fast/forms/textfield-to-password-on-focus.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType): If the current node has
        focus, call updateFocusAppearance() to make sure its state is correct
        after changing its type.

LayoutTests:

        Bug 18900: Password field has focus but can't type text (i.rememberthemilk.com)
        <https://bugs.webkit.org/show_bug.cgi?id=18900>

        Reviewed by Adele.

        * fast/forms/textfield-to-password-on-focus-expected.txt: Added.
        * fast/forms/textfield-to-password-on-focus.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/4867889> REGRESSION: "Choose File.." buttons are exposed as AXGroup...
cfleizach@apple.com [Wed, 7 May 2008 16:35:48 +0000 (16:35 +0000)]
<rdar://problem/4867889> REGRESSION: "Choose File.." buttons are exposed as AXGroup instead of AXButton

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Wed, 7 May 2008 14:21:40 +0000 (14:21 +0000)]
2008-05-07  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Add ~250 tests that fail to the skipped list so we have a sane baseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Wed, 7 May 2008 13:05:27 +0000 (13:05 +0000)]
2008-05-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Bug 17971: [Curl] FormData processing should be moved to its own class

        Move FormData treatment into FormDataStream. The aim is to have FormDataStream behave like a stream that cURL
        could manipulate.

        First step into having complete file uploading facility in cURL.

        No test case as it is only code refactoring.

        * GNUmakefile.am: Add FormDataStreamCurl.cpp
        * platform/network/ResourceHandleInternal.h: Move code to FormStreamDataCurl.h
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/curl/FormDataStreamCurl.cpp: Added.
        (WebCore::FormDataStream::~FormDataStream):
        (WebCore::FormDataStream::read):
        * platform/network/curl/FormDataStreamCurl.h: Added.
        (WebCore::FormDataStream::FormDataStream):
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::readCallback): Move code to FormDataStreamCurl.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Adam Treat <treat@kde.org>
hausmann@webkit.org [Wed, 7 May 2008 12:28:42 +0000 (12:28 +0000)]
2008-05-07  Adam Treat  <treat@kde.org>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=18898

        Fixed wrong transform being used for creating the pixmap for a new
        transparency layer. This fixes the popup menus on dell.com.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 7 May 2008 12:10:01 +0000 (12:10 +0000)]
2008-05-07  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Share the plug-in directories between Gtk and Qt/X11 port.

        * platform/qt/FileSystemQt.cpp:
        (WebCore::homeDirectoryPath): Implement it for Qt.
        * plugins/PluginDatabase.cpp:
        (WebCore::addMozillaPluginDirectories): Shared code.
        (WebCore::PluginDatabase::defaultPluginDirectories):
        (WebCore::PluginDatabase::isPreferredPluginDirectory): Shared code.
        * plugins/gtk/PluginDatabaseGtk.cpp:
        (WebCore::PluginDatabase::isPreferredPluginDirectory): Refactored.
        * plugins/qt/PluginDatabaseQt.cpp: Refactored.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Wed, 7 May 2008 11:46:01 +0000 (11:46 +0000)]
2008-05-07  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Fix build issues on Mac and refeactor the .pro file a bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Wed, 7 May 2008 11:45:30 +0000 (11:45 +0000)]
2008-05-07  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Draw scrollview corners (between scrollbars) using the Qt style.

        https://bugs.webkit.org/show_bug.cgi?id=18894

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Use File::Find and Getopt::Long in make-js-test-wrappers
ddkilzer@apple.com [Wed, 7 May 2008 09:50:58 +0000 (09:50 +0000)]
    Use File::Find and Getopt::Long in make-js-test-wrappers

        Reviewed by Darin.

        * Scripts/make-js-test-wrappers:
        - Updated Apple copyright statement.
        - Added command-line switch parsing and -h|--help switch.
        - Allowed user to pass list of files/directories on which to do
          a restricted search for TEMPLATE.html files.  The default
          behavior is still to search the entire LayoutTests directory.
        - Removed duplicate 'use strict' statement.
        - Replaced use of `find` statements with File::Find::find().
        - Remove unneeded chomp() calls now that we use File::Find.
        (directoryFilter): Added.  Filters .svn directories when used
        with File::Find::find().
        (findTemplateFiles): Added.  Returns a list of TEMPLATE.html
        files found.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Wed, 7 May 2008 09:37:29 +0000 (09:37 +0000)]
2008-05-07  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt build, added AccessibilityListBox and ListBoxOption.cpp to
        the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 7 May 2008 09:37:13 +0000 (09:37 +0000)]
2008-05-07  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Support for isMainThread in the Qt port.

        * wtf/ThreadingQt.cpp:
        (WTF::initializeThreading): Adjusted.
        (WTF::isMainThread): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 7 May 2008 09:36:59 +0000 (09:36 +0000)]
2008-05-07  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Holger.

        Fix building without storage support.

        * page/PageGroup.cpp:
        (WebCore::PageGroup::closeLocalStorage): proper #if

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 7 May 2008 09:36:39 +0000 (09:36 +0000)]
2008-05-07  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Oliver Hunt.

        Fix building without accessibility.

        * page/AXObjectCache.cpp:
        (WebCore::AXObjectCache::selectedChildrenChanged): proper #if

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Wed, 7 May 2008 06:33:25 +0000 (06:33 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix <rdar://problem/5914544> Crash in layoutInlineChildren()

        Test: fast/block/float/float-on-zero-height-line.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::markLinesDirtyInVerticalRange):

LayoutTests:

        Reviewed by Darin Adler.

        - test for <rdar://problem/5914544> Crash in layoutInlineChildren()

        * fast/block/float/float-on-zero-height-line.html: Added.
        * platform/mac/fast/block/float/float-on-zero-height-line-expected.checksum: Added.
        * platform/mac/fast/block/float/float-on-zero-height-line-expected.png: Added.
        * platform/mac/fast/block/float/float-on-zero-height-line-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Wed, 7 May 2008 06:16:14 +0000 (06:16 +0000)]
2008-05-06  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Andersca.

        prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file.

        * Plugins/WebPluginDatabase.m: Removed.
        * Plugins/WebPluginDatabase.mm: Copied from WebKit/mac/Plugins/WebPluginDatabase.m.
        * Plugins/npapi.m: Removed.
        * Plugins/npapi.mm: Copied from WebKit/mac/Plugins/npapi.m.

        prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
alice.liu@apple.com [Wed, 7 May 2008 05:35:24 +0000 (05:35 +0000)]
WebCore:

2008-05-06  Alice Liu  <alice.liu@apple.com>

        Reviewed by Adele Peterson and John Sullivan.

        changes needed to build on Windows after r32911 and r32927

        * WebCore.vcproj/WebCore.vcproj:
        * page/AXObjectCache.cpp:
        (WebCore::AXObjectCache::selectedChildrenChanged):
        * page/AccessibilityObject.h:
        (WebCore::AccessibilityObject::document):
        (WebCore::AccessibilityObject::topDocumentFrameView):
        (WebCore::AccessibilityObject::documentFrameView):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::document):
        (WebCore::AccessibilityRenderObject::topDocumentFrameView):
        (WebCore::AccessibilityRenderObject::documentFrameView):
        * page/AccessibilityRenderObject.h:
        * page/mac/AXObjectCacheMac.mm:
        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper position]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

WebKit/win:

2008-05-06  Alice Liu  <alice.liu@apple.com>

        Reviewed by Adele Peterson and John Sullivan.

        changes needed to build on Windows after r32911 and r32927

        * AccessibleBase.cpp:
        (AccessibleBase::get_accParent):
        * AccessibleDocument.cpp:
        (AccessibleDocument::document):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 7 May 2008 05:31:34 +0000 (05:31 +0000)]
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Fix a few bugs with the final sync'ing of LocalStorageAreas when the thread is shut down.
        1 - A sync task actually needs to be scheduled for each LocalStorageArea when the shut down occurs.
        2 - Pending sync timers all need to be cancelled.

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea):
        (WebCore::LocalStorage::close): Tell each LocalStorageArea to schedule it's final sync before scheduling
          thread termination.
        * storage/LocalStorage.h:  Change the map to be of LocalStorageAreas instead of StorageAreas

        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::LocalStorageArea):
        (WebCore::LocalStorageArea::~LocalStorageArea): ASSERT the timer has been cancelled, but make SURE it is
          in release builds.
        (WebCore::LocalStorageArea::scheduleFinalSync): Cancel the sync timer, schedule the final sync, and set the
          "final sync scheduled" flag
        (WebCore::LocalStorageArea::scheduleItemForSync): ASSERT that the final sync hasn't already been scheduled
        (WebCore::LocalStorageArea::scheduleClear): Ditto
        * storage/LocalStorageArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32942 268f45cc-cd09-0410-ab3c-d52691b4dbfc