ojan@chromium.org [Mon, 13 Feb 2012 23:37:55 +0000 (23:37 +0000)]
nesting horizontal flexboxes is broken
https://bugs.webkit.org/show_bug.cgi?id=76867
Reviewed by David Hyatt.
Source/WebCore:
This is copied from RenderDeprecatedFlexibleBox and updated
for RenderFlexibleBox and to handle vertical writing mode.
Tests: css3/flexbox/preferred-widths-orthogonal.html
css3/flexbox/preferred-widths.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths):
* rendering/RenderFlexibleBox.cpp:
(WebCore::marginWidthForChild):
(WebCore):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
LayoutTests:
* css3/flexbox/floated-flexbox-expected.txt:
* css3/flexbox/line-wrapping.html:
The old results here were wrong because they wrapped the contents of each flex item.
* css3/flexbox/preferred-widths-expected.txt: Added.
* css3/flexbox/preferred-widths-orthogonal-expected.txt: Added.
* css3/flexbox/preferred-widths-orthogonal.html: Added.
* css3/flexbox/preferred-widths.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihnea@adobe.com [Mon, 13 Feb 2012 23:28:30 +0000 (23:28 +0000)]
Crash in RenderFlowThread::setRegionBoxesRegionStyle
https://bugs.webkit.org/show_bug.cgi?id=78298
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/regions/set-box-style-in-region-crash.html
We have to make sure that anonymous block objects get their information in RenderFlowThread
removed properly.
* dom/Node.cpp:
(WebCore::Node::diff):
Correct a comment.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseAnonymousBoxChild):
Remove the information for anonymous block from render flow thread.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::removeFlowChildInfo):
(WebCore):
(WebCore::RenderFlowThread::setRegionRangeForBox):
Do not set region range if the flow thread does not have regions.
* rendering/RenderFlowThread.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
Add an assert to make sure that after we remove an object, there is no remaining info
in any render flow thread.
LayoutTests:
* fast/regions/set-box-style-in-region-crash-expected.txt: Added.
* fast/regions/set-box-style-in-region-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 13 Feb 2012 23:22:10 +0000 (23:22 +0000)]
[chromium] Unreviewed, skip http/tests/navigation/https-in-page-cache.html
because we don't enable the page cache in chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 13 Feb 2012 23:17:29 +0000 (23:17 +0000)]
Add a skeleton ChromiumAndroid port to webkitpy
https://bugs.webkit.org/show_bug.cgi?id=78543
Reviewed by Eric Seidel.
This patch just adds an empty ChromiumAndroid port object to webkitpy
and wires it up to the factory objects. An actual implementation will
follow.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
* Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
(ChromiumAndroidPort):
(ChromiumAndroidPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest.test_all_test_configurations):
* Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 13 Feb 2012 23:13:14 +0000 (23:13 +0000)]
[chromium] Unreviewed, r107611 enabled layout tests in css3/filters,
but some are missing results.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Mon, 13 Feb 2012 23:10:37 +0000 (23:10 +0000)]
[chromium] Let WebKit::initialize call InitWebCoreSystemInterface on mac.
https://bugs.webkit.org/show_bug.cgi?id=78246
This allows removing a bunch of code in chromium land (https://chromiumcodereview.appspot.com/9374020/),
and helps with the component build on mac (InitWebCoreSystemInterface is not an
exported function, and it shouldn't be).
Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm early-returns when it's
called twice, so it's safe to land this change, and remove the calls in client
code in a later CL.
Reviewed by Darin Fisher.
* src/WebKit.cpp:
(WebKit::initializeWithoutV8):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 13 Feb 2012 23:07:22 +0000 (23:07 +0000)]
[chromium] Unreviewed gardening. We don't need to pass
platform/win/inverted-colors/non-composited.html.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Mon, 13 Feb 2012 22:59:15 +0000 (22:59 +0000)]
[chromium] Unreviewed gardening. Rebaselining GPU results.
* platform/chromium-gpu-linux/media/controls-after-reload-expected.png:
* platform/chromium-gpu-linux/media/controls-strict-expected.png:
* platform/chromium-gpu-linux/media/controls-styling-expected.png:
* platform/chromium-gpu-linux/media/controls-without-preload-expected.png:
* platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png:
* platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
* platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
* platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
* platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
* platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png:
* platform/chromium-gpu-linux/media/video-transformed-expected.png:
* platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-expected.png:
* platform/chromium-gpu-mac/media/controls-after-reload-expected.txt: Removed.
* platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
* platform/chromium-gpu-mac/media/video-playing-and-pause-expected.txt: Removed.
* platform/chromium-gpu-win/media/controls-strict-expected.txt: Removed.
* platform/chromium-gpu-win/media/controls-styling-expected.txt: Removed.
* platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Removed.
* platform/chromium-gpu-win/media/video-controls-rendering-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 13 Feb 2012 22:55:46 +0000 (22:55 +0000)]
Unreviewed, rolling out r107582.
http://trac.webkit.org/changeset/107582
https://bugs.webkit.org/show_bug.cgi?id=78349
Broke three inspector interactive_ui_tests
Source/WebCore:
* English.lproj/localizedStrings.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._removeUISourceCode.get while):
(WebInspector.ScriptsNavigator.prototype._removeUISourceCode):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
LayoutTests:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Removed.
* inspector/debugger/scripts-combobox-file-selector-history.html: Removed.
* inspector/debugger/scripts-file-selector-expected.txt: Removed.
* inspector/debugger/scripts-file-selector.html: Removed.
* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/scripts-sorting-expected.txt:
* inspector/debugger/scripts-sorting.html:
* inspector/debugger/source-frame-count.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 13 Feb 2012 22:39:57 +0000 (22:39 +0000)]
NRWT's HTTP servers should support additional directories for resources
https://bugs.webkit.org/show_bug.cgi?id=78528
Reviewed by Eric Seidel.
This functionality will be used by the Chromium-Android port.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.to.start_http_server):
* Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
(LayoutTestApacheHttpd.__init__):
* Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd.__init__):
(Lighttpd._prepare_config):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Mon, 13 Feb 2012 22:26:29 +0000 (22:26 +0000)]
Source/WebCore: Incorrect children placement in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78160
Reviewed by David Hyatt.
Test: fast/multicol/span/clone-before-after-content-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone): no longer need to take care of making
children noninline (remove fix r105769) since moveChild functions take
care of adding the child properly if type of children differ. this
function just makes sure to set the right value of childrenInline property.
(WebCore::RenderBlock::splitBlocks): similar to moveChild functions below.
(WebCore::RenderBlock::moveChildTo): when child is fullRemoveInsert (across
different parents, e.g clones), we should use addChild function to make sure
it handles the case of different type of children between fromBlock and
toBlock correctly (specifically making children non-inline/wrapping inline
children under anonymous blocks.).
(WebCore::RenderBlock::moveChildrenTo):
* rendering/RenderBlock.h:
(RenderBlock):
(WebCore::RenderBlock::moveAllChildrenTo): Rename to->toBlock.
(WebCore::RenderBlock::moveChildrenTo): Rename to->toBlock.
LayoutTests: Incorrect children placement in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78160
Reviewed by David Hyatt.
* fast/multicol/span/clone-before-after-content-crash-expected.txt: Added.
* fast/multicol/span/clone-before-after-content-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Mon, 13 Feb 2012 22:22:49 +0000 (22:22 +0000)]
Source/WebCore: [chromium] Implement Brightness and Contrast filters on composited
layers. Fix Saturation filter.
https://bugs.webkit.org/show_bug.cgi?id=78527
Reviewed by Kenneth Russell.
Will be covered by existing tests in css3/filters, when enabled.
* platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
(WebCore::CCRenderSurfaceFilters::apply):
LayoutTests: Unskip the css3/filters tests, so we can get some baselines off the
bots.
https://bugs.webkit.org/show_bug.cgi?id=78527
Reviewed by Kenneth Russell.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 13 Feb 2012 22:17:07 +0000 (22:17 +0000)]
Turn off edge antialiasing for tile cache tile layers
https://bugs.webkit.org/show_bug.cgi?id=78533
<rdar://problem/
10710798>
Reviewed by Sam Weinig.
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::createTileLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Mon, 13 Feb 2012 22:15:35 +0000 (22:15 +0000)]
Build fix. Unreviewed.
Source/WebCore:
* WebCore.xcodeproj/project.pbxproj:
Source/WebKit/qt:
* WebCoreSupport/PlatformStrategiesQt.cpp:
(PlatformStrategiesQt::createPasteboardStrategy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Mon, 13 Feb 2012 22:12:44 +0000 (22:12 +0000)]
<rdar://problem/7196487> and https://bugs.webkit.org/show_bug.cgi?id=26777 Add https pages to the page cache in some cases
Reviewed by Anders Carlsson.
Source/WebCore:
Test: http/tests/navigation/https-in-page-cache.html
* history/PageCache.cpp:
(WebCore::PageCache::canCachePageContainingThisFrame): Allow HTTPS pages that do not specify cache-control: no-cache
or cache-control: no-store into the page cache. This will match Firefox's behavior for HTTPS in their bfcache.
LayoutTests:
* http/tests/navigation/https-in-page-cache.html: Added.
* http/tests/navigation/https-in-page-cache-expected.txt: Added.
* http/tests/navigation/resources/https-in-page-cache-1.php: Added.
* http/tests/navigation/resources/https-in-page-cache-2.php: Added.
* http/tests/navigation/resources/https-in-page-cache-3.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Mon, 13 Feb 2012 22:04:29 +0000 (22:04 +0000)]
Source/WebCore: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
https://bugs.webkit.org/show_bug.cgi?id=78282
This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
interface but this one more step in the direction of removing access to NSPasteboard from
the WebProcess.
As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.
Reviewed by Anders Carlsson.
No new tests. No change in behavior, just code refactoring.
* WebCore.exp.in: Added exported class PlatformPasteboard.
* WebCore.xcodeproj/project.pbxproj: Added new files to the build.
* editing/mac/EditorMac.mm:
(WebCore::Editor::writeSelectionToPasteboard): New method signature that doesn't use OBJ-C types.
* platform/Pasteboard.h:
* platform/PasteboardStrategy.h: Added PasteboardStrategy abstract class.
* platform/PlatformPasteboard.h: Added. This class implements access to NSPasteboard.
* platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::pasteboardStrategy): Added.
* platform/mac/DragDataMac.mm:
(WebCore::DragData::canSmartReplace):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::asURL):
* platform/mac/PasteboardMac.mm:
(WebCore::selectionPasteboardTypes): Changed to use Vector<String> instead of NSArray.
(WebCore::writableTypesForURL): Ditto.
(WebCore::createWritableTypesForImage): Ditto.
(WebCore::writableTypesForImage): Ditto.
(WebCore::Pasteboard::Pasteboard): Removed access to NSPasteboard.
(WebCore::Pasteboard::clear): Modified to use platformStrategies()->pasteboardStrategy().
(WebCore::Pasteboard::writeSelectionForTypes): Ditto.
(WebCore::Pasteboard::writePlainText): Ditto.
(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::writeURLForTypes): Ditto.
(WebCore::Pasteboard::writeURL): Ditto.
(WebCore::writeFileWrapperAsRTFDAttachment): Ditto.
(WebCore::Pasteboard::writeImage): Ditto.
(WebCore::Pasteboard::writeClipboard): Ditto.
(WebCore::Pasteboard::canSmartReplace): Ditto.
(WebCore::Pasteboard::plainText): Ditto.
(WebCore::documentFragmentWithRTF): Ditto.
(WebCore::Pasteboard::documentFragment): Ditto.
* platform/mac/PlatformPasteboardMac.mm: Added.
(WebCore::PlatformPasteboard::PlatformPasteboard):
(WebCore::PlatformPasteboard::getTypes):
(WebCore::PlatformPasteboard::bufferForType):
(WebCore::PlatformPasteboard::getPathnamesForType):
(WebCore::PlatformPasteboard::stringForType):
(WebCore::PlatformPasteboard::copy):
(WebCore::PlatformPasteboard::setTypes):
(WebCore::PlatformPasteboard::setBufferForType):
(WebCore::PlatformPasteboard::setPathnamesForType):
(WebCore::PlatformPasteboard::setStringForType):
Source/WebKit/mac: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
https://bugs.webkit.org/show_bug.cgi?id=78282
This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
interface but this one more step in the direction of removing access to NSPasteboard from
the WebProcess.
As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.
Reviewed by Anders Carlsson.
* WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
* WebCoreSupport/WebPlatformStrategies.mm: Added implementation of PasteboardStrategy interface.
(WebPlatformStrategies::createPasteboardStrategy):
(WebPlatformStrategies::getTypes):
(WebPlatformStrategies::bufferForType):
(WebPlatformStrategies::getPathnamesForType):
(WebPlatformStrategies::stringForType):
(WebPlatformStrategies::copy):
(WebPlatformStrategies::setTypes):
(WebPlatformStrategies::setBufferForType):
(WebPlatformStrategies::setPathnamesForType):
(WebPlatformStrategies::setStringForType):
Source/WebKit/qt: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
https://bugs.webkit.org/show_bug.cgi?id=78282
Build fix. Unreviewed.
* WebCoreSupport/PlatformStrategiesQt.cpp:
(WebPlatformStrategies::createPasteboardStrategy):
* WebCoreSupport/PlatformStrategiesQt.h:
(PlatformStrategiesQt):
Source/WebKit2: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
https://bugs.webkit.org/show_bug.cgi?id=78282
This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
interface but this one more step in the direction of removing access to NSPasteboard from
the WebProcess.
As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.
Reviewed by Anders Carlsson.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added implementation of PasteboardStrategy
interface.
(WebKit::WebPlatformStrategies::createPasteboardStrategy):
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::getPathnamesForType):
(WebKit::WebPlatformStrategies::stringForType):
(WebKit::WebPlatformStrategies::copy):
(WebKit::WebPlatformStrategies::setTypes):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::setPathnamesForType):
(WebKit::WebPlatformStrategies::setStringForType):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 22:02:26 +0000 (22:02 +0000)]
[CSS Regions] Inconsistent text selection behavior in regions
https://bugs.webkit.org/show_bug.cgi?id=76456
Patch by Raul Hudea <rhudea@adobe.com> on 2012-02-13
Reviewed by David Hyatt.
Source/WebCore:
Use the proper bounding rect when doing hit testing on flow threads.
Based on initial patch by Alexandru Chiculita.
Test: fast/regions/hit-test-region.html
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::hitTestRegion):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::nodeAtPoint):
LayoutTests:
* fast/regions/hit-test-region-expected.txt: Added.
* fast/regions/hit-test-region.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Mon, 13 Feb 2012 21:59:17 +0000 (21:59 +0000)]
[Windows] Add API to enable inverted color drawing on a WebView
https://bugs.webkit.org/show_bug.cgi?id=77382
Reviewed by Adam Roben.
Source/WebCore:
Implement CACFLayerTreeHost::setShouldInvertColors(), which instructs
the layer tree host to render composited content with inverted colors.
Test: platform/win/inverted-colors/non-composited.html
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::setShouldInvertColors):
(WebCore):
* platform/graphics/ca/win/CACFLayerTreeHost.h:
(CACFLayerTreeHost):
* platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Use
SOFT_LINK_OPTIONAL since WKCACFViewSetShouldInvertColors might not
exist in older versions of WebKitQuartzCoreAdditions.
(WebCore::WKCACFViewLayerTreeHost::setShouldInvertColors):
(WebCore):
* platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:
(WKCACFViewLayerTreeHost):
Source/WebKit/win:
Add a new private WebPreference key called "WebKitShouldInvertColors"
and add private cover methods to get and set the preference. When this
preference changes on a WebPreference object, all WebViews listening to
that object will repaint to reflect the new value.
* Interfaces/IWebPreferencesPrivate.idl: Add [setS|s]houldInvertColors()
cover methods for WebKitShouldInvertColorsPreferenceKey.
* WebPreferenceKeysPrivate.h: Add WebKitShouldInvertColorsPreferenceKey.
* WebPreferences.cpp:
(WebPreferences::shouldInvertColors):
(WebPreferences::setShouldInvertColors):
* WebPreferences.h:
(WebPreferences):
* WebView.cpp:
(WebView::setShouldInvertColors): If m_shouldInvertColors changes,
update the value on the WebView and in m_layerTreeHost, then repaint
the view.
(WebView::notifyPreferencesChanged):
(WebView::setAcceleratedCompositing): When creating a new layer tree
host, tell it whether it should be inverting colors.
* WebView.h:
LayoutTests:
Add a test for non-composited inverted drawing. Testing the composited
path is blocked on <https://bugs.webkit.org/show_bug.cgi?id=78439>.
* platform/win-wk2/platform/win/inverted-colors/non-composited-expected.png: Added.
* platform/win-wk2/platform/win/inverted-colors/non-composited-expected.txt: Added.
* platform/win/inverted-colors/non-composited-expected.png: Added.
* platform/win/inverted-colors/non-composited-expected.txt: Added.
* platform/win/inverted-colors/non-composited.html: Added.
* platform/win/inverted-colors/resources/gradient.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 13 Feb 2012 21:55:13 +0000 (21:55 +0000)]
[chromium] Unreviewed gardening. Marking some debug tests as failing.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 13 Feb 2012 21:45:51 +0000 (21:45 +0000)]
The scrolling tree needs to know about the back forward state of the page
https://bugs.webkit.org/show_bug.cgi?id=78523
<rdar://problem/
10756548>
Reviewed by Sam Weinig.
Source/WebCore:
In order to know if a page should rubber-band in the horizontal direction, the scrolling tree
needs to know about the back/forward state of the page.
* WebCore.exp.in:
Export new symbols.
* WebCore.xcodeproj/project.pbxproj:
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
Initialize m_canGoBack and m_canGoForward.
(WebCore::ScrollingTree::updateBackForwardState):
Update m_canGoBack and m_canGoForward.
* page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::canGoBack):
(WebCore::ScrollingTree::canGoForward):
Add getters.
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::shouldRubberBandInDirection):
Implement this, using canGoBack and canGoForward.
Source/WebKit2:
Pass the back/forward state in the WheelEvent message. This is pretty hacky but works well.
* Platform/CoreIPC/HandleMessage.h:
(CoreIPC):
(CoreIPC::callMemberFunction):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::didReceiveEvent):
* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
* WebProcess/WebPage/EventDispatcher.h:
(EventDispatcher):
* WebProcess/WebPage/EventDispatcher.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Mon, 13 Feb 2012 21:34:10 +0000 (21:34 +0000)]
chromium gpu draws scrollbars slightly differently in debug vs. release modes on
https://bugs.webkit.org/show_bug.cgi?id=58587
Unreviewed rebaseline (the scrollbar issue the bug is about was fixed previously).
* platform/chromium-linux/media/video-controls-rendering-expected.png:
* platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
* platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png: Added.
* platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/video-controls-rendering-expected.txt.
* platform/chromium-mac/media/video-controls-rendering-expected.png: Removed.
* platform/chromium-win/media/video-controls-rendering-expected.png:
* platform/chromium/test_expectations.txt:
* platform/mac-future/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/mac/media/video-controls-rendering-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 13 Feb 2012 21:24:15 +0000 (21:24 +0000)]
WebKit2 build emits a warning about not stripping code-signed PluginProcess.app when copying it into the framework
https://bugs.webkit.org/show_bug.cgi?id=78451
Reviewed by Sam Weinig.
* Configurations/Base.xcconfig: Set COPY_PHASE_STRIP to NO.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Mon, 13 Feb 2012 21:17:59 +0000 (21:17 +0000)]
Rebaseline media layouttests following keyframe addition to test.ogv
https://bugs.webkit.org/show_bug.cgi?id=78367
Unreviewed chromium rebaselining.
* platform/chromium-gpu-mac/media/controls-after-reload-expected.png:
* platform/chromium-gpu-mac/media/controls-after-reload-expected.txt: Added.
* platform/chromium-gpu-mac/media/controls-strict-expected.png:
* platform/chromium-gpu-mac/media/controls-styling-expected.png:
* platform/chromium-gpu-mac/media/controls-without-preload-expected.png:
* platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png:
* platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
* platform/chromium-gpu-mac/media/video-layer-crash-expected.png:
* platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png:
* platform/chromium-gpu-mac/media/video-playing-and-pause-expected.txt: Added.
* platform/chromium-gpu-mac/media/video-transformed-expected.png:
* platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
* platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
* platform/chromium-gpu-mac/media/video-zoom-expected.png:
* platform/chromium-gpu-win/media/controls-after-reload-expected.png:
* platform/chromium-gpu-win/media/controls-strict-expected.png:
* platform/chromium-gpu-win/media/controls-strict-expected.txt: Copied from LayoutTests/platform/chromium/media/controls-strict-expected.txt.
* platform/chromium-gpu-win/media/controls-styling-expected.png:
* platform/chromium-gpu-win/media/controls-styling-expected.txt: Copied from LayoutTests/platform/chromium/media/controls-styling-expected.txt.
* platform/chromium-gpu-win/media/controls-without-preload-expected.png:
* platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Copied from LayoutTests/platform/chromium/media/controls-without-preload-expected.txt.
* platform/chromium-gpu-win/media/video-aspect-ratio-expected.png:
* platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
* platform/chromium-gpu-win/media/video-display-toggle-expected.png:
* platform/chromium-gpu-win/media/video-layer-crash-expected.png:
* platform/chromium-gpu-win/media/video-playing-and-pause-expected.png:
* platform/chromium-gpu-win/media/video-transformed-expected.png:
* platform/chromium-gpu-win/media/video-volume-slider-expected.png:
* platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
* platform/chromium-gpu-win/media/video-zoom-expected.png:
* platform/chromium-linux-x86/media/video-display-toggle-expected.png: Added.
* platform/chromium-linux/media/controls-after-reload-expected.png:
* platform/chromium-linux/media/controls-strict-expected.png:
* platform/chromium-linux/media/controls-styling-expected.png:
* platform/chromium-linux/media/controls-without-preload-expected.png:
* platform/chromium-linux/media/video-aspect-ratio-expected.png:
* platform/chromium-linux/media/video-display-toggle-expected.png:
* platform/chromium-linux/media/video-layer-crash-expected.png:
* platform/chromium-linux/media/video-playing-and-pause-expected.png:
* platform/chromium-linux/media/video-transformed-expected.png:
* platform/chromium-linux/media/video-volume-slider-expected.png:
* platform/chromium-linux/media/video-zoom-controls-expected.png:
* platform/chromium-linux/media/video-zoom-expected.png:
* platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
* platform/chromium-mac-leopard/media/controls-strict-expected.png:
* platform/chromium-mac-leopard/media/controls-styling-expected.png:
* platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
* platform/chromium-mac-leopard/media/video-aspect-ratio-expected.png:
* platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
* platform/chromium-mac-leopard/media/video-layer-crash-expected.png:
* platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png:
* platform/chromium-mac-leopard/media/video-transformed-expected.png:
* platform/chromium-mac-leopard/media/video-volume-slider-expected.png:
* platform/chromium-mac-leopard/media/video-zoom-expected.png:
* platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
* platform/chromium-mac-snowleopard/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-after-reload-expected.txt.
* platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
* platform/chromium-mac-snowleopard/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-strict-expected.txt.
* platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
* platform/chromium-mac-snowleopard/media/controls-styling-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-styling-expected.txt.
* platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
* platform/chromium-mac-snowleopard/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-without-preload-expected.txt.
* platform/chromium-mac-snowleopard/media/video-aspect-ratio-expected.png: Added.
* platform/chromium-mac-snowleopard/media/video-canvas-alpha-expected.png: Added.
* platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
* platform/chromium-mac-snowleopard/media/video-layer-crash-expected.png:
* platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
* platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.txt: Renamed from LayoutTests/platform/chromium/media/video-playing-and-pause-expected.txt.
* platform/chromium-mac-snowleopard/media/video-transformed-expected.png:
* platform/chromium-mac-snowleopard/media/video-volume-slider-expected.png:
* platform/chromium-mac-snowleopard/media/video-volume-slider-expected.txt: Renamed from LayoutTests/platform/chromium/media/video-volume-slider-expected.txt.
* platform/chromium-mac-snowleopard/media/video-zoom-controls-expected.png:
* platform/chromium-mac-snowleopard/media/video-zoom-controls-expected.txt: Renamed from LayoutTests/platform/chromium/media/video-zoom-controls-expected.txt.
* platform/chromium-mac-snowleopard/media/video-zoom-expected.png: Added.
* platform/chromium-mac/media/video-aspect-ratio-expected.png: Removed.
* platform/chromium-mac/media/video-canvas-alpha-expected.png: Removed.
* platform/chromium-mac/media/video-zoom-expected.png: Removed.
* platform/chromium-win/media/controls-after-reload-expected.png:
* platform/chromium-win/media/controls-strict-expected.png:
* platform/chromium-win/media/controls-styling-expected.png:
* platform/chromium-win/media/controls-without-preload-expected.png:
* platform/chromium-win/media/video-aspect-ratio-expected.png:
* platform/chromium-win/media/video-canvas-alpha-expected.png:
* platform/chromium-win/media/video-display-toggle-expected.png:
* platform/chromium-win/media/video-layer-crash-expected.png:
* platform/chromium-win/media/video-playing-and-pause-expected.png:
* platform/chromium-win/media/video-transformed-expected.png:
* platform/chromium-win/media/video-volume-slider-expected.png:
* platform/chromium-win/media/video-zoom-controls-expected.png:
* platform/chromium-win/media/video-zoom-expected.png:
* platform/chromium/test_expectations.txt:
* platform/mac-future/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/mac/media/controls-strict-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Mon, 13 Feb 2012 21:07:08 +0000 (21:07 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=78520 Cleanup PageCache::canCachePageContainingThisFrame readability
Reviewed by Anders Carlsson.
No new tests. (Code cleanup, no change in behavior)
* history/PageCache.cpp:
(WebCore::PageCache::canCachePageContainingThisFrame): Store three commonly
getter-accessed variables in local variables for readability.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 13 Feb 2012 20:57:46 +0000 (20:57 +0000)]
Move JSC related assertions out of Assertions.h and into their own header
https://bugs.webkit.org/show_bug.cgi?id=78508
Reviewed by Gavin Barraclough.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
Add GCAssertions.h
* heap/GCAssertions.h: Added.
Move assertions here.
* runtime/WriteBarrier.h:
Add #include of GCAssertions.h
* wtf/Assertions.h:
Remove JSC related assertions.
* wtf/Compiler.h:
Add compiler check for __has_trivial_destructor.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 20:31:43 +0000 (20:31 +0000)]
Update MIPS patchOffsetGetByIdSlowCaseCall
https://bugs.webkit.org/show_bug.cgi?id=78392
Patch by Chao-ying Fu <fu@mips.com> on 2012-02-13
Reviewed by Gavin Barraclough.
* jit/JIT.h:
(JIT):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Mon, 13 Feb 2012 20:14:58 +0000 (20:14 +0000)]
Don't include a separator before the "Inspect Element" context menu item when the context menu is empty.
https://webkit.org/b/78312
Reviewed by Brian Weinstein.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::addInspectElementItem): Check itemCount before appending the separator.
* platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::itemCount): Added. Implement so this builds on GTK.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 13 Feb 2012 19:54:31 +0000 (19:54 +0000)]
[WIN] Define HWND_MESSAGE if not done already
https://bugs.webkit.org/show_bug.cgi?id=78341
Reviewed by Adam Roben.
HWND_MESSAGE is not defined on WinCE.
Set it to 0 when not defined to avoid #ifdefs.
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::Pasteboard):
* platform/win/WindowsExtras.h:
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Mon, 13 Feb 2012 19:39:31 +0000 (19:39 +0000)]
Add fischman as committer.
Unreviewed
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 13 Feb 2012 19:32:17 +0000 (19:32 +0000)]
Yet another perf-o-matic build fix. It turns out that a task of the same name can't be
queued for days after the first task is completed. So don't use it. Updating persistent
caches more often than necessary is better than never updating them.
* Websites/webkit-perf.appspot.com/controller.py:
(schedule_manifest_update):
(schedule_dashboard_update):
(schedule_runs_update):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 13 Feb 2012 19:30:52 +0000 (19:30 +0000)]
AX: <mark> element should be exposed through attributes
https://bugs.webkit.org/show_bug.cgi?id=75727
Reviewed by Beth Dakin.
Source/WebCore:
Exposes an attribute indicating that an element has highlighting through attributedStringForRange.
Also allows the search mechanism to find elements with this style.
Test: platform/mac/accessibility/attributed-string-includes-highlighting.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::AccessibilityObject::hasHighlighting):
* accessibility/AccessibilityObject.h:
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(createAccessibilitySearchKeyMap):
(AXAttributeStringSetStyle):
LayoutTests:
* platform/mac/accessibility/attributed-string-includes-highlighting-expected.txt: Added.
* platform/mac/accessibility/attributed-string-includes-highlighting.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 13 Feb 2012 19:23:52 +0000 (19:23 +0000)]
AX: the web area should report that focus can be set to itself
https://bugs.webkit.org/show_bug.cgi?id=78272
Reviewed by Beth Dakin.
Source/WebCore:
Test: platform/mac/accessibility/webarea-can-set-focus.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable):
Fixed erroneous comment.
LayoutTests:
* platform/mac/accessibility/webarea-can-set-focus-expected.txt: Added.
* platform/mac/accessibility/webarea-can-set-focus.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 13 Feb 2012 19:05:27 +0000 (19:05 +0000)]
Remove obsolete #if from ThreadSpecific.h
https://bugs.webkit.org/show_bug.cgi?id=78485
Reviewed by Adam Roben.
Since alle platform use either pthread or Win32 for threading,
we can remove all PLATFORM() preprocessor statements.
* wtf/ThreadSpecific.h:
(ThreadSpecific):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 13 Feb 2012 18:08:49 +0000 (18:08 +0000)]
Port RunLoop to WinCE
https://bugs.webkit.org/show_bug.cgi?id=76781
Reviewed by Adam Roben.
* platform/win/RunLoopWin.cpp:
(WebCore::RunLoop::registerRunLoopMessageWindowClass):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 13 Feb 2012 18:06:41 +0000 (18:06 +0000)]
[chromium] Unreviewed, update mac-snowleopard result. This matches
the Apple Mac (Lion) result except for minor antialias differences.
* platform/chromium-mac-snowleopard/svg/custom/foreignObject-crash-on-hover-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Mon, 13 Feb 2012 17:51:24 +0000 (17:51 +0000)]
Fix the Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Mon, 13 Feb 2012 17:50:16 +0000 (17:50 +0000)]
Web Inspector: Make ScriptsNavigator default file selector.
https://bugs.webkit.org/show_bug.cgi?id=78349
Reviewed by Pavel Feldman.
Source/WebCore:
Moved ScriptsNavigator out of experiments.
Introduced new setting "useScriptsNavigator" with true as default value.
Updated scripts panel tests related to file selector.
Tests: inspector/debugger/scripts-combobox-file-selector-history.html
inspector/debugger/scripts-file-selector.html
* English.lproj/localizedStrings.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._removeUISourceCode):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
LayoutTests:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
(initialize_DebuggerTest.):
* inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Added.
* inspector/debugger/scripts-combobox-file-selector-history.html: Added.
* inspector/debugger/scripts-file-selector-expected.txt: Copied from LayoutTests/inspector/debugger/scripts-panel-expected.txt.
* inspector/debugger/scripts-file-selector.html: Added.
* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/scripts-sorting-expected.txt:
* inspector/debugger/scripts-sorting.html:
* inspector/debugger/source-frame-count.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 13 Feb 2012 17:47:25 +0000 (17:47 +0000)]
Use C11's _Static_assert for COMPILE_ASSERT if it is available
https://bugs.webkit.org/show_bug.cgi?id=78506
Rubber-stamped by Antti Koivisto.
Use C11's _Static_assert for COMPILE_ASSERT if it is available to give slightly
better error messages.
* wtf/Assertions.h:
Use _Static_assert if it is available.
* wtf/Compiler.h:
Add COMPILER_SUPPORTS support for _Static_assert when using the LLVM Compiler.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 13 Feb 2012 17:44:20 +0000 (17:44 +0000)]
Make HTMLTableCaptionElement inherit from HTMLElement.
<http://webkit.org/b/78505>
Reviewed by Antti Koivisto.
HTMLTableCaptionElement was already bypassing its base class (HTMLTablePartElement)
and calling up to HTMLElement in all its overrides. Just make it an HTMLElement
instead since it doesn't use anything from HTMLTablePartElement.
Remove parseAttribute() overload since it's no longer needed.
* html/HTMLTableCaptionElement.cpp:
(WebCore::HTMLTableCaptionElement::HTMLTableCaptionElement):
(WebCore::HTMLTableCaptionElement::isPresentationAttribute):
(WebCore::HTMLTableCaptionElement::collectStyleForAttribute):
* html/HTMLTableCaptionElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 13 Feb 2012 17:37:48 +0000 (17:37 +0000)]
HTMLMarqueeElement: Don't cache presence of truespeed attribute.
<http://webkit.org/b/78483>
Reviewed by Antti Koivisto.
Out-of-line minimumDelay() and look up the "truespeed" attribute there instead
of caching the minimum delay in parseAttribute().
Remove HTMLMarqueeElement::parseAttribute() as it's no longer needed.
* html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
(WebCore::HTMLMarqueeElement::minimumDelay):
* html/HTMLMarqueeElement.h:
(HTMLMarqueeElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 13 Feb 2012 17:21:06 +0000 (17:21 +0000)]
[Qt] Unreviewed gardening, skip a new failing test.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 13 Feb 2012 17:18:38 +0000 (17:18 +0000)]
Windows build fix.
* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Mon, 13 Feb 2012 17:11:57 +0000 (17:11 +0000)]
Web Inspector: [refactoring] factor common timeline UI state into TimelinePresentationModel
https://bugs.webkit.org/show_bug.cgi?id=78501
Reviewed by Pavel Feldman.
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
(WebInspector.TimelineOverviewPane.prototype.scrollWindow):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._createTopPane):
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._createTimelineCategoryStatusBarCheckbox):
(WebInspector.TimelinePanel.prototype._onCategoryCheckboxClicked):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype._updateBoundaries):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.get categories):
(WebInspector.TimelinePresentationModel.prototype.addCategory):
(WebInspector.TimelinePresentationModel.prototype.setWindowPosition):
(WebInspector.TimelinePresentationModel.prototype.setCategoryVisibility):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 16:39:34 +0000 (16:39 +0000)]
Use requestAnimationFrame callbacks to pump CSS animations
https://bugs.webkit.org/show_bug.cgi?id=64591
Patch by Joel Webber <jgw@google.com> on 2012-02-13
Reviewed by James Robinson.
No new tests needed (covered by tests in animations/*).
* page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations):
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::updateAnimationTimer):
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):
(WebCore::AnimationControllerPrivate::animationFrameCallbackFired):
(WebCore::AnimationController::updateAnimations):
(WebCore::AnimationController::serviceAnimations):
* page/animation/AnimationController.h:
* page/animation/AnimationControllerPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 13 Feb 2012 16:29:46 +0000 (16:29 +0000)]
Add WindowsExtras.h
https://bugs.webkit.org/show_bug.cgi?id=78340
Reviewed by Adam Roben.
Add a new file to share common code for Win32/WinCE differences.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::PopupMenuWndProc):
* platform/win/RunLoopWin.cpp:
(WebCore::RunLoop::RunLoopWndProc):
* platform/win/WindowsExtras.h: Added.
(WebCore):
(WebCore::getWindowPointer):
(WebCore::setWindowPointer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 13 Feb 2012 15:54:24 +0000 (15:54 +0000)]
Don't mark element for style recalc when modifying its attribute style.
<http://webkit.org/b/78497>
Reviewed by Antti Koivisto.
StylePropertySet::setNeedsStyleRecalc() shouldn't do anything for attribute styles.
Their invalidation is handled exclusively by StyledElement::attributeChanged().
Elements with presentation attributes were being marked for style recalc twice,
once when the attribute changed, and again during attribute style update, below the
call to collectStyleForAttribute().
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::setNeedsStyleRecalc):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 13 Feb 2012 15:10:26 +0000 (15:10 +0000)]
Unreviewed, add new chromium baselines for font-face-multiple-faces.html.
* platform/chromium-mac-snowleopard/fast/css/font-face-multiple-faces-expected.png:
* platform/chromium-win/fast/css/font-face-multiple-faces-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 15:05:17 +0000 (15:05 +0000)]
Manage ShareableBitmap object lifecycle properly, when QImage is created
using the shared data.
https://bugs.webkit.org/show_bug.cgi?id=77546
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-02-13
Reviewed by Simon Hausmann.
* Shared/ShareableBitmap.h:
(ShareableBitmap):
* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::createQImage):
(WebKit):
(WebKit::ShareableBitmap::releaseSharedMemoryData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Mon, 13 Feb 2012 15:02:44 +0000 (15:02 +0000)]
Move attribute storage from NamedNodeMap to ElementAttributeData
https://bugs.webkit.org/show_bug.cgi?id=77674
Reviewed by Andreas Kling.
Move m_attributes vector from NamedNodeMap to ElementAttributeData. Make the
remaining callsites interact with ElementAttributeData if possible. The parsing
code is still interacting with NamedNodeMap, so some functions remained as
wrappers there. A next change will it use ElementAttributeData instead.
The code for DOM exported functions remained in NamedNodeMap. This implementation
should move to Element in a next change, too.
* dom/Attr.h:
(Attr):
* dom/Element.cpp:
(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributeMap):
(WebCore::Element::removeAttribute):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::normalizeAttributes):
* dom/Element.h:
(Element):
(WebCore::Element::ensureUpdatedAttributes):
(WebCore::Element::ensureAttributeData):
(WebCore):
(WebCore::Element::updatedAttributeData):
(WebCore::Element::ensureUpdatedAttributeData):
These *AttributeData functions are the correct correct way for callers to touch
the details of attribute storage. The "updated" variants will update invalid
attributes before return.
(WebCore::Element::setAttributesFromElement):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::~ElementAttributeData):
(WebCore):
(WebCore::ElementAttributeData::ensureInlineStyleDecl):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::detachAttributesFromElement):
(WebCore::ElementAttributeData::copyAttributesToVector):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::setAttributes): Make use of the assumption that
this will only be called with a valid Element, since the only call site is an
Element method.
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute): Make use of the assumption
this will only be called with a valid Element, since the only call site return
early if there's no Element.
* dom/ElementAttributeData.h:
(ElementAttributeData):
(WebCore::ElementAttributeData::length):
(WebCore::ElementAttributeData::isEmpty):
(WebCore::ElementAttributeData::attributeItem):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::item):
(WebCore::NamedNodeMap::detachFromElement):
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::length):
(WebCore::NamedNodeMap::isEmpty):
(WebCore::NamedNodeMap::attributeItem):
(WebCore::NamedNodeMap::getAttributeItem):
(WebCore::NamedNodeMap::getAttributeItemIndex):
(WebCore::NamedNodeMap::shrinkToLength):
(WebCore::NamedNodeMap::reserveInitialCapacity):
(WebCore::NamedNodeMap::addAttribute):
(WebCore::NamedNodeMap::removeAttribute):
(NamedNodeMap):
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateAttributeStyle):
* dom/StyledElement.h:
(WebCore::StyledElement::ensureInlineStyleDecl):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
* svg/properties/SVGAnimatedPropertySynchronizer.h:
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 14:50:58 +0000 (14:50 +0000)]
Web Inspector: wrong percent calculations for empty snapshot.
https://bugs.webkit.org/show_bug.cgi?id=78329
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-13
Reviewed by Yury Semikhatsky.
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 14:33:29 +0000 (14:33 +0000)]
Web Inspector: add class filter to heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=78362
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-13
Reviewed by Yury Semikhatsky.
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.insertChild):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._nameFilterChanged):
(WebInspector.DetailedHeapshotView.prototype._changeNameFilter):
* inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view .constructors-view-grid):
(.detailed-heapshot-view .constructors-view-toolbar):
(.detailed-heapshot-view .constructors-view-toolbar input.constructors-view-filter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Mon, 13 Feb 2012 14:27:51 +0000 (14:27 +0000)]
Web Inspector: In Inspector.json PropertyDescriptor.writable should be declared optional
https://bugs.webkit.org/show_bug.cgi?id=77917
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-13
Reviewed by Pavel Feldman.
Source/WebCore:
Property descriptor is fixed in Inspector.json. Also retroactively in
0.1 and 1.0.
Injected script in instructed to never return null property values.
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector-0.1.json:
* inspector/Inspector-1.0.json:
* inspector/Inspector.json:
LayoutTests:
"Undefined" getter and setter is now visible.
* inspector/runtime/runtime-getProperties-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Mon, 13 Feb 2012 14:18:13 +0000 (14:18 +0000)]
[GTK] Add GSList to the list of GObject types in GOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=78487
Reviewed by Philippe Normand.
Source/JavaScriptCore:
Handle the GSList type in GOwnPtr, by calling g_slist_free in the
implementation of the freeOwnedGPtr template function.
* wtf/gobject/GOwnPtr.cpp:
(WTF::GSList):
(WTF):
* wtf/gobject/GOwnPtr.h:
(WTF):
* wtf/gobject/GTypedefs.h:
Source/WebKit/gtk:
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::runOpenPanel): Use GOwnPtr<GSList> for the
list of filenames returned by gtk_file_chooser_get_filenames().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 14:16:32 +0000 (14:16 +0000)]
[GTK] Revise configuration for MHTML
https://bugs.webkit.org/show_bug.cgi?id=78364
Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-02-13
Reviewed by Gustavo Noronha Silva.
.:
Added some lines to show checking messages, whether mhtml is enabled or not
during configuration and the configuration result for mhtml.
MHTML is a web page archive format used to combine resources
that are typically represented by external links (such as images, Flash animations,
Java applets, audio files) together with HTML code into a single file.
http://en.wikipedia.org/wiki/MHTML
* configure.ac:
Source/WebCore:
Added mhtml directory and removed target files duplicated to build when enabling mhtml.
Archive.cpp, ArchiveFactory.cpp & their headers are included at the above line.
This duplication has caused build-break if mhtml is enabled.
No new tests, since no new features.
* GNUmakefile.am:
* GNUmakefile.list.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 13 Feb 2012 13:59:13 +0000 (13:59 +0000)]
[Qt] Unreviewed gardening.
* platform/qt/test_expectations.txt: Mark fast/js/dfg-inline-function-dot-caller.html as slow in debug mode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 13 Feb 2012 13:42:56 +0000 (13:42 +0000)]
2012-02-13 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, add "IMAGE" to two svg/carto.net tests expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kubo@profusion.mobi [Mon, 13 Feb 2012 13:30:42 +0000 (13:30 +0000)]
[EFL] Drop support for the Curl network backend.
https://bugs.webkit.org/show_bug.cgi?id=77874
Reviewed by Eric Seidel.
Nobody seems to be maintaining the Curl backend in WebCore, the
EFL port developers all seem to be using the Soup backend and the
port itself has many features which are only implemented for the
latter.
.:
* Source/cmake/OptionsEfl.cmake: Remove network backend selection
checks and unconditionally require Glib and Libsoup, bump the
required LibSoup version to the same one the GTK+ port looks for,
since we share the same network backend.
Source/JavaScriptCore:
* wtf/PlatformEfl.cmake: Always build the gobject-dependent source
files.
Source/WebCore:
No new tests, just some dependency plumbing.
* PlatformEfl.cmake: Build the glib/soup source files
unconditionally.
* platform/efl/FileSystemEfl.cpp: Remove ENABLE(GLIB_SUPPORT) check.
Source/WebKit/efl:
* CMakeListsEfl.txt: Unconditionally build soup-dependent files
and always add the glib/soup include directories and libraries.
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
Remove USE(SOUP) checks.
* ewk/ewk_auth.cpp:
(ewk_auth_show_dialog_callback_set): Ditto.
(ewk_auth_credentials_set): Ditto.
* ewk/ewk_cookies.cpp:
(ewk_cookies_file_set): Ditto.
(ewk_cookies_clear): Ditto.
(ewk_cookies_get_all): Ditto.
(ewk_cookies_cookie_del): Ditto.
(ewk_cookies_cookie_free): Ditto.
(ewk_cookies_policy_set): Ditto.
(ewk_cookies_policy_get): Ditto.
* ewk/ewk_frame.cpp:
(ewk_frame_certificate_status_get): Ditto.
* ewk/ewk_main.cpp:
(_ewk_init_body): Ditto.
* ewk/ewk_network.cpp:
(ewk_network_proxy_uri_set): Ditto.
(ewk_network_proxy_uri_get): Ditto.
(ewk_network_tls_certificate_check_get): Ditto.
(ewk_network_tls_certificate_check_set): Ditto.
(ewk_network_tls_ca_certificates_path_get): Ditto.
(ewk_network_tls_ca_certificates_path_set): Ditto.
(ewk_network_default_soup_session_get): Ditto.
* ewk/ewk_network.h: Update apidox for
ewk_network_default_soup_session_get() now that libsoup is the
only available backend.
Source/WebKit2:
* PlatformEfl.cmake: Unconditionally build the glib/soup source
files and unconditionally add the required include directories and
libraries.
* WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl): Remove USE(SOUP) check.
Tools:
* DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
and always add the required include directories.
* EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
include directories and link to them.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 13 Feb 2012 13:12:15 +0000 (13:12 +0000)]
Web Inspector: wrap settings selector text and adding a rule with undoable actions.
https://bugs.webkit.org/show_bug.cgi?id=78482
Reviewed by Yury Semikhatsky.
Source/WebCore:
Tests: inspector/styles/undo-add-new-rule.html
inspector/styles/undo-set-selector-text.html
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::StyleSheetAction::StyleSheetAction):
(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::mergeId):
(WebCore::InspectorCSSAgent::TogglePropertyAction::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(InspectorCSSAgent::SetRuleSelectorAction):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::SetRuleSelectorAction):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::perform):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::undo):
(WebCore):
(InspectorCSSAgent::AddRuleAction):
(WebCore::InspectorCSSAgent::AddRuleAction::AddRuleAction):
(WebCore::InspectorCSSAgent::AddRuleAction::perform):
(WebCore::InspectorCSSAgent::AddRuleAction::undo):
(WebCore::InspectorCSSAgent::AddRuleAction::newRuleId):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::styleSheetChanged):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ruleSelector):
(WebCore):
(WebCore::InspectorStyleSheet::setRuleSelector):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::deleteRule):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::toggleProperty):
(WebCore::InspectorStyleSheet::fireStyleSheetChanged):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
* inspector/InspectorStyleSheet.h:
(InspectorStyleSheet):
(WebCore::InspectorStyleSheet::styleId):
(InspectorStyleSheetForInlineStyle):
LayoutTests:
* inspector/styles/undo-add-new-rule-expected.txt: Added.
* inspector/styles/undo-add-new-rule.html: Added.
* inspector/styles/undo-set-selector-text-expected.txt: Added.
* inspector/styles/undo-set-selector-text.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 13 Feb 2012 12:45:51 +0000 (12:45 +0000)]
[Qt] Unreviewed gardening, unskip now passing tests.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Mon, 13 Feb 2012 12:45:15 +0000 (12:45 +0000)]
[WebSocket] Update pywebsocket to 0.7.1
https://bugs.webkit.org/show_bug.cgi?id=78484
pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
Reviewed by Kent Tamura.
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook._install_pywebsocket):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 13 Feb 2012 12:15:24 +0000 (12:15 +0000)]
Rename names defined in ContentInclutionSelector to more intuitive names.
https://bugs.webkit.org/show_bug.cgi?id=78333
Reviewed by Hajime Morita.
This is just refactoring, renaming non-intuitive names to more intuitive names
so that they match the terms in the spec.
No tests. No change in behavior.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
* dom/NodeRenderingContext.h:
(NodeRenderingContext):
(WebCore::NodeRenderingContext::insertionPoint):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::insertionPointFor):
(WebCore::ShadowRoot::isSelectorActive):
(WebCore::ShadowRoot::attach):
(WebCore::ShadowRoot::selector):
(WebCore::ShadowRoot::ensureSelector):
* dom/ShadowRoot.h:
(WebCore):
(ShadowRoot):
* html/shadow/ContentInclusionSelector.h: Removed.
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
* html/shadow/HTMLContentElement.h:
(WebCore):
(WebCore::HTMLContentElement::selections):
(WebCore::HTMLContentElement::hasSelection):
(HTMLContentElement):
* html/shadow/HTMLContentSelector.cpp: Renamed from Source/WebCore/html/shadow/ContentInclusionSelector.cpp.
(WebCore):
(WebCore::HTMLContentSeleciton::append):
(WebCore::HTMLContentSeleciton::unlink):
(WebCore::HTMLContentSelectionList::HTMLContentSelectionList):
(WebCore::HTMLContentSelectionList::~HTMLContentSelectionList):
(WebCore::HTMLContentSelectionList::find):
(WebCore::HTMLContentSelectionList::clear):
(WebCore::HTMLContentSelectionList::append):
(WebCore::HTMLContentSelector::HTMLContentSelector):
(WebCore::HTMLContentSelector::~HTMLContentSelector):
(WebCore::HTMLContentSelector::select):
(WebCore::HTMLContentSelector::unselect):
(WebCore::HTMLContentSelector::findFor):
(WebCore::HTMLContentSelector::didSelect):
(WebCore::HTMLContentSelector::willSelectOver):
* html/shadow/HTMLContentSelector.h: Added.
(WebCore):
(HTMLContentSeleciton):
(WebCore::HTMLContentSeleciton::insertionPoint):
(WebCore::HTMLContentSeleciton::node):
(WebCore::HTMLContentSeleciton::next):
(WebCore::HTMLContentSeleciton::previous):
(WebCore::HTMLContentSeleciton::HTMLContentSeleciton):
(WebCore::HTMLContentSeleciton::create):
(HTMLContentSelectionList):
(WebCore::HTMLContentSelectionList::first):
(WebCore::HTMLContentSelectionList::last):
(WebCore::HTMLContentSelectionList::isEmpty):
(HTMLContentSelectionSet):
(WebCore::HTMLContentSelectionSet::add):
(WebCore::HTMLContentSelectionSet::remove):
(WebCore::HTMLContentSelectionSet::isEmpty):
(Translator):
(WebCore::HTMLContentSelectionSet::Translator::hash):
(WebCore::HTMLContentSelectionSet::Translator::equal):
(WebCore::HTMLContentSelectionSet::Hash::hash):
(WebCore::HTMLContentSelectionSet::Hash::equal):
(Hash):
(WebCore::HTMLContentSelectionSet::find):
(HTMLContentSelector):
(WebCore::HTMLContentSelector::hasCandidates):
* testing/Internals.cpp:
(WebCore::Internals::includerFor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Mon, 13 Feb 2012 11:57:00 +0000 (11:57 +0000)]
[Texmap] morphing-cubes animation appears too close when clicking the button
https://bugs.webkit.org/show_bug.cgi?id=78476
Fixed bug in TextureMapperAnimation that made transform animations that go to/from identity
to not work.
Reviewed by Simon Hausmann.
No behavior changes.
* platform/graphics/texmap/TextureMapperAnimation.cpp:
(WebCore::applyTransformAnimation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 11:01:16 +0000 (11:01 +0000)]
[Forms] Use enum instead of bool for HTMLInputElement::setValue
https://bugs.webkit.org/show_bug.cgi?id=75217
Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-02-13
Reviewed by Kent Tamura.
Source/WebCore:
Use TextFieldEventBehavior enum instead of sendChangeEvent bool
parameter for HTMLInputElement::setValue method. This new enum
parameter will be extended to dispatch input and change events
when user agent populates input field as specified in
"Common events behavior" of HTML5 standard.
This patch is required for fixing bug 75067 "[Forms] Spin buttons
of number input type should fire both input and change event."
No new tests. Existing tests cover this patch.
* html/BaseButtonInputType.cpp:
(WebCore::BaseButtonInputType::setValue):
* html/BaseButtonInputType.h:
* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::setValue):
* html/BaseCheckableInputType.h:
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::setValueAsNumber):
* html/BaseDateAndTimeInputType.h:
* html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::willDispatchClick):
* html/ColorInputType.cpp:
(WebCore::ColorInputType::setValue):
* html/ColorInputType.h:
* html/FileInputType.cpp:
(WebCore::FileInputType::setValue):
* html/FileInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::applyStep):
(WebCore::HTMLInputElement::stepUp):
(WebCore::HTMLInputElement::stepDown):
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::setValueForUser):
(WebCore::HTMLInputElement::setValue):
(WebCore::HTMLInputElement::setValueInternal):
(WebCore::HTMLInputElement::setValueAsNumber):
(WebCore::HTMLInputElement::stepUpFromRenderer):
* html/HTMLInputElement.h:
* html/HTMLTextFormControlElement.h:
* html/HiddenInputType.cpp:
(WebCore::HiddenInputType::setValue):
* html/HiddenInputType.h:
* html/InputType.cpp:
(WebCore::InputType::setValueAsNumber):
(WebCore::InputType::setValue):
* html/InputType.h:
* html/NumberInputType.cpp:
(WebCore::NumberInputType::setValueAsNumber):
* html/NumberInputType.h:
* html/RadioInputType.cpp:
(WebCore::RadioInputType::willDispatchClick):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::setValueAsNumber):
(WebCore::RangeInputType::handleKeydownEvent):
(WebCore::RangeInputType::setValue):
* html/RangeInputType.h:
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::setValue):
* html/TextFieldInputType.h:
Source/WebKit/chromium:
* src/WebInputElement.cpp:
(WebKit::WebInputElement::setValue): Use enum for HTMLInputElement::setValue
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 13 Feb 2012 10:36:55 +0000 (10:36 +0000)]
Move attribute style invalidation to attributeChanged().
<http://webkit.org/b/78461>
Reviewed by Antti Koivisto.
Moved attribute style invalidation out of the parseAttribute() overloads
and added an "isPresentationAttribute(Attribute*) virtual to StyledElement.
Returning true for a given Attribute will cause attribute style invalidation
when that attribute passes through attributeChanged().
Removed a couple of parseAttribute() overloads whose only remaining purpose
was invalidating attribute style.
For form elements that deliberately don't map the "align" attribute, added
short-circuits in isPresentationAttribute instead of falling back to the
respective base class (which may othweise then map "align")
* dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
* dom/StyledElement.h:
(WebCore::StyledElement::isPresentationAttribute):
* html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::isPresentationAttribute):
* html/HTMLBRElement.h:
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::isPresentationAttribute):
(WebCore::HTMLBodyElement::collectStyleForAttribute):
(WebCore::HTMLBodyElement::parseAttribute):
* html/HTMLBodyElement.h:
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::isPresentationAttribute):
(WebCore::HTMLButtonElement::parseAttribute):
* html/HTMLButtonElement.h:
* html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::isPresentationAttribute):
* html/HTMLDivElement.h:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::isPresentationAttribute):
(WebCore::HTMLElement::parseAttribute):
* html/HTMLElement.h:
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::isPresentationAttribute):
(WebCore::HTMLEmbedElement::parseAttribute):
* html/HTMLEmbedElement.h:
* html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::isPresentationAttribute):
* html/HTMLFontElement.h:
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::isPresentationAttribute):
(WebCore::HTMLFrameSetElement::parseAttribute):
* html/HTMLFrameSetElement.h:
* html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::isPresentationAttribute):
(WebCore::HTMLHRElement::collectStyleForAttribute):
* html/HTMLHRElement.h:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::isPresentationAttribute):
(WebCore::HTMLIFrameElement::collectStyleForAttribute):
(WebCore::HTMLIFrameElement::parseAttribute):
* html/HTMLIFrameElement.h:
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::isPresentationAttribute):
(WebCore::HTMLImageElement::collectStyleForAttribute):
(WebCore::HTMLImageElement::parseAttribute):
* html/HTMLImageElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isPresentationAttribute):
(WebCore::HTMLInputElement::collectStyleForAttribute):
(WebCore::HTMLInputElement::parseAttribute):
* html/HTMLInputElement.h:
* html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::isPresentationAttribute):
(WebCore::HTMLLIElement::parseAttribute):
* html/HTMLLIElement.h:
* html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::isPresentationAttribute):
(WebCore::HTMLMarqueeElement::collectStyleForAttribute):
(WebCore::HTMLMarqueeElement::parseAttribute):
* html/HTMLMarqueeElement.h:
* html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::isPresentationAttribute):
(WebCore::HTMLOListElement::parseAttribute):
* html/HTMLOListElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::isPresentationAttribute):
(WebCore::HTMLObjectElement::parseAttribute):
* html/HTMLObjectElement.h:
* html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::isPresentationAttribute):
* html/HTMLParagraphElement.h:
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::isPresentationAttribute):
(WebCore::HTMLPlugInElement::collectStyleForAttribute):
* html/HTMLPlugInElement.h:
* html/HTMLPreElement.cpp:
(WebCore::HTMLPreElement::isPresentationAttribute):
(WebCore::HTMLPreElement::collectStyleForAttribute):
* html/HTMLPreElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::isPresentationAttribute):
(WebCore::HTMLSelectElement::parseAttribute):
* html/HTMLSelectElement.h:
* html/HTMLTableCaptionElement.cpp:
(WebCore::HTMLTableCaptionElement::isPresentationAttribute):
(WebCore::HTMLTableCaptionElement::parseAttribute):
* html/HTMLTableCaptionElement.h:
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::isPresentationAttribute):
(WebCore::HTMLTableCellElement::collectStyleForAttribute):
(WebCore::HTMLTableCellElement::parseAttribute):
* html/HTMLTableCellElement.h:
* html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::isPresentationAttribute):
(WebCore::HTMLTableColElement::parseAttribute):
* html/HTMLTableColElement.h:
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::isPresentationAttribute):
(WebCore::HTMLTableElement::parseAttribute):
* html/HTMLTableElement.h:
* html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::isPresentationAttribute):
(WebCore::HTMLTablePartElement::collectStyleForAttribute):
* html/HTMLTablePartElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::isPresentationAttribute):
(WebCore::HTMLTextAreaElement::parseAttribute):
* html/HTMLTextAreaElement.h:
* html/HTMLUListElement.cpp:
(WebCore::HTMLUListElement::isPresentationAttribute):
(WebCore::HTMLUListElement::collectStyleForAttribute):
* html/HTMLUListElement.h:
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::isPresentationAttribute):
(WebCore::HTMLVideoElement::parseAttribute):
* html/HTMLVideoElement.h:
* mathml/MathMLElement.cpp:
(WebCore::MathMLElement::isPresentationAttribute):
(WebCore::MathMLElement::collectStyleForAttribute):
* mathml/MathMLElement.h:
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::isPresentationAttribute):
(WebCore::SVGImageElement::parseAttribute):
* svg/SVGImageElement.h:
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::isPresentationAttribute):
(WebCore::SVGStyledElement::parseAttribute):
* svg/SVGStyledElement.h:
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::isPresentationAttribute):
(WebCore::SVGTextContentElement::parseAttribute):
* svg/SVGTextContentElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 13 Feb 2012 10:24:21 +0000 (10:24 +0000)]
Add [JSCustomToJSObject] IDL attribute to interfaces that have
custom toJS() but do not have custom toV8()
https://bugs.webkit.org/show_bug.cgi?id=78466
Reviewed by Adam Barth.
This is the second step to remove hard-coding in HasCustomToV8Implementation()
in CodeGeneratorV8.pm. This patch replaces [JSCustomToJS] with [JSCustomToJSObject]
for interfaces which have custom toJS() but do not have custom toV8().
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(HasCustomToV8Implementation): I found that AbstractWorker and CanvasRenderingContext
are the only IDL files to which I need to add [JSCustomToJSObject].
Other IDL files which had been listed here do not have [JSCustomToJS].
* html/canvas/CanvasRenderingContext.idl:
* workers/AbstractWorker.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 13 Feb 2012 10:23:24 +0000 (10:23 +0000)]
Unreviewed gardening after r107544.
* fast/dom/wrapper-classes-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 13 Feb 2012 10:09:49 +0000 (10:09 +0000)]
Avoid unnecessary work when evaluating style sharing candidates.
<http://webkit.org/b/78220>
Reviewed by Antti Koivisto.
Do the cheap checks (bitfields, pointers) before calling virtuals and doing hash lookups.
Remove comparison of attributes that are reflected in the attribute styles (cellpadding.)
Moved comparison of "type" and "readonly" attributes into the more specific
canShareStyleWithControl() since they are only relevant for input elements. Don't bother
calling isFormControlElement() on both elements as they already have the same tagQName().
Altogether this knocks off ~8ms worth of samples per cycle of the "Moz" page cycler test.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::isCommonAttributeSelectorAttribute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 13 Feb 2012 10:08:57 +0000 (10:08 +0000)]
2012-02-13 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, mark dfg-put-by-id-prototype-check.html as failing in chromium (new test).
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 13 Feb 2012 10:08:11 +0000 (10:08 +0000)]
Unreviewed. Build fix for !ENABLE(JIT) after r107485.
* bytecode/PolymorphicPutByIdList.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 09:47:40 +0000 (09:47 +0000)]
<summary> is not keyboard accessible.
https://bugs.webkit.org/show_bug.cgi?id=75478
Patch by Arko Saha <arko@motorola.com> on 2012-02-13
Reviewed by Hajime Morita.
Source/WebCore:
Toggle the content of <details> element on pressing Enter or Spacebar
key on a focused <summary> element.
Test: fast/html/details-keyboard-show-hide.html
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::supportsFocus):
(WebCore):
(WebCore::HTMLSummaryElement::defaultEventHandler):
* html/HTMLSummaryElement.h:
(HTMLSummaryElement):
LayoutTests:
* fast/html/details-keyboard-show-hide-expected.txt: Added.
* fast/html/details-keyboard-show-hide.html: Added.
* platform/chromium/test_expectations.txt: <summary> is now focusable and clicking
it draws a focus ring. So we need to rebase failed test cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 13 Feb 2012 09:37:22 +0000 (09:37 +0000)]
[Qt] REGRESSION(r107518): It broke many tests
https://bugs.webkit.org/show_bug.cgi?id=78471
* platform/qt/Skipped: Unreviewed gardening, skip failing tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 13 Feb 2012 09:31:49 +0000 (09:31 +0000)]
2012-02-13 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, add new baseline for font-face-default-font.html on linux.
* platform/chromium-linux/fast/css/font-face-default-font-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Mon, 13 Feb 2012 09:30:45 +0000 (09:30 +0000)]
Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Preparation for a bunch of rebaselines.
* platform/chromium/test_expectations.txt: unskip tests to allow bots to cycle and
produce the new JPEG image results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Mon, 13 Feb 2012 09:28:44 +0000 (09:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=78434
Unreviewed - temporarily reverting r107498 will I fix a couple of testcases.
Source/JavaScriptCore:
* parser/Parser.cpp:
(JSC::::parseFunctionInfo):
* runtime/ClassInfo.h:
(MethodTable):
(JSC):
* runtime/JSCell.cpp:
(JSC):
* runtime/JSCell.h:
(JSCell):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC):
* runtime/JSGlobalObjectFunctions.h:
(JSC):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSValue::get):
* runtime/JSString.cpp:
(JSC::JSString::getOwnPropertySlot):
* runtime/JSValue.h:
(JSValue):
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetPrototypeOf):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
* runtime/Structure.h:
(JSC::Structure::setHasGetterSetterProperties):
(Structure):
Source/WebCore:
* bindings/js/JSDOMWindowBase.cpp:
(WebCore):
* bindings/js/JSDOMWindowBase.h:
(JSDOMWindowBase):
LayoutTests:
* fast/js/Object-getOwnPropertyNames-expected.txt:
* fast/js/cyclic-prototypes-expected.txt:
* fast/js/parser-syntax-check-expected.txt:
* fast/js/preventExtensions-expected.txt:
* fast/js/prototypes-expected.txt:
* fast/js/script-tests/Object-getOwnPropertyNames.js:
* fast/js/script-tests/cyclic-prototypes.js:
* fast/js/script-tests/parser-syntax-check.js:
* fast/js/script-tests/preventExtensions.js:
* fast/js/script-tests/prototypes.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 13 Feb 2012 09:01:29 +0000 (09:01 +0000)]
2012-02-13 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, remove missing test from expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Mon, 13 Feb 2012 08:53:26 +0000 (08:53 +0000)]
Web Inspector: get rid of cycles in containment view of an object.
https://bugs.webkit.org/show_bug.cgi?id=78462
Reviewed by Yury Semikhatsky.
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 13 Feb 2012 08:18:38 +0000 (08:18 +0000)]
Remove ENABLE(MEDIA_STREAM) from Navigator.h
https://bugs.webkit.org/show_bug.cgi?id=78467
Reviewed by Kentaro Hara.
Navigator.webkitGetUser media doesn't really have anything to do with
Navigator.cpp. This patch moves it into the mediastream directory and
removes the ENABLE(MEDIA_STREAM) ifdefs in Navigator.h and
Navigator.cpp.
* GNUmakefile.list.am:
* WebCore.gypi:
* mediastream/NavigatorMediaStream.cpp: Added.
(WebCore):
(WebCore::NavigatorMediaStream::NavigatorMediaStream):
(WebCore::NavigatorMediaStream::~NavigatorMediaStream):
(WebCore::NavigatorMediaStream::webkitGetUserMedia):
* mediastream/NavigatorMediaStream.h: Added.
(WebCore):
(NavigatorMediaStream):
* mediastream/NavigatorMediaStream.idl: Added.
* page/Navigator.cpp:
(WebCore):
* page/Navigator.h:
(WebCore):
(Navigator):
* page/Navigator.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 13 Feb 2012 08:17:59 +0000 (08:17 +0000)]
This test is testing the argument handling behavior of this API. Now
that we autogenerate this code, we now throw consistent exceptions with
the rest of the platform. There shouldn't be a compat issue here
because this API hasn't shipped in production releases yet.
* fast/dom/MediaStream/argument-types-expected.txt:
* fast/dom/MediaStream/script-tests/argument-types.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 08:10:08 +0000 (08:10 +0000)]
[EFL][DRT] Add new expected layout results come from bug 78091.
https://bugs.webkit.org/show_bug.cgi?id=78188
Patch by Kangil Han <kangil.han@samsung.com> on 2012-02-13
Reviewed by Ryosuke Niwa.
Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
This patch will activate around 1,900 test cases from skipped list in EFL port.
* platform/efl/Skipped:
* platform/efl/svg/css/composite-shadow-example-expected.txt: Added.
* platform/efl/svg/css/composite-shadow-text-expected.txt: Added.
* platform/efl/svg/css/composite-shadow-with-opacity-expected.txt: Added.
* platform/efl/svg/css/css-box-min-width-expected.txt: Added.
* platform/efl/svg/css/group-with-shadow-expected.txt: Added.
* platform/efl/svg/css/mask-with-shadow-expected.txt: Added.
* platform/efl/svg/css/path-gradient-stroke-shadow-expected.txt: Added.
* platform/efl/svg/css/path-with-shadow-expected.txt: Added.
* platform/efl/svg/css/shadow-and-opacity-expected.txt: Added.
* platform/efl/svg/css/shadow-changes-expected.txt: Added.
* platform/efl/svg/css/shadow-with-large-radius-expected.txt: Added.
* platform/efl/svg/css/shadow-with-negative-offset-expected.txt: Added.
* platform/efl/svg/css/stars-with-shadow-expected.txt: Added.
* platform/efl/svg/css/text-gradient-shadow-expected.txt: Added.
* platform/efl/svg/css/text-shadow-multiple-expected.txt: Added.
* platform/efl/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
* platform/efl/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
* platform/efl/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Added.
* platform/efl/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt: Added.
* platform/efl/svg/foreignObject/svg-document-as-direct-child-expected.txt: Added.
* platform/efl/svg/foreignObject/svg-document-in-html-document-expected.txt: Added.
* platform/efl/svg/hixie/cascade/001-broken-expected.txt: Added.
* platform/efl/svg/hixie/cascade/002-expected.txt: Added.
* platform/efl/svg/hixie/data-types/001-expected.txt: Added.
* platform/efl/svg/hixie/data-types/002-expected.txt: Added.
* platform/efl/svg/hixie/dynamic/002-expected.txt: Added.
* platform/efl/svg/hixie/dynamic/003-expected.txt: Added.
* platform/efl/svg/hixie/dynamic/004-expected.txt: Added.
* platform/efl/svg/hixie/dynamic/005-expected.txt: Added.
* platform/efl/svg/hixie/dynamic/006-expected.txt: Added.
* platform/efl/svg/hixie/error/001-expected.txt: Added.
* platform/efl/svg/hixie/error/002-expected.txt: Added.
* platform/efl/svg/hixie/error/003-expected.txt: Added.
* platform/efl/svg/hixie/error/006-expected.txt: Added.
* platform/efl/svg/hixie/error/007-expected.txt: Added.
* platform/efl/svg/hixie/error/008-expected.txt: Added.
* platform/efl/svg/hixie/error/009-expected.txt: Added.
* platform/efl/svg/hixie/error/010-expected.txt: Added.
* platform/efl/svg/hixie/error/011-expected.txt: Added.
* platform/efl/svg/hixie/error/012-expected.txt: Added.
* platform/efl/svg/hixie/error/013-expected.txt: Added.
* platform/efl/svg/hixie/error/014-expected.txt: Added.
* platform/efl/svg/hixie/error/014-test-expected.txt: Added.
* platform/efl/svg/hixie/error/015-expected.txt: Added.
* platform/efl/svg/hixie/error/016-expected.txt: Added.
* platform/efl/svg/hixie/error/017-expected.txt: Added.
* platform/efl/svg/hixie/intrinsic/001-expected.txt: Added.
* platform/efl/svg/hixie/intrinsic/002-expected.txt: Added.
* platform/efl/svg/hixie/intrinsic/003-expected.txt: Added.
* platform/efl/svg/hixie/links/002-expected.txt: Added.
* platform/efl/svg/hixie/mixed/003-expected.txt: Added.
* platform/efl/svg/hixie/mixed/004-expected.txt: Added.
* platform/efl/svg/hixie/mixed/005-expected.txt: Added.
* platform/efl/svg/hixie/mixed/006-expected.txt: Added.
* platform/efl/svg/hixie/mixed/007-expected.txt: Added.
* platform/efl/svg/hixie/mixed/008-expected.txt: Added.
* platform/efl/svg/hixie/mixed/009-expected.txt: Added.
* platform/efl/svg/hixie/mixed/010-expected.txt: Added.
* platform/efl/svg/hixie/mixed/011-expected.txt: Added.
* platform/efl/svg/hixie/painting/001-expected.txt: Added.
* platform/efl/svg/hixie/perf/001-expected.txt: Added.
* platform/efl/svg/hixie/perf/002-expected.txt: Added.
* platform/efl/svg/hixie/perf/003-expected.txt: Added.
* platform/efl/svg/hixie/perf/004-expected.txt: Added.
* platform/efl/svg/hixie/perf/005-expected.txt: Added.
* platform/efl/svg/hixie/perf/006-expected.txt: Added.
* platform/efl/svg/hixie/perf/007-expected.txt: Added.
* platform/efl/svg/hixie/processing-model/003-expected.txt: Added.
* platform/efl/svg/hixie/processing-model/004-expected.txt: Added.
* platform/efl/svg/hixie/processing-model/005-expected.txt: Added.
* platform/efl/svg/hixie/rendering-model/001-expected.txt: Added.
* platform/efl/svg/hixie/rendering-model/002-expected.txt: Added.
* platform/efl/svg/hixie/rendering-model/003-expected.txt: Added.
* platform/efl/svg/hixie/rendering-model/003a-expected.txt: Added.
* platform/efl/svg/hixie/rendering-model/004-expected.txt: Added.
* platform/efl/svg/hixie/shapes/path/001-expected.txt: Added.
* platform/efl/svg/hixie/text/001-expected.txt: Added.
* platform/efl/svg/hixie/text/002-expected.txt: Added.
* platform/efl/svg/hixie/text/003-expected.txt: Added.
* platform/efl/svg/hixie/text/003a-expected.txt: Added.
* platform/efl/svg/hixie/text/003b-expected.txt: Added.
* platform/efl/svg/hixie/transform/001-expected.txt: Added.
* platform/efl/svg/hixie/use/001-expected.txt: Added.
* platform/efl/svg/hixie/use/002-expected.txt: Added.
* platform/efl/svg/hixie/use/002-test-expected.txt: Added.
* platform/efl/svg/hixie/viewbox/001-expected.txt: Added.
* platform/efl/svg/hixie/viewbox/004-expected.txt: Added.
* platform/efl/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Added.
* platform/efl/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Added.
* platform/efl/svg/in-html/by-reference-expected.txt: Added.
* platform/efl/svg/in-html/circle-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-foreignObject-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-inner-svg-element-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Added.
* platform/efl/svg/repaint/filter-child-repaint-expected.txt: Added.
* platform/efl/svg/repaint/filter-repaint-expected.txt: Added.
* platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
* platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
* platform/efl/svg/transforms/animated-path-inside-transformed-html-expected.txt: Added.
* platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
* platform/efl/svg/transforms/svg-css-transforms-expected.txt: Added.
* platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
* platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Added.
* platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Added.
* platform/efl/svg/wicd/rightsizing-grid-expected.txt: Added.
* platform/efl/svg/wicd/sizing-flakiness-expected.txt: Added.
* platform/efl/svg/wicd/test-rightsizing-a-expected.txt: Added.
* platform/efl/svg/wicd/test-rightsizing-b-expected.txt: Added.
* platform/efl/svg/wicd/test-scalable-background-image1-expected.txt: Added.
* platform/efl/svg/wicd/test-scalable-background-image2-expected.txt: Added.
* platform/efl/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
* platform/efl/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-background-images-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
* platform/efl/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
* platform/efl/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
* platform/efl/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
* platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
* platform/efl/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
* platform/efl/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
* platform/efl/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
* platform/efl/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
* platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 13 Feb 2012 07:59:22 +0000 (07:59 +0000)]
Unreviewed, skipping 2 tests failing because of bug 78434.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 13 Feb 2012 07:30:15 +0000 (07:30 +0000)]
Navigator.webkitGetUserMedia doesn't need to be custom
https://bugs.webkit.org/show_bug.cgi?id=78464
Reviewed by Eric Seidel.
The code generator has gotten smarter since this function was added.
* GNUmakefile.list.am:
* UseV8.cmake:
* WebCore.gypi:
* bindings/js/JSNavigatorCustom.cpp: Removed.
* bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
* page/Navigator.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 13 Feb 2012 07:03:16 +0000 (07:03 +0000)]
Move ENABLE(GAMEPAD) logic out of Navigator.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=78457
Reviewed by Hajime Morita.
This patch moves GAMEPAD-specific logic out of Navigator by introducing
the concept of a NavigatorSupplement, analogous to the recently
introduced PageSupplement.
* Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::from):
(WebCore):
(WebCore::NavigatorGamepad::webkitGamepads):
(WebCore::NavigatorGamepad::gamepads):
* Modules/gamepad/NavigatorGamepad.h:
(NavigatorGamepad):
* WebCore.gypi:
* dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::supplementName):
* page/Navigator.cpp:
(WebCore::Navigator::provideSupplement):
(WebCore):
(WebCore::Navigator::requireSupplement):
* page/Navigator.h:
(Navigator):
* page/Page.h:
(Page):
* page/PageSupplement.h:
- This patch cleans up some nits in PageSupplement.
(WebCore):
(PageSupplement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 13 Feb 2012 07:00:02 +0000 (07:00 +0000)]
Another perf-o-matic build fix.
* Websites/webkit-perf.appspot.com/report_process_handler.py:
(ReportProcessHandler._create_build_if_possible):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Mon, 13 Feb 2012 06:47:45 +0000 (06:47 +0000)]
Unreviewed test expectations update after r107516.
* platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/font-face-multiple-faces-expected.png:
* platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/font-face-multiple-faces-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/css/font-face-multiple-faces-expected.png.
* platform/chromium-mac/fast/css/font-face-default-font-expected.png: Removed.
* platform/chromium-win/fast/css/font-face-default-font-expected.png:
* platform/chromium-win/fast/css/font-face-default-font-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107534
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Mon, 13 Feb 2012 06:41:12 +0000 (06:41 +0000)]
Remove fast/css/font-face-descriptor-multiple-values.html
https://bugs.webkit.org/show_bug.cgi?id=78456
The test is no longer needed because WebKit now follow the current
draft(*1) and doesn't accept multiple font-weight descriptors.
(*1) http://dev.w3.org/csswg/css3-fonts/#descdef-font-weight
Reviewed by Hajime Morita.
* fast/css/font-face-descriptor-multiple-values.html: Removed.
* fast/css/resources/font-face-descriptor-multiple-values-parsing.js: Removed.
* platform/chromium-linux/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
* platform/chromium-mac-leopard/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
* platform/chromium-mac/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
* platform/chromium-mac/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt: Removed.
* platform/chromium-win/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
* platform/chromium-win/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
* platform/chromium-win/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt: Removed.
* platform/efl/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
* platform/efl/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
* platform/gtk/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
* platform/gtk/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
* platform/mac-leopard/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
* platform/mac/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
* platform/mac/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
* platform/qt/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
* platform/qt/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 13 Feb 2012 06:20:18 +0000 (06:20 +0000)]
Perf-o-matic build fix.
* Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107532
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 13 Feb 2012 05:45:08 +0000 (05:45 +0000)]
REGRESSION: Perf-o-matic adds duplicated test results
https://bugs.webkit.org/show_bug.cgi?id=78373
Reviewed by Hajime Morita.
Add TestResult inside a transaction. We use high replication databsae but this should prevent
the duplication in the most of the time.
Also fixed random bugs in Controller and ReportHandler.
* Websites/webkit-perf.appspot.com/controller.py:
(get_persistent_cache):
* Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post):
* Websites/webkit-perf.appspot.com/report_process_handler.py:
(ReportProcessHandler.post):
(ReportProcessHandler._add_test_if_needed):
(ReportProcessHandler):
(ReportProcessHandler._add_test_result_if_needed):
(ReportProcessHandler._add_test_result_if_needed._float_or_none):
(ReportProcessHandler._add_test_result_if_needed.execute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 13 Feb 2012 05:35:55 +0000 (05:35 +0000)]
Add a [V8CustomToJSObject] IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=78450
Reviewed by Adam Barth.
This is the first step to remove hard-coding in HasCustomToV8Implementation()
in CodeGeneratorV8.pm. This patch adds [V8CustomToJSObject]
to interfaces which have custom toV8() but do not have custom toJS().
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm: Replaced hard-coding with [V8CustomToJSObject].
(HasCustomToV8Implementation):
* css/CSSStyleSheet.idl: Added [V8CustomToJSObject].
* dom/DOMStringMap.idl:
* dom/Element.idl:
* dom/NamedNodeMap.idl:
* html/DOMTokenList.idl:
* html/HTMLDocument.idl:
* html/HTMLElement.idl:
* html/canvas/CanvasPixelArray.idl:
* inspector/ScriptProfile.idl:
* inspector/ScriptProfileNode.idl:
* page/DOMWindow.idl:
* page/Location.idl:
* svg/SVGDocument.idl:
* svg/SVGElement.idl:
* workers/WorkerContext.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 05:26:45 +0000 (05:26 +0000)]
[EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
https://bugs.webkit.org/show_bug.cgi?id=78091
Patch by Kangil Han <kangil.han@samsung.com> on 2012-02-12
Reviewed by Hajime Morita.
Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
This patch will activate around 1,900 test cases from skipped list in EFL port.
Tools:
* DumpRenderTree/efl/EventSender.cpp:
(textZoom):
(pageZoom):
(textZoomInCallback):
(textZoomOutCallback):
(zoomPageInCallback):
(zoomPageOutCallback):
LayoutTests:
* platform/efl/fast/css/ignore-text-zoom-expected.txt: Added.
* platform/efl/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
* platform/efl/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
* platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
* platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
* platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
* platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
* platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
* platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
* platform/efl/svg/as-background-image/animated-svg-as-background-expected.txt: Added.
* platform/efl/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
* platform/efl/svg/as-background-image/background-image-tiled-expected.txt: Added.
* platform/efl/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
* platform/efl/svg/as-background-image/svg-as-background-2-expected.txt: Added.
* platform/efl/svg/as-background-image/svg-as-background-6-expected.txt: Added.
* platform/efl/svg/as-background-image/svg-as-background-expected.txt: Added.
* platform/efl/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Added.
* platform/efl/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Added.
* platform/efl/svg/as-background-image/svg-as-tiled-background-expected.txt: Added.
* platform/efl/svg/as-background-image/svg-background-partial-redraw-expected.txt: Added.
* platform/efl/svg/as-background-image/svg-width-100p-as-background-expected.txt: Added.
* platform/efl/svg/as-border-image/svg-as-border-image-2-expected.txt: Added.
* platform/efl/svg/as-border-image/svg-as-border-image-expected.txt: Added.
* platform/efl/svg/as-image/animated-svg-as-image-expected.txt: Added.
* platform/efl/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
* platform/efl/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
* platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/efl/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
* platform/efl/svg/as-image/same-image-two-instances-expected.txt: Added.
* platform/efl/svg/as-image/svg-as-image-expected.txt: Added.
* platform/efl/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
* platform/efl/svg/as-image/svg-image-change-content-size-expected.txt: Added.
* platform/efl/svg/batik/filters/feTile-expected.txt: Added.
* platform/efl/svg/batik/filters/filterRegions-expected.txt: Added.
* platform/efl/svg/batik/masking/maskRegions-expected.txt: Added.
* platform/efl/svg/batik/paints/gradientLimit-expected.txt: Added.
* platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Added.
* platform/efl/svg/batik/paints/patternRegionA-expected.txt: Added.
* platform/efl/svg/batik/paints/patternRegions-expected.txt: Added.
* platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
* platform/efl/svg/batik/text/longTextOnPath-expected.txt: Added.
* platform/efl/svg/batik/text/smallFonts-expected.txt: Added.
* platform/efl/svg/batik/text/textAnchor-expected.txt: Added.
* platform/efl/svg/batik/text/textAnchor2-expected.txt: Added.
* platform/efl/svg/batik/text/textAnchor3-expected.txt: Added.
* platform/efl/svg/batik/text/textDecoration-expected.txt: Added.
* platform/efl/svg/batik/text/textDecoration2-expected.txt: Added.
* platform/efl/svg/batik/text/textEffect-expected.txt: Added.
* platform/efl/svg/batik/text/textEffect2-expected.txt: Added.
* platform/efl/svg/batik/text/textEffect3-expected.txt: Added.
* platform/efl/svg/batik/text/textFeatures-expected.txt: Added.
* platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
* platform/efl/svg/batik/text/textLayout-expected.txt: Added.
* platform/efl/svg/batik/text/textLayout2-expected.txt: Added.
* platform/efl/svg/batik/text/textLength-expected.txt: Added.
* platform/efl/svg/batik/text/textOnPath-expected.txt: Added.
* platform/efl/svg/batik/text/textOnPath2-expected.txt: Added.
* platform/efl/svg/batik/text/textOnPath3-expected.txt: Added.
* platform/efl/svg/batik/text/textOnPathSpaces-expected.txt: Added.
* platform/efl/svg/batik/text/textPCDATA-expected.txt: Added.
* platform/efl/svg/batik/text/textPosition-expected.txt: Added.
* platform/efl/svg/batik/text/textPosition2-expected.txt: Added.
* platform/efl/svg/batik/text/textProperties-expected.txt: Added.
* platform/efl/svg/batik/text/textProperties2-expected.txt: Added.
* platform/efl/svg/batik/text/textStyles-expected.txt: Added.
* platform/efl/svg/batik/text/verticalText-expected.txt: Added.
* platform/efl/svg/batik/text/verticalTextOnPath-expected.txt: Added.
* platform/efl/svg/batik/text/xmlSpace-expected.txt: Added.
* platform/efl/svg/carto.net/button-expected.txt: Added.
* platform/efl/svg/carto.net/colourpicker-expected.txt: Added.
* platform/efl/svg/carto.net/combobox-expected.txt: Added.
* platform/efl/svg/carto.net/scrollbar-expected.txt: Added.
* platform/efl/svg/carto.net/selectionlist-expected.txt: Added.
* platform/efl/svg/carto.net/slider-expected.txt: Added.
* platform/efl/svg/carto.net/tabgroup-expected.txt: Added.
* platform/efl/svg/carto.net/textbox-expected.txt: Added.
* platform/efl/svg/carto.net/window-expected.txt: Added.
* platform/efl/svg/clip-path/clip-in-clip-expected.txt: Added.
* platform/efl/svg/clip-path/clip-in-mask-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-child-clipped-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-css-transform-1-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-css-transform-2-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-evenodd-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-nonzero-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-pixelation-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-recursive-call-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-text-and-shape-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-text-and-stroke-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-text-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-transform-1-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-use-as-child2-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-use-as-child3-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-use-as-child4-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-use-as-child5-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-with-container-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.txt: Added.
* platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.txt: Added.
* platform/efl/svg/clip-path/clipper-placement-issue-expected.txt: Added.
* platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Added.
* platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Added.
* platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Added.
* platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Added.
* platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Added.
* platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Added.
* platform/efl/svg/css/arrow-with-shadow-expected.txt: Added.
* platform/efl/svg/css/clippath-with-shadow-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 05:00:29 +0000 (05:00 +0000)]
CSS3 currentColor on outline-color gets treated as inherit
https://bugs.webkit.org/show_bug.cgi?id=73180
Patch by David Barr <davidbarr@chromium.org> on 2012-02-12
Reviewed by Antti Koivisto.
Source/WebCore:
The CSS2 and CSS3 UI modules state that outline-color
is not inherited. Make it so.
http://www.w3.org/TR/CSS2/ui.html#propdef-outline-color
http://www.w3.org/TR/css3-ui/#outline-color
Test: fast/css/outline-currentcolor.html
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
LayoutTests:
Adapted fast/css/background-currentcolor.html dumpRenderTree test
for outline-color.
* fast/css/outline-currentcolor-expected.txt: Added.
* fast/css/outline-currentcolor.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 05:00:25 +0000 (05:00 +0000)]
KeywordLookupGenerator.py script fails in some cases
https://bugs.webkit.org/show_bug.cgi?id=77886
Patch by Ashod Nakashian <ashodnakashian@yahoo.com> on 2012-02-12
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
* parser/Keywords.table: Converted to LF-only.
Tools:
* Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
* Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
(GlobalVariablesTest.test_path_rules_specifier):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Mon, 13 Feb 2012 04:58:11 +0000 (04:58 +0000)]
CSSPageRule should inherit from CSSRule instead of CSSStyleRule
https://bugs.webkit.org/show_bug.cgi?id=78452
Reviewed by Anders Carlsson.
This matches CSSOM and eliminates the only subclass of CSSStyleRule, enabling further refactoring.
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::CSSPageRule):
(WebCore::CSSPageRule::~CSSPageRule):
(WebCore):
(WebCore::CSSPageRule::selectorText):
(WebCore::CSSPageRule::setSelectorText):
(WebCore::CSSPageRule::cssText):
* css/CSSPageRule.h:
(CSSPageRule):
(WebCore::CSSPageRule::style):
(WebCore::CSSPageRule::selector):
(WebCore::CSSPageRule::properties):
(WebCore::CSSPageRule::adoptSelectorVector):
(WebCore::CSSPageRule::setDeclaration):
* css/CSSRule.cpp:
(WebCore::CSSRule::cssText):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::generateSelectorText):
* css/CSSStyleSelector.cpp:
(WebCore::RuleSet::pageRules):
(RuleSet):
(WebCore::RuleSet::addPageRule):
(WebCore::comparePageRules):
(WebCore::CSSStyleSelector::matchPageRules):
(WebCore::CSSStyleSelector::matchPageRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 04:15:49 +0000 (04:15 +0000)]
Introduce ShadowRootList.
https://bugs.webkit.org/show_bug.cgi?id=78069
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-12
Reviewed by Hajime Morita.
Source/JavaScriptCore:
DoublyLinkedList should have tail() method to take the last element.
* wtf/DoublyLinkedList.h:
(DoublyLinkedList):
(WTF::::tail):
(WTF):
Source/WebCore:
This is a step to implement multiple shadow subtrees.
This patch introduces a shadow root list. ShadowRootList is a doubly linked list,
and each shadow root now has a younger shadow root and older shadow root,
which are a previous element and a next element respectively.
Since a visual tree traversal, which will be introduced in coming patches, will need a older shadow root,
we make a shadow root list a doubly linked list.
However, ShadowRootList does not have more than one shadow root now.
This will be changed in a series of coming patches.
Element::shadowRoot(), setShadowRoot(), ensureShadowRoot(), and removeShadowRoot() are
emulated using ShadowRootList for a while. These API will be replaced to ShadowRootList API later.
No new tests, no change in behavior.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/Element.cpp:
(WebCore::Element::hasShadowRoot):
Retruns true if an element has a shadowRoot.
(WebCore::Element::shadowRootList):
Gets shadow root list if any.
(WebCore::Element::shadowRoot):
Gets the first shadow root from the shadow root list.
(WebCore::Element::setShadowRoot):
Sets the first shadow root to the shadow root list.
(WebCore::Element::removeShadowRoot):
Removes all the shadow roots in the shadow root list.
* dom/Element.h:
(WebCore):
(Element):
* dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::ElementRareData):
Has shadow root lists instead of shadow root.
(WebCore::ElementRareData::~ElementRareData):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):
* dom/ShadowRoot.h:
(ShadowRoot):
(WebCore::ShadowRoot::youngerShadowRoot):
(WebCore::ShadowRoot::olderShadowRoot):
* dom/ShadowRootList.cpp: Added.
(WebCore):
(WebCore::ShadowRootList::ShadowRootList):
(WebCore::ShadowRootList::~ShadowRootList):
(WebCore::ShadowRootList::pushShadowRoot):
Adds a shadow root into the list. Currently we limit the list can have only one shadow root.
(WebCore::ShadowRootList::popShadowRoot):
Removes and returns the youngest shadow root if any.
* dom/ShadowRootList.h: Added.
(WebCore):
(ShadowRootList):
(WebCore::ShadowRootList::hasShadowRoot):
(WebCore::ShadowRootList::youngestShadowRoot):
(WebCore::ShadowRootList::oldestShadowRoot):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 03:53:06 +0000 (03:53 +0000)]
INPUT shouldn't create ShadowRoot dynamically.
https://bugs.webkit.org/show_bug.cgi?id=77930
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-12
Reviewed by Dimitri Glazkov.
Source/WebCore:
When input type is changed, ShadowRoot was being re-created. This makes it difficult to
support multiple shadow subtrees. This patch makes input re-use the existing shadow root
instead of re-creating a shaow root. A shadow root should be created when an element is created.
Since media control elements are implemented using input elements, these elements should also
create a shadow root in their construction phase.
Test: fast/dom/shadow/input-shadow-nochange.html
Tests related to media controls should be covered by existing tests.
* html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
* html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::createShadowSubtree):
* html/InputType.cpp:
(WebCore::InputType::destroyShadowSubtree):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
* html/shadow/MediaControlElements.cpp:
Creates a shadow tree in the construction phase.
(WebCore::MediaControlPanelMuteButtonElement::create):
(WebCore::MediaControlVolumeSliderMuteButtonElement::create):
(WebCore::MediaControlPlayButtonElement::create):
(WebCore::MediaControlSeekForwardButtonElement::create):
(WebCore::MediaControlSeekBackButtonElement::create):
(WebCore::MediaControlRewindButtonElement::create):
(WebCore::MediaControlReturnToRealtimeButtonElement::create):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
(WebCore::MediaControlTimelineElement::create):
(WebCore::MediaControlVolumeSliderElement::create):
(WebCore::MediaControlFullscreenVolumeSliderElement::create):
(WebCore::MediaControlFullscreenButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::create):
LayoutTests:
Ensures cheaging input type does not cause shadow root recreation.
* fast/dom/shadow/input-shadow-nochange.html: Added.
* fast/dom/shadow/input-shadow-nochange-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107524
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 03:35:19 +0000 (03:35 +0000)]
SVGTRefElement shouldn't create a shadow root dynamically.
https://bugs.webkit.org/show_bug.cgi?id=77938
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-12
Reviewed by Hajime Morita.
Source/WebCore:
SVGTRefElement creates a shadow root dynamically. This will cause a problem to support
multiple shadow subtrees. So it should be created in a constructor phase.
Test: svg/custom/tref-shadowdom.html
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::create):
(WebCore::SVGTRefElement::createShadowSubtree):
(WebCore):
(WebCore::SVGTRefElement::updateReferencedText):
* svg/SVGTRefElement.h:
(SVGTRefElement):
LayoutTests:
Checks a shadow root exists of tref element in cases xlink:href is set and is not set.
* svg/custom/tref-shadowdom-expected.txt: Added.
* svg/custom/tref-shadowdom.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 03:15:50 +0000 (03:15 +0000)]
Add toText and isTextNode helpers in Text class.
https://bugs.webkit.org/show_bug.cgi?id=78140
Unit test case for the new style checker introduced.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-02-12
Reviewed by Adam Barth.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest):
(CppStyleTest.test_static_cast_readability): Added a unit test case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Mon, 13 Feb 2012 02:15:55 +0000 (02:15 +0000)]
Enable features supported by EFL port in build-webkit.
https://bugs.webkit.org/show_bug.cgi?id=78348
Reviewed by Ryosuke Niwa.
Sync build-webkit with OptionEfl.cmake, as some features enabled in
OptionEfl.cmake are not enabled in build-webkit.
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 13 Feb 2012 02:12:57 +0000 (02:12 +0000)]
Unreviewed. Rebaselined run-bindings-tests results.
* bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore):
(WebCore::JSTestActiveDOMObject::destroy):
(WebCore::JSTestActiveDOMObject::~JSTestActiveDOMObject):
* bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(JSTestActiveDOMObject):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore):
(WebCore::JSTestCustomNamedGetter::destroy):
(WebCore::JSTestCustomNamedGetter::~JSTestCustomNamedGetter):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(JSTestCustomNamedGetter):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore):
(WebCore::JSTestEventConstructor::destroy):
(WebCore::JSTestEventConstructor::~JSTestEventConstructor):
* bindings/scripts/test/JS/JSTestEventConstructor.h:
(JSTestEventConstructor):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore):
(WebCore::JSTestEventTarget::destroy):
(WebCore::JSTestEventTarget::~JSTestEventTarget):
* bindings/scripts/test/JS/JSTestEventTarget.h:
(JSTestEventTarget):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore):
(WebCore::JSTestInterface::destroy):
(WebCore::JSTestInterface::~JSTestInterface):
* bindings/scripts/test/JS/JSTestInterface.h:
(JSTestInterface):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore):
(WebCore::JSTestMediaQueryListListener::destroy):
(WebCore::JSTestMediaQueryListListener::~JSTestMediaQueryListListener):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(JSTestMediaQueryListListener):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore):
(WebCore::JSTestNamedConstructor::destroy):
(WebCore::JSTestNamedConstructor::~JSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestNamedConstructor.h:
(JSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::JSTestObj::destroy):
(WebCore::JSTestObj::~JSTestObj):
* bindings/scripts/test/JS/JSTestObj.h:
(JSTestObj):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::JSTestSerializedScriptValueInterface::destroy):
(WebCore::JSTestSerializedScriptValueInterface::~JSTestSerializedScriptValueInterface):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(JSTestSerializedScriptValueInterface):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Mon, 13 Feb 2012 01:59:59 +0000 (01:59 +0000)]
Regression (r104528): Crash when moving nodes across documents.
https://bugs.webkit.org/show_bug.cgi?id=78432
Reviewed by Hajime Morita.
Source/WebCore:
Test: fast/dom/node-move-to-new-document-crash-main.html
* dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
LayoutTests:
* fast/dom/node-move-to-new-document-crash-main-expected.txt: Added.
* fast/dom/node-move-to-new-document-crash-main.html: Added.
* fast/dom/resources/node-move-to-new-document-crash.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Feb 2012 01:18:28 +0000 (01:18 +0000)]
Page should have less intrusive way to associate API implementation objects.
https://bugs.webkit.org/show_bug.cgi?id=78085
Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-12
Reviewed by Adam Barth.
Source/WebCore:
Introducing PageSupplement interface to attach behind-the-flag-ish
objects to Page instances.
This change aims to improve modularity of Modules/ entries. With
PageSupplement mechinary, we can eliminate ifdef conditionals from
Page.h/Page.cpp and are able to add Modules/ entries without
touching non-Module WebCore files. WebKit API classes like WebPage
can "provide" these objects dynamically during the Page setup phase.
In this change, DeviceMotionController and
DeviceOrientationController is updated to adopt PageSupplement
inteface for an illustrative purpose because they are going to
move into Modules/ shortly. Other Page associated API backing
objects also should be transformed to PageSupplement family.
Reviewed by Adam Barth.
No new tests. No behavior change.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DeviceMotionClient.h:
(WebCore):
* dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::supplementName):
(WebCore):
(WebCore::DeviceMotionController::isActiveAt):
(WebCore::provideDeviceMotionTo):
* dom/DeviceMotionController.h:
(DeviceMotionController):
(WebCore::DeviceMotionController::from):
* dom/DeviceOrientationClient.h:
(WebCore):
* dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::supplementName):
(WebCore):
(WebCore::DeviceOrientationController::isActiveAt):
(WebCore::provideDeviceOrientationTo):
* dom/DeviceOrientationController.h:
(DeviceOrientationController):
(WebCore::DeviceOrientationController::from):
* dom/Document.cpp:
(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):
* history/PageCache.cpp:
(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):
* page/PageSupplement.cpp:
(WebCore::PageSupplement::~PageSupplement):
(WebCore::PageSupplement::provideTo):
(WebCore::PageSupplement::from):
* page/PageSupplement.h:
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::provideSupplement):
(WebCore):
(WebCore::Page::requireSupplement):
(WebCore::Page::notifyDestroyedToSupplements):
(WebCore::Page::PageClients::PageClients):
* page/Page.h:
(WebCore):
(PageClients):
(Page):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
Source/WebKit/chromium:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
Source/WebKit/mac:
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Source/WebKit/qt:
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log