WebKit-https.git
11 years ago2009-04-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 7 Apr 2009 18:28:46 +0000 (18:28 +0000)]
2009-04-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed build fix. Fix non-Mac builds.

        * bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 7 Apr 2009 17:57:11 +0000 (17:57 +0000)]
2009-04-07  Anders Carlsson  <andersca@apple.com>

        Try to fix the Tiger build.

        * Plugins/WebBaseNetscapePluginView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 7 Apr 2009 17:45:00 +0000 (17:45 +0000)]
2009-04-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=25069

        Clean up the accelerated compositing code that determines the format of
        the GraphicsLayer hierarchy, being more explicit about which parts have
        to happen before and after descendant layers have been updated. Also remove
        some unhelpful caching of state.

        * dom/Document.cpp:
        (WebCore::Document::recalcStyle):
        Only call updateCompositingLayers() if we know we're not going to be
        doing a layout soon.

        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::setDrawsContent):
        Toggling drawsContent from false to true should do a setNeedsDisplay().

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::styleChanged):
        updateLayerCompositingState() no longer updates the layer geometry, so
        do that here if we're not going to rebuild layers anyway.
        Also, updateLayerCompositingState() no longer does a setContentsNeedDisplay,
        so do that if the style change indicates that a repaint is required.

        * rendering/RenderLayerBacking.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::RenderLayerBacking):
        (WebCore::RenderLayerBacking::updateAfterLayout):
        The 'drawing optimizations' logic has been rolled into updateGraphicsLayerConfiguration()
        and updateGraphicsLayerGeometry().

        (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
        Group that code that decides what GraphicsLayers are needed into this method,
        which deals with clipping layers and 'direct compositing': images that can be
        rendered via the compositor.

        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
        Call setDrawsContent() if updateGraphicsLayerConfiguration() didn't already
        figure it out for image layers.

        (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
        Remove the m_simpleCompositingLayerStatusDirty cache indicator, since we just
        computed it every time anyway.

        * rendering/RenderLayerCompositor.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateLayerCompositingState):
        updateGraphicsLayers() was renamed to updateGraphicsLayerConfiguration(),
        which calls clippedByAncestor() etc. itself rather than having everything passed in.
        Repaints are taken care of by styleChanged() and setDrawsContent().

        (WebCore::RenderLayerCompositor::calculateCompositedBounds):
        !layer->isComposited() && layer->transform() is a synonym for paintsWithTransform().

        (WebCore::RenderLayerCompositor::setCompositingParent):
        No need to call updateGraphicsLayerGeometry() here, because we're going to
        rebuild layers anyway.

        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
        Add comments, and test layerBacking instead of layer->isComposited().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 7 Apr 2009 17:41:40 +0000 (17:41 +0000)]
2009-04-07  Anders Carlsson  <andersca@apple.com>

        Another attempt at fixing the build.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 7 Apr 2009 17:33:30 +0000 (17:33 +0000)]
2009-04-07  Anders Carlsson  <andersca@apple.com>

        Fix build.

        * WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
andersca@apple.com [Tue, 7 Apr 2009 17:22:47 +0000 (17:22 +0000)]
WebCore:

2009-04-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/6667001> NPAPI: need NPN_Get/SetValueForURL() and NPN_GetAuthenticationInfo()

        * WebCore.base.exp:
        Add symbols needed by WebKit.

        * WebCore.xcodeproj/project.pbxproj:
        Make CookieJar a private header.

        * bridge/npapi.h:
        Add function definitions.

        * plugins/npfunctions.h:
        Fix the NPN_SetValueForURLProcPtr signature.

WebKit/mac:

2009-04-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/6667001>
        NPAPI: need NPN_Get/SetValueForURL() and NPN_GetAuthenticationInfo()

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCGetCookies):
        (WKPCGetProxy):
        (WKPCSetCookies):
        (WKPCGetAuthenticationInfo):
        New MIG functions to be used by the plug-in host.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::getCookies):
        (WebKit::NetscapePluginInstanceProxy::setCookies):
        (WebKit::NetscapePluginInstanceProxy::getProxy):
        (WebKit::NetscapePluginInstanceProxy::getAuthenticationInfo):
        Implement these.

        * Plugins/Hosted/WebKitPluginClient.defs:
        Add callbacks.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView URLWithCString:]):
        Factor this out of URLWithCString.

        (-[WebBaseNetscapePluginView requestWithURLCString:]):
        Call URLWithCString.

        (WebKit::proxiesForURL):
        Return a string representation of proxies for a given URL.

        (WebKit::getAuthenticationInfo):
        Get the authentication info for a given host/protocol/scheme/realm/port combination.

        * Plugins/WebNetscapePluginPackage.mm:
        (-[WebNetscapePluginPackage _tryLoad]):
        Initialize the new vtable functions.

        * Plugins/WebNetscapePluginView.h:
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView getVariable:forURL:value:length:]):
        (-[WebNetscapePluginView setVariable:forURL:value:length:]):
        (-[WebNetscapePluginView getAuthenticationInfoWithProtocol:host:port:scheme:realm:username:usernameLength:password:passwordLength:]):
        Implement these.

        * Plugins/npapi.mm:
        (NPN_GetValueForURL):
        (NPN_SetValueForURL):
        (NPN_GetAuthenticationInfo):
        Call the plug-in view functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix <rdar://6520933> REGRESSION (3.2.1-ToT): Scroll bar disappears in WebView...
aroben@apple.com [Tue, 7 Apr 2009 17:13:50 +0000 (17:13 +0000)]
    Fix <rdar://6520933> REGRESSION (3.2.1-ToT): Scroll bar disappears in WebView and Bookmarks view after switching theme or turning on High Contrast mode

        Reviewed by Dave Hyatt.

        * platform/win/ScrollbarThemeWin.cpp:
        (WebCore::ScrollbarThemeWin::themeChanged): Null out scrollbarTheme
        after closing it so that we'll re-open the theme next time we paint.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Small cleanup/correctness fix in ScrollbarThemeWin
aroben@apple.com [Tue, 7 Apr 2009 17:12:33 +0000 (17:12 +0000)]
    Small cleanup/correctness fix in ScrollbarThemeWin

        Reviewed by Dave Hyatt.

        * platform/win/ScrollbarThemeWin.cpp: Removed the now-unused
        haveTheme boolean.
        (WebCore::checkAndInitScrollbarTheme): Check IsThemeActive() before
        calling OpenThemeData. This seems to be what MSDN recommends.
        (WebCore::ScrollbarThemeWin::themeChanged): Null-check scrollbarTheme
        before closing it, rather than indirectly null-checking it via
        checking haveTheme.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Tue, 7 Apr 2009 17:08:18 +0000 (17:08 +0000)]
WebCore:

        Reviewed by John Sullivan.

        - when -webkit-line-break: after-white-space is specified but the text
          does not auto-wrap, do not shrink the trailing space to fit in the
          available width

        Test: fast/text/whitespace/nowrap-line-break-after-white-space.html

        - when shrinking such trailing space, do not shrink below zero

        Covered by existing tests

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::computeHorizontalPositionsForLine):
        (WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

        Reviewed by John Sullivan.

        - test that when -webkit-line-break: after-white-space is combined with
          white-space: nowrap, the trailing space is not shrunk to fit the in
          the available width

        - updates results for that and for not shrinking trailing space to less
          than zero

        * fast/text/whitespace/nowrap-line-break-after-white-space-expected.txt: Added.
        * fast/text/whitespace/nowrap-line-break-after-white-space.html: Added.
        * platform/mac/fast/block/float/editable-text-overlapping-float-expected.txt:
        * platform/mac/fast/inline/long-wrapped-line-expected.txt:
        * platform/mac/fast/text/whitespace/tab-character-basics-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
eric@webkit.org [Tue, 7 Apr 2009 14:25:57 +0000 (14:25 +0000)]
    Reviewed by Darin Adler.

        Move RangeBoundaryPoint off of Position, per Darin's suggestion
        https://bugs.webkit.org/show_bug.cgi?id=24966

        Rename setToChild to setToBeforeChild (since that's what the method does)

        * dom/Position.h:
        (WebCore::Position::offsetInContainerNode):
        * dom/Range.cpp:
        (WebCore::Range::insertNode):
        (WebCore::Range::selectNodeContents):
        (WebCore::boundaryNodeWillBeRemoved):
        * dom/Range.h:
        (WebCore::Range::startPosition):
        (WebCore::Range::endPosition):
        * dom/RangeBoundaryPoint.h:
        (WebCore::RangeBoundaryPoint::RangeBoundaryPoint):
        (WebCore::RangeBoundaryPoint::container):
        (WebCore::RangeBoundaryPoint::childBefore):
        (WebCore::RangeBoundaryPoint::position):
        (WebCore::RangeBoundaryPoint::offset):
        (WebCore::RangeBoundaryPoint::clear):
        (WebCore::RangeBoundaryPoint::set):
        (WebCore::RangeBoundaryPoint::setOffset):
        (WebCore::RangeBoundaryPoint::setToBeforeChild):
        (WebCore::RangeBoundaryPoint::setToStartOfNode):
        (WebCore::RangeBoundaryPoint::setToEndOfNode):
        (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
        (WebCore::RangeBoundaryPoint::invalidateOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
eric@webkit.org [Tue, 7 Apr 2009 14:25:23 +0000 (14:25 +0000)]
    Reviewed by Darin Adler.

        Add containerNode(), computeOffsetInContainerNode(),
        computeNodeBeforePosition() and computeNodeAfterPosition().
        https://bugs.webkit.org/show_bug.cgi?id=24763

        These functions will replace uses of rangeCompliantPosition()
        in future patches.

        No changes in behavior, thus no tests.

        * dom/Position.cpp:
        (WebCore::Position::containerNode):
        (WebCore::Position::computeOffsetInContainerNode):
        (WebCore::Position::computeNodeBeforePosition):
        (WebCore::Position::computeNodeAfterPosition):
        (WebCore::Position::anchorType):
        * dom/Position.h:
        (WebCore::Position::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-04 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 7 Apr 2009 11:48:06 +0000 (11:48 +0000)]
2009-04-04  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=25033
        dtoa.cpp segfaults with g++ 4.4.0

        g++ 4.4.0 seems to be more strict about aliasing rules, so it
        produces incorrect code if dtoa.cpp is compiled with
        -fstrict-aliasing (it also emits a ton of warnings, so fair enough
        I guess). The problem was that we were only casting variables to
        union types in order to do type punning, but GCC and the C
        standard require that we actually use a union to store the value.

        This patch does just that, the code is mostly copied from the dtoa
        version in GCC:
        http://gcc.gnu.org/viewcvs/trunk/libjava/classpath/native/fdlibm/dtoa.c?view=markup.

        * wtf/dtoa.cpp:
        (WTF::ulp):
        (WTF::b2d):
        (WTF::ratio):
        (WTF::hexnan):
        (WTF::strtod):
        (WTF::dtoa):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 6 Apr 2009 23:43:00 +0000 (23:43 +0000)]
2009-04-06  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Bottleneck dispatching mutation events in a new dispatchMutationEvent
        function.

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::dispatchModifiedEvent):
        * dom/ContainerNode.cpp:
        (WebCore::dispatchChildInsertionEvents):
        (WebCore::dispatchChildRemovalEvents):
        * dom/Node.cpp:
        (WebCore::Node::dispatchSubtreeModifiedEvent):
        (WebCore::Node::dispatchMutationEvent):
        * dom/Node.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 6 Apr 2009 23:11:59 +0000 (23:11 +0000)]
2009-04-06  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=25059
        Remove references to dominantScript, getGenericFontForScript.

        * platform/graphics/chromium/FontCacheChromiumWin.cpp: Removed references
            to getGenericFontForScript.
        (WebCore::FontCache::getLastResortFallbackFont): Removed calls to dominantScript.
        * platform/graphics/chromium/FontCacheLinux.cpp: Ditto.
        * rendering/RenderThemeChromiumLinux.cpp:
        (WebCore::defaultGUIFont): Removed Document* arg.
        (WebCore::RenderThemeChromiumLinux::systemFont): Ditto.
        * rendering/RenderThemeChromiumLinux.h: Ditto.
        * rendering/RenderThemeChromiumMac.h: Ditto.
        * rendering/RenderThemeChromiumMac.mm: Ditto.
        (WebCore::RenderThemeChromiumMac::systemFont): Ditto.
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::defaultGUIFont): Ditto.
        (WebCore::RenderThemeChromiumWin::systemFont): Ditto.
        * rendering/RenderThemeChromiumWin.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Mon, 6 Apr 2009 23:04:56 +0000 (23:04 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Mon, 6 Apr 2009 22:42:47 +0000 (22:42 +0000)]
2009-04-06  Christian Dywan  <christian@twotoasts.de>

        Rubber-stamped by Oliver Hunt.

        * de.po: Added German translation for WebKitGTK+.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 6 Apr 2009 21:56:25 +0000 (21:56 +0000)]
2009-04-06  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Fixed https://bugs.webkit.org/show_bug.cgi?id=21260
        Unbounded memory growth when churning elements with anonymous event handler functions

        The problem was that a protected event listener's scope chain would end
        up with a reference to the Node protecting it, causing a cycle. The
        solution is to stop protecting event listeners and rely on marking instead.

        This patch converts most Node event listeners to use marking instead of
        GC protection.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::isObservableThroughDOM):
        (WebCore::markDOMNodesForDocument): Refactored the test for whether a Node
        needs marking, and added a case for marking the node in order to mark its
        event listeners.

        * bindings/js/JSNodeCustom.cpp:
        (WebCore::markEventListeners):
        (WebCore::JSNode::addEventListener):
        (WebCore::JSNode::removeEventListener):
        (WebCore::JSNode::mark): Added code to mark a Node's event listeners when
        marking the Node. Changed code using protected event listeners to use event
        listeners.

        * dom/Node.idl: Changed code using protected event listeners to use event
        listeners.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 6 Apr 2009 20:58:21 +0000 (20:58 +0000)]
2009-04-06  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Remove unchecked bool return values for some dispatch event functions.

        * dom/Node.cpp:
        (WebCore::Node::dispatchSubtreeModifiedEvent):
        (WebCore::Node::dispatchUIEvent):
        (WebCore::Node::dispatchWebKitAnimationEvent):
        (WebCore::Node::dispatchWebKitTransitionEvent):
        (WebCore::Node::dispatchProgressEvent):
        * dom/Node.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Darin Fisher <darin@chromium.org>
darin@chromium.org [Mon, 6 Apr 2009 20:48:08 +0000 (20:48 +0000)]
2009-04-06  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25058
        Fix chromium build bustage caused by r42216

        * bindings/scripts/CodeGeneratorJS.pm:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 6 Apr 2009 19:48:39 +0000 (19:48 +0000)]
2009-04-06  Dimitri Glazkov  <dglazkov@chromium.org>

        Not reviewed because it's stupidly obvious.

        Correct the expected result by adding an extra line break.

        * fast/dom/HTMLSelectElement/length-not-overridden-expected.txt: Added
            an extra line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 6 Apr 2009 19:39:30 +0000 (19:39 +0000)]
2009-04-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Sam Weinig.

        * pt_BR.po: Added Brazilian Portuguese translation for WebKitGTK+.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 6 Apr 2009 19:39:14 +0000 (19:39 +0000)]
2009-04-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Sam Weinig.

        Added rules to maintain the localization support. We cannot simply
        use whatever gettextize gives us because our build system is
        non-recursive.

        * GNUmakefile.am:
        * configure.ac:

WebCore/

2009-04-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=20575
        No localization in WebKitGtk

        * platform/gtk/FileChooserGtk.cpp: Remove usage of glib/gi18n.h,
        since there are not translatable strings.
        * platform/gtk/LocalizedStringsGtk.cpp: Use the glib i18n header
        that is specific for libraries.

WebKit/gtk/

2009-04-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=20575
        No localization in WebKitGtk

        Implemented localization support for WebKitGTK+.

        * WebCoreSupport/ChromeClientGtk.cpp:
        * WebCoreSupport/ContextMenuClientGtk.cpp:
        * po/POTFILES: Added.
        * po/README: Added.
        * po/webkit.pot: Added.
        * webkit/webkitdownload.cpp:
        (_WebKitDownloadPrivate::webkit_download_class_init):
        * webkit/webkitprivate.cpp:
        (webkit_init):
        * webkit/webkitwebframe.cpp:

WebKit/gtk/po/

2009-04-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Sam Weinig.

        * GNUmakefile.am, POTFILES, webkit.pot: Initial setup of the
        localization infra-structure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRevert r42249 to fix the build.
darin@chromium.org [Mon, 6 Apr 2009 18:41:24 +0000 (18:41 +0000)]
Revert r42249 to fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Darin Fisher <darin@chromium.org>
darin@chromium.org [Mon, 6 Apr 2009 18:23:45 +0000 (18:23 +0000)]
2009-04-06  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25058
        Fix chromium build bustage caused by r42216

        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Mike Belshe <mike@belshe.com>
dglazkov@chromium.org [Mon, 6 Apr 2009 18:08:21 +0000 (18:08 +0000)]
2009-04-06  Mike Belshe  <mike@belshe.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24978
        Use custom implementations of a few Node methods so that
        we don't over-aggressively create JS wrappers here.

        * bindings/v8/custom/V8NodeCustom.cpp: Added custom implementations.
        * dom/Node.idl: Removed JSC-specifier, making impl custom for V8 as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
dglazkov@chromium.org [Mon, 6 Apr 2009 18:01:17 +0000 (18:01 +0000)]
WebCore:

2009-04-06  Dave Moore  <davemoore@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25031
        Make the V8 element collections check for named properties *before*
        checking if there are any elements with the same name. Otherwise
        it is both incorrect and slow.

        Test: fast/dom/HTMLSelectElement/length-not-overridden.html

        Both of these interceptors were attempting to find an element in the
        collection that had a name or id of the property name before checking
        for a JS property with that name.
        * bindings/v8/V8Collection.h:
        (WebCore::collectionNamedPropertyGetter):
        (WebCore::nodeCollectionNamedPropertyGetter):

LayoutTests:

2009-04-06  Dave Moore  <davemoore@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25031
        Test for ensuring that named elements don't override properties on collections

        * fast/dom/HTMLSelectElement/length-not-overridden-expected.txt: Added.
        * fast/dom/HTMLSelectElement/length-not-overridden.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 6 Apr 2009 17:51:53 +0000 (17:51 +0000)]
2009-04-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=25052

        Pull the call to updateGraphicsLayerGeometry() out of updateGraphicsLayers(),
        because we need to call it at the end of rebuildCompositingLayerTree() once
        we've determined which descendant layers are composited, otherwise
        calculateCompositedBounds() can give the wrong answer.

        Now that updateLayerCompositingState() doesn't end up calling updateGraphicsLayerGeometry(),
        call that explicitly from styleChanged(), if we know a layer update is not pending,
        and similarly from updateAfterLayout().

        Test: compositing/overflow/overflow-positioning.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::styleChanged):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateAfterLayout):
        (WebCore::RenderLayerBacking::updateGraphicsLayers):
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Mike Belshe <mike@belshe.com>
darin@chromium.org [Mon, 6 Apr 2009 16:01:33 +0000 (16:01 +0000)]
2009-04-06  Mike Belshe  <mike@belshe.com>

        Reviewed by Alexey Proskuryakov.

        Add accessors to AtomicString which take String/const char* arguments
        so that we don't accidentally thrash the AtomicString table.

        https://bugs.webkit.org/show_bug.cgi?id=24979

        * platform/text/AtomicString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Mon, 6 Apr 2009 15:47:35 +0000 (15:47 +0000)]
2009-04-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Rename DOM API select function to findFirst, findAll, etc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 6 Apr 2009 15:37:01 +0000 (15:37 +0000)]
2009-04-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Tor Arne Vestbø.

        Add /Programs to the productDir for GTK+, instead of adding
        /JavaScriptCore, when running jsc.

        * Scripts/run-sunspider:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[GTK+] Correct the column and row cursor
zecke@webkit.org [Mon, 6 Apr 2009 14:17:22 +0000 (14:17 +0000)]
[GTK+] Correct the column and row cursor

Make col and row work in WebCore/manual-tests/cursor.html. The issue
was spotted in the WebKit inspector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Mon, 6 Apr 2009 12:59:24 +0000 (12:59 +0000)]
2009-04-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Don't show and hide the platformPluginWidget, as it's our QWebView

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-05 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 6 Apr 2009 11:58:02 +0000 (11:58 +0000)]
2009-04-05  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=25042
        destroying webview widget directly causes crash.

        Do not connect the WebView to its own screen-changed signal, set a
        default handler instead.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-05 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 6 Apr 2009 11:57:47 +0000 (11:57 +0000)]
2009-04-05  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=25042
        destroying webview widget directly causes crash.

        GtkWidget::screen-changed can be emitted when a widget is being
        destroyed, protect against it.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hausmann@webkit.org [Mon, 6 Apr 2009 11:25:37 +0000 (11:25 +0000)]
WebCore:

    2009-04-06  Simon Hausmann  <simon.hausmann@nokia.com>

            Reviewed by Tor Arne Vestbø.

            Add new files to the Qt build.
            Export helper function from the Qt JSC binding, needed in WebKit/qt.

WebKit/qt:

    2009-04-06  Simon Hausmann  <simon.hausmann@nokia.com>
                Ariya Hidayat <ariya.hidayat@nokia.com>
                Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
                Genevieve Mak <gen@staikos.net>

            Reviewed by Tor Arne Vestbø, Simon Hausmann

            First revision of new API in the Qt port to access the DOM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 6 Apr 2009 11:13:18 +0000 (11:13 +0000)]
2009-04-06  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Changed ScriptFunctionCall's last argument from a const char* as the function name to a String.

        Internally the function name is stored as a WebCore::String and the Qt port wants to use this
        constructor programmatically where the function name is also a WebCore::String.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-06 Mike Belshe <mike@belshe.com>
eric@webkit.org [Mon, 6 Apr 2009 09:51:57 +0000 (09:51 +0000)]
2009-04-06  Mike Belshe <mike@belshe.com>

        Reviewed by Eric Seidel.

        HTMLCanvasElement crash when ImageBuffer creation fails.
        https://bugs.webkit.org/show_bug.cgi?id=23212

        Check for NULL before using the ImageBuffer as we might
        be low on memory and creation may have failed.

        Test case creation blocked by:
        https://bugs.webkit.org/show_bug.cgi?id=25055

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::createImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-05 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 5 Apr 2009 22:48:05 +0000 (22:48 +0000)]
2009-04-05  Geoffrey Garen  <ggaren@apple.com>

        [Originally] Reviewed by Sam Weinig.

        Rolled back in r42214 with crashes fixed.

        [Removed irrelevant ExecState* parameter from event handler registration code.]

        [No change in behavior.]

        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::addEventListener):
        (WebCore::JSDOMApplicationCache::removeEventListener):
        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
        (WebCore::JSDOMGlobalObject::findJSEventListener):
        (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
        * bindings/js/JSDOMGlobalObject.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::addEventListener):
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::addEventListener):
        (WebCore::JSMessagePort::removeEventListener):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::addEventListener):
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::addEventListener):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::addEventListener):
        (WebCore::JSWorkerContext::removeEventListener):
        * bindings/js/JSWorkerCustom.cpp:
        (WebCore::JSWorker::addEventListener):
        (WebCore::JSWorker::removeEventListener):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::addEventListener):
        (WebCore::JSXMLHttpRequest::removeEventListener):
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        (WebCore::JSXMLHttpRequestUpload::addEventListener):
        (WebCore::JSXMLHttpRequestUpload::removeEventListener):
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-05 Erik L. Bunce <elbunce@xendom.com>
hausmann@webkit.org [Sun, 5 Apr 2009 17:26:41 +0000 (17:26 +0000)]
2009-04-05  Erik L. Bunce  <elbunce@xendom.com>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=25050

        Fix an assert failure when dropping an 'empty' text/uri-list on a QWebView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Qt build
hausmann@webkit.org [Sun, 5 Apr 2009 14:56:29 +0000 (14:56 +0000)]
Fix the Qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-05 Mike Hommey <glandium@debian.org>
jmalonzo@webkit.org [Sun, 5 Apr 2009 08:21:55 +0000 (08:21 +0000)]
2009-04-05  Mike Hommey  <glandium@debian.org>

        Reviewed by Holger Freyther.

        Filter out all C++ symbols
        https://bugs.webkit.org/show_bug.cgi?id=24960

        Considering the public API is all C, we can just filter out all
        C++ mangled symbols, which will avoid exporting symbols in some
        corner cases such as gcc bugs on specific architectures, etc.

        * autotools/symbols.filter:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-05 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 5 Apr 2009 08:16:38 +0000 (08:16 +0000)]
2009-04-05  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
        https://bugs.webkit.org/show_bug.cgi?id=24487

        Updated documentation and put more information about the
        private-browsing setting for WebKitGtk.

        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fixes for wxMac/Tiger.
kevino@webkit.org [Sun, 5 Apr 2009 03:56:32 +0000 (03:56 +0000)]
Build fixes for wxMac/Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fixes for the Windows port.
kevino@webkit.org [Sun, 5 Apr 2009 00:06:29 +0000 (00:06 +0000)]
wx build fixes for the Windows port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 4 Apr 2009 20:25:49 +0000 (20:25 +0000)]
2009-04-04  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Cameron Zwarich

        https://bugs.webkit.org/show_bug.cgi?id=24648

        Ensure that mapPoint(const IntPoint&) calls the FloatPoint
        version to avoid infinite recursion.

        No test because mapPoint(const IntPoint&) isn't ever called
        on Mac, so I can't reproduce.

        * platform/graphics/transforms/TransformationMatrix.h:
        (WebCore::TransformationMatrix::mapPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sat, 4 Apr 2009 07:33:39 +0000 (07:33 +0000)]
WebCore:

        Reviewed by Mark Rowe.

        - fix <rdar://problem/6757862> REGRESSION: Cannot use the mouse to place
          the insertion point inside a Thai character

        Test: fast/text/international/thai-offsetForPosition-inside-character.html

        * platform/graphics/mac/CoreTextController.cpp:
        (WebCore::CoreTextController::offsetForPosition): Changed to use
        cursorMovementIterator instead of characterBreakIterator, allowing this
        function to return a valid cursor position even if it is not at
        a character boundary.

LayoutTests:

        Reviewed by Mark Rowe.

        - test for  <rdar://problem/6757862> REGRESSION: Cannot use the mouse to
          place the insertion point inside a Thai character

        * fast/text/international/thai-offsetForPosition-inside-character-expected.txt: Added.
        * fast/text/international/thai-offsetForPosition-inside-character.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sat, 4 Apr 2009 07:27:44 +0000 (07:27 +0000)]
WebCore:

        Reviewed by Mark Rowe.

        - fix an assertion failure when clicking at the beginning of a
          glyph cluster at the beginning of a text run

        Test: fast/text/offsetForPosition-cluster-at-zero.html

        * platform/graphics/mac/CoreTextController.cpp:
        (WebCore::CoreTextController::offsetForPosition): Corrected the bound
        check on firstGlyphBeforeCluster, letting it be 0 or -1, but not less
        than -1.

LayoutTests:

        Reviewed by Mark Rowe.

        - test for a bug where computing the text offset for a position at the
          beginning of a glyph cluster at the beginning of a Core Text run resulted
          in an attempt to read past the end of a vector

        * fast/text/offsetForPosition-cluster-at-zero-expected.txt: Added.
        * fast/text/offsetForPosition-cluster-at-zero.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 4 Apr 2009 07:20:53 +0000 (07:20 +0000)]
2009-04-04  Sam Weinig  <sam@webkit.org>

        Update test result.

        * dom/xhtml/level2/html/HTMLFormElement10-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Allows 16 HTML/CSS standard colors to be shown as swatch backgrounds
timothy@apple.com [Sat, 4 Apr 2009 01:06:29 +0000 (01:06 +0000)]
    Allows 16 HTML/CSS standard colors to be shown as swatch backgrounds
        when the names are given.

        https://bugs.webkit.org/show_bug.cgi?id=25044

        Reviewed by Timothy Hatcher.

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.updateTitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Sat, 4 Apr 2009 00:56:25 +0000 (00:56 +0000)]
WebCore:

2009-04-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        <rdar://problem/6330929>
        https://bugs.webkit.org/show_bug.cgi?id=21456

        Don't update the document pointer for all inactive windows on navigations.
        This change causes us to differ slightly from Firefox when accessing the
        document from within a closure tied to a navigated context, but as all
        browsers differ on this edge case, I don't foresee compatibility issues.

        Test: http/tests/security/cross-frame-access-document-direct.html

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::clearWindowShell):
        (WebCore::ScriptController::initScript):
        (WebCore::ScriptController::updateDocument):
        * bindings/js/ScriptController.h:

LayoutTests:

2009-04-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Update tests for <rdar://problem/6330929>
        https://bugs.webkit.org/show_bug.cgi?id=21456

        * dom/xhtml/level2/html/HTMLFormElement10-expected.txt:
        * fast/dom/Window/dom-access-from-closure-iframe-expected.txt:
        * fast/dom/Window/dom-access-from-closure-window-expected.txt:
        * http/tests/security/cross-frame-access-document-direct-expected.txt: Added.
        * http/tests/security/cross-frame-access-document-direct.html: Added.
        * http/tests/security/resources/cross-frame-iframe-for-document-direct-test-victim.html: Added.
        * http/tests/security/resources/cross-frame-iframe-for-document-direct-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fixed https://bugs.webkit.org/show_bug.cgi?id=24787.
cmarrin@apple.com [Sat, 4 Apr 2009 00:49:13 +0000 (00:49 +0000)]
    Fixed https://bugs.webkit.org/show_bug.cgi?id=24787.

        We were starting transitions with 0 duration and delay, which is
        useless. With accelerated compositing on, this went through a code
        path that tried to use m_toStyle, which never got set because the
        transitions was short circuited before it had a chance to. So I
        both protect against using that null pointer and avoid starting
        the transition in the first place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fixes a bug where you could not type any more in the Web Inspector's
timothy@apple.com [Sat, 4 Apr 2009 00:41:04 +0000 (00:41 +0000)]
    Fixes a bug where you could not type any more in the Web Inspector's
        search field after the first match is selected in the Resources panel.

        https://bugs.webkit.org/show_bug.cgi?id=23982
        rdar://problem/6592367

        Reviewed by Darin Adler.

        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype._jumpToSearchResult): Use the
        window object of the frame to set the selection, not the main window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-03 Kevin Decker <kdecker@apple.com>
sullivan@apple.com [Sat, 4 Apr 2009 00:37:55 +0000 (00:37 +0000)]
2009-04-03  Kevin Decker  <kdecker@apple.com>

        Reviewed by Anders Carlsson.

        <rdar://problem/6756512>

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::spawnPluginHost): Tweaked the visibleName property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-03 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Sat, 4 Apr 2009 00:34:28 +0000 (00:34 +0000)]
2009-04-03  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Mark Rowe.

        Fix running DumpRenderTree with a root.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Fri, 3 Apr 2009 23:49:00 +0000 (23:49 +0000)]
WebCore:

2009-04-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=22081
        <rdar://problem/6346030>
        Don't allow overriding the return value of window.location.

        Tests: fast/dom/Window/Location/location-override-toString-on-proto-using-defineGetter.html
               fast/dom/Window/Location/location-override-toString-on-proto-using-with.html
               fast/dom/Window/Location/location-override-toString-on-proto.html
               fast/dom/Window/Location/location-override-toString-using-defineGetter.html
               fast/dom/Window/Location/location-override-toString-using-with.html
               fast/dom/Window/Location/location-override-toString.html
               fast/dom/Window/Location/location-override-valueOf-on-proto-using-defineGetter.html
               fast/dom/Window/Location/location-override-valueOf-on-proto-using-with.html
               fast/dom/Window/Location/location-override-valueOf-on-proto.html
               fast/dom/Window/Location/location-override-valueOf-using-defineGetter.html
               fast/dom/Window/Location/location-override-valueOf-using-with.html
               fast/dom/Window/Location/location-override-valueOf.html
               fast/dom/Window/Location/window-override-location-using-defineGetter.html
               fast/dom/Window/Location/window-override-window-using-defineGetter.html
               fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString.html
               fast/dom/Window/Location/window-shadow-location-using-string.html
               fast/dom/Window/Location/window-shadow-window-using-js-object-with-location-field.html

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::defineGetter):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::customPut):
        (WebCore::JSLocation::defineGetter):
        (WebCore::JSLocationPrototype::customPut):
        (WebCore::JSLocationPrototype::defineGetter):
        * bindings/scripts/CodeGeneratorJS.pm:
        * page/Location.idl:

LayoutTests:

2009-04-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Tests for https://bugs.webkit.org/show_bug.cgi?id=22081
        <rdar://problem/6346030>
        Don't allow overriding the return value of window.location.

        * fast/dom/Window/Location: Added.
        * fast/dom/Window/Location/location-override-toString-expected.txt: Added.
        * fast/dom/Window/Location/location-override-toString-on-proto-expected.txt: Added.
        * fast/dom/Window/Location/location-override-toString-on-proto-using-defineGetter-expected.txt: Added.
        * fast/dom/Window/Location/location-override-toString-on-proto-using-defineGetter.html: Added.
        * fast/dom/Window/Location/location-override-toString-on-proto-using-with-expected.txt: Added.
        * fast/dom/Window/Location/location-override-toString-on-proto-using-with.html: Added.
        * fast/dom/Window/Location/location-override-toString-on-proto.html: Added.
        * fast/dom/Window/Location/location-override-toString-using-defineGetter-expected.txt: Added.
        * fast/dom/Window/Location/location-override-toString-using-defineGetter.html: Added.
        * fast/dom/Window/Location/location-override-toString-using-with-expected.txt: Added.
        * fast/dom/Window/Location/location-override-toString-using-with.html: Added.
        * fast/dom/Window/Location/location-override-toString.html: Added.
        * fast/dom/Window/Location/location-override-valueOf-expected.txt: Added.
        * fast/dom/Window/Location/location-override-valueOf-on-proto-expected.txt: Added.
        * fast/dom/Window/Location/location-override-valueOf-on-proto-using-defineGetter-expected.txt: Added.
        * fast/dom/Window/Location/location-override-valueOf-on-proto-using-defineGetter.html: Added.
        * fast/dom/Window/Location/location-override-valueOf-on-proto-using-with-expected.txt: Added.
        * fast/dom/Window/Location/location-override-valueOf-on-proto-using-with.html: Added.
        * fast/dom/Window/Location/location-override-valueOf-on-proto.html: Added.
        * fast/dom/Window/Location/location-override-valueOf-using-defineGetter-expected.txt: Added.
        * fast/dom/Window/Location/location-override-valueOf-using-defineGetter.html: Added.
        * fast/dom/Window/Location/location-override-valueOf-using-with-expected.txt: Added.
        * fast/dom/Window/Location/location-override-valueOf-using-with.html: Added.
        * fast/dom/Window/Location/location-override-valueOf.html: Added.
        * fast/dom/Window/Location/resources: Added.
        * fast/dom/Window/Location/resources/location-tests-functions.js: Added.
        (normalizeURL):
        * fast/dom/Window/Location/resources/pass.html: Added.
        * fast/dom/Window/Location/resources/window-shadow-location-using-js-object-with-toString-iframe.html: Added.
        * fast/dom/Window/Location/resources/window-shadow-location-using-string-iframe.html: Added.
        * fast/dom/Window/Location/window-override-location-using-defineGetter-expected.txt: Added.
        * fast/dom/Window/Location/window-override-location-using-defineGetter.html: Added.
        * fast/dom/Window/Location/window-override-window-using-defineGetter-expected.txt: Added.
        * fast/dom/Window/Location/window-override-window-using-defineGetter.html: Added.
        * fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString-expected.txt: Added.
        * fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString.html: Added.
        * fast/dom/Window/Location/window-shadow-location-using-string-expected.txt: Added.
        * fast/dom/Window/Location/window-shadow-location-using-string.html: Added.
        * fast/dom/Window/Location/window-shadow-window-using-js-object-with-location-field-expected.txt: Added.
        * fast/dom/Window/Location/window-shadow-window-using-js-object-with-location-field.html: Added.
        * http/tests/security/cross-frame-access-location-put-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-03 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 3 Apr 2009 23:19:49 +0000 (23:19 +0000)]
2009-04-03  Geoffrey Garen  <ggaren@apple.com>

        Rolled out r42214 since it seems to have caused crashes on the buildbot.

        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::addEventListener):
        (WebCore::JSDOMApplicationCache::removeEventListener):
        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
        (WebCore::JSDOMGlobalObject::findJSEventListener):
        (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
        * bindings/js/JSDOMGlobalObject.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::addEventListener):
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::addEventListener):
        (WebCore::JSMessagePort::removeEventListener):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::addEventListener):
        (WebCore::JSNode::removeEventListener):
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::addEventListener):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::addEventListener):
        (WebCore::JSWorkerContext::removeEventListener):
        * bindings/js/JSWorkerCustom.cpp:
        (WebCore::JSWorker::addEventListener):
        (WebCore::JSWorker::removeEventListener):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::addEventListener):
        (WebCore::JSXMLHttpRequest::removeEventListener):
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        (WebCore::JSXMLHttpRequestUpload::addEventListener):
        (WebCore::JSXMLHttpRequestUpload::removeEventListener):
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Fri, 3 Apr 2009 23:13:12 +0000 (23:13 +0000)]
WebCore:

2009-04-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Fix for <rdar://problem/6476356>
        https://bugs.webkit.org/show_bug.cgi?id=23148

        - Use the window object the Location and History objects are directly associated with
          instead of the lexical global object to pick the object prototype to serve as the
          base of the their respective prototype chains.
        - Re-factor as necessary to allow passing the correct global object to the createPrototype
          functions.

        Tests: http/tests/security/cross-frame-access-history-prototype.html
               http/tests/security/cross-frame-access-location-prototype.html

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::JSAudioConstructor::JSAudioConstructor):
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::getCachedDOMStructure):
        (WebCore::cacheDOMStructure):
        * bindings/js/JSDOMBinding.h:
        (WebCore::getDOMStructure):
        (WebCore::getDOMPrototype):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::history):
        (WebCore::JSDOMWindow::location):
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::location):
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::JSImageConstructor::JSImageConstructor):
        * bindings/js/JSMessageChannelConstructor.cpp:
        (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
        * bindings/js/JSNamedNodesCollection.h:
        (WebCore::JSNamedNodesCollection::createPrototype):
        * bindings/js/JSOptionConstructor.cpp:
        (WebCore::JSOptionConstructor::JSOptionConstructor):
        * bindings/js/JSRGBColor.h:
        (WebCore::JSRGBColor::createPrototype):
        * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
        (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
        * bindings/js/JSWebKitPointConstructor.cpp:
        (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
        * bindings/js/JSWorkerConstructor.cpp:
        (WebCore::JSWorkerConstructor::JSWorkerConstructor):
        * bindings/js/JSXMLHttpRequestConstructor.cpp:
        (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
        * bindings/js/JSXSLTProcessorConstructor.cpp:
        (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/objc/objc_runtime.h:
        (JSC::Bindings::ObjcFallbackObjectImp::createPrototype):
        * bridge/runtime_array.h:
        (JSC::RuntimeArray::createPrototype):
        * bridge/runtime_method.h:
        (JSC::RuntimeMethod::createPrototype):
        * bridge/runtime_object.h:
        (JSC::RuntimeObjectImp::createPrototype):
        * page/DOMWindow.idl:

LayoutTests:

2009-04-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Tests for <rdar://problem/6476356>
        https://bugs.webkit.org/show_bug.cgi?id=23148

        Test for using the correct global object for location and history object
        prototype chain creation.

        * http/tests/security/cross-frame-access-history-prototype-expected.txt: Added.
        * http/tests/security/cross-frame-access-history-prototype.html: Added.
        * http/tests/security/cross-frame-access-location-prototype-expected.txt: Added.
        * http/tests/security/cross-frame-access-location-prototype.html: Added.
        * http/tests/security/resources/cross-frame-history-prototype-iframe.html: Added.
        * http/tests/security/resources/cross-frame-location-prototype-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-03 Jian Li <jianli@chromium.org>
dimich@chromium.org [Fri, 3 Apr 2009 22:24:39 +0000 (22:24 +0000)]
2009-04-03  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=25009
        Upstream changes to WorkerContextExecutionProxy for V8 bindings in order to use V8EventListenerList as container.

        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
        (WebCore::WorkerContextExecutionProxy::dispose):
        (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener):
        (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
        * bindings/v8/WorkerContextExecutionProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-03 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 3 Apr 2009 22:09:15 +0000 (22:09 +0000)]
2009-04-03  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Removed irrelevant ExecState* parameter from event handler registration code.

        No change in behavior.

        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::addEventListener):
        (WebCore::JSDOMApplicationCache::removeEventListener):
        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
        (WebCore::JSDOMGlobalObject::findJSEventListener):
        (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
        * bindings/js/JSDOMGlobalObject.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::addEventListener):
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::addEventListener):
        (WebCore::JSMessagePort::removeEventListener):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::addEventListener):
        (WebCore::JSNode::removeEventListener):
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::addEventListener):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::addEventListener):
        (WebCore::JSWorkerContext::removeEventListener):
        * bindings/js/JSWorkerCustom.cpp:
        (WebCore::JSWorker::addEventListener):
        (WebCore::JSWorker::removeEventListener):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::addEventListener):
        (WebCore::JSXMLHttpRequest::removeEventListener):
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        (WebCore::JSXMLHttpRequestUpload::addEventListener):
        (WebCore::JSXMLHttpRequestUpload::removeEventListener):
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlsson.
kdecker@apple.com [Fri, 3 Apr 2009 22:00:08 +0000 (22:00 +0000)]
    Reviewed by Anders Carlsson.

        <rdar://problem/6756512>

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::spawnPluginHost): Tweaked the visibleName property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Skip tests that rely on layoutTestController.waitForPolicyDelegate on platfor...
aroben@apple.com [Fri, 3 Apr 2009 21:21:23 +0000 (21:21 +0000)]
    Skip tests that rely on layoutTestController.waitForPolicyDelegate on platforms that don't implement that functionality

        Implementing is covered by the following bugs:
        <https://bugs.webkit.org/show_bug.cgi?id=25036>
        <https://bugs.webkit.org/show_bug.cgi?id=25037>
        <https://bugs.webkit.org/show_bug.cgi?id=25038>

        Rubber-stamped by Mark Rowe.

        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        Skip tests that use layoutTestController.waitForPolicyDelegate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Fri, 3 Apr 2009 21:09:51 +0000 (21:09 +0000)]
WebCore:

        Reviewed by Simon Fraser.

        - fix <rdar://problem/6634771> Under full-page zoom, cannot scroll
          MobileMe contact list

        Test: fast/css/zoom-in-length-round-trip.html

        * dom/Element.cpp:
        (WebCore::adjustForLocalZoom): For zoom factors greater than 1, ensure
        that the returned value is equal to the original unscaled value.
        (WebCore::adjustForAbsoluteZoom): Ditto.

LayoutTests:

        Reviewed by Simon Fraser.

        - test for <rdar://problem/6634771> Under full-page zoom, cannot scroll
          MobileMe contact list

        * fast/css/zoom-in-length-round-trip-expected.txt: Added.
        * fast/css/zoom-in-length-round-trip.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-03 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Fri, 3 Apr 2009 20:44:51 +0000 (20:44 +0000)]
2009-04-03  John Sullivan  <sullivan@apple.com>

        fixed <rdar://problem/6355573> [WebView _setCacheModel:] leaks the result of _CFURLCacheCopyCacheDirectory

        Reviewed by Adam Roben

        * WebView/WebView.mm:
        (+[WebView _setCacheModel:]):
        use WebCFAutorelease rather than autorelease on result of method that returns CFStringRef

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-03 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 3 Apr 2009 20:35:45 +0000 (20:35 +0000)]
2009-04-03  Simon Fraser  <simon.fraser@apple.com>

        Update expected result due to rounding difference after r42207.

        * platform/mac/svg/hixie/perf/007-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fixed https://bugs.webkit.org/show_bug.cgi?id=24941
cmarrin@apple.com [Fri, 3 Apr 2009 19:29:22 +0000 (19:29 +0000)]
    Fixed https://bugs.webkit.org/show_bug.cgi?id=24941

        This fix essentially does a -viewWillDraw call for layout. It adds
        a CFRunLoopObserver which performs layout just before drawing on the
        Mac platform. This makes sure layout is complete before rendering and
        avoids a flash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 3 Apr 2009 18:57:15 +0000 (18:57 +0000)]
2009-04-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=24648

        Optimize mapPoint(), mapRect() and mapQuad() for identity matrix and translations.

        * platform/graphics/transforms/TransformationMatrix.cpp:
        (WebCore::TransformationMatrix::mapPoint):
        (WebCore::TransformationMatrix::mapRect):
        (WebCore::TransformationMatrix::mapQuad):
        * platform/graphics/transforms/TransformationMatrix.h:
        (WebCore::TransformationMatrix::mapPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 3 Apr 2009 18:39:48 +0000 (18:39 +0000)]
2009-04-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=25018

        Add containsPoint() and containsQuad() methods to FloatQuad.

        * platform/graphics/FloatQuad.cpp:
        (WebCore::dot):
        (WebCore::isPointInTriangle):
        (WebCore::FloatQuad::containsPoint):
        (WebCore::FloatQuad::containsQuad):
        * platform/graphics/FloatQuad.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-03 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 3 Apr 2009 18:28:49 +0000 (18:28 +0000)]
2009-04-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        WebKit side of <rdar://problem/6752953>.

        Pass the clip rect to the plug-in host.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::resize):
        * Plugins/Hosted/WebKitPluginHost.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin.
kdecker@apple.com [Fri, 3 Apr 2009 18:16:05 +0000 (18:16 +0000)]
    Reviewed by Darin.

        *  loader/ProgressTracker.cpp: Included DocumentLoader.h
        (WebCore::ProgressTracker::incrementProgress): Limit the 50%-clamp rule to
        documents that use WebCore's layout system.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-03 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 3 Apr 2009 18:06:21 +0000 (18:06 +0000)]
2009-04-03  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6336092> REGRESSION: movie does not resize correctly

        Test: media/video-size-intrinsic-scale.html

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::naturalSize): Use QTMovieCurrentSizeAttribute instead
        of QTMovieNaturalSizeAttribute so we return the correct size for movies saved
        with a non-default matrix.
        (WebCore::MediaPlayerPrivate::setSize): Don't resize the QTMovieView
        because [QTMovieView setFrame] also resizes the movie itself, and as
        the renderer calls setSize immediately when a movie reports a size change
        (QTMovieSizeDidChangeNotification) we can get into a feedback loop
        observing the size change and resetting the size, and this can cause
        QuickTime to miss correctly setting a movie's size when the media size
        changes after opening (as happens with an rtsp movie once the server sends
        the track sizes). Instead, remember the size passed to paint() and
        resize the view when it changes.
        (WebCore::MediaPlayerPrivate::paint): Resize the view when passed a new size.

        * platform/graphics/win/QTMovieWin.cpp:
        (QTMovieWin::getNaturalSize): Use GetMovieBox instead of GetMovieNaturalBoundsRect
        so we return the correct size for movies saved with non-default matrix.

2009-04-03  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6336092> REGRESSION: movie does not resize correctly

        * media/content/scaled-matrix.mov: Added. QuickTime movie saved with 2x scale.
        * media/video-size-intrinsic-scale-expected.txt: Added.
        * media/video-size-intrinsic-scale.html: Added, test that element with a scaled movie is
        sized correctly.
        * media/video-test.js: Modify so it can be included in <head> element.
        (logConsole): New, wraps creating console <div>, doesn't assume document.body exists.
        (consoleWrite): Call logConsole().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-03 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 3 Apr 2009 17:52:41 +0000 (17:52 +0000)]
2009-04-03  Darin Fisher  <darin@chromium.org>

        Reviewed by Darin Adler.

        Restore FrameLoader::policyDocumentLoader to fix the Chromium build.
        https://bugs.webkit.org/show_bug.cgi?id=25028

        * loader/FrameLoader.h:
        (WebCore::FrameLoader::policyDocumentLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFixed a backwards comment in ChangeLog.
darin@apple.com [Fri, 3 Apr 2009 16:58:53 +0000 (16:58 +0000)]
Fixed a backwards comment in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Michael Nordman <michaeln@google.com>
darin@chromium.org [Fri, 3 Apr 2009 16:28:48 +0000 (16:28 +0000)]
2009-04-02  Michael Nordman  <michaeln@google.com>

        Reviewed by Alexey Proskuryakov.

        Use long long, not int64, when working in webcore (sorry).
        https://bugs.webkit.org/show_bug.cgi?id=25011

        No change in functionality, so no tests.

        * platform/network/chromium/ResourceResponse.h:
        (WebCore::ResourceResponse::getAppCacheID):
        (WebCore::ResourceResponse::setAppCacheID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Fri, 3 Apr 2009 13:00:35 +0000 (13:00 +0000)]
2009-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        Require GTK+ >= 2.10; 2.8 is already very old, and some very
        useful APIs are only available since 2.10.

        * configure.ac:

WebCore/

2009-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        Remove pre-processor checks for GTK+ >= 2.10, since we now require
        at least that version.

        * platform/graphics/gtk/FontPlatformDataGtk.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        * platform/gtk/ContextMenuItemGtk.cpp:
        (WebCore::gtkStockIDFromContextMenuAction):
        * platform/gtk/KeyEventGtk.cpp:
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
        * platform/gtk/LocalizedStringsGtk.cpp:
        (WebCore::contextMenuItemTagSelectAll):
        * platform/gtk/MouseEventGtk.cpp:
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):
        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::documentFragment):
        * platform/gtk/WheelEventGtk.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit/gtk

2009-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        Remove pre-processor checks for GTK+ >= 2.10, since we now require
        at least that version.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::clipboard_clear_contents_cb):
        (WebKit::EditorClient::respondToChangedSelection):
        * webkit/webkitwebframe.cpp:
        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 3 Apr 2009 06:49:19 +0000 (06:49 +0000)]
2009-04-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=25021

        Fix repainting an element with a reflection and transform after layout.
        Telling the reflection to repaint directly is wrong, because, with
        LayoutState enabled, it only takes the reflection's transform into account,
        not that of the element. We can fix this, and keep the benefits of LayoutState,
        by computing the reflected repaint rect, and repainting that using the original
        renderer.

        Test: fast/repaint/reflection-repaint-test.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 3 Apr 2009 05:39:44 +0000 (05:39 +0000)]
2009-04-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=23307

        When repainting during layout (when LayoutState is enabled), we need
        to apply the transform to the dirty rect, before applying x(), y() and
        the offset storted in the LayoutState.

        Also bypass LayoutState in mapLocalToContainer() if we have a repaintContainer,
        since LayoutState is always root-relative.

        Test: fast/repaint/transform-layout-repaint.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::mapLocalToContainer):
        (WebCore::RenderBox::computeRectForRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6684745> Crash in -[WebView removeSizeObservers] when loading NIB...
mrowe@apple.com [Fri, 3 Apr 2009 03:10:29 +0000 (03:10 +0000)]
<rdar://problem/6684745> Crash in -[WebView removeSizeObservers] when loading NIB file

Reviewed by Dan Bernstein and Timothy Hatcher.

The implementation of -[NSView initWithCoder:] can result in -viewWillMoveToSuperview:/-viewDidMoveToSuperview: being sent to
our view before we've had a chance to initialize _private, so we need to ensure it is non-nil before dereferencing it in those
methods.

* WebView/WebView.mm:
(-[WebView removeSizeObservers]): Nil-check _private before dereferencing it.
(-[WebView addSizeObservers]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Mac build after r42191.
mrowe@apple.com [Fri, 3 Apr 2009 01:07:52 +0000 (01:07 +0000)]
Fix the Mac build after r42191.

* WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Windows build after r42190.
mrowe@apple.com [Fri, 3 Apr 2009 01:01:45 +0000 (01:01 +0000)]
Fix Windows build after r42190.

* page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):  Update to use the new name of the constant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFixed ChangeLog.
darin@apple.com [Fri, 3 Apr 2009 00:42:20 +0000 (00:42 +0000)]
Fixed ChangeLog.

2009-04-02  Darin Adler  <darin@apple.com>

        Reviewed by Brady Eidson.

        <rdar://problem/6625840> Previous Page isn't loaded after hitting back button at http://www.breakingnews.ie/

        Test: http/tests/navigation/onload-navigation-iframe-2.html

        * html/HTMLFrameElement.cpp:
        (WebCore::HTMLFrameElement::HTMLFrameElement): Removed unneeded createdByParser flag.
        * html/HTMLFrameElement.h: Ditto.
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Ditto.
        * html/HTMLFrameElementBase.h: Ditto.
        * html/HTMLFrameOwnerElement.cpp:
        (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): Ditto.
        * html/HTMLFrameOwnerElement.h: Ditto.
        * html/HTMLIFrameElement.cpp:
        (WebCore::HTMLIFrameElement::HTMLIFrameElement): Ditto.
        * html/HTMLIFrameElement.h: Ditto.
        * html/HTMLPlugInElement.cpp:
        (WebCore::HTMLPlugInElement::HTMLPlugInElement): Ditto.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::submitForm): Removed unneeded check of the createdByParser flag.
        The original change that introduced this, http://trac.webkit.org/changeset/25410, does
        not make it clear why this check was needed. And it seems it is needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Fri, 3 Apr 2009 00:41:04 +0000 (00:41 +0000)]
WebCore:

2009-04-02  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Add a way to get a list of focusable nodes.

        * dom/Document.cpp:
        (WebCore::Document::setFocusedNode):
        (WebCore::Document::getFocusableNodes):
        * dom/Document.h:

LayoutTests:

2009-04-02  Darin Adler  <darin@apple.com>

        Reviewed by Brady Eidson.

        <rdar://problem/6625840> Previous Page isn't loaded after hitting back button at http://www.breakingnews.ie/

        * http/tests/navigation/onload-navigation-iframe-2-expected.txt: Copied from
        LayoutTests/http/tests/navigation/onload-navigation-iframe-expected.txt.
        Updated for slight difference in the new test.

        * http/tests/navigation/onload-navigation-iframe-2.html: Copied from
        LayoutTests/http/tests/navigation/onload-navigation-iframe.html.
        Changed test to use an iframe element already in the HTML.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
adele@apple.com [Fri, 3 Apr 2009 00:39:18 +0000 (00:39 +0000)]
WebCore:

2009-04-02  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Add a way to get a list of focusable nodes.

        * dom/Document.cpp:
        (WebCore::Document::setFocusedNode):
        (WebCore::Document::getFocusableNodes):
        * dom/Document.h:

WebKit:

2009-04-02  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        * WebKit.xcodeproj/project.pbxproj:
        Add WebDOMOperationsInternal.h and make WebDOMOperationsPrivate.h private.

WebKit/mac:

2009-04-02  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Add a way to get a list of focusable nodes.

        * DOM/WebDOMOperations.mm:
        (-[DOMDocument _focusableNodes]):
        * DOM/WebDOMOperationsInternal.h: Added.
        * DOM/WebDOMOperationsPrivate.h: Make this a private header.
        Move old methods to WebDOMOperationsInternal.h
        * WebView/WebHTMLView.mm: Use methods from WebDOMOperationsInternal.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 3 Apr 2009 00:19:26 +0000 (00:19 +0000)]
2009-04-02  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/6654255> crash due to null FrameView in EventHandler

        Lots of code was added to EventHandler that used view() and page() without
        null checking, but both of those can become null due to the frame lifetime.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEventSingleClick):
        (WebCore::EventHandler::eventMayStartDrag):
        (WebCore::EventHandler::handleAutoscroll):
        (WebCore::EventHandler::autoscrollTimerFired):
        (WebCore::EventHandler::setPanScrollCursor):
        (WebCore::EventHandler::allowDHTMLDrag):
        (WebCore::EventHandler::hitTestResultAtPoint):
        (WebCore::EventHandler::stopAutoscrollTimer):
        (WebCore::EventHandler::selectCursor):
        (WebCore::EventHandler::handleMousePressEvent):
        (WebCore::EventHandler::handleMouseMoveEvent):
        (WebCore::EventHandler::dispatchDragEvent):
        (WebCore::EventHandler::prepareMouseEvent):
        (WebCore::EventHandler::dispatchMouseEvent):
        (WebCore::EventHandler::handleWheelEvent):
        (WebCore::EventHandler::hoverTimerFired):
        (WebCore::EventHandler::keyEvent):
        (WebCore::EventHandler::dragHysteresisExceeded):
        (WebCore::EventHandler::shouldDragAutoNode):
        (WebCore::EventHandler::handleDrag):
        (WebCore::EventHandler::handleTextInputEvent):
        (WebCore::EventHandler::addPendingFrameUnloadEventCount):
        (WebCore::EventHandler::removePendingFrameUnloadEventCount):
        (WebCore::EventHandler::clearPendingFrameUnloadEventCount):
        (WebCore::EventHandler::addPendingFrameBeforeUnloadEventCount):
        (WebCore::EventHandler::removePendingFrameBeforeUnloadEventCount):
        (WebCore::EventHandler::clearPendingFrameBeforeUnloadEventCount):
        Added null checks for view() and page(). Made minor code cleanups.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 2 Apr 2009 21:58:42 +0000 (21:58 +0000)]
2009-04-02  David Hyatt  <hyatt@apple.com>

        Reviewed by Oliver Hunt.

        Fix regression in <object> layout test.  Make sure that even though a 404 image loads, that <object>
        still considers it an error for the purposes of firing onerror.

        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::dispatchLoadEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 2 Apr 2009 21:58:19 +0000 (21:58 +0000)]
2009-04-02  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Adler.

        Split no-port test case into separate file, since its result may
        depend on the behavior of a DNS proxy on some systems.
        https://bugs.webkit.org/show_bug.cgi?id=21530

        * platform/mac-tiger/security/block-test-expected.txt: updated
        * platform/mac-tiger/security/block-test-no-port-expected.txt: Added.
        * platform/mac/security/block-test-expected.txt: updated
        * platform/mac/security/block-test-no-port-expected.txt: Added.
        * security/block-test-no-port.html: Added.
        * security/block-test.html: removed no-port test case

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 2 Apr 2009 21:48:16 +0000 (21:48 +0000)]
2009-04-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=25010
        Refactor InspectorController to replace all JS function invocations with
        ScriptFunctionCall.

        * bindings/js/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::appendArgument): Added int, UString,
            and JSValuePtr methods.
        (WebCore::ScriptFunctionCall::call): Added simplified, exception-eating
            method.
        * bindings/js/ScriptFunctionCall.h: Decls for above.
        * bindings/js/ScriptObjectQuarantine.cpp: Added helper for Node and DOMWindow.
        (WebCore::getQuarantinedScriptObject):
        * bindings/js/ScriptObjectQuarantine.h: Decls for above.
        * inspector/InspectorController.cpp:
        (WebCore::callSimpleFunction): Made into a static.
        (WebCore::InspectorController::focusNode): Refactored to use ScriptFunctionCall.
        (WebCore::InspectorController::toggleRecordButton): Ditto.
        (WebCore::InspectorController::startGroup): Ditto.
        (WebCore::InspectorController::setAttachedWindow): Ditto.
        (WebCore::InspectorController::inspectedWindowScriptObjectCleared): Ditto.
        (WebCore::InspectorController::addScriptProfile): Ditto.
        (WebCore::InspectorController::didParseSource): Ditto.
        (WebCore::InspectorController::failedToParseSource): Ditto.
        (WebCore::InspectorController::didPause): Ditto.
        * inspector/InspectorController.h: Removed callFunction and callSimpleFunction
            decls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Jian Li <jianli@chromium.org>
dimich@chromium.org [Thu, 2 Apr 2009 21:30:01 +0000 (21:30 +0000)]
2009-04-02  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        Upstream changes to V8WorkerContextEventListener for V8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=25007

        * bindings/v8/V8ObjectEventListener.h:
        * bindings/v8/V8WorkerContextEventListener.h:
        * bindings/v8/V8WorkerContextEventListener.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Jian Li <jianli@chromium.org>
dimich@chromium.org [Thu, 2 Apr 2009 21:29:52 +0000 (21:29 +0000)]
2009-04-02  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        Upstream V8WorkerContextObjectEventListener for V8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=25005

        * bindings/v8/V8WorkerContextObjectEventListener.cpp: Added.
        * bindings/v8/V8WorkerContextObjectEventListener.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Jian Li <jianli@chromium.org>
dimich@chromium.org [Thu, 2 Apr 2009 21:29:44 +0000 (21:29 +0000)]
2009-04-02  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        Upstream V8EventListenerList for V8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=25004

        * bindings/v8/V8EventListenerList.cpp: Added.
        * bindings/v8/V8EventListenerList.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix for Windows machines that don't have WebKitTools/Scipts in their...
aroben@apple.com [Thu, 2 Apr 2009 20:45:56 +0000 (20:45 +0000)]
    Build fix for Windows machines that don't have WebKitTools/Scipts in their PATH

        * Scripts/pdevenv: Add WebKitTools/Scripts to PATH when launching
        Visual Studio/VC++ Express.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Use pdevenv when building .vcproj files via our scripts
aroben@apple.com [Thu, 2 Apr 2009 20:31:58 +0000 (20:31 +0000)]
    Use pdevenv when building .vcproj files via our scripts

        Reviewed by Mark Rowe.

        * Scripts/webkitdirs.pm:
        (sub buildVisualStudioProject): Use pdevenv instead of invoking Visual
        Studio/VC++ Express directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix release build bustage.
hyatt@apple.com [Thu, 2 Apr 2009 20:22:26 +0000 (20:22 +0000)]
Fix release build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Michael Nordman <michaeln@google.com>
darin@chromium.org [Thu, 2 Apr 2009 20:00:15 +0000 (20:00 +0000)]
2009-04-02  Michael Nordman  <michaeln@google.com>

        Reviewed by Darin Fisher.

        Chromium's ResourceRequest and ResourceResponse structs need some new data members.
        https://bugs.webkit.org/show_bug.cgi?id=24897

        These fields are needed to facilitate Chromium's implementation of the HTML5
        ApplicationCache feature. We need to know what frame (or context) is doing the
        requesting, and from what cache the resulting resource was retrieved.

        No change in functionality, so no tests.

        * platform/network/chromium/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest):
        (WebCore::ResourceRequest::appCacheContextID):
        (WebCore::ResourceRequest::setAppCacheContextID):
        * platform/network/chromium/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        (WebCore::ResourceResponse::getAppCacheID):
        (WebCore::ResourceResponse::setAppCacheID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Thu, 2 Apr 2009 19:57:47 +0000 (19:57 +0000)]
WebCore:

2009-04-02  David Hyatt  <hyatt@apple.com>

        Reviewed by Darin Adler

        Fix for https://bugs.webkit.org/show_bug.cgi?id=24643.

        Make sure images just ignore HTTP error codes and keep loading anyway.  Only <object> checks http error codes and falls back.  Everyone
        else just ignores it and displays the image anyway.

        Added http/tests/misc/image-error.html

        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::notifyFinished):
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::CachedImage):
        * loader/CachedImage.h:
        (WebCore::CachedImage::httpStatusCodeError):
        (WebCore::CachedImage::httpStatusCodeErrorOccurred):
        * loader/CachedResource.h:
        (WebCore::CachedResource::httpStatusCodeError):
        * loader/loader.cpp:
        (WebCore::Loader::Host::didReceiveData):

LayoutTests:

2009-04-02  David Hyatt  <hyatt@apple.com>

        Reviewed by Darin Adler

        Add test for https://bugs.webkit.org/show_bug.cgi?id=24643

        * http/tests/misc/image-error-expected.txt: Added.
        * http/tests/misc/image-error.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Jian Li <jianli@chromium.org>
dimich@chromium.org [Thu, 2 Apr 2009 18:42:28 +0000 (18:42 +0000)]
2009-04-02  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add XHR constructor in WorkerContext.idl for V8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=24962

        * workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 2 Apr 2009 18:22:22 +0000 (18:22 +0000)]
2009-04-02  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Adler.

        Split long-running regexp out of the main regexp-overflow test file
        so VMs (such as V8) that don't limit execution time can still run
        the rest of the test cases.
        https://bugs.webkit.org/show_bug.cgi?id=18327

        * fast/js/regexp-overflow-expected.txt: updated
        * fast/js/regexp-overflow-too-big-expected.txt: Added.
        * fast/js/regexp-overflow-too-big.html: Added.
        * fast/js/resources/regexp-overflow-too-big.js: Added.
        * fast/js/resources/regexp-overflow.js: removed one test case

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 2 Apr 2009 18:18:40 +0000 (18:18 +0000)]
2009-04-02  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Adler.

        Minor cleanup: remove unneeded "toLower" on typeof.

        * fast/dom/Window/window-lookup-precedence.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-01 Ben Murdoch <benm@google.com>
aroben@apple.com [Thu, 2 Apr 2009 17:30:21 +0000 (17:30 +0000)]
2009-04-01  Ben Murdoch  <benm@google.com>

        Fix Bug 19743: Release build fails on 32-bit Windows

        <https://bugs.webkit.org/show_bug.cgi?id=19743>

        Combines all the HTML element cpp files into one to help reduce the
        size of WebCore.lib so we can build in release mode on 32bit Windows.

        Reviewed by Adam Roben.

        * WebCore.vcproj/WebCore.vcproj: Excluded all the separate
        HTML*Element.cpp files from the build. Added HTMLElementsAllInOne.cpp
        to the build.
        * html/HTMLElementsAllInOne.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 2 Apr 2009 16:47:38 +0000 (16:47 +0000)]
2009-04-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=24999

        Optimize hit testing with transforms.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::mapLocalToContainer):
        (WebCore::RenderBox::mapAbsoluteToLocalPoint):
        getTransformFromContainer() change to return the matrix by reference.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::update3DTransformedDescendantStatus):
        The method failed to set m_3DTransformedDescendantStatusDirty to false,
        so did the work every time.

        (WebCore::RenderLayer::createLocalTransformState):
        Only call the expensive getTransformFromContainer() if there is a transform,
        otherwise we just have a translation.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::getTransformFromContainer):
        * rendering/RenderObject.h:
        Change transformFromContainer() to getTransformFromContainer(), and return
        the matrix by reference to reduce copying.
        New enum values for arguments for readability.

        * rendering/TransformState.cpp:
        (WebCore::TransformState::move):
        (WebCore::TransformState::applyTransform):
        (WebCore::HitTestingTransformState::translate):
        New method that adds a translation to the accumulated matrix, optionally
        without flattening. Cheaper than applyTransform().

        (WebCore::HitTestingTransformState::applyTransform):
        (WebCore::HitTestingTransformState::flatten):
        (WebCore::HitTestingTransformState::flattenWithTransform):
        Add flattenWithTransform(), which is a helper that allows us to
        avoid doing the inverse() twice.

        * rendering/TransformState.h:
        (WebCore::TransformState::):
        (WebCore::TransformState::move):
        (WebCore::HitTestingTransformState::):
        New method on HitTestingTransformState that adds a translation to the
        accumulated matrix, optionally without flattening. Cheaper than applyTransform().
        New enum values for arguments for readability.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-02 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 2 Apr 2009 16:35:15 +0000 (16:35 +0000)]
2009-04-02  Darin Adler  <darin@apple.com>

        Reviewed by Kevin Decker.

        <rdar://problem/6744471> crash in GC due to uninitialized callFunction pointer

        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Initialize
        callFunction as we do the other data members that are used in the mark function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42173 268f45cc-cd09-0410-ab3c-d52691b4dbfc