WebKit-https.git
10 years agoVersioning.
mrowe@apple.com [Thu, 17 Dec 2009 22:10:30 +0000 (22:10 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Marc-Antoine Ruel <maruel@chromium.org>
eric@webkit.org [Thu, 17 Dec 2009 21:52:14 +0000 (21:52 +0000)]
2009-12-17  Marc-Antoine Ruel  <maruel@chromium.org>

        Reviewed by Eric Seidel.

        Fix link failure on LTCG builds on Windows for chromium port.

        Reenable SVGAllInOne.cpp. This required some fixups.

        Namely, there was conflicts in constants between HTMLNames and
        SVGNames, and conflicts between static functions names.

        No new tests as functionality has not changed.

        * WebCore.gyp/WebCore.gyp:
        * svg/SVGAllInOne.cpp:
        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::rebuildFontFace):
        * svg/SVGGlyphElement.cpp:
        (WebCore::SVGGlyphElement::invalidateGlyphCache):
        (WebCore::SVGGlyphElement::buildGlyphIdentifier):
        * svg/SVGHKernElement.cpp:
        (WebCore::SVGHKernElement::insertedIntoDocument):
        (WebCore::SVGHKernElement::removedFromDocument):
        * svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::type):
        (WebCore::SVGStyleElement::setType):
        (WebCore::SVGStyleElement::media):
        (WebCore::SVGStyleElement::setMedia):
        (WebCore::SVGStyleElement::title):
        (WebCore::SVGStyleElement::setTitle):
        (WebCore::SVGStyleElement::parseMappedAttribute):
        * svg/SVGStyledElement.cpp:
        (WebCore::mapAttributeToCSSProperty):
        (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
        * svg/SVGStyledElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix VI
aroben@apple.com [Thu, 17 Dec 2009 21:38:53 +0000 (21:38 +0000)]
Chromium build fix VI

* svg/animation/SMILTimeContainer.h: Added now-needed #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix V
aroben@apple.com [Thu, 17 Dec 2009 21:37:32 +0000 (21:37 +0000)]
Chromium build fix V

* platform/KURLGoogle.cpp: Added now-needed #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix IV
aroben@apple.com [Thu, 17 Dec 2009 21:29:36 +0000 (21:29 +0000)]
Chromium build fix IV

* loader/CrossOriginPreflightResultCache.h: Added now-needed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Thu, 17 Dec 2009 21:26:02 +0000 (21:26 +0000)]
2009-12-17  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Eric Seidel.

        Added the key WebKitEnableCaretBrowsing to the
        layoutTestController.overridePreference in order to activate caret
        browsing.
        https://bugs.webkit.org/show_bug.cgi?id=32612

        * DumpRenderTree/gtk/DumpRenderTree.cpp: Added the reset value of
        the setting.
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Inserted the new
        key in the keytable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix III
aroben@apple.com [Thu, 17 Dec 2009 21:19:24 +0000 (21:19 +0000)]
Chromium build fix III

* platform/graphics/Font.h: Added now-needed #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix II
aroben@apple.com [Thu, 17 Dec 2009 21:10:20 +0000 (21:10 +0000)]
Chromium build fix II

* dom/EventTarget.h: Added now-needed #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Zoltan Horvath <zoltan@webkit.org>
eric@webkit.org [Thu, 17 Dec 2009 21:09:37 +0000 (21:09 +0000)]
2009-12-17  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Eric Seidel.

        Allow custom memory allocation control for js bindings
        https://bugs.webkit.org/show_bug.cgi?id=32655

        Inherits the following classes from Noncopyable because these are instantiated
        by 'new' and no need to be copyable:

        class name                  - instantiated at:  WebCore/'location'

        class ScriptCachedFrameData - history/CachedFrame.cpp:117
        class WebCoreJSClientData   - bindings/js/JSDOMWindowBase.cpp:162
        class ScheduledAction       - bindings/js/ScheduledAction.cpp:58

        * bindings/js/JSDOMBinding.h:
        * bindings/js/ScheduledAction.h:
        * bindings/js/ScriptCachedFrameData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix
aroben@apple.com [Thu, 17 Dec 2009 20:56:58 +0000 (20:56 +0000)]
Chromium build fix

* dom/QualifiedName.h: Added now-needed #include of HashTraits.h
(which itself #includes HashFunctions.h).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
eric@webkit.org [Thu, 17 Dec 2009 20:53:12 +0000 (20:53 +0000)]
2009-12-17  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: Incorrect Doctype.

        REGRESSION(4.0.4-TOT):Web Inspector: Incorrect Doctype
        https://bugs.webkit.org/show_bug.cgi?id=32671

        * inspector/elements-panel-structure-expected.txt:
        * inspector/elements-panel-structure.html:
2009-12-17  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: Incorrect Doctype.

        REGRESSION(4.0.4-TOT):Web Inspector: Incorrect Doctype
        https://bugs.webkit.org/show_bug.cgi?id=32671

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForNode):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't include all JSC headers everywhere
aroben@apple.com [Thu, 17 Dec 2009 20:38:57 +0000 (20:38 +0000)]
Don't include all JSC headers everywhere

https://bugs.webkit.org/show_bug.cgi?id=32663

Patch by Benjamin Otte <otte@gnome.org> on 2009-12-17
Reviewed by Adam Roben.

Remove HashMap HashSet and OwnPtr includes from PlatformString.h.
Reduces code size of Gtk build by another 5%.

* platform/text/PlatformString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac build fix
aroben@apple.com [Thu, 17 Dec 2009 20:32:45 +0000 (20:32 +0000)]
Mac build fix

* WebView/WebVideoFullscreenController.mm: Added now-needed #import.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac/Qt build fixes
aroben@apple.com [Thu, 17 Dec 2009 20:22:52 +0000 (20:22 +0000)]
Mac/Qt build fixes

* platform/graphics/mac/Canvas3DLayer.mm:
* platform/graphics/mac/GraphicsContext3DMac.cpp:
* platform/qt/Localizations.cpp:
Added missing #includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't include all JSC headers everywhere
aroben@apple.com [Thu, 17 Dec 2009 20:00:50 +0000 (20:00 +0000)]
Don't include all JSC headers everywhere

https://bugs.webkit.org/show_bug.cgi?id=32663

Patch by Benjamin Otte <otte@gnome.org> on 2009-12-17
Reviewed by Adam Roben.

WebCore:

PlatformString.h included almost all of JSC via runtime/Identifier.h.
This patch gets rid of this include by forward-declaring the required
classes instead.
This reduces the build size of the object files on a Gtk debug build
by 10%. The resulting libwebkit.so gets 5% smaller.

No new tests as it's just a build improvement.

* platform/gtk/LocalizedStringsGtk.cpp:
include math.h here (it used to be pulled by JSC)
* platform/text/PlatformString.h:
* platform/text/String.cpp:

WebKit/win:

* WebCoreLocalizedStrings.cpp: Added now-needed #include of
MathExtras.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Evan Martin <evan@chromium.org>
eric@webkit.org [Thu, 17 Dec 2009 19:59:43 +0000 (19:59 +0000)]
2009-12-17  Evan Martin  <evan@chromium.org>

        Reviewed by Xan Lopez.

        Always use all WebCore include paths in GtkWebKit.

        With this patch, I can disable all optional features and still build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed layout test fix.
cfleizach@apple.com [Thu, 17 Dec 2009 19:58:13 +0000 (19:58 +0000)]
Unreviewed layout test fix.

WAI-ARIA: implement treegrid
https://bugs.webkit.org/show_bug.cgi?id=31299

The test for this patch shouldn't be run on Tiger.

* platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: DRT needs to support URL for accessibility
cfleizach@apple.com [Thu, 17 Dec 2009 19:48:00 +0000 (19:48 +0000)]
AX: DRT needs to support URL for accessibility
https://bugs.webkit.org/show_bug.cgi?id=32666

Reviewed by David Kilzer.

* DumpRenderTree/AccessibilityUIElement.cpp:
(getURLCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::url):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::url):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::url):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed; added myself to committers
philn@webkit.org [Thu, 17 Dec 2009 19:36:07 +0000 (19:36 +0000)]
    Unreviewed; added myself to committers

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 17 Dec 2009 19:23:19 +0000 (19:23 +0000)]
2009-12-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        More make distcheck fixes. Use a more robust solution to making
        sure we are in the correct directory for running these tests.

        * tests/testmimehandling.c:
        (main):
        * tests/testwebview.c:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; added myself to committers
otte@webkit.org [Thu, 17 Dec 2009 19:21:18 +0000 (19:21 +0000)]
Unreviewed; added myself to committers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Yaar Schnitman <yaar@chromium.org>
yaar@google.com [Thu, 17 Dec 2009 19:18:40 +0000 (19:18 +0000)]
2009-12-17  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Darin Fisher.

        Added WebPageSerializer to WebKit API and enriched the WebNode hierarchy to support
        downstream unit-testing of serialization.

        WebPageSerializer was adapted from Chromium's dom_serializer, originally authored by Johnny Ding.

        https://bugs.webkit.org/show_bug.cgi?id=31737

        * WebKit.gyp:
        * public/WebDocument.h: Added.
        (WebKit::WebDocument::WebDocument):
        (WebKit::WebDocument::operator=):
        (WebKit::WebDocument::assign):
        * public/WebElement.h:
        * public/WebFormElement.h:
        (WebKit::WebFormElement::operator=):
        * public/WebFrame.h:
        * public/WebNode.h:
        (WebKit::WebNode::):
        (WebKit::WebNode::toConstElement):
        * public/WebNodeCollection.h: Added.
        (WebKit::WebNodeCollection::~WebNodeCollection):
        (WebKit::WebNodeCollection::WebNodeCollection):
        (WebKit::WebNodeCollection::operator=):
        * public/WebNodeList.h: Added.
        (WebKit::WebNodeList::~WebNodeList):
        (WebKit::WebNodeList::WebNodeList):
        (WebKit::WebNodeList::operator=):
        * public/WebPageSerializer.h: Added.
        * public/WebPageSerializerClient.h: Added.
        (WebKit::WebPageSerializerClient::):
        (WebKit::WebPageSerializerClient::WebPageSerializerClient):
        (WebKit::WebPageSerializerClient::~WebPageSerializerClient):
        * public/WebString.h:
        * public/WebView.h:
        * src/AssertMatchingEnums.cpp:
        * src/DOMUtilitiesPrivate.cpp:
        (WebKit::elementHasLegalLinkAttribute):
        * src/DOMUtilitiesPrivate.h:
        * src/WebDocument.cpp: Added.
        (WebKit::WebDocument::WebDocument):
        (WebKit::WebDocument::operator=):
        (WebKit::WebDocument::operator WTF::PassRefPtr<Document>):
        (WebKit::WebDocument::frame):
        (WebKit::WebDocument::isHTMLDocument):
        (WebKit::WebDocument::baseURL):
        (WebKit::WebDocument::body):
        (WebKit::WebDocument::head):
        (WebKit::WebDocument::all):
        (WebKit::WebDocument::completeURL):
        * src/WebElement.cpp:
        (WebKit::WebElement::hasTagName):
        (WebKit::WebElement::hasAttribute):
        (WebKit::WebElement::getAttribute):
        * src/WebEntities.cpp: Added.
        (WebKit::populateMap):
        (WebKit::):
        (WebKit::WebEntities::WebEntities):
        (WebKit::WebEntities::entityNameByCode):
        (WebKit::WebEntities::convertEntitiesInString):
        * src/WebEntities.h: Added.
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrame::fromFrameOwnerElement):
        (WebKit::WebFrameImpl::encoding):
        (WebKit::WebFrameImpl::document):
        (WebKit::WebFrameImpl::fromFrameOwnerElement):
        * src/WebFrameImpl.h:
        * src/WebNode.cpp:
        (WebKit::WebNode::nodeType):
        (WebKit::WebNode::nodeValue):
        (WebKit::WebNode::document):
        (WebKit::WebNode::firstChild):
        (WebKit::WebNode::lastChild):
        (WebKit::WebNode::previousSibling):
        (WebKit::WebNode::nextSibling):
        (WebKit::WebNode::hasChildNodes):
        (WebKit::WebNode::childNodes):
        (WebKit::WebNode::createMarkup):
        (WebKit::WebNode::isTextNode):
        (WebKit::WebNode::isElementNode):
        * src/WebNodeCollection.cpp: Added.
        (WebKit::WebNodeCollection::reset):
        (WebKit::WebNodeCollection::assign):
        (WebKit::WebNodeCollection::WebNodeCollection):
        (WebKit::WebNodeCollection::length):
        (WebKit::WebNodeCollection::nextItem):
        (WebKit::WebNodeCollection::firstItem):
        * src/WebNodeList.cpp: Added.
        (WebKit::WebNodeList::reset):
        (WebKit::WebNodeList::assign):
        (WebKit::WebNodeList::WebNodeList):
        (WebKit::WebNodeList::length):
        (WebKit::WebNodeList::item):
        * src/WebPageSerializer.cpp: Added.
        (WebKit::WebPageSerializer::serialize):
        (WebKit::WebPageSerializer::generateMetaCharsetDeclaration):
        (WebKit::WebPageSerializer::generateMarkOfTheWebDeclaration):
        (WebKit::WebPageSerializer::generateBaseTagDeclaration):
        * src/WebPageSerializerImpl.cpp: Added.
        (WebKit::WebPageSerializerImpl::SerializeDomParam::SerializeDomParam):
        (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
        (WebKit::WebPageSerializerImpl::postActionAfterSerializeOpenTag):
        (WebKit::WebPageSerializerImpl::preActionBeforeSerializeEndTag):
        (WebKit::WebPageSerializerImpl::postActionAfterSerializeEndTag):
        (WebKit::WebPageSerializerImpl::saveHTMLContentToBuffer):
        (WebKit::WebPageSerializerImpl::openTagToString):
        (WebKit::WebPageSerializerImpl::endTagToString):
        (WebKit::WebPageSerializerImpl::buildContentForNode):
        (WebKit::WebPageSerializerImpl::WebPageSerializerImpl):
        (WebKit::WebPageSerializerImpl::collectTargetFrames):
        (WebKit::WebPageSerializerImpl::serialize):
        * src/WebPageSerializerImpl.h: Added.
        * src/WebString.cpp:
        (WebKit::WebString::WebString):
        (WebKit::WebString::operator=):
        * src/WebViewImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Thu, 17 Dec 2009 19:14:33 +0000 (19:14 +0000)]
2009-12-17  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Don't assume downloads are always synchronous
        http://bugs.webkit.org/show_bug.cgi?id=32359

        * tests/testdownload.c:
        (download_requested_cb):
        (set_filename):
        (test_webkit_download_perform):
        (test_webkit_download_synch):
        (test_webkit_download_asynch):
        (main): Test downloads synchronously and asynchronously.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_class_init):
        (webkit_web_view_request_download): Only try to start a requested
        download if the destination URI is set and clarify the documentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMerge branch 'bug/26304' into staging
philn@webkit.org [Thu, 17 Dec 2009 19:13:42 +0000 (19:13 +0000)]
Merge branch 'bug/26304' into staging

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSync JavaScriptCore.vcproj with JavaScriptCore.xcodeproj and the source tree
aroben@apple.com [Thu, 17 Dec 2009 19:12:38 +0000 (19:12 +0000)]
Sync JavaScriptCore.vcproj with JavaScriptCore.xcodeproj and the source tree

Fixes <http://webkit.org/b/32665>.

Reviewed by Ada Chan.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Moved
around files and filters so that the structure matches
JavaScriptCore.xcodeproj and the source tree. A few headers that were
previously omitted have been added, as well as JSZombie.{cpp,h}.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove HeavyProfile and TreeProfile completely
aroben@apple.com [Thu, 17 Dec 2009 19:12:26 +0000 (19:12 +0000)]
Remove HeavyProfile and TreeProfile completely

These were mostly removed in r42808, but the empty files were left in
place.

Fixes <http://webkit.org/b/32664>.

Reviewed by John Sullivan.

* Android.mk:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCoreSources.bkl:
Removed HeavyProfile/TreeProfile source files.

* profiler/HeavyProfile.cpp: Removed.
* profiler/HeavyProfile.h: Removed.
* profiler/TreeProfile.cpp: Removed.
* profiler/TreeProfile.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove WebKit.sln's Debug_All and Debug_Internal configurations
aroben@apple.com [Thu, 17 Dec 2009 19:12:03 +0000 (19:12 +0000)]
Remove WebKit.sln's Debug_All and Debug_Internal configurations

These configurations aren't buildable by people outside of Apple, and
Apple doesn't use this solution file.

Fixes <http://webkit.org/b/31000> Windows WebKit Build Configuration
should default to Debug instead of Debug_all.

Rubber-stamped by Dan Bernstein.

* WebKit.vcproj/WebKit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Thu, 17 Dec 2009 19:09:33 +0000 (19:09 +0000)]
2009-12-17  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Xan Lopez.

        Deprecate the title-changed signal of WebKitWebFrame.

        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Thu, 17 Dec 2009 18:39:42 +0000 (18:39 +0000)]
2009-12-17  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] support navigator.onLine and ononline/onoffline events.
        https://bugs.webkit.org/show_bug.cgi?id=32555

        Hooked up Bearer Management to NetworkStateNotifier. This solution is available
        only if QtMobility's Bearer Management is installed.

        * WebCore.pro:
        * platform/network/NetworkStateNotifier.h:
        * platform/network/qt/NetworkStateNotifierPrivate.h: Added.
        * platform/network/qt/NetworkStateNotifierQt.cpp: Added.
        (WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate):
        (WebCore::NetworkStateNotifierPrivate::onlineStateChanged):
        (WebCore::NetworkStateNotifierPrivate::~NetworkStateNotifierPrivate):
        (WebCore::NetworkStateNotifier::updateState):
        (WebCore::NetworkStateNotifier::NetworkStateNotifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 17 Dec 2009 18:25:38 +0000 (18:25 +0000)]
2009-12-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Switch to 11px as default for source-code in WebKit.

        https://bugs.webkit.org/show_bug.cgi?id=32646

        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Symbian build fix: Don't include QtXml/qxmlstream.h but omit the prefix, to
hausmann@webkit.org [Thu, 17 Dec 2009 17:57:17 +0000 (17:57 +0000)]
[Qt] Symbian build fix: Don't include QtXml/qxmlstream.h but omit the prefix, to
make sure we pick up the header file from QtCore. That is where the implementation
is compiled.

Reviewed by Tor Arne Vestbø.

* dom/XMLTokenizer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Thu, 17 Dec 2009 17:44:11 +0000 (17:44 +0000)]
2009-12-17  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
        https://bugs.webkit.org/show_bug.cgi?id=21599

        Implement GRefPtr, a smart pointer for reference counted GObject types.

        * GNUmakefile.am:
        * wtf/gtk/GOwnPtr.cpp:
        (WTF::GDir):
        * wtf/gtk/GRefPtr.h: Added.
        (WTF::):
        (WTF::GRefPtr::GRefPtr):
        (WTF::GRefPtr::~GRefPtr):
        (WTF::GRefPtr::clear):
        (WTF::GRefPtr::get):
        (WTF::GRefPtr::operator*):
        (WTF::GRefPtr::operator->):
        (WTF::GRefPtr::operator!):
        (WTF::GRefPtr::operator UnspecifiedBoolType):
        (WTF::GRefPtr::hashTableDeletedValue):
        (WTF::::operator):
        (WTF::::swap):
        (WTF::swap):
        (WTF::operator==):
        (WTF::operator!=):
        (WTF::static_pointer_cast):
        (WTF::const_pointer_cast):
        (WTF::getPtr):
        (WTF::adoptGRef):
        (WTF::refGPtr):
        (WTF::derefGPtr):
2009-12-17  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
        https://bugs.webkit.org/show_bug.cgi?id=21599

        Add GRefPtr support for GTK types to WebCore, as JSC does not link against
        GTK+. Also convert PopupMenu::m_poup from a raw pointer to a GRefPtr.

        No new tests as functionality has not changed.

        * GNUmakefile.am:
        * platform/PopupMenu.h:
        * platform/gtk/GRefPtrGtk.cpp: Added.
        (WTF::refGPtr):
        (WTF::derefGPtr):
        * platform/gtk/GRefPtrGtk.h: Added.
        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenu::PopupMenu):
        (WebCore::PopupMenu::~PopupMenu):
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::hide):
        (WebCore::PopupMenu::menuRemoveItem):
2009-12-17  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
        https://bugs.webkit.org/show_bug.cgi?id=21599

        Convert a use of GOwnPtr for a reference counted type to GRefPtr.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Thu, 17 Dec 2009 17:21:40 +0000 (17:21 +0000)]
2009-12-17  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Add support for mocking touch events with Q(GV)Launcher
        https://bugs.webkit.org/show_bug.cgi?id=32434

        The event delivery should go through QCoreApplication::sendEvent()

        * QtLauncher/main.cpp:
        (MainWindow::sendTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Kim Grönholm <kim.gronholm@nomovok.com>
eric@webkit.org [Thu, 17 Dec 2009 17:09:23 +0000 (17:09 +0000)]
2009-12-17  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Simon Hausmann.

        [Qt] Add support for touch events in QWebView and QGraphicsWebView
        https://bugs.webkit.org/show_bug.cgi?id=32432

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebView::QGraphicsWebView):
        (QGraphicsWebView::sceneEvent):
        * Api/qwebview.cpp:
        (QWebView::QWebView):
        (QWebView::event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 17 Dec 2009 17:06:01 +0000 (17:06 +0000)]
2009-12-17  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by David Levin.

        Provide explicit implementation of 'non-template' WebVector<T>::operator=

        https://bugs.webkit.org/show_bug.cgi?id=32363

        * public/WebVector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Evan Martin <evan@chromium.org>
eric@webkit.org [Thu, 17 Dec 2009 15:56:47 +0000 (15:56 +0000)]
2009-12-17  Evan Martin  <evan@chromium.org>

        Reviewed by Xan Lopez.

        Expose the page workarounds ("quirks") setting to the GTK+ WebKit API.

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Thu, 17 Dec 2009 15:34:33 +0000 (15:34 +0000)]
2009-12-17  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Advice links to source code in CPU profiler to open in debugger,
        not in resources tab.

        Also work around the case when resources are disabled, but scripts are present.

        https://bugs.webkit.org/show_bug.cgi?id=32610

        * inspector/front-end/Panel.js:
        (WebInspector.Panel.prototype.updateMainViewWidth):
        (WebInspector.Panel.prototype.canShowSourceLineForURL):
        (WebInspector.Panel.prototype.showSourceLineForURL):
        * inspector/front-end/ProfileDataGridTree.js:
        (WebInspector.ProfileDataGridNode.prototype.createCell):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.canShowSourceLineForURL):
        (WebInspector.ResourcesPanel.prototype.showSourceLineForURL):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.scriptForURL):
        (WebInspector.ScriptsPanel.prototype.canShowSourceLineForURL):
        (WebInspector.ScriptsPanel.prototype.showSourceLineForURL):
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        * inspector/front-end/inspector.js:
        (WebInspector.documentClick.followLink):
        (WebInspector.documentClick):
        (WebInspector._choosePanelToShowSourceLineForURL):
        (WebInspector.canShowSourceLineForURL):
        (WebInspector.showSourceLineForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkipping one test that needs overriding of standard preferences,
kov@webkit.org [Thu, 17 Dec 2009 14:42:40 +0000 (14:42 +0000)]
Skipping one test that needs overriding of standard preferences,
and a new one.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Xan Lopez.
philn@webkit.org [Thu, 17 Dec 2009 14:27:00 +0000 (14:27 +0000)]
    Reviewed by Xan Lopez.

        [GTK] display FPS stats for video element
        https://bugs.webkit.org/show_bug.cgi?id=32560

        Display FPS statistics if WEBKIT_DEBUG environment variable
        contains the Media log category. This feature requires a very
        recent (>= 0.10.18) version of gst-plugins-bad.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::createGSTPlayBin):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Kim Grönholm <kim.gronholm@nomovok.com>
eric@webkit.org [Thu, 17 Dec 2009 14:01:48 +0000 (14:01 +0000)]
2009-12-17  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Simon Hausmann.

        [Qt] Add support for mocking touch events with QtLauncher
        https://bugs.webkit.org/show_bug.cgi?id=32434

        * QtLauncher/main.cpp:
        (MainWindow::MainWindow):
        (MainWindow::sendTouchEvent):
        (MainWindow::eventFilter):
        (MainWindow::setTouchMocking):
        (MainWindow::setupUI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReverting 52246 and 52248 because they crash tests.
kov@webkit.org [Thu, 17 Dec 2009 13:05:40 +0000 (13:05 +0000)]
Reverting 52246 and 52248 because they crash tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Landing files I forgot to commit.
kov@webkit.org [Thu, 17 Dec 2009 12:30:37 +0000 (12:30 +0000)]
Build fix. Landing files I forgot to commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 17 Dec 2009 12:13:04 +0000 (12:13 +0000)]
2009-12-16  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] segfault during volume notification
        https://bugs.webkit.org/show_bug.cgi?id=32603

        Emit volumeChanged and durationChanged upon notification from
        GStreamer. Also don't reset the volume property on playbin, it is
        not needed as it is 1.0 by default both on playbin and in the
        MediaPlayer.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateMessageCallback):
        (WebCore::mediaPlayerPrivateVolumeChangedCallback):
        (WebCore::notifyVolumeIdleCallback):
        (WebCore::doGstInit):
        (WebCore::MediaPlayerPrivate::isAvailable):
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::volumeChanged):
        (WebCore::MediaPlayerPrivate::didEnd):
        (WebCore::MediaPlayerPrivate::durationChanged):
        (WebCore::mimeTypeCache):
        (WebCore::MediaPlayerPrivate::createGSTPlayBin):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

2009-11-11  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] Should emit {networkState,readyState,volume,time,size,rate,duration}Changed signals
        https://bugs.webkit.org/show_bug.cgi?id=30377

        Emit volumeChanged and durationChanged upon notification from
        GStreamer.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateMessageCallback):
        (WebCore::mediaPlayerPrivateVolumeCallback):
        (WebCore::notify_volume_idle_cb):
        (WebCore::MediaPlayerPrivate::didEnd):
        (WebCore::MediaPlayerPrivate::durationChanged):
        (WebCore::MediaPlayerPrivate::createGSTPlayBin):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore
kov@webkit.org [Thu, 17 Dec 2009 12:02:21 +0000 (12:02 +0000)]
WebCore

2009-12-17  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
        https://bugs.webkit.org/show_bug.cgi?id=21599

        Add GRefPtr support for GTK types to WebCore, as JSC does not link against
        GTK+. Also convert PopupMenu::m_poup from a raw pointer to a GRefPtr.

        No new tests as functionality has not changed.

        * GNUmakefile.am:
        * platform/PopupMenu.h:
        * platform/gtk/GRefPtrGtk.cpp: Added.
        (WTF::refGPtr):
        (WTF::derefGPtr):
        * platform/gtk/GRefPtrGtk.h: Added.
        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenu::PopupMenu):
        (WebCore::PopupMenu::~PopupMenu):
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::hide):
        (WebCore::PopupMenu::menuRemoveItem):

JavaScriptCore

2009-12-17  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
        https://bugs.webkit.org/show_bug.cgi?id=21599

        Implement GRefPtr, a smart pointer for reference counted GObject types.

        * GNUmakefile.am:
        * wtf/gtk/GOwnPtr.cpp:
        (WTF::GDir):
        * wtf/gtk/GRefPtr.h: Added.
        (WTF::):
        (WTF::GRefPtr::GRefPtr):
        (WTF::GRefPtr::~GRefPtr):
        (WTF::GRefPtr::clear):
        (WTF::GRefPtr::get):
        (WTF::GRefPtr::operator*):
        (WTF::GRefPtr::operator->):
        (WTF::GRefPtr::operator!):
        (WTF::GRefPtr::operator UnspecifiedBoolType):
        (WTF::GRefPtr::hashTableDeletedValue):
        (WTF::::operator):
        (WTF::::swap):
        (WTF::swap):
        (WTF::operator==):
        (WTF::operator!=):
        (WTF::static_pointer_cast):
        (WTF::const_pointer_cast):
        (WTF::getPtr):
        (WTF::adoptGRef):
        (WTF::refGPtr):
        (WTF::derefGPtr):

WebKit/gtk

2009-12-17  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
        https://bugs.webkit.org/show_bug.cgi?id=21599

        Convert a use of GOwnPtr for a reference counted type to GRefPtr.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Evan Martin <evan@chromium.org>
eric@webkit.org [Thu, 17 Dec 2009 11:48:53 +0000 (11:48 +0000)]
2009-12-17  Evan Martin  <evan@chromium.org>

        Reviewed by Xan Lopez.

        gtk: always use standard include paths, regardless of settings.
        WebKit style is to wrap the body of a header in #if ENABLE(FOO),
        so they're always safe to include whether the features are enabled or
        not.

        This fixes building with --disable-database and other flags.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Build fixes for make distcheck.
kov@webkit.org [Thu, 17 Dec 2009 11:33:55 +0000 (11:33 +0000)]
Unreviewed. Build fixes for make distcheck.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Rubber-stamped by Gustavo Noronha Silva.
philn@webkit.org [Thu, 17 Dec 2009 11:14:08 +0000 (11:14 +0000)]
    Rubber-stamped by Gustavo Noronha Silva.

        Trivial WebKit coding style fix.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 17 Dec 2009 08:27:25 +0000 (08:27 +0000)]
2009-12-17  Adam Barth  <abarth@webkit.org>

        Rubber stamp by Seidel.

        Clean up exception handling in WorkQueue.  Basically, a bunch of the
        delegate messages can throw exceptions because of network errors.  We
        want the queues to keep on ticking instead of erroring out.  That means
        we want to catch generic exceptions and continue looping.

        Also, cleaned up the exception handling in the EWS to properly log
        failures.

        * Scripts/modules/commands/early_warning_system.py:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/workqueue.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 17 Dec 2009 07:52:52 +0000 (07:52 +0000)]
2009-12-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Make UpdateStep quiet
        https://bugs.webkit.org/show_bug.cgi?id=32599

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/buildsteps_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Evan Martin <evan@chromium.org>
abarth@webkit.org [Thu, 17 Dec 2009 07:41:11 +0000 (07:41 +0000)]
2009-12-16  Evan Martin  <evan@chromium.org>

        Reviewed by Adam Barth.

        Add Gtk to the early warning system WebKit port list.

        https://bugs.webkit.org/show_bug.cgi?id=32629

        * Scripts/modules/commands/early_warning_system.py:
        * Scripts/modules/webkitport.py:
        * Scripts/modules/webkitport_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Thu, 17 Dec 2009 07:40:27 +0000 (07:40 +0000)]
2009-12-16  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        post-diff is failing with exception under guess_reviewer_from_bug
        https://bugs.webkit.org/show_bug.cgi?id=32642

        Also refactor output capturing code into
        OutputCapture.assert_outputs to share more code between tests.

        * Scripts/modules/buildsteps.py:
         - Add the missing include.
         - Give guess_reviewer_from_bug a private underscore.
        * Scripts/modules/buildsteps_unittest.py: Added.
         - Test to make sure _guess_reviewer_from_bug works as expected.
        * Scripts/modules/commands/commandtest.py:
         - Custom code is now obsoleted by OutputCapture.assert_outputs
        * Scripts/modules/commands/queues_unittest.py:
         - ditto
        * Scripts/modules/credentials_unittest.py:
         - ditto
        * Scripts/modules/mock_bugzillatool.py:
         - fetch_reviewed_patches_from_bug can never return None
        * Scripts/modules/multicommandtool_unittest.py:
         - Custom code is now obsoleted by OutputCapture.assert_outputs
        * Scripts/modules/outputcapture.py:
         - Add assert_outputs to share more code between tests.
        * Scripts/run-webkit-unittests:
         - Add buildsteps_unittest.py

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 17 Dec 2009 07:37:09 +0000 (07:37 +0000)]
2009-12-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Added a default argument to _update_status so that callers
        don't have to explictly pass None when they don't have a patch object.

        * Scripts/modules/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, build fix.
ukai@chromium.org [Thu, 17 Dec 2009 07:17:55 +0000 (07:17 +0000)]
Unreviewed, build fix.

[Chromium] Add EditableTextRole to catch up with
http://trac.webkit.org/changeset/52233

* public/WebAccessibilityRole.h:
(WebKit::): Added WebAccessibilityRoleEditableText
* src/AssertMatchingEnums.cpp: Added matching compile assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Put test into skiplist because of missing layoutTestController.setSmartInsertDel...
ossy@webkit.org [Thu, 17 Dec 2009 07:05:26 +0000 (07:05 +0000)]
[Qt] Put test into skiplist because of missing layoutTestController.setSmartInsertDeleteEnabled().

* platform/qt/Skipped: editing/selection/doubleclick-beside-cr-span.html added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 MORITA Hajime <morrita@gmail.com>
hamaji@chromium.org [Thu, 17 Dec 2009 06:30:20 +0000 (06:30 +0000)]
2009-12-15 MORITA Hajime <morrita@gmail.com>

        Reviewed by Eric Seidel.

        Bug 28306: double-clicking a word inside <b> beside newline select two words
        https://bugs.webkit.org/show_bug.cgi?id=28306

        SimplifiedBackwardsTextIterator missed trailing whitespaces just
        before folding line-break, which is used to detect word
        boundaries. This fix checks strings on RenderText and expand text
        range on SimplifiedBackwardsTextIterator to include trailing
        whitespaces if availble.

        Test: editing/selection/doubleclick-beside-cr-span.html

        * editing/TextIterator.cpp:
        (WebCore::collapsedSpaceLength):
        (WebCore::maxOffsetIncludingCollapsedSpaces):
        (WebCore::SimplifiedBackwardsTextIterator::advance):
2009-12-16  MORITA Hajime <morrita@gmail.com>

        Reviewed by Eric Seidel.

        Bug 28306: double-clicking a word inside <b> beside newline select two words
        https://bugs.webkit.org/show_bug.cgi?id=28306

        SimplifiedBackwardsTextIterator missed trailing whitespaces just
        before folding line-break, which is used to detect word
        boundaries. This fix checks strings on RenderText and expand text
        range on SimplifiedBackwardsTextIterator to include trailing
        whitespaces if availble.

        * editing/selection/doubleclick-beside-cr-span-expected.txt: Added.
        * editing/selection/doubleclick-beside-cr-span.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 17 Dec 2009 06:19:05 +0000 (06:19 +0000)]
2009-12-16  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix flakiness in WebSocket handshake console message.
        https://bugs.webkit.org/show_bug.cgi?id=32598

        In chromium, LayoutTests/websocket/tests/handshake-error.html is
        flaky, because it outputs the following console message several times:
          CONSOLE MESSAGE: line 0: Unexpected response code:101
        Update m_mode in WebSocketHandshake correctly: Once it finds
        error in handshake message, set m_mode to Failed and don't try
        reading handshake message again.  If handshake message is not yet
        fully received, set m_mode to Incomplete, so next didReceiveData()
        will try to check handshake message again.

        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::didReceiveData):
        * websockets/WebSocketHandshake.cpp:
        (WebCore::WebSocketHandshake::readServerHandshake):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 17 Dec 2009 05:58:00 +0000 (05:58 +0000)]
2009-12-16  Jon Honeycutt  <jhoneycutt@apple.com>

        MSAA: Accessibility role of text nodes is wrong

        https://bugs.webkit.org/show_bug.cgi?id=32631
        <rdar://problem/7369084>

        Reviewed by Alice Liu.

        Test: platform/win/accessibility/text-role.html

        WebCore/:
        * accessibility/AccessibilityObject.h:
        (WebCore::):
        Add a new role to the enum.
        (WebCore::AccessibilityObject::roleValueForMSAA):
        Declare a function to return the accessibility role for MSAA; the base
        implementation returns the old role value.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
        Initialize m_roleForMSAA.
        (WebCore::AccessibilityRenderObject::roleValueForMSAA):
        If m_roleForMSAA has been set, return it. If the renderer is a
        RenderText, set the role to EditableTextRole to match IE and Firefox.
        Otherwise, set the role for MSAA to the old role value.

        * accessibility/AccessibilityRenderObject.h:
        Add a member to hold the role for MSAA, and declare an override of
        roleValueForMSAA().

        WebKit/win/:
        * AccessibleBase.cpp:
        (MSAARole):
        If the role is WebCore::EditableTextRole, return ROLE_SYSTEM_TEXT.
        (AccessibleBase::role):
        Call roleValueForMSAA().

        LayoutTests/:
        * platform/win/accessibility/text-role-expected.txt: Added.
        * platform/win/accessibility/text-role.html: Added.
        Check that the role of the text node that is the first child of the
        <a> tag has the "editable text" role.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 17 Dec 2009 05:30:45 +0000 (05:30 +0000)]
2009-12-16  Kent Tamura  <tkent@chromium.org>

        Reviewed by David Levin.

        check-webkit-style supports for TAB check against text files.
        https://bugs.webkit.org/show_bug.cgi?id=32538

        * Scripts/check-webkit-style:
          Move process_patch() to style.py.
        * Scripts/modules/cpp_style.py:
          Add can_handle().
        * Scripts/modules/cpp_style_unittest.py:
          Add tests for can_handle().
        * Scripts/modules/style.py:
          Added. This is a front-end of cpp_style and text_style. It dispatches
          files to an appropriate linter.
        * Scripts/modules/text_style.py:
          Added. This is a linter module for generic text files. It supports
          only for TAB checking at this moment.
        * Scripts/modules/text_style_unittest.py:
          Added. Tests for text_style.py.
        * Scripts/run-webkit-unittests:
          Add text_style_unittest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed <rdar://problem/7355025> Interpreter::privateExecute macro generates
ggaren@apple.com [Thu, 17 Dec 2009 03:50:37 +0000 (03:50 +0000)]
Fixed <rdar://problem/7355025> Interpreter::privateExecute macro generates
bloated code

Reviewed by Oliver Hunt.

This patch cuts Interpreter stack use by about a third.

* bytecode/Opcode.h: Changed Opcode to const void* to work with the
const static initiliazation we want to do in Interpreter::privateExecute.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter): Moved hashtable initialization here to
avoid polluting Interpreter::privateExecute's stack, and changed it from a
series of add() calls to one add() call in a loop, to cut down on code size.

(JSC::Interpreter::privateExecute): Changed a series of label computations
to a copy of a compile-time constant array to cut down on code size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 17 Dec 2009 00:44:10 +0000 (00:44 +0000)]
2009-12-16  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Darin Adler.

        Fix LayoutTests/websocket/tests/url-with-query-for-no-query.html
        https://bugs.webkit.org/show_bug.cgi?id=32606

        It should test with /websocket/tests/no-query

        * websocket/tests/script-tests/url-with-query-for-no-query.js:
        * websocket/tests/url-with-query-for-no-query-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 17 Dec 2009 00:41:04 +0000 (00:41 +0000)]
2009-12-16  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52206.
        http://trac.webkit.org/changeset/52206
        https://bugs.webkit.org/show_bug.cgi?id=31187

        This broke pixel tests on Mac.  Presumably the code in
        ImageCG is wrong here.

        * platform/graphics/BitmapImage.h:
        * platform/graphics/GeneratedImage.cpp:
        (WebCore::GeneratedImage::drawPattern):
        * platform/graphics/GeneratedImage.h:
        * platform/graphics/Image.cpp:
        (WebCore::Image::drawTiled):
        * platform/graphics/Image.h:
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/haiku/ImageHaiku.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/wince/GraphicsContextWince.cpp:
        (WebCore::GraphicsContext::drawBitmapPattern):
        * platform/graphics/wince/ImageBufferWince.cpp:
        (WebCore::):
        (WebCore::BufferedImage::drawPattern):
        * platform/graphics/wx/ImageWx.cpp:
        (WebCore::BitmapImage::drawPattern):
        (WebCore::Image::drawPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 17 Dec 2009 00:40:10 +0000 (00:40 +0000)]
2009-12-16  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        bugzilla-tool should not require users to install mechanize
        https://bugs.webkit.org/show_bug.cgi?id=32635

        Centralize our import logic.

        * Scripts/modules/bugzilla.py: use webkit_mechanize
        * Scripts/modules/statusbot.py: use webkit_mechanize
        * Scripts/modules/webkit_mechanize.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] editing/selection/empty-cell-right-click.html introduced in r52220 failed.
ossy@webkit.org [Thu, 17 Dec 2009 00:31:39 +0000 (00:31 +0000)]
[Qt] editing/selection/empty-cell-right-click.html introduced in r52220 failed.
https://bugs.webkit.org/show_bug.cgi?id=32639

Test was refactored by r52226, and now it passes.

* platform/qt/Skipped: unskip editing/selection/empty-cell-right-click.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevised version of the test for:
enrica@apple.com [Thu, 17 Dec 2009 00:15:52 +0000 (00:15 +0000)]
Revised version of the test for:
<rdar://problem/5565465
https://bugs.webkit.org/show_bug.cgi?id=32622

Reviewed by Adele Peterson.

* editing/selection/empty-cell-right-click-expected.txt:
* editing/selection/empty-cell-right-click.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Simon Hausmann.
ossy@webkit.org [Thu, 17 Dec 2009 00:07:03 +0000 (00:07 +0000)]
Rubber-stamped by Simon Hausmann.

[Qt] editing/selection/empty-cell-right-click.html introduced in r52220 failed.
https://bugs.webkit.org/show_bug.cgi?id=32639

* platform/qt/Skipped: editing/selection/empty-cell-right-click.html added until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 17 Dec 2009 00:03:49 +0000 (00:03 +0000)]
2009-12-16  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=32637
        [V8] Generate most named property getters.

        Covered by existing tests.

        * bindings/scripts/CodeGeneratorV8.pm: Added generation of SetNamedPropertyHandler call.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate): Removed now-generated SetNamedPropertyHandler callsites.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Wed, 16 Dec 2009 23:52:38 +0000 (23:52 +0000)]
2009-12-16  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement combobox delegate for Qt
        https://bugs.webkit.org/show_bug.cgi?id=32550

        Abstract popup menu factory.

        A static method from QtAbstractPopupMenu is used to create its instances. If a factory
        has been suplied to class QtAbstractPopupMenu the factory will be used to create the
        objects. If not an instance of QtFallbackPopupMenu will be created.

        The objective is to make it easy to replace the combobox popup at WebCore layer providing
        support to the combobox popup delegation API. Future patches will make it possible to
        replace the combobox popup at WebKit layer.

        No behavior changes.

        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::PopupMenu):
        * platform/qt/QtAbstractWebPopup.cpp:
        (WebCore::QtAbstractWebPopup::setFactory):
        (WebCore::QtAbstractWebPopup::create):
        * platform/qt/QtAbstractWebPopup.h:
        * platform/qt/QtFallbackWebPopup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Disable debug variants of WebKit frameworks.
mrowe@apple.com [Wed, 16 Dec 2009 23:39:35 +0000 (23:39 +0000)]
Build fix.  Disable debug variants of WebKit frameworks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 16 Dec 2009 22:19:54 +0000 (22:19 +0000)]
2009-12-16  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Generalize commit-queue recent status page for all queues
        https://bugs.webkit.org/show_bug.cgi?id=32633

        * QueueStatusServer/index.html:
         - Generalize to support other queues.
        * QueueStatusServer/queue_status.py:
         - Generalize MainPage to support other queues.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Right clicking in a table cell creates a selection that extends into the...
enrica@apple.com [Wed, 16 Dec 2009 22:02:03 +0000 (22:02 +0000)]
WebCore: Right clicking in a table cell creates a selection that extends into the next cell.
<rdar://problem/5565465>
https://bugs.webkit.org/show_bug.cgi?id=32622

Reviewed by Eric Seidel.

Avoid extending the selection to the next cell if we start from an empty cell.

Test: editing/selection/empty-cell-right-click.html

* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Replaced the code that check for empty table cell
with a call to the new function.
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity): Extends the
selection only if we are not starting from an empty table cell.
* editing/htmlediting.cpp:
(WebCore::isEmptyTableCell): Added a function since this check is performed now in two places.
* editing/htmlediting.h: Added isEmptyTableCell declaration.

LayoutTests: Right clicking in a table cell creates a selection that extends into the next cell.
<rdar://problem/5565465>
https://bugs.webkit.org/show_bug.cgi?id=32622

Reviewed by Eric Seidel.

* editing/selection/empty-cell-right-click-expected.txt: Added.
* editing/selection/empty-cell-right-click.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Wed, 16 Dec 2009 21:56:54 +0000 (21:56 +0000)]
2009-12-16  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        feMerge crahses if feMergeNodes attribute in is empty
        https://bugs.webkit.org/show_bug.cgi?id=32489

        The previous test only checked if feMerge works on empty node
        without a last effect. In this case we get a source image and
        everything works fine. This test also covers the case if there
        is a last effect.

        * platform/mac/svg/custom/empty-merge-expected.checksum:
        * platform/mac/svg/custom/empty-merge-expected.png:
        * platform/mac/svg/custom/empty-merge-expected.txt:
        * svg/custom/empty-merge.svg:
2009-12-16  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        feMerge crahses if feMergeNodes attribute in is empty
        https://bugs.webkit.org/show_bug.cgi?id=32489

        SVGFEMergeElement only stored pointers to all effects of it's nodes
        in a list. But it should store the RefPtr otherwise the effects get
        dereferenced and WebKit crashes.
        I also made a short clean-up in SVGFilterBuilder. No change in
        functionality.

        Test: I updated svg/custom/empty-merge.svg to cover this problem.

        * svg/SVGFEMergeElement.cpp:
        (WebCore::SVGFEMergeElement::build):
        * svg/graphics/filters/SVGFEMerge.cpp:
        (WebCore::FEMerge::FEMerge):
        (WebCore::FEMerge::create):
        (WebCore::FEMerge::mergeInputs):
        (WebCore::FEMerge::setMergeInputs):
        * svg/graphics/filters/SVGFEMerge.h:
        * svg/graphics/filters/SVGFilterBuilder.cpp:
        (WebCore::SVGFilterBuilder::add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Evan Martin <evan@chromium.org>
eric@webkit.org [Wed, 16 Dec 2009 21:24:08 +0000 (21:24 +0000)]
2009-12-16  Evan Martin  <evan@chromium.org>

        Reviewed by Adam Barth.

        Early warning system server should display output as UTF-8.

        https://bugs.webkit.org/show_bug.cgi?id=32625

        * QueueStatusServer/queue_status.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPart of <http://webkit.org/b/32568>.
bweinstein@apple.com [Wed, 16 Dec 2009 21:17:08 +0000 (21:17 +0000)]
Part of <http://webkit.org/b/32568>.
Web Inspector: Context Menus should be used in more places.

Reviewed by Timothy Hatcher.

Add a context menu entry in the console to clear the console. This
is only shown when there is no user selection of text, because if
there is selection of the text, then we want to give the user the Copy +
Spell Check context menu that they are used to.

* English.lproj/localizedStrings.js: Added "Clear Console".
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._handleContextMenuEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 16 Dec 2009 21:17:00 +0000 (21:17 +0000)]
2009-12-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Add error handling to the early warning system
        https://bugs.webkit.org/show_bug.cgi?id=32594

        This should be the last step in making the EWS operational.  When we
        have a build error, we post the log to QueueStatusServer and add a link
        to the bug.

        * Scripts/modules/commands/early_warning_system.py:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/executive.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Wed, 16 Dec 2009 21:15:34 +0000 (21:15 +0000)]
2009-12-16  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha Silva.

        Deprecate the old loading signals load-started, load-committed,
        load-finished, load-progress-changed and change unit tests to use
        load-status instead.

        * tests/testmimehandling.c:
        (idle_quit_loop_cb):
        (test_mime_type): use notify::load-status
        * tests/testwebdatasource.c:
        (notify_load_status_unreachable_cb):
        (notify_load_status_cb):
        (test_webkit_web_data_source):
        (test_webkit_web_data_source_unreachable_uri): Remove uses of
        g_main_loop_is_running. It's an error if the loop is wrongly terminated.
        * tests/testwebresource.c:
        (notify_load_status_cb):
        (test_web_resource_loading):
        (notify_load_status_sub_cb):
        (test_web_resource_sub_resource_loading): use notify::load-status
        * tests/testwebview.c:
        (idle_quit_loop_cb):
        (test_webkit_web_view_icon_uri):
        * tests/testwindow.c:
        (notify_load_status_cb):
        (test_webkit_window_scrollbar_policy): use notify::load-status
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_class_init):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_class_init): Deprecate old load signals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixes <https://bugs.webkit.org/show_bug.cgi?id=32621>.
bweinstein@apple.com [Wed, 16 Dec 2009 20:59:04 +0000 (20:59 +0000)]
Fixes <https://bugs.webkit.org/show_bug.cgi?id=32621>.
Web Inspector: [REGRESSION (52095-52100)] Resources filter disappears when switching
from / to resources panel.

Reviewed by Pavel Feldman.

Changed style in sidebar-resizer-vertical, because if the min-height was 100%, we start
to cover the scope bar.

* inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 16 Dec 2009 20:14:34 +0000 (20:14 +0000)]
2009-12-16  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        [V8] Switch all indexers to be generated.
        https://bugs.webkit.org/show_bug.cgi?id=32569

        Covered by existing tests.

        * WebCore.gypi: Remove V8FileListCustom.cpp and V8ClientRecListCustom.cpp,
            as they are now generated.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate): Remove customization of ClientRectList,
            FileList, and DataGridColumnList templates.
        * bindings/v8/custom/V8ClientRectListCustom.cpp: Removed.
        * bindings/v8/custom/V8CustomBinding.h: Remove custom indexer getter decls.
        * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Remove indexer getter definition.
        * bindings/v8/custom/V8FileListCustom.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 anton muhin <antonm@chromium.org>
eric@webkit.org [Wed, 16 Dec 2009 19:34:00 +0000 (19:34 +0000)]
2009-12-16  anton muhin  <antonm@chromium.org>

        Reviewed by Darin Adler.

        [dom] make dom/Node.cpp compile if DUMP_NODE_STATISTICS is on
        https://bugs.webkit.org/show_bug.cgi?id=32617

        * dom/Node.cpp:
        (WebCore::Node::dumpStatistics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 16 Dec 2009 19:25:09 +0000 (19:25 +0000)]
2009-12-16  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        [V8] There is no such thing as HTMLSelectElementCollection.
        https://bugs.webkit.org/show_bug.cgi?id=32616

        Refactoring, covered by existing tests.

        * WebCore.gypi: Removed V8HTMLSelectElementCollectionCustom.cpp
        * bindings/v8/V8Collection.h: Removed one-off template.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate): Renamed all references to HTMLSelectElementCollection
            to HTMLSelectElement.
        * bindings/v8/custom/V8CustomBinding.h: Renamed custom indexer decls.
        * bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Removed.
        * bindings/v8/custom/V8HTMLSelectElementCustom.cpp: Moved code as-is from
            V8HTMLSelectElementCollectionCustom.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixing bug number in ChangeLog
kov@webkit.org [Wed, 16 Dec 2009 19:20:25 +0000 (19:20 +0000)]
Fixing bug number in ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBrought this file up to date, sans review.
sullivan@apple.com [Wed, 16 Dec 2009 19:15:54 +0000 (19:15 +0000)]
Brought this file up to date, sans review.

* StringsNotToBeLocalized.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Dan Winship <danw@gnome.org>
eric@webkit.org [Wed, 16 Dec 2009 19:14:36 +0000 (19:14 +0000)]
2009-12-16  Dan Winship  <danw@gnome.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Content-Encoding support

        https://bugs.webkit.org/show_bug.cgi?id=522772

        * configure.ac: require libsoup 2.28.2 for SoupContentDecoder
2009-12-16  Dan Winship  <danw@gnome.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Content-Encoding support

        https://bugs.webkit.org/show_bug.cgi?id=522772

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::startHttp): Don't force "Accept-Encoding: identity" any
        more
2009-12-16  Dan Winship  <danw@gnome.org>

        Reviewed by Gustavo Noronha Silva.

        Content-Encoding support

        https://bugs.webkit.org/show_bug.cgi?id=522772

        * webkit/webkitprivate.cpp:
        (webkit_init): add a SoupContentDecoder feature to the session

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Wed, 16 Dec 2009 19:03:50 +0000 (19:03 +0000)]
2009-12-16  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha Silva.

        Take into account favicon.ico in the webresource test.

        * tests/testwebresource.c:
        (test_web_resource_sub_resource_loading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Benjamin Otte <otte@gnome.org>
eric@webkit.org [Wed, 16 Dec 2009 19:00:25 +0000 (19:00 +0000)]
2009-12-16  Benjamin Otte  <otte@gnome.org>

        Reviewed by Darin Adler.

        Get rid of the phase argument to Image::drawPattern.
        https://bugs.webkit.org/show_bug.cgi?id=31187

        The argument can be expressed equally well as part of the
        patternTransform. All backends but the Qt one did exactly that
        manually anyway.

        * platform/graphics/BitmapImage.h:
        * platform/graphics/GeneratedImage.cpp:
        (WebCore::GeneratedImage::drawPattern):
        * platform/graphics/GeneratedImage.h:
        * platform/graphics/Image.cpp:
        (WebCore::Image::drawTiled):
        * platform/graphics/Image.h:
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/haiku/ImageHaiku.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/wince/GraphicsContextWince.cpp:
        (WebCore::GraphicsContext::drawBitmapPattern):
        * platform/graphics/wince/ImageBufferWince.cpp:
        (WebCore::):
        (WebCore::BufferedImage::drawPattern):
        * platform/graphics/wx/ImageWx.cpp:
        (WebCore::BitmapImage::drawPattern):
        (WebCore::Image::drawPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Kenneth Russell <kbr@google.com>
eric@webkit.org [Wed, 16 Dec 2009 18:50:55 +0000 (18:50 +0000)]
2009-12-16  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Performance problems with index validation code for drawElements
        https://bugs.webkit.org/show_bug.cgi?id=32466

        Added a cache of the maximum index for each element type to
        WebGLBuffer, querying it before iterating through the indices in
        the client-side copy of the buffer's data. Hoisted checks of the
        size of the element array itself into validateElementArraySize to
        avoid duplicating code.

        The performance improvement has been measured with manual tests.
        Existing layout tests cover the index validation functionality
        and continue to pass as before.

        * html/canvas/WebGLBuffer.cpp:
        (WebCore::WebGLBuffer::WebGLBuffer):
        (WebCore::WebGLBuffer::associateBufferData):
        (WebCore::WebGLBuffer::associateBufferSubData):
        (WebCore::WebGLBuffer::getCachedMaxIndex):
        (WebCore::WebGLBuffer::setCachedMaxIndex):
        (WebCore::WebGLBuffer::clearCachedMaxIndices):
        * html/canvas/WebGLBuffer.h:
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::validateElementArraySize):
        (WebCore::WebGLRenderingContext::validateIndexArrayConservative):
        (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
        (WebCore::WebGLRenderingContext::validateRenderingState):
        (WebCore::WebGLRenderingContext::drawElements):
        * html/canvas/WebGLRenderingContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Zelidrag Hornung <zelidrag@chromium.org>
eric@webkit.org [Wed, 16 Dec 2009 18:43:27 +0000 (18:43 +0000)]
2009-12-16  Zelidrag Hornung  <zelidrag@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=32261
        Added ability to separate the autocomplete suggestion previewing from
        the actual accepting of the suggested value in HTMLInputElement.
        This element (it's single line text incarnation) can now
        be put in suggestion mode where renderer might display the suggested
        value without making it automatically exposed to JavaScript.

        No new tests. This new methods are not exposed yet. It's use will be
        platform specific. PopupMenu and Chromium specific changes will be
        separated based on Darin Adler's comments.

        * dom/InputElement.h:
        (WebCore::InputElementData::suggestedValue):
        (WebCore::InputElementData::setSuggestedValue):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::suggestedValue):
        (WebCore::HTMLInputElement::setSuggestedValue):
        (WebCore::HTMLInputElement::setValue):
        (WebCore::HTMLInputElement::setValueFromRenderer):
        * html/HTMLInputElement.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::updateFromElement):
        * wml/WMLInputElement.cpp:
        (WebCore::WMLInputElement::suggestedValue):
        * wml/WMLInputElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 16 Dec 2009 18:24:59 +0000 (18:24 +0000)]
2009-12-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Make Elements tree, properties section and resources
        view monospace.

        https://bugs.webkit.org/show_bug.cgi?id=32609

        * inspector/front-end/ElementsPanel.js:
        * inspector/front-end/PropertiesSection.js:
        (WebInspector.PropertiesSection):
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView):
        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Wed, 16 Dec 2009 18:12:55 +0000 (18:12 +0000)]
2009-12-16  Dirk Schulze  <krit@webkit.org>

        Reviewed by Darin Adler.

        sourceGraphic wrong if positive x,y is >0 and objectBB is selected on Filter
        https://bugs.webkit.org/show_bug.cgi?id=32575

        Check if the GraphicsContex get adjusted, if the source rect is clipped
        to the filter rect.

        * platform/mac/svg/filters/filter-source-position-expected.checksum: Added.
        * platform/mac/svg/filters/filter-source-position-expected.png: Added.
        * platform/mac/svg/filters/filter-source-position-expected.txt: Added.
        * svg/filters/filter-source-position.svg: Added.
2009-12-16  Dirk Schulze  <krit@webkit.org>

        Reviewed by Darin Adler.

        sourceGraphic wrong if positive x,y is >0 and objectBB is selected on Filter
        https://bugs.webkit.org/show_bug.cgi?id=32575

        On SVG Filters, the rest of the source graphic gets clipped to the filter
        rest. This helps us to minimize the size of intermediate ImageBuffers. If
        the position moves to the right or to the bottom, we have to adjust the
        GraphicContext of this intermediate ImageBuffer.
        This patch fixes the adjustment of the context, according to the clipping.

        Test: svg/filters/filter-source-position.svg

        * svg/graphics/SVGResourceFilter.cpp:
        (WebCore::SVGResourceFilter::prepareFilter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrashTracer: [USER] 1 crash in Safari at com.apple.WebCore: WebCore::endsOfNodeAreVis...
enrica@apple.com [Wed, 16 Dec 2009 17:59:58 +0000 (17:59 +0000)]
CrashTracer: [USER] 1 crash in Safari at com.apple.WebCore: WebCore::endsOfNodeAreVisuallyDistinctPositions + 115
<rdar://problem/7467108>
https://bugs.webkit.org/show_bug.cgi?id=32590

Reviewed by Adele Peterson.

WebCore:

If the element is a button there is no need to look at the children to calculate the caret position.

Test: editing/selection/button-right-click.html

* dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset): Avoid calling recursively this method,
when starting from a button element.

LayoutTests:

* editing/selection/button-right-click-expected.txt: Added.
* editing/selection/button-right-click.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Xan Lopez.
kov@webkit.org [Wed, 16 Dec 2009 17:37:03 +0000 (17:37 +0000)]
Rubber-stamped by Xan Lopez.

Add tab_key_cycles_through_elements to copies of
WebKitWebSettings.

* webkit/webkitwebsettings.cpp:
(webkit_web_settings_copy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Wed, 16 Dec 2009 17:27:09 +0000 (17:27 +0000)]
2009-12-16  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement combobox delegate for Qt
        https://bugs.webkit.org/show_bug.cgi?id=32550

        Refactoring of class QWebPopup.

        Class QWebPopup has been split in QtAbstractWebPopup and QtFallbackWebPopup.
        Both new classes are now in corresponding files and files QWebPopup.* have been removed.

        Custom combo popup classes will inherit from QtAbstractWebPopup. It is not the public API as it is
        in WebCore and will not be visible by users of QtWebKit. It will be used in implementation of
        public QtWebKit combobox popup delegation API.

        Class QtFallbackWebPopup inherits from QtAbstractWebPopup and implements the currently used combobox popup.
        It needs to be improved to provide standard features that are missing like style or indentation.

        No behavior changes.

        * WebCore.pro:
        * platform/PopupMenu.h:
        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::PopupMenu):
        * platform/qt/QWebPopup.cpp: Removed.
        * platform/qt/QWebPopup.h: Removed.
        * platform/qt/QtAbstractWebPopup.cpp: Added.
        (WebCore::QtAbstractWebPopup::QtAbstractWebPopup):
        (WebCore::QtAbstractWebPopup::~QtAbstractWebPopup):
        (WebCore::QtAbstractWebPopup::client):
        * platform/qt/QtAbstractWebPopup.h: Added.
        * platform/qt/QtFallbackWebPopup.cpp: Added.
        (WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
        (WebCore::QtFallbackWebPopup::show):
        (WebCore::QtFallbackWebPopup::populate):
        (WebCore::QtFallbackWebPopup::showPopup):
        (WebCore::QtFallbackWebPopup::hidePopup):
        (WebCore::QtFallbackWebPopup::activeChanged):
        * platform/qt/QtFallbackWebPopup.h: Added.
        (WebCore::QtFallbackWebPopup::hide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Wed, 16 Dec 2009 17:04:39 +0000 (17:04 +0000)]
2009-12-16  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] webkit_web_navigation_action_get_button() documentation
        https://bugs.webkit.org/show_bug.cgi?id=25555

        Small documentation improvement for webkit_web_navigation_action_get_button.

        * webkit/webkitwebnavigationaction.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Wed, 16 Dec 2009 14:21:58 +0000 (14:21 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=31332

[Qt] After http://trac.webkit.org/changeset/52192
there are a failing and a timeouter test.

* platform/qt/Skipped: http/tests/misc/drag-over-iframe-invalid-source-crash.html added until fix.
* platform/qt/fast/text/international/khmer-selection-expected.txt: update outdated expected.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Simon Hausmann.
ossy@webkit.org [Wed, 16 Dec 2009 10:42:06 +0000 (10:42 +0000)]
Rubber-stamped by Simon Hausmann.

[Qt] http://trac.webkit.org/changeset/52194 fixed a side-effect
of DumpRenderTree. The previously wrong expected file updated.

* platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt: updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkipping a new test, and a test that fails only on the release bot,
kov@webkit.org [Wed, 16 Dec 2009 10:25:52 +0000 (10:25 +0000)]
Skipping a new test, and a test that fails only on the release bot,
apparently because of rouding errors.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitTools: Fix crash with tests that use custom font faces.
hausmann@webkit.org [Wed, 16 Dec 2009 10:06:45 +0000 (10:06 +0000)]
WebKitTools: Fix crash with tests that use custom font faces.

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=32600

In the DRT we call QApplication::removeAllApplicationFonts(), to make sure
that custom font faces between tests don't influence each other. Calling this
function in Qt however also invalidates all existing handles with QFontDatabase.

In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(),
which implies a call to WebCore::FontCache::fontCache()->invalidate().

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):

LayoutTests: [Qt] Unskip fast/css/font-face-multiple-families.html.

Reviewed by Holger Freyther.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 16 Dec 2009 10:05:29 +0000 (10:05 +0000)]
2009-12-15  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: beautify HTTP info section.

        https://bugs.webkit.org/show_bug.cgi?id=32583

        * English.lproj/localizedStrings.js:
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView):
        (WebInspector.ResourceView.prototype._refreshURL):
        (WebInspector.ResourceView.prototype._refreshHTTPInformation):
        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Wed, 16 Dec 2009 09:54:34 +0000 (09:54 +0000)]
2009-12-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Maintain button state between mouse events.

        This allows eventSender to generate drag events.

        https://bugs.webkit.org/show_bug.cgi?id=32601

        * DumpRenderTree/qt/EventSenderQt.cpp:
        (EventSender::mouseDown):
        (EventSender::mouseUp):
        (EventSender::mouseMoveTo):
        * DumpRenderTree/qt/EventSenderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert r52085, because it causes crashes on media tests in the release
kov@webkit.org [Wed, 16 Dec 2009 09:52:25 +0000 (09:52 +0000)]
Revert r52085, because it causes crashes on media tests in the release
bot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] fast/css/font-face-unused-source-loaded.html crashes
ossy@webkit.org [Wed, 16 Dec 2009 08:56:37 +0000 (08:56 +0000)]
[Qt] fast/css/font-face-unused-source-loaded.html crashes
https://bugs.webkit.org/show_bug.cgi?id=32600

Reviewed by Simon Hausmann.

The crash caused by fast/css/font-face-multiple-families.html, added to skiplist until fix.

* platform/qt/Skipped: fast/css/font-face-multiple-families.html added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52190 268f45cc-cd09-0410-ab3c-d52691b4dbfc