WebKit-https.git
6 years agoThe second part of the build fix for r146702. This should do it.
rniwa@webkit.org [Sat, 23 Mar 2013 03:35:29 +0000 (03:35 +0000)]
The second part of the build fix for r146702. This should do it.
I had to see the mangled name for the new signature.

Source/WebKit:

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

* WebKit.vcproj/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Mark canvas-toDataURL-webp.html imageOnlyFailure Pass
noel.gordon@gmail.com [Sat, 23 Mar 2013 03:34:16 +0000 (03:34 +0000)]
[chromium] Mark canvas-toDataURL-webp.html imageOnlyFailure Pass
https://bugs.webkit.org/show_bug.cgi?id=93310

Unreviewed test expectations update.

libwebp will be updated to 0.3.0 in chrome, changing the encoder
output, after which these test results will need to be updated.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the typo: WIN -> WINDOWS.
rniwa@webkit.org [Sat, 23 Mar 2013 03:24:23 +0000 (03:24 +0000)]
Fix the typo: WIN -> WINDOWS.

* API/tests/testapi.c:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoI really can't figure out what's wrong with this one.
rniwa@webkit.org [Sat, 23 Mar 2013 03:12:51 +0000 (03:12 +0000)]
I really can't figure out what's wrong with this one.
Temporarily disable the test added by r146682 on Windows since it doesn't compile.

* API/tests/testapi.c:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Mark more tests as crashing.
pkasting@chromium.org [Sat, 23 Mar 2013 03:09:49 +0000 (03:09 +0000)]
[chromium] Mark more tests as crashing.
https://bugs.webkit.org/show_bug.cgi?id=113067

Unreviewed, test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix attempt after r146702.
rniwa@webkit.org [Sat, 23 Mar 2013 02:50:05 +0000 (02:50 +0000)]
Build fix attempt after r146702.

Source/WebKit:

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

* WebKit.vcproj/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd runtime setting for hidden page DOM timer throttling and CSS animation suspension
cmuppala@apple.com [Sat, 23 Mar 2013 02:15:36 +0000 (02:15 +0000)]
Add runtime setting for hidden page DOM timer throttling and CSS animation suspension
https://bugs.webkit.org/show_bug.cgi?id=112308

Reviewed by Gavin Barraclough.

Source/WebCore:

No new tests.  Only adding settings to enable/disable existing features
and hence existing tests suffice.

* WebCore.exp.in:
* page/Page.cpp:
(WebCore::Page::setVisibilityState): Check if DOM timer throttling
and CSS animation suspension are enabled before turning them on.
(WebCore::Page::hiddenPageDOMTimerThrottlingStateChanged): Start or stop
DOM timer throttling based on page visibility and the new setting state.
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged): Ditto
for CSS animation suspension.
* page/Page.h:
* page/Settings.cpp:
(WebCore::Settings::Settings): Initialize the flags for enabling hidden
page DOM timer throttling and CSS animation suspension to false.
(WebCore::Settings::setHiddenPageDOMTimerThrottlingEnabled): Update flag
and notify page that the state of the setting has changed.
(WebCore::Settings::setHiddenPageCSSAnimationSuspensionEnabled): Ditto.
* page/Settings.h:
(WebCore::Settings::hiddenPageDOMTimerThrottlingEnabled):
(WebCore::Settings::hiddenPageCSSAnimationSuspensionEnabled):

Source/WebKit/mac:

Add private preference for enabling/disabling hidden page DOM timer
throttling and CSS animation suspension.  The preference should be
disabled by default to avoid compatibility issues.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences hiddenPageDOMTimerThrottlingEnabled]):
(-[WebPreferences setHiddenPageDOMTimerThrottlingEnabled:]):
(-[WebPreferences hiddenPageCSSAnimationSuspensionEnabled]):
(-[WebPreferences setHiddenPageCSSAnimationSuspensionEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit2:

Add private preference for enabling/disabling hidden page DOM timer
throttling and CSS animation suspension.  The preference should be
enabled by default only on Mac, where WebKit2 is a private API and
hence compatibility is less of a issue.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetHiddenPageDOMTimerThrottlingEnabled):
(WKPreferencesGetHiddenPageDOMTimerThrottlingEnabled):
(WKPreferencesSetHiddenPageCSSAnimationSuspensionEnabled):
(WKPreferencesGetHiddenPageCSSAnimationSuspensionEnabled):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Allow
WebKitTestRunner to override hiddenPageDOMTimerThrottlingEnabled.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

LayoutTests:

Hidden page DOM timer throttling is disabled by default in WebKit1 and
in WebKit2 for platforms other than Mac.  Override the preference to
enable it during the test.

* fast/dom/timer-throttling-hidden-page.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Move self from contributor to committer list.
cmuppala@apple.com [Sat, 23 Mar 2013 02:01:11 +0000 (02:01 +0000)]
Unreviewed.  Move self from contributor to committer list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove 2 bad branches from StringHash::equal() and CaseFoldingHash::equal()
benjamin@webkit.org [Sat, 23 Mar 2013 01:35:34 +0000 (01:35 +0000)]
Remove 2 bad branches from StringHash::equal() and CaseFoldingHash::equal()
https://bugs.webkit.org/show_bug.cgi?id=113003

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-22
Reviewed by Eric Seidel.

Source/WebCore:

Fix two unfortunate use of StringHash and use the correct StringImpl function.

* html/parser/HTMLParserIdioms.cpp:
(WebCore::threadSafeEqual):
* html/parser/HTMLTreeBuilderSimulator.cpp:
(WebCore::tokenExitsSVG):

Source/WTF:

StringHash::equal() and CaseFoldingHash::equal() were both testing for
the nullity of the two input pointers. The catch is: neither traits handle
null pointers, and any client code would have crashed on hash(), before equal()
is called.
Consequently, the two branches had a pass rate of zero when called from a HashMap code.

The function is also never inlined because it is too big (the code of equal() for characters
is always inlined, causing the function to be quite big).

This patch introduces two new functions in the StringImpl API: equalNonNull() and
equalIgnoringCaseNonNull(). Those functions are similar to their equal() equivalent
but make the assumtion the input is never null.

The functions are used for StringHash to avoid the useless branches.

* wtf/text/StringHash.h:
(WTF::StringHash::equal):
(WTF::CaseFoldingHash::equal):
* wtf/text/StringImpl.cpp:
(WTF::stringImplContentEqual):
(WTF::equal):
(WTF::equalNonNull):
(WTF::equalIgnoringCase):
(WTF::equalIgnoringCaseNonNull):
(WTF::equalIgnoringNullity):
* wtf/text/StringImpl.h:
(WTF::equalIgnoringCase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSet the cache partition property on CFURLRequests
aestes@apple.com [Sat, 23 Mar 2013 01:19:35 +0000 (01:19 +0000)]
Set the cache partition property on CFURLRequests
https://bugs.webkit.org/show_bug.cgi?id=113116

Patch by Jeffrey Pfau
Reviewed by David Kilzer.

* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Test expectations after Skia changes
schenney@chromium.org [Sat, 23 Mar 2013 01:17:43 +0000 (01:17 +0000)]
[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

Adding bug numbers for two failing tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Test expectations after Skia changes
schenney@chromium.org [Sat, 23 Mar 2013 01:10:35 +0000 (01:10 +0000)]
[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

The rest.

* platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-linux/fast/borders/border-radius-with-box-shadow-01-expected.png:
* platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png:
* platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
* platform/chromium-linux/fast/box-shadow/inset-expected.png:
* platform/chromium-linux/fast/box-shadow/scaled-box-shadow-expected.png: Added.
* platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png:
* platform/chromium-mac-lion/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
* platform/chromium-mac-lion/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
* platform/chromium-mac-lion/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/chromium-mac-lion/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
* platform/chromium-mac-lion/editing/selection/select-text-overflow-ellipsis-expected.png:
* platform/chromium-mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
* platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
* platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
* platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
* platform/chromium-mac-lion/fast/backgrounds/animated-svg-as-mask-expected.png:
* platform/chromium-mac-lion/fast/borders/border-antialiasing-expected.png:
* platform/chromium-mac-lion/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-mac-lion/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-mac-lion/fast/box-shadow/inset-expected.png:
* platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
* platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
* platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-text-overflow-ellipsis-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-mac/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
* platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
* platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
* platform/chromium-mac/editing/selection/select-text-overflow-ellipsis-expected.png:
* platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png:
* platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
* platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-mac/fast/borders/border-radius-with-box-shadow-01-expected.png:
* platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png:
* platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png:
* platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
* platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
* platform/chromium-mac/fast/box-shadow/inset-expected.png:
* platform/chromium-mac/fast/box-shadow/scaled-box-shadow-expected.png:
* platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png:
* platform/chromium-mac/fast/box-shadow/shadow-tiling-artifact-expected.png:
* platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png:
* platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-win/fast/borders/border-radius-with-box-shadow-01-expected.png:
* platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png:
* platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
* platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
* platform/chromium-win/fast/box-shadow/inset-expected.png:
* platform/chromium-win/fast/box-shadow/scaled-box-shadow-expected.png:
* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
* platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png:
* platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png:
* platform/chromium/TestExpectations:
* platform/efl-wk2/fast/borders/border-radius-split-inline-expected.png: Added.
* platform/efl-wk2/fast/box-shadow/basic-shadows-expected.png: Added.
* platform/efl-wk2/fast/box-shadow/box-shadow-transformed-expected.png: Added.
* platform/efl-wk2/fast/box-shadow/inset-expected.png: Added.
* platform/efl-wk2/fast/box-shadow/scaled-box-shadow-expected.png: Added.
* platform/efl/fast/borders/border-radius-split-inline-expected.png: Removed.
* platform/efl/fast/box-shadow/basic-shadows-expected.png: Removed.
* platform/efl/fast/box-shadow/box-shadow-transformed-expected.png: Removed.
* platform/efl/fast/box-shadow/inset-expected.png: Removed.
* platform/efl/fast/box-shadow/scaled-box-shadow-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAnother build fix (after r146693) for r146682.
rniwa@webkit.org [Sat, 23 Mar 2013 01:09:22 +0000 (01:09 +0000)]
Another build fix (after r146693) for r146682.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] content-sized row tracks with percentage logical height grid items...
jchaffraix@webkit.org [Sat, 23 Mar 2013 01:07:17 +0000 (01:07 +0000)]
[CSS Grid Layout] content-sized row tracks with percentage logical height grid items don't resolve properly
https://bugs.webkit.org/show_bug.cgi?id=113085

Reviewed by Tony Chang.

Source/WebCore:

The core issue is that because overrideContainingBlockLogicalHeight() is unset in
logicalContentHeightForChild, RenderBox::computePercentageLogicalHeight would try to
resolve percentage logical height against the grid element (wrong containing block
as a grid item's containing block is the grid area).

Tests: fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html
       fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::logicalContentHeightForChild):
Set our override logical height to -1, so that we don't try to constrain a grid item's logical height
based on resolving (badly) its percentage.

LayoutTests:

* fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution-expected.txt:
Updated the result to pass.

* fast/css-grid-layout/grid-item-multiple-minmax-content-resolution-expected.txt: Added.
* fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html: Added.
* fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution-expected.txt: Added.
* fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html: Added.
Added more testing to ensure that we properly do the resolution.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Test expectations after Skia changes
schenney@chromium.org [Sat, 23 Mar 2013 01:03:26 +0000 (01:03 +0000)]
[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

fast/canvas/...
fast/css/...
fast/forms/...
fast/multicol/...

* platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-linux/fast/css/color-correction-on-box-shadow-expected.png:
* platform/chromium-linux/fast/css/color-correction-on-text-shadow-expected.png:
* platform/chromium-linux/fast/css/font-family-pictograph-expected.png:
* platform/chromium-linux/fast/css/font-family-pictograph-expected.txt:
* platform/chromium-linux/fast/css/shadow-multiple-expected.png:
* platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-mac-lion/fast/css/color-correction-on-box-shadow-expected.png:
* platform/chromium-mac-lion/fast/css/color-correction-on-text-shadow-expected.png:
* platform/chromium-mac-lion/fast/css/empty-pseudo-class-expected.png:
* platform/chromium-mac-lion/fast/css/first-child-pseudo-class-expected.png:
* platform/chromium-mac-lion/fast/css/first-of-type-pseudo-class-expected.png:
* platform/chromium-mac-lion/fast/css/last-child-pseudo-class-expected.png:
* platform/chromium-mac-lion/fast/css/last-of-type-pseudo-class-expected.png:
* platform/chromium-mac-lion/fast/css/only-child-pseudo-class-expected.png:
* platform/chromium-mac-lion/fast/css/only-of-type-pseudo-class-expected.png:
* platform/chromium-mac-lion/fast/css/shadow-multiple-expected.png:
* platform/chromium-mac-lion/fast/dynamic/text-combine-expected.png:
* platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-lion/fast/line-grid/line-grid-contains-value-expected.png:
* platform/chromium-mac-lion/fast/multicol/nested-columns-expected.png:
* platform/chromium-mac-lion/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-mac-snowleopard/fast/css/color-correction-on-box-shadow-expected.png:
* platform/chromium-mac-snowleopard/fast/css/color-correction-on-text-shadow-expected.png:
* platform/chromium-mac-snowleopard/fast/css/empty-pseudo-class-expected.png:
* platform/chromium-mac-snowleopard/fast/css/first-child-pseudo-class-expected.png:
* platform/chromium-mac-snowleopard/fast/css/first-of-type-pseudo-class-expected.png:
* platform/chromium-mac-snowleopard/fast/css/last-child-pseudo-class-expected.png:
* platform/chromium-mac-snowleopard/fast/css/last-of-type-pseudo-class-expected.png:
* platform/chromium-mac-snowleopard/fast/css/only-child-pseudo-class-expected.png:
* platform/chromium-mac-snowleopard/fast/css/only-of-type-pseudo-class-expected.png:
* platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-contains-value-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/nested-columns-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-mac/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png:
* platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.png:
* platform/chromium-mac/fast/css/empty-pseudo-class-expected.png:
* platform/chromium-mac/fast/css/first-child-pseudo-class-expected.png:
* platform/chromium-mac/fast/css/first-of-type-pseudo-class-expected.png:
* platform/chromium-mac/fast/css/last-child-pseudo-class-expected.png:
* platform/chromium-mac/fast/css/last-of-type-pseudo-class-expected.png:
* platform/chromium-mac/fast/css/only-child-pseudo-class-expected.png:
* platform/chromium-mac/fast/css/only-of-type-pseudo-class-expected.png:
* platform/chromium-mac/fast/css/shadow-multiple-expected.png:
* platform/chromium-mac/fast/dynamic/text-combine-expected.png:
* platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac/fast/line-grid/line-grid-contains-value-expected.png:
* platform/chromium-mac/fast/multicol/nested-columns-expected.png:
* platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-win/fast/css/color-correction-on-box-shadow-expected.png:
* platform/chromium-win/fast/css/color-correction-on-text-shadow-expected.png:
* platform/chromium-win/fast/css/shadow-multiple-expected.png:
* platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
* platform/chromium/TestExpectations:
* platform/efl-wk2/fast/multicol: Added.
* platform/efl-wk2/fast/multicol/shadow-breaking-expected.png: Added.
* platform/efl/fast/multicol/shadow-breaking-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Test expectations after Skia changes
schenney@chromium.org [Sat, 23 Mar 2013 00:52:22 +0000 (00:52 +0000)]
[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

fast/repaint/...
fast/ruby/...

* fast/repaint/moving-shadow-on-container-expected.png: Added.
* fast/repaint/search-field-cancel-expected.txt: Added.
* platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.png: Removed.
* platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.png:
* platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac-lion/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-mac-lion/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-mac-lion/fast/repaint/moving-shadow-on-container-expected.png:
* platform/chromium-mac-lion/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-mac-lion/fast/repaint/scale-page-shrink-expected.png: Added.
* platform/chromium-mac-lion/fast/repaint/search-field-cancel-expected.png: Added.
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/scale-page-shrink-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/ruby/base-shorter-than-text-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/ruby/base-shorter-than-text-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/ruby/position-after-expected.png:
* platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-mac/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
* platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-mac/fast/repaint/scale-page-shrink-expected.png: Added.
* platform/chromium-mac/fast/repaint/search-field-cancel-expected.png: Added.
* platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac/fast/repaint/transform-replaced-shadows-expected.png:
* platform/chromium-mac/fast/ruby/position-after-expected.png:
* platform/chromium-win-xp/fast/repaint/box-shadow-h-expected.png: Removed.
* platform/chromium-win-xp/fast/repaint/box-shadow-v-expected.png: Removed.
* platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.png: Removed.
* platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.txt: Removed.
* platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
* platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-win/fast/repaint/search-field-cancel-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/fast/repaint/search-field-cancel-expected.png: Removed.
* platform/chromium/fast/repaint/search-field-cancel-expected.txt: Removed.
* platform/efl-wk2/fast/repaint/moving-shadow-on-container-expected.png: Added.
* platform/efl-wk2/fast/repaint/moving-shadow-on-path-expected.png: Added.
* platform/efl-wk2/fast/repaint/transform-replaced-shadows-expected.png: Added.
* platform/efl/fast/repaint/moving-shadow-on-container-expected.png: Removed.
* platform/efl/fast/repaint/moving-shadow-on-path-expected.png: Removed.
* platform/efl/fast/repaint/transform-replaced-shadows-expected.png: Removed.
* platform/gtk/fast/repaint/moving-shadow-on-container-expected.png: Removed.
* platform/mac/fast/repaint/moving-shadow-on-container-expected.png: Removed.
* platform/mac/fast/repaint/search-field-cancel-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCheck WEBGL_draw_buffers requirements before exposing the extension
zmo@google.com [Sat, 23 Mar 2013 00:45:21 +0000 (00:45 +0000)]
Check WEBGL_draw_buffers requirements before exposing the extension
https://bugs.webkit.org/show_bug.cgi?id=112359

Reviewed by Kenneth Russell.

* html/canvas/EXTDrawBuffers.cpp:
(WebCore::EXTDrawBuffers::supported): call satisfies*().
(WebCore::EXTDrawBuffers::drawBuffersEXT):
(WebCore):
(WebCore::EXTDrawBuffers::satisfiesWebGLRequirements): check WebGL requirements.
* html/canvas/EXTDrawBuffers.h:
(EXTDrawBuffers):
* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::getDrawBuffer):
(WebCore):
* html/canvas/WebGLFramebuffer.h:
(WebGLFramebuffer):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateFramebufferFuncParameters):
(WebCore::WebGLRenderingContext::getMaxDrawBuffers):
(WebCore::WebGLRenderingContext::getMaxColorAttachments):
(WebCore::WebGLRenderingContext::setBackDrawBuffer):
(WebCore::WebGLRenderingContext::restoreCurrentFramebuffer):
(WebCore::WebGLRenderingContext::restoreCurrentTexture2D):
(WebCore::WebGLRenderingContext::supportsDrawBuffers): a cached version of EXTDrawBuffers::supports()
* html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. AppleWin build fix.
roger_fong@apple.com [Sat, 23 Mar 2013 00:44:31 +0000 (00:44 +0000)]
Unreviewed. AppleWin build fix.

* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
* JavaScriptCore.vcxproj/copy-files.cmd:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Test expectations after Skia changes
schenney@chromium.org [Sat, 23 Mar 2013 00:37:15 +0000 (00:37 +0000)]
[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

fast/text/...

* platform/chromium-linux/fast/text/emphasis-avoid-ruby-expected.png: Added.
* platform/chromium-linux/fast/text/shadow-translucent-fill-expected.png:
* platform/chromium-linux/fast/text/stroking-decorations-expected.png:
* platform/chromium-linux/fast/text/stroking-expected.png:
* platform/chromium-linux/fast/transforms/shadows-expected.png:
* platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.png:
* platform/chromium-mac-lion/fast/text/international/bold-bengali-expected.png:
* platform/chromium-mac-lion/fast/text/international/text-spliced-font-expected.png:
* platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.png:
* platform/chromium-mac-lion/fast/text/justify-ideograph-vertical-expected.png:
* platform/chromium-mac-lion/fast/text/orientation-sideways-expected.png:
* platform/chromium-mac-lion/fast/text/shadow-translucent-fill-expected.png:
* platform/chromium-mac-lion/fast/text/stroking-decorations-expected.png:
* platform/chromium-mac-lion/fast/text/stroking-expected.png:
* platform/chromium-mac-lion/fast/text/whitespace/024-expected.png:
* platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-001-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-002-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-003-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png:
* platform/chromium-mac-snowleopard/fast/text/justify-ideograph-vertical-expected.png:
* platform/chromium-mac-snowleopard/fast/text/shadow-translucent-fill-expected.png:
* platform/chromium-mac-snowleopard/fast/text/whitespace/024-expected.png:
* platform/chromium-mac/fast/text/decorations-with-text-combine-expected.png:
* platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
* platform/chromium-mac/fast/text/shadow-translucent-fill-expected.png:
* platform/chromium-mac/fast/text/stroking-decorations-expected.png:
* platform/chromium-mac/fast/text/stroking-expected.png:
* platform/chromium-mac/fast/text/whitespace/024-expected.png:
* platform/chromium-mac/fast/transforms/shadows-expected.png:
* platform/chromium-win-xp/fast/text/stroking-decorations-expected.png:
* platform/chromium-win-xp/fast/text/stroking-expected.png:
* platform/chromium-win/fast/text/international/bold-bengali-expected.png:
* platform/chromium-win/fast/text/international/bold-bengali-expected.txt:
* platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
* platform/chromium-win/fast/text/stroking-decorations-expected.png:
* platform/chromium-win/fast/text/stroking-expected.png:
* platform/chromium-win/fast/transforms/shadows-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/fast/text/international/bold-bengali-expected.png: Removed.
* platform/efl-wk2/fast/text/shadow-translucent-fill-expected.png: Added.
* platform/efl/fast/text/shadow-translucent-fill-expected.png: Removed.
* platform/qt-unknown/fast: Added.
* platform/qt-unknown/fast/text: Added.
* platform/qt-unknown/fast/text/international: Added.
* platform/qt-unknown/fast/text/international/text-spliced-font-expected.png: Added.
* platform/qt/fast/text/international/text-spliced-font-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEWS should use a human readable port name when uploading layout test archives
rniwa@webkit.org [Sat, 23 Mar 2013 00:31:14 +0000 (00:31 +0000)]
EWS should use a human readable port name when uploading layout test archives
https://bugs.webkit.org/show_bug.cgi?id=113099

Reviewed by Dirk Pranke.

Use new port's object's name() method to report human readable port names.
This will also help us resolving the bug to apply layout test results posted by EWS.

* Scripts/webkitpy/tool/bot/botinfo.py:
(BotInfo.__init__): Take port's name.
(BotInfo.summary_text):

* Scripts/webkitpy/tool/bot/botinfo_unittest.py:
(BotInfoTest.test_summary_text):

* Scripts/webkitpy/tool/bot/flakytestreporter.py:
(FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.

* Scripts/webkitpy/tool/commands/queues.py:
(PatchProcessingQueue.__init__): Initialize self._port.
(PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
and use that for the attachment filename and the comment posted.

* Scripts/webkitpy/tool/commands/queues_unittest.py:
(PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
"mac-snowleopard" as expected for TestPort.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Test expectations after Skia changes
schenney@chromium.org [Sat, 23 Mar 2013 00:26:19 +0000 (00:26 +0000)]
[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

One I missed.

* platform/chromium-mac-lion/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Fix AppleWin port following https://bugs.webkit.org/show_bug.cgi?id=113100.
roger_fong@apple.com [Sat, 23 Mar 2013 00:24:10 +0000 (00:24 +0000)]
Unreviewed. Fix AppleWin port following https://bugs.webkit.org/show_bug.cgi?id=113100.
Patch by Alexey Proskuryakov.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::platformLoadResourceSynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago-[TinyDOMNode dealloc] should call [super dealloc] when ARC is not enabled
mhahnenberg@apple.com [Sat, 23 Mar 2013 00:21:22 +0000 (00:21 +0000)]
-[TinyDOMNode dealloc] should call [super dealloc] when ARC is not enabled
https://bugs.webkit.org/show_bug.cgi?id=113054

Reviewed by Geoffrey Garen.

* API/tests/testapi.mm:
(-[TinyDOMNode dealloc]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Fix AppleWin port following https://bugs.webkit.org/show_bug.cgi?id=113100.
roger_fong@apple.com [Sat, 23 Mar 2013 00:14:36 +0000 (00:14 +0000)]
Unreviewed. Fix AppleWin port following https://bugs.webkit.org/show_bug.cgi?id=113100.
Patch by Alexey Proskuryakov.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::platformLoadResourceSynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTrivial fixes to the gyp-build autogen.sh script.
kov@webkit.org [Sat, 23 Mar 2013 00:10:39 +0000 (00:10 +0000)]
Trivial fixes to the gyp-build autogen.sh script.

Reviewed by Martin Robinson (mrobinson).

* gyp/autogen.sh: add /bin/sh -e as hashbang, so stricter shells will be happy to
run the script; deal with automake exiting with an error code because there is no
Makefile.am for it to work on.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPlugin Snapshotting: Auto-start dominant plugins
timothy_horton@apple.com [Sat, 23 Mar 2013 00:00:28 +0000 (00:00 +0000)]
Plugin Snapshotting: Auto-start dominant plugins
​https://bugs.webkit.org/show_bug.cgi?id=113111
<rdar://problem/13475726>

Reviewed by Dean Jackson.

Add a test for http://trac.webkit.org/changeset/146679.

* platform/mac-wk2/plugins/snapshotting/autoplay-dominant-expected.txt: Added.
* plugins/snapshotting/autoplay-dominant.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r146272): layout issues for flex boxes that have -webkit-flex-wrap: wrap
tony@chromium.org [Fri, 22 Mar 2013 23:58:42 +0000 (23:58 +0000)]
REGRESSION (r146272): layout issues for flex boxes that have -webkit-flex-wrap: wrap
https://bugs.webkit.org/show_bug.cgi?id=113071

Reviewed by Ojan Vafai.

Source/WebCore:

The refactor in r139535 introduced this bug, where a variable name wasn't updated properly.
In combination with r146272, this bug became more visible when nesting multiline flexboxen.

Test: css3/flexbox/multiline-min-preferred-width.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths): We want the width of the widest
flexitem, the value in m_minPreferredWidth isn't relevant. Also update the comment for max
preferred width.

LayoutTests:

* css3/flexbox/multiline-min-preferred-width-expected.txt: Added.
* css3/flexbox/multiline-min-preferred-width.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shaders] Clamp css_MixColor before the blending and compositing steps
mvujovic@adobe.com [Fri, 22 Mar 2013 23:56:04 +0000 (23:56 +0000)]
[CSS Shaders] Clamp css_MixColor before the blending and compositing steps
https://bugs.webkit.org/show_bug.cgi?id=113088

Reviewed by Dean Jackson.

Source/WebCore:

The blending and compositing operations from the spec [1] expect that they are operating on
valid color inputs, in the range [0.0, 1.0]. Thus, we should clamp the css_MixColor input to
this range to avoid implementation-dependent behavior for invalid color inputs.

[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blending

Tests: css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html
       css3/filters/custom/custom-filter-clamp-css-mix-color.html

* platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader):
    Clamp css_MixColor as clampedMixColor before using it in the blending and compositing
    steps.

LayoutTests:

* css3/filters/custom/custom-filter-clamp-css-mix-color-expected.html: Added.
* css3/filters/custom/custom-filter-clamp-css-mix-color-negative-expected.html: Added.
* css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html: Added.
* css3/filters/custom/custom-filter-clamp-css-mix-color.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoopaqueJSClassData should be cached on JSGlobalObject, not the JSGlobalData
mhahnenberg@apple.com [Fri, 22 Mar 2013 23:49:52 +0000 (23:49 +0000)]
opaqueJSClassData should be cached on JSGlobalObject, not the JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=113086

Reviewed by Geoffrey Garen.

opaqueJSClassData stores cached prototypes for JSClassRefs in the C API. It doesn't make sense to
share these prototypes within a JSGlobalData across JSGlobalObjects, and in fact doing so will cause
a leak of the original JSGlobalObject that these prototypes were created in. Therefore we should move
this cache to JSGlobalObject where it belongs and where it won't cause memory leaks.

* API/JSBase.cpp: Needed to add an extern "C" so that testapi.c can use the super secret GC function.
* API/JSClassRef.cpp: We now grab the cached context data from the global object rather than the global data.
(OpaqueJSClass::contextData):
* API/JSClassRef.h: Remove this header because it's unnecessary and causes circular dependencies.
* API/tests/testapi.c: Added a new test that makes sure that using the same JSClassRef in two different contexts
doesn't cause leaks of the original global object.
(leakFinalize):
(nestedAllocateObject): This is a hack to bypass the conservative scan of the GC, which was unnecessarily marking
objects and keeping them alive, ruining the test result.
(testLeakingPrototypesAcrossContexts):
(main):
* API/tests/testapi.mm: extern "C" this so we can continue using it here.
* runtime/JSGlobalData.cpp: Remove JSClassRef related stuff.
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSGlobalObject.h: Add the stuff that JSGlobalData had. We add it to JSGlobalObjectRareData so that
clients who don't use the C API don't have to pay the memory cost of this extra HashMap.
(JSGlobalObject):
(JSGlobalObjectRareData):
(JSC::JSGlobalObject::opaqueJSClassData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Add WebCoreDOM to the gyp build
mrobinson@webkit.org [Fri, 22 Mar 2013 23:48:40 +0000 (23:48 +0000)]
[GTK] Add WebCoreDOM to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=112737

Reviewed by Nico Weber.

* WebCore.gyp/WebCoreGTK.gyp: Add WebCoreDOM to the gyp build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Add WebCoreHTML to the gyp build
mrobinson@webkit.org [Fri, 22 Mar 2013 23:47:27 +0000 (23:47 +0000)]
[GTK] Add WebCoreHTML to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=112727

Reviewed by Nico Weber.

* WebCore.gyp/WebCoreGTK.gyp: Add support for building all files under
the HTML directory. This includes splitting off common WebCore dependencies
into an aggregate target and adding a top-level WebCore target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPlugin Snapshotting: Auto-start dominant plugins
timothy_horton@apple.com [Fri, 22 Mar 2013 23:43:21 +0000 (23:43 +0000)]
Plugin Snapshotting: Auto-start dominant plugins
https://bugs.webkit.org/show_bug.cgi?id=113111
<rdar://problem/13475726>

Reviewed by Dean Jackson.

* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
Acknowledge the new "Restarting" DisplayState.
* html/HTMLPlugInElement.h:
Rename PlayingWithPendingMouseClick to RestartingWithPendingMouseClick for accuracy.
Add "Restarting" DisplayState, so we can be aware that the plugin is intentionally restarting and not re-snapshot it.
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Remove m_isPrimarySnapshottedPlugIn.
(WebCore::classNameForShadowRoot): Remove m_isPrimarySnapshottedPlugIn.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Restart the plugin when it becomes primary.
(WebCore::HTMLPlugInImageElement::updateSnapshotInfo): Remove m_isPrimarySnapshottedPlugIn.
(WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn):
Move the plugin to Restarting unless it's already marked as PendingMouseClick.
(WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired): Match the PlayingWithPendingMouseClick rename.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Don't snapshot if we're restarting.
* html/HTMLPlugInImageElement.h: Remove m_isPrimarySnapshottedPlugIn.
* rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::paint): Acknowledge the new "Restarting" DisplayState.
(WebCore::RenderSnapshottedPlugIn::getCursor): Acknowledge the new "Restarting" DisplayState.
(WebCore::RenderSnapshottedPlugIn::handleEvent): Match the PlayingWithPendingMouseClick rename.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin):
(WebKit::PluginView::paint):
(WebKit::PluginView::invalidateRect):
(WebKit::PluginView::isAcceleratedCompositingEnabled):
Acknowledge the new "Restarting" DisplayState.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Mark test as expected to timeout.
pkasting@chromium.org [Fri, 22 Mar 2013 23:43:11 +0000 (23:43 +0000)]
[chromium] Mark test as expected to timeout.
https://bugs.webkit.org/show_bug.cgi?id=113114

Unreviewed, test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Add support for building the WebCore bindings to the gyp build
mrobinson@webkit.org [Fri, 22 Mar 2013 23:40:45 +0000 (23:40 +0000)]
[GTK] Add support for building the WebCore bindings to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=112638

Reviewed by Nico Weber.

Source/JavaScriptCore:

* JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Export all include directories to direct
dependents and fix the indentation of the libjavascriptcore target.

Source/WebCore:

Add targets, actions, and rules for building the WebCore bindings. This is
the first part of the WebCoreGTK build.

* WebCore.gyp/ConvertFileToHeaderWithCharacterArray.gypi: Added.
* WebCore.gyp/MakeNames.gypi: Added.
* WebCore.gyp/WebCoreGTK.gyp: Added WebCore bindings build. This has been adapted
from the Chromium build.
* WebCore.gypi: Updated list of derived sources files and added a parameter
for adjusting the location of the built files. We don't want to force the
Mac build to change, but we'd still like to reuse the scripts that the
Chromium build uses.

Source/WebKit/gtk:

* gyp/Configuration.gypi.in: Added options for enabling SVG and setting the location of
the WebCore derived sources.
* gyp/run-gyp: Include the gyp scripts directory on the Python path and make the WebCoreGTK
gyp file the default for the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] [gyp] Expose a few more compiler defines for the gyp build
mrobinson@webkit.org [Fri, 22 Mar 2013 23:29:19 +0000 (23:29 +0000)]
[GTK] [gyp] Expose a few more compiler defines for the gyp build
https://bugs.webkit.org/show_bug.cgi?id=113109

Reviewed by Gustavo Noronha Silva.

* gyp/Configuration.gypi.in: Expose the version number string and data
directory to the gyp build as command-line arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] [gyp] Feature defines are not space separated
mrobinson@webkit.org [Fri, 22 Mar 2013 23:28:33 +0000 (23:28 +0000)]
[GTK] [gyp] Feature defines are not space separated
https://bugs.webkit.org/show_bug.cgi?id=113108

Reviewed by Gustavo Noronha Silva.

* gyp/configure.ac: Properly export feature defines for gyp during
configure phase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Build fix in InputHandler
commit-queue@webkit.org [Fri, 22 Mar 2013 23:23:07 +0000 (23:23 +0000)]
[BlackBerry] Build fix in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=113092

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-03-22
Reviewed by Rob Buis.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setElementUnfocused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAfter switching to another space and back, video races to catch up with audio
jer.noble@apple.com [Fri, 22 Mar 2013 23:12:36 +0000 (23:12 +0000)]
After switching to another space and back, video races to catch up with audio
https://bugs.webkit.org/show_bug.cgi?id=113006

Reviewed by Anders Carlsson.

Add an observer for the NSWorkspaceActiveSpaceDidChangeNotification notification, and trigger
a visibility update when that notification is observed.

* UIProcess/API/mac/WKView.mm:
(-[WKView dealloc]): Unregister the observer.
(-[WKView _activeSpaceDidChange:]): Notify the view that its visibility may have changed.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): Add the observer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd client callbacks to notify of changes of associated from controls
commit-queue@webkit.org [Fri, 22 Mar 2013 23:11:59 +0000 (23:11 +0000)]
Add client callbacks to notify of changes of associated from controls
https://bugs.webkit.org/show_bug.cgi?id=110375

Patch by Dane Wallinga <dgwallinga@chromium.org> on 2013-03-22
Reviewed by Ryosuke Niwa.

Source/WebCore:

Hook FormAssociatedElement, HTMLFormElement to notify EditorClient of form changes after a page has loaded.
Will be used to add autofill support for ajax-y webpages. e.g if while filling out a form, new fields
are dynamically created, autofill can know to re-query the autofill server and keep going.
https://bugs.webkit.org/show_bug.cgi?id=110375

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::didAssociateFormControl):
(WebCore):
(WebCore::Document::didAssociateFormControlsTimerFired):
* dom/Document.h:
(Document):
added method didAssociateFormControl, which batches form changes
and calls out to ChromeClient on a timer.
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::resetFormOwner):
(WebCore::FormAssociatedElement::formAttributeChanged):
(WebCore):
* html/FormAssociatedElement.h:
(FormAssociatedElement):
add calls to Document::didAssociateFormControl when form changes
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::insertedInto):
(WebCore):
* html/HTMLFormElement.h:
add call to Document::didAssociateFormControl
* loader/EmptyClients.h:
(EmptyChromeClient):
(WebCore::EmptyChromeClient::didAssociateFormControls):
(WebCore::EmptyChromeClient::shouldNotifyOnFormChanges):
* page/ChromeClient.h:
(ChromeClient):
add new method didAssociateFormControls

Source/WebKit/chromium:

Implement form association methods of ChromeClient
to inform autofill of form changes after a page has loaded

* public/WebAutofillClient.h:
(WebAutofillClient):
(WebKit::WebAutofillClient::didAssociateInput):
(WebKit::WebAutofillClient::didAddForm):
(WebKit::WebAutofillClient::didAssociateFormControls):
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::didAssociateFormControls):
(WebKit):
(WebKit::ChromeClientImpl::shouldNotifyOnFormChanges):
* src/ChromeClientImpl.h:
(ChromeClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Test expectations after Skia changes
schenney@chromium.org [Fri, 22 Mar 2013 23:02:56 +0000 (23:02 +0000)]
[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

The next round.

Too many files to list, plus ...
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix some minor issues in the DFG's profiling of heap accesses
fpizlo@apple.com [Fri, 22 Mar 2013 23:00:57 +0000 (23:00 +0000)]
Fix some minor issues in the DFG's profiling of heap accesses
https://bugs.webkit.org/show_bug.cgi?id=113010

Reviewed by Goeffrey Garen.

1) If a CodeBlock gets jettisoned by GC, we should count the exit sites.

2) If a CodeBlock clears a structure stub during GC, it should record this, and
the DFG should prefer to not inline that access (i.e. treat it as if it had an
exit site).

3) If a PutById was seen by the baseline JIT, and the JIT attempted to cache it,
but it chose not to, then assume that it will take slow path.

4) If we frequently exited because of a structure check on a weak constant,
don't try to inline that access in the future.

5) Treat all exits that were counted as being frequent.

81% speed-up on Octane/gbemu. Small speed-ups elsewhere, and no regressions.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeUnconditionally):
(JSC):
(JSC::CodeBlock::resetStubDuringGCInternal):
(JSC::CodeBlock::reoptimize):
(JSC::CodeBlock::jettison):
(JSC::ProgramCodeBlock::jettisonImpl):
(JSC::EvalCodeBlock::jettisonImpl):
(JSC::FunctionCodeBlock::jettisonImpl):
(JSC::CodeBlock::tallyFrequentExitSites):
* bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::tallyFrequentExitSites):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::StructureStubInfo):
(StructureStubInfo):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
* dfg/DFGOSRExit.h:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):
(OSRExit):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Options.h:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoName correctly the argument of StringImpl::setIsAtomic()
benjamin@webkit.org [Fri, 22 Mar 2013 22:49:33 +0000 (22:49 +0000)]
Name correctly the argument of StringImpl::setIsAtomic()
https://bugs.webkit.org/show_bug.cgi?id=113000

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-22
Reviewed by Geoffrey Garen.

* wtf/text/StringImpl.h:
(WTF::StringImpl::setIsAtomic):
The argument was probably an unfortunate copy-paste from setIsIdentifier().
Fix the name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago Split ResourceHandleMac into multiple files
ap@apple.com [Fri, 22 Mar 2013 22:44:07 +0000 (22:44 +0000)]
    Split ResourceHandleMac into multiple files
        https://bugs.webkit.org/show_bug.cgi?id=113100

        Reviewed by Geoff Garen.

        It's grown too big to navigate, and I'm going to make WebCoreResourceHandleAsDelegate
        substantially more complicated yet.

        1. Mechanically moved WebCoreResourceHandleAsDelegate into separate files.
        2. Refactored WebCoreSynchronousLoaderClient to be cross-platform, and moved it into
        separate files.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcxproj/WebCore.vcxproj:
        * WebCore.vcxproj/WebCore.vcxproj.filters:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/network/SynchronousLoaderClient.cpp: Added.
        * platform/network/SynchronousLoaderClient.h: Added.
        * platform/network/cf/ResourceHandleCFNet.cpp:
        * platform/network/mac/SynchronousLoaderClient.mm: Added.
        * platform/network/mac/WebCoreResourceHandleAsDelegate.h: Added.
        * platform/network/mac/WebCoreResourceHandleAsDelegate.mm: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Test expectation after Skia changes
schenney@chromium.org [Fri, 22 Mar 2013 22:38:58 +0000 (22:38 +0000)]
[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

SVG and Compositing tests

Too many files to list, plus ...
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the expected image result as r78910 committed a bad expected result.
rniwa@webkit.org [Fri, 22 Mar 2013 22:24:52 +0000 (22:24 +0000)]
Fix the expected image result as r78910 committed a bad expected result.
See http://trac.webkit.org/changeset/78910/trunk/LayoutTests/platform/mac/editing/deleting/deletionUI-single-instance-expected.png

* platform/mac/editing/deleting/deletionUI-single-instance-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded a setting for whether JavaScript markup is enabled
ggaren@apple.com [Fri, 22 Mar 2013 22:19:52 +0000 (22:19 +0000)]
Added a setting for whether JavaScript markup is enabled
https://bugs.webkit.org/show_bug.cgi?id=112999

Reviewed by Maciej Stachowiak.

This setting is useful for clients that want protection from script
injection attacks.

../WebCore:

* page/Settings.h:
(Settings): Clarified which clients should call canExecuteScripts().

* page/Settings.in: Added the new setting.

../WebKit2:

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesGetJavaScriptMarkupEnabled):
(WKPreferencesSetJavaScriptMarkupEnabled):
(WKPreferencesGetJavaScriptEnabled):
* UIProcess/API/C/WKPreferences.h:
* UIProcess/API/mac/WKBrowsingContextGroup.mm:
(-[WKBrowsingContextGroup allowsJavaScriptMarkup]):
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Plumbed through to API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a failing test expectation to media/track/track-prefer-captions.html on Windows...
rniwa@webkit.org [Fri, 22 Mar 2013 22:19:08 +0000 (22:19 +0000)]
Add a failing test expectation to media/track/track-prefer-captions.html on Windows after r146647.
The failure is tracked by the bug 113106.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] editing/pasteboard/can-read-in-copy-and-cut-events.html fails
rniwa@webkit.org [Fri, 22 Mar 2013 22:06:02 +0000 (22:06 +0000)]
[Win] editing/pasteboard/can-read-in-copy-and-cut-events.html fails
https://bugs.webkit.org/show_bug.cgi?id=113102

Skip a test added by r146644 since writing into clipboard is not supported on Windows port.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix.
roger_fong@apple.com [Fri, 22 Mar 2013 22:04:43 +0000 (22:04 +0000)]
Unreviewed build fix.

* bindings/scripts/preprocessor.pm:
(applyPreprocessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate svg/custom/marker-orient-auto expectations
pdr@google.com [Fri, 22 Mar 2013 22:03:01 +0000 (22:03 +0000)]
Update svg/custom/marker-orient-auto expectations

Unreviewed update of test expectations.

* platform/chromium-mac-lion/svg/custom/marker-orient-auto-expected.png: Added.
* platform/chromium-mac-lion/svg/custom/marker-orient-auto-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/marker-orient-auto-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/marker-orient-auto-expected.txt: Added.
* platform/chromium-mac/svg/custom/marker-orient-auto-expected.png: Added.
* platform/chromium-mac/svg/custom/marker-orient-auto-expected.txt: Added.
* platform/chromium-win/svg/custom/marker-orient-auto-expected.png: Added.
* platform/chromium-win/svg/custom/marker-orient-auto-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd failing test expectations for two more position: sticky tests to make Mac EWS...
rniwa@webkit.org [Fri, 22 Mar 2013 21:14:00 +0000 (21:14 +0000)]
Add failing test expectations for two more position: sticky tests to make Mac EWS happy.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNRWT: Enable pixel tests when retrying tests
rniwa@webkit.org [Fri, 22 Mar 2013 21:05:38 +0000 (21:05 +0000)]
NRWT: Enable pixel tests when retrying tests
https://bugs.webkit.org/show_bug.cgi?id=112898

Reviewed by Dirk Pranke.

Tools:

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
if we've forced pixel tests in the retry.
(Manager._run_tests):
(Manager._clean_up_run): Fixed the capitalizations.
(Manager._force_pixel_tests_if_needed): Added.

* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(_interpret_test_failures): Now that this function maybe called multiple times, only set
'image_diff_percent' if it doesn't already exist.

(summarize_results): When the first attempt resulted in a text failure and the second attempt
resulted in image and text failures and we've forced to run pixel tests in the retry run,
treat this as a regular regression instead of a flakiness.

Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
run had image diffs.

* Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
(summarized_results):

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
Also removed some dead code.

(RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
is set and pixel_tests_enabled is set to false.
(EndToEndTest.test_reftest_with_two_notrefs):

LayoutTests:

Link to images and image diff in retries when they're only available in retries.

* fast/harness/resources/results-test.js: Added a test case.
* fast/harness/results-expected.txt:
* fast/harness/results.html:
(imageResultsCell): Extracted from tableRow.
(tableRow): Split the actual result into two tokens (first attempt and retry),
and then check if the image failure was detected in the first attempt. If not,
add hyperlinks to the actual results in the retry run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate svg/custom/marker-orient-auto-expected test expectation.
pdr@google.com [Fri, 22 Mar 2013 21:00:21 +0000 (21:00 +0000)]
Update svg/custom/marker-orient-auto-expected test expectation.

Unreviewed update of test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Test expectation after Skia changes
schenney@chromium.org [Fri, 22 Mar 2013 20:59:13 +0000 (20:59 +0000)]
[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

One more not-expected failure, fixed.

* platform/chromium-mac-lion/fast/multicol/vertical-lr/nested-columns-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png:
* platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Test expectation after Skia changes
schenney@chromium.org [Fri, 22 Mar 2013 20:57:43 +0000 (20:57 +0000)]
[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

Some more currently failing (not expected) tests.

* platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-clear-expected.png:
* platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
* platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-expected.png:
* platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
* platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDFG folding of PutById to SimpleReplace should consider the specialized function...
fpizlo@apple.com [Fri, 22 Mar 2013 20:51:24 +0000 (20:51 +0000)]
DFG folding of PutById to SimpleReplace should consider the specialized function case
https://bugs.webkit.org/show_bug.cgi?id=113093

Reviewed by Geoffrey Garen and Mark Hahnenberg.

Source/JavaScriptCore:

* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):

LayoutTests:

* fast/js/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function-expected.txt: Added.
* fast/js/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function.js: Added.
(foo):
(baz):
(fuzz):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd failing test expectations to the test added by r146644 on Mac.
rniwa@webkit.org [Fri, 22 Mar 2013 20:41:56 +0000 (20:41 +0000)]
Add failing test expectations to the test added by r146644 on Mac.
The failure is tracked by http://webkit.org/b/113094.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Force kill gcc-3.exe during bindings generation tests to avoid process...
roger_fong@apple.com [Fri, 22 Mar 2013 20:36:05 +0000 (20:36 +0000)]
Unreviewed. Force kill gcc-3.exe during bindings generation tests to avoid process hangs.

This problem is occuring on the WinEWS bots where there are somehow multiple gcc-3 processes existing at the same time.
This is a speculative fix. There should only be 1 gcc-3.exe process running at a time ever.

* bindings/scripts/preprocessor.pm:
(applyPreprocessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake it possible to run layout tests on Retina MBP
timothy_horton@apple.com [Fri, 22 Mar 2013 20:34:53 +0000 (20:34 +0000)]
Make it possible to run layout tests on Retina MBP
https://bugs.webkit.org/show_bug.cgi?id=93673

Reviewed by Ryosuke Niwa.

Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
windows on 2x machines still run at 1x.

* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
Reset the window resolution to 1x on creation.
* DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
(-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
(WTR::PlatformWebView::PlatformWebView):
Add NSWindow details, reset the window resolution to 1x on creation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCleanup text track selection logic
eric.carlson@apple.com [Fri, 22 Mar 2013 20:24:35 +0000 (20:24 +0000)]
Cleanup text track selection logic
https://bugs.webkit.org/show_bug.cgi?id=113062

Reviewed by Jer Noble.

No new tests, covered by existing tests.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Remove.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Don't look at track attributes directly,
    use captionPreferences->textTrackSelectionScore to calculate track rank.
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Set m_processingPreferenceChange here
    instead of in captionPreferencesChanged.
(WebCore::HTMLMediaElement::captionPreferencesChanged): Don't suppress calls to setClosedCaptionsVisible,
    existing code already makes sure we don't do unnecessary work.
* html/HTMLMediaElement.h:

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Drive by cleanup, don't
    process inactive cues.

* html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::changedClosedCaptionsVisibility): Call resetTrackListMenu instead
    of updateDisplay so we only mark the menu as needing a recalculation and do the work when
    it is displayed.

* page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::shouldShowCaptions): When in testing mode, return true if
    the caption or subtitle preference has been set.
(WebCore::CaptionUserPreferences::setShouldShowCaptions): In testing mode, clear the caption
    and subtitle preference when passed false.
(WebCore::CaptionUserPreferences::textTrackSelectionScore): Calculate the track score based on
    track type preference and preferred language.
(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Score a track according to
    the language presence and position in the preferred languages list.
* page/CaptionUserPreferences.h:

* page/CaptionUserPreferencesMac.h:
* page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Calculate track language score
    according to user preferences.

* platform/Language.cpp:
(WebCore::indexOfBestMatchingLanguageInList): Repurposed the static bestMatchingLanguage
    function to return the location of a language in a Vector.
(WebCore::preferredLanguageFromList): Removed.
* platform/Language.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix for TransformationMatrix
commit-queue@webkit.org [Fri, 22 Mar 2013 20:16:49 +0000 (20:16 +0000)]
Build fix for TransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=113087

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-03-22
Reviewed by Martin Robinson.

This is a trivial build fix for clutter ac backend. Clutter AC backend doesn't use
TextureMapper so there is nowhere including TransformationMatrix.h.
For the reason, we include it explicitly.

No new tests because of no functionality change.

* platform/graphics/clutter/GraphicsContext3DPrivate.cpp:
* platform/graphics/clutter/GraphicsContext3DPrivate.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCoordinates.idl lacks Conditional=GEOLOCATION
commit-queue@webkit.org [Fri, 22 Mar 2013 20:14:05 +0000 (20:14 +0000)]
Coordinates.idl lacks Conditional=GEOLOCATION
https://bugs.webkit.org/show_bug.cgi?id=112949

Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
Reviewed by Steve Block.

No new tests, build optimization only.

* page/Coordinates.idl: Added GEOLOCATION conditional guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoData store should be readable in dragstart/copy/cut events
dcheng@chromium.org [Fri, 22 Mar 2013 20:04:15 +0000 (20:04 +0000)]
Data store should be readable in dragstart/copy/cut events
https://bugs.webkit.org/show_bug.cgi?id=23695

Reviewed by Tony Chang.

Source/WebCore:

There were several events where data could be written but not read back due to the fact that
different Clipboard method implementations checked permissions inconsistently. This patch
adds helper methods to check if an operation is permitted on a Clipboard and refactors all
direct comparisons against Clipboard::m_policy to use the new helpers instead. This fixes
several bugs where Clipboard::types and Clipboard::getData are not usable inside the
aforementioned events.

Tests: editing/pasteboard/can-read-in-copy-and-cut-events.html
       editing/pasteboard/can-read-in-dragstart-event.html

* dom/Clipboard.cpp:
(WebCore::Clipboard::canReadTypes): Formerly restricted to ClipboardReadable and
                                    ClipboardTypesReadable; now allows ClipboardWritable as
                                    well.
(WebCore::Clipboard::canReadData): Formerly restricted to ClipboardReadable; now allows
                                   ClipboardWritable as well.
(WebCore::Clipboard::canWriteData):
(WebCore::Clipboard::canSetDragImage):
(WebCore::Clipboard::hasFileOfType):
(WebCore::Clipboard::hasStringOfType):
(WebCore::Clipboard::setDropEffect):
(WebCore::Clipboard::setEffectAllowed):
* dom/Clipboard.h:
(Clipboard):
* platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::clearData):
(WebCore::ClipboardBlackBerry::clearAllData):
(WebCore::ClipboardBlackBerry::getData):
(WebCore::ClipboardBlackBerry::setData):
(WebCore::ClipboardBlackBerry::types):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::DataTransferItemPolicyWrapper::kind):
(WebCore::DataTransferItemPolicyWrapper::type):
(WebCore::DataTransferItemPolicyWrapper::getAsString):
(WebCore::DataTransferItemPolicyWrapper::getAsFile):
(WebCore::ClipboardChromium::clearData):
(WebCore::ClipboardChromium::clearAllData):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::setData):
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::files):
(WebCore::ClipboardChromium::setDragImage):
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::clearData):
(WebCore::ClipboardGtk::clearAllData):
(WebCore::ClipboardGtk::getData):
(WebCore::ClipboardGtk::setData):
(WebCore::ClipboardGtk::types):
(WebCore::ClipboardGtk::files):
(WebCore::ClipboardGtk::setDragImage):
* platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::clearData):
(WebCore::ClipboardMac::clearAllData):
(WebCore::ClipboardMac::getData):
(WebCore::ClipboardMac::setData):
(WebCore::ClipboardMac::types):
(WebCore::ClipboardMac::files):
(WebCore::ClipboardMac::setDragImage):
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::clearData):
(WebCore::ClipboardQt::clearAllData):
(WebCore::ClipboardQt::getData):
(WebCore::ClipboardQt::setData):
(WebCore::ClipboardQt::types):
(WebCore::ClipboardQt::files):
(WebCore::ClipboardQt::setDragImage):
(WebCore::ClipboardQt::items):
* platform/qt/DataTransferItemListQt.cpp:
(WebCore::DataTransferItemListQt::length):
(WebCore::DataTransferItemListQt::item):
(WebCore::DataTransferItemListQt::deleteItem):
(WebCore::DataTransferItemListQt::clear):
(WebCore::DataTransferItemListQt::add):
* platform/qt/DataTransferItemQt.cpp:
(WebCore::DataTransferItemQt::getAsString):
* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::clearData):
(WebCore::ClipboardWin::clearAllData):
(WebCore::ClipboardWin::getData):
(WebCore::ClipboardWin::setData):
(WebCore::ClipboardWin::types):
(WebCore::ClipboardWin::files):
(WebCore::ClipboardWin::setDragImage):

LayoutTests:

* editing/pasteboard/can-read-in-copy-and-cut-events-expected.txt: Added.
* editing/pasteboard/can-read-in-copy-and-cut-events.html: Added.
* editing/pasteboard/can-read-in-dragstart-event-expected.txt: Added.
* editing/pasteboard/can-read-in-dragstart-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Test expectation after Skia changes
schenney@chromium.org [Fri, 22 Mar 2013 20:00:13 +0000 (20:00 +0000)]
[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

Only the things failing on the bots, not already accounted for.

* platform/chromium-linux/fast/text/international/danda-space-expected.png:
* platform/chromium-mac-lion/fast/multicol/vertical-rl/nested-columns-expected.png:
* platform/chromium-mac-lion/fast/ruby/base-shorter-than-text-expected.png:
* platform/chromium-mac-lion/fast/text/emphasis-combined-text-expected.png:
* platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.png:
* platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png:
* platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
* platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png:
* platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.png:
* platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
* platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
* platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Remove pushLayoutState(RenderFlowThread*) from RenderView
abucur@adobe.com [Fri, 22 Mar 2013 19:44:30 +0000 (19:44 +0000)]
[CSS Regions] Remove pushLayoutState(RenderFlowThread*) from RenderView
https://bugs.webkit.org/show_bug.cgi?id=113084

Reviewed by Dirk Schulze.

Remove void pushLayoutState(RenderFlowThread*, bool regionsChanged) from RenderView.h because it's not used.

Tests: Code cleanup. No tests needed.

* rendering/RenderView.h:
(RenderView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCheck focused node reference when traversing through history
commit-queue@webkit.org [Fri, 22 Mar 2013 19:34:23 +0000 (19:34 +0000)]
Check focused node reference when traversing through history
https://bugs.webkit.org/show_bug.cgi?id=113082

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-03-22
Reviewed by Rob Buis.

PR312101
Check if we have a valid node and document before attempting to access its frame and
frame selection. This is causing issues when going back to a page after a redirect
where a stale pointer is used.
Further, the focused node should be changed after the frame is fully loaded.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::restoreViewState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Fix build issues to enable CSS Filter and Shaders support.
commit-queue@webkit.org [Fri, 22 Mar 2013 19:23:45 +0000 (19:23 +0000)]
[EFL] Fix build issues to enable CSS Filter and Shaders support.
https://bugs.webkit.org/show_bug.cgi?id=111274

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-22
Reviewed by Noam Rosenthal.

This is in preperation to enable CSS Filter and Shaders support.
This patch fixes related build issues to enable the support.

* platform/graphics/surfaces/efl/GLTransportSurface.cpp:
* platform/graphics/texmap/TextureMapper.cpp:
* platform/graphics/texmap/TextureMapper.h:
(WebCore):
* platform/graphics/texmap/TextureMapperGL.cpp:
* platform/graphics/texmap/TextureMapperGL.h:
(WebCore):
* platform/graphics/texmap/TextureMapperShaderProgram.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Remove Android platform expectations from Chromium TestExpectations.
pkasting@chromium.org [Fri, 22 Mar 2013 19:11:54 +0000 (19:11 +0000)]
[chromium] Remove Android platform expectations from Chromium TestExpectations.
(Too many bug URLs to list)

Unreivewed, test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement isEnabledFormControl() for SliderThumbElement and SpinButtonElement in...
falken@chromium.org [Fri, 22 Mar 2013 19:01:22 +0000 (19:01 +0000)]
Implement isEnabledFormControl() for SliderThumbElement and SpinButtonElement in terms of disabled()
https://bugs.webkit.org/show_bug.cgi?id=112993

Reviewed by Kent Tamura.

This is an intermediate step for refactoring Node::disabled and
Element::isEnabledFormControl. All classes that override
isEnabledFormControl just return !disabled(), except for
SliderThumbElement and SpinButtonElement. This patch changes those two
classes to do so, which shows that the two functions are redundant and
easy to refactor into a single function in a subsequent patch.

No new tests, there should be no behavior change.

* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::disabled):
(WebCore):
(WebCore::SliderThumbElement::isEnabledFormControl):
* html/shadow/SliderThumbElement.h:
(SliderThumbElement):
* html/shadow/SpinButtonElement.h: The check of shadowHost() is
necessary because it can be detached by JavaScript that runs during
event handling (see r76566)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Include the right GL header for GLES2
mario@webkit.org [Fri, 22 Mar 2013 18:47:36 +0000 (18:47 +0000)]
[GTK] Include the right GL header for GLES2
https://bugs.webkit.org/show_bug.cgi?id=113034

Reviewed by Martin Robinson.

Include GLES2/gl2.h when using GLES2.

Source/WebKit/gtk:

* WebCoreSupport/AcceleratedCompositingContextGL.cpp:

Source/WebKit2:

* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Hit Test doesn't need to be active
commit-queue@webkit.org [Fri, 22 Mar 2013 18:28:36 +0000 (18:28 +0000)]
[BlackBerry] Hit Test doesn't need to be active
https://bugs.webkit.org/show_bug.cgi?id=113072

Patch by Genevieve Mak <gmak@rim.com> on 2013-03-22
Reviewed by Rob Buis.

Reviewed Internally By Mike Lattanzio.
PR #306074

* WebKitSupport/ProximityDetector.cpp:
(BlackBerry::WebKit::ProximityDetector::findBestPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Support Quota API in Worker
alecflett@chromium.org [Fri, 22 Mar 2013 18:27:02 +0000 (18:27 +0000)]
[chromium] Support Quota API in Worker
https://bugs.webkit.org/show_bug.cgi?id=112713

Hook up WebKit side of queryUsageAndQuota. Tests
and WebCore code will come in https://bugs.webkit.org/show_bug.cgi?id=112972

Reviewed by David Levin.

* WebKit.gyp:
* public/WebCommonWorkerClient.h:
(WebKit::WebCommonWorkerClient::queryUsageAndQuota):
* src/StorageQuotaChromium.cpp:
(WebCore::StorageQuota::queryUsageAndQuota):
(WebCore::StorageQuota::requestQuota):
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::queryUsageAndQuota):
(WebKit):
* src/WebWorkerClientImpl.h:
* src/WorkerStorageQuotaCallbacksBridge.cpp: Added.
(WebKit):
(MainThreadStorageQuotaCallbacks):
(WebKit::MainThreadStorageQuotaCallbacks::createLeakedPtr):
(WebKit::MainThreadStorageQuotaCallbacks::~MainThreadStorageQuotaCallbacks):
(WebKit::MainThreadStorageQuotaCallbacks::didQueryStorageUsageAndQuota):
(WebKit::MainThreadStorageQuotaCallbacks::didFail):
(WebKit::MainThreadStorageQuotaCallbacks::didGrantStorageQuota):
(WebKit::MainThreadStorageQuotaCallbacks::MainThreadStorageQuotaCallbacks):
(WorkerStorageQuotaContextObserver):
(WebKit::WorkerStorageQuotaContextObserver::create):
(WebKit::WorkerStorageQuotaContextObserver::notifyStop):
(WebKit::WorkerStorageQuotaContextObserver::WorkerStorageQuotaContextObserver):
(WebKit::WorkerStorageQuotaCallbacksBridge::stop):
(WebKit::WorkerStorageQuotaCallbacksBridge::cleanUpAfterCallback):
(WebKit::WorkerStorageQuotaCallbacksBridge::WorkerStorageQuotaCallbacksBridge):
(WebKit::WorkerStorageQuotaCallbacksBridge::~WorkerStorageQuotaCallbacksBridge):
(WebKit::WorkerStorageQuotaCallbacksBridge::postQueryUsageAndQuotaToMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::queryUsageAndQuotaOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didFailOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didQueryStorageUsageAndQuotaOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didFailOnWorkerThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didQueryStorageUsageAndQuotaOnWorkerThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::runTaskOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::runTaskOnWorkerThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::mayPostTaskToWorker):
* src/WorkerStorageQuotaCallbacksBridge.h: Added.
(WebCore):
(WebKit):
(WorkerStorageQuotaCallbacksBridge):
(WebKit::WorkerStorageQuotaCallbacksBridge::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a failure test expectation to media/track/track-user-preferences.html after r146380.
rniwa@webkit.org [Fri, 22 Mar 2013 18:13:36 +0000 (18:13 +0000)]
Add a failure test expectation to media/track/track-user-preferences.html after r146380.
The failure is tracked by the webkit.org/b/113083.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] New fast/text/word-space-with-kerning-3.html fails on Qt.
allan.jensen@digia.com [Fri, 22 Mar 2013 17:51:11 +0000 (17:51 +0000)]
[Qt] New fast/text/word-space-with-kerning-3.html fails on Qt.
https://bugs.webkit.org/show_bug.cgi?id=112668

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Qt adds word-spacing to leading spaces, but WebCore only expects
us to add for trailing spaces. We only corrected for this in width
calculation but do need to also do it for drawing.

Instead of subtracting the extra word-spacing we now configure the
FormatRange not to apply to leading spaces. This means this behavior
will be applied everywhere reliably.

* platform/graphics/Font.h:
(Font):
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::initFormatForTextLayout):

LayoutTests:

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r146540?): Crashes in storage/indexeddb/factory-basics-workers.html,...
jsbell@chromium.org [Fri, 22 Mar 2013 17:41:26 +0000 (17:41 +0000)]
REGRESSION (r146540?): Crashes in storage/indexeddb/factory-basics-workers.html, storage/indexeddb/transaction-error.html
https://bugs.webkit.org/show_bug.cgi?id=113019

Reviewed by Tony Chang.

Also manifesting flakily under Chromium's content_shell. It's an ASSERT being hit in
the IDBTransaction destructor. The cause was r146540 which allows a stopped context
to reclaim script wrappers. This allows the IDBTransaction to be deref'd at times where
it previously would have just leaked. Modulate the destructor assertions to account
for this case.

No new tests; failures already manifest as flaky crashes in some ports.

* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::~IDBTransaction): If context is stopped, expected state
transitions/cleanup may not have occurred before destructor runs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIndexedDB: Histogram available disk space on attempt to open database
dgrogan@chromium.org [Fri, 22 Mar 2013 17:34:20 +0000 (17:34 +0000)]
IndexedDB: Histogram available disk space on attempt to open database
https://bugs.webkit.org/show_bug.cgi?id=112862

Reviewed by Tony Chang.

Source/Platform:

* chromium/public/Platform.h:
(WebKit::Platform::availableDiskSpaceInBytes):
(Platform):

Source/WebCore:

ChromeOS suspects they might be hitting disk corruption when the disks
are nearly full. This patch logs the available space to either the
"success" or the "fail" histogram as appropriate so that the
distributions can be compared.

No new tests - I don't know of a good way to test histograms. Local
printf testing didn't turn up any bugs.

* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::HistogramFreeSpace):
(WebCore):
(WebCore::LevelDBDatabase::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Selection overlay clipped incorrectly
commit-queue@webkit.org [Fri, 22 Mar 2013 17:11:53 +0000 (17:11 +0000)]
[BlackBerry] Selection overlay clipped incorrectly
https://bugs.webkit.org/show_bug.cgi?id=113069

Patch by Andrew Lo <anlo@rim.com> on 2013-03-22
Reviewed by George Staikos.
Internally reviewed by Arvid Nilsson.

As a follow-up to r146278, the clip rect also needs to be
adjusted by the parent's offset when drawing the
selection overlay.

* WebKitSupport/SelectionOverlay.cpp:
(BlackBerry::WebKit::SelectionOverlay::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r146239): Reproducible crash in WebCore::DocumentLoader::responseReceived.
japhet@chromium.org [Fri, 22 Mar 2013 17:05:12 +0000 (17:05 +0000)]
REGRESSION (r146239): Reproducible crash in WebCore::DocumentLoader::responseReceived.
https://bugs.webkit.org/show_bug.cgi?id=112811

Reviewed by Brady Eidson.

Source/WebCore:

Test: http/tests/cache/x-frame-options-304.html

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::switchClientsToRevalidatedResource):
* loader/cache/CachedRawResource.h:

LayoutTests:

* http/tests/cache/resources/x-frame-options.php: Added.
* http/tests/cache/x-frame-options-304-expected.txt: Added.
* http/tests/cache/x-frame-options-304.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLeak bots shouldn't build
rniwa@webkit.org [Fri, 22 Mar 2013 17:03:12 +0000 (17:03 +0000)]
Leak bots shouldn't build
https://bugs.webkit.org/show_bug.cgi?id=112774

Reviewed by Simon Fraser.

Since leak bots use regular debug builds, there is no need to build on these bots.
Simply downloading builds will dramatically improve the cycle time of these bots.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
TestFactory instead of BuildAndTestFactory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd flaky crash expectations on some media tests per bugs 113075 and 113076.
rniwa@webkit.org [Fri, 22 Mar 2013 16:58:59 +0000 (16:58 +0000)]
Add flaky crash expectations on some media tests per bugs 113075 and 113076.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION: -webkit-box-reflect does not show on video elements
jer.noble@apple.com [Fri, 22 Mar 2013 16:24:48 +0000 (16:24 +0000)]
REGRESSION: -webkit-box-reflect does not show on video elements
https://bugs.webkit.org/show_bug.cgi?id=112397

Reviewed by Eric Carlson.

Work around the ASSERTs generated when setting an AVPlayerLayer's player property
during a CA flush by setting the player property during the next runloop, outside
of a CA flush.

* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::clone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Curl] Performance fix, avoid loading cookie file on every request.
commit-queue@webkit.org [Fri, 22 Mar 2013 16:22:26 +0000 (16:22 +0000)]
[Curl] Performance fix, avoid loading cookie file on every request.
https://bugs.webkit.org/show_bug.cgi?id=113023

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-03-22
Reviewed by Brent Fulgham.

We currently load the cookie file on every request, and when setting cookies from JavaScript, by using the option CURLOPT_COOKIEFILE.
This is very inefficient as the cookie file can get quite large, and file I/O is slow.
It is sufficient to load the cookie file on startup, as we use a shared cookie database between the requests.

* platform/network/curl/CookieJarCurl.cpp:
(WebCore::setCookiesFromDOM): Avoid loading cookie file when setting cookies from JavaScript.
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::initializeHandle): Avoid loading cookie file on every request.
(WebCore::ResourceHandleManager::initCookieSession): Load the cookie file to shared database on startup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Update Input field Background Color
commit-queue@webkit.org [Fri, 22 Mar 2013 16:08:54 +0000 (16:08 +0000)]
[BlackBerry] Update Input field Background Color
https://bugs.webkit.org/show_bug.cgi?id=113063

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-03-22
Reviewed by George Staikos.

RIM PR 307463.
Internally reviewed by Ed Baker.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintTextFieldOrTextAreaOrSearchField):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: FlameChart. Draw function names over flame chart bar if they fit into...
loislo@chromium.org [Fri, 22 Mar 2013 15:56:22 +0000 (15:56 +0000)]
Web Inspector: FlameChart. Draw function names over flame chart bar if they fit into the bar.
https://bugs.webkit.org/show_bug.cgi?id=113052

Reviewed by Vsevolod Vlasov.

The draw function will draw the bar title if the text is less than bar width.
Unfortunately almost all the projects which need to be profiled
use long function names with dots. So if the function name has dots and
doesn't fit into the space then prepareTitle will try to drop the prefix before dot.
If the title has no dots then the function will strip the tail of the title.

* inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._prepareTitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Update test expectations for a bunch of softwarecompositing tests.
yurys@chromium.org [Fri, 22 Mar 2013 15:55:11 +0000 (15:55 +0000)]
Unreviewed. Update test expectations for a bunch of softwarecompositing tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Add "hidden" attribute to the recently added APIs in Inspector.json
commit-queue@webkit.org [Fri, 22 Mar 2013 15:44:51 +0000 (15:44 +0000)]
Web Inspector: Add "hidden" attribute to the recently added APIs in Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=113061

Added "hidden": true to the APIs introduced since version 1.0.

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-22
Reviewed by Pavel Feldman.

* inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebKit/chromium: Skia flag removal to enable bug fixes and performance improve...
schenney@chromium.org [Fri, 22 Mar 2013 15:39:31 +0000 (15:39 +0000)]
Source/WebKit/chromium: Skia flag removal to enable bug fixes and performance improvements.

Unreviewed code enabling.

* skia_webkit.gyp:

LayoutTests: Enabling Skia features/modifications.

Unreviewed Chromium expectations, all of which will be removed later today.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Correctly implement scrollToLine, revealLine and setSelection on CodeM...
vsevik@chromium.org [Fri, 22 Mar 2013 15:22:50 +0000 (15:22 +0000)]
Web Inspector: Correctly implement scrollToLine, revealLine and setSelection on CodeMirror  editor.
https://bugs.webkit.org/show_bug.cgi?id=113028

Reviewed by Pavel Feldman.

Added focus event handler to CodeMirror editor view elememnt to support inspector's focus model.
Added selection and scroll listeners to correctly save editor scroll and selection in history.
Implemented revealLine, scrollToLine and setSelection.
Note: CodeMirror's coordsChar method does not work correctly in "local" mode, implemented as binary search
as a temporary workaround.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.defaultFocusedElement):
(WebInspector.CodeMirrorTextEditor.prototype._handleElementFocus):
(WebInspector.CodeMirrorTextEditor.prototype.revealLine):
(WebInspector.CodeMirrorTextEditor.prototype._coordsChar):
(WebInspector.CodeMirrorTextEditor.prototype._topScrolledLine):
(WebInspector.CodeMirrorTextEditor.prototype._bottomScrolledLine):
(WebInspector.CodeMirrorTextEditor.prototype._scroll):
(WebInspector.CodeMirrorTextEditor.prototype._selectionChange):
(WebInspector.CodeMirrorTextEditor.prototype.scrollToLine):
(WebInspector.CodeMirrorTextEditor.prototype.setSelection):
(WebInspector.CodeMirrorTextEditor.prototype.copyRange):
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.copyRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [Regression] Editor scroll is not restored after inspector reload.
vsevik@chromium.org [Fri, 22 Mar 2013 15:16:27 +0000 (15:16 +0000)]
Web Inspector: [Regression] Editor scroll is not restored after inspector reload.
https://bugs.webkit.org/show_bug.cgi?id=113027

Reviewed by Pavel Feldman.

* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype._isEditorShowing):
(WebInspector.SourceFrame.prototype._innerHighlightLineIfNeeded):
(WebInspector.SourceFrame.prototype._innerRevealLineIfNeeded):
(WebInspector.SourceFrame.prototype._innerScrollToLineIfNeeded):
(WebInspector.SourceFrame.prototype._innerSetSelectionIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Fix build with OPENCL 1.2
allan.jensen@digia.com [Fri, 22 Mar 2013 15:04:10 +0000 (15:04 +0000)]
[Qt] Fix build with OPENCL 1.2
https://bugs.webkit.org/show_bug.cgi?id=113056

Reviewed by Kenneth Rohde Christiansen.

Switch qmake checks to the modern style which means we can enable OpenCL with
WEBKIT_CONFIG+=opencl.

Upgrade OpenCL 1.1 clCreateImage2D to OpenCL 1.2 clCreateImage calls.

* Target.pri:
* WebCore.pri:
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::createOpenCLImageResult):
* platform/graphics/gpu/opencl/FilterContextOpenCL.cpp:
(WebCore::FilterContextOpenCL::createOpenCLImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTelugu [te] language translation submission for WebKitGTK+ HEAD
kov@webkit.org [Fri, 22 Mar 2013 14:54:05 +0000 (14:54 +0000)]
Telugu [te] language translation submission for WebKitGTK+ HEAD
https://bugs.webkit.org/show_bug.cgi?id=103052

Patch by Krishnababu Krothapalli <kkrothap@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).

* te.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed chromium rebaselines for r146600.
eae@chromium.org [Fri, 22 Mar 2013 14:45:18 +0000 (14:45 +0000)]
Unreviewed chromium rebaselines for r146600.

* platform/chromium-mac-lion/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
* platform/chromium-mac-lion/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
* platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.png:
* platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
* platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.txt:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
* platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][AC] Opacity animation doesn't work with clutter backend
commit-queue@webkit.org [Fri, 22 Mar 2013 14:42:16 +0000 (14:42 +0000)]
[GTK][AC] Opacity animation doesn't work with clutter backend
https://bugs.webkit.org/show_bug.cgi?id=110347

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva.

The static casting in ternary operator doesn't change actual inputted argument type.
So I replaced it with if-else statement.

Covered by existing animation tests.

* platform/graphics/clutter/PlatformClutterAnimation.cpp:
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore::PlatformClutterAnimation::addClutterKeyframeTransitionForProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][AC] Add removing animations procedure with clutter ac backend
commit-queue@webkit.org [Fri, 22 Mar 2013 14:38:31 +0000 (14:38 +0000)]
[GTK][AC] Add removing animations procedure with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=110607

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva.

This changes is based on mac port implementation. The only different thing is
that updateAnimations is called explicitly in destructor of GraphicsLayerClutter
to remove uncommitted animations. Because even though we call notifyFlushRequired
to remove existing animations in removeAnimation(), removeClutterAnimationFromLayer
has been never reached since the root layer is destroyed before. It means
that we haven't lost a change to remove actual animations from clutterActor.

Covered by existing animation tests.

* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::removeAnimation):
(WebCore):
(WebCore::GraphicsLayerClutter::removeClutterAnimationFromLayer):
* platform/graphics/clutter/GraphicsLayerClutter.h:
(WebCore::GraphicsLayerClutter::animationIsRunning):
(GraphicsLayerClutter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WebGL] Optimize AlphaOp for HTMLVideoElement input.
commit-queue@webkit.org [Fri, 22 Mar 2013 14:28:56 +0000 (14:28 +0000)]
[EFL][WebGL] Optimize AlphaOp for HTMLVideoElement input.
https://bugs.webkit.org/show_bug.cgi?id=113049

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-22
Reviewed by Kenneth Rohde Christiansen.

Covered by existing tests.

Changeset 137397 implemented optimisation to avoid any
unnecessary Unmultiply or Premultiply operation in unpack/pack
provided the Image source is from HTMLVideoElement. This patch
enables the same for EFL port.

* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed chromium and apple mac rebaselines for r146600.
eae@chromium.org [Fri, 22 Mar 2013 14:27:46 +0000 (14:27 +0000)]
Unreviewed chromium and apple mac rebaselines for r146600.

* platform/chromium-mac-lion/fast/text/international/bidi-layout-across-linebreak-expected.png:
* platform/chromium-mac-lion/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
* platform/chromium-mac-lion/fast/transforms/bounding-rect-zoom-expected.txt: Added.
* platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
* platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
* platform/chromium/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
* platform/chromium/fast/transforms/bounding-rect-zoom-expected.txt: Added.
* platform/mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
* platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix an assert when opening the Web Inspector window for the first time.
timothy@apple.com [Fri, 22 Mar 2013 14:24:50 +0000 (14:24 +0000)]
Fix an assert when opening the Web Inspector window for the first time.

rdar://problem/13471765
https://webkit.org/b/113053

Reviewed by Eric Carlson.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow): Assign m_inspectorWindow
earlier so it is ready for when center is called and windowDidMove: gets called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBUILD FIX (r146558): Build testapi.mm with ARC enabled for armv7s
ddkilzer@apple.com [Fri, 22 Mar 2013 14:22:21 +0000 (14:22 +0000)]
BUILD FIX (r146558): Build testapi.mm with ARC enabled for armv7s
<http://webkit.org/b/112608>

Fixes the following build failure:

    Source/JavaScriptCore/API/tests/testapi.mm:205:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls]
    }
    ^
    1 error generated.

* Configurations/ToolExecutable.xcconfig: Enable ARC for armv7s
architecture.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRevert "BUILD FIX (r146558): Call [super dealloc] from -[TinyDOMNode dealloc]"
ddkilzer@apple.com [Fri, 22 Mar 2013 13:53:37 +0000 (13:53 +0000)]
Revert "BUILD FIX (r146558): Call [super dealloc] from -[TinyDOMNode dealloc]"

This fixes a build failure introduced by this change:

    Source/JavaScriptCore/API/tests/testapi.mm:206:6: error: ARC forbids explicit message send of 'dealloc'
        [super dealloc];
         ^     ~~~~~~~
    1 error generated.

Not sure why this didn't fail locally on my Mac Pro.

* API/tests/testapi.mm:
(-[TinyDOMNode dealloc]): Remove call to [super dealloc].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Missed one in r146589.
zarvai@inf.u-szeged.hu [Fri, 22 Mar 2013 13:46:45 +0000 (13:46 +0000)]
[Qt] Unreviewed gardening. Missed one in r146589.

* platform/qt/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Rebaselining after r146531.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146602 268f45cc-cd09-0410-ab3c-d52691b4dbfc