timothy@apple.com [Fri, 4 Apr 2008 20:13:34 +0000 (20:13 +0000)]
Fixes a null exception when hovering in some areas of the DOM tree.
Reviewed by Adam Roben.
* page/inspector/treeoutline.js:
(TreeOutline.prototype.treeElementFromPoint): Check listNode for null/undefined
before accessing any properties. Return null if listNode is null.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 4 Apr 2008 20:05:38 +0000 (20:05 +0000)]
Changing WebInspector.currentFocusElement to/from an input element
does not change the actual focus of that input element. You see this
in the search field.
Reviewed by Adam Roben.
* page/inspector/inspector.js:
(WebInspector.set currentFocusElement): Call blur and focus if the
node implements them.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 4 Apr 2008 19:18:12 +0000 (19:18 +0000)]
2008-04-04 David Hyatt <hyatt@apple.com>
Improve the background size heuristic for SVGs used as background images with no intrinsic size specified.
Treat them as having a background-size of 100%. This means their maximal size will be the box established
by background-origin.
Reviewed by Beth
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calculateBackgroundSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 4 Apr 2008 19:16:46 +0000 (19:16 +0000)]
Correctly show DOCTYPE in the breadcrumbs and match the CSS rules
from view-source.css for the DOCTYPE in the DOM tree.
Reviewed by Adam Roben.
* css/view-source.css: Add and correct comments about keeping
in-sync with inspector.css.
* page/inspector/ElementsPanel.js:
(WebInspector.DocumentPanel.prototype.updateBreadcrumb):
Add a case for Node.DOCUMENT_TYPE_NODE.
* page/inspector/inspector.css: Add a rule for .webkit-html-doctype.
* page/inspector/utilities.js:
(nodeTitleInfo): Use the webkit-html-doctype class for nodes
with Node.DOCUMENT_TYPE_NODE.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Apr 2008 19:02:33 +0000 (19:02 +0000)]
- try to fix the Tiger build
* icu/unicode/uscript.h: Copied from WebKit/mac/icu/unicode/uscript.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 4 Apr 2008 18:17:58 +0000 (18:17 +0000)]
Make WebKit use WebCore's copy of the ICU headers
WebCore:
Copy icu/ to PrivateHeaders for WebKit's benefit
Rubberstamped by Tim Hatcher.
* WebCore.xcodeproj/project.pbxproj: Renamed the Copy Forwarding
Headers build phase to Copy Forwarding and ICU Headers, and added the
icu/ directory to it.
WebKit/mac:
Use WebCore's ICU headers instead of our own copy
Rubberstamped by Tim Hatcher.
* Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
PrivateHeaders.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 4 Apr 2008 17:47:42 +0000 (17:47 +0000)]
Fix <rdar://problem/5804776> Would like to use WebCore's ForwardingHeaders in WebKit without manually creating copies
WebCore:
Fix <rdar://problem/5804776> Would like to use WebCore's
ForwardingHeaders in WebKit without manually creating copies
Patch by Tim Hatcher, typed by me.
* WebCore.xcodeproj/project.pbxproj: Added a new build phase, Copy
Forwarding Headers, that copies the ForwardingHeaders directory to
WebCore's PrivateHeaders directory.
WebKit/mac:
Fix <rdar://problem/5804776> Would like to use WebCore's
ForwardingHeaders in WebKit without manually creating copies
Patch by Tim Hatcher, typed by me.
* Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
WebCore's PrivateHeaders instead of our own copy.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Fri, 4 Apr 2008 17:21:33 +0000 (17:21 +0000)]
WebCore:
Changed the signature of imageTitleForFilename so we can pass in the width
and height as integers.
Reviewed by Dan.
* page/mac/WebCoreViewFactory.h:
* platform/mac/LocalizedStringsMac.mm:
(WebCore::imageTitle):
WebKit:
Updated the format string for window title for a standalone image to take integers.
Reviewed by Dan.
* English.lproj/Localizable.strings:
WebKit/mac:
Now we pass width and height directly as integers to format
the window title for a standalone image.
Reviewed by Dan.
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory imageTitleForFilename:width:height:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Fri, 4 Apr 2008 15:57:16 +0000 (15:57 +0000)]
<rdar://problem/5830598> Image file opened in the browser window shows "Localized String Not Found' in window's title bar instead file name
Save WebCoreLocalizedStrings.cpp with UTF8 encoding.
Changed the format string to take in integers.
Reviewed by Dan.
* English.lproj/Localizable.strings: Updated.
* WebCoreLocalizedStrings.cpp:
(WebCore::imageTitle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Apr 2008 05:28:56 +0000 (05:28 +0000)]
Forgot to save after the last change...
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Apr 2008 05:20:53 +0000 (05:20 +0000)]
- Windows build fix
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::matchImprovingEnumProc):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Fri, 4 Apr 2008 05:08:34 +0000 (05:08 +0000)]
Fix PlatformGradient so that it's a pointer on all platforms.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Apr 2008 04:47:03 +0000 (04:47 +0000)]
- 64-bit build fix
* platform/mac/WebFontCache.mm:
(+[WebFontCache internalFontWithFamily:traits:weight:size:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Fri, 4 Apr 2008 04:34:44 +0000 (04:34 +0000)]
wx build fix. Add stubs for gradient class platform functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Fri, 4 Apr 2008 04:32:38 +0000 (04:32 +0000)]
Reviewed by Dan Bernstein.
Refactor Gradient.h to have the same API on platforms without a gradient class.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Apr 2008 04:13:45 +0000 (04:13 +0000)]
- Qt build fix
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::Font):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Apr 2008 04:07:28 +0000 (04:07 +0000)]
- Tiger build fix
* platform/mac/WebFontCache.mm:
* rendering/RenderThemeMac.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Apr 2008 04:04:29 +0000 (04:04 +0000)]
- Gtk build fix
* platform/graphics/gtk/FontPlatformData.h:
(WebCore::FontPlatformData::size):
* platform/graphics/gtk/FontPlatformDataGtk.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/gtk/FontPlatformDataPango.cpp:
(WebCore::FontPlatformData::FontPlatformData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Apr 2008 03:51:50 +0000 (03:51 +0000)]
- project file updates in preparation for build fixes
* GNUmakefile.am:
* WebCore.pro:
* WebCoreSources.bkl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Apr 2008 03:46:59 +0000 (03:46 +0000)]
WebCore:
2008-04-03 Nicholas Shanks <webkit@nickshanks.com>
Updated by Dan Bernstein. Reviewed by Dave Hyatt.
- WebCore part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
font-weight does not properly support graded weights
Tests to come: <http://bugs.webkit.org/show_bug.cgi?id=18306>
Build fixes for platforms other than Mac and Windows to come.
* WebCore.vcproj/WebCore.vcproj: Added FontDescription.cpp.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to
return additional weight value keywords 100, 200, 300, 500, 600, 800
and 900.
* css/CSSFontSelector.cpp:
(WebCore::hashForFont): Changed the bold parameter into a weight
parameter and added the weight to the string to be hashed.
(WebCore::CSSFontSelector::addFontFaceRule): Changed to apply all CSS
weight values to the font description.
(WebCore::CSSFontSelector::getFontData): Updated the fallback logic to
go through all weights equal or lighter from the desired weight. For
SVG, to also consider heavier weights.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Cleaned up parsing of the font-weight
property.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Changed to apply all CSS
weight values to the font description.
* platform/graphics/Font.h:
(WebCore::Font::weight): Updated for the change to
FontDescription::weight().
* platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): Replaced
the bold component of the key with a weight component.
(WebCore::FontPlatformDataCacheKey::operator==): Updated for the above.
(WebCore::computeHash): Ditto.
(WebCore::FontPlatformDataCacheKeyTraits::deletedValue): Removed
unnecessary parameters.
(WebCore::FontPlatformDataCacheKeyTraits::emptyValue): Ditto.
(WebCore::FontCache::getCachedFontPlatformData): Updated for the change
in FontPlatformDataCacheKey.
* platform/graphics/FontDescription.cpp: Added.
(WebCore::FontDescription::lighterWeight): Added. Returns a lighter CSS
font-weight value if there is one, or the lightest value.
(WebCore::FontDescription::bolderWeight): Added. Returns a heavier CSS
font-weight value if there is one, or the heaviest value.
* platform/graphics/FontDescription.h:
(WebCore::FontWeight): Added this enumeration.
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::bold): Removed.
(WebCore::FontDescription::weight): Changed to return a FontWeight.
(WebCore::FontDescription::setBold): Removed.
(WebCore::FontDescription::setWeight): Changed to take a FontWeight.
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::toAppKitFontWeight): Added. Maps a FontWeight to the AppKit
font weight scale of 0-15.
(WebCore::isAppKitFontWeightBold): Added.
(WebCore::FontCache::getFontDataForCharacters): Changed to use a weight
instead of the bold trait for custom fonts, and to decide whether to
synthesize bold based on the weights rather than the bold trait.
(WebCore::FontCache::fontExists): Updated for the change in
WebFontCache .
(WebCore::FontCache::createFontPlatformData): Ditto. Also changed to
decide whether to synthesize bold based on the weights rather than on
the bold trait.
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::toGDIFontWeight): Added. Maps a FontWeight to a GDI font
weight constant.
(WebCore::isGDIFontWeightBold): Added.
(WebCore::adjustedGDIFontWeight): Added.
(WebCore::MatchImprovingProcData::MatchImprovingProcData): Added this
data structure for use by the following callback.
(WebCore::matchImprovingEnumProc): Added. The logic of this method is a
simplification of the betterChoice() predicate in WebFontCache.mm, which
considers only the italic trait and the weight.
(WebCore::createGDIFont): Added. Similarly to
+[WebFontCache fontWithFamily:traits:weight:size:], this function
finds the closest match in the family for the desired italic bit and
weight.
(WebCore::FontCache::fontExists): Changed to call createGDIFont().
(WebCore::FontCache::createFontPlatformData): Ditto. Also changed to
compute the synthetic bold and synthetic italic flags based on weights
and italic bits and pass them to the FontPlatformData constructor.
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Changed the bold and
oblique parameters to mean whether these should be synthesized and
removed the font enumeration code that used to decide that.
* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::smallCapsFontData): Changed to pass the
synthetic bold and oblique flags from the full-size FontPlatformData to
the FontPlatformData constructor for the small caps font.
* platform/mac/WebCoreTextRenderer.h:
* platform/mac/WebCoreTextRenderer.mm:
(WebCoreFindFont): Added a weight parameter, which is passed to
+[WebFontCache fontWithFamily:traits:weight:size:].
* platform/mac/WebFontCache.h:
* platform/mac/WebFontCache.mm:
(acceptableChoice):
(betterChoice): Changed to ignore the bold trait. Changed the logic for
deciding based on weights to prefer the font whose weight is closer to
the desired one, or, if both candidates' weights are the same distance
from the desired weight, the one that is more "off-center".
(+[WebFontCache internalFontWithFamily:traits:weight:size:]): Changed to
check for weight when matching by full name. Changed to pass
the actual desired weight instead of the constant 5 to
acceptableChoice() and betterChoice(). Changed to use weights to decide
whether to synthesize bold.
(+[WebFontCache fontWithFamily:traits:weight:size:]): Added a weight
parameter, which is passed to the internal method.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::paint): Updated for the change to FontDescription.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement): Ditto.
(WebCore::RenderListBox::paintItemForeground): Ditto.
* rendering/RenderThemeMac.mm:
(WebCore::toFontWeight): Added. Maps the AppKit font weight range of
0-15 to the FontWeight range.
(WebCore::RenderThemeMac::systemFont): Updated for the change to
FontDescription.
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::systemFont): Ditto.
WebKit/mac:
2008-04-03 Nicholas Shanks <webkit@nickshanks.com>
Updated by Dan Bernstein. Reviewed by Dave Hyatt.
- WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
font-weight does not properly support graded weights
* WebView/WebHTMLView.mm:
(-[WebHTMLView _styleFromFontAttributes:]):
(-[WebHTMLView _originalFontB]):
(-[WebHTMLView _addToStyle:fontA:fontB:]):
WebKit/win:
2008-04-03 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
font-weight does not properly support graded weights
* DOMCoreClasses.cpp:
(DOMElement::font): Updated for the change to FontDescription.
* WebCoreSupport/WebDragClient.cpp:
(dragLabelFont): Ditto.
* WebKitGraphics.cpp:
(makeFont): Ditto.
* WebKitGraphics.h: Added a FIXME.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Apr 2008 03:10:23 +0000 (03:10 +0000)]
- another Gtk build fix attempt
* platform/graphics/cairo/GradientCairo.cpp:
(WebCore::Gradient::platformDestroy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Apr 2008 02:05:42 +0000 (02:05 +0000)]
- attempted Gtk build fix
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Apr 2008 01:02:09 +0000 (01:02 +0000)]
- attempted Qt build fix
* platform/graphics/qt/GradientQt.cpp:
(WebCore::Gradient::platformDestroy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Apr 2008 00:43:39 +0000 (00:43 +0000)]
- attempted Gtk build fix
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::stroke):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Apr 2008 00:40:22 +0000 (00:40 +0000)]
- attempted Qt build fix
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::stroke):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 3 Apr 2008 23:13:24 +0000 (23:13 +0000)]
<rdar://problem/5835382> Calling window.open immediately after window.close can sometimes result in no window being created
Group name tracking needs to happen using code in WebCore::Page, since it is more involved than
just setting a string.
Reviewed by Adam Roben.
* WebView.cpp:
(WebView::close): Add null check (found via code inspection).
(WebView::initWithFrame): Store the group name directly in Page.
(WebView::setGroupName): Store the group name directly in Page.
(WebView::groupName): Retrieve the group name directly from Page.
* WebView.h: Removed m_groupName
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 3 Apr 2008 23:08:28 +0000 (23:08 +0000)]
2008-04-03 Beth Dakin <bdakin@apple.com>
Reviewed by Alice.
Build fix for non-Macs.
* page/AXObjectCache.h:
(WebCore::AXObjectCache::isIDinUse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Thu, 3 Apr 2008 22:48:48 +0000 (22:48 +0000)]
2008-04-03 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Darin.
Correct build error due to incomplete merging of changes to project
files from Issue 17985. This small project file patch corrects
the build issue (see http://bugs.webkit.org/show_bug.cgi?id=18195).
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 3 Apr 2008 22:02:45 +0000 (22:02 +0000)]
2008-04-02 Beth Dakin <bdakin@apple.com>
Reviewed by Hyatt.
This patch eliminates AccessibilityObjectMac. All of the platform-
specific code is now in AccessibilityObjectWrapper.
* WebCore.xcodeproj/project.pbxproj:
* dom/Element.h:
(WebCore::Element::isPasswordField):
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::isPasswordField):
* page/AXObjectCache.h:
(WebCore::AXObjectCache::isIDinUse):
* page/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isPasswordField):
(WebCore::AccessibilityObject::press):
(WebCore::AccessibilityObject::widgetForAttachmentView):
(WebCore::AccessibilityObject::doAXBoundsForTextMarkerRange):
(WebCore::AccessibilityObject::doAXTextMarkerForPosition):
* page/AccessibilityObject.h:
(WebCore::AccessibilityObject::areaElement):
(WebCore::AccessibilityObject::setWrapper):
* page/mac/AXObjectCacheMac.mm:
* page/mac/AccessibilityObjectMac.mm: Removed.
* page/mac/AccessibilityObjectWrapper.h:
* page/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper attachmentView]):
(textMarkerForVisiblePosition):
(visiblePositionForTextMarker):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(textMarkerRangeFromMarkers):
(AXAttributeStringSetFont):
(CreateCGColorIfDifferent):
(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetStyle):
(blockquoteLevel):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetSpelling):
(AXAttributeStringSetHeadingLevel):
(AXLinkElementForNode):
(AXAttributeStringSetElement):
(AXAttributedStringAppendText):
(nsStringForReplacedNode):
(-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[AccessibilityObjectWrapper accessibilityActionNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
(-[AccessibilityObjectWrapper textMarkerRangeForSelection]):
(-[AccessibilityObjectWrapper position]):
(createAccessibilityRoleMap):
(RoleEntry::):
(roleValueToNSString):
(-[AccessibilityObjectWrapper role]):
(-[AccessibilityObjectWrapper subrole]):
(-[AccessibilityObjectWrapper roleDescription]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityIsIgnored]):
(-[AccessibilityObjectWrapper accessibilityPerformAction:]):
(-[AccessibilityObjectWrapper doAXAttributedStringForRange:]):
(-[AccessibilityObjectWrapper doAXRTFForRange:]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[AccessibilityObjectWrapper accessibilityShouldUseUniqueId]):
* platform/ScrollView.h:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::viewRectToScreen):
(WebCore::ScrollView::absolutePointToView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 3 Apr 2008 21:57:13 +0000 (21:57 +0000)]
2008-04-03 David Hyatt <hyatt@apple.com>
Create a new cross-platform Gradient abstraction and make CanvasGradient wrap it. This first
step just cleans up CanvasGradient. The code that calls it remains ifdef'd however.
Reviewed by olliej
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::toJS):
* html/CanvasGradient.cpp:
(WebCore::CanvasGradient::CanvasGradient):
* html/CanvasGradient.h:
(WebCore::CanvasGradient::gradient):
(WebCore::CanvasGradient::addColorStop):
(WebCore::CanvasGradient::getColor):
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::fillRect):
* html/CanvasStyle.h:
(WebCore::CanvasStyle::canvasGradient):
* platform/graphics/Gradient.cpp: Added.
(WebCore::Gradient::Gradient):
(WebCore::Gradient::~Gradient):
(WebCore::Gradient::addColorStop):
(WebCore::compareStops):
(WebCore::Gradient::getColor):
(WebCore::Gradient::findStop):
* platform/graphics/Gradient.h: Added.
(WebCore::Gradient::ColorStop::ColorStop):
(WebCore::Gradient::platformInit):
* platform/graphics/cairo/GradientCairo.cpp: Added.
(WebCore::Gradient::platformDestroy):
(WebCore::Gradient::platformGradient):
* platform/graphics/cg/GradientCG.cpp: Added.
(WebCore::Gradient::platformDestroy):
(WebCore::gradientCallback):
(WebCore::Gradient::platformGradient):
* platform/graphics/qt/GradientQt.cpp: Added.
(WebCore::Gradient::platformDestroy):
(WebCore::Gradient::platformGradient):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 21:47:25 +0000 (21:47 +0000)]
Roll out r31599 and r31605 again after discussion with Mark Rowe.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 21:25:39 +0000 (21:25 +0000)]
Attempted build fix
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 3 Apr 2008 21:14:47 +0000 (21:14 +0000)]
2008-04-03 David Hyatt <hyatt@apple.com>
Fix for bug 18194, resizable text fields get messed up when resizing in the presence of zoom.
Reviewed by adele
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 3 Apr 2008 20:30:05 +0000 (20:30 +0000)]
Rollout r31566 as there were a few issues i missed during review (thanks to antti for pointing them out)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 20:17:59 +0000 (20:17 +0000)]
2008-04-03 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
* Change IconDatabase::iconForPageURL to return more information. E.g. if
an image has been found, or if the loading of an image has been scheduled.
* Update FrameLoader to use another method to trigger reading from disk
* Update the QWebFrame and QWebSettings
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 19:22:57 +0000 (19:22 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* Safari is using the IconDatabase the following way (assumption). Before they
call iconDatabase()->open they "retain" all URLs they are interested in, these
could come from the history.
* When opening the iconDatabase() a thread will be started that is going to import
the URLs, all none manually retained URLs are scheduled for removal. The removal
is going to happen when the next icon gets stored in the database.
* We do not have any IconDatabase code, we can not retain the URLs before opening the
database. To disable the automatic pruning of the icons we will ask the IconDatabase
to delay this operation. This means our IconDatabase, when used, will grow, so we should
try to have a IconDatabase class in 4.4.
* The only way to counter the growth is a call to QWebSettings::clearIconDatabase
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 19:01:45 +0000 (19:01 +0000)]
Oops, fixed previous commit/merge error that caused build failure in Qt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 3 Apr 2008 19:00:40 +0000 (19:00 +0000)]
Allow WebArchive to be created via COM.
Replaced IID_DOMNode with __uuidof(DOMNode).
Reviewed by Adam and Steve.
* DOMCoreClasses.cpp:
(DOMNode::QueryInterface):
(DOMNode::isSameNode):
* DOMCoreClasses.h:
* ForEachCoClass.h:
* Interfaces/WebKit.idl:
* WebArchive.cpp:
(WebArchive::createInstance):
* WebArchive.h:
* WebKitClassFactory.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 18:59:03 +0000 (18:59 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>
Add a way to get the site icon for a url
static QPixmap iconForUrl(const QUrl &url);
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 18:46:58 +0000 (18:46 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* Update the Copyright info in QWebSettings
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 18:46:44 +0000 (18:46 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* The isEmpty check is not needed anymore with the earlier backport
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 3 Apr 2008 16:50:13 +0000 (16:50 +0000)]
2008-04-03 Brady Eidson <beidson@apple.com>
Fix a tab into 4-spaces instead
* webarchive/test-css-import-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 3 Apr 2008 16:20:42 +0000 (16:20 +0000)]
- Mac build fix
* WebCore.base.exp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 13:21:25 +0000 (13:21 +0000)]
Fix the build when building without icondatabase.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 12:27:21 +0000 (12:27 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* Remove the unused 'cache' parameter
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 12:04:09 +0000 (12:04 +0000)]
2008-04-03 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
* Add WebCore/loader/icon to the DEPENDPATH as well
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 11:40:30 +0000 (11:40 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* Add a Qt specific result for bad-scheme-subframe-expected.txt
* To match the mac-port we would have to return IgnoreNavigationRequest for
schemes/URLs not supported by the QNetworkAccessManager in QWebPage::navigationRequested
but we can't do that because QNetworkAccessManager does not expose a list of supported
schemes and operations. So in contrast to the mac we will try to load the frame and fail.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 11:40:09 +0000 (11:40 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* Fix http/tests/loading/simple-subframe.html by adding a test result. The result is
quite similar to the one of the mac port.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 10:31:31 +0000 (10:31 +0000)]
2008-04-03 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
* Enable running http tests for Qt again. Failing tests can be put into the skipped list.
* Running these tests on windows and other platforms might need some work.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 10:31:18 +0000 (10:31 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* For the http tests we need the output of the FrameLoaderClient. The QtWebKit API
is not exporting enough to create the output in DRT itself. Settle with the approach
Lars has taken for the Editing support and add branches to our FrameLoaderClient code.
* run-webkit-tests http/tests(/loading) can now be executed.
* For tests in loading/ directories we are going to throw away the dirty
QWebPage to start with something clean.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 10:30:59 +0000 (10:30 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* Treat http and https as special URLs as well. Change the main.cpp and
DumpRenderTree.cpp to handle http and https URIs as input.
* I'm not doing the clean up and merging of these two checks now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Apr 2008 10:30:44 +0000 (10:30 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* Remove dumpFrameLoadCallbacks from simple-subframe.html because it is
located in a directory with the name "loading". And this will autoamtically
enable dumping.
* Remove this method from the LayoutTestController as it is unused now and this
avoids adding it to the DRT of the Qt port.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 3 Apr 2008 05:56:21 +0000 (05:56 +0000)]
WebCore:
2008-04-02 Brady Eidson <beidson@apple.com>
Reviewed by Mitz Pettel
<rdar://problem/5838347> and http://bugs.webkit.org/show_bug.cgi?id=11839
Webarchive fails to save CSS files in @import statements
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::addSubresourceURLStrings): Recursively add the URL each @import rule under the current style sheet.
* css/CSSStyleSheet.h:
* css/StyleSheet.h:
(WebCore::StyleSheet::addSubresourceURLStrings):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::getSubresourceAttributeStrings): Add the linked URL as well as all @import
rules rooted at the linked stylesheet.
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::getSubresourceAttributeStrings): Walk all @import rules rooted at this
stylesheet to add to the list.
* html/HTMLStyleElement.h:
LayoutTests:
2008-04-02 Brady Eidson <beidson@apple.com>
Written by David Kilzer, tweaked by Brady, Reviewed by Mitz Pettel
- test for http://bugs.webkit.org/show_bug.cgi?id=11839
Webarchive fails to save CSS files in @import statements
The idea is to <link> to a CSS file which @imports another CSS file,
and also @import a CSS file inside a <style> element, which also @imports another CSS file
Then make sure all 4 of the css files are in the resulting webarchive
* webarchive/resources/test-css-import-recurse.css: Added.
* webarchive/resources/test-css-import.css: Added.
* webarchive/resources/test-css-link-recurse.css: Added.
* webarchive/resources/test-css-link.css: Added.
* webarchive/test-css-import-expected.txt: Added.
* webarchive/test-css-import.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 3 Apr 2008 05:11:00 +0000 (05:11 +0000)]
Ensure that debug symbols are generated for x86_64 and ppc64 builds.
Reviewed by Oliver Hunt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
christian@webkit.org [Thu, 3 Apr 2008 00:24:26 +0000 (00:24 +0000)]
Build fix for GCC 4.3.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 2 Apr 2008 22:49:55 +0000 (22:49 +0000)]
2008-04-02 Christian Persch <chpe@gnome.org>
Reviewed by Alp Toker.
GTK+/Pango font backend build fix.
* platform/graphics/gtk/FontCustomPlatformDataPango.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 2 Apr 2008 21:48:16 +0000 (21:48 +0000)]
Not reviewed. Speculative fix for hanging tests on buildbot (Tiger). Click events may have wrong origins.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 2 Apr 2008 18:41:54 +0000 (18:41 +0000)]
No review, build fix only.
Speculative build fix for no-svg build.
Use #if ENABLE(SVG) instead of #if ENABLE_SVG
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::getPropertyValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 2 Apr 2008 18:12:28 +0000 (18:12 +0000)]
Rename instances of ExecState from "state" to "exec" in JavaScriptDebugServer
Rename requested by Darin Adler.
* page/JavaScriptDebugServer.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 2 Apr 2008 17:59:44 +0000 (17:59 +0000)]
Make it possible for JavaScriptDebugListeners to listen to specific Pages
JavaScriptDebugServer now has overloads of its
addListener/removeListener methods that take a Page* to indicate for
which Page the JavaScriptDebugListener wishes to receive messages.
Reviewed by Darin.
* page/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::~JavaScriptDebugServer): Delete all
ListenerSets being held in m_pageListenersMap.
(WebCore::JavaScriptDebugServer::addListener): Changed to call
hasListeners().
(WebCore::JavaScriptDebugServer::removeListener): Ditto.
(WebCore::JavaScriptDebugServer::addListener): Added. This overload
takes a Page* and puts the listener in the appropriate ListenerSet
within m_pageListenersMap. The ListenerSet is allocated and added to
m_pageListenersMap when its first listener is added.
(WebCore::JavaScriptDebugServer::removeListener): Added. This overload
takes a Page* and removes the listener from the appropriate
ListenerSet in m_pageListenersMap. The ListenerSet is deleted and
removed from m_pageListenersMap when its last listener is removed.
(WebCore::toPage): Added. Retrieves the parent Page from an ExecState.
(WebCore::JavaScriptDebugServer::sourceParsed): Changed to call
dispatchDidParseSource/dispatchDidFailToParseSource for both the
global listeners and the Page listeners.
(WebCore::dispatchFunctionToListeners): Added. This code was extracted
from the JavaScriptDebugServer method of the same name.
(WebCore::JavaScriptDebugServer::dispatchFunctionToListeners): Call
dispatchFunctionToListeners for both the global listeners and the Page
listeners.
* page/JavaScriptDebugServer.h:
- Added declarations for new methods.
- Made JavaScriptExecutionCallback typedef public so that it could
be used by a helper method.
- Added new m_pageListenersMap member.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 2 Apr 2008 13:50:35 +0000 (13:50 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* Export the PageCache and Cache capacity call one to one. This is only there
to allow the QtLauncher to play with caching.
* TODO: make API decisions and consider following the windows Api to set a WebCacheModel
and determine certain values automatically.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 2 Apr 2008 13:50:19 +0000 (13:50 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Prepapre everything for enabling the PageCache for the Qt Platform:
* Claim that we can cache pages
* Create the FrameView FrameLoaderClientQt::transitionToCommittedForNewPage using
the initial size of the viewport and stop creating it in the QWebFramePrivate::init
Differences to the Windows port:
* attachToWindow/detachFromWindow is not called and is not (yet) part
of Widget/ScrollView of the Qt platform. We might need that for plugin
support in the future.
* We store the margin's and scrolling flag inside QWebFrame and use it when
creating the FrameView.
What is missing:
* API to call pageCache()->setCapacity(XYZ);
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 2 Apr 2008 13:49:12 +0000 (13:49 +0000)]
Fix compilation on case-sensitive file systems.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 2 Apr 2008 12:55:03 +0000 (12:55 +0000)]
Reviewed by Oliver.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=17779 (SVG 1.1 Errata demands "SVG JavaScript Liveness" support)
SVG Errata states: "All SVG DOM objects that directly correspond to an
attribute, e.g. the SVGAnimatedLength 'ry' in an SVGRectElement, are live. This
means that any changes made to the attribute are immediately reflected in the
corresponding SVG DOM object." (see linked URL on bug report)
Until now only XML -> SVG DOM changes took affect, aka. changing the 'rx' attribute of a <rect>
element resuted in changes when accessing 'rx' through SVG DOM (rx.baseVal.value).
Add a new synchronization layer to handle SVG DOM -> XML changes.
Added Test: svg/custom/svg-xml-dom-sync.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 2 Apr 2008 12:00:58 +0000 (12:00 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* For the PageCache support we do not want to create a FrameView in the constructor
of QWebFrame. In QWegPage::viewportSize() we currently call mainFrame() and that will
create a QWebFrame if no mainFrame is present and this gets called when we try to
create a FrameView...
* Keep a copy of the initial viewportSize around and use it if we do not have a Frame
or FrameView.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 2 Apr 2008 12:00:45 +0000 (12:00 +0000)]
2008-04-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
* Always return true in FrameLoaderClientQt::shouldGoToHistoryItem, like the windows port
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 2 Apr 2008 12:00:31 +0000 (12:00 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* Attempt to make the m_webFrame null pointer checking consistent. Always check for
m_webFrame. It should get set by the QWebFrame with the FramerLoaderClientQt::setFrame
call and should stay valid until the destruction of the QWebFrame.
* Currently the same checking is not needed for m_frame as it will only set to 0 in
FrameLoaderClientQt::frameLoaderDestroyed and should be not 0 because of the setFrame
initialisation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 2 Apr 2008 11:54:02 +0000 (11:54 +0000)]
2008-04-02 Darin Adler <darin@apple.com>
Reviewed by Alexey.
- fix storage leak seen on buildbot
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::utiFromMIMEType): Put the result of createCFString() into a RetainPtr. Changed
result to be a RetainPtr.
(WebCore::ImageBuffer::toDataURL): Tweak a little bit, removing one local variable and
some unneeded explicit conversions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 2 Apr 2008 06:50:41 +0000 (06:50 +0000)]
Rubber-stamped by Darin.
Turn off using 64-bit arithmetic on 32-bit hardware, as dtoa own code is faster than
compiler-provided emulation.
1% speedup on Acid3 test 26.
* kjs/dtoa.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 2 Apr 2008 06:38:32 +0000 (06:38 +0000)]
Reviewed by Darin.
Make MathExtras.h thread safe.
* kjs/math_object.cpp:
(KJS::mathProtoFuncRandom): If threading is enabled, rely on initializeThreading to call
wtf_random_init().
* wtf/Threading.h:
* wtf/ThreadingGtk.cpp:
(WTF::initializeThreading):
* wtf/ThreadingNone.cpp:
(WTF::initializeThreading):
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
* wtf/ThreadingWin.cpp:
(WTF::initializeThreading):
Call wtf_random_init(); made the function non-inline to avoid having to include too many
headers in Threading.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 2 Apr 2008 00:30:34 +0000 (00:30 +0000)]
2008-04-01 Darin Adler <darin@apple.com>
* WebCore.vcproj/WebCore.vcproj: Added RangeBoundaryPoint.h -- not required, but convenient.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 2 Apr 2008 00:28:29 +0000 (00:28 +0000)]
2008-04-01 Darin Adler <darin@apple.com>
Reviewed by Sam and Antti.
- fix <rdar://problem/5829565> paste performance slowed down with the Range Acid3 changes
Added a new class, RangeBoundaryPoint, to use for range boundary points. The "truth" of
the offset is now stored as a node pointer, and the offset is computed as and when needed.
This allows us to efficiently update when the DOM tree is changed -- computation of the
node offsets is deferred until the Range is used later.
* WebCore.base.exp: Export nodeIndex().
* WebCore.xcodeproj/project.pbxproj: Added RangeBoundaryPoint.h, removed NodeWithIndexBefore.h
and NodeWIthIndexAfter.h. Also let Xcode tweak the file formatting.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::childrenChanged): Pass fewer arguments to Document.
* dom/Document.cpp:
(WebCore::Document::nodeChildrenChanged): Pass fewer arguments to Range.
(WebCore::Document::nodeWillBeRemoved): Pass node to range as a raw node pointer; no need for
the index.
* dom/Document.h: Take fewer arguments.
* dom/NodeWithIndexAfter.h: Removed.
* dom/NodeWithIndexBefore.h: Removed.
* dom/Range.cpp:
(WebCore::Range::Range): Changed to use the new RangeBoundaryPoint constructor.
(WebCore::Range::create): Updated to use RangeBoundaryPoint instead of Position.
(WebCore::Range::~Range): Ditto.
(WebCore::Range::startContainer): Ditto.
(WebCore::Range::startOffset): Ditto.
(WebCore::Range::endContainer): Ditto.
(WebCore::Range::endOffset): Ditto.
(WebCore::Range::commonAncestorContainer): Ditto.
(WebCore::Range::collapsed): Ditto.
(WebCore::Range::setStart): Ditto.
(WebCore::Range::setEnd): Ditto.
(WebCore::Range::collapse): Ditto.
(WebCore::Range::isPointInRange): Ditto.
(WebCore::Range::comparePoint): Ditto.
(WebCore::Range::compareNode): Ditto.
(WebCore::Range::compareBoundaryPoints): Ditto.
(WebCore::Range::boundaryPointsValid): Ditto.
(WebCore::Range::intersectsNode): Ditto.
(WebCore::Range::processContents): Ditto.
(WebCore::Range::cloneContents): Ditto.
(WebCore::Range::insertNode): Updated to use RangeBoundaryPoint. Also simplified the code
at the end that updates the range -- not all of it is needed now since most of the fixup
is done automatically by the range document mutation machinery. The one bit that remains
is arguably a bug, but we need to keep it to keep passing Acid3 until we get clarification
that it is indeed a bug (and then Acid3 will probably have to change).
(WebCore::Range::toString): Update to use RangeBoundaryPoint instead of Position.
(WebCore::Range::text): Ditto.
(WebCore::Range::createContextualFragment): Ditto.
(WebCore::Range::detach): Ditto.
(WebCore::Range::checkNodeWOffset): Changed case where the offset is a node offset to
be more efficient by using childNode instead of childNodeCount, and also return the node
before which is needed to set the value of a RangeBoundaryPoint.
(WebCore::Range::cloneRange): Ditto.
(WebCore::Range::setStartAfter): Ditto.
(WebCore::Range::setEndBefore): Ditto.
(WebCore::Range::setEndAfter): Ditto.
(WebCore::Range::selectNode): Ditto.
(WebCore::Range::selectNodeContents): Ditto.
(WebCore::Range::surroundContents): Ditto.
(WebCore::Range::setStartBefore): Ditto.
(WebCore::Range::checkDeleteExtract): Ditto.
(WebCore::Range::containedByReadOnly): Ditto.
(WebCore::Range::firstNode): Ditto.
(WebCore::Range::editingStartPosition): Ditto.
(WebCore::Range::pastLastNode): Ditto.
(WebCore::Range::addLineBoxRects): Ditto.
(WebCore::Range::formatForDebugger): Ditto.
(WebCore::Range::maxStartOffset): Ditto.
(WebCore::Range::maxEndOffset): Ditto.
(WebCore::boundaryNodeChildrenChanged): Updated to use RangeBoundaryPoint instead of
Position. Also changed name and changed to just call invalidateOffset.
(WebCore::Range::nodeChildrenChanged): Changed to take just a container node.
(WebCore::boundaryNodeWillBeRemoved): Updated to use RangeBoundaryPoint instead of
Position. Also changed name and changed to update childBefore.
(WebCore::Range::nodeWillBeRemoved): Changed to just take a Node*.
(WebCore::boundaryTextInserted): Updated to use RangeBoundaryPoint instead of
Position. Also changed name.
(WebCore::Range::textInserted): Ditto.
(WebCore::boundaryTextRemoved): Ditto.
(WebCore::Range::textRemoved): Ditto.
(WebCore::boundaryTextNodesMerged): Ditto.
(WebCore::Range::textNodesMerged): Ditto.
(WebCore::boundaryTextNodesSplit): Ditto.
(WebCore::Range::textNodeSplit): Ditto.
* dom/Range.h: Updated to use RangeBoundaryPoint instead of Position.
* dom/RangeBoundaryPoint.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 2 Apr 2008 00:22:30 +0000 (00:22 +0000)]
2008-04-01 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
Get rid of old "bindings" forwarding headers.
* ForwardingHeaders/bindings: Removed.
* ForwardingHeaders/bindings/NP_jsobject.h: Removed.
* ForwardingHeaders/bindings/npruntime.h: Removed.
* ForwardingHeaders/bindings/npruntime_impl.h: Removed.
* ForwardingHeaders/bindings/npruntime_internal.h: Removed.
* ForwardingHeaders/bindings/runtime.h: Removed.
* ForwardingHeaders/bindings/runtime_object.h: Removed.
* ForwardingHeaders/bindings/runtime_root.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 1 Apr 2008 23:11:00 +0000 (23:11 +0000)]
WebKit/win:
Reviewed by Jon Honeycutt and Cake
Hookup WebArchive API enough to be able to save the archive of a DOMNode
* DOMCoreClasses.h: Add a GUID for DOMNode
* Interfaces/IWebArchive.idl: Add initWithNode()
* WebArchive.cpp:
(WebArchive::initWithNode):
(WebArchive::data): Actually return LegacyWebArchive-style data
* WebArchive.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 1 Apr 2008 22:44:17 +0000 (22:44 +0000)]
2008-04-01 Timothy Hatcher <timothy@apple.com>
Rename DatabasePanel.js to DatabasesPanel.js to facilitate the up-coming UI refresh changes.
http://bugs.webkit.org/show_bug.cgi?id=17773
Rubber-stamped by Brady Eidson.
* WebCore.vcproj/WebCore.vcproj: Reference DatabasesPanel.js.
* page/inspector/DatabasePanel.js: Removed.
* page/inspector/DatabasesPanel.js: Copied from page/inspector/DatabasePanel.js.
* page/inspector/WebKit.qrc: Reference DatabasesPanel.js.
* page/inspector/inspector.html: Reference DatabasesPanel.js.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 1 Apr 2008 22:31:11 +0000 (22:31 +0000)]
2008-04-01 Brady Eidson <beidson@apple.com>
Touch a file to get Windows to rebuild WebCore
* platform/ContextMenu.cpp: Alphabetize headers
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 1 Apr 2008 20:26:27 +0000 (20:26 +0000)]
WebCore:
Reviewed by Adam Roben
Export loader/archive and loader/archive/cf headers for WebKitWin to use
* WebCore.vcproj/WebCore.vcproj:
WebKit/win:
Reviewed by Adam Roben
Add empty implementations of WebArchive for future work
* WebArchive.cpp: Added.
(WebArchive::createInstance):
(WebArchive::WebArchive):
(WebArchive::~WebArchive):
(WebArchive::QueryInterface):
(WebArchive::AddRef):
(WebArchive::Release):
(WebArchive::initWithMainResource):
(WebArchive::initWithData):
(WebArchive::mainResource):
(WebArchive::subResources):
(WebArchive::subframeArchives):
(WebArchive::data):
* WebArchive.h: Added.
* WebKit.vcproj/WebKit.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 1 Apr 2008 19:45:50 +0000 (19:45 +0000)]
WebCore:
Reviewed by Darin
WebArchives need to load on Windows the same way as on Mac, and this change in the
finished-loading code path was a big part of that
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedLoadingDocument): Only call the client's finishedLoading()
for non-archive loads
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 1 Apr 2008 17:47:06 +0000 (17:47 +0000)]
- Mac build fix
* WebCore.xcodeproj/project.pbxproj: Made FontRenderingMode.h private.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31532
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 1 Apr 2008 16:41:33 +0000 (16:41 +0000)]
Reviewed by Darin Adler.
- move the FontRenderingMode enumeration into its own header file
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* loader/CachedFont.h:
* platform/graphics/FontDescription.h:
* platform/graphics/FontRenderingMode.h: Added.
(WebCore::):
* platform/graphics/gtk/FontCustomPlatformData.h:
* platform/graphics/mac/FontCustomPlatformData.h:
* platform/graphics/qt/FontCustomPlatformData.h:
* platform/graphics/win/FontCustomPlatformData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 1 Apr 2008 16:36:52 +0000 (16:36 +0000)]
2008-04-01 Darin Adler <darin@apple.com>
Reviewed by Mitz.
- fix <rdar://problem/5833351> REGRESSION: Leak in JSCustomXPathNSResolver::create
- fix <rdar://problem/5833216> REGRESSION: Leak in CSSStyleSelector::addViewportDependentMediaQueryResult
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::create): Added a missing adoptRef.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::~CSSStyleSelector): Added a missing call to deleteAllValues.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 1 Apr 2008 16:19:21 +0000 (16:19 +0000)]
Clear stray executable bit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Tue, 1 Apr 2008 16:04:17 +0000 (16:04 +0000)]
tiger build fix
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 1 Apr 2008 15:44:24 +0000 (15:44 +0000)]
2008-04-01 Darin Adler <darin@apple.com>
Reviewed by Sam.
- speed up hasChildNodes, which does not need to be virtual
* dom/ContainerNode.cpp: Removed hasChildNodes.
* dom/ContainerNode.h: Added non-virtual inline hasChildNodes.
* dom/Node.cpp: Removed hasChildNodes.
* dom/Node.h: Added non-vritual inline hasChildNodes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 1 Apr 2008 15:08:47 +0000 (15:08 +0000)]
Fix Qt DRT run by also printing EOF on stderr, as expected by
run-webkit-tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 1 Apr 2008 10:27:52 +0000 (10:27 +0000)]
Fix the non-mac build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 1 Apr 2008 08:47:04 +0000 (08:47 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* Get the RefCounting of WebCore::Frame right and make sure that both QWebFrame
and WebCore::Frame get destroyed if we leave site with subframes and on the
end of the application.
* Use adoptRef in FrameLoaderClientQt::createFrame to get the refs right for subframes. We
do not want to add an extra reference. Without this we are leaking subframes.
* Assume that the lifetime of a Frame and FrameLoader are the same, when the Frame is gone
we want to destroy the QWebFrame (e.g. on a page with subframes). Add delete m_webFrame
in the frameLoaderDestroyed method to do that.
* If we happen to delete the QWebFrame before the FrameLoaderClientQt we set m_webFrame to
zero in the FrameLoaderClientQt to avoid bad things.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 1 Apr 2008 08:46:48 +0000 (08:46 +0000)]
2008-04-01 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
* Do not save a RefPtr to the frame. The FrameLoaderClient, Frame and
QWebFrame should have the same lifetime everything else is a leak
or issue.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 1 Apr 2008 08:46:30 +0000 (08:46 +0000)]
2008-04-01 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
* Do not store the QWebFrame associated with a ScrollView/FrameView
in the WebCore::Widget.
* Instead of asking the Widget for the QWebFrame use the QWebFramePrivate::core
and QWebFramePrivate::kit function to convert from and to QWebFrame.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 1 Apr 2008 08:44:34 +0000 (08:44 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* Do not store the FrameView in the QWebFrame and cope with the situation when
a WebCore::Frame has no WebCore::FrameView.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Tue, 1 Apr 2008 08:40:10 +0000 (08:40 +0000)]
WebCore:
2008-04-01 Alice Liu <alice.liu@apple.com>
Patch by Beth Dakin <bdakin@apple.com> and Alice Liu
Reviewed by Darin.
Refactored WebCore Accessibility code. Prior to this patch, WebCore
accessibility was implemented in an ObjC class named WebCoreAXObject,
with much of the "guts" in C++. This patch the next natural step of
factoring out the C++ code into a class named AccessibilityObject, and
in order to maintain the required ObjC object ties, also implements an
ObjC class named AccessibilityObjectWrapper as a thin wrapper around the
C++ object. Internally within WebCore we operate on the C++ object as
much as possible, and the ObjC object gets used mostly when we need to
return something to AppKit or call something implemented on NSObject.
The AXObjectCache still keeps one HashMap, now of RenderObjects to
AccessibilityObjects instead of WebCoreAXObjects, and the
AccessibilityObject keeps track of its ObjC wrapper.
* WebCore.xcodeproj/project.pbxproj:
* page/AXObjectCache.h:
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::removeAXID):
* page/AccessibilityObject.cpp: Added.
(WebCore::AccessibilityObject::AccessibilityObject):
(WebCore::AccessibilityObject::~AccessibilityObject):
(WebCore::AccessibilityObject::create):
(WebCore::AccessibilityObject::detach):
(WebCore::AccessibilityObject::firstChild):
(WebCore::AccessibilityObject::lastChild):
(WebCore::AccessibilityObject::previousSibling):
(WebCore::AccessibilityObject::nextSibling):
(WebCore::AccessibilityObject::parentObject):
(WebCore::AccessibilityObject::parentObjectUnignored):
(WebCore::AccessibilityObject::isWebArea):
(WebCore::AccessibilityObject::isImageButton):
(WebCore::AccessibilityObject::isAnchor):
(WebCore::AccessibilityObject::isTextControl):
(WebCore::AccessibilityObject::isImage):
(WebCore::AccessibilityObject::isAttachment):
(WebCore::isPasswordFieldElement):
(WebCore::AccessibilityObject::isPasswordField):
(WebCore::AccessibilityObject::headingLevel):
(WebCore::AccessibilityObject::isHeading):
(WebCore::AccessibilityObject::anchorElement):
(WebCore::isCheckboxOrRadio):
(WebCore::AccessibilityObject::actionElement):
(WebCore::AccessibilityObject::mouseButtonListener):
(WebCore::AccessibilityObject::helpText):
(WebCore::AccessibilityObject::textUnderElement):
(WebCore::AccessibilityObject::hasIntValue):
(WebCore::AccessibilityObject::intValue):
(WebCore::AccessibilityObject::stringValue):
(WebCore::labelForElement):
(WebCore::AccessibilityObject::title):
(WebCore::AccessibilityObject::accessibilityDescription):
(WebCore::AccessibilityObject::boundingBoxRect):
(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::linkedUIElement):
(WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
(WebCore::AccessibilityObject::accessibilityIsIgnored):
(WebCore::AccessibilityObject::loaded):
(WebCore::AccessibilityObject::layoutCount):
(WebCore::AccessibilityObject::textLength):
(WebCore::AccessibilityObject::selectedText):
(WebCore::AccessibilityObject::selection):
(WebCore::AccessibilityObject::selectedTextRange):
(WebCore::AccessibilityObject::setSelectedText):
(WebCore::AccessibilityObject::setSelectedTextRange):
(WebCore::AccessibilityObject::makeRangeVisible):
(WebCore::AccessibilityObject::url):
(WebCore::AccessibilityObject::isVisited):
(WebCore::AccessibilityObject::isFocused):
(WebCore::AccessibilityObject::setFocused):
(WebCore::AccessibilityObject::setValue):
(WebCore::AccessibilityObject::isEnabled):
(WebCore::AccessibilityObject::press):
(WebCore::AccessibilityObject::topRenderer):
(WebCore::AccessibilityObject::textControl):
(WebCore::AccessibilityObject::widget):
(WebCore::AccessibilityObject::axObjectCache):
(WebCore::AccessibilityObject::documentLinks):
(WebCore::AccessibilityObject::documentFrameView):
(WebCore::AccessibilityObject::frameViewIfRenderView):
(WebCore::AccessibilityObject::visiblePositionRange):
(WebCore::AccessibilityObject::doAXTextMarkerRangeForLine):
(WebCore::AccessibilityObject::doAXTextMarkerRangeForUnorderedTextMarkers):
(WebCore::AccessibilityObject::doAXLeftWordTextMarkerRangeForTextMarker):
(WebCore::AccessibilityObject::doAXRightWordTextMarkerRangeForTextMarker):
(WebCore::updateAXLineStartForVisiblePosition):
(WebCore::AccessibilityObject::doAXLeftLineTextMarkerRangeForTextMarker):
(WebCore::AccessibilityObject::doAXRightLineTextMarkerRangeForTextMarker):
(WebCore::AccessibilityObject::doAXSentenceTextMarkerRangeForTextMarker):
(WebCore::AccessibilityObject::doAXParagraphTextMarkerRangeForTextMarker):
(WebCore::startOfStyleRange):
(WebCore::endOfStyleRange):
(WebCore::AccessibilityObject::doAXStyleTextMarkerRangeForTextMarker):
(WebCore::AccessibilityObject::textMarkerRangeForRange):
(WebCore::AccessibilityObject::stringForReplacedNode):
(WebCore::AccessibilityObject::doAXStringForTextMarkerRange):
(WebCore::AccessibilityObject::doAXBoundsForTextMarkerRange):
(WebCore::AccessibilityObject::doAXLengthForTextMarkerRange):
(WebCore::AccessibilityObject::doSetAXSelectedTextMarkerRange):
(WebCore::AccessibilityObject::doAXTextMarkerForPosition):
(WebCore::AccessibilityObject::doAXNextTextMarkerForTextMarker):
(WebCore::AccessibilityObject::doAXPreviousTextMarkerForTextMarker):
(WebCore::AccessibilityObject::doAXNextWordEndTextMarkerForTextMarker):
(WebCore::AccessibilityObject::doAXPreviousWordStartTextMarkerForTextMarker):
(WebCore::AccessibilityObject::doAXNextLineEndTextMarkerForTextMarker):
(WebCore::AccessibilityObject::doAXPreviousLineStartTextMarkerForTextMarker):
(WebCore::AccessibilityObject::doAXNextSentenceEndTextMarkerForTextMarker):
(WebCore::AccessibilityObject::doAXPreviousSentenceStartTextMarkerForTextMarker):
(WebCore::AccessibilityObject::doAXNextParagraphEndTextMarkerForTextMarker):
(WebCore::AccessibilityObject::doAXPreviousParagraphStartTextMarkerForTextMarker):
(WebCore::AccessibilityObject::textMarkerForIndex):
(WebCore::AccessibilityObject::doAXUIElementForTextMarker):
(WebCore::AccessibilityObject::doAXLineForTextMarker):
(WebCore::AccessibilityObject::rangeForTextMarkerRange):
(WebCore::AccessibilityObject::indexForTextMarker):
(WebCore::AccessibilityObject::doAXRangeForLine):
(WebCore::AccessibilityObject::doAXRangeForPosition):
(WebCore::AccessibilityObject::doAXRangeForIndex):
(WebCore::AccessibilityObject::doAXStyleRangeForIndex):
(WebCore::AccessibilityObject::doAXStringForRange):
(WebCore::AccessibilityObject::doAXBoundsForRange):
(WebCore::AccessibilityObject::doAXLineForIndex):
(WebCore::AccessibilityObject::doAccessibilityHitTest):
(WebCore::AccessibilityObject::focusedUIElement):
(WebCore::AccessibilityObject::observableObject):
(WebCore::AccessibilityObject::roleValue):
(WebCore::AccessibilityObject::canSetFocusAttribute):
(WebCore::AccessibilityObject::canSetValueAttribute):
(WebCore::AccessibilityObject::canSetTextRangeAttributes):
(WebCore::AccessibilityObject::childrenChanged):
(WebCore::AccessibilityObject::clearChildren):
(WebCore::AccessibilityObject::hasChildren):
(WebCore::AccessibilityObject::addChildren):
(WebCore::AccessibilityObject::axObjectID):
(WebCore::AccessibilityObject::setAXObjectID):
(WebCore::AccessibilityObject::removeAXObjectID):
* page/AccessibilityObject.h: Added.
(WebCore::):
(WebCore::VisiblePositionRange::VisiblePositionRange):
(WebCore::VisiblePositionRange::isNull):
(WebCore::AccessibilityObject::detached):
(WebCore::AccessibilityObject::PlainTextRange::PlainTextRange):
(WebCore::AccessibilityObject::PlainTextRange::isNull):
(WebCore::AccessibilityObject::renderer):
(WebCore::AccessibilityObject::children):
(WebCore::AccessibilityObject::wrapper):
(WebCore::AccessibilityObject::setWrapper):
* page/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::getAXID):
(WebCore::AXObjectCache::removeAXID):
(WebCore::AXObjectCache::textMarkerForVisiblePosition):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::postNotificationToElement):
* page/mac/AccessibilityObjectMac.mm: Added.
(createAccessibilityRoleMap):
(RoleEntry::):
(roleValueToNSString):
(AccessibilityObject::attachmentView):
(AccessibilityObject::performPressActionForAttachment):
(AccessibilityObject::textMarkerRange):
(AccessibilityObject::textMarkerForVisiblePosition):
(AccessibilityObject::startTextMarker):
(AccessibilityObject::visiblePositionForTextMarker):
(AccessibilityObject::visiblePositionForStartOfTextMarkerRange):
(AccessibilityObject::visiblePositionForEndOfTextMarkerRange):
(AccessibilityObject::textMarkerRangeFromVisiblePositions):
(AccessibilityObject::textMarkerRangeForSelection):
(AccessibilityObject::textMarkerRangeFromMarkers):
(AccessibilityObject::convertViewRectToScreenCoords):
(AccessibilityObject::convertAbsolutePointToViewCoords):
(AccessibilityObject::convertWidgetChildrenToNSArray):
(AccessibilityObject::position):
(AccessibilityObject::role):
(AccessibilityObject::subrole):
(AccessibilityObject::roleDescription):
(blockquoteLevel):
(AccessibilityObject::AXAttributeStringSetElement):
(AXAttributeStringSetBlockquoteLevel):
(CreateCGColorIfDifferent):
(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetFont):
(AXAttributeStringSetStyle):
(AccessibilityObject::AXAttributeStringSetHeadingLevel):
(AccessibilityObject::AXLinkElementForNode):
(AXAttributeStringSetSpelling):
(AccessibilityObject::AXAttributedStringAppendText):
(nsStringForReplacedNode):
(AccessibilityObject::doAXAttributedStringForTextMarkerRange):
(AccessibilityObject::doAXAttributedStringForRange):
(AccessibilityObject::doAXRTFForRange):
* page/mac/AccessibilityObjectWrapper.h: Added.
* page/mac/AccessibilityObjectWrapper.mm: Added.
(-[AccessibilityObjectWrapper initWithAccessibilityObject:]):
(-[AccessibilityObjectWrapper unregisterUniqueIdForUIElement]):
(-[AccessibilityObjectWrapper detach]):
(-[AccessibilityObjectWrapper accessibilityObject]):
(-[AccessibilityObjectWrapper accessibilityActionNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
(-[AccessibilityObjectWrapper renderWidgetChildren]):
(convertToNSArray):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
(-[AccessibilityObjectWrapper accessibilityHitTest:]):
(-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[AccessibilityObjectWrapper accessibilityIsIgnored]):
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityPerformAction:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(rendererForView):
(-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
(-[AccessibilityObjectWrapper accessibilityActionDescription:]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[AccessibilityObjectWrapper accessibilityShouldUseUniqueId]):
* page/mac/WebCoreAXObject.h: Removed.
* page/mac/WebCoreAXObject.mm: Removed.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::selectElement):
* rendering/RenderMenuList.h:
WebKit/mac:
2008-03-31 Alice Liu <alice.liu@apple.com>
Reviewed by Darin.
* WebView/WebFrame.mm:
(-[WebFrame _accessibilityTree]):
The syntax for fetching an object from the AXObjectCache changed slightly
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 1 Apr 2008 08:24:16 +0000 (08:24 +0000)]
2008-04-01 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
* Change the order of the methods to match with the FrameLoaderClient.h to ease
removing methods in the future.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31516
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 1 Apr 2008 08:24:04 +0000 (08:24 +0000)]
2008-04-01 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
* Remove virtuals in the FrameLoaderClientQt that don't exist in the base class.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 1 Apr 2008 06:54:09 +0000 (06:54 +0000)]
- fix previous attempted fixes
* platform/qt/TemporaryLinkStubs.cpp:
(PluginDatabase::getPluginPathsInDirectories):
* platform/wx/TemporaryLinkStubs.cpp:
(PluginDatabase::getPluginPathsInDirectories):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31513
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 1 Apr 2008 06:40:40 +0000 (06:40 +0000)]
- fix Qt link stubs
* platform/qt/TemporaryLinkStubs.cpp:
(PluginDatabase::getPluginPathsInDirectories):
(PluginDatabase::isPreferredPluginDirectory):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 1 Apr 2008 06:31:41 +0000 (06:31 +0000)]
- try to fix the Wx build
* platform/wx/TemporaryLinkStubs.cpp:
(PluginDatabase::getPluginPathsInDirectories):
(PluginDatabase::isPreferredPluginDirectory):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 1 Apr 2008 06:26:11 +0000 (06:26 +0000)]
- Gtk and Qt build fixes
* platform/graphics/gtk/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/gtk/FontCustomPlatformData.h:
* platform/graphics/qt/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/qt/FontCustomPlatformData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 1 Apr 2008 06:04:05 +0000 (06:04 +0000)]
- Mac build fix
* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/mac/FontCustomPlatformData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 1 Apr 2008 05:49:35 +0000 (05:49 +0000)]
2008-03-31 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- fix <rdar://problem/5792638> @font-face with downloadable fonts doesn't work with GDI text
* WebCore.vcproj/WebCore.vcproj: Added GetEOTHeader.{h,cpp}
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData): Changed to pass the rendering
mode to CachedFont::platformDataFromCustomData().
* loader/CachedFont.cpp:
(WebCore::CachedFont::platformDataFromCustomData): Added a rendering
mode parameter which is passed down to
FontCustomPlatformData::fontPlatformData().
* loader/CachedFont.h:
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::fontExists): Changed the number 5 to the named
constant CLEARTYPE_QUALITY.
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData): Added code
to delete the embedded font reference.
(WebCore::FontCustomPlatformData::fontPlatformData): Added code to
create an HFONT from the embedded font reference and pass it along with
the CGFontRef to the FontPlatformData constructor. Added a rendering
mode parameter which is passed down to the FontPlatformData constructor.
(WebCore::EOTStream::EOTStream): Added this helper class used to feed
data to TTLoadEmbeddedFont().
(WebCore::EOTStream::read): Added.
(WebCore::readEmbedProc): Added this TTLoadEmbeddedFont() callback.
(WebCore::createUniqueFontName): Added. Creates a unique GUID-derived
font name.
(WebCore::createFontCustomPlatformData): Added code to make the font
accessible to GDI by creating an Embedded OpenType stream and
activating it in the process under a globally-unique name.
* platform/graphics/win/FontCustomPlatformData.h:
Added a font reference data member which holds the embedded font.
(WebCore::FontCustomPlatformData::FontCustomPlatformData): Added a
rendering mode parameter.
* platform/graphics/win/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData): Made this class always
own the CGFontRef and the HFONT by turning these data members into a
RetainPtr and a RefPtr around a RefCountedHFONT.
Added an HFONT parameter to the CGFontRef-based constructor.
Made platformDataInit() private.
(WebCore::FontPlatformData::hfont):
(WebCore::FontPlatformData::cgFont):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::RefCountedHFONT::RefCountedHFONT): Added.
(WebCore::FontPlatformData::RefCountedHFONT::~RefCountedHFONT):
(WebCore::FontPlatformData::RefCountedHFONT::hfont):
(WebCore::FontPlatformData::RefCountedHFONT::hash):
* platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::FontPlatformData::platformDataInit): Changed to take
ownership of the CGFontRef created here.
(WebCore::FontPlatformData::FontPlatformData): Added an HFONT parameter
and a useGDI flag.
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Changed to take ownership
of the HFONT.
* platform/graphics/win/GetEOTHeader.cpp: Added.
(WebCore::BigEndianUShort::operator unsigned short):
(WebCore::BigEndianULong::operator unsigned):
(WebCore::appendBigEndianStringToEOTHeader):
(WebCore::getEOTHeader): Added. Creates an Embedded OpenType (.eot)
header for the given font data, making it suitable as input for
TTLoadEmbeddedFont.
* platform/graphics/win/GetEOTHeader.h: Added.
* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformDestroy): Removed code to delete parts
of the FontPlatformData, since they are now always owned and managed
by the FontPlatformData.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 1 Apr 2008 03:25:26 +0000 (03:25 +0000)]
2008-03-31 Darin Adler <darin@apple.com>
Reviewed by Anders.
- fix crash seen on buildbot (regression from a recent speedup)
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::createElement): Check validity before calling isLower, since
that takes care of the null string case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log