WebKit-https.git
6 years agoAdded a Radar number to my last ChangeLog
ggaren@apple.com [Mon, 24 Jun 2013 17:42:22 +0000 (17:42 +0000)]
Added a Radar number to my last ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPotential crash when in-band track is removed
eric.carlson@apple.com [Mon, 24 Jun 2013 17:12:07 +0000 (17:12 +0000)]
Potential crash when in-band track is removed
https://bugs.webkit.org/show_bug.cgi?id=117938
<rdar://problem/14246763>

Reviewed by Jer Noble.

This is timing dependent and I was unable to come up with a reliable test.

* html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::willRemoveTextTrackPrivate): Early return if the media element
    has been cleared.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] WTF.dll is linking with CoreFoundation.lib in VS2010.
commit-queue@webkit.org [Mon, 24 Jun 2013 16:25:28 +0000 (16:25 +0000)]
[WinCairo] WTF.dll is linking with CoreFoundation.lib in VS2010.
https://bugs.webkit.org/show_bug.cgi?id=117294

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-24
Reviewed by Brent Fulgham.

WinCairo build should not use CoreFoundation.

* WTF.vcxproj/WTFCFLite.props: Added.
* WTF.vcxproj/WTFCommon.props: Remove CoreFoundation.lib from depencency list.
* WTF.vcxproj/WTFCoreFoundation.props: Added.
* WTF.vcxproj/WTFDebug.props: Import WTFCoreFoundation.props for WinApple.
* WTF.vcxproj/WTFDebugWinCairo.props: Import WTFCFLite.props for WinCairo.
* WTF.vcxproj/WTFRelease.props: Import WTFCoreFoundation.props for WinApple.
* WTF.vcxproj/WTFReleaseWinCairo.props: Import WTFCFLite.props for WinCairo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWaveTable name has changed to PeriodicWave
crogers@google.com [Mon, 24 Jun 2013 16:21:52 +0000 (16:21 +0000)]
WaveTable name has changed to PeriodicWave
https://bugs.webkit.org/show_bug.cgi?id=117748

Reviewed by Jer Noble.

Source/WebCore:

See related Web Audio bug and spec change:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=19561
https://dvcs.w3.org/hg/audio/rev/7c4a40a9bb57

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createPeriodicWave):
* Modules/webaudio/AudioContext.h:
* Modules/webaudio/AudioContext.idl:
* Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::OscillatorNode):
(WebCore::OscillatorNode::setType):
(WebCore::OscillatorNode::calculateSampleAccuratePhaseIncrements):
(WebCore::OscillatorNode::process):
(WebCore::OscillatorNode::setPeriodicWave):
(WebCore::OscillatorNode::propagatesSilence):
* Modules/webaudio/OscillatorNode.h:
* Modules/webaudio/OscillatorNode.idl:
* Modules/webaudio/PeriodicWave.cpp: Renamed from Source/WebCore/Modules/webaudio/WaveTable.cpp.
(WebCore::PeriodicWave::create):
(WebCore::PeriodicWave::createSine):
(WebCore::PeriodicWave::createSquare):
(WebCore::PeriodicWave::createSawtooth):
(WebCore::PeriodicWave::createTriangle):
(WebCore::PeriodicWave::PeriodicWave):
(WebCore::PeriodicWave::waveDataForFundamentalFrequency):
(WebCore::PeriodicWave::maxNumberOfPartials):
(WebCore::PeriodicWave::numberOfPartialsForRange):
(WebCore::PeriodicWave::createBandLimitedTables):
(WebCore::PeriodicWave::generateBasicWaveform):
* Modules/webaudio/PeriodicWave.h: Renamed from Source/WebCore/Modules/webaudio/WaveTable.h.
(WebCore::PeriodicWave::rateScale):
(WebCore::PeriodicWave::periodicWaveSize):
(WebCore::PeriodicWave::sampleRate):
(WebCore::PeriodicWave::numberOfRanges):
* Modules/webaudio/PeriodicWave.idl: Renamed from Source/WebCore/Modules/webaudio/WaveTable.idl.
* Target.pri:
* WebCore.xcodeproj/project.pbxproj:

Tools:

* Scripts/do-webcore-rename:

LayoutTests:

* fast/js/global-constructors-attributes-expected.txt:
* webaudio/oscillator-basic-expected.txt:
* webaudio/oscillator-basic.html:
* webaudio/oscillator-custom.html:
* webaudio/resources/oscillator-testing.js:
(generateExponentialOscillatorSweep):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Unreviewed build correction after r151868
bfulgham@apple.com [Mon, 24 Jun 2013 15:35:49 +0000 (15:35 +0000)]
[Mac] Unreviewed build correction after r151868
New test expecation had been placed in the wrong directory.

* platform/mac/accessibility/listitem-title-expected.txt: Copied from platform/mac/listitem-title-actual.txt.
* platform/mac/listitem-title-actual.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCommented IDL implements statements should not impact code generation
ch.dumez@sisa.samsung.com [Mon, 24 Jun 2013 15:14:28 +0000 (15:14 +0000)]
Commented IDL implements statements should not impact code generation
https://bugs.webkit.org/show_bug.cgi?id=117932

Reviewed by Kentaro Hara.

Fix regular expression in preprocess-idls.pl script so that commented
IDL implements statements no longer cause any code to be generated.

No new tests, covered by TestObj.idl.

* bindings/scripts/preprocess-idls.pl:
(getImplementedInterfacesFromIDL):
* bindings/scripts/test/TestObj.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdopt is/toHTMLStyleElement for minor code cleanup
kangil.han@samsung.com [Mon, 24 Jun 2013 15:12:52 +0000 (15:12 +0000)]
Adopt is/toHTMLStyleElement for minor code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117917

Reviewed by Antti Koivisto.

This patch refers to http://src.chromium.org/viewvc/blink?view=revision&revision=152853

There are some usages of static_cast to HTMLStyleElement so this patch creates toHTMLStyleElement
function for code cleanup. Plus, isHTMLStyleElement is also made for same purpose.

* css/CSSStyleSheet.cpp:
(WebCore::isAcceptableCSSStyleSheetParent):
* css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::scopeFor):
* css/StyleSheetList.cpp:
(WebCore::StyleSheetList::getNamedItem):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
* dom/Node.cpp:
(WebCore::Node::numberOfScopedHTMLStyleChildren):
* html/HTMLStyleElement.h:
(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::inlineStyleSheetText):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCleanup RenderThemeWin after r151783 and r151794.
paroga@webkit.org [Mon, 24 Jun 2013 15:09:35 +0000 (15:09 +0000)]
Cleanup RenderThemeWin after r151783 and r151794.
https://bugs.webkit.org/show_bug.cgi?id=117936

Reviewed by Alexis Menard.

GetSysColor() takes an integer as argument. Let cssValueIdToSysColorIndex()
return an int instead of casting the values to the CSSValueID type.

* rendering/RenderThemeWin.cpp:
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWin::systemColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse SetFilePointer instead of SetFilePointerEx in FileSystemWin
paroga@webkit.org [Mon, 24 Jun 2013 14:16:42 +0000 (14:16 +0000)]
Use SetFilePointer instead of SetFilePointerEx in FileSystemWin
https://bugs.webkit.org/show_bug.cgi?id=116205

Reviewed by Ryosuke Niwa.

SetFilePointerEx is not available on Windows CE, so use SetFilePointer.
Also add a extra return for the case of an failure.

* platform/win/FileSystemWin.cpp:
(WebCore::seekFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIntroduce WindowTimers IDL interface
ch.dumez@sisa.samsung.com [Mon, 24 Jun 2013 14:07:53 +0000 (14:07 +0000)]
Introduce WindowTimers IDL interface
https://bugs.webkit.org/show_bug.cgi?id=117929

Reviewed by Kentaro Hara.

Introduce WindowTimers IDL interface and have both DOMWindow and WorkerContext
implement it to match the latest specification and avoid IDL duplication:
- http://www.whatwg.org/specs/web-apps/current-work/multipage/timers.html#windowtimers
- http://dev.w3.org/html5/workers/#apis-available-to-workers

No new tests, no behavior change.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* page/DOMWindow.idl:
* page/WindowTimers.idl:
* workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix for WinCE after r151563.
paroga@webkit.org [Mon, 24 Jun 2013 13:58:22 +0000 (13:58 +0000)]
Build fix for WinCE after r151563.

* bindings/js/JSDOMBinding.cpp:
(WebCore::toInt8): Use fabs() instead of abs().
(WebCore::toUInt8): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix for WinCE after r151783.
paroga@webkit.org [Mon, 24 Jun 2013 13:09:08 +0000 (13:09 +0000)]
Build fix for WinCE after r151783.

* rendering/RenderThemeWinCE.cpp:
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWinCE::systemColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CMAKE] Clear unused cmakedefines
ryuan.choi@samsung.com [Mon, 24 Jun 2013 12:31:34 +0000 (12:31 +0000)]
[CMAKE] Clear unused cmakedefines
https://bugs.webkit.org/show_bug.cgi?id=117931

Reviewed by Christophe Dumez.

* Source/cmakeconfig.h.cmake:
Removed ENABLE_AS_IMAGE, ENABLE_LEGACY_WEBKIT_BLOB_BUILDER and
ENABLE_CLIENT_BASED_GEOLOCATION cmakedefines which already removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Implement unit test callback: onWordGuesses.
commit-queue@webkit.org [Mon, 24 Jun 2013 09:38:06 +0000 (09:38 +0000)]
[EFL][WK2] Implement unit test callback: onWordGuesses.
https://bugs.webkit.org/show_bug.cgi?id=117794

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-06-24
Reviewed by Christophe Dumez.

* UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(onWordGuesses):
Add client suggestions for the word.

(checkClientSuggestionsForWord):
Verify the suggestions that were given by the client.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r151021.
commit-queue@webkit.org [Mon, 24 Jun 2013 09:32:54 +0000 (09:32 +0000)]
Unreviewed, rolling out r151021.
http://trac.webkit.org/changeset/151021
https://bugs.webkit.org/show_bug.cgi?id=117924

caused regressions on Qt and GTK (#117141 and #117688)
(Requested by philn on #webkit).

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):
(webKitWebSrcFinalize):
(webKitWebSrcSetProperty):
(webKitWebSrcGetProperty):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):
(StreamingClient::StreamingClient):
(StreamingClient::~StreamingClient):
(StreamingClient::didReceiveResponse):
(StreamingClient::didReceiveData):
(StreamingClient::didFinishLoading):
(StreamingClient::wasBlocked):
(StreamingClient::cannotShowURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Skipping the crashing tests on debug bots.
zarvai@inf.u-szeged.hu [Mon, 24 Jun 2013 08:03:41 +0000 (08:03 +0000)]
[Qt] Unreviewed gardening. Skipping the crashing tests on debug bots.
https://bugs.webkit.org/show_bug.cgi?id=94458

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-24

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove IDL implements statements to IDL files that implement the interface
ch.dumez@sisa.samsung.com [Mon, 24 Jun 2013 07:58:35 +0000 (07:58 +0000)]
Move IDL implements statements to IDL files that implement the interface
https://bugs.webkit.org/show_bug.cgi?id=117921

Reviewed by Kentaro Hara.

Move IDL implements statements to IDL files that implement the interface
so that we can more easily know that a given IDL interface implements
another.

The generator now enforces this as well for consistency.

No new tests, covered by TestImplements.idl.

* bindings/scripts/preprocess-idls.pl:
(getImplementedInterfacesFromIDL):
* bindings/scripts/test/TestImplements.idl:
* bindings/scripts/test/TestInterface.idl:
* dom/CharacterData.idl:
* dom/ChildNode.idl:
* dom/DocumentType.idl:
* dom/Element.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHittest finds the truncated text instead of the floating input, when the input is...
commit-queue@webkit.org [Mon, 24 Jun 2013 07:32:21 +0000 (07:32 +0000)]
Hittest finds the truncated text instead of the floating input, when the input is clicked.
https://bugs.webkit.org/show_bug.cgi?id=115675

Patch by Zalan Bujtas <zalan@apple.com> on 2013-06-24
Reviewed by David Hyatt.

Ignore truncated text on inline textbox and everything beyond the ellipsis box on
the root inlinebox while hittesting. (provided that nodeAtPoint finds no hit for any of
the root inline's children.)

Source/WebCore:

Test: fast/css/text-overflow-ellipsis-and-floating-input-hittest.html

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):

LayoutTests:

* fast/css/text-overflow-ellipsis-and-floating-input-hittest-expected.txt: Added.
* fast/css/text-overflow-ellipsis-and-floating-input-hittest.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: Rebaseline test after r151868
bfulgham@apple.com [Mon, 24 Jun 2013 06:20:34 +0000 (06:20 +0000)]
AX: Rebaseline test after r151868
https://bugs.webkit.org/show_bug.cgi?id=117892

Rubber stamped by Chris Fleizach.

* platform/mac/accessibility/lists-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening. Unskip two media tests because there is no crash after...
gyuyoung.kim@samsung.com [Mon, 24 Jun 2013 05:49:47 +0000 (05:49 +0000)]
Unreviewed EFL gardening. Unskip two media tests because there is no crash after system update.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSort all the Xcode project files
darin@apple.com [Mon, 24 Jun 2013 00:40:06 +0000 (00:40 +0000)]
Sort all the Xcode project files
https://bugs.webkit.org/show_bug.cgi?id=117696

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

* JavaScriptCore.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/ThirdParty:

* gtest/xcode/Samples/FrameworkSample/WidgetFramework.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.
* gtest/xcode/gtest.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/ThirdParty/ANGLE:

* ANGLE.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/WebInspectorUI:

* WebInspectorUI.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/WebKit2:

* WebKit2.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/WTF:

* WTF.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove redundant helper from RenderRegion.
commit-queue@webkit.org [Sun, 23 Jun 2013 06:24:15 +0000 (06:24 +0000)]
Remove redundant helper from RenderRegion.
https://bugs.webkit.org/show_bug.cgi?id=117915

Patch by Zalan Bujtas <zalan@apple.com> on 2013-06-22
Reviewed by Andreas Kling.

Minor code cleanup.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOversetState):
(WebCore::RenderRegion::setRegionOversetState):
* rendering/RenderRegion.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Add support for MHTML save/load feature to MiniBrowser
commit-queue@webkit.org [Sun, 23 Jun 2013 06:14:13 +0000 (06:14 +0000)]
[EFL] Add support for MHTML save/load feature to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=106620

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-06-22
Reviewed by Christophe Dumez.

Enable CTRL + S as save page in mhtml and CTRL + L to load any page
from filesystem.

* MiniBrowser/efl/CMakeLists.txt:
* MiniBrowser/efl/main.c:
(page_contents_callback):
(on_key_down):
(show_file_entry_dialog): generic function to show file enrty
selector dialogue

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSlightly reduce width threshold on detection of primary snapshotted Plug-In
dino@apple.com [Sat, 22 Jun 2013 23:33:48 +0000 (23:33 +0000)]
Slightly reduce width threshold on detection of primary snapshotted Plug-In
https://bugs.webkit.org/show_bug.cgi?id=117914
<rdar://problem/14136687>

Reviewed by Simon Fraser.

We've noticed some content that should be detected as the primary snapshotted plug-in,
but is just a bit smaller than our 450x300 minimum threshold. Reduce the width to 400.

* WebProcess/WebPage/WebPage.cpp: Change primarySnapshottedPlugInMinimumWidth from 450 to 400.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix after r151878.
mrowe@apple.com [Sat, 22 Jun 2013 23:16:42 +0000 (23:16 +0000)]
Build fix after r151878.

* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::startLoading): Pass the new UseDefaultOriginRestrictionsForType
argument to the ResourceLoaderOptions constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFollowup from r151877 .
simon.fraser@apple.com [Sat, 22 Jun 2013 20:29:30 +0000 (20:29 +0000)]
Followup from r151877 .
Fix crash in fast/frames/iframe-access-screen-of-deleted.html by null-checking the widget.

* platform/mac/PlatformScreenMac.mm:
(WebCore::screenForWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] limit shape image values to same origin
hmuller@adobe.com [Sat, 22 Jun 2013 19:56:37 +0000 (19:56 +0000)]
[CSS Shapes] limit shape image values to same origin
https://bugs.webkit.org/show_bug.cgi?id=117610

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Restrict the image URL values for shape-inside and shape-outside to
the same origin as the document. The alpha channel of image shape values
will be thresholded to produce the shape's boundaries (see bug 116643)
so normal image access rules aren't secure enough.

Added a RequestOriginPolicy ResourceLoaderOption which is used by
StyleResolver::loadPendingShapeImage() to request the additional restriction.
The change should have no other effect although it does enable one to apply
the same restriction to other resources which can currently be loaded from
any origin - see CachedResourceLoader::canRequest().

Test: http/tests/security/shape-inside-image-origin.html

* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage): Add an effectively optional ResourceLoaderOptions parameter.
* css/CSSImageValue.h:
(WebCore::CSSImageValue::cachedImage): Ditto.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingShapeImage): Load the image with the default CachedResourceLoader options plus RestrictToSameOrigin.
(WebCore::StyleResolver::loadPendingImages): Call loadPendingShapeImage().
* css/StyleResolver.h:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource): Update the ResourceLoaderOptions static variable.
* loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader): Ditto.
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::options):
* loader/ResourceLoaderOptions.h: Add RequestOriginPolicy enum.
(WebCore::ResourceLoaderOptions::ResourceLoaderOptions):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest): Pass ResourceLoaderOptions along to revised CachedResourceLoader::canRequest().
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet): Update load() ResourceLoaderOptions.
(WebCore::CachedResourceLoader::canRequest): Replaced ContentSecurityPolicyCheck parameter with ResourceLoaderOptions.
(WebCore::CachedResourceLoader::requestResource): Pass ResourceLoaderOptions along to revised CachedResourceLoader::canRequest().
(WebCore::CachedResourceLoader::defaultCachedResourceOptions): Added UseDefaultOriginRestrictionsForType initializer.
* loader/cache/CachedResourceLoader.h:
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading): Added UseDefaultOriginRestrictionsForType intializer.

LayoutTests:

Verify that a non same-origin image URL specified for shape-inside or
shape-outside will not load and the shape property will be reset to "none".

* http/tests/resources/square100.png: Added.
* http/tests/security/shape-inside-image-origin-expected.txt: Added.
* http/tests/security/shape-inside-image-origin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoscreen.availWidth always returns width of primary display
simon.fraser@apple.com [Sat, 22 Jun 2013 19:41:31 +0000 (19:41 +0000)]
screen.availWidth always returns width of primary display
https://bugs.webkit.org/show_bug.cgi?id=117863

Source/WebCore:

Reviewed by Geoffrey Garen.

In WebKit2, Widgets have no platformWidget, so trying to get to the
NSScreen via the platform widget's window never succeeded, and we always
fell back on getting info for the main display.

However, we were already pushing the WKView's displayID down to the
WebProcess for the requestAnimationFrame infrastructure, so use that.

Add a virtual function on Widget windowDisplayID(), that is overridden
in FrameView to return the PlatformDisplayID which Page has.

Fix PlatformScreenMac to fall back to Widget::windowDisplayID() when it fails
to get an NSWindow from the Widget.

Add a utility category on NSScreen to get an NSScreen's displayID, and to
find an NSScreen given a displayID.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* page/FrameView.cpp:
(WebCore::FrameView::windowDisplayID):
* page/FrameView.h:
* platform/Widget.cpp:
(WebCore::Widget::windowDisplayID):
* platform/Widget.h:
* platform/mac/PlatformScreenMac.h: Added.
* platform/mac/PlatformScreenMac.mm:
(+[NSScreen screenForDislayID:]):
(-[NSScreen displayID]):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::windowDisplayID):

Source/WebKit2:

Reviewed by Geoffrey Garen.

In WebKit2, Widgets have no platformWidget, so trying to get to the
NSScreen via the platform widget's window never succeeded, and we always
fell back on getting info for the main display.

However, we were already pushing the WKView's displayID down to the
WebProcess for the requestAnimationFrame infrastructure, so use that.

The WebProcess would not receive a displayID for a WKView until the window
was activated; fix by calling -doWindowDidChangeScreen when the view
moves to a window, rather than doing it from -_windowDidBecomeKey:.

* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrashes due to NULL dereference beneath WebCore::StyleResolver::loadPendingSVGDocumen...
ggaren@apple.com [Sat, 22 Jun 2013 02:36:13 +0000 (02:36 +0000)]
Crashes due to NULL dereference beneath WebCore::StyleResolver::loadPendingSVGDocuments and related functions
https://bugs.webkit.org/show_bug.cgi?id=117903

Reviewed by Darin Adler.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingSVGDocuments): Add a NULL check for
RenderStyle here...
(WebCore::StyleResolver::loadPendingResources): ...and here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOccasional crash swiping between pages
simon.fraser@apple.com [Sat, 22 Jun 2013 01:10:24 +0000 (01:10 +0000)]
Occasional crash swiping between pages
https://bugs.webkit.org/show_bug.cgi?id=117902

Reviewed by Beth Dakin.

m_scrollingStateTree->rootStateNode() can be null when quickly swiping between pages,
so check this in ScrollingCoordinatorMac::commitTreeState().

* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::commitTreeState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed crash protection for DRT
bfulgham@apple.com [Sat, 22 Jun 2013 00:25:55 +0000 (00:25 +0000)]
[Windows] Unreviewed crash protection for DRT

* DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
to avoid crashing during test runs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed gardening.
bfulgham@apple.com [Sat, 22 Jun 2013 00:08:34 +0000 (00:08 +0000)]
[Windows] Unreviewed gardening.

* platform/win/accessibility/aria-menubar-menuitems-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/JavaScriptCore: Introducing the VMStackBounds class.
mark.lam@apple.com [Fri, 21 Jun 2013 23:58:52 +0000 (23:58 +0000)]
Source/JavaScriptCore: Introducing the VMStackBounds class.
https://bugs.webkit.org/show_bug.cgi?id=117862.

Reviewed by Geoffrey Garen.

- Removed Interpreter::StackPolicy.
- The new VMStackBounds will take over choosing the appropriate stack
  size requirements, and invoking the underlying WTF::StackBounds to
  to the real bounds check.
- VMStackBounds will now be used universally throughout JSC instead of
  WTF::StackBounds.

* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* bytecompiler/BytecodeGenerator.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
* interpreter/Interpreter.h:
(JSC::Interpreter::isInErrorHandlingMode):
* parser/Parser.cpp:
(JSC::::Parser):
* parser/Parser.h:
* runtime/StringRecursionChecker.h:
(JSC::StringRecursionChecker::performCheck):
* runtime/VMStackBounds.h: Added.
(JSC::VMStackBounds::VMStackBounds):
(JSC::VMStackBounds::isSafeToRecurse):
(JSC::VMStackBounds::requiredCapacity):

LayoutTests: Reverting failure expectation for fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html.
https://bugs.webkit.org/show_bug.cgi?id=117862.

Reviewed by Geoffrey Garen.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: Title for ListItemRole should consist of concatenated child text elements.
bfulgham@apple.com [Fri, 21 Jun 2013 23:39:41 +0000 (23:39 +0000)]
AX: Title for ListItemRole should consist of concatenated child text elements.
https://bugs.webkit.org/show_bug.cgi?id=117892

Reviewed by Chris Fleizach.

Source/WebCore:

accessibility/listitem-title.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::visibleText): Add ListItemRole to set of
elements that concatenate their children for display purposes.
(WebCore::AccessibilityNodeObject::title): Ditto.

LayoutTests:

* accessibility/listitem-title.html: Added.
* platform/mac/accessibility/listitem-title-expected.txt: Added.
* platform/win/accessibility/listitem-title-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[MediaStream]: Remove ``>= 0'' assertion from a size_t variable
commit-queue@webkit.org [Fri, 21 Jun 2013 22:50:01 +0000 (22:50 +0000)]
[MediaStream]: Remove ``>= 0'' assertion from a size_t variable
https://bugs.webkit.org/show_bug.cgi?id=117890

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-06-21
Reviewed by Adam Barth.

This patch fixes a strict build by removing the ``>= 0'' assertion from
a size_t (unsigned type) variable in RTCStatsResponse.cpp.

No new tests; build fix.

* Modules/mediastream/RTCStatsResponse.cpp:
(WebCore::RTCStatsResponse::addStatistic): Remove ``>=0''assertion,
since the variable is unsigned and is always >= 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Uncaught exception when pretty printing WebInspector.Script
commit-queue@webkit.org [Fri, 21 Jun 2013 22:13:07 +0000 (22:13 +0000)]
Web Inspector: Uncaught exception when pretty printing WebInspector.Script
https://bugs.webkit.org/show_bug.cgi?id=117893

This was an issue with an earlier refactoring. The sourceCode is a Script,
so replace the non-existent local variable "script" with "this._sourceCode".

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-06-21
Reviewed by Timothy Hatcher.

* UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype.textEditorUpdatedFormatting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGraphicsContext3DNEON.h cannot be found on Windows and does not need to be found.
achristensen@apple.com [Fri, 21 Jun 2013 21:55:47 +0000 (21:55 +0000)]
GraphicsContext3DNEON.h cannot be found on Windows and does not need to be found.
https://bugs.webkit.org/show_bug.cgi?id=117894

Reviewed by Brent Fulgham.

* platform/graphics/GraphicsContext3D.cpp:
Added #if HAVE(ARM_NEON_INTRINSICS) around #include "GraphicsContext3DNEON.h"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIgnoring padding-right of inline elements in containers with undefined width
robert@webkit.org [Fri, 21 Jun 2013 21:04:21 +0000 (21:04 +0000)]
Ignoring padding-right of inline elements in containers with undefined width
https://bugs.webkit.org/show_bug.cgi?id=76451

Reviewed by David Hyatt.

Source/WebCore:

Collapsed trailing space on a normal wrap line should not cause a line-break
if it is the difference between fitting on the line and breaking. Likewise, on a line that
has a mix of auto-wrap and no-wrap inlines we don't want a trailing space at the end of a no-wrap inline
to be the difference between that no-wrap inline fitting or breaking the line. This latter
scenario is covered already by inline-whitespace-wrapping-8.html.

Test: fast/text/whitespace/inline-whitespace-wrapping-9.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::fitsOnLineIncludingExtraWidth):
(WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
(WebCore::LineWidth::currentWidth):
(WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

* fast/text/whitespace/inline-whitespace-wrapping-9-expected.html: Added.
* fast/text/whitespace/inline-whitespace-wrapping-9.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded WebGL source files to Windows build and made Windows build successfully with...
achristensen@apple.com [Fri, 21 Jun 2013 20:57:26 +0000 (20:57 +0000)]
Added WebGL source files to Windows build and made Windows build successfully with them.
https://bugs.webkit.org/show_bug.cgi?id=117853

Reviewed by Brent Fulgham.

* WebCore.vcxproj/WebCore.vcxproj: Added WebGL source files.
* WebCore.vcxproj/WebCore.vcxproj.filters: Added platform\graphics\opengl and platform\graphics\gpu filters.
* WebCore.vcxproj/WebCorePreBuild.cmd: Copy ANGLE headers and glext.h before building WebCore (which now uses them).
* platform/graphics/ANGLEWebKitBridge.h: Look in newly copied directory for ShaderLang.h.
* platform/graphics/OpenGLShims.h: Include GL/glext.h.
* platform/graphics/gpu/LoopBlinnShader.cpp:
(WebCore::LoopBlinnShader::use): Fixed parameter ordering in call to uniformMatrix4fv.
* platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::createOffScreenSurface): Added notImplemented for non-EGL builds for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate platform text track menu
eric.carlson@apple.com [Fri, 21 Jun 2013 20:37:31 +0000 (20:37 +0000)]
Update platform text track menu
https://bugs.webkit.org/show_bug.cgi?id=117884

Reviewed by Jer Noble.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setSelectedTextTrack):
* html/track/TextTrack.cpp:
(WebCore::TextTrack::platformTextTrack):
* platform/graphics/PlatformTextTrack.h:
(WebCore::PlatformTextTrack::create):
(WebCore::PlatformTextTrack::uniqueId):
(WebCore::PlatformTextTrack::captionMenuOffItem):
(WebCore::PlatformTextTrack::captionMenuAutomaticItem):
(WebCore::PlatformTextTrack::PlatformTextTrack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: audio/video playback control timers (elapsed and remaining) should be exposed...
commit-queue@webkit.org [Fri, 21 Jun 2013 20:21:07 +0000 (20:21 +0000)]
AX: audio/video playback control timers (elapsed and remaining) should be exposed as ApplicationTimerRole
https://bugs.webkit.org/show_bug.cgi?id=117883

Patch by James Craig <james@cookiecrook.com> on 2013-06-21
Reviewed by Chris Fleizach.

Some of the media controls were returning the wrong role. Updated existing test coverage.

Source/WebCore:

* accessibility/AccessibilityMediaControls.h:
(WebCore::AccessibilityMediaTimeDisplay::roleValue):

LayoutTests:

* accessibility/media-element.html:
* platform/mac/accessibility/media-element-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded glext.h from http://www.opengl.org/registry/oldspecs/glext.h for Windows
achristensen@apple.com [Fri, 21 Jun 2013 19:59:44 +0000 (19:59 +0000)]
Added glext.h from opengl.org/registry/oldspecs/glext.h for Windows
This file does not meet WebKit style guidelines.
Part of https://bugs.webkit.org/show_bug.cgi?id=117853

Reviewed by Brent Fulgham.

* platform/graphics/win/GL: Added.
* platform/graphics/win/GL/glext.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Fix a missing parenthesis in include directory path.
roger_fong@apple.com [Fri, 21 Jun 2013 18:47:33 +0000 (18:47 +0000)]
Unreviewed. Fix a missing parenthesis in include directory path.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorCommon.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStop removing and re-adding breakpoints from the backend on reload.
timothy@apple.com [Fri, 21 Jun 2013 18:16:58 +0000 (18:16 +0000)]
Stop removing and re-adding breakpoints from the backend on reload.

On reload the sourceCode for breakpoints are nulled out, which fires DisplayLocationDidChange.
Then the sourceCode is reassociated, firing DisplayLocationDidChange again. In these cases we
don't need to update the backend, since nothing really changed.

https://bugs.webkit.org/show_bug.cgi?id=117877

Reviewed by Joseph Pecoraro.

* UserInterface/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype._breakpointDisplayLocationDidChange): Return early when
_ignoreBreakpointDisplayLocationDidChangeEvent is true.
(WebInspector.DebuggerManager.prototype.reset): Set _ignoreBreakpointDisplayLocationDidChangeEvent.
(WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix TextTrackCue::cueIndex() to handle the null case of TextTrack::cues(() properly
commit-queue@webkit.org [Fri, 21 Jun 2013 18:08:06 +0000 (18:08 +0000)]
Fix TextTrackCue::cueIndex() to handle the null case of TextTrack::cues(() properly
https://bugs.webkit.org/show_bug.cgi?id=117815
<rdar://problem/14211041>

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-21
Reviewed by Ryosuke Niwa.

This patch adds assert statements to try to catch when
track()->cues() returns a null pointer.

* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::cueIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Hang drawing captions after pressing the home button while playing a video
jer.noble@apple.com [Fri, 21 Jun 2013 17:52:16 +0000 (17:52 +0000)]
[iOS] Hang drawing captions after pressing the home button while playing a video
https://bugs.webkit.org/show_bug.cgi?id=117882

Reviewed by Eric Carlson.

Instead of rendering in a callback on the main thread, pre-render the captions and pass to the main
thread as a CGImage. As such, rename paintTextTrackRepresentation() to createTextTrackRepresentationImage().

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage): Renamed from
    paintTextTrackRepresentation. Now returns an Image object.
* html/shadow/MediaControlElements.h:
* platform/graphics/MediaPlayer.h:
* platform/graphics/TextTrackRepresentation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Move overset compute code from flow thread to named flow thread
commit-queue@webkit.org [Fri, 21 Jun 2013 17:42:52 +0000 (17:42 +0000)]
[CSS Regions] Move overset compute code from flow thread to named flow thread
https://bugs.webkit.org/show_bug.cgi?id=117835

Patch by Radu Stavila <stavila@adobe.com> on 2013-06-21
Reviewed by Andreas Kling.

Moved computeOversetStateForRegions() and overset() methods from RenderFlowThread to RenderNamedFlowThread.
Added ASSERTS in RenderRegion::regionOversetState and RenderRegion::setRegionOversetState to ensure
the region was created from an element.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
* rendering/RenderFlowThread.h:
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::computeOversetStateForRegions):
* rendering/RenderNamedFlowThread.h:
(WebCore::RenderNamedFlowThread::overset):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOversetState):
(WebCore::RenderRegion::setRegionOversetState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r151838.
commit-queue@webkit.org [Fri, 21 Jun 2013 16:48:31 +0000 (16:48 +0000)]
Unreviewed, rolling out r151838.
http://trac.webkit.org/changeset/151838
https://bugs.webkit.org/show_bug.cgi?id=117880

Breaks MediaPlayerPrivateQt on Mac (Requested by carewolf on
#webkit).

* html/HTMLMediaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: [Windows] AX: Radio buttons with "tab" role should describe themselve...
bfulgham@apple.com [Fri, 21 Jun 2013 16:35:34 +0000 (16:35 +0000)]
Source/WebCore: [Windows] AX: Radio buttons with "tab" role should describe themselves as tabs
https://bugs.webkit.org/show_bug.cgi?id=117837

Reviewed by Chris Fleizach.

accessibility/aria-tab-role-on-buttons.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canSetSelectedAttribute): Indicate that certain accessibility
types (such as Tabs) can be selected.
* accessibility/AccessibilityNodeObject.h: Signature for canSelectAttribute override.

Source/WebKit/win: [Windows] AX: Radio buttons with "tab" role should describe themselves as tabs.
https://bugs.webkit.org/show_bug.cgi?id=117837

Reviewed by Chris Fleizach.

* AccessibleBase.cpp:
(MSAARole): Don't expose TabRole as a radio button to satisfy buggy screen readers.

LayoutTests: [Windows] AX: Radio buttons with "tab" role should describe themselves as tabs.
https://bugs.webkit.org/show_bug.cgi?id=117837

Reviewed by Chris Fleizach.

* accessibility/aria-tab-role-on-buttons.html: Added.
* accessibility/aria-tab-role-on-buttons-expected.txt: Added.
* platform/win/aria-tab-role-on-buttons-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unused GesturePinch events
allan.jensen@digia.com [Fri, 21 Jun 2013 16:12:54 +0000 (16:12 +0000)]
Remove unused GesturePinch events
https://bugs.webkit.org/show_bug.cgi?id=117875

Reviewed by Andreas Kling.

The gesturePinch events have not been used for some time, even Chromium
had stop using them before moving out of webkit.

* dom/GestureEvent.cpp:
(WebCore::GestureEvent::create):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* platform/PlatformEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImprove the reattaching process while applying the :hover style
commit-queue@webkit.org [Fri, 21 Jun 2013 16:03:10 +0000 (16:03 +0000)]
Improve the reattaching process while applying the :hover style
https://bugs.webkit.org/show_bug.cgi?id=117590

Patch by Radu Stavila <stavila@adobe.com> on 2013-06-21
Reviewed by Andreas Kling.

Source/WebCore:

Changes made:
    - context is properly propagated to the element's children and to Shadow DOM elements.
    - context is properly set on the lazyReattach method.
    - another hit-testing is triggered when needed.
    - when a hovered element is detached, it's ancestors are also removed from the hovered state.

Tests: fast/css/hover-display-block-inline.html
       fast/css/hover-display-block-none.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::attach):
(WebCore::ContainerNode::detach):
* dom/ContainerNode.h:
(WebCore::ContainerNode::attachChildren):
(WebCore::ContainerNode::detachChildrenIfNeeded):
(WebCore::ContainerNode::detachChildren):
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
(WebCore::Document::updateHoverActiveState):
* dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::detach):
* dom/ElementShadow.cpp:
(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::detach):
* dom/ElementShadow.h:
* dom/Node.h:
(WebCore::Node::lazyReattach):

LayoutTests:

Moved hover-display-block-inline.html and hover-display-block-none.html from fast/regions to fast/css.
Updated hover-display-block-none.html and hover-single-flow-into-other.html to ensure the outcome won't be affected by the machine's speed.
Updated input-file-re-render.html to stop it from failing on windows and linux machines (a more detailed description can be found inside the test itself).

* fast/css/hover-display-block-inline-expected.txt: Renamed from LayoutTests/fast/regions/hover-display-block-inline-expected.txt.
* fast/css/hover-display-block-inline.html: Renamed from LayoutTests/fast/regions/hover-display-block-inline.html.
* fast/css/hover-display-block-none-expected.txt: Renamed from LayoutTests/fast/regions/hover-display-block-none-expected.txt.
* fast/css/hover-display-block-none.html: Added.
* fast/css/hover-update-expected.txt:
* fast/css/hover-update.html:
* fast/forms/file/input-file-re-render.html:
* fast/regions/hover-display-block-none.html: Removed.
* fast/regions/hover-single-flow-into-other.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHTMLMediaElement should inherit from MediaPlayerClient privately
allan.jensen@digia.com [Fri, 21 Jun 2013 16:01:52 +0000 (16:01 +0000)]
HTMLMediaElement should inherit from MediaPlayerClient privately
https://bugs.webkit.org/show_bug.cgi?id=117874

Reviewed by Andreas Kling.

Fixing FIXME: HTMLMediaElement was stuck with public inheritance from
MediaPlayerClient due to the Chromium port.
This can now be fixed to a private inheritance.

* html/HTMLMediaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Chromium-only TouchDisambiguation
allan.jensen@digia.com [Fri, 21 Jun 2013 15:58:41 +0000 (15:58 +0000)]
Remove Chromium-only TouchDisambiguation
https://bugs.webkit.org/show_bug.cgi?id=117873

Reviewed by Andreas Kling.

* page/TouchDisambiguation.cpp: Removed.
* page/TouchDisambiguation.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRollout r150602: Restoring text-overflow vs. floating rendering behaviour.
commit-queue@webkit.org [Fri, 21 Jun 2013 15:45:21 +0000 (15:45 +0000)]
Rollout r150602: Restoring text-overflow vs. floating rendering behaviour.
https://bugs.webkit.org/show_bug.cgi?id=117871

Unreviewed. Rolling out r150602.
Undesirable rendering behaviour.

Patch by Zalan Bujtas <zalan@apple.com> on 2013-06-21

Source/WebCore:

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkLinesForTextOverflow):

LayoutTests:

* fast/css/text-overflow-ellipsis-behind-floats-expected.html:
* fast/css/text-overflow-ellipsis-behind-floats.html:
* fast/css/text-overflow-ellipsis-full-truncate-rtl-expected.html:
* fast/css/text-overflow-ellipsis-full-truncate-rtl.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Integrate new regionOversetChange event into inspector
commit-queue@webkit.org [Fri, 21 Jun 2013 14:31:26 +0000 (14:31 +0000)]
Web Inspector: Integrate new regionOversetChange event into inspector
https://bugs.webkit.org/show_bug.cgi?id=117833

Source/WebCore:

Added the new regionOversetChange event to the WebInspector.

Patch by Radu Stavila <stavila@adobe.com> on 2013-06-21
Reviewed by Joseph Pecoraro.

Tests:  inspector/styles/protocol-css-regions-commands.html:

* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
(WebCore::ChangeRegionOversetTask::scheduleFor):
(WebCore::ChangeRegionOversetTask::unschedule):
(WebCore::ChangeRegionOversetTask::reset):
(WebCore::ChangeRegionOversetTask::onTimer):
(WebCore::InspectorCSSAgent::resetNonPersistentData):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::didChangeRegionOverset):
(WebCore::InspectorCSSAgent::regionOversetChanged):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didChangeRegionOversetImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didChangeRegionOverset):
* inspector/front-end/CSSNamedFlowCollectionsView.js:
(WebInspector.CSSNamedFlowCollectionsView.prototype._regionOversetChanged):
(WebInspector.CSSNamedFlowCollectionsView.prototype.wasShown):
(WebInspector.CSSNamedFlowCollectionsView.prototype.willHide):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._regionOversetChanged):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.CSSDispatcher.prototype.regionOversetChanged):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEvent):

LayoutTests:

Tests for the new regionOversetChange event.

Patch by Radu Stavila <stavila@adobe.com> on 2013-06-21
Reviewed by Joseph Pecoraro.

* inspector/styles/protocol-css-regions-commands-expected.txt:
* inspector/styles/protocol-css-regions-commands.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] NetworkStateNotifierEfl: Use closeWithRetry instead of looping for EINTR on...
commit-queue@webkit.org [Fri, 21 Jun 2013 13:59:19 +0000 (13:59 +0000)]
[EFL] NetworkStateNotifierEfl: Use closeWithRetry instead of looping for EINTR on close
https://bugs.webkit.org/show_bug.cgi?id=117872

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-06-21
Reviewed by Christophe Dumez.

closeWithRetry works around the Linux behavior of closing the file descriptor
unconditionally even if the close() call is interrupted.

No new tests, no behavior change.

* platform/network/efl/NetworkStateNotifierEfl.cpp:
(WebCore::NetworkStateNotifier::~NetworkStateNotifier): Use closeWithRetry instead of
looping for EINTR on close.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Do not try to load videos in unit tests
carlosgc@webkit.org [Fri, 21 Jun 2013 11:41:39 +0000 (11:41 +0000)]
[GTK] Do not try to load videos in unit tests
https://bugs.webkit.org/show_bug.cgi?id=117866

Reviewed by Philippe Normand.

It makes the tests slower, and generates and error because we use
a fake src.

* UIProcess/API/gtk/tests/TestContextMenu.cpp:
(testContextMenuDefaultMenu): Use preload='none' in video tag.
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMouseTarget): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
ch.dumez@sisa.samsung.com [Fri, 21 Jun 2013 10:34:57 +0000 (10:34 +0000)]
REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
https://bugs.webkit.org/show_bug.cgi?id=117825

Reviewed by Kentaro Hara.

Source/WebCore:

Partially revert r150663 so that we use Settings to enable WebAudio instead of
RuntimeEnabledFeatures.

Introduce a new [EnabledBySetting] IDL extended attribute which behaves similarly to
the existing [EnabledAtRuntime] but relies on Settings instead of RuntimeEnabledFeatures
to determine if the feature should be enabled. Make use of this new IDL attribute for
webkitAudioContext interface.

No new tests, no behavior change.

* Modules/webaudio/AudioContext.idl:
* WebCore.exp.in:
* WebCore.order:
* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/preprocess-idls.pl:
(GenerateConstructorAttribute):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestObjTestSubObjEnabledBySettingConstructor):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj TestSubObjEnabledBySetting]):
(-[DOMTestObj setTestSubObjEnabledBySetting:]):
* bindings/scripts/test/TestObj.idl:
* page/Settings.in:

Source/WebKit/efl:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setWebAudioEnabled):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):

Source/WebKit/gtk:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Source/WebKit/mac:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):

Source/WebKit/win:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

* WebView.cpp:
(WebView::notifyPreferencesChanged):

Source/WebKit2:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Tools:

DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::overridePreference):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ATK] Added support for aria-required attribute.
commit-queue@webkit.org [Fri, 21 Jun 2013 10:33:34 +0000 (10:33 +0000)]
[ATK] Added support for aria-required attribute.
https://bugs.webkit.org/show_bug.cgi?id=117730

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-06-21
Reviewed by Chris Fleizach.

Source/WebCore:

Tests: accessibility/aria-required.html
       accessibility/html5-required-attribute.html

The aria-required attribute is used to indicate that user input is required on an
element before a form can be submitted.

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(setAtkStateSetFromCoreObject):

Tools:

Added support for testing aria-required attribute.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isRequired):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isRequired):

LayoutTests:

Moving specific platform accessibility tests.

* accessibility/aria-required-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-required-expected.txt.
* accessibility/aria-required.html: Renamed from LayoutTests/platform/mac/accessibility/aria-required.html.
* accessibility/html5-required-attribute-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/html5-required-attribute-expected.txt.
* accessibility/html5-required-attribute.html: Renamed from LayoutTests/platform/mac/accessibility/html5-required-attribute.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIndieUI: Add basic IndieUI infrastructure
cfleizach@apple.com [Fri, 21 Jun 2013 09:36:05 +0000 (09:36 +0000)]
IndieUI: Add basic IndieUI infrastructure
https://bugs.webkit.org/show_bug.cgi?id=117367

Unreviewed. Update Lion expected results.

* platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIndieUI: Add basic IndieUI infrastructure
cfleizach@apple.com [Fri, 21 Jun 2013 08:55:06 +0000 (08:55 +0000)]
IndieUI: Add basic IndieUI infrastructure
https://bugs.webkit.org/show_bug.cgi?id=117367

Unreviewed. Revert erroneous file that was included accidentally.

* accessibility/AccessibilityNodeObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2][EFL]: Invalidate the ProcessLauncher when the process is terminated before...
commit-queue@webkit.org [Fri, 21 Jun 2013 08:52:27 +0000 (08:52 +0000)]
[WK2][EFL]: Invalidate the ProcessLauncher when the process is terminated before it has finished launching
https://bugs.webkit.org/show_bug.cgi?id=117865

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-06-21
Reviewed by Christophe Dumez.

Original patch from Carlos Garcia Campos for the Gtk port.

* UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::terminateProcess): If process is still
launching, just invalidate the launcher. Reset the process
identifier after killing the process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIndieUI: Add basic IndieUI infrastructure
cfleizach@apple.com [Fri, 21 Jun 2013 08:51:37 +0000 (08:51 +0000)]
IndieUI: Add basic IndieUI infrastructure
https://bugs.webkit.org/show_bug.cgi?id=117367

Reviewed by Ryosuke Niwa.

Source/WebCore:

IndieUI is a new W3C spec that aims to abstract the connection between input and action, so that
a user (possibly using assistive technologies like a screen reader) does not need a specific kind
of device (like a mouse) to interact with an object.
http://www.w3.org/WAI/IndieUI/

This initial patch adds in the basic support for UIRequestEvent and the uiactions attribute.
It modifies the config files to enable and build this feature.

Tests: indieui/create-uirequestevent.html
       indieui/uiactions.html

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* GNUmakefile.am:
* Modules/indieui: Added.
* Modules/indieui/UIRequestEvent.cpp: Added.
(WebCore::UIRequestEventInit::UIRequestEventInit):
(WebCore::UIRequestEvent::create):
(WebCore::UIRequestEvent::UIRequestEvent):
(WebCore::UIRequestEvent::~UIRequestEvent):
(WebCore::UIRequestEvent::interfaceName):
(WebCore::UIRequestEventDispatchMediator::UIRequestEventDispatchMediator):
(WebCore::UIRequestEventDispatchMediator::event):
(WebCore::UIRequestEventDispatchMediator::dispatchEvent):
* Modules/indieui/UIRequestEvent.h: Added.
(WebCore::UIRequestEvent::receiver):
(WebCore::UIRequestEventDispatchMediator::create):
* Modules/indieui/UIRequestEvent.idl: Added.
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityNodeObject.h:
* dom/Element.cpp:
(WebCore::Element::setUIActions):
(WebCore::Element::UIActions):
* dom/Element.h:
* dom/Element.idl:
* dom/Event.cpp:
(WebCore::EventInit::EventInit):
* dom/Event.h:
* dom/EventNames.in:
* dom/Node.cpp:
(WebCore::Node::dispatchUIRequestEvent):
* dom/Node.h:
* dom/UIEvent.cpp:
(WebCore::UIEventInit::UIEventInit):
* dom/UIEvent.h:
* html/HTMLAttributeNames.in:

LayoutTests:

* fast/js/dom-static-property-for-in-iteration-expected.txt:
* fast/js/global-constructors-attributes-expected.txt:
* indieui: Added.
* indieui/create-uirequestevent-expected.txt: Added.
* indieui/create-uirequestevent.html: Added.
* indieui/uiactions-expected.txt: Added.
* indieui/uiactions.html: Added.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/qt/TestExpectations:
* platform/qt/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
* platform/win/TestExpectations:
* platform/win/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Migrate WebKitWebResource to GTask
carlosgc@webkit.org [Fri, 21 Jun 2013 08:07:10 +0000 (08:07 +0000)]
[GTK] Migrate WebKitWebResource to GTask
https://bugs.webkit.org/show_bug.cgi?id=117152

Reviewed by Gustavo Noronha Silva.

* UIProcess/API/gtk/WebKitWebResource.cpp:
(resourceDataCallback):
(webkit_web_resource_get_data):
(webkit_web_resource_get_data_finish):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Looping for EINTR on close() is incorrect for Linux, at least
commit-queue@webkit.org [Fri, 21 Jun 2013 06:02:58 +0000 (06:02 +0000)]
[WK2] Looping for EINTR on close() is incorrect for Linux, at least
https://bugs.webkit.org/show_bug.cgi?id=117266

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-06-20
Reviewed by Darin Adler.

Source/WebKit2:

Call closeWithRetry() to work around a difference in how the retry needs to
be done on Linux.

* Platform/CoreIPC/unix/AttachmentUnix.cpp:
(CoreIPC::Attachment::dispose):
* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate):
* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::create):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::SharedMemory::createHandle):
* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::createWebProcessConnection):
* SharedWorkerProcess/SharedWorkerProcess.cpp:
(WebKit::SharedWorkerProcess::createWebProcessConnection):
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess): All these places had
``close-followed-by-EINTR-handling'' replaced with the new closeWithRetry()
function added in this commit.

Source/WTF:

Added file UniStdExtras with a closeWithRetry() function that works around
the EINTR behavior on Linux during a close() call: it closes the descriptor
unconditionally even when the call is interrupted.

* wtf/UniStdExtras.h: Added.
(WTF::closeWithRetry): Wrapper around POSIX close() that handles EINTR
correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r151808): fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html...
rniwa@webkit.org [Fri, 21 Jun 2013 04:00:50 +0000 (04:00 +0000)]
REGRESSION(r151808): fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html fails
https://bugs.webkit.org/show_bug.cgi?id=117862

Add a failing test expectation.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r145788): mouse drag on canvas shouldn't start selection
rniwa@webkit.org [Fri, 21 Jun 2013 03:52:46 +0000 (03:52 +0000)]
REGRESSION(r145788): mouse drag on canvas shouldn't start selection
https://bugs.webkit.org/show_bug.cgi?id=117860

Reviewed by Benjamin Poulain.

Source/WebCore:

Like HTMLImageElement, HTMLCanvasElement shouldn't start selection.

Also uninline some virtual function overrides.

Test: fast/events/mosuedrag-on-canvas-should-not-start-selection.html

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::areAuthorShadowsAllowed):
(WebCore::HTMLCanvasElement::canContainRangeEndPoint):
(WebCore::HTMLCanvasElement::canStartSelection):
* html/HTMLCanvasElement.h:

LayoutTests:

Add a regression test for dragging mouse inside a canvas.
The canvas should not be selected and mouseup event should fire.

* fast/events/mosuedrag-on-canvas-should-not-start-selection-expected.txt: Added.
* fast/events/mosuedrag-on-canvas-should-not-start-selection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r149652): accessing items in .children via id doesn't work when element...
rniwa@webkit.org [Fri, 21 Jun 2013 03:50:47 +0000 (03:50 +0000)]
REGRESSION(r149652): accessing items in .children via id doesn't work when element is not rooted in DOM tree
https://bugs.webkit.org/show_bug.cgi?id=117836

Reviewed by Benjamin Poulain.

Source/WebCore:

When the root node of a HTML collection is not in the document or in a shadow tree,
we shouldn't use its tree scope's id and name maps to find name getters.

Always use the slow path in such cases.

Test: fast/dom/htmlallcollection-detached-node-children.html

* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::namedItem):

LayoutTests:

Add a regression test for named getter for a detached element.

* fast/dom/htmlallcollection-detached-node-children-expected.txt: Added.
* fast/dom/htmlallcollection-detached-node-children.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRefine the StackBounds computation for Windows.
mark.lam@apple.com [Fri, 21 Jun 2013 02:49:26 +0000 (02:49 +0000)]
Refine the StackBounds computation for Windows.
https://bugs.webkit.org/show_bug.cgi?id=117854.

Reviewed by Brent Fulgham.

* wtf/StackBounds.cpp:
(WTF::StackBounds::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CMAKE][EFL] Enable DOM4 Events Constructor
ryuan.choi@samsung.com [Fri, 21 Jun 2013 02:26:38 +0000 (02:26 +0000)]
[CMAKE][EFL] Enable DOM4 Events Constructor
https://bugs.webkit.org/show_bug.cgi?id=117858

Reviewed by Laszlo Gombos.

.:

* Source/cmake/OptionsEfl.cmake: Enabled ENABLE_DOM4_EVENTS_CONSTRUCTOR.
* Source/cmake/WebKitFeatures.cmake: Added ENABLE_DOM4_EVENTS_CONSTRUCTOR.
* Source/cmakeconfig.h.cmake: Ditto.

Tools:

* Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.

LayoutTests:

* platform/efl/TestExpectations: Unskip the related tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago https://bugs.webkit.org/show_bug.cgi?id=116495
ap@apple.com [Fri, 21 Jun 2013 00:44:38 +0000 (00:44 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=116495
        Fix null-pointer deref in DocumentLoader::responseReceived()

        Patch by Nate Chapin, reviewed by Mike West and myself.

        Test: http/tests/security/XFrameOptions/x-frame-options-deny-delete-frame-in-load-event.html

        * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::responseReceived): Added
        a null check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Roll out part of r150618.
roger_fong@apple.com [Thu, 20 Jun 2013 23:43:04 +0000 (23:43 +0000)]
Unreviewed. Roll out part of r150618.

* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Undoing r150621 to roll r150600 back in as the jsc test
mark.lam@apple.com [Thu, 20 Jun 2013 23:36:28 +0000 (23:36 +0000)]
[Windows] Undoing r150621 to roll r150600 back in as the jsc test
failures have been fixed in r151808.
https://bugs.webkit.org/show_bug.cgi?id=116661.

Reviewed by Brent Fulgham.

* wtf/StackBounds.cpp:
(WTF::StackBounds::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Send the correct offsets for misspelled words.
commit-queue@webkit.org [Thu, 20 Jun 2013 22:52:37 +0000 (22:52 +0000)]
[BlackBerry] Send the correct offsets for misspelled words.
https://bugs.webkit.org/show_bug.cgi?id=117846

JIRA116916.
When the caret is placed after a word, the offsets were calculated around
the proceeding space. As such, words that end a sentence worked correctly, but
midsentence words did not. The 'startOfWord' was calculated for the space ahead
and not for the word before it. Now finding the start of the word correctly and
calculating the end from there.

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-06-20
Reviewed by Rob Buis.

Internally reviewed by Genevieve Mak.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange stack capacity requirement to be more reasonable.
mark.lam@apple.com [Thu, 20 Jun 2013 22:17:27 +0000 (22:17 +0000)]
Change stack capacity requirement to be more reasonable.
https://bugs.webkit.org/show_bug.cgi?id=117801.

Reviewed by Geoffrey Garen.

Previously, the requiredStack in StackPolicy::StackPolicy() was set to
to a high value like 256K to reduce the chances of encountering an
undetected stack overflow in a scenario where we have a combination of
deeply nested divs and a large amount recursive re-entries into the VM.

However, this high value of requiredStack still does not completely
ensure that we will never encounter an undetected stack overflow. It
only lessens the probability of encountering it.

Secondly, on some platforms, the total stack size can be less than 256K
to start with. Hence, this high value requiredStack renders the VM
unuseable on those platforms.

This patch will fix the requiredStack to be more reasonable based on
real world stack usage by the VM. We won't (and cannot) try to prevent
undetected stack overflows outside of JSC as well. External code that
do deep recursion (e.g. Documnet::updateLayout()) should do their own
stack checks.

From a previous experiment, we measured the following:

On a debug build on OSX:
1. Stack usage different between recursive calls to interpreter entry:
   7744 bytes
On a release build on OSX:
2. Stack usage difference between recursive calls to interpreter entry:
   6352 bytes

Using these as a guide, we'll pick the following values for the
StackPolicy:
   requiredStack: 32K
   errorModeRequiredStack: 16K

The requiredStack is chosen to be 4x the measured usage above. The
additional 3x is a conservative estimate to account for stack space
that may be needed by other native functions called while in the
interpreter.

The errorModeRequiredStack has to be less than the requiredStack or we
won't be able to reenter the interpreter to do error handling work when
an imminent stack overflow is detected. It is assumed that the error
handling code will only do minimal work to allocate an exception and its
stack trace, and not run any arbitrary JS code. As such, it is safe to
allow re-entry into the interpreter with only 2x the measured usage in
this case.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::StackPolicy::StackPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoInitial advance on the first glyph of the run is not correctly set for rtl text.
enrica@apple.com [Thu, 20 Jun 2013 22:15:34 +0000 (22:15 +0000)]
Initial advance on the first glyph of the run is not correctly set for rtl text.
https://bugs.webkit.org/show_bug.cgi?id=117839
<rdar://problem/13860717>

Reviewed by Sam Weinig.

Source/WebCore:

We need to set the initial advance to the glyphBuffer, using the
initial advance of the complex run that will be drawn first.
In order to choose the run correctly we must consider the text direction.

Test: fast/text/complex-first-glyph-with-initial-advance.html

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::advance):

LayoutTests:

* fast/text/complex-first-glyph-with-initial-advance-expected.html: Added.
* fast/text/complex-first-glyph-with-initial-advance.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFixed WebGL compile errors on Windows.
achristensen@apple.com [Thu, 20 Jun 2013 21:37:10 +0000 (21:37 +0000)]
Fixed WebGL compile errors on Windows.
https://bugs.webkit.org/show_bug.cgi?id=117805

Reviewed by Brent Fulgham.

* html/canvas/WebGLRenderingContext.cpp: Included CString.h.
Added PLATFORM(WIN) to existing lists of platform macros.
* platform/graphics/ANGLEWebKitBridge.h:
* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::ShaderSourceEntry::symbolMap):
* platform/graphics/OpenGLESShims.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFrameView needs to initialize paintsEntireContents on creation
simon.fraser@apple.com [Thu, 20 Jun 2013 21:28:20 +0000 (21:28 +0000)]
FrameView needs to initialize paintsEntireContents on creation
https://bugs.webkit.org/show_bug.cgi?id=117844

Source/WebCore:

Reviewed by Anders Carlsson.

In WebKit1, if the WebView is layer-backed, WebHTMLView gets a layer.
In this mode, FrameView::paintsEntireContents() is true. However,
we would only call setPaintsEntireContents(true) on the FrameView
when the view's layer-backed status changes. FrameView also needs
to fetch this state when it is initialized, because we may be creating
a new FrameView for an already layer-backed WebHTMLView.

* page/ChromeClient.h:
(WebCore::ChromeClient::shouldPaintEntireContents):
* page/FrameView.cpp:
(WebCore::FrameView::init):

Source/WebKit/mac:

Reviewed by Anders Carlsson.

In WebKit1, if the WebView is layer-backed, WebHTMLView gets a layer.
In this mode, FrameView::paintsEntireContents() is true. However,
we would only call setPaintsEntireContents(true) on the FrameView
when the view's layer-backed status changes. FrameView also needs
to fetch this state when it is initialized, because we may be creating
a new FrameView for an already layer-backed WebHTMLView.

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldPaintEntireContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSticky elements are missing or misplaced sometimes when reloading a page that scrolls...
simon.fraser@apple.com [Thu, 20 Jun 2013 21:28:15 +0000 (21:28 +0000)]
Sticky elements are missing or misplaced sometimes when reloading a page that scrolls to a named anchor
https://bugs.webkit.org/show_bug.cgi?id=117819

Reviewed by Anders Carlsson.

At the end of FrameView::performPostLayoutTasks() we call scrollToAnchor() which attempts
to restore the scroll position to a named anchor, even when the document has been
changed by layout. This ends up in a call to ScrollView::scrollTo(), which in turn
calls repaintFixedElementsAfterScrolling(). However, repaintFixedElementsAfterScrolling()
would bail if m_nestedLayoutCount != 0, so we never updated layer positions which
depend on scroll position (but which would not be updated by layout, since their
renderers are not marked for layout when scrolling happens).

We've solved this problem once before in updateFixedElementsAfterScrolling() which
checks for m_nestedLayoutCount <= 1, so that we do work on the outermost nested layout.
Apply that same fix to repaintFixedElementsAfterScrolling().

Very timing-dependent, so hard to make a test.

* page/FrameView.cpp:
(WebCore::FrameView::repaintFixedElementsAfterScrolling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r151463.
commit-queue@webkit.org [Thu, 20 Jun 2013 21:10:23 +0000 (21:10 +0000)]
Unreviewed, rolling out r151463.
http://trac.webkit.org/changeset/151463
https://bugs.webkit.org/show_bug.cgi?id=117850

"r151451 was rolled out" (Requested by rhogan on #webkit).

* platform/efl/fast/forms/button-positioned-expected.txt:
* platform/efl/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/efl/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
* platform/gtk/fast/forms/button-positioned-expected.txt:
* platform/gtk/fast/forms/input-appearance-preventDefault-expected.png:
* platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/gtk/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
* platform/win/fast/forms/onselect-textfield-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHashSet: reverse the order of the template arguments at alternate 'find', 'contains...
mikhail.pozdnyakov@intel.com [Thu, 20 Jun 2013 21:09:56 +0000 (21:09 +0000)]
HashSet: reverse the order of the template arguments at alternate 'find', 'contains' and 'add' methods
https://bugs.webkit.org/show_bug.cgi?id=117830

Reviewed by Anders Carlsson.

The order of the template arguments at HashSet alternate 'find', 'contains' and
'add' methods is reversed so that callers can just pass the translator
and let the compiler deduce input argument type.

Source/JavaScriptCore:

* runtime/Identifier.h:
(JSC::IdentifierTable::add):

Source/WebCore:

No new tests. No new functionality.

* dom/QualifiedName.cpp:
(WebCore::QualifiedName::QualifiedName):
* platform/graphics/cg/SubimageCacheWithTimer.cpp:
(WebCore::SubimageCacheWithTimer::getSubimage):
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::isSupportedAttribute):
* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::isSupportedAttribute):
* svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::isSupportedAttribute):
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::isSupportedAttribute):
* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::isSupportedAttribute):
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::isSupportedAttribute):
* svg/SVGComponentTransferFunctionElement.cpp:
(WebCore::SVGComponentTransferFunctionElement::isSupportedAttribute):
* svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::isSupportedAttribute):
* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::isSupportedAttribute):
* svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::isSupportedAttribute):
* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::isSupportedAttribute):
* svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::isSupportedAttribute):
* svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::isSupportedAttribute):
* svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute):
* svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::isSupportedAttribute):
* svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::isSupportedAttribute):
* svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::isSupportedAttribute):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::isSupportedAttribute):
* svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::isSupportedAttribute):
* svg/SVGFEMergeNodeElement.cpp:
(WebCore::SVGFEMergeNodeElement::isSupportedAttribute):
* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::isSupportedAttribute):
* svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::isSupportedAttribute):
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::isSupportedAttribute):
* svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::isSupportedAttribute):
* svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::isSupportedAttribute):
* svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::isSupportedAttribute):
(WebCore::SVGFilterElement::childShouldCreateRenderer):
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::isSupportedAttribute):
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::isSupportedAttribute):
* svg/SVGGElement.cpp:
(WebCore::SVGGElement::isSupportedAttribute):
* svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::isSupportedAttribute):
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::isSupportedAttribute):
* svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::isSupportedAttribute):
* svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::isSupportedAttribute):
* svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::isSupportedAttribute):
* svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::isSupportedAttribute):
* svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::isSupportedAttribute):
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::isSupportedAttribute):
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::isSupportedAttribute):
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::isSupportedAttribute):
* svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::isSupportedAttribute):
* svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::isSupportedAttribute):
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::isSupportedAttribute):
* svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::isSupportedAttribute):
* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::isSupportedAttribute):
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::isSupportedAttribute):
* svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::isSupportedAttribute):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::isSupportedAttribute):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::isSupportedAttribute):
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::isSupportedAttribute):
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::isSupportedAttribute):
* svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::isSupportedAttribute):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::isSupportedAttribute):
(WebCore::isDisallowedElement):
* svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::isSupportedAttribute):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::isSupportedAttribute):

Source/WTF:

* wtf/HashSet.h:
* wtf/text/AtomicString.cpp:
(WTF::addToStringTable):
(WTF::findString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r151451.
commit-queue@webkit.org [Thu, 20 Jun 2013 20:46:21 +0000 (20:46 +0000)]
Unreviewed, rolling out r151451.
http://trac.webkit.org/changeset/151451
https://bugs.webkit.org/show_bug.cgi?id=117848

"Broke quite a lot of sites" (Requested by rhogan on #webkit).

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::intrinsicSize):
* rendering/RenderButton.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::computeLogicalHeight):
* rendering/RenderListBox.h:
* rendering/RenderMenuList.h:
* rendering/RenderReplaced.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControl::computeLogicalHeight):
* rendering/RenderTextControl.h:

LayoutTests:

* fast/forms/onselect-textfield-expected.txt:
* fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Removed.
* fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
* fast/replaced/width-and-height-of-positioned-replaced-elements.html: Removed.
* platform/mac-wk2/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
* platform/mac/fast/forms/button-positioned-expected.txt:
* platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
* platform/qt/fast/forms/button-positioned-expected.txt:
* platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r151788.
commit-queue@webkit.org [Thu, 20 Jun 2013 20:37:15 +0000 (20:37 +0000)]
Unreviewed, rolling out r151788.
http://trac.webkit.org/changeset/151788
https://bugs.webkit.org/show_bug.cgi?id=117847

"This is the wrong fix" (Requested by rhogan on #webkit).

Source/WebCore:

* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::computePreferredLogicalWidths):

LayoutTests:

* fast/forms/onselect-textfield-expected.txt:
* fast/replaced/height-of-positioned-text-control-expected.html: Removed.
* fast/replaced/height-of-positioned-text-control.html: Removed.
* fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
* platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
* platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png:
* platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
* platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Gstreamer] cleanup buffering and state updates
kbalazs@webkit.org [Thu, 20 Jun 2013 20:19:36 +0000 (20:19 +0000)]
[Gstreamer] cleanup buffering and state updates
https://bugs.webkit.org/show_bug.cgi?id=116642

Reviewed by Philippe Normand.

Source/WebCore:

Covered by existing media tests, especially the ones that have been unskipped.

Always do download buffering. It should not differ if preload is "none" because
it's about when to start buffering, not about how. Fix a bunch other subtle issues
to make this change go smoothly with the tests. As a bonus some tests that were
failing so far started to pass.
It is possible to further tweak the buffering in a way that will enable us to support
a different and appropriate behavior for preload="metadata" but it should be managed
a bit differently. I will implement it in a follow-up.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::load): Don't call setDownloadBuffering
yet. Now it also responsible for starting the fill timer and it turned out that
setting the download flag before the pipeline is set to a state has negative
effect on some tests. Most probably GStreamer starts buffering too early if
we set the download flag.
(WebCore::MediaPlayerPrivateGStreamer::commitLoad): Call setDownloadBuffering now.
(WebCore::MediaPlayerPrivateGStreamer::play): Ditto, plus set m_delayingLoad to false
because otherwise setPreload will wrongly assume that the load has not been committed
yet if prepareToPlay is not called before play.
(WebCore::MediaPlayerPrivateGStreamer::pause): Make sure we don't commit a load here
if it was not committed yet by looking in the pipeline state.
(WebCore::MediaPlayerPrivateGStreamer::processBufferingStats): No need to observe the
type of buffering.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): Introduced m_downloadFinished to update
ready and network states in updateStates based on it. The previously used condition
- (maxTimeLoaded() == duration()) - was not correct in the case when duration is not known.
(WebCore::MediaPlayerPrivateGStreamer::maxTimeLoaded): Removed a lie. If the fill timer is not active
it does not necesarily means that download has been finished. This lie was actually ensuring
a lot of tests to pass because it made the condition (maxTimeLoaded() == duration()) true.
Now that state updates has been cleaned up we don't need to lie.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Merge all the parts that takes part in updating
ready and network states. It was untrackable. Unset download buffering for for live streams early so
we don't need to restart them.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer): Removed m_startedBuffering because there is no need for it now.

LayoutTests:

Remove failure expectations from tests that started to pass.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoASSERT removing then adding a <track> element
eric.carlson@apple.com [Thu, 20 Jun 2013 20:14:03 +0000 (20:14 +0000)]
ASSERT removing then adding a <track> element
https://bugs.webkit.org/show_bug.cgi?id=117814

Reviewed by Jer Noble.

Source/WebCore:

Test: media/track/add-and-remove-track.html

* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedInto): Always call ensureTrack before adding the track
    to the parent <video> element.
(WebCore::HTMLTrackElement::ensureTrack): Call m_track->setTrackElement() in case the
    parent was cleared after m_track was created.

* html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::setTrackElement): New, set m_trackElement.
* html/track/LoadableTextTrack.h:

LayoutTests:

* media/track/add-and-remove-track-expected.txt: Added.
* media/track/add-and-remove-track.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebProcess hangs loading eff.org (Waiting forever on a sync XHR, NetworkProcess unabl...
beidson@apple.com [Thu, 20 Jun 2013 20:12:35 +0000 (20:12 +0000)]
WebProcess hangs loading eff.org (Waiting forever on a sync XHR, NetworkProcess unable to service it).
<rdar://problem/14112329> and https://bugs.webkit.org/show_bug.cgi?id=117842

Reviewed by Alexey Proskuryakov.

* NetworkProcess/HostRecord.cpp:
(WebKit::removeLoaderFromQueue): Utility to clear a Loader out of a LoaderQueue.
(WebKit::HostRecord::removeLoader): Use removeLoaderFromQueue, and also try to clear the loader from m_syncLoadersPending.
(WebKit::HostRecord::servePendingRequestsForQueue): Small refactoring/cleanup.
(WebKit::HostRecord::limitsRequests): Change so that if the number of loaders in flight is exactly equal to the limit, then
  allow serving a synchronous loader to go exactly one beyond the limit.
* NetworkProcess/HostRecord.h:

Make the static maxRequestsInFlightPerHost a member of the NetworkResourceLoadScheduler, instead:
* NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::NetworkResourceLoadScheduler):
(WebKit::NetworkResourceLoadScheduler::hostForURL):
* NetworkProcess/NetworkResourceLoadScheduler.h:

* NetworkProcess/mac/NetworkResourceLoadSchedulerMac.mm:
(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost): Tell CFNetwork to allow
  7 connections per host instead of 6, but tell the scheduler that 6 is still the normal limit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Build fix for Apple Windows port.
roger_fong@apple.com [Thu, 20 Jun 2013 20:12:28 +0000 (20:12 +0000)]
Unreviewed. Build fix for Apple Windows port.

* rendering/RenderThemeWin.cpp:
(WebCore::cssValueIdToSysColorIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago [Mac] Downloaded file name encoding is incorrect when download link opens...
ap@apple.com [Thu, 20 Jun 2013 20:06:02 +0000 (20:06 +0000)]
    [Mac] Downloaded file name encoding is incorrect when download link opens in a new window
        https://bugs.webkit.org/show_bug.cgi?id=117818
        <rdar://problem/14212635>

        Reviewed by Brady Eidson.

        No tests added. The machinery we have for logging downloaded file name is very
        far from being able to work in a secondary window.

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
        Made a targeted fix - don't update encoding fallback array if we already have one,
        there is no chance for it to be more correct. In this case, it's incorrect because
        it comes from a new blank window, instead of original referer.
        We have a lot of code in addExtraFieldsToRequest() to struggle with this, and we have
        a FIXME to try not calling it from policy delegate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoVersioning.
lforschler@apple.com [Thu, 20 Jun 2013 19:44:39 +0000 (19:44 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] remove bashism from configure
zandobersek@gmail.com [Thu, 20 Jun 2013 19:32:36 +0000 (19:32 +0000)]
[GTK] remove bashism from configure
https://bugs.webkit.org/show_bug.cgi?id=117796

Reviewed by Gustavo Noronha Silva.

* Source/autotools/FindDependencies.m4: Perform string appending by redeclaring the base string to the value
of the base string followed by the string that's being appended. This replaces the use of the '+=' operator
that works under bash but is not supported by other shells.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMark compositing/repaint/positioned-movement.html as flaky on Mountain Lion Debug
benjamin@webkit.org [Thu, 20 Jun 2013 19:16:31 +0000 (19:16 +0000)]
Mark compositing/repaint/positioned-movement.html as flaky on Mountain Lion Debug

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-20

* platform/mac-wk2/TestExpectations:
The test fails regularly in Debug on Mountain Lion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][WK2] REGRESSION(r151737): fast/replaced/width100percent-image.html fails
robert@webkit.org [Thu, 20 Jun 2013 19:10:08 +0000 (19:10 +0000)]
[Qt][WK2] REGRESSION(r151737): fast/replaced/width100percent-image.html fails
https://bugs.webkit.org/show_bug.cgi?id=117824

Unreviewed, rebaselining.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png:
* platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r151451): Text not vertically centered correctly on icloud.com
robert@webkit.org [Thu, 20 Jun 2013 18:58:42 +0000 (18:58 +0000)]
REGRESSION (r151451): Text not vertically centered correctly on icloud.com
https://bugs.webkit.org/show_bug.cgi?id=117744

Reviewed by David Hyatt.

Source/WebCore:

The positioned height and width computation adds in the element's border and padding so
don't add it to the intrinsic height and preferred widths of text controls that are
absolutely positioned.

Test: fast/replaced/height-of-positioned-text-control.html

* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::computePreferredLogicalWidths):

LayoutTests:

* fast/forms/onselect-textfield-expected.txt:
* fast/replaced/height-of-positioned-text-control-expected.html: Added.
* fast/replaced/height-of-positioned-text-control.html: Added.
* fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
* platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
* platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
* platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
* platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake Windows makefile copy build output to a different folder.
roger_fong@apple.com [Thu, 20 Jun 2013 18:55:36 +0000 (18:55 +0000)]
Make Windows makefile copy build output to a different folder.
<rdar://problem/14219184>.

* WTF.vcxproj/WTF.make:
* JavaScriptCore.vcxproj/JavaScriptCore.make:
* WebCore.vcxproj/WebCore.make:
* WebKit.vcxproj/WebKit.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImproper deallocation of JSManagedValue causes crashes during autorelease pool draining
mhahnenberg@apple.com [Thu, 20 Jun 2013 18:36:27 +0000 (18:36 +0000)]
Improper deallocation of JSManagedValue causes crashes during autorelease pool draining
https://bugs.webkit.org/show_bug.cgi?id=117840

Reviewed by Geoffrey Garen.

Improperly managing a JSManagedValue can cause a crash when the JSC::Weak inside the
JSManagedValue is destroyed upon deallocation. We would rather have improperly maintained
JSManagedValues cause memory leaks than take down the whole app.

The fix is to use the callback to the JSC::Weak on the destruction of the VM so that we
can safely null it out. This will prevent ~Weak from crashing.

* API/JSManagedValue.mm:
(-[JSManagedValue JSC::JSC::]):
(JSManagedValueHandleOwner::finalize):
* API/tests/testapi.mm: Added a test that crashed prior to this fix due to a leaked
managed reference. Also fixed a small style nit I noticed in another test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRoll-on in-band captions are displayed bottom-to-top rather than top-to-bottom.
jer.noble@apple.com [Thu, 20 Jun 2013 18:24:08 +0000 (18:24 +0000)]
Roll-on in-band captions are displayed bottom-to-top rather than top-to-bottom.
https://bugs.webkit.org/show_bug.cgi?id=117811

Reviewed by Eric Carlson.

When comparing Generic cues, we should check that their type is Generic, not WebVTT.

* html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::isOrderedBefore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CMake][CSS Shaders] Add WebCore files for CSS Shaders to CMakeLists.txt
commit-queue@webkit.org [Thu, 20 Jun 2013 18:07:48 +0000 (18:07 +0000)]
[CMake][CSS Shaders] Add WebCore files for CSS Shaders to CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=117711

Patch by Ralph Thomas <ralpht@gmail.com> on 2013-06-20
Reviewed by Laszlo Gombos.

No new tests, no CMake platforms currently enable this functionality.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCleanup usage of CSSPropertyID and CSSValueID inside WebKit.
alexis@webkit.org [Thu, 20 Jun 2013 18:04:52 +0000 (18:04 +0000)]
Cleanup usage of CSSPropertyID and CSSValueID inside WebKit.
https://bugs.webkit.org/show_bug.cgi?id=117829

Reviewed by Andreas Kling.

A lot of call sites were using integers to represent them. While it's
not incorrect per se, it's not ideal for various reason such as type
safety or to remove ambiguity.

This patch eradicate the wrong usage by not letting any integer based
API for getting CSSValueIDs or CSSPropertyIDs from CSSPrimitiveValues.

Instead we use new but typed functions to construct the values as well
as getting them. Two customs and internal types were added to CSSPrimitiveValue
to handle correctly the new APIs.

It's good to note that in order to preserve compatibility on the
CSSPrimitiveValue type whenever CSSPrimitiveValue handles a CSSValueID
or a CSSPropertyID the return type for the public API will be CSS_IDENT
despite it is a separate internal type.

No new tests: refactor, existing tests should cover.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyMatches):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
* css/CSSGradientValue.cpp:
(WebCore::positionFromValue):
(WebCore::CSSLinearGradientValue::customCssText):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::customCssText):
(WebCore::CSSRadialGradientValue::createGradient):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseSystemColor):
(WebCore::isFillPositionKeyword):
(WebCore::CSSParser::parse4ValuesFillPosition):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::isBlendMode):
(WebCore::CSSParser::isCompositeOperator):
* css/CSSParser.h:
* css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::propertyName):
(WebCore::valueName):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isValueID):
(WebCore::CSSPrimitiveValue::createIdentifier):
(WebCore::CSSPrimitiveValue::createParserOperator):
(WebCore::CSSPrimitiveValue::getPropertyID):
(WebCore::CSSPrimitiveValue::getValueID):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator CSSReflectionDirection):
(WebCore::CSSPrimitiveValue::operator ColumnSpan):
(WebCore::CSSPrimitiveValue::operator PrintColorAdjust):
(WebCore::CSSPrimitiveValue::operator EBorderStyle):
(WebCore::CSSPrimitiveValue::operator OutlineIsAuto):
(WebCore::CSSPrimitiveValue::operator CompositeOperator):
(WebCore::CSSPrimitiveValue::operator ControlPart):
(WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
(WebCore::CSSPrimitiveValue::operator EFillAttachment):
(WebCore::CSSPrimitiveValue::operator EFillBox):
(WebCore::CSSPrimitiveValue::operator EFillRepeat):
(WebCore::CSSPrimitiveValue::operator EBoxPack):
(WebCore::CSSPrimitiveValue::operator EBoxAlignment):
(WebCore::CSSPrimitiveValue::operator EBoxDecorationBreak):
(WebCore::CSSPrimitiveValue::operator BackgroundEdgeOrigin):
(WebCore::CSSPrimitiveValue::operator EBoxSizing):
(WebCore::CSSPrimitiveValue::operator EBoxDirection):
(WebCore::CSSPrimitiveValue::operator EBoxLines):
(WebCore::CSSPrimitiveValue::operator EBoxOrient):
(WebCore::CSSPrimitiveValue::operator ECaptionSide):
(WebCore::CSSPrimitiveValue::operator EClear):
(WebCore::CSSPrimitiveValue::operator ECursor):
(WebCore::CSSPrimitiveValue::operator CursorVisibility):
(WebCore::CSSPrimitiveValue::operator EDisplay):
(WebCore::CSSPrimitiveValue::operator EEmptyCell):
(WebCore::CSSPrimitiveValue::operator EAlignItems):
(WebCore::CSSPrimitiveValue::operator EJustifyContent):
(WebCore::CSSPrimitiveValue::operator EFlexDirection):
(WebCore::CSSPrimitiveValue::operator EAlignContent):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):
(WebCore::CSSPrimitiveValue::operator EFloat):
(WebCore::CSSPrimitiveValue::operator LineBreak):
(WebCore::CSSPrimitiveValue::operator EListStylePosition):
(WebCore::CSSPrimitiveValue::operator EListStyleType):
(WebCore::CSSPrimitiveValue::operator EMarginCollapse):
(WebCore::CSSPrimitiveValue::operator EMarqueeBehavior):
(WebCore::CSSPrimitiveValue::operator RegionFragment):
(WebCore::CSSPrimitiveValue::operator EMarqueeDirection):
(WebCore::CSSPrimitiveValue::operator ENBSPMode):
(WebCore::CSSPrimitiveValue::operator EOverflow):
(WebCore::CSSPrimitiveValue::operator EPageBreak):
(WebCore::CSSPrimitiveValue::operator EPosition):
(WebCore::CSSPrimitiveValue::operator EResize):
(WebCore::CSSPrimitiveValue::operator ETableLayout):
(WebCore::CSSPrimitiveValue::operator ETextAlign):
(WebCore::CSSPrimitiveValue::operator TextAlignLast):
(WebCore::CSSPrimitiveValue::operator TextJustify):
(WebCore::CSSPrimitiveValue::operator TextDecoration):
(WebCore::CSSPrimitiveValue::operator TextDecorationStyle):
(WebCore::CSSPrimitiveValue::operator TextUnderlinePosition):
(WebCore::CSSPrimitiveValue::operator ETextSecurity):
(WebCore::CSSPrimitiveValue::operator ETextTransform):
(WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
(WebCore::CSSPrimitiveValue::operator EUserDrag):
(WebCore::CSSPrimitiveValue::operator EUserModify):
(WebCore::CSSPrimitiveValue::operator EUserSelect):
(WebCore::CSSPrimitiveValue::operator EVerticalAlign):
(WebCore::CSSPrimitiveValue::operator EVisibility):
(WebCore::CSSPrimitiveValue::operator EWhiteSpace):
(WebCore::CSSPrimitiveValue::operator EWordBreak):
(WebCore::CSSPrimitiveValue::operator EOverflowWrap):
(WebCore::CSSPrimitiveValue::operator TextDirection):
(WebCore::CSSPrimitiveValue::operator WritingMode):
(WebCore::CSSPrimitiveValue::operator TextCombine):
(WebCore::CSSPrimitiveValue::operator RubyPosition):
(WebCore::CSSPrimitiveValue::operator TextEmphasisPosition):
(WebCore::CSSPrimitiveValue::operator TextOverflow):
(WebCore::CSSPrimitiveValue::operator TextEmphasisFill):
(WebCore::CSSPrimitiveValue::operator TextEmphasisMark):
(WebCore::CSSPrimitiveValue::operator TextOrientation):
(WebCore::CSSPrimitiveValue::operator EPointerEvents):
(WebCore::CSSPrimitiveValue::operator FontDescription::Kerning):
(WebCore::CSSPrimitiveValue::operator FontSmoothingMode):
(WebCore::CSSPrimitiveValue::operator FontWeight):
(WebCore::CSSPrimitiveValue::operator FontItalic):
(WebCore::CSSPrimitiveValue::operator FontSmallCaps):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode):
(WebCore::CSSPrimitiveValue::operator ColorSpace):
(WebCore::CSSPrimitiveValue::operator Hyphens):
(WebCore::CSSPrimitiveValue::operator LineSnap):
(WebCore::CSSPrimitiveValue::operator LineAlign):
(WebCore::CSSPrimitiveValue::operator Order):
(WebCore::CSSPrimitiveValue::operator ESpeak):
(WebCore::CSSPrimitiveValue::operator BlendMode):
(WebCore::CSSPrimitiveValue::operator LineCap):
(WebCore::CSSPrimitiveValue::operator LineJoin):
(WebCore::CSSPrimitiveValue::operator WindRule):
(WebCore::CSSPrimitiveValue::operator EAlignmentBaseline):
(WebCore::CSSPrimitiveValue::operator EBorderCollapse):
(WebCore::CSSPrimitiveValue::operator EBorderFit):
(WebCore::CSSPrimitiveValue::operator EImageRendering):
(WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
(WebCore::CSSPrimitiveValue::operator ColumnAxis):
(WebCore::CSSPrimitiveValue::operator ColumnProgression):
(WebCore::CSSPrimitiveValue::operator WrapFlow):
(WebCore::CSSPrimitiveValue::operator WrapThrough):
(WebCore::CSSPrimitiveValue::operator GridAutoFlow):
(WebCore::CSSPrimitiveValue::convertToLength):
(WebCore::CSSPrimitiveValue::operator EBufferedRendering):
(WebCore::CSSPrimitiveValue::operator EColorInterpolation):
(WebCore::CSSPrimitiveValue::operator EColorRendering):
(WebCore::CSSPrimitiveValue::operator EDominantBaseline):
(WebCore::CSSPrimitiveValue::operator EShapeRendering):
(WebCore::CSSPrimitiveValue::operator ETextAnchor):
(WebCore::CSSPrimitiveValue::operator SVGWritingMode):
(WebCore::CSSPrimitiveValue::operator EVectorEffect):
(WebCore::CSSPrimitiveValue::operator EMaskType):
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):
* css/Counter.h:
(WebCore::Counter::listStyleIdent):
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::getPageSizeFromName):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
* css/MediaQueryEvaluator.cpp:
(WebCore::orientationMediaFeatureEval):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
* css/StyleResolver.cpp:
(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
(WebCore::colorForCSSValue):
(WebCore::StyleResolver::colorFromPrimitiveValueIsDerivedFromElement):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
* css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::getViewportArgumentValue):
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
* editing/ApplyStyleCommand.cpp:
(WebCore::toIdentifier):
* editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::create):
(WebCore::HTMLElementEquivalent::HTMLElementEquivalent):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::HTMLTextDecorationEquivalent::create):
(WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::fontWeightIsBold):
(WebCore::legacyFontSizeFromCSSValue):
(WebCore::isTransparentColorValue):
* editing/EditingStyle.h:
* editing/markup.cpp:
(WebCore::propertyMissingOrEqualToNone):
* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::systemFont):
* platform/blackberry/RenderThemeBlackBerry.h:
(WebCore::RenderThemeBlackBerry::systemFont):
* platform/blackberry/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::systemFont):
* platform/blackberry/RenderThemeEfl.h:
(WebCore::RenderThemeEfl::systemFont):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::systemFont):
* platform/gtk/RenderThemeGtk.h:
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::systemColor):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::systemColor):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::systemFont):
(WebCore::RenderThemeQt::systemColor):
* platform/qt/RenderThemeQt.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::systemColor):
* rendering/RenderTheme.h:
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemFont):
(WebCore::RenderThemeMac::systemColor):
* rendering/RenderThemeSafari.h:
(WebCore::RenderThemeSafari::systemFont):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::systemFont):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::systemFont):
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWin::systemColor):
* rendering/RenderThemeWin.h:
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::systemFont):
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWinCE::systemColor):
* rendering/RenderThemeWinCE.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
commit-queue@webkit.org [Thu, 20 Jun 2013 17:14:32 +0000 (17:14 +0000)]
[BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
https://bugs.webkit.org/show_bug.cgi?id=117827

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-06-20
Reviewed by Rob Buis.

Source/WebKit/blackberry:

Add DumpRenderTreeClient::willSendRequestForFrame() to handle
dispatchWillSendRequest() in DRT.

Fixes tests
fast/loader/onload-willSendRequest-null-for-script.html and
fast/loader/willSendRequest-null-for-preload.html.

* Api/DumpRenderTreeClient.h:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):

Tools:

Reset the passed in request if willSendRequestReturnsNull() is
true or willSendRequestReturnsNullOnRedirect() is true and it's a
redirection.

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
* DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCommit queue shouldn't reopen unrelated bugs because of flakiness
ossy@webkit.org [Thu, 20 Jun 2013 16:59:54 +0000 (16:59 +0000)]
Commit queue shouldn't reopen unrelated bugs because of flakiness
https://bugs.webkit.org/show_bug.cgi?id=117503

Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/tool/bot/flakytestreporter.py:
(_follow_duplicate_chain):
(_update_bug_for_flaky_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151779 268f45cc-cd09-0410-ab3c-d52691b4dbfc