WebKit-https.git
7 years agoTest rebaselines after http://trac.webkit.org/changeset/128517.
ojan@chromium.org [Fri, 14 Sep 2012 01:37:29 +0000 (01:37 +0000)]
Test rebaselines after trac.webkit.org/changeset/128517.

* fast/table/height-percent-test-expected.txt:
* platform/chromium-mac-snowleopard/fast/table/height-percent-test-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/core/cell_heights-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac/fast/table/height-percent-test-expected.png:
* platform/chromium-mac/tables/mozilla/core/cell_heights-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/chromium-win/fast/table/height-percent-test-expected.png:
* platform/chromium-win/tables/mozilla/core/cell_heights-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/fast/table/height-percent-test-expected.txt: Removed.
* platform/gtk/TestExpectations:
* platform/gtk/fast/table/height-percent-test-expected.txt: Removed.
* platform/gtk/tables/mozilla/core/cell_heights-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug19526-expected.txt: Removed.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/mac/TestExpectations:
* platform/mac/tables/mozilla/core/cell_heights-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug19526-expected.txt:
* platform/qt/TestExpectations:
* platform/qt/fast/table/height-percent-test-expected.txt: Renamed from LayoutTests/platform/mac/fast/table/height-percent-test-expected.txt.
* platform/qt/tables/mozilla/core/cell_heights-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug19526-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/win-future/fast/table/height-percent-test-expected.txt: Copied from LayoutTests/fast/table/height-percent-test-expected.txt.
* tables/mozilla_expected_failures/bugs/bug19526-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug19526-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/12255720> Fix the build with newer Clang
mrowe@apple.com [Fri, 14 Sep 2012 01:35:46 +0000 (01:35 +0000)]
<rdar://problem/12255720> Fix the build with newer Clang

Reviewed by Sam Weinig.

Clang generates a warning about the inclusion of trailing commas on the final enum item as it's apparently
a C++11 extension. Remove them.

* src/compiler/BaseTypes.h:
* src/compiler/ExtensionBehavior.h:
* src/compiler/ParseHelper.cpp:
(TParseContext::parseVectorFields):
* src/compiler/intermediate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline fast/css/percentage-height-auto-sized-body-quirks.html after
ojan@chromium.org [Fri, 14 Sep 2012 01:30:06 +0000 (01:30 +0000)]
Rebaseline fast/css/percentage-height-auto-sized-body-quirks.html after
http://trac.webkit.org/changeset/128517. The results are now consistent
across platforms.

* platform/efl/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.
* platform/gtk/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.
* platform/mac/TestExpectations:
* platform/qt/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Implement missing initializeLogChannel function
commit-queue@webkit.org [Fri, 14 Sep 2012 01:15:39 +0000 (01:15 +0000)]
[EFL][WK2] Implement missing initializeLogChannel function
https://bugs.webkit.org/show_bug.cgi?id=96478

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-09-13
Reviewed by Gyuyoung Kim.

Implemented log channel initialization function for EFL platform in WebKit2.

* Platform/Logging.cpp:
(WebKit):
* Platform/Logging.h:
(WebKit):
* Platform/efl/LoggingEfl.cpp: Added.
(WebKit):
(WebKit::initializeLogChannel): Channel is initialized if its name is found in WEBKIT_DEBUG.
* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd gender-neutral form of webkit-patch land-cowboy
pdr@google.com [Fri, 14 Sep 2012 00:52:47 +0000 (00:52 +0000)]
Add gender-neutral form of webkit-patch land-cowboy
https://bugs.webkit.org/show_bug.cgi?id=96709

Reviewed by Adam Barth.

Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.

* Scripts/webkitpy/tool/commands/download.py:
(LandCowhand):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Remove some parameters in browserCreate()
commit-queue@webkit.org [Fri, 14 Sep 2012 00:43:19 +0000 (00:43 +0000)]
[EFL] Remove some parameters in browserCreate()
https://bugs.webkit.org/show_bug.cgi?id=96499

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
And I have moved some parameters into User_Arguments.

* EWebLauncher/main.c:
(_User_Arguments):
(_ELauncher):
(on_key_down):
(browserCreate):
(findThemePath):
(parseUserArguments):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake global const initialisation explicit in the bytecode
oliver@apple.com [Fri, 14 Sep 2012 00:43:04 +0000 (00:43 +0000)]
Make global const initialisation explicit in the bytecode
https://bugs.webkit.org/show_bug.cgi?id=96711

Reviewed by Gavin Barraclough.

Added op_init_global_const to make initialisation of global const
fields explicit.  This will help us keep correct semantics in the
upcoming variable resolution refactoring.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitInitGlobalConst):
(JSC):
* bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
* bytecompiler/NodesCodegen.cpp:
(JSC::ConstDeclNode::emitCodeSingle):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Consolidate two-phase connection to avoid race conditions
jsbell@chromium.org [Fri, 14 Sep 2012 00:28:38 +0000 (00:28 +0000)]
IndexedDB: Consolidate two-phase connection to avoid race conditions
https://bugs.webkit.org/show_bug.cgi?id=90411

Reviewed by Tony Chang.

Source/WebCore:

Previously, IDB connections were opened by having the front-end (1) call through to
a back-end open() method, eventually receive a success message with a back-end object
handle, and (2) call into the back-end object to register front-end callbacks. This left
the back-end's notion of an open connection in a limbo state between these two calls.
In multi-process ports, a crash of the front-end process could leave the back-end wedged
waiting for this second call (e.g. can't delete until all connections are closed).

Simplify this by having the front-end pass through the callbacks into the back-end
during the initial open() call, which eliminates the limbo state.

No new tests - no functional changes. Chromium port's webkit_unit_tests updated.

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::create):
(WebCore::IDBDatabase::IDBDatabase): Db-callbacks is available at creation time.
(WebCore::IDBDatabase::~IDBDatabase):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create): Need to track db-callbacks as well.
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::databaseCallbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(IDBDatabaseBackendImpl::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create): Ditto.
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::databaseCallbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::PendingOpenWithVersionCall):
(IDBDatabaseBackendImpl::PendingOpenWithVersionCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::connectionCount): Don't need to count limbo connections any more.
(WebCore::IDBDatabaseBackendImpl::processPendingCalls): Pass through db-callbacks.
(WebCore::IDBDatabaseBackendImpl::openConnection): No more limbo connections (yay!).
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction): Pass through db-callbacks.
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion): Ditto.
(WebCore::IDBDatabaseBackendImpl::deleteDatabase): Style.
(WebCore::IDBDatabaseBackendImpl::close): Resolve FIXME about connectionCount.
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:
(WebCore::IDBDatabaseCallbacksImpl::create):
(WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
(WebCore::IDBDatabaseCallbacksImpl::connect):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
(IDBDatabaseCallbacksImpl):
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open): Mint the db-callbacks here...
* Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open): ...passed through to here...
* Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl):
* Modules/indexeddb/IDBFactoryBackendInterface.h:
(IDBFactoryBackendInterface):
* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::create): ...all the way to here...
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded): ...and finally hooked up here.
(WebCore::IDBOpenDBRequest::onSuccess): (or here, if no upgrade needed).
* Modules/indexeddb/IDBOpenDBRequest.h:
(WebCore):
(IDBOpenDBRequest):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort): Tweak event/notification ordering; the
notifying the database that the transaction is finished may unblock closing,
which fires more events, and the delivery matters. Previously the close would
be blocked by the transaction which gave the desired order.
(WebCore::IDBTransaction::onComplete): Ditto.
* inspector/InspectorIndexedDBAgent.cpp: New hookup logic.
(WebCore):

Source/WebKit/chromium:

API plumbing for simplified single-phase connection opening, and tests updated
to exercise the new APIs.

* public/WebIDBDatabase.h:
(WebIDBDatabase): Just a FIXME to remove the old second-phase hookup API.
* public/WebIDBFactory.h:
(WebKit):
(WebIDBFactory):
(WebKit::WebIDBFactory::open): New overload that takes db-callbacks.
* src/IDBCallbacksProxy.cpp: The db-callbacks plumbing is needed earlier.
(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):
(WebKit):
(WebKit::IDBCallbacksProxy::setDatabaseCallbacks): Needs to hold on to
the db-callbacks and hook it up when the onSuccess callback comes through.
* src/IDBCallbacksProxy.h:
(WebKit):
(IDBCallbacksProxy):
* src/IDBDatabaseBackendProxy.cpp:
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::open):
* src/IDBFactoryBackendProxy.h:
(IDBFactoryBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
(WebKit::WebIDBDatabaseImpl::close):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::open):
* src/WebIDBFactoryImpl.h:
(WebIDBFactoryImpl):
* tests/IDBAbortOnCorruptTest.cpp:
(FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::create):
(WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks):
(WebCore):
(WebCore::TEST): Updated connection sequence.
* tests/IDBDatabaseBackendTest.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago https://bugs.webkit.org/show_bug.cgi?id=93654
ap@apple.com [Fri, 14 Sep 2012 00:26:16 +0000 (00:26 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=93654
        REGRESSION(r125126): It made fast/events/keyevent-iframe-removed-crash.html assert

        Unskipped tests that should not assert any more (there were more than the one in
        bug title). Re-attributed some remaining failures that were tracked together with that.

        * platform/gtk/TestExpectations:
        * platform/mac/Skipped:
        * platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agosuspend/resumeWidgetHierarchyUpdates should be a RAII object
rniwa@webkit.org [Fri, 14 Sep 2012 00:20:04 +0000 (00:20 +0000)]
suspend/resumeWidgetHierarchyUpdates should be a RAII object
https://bugs.webkit.org/show_bug.cgi?id=96706

Reviewed by Simon Fraser.

Source/WebCore:

Replaced suspendWidgetHierarchyUpdates and resumeWidgetHierarchyUpdates by WidgetHierarchyUpdatesSuspensionScope.

* WebCore.exp.in: Export new symbols.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::detach):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
* rendering/RenderWidget.cpp:
(WebCore):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::widgetNewParentMap):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
(WebCore::moveWidgetToParentSoon):
* rendering/RenderWidget.h:
(WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::~WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::isSuspended):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::scheduleWidgetToMove):
(WebCore):
(RenderWidget):

Source/WebKit/mac:

* WebView/WebHTMLView.mm:
(-[WebHTMLView _invalidateGStatesForTree]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove lines for fast/table/bad-replaced-sizing-preferred-logical-widths.html
ojan@chromium.org [Fri, 14 Sep 2012 00:11:47 +0000 (00:11 +0000)]
Remove lines for fast/table/bad-replaced-sizing-preferred-logical-widths.html
fixed in http://trac.webkit.org/changeset/128528.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLots of repaints in the top left tile on this site
simon.fraser@apple.com [Fri, 14 Sep 2012 00:02:51 +0000 (00:02 +0000)]
Lots of repaints in the top left tile on this site
https://bugs.webkit.org/show_bug.cgi?id=96698

Reviewed by Anders Carlsson.

When given a rect outside of the current tile coverage rect,
TileCache::setNeedsDisplayInRect() would try to invalidate the
top left tile. This would normally be a no-op, except when repaint
counters are visible, in which case it would invalidate the counter
area.

Fix by doing an early return if the intersection between the repaint
rect and the tile coverage rect is empty.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setNeedsDisplayInRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening for r128516/r128517:
jamesr@google.com [Thu, 13 Sep 2012 23:53:20 +0000 (23:53 +0000)]
Unreviewed gardening for r128516/r128517:
  remove the now-unnecessary cr-mac expectations for fast/writing-mode test.
  fix baseline for fast/table/bad-replaced-sizing-preferred-logical-widths.html

* platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/12283706> WebKit looks for some files on the system even when buildin...
mrowe@apple.com [Thu, 13 Sep 2012 23:48:50 +0000 (23:48 +0000)]
<rdar://problem/12283706> WebKit looks for some files on the system even when building against an SDK.

Reviewed by David Kilzer.

If an SDK is being used, pass it through to our custom invocations of the preprocessor.

Source/WebCore:

* DerivedSources.make:

Source/WebKit2:

* DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlatformGestureCurveTest compile fix pt 2
jamesr@google.com [Thu, 13 Sep 2012 23:29:55 +0000 (23:29 +0000)]
PlatformGestureCurveTest compile fix pt 2

* tests/PlatformGestureCurveTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Unreviewed build fix.
bfulgham@webkit.org [Thu, 13 Sep 2012 23:18:24 +0000 (23:18 +0000)]
[WinCairo] Unreviewed build fix.

* WebCookieManagerCurl.cpp: Remove unused 'using WebCore'
declaration that prevented the build from completing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: ASSERT(!eventDispatchForbidden()) fires when removed plugin re-insert...
tsepez@chromium.org [Thu, 13 Sep 2012 23:12:03 +0000 (23:12 +0000)]
Source/WebCore: ASSERT(!eventDispatchForbidden()) fires when removed plugin re-inserted as part of readyStateChange.
https://bugs.webkit.org/show_bug.cgi?id=93639

Reviewed by Ryosuke Niwa.

Removing a plugin causes a detach which can cancel the last remaining load on a page,
resulting in a readyStateChange event during a time when things are inconsisent. Defer
the detach which triggers this chain of events until after the node is fully removed
from the document's elementsById map.

Test: plugins/plugin-remove-readystatechange.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):

LayoutTests: ASSERT(!eventDispatchForbidden()) firest when removed plugin re-inserted as part of readyStateChange.
https://bugs.webkit.org/show_bug.cgi?id=93639

Reviewed by Ryosuke Niwa.

Add a new testcase to cover this issue.  Test passes if assert doesn't fire in debug builds.

* plugins/plugin-remove-readystatechange-expected.txt: Added.
* plugins/plugin-remove-readystatechange.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Unreviewed build fix for export declarations.
bfulgham@webkit.org [Thu, 13 Sep 2012 23:09:30 +0000 (23:09 +0000)]
[WinCairo] Unreviewed build fix for export declarations.

New entries were added to the standard Windows export definition
file, but were not added to the WinCairo version, breaking the build.

* win/WebKit2CFLite.def: Incoproate changes from WebKit2.def file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix compile warning/error on windows - literal that isn't exactly representable as...
jamesr@google.com [Thu, 13 Sep 2012 23:07:20 +0000 (23:07 +0000)]
Fix compile warning/error on windows - literal that isn't exactly representable as a float needs "f" suffix.

* tests/PlatformGestureCurveTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd optional debug logging when we fall into/out of threaded scrolling
timothy_horton@apple.com [Thu, 13 Sep 2012 23:04:21 +0000 (23:04 +0000)]
Add optional debug logging when we fall into/out of threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=93898
<rdar://problem/12089098>

Reviewed by Simon Fraser.

Add logging when we enter and exit the threaded scrolling mode, and logs the reasons we
fall into main-thread scrolling.

The logging output looks like this:
    SCROLLING: Switching to main-thread scrolling mode. Time: 15843.554718 Reason(s): viewport-constrained objects
    SCROLLING: Switching to threaded scrolling mode. Time: 15844.550866
    SCROLLING: Switching to main-thread scrolling mode. Time: 15845.551214 Reason(s): viewport-constrained objects
    SCROLLING: Switching to threaded scrolling mode. Time: 15846.552619
    SCROLLING: Switching to main-thread scrolling mode. Time: 15847.553587 Reason(s): viewport-constrained objects
    SCROLLING: Switching to threaded scrolling mode. Time: 15848.554084

No new tests, as this is just debugging logging.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
Construct a bitfield describing the reasons we fall into main-thread scrolling mode.

* page/scrolling/ScrollingCoordinatorNone.cpp:
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
* page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::ScrollingTreeNode):
* page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::shouldUpdateScrollLayerPositionOnMainThread):
* page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setShouldUpdateScrollLayerPositionOnMainThread):
* page/scrolling/ScrollingTreeState.h:
(WebCore::ScrollingTreeState::shouldUpdateScrollLayerPositionOnMainThread):
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
Use the reasons bitfield instead of a boolean.

* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
Add MainThreadScrollingReasons enum, with the current reasons that we might fallback to main-thread scrolling.

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::scrollingPerformanceLoggingEnabled):
Fix a typo (scrollingPeformanceLoggingEnabled -> scrollingPerformanceLoggingEnabled).

* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
(WebCore::logThreadedScrollingMode):
Pretty-print the scrolling mode and shouldUpdateScrollLayerPositionOnMainThreadReason.

Update the scrolling tree's scrollingPerformanceLoggingEnabled preference
before the early-return if we don't have layer debugging borders on.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Binding: Generate batched attribute/const/callback struct names can collide
jsbell@chromium.org [Thu, 13 Sep 2012 23:01:34 +0000 (23:01 +0000)]
[V8] Binding: Generate batched attribute/const/callback struct names can collide
https://bugs.webkit.org/show_bug.cgi?id=96700

Reviewed by Kentaro Hara.

The V8 binding code generator spits out static arrays for batched configuration of
consts, attributes, and callbacks. Prior to this patch, it would spit them out
in the WebCore namespace with names like <BaseType>Callbacks which could collide with
other code. This change renames them from <BaseType><Suffix> to V8<BaseType><Suffix>.

Tests: Rebaselined the binding/scripts/test/V8/* results. No functional changes.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(Float64ArrayV8Internal):
(WebCore):
(WebCore::ConfigureV8Float64ArrayTemplate):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(TestActiveDOMObjectV8Internal):
(WebCore):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(TestCustomNamedGetterV8Internal):
(WebCore):
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(TestEventConstructorV8Internal):
(WebCore):
(WebCore::ConfigureV8TestEventConstructorTemplate):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(TestEventTargetV8Internal):
(WebCore):
(WebCore::ConfigureV8TestEventTargetTemplate):
* bindings/scripts/test/V8/V8TestException.cpp:
(TestExceptionV8Internal):
(WebCore):
(WebCore::ConfigureV8TestExceptionTemplate):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(TestInterfaceV8Internal):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(TestMediaQueryListListenerV8Internal):
(WebCore):
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
* bindings/scripts/test/V8/V8TestObj.cpp:
(TestObjV8Internal):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Improve string manipulation in EflKeyboardUtilities.cpp
ryuan.choi@samsung.com [Thu, 13 Sep 2012 22:58:42 +0000 (22:58 +0000)]
[EFL] Improve string manipulation in EflKeyboardUtilities.cpp
https://bugs.webkit.org/show_bug.cgi?id=96598

Reviewed by Benjamin Poulain.

Uses ASCIILiteral for static strings as recommended by
http://trac.webkit.org/wiki/EfficientStrings and uses HexNumber to remove
String::format.

No behavior change. Just a refactoring.

* platform/efl/EflKeyboardUtilities.cpp:
(WebCore::addCharactersToKeyMap):
(WebCore::createKeyMap):
(WebCore::createWindowsKeyMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Adding myself to the committers list.
mark.lam@apple.com [Thu, 13 Sep 2012 22:58:09 +0000 (22:58 +0000)]
Unreviewed. Adding myself to the committers list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agopercentage heights in quirks mode with auto-sized body are computed incorrectly
ojan@chromium.org [Thu, 13 Sep 2012 22:56:07 +0000 (22:56 +0000)]
percentage heights in quirks mode with auto-sized body are computed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=96426

Reviewed by Tony Chang.

Source/WebCore:

In quirks mode, for the body element, we need to keep walking up to the html element
if the body's height is auto. Also, we need to subtract the body/html elements
margin/border/padding so that we properly get the body's content height.

This behavior matches IE9, FF and Opera.

None of this applies to standards mode since we don't walk up the
containingBlock chain for auto-sized elements.

Test: fast/css/percentage-height-auto-sized-body-quirks.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):

LayoutTests:

* fast/css/percentage-height-auto-sized-body-quirks-expected.txt: Added.
* fast/css/percentage-height-auto-sized-body-quirks.html: Added.
Verified that this matches IE9, FF15 and Opera12.

* fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt:
* platform/chromium-linux/fast/table/height-percent-test-expected.png:
* platform/chromium-linux/tables/mozilla/core/cell_heights-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-win/tables/mozilla/core/cell_heights-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug19526-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/mac/fast/table/height-percent-test-expected.txt:
Verified that all the changes match FF15.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/table/bad-replaced-sizing-preferred-logical-widths.html is failing on Mac, Chrom...
ojan@chromium.org [Thu, 13 Sep 2012 22:52:22 +0000 (22:52 +0000)]
fast/table/bad-replaced-sizing-preferred-logical-widths.html is failing on Mac, Chromium-Mac, GTK, EFL
https://bugs.webkit.org/show_bug.cgi?id=96594

Reviewed by Tony Chang.

Remove the text so that this test gets metrics the same across platforms.

* fast/table/bad-replaced-sizing-preferred-logical-widths.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Fix lint error in my last TestExpectations patch - whoops!
jamesr@google.com [Thu, 13 Sep 2012 22:50:29 +0000 (22:50 +0000)]
Unreviewed gardening. Fix lint error in my last TestExpectations patch - whoops!

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHide all ancestors of the full screen element when going full screen
enne@google.com [Thu, 13 Sep 2012 22:32:28 +0000 (22:32 +0000)]
Hide all ancestors of the full screen element when going full screen
https://bugs.webkit.org/show_bug.cgi?id=96332

Reviewed by James Robinson.

Source/WebCore:

Since fixed position elements can now sometimes become stacking
contexts, explicitly set position: static on full-screen ancestors so
that there are no stacking context ancestors that could cause the full
screen element to become incorrectly sorted.

Test: fullscreen/full-screen-fixed-pos-parent.html

* css/fullscreen.css:
(:-webkit-full-screen-ancestor:not(iframe)):

LayoutTests:

This test has an all red image that (without this patch) incorrectly
sorts on top of the full screen element. With this patch, the all
green full screen element appears on top.

* fullscreen/full-screen-fixed-pos-parent-expected.png: Added.
* fullscreen/full-screen-fixed-pos-parent-expected.txt: Added.
* fullscreen/full-screen-fixed-pos-parent.html: Added.
* fullscreen/resources/green.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r125126): It made fast/events/keyevent-iframe-removed-crash.html assert
abarth@webkit.org [Thu, 13 Sep 2012 22:19:43 +0000 (22:19 +0000)]
REGRESSION(r125126): It made fast/events/keyevent-iframe-removed-crash.html assert
https://bugs.webkit.org/show_bug.cgi?id=93654

Reviewed by Eric Seidel.

Source/WebCore:

When wrapping a Document, we need to ensure that the global object for
the wrapper actually exists before trying to create the wrapper. In
other cases in the DOM, we always touch the global object before trying
to wrap a given DOM object. For Document, however,
HTMLFrameElement.contentDocument is a rare way to get at a DOM object
for a global object without first touching the Window object.

Rather than writing custom bindings for
HTMLFrameElement.contentDocument, this patch just makes toJS for
Document ensure that toJS for DOMWindow has been called first. The V8
bindings have some similar code.

Test: fast/dom/content-document-prototype.html

* bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS):

LayoutTests:

* fast/dom/content-document-prototype-expected.txt: Added.
* fast/dom/content-document-prototype.html: Added.
    - Check that HTMLFrameElement.contentDocument ends up with the
      right prototype chain. This is a tricky case because not only the
      prototype chain of the property different from the holder, we
      never actually touch the DOMWindow in this test case so the
      prototype chain leads to a global object that doesn't even exist
      yet!
* fast/events/keyevent-iframe-removed-crash.html:
    - Add a call to gc() so that this test will ASSERT reliabily if we
      cause a similar problem in the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build.
andersca@apple.com [Thu, 13 Sep 2012 22:13:07 +0000 (22:13 +0000)]
Fix build.

* platform/graphics/Latin1TextIterator.h:
(WebCore::Latin1TextIterator::Latin1TextIterator):
(Latin1TextIterator):
m_endCharacter is an unused private member variable, so just remove it to appease newer versions of clang.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun-perf-tests output cryptic error when the config file is missing.
rniwa@webkit.org [Thu, 13 Sep 2012 21:51:59 +0000 (21:51 +0000)]
run-perf-tests output cryptic error when the config file is missing.
https://bugs.webkit.org/show_bug.cgi?id=96453

Reviewed by Tony Chang.

Add a special error message when a configuration file is missing.

Also update the help message of --source-json-path to signify the fact it specifies
the configuration file on performance tests bots.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._generate_and_show_results):
(PerfTestsRunner._merge_slave_config_json):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(_test_run_with_json_output): Make upload to fail by default and assert the result
in the function so that we can return logs instead.
(_test_run_with_json_output.mock_upload_json):
(test_run_with_json_output):
(test_run_with_description):
(test_run_respects_no_results):
(test_run_with_slave_config_json):
(test_run_with_bad_slave_config_json):
(test_run_with_multiple_repositories):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening - upstream some skia_test_expectations.txt entries.
jamesr@google.com [Thu, 13 Sep 2012 21:29:53 +0000 (21:29 +0000)]
Unreviewed gardening - upstream some skia_test_expectations.txt entries.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Cleanup AboutDataEnableFeatures.in
rwlbuis@webkit.org [Thu, 13 Sep 2012 21:21:25 +0000 (21:21 +0000)]
[BlackBerry] Cleanup AboutDataEnableFeatures.in
https://bugs.webkit.org/show_bug.cgi?id=96695

Reviewed by Antonio Gomes.

Remove unused features.

* WebCoreSupport/AboutDataEnableFeatures.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTypo in RenderStyle::isFlippedLinesWritingMode(), small refactoring possible
commit-queue@webkit.org [Thu, 13 Sep 2012 21:21:12 +0000 (21:21 +0000)]
Typo in RenderStyle::isFlippedLinesWritingMode(), small refactoring possible
https://bugs.webkit.org/show_bug.cgi?id=96679

Patch by Hans Muller <hmuller@adobe.com> on 2012-09-13
Reviewed by Darin Adler.

Fixed a typo in the comment for RenderStyle::isFlippedLinesWritingMode() and refactored the
three RendersStyle::isXXXWritingMode() inlines to use the inlines defined in WritingMode.h.
Moved the comments to WritingMode.h

No new tests needed.

* platform/text/WritingMode.h:
(WebCore):
* rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEvas_Object* is a ref'ed structure, so tread it as such
kenneth@webkit.org [Thu, 13 Sep 2012 21:19:41 +0000 (21:19 +0000)]
Evas_Object* is a ref'ed structure, so tread it as such
https://bugs.webkit.org/show_bug.cgi?id=96659

Reviewed by Adam Barth.

Source/WebCore:

Replace OwnPtr<Evas_Object> with RefPtr.

* PlatformEfl.cmake:
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
(ThemePartCacheEntry):

Source/WebKit/efl:

Replace OwnPtr<Evas_Object> with RefPtr.

* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::init):
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):

Source/WTF:

Remove OwnPtr support for Evas_Object* and add support for it
with RefPtr instead (the latter moved from WebCore).

* wtf/PlatformEfl.cmake:
* wtf/efl/OwnPtrEfl.cpp:
* wtf/efl/RefPtrEfl.cpp: Renamed from Source/WebCore/platform/efl/RefPtrEfl.cpp.
(WTF):
(WTF::refIfNotNull):
(WTF::derefIfNotNull):
* wtf/efl/RefPtrEfl.h: Renamed from Source/WebCore/platform/efl/RefPtrEfl.h.
(WTF):

Tools:

Replace OwnPtr<Evas_Object> with RefPtr.

* DumpRenderTree/efl/ImageDiff.cpp:
(calculateDifference):
(printImageDifferences):
(readImageFromStdin):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother typo fix. Apparently, I "fixed" the wrong line in the previous commit.
rniwa@webkit.org [Thu, 13 Sep 2012 21:07:46 +0000 (21:07 +0000)]
Another typo fix. Apparently, I "fixed" the wrong line in the previous commit.

* coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] REGRESSION(r127457): Context menu on textarea is displayed in the wrong...
jchaffraix@webkit.org [Thu, 13 Sep 2012 21:05:54 +0000 (21:05 +0000)]
[Chromium] REGRESSION(r127457): Context menu on textarea is displayed in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=96593

Reviewed by Adam Barth.

After r127457, the HitTestResult stored in ContextMenuController is in window coordinates.
Trying to convert it again to window coordinates will result in adding the containing frame's
position twice, thus the wrong placing.

Chromium Mac wasn't impacted by the regression and I manually checked that the fix doesn't impact Mac.

Unfortunately, no test as I don't think we have a way of testing context menu position.

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded 8 bit path to WidthIterator::advance()
msaboff@apple.com [Thu, 13 Sep 2012 21:03:55 +0000 (21:03 +0000)]
Added 8 bit path to WidthIterator::advance()
https://bugs.webkit.org/show_bug.cgi?id=96590

Reviewed by Geoffrey Garen.

Source/WebCore:

Added 8 bit path to advance() by adding a templatized advanceInternal private
method and added a simple 8 bit Latin-1 TextIterator.  Updated SurrogatePairAwareTextIterator
by making both consume() and advance() inlined and adding consumeSlowCase() for
surrogate handling.  These changes are a performance progression on the Layout tests.

No new tests because of no behavior changes.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/Latin1TextIterator.h: Copied from Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.h.
(Latin1TextIterator):
(WebCore::Latin1TextIterator::Latin1TextIterator):
(WebCore::Latin1TextIterator::consume):
(WebCore::Latin1TextIterator::advance):
(WebCore::Latin1TextIterator::characters):
* platform/graphics/SurrogatePairAwareTextIterator.cpp:
(WebCore::SurrogatePairAwareTextIterator::consumeSlowCase):
* platform/graphics/SurrogatePairAwareTextIterator.h:
(WebCore::SurrogatePairAwareTextIterator::consume):
(SurrogatePairAwareTextIterator):
(WebCore::SurrogatePairAwareTextIterator::advance):
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):
* platform/graphics/WidthIterator.h:
(WidthIterator):

Source/WTF:

Added new character constant for Hiragana Letter Small A.

* wtf/unicode/CharacterNames.h:
(Unicode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix a typo per Darin's comment.
rniwa@webkit.org [Thu, 13 Sep 2012 20:49:54 +0000 (20:49 +0000)]
Fix a typo per Darin's comment.

* coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Rename InspectorOverlay in blackberry/WebKitSupport
rwlbuis@webkit.org [Thu, 13 Sep 2012 20:43:55 +0000 (20:43 +0000)]
[BlackBerry] Rename InspectorOverlay in blackberry/WebKitSupport
https://bugs.webkit.org/show_bug.cgi?id=96689

Reviewed by Antonio Gomes.

Rename to InspectorClientBlackBerry to avoid include problems.

* WebCoreSupport/InspectorClientBlackBerry.h:
* WebKitSupport/InspectorOverlayBlackBerry.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.cpp.
(WebKit):
(BlackBerry::WebKit::InspectorOverlay::create):
(BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
(BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
(BlackBerry::WebKit::InspectorOverlay::paintContents):
(BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
(BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
(BlackBerry::WebKit::InspectorOverlay::~InspectorOverlay):
(BlackBerry::WebKit::InspectorOverlay::clear):
(BlackBerry::WebKit::InspectorOverlay::update):
* WebKitSupport/InspectorOverlayBlackBerry.h: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.h.
(WebCore):
(WebKit):
(InspectorOverlay):
(InspectorOverlayClient):
(BlackBerry::WebKit::InspectorOverlay::setClient):
(BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] alter fling animation parameters.
rjkroege@chromium.org [Thu, 13 Sep 2012 20:26:24 +0000 (20:26 +0000)]
[chromium] alter fling animation parameters.
https://bugs.webkit.org/show_bug.cgi?id=96666

Reviewed by Adrienne Walker.

Corrected the test to be non-fragile in the presence of altered fling
curve parameters.

* tests/PlatformGestureCurveTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoText Autosizing: Add explanations to tests.
commit-queue@webkit.org [Thu, 13 Sep 2012 20:23:13 +0000 (20:23 +0000)]
Text Autosizing: Add explanations to tests.
https://bugs.webkit.org/show_bug.cgi?id=96673

Patch by John Mellor <johnme@chromium.org> on 2012-09-13
Reviewed by Julien Chaffraix.

Replaces some of the lorem ipsum filler text in Text Autosizing tests
with explanations of why the result is expected (and other minor tweaks
to tests).

* fast/text-autosizing/font-scale-factor-expected.html:
* fast/text-autosizing/font-scale-factor.html:
* fast/text-autosizing/narrow-iframe-expected.html:
* fast/text-autosizing/narrow-iframe-flattened-expected.html:
* fast/text-autosizing/narrow-iframe-flattened.html:
* fast/text-autosizing/narrow-iframe.html:
* fast/text-autosizing/nested-em-line-height-expected.html:
* fast/text-autosizing/nested-em-line-height.html:
* fast/text-autosizing/simple-paragraph-expected.html:
* fast/text-autosizing/simple-paragraph.html:
* fast/text-autosizing/span-child-expected.html:
* fast/text-autosizing/span-child.html:
* fast/text-autosizing/various-font-sizes-expected.html:
* fast/text-autosizing/various-font-sizes.html:
* fast/text-autosizing/wide-block-expected.html:
* fast/text-autosizing/wide-block.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a style guide rule for signed and unsigned int
rniwa@webkit.org [Thu, 13 Sep 2012 20:17:42 +0000 (20:17 +0000)]
Add a style guide rule for signed and unsigned int
https://bugs.webkit.org/show_bug.cgi?id=96682

Reviewed by Geoffrey Garen.

Add a rule per http://lists.webkit.org/pipermail/webkit-dev/2012-September/022199.html.

* coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename forEachCell to forEachLiveCell
mhahnenberg@apple.com [Thu, 13 Sep 2012 20:08:53 +0000 (20:08 +0000)]
Rename forEachCell to forEachLiveCell
https://bugs.webkit.org/show_bug.cgi?id=96685

Reviewed by Oliver Hunt.

forEachCell actually only iterates over live cells. We should rename it to
reflect what it actually does. This is also helpful because we want to add a new
forEachCell that actually does iterate each and every cell in a MarkedBlock
regardless of whether or not it is live.

* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* heap/Heap.cpp:
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
* heap/MarkedBlock.h:
(MarkedBlock):
(JSC::MarkedBlock::forEachLiveCell):
* heap/MarkedSpace.h:
(MarkedSpace):
(JSC::MarkedSpace::forEachLiveCell):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::releaseExecutableMemory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] ResourceRequest string optimizations
yoli@rim.com [Thu, 13 Sep 2012 20:02:39 +0000 (20:02 +0000)]
[BlackBerry] ResourceRequest string optimizations
https://bugs.webkit.org/show_bug.cgi?id=96661

Reviewed by Rob Buis.

RIM PR# 207965.
Call PlatformRequest's method to add the Accept-Language header.

No new tests as no functional change.

* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r128489.
commit-queue@webkit.org [Thu, 13 Sep 2012 19:57:54 +0000 (19:57 +0000)]
Unreviewed, rolling out r128489.
http://trac.webkit.org/changeset/128489
https://bugs.webkit.org/show_bug.cgi?id=96686

Does not compile on windows (Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

Source/WebCore:

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::create):
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::registerFrontendCallbacks):
(WebCore):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(IDBDatabaseBackendImpl::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::PendingOpenWithVersionCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::connectionCount):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::close):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:
(WebCore::IDBDatabaseCallbacksImpl::create):
(WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
(WebCore::IDBDatabaseCallbacksImpl::unregisterDatabase):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
(IDBDatabaseCallbacksImpl):
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open):
* Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
* Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl):
* Modules/indexeddb/IDBFactoryBackendInterface.h:
(IDBFactoryBackendInterface):
* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::create):
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
(WebCore::IDBOpenDBRequest::onSuccess):
* Modules/indexeddb/IDBOpenDBRequest.h:
(IDBOpenDBRequest):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):

Source/WebKit/chromium:

* public/WebIDBDatabase.h:
* public/WebIDBFactory.h:
(WebIDBFactory):
* src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):
* src/IDBCallbacksProxy.h:
(WebKit):
(IDBCallbacksProxy):
* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks):
(WebKit):
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::open):
* src/IDBFactoryBackendProxy.h:
(IDBFactoryBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
(WebKit::WebIDBDatabaseImpl::close):
(WebKit::WebIDBDatabaseImpl::open):
(WebKit):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::open):
* src/WebIDBFactoryImpl.h:
(WebIDBFactoryImpl):
* tests/IDBAbortOnCorruptTest.cpp:
(WebCore::TEST):
* tests/IDBDatabaseBackendTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOne more unreviewed trivial fix after r128399.
ossy@webkit.org [Thu, 13 Sep 2012 19:52:36 +0000 (19:52 +0000)]
One more unreviewed trivial fix after r128399.

* BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor duplicate code into RenderFlexibleBox::mainAxisContentExtent
tony@chromium.org [Thu, 13 Sep 2012 19:49:34 +0000 (19:49 +0000)]
Refactor duplicate code into RenderFlexibleBox::mainAxisContentExtent
https://bugs.webkit.org/show_bug.cgi?id=96676

Reviewed by Eric Seidel.

There was computeAvailableFreeSpace() and lineBreakLength() shared some very similar code.
Merge this code into mainAxisContentExtent().

No new tests, this is just a refactor.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisContentExtent): Take contentLogicalHeight as a parameter,
which is needed when determining the logical height.
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace): Use mainAxisContentExtent() and inline.
(WebCore::RenderFlexibleBox::computeNextFlexLine): Use mainAxisContentExtent().
* rendering/RenderFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed trivial fix after r128399.
ossy@webkit.org [Thu, 13 Sep 2012 19:46:07 +0000 (19:46 +0000)]
Unreviewed trivial fix after r128399.

* BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
(getLatestSVNRevision):
(waitForSVNRevision):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd new accelerated compositing for overflow scroll setting.
commit-queue@webkit.org [Thu, 13 Sep 2012 19:26:35 +0000 (19:26 +0000)]
Add new accelerated compositing for overflow scroll setting.
https://bugs.webkit.org/show_bug.cgi?id=95885

Patch by Glenn Hartmann <hartmanng@chromium.org> on 2012-09-13
Reviewed by James Robinson.

wkb.ug/91117 introduces RenderLayer::usesCompositedScrolling(), which
currently returns true if we're overflow scrolling and the element has
been styled with '-webkit-overflow-scrolling: touch'. If this is true,
we get promoted to a composited layer, the associated RenderLayerBacking
gets special scrolling layers and in response to RenderLayer::scrollTo()
we no longer have to invalidate everything to get the scrolled content
in the right spot, thereby avoiding very expensive repaints. It's
unfortunate that we require -webkit-overflow-scrolling: touch, though.
It would be nice if RenderLayer::usesCompositedScrolling() returned true
if the page would continue to behave correctly.  This is what
wkb.ug/94743 is intended to do.  Unfortunately, when we become a
composited layer, we switch from subpixel to grayscale anti-aliasing. We
only want to auto-opt into composited scrolling if we don't mind the
change in anti-aliasing, so we need a flag to enable/disable this
feature.

Source/WebCore:

No new tests -- no change in behaviour.

* page/Settings.h:
(WebCore::Settings::setAcceleratedCompositingForOverflowScrollEnabled):
(WebCore::Settings::acceleratedCompositingForOverflowScrollEnabled):
(Settings):

Source/WebKit/chromium:

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAcceleratedCompositingForOverflowScrollEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
commit-queue@webkit.org [Thu, 13 Sep 2012 19:26:12 +0000 (19:26 +0000)]
[WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
https://bugs.webkit.org/show_bug.cgi?id=96366

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-13
Reviewed by Anders Carlsson.

Source/WebKit2:

Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
by calling shouldClose() on the FrameLoader.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCallShouldCloseOnWebView):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

Tools:

Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
by calling shouldClose() on the FrameLoader.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::callShouldCloseOnWebView):
(WTR):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):

LayoutTests:

Unskip passing test fast/events/onbeforeunload-focused-iframe.html

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r128453.
zandobersek@gmail.com [Thu, 13 Sep 2012 19:21:26 +0000 (19:21 +0000)]
Unreviewed, rolling out r128453.
http://trac.webkit.org/changeset/128453
https://bugs.webkit.org/show_bug.cgi?id=96681

Having tests use the same appcache directory leads to timeouts
(Requested by zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::clearMemoryCache):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools:

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Consolidate two-phase connection to avoid race conditions
jsbell@chromium.org [Thu, 13 Sep 2012 19:19:44 +0000 (19:19 +0000)]
IndexedDB: Consolidate two-phase connection to avoid race conditions
https://bugs.webkit.org/show_bug.cgi?id=90411

Reviewed by Tony Chang.

Source/WebCore:

Previously, IDB connections were opened by having the front-end (1) call through to
a back-end open() method, eventually receive a success message with a back-end object
handle, and (2) call into the back-end object to register front-end callbacks. This left
the back-end's notion of an open connection in a limbo state between these two calls.
In multi-process ports, a crash of the front-end process could leave the back-end wedged
waiting for this second call (e.g. can't delete until all connections are closed).

Simplify this by having the front-end pass through the callbacks into the back-end
during the initial open() call, which eliminates the limbo state.

No new tests - no functional changes. Chromium port's webkit_unit_tests updated.

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::create):
(WebCore::IDBDatabase::IDBDatabase): Db-callbacks is available at creation time.
(WebCore::IDBDatabase::~IDBDatabase):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create): Need to track db-callbacks as well.
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::databaseCallbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(IDBDatabaseBackendImpl::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create): Ditto.
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::databaseCallbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::PendingOpenWithVersionCall):
(IDBDatabaseBackendImpl::PendingOpenWithVersionCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::connectionCount): Don't need to count limbo connections any more.
(WebCore::IDBDatabaseBackendImpl::processPendingCalls): Pass through db-callbacks.
(WebCore::IDBDatabaseBackendImpl::openConnection): No more limbo connections (yay!).
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction): Pass through db-callbacks.
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion): Ditto.
(WebCore::IDBDatabaseBackendImpl::deleteDatabase): Style.
(WebCore::IDBDatabaseBackendImpl::close): Resolve FIXME about connectionCount.
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:
(WebCore::IDBDatabaseCallbacksImpl::create):
(WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
(WebCore::IDBDatabaseCallbacksImpl::connect):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
(IDBDatabaseCallbacksImpl):
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open): Mint the db-callbacks here...
* Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open): ...passed through to here...
* Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl):
* Modules/indexeddb/IDBFactoryBackendInterface.h:
(IDBFactoryBackendInterface):
* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::create): ...all the way to here...
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded): ...and finally hooked up here.
(WebCore::IDBOpenDBRequest::onSuccess): (or here, if no upgrade needed).
* Modules/indexeddb/IDBOpenDBRequest.h:
(WebCore):
(IDBOpenDBRequest):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort): Tweak event/notification ordering; the
notifying the database that the transaction is finished may unblock closing,
which fires more events, and the delivery matters. Previously the close would
be blocked by the transaction which gave the desired order.
(WebCore::IDBTransaction::onComplete): Ditto.
* inspector/InspectorIndexedDBAgent.cpp: New hookup logic.
(WebCore):

Source/WebKit/chromium:

API plumbing for simplified single-phase connection opening, and tests updated
to exercise the new APIs.

* public/WebIDBDatabase.h:
(WebIDBDatabase): Just a FIXME to remove the old second-phase hookup API.
* public/WebIDBFactory.h:
(WebKit):
(WebIDBFactory):
(WebKit::WebIDBFactory::open): New overload that takes db-callbacks.
* src/IDBCallbacksProxy.cpp: The db-callbacks plumbing is needed earlier.
(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):
(WebKit):
(WebKit::IDBCallbacksProxy::setDatabaseCallbacks): Needs to hold on to
the db-callbacks and hook it up when the onSuccess callback comes through.
* src/IDBCallbacksProxy.h:
(WebKit):
(IDBCallbacksProxy):
* src/IDBDatabaseBackendProxy.cpp:
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::open):
* src/IDBFactoryBackendProxy.h:
(IDBFactoryBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
(WebKit::WebIDBDatabaseImpl::close):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::open):
* src/WebIDBFactoryImpl.h:
(WebIDBFactoryImpl):
* tests/IDBAbortOnCorruptTest.cpp:
(FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::create):
(WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks):
(WebCore):
(WebCore::TEST): Updated connection sequence.
* tests/IDBDatabaseBackendTest.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
jamesr@google.com [Thu, 13 Sep 2012 19:06:00 +0000 (19:06 +0000)]
[chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
https://bugs.webkit.org/show_bug.cgi?id=96678

Reviewed by Dirk Pranke.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Thu, 13 Sep 2012 18:41:49 +0000 (18:41 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFlexitem margins should be based on content width, not width
tony@chromium.org [Thu, 13 Sep 2012 18:39:27 +0000 (18:39 +0000)]
Flexitem margins should be based on content width, not width
https://bugs.webkit.org/show_bug.cgi?id=96674

Reviewed by Ojan Vafai.

Source/WebCore:

Margins should be based on content width. Also remove some calls to
mainAxisContentExtent() when we can use contentLogicalWidth instead.

Tests: css3/flexbox/percent-margins.html has a new testcase.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild): Use contentLogicalWidth instead of
passing in the maximum value (only used in the width case).
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): Don't pass in mainAxisContentExtent.
(WebCore::RenderFlexibleBox::computeChildMarginValue): Use contentLogicalWidth and simplify the code.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Remove unnecessary mainAxisContentExtent() call.
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax): Remove unnecessary flexboxAvailableContentExtent.
(WebCore::RenderFlexibleBox::computeNextFlexLine): Remove unnecessary mainAxisContentExtent() call.
(WebCore::RenderFlexibleBox::resolveFlexibleLengths): Remove unnecessary mainAxisContentExtent() call.
* rendering/RenderFlexibleBox.h: Remove unnecessary params.

LayoutTests:

Add a test case where contentWidth != width.

* css3/flexbox/percent-margins-expected.txt:
* css3/flexbox/percent-margins.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Assertion reached on RenderThemeEFL when setting a theme to an invalid path
commit-queue@webkit.org [Thu, 13 Sep 2012 18:33:41 +0000 (18:33 +0000)]
[EFL] Assertion reached on RenderThemeEFL when setting a theme to an invalid path
https://bugs.webkit.org/show_bug.cgi?id=96649

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Keep the consistence by restoring the reference to the old theme path
when the new one cannot be loaded.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::setThemePath):

Source/WebKit2:

Updated the alternative test theme file. It is basically
the default theme with extra padding on the button widget as
specified by the comments on the test case.

* UIProcess/API/efl/tests/resources/big_button_theme.edj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, warning fix left over from r128456 (bug 96645)
commit-queue@webkit.org [Thu, 13 Sep 2012 18:16:59 +0000 (18:16 +0000)]
Unreviewed, warning fix left over from r128456 (bug 96645)

Patch by Antonio Gomes <agomes@rim.com> on 2012-09-13

* Api/InRegionScroller.cpp:
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] alter fling animation parameters.
rjkroege@chromium.org [Thu, 13 Sep 2012 18:16:32 +0000 (18:16 +0000)]
[chromium] alter fling animation parameters.
https://bugs.webkit.org/show_bug.cgi?id=96666

Reviewed by Adrienne Walker.

Adjusted configuration parameters for fling animation to have a longer
tail and more similarity between touchpad and touchscreen.

Covered by existing tests.

* platform/TouchFlingPlatformGestureCurve.cpp:
(WebCore::TouchFlingPlatformGestureCurve::createForTouchPad):
(WebCore::TouchFlingPlatformGestureCurve::createForTouchScreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Properties of IDBKeyRange should default to undefined
jsbell@chromium.org [Thu, 13 Sep 2012 18:05:03 +0000 (18:05 +0000)]
IndexedDB: Properties of IDBKeyRange should default to undefined
https://bugs.webkit.org/show_bug.cgi?id=96401

Reviewed by Adam Barth.

Source/WebCore:

Per the IndexedDB spec, properties of IDBKeyRange should be |undefined| if
not set (i.e. range.upper if created with lowerBound(), and vice versa), rather
than null.

Test: storage/indexeddb/keyrange.html

* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8): Since IDBKeyRange is the only place where possibly-null
keys are returned to script, change the JS value from null to undefined.
And call v8Undefined(). It's faster.
* bindings/js/custom/JSIDBKeyCustom.cpp:
(WebCore::toJS): Ditto.

LayoutTests:

Update test expectations.

* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/resources/keyrange.js:
(checkLowerBoundKeyRange):
(checkUpperBoundKeyRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed changes to watchlist.
rwlbuis@webkit.org [Thu, 13 Sep 2012 18:03:02 +0000 (18:03 +0000)]
Unreviewed changes to watchlist.

- Add myself to BlackBerry bugs

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd an SVG entry to the watchlist
schenney@chromium.org [Thu, 13 Sep 2012 17:50:03 +0000 (17:50 +0000)]
Add an SVG entry to the watchlist

Unreviewed config change.

* Scripts/webkitpy/common/config/watchlist:
- Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
- Added myself and pdr as watchers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoContinue to send mouse move events to a non-scrollable page
commit-queue@webkit.org [Thu, 13 Sep 2012 17:29:20 +0000 (17:29 +0000)]
Continue to send mouse move events to a non-scrollable page
even if they are not consumed.
PR #207024
https://bugs.webkit.org/show_bug.cgi?id=96655

Patch by Genevieve Mak <gmak@rim.com> on 2012-09-13
Reviewed by Antonio Gomes.

* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::isMainFrameScrollable):
(WebKit):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor paint overflow clipping
commit-queue@webkit.org [Thu, 13 Sep 2012 17:22:21 +0000 (17:22 +0000)]
Refactor paint overflow clipping
https://bugs.webkit.org/show_bug.cgi?id=96625

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-09-13
Reviewed by Simon Fraser.

The same logic for applying overflow clipping based on the cached size of a
RenderBox has been duplicated to four different places. Consolidate them to a
single RenderBox utility function.

This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=96087.

No new functionality; covered by existing tests.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint):
(WebCore):
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::computeRectForRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Missing conditions in InRegionScrollerPrivate::canScrollRenderBox
zhajiang@rim.com [Thu, 13 Sep 2012 17:03:05 +0000 (17:03 +0000)]
[BlackBerry] Missing conditions in InRegionScrollerPrivate::canScrollRenderBox
https://bugs.webkit.org/show_bug.cgi?id=96660

Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 207884
According to RenderBox::canBeScrolledAndHasScrollableArea(), we should
bail out early in InRegionScrollerPrivate::canScrollRenderBox() if the
RenderBox's scroll height equals the client height and the scroll width
equals the client width. Otherwise, we will miss the conditions.

* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother prospective Qt/Windows build fix: Add missing CString.h include.
hausmann@webkit.org [Thu, 13 Sep 2012 16:37:42 +0000 (16:37 +0000)]
Another prospective Qt/Windows build fix: Add missing CString.h include.

* platform/qt/UserAgentQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStop shuttling PseudoId from StyleResolver to SelectorChecker.
dglazkov@chromium.org [Thu, 13 Sep 2012 16:33:04 +0000 (16:33 +0000)]
Stop shuttling PseudoId from StyleResolver to SelectorChecker.
https://bugs.webkit.org/show_bug.cgi?id=96431

Reviewed by Eric Seidel.

SelectorChecker retained extra state to store the PseudoId value of the element. It was sad, because we needed to explicitly maintain its integrity. Instead, we now just make it part of StyleResolver and feed to SelectorChecker as part of SelectorCheckingContext.

No new tests, refactoring only. Covered by existing tests.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::SelectorChecker): Removed state initializer.
(WebCore::SelectorChecker::checkSelector): Changed to look into context, rather than own member.
* css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): Added pseudoStyle as parameter.
(SelectorCheckingContext): Added pseudoStyle as member.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Changed to look at own member, rather than m_checker.
* css/StyleResolver.h:
(StyleResolver): Added new member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed prospective Qt/MSVC build fix.
hausmann@webkit.org [Thu, 13 Sep 2012 16:24:37 +0000 (16:24 +0000)]
Unreviewed prospective Qt/MSVC build fix.

* platform/qt/UserAgentQt.cpp:
(WebCore::UserAgentQt::standardUserAgent): Try to make the conversion from the 8-bit
String to a QLatin1String successful.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] LayerTreeCoordinator should release unused UpdatedAtlases
kbalazs@webkit.org [Thu, 13 Sep 2012 16:18:21 +0000 (16:18 +0000)]
[WK2] LayerTreeCoordinator should release unused UpdatedAtlases
https://bugs.webkit.org/show_bug.cgi?id=95072

Reviewed by Jocelyn Turcotte.

Release graphic buffers that haven't been used for a while in order to save memory.
This way we can give back memory to the system when no user interaction happens
after a period of time, for example when we are in the background.

* Shared/ShareableBitmap.h:
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::beginContentUpdate):
(WebKit):
(WebKit::LayerTreeCoordinator::scheduleReleaseInactiveAtlases):
(WebKit::LayerTreeCoordinator::releaseInactiveAtlasesTimerFired):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
* WebProcess/WebPage/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::didSwapBuffers):
Don't call buildLayoutIfNeeded here. It's enought to call it in beginPaintingOnAvailableBuffer
and this way we can track whether this atlas is used with m_areaAllocator.
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
* WebProcess/WebPage/UpdateAtlas.h:
(WebKit::UpdateAtlas::addTimeInactive):
(WebKit::UpdateAtlas::isInactive):
(WebKit::UpdateAtlas::isInUse):
(UpdateAtlas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] fast/forms/access-key-for-all-elements.html fails
commit-queue@webkit.org [Thu, 13 Sep 2012 16:07:53 +0000 (16:07 +0000)]
[Qt][WK2] fast/forms/access-key-for-all-elements.html fails
https://bugs.webkit.org/show_bug.cgi?id=73917

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-09-13
Reviewed by Simon Hausmann.

Access-key tests were failing due to hardcoded Mac OS X in the
Qt WK2 user agent string. This commit moves the WK1 implementation
to a shared one to be used by both versions.

Source/WebCore:

Adds the shared user agent implementation.

* Target.pri:
* platform/qt/UserAgentQt.cpp: Added.
(WebCore):
(WebCore::UserAgentQt::standardUserAgent):
* platform/qt/UserAgentQt.h: Added.
(WebCore):
(UserAgentQt):

Source/WebKit/qt:

Change QWebPage to use the shared user agent implementation.

* Api/qwebpage.cpp:
(QWebPage::userAgentForUrl):

Source/WebKit2:

Use the shared implementation instead of hardcoding the user agent.

* UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::standardUserAgent):

LayoutTests:

Unskip now passing tests.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Page Popup for Month is non-functional.
commit-queue@webkit.org [Thu, 13 Sep 2012 16:01:46 +0000 (16:01 +0000)]
[BlackBerry] Page Popup for Month is non-functional.
https://bugs.webkit.org/show_bug.cgi?id=96651

Patch by Jessica Cao <jecao@rim.com> on 2012-09-13
Reviewed by Rob Buis.

Hook up support for Month popup.

* WebCoreSupport/DatePickerClient.cpp:
(WebCore::DatePickerClient::generateHTML):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openDatePopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Remove some redundant warning flags and enable a few more warnings.
commit-queue@webkit.org [Thu, 13 Sep 2012 15:31:12 +0000 (15:31 +0000)]
[CMake] Remove some redundant warning flags and enable a few more warnings.
https://bugs.webkit.org/show_bug.cgi?id=96654

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

* Source/cmake/WebKitHelpers.cmake: Remove a few warning flags
which are already enabled by -Wall and -Wextra, remove -W which
looks useless and also enable a few more warnings by removing
their -Wno-foo counterparts which were present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Use RefPtr for storing cairo_surface_t
kenneth@webkit.org [Thu, 13 Sep 2012 15:27:39 +0000 (15:27 +0000)]
[EFL] Use RefPtr for storing cairo_surface_t
https://bugs.webkit.org/show_bug.cgi?id=96647

Reviewed by Simon Hausmann.

Refactoring, covered by existing tests.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::createSurfaceForBackingStore):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::reuse):
(WebCore::RenderThemeEfl::paintThemePart):
* platform/efl/RenderThemeEfl.h:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::surface):
(ThemePartCacheEntry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove updateHoverActiveState to Document.
allan.jensen@nokia.com [Thu, 13 Sep 2012 15:22:37 +0000 (15:22 +0000)]
Move updateHoverActiveState to Document.
https://bugs.webkit.org/show_bug.cgi?id=95858

Reviewed by Antonio Gomes.

RenderLayer::updateHoverActiveState contains the logic that updates hover and active states based on
hit-tests, but hover and active states are document states, and does have any relation to layers other
than documents having atleast one layer.

By moving the function it will be in the same place as other active/hover state maintainace, and we avoid
excessive updates of the state from hit-testing flow threads.

* dom/Document.cpp:
(WebCore::commonAncestor):
(WebCore::Document::updateHoverActiveState):
* dom/Document.h:
(Document):
* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEventForKey):
* rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::nodeAtPoint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):
* rendering/RenderLayer.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::hitTest):
* rendering/RenderView.h:
(RenderView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Gardening after r128393
commit-queue@webkit.org [Thu, 13 Sep 2012 15:16:47 +0000 (15:16 +0000)]
[EFL][WK2] Gardening after r128393
https://bugs.webkit.org/show_bug.cgi?id=96640

Unreviewed gardening.

Corrected expectations for the following files:
fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
fast/dom/HTMLAnchorElement/anchor-download.html

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-13

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make WebKit2 work on Windows with Qt 5
hausmann@webkit.org [Thu, 13 Sep 2012 15:15:52 +0000 (15:15 +0000)]
[Qt] Make WebKit2 work on Windows with Qt 5
https://bugs.webkit.org/show_bug.cgi?id=76776

Reviewed by Tor Arne Vestbø.

WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
that for the GL TextureMapper (it's only built when that feature is set).

* qmake/mkspecs/features/configure.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Ensure that QT is finalized before loading qt_module.prf
vestbo@webkit.org [Thu, 13 Sep 2012 15:10:43 +0000 (15:10 +0000)]
[Qt] Ensure that QT is finalized before loading qt_module.prf

As qt_module.prf does dependency tracking based on the content of the
QT variable. The intermediate WebKit modules modify the variable in
their .pri files, so we have to ensure we've loaded all the modules
before loading qt_module.

Reviewed by Tor Arne Vestbø.
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Remove a lot of C'ism from Ewk_Tiled_Backing_Store
commit-queue@webkit.org [Thu, 13 Sep 2012 15:09:29 +0000 (15:09 +0000)]
[EFL] Remove a lot of C'ism from Ewk_Tiled_Backing_Store
https://bugs.webkit.org/show_bug.cgi?id=96631

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

Remove a lot of C'ism from Ewk_Tiled_Backing_Store and
fix coding style.

* ewk/ewk_tiled_backing_store.cpp:
(_Ewk_Tiled_Backing_Store_Item):
(_Ewk_Tiled_Backing_Store_Data):
(_ewk_tiled_backing_store_updates_process):
(_ewk_tiled_backing_store_flush):
(_ewk_tiled_backing_store_tile_new):
(_ewk_tiled_backing_store_item_resize):
(_ewk_tiled_backing_store_tile_associate):
(_ewk_tiled_backing_store_tile_dissociate):
(_ewk_tiled_backing_store_tile_dissociate_all):
(_ewk_tiled_backing_store_pre_render_request_add):
(_ewk_tiled_backing_store_pre_render_request_del):
(_ewk_tiled_backing_store_pre_render_request_first):
(_ewk_tiled_backing_store_pre_render_request_clear):
(_ewk_tiled_backing_store_pre_render_request_process_single):
(_ewk_tiled_backing_store_item_process_idler_start):
(_ewk_tiled_backing_store_disable_render):
(_ewk_tiled_backing_store_enable_render):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_item_add):
(_ewk_tiled_backing_store_item_smooth_scale_set):
(_ewk_tiled_backing_store_changed):
(_ewk_tiled_backing_store_view_cols_end_del):
(_ewk_tiled_backing_store_view_cols_end_add):
(_ewk_tiled_backing_store_view_row_del):
(_ewk_tiled_backing_store_view_rows_range_del):
(_ewk_tiled_backing_store_view_rows_all_del):
(_ewk_tiled_backing_store_smart_member_del):
(_ewk_tiled_backing_store_smart_member_add):
(_ewk_tiled_backing_store_mem_dbg):
(_ewk_tiled_backing_store_sig_usr):
(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_smart_del):
(_ewk_tiled_backing_store_smart_show):
(_ewk_tiled_backing_store_smart_hide):
(_ewk_tiled_backing_store_recalc_renderers):
(_ewk_tiled_backing_store_smart_calculate_size):
(_ewk_tiled_backing_store_view_dbg):
(_ewk_tiled_backing_store_view_wrap_up):
(_ewk_tiled_backing_store_view_wrap_down):
(_ewk_tiled_backing_store_view_wrap_left):
(_ewk_tiled_backing_store_view_wrap_right):
(_ewk_tiled_backing_store_view_refill):
(_ewk_tiled_backing_store_view_pos_apply):
(_ewk_tiled_backing_store_smart_calculate_offset_force):
(_ewk_tiled_backing_store_smart_calculate_offset):
(_ewk_tiled_backing_store_smart_calculate_pos):
(_ewk_tiled_backing_store_fill_renderers):
(_ewk_tiled_backing_store_smart_calculate):
(ewk_tiled_backing_store_render_cb_set):
(ewk_tiled_backing_store_tile_unused_cache_get):
(_ewk_tiled_backing_store_scroll_full_offset_set_internal):
(ewk_tiled_backing_store_scroll_full_offset_set):
(ewk_tiled_backing_store_scroll_full_offset_add):
(_ewk_tiled_backing_store_zoom_set_internal):
(ewk_tiled_backing_store_zoom_set):
(ewk_tiled_backing_store_zoom_weak_set):
(ewk_tiled_backing_store_fix_offsets):
(ewk_tiled_backing_store_zoom_weak_smooth_scale_set):
(ewk_tiled_backing_store_alpha_set):
(ewk_tiled_backing_store_update):
(ewk_tiled_backing_store_updates_process_pre_set):
(ewk_tiled_backing_store_updates_process_post_set):
(ewk_tiled_backing_store_disabled_update_set):
(ewk_tiled_backing_store_flush):
(ewk_tiled_backing_store_pre_render_tile_add):
(ewk_tiled_backing_store_pre_render_spiral_queue):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):
(ewk_tiled_backing_store_pre_render_cancel):
(ewk_tiled_backing_store_disable_render):
(ewk_tiled_backing_store_enable_render):
* ewk/ewk_tiled_backing_store_private.h:
(_Ewk_Tile_Stats):
(_Ewk_Tile):
* ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_render_cb):
(_ewk_view_tiled_smart_backing_store_add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed fix for: REGRESSION(r128451): It broke inspector/profiler/memory-instrumen...
loislo@chromium.org [Thu, 13 Sep 2012 15:05:29 +0000 (15:05 +0000)]
Unreviewed fix for: REGRESSION(r128451): It broke inspector/profiler/memory-instrumentation-cached-images.html
https://bugs.webkit.org/show_bug.cgi?id=96653

* inspector/profiler/memory-instrumentation-cached-images.html:
* inspector/profiler/memory-instrumentation-cached-images-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: hit test doesn't take iframe scroll position into account
allan.jensen@nokia.com [Thu, 13 Sep 2012 15:03:48 +0000 (15:03 +0000)]
REGRESSION: hit test doesn't take iframe scroll position into account
https://bugs.webkit.org/show_bug.cgi?id=96541

Source/WebCore:

Reviewed by Antonio Gomes.

Convert the coordinate correctly by taking scroll position plus frame
borders and padding into account.

Test: fast/events/touch/touch-inside-iframe-scrolled.html

* rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::nodeAtPoint):

LayoutTests:

Reviewed by Antonio Gomes.
Test written by Rick Byers.

Test that scroll position is taken into account in hit testing.

* fast/events/touch/resources/touch-inside-iframe-scrolled2.html: Added.
* fast/events/touch/touch-inside-iframe-scrolled-expected.txt: Added.
* fast/events/touch/touch-inside-iframe-scrolled.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
hausmann@webkit.org [Thu, 13 Sep 2012 15:03:24 +0000 (15:03 +0000)]
[Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
https://bugs.webkit.org/show_bug.cgi?id=96633

Reviewed by Csaba Osztrogonác.

WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
It's the usual problem and the usual solution is to rename one of the conflicting files.
This patch chooses to rename DRT instead of WTR and MBR.

Fixed include order at the same time to match style guide.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
(messageHandler):
(isOption):
(takeOptionValue):
(printUsage):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe Script run-launcher should support -2 in combination with --efl
kenneth@webkit.org [Thu, 13 Sep 2012 14:59:22 +0000 (14:59 +0000)]
The Script run-launcher should support -2 in combination with --efl
https://bugs.webkit.org/show_bug.cgi?id=96639

Reviewed by Simon Hausmann.

Support running the MiniBrowser then supplied -2 as argument.

* Scripts/run-launcher:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix build of WTR and the QML2 plugin on Windows
hausmann@webkit.org [Thu, 13 Sep 2012 14:58:35 +0000 (14:58 +0000)]
[Qt] Fix build of WTR and the QML2 plugin on Windows
https://bugs.webkit.org/show_bug.cgi?id=96652

Reviewed by Tor Arne Vestbø.

Some components that we build such as WTR or the QML2 plugin include
WebKit2 header files as well as WebKit2's config.h. Only the include
paths of WebKit2 are required for that at the moment (WEBKIT +=
webkit2). Only on Windows WebKit2's config.h also includes
WebCore/config.h, which in turn requires to have WebCore/platform in
your include search path. That in turn means that any component that
wants to use WebKit2 headers also needs the WebCore headers, but only
one Windows. It turns out that for the Qt build we don't need it, so
skip it in our configuration and make the include path requirement
the same across all the platforms we build.

* config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, add my Intel email address to the list.
rakuco@webkit.org [Thu, 13 Sep 2012 14:56:48 +0000 (14:56 +0000)]
Unreviewed, add my Intel email address to the list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] REGRESSION(r128245): It made zillion API tests fail
abecsi@webkit.org [Thu, 13 Sep 2012 14:42:36 +0000 (14:42 +0000)]
[Qt][WK2] REGRESSION(r128245): It made zillion API tests fail
https://bugs.webkit.org/show_bug.cgi?id=96531

Reviewed by Jocelyn Turcotte.

Preferences have to be updated after the drawing area was created
for compositing mode to be set.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] ASSERT failure in InRegionScrollableArea::InRegionScrollableArea
tonikitoo@webkit.org [Thu, 13 Sep 2012 14:29:42 +0000 (14:29 +0000)]
[BlackBerry] ASSERT failure in InRegionScrollableArea::InRegionScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=96645
PR #207307

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>

We use canScrollRenderBox to promote the layer as scrollable instead
of RenderBox::canScrollAndHasScrollableArea (see comment above the former).
We should assert against the former as well.

* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
* Api/InRegionScroller_p.h:
(WebCore):
(InRegionScrollerPrivate):
* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
vestbo@webkit.org [Thu, 13 Sep 2012 14:21:25 +0000 (14:21 +0000)]
[Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS

Reviewed by Ossy.

* qmake/mkspecs/features/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Implement LayoutTestController::layerTreeAsText
kenneth@webkit.org [Thu, 13 Sep 2012 14:15:14 +0000 (14:15 +0000)]
[EFL][DRT] Implement LayoutTestController::layerTreeAsText
https://bugs.webkit.org/show_bug.cgi?id=82294

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Add a support method for getting layerTreeAsText.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::layerTreeAsText):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.

* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::layerTreeAsText):

LayoutTests:

The tests are no longer failing because of missing layerTreeAsText
but due to accelerated compositing not being enabled.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Clear application cache between tests in DumpRenderTree
zandobersek@gmail.com [Thu, 13 Sep 2012 14:03:01 +0000 (14:03 +0000)]
[GTK] Clear application cache between tests in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=96543

Reviewed by Philippe Normand.

Source/WebKit/gtk:

Add a method to the DumpRenderTreeSupportGtk class that upon calling
clears the application cache and vacuums the database file.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::clearApplicationCache):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools:

Call the new DumpRenderTreeSupportGtk method to clear application cache
after each test.

Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
as well. Currently it points to a subdirectory in the layout tests results
directory. At least on the builders this ensures an empty cache directory
with each test run.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 13 Sep 2012 13:46:08 +0000 (13:46 +0000)]
Unreviewed GTK gardening.

Specifying a few slow tests on the debug configuration that pass
when given sufficient time to do so.

Branching expectations for three spellcheck test failures, on release
configuration they time out while on the debug configuration they
have enough time to fail.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: NMI: remove the dependency of platform sources from WebCore header...
loislo@chromium.org [Thu, 13 Sep 2012 13:22:40 +0000 (13:22 +0000)]
Web Inspector: NMI: remove the dependency of platform sources from WebCore header introduced by NMI instrumentation.
https://bugs.webkit.org/show_bug.cgi?id=96367

Reviewed by Yury Semikhatsky.

the target is to move 'platform' specific instrumentation code
from WebCoreMemoryInstrumentation into the new PlatformMemoryInstrumentation.

Drive by fix: New type DOM.Image was introduced.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
* dom/WebCoreMemoryInstrumentation.h:
(WebCoreMemoryTypes):
* inspector/InspectorMemoryAgent.cpp:
(WebCore):
* platform/KURL.cpp:
* platform/KURLGoogle.cpp:
* platform/PlatformMemoryInstrumentation.cpp: Copied from Source/WebCore/platform/graphics/GeneratedImage.cpp.
(WebCore):
* platform/PlatformMemoryInstrumentation.h: Copied from Source/WebCore/platform/graphics/GeneratedImage.cpp.
(WebCore):
(PlatformMemoryTypes):
* platform/SharedBuffer.cpp:
* platform/TreeShared.h:
(WebCore::TreeShared::reportMemoryUsage):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::reportMemoryUsage):
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratedImage.cpp:
(WebCore::GeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratorGeneratedImage.h:
* platform/graphics/Image.cpp:
(WebCore::Image::reportMemoryUsage):
* platform/network/FormData.cpp:
(WebCore::FormData::reportMemoryUsage):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsage):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
vestbo@webkit.org [Thu, 13 Sep 2012 12:39:46 +0000 (12:39 +0000)]
[Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file

Unless it's actually a dependency of the public QtWebKit API.

We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
files with their _PRIVATE equivivalent, but that's likely to break when
someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
clean up the variables in default_post.

This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
longer needed, as it was a workaround for the intermediate libraries ending
up in the prl file. And, since CONFIG -= staticlib was there to support
the explicitlib option, we can remove that too (as well as the exception
for gprof, since it would be empty). If gprof needs tweaks to always link
statically they should go in gprof.prf.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix UIProcess build with Qt on Windows
commit-queue@webkit.org [Thu, 13 Sep 2012 12:37:51 +0000 (12:37 +0000)]
[Qt] Fix UIProcess build with Qt on Windows
https://bugs.webkit.org/show_bug.cgi?id=96635

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-13
Reviewed by Csaba Osztrogonác.

Enabling setShouldCloseConnectionOnProcessTermination on the connection
is something that is only implemented in ConnectionUnix, not
ConnectionWin.cpp, where appears to be built-in functionality.

* UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::WebConnectionToWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: NMI: instrument KURL directly.
loislo@chromium.org [Thu, 13 Sep 2012 12:12:19 +0000 (12:12 +0000)]
Web Inspector: NMI: instrument KURL directly.
https://bugs.webkit.org/show_bug.cgi?id=96624

Reviewed by Yury Semikhatsky.

I replaced traits based instrumentation of KURL with reportMemoryUsage functions.
CString* were also instrumented.

Drive by fix: Instrumentation code in QualifiedName was moved to cpp.

Source/WebCore:

* bindings/v8/V8DOMMap.h:
* dom/Attribute.h:
* dom/QualifiedName.cpp:
(WebCore::QualifiedName::reportMemoryUsage):
(WebCore):
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
* dom/QualifiedName.h:
(QualifiedNameImpl):
(QualifiedName):
* dom/WebCoreMemoryInstrumentation.cpp:
* dom/WebCoreMemoryInstrumentation.h:
(WebCore):
* platform/KURL.cpp:
(WebCore::KURL::reportMemoryUsage):
(WebCore):
* platform/KURL.h:
(KURL):
* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::reportMemoryUsage):
* platform/KURLGooglePrivate.h:
(KURLGooglePrivate):
* platform/KURLWTFURLImpl.h:
(KURLWTFURLImpl):
(WebCore::KURLWTFURLImpl::reportMemoryUsage):

Source/WebKit/chromium:

* tests/MemoryInstrumentationTest.cpp:
(WebCore):
(InstrumentedOwner):
(WebCore::InstrumentedOwner::InstrumentedOwner):
(WebCore::InstrumentedOwner::reportMemoryUsage):
(WebCore::TEST):

Source/WTF:

* wtf/text/CString.h:
(CStringBuffer):
(WTF::CStringBuffer::reportMemoryUsage):
(CString):
(WTF::CString::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
commit-queue@webkit.org [Thu, 13 Sep 2012 12:11:35 +0000 (12:11 +0000)]
[GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=96632

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-09-13
Reviewed by Carlos Garcia Campos.

Fix this by using atk_object_get_n_accessible_children instead of
calling getChildren() from childCount.

* WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
(WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
loop by using atk_object_get_n_accessible_children().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r128375, r128431
commit-queue@webkit.org [Thu, 13 Sep 2012 12:08:45 +0000 (12:08 +0000)]
[EFL] Gardening after r128375, r128431
https://bugs.webkit.org/show_bug.cgi?id=96630

Unreviewed gardening.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-13

* platform/efl/TestExpectations: Unskip fast/overflow/overflow-height-float-not-removed-crash.html.
* platform/efl/fast/table/height-percent-test-vertical-expected.png: Rebase.
* platform/efl/fast/table/height-percent-test-vertical-expected.txt: Ditto.
* platform/efl/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added. Rebase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] New fast/forms/number/number-spinbutton-click-in-iframe.html fails
kkristof@inf.u-szeged.hu [Thu, 13 Sep 2012 12:01:33 +0000 (12:01 +0000)]
[Qt][WK2] New fast/forms/number/number-spinbutton-click-in-iframe.html fails
https://bugs.webkit.org/show_bug.cgi?id=96634

Unreviewed gardening.

* platform/qt-5.0-wk2/Skipped: skip the failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Thu, 13 Sep 2012 11:16:09 +0000 (11:16 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Unskip a now passing test, and add a missing URL.
* platform/qt/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Rebaseline after 128433. It hasn't been updated correctly...
kadam@inf.u-szeged.hu [Thu, 13 Sep 2012 11:13:39 +0000 (11:13 +0000)]
[Qt] Unreviewed gardening. Rebaseline after 128433. It hasn't been updated correctly in the previous revision.

* platform/qt/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate binding test expectation for http://trac.webkit.org/changeset/128400
tkent@chromium.org [Thu, 13 Sep 2012 11:04:43 +0000 (11:04 +0000)]
Update binding test expectation for trac.webkit.org/changeset/128400
https://bugs.webkit.org/show_bug.cgi?id=91933

* bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64Array::getOwnPropertySlotByIndex):
(WebCore::JSFloat64Array::putByIndex):
* bindings/scripts/test/JS/JSFloat64Array.h:
(JSFloat64Array):
* bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(JSTestActiveDOMObject):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlotByIndex):
(WebCore):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(JSTestCustomNamedGetter):
* bindings/scripts/test/JS/JSTestEventConstructor.h:
(JSTestEventConstructor):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::getOwnPropertySlotByIndex):
* bindings/scripts/test/JS/JSTestEventTarget.h:
(JSTestEventTarget):
* bindings/scripts/test/JS/JSTestException.h:
(JSTestException):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterface::putByIndex):
(WebCore):
* bindings/scripts/test/JS/JSTestInterface.h:
(JSTestInterface):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(JSTestMediaQueryListListener):
* bindings/scripts/test/JS/JSTestNamedConstructor.h:
(JSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestNode.h:
(JSTestNode):
* bindings/scripts/test/JS/JSTestObj.h:
(JSTestObj):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(JSTestSerializedScriptValueInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Test expectation update
tkent@chromium.org [Thu, 13 Sep 2012 10:41:00 +0000 (10:41 +0000)]
[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=96628

* platform/chromium/TestExpectations:
calculate-order.html is flaky on Lion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128441 268f45cc-cd09-0410-ab3c-d52691b4dbfc