WebKit-https.git
7 years agoCleanup visibility of some computePreferredLogicalWidths calls
ojan@chromium.org [Tue, 15 Jan 2013 20:39:40 +0000 (20:39 +0000)]
Cleanup visibility of some computePreferredLogicalWidths calls
https://bugs.webkit.org/show_bug.cgi?id=106933

Reviewed by Levi Weintraub.

No need for these to be public.

* rendering/RenderBox.h:
(WebCore::RenderBox::computePreferredLogicalWidths):
This should never get called in practice. Add an assert to that effect.

* rendering/RenderGrid.h:
(RenderGrid):
* rendering/RenderReplica.h:
(RenderReplica):
* rendering/RenderScrollbarPart.h:
(RenderScrollbarPart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenaming CleanWorkingDirectory step to DiscardLocalChanges to make
commit-queue@webkit.org [Tue, 15 Jan 2013 20:03:10 +0000 (20:03 +0000)]
Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
functionality match the name.
https://bugs.webkit.org/show_bug.cgi?id=106870

Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-15
Reviewed by Adam Barth.

* Scripts/webkitpy/tool/commands/download.py:
(Clean):
(Update):
(Build):
(BuildAndTest):
(CheckStyle):
(BuildAttachment):
(BuildAndTestAttachment):
(AbstractPatchApplyingCommand):
(ApplyWatchList):
(AbstractPatchLandingCommand):
(CreateRollout):
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
(CleanWorkingDirectory.options):
(CleanWorkingDirectory.run):
* Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
* Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
* Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Filters] brightness() function doesn't work as specified
krit@webkit.org [Tue, 15 Jan 2013 20:02:20 +0000 (20:02 +0000)]
[CSS Filters] brightness() function doesn't work as specified
https://bugs.webkit.org/show_bug.cgi?id=106674

Source/WebCore:

Reviewed by Dean Jackson.

The brightness filter implementation modified the intercept instead of the slope on
the feComponentTransfer function. The passed amount acts as multiplier for each
color chanel now.

Existing tests cover the changes and were updated.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseBuiltinFilterArguments):
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setFilters):
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):

LayoutTests:

Negative brightness values are possible but are meaningless. Modify the tests
to mainly use positive amounts for brightness tests.

Reviewed by Dean Jackson.

* css3/filters/effect-brightness-clamping-hw.html:
* css3/filters/effect-brightness-hw.html:
* css3/filters/effect-combined-hw.html:
* css3/filters/effect-combined.html:
* css3/filters/multiple-filters-invalidation.html:
* css3/filters/null-effect-check.html:
* css3/filters/script-tests/filter-property-parsing-invalid.js:
* css3/filters/script-tests/filter-property-parsing.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Autotools] Add support for WebKit2-only builds
zandobersek@gmail.com [Tue, 15 Jan 2013 19:49:50 +0000 (19:49 +0000)]
[Autotools] Add support for WebKit2-only builds
https://bugs.webkit.org/show_bug.cgi?id=106889

Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-01-15
Reviewed by Gustavo Noronha Silva.

.:

* GNUmakefile.am: Only copy the WebKit1 documentation into the destination
directory if building WebKit1.
* configure.ac: Add a configuration option for disabling the WebKit1 build.
Only conditionally copy WebKit1-specific targets from the input files. Some
small style changes to the WebKit2 configuration flag included as well.

Source/WebKit/gtk:

* GNUmakefile.am: Only build the WebKit1-specific targets if actually
building WebKit1. This puts the libwebkitgtk library, the pkg-config file
and the WebKit1-specific unit tests under the ENABLE_WEBKIT1 Automake
conditional.

Tools:

* GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
* Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
building the GTK port through build-webkit.
* Scripts/webkitdirs.pm:
(buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
arguments when not building WebKit1.
(buildGtkProject): Pass along the information on whether to build WebKit1 when building
through the Autotools build system.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
zandobersek@gmail.com [Tue, 15 Jan 2013 19:47:31 +0000 (19:47 +0000)]
[GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
https://bugs.webkit.org/show_bug.cgi?id=106197

Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-01-15
Reviewed by Martin Robinson.

Source/WebCore:

No new tests - existing layout tests are being unskipped, only a few fail
(but their failures are of cross-platform nature).

* GNUmakefile.features.am.in: Add feature defines for all three features.
They are disabled by default for now.
* GNUmakefile.list.am: Add missing build targets.
* bindings/gobject/GNUmakefile.am: Ditto.
* bindings/js/JSPerformanceEntryCustom.cpp: Added the necessary custom bindings.
Mimics the custom V8 bindings.
(WebCore):
(WebCore::toJS):

Tools:

* Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
features. Enable them on GTK, meaning they will be enabled in development builds
(i.e. when building with build-webkit).

LayoutTests:

Unskip related tests, add a few expectations for still-failing tests.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Enable CSS Image Resolution feature
zandobersek@gmail.com [Tue, 15 Jan 2013 19:46:01 +0000 (19:46 +0000)]
[GTK] Enable CSS Image Resolution feature
https://bugs.webkit.org/show_bug.cgi?id=99038

Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-01-15
Reviewed by Gustavo Noronha Silva.

Tools:

Enable the CSS Image Resolution feature for the development
builds of the GTK port.

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Remove the failure expectation for the fast/css/image-resolution directory,
the single layout test inside it now passes.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Stop passing the unstable features flag to configure script when using build...
zandobersek@gmail.com [Tue, 15 Jan 2013 19:42:41 +0000 (19:42 +0000)]
[GTK] Stop passing the unstable features flag to configure script when using build-webkit
https://bugs.webkit.org/show_bug.cgi?id=106579

Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-01-15
Reviewed by Gustavo Noronha Silva.

The --enable-unstable-features flag is not required to be passed anymore
to the configure script as it was removed in r138252.

* Scripts/webkitdirs.pm:
(buildAutotoolsProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Autotools] Unify JavaScriptCore sources list, regardless of target OS
zandobersek@gmail.com [Tue, 15 Jan 2013 19:41:02 +0000 (19:41 +0000)]
[Autotools] Unify JavaScriptCore sources list, regardless of target OS
https://bugs.webkit.org/show_bug.cgi?id=106007

Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-01-15
Reviewed by Gustavo Noronha Silva.

Include the Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp target
in the general sources list as it is guarded by the ENABLE_EXECUTABLE_ALLOCATOR_FIXED
feature define. This define is only used on 64-bit architecture and indirectly depends
on enabling either JIT or YARR JIT feature. Both of these defines are disabled on
Windows OS when using 64-bit architecture so there's no need to add this target to
sources only when the target OS is Windows.

* GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
tony@chromium.org [Tue, 15 Jan 2013 19:35:07 +0000 (19:35 +0000)]
[chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.

* Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
* Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
(TestHttpServer.test_win32_start_and_stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 15 Jan 2013 19:25:38 +0000 (19:25 +0000)]
Unreviewed GTK gardening.

Remove a few failure expectations for tests that now pass.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnprefixed transitionend event doesn't seem to be implemented, which breaks many...
alexis@webkit.org [Tue, 15 Jan 2013 19:17:42 +0000 (19:17 +0000)]
Unprefixed transitionend event doesn't seem to be implemented, which breaks many sites
https://bugs.webkit.org/show_bug.cgi?id=105647

Reviewed by Julien Chaffraix.

Source/WebCore:

Add support for transitionend event delivery as part as the unprefixing
work on CSS Transitions. This patch adds some code in EventTarget to
figure out if the current event to dispatch has a prefixed version or
not. Then from the list of listeners we deduce which event should be delivered
(prefixed or unprefixed).

In the case of the CSS Transitions, WebKit will now behave as follow :
if an event listener is attached to the prefixed version of the
transition end event then only the prefixed event will be send.
If an event listener is attached to the unprefixed version
of the transition end event then only the unprefixed event will be
send. If there are event listeners on both unprefixed and prefixed
events then only the unprefixed event will be send.

The behavior was discussed here :
http://lists.webkit.org/pipermail/webkit-dev/2013-January/023301.html.

Tests: transitions/transition-end-event-unprefixed-01.html
       transitions/transition-end-event-unprefixed-02.html

* dom/Document.cpp:
(WebCore::Document::addListenerTypeIfNeeded): Register the prefixed
listener too as transitionend listeners so that we properly dispatch
events for them.
* dom/EventNames.h:
(WebCore): Add the new transitionend name.
* dom/EventTarget.cpp:
(WebCore::createMatchingPrefixedEvent):
(WebCore::prefixedType):
(WebCore::EventTarget::fireEventListeners): Find out if somebody is
listening for unprefixed events, if so we always send the unprefixed
event, if not then we create a prefixed event and send it.
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::sendTransitionEvent): Always create by
default unprefixed events.

LayoutTests:

Cover that event delivery is correct : we received unprefixed events.

* transitions/transition-end-event-helpers.js:
(recordTransitionEndEvent):
* transitions/transition-end-event-unprefixed-01-expected.txt: Added.
* transitions/transition-end-event-unprefixed-01.html: Added.
* transitions/transition-end-event-unprefixed-02-expected.txt: Added.
* transitions/transition-end-event-unprefixed-02.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpstream iOS changes for ANGLE project
ddkilzer@apple.com [Tue, 15 Jan 2013 19:17:09 +0000 (19:17 +0000)]
Upstream iOS changes for ANGLE project
<http://webkit.org/b/106913>

Reviewed by Joseph Pecoraro.

* ANGLE.xcodeproj/project.pbxproj:
- Use $(INSTALL_PATH_PREFIX) with CopyFiles build phase paths.
- Add iOS.xcconfig to project.
* Configurations/ANGLE.xcconfig:
- Use INSTALL_PATH_ACTUAL instead of INSTALL_PATH.  (See below.)
- Use $(INSTALL_PATH_PREFIX) with PUBLIC_HEADERS_FOLDER_PATH.
* Configurations/Base.xcconfig:
- Include iOS.xcconfig.
- Add per-platform values for GCC_ENABLE_OBJC_GC and
  GCC_MODEL_TUNING.
- Define INSTALL_PATH when building for macosx SDK.
* Configurations/iOS.xcconfig: Add.  Note that missing include
files are simply ignored without an error by Xcode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake AtomicMarkupTokenBase use a bare UChar* for external characters
tonyg@chromium.org [Tue, 15 Jan 2013 19:06:25 +0000 (19:06 +0000)]
Make AtomicMarkupTokenBase use a bare UChar* for external characters
https://bugs.webkit.org/show_bug.cgi?id=106919

Reviewed by Eric Seidel.

This allows an arbitrary backing for external characters which is necessary for the threaded HTML parser.

No new tests because no new functionality.

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):
* xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::characters):
(AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::charactersLength):
(WebCore::AtomicMarkupTokenBase::clearExternalCharacters):
* xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Manual zoom propagates to next page load
zhajiang@rim.com [Tue, 15 Jan 2013 19:00:28 +0000 (19:00 +0000)]
[BlackBerry] Manual zoom propagates to next page load
https://bugs.webkit.org/show_bug.cgi?id=106914

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Yong Li.
Internally reviewed by Eli Fidler and Jakob Petsovits.

PR: 280481
During load committed, the web page scale was reset. However, UI thread
still kept the old scale in UserInterfaceViewportAccessor so that it
blitted the contents at the old scale although WebKit thread could
update the UI thread scale later when finished the load.
We should update the scale of the UI thread right after we reset it in
WebKit thread to keep them in sync.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::resetScales):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoANGLE should build with -Wshorten-64-to-32
ddkilzer@apple.com [Tue, 15 Jan 2013 18:56:19 +0000 (18:56 +0000)]
ANGLE should build with -Wshorten-64-to-32
<http://webkit.org/b/106798>
<http://code.google.com/p/angleproject/issues/detail?id=396>

Reviewed by Kenneth Russell.

Most changes below are simply to document issues with #pragma
statements per request by upstream.  The change to osinclude.h
is the only bug fix, which defines OS_TLSIndex in terms of
pthread_key_t instead of unsigned int since pthread_key_t is a
64-bit value on 64-bit Mac OS X.

* Configurations/Base.xcconfig: Enable -Wshorten-64-to-32 by
setting GCC_WARN_64_TO_32_BIT_CONVERSION to YES.
* src/compiler/Intermediate.cpp:
(TIntermTraverser::hash): Add #pragmas for clang to ignore
-Wshorten-64-to-32 warning.
* src/compiler/MapLongVariableNames.cpp:
(LongNameMap::Size): Ditto.
* src/compiler/ShaderLang.cpp:
(getVariableInfo): Ditto.
(ShGetInfo): Ditto.
* src/compiler/ValidateLimitations.cpp:
(ValidateLimitations::validateFunctionCall): Ditto.
* src/compiler/glslang.l: Ditto.
* src/compiler/glslang_lex.cpp: Ditto.
* src/compiler/osinclude.h: Change type of OS_TLSIndex to
pthread_key_t.  Define OS_INVALID_TLS_INDEX by using
static_cast<OS_TLSIndex>(-1).
* src/compiler/preprocessor/Input.cpp:
(pp::Input::Input): Add #pragmas for clang to ignore
-Wshorten-64-to-32 warning.
* src/compiler/preprocessor/Tokenizer.cpp: Ditto.
* src/compiler/preprocessor/Tokenizer.l: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 15 Jan 2013 18:54:27 +0000 (18:54 +0000)]
Unreviewed GTK gardening.

Adding failure/crash/missing expectations for accessibility tests after
r139444, r139534 and r139663.
Adding platform-specific baselines for two scrolling coordinator tests that are
required after r139686.

* platform/gtk/TestExpectations:
* platform/gtk/scrollingcoordinator: Added.
* platform/gtk/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
* platform/gtk/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMicrodata: propertiesCollection[name] should return undefined if item doesn't have...
arko@motorola.com [Tue, 15 Jan 2013 18:49:17 +0000 (18:49 +0000)]
Microdata: propertiesCollection[name] should return undefined if item doesn't have a property named 'name'
https://bugs.webkit.org/show_bug.cgi?id=106849

Reviewed by Kentaro Hara.

Source/WebCore:

We should return undefined if hasNamedItem() is false.

Test: fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html

* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::V8HTMLCollection::namedPropertyGetter):

LayoutTests:

* fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name-expected.txt: Added.
* fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Fix build after r139665
commit-queue@webkit.org [Tue, 15 Jan 2013 18:34:07 +0000 (18:34 +0000)]
[GTK] Fix build after r139665
https://bugs.webkit.org/show_bug.cgi?id=106917

Patch by Michael Pruett <michael@68k.org> on 2013-01-15
Reviewed by Dean Jackson.

* GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=106855
eae@chromium.org [Tue, 15 Jan 2013 18:22:11 +0000 (18:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=106855
https://bugs.webkit.org/show_bug.cgi?id=106855

Reviewed by Levi Weintraub.

Speed up zoomed-offset-size.html test and remove SLOW modifier
from TestExpectations.

* fast/images/zoomed-offset-size-expected.txt:
* fast/images/zoomed-offset-size.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove parent pointer from TreeShared to subclass
antti@apple.com [Tue, 15 Jan 2013 18:11:30 +0000 (18:11 +0000)]
Move parent pointer from TreeShared to subclass
https://bugs.webkit.org/show_bug.cgi?id=106910

Reviewed by Darin Adler.

This simplifies both TreeShared and clients, and makes code dealing with parents more understandable in general.

* dom/Document.h:
(WebCore::Node::Node):
* dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
* dom/Node.h:

    Add m_parentOrHostNode variable (matching the accessor names).

(Node):
(WebCore::Node::hasTreeSharedParent):
(WebCore::Node::parentNode):
(WebCore::Node::setParentOrHostNode):
(WebCore::Node::parentOrHostNode):
* platform/TreeShared.h:
(WebCore):
(WebCore::TreeShared::TreeShared):
(WebCore::TreeShared::deref):

    Call subclass hasTreeSharedParent() to figure out if it is time to delete.

(TreeShared):

    Remove parent pointer and accessors.
    Remove ParentNodeType template parameter.
    Remove now unnecessay reportMemoryUsage().

(WebCore::adopted):
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::SVGElementInstance):
* svg/SVGElementInstance.h:

    Add m_parentInstance variable.

(WebCore::SVGElementInstance::setParentOrHostNode):
(WebCore::SVGElementInstance::parentNode):
(SVGElementInstance):
(WebCore::SVGElementInstance::hasTreeSharedParent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow tiled WKViews to have transparent backgrounds
simon.fraser@apple.com [Tue, 15 Jan 2013 18:10:28 +0000 (18:10 +0000)]
Allow tiled WKViews to have transparent backgrounds
https://bugs.webkit.org/show_bug.cgi?id=106400

Source/WebCore:

Reviewed by Anders Carlsson.

When WKViews were set to have transparent backgrounds, they still
obscured content behind the view, for several reasons.

First, when in tiled scrolling mode, WKView set the background
of its layer to opaque white. Fix by using the clearColor (effectively
removing the background color) if the view has a non-opaque background.

Second, RenderLayerBacking just looked at FrameViews's isTransparent()
when deciding to make TileCache tiles non-opaque, but it also needs to
consider FrameViews with a non-opaque base background color. The
same logic was necessary to avoid setting an opaque white background
color on the TileCache layer.

Finally, for views with non-opaque backgrounds, we don't want to display
linen, so RenderLayerCompositor::requiresOverhangAreasLayer() was changed
to return false in that case.

View transparency is not testable in layout tests.

* page/FrameView.cpp:
(WebCore::FrameView::hasOpaqueBackground):
* page/FrameView.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::updateBackgroundColor):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):

Source/WebKit2:

Reviewed by Anders Carlsson.

When WKViews were set to have transparent backgrounds, they still
obscured content behind the view, for several reasons.

First, when in tiled scrolling mode, WKView set the background
of its layer to opaque white. Fix by using the clearColor (effectively
removing the background color) if the view has a non-opaque background.

Second, RenderLayerBacking just looked at FrameViews's isTransparent()
when deciding to make TileCache tiles non-opaque, but it also needs to
consider FrameViews with a non-opaque base background color. The
same logic was necessary to avoid setting an opaque white background
color on the TileCache layer.

Finally, for views with non-opaque backgrounds, we don't want to display
linen, so RenderLayerCompositor::requiresOverhangAreasLayer() was changed
to return false in that case.

* UIProcess/API/mac/WKView.mm:
(-[WKView updateLayer]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderView does not need to override computePreferredLogicalWidth
ojan@chromium.org [Tue, 15 Jan 2013 17:54:22 +0000 (17:54 +0000)]
RenderView does not need to override computePreferredLogicalWidth
https://bugs.webkit.org/show_bug.cgi?id=106852

Reviewed by Levi Weintraub.

Calling minPreferredLogicalWidth calls computePreferredLogicalWidth,
which happens a few lines later in layoutWithFlattening. No need
to call it explicitly.

* rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::layoutWithFlattening):
* rendering/RenderView.cpp:
* rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Marking the deferred version of
leviw@chromium.org [Tue, 15 Jan 2013 17:50:55 +0000 (17:50 +0000)]
Unreviewed gardening. Marking the deferred version of
fast/images/zoomed-offset-size.html as slow.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Adding Michael Pruett as contributor.
jsbell@chromium.org [Tue, 15 Jan 2013 17:24:04 +0000 (17:24 +0000)]
Unreviewed. Adding Michael Pruett as contributor.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, remove file that was accidentally added to the wrong patch.
vsevik@chromium.org [Tue, 15 Jan 2013 17:13:07 +0000 (17:13 +0000)]
Unreviewed, remove file that was accidentally added to the wrong patch.

* inspector/front-end/FileSystemWorkspaceProvider.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect
fmalita@chromium.org [Tue, 15 Jan 2013 16:57:55 +0000 (16:57 +0000)]
[Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect
https://bugs.webkit.org/show_bug.cgi?id=106898

Reviewed by Stephen White.

Source/WebCore:

Since drawRRect() doesn't cover the whole bounding rect, it needs to pass a didDrawBounded
notification down to the opaque region tracker (instead of didDrawRect as it currently
does).

Test: platform/chromium/compositing/rounded-corners.html

* platform/graphics/skia/PlatformContextSkia.h:
(WebCore::PlatformContextSkia::drawRRect):

Source/WebKit/chromium:

* tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
(WebCore):

LayoutTests:

* platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.png: Added.
* platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt: Added.
* platform/chromium/TestExpectations:
* platform/chromium/compositing/rounded-corners.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Update my email addresses.
victor@rosedu.org [Tue, 15 Jan 2013 16:35:41 +0000 (16:35 +0000)]
Unreviewed. Update my email addresses.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Waiting on the gdb process will lead to deadlock
zandobersek@gmail.com [Tue, 15 Jan 2013 16:03:37 +0000 (16:03 +0000)]
[GTK] Waiting on the gdb process will lead to deadlock
https://bugs.webkit.org/show_bug.cgi?id=106906

Reviewed by Philippe Normand.

Use communicate() rather than wait() on the Popen object that's running the gdb
command. This avoids the deadlock that occurs on the GTK builders.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._get_gdb_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] WebGL does not require accelerated compositing
allan.jensen@digia.com [Tue, 15 Jan 2013 16:01:56 +0000 (16:01 +0000)]
[Qt] WebGL does not require accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=106892

Reviewed by Jocelyn Turcotte.

Allow the creation of WebGL canvas even when accelerated compositing is not enabled.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed failing test skip.
vsevik@chromium.org [Tue, 15 Jan 2013 15:57:41 +0000 (15:57 +0000)]
Unreviewed failing test skip.
https://bugs.webkit.org/show_bug.cgi?id=106883

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: refactor DefaultTextEditor's paintLine method
commit-queue@webkit.org [Tue, 15 Jan 2013 15:50:11 +0000 (15:50 +0000)]
Web Inspector: refactor DefaultTextEditor's paintLine method
https://bugs.webkit.org/show_bug.cgi?id=106893

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-15
Reviewed by Pavel Feldman.

Move render ranges functionality out of paintLine method into separate subroutine.

No new tests: no change in behaviour.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._renderRanges): Added.
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agodisplay:inline's hover behavior is not applied to ::before and ::after pseudo elements
commit-queue@webkit.org [Tue, 15 Jan 2013 15:42:55 +0000 (15:42 +0000)]
display:inline's hover behavior is not applied to ::before and ::after pseudo elements
https://bugs.webkit.org/show_bug.cgi?id=91723

Patch by Elliott Sprehn <esprehn@gmail.com> on 2013-01-15
Reviewed by Eric Seidel.

Source/WebCore:

When hovering over the anonymous text renderers inside :before and :after
we would correctly detect a hit in InlineTextBox::nodeAtPoint, but would
then fail to set the correct node for the hit test because in
RenderObject::updateHitTestResult node() is null. Instead we should walk
up the render tree to the PseudoElement and treat it as if we hit that.

Test: fast/css-generated-content/hover-inline.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::updateHitTestResult):

LayoutTests:

Add a test that hovering generated content inside an inline element causes
the element to become hovered.

* fast/css-generated-content/hover-inline-expected.txt: Added.
* fast/css-generated-content/hover-inline.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGraphicsSurface: Canvas with WebGL content is painted off by one pixel
zeno.albisser@digia.com [Tue, 15 Jan 2013 15:41:34 +0000 (15:41 +0000)]
GraphicsSurface: Canvas with WebGL content is painted off by one pixel
https://bugs.webkit.org/show_bug.cgi?id=106446

When painting to TextureMapper the provided targetRect is in contents
coordinate system. This leads to an off by one pixel error when painting
outlines of 1px.
This needs to be taken into account in the transformation matrix
and in the TextureMapperGL::drawTexture call.

Test: fast/canvas/webgl/webgl-composite-modes.html

Reviewed by Noam Rosenthal.

* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
* platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] media/track/track-css-cue-lifetime.html Win7 dbg times out since r139562
commit-queue@webkit.org [Tue, 15 Jan 2013 15:12:11 +0000 (15:12 +0000)]
[Chromium] media/track/track-css-cue-lifetime.html Win7 dbg times out since r139562
https://bugs.webkit.org/show_bug.cgi?id=106853

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-01-15
Reviewed by Eric Carlson.

The amount of seeks may be reduced significantly since they may be slow.

* media/track/track-css-cue-lifetime-expected.txt:
* media/track/track-css-cue-lifetime.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Limit the number of frames printed out when backtracing with gdb
zandobersek@gmail.com [Tue, 15 Jan 2013 15:10:14 +0000 (15:10 +0000)]
[GTK] Limit the number of frames printed out when backtracing with gdb
https://bugs.webkit.org/show_bug.cgi?id=106901

Reviewed by Philippe Normand.

Printing an unlimited number of frames when dumping the gdb backtracing
output can cause timeouts in the builders. This patch limits the number
of frames that are printed out to 1024.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._get_gdb_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Make an Isolate parameter mandatory in SerializedScriptValue methods
haraken@chromium.org [Tue, 15 Jan 2013 13:49:57 +0000 (13:49 +0000)]
[V8] Make an Isolate parameter mandatory in SerializedScriptValue methods
https://bugs.webkit.org/show_bug.cgi?id=106800

Reviewed by Adam Barth.

SerializedScriptValue methods are used by both V8 bindings
and WebCore. So they should support both an Isolate-version
method and an non-Isolate version method.

There are two ways to accomplish that:

[1] Use an optional Isolate parameter.

[2] Implement two versions and delegate the non-Isolate
version method to the Isolate version method.

I would prefer the approach [2], because I'd like to statically
make sure that we never pass a 0 Isolate. If we take the approach
[1], we need to insert ASSERT(isolate) here and there.

This patch implements the approach [2].

No tests. No change in behavior.

* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
(WebCore):
(WebCore::SerializedScriptValue::nullValue):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::SerializedScriptValue):
* bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS] Rename the enum, from "ETextAlignLast" to "TextAlignLast"
commit-queue@webkit.org [Tue, 15 Jan 2013 13:31:49 +0000 (13:31 +0000)]
[CSS] Rename the enum, from "ETextAlignLast" to "TextAlignLast"
https://bugs.webkit.org/show_bug.cgi?id=106887

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2013-01-15
Reviewed by Alexis Menard.

No new tests are added since there is no behavior changes.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextAlignLast):
* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Fixing crashing bug in MediaStream
tommyw@google.com [Tue, 15 Jan 2013 10:45:04 +0000 (10:45 +0000)]
MediaStream API: Fixing crashing bug in MediaStream
https://bugs.webkit.org/show_bug.cgi?id=106886

Reviewed by Eric Seidel.

Source/WebCore:

Fixing crashing bug during destruction.

No new tests needed.

* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::contextDestroyed):

LayoutTests:

Removing obsolete exception.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][CSS Shaders] Make custom filter render in Wk1 mode
allan.jensen@digia.com [Tue, 15 Jan 2013 10:01:57 +0000 (10:01 +0000)]
[Qt][CSS Shaders] Make custom filter render in Wk1 mode
https://bugs.webkit.org/show_bug.cgi?id=101532

Reviewed by Noam Rosenthal.

Handle ValidatedCustomFilterOperations which are used by WebKit1. To keep the cache of compiled programs working,
the cache has been updated to use CustomFilterProgramInfo as a hash key. CustomFilterProgramInfo is an existing
class specifically designed for this purpose.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::getPassesRequiredForFilter):
(WebCore::TextureMapperGL::removeCachedCustomFilterProgram):
(WebCore::TextureMapperGL::drawUsingCustomFilter):
(WebCore::BitmapTextureGL::applyFilters):
* platform/graphics/texmap/TextureMapperGL.h:
(TextureMapperGL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening
ossy@webkit.org [Tue, 15 Jan 2013 09:51:00 +0000 (09:51 +0000)]
[Qt] Gardening

Skip failing tests after r139609.
https://bugs.webkit.org/show_bug.cgi?id=104909

Skip failing inspector/editor/text-editor-formatter.html test.
https://bugs.webkit.org/show_bug.cgi?id=106883

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2013-01-15
Reviewed by Csaba Osztrogon√°c.

* platform/qt/TestExpectations:
* platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added after r139686.
* platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added after r139686.
* platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added after r139686.
* platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added after r139686.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Canvas] introduce CallArgument type into the protocol
aandrey@chromium.org [Tue, 15 Jan 2013 09:46:29 +0000 (09:46 +0000)]
Web Inspector: [Canvas] introduce CallArgument type into the protocol
https://bugs.webkit.org/show_bug.cgi?id=106640

Reviewed by Yury Semikhatsky.

Source/WebCore:

CallArgument type abstraction to describe arguments of a canvas context call.
Drive-by: Introduce a CanvasContext to fix the wrong contextId value in the protocol.
The contextId should point to the Resource that represents a context (2D or 3D canvas).

* inspector/InjectedScriptCanvasModuleSource.js:
(.):
* inspector/Inspector.json:
* inspector/front-end/CanvasProfileView.js:

LayoutTests:

Replaced hacky stub with actual Cache implementation.

* inspector/profiler/webgl/webgl-profiler-get-error.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow zero values as results from the runFunction.
dominicc@chromium.org [Tue, 15 Jan 2013 09:42:25 +0000 (09:42 +0000)]
Allow zero values as results from the runFunction.
https://bugs.webkit.org/show_bug.cgi?id=102500

Reviewed by Kentaro Hara.

DOM/DOMWalk.js fails on the Chromium Win perf bot because one or
more parts of the test usually return zero at some point.

* resources/runner.js: Accept merely non-negative results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix ImageDiff's image format conversion
abecsi@webkit.org [Tue, 15 Jan 2013 09:33:54 +0000 (09:33 +0000)]
[Qt] Fix ImageDiff's image format conversion
https://bugs.webkit.org/show_bug.cgi?id=106880

Reviewed by Csaba Osztrogon√°c.

Besides actually doing the conversion this also silences the suspicious warning:
"ignoring return value of function declared with warn_unused_result attribute".

* ImageDiff/qt/ImageDiff.cpp:
(main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
copy of the image in the given format and does not alter the image itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Support inspector file system access with isolated file system through...
vsevik@chromium.org [Tue, 15 Jan 2013 09:06:01 +0000 (09:06 +0000)]
Web Inspector: Support inspector file system access with isolated file system through InspectorFrontendHost.
https://bugs.webkit.org/show_bug.cgi?id=105727

Reviewed by Pavel Feldman.

Source/WebCore:

File system access through isolated file system is implemented in inspector.
File system access requests are sent through InspectorFrontendHost.
Introduced IsolatedFileSystemModel encapsulating file system access logic.
Introduced FileSystemMapping that provides mapping between workspace uris and file system pathes.
DOMFileSystem.createIsolatedFileSystem modified to accept optional registeredName parameter.

* Modules/filesystem/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::createIsolatedFileSystem):
* Modules/filesystem/DOMFileSystem.h:
(DOMFileSystem):
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):
* inspector/InspectorFrontendClientLocal.h:
(WebCore::InspectorFrontendClientLocal::supportsFileSystems):
(WebCore::InspectorFrontendClientLocal::requestFileSystems):
(WebCore::InspectorFrontendClientLocal::addFileSystem):
(WebCore::InspectorFrontendClientLocal::removeFileSystem):
(InspectorFrontendClientLocal):
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::supportsFileSystems):
(WebCore):
(WebCore::InspectorFrontendHost::requestFileSystems):
(WebCore::InspectorFrontendHost::addFileSystem):
(WebCore::InspectorFrontendHost::removeFileSystem):
(WebCore::InspectorFrontendHost::isolatedFileSystem):
* inspector/InspectorFrontendHost.h:
(WebCore):
(InspectorFrontendHost):
* inspector/InspectorFrontendHost.idl:
* inspector/compile-front-end.py:
* inspector/front-end/FileSystemMapping.js: Added.
* inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.fileSystemsLoaded):
(InspectorFrontendAPI.fileSystemRemoved):
(InspectorFrontendAPI.fileSystemAdded):
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.supportsFileSystems):
(.WebInspector.InspectorFrontendHostStub.prototype.requestFileSystems):
(.WebInspector.InspectorFrontendHostStub.prototype.addFileSystem):
(.WebInspector.InspectorFrontendHostStub.prototype.removeFileSystem):
(.WebInspector.InspectorFrontendHostStub.prototype.isolatedFileSystem):
* inspector/front-end/IsolatedFileSystemModel.js: Added.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/externs.js:
(DOMFileSystem):
(InspectorFrontendHostAPI.prototype.supportsFileSystems):
(InspectorFrontendHostAPI.prototype.requestFileSystems):
(InspectorFrontendHostAPI.prototype.addFileSystem):
(InspectorFrontendHostAPI.prototype.removeFileSystem):
(InspectorFrontendHostAPI.prototype.isolatedFileSystem):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

Source/WebKit/chromium:

File system access methods plumbing made for Chromium.

* public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::requestFileSystems):
(WebKit::WebDevToolsFrontendClient::addFileSystem):
(WebKit::WebDevToolsFrontendClient::removeFileSystem):
(WebDevToolsFrontendClient):
* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::supportsFileSystems):
(WebKit):
(WebKit::InspectorFrontendClientImpl::requestFileSystems):
(WebKit::InspectorFrontendClientImpl::addFileSystem):
(WebKit::InspectorFrontendClientImpl::removeFileSystem):
* src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WebGL] Add error handling to carefully manage Window backing pixmaps.
commit-queue@webkit.org [Tue, 15 Jan 2013 08:56:42 +0000 (08:56 +0000)]
[EFL][WebGL] Add error handling to carefully manage Window backing pixmaps.
https://bugs.webkit.org/show_bug.cgi?id=106582

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-01-15
Reviewed by Kenneth Rohde Christiansen.

We use XCompositeNameWindowPixmap to create a pixmap that serves as a reference to
the off-screen storage for a Window Handle. We expect the Window to be valid and
the created glx pixmap to be a valid drawable. This may not be true always.
This patch adds support for X Error checks and handles the generated errors.

Covered by existing WebGL layout tests.

* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore):
(WebCore::handleXPixmapCreationError):
(ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::~ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::isValidOperation):
Helper Class to catch XErrors.

(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap): Added support to check and handle generated XErrors.
(WebCore::GraphicsSurfacePrivate::findFBConfigWithAlpha):
(WebCore::GraphicsSurfacePrivate::clear): Destroys GL Resources.
(GraphicsSurfacePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] [WebGL] Minor cleanup in PlatformContext.
commit-queue@webkit.org [Tue, 15 Jan 2013 08:54:59 +0000 (08:54 +0000)]
[EFL] [WebGL] Minor cleanup in PlatformContext.
https://bugs.webkit.org/show_bug.cgi?id=106758

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-01-15
Reviewed by Kenneth Rohde Christiansen.

We currently have different implementations of CurrentContextWrapper for EGL and GLX.
This patch cleans up the code to use same implementation for both the backends.

* platform/graphics/opengl/GLPlatformContext.cpp:
(GLCurrentContextWrapper):
(WebCore::GLCurrentContextWrapper::GLCurrentContextWrapper):
(WebCore::GLCurrentContextWrapper::~GLCurrentContextWrapper):

Common implementation for both EGL and GLX.
(WebCore::createOffScreenContext):
(WebCore::GLPlatformContext::createContext):
* platform/graphics/surfaces/egl/EGLContext.cpp:
* platform/graphics/surfaces/egl/EGLContext.h:
* platform/graphics/surfaces/glx/GLXContext.h:

Removed code related to CurrentContextWrapper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoplatform/mac/accessibility/progressbar.html fails on Mac WK1 and WK2
rniwa@webkit.org [Tue, 15 Jan 2013 08:30:34 +0000 (08:30 +0000)]
platform/mac/accessibility/progressbar.html fails on Mac WK1 and WK2
https://bugs.webkit.org/show_bug.cgi?id=106850

Reviewed by Chris Fleizach.

The bug was caused by some callers of supportsFocus directly calling that of Node.
Fixed the bug by calling HTMLElement's so that the virtual function on Element gets
called as needed.

* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::supportsFocus):
* html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::supportsFocus):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::supportsFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] move remaining methods that just set a boolean flag to TestRunner library
jochen@chromium.org [Tue, 15 Jan 2013 08:19:57 +0000 (08:19 +0000)]
[chromium] move remaining methods that just set a boolean flag to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106823

Reviewed by Darin Fisher.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
(WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
(WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
(WebTestRunner::WebTestRunner::testRepaint):
(WebTestRunner::WebTestRunner::sweepHorizontally):
(WebTestRunner::WebTestRunner::isPrinting):
(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpBackForwardList):
(WebTestRunner):
(WebTestRunner::TestRunner::deferMainResourceDataLoad):
(WebTestRunner::TestRunner::shouldDumpSelectionRect):
(WebTestRunner::TestRunner::testRepaint):
(WebTestRunner::TestRunner::sweepHorizontally):
(WebTestRunner::TestRunner::isPrinting):
(WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
(WebTestRunner::TestRunner::dumpBackForwardList):
(WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
(WebTestRunner::TestRunner::dumpSelectionRect):
(WebTestRunner::TestRunner::repaintSweepHorizontally):
(WebTestRunner::TestRunner::setPrinting):
(WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Tue, 15 Jan 2013 07:20:13 +0000 (07:20 +0000)]
[Chromium] Unreviewed gardening.

Roll Chromium to r176801.

* DEPS: Rollin' on the river.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Tue, 15 Jan 2013 06:53:34 +0000 (06:53 +0000)]
[Chromium] Unreviewed gardening.

Add XP image expectations for this test; see
<https://bugs.webkit.org/show_bug.cgi?id=106875>:

svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove nonexistent file in ANGLE Xcode project
ddkilzer@apple.com [Tue, 15 Jan 2013 06:15:57 +0000 (06:15 +0000)]
Remove nonexistent file in ANGLE Xcode project

* ANGLE.xcodeproj/project.pbxproj: Remove references to
ossource_nspr.cpp which was removed in r139665.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Tue, 15 Jan 2013 05:29:36 +0000 (05:29 +0000)]
[Chromium] Unreviewed gardening.

Add Lion Debug crash expectations for this test; see
<https://bugs.webkit.org/show_bug.cgi?id=106869>:

fast/mediastream/RTCPeerConnection-events.html

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: stub out show_results_html for mock ports
dpranke@chromium.org [Tue, 15 Jan 2013 05:25:56 +0000 (05:25 +0000)]
nrwt: stub out show_results_html for mock ports
https://bugs.webkit.org/show_bug.cgi?id=106848

Reviewed by Ojan Vafai.

We were accidentally using the underlying ports'
show_results_html_file() implementation, which would, unsurprisingly,
fail in many cases (e.g., running mock-efl on the mac).

No test added since we don't generally add tests for the mock
implementation.

* Scripts/webkitpy/layout_tests/port/mock_drt.py:
(MockDRTPort.show_results_html_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement ID selector matching for the WebVTT ::cue pseudo element
commit-queue@webkit.org [Tue, 15 Jan 2013 05:22:43 +0000 (05:22 +0000)]
Implement ID selector matching for the WebVTT ::cue pseudo element
https://bugs.webkit.org/show_bug.cgi?id=105481

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-01-14
Reviewed by Eric Carlson.

Source/WebCore:

Implemented matching cue WebVTT elements by an identifier. Identifiers of all WebVTT nodes in the rendering tree for
a given cue are set to match the cue identifier.

Existing tests were modified to cover this case.

* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::markFutureAndPastNodes):

LayoutTests:

* media/track/captions-webvtt/styling.vtt:
* media/track/track-css-matching-expected.txt:
* media/track/track-css-matching.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove unused public/platform/WebColorName.h
pilgrim@chromium.org [Tue, 15 Jan 2013 05:17:36 +0000 (05:17 +0000)]
[Chromium] Remove unused public/platform/WebColorName.h
https://bugs.webkit.org/show_bug.cgi?id=106865

Reviewed by Adam Barth.

This file is no longer referenced anywhere in WebKit or Chromium.

* public/platform/WebColorName.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChanging clean_working_directory/clean_local_commits and related
commit-queue@webkit.org [Tue, 15 Jan 2013 05:16:20 +0000 (05:16 +0000)]
Changing clean_working_directory/clean_local_commits and related
functions to have consistent naming.

https://bugs.webkit.org/show_bug.cgi?id=104198

Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-14
Reviewed by Adam Barth.

* Scripts/webkitpy/common/checkout/scm/git.py:
* Scripts/webkitpy/common/checkout/scm/scm.py:
* Scripts/webkitpy/common/checkout/scm/scm_mock.py:
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
* Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
* Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Use explicit WebKit prefixes in BlobRegistryProxy
pilgrim@chromium.org [Tue, 15 Jan 2013 05:15:31 +0000 (05:15 +0000)]
[Chromium] Use explicit WebKit prefixes in BlobRegistryProxy
https://bugs.webkit.org/show_bug.cgi?id=106859

Reviewed by Adam Barth.

As requested in https://bugs.webkit.org/show_bug.cgi?id=106831#c2

* platform/network/chromium/BlobRegistryProxy.cpp:
(WebCore::BlobRegistryProxy::registerBlobURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[ANGLE] Update ANGLE in WebKit
mvujovic@adobe.com [Tue, 15 Jan 2013 05:06:50 +0000 (05:06 +0000)]
[ANGLE] Update ANGLE in WebKit
https://bugs.webkit.org/show_bug.cgi?id=106274

Unreviewed build fix for GTK after http://trac.webkit.org/changeset/139702

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Tue, 15 Jan 2013 03:49:43 +0000 (03:49 +0000)]
[Chromium] Unreviewed gardening.

Update test expectations for these tests:

fast/images/zoomed-offset-size.html
media/track/track-css-cue-lifetime.html
svg/custom/foreign-object-skew.svg
svg/custom/foreign-object-skew.svg

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Tue, 15 Jan 2013 03:46:05 +0000 (03:46 +0000)]
[Chromium] Unreviewed gardening.

Rebaseline these tests:

scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.html

after r139686. Note in TestExpectations image failure for
non-fast-scrollable-region-transformed-iframe.html on SnowLeopard
Debug; see <https://bugs.webkit.org/show_bug.cgi?id=106858>

* platform/chromium-mac-lion/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.
* platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoYet another unreviewed attempted QT build fix, this time because
dino@apple.com [Tue, 15 Jan 2013 03:40:18 +0000 (03:40 +0000)]
Yet another unreviewed attempted QT build fix, this time because
it's falling over on Filters.

* rendering/RenderSnapshottedPlugIn.cpp:
(WebCore):
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshotWithLabel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL build fix.
dino@apple.com [Tue, 15 Jan 2013 03:12:29 +0000 (03:12 +0000)]
Unreviewed EFL build fix.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed QT build fix.
dino@apple.com [Tue, 15 Jan 2013 03:02:39 +0000 (03:02 +0000)]
Unreviewed QT build fix.

* ANGLE.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix EWS GCE build scripts to detect which zone is available
commit-queue@webkit.org [Tue, 15 Jan 2013 03:00:55 +0000 (03:00 +0000)]
Fix EWS GCE build scripts to detect which zone is available
https://bugs.webkit.org/show_bug.cgi?id=106524

Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-14
Reviewed by Adam Barth.

* EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
* EWSTools/GoogleComputeEngine/build-commit-queue.sh:
* EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
* EWSTools/GoogleComputeEngine/findzone.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/dom/HTMLTemplateElement/inertContents.html is flaky on Debug Chromium bots
rafaelw@chromium.org [Tue, 15 Jan 2013 02:49:41 +0000 (02:49 +0000)]
fast/dom/HTMLTemplateElement/inertContents.html is flaky on Debug Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=106810

Reviewed by Levi Weintraub.

This patch reverts the test for inertContents back to a non-flaky version which did not
attempt to assert that images are prevented from loaded.

* fast/dom/HTMLTemplateElement/inertContents-expected.txt:
* fast/dom/HTMLTemplateElement/inertContents.html:
* platform/chromium/TestExpectations:
* platform/efl/fast/dom/HTMLTemplateElement/inertContents-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[ANGLE] Update ANGLE in WebKit
dino@apple.com [Tue, 15 Jan 2013 02:45:24 +0000 (02:45 +0000)]
[ANGLE] Update ANGLE in WebKit
https://bugs.webkit.org/show_bug.cgi?id=106274

Unreviewed attempted build fix.

Source/ThirdParty/ANGLE:

Remove the copy files stage. Make khrplatform.h a public header.

* ANGLE.xcodeproj/project.pbxproj:
* include/GLSLANG/ShaderLang.h:

Source/WebKit:

The khrplatform.h file is now a public header without a directory
prefix. Update the include path to look in the right place.

* PlatformEfl.cmake:

Source/WebKit2:

The khrplatform.h file is now a public header without a directory
prefix. Update the include path to look in the right place.

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBlur the label background of a snapshotted plugin
dino@apple.com [Tue, 15 Jan 2013 02:44:55 +0000 (02:44 +0000)]
Blur the label background of a snapshotted plugin
https://bugs.webkit.org/show_bug.cgi?id=106630

Reviewed by Simon Fraser.

When we are showing a label indicating the plugin has been snapshotted,
slightly blur the snapshot behind the label so that it is more clear. I expect
that if/when other ports pick up this code, we'll need to separate the
UI treatment somewhat, but this is ok for a first step.

* rendering/RenderSnapshottedPlugIn.cpp:
(RenderSnapshottedPlugInBlurFilter): Private class to use FEGaussianBlur to blur an image.
(WebCore::RenderSnapshottedPlugInBlurFilter::create):
(WebCore::RenderSnapshottedPlugInBlurFilter::setSourceImageRect):
(WebCore::RenderSnapshottedPlugInBlurFilter::sourceImageRect):
(WebCore::RenderSnapshottedPlugInBlurFilter::filterRegion):
(WebCore::RenderSnapshottedPlugInBlurFilter::output):
(WebCore::RenderSnapshottedPlugInBlurFilter::RenderSnapshottedPlugInBlurFilter):
(WebCore::RenderSnapshottedPlugInBlurFilter::apply):
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): New member variable to hold a cached version of a preblurred snapshot.
(WebCore::RenderSnapshottedPlugIn::~RenderSnapshottedPlugIn): Remember to remove the preblurred image from the cache.
(WebCore::RenderSnapshottedPlugIn::updateSnapshot): Zero the preblurred version if it exists.
(WebCore::RenderSnapshottedPlugIn::paintReplaced): Either paint snapshot or blurred snapshot with label.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): New method to paint a full sized snapshot.
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshot):
(WebCore::snapshottedPluginImageForLabelDisplay): Static function to produce the blurred snapshot.
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshotWithLabel): Calls paintSnapshot with the blurred snapshot on Mac.
* rendering/RenderSnapshottedPlugIn.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdding an error string to AmbiguousCommitError.
commit-queue@webkit.org [Tue, 15 Jan 2013 02:08:38 +0000 (02:08 +0000)]
Adding an error string to AmbiguousCommitError.
https://bugs.webkit.org/show_bug.cgi?id=106846

Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-14
Reviewed by Adam Barth.

* Scripts/webkitpy/common/checkout/scm/git.py:
(AmbiguousCommitError.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Adding mac expectatons after r139686.
leviw@chromium.org [Tue, 15 Jan 2013 02:06:20 +0000 (02:06 +0000)]
Unreviewed gardening. Adding mac expectatons after r139686.

* platform/chromium-mac/scrollingcoordinator: Added.
* platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Move BlobRegistryProxy into WebCore
pilgrim@chromium.org [Tue, 15 Jan 2013 01:58:07 +0000 (01:58 +0000)]
[Chromium] Move BlobRegistryProxy into WebCore
https://bugs.webkit.org/show_bug.cgi?id=106831

Reviewed by Adam Barth.

Part of a larger refactoring series to remove layering violations
in Chromium. See tracking bug 106829.

Source/WebCore:

* WebCore.gypi:
* platform/network/chromium/BlobRegistryProxy.cpp: Added.
(WebCore):
(WebCore::blobRegistry):
(WebCore::BlobRegistryProxy::BlobRegistryProxy):
(WebCore::BlobRegistryProxy::registerBlobURL):
(WebCore::BlobRegistryProxy::unregisterBlobURL):
* platform/network/chromium/BlobRegistryProxy.h: Added.
(WebCore):
(BlobRegistryProxy):
(WebCore::BlobRegistryProxy::loadResourceSynchronously):
(WebCore::BlobRegistryProxy::~BlobRegistryProxy):

Source/WebKit/chromium:

* WebKit.gyp:
* src/BlobRegistryProxy.cpp: Removed.
* src/BlobRegistryProxy.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agokill whole lighttpd process tree for chromium win
dpranke@chromium.org [Tue, 15 Jan 2013 01:40:54 +0000 (01:40 +0000)]
kill whole lighttpd process tree for chromium win
https://bugs.webkit.org/show_bug.cgi?id=106838

Reviewed by Tony Chang.

Land a speculative fix for lighttpd.exe hanging on some chromium bots;
I think a test is causing a httpd server child process to wedge and
killing the parent httpd server process isn't sufficient to ensure
that the children are also killed.

* Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd._check_and_kill):
* Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
(TestHttpServer.test_start_cmd):
(TestHttpServer):
(TestHttpServer.test_win32_start_and_stop):
(TestHttpServer.test_win32_start_and_stop.wait_for_action):
(TestHttpServer.test_win32_start_and_stop.mock_returns):
(TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Rolling out r139618. Appears to be causing sporadic crashes on Debug...
leviw@chromium.org [Tue, 15 Jan 2013 01:36:32 +0000 (01:36 +0000)]
Source/WebCore: Rolling out r139618. Appears to be causing sporadic crashes on Debug bots.

* Modules/mediastream/MediaStream.cpp:
(WebCore::processTrack):
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::readyState):
* Modules/mediastream/MediaStreamTrack.h:
* Modules/mediastream/MediaStreamTrack.idl:

LayoutTests: Speculatively rolling out r139618. Appears to be causing sporadic crashes on Debug bots.

* fast/mediastream/MediaStreamTrack-expected.txt:
* fast/mediastream/MediaStreamTrack.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRolling out r139678. This triggered a number of WebAudio crashes on Debug bots.
leviw@chromium.org [Tue, 15 Jan 2013 01:31:34 +0000 (01:31 +0000)]
Rolling out r139678. This triggered a number of WebAudio crashes on Debug bots.

* platform/audio/chromium/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Rolling out r139683. It broke a bunch of webkit_unit_tests.
leviw@chromium.org [Tue, 15 Jan 2013 01:22:59 +0000 (01:22 +0000)]
Source/WebCore: Rolling out r139683. It broke a bunch of webkit_unit_tests.

Source/WebKit/win: Rolling out r139683. It broke a bunch of webkit_unit_tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderListItem does not need to override computePreferredLogicalWidth
ojan@chromium.org [Tue, 15 Jan 2013 01:19:14 +0000 (01:19 +0000)]
RenderListItem does not need to override computePreferredLogicalWidth
https://bugs.webkit.org/show_bug.cgi?id=106839

Reviewed by Levi Weintraub.

Apparently there was a time when the list marker was considered part of
the list item's preferred width, but that is no longer the case.
This code was added in r3421. The code around preferred widths has change
a lot since then.

* rendering/RenderListItem.cpp:
* rendering/RenderListItem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement element type selectors for the WebVTT ::cue pseudo class
commit-queue@webkit.org [Tue, 15 Jan 2013 01:17:16 +0000 (01:17 +0000)]
Implement element type selectors for the WebVTT ::cue pseudo class
https://bugs.webkit.org/show_bug.cgi?id=105480

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-01-14
Reviewed by Antti Koivisto.

Source/WebCore:

Implemented tag matching for the WebVTT specific tags "c" and "v". All common html tags like "b" and "i" are
handled without any changes to the code. Creating a rendering tree and DOM tree now use different code paths.
They both are made by cloning and modifying the tree produced by the parser. Voice tags now use spans for both
rendering and DOM trees to conform to specs. Since this changes a lot of code little refactoring has been
done. Removed m_hasInnerTimestamps since it is no longer needed, it doesn't affect anything. m_documentFragment
was renamed to m_webVTTNodeTree.

Existing tests were modified to cover this case.

* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::setText): rename m_documentFragment to m_webVTTNodeTree
(WebCore::TextTrackCue::createWebVTTNodeTree): parse the cue if it hasn't been parsed before.
(WebCore::TextTrackCue::copyWebVTTNodeToDOMTree): clone and prepare a node for using in the DOM tree according to specs.
(WebCore::TextTrackCue::getCueAsHTML): get a DOM tree for the cue.
(WebCore::TextTrackCue::createCueRenderingTree): create a rendering tree (main tree is just being cloned for now).
(WebCore::TextTrackCue::markFutureAndPastNodes): tightening the argument type.
(WebCore::TextTrackCue::updateDisplayTree):
(WebCore::TextTrackCue::getDisplayTree): code cleanup, removed m_hasInnerTimeStamps.
* html/track/TextTrackCue.h:
(WebCore::TextTrackCue::voiceElementTagName):
(TextTrackCue):
(WebCore::TextTrackCue::classElementTagName):
* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken): type of the newly created elements was changed to Element to avoid hitting
an assertion when cloning because a cloned element will not have HTMLElement type for elements with "v" and "c" tag.

LayoutTests:

* media/track/captions-webvtt/styling.vtt:
* media/track/track-css-matching-expected.txt:
* media/track/track-css-matching.html:
* media/track/track-webvtt-tc026-voice.html: voice elements should be spans according to specs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSometimes RenderLayer::updateNeedsCompositedScrolling is not called
wangxianzhu@chromium.org [Tue, 15 Jan 2013 01:13:45 +0000 (01:13 +0000)]
Sometimes RenderLayer::updateNeedsCompositedScrolling is not called
https://bugs.webkit.org/show_bug.cgi?id=106271

Reviewed by Simon Fraser.

Source/WebCore:

1. If a layer has no out-of-flow descendant, m_hasOutOfFlowPositionedDescendant won't change and won't trigger updateNeedsCompositedScrolling in updateDescendantDependentFlags. Set m_hasOutOfFlowPositionedDescendantDirty to true and call updateNeedsCompositedScrolling when the dirty flag becomes false from true.
2. When the content size changes causing change of scrollable status, updateNeedsCompositedScrolling should also be called.

Test: compositing/overflow/dynamic-composited-scrolling-status.html

* page/FrameView.cpp:
(WebCore::FrameView::addScrollableArea): Returns whether the scrollable area has just been newly added.
(WebCore::FrameView::removeScrollableArea): Returns whether the scrollable area has just been removed.
* page/FrameView.h:
(FrameView):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer): Changed the initial value of m_hasOutOfFlowPositionedDescendantDirty to true to make sure m_hasOutOfFlowPositionedDescendant will be updated initially.
(WebCore::RenderLayer::updateDescendantDependentFlags): Call updateNeedsCompositedScrolling when m_hasOutOfFlowPositionedDescendantDirty is true.
(RenderLayer::updateScrollableAreaSet): Calls updateNeedsCompositedScrolling() when scrollable status changes.
* rendering/RenderLayer.h:
(RenderLayer):

LayoutTests:

* compositing/overflow/dynamic-composited-scrolling-status-expected.txt: Added.
* compositing/overflow/dynamic-composited-scrolling-status.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEFL build fix after r139681.
rniwa@webkit.org [Tue, 15 Jan 2013 01:02:20 +0000 (01:02 +0000)]
EFL build fix after r139681.

* dom/NodeRareData.h:
(WebCore::NodeMicroDataTokenLists::NodeMicroDataTokenLists):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Enable `update-webkit --chromium --ninja` on windows
thakis@chromium.org [Tue, 15 Jan 2013 01:00:42 +0000 (01:00 +0000)]
[chromium] Enable `update-webkit --chromium --ninja` on windows
https://bugs.webkit.org/show_bug.cgi?id=106836

Reviewed by Eric Seidel.

After running this, build-webkit --chromium will use ninja to build.
Apparently there are some minor issues with that still, so it's
not quite ready for use yet.

* Scripts/webkitdirs.pm:
(determineIsChromiumNinja):
(buildChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG should not forget that it had proved something to be a constant during a merge...
fpizlo@apple.com [Tue, 15 Jan 2013 00:56:35 +0000 (00:56 +0000)]
DFG should not forget that it had proved something to be a constant during a merge just because it's merging against the empty value
https://bugs.webkit.org/show_bug.cgi?id=106727

Reviewed by Oliver Hunt.

The problem was this statement:

if (m_value != other.m_value)
    m_value = JSValue();

This is well-intentioned, in the sense that if we want our abstract value (i.e. this) to become the superset of the other
abstract value, and the two abstract values have proven different constants, then our abstract value should rescind its
claim that it has been proven to be constant. But this misses the special case that if the other abstract value is
completely clear (meaning that it wishes to contribute zero information and so the superset operation shouldn't change
this), it will have a clear m_value. So, the code prior to this patch would rescind the constant proof even though it
didn't have to.

This comes up rarely and I don't believe it will be a performance win, but it is good to have the CFA been consistently
precise as often as possible.

* dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::merge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPython implementation reports "MemoryError" instead of doing things
fpizlo@apple.com [Tue, 15 Jan 2013 00:53:39 +0000 (00:53 +0000)]
Python implementation reports "MemoryError" instead of doing things
https://bugs.webkit.org/show_bug.cgi?id=106690

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

The bug was that the CFA was assuming that a variable is dead at the end of a basic block and hence doesn't need to
be merged to the next block if the last mention of the variable was dead. This is almost correct, except that it
doesn't work if the last mention is a GetLocal - the GetLocal itself may be dead, but that doesn't mean that the
variable is dead - it may still be live. The appropriate thing to do is to look at the GetLocal's Phi. If the
variable is used in the next block then the next block will have a reference to the last mention in our block unless
that last mention is a GetLocal, in which case it will link to the Phi. Doing it this way captures everything that
the CFA wants: if the last use is a live GetLocal then the CFA needs to consider the GetLocal itself for possible
refinements to the proof of the value in the variable, but if the GetLocal is dead, then this must mean that the
variable is not mentioned in the block but may still be "passed through" it, which is what the Phi will tell us.
Note that it is not possible for the GetLocal to refer to anything other than a Phi, and it is also not possible
for the last mention of a variable to be a dead GetLocal while there are other mentions that aren't dead - if
there had been SetLocals or GetLocals prior to the dead one then the dead one wouldn't have been emitted by the
parser.

This also fixes a similar bug in the handling of captured variables. If a variable is captured, then it doesn't
matter if the last mention is dead, or not. Either way, we already know that a captured variable will be live in
the next block, so we must merge it no matter what.

Finally, this change makes the output of Operands dumping a bit more verbose: it now prints the variable name next
to each variable's dump. I've often found the lack of this information confusing particularly for operand dumps
that involve a lot of variables.

* bytecode/Operands.h:
(JSC::dumpOperands):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::mergeStateAtTail):

LayoutTests:

Reviewed by Oliver Hunt.

* fast/js/dfg-cfa-merge-with-dead-use-at-tail-expected.txt: Added.
* fast/js/dfg-cfa-merge-with-dead-use-at-tail.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-cfa-merge-with-dead-use-at-tail.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCorrect FrameView::scrollableAreaBoundingBox() calculation in the presence of transforms
commit-queue@webkit.org [Tue, 15 Jan 2013 00:51:30 +0000 (00:51 +0000)]
Correct FrameView::scrollableAreaBoundingBox() calculation in the presence of transforms
https://bugs.webkit.org/show_bug.cgi?id=105075

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-01-14
Reviewed by Simon Fraser.

As mentioned by the FIXME comment, we need to ask the renderer for the
absolute bounding box of a frame for correct transformation.
This fixes the bug that iframe cannot be scrolled properly when it is
transformed.

Source/WebCore:

Tests: scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
       scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html

* page/FrameView.cpp:
(WebCore::FrameView::scrollableAreaBoundingBox):

LayoutTests:

* platform/mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.
* platform/mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
* platform/mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added.
* platform/mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
* scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.
* scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
* scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html: Added.
* scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added.
* scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
* scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html: Added.
* scrollingcoordinator/resources/non-fast-scrollable-region-testing.js: Added.
(runNonFastScrollableRegionTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago <rdar://problem/12524710> Update sandbox rules after r128003
ap@apple.com [Tue, 15 Jan 2013 00:45:46 +0000 (00:45 +0000)]
    <rdar://problem/12524710> Update sandbox rules after r128003
        https://bugs.webkit.org/show_bug.cgi?id=106840

        Reviewed by Anders Carlsson.

        * WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Fixing Mac results for fast/repaint/overhanging-float-detach...
leviw@chromium.org [Tue, 15 Jan 2013 00:12:51 +0000 (00:12 +0000)]
Unreviewed gardening. Fixing Mac results for fast/repaint/overhanging-float-detach-repaint.html.

* platform/chromium-mac-lion/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
* platform/chromium-mac/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago.: Enable reuse of cached main resources
japhet@chromium.org [Tue, 15 Jan 2013 00:10:05 +0000 (00:10 +0000)]
.: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667

Reviewed by Antti Koivisto.

* Source/autotools/symbols.filter: Expose MemoryCache::resourceForURL().

Source/WebCore: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667

Reviewed by Antti Koivisto.

Test: http/tests/cache/cached-main-resource.html

* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::hasManifest): Returns true if the <html> element has a non-empty manifest attribute.
* dom/Document.h:
(Document):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadedResourceFromMemoryCache): Don't send delegate callbacks for cache hit here, since
    MainResourceLoader will take care of it.
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::responseReceived): Don't try to cache loads from the application cache.
(WebCore::MainResourceLoader::didFinishLoading): Don't try to cache loads from the application cache.
(WebCore::MainResourceLoader::load): Ensure we create a resource load identifier for cache hits. Also,
    ensure we correctly popualate fragment identifiers in the ResourceRequest reported to DocumentLoader.
(WebCore::MainResourceLoader::identifier):
* loader/MainResourceLoader.h: Rename m_substituteDataLoadIdentifier to m_identifierForLoadWithoutResourceLoader
    to better describe when it is used.
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::didAddClient): Synthesize redirect notifications for cache hits if necessary.
(WebCore::CachedRawResource::willSendRequest): Note the redirects we received.
(WebCore::CachedRawResource::canReuse): Don't reuse a resource if the redirect chain included a "Cache-control: no-store".
* loader/cache/CachedRawResource.h:
(CachedRawResource):
(RedirectPair):
(WebCore::CachedRawResource::RedirectPair::RedirectPair):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::addClientToSet):: Don't return cached data for a main resource synchronously
* loader/cache/CachedResource.h:
(WebCore::CachedResource::canReuse):
(CachedResource):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy): Permit cache reuse for main resources.
* testing/Internals.cpp:
(WebCore::Internals::isLoadingFromMemoryCache):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit/win: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667

Reviewed by Antti Koivisto.

* WebKit.vcproj/WebKitExports.def.in: Expose some MemoryCache symbols for use in Internals.

LayoutTests: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667.

Reviewed by Antti Koivisto.

* http/tests/cache/cached-main-resource-expected.txt: Added.
* http/tests/cache/cached-main-resource.html: Added.
* http/tests/cache/resources/cacheable-iframe.php: Added.
* http/tests/inspector/resource-har-pages-expected.txt:
* http/tests/loading/redirect-methods-expected.txt:
* http/tests/misc/favicon-loads-with-images-disabled-expected.txt:
* http/tests/misc/link-rel-icon-beforeload-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix vcproj file. Missing file tag after http://trac.webkit.org/changeset...
roger_fong@apple.com [Tue, 15 Jan 2013 00:09:03 +0000 (00:09 +0000)]
Unreviewed. Fix vcproj file. Missing file tag after trac.webkit.org/changeset/139541.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove functions from NodeRareData to ElementRareData and other classes
rniwa@webkit.org [Mon, 14 Jan 2013 23:57:39 +0000 (23:57 +0000)]
Move functions from NodeRareData to ElementRareData and other classes
https://bugs.webkit.org/show_bug.cgi?id=106679

Reviewed by Benjamin Poulain.

Moved tab index related functions from NodeRareData to ElementRareData since only
HTMLElement uses them, and moved related functions on Node to Element accordingly.

Also replaced transientMutationObserverRegistry and ensureTransientMutationObserverRegistry
by ensureMutationObserverData, and moved micro-data related member functions into
NodeMicroDataTokenLists, and moved NodeMutationObserverData and NodeMicroDataTokenLists
out of NodeRareData as they're used outside of NodeRareData now.

The intention is to move more code into NodeMutationObserverData and NodeMicroDataTokenLists
in the follow up patches so that they can detect the removability of NodeRareData.

No new tests are added since there should be no behavior changes.

* dom/Element.cpp:
(WebCore::Element::clearTabIndexExplicitlyIfNeeded):
(WebCore::Element::setTabIndexExplicitly):
(WebCore::Element::tabIndex):
(WebCore::Element::supportsFocus):
* dom/Element.h:
(Element):
* dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::tabIndex):
(WebCore::ElementRareData::setTabIndexExplicitly):
(WebCore::ElementRareData::tabIndexSetExplicitly):
(WebCore::ElementRareData::clearTabIndexExplicitly):
* dom/Node.cpp:
(WebCore::Node::tabIndex):
(WebCore::Node::supportsFocus):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::transientMutationObserverRegistry):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::registerTransientMutationObserver):
(WebCore::Node::itemProp):
(WebCore::Node::setItemProp):
(WebCore::Node::itemRef):
(WebCore::Node::setItemRef):
(WebCore::Node::itemType):
(WebCore::Node::setItemType):
* dom/Node.h:
(Node):
* dom/NodeRareData.h:
(NodeMutationObserverData):
(WebCore::NodeMutationObserverData::create):
(NodeMicroDataTokenLists):
(WebCore::NodeMicroDataTokenLists::create):
(WebCore::NodeMicroDataTokenLists::itemProp):
(WebCore::NodeMicroDataTokenLists::itemRef):
(WebCore::NodeMicroDataTokenLists::itemType):
(NodeRareData):
(WebCore::NodeRareData::mutationObserverData):
(WebCore::NodeRareData::ensureMutationObserverData):
(WebCore::NodeRareData::ensureMicroDataTokenLists):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unnecessary setNeedsLayoutAndPrefWidthsRecalc from RenderTable
ojan@chromium.org [Mon, 14 Jan 2013 23:53:51 +0000 (23:53 +0000)]
Remove unnecessary setNeedsLayoutAndPrefWidthsRecalc from RenderTable
https://bugs.webkit.org/show_bug.cgi?id=106832

Reviewed by Levi Weintraub.

These are both called from locations that either set these bits themselves
or clearly don't need these bits set (e.g. computePreferredLogicalWidths).

* rendering/RenderTable.cpp:
(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: use the same search path for baselines and TestExpectations on apple mac
dpranke@chromium.org [Mon, 14 Jan 2013 23:50:42 +0000 (23:50 +0000)]
nrwt: use the same search path for baselines and TestExpectations on apple mac
https://bugs.webkit.org/show_bug.cgi?id=105599

Reviewed by Ryosuke Niwa.

Bug 105583 revealed some confusion due to the fact that the Apple
Mac port used a different list of directories to search for baselines
and TestExpectations files (actually, pretty much every port does).

It seems like a good idea to use the same list for both by default, but
making this happen will affect every port in slightly different ways, so
we'll try this on the Apple Mac port first.

Note that the effective changes for this are that:
1) The apple mac port will look in platform/wk2 for baselines where
it didn't before (it will look after looking in mac-wk2 but before
the non-wk2 dirs)
2) The apple mac-snowleopard port will use the expectations in
mac-lion as well as the expectations in mac-snowleopard, although
I'm not even sure if mac-snowleopard is still supported ...

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.default_baseline_search_path):
(MacPort.expectations_files):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_baseline_search_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSwitch AudioDestinationChromium over to new createAudioDevice() method
crogers@google.com [Mon, 14 Jan 2013 23:49:56 +0000 (23:49 +0000)]
Switch AudioDestinationChromium over to new createAudioDevice() method
https://bugs.webkit.org/show_bug.cgi?id=106816

Reviewed by James Robinson.

* platform/audio/chromium/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Marking fast/image/zoomed-offset-size.html as slow on debug.
leviw@chromium.org [Mon, 14 Jan 2013 23:49:00 +0000 (23:49 +0000)]
Unreviewed gardening. Marking fast/image/zoomed-offset-size.html as slow on debug.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Marking fast/borders/outline-alpha-inline.html as failing image...
leviw@chromium.org [Mon, 14 Jan 2013 23:44:10 +0000 (23:44 +0000)]
Unreviewed gardening. Marking fast/borders/outline-alpha-inline.html as failing image results.
Likely Stephen Schenney's skia changes are to blame.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] REGRESSION(r139189): MiniBrowser renders abnormally with -r option.
commit-queue@webkit.org [Mon, 14 Jan 2013 23:13:13 +0000 (23:13 +0000)]
[EFL] REGRESSION(r139189): MiniBrowser renders abnormally with -r option.
https://bugs.webkit.org/show_bug.cgi?id=106512

Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-14
Reviewed by Kenneth Rohde Christiansen.

PageViewportController handles only pageScaleFactor after r139189. So
PageViewportControllerClientEFL calls EwkView::setScaleFactor() with
pageScaleFactor instead of pageScaleFactor * deviceScaleFactor.

This patch makes EwkView handle pageScaleFactor.
1. EwkView uses pageScaleFactor * deviceScaleFactor when drawing in
the device unit.
2. EwkView uses pageScaleFactor when notifying the scale to
PageViewportController.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::deviceScaleFactor):
(EwkViewImpl::transformFromScene):
(EwkViewImpl::displayTimerFired):
* UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
(EwkViewImpl::setPageScaleFactor):
(EwkViewImpl::pageScaleFactor):
* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::didRenderFrame):
* UIProcess/PageViewportControllerClient.h:
(PageViewportControllerClient):
* UIProcess/efl/PageClientLegacyImpl.cpp:
(WebKit::PageClientLegacyImpl::updateViewportSize):
* UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
(WebKit::PageViewportControllerClientEfl::setPageScaleFactor):
(WebKit::PageViewportControllerClientEfl::didResumeContent):
* UIProcess/efl/PageViewportControllerClientEfl.h:
(PageViewportControllerClientEfl):
* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::setPageScaleFactor):
* UIProcess/qt/PageViewportControllerClientQt.h:
(PageViewportControllerClientQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[TexMap] Use a premuliplied color in TextureMapperGL.
commit-queue@webkit.org [Mon, 14 Jan 2013 23:11:04 +0000 (23:11 +0000)]
[TexMap] Use a premuliplied color in TextureMapperGL.
https://bugs.webkit.org/show_bug.cgi?id=105786

Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-14
Reviewed by Noam Rosenthal.

Source/WebCore:

TextureMapperGL always uses a premultiplied color, so we must convert
an unmultiplied color to a premultiplied color before setting the uniform value of
colorLocation.

Test: compositing/background-color/background-color-alpha-with-opacity.html

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawBorder):
(WebCore::TextureMapperGL::drawSolidColor):
(WebCore::prepareFilterProgram):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::blendWithOpacity):
(WebCore):
(WebCore::TextureMapperLayer::paintSelf):
    TextureMapperLayer must not convert solidColor to premultiplied
    color, because TextureMapperImageBuffer expects unmultiplied color.

LayoutTests:

Created new tests for composited background colors with fractional
number opacity. This test is similar to background-color-alpha.html

* compositing/background-color/background-color-alpha-with-opacity-expected.html: Added.
* compositing/background-color/background-color-alpha-with-opacity.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMicrodata: REGRESSION(r138725): Causes crash in chromium port
arko@motorola.com [Mon, 14 Jan 2013 23:02:19 +0000 (23:02 +0000)]
Microdata: REGRESSION(r138725): Causes crash in chromium port
https://bugs.webkit.org/show_bug.cgi?id=106828

Reviewed by Ryosuke Niwa.

Source/WebCore:

We should hold PropertyNodeList in RefPtr<PropertyNodeList>.

Test: fast/dom/MicroData/propertiescollection-crash.html

* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::V8HTMLCollection::namedPropertyGetter):

LayoutTests:

* fast/dom/MicroData/propertiescollection-crash-expected.txt: Added.
* fast/dom/MicroData/propertiescollection-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline after Skia changes
schenney@chromium.org [Mon, 14 Jan 2013 22:48:56 +0000 (22:48 +0000)]
[Chromium] Rebaseline after Skia changes

Unreviewed expectatiosn update for two remaining tests.

* platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-win/fast/borders/outline-alpha-inline-expected.png: Added.
* platform/chromium/fast/borders/outline-alpha-inline-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPositioned children of an overflow:visible container should ignore scroll offset...
commit-queue@webkit.org [Mon, 14 Jan 2013 22:44:02 +0000 (22:44 +0000)]
Positioned children of an overflow:visible container should ignore scroll offset when updating layer position
https://bugs.webkit.org/show_bug.cgi?id=106814

Source/WebCore:

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-01-14
Reviewed by Simon Fraser.

This patch fixes a bug in RenderLayer::updateLayerPosition that
scrollLeft / scrollTop of a block should only be effective when the
block has overflow clipping. The bug results in rendering artifacts
and triggers a RenderGeometryMap assertion falure.

Fixes http://crbug.com/167985

Test: fast/overflow/overflow-visible-should-ignore-scroll.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):

LayoutTests:

This patch fixes a bug in RenderLayer::updateLayerPosition that
scrollLeft / scrollTop of a block should only be effective when the
block has overflow clipping. The bug results in rendering artifacts
and triggers a RenderGeometryMap assertion falure.

Fixes http://crbug.com/167985

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-01-14
Reviewed by Simon Fraser.

* fast/overflow/overflow-visible-should-ignore-scroll-expected.html: Added.
* fast/overflow/overflow-visible-should-ignore-scroll.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium mac rebaseline for r139659.
eae@chromium.org [Mon, 14 Jan 2013 22:41:44 +0000 (22:41 +0000)]
Unreviewed chromium mac rebaseline for r139659.

* platform/chromium-mac/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] FCC appears when switching search engine providers
commit-queue@webkit.org [Mon, 14 Jan 2013 22:41:09 +0000 (22:41 +0000)]
[BlackBerry] FCC appears when switching search engine providers
https://bugs.webkit.org/show_bug.cgi?id=106824

Magnifying glass appears when switching search engine providers

PR 279178

Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-01-14
Reviewed by Rob Buis.
Internal Reviewed by Mike Fenton.

We need to make sure fatfinger is touching a textfield when we tell notifyCaretChanged
to show the FCC.

This behaviour is accidentally regressed in the fix in PR 267177, causing the FCC to show
when the user touches an element that is not a textfield and changes the caret in the inputbar..

Tested that the behaviour in 267177 isn't reproducible and the FCC isn't invoked when we switch
search engine providers.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Remove IDBObjectStore/IndexBackendImpl and support functions
alecflett@chromium.org [Mon, 14 Jan 2013 22:40:24 +0000 (22:40 +0000)]
IndexedDB: Remove IDBObjectStore/IndexBackendImpl and support functions
https://bugs.webkit.org/show_bug.cgi?id=106605

Source/WebCore:

Remove all uses of IDBObjectStoreBackendInterface and IDBIndexBackend*,
as they are no longer used after recent refactoring.

Reviewed by Darin Fisher.

* GNUmakefile.list.am:
* Modules/indexeddb/IDBCallbacks.h:
(WebCore):
* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update):
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(WebCore):
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl):
* Modules/indexeddb/IDBFactoryBackendInterface.h:
(IDBFactoryBackendInterface):
* Modules/indexeddb/IDBIndex.cpp:
* Modules/indexeddb/IDBIndexBackendInterface.h: Removed.
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
* Modules/indexeddb/IDBObjectStore.h:
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::makeIndexWriters):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(WebCore::IDBObjectStoreBackendImpl::IndexWriter::IndexWriter):
(IndexWriter):
(IDBObjectStoreBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h: Removed.
* Modules/indexeddb/IDBTransaction.cpp:
* Modules/indexeddb/IDBTransactionBackendImpl.h:
(IDBTransactionBackendImpl):
* Modules/indexeddb/IDBTransactionBackendInterface.h:
(WebCore):
* Modules/indexeddb/IDBTransactionCoordinator.cpp:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Remove all references to IDBObjectStoreBackend* and IDBIndexBackend*
as they no longer exist in WebCore.

Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebIDBCallbacks.h:
(WebKit):
* public/WebIDBDatabase.h:
(WebKit):
(WebKit::WebIDBDatabase::metadata):
* public/WebIDBFactory.h:
(WebIDBFactory):
* public/WebIDBIndex.h: Removed.
* public/WebIDBObjectStore.h: Removed.
* public/WebIDBTransaction.h:
* src/IDBCallbacksProxy.cpp:
* src/IDBDatabaseBackendProxy.cpp:
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBFactoryBackendProxy.cpp:
* src/IDBFactoryBackendProxy.h:
(IDBFactoryBackendProxy):
* src/IDBIndexBackendProxy.cpp: Removed.
* src/IDBIndexBackendProxy.h: Removed.
* src/IDBObjectStoreBackendProxy.cpp: Removed.
* src/IDBObjectStoreBackendProxy.h: Removed.
* src/IDBTransactionBackendProxy.cpp:
* src/IDBTransactionBackendProxy.h:
(IDBTransactionBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::put):
(WebKit::WebIDBDatabaseImpl::setIndexKeys):
* src/WebIDBDatabaseImpl.h:
(WebKit):
(WebIDBDatabaseImpl):
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::getDatabaseNames):
* src/WebIDBFactoryImpl.h:
(WebIDBFactoryImpl):
* src/WebIDBIndexImpl.cpp: Removed.
* src/WebIDBIndexImpl.h: Removed.
* src/WebIDBObjectStoreImpl.cpp: Removed.
* src/WebIDBObjectStoreImpl.h: Removed.
* src/WebIDBTransactionImpl.cpp:
* src/WebIDBTransactionImpl.h:
* tests/IDBAbortOnCorruptTest.cpp:
(WebCore::TEST):
* tests/IDBDatabaseBackendTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139666 268f45cc-cd09-0410-ab3c-d52691b4dbfc