WebKit-https.git
7 years agoDisable ENABLE_DATALIST for now
keishi@webkit.org [Wed, 4 Apr 2012 04:43:17 +0000 (04:43 +0000)]
Disable ENABLE_DATALIST for now
https://bugs.webkit.org/show_bug.cgi?id=82871

Reviewed by Kent Tamura.

.:

We should disable ENABLE_DATALIST because
- We need platform-dependent implementation, and non-BlackBerry platforms don't have it.
- We need to hide the content of <datalist>, but it is shown for now.

* Source/cmake/OptionsEfl.cmake: Disabled ENABLE_DATALIST.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Source/WebCore:

* Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Tools:

* Scripts/build-webkit: Disabled ENABLE_DATALIST.

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops: Disabled ENABLE_DATALIST.

LayoutTests:

Moved datalist tests into directory fast/forms/datalist and added it to Skipped files.

* fast/forms/datalist/datalist-expected.txt: Moved from LayoutTests/fast/forms/datalist-expected.txt.
* fast/forms/datalist/datalist-nonoption-child-expected.txt: Moved from LayoutTests/fast/forms/datalist-nonoption-child-expected.txt.
* fast/forms/datalist/datalist-nonoption-child.html: Moved from LayoutTests/fast/forms/datalist-nonoption-child.html.
* fast/forms/datalist/datalist.html: Moved from LayoutTests/fast/forms/datalist.html.
* fast/forms/datalist/input-list-expected.txt: Moved from LayoutTests/fast/forms/input-list-expected.txt.
* fast/forms/datalist/input-list.html: Moved from LayoutTests/fast/forms/input-list.html.
* fast/forms/datalist/input-selectedoption-expected.txt: Moved from LayoutTests/fast/forms/input-selectedoption-expected.txt.
* fast/forms/datalist/input-selectedoption.html: Moved from LayoutTests/fast/forms/input-selectedoption.html.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agojsr/sret should be removed
fpizlo@apple.com [Wed, 4 Apr 2012 04:25:56 +0000 (04:25 +0000)]
jsr/sret should be removed
https://bugs.webkit.org/show_bug.cgi?id=82986
<rdar://problem/11017015>

Reviewed by Sam Weinig and Geoff Garen.

Replaces jsr/sret with finally block inlining.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::pushFinallyContext):
(JSC::BytecodeGenerator::emitComplexJumpScopes):
(JSC):
* bytecompiler/BytecodeGenerator.h:
(FinallyContext):
(BytecodeGenerator):
* bytecompiler/NodesCodegen.cpp:
(JSC::TryNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JIT):
* jit/JITOpcodes.cpp:
(JSC):
* jit/JITOpcodes32_64.cpp:
(JSC):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Assert on startup after r113090
yael.aharon@nokia.com [Wed, 4 Apr 2012 04:21:15 +0000 (04:21 +0000)]
[Qt][WK2] Assert on startup after r113090
https://bugs.webkit.org/show_bug.cgi?id=83111

Reviewed by Noam Rosenthal.

Source/WebCore:

Add willBeDestroyed to to GraphicsLayerTextureMapper.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::~GraphicsLayerTextureMapper):
(WebCore):
(WebCore::WebGraphicsLayer::willBeDestroyed):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):

Source/WebKit2:

Add willBeDestroyed to to WebGraphicsLayer.

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore):
(WebCore::WebGraphicsLayer::willBeDestroyed):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSigh... this isn't going well. I can't even reproduce this issue locally.
rniwa@webkit.org [Wed, 4 Apr 2012 03:52:07 +0000 (03:52 +0000)]
Sigh... this isn't going well. I can't even reproduce this issue locally.
Another speculative fix.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow the old WebKit2 drawing model to host layers in the window server
weinig@apple.com [Wed, 4 Apr 2012 03:35:40 +0000 (03:35 +0000)]
Allow the old WebKit2 drawing model to host layers in the window server
<rdar://problem/11170525>
https://bugs.webkit.org/show_bug.cgi?id=83101

Reviewed by Anders Carlsson.

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::layerHostingModeDidChange):
* UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
* WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setLayerHostingMode):
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
* WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
(WebKit::LayerTreeHost::setLayerHostingMode):
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
(LayerTreeHostCAMac):
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::platformInitialize):
(WebKit::LayerTreeHostCAMac::setLayerHostingMode):
Pipe layer hosting mode to the old drawing area.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Out-of-process font loading garbles text
bashi@chromium.org [Wed, 4 Apr 2012 03:15:33 +0000 (03:15 +0000)]
[Chromium] Out-of-process font loading garbles text
https://bugs.webkit.org/show_bug.cgi?id=83002

Reviewed by Kent Tamura.

Initialize m_CTFont by using m_cgFont in FontPlatformData when we use
out-of-process font loading.

No new tests. This problem only occurs when the user uses a third party
font management software like Font Explorer so it is difficult to add
tests.

* platform/graphics/chromium/CrossProcessFontLoading.mm:
(WebCore):
(WebCore::FontPlatformData::loadFont): If font loading fails, set null to outNSFont so that the FontPlatformData won't be used.
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::ctFont): Modified to return the appropriate NSFont object when the font from the browser process.
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData): Returns null when the generated FontPlatformData object doesn't have NSFont object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate another baseline for a failing chromium SL svg test (and mark it flaky).
dpranke@chromium.org [Wed, 4 Apr 2012 02:53:35 +0000 (02:53 +0000)]
Update another baseline for a failing chromium SL svg test (and mark it flaky).

Unreviewed, expectations change.

* platform/chromium-mac-snowleopard/svg/text/ems-display-none-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate baselines for failing svg tests ...
dpranke@chromium.org [Wed, 4 Apr 2012 02:28:49 +0000 (02:28 +0000)]
Update baselines for failing svg tests ...

Reviewed by NOBODY (OOPS!).

* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoI don't know why I'm so sloppy today. Another build fix.
rniwa@webkit.org [Wed, 4 Apr 2012 02:19:31 +0000 (02:19 +0000)]
I don't know why I'm so sloppy today. Another build fix.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrevent spellchecking text pasted to an element having spellchecking disabled
hbono@chromium.org [Wed, 4 Apr 2012 02:18:49 +0000 (02:18 +0000)]
Prevent spellchecking text pasted to an element having spellchecking disabled
https://bugs.webkit.org/show_bug.cgi?id=81323

Reviewed by Hajime Morita.

This change prevent calling SpellChecker::requestCheckingFor when pasting text
to an element whose spellcheck attribute is false or a password input.

Source/WebCore:

Test: editing/spelling/spellcheck-paste-disabled.html

* editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment): Disabled spellchecking on password inputs.
* editing/SpellChecker.cpp:
(WebCore::SpellChecker::isCheckable): Return false when spellchecking is disabled.

LayoutTests:

* editing/spelling/spellcheck-paste-disabled-expected.txt: Added.
* editing/spelling/spellcheck-paste-disabled.html: Added.
* platform/efl/Skipped: Skipped due to the lack of requestCheckingOfString().
* platform/gtk/Skipped: ditto.
* platform/mac-leopard/Skipped: ditto.
* platform/mac-lion/Skipped: ditto.
* platform/mac-wk2/Skipped: ditto.
* platform/qt/Skipped: ditto.
* platform/win-wk2/Skipped: ditto.
* platform/win/Skipped: ditto.
* platform/wincairo/Skipped: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake it possible to install the JavaScriptCore test tools.
mrowe@apple.com [Wed, 4 Apr 2012 02:12:40 +0000 (02:12 +0000)]
Make it possible to install the JavaScriptCore test tools.

Part of <rdar://problem/11158607>.

Reviewed by Filip Pizlo.

* JavaScriptCore.xcodeproj/project.pbxproj: Introduce an aggregate target named
Test Tools that builds testapi, minidom and testRegExp. Switch All from depending on
those targets individually to depending on the new aggregate target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake FocusController use a ComposedShadowTreeWalker, instead of ReifiedTreeTraversal...
hayato@chromium.org [Wed, 4 Apr 2012 02:11:42 +0000 (02:11 +0000)]
Make FocusController use a ComposedShadowTreeWalker, instead of ReifiedTreeTraversal APIs.
https://bugs.webkit.org/show_bug.cgi?id=82694

Reviewed by Dimitri Glazkov.

Rewrite a focus controller so that it uses ComposedShadowTreeWalker
since that is a preferred way to traverse composed shadow tree.
I'll get rid of ReifiedTreeTraversal in follow-up patches, which is now deprecated.

No new tests. No change in functionality.

* page/FocusController.cpp:
(WebCore::walkerFrom):
(WebCore):
(WebCore::walkerFromNext):
(WebCore::walkerFromPrevious):
(WebCore::nextNode):
(WebCore::previousNode):
(WebCore::FocusController::findNodeWithExactTabIndex):
(WebCore::nextNodeWithGreaterTabIndex):
(WebCore::previousNodeWithLowerTabIndex):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHopefully the last build fix for Chromium Windows.
rniwa@webkit.org [Wed, 4 Apr 2012 01:49:00 +0000 (01:49 +0000)]
Hopefully the last build fix for Chromium Windows.

Explicitly execute new-run-webkit-tests and old-run-webkit-tests by python and perl.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Crash in ~GraphicsContext3D() when init failed
commit-queue@webkit.org [Wed, 4 Apr 2012 01:44:10 +0000 (01:44 +0000)]
[Qt] Crash in ~GraphicsContext3D() when init failed
https://bugs.webkit.org/show_bug.cgi?id=82992

Patch by Srikumar Bonda <srikumar.b@gmail.com> on 2012-04-03
Reviewed by Luiz Agostini.

WebKit crashes in ~GraphicsContext3D() while freeing the variables which are
not even allocated because of the init failure in GraphicsContext3D() for Qt.
In addition, Added a safety check in makeContextCurrent() before accessing
GraphicsContext3DPrivate object.

No new tests because the change is about adding null check
before accessing the variables.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Lots of timeouts causing Mac10.6 to exit early.
dpranke@chromium.org [Wed, 4 Apr 2012 01:40:39 +0000 (01:40 +0000)]
[Chromium] Lots of timeouts causing Mac10.6 to exit early.
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, build fix (slightly reviewed by Simon Fraser and Eric Seidel, but not approved).

Add logic to the apple mac and chromium mac code to not use
too many workers; it looks like the xserves (and possibly mac
pros) count hyperthreaded cores when they really shouldn't and
we end up using too many workers at a time; this leads to tests
thrashing and timing out.

This change is a temporary fix to make the bots happy while I
look into more profiling and other fixes.

* Scripts/webkitpy/layout_tests/port/mac.py:
(ChromiumMacPort.default_child_processes):

* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.default_child_processes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOfflineasm ARM backend has a very convoluted way of saying it wants to emit a
fpizlo@apple.com [Wed, 4 Apr 2012 01:38:46 +0000 (01:38 +0000)]
Offlineasm ARM backend has a very convoluted way of saying it wants to emit a
three-operand multiply instruction
https://bugs.webkit.org/show_bug.cgi?id=83100

Reviewed by Darin Adler.

Changed the "muli"/"mulp" case to call emitArmV7() since that helper method was
already smart enough to do the Right Thing for multiply.

* offlineasm/armv7.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening: skip LayoutTest/storage/domstorage/quota.html
michaeln@google.com [Wed, 4 Apr 2012 01:30:13 +0000 (01:30 +0000)]
[chromium] Unreviewed gardening: skip LayoutTest/storage/domstorage/quota.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd audit token to PHCheckInWithPluginHost
andersca@apple.com [Wed, 4 Apr 2012 01:28:32 +0000 (01:28 +0000)]
Add audit token to PHCheckInWithPluginHost
https://bugs.webkit.org/show_bug.cgi?id=83102

Reviewed by Sam Weinig.

* Plugins/Hosted/WebKitPluginHost.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test media/video-source-error.html is flaky on cr-win
fischman@chromium.org [Wed, 4 Apr 2012 01:26:00 +0000 (01:26 +0000)]
Layout Test media/video-source-error.html is flaky on cr-win
https://bugs.webkit.org/show_bug.cgi?id=80068

Unreviewed; test is no longer showing up on flakiness dashboard.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKitTestRunner's EventSender is leaky
simon.fraser@apple.com [Wed, 4 Apr 2012 01:06:43 +0000 (01:06 +0000)]
WebKitTestRunner's EventSender is leaky
https://bugs.webkit.org/show_bug.cgi?id=83099

Reviewed by Beth Dakin.

Fix leaks of WKNumbers by using the adoptWK idiom, and make
all the code consistent.

* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::leapForward):
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::mouseScrollBy):
(WTR::EventSendingController::addTouchPoint):
(WTR::EventSendingController::updateTouchPoint):
(WTR::EventSendingController::setTouchModifier):
(WTR::EventSendingController::releaseTouchPoint):
(WTR::EventSendingController::cancelTouchPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Include Image.h in TextFieldDecoratorImpl.cpp
commit-queue@webkit.org [Wed, 4 Apr 2012 01:03:43 +0000 (01:03 +0000)]
[chromium] Include Image.h in TextFieldDecoratorImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=83066

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-03
Reviewed by James Robinson.

* src/TextFieldDecoratorImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother build fix. Don't use old-run-webkit-tests on Chromium Windows bots.
rniwa@webkit.org [Wed, 4 Apr 2012 01:02:05 +0000 (01:02 +0000)]
Another build fix. Don't use old-run-webkit-tests on Chromium Windows bots.

* Scripts/run-webkit-tests:
(useNewRunWebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agokill-old-processes should kill apache2 and httpd
rniwa@webkit.org [Wed, 4 Apr 2012 00:57:32 +0000 (00:57 +0000)]
kill-old-processes should kill apache2 and httpd
https://bugs.webkit.org/show_bug.cgi?id=83065

Reviewed by Tony Chang.

Kill apache2 and httpd on Mac and Linux (Windows uses lighttpd) to free up port 8000.

* BuildSlaveSupport/kill-old-processes:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOfflineasm ARM backend uses the wrong mnemonic for multiply
fpizlo@apple.com [Wed, 4 Apr 2012 00:50:07 +0000 (00:50 +0000)]
Offlineasm ARM backend uses the wrong mnemonic for multiply
https://bugs.webkit.org/show_bug.cgi?id=83098
<rdar://problem/11168744>

Reviewed by Gavin Barraclough.

Use "mul" instead of "muls" since we're passing three operands, not two.

* offlineasm/armv7.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLinux crashes during boot
barraclough@apple.com [Wed, 4 Apr 2012 00:29:52 +0000 (00:29 +0000)]
Linux crashes during boot
https://bugs.webkit.org/show_bug.cgi?id=83096

Reviewed by Filip Pizlo.

The bug here is that we add empty JSValues to the sparse map, and then set them
- but a GC may occur before doing so (due to a call to reportExtraMemory cost).
We may want to consider making it safe to mark empty JSValues, but the simple &
contained fix to this specific bug is to just initialize these values to
something other than JSValue().

* runtime/JSArray.cpp:
(JSC::SparseArrayValueMap::add):
    - Initialize sparse map entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse V8 completion callback API to assert that V8RecursionScope is on the stack whenev...
rafaelw@chromium.org [Wed, 4 Apr 2012 00:28:24 +0000 (00:28 +0000)]
Use V8 completion callback API to assert that V8RecursionScope is on the stack whenever invoking script
https://bugs.webkit.org/show_bug.cgi?id=79131

Reviewed by Adam Barth.

Source/WebCore:

End-of-microtask work (cancelling outstanding IDB transactions,
delivering DOM mutations) depend on V8RecursionScope being on the
stack whenever a call is made into script. V8 provides a completion
callback API that could be used to hook these "end-of-microtask"
events, but it turns out that WebKit calls into script for various
reasons besides running script from the page. For example, constructing
wrapper objects from function templates counts as "running script",
yet it's not appropriate to run this callback every time a JS wrapper
is constructed.

Instead, this patch makes use of the V8 completion callback mechanism
only in debug mode, to assert that either a V8RecursionScope (when
calling author script) or a V8RecursionScope::MicrotaskSuppression
(when calling non-author script) is on the stack when V8 thinks it's
finished executing script. This requires dropping MicrotaskSuppression
objects in a bunch of places, most notably the Inspector.
Note that in release mode, this class does nothing and thus should be
optimized away.

No new tests. Existing tests have appropriate coverage.

* Target.pri:
* WebCore.gypi:
* bindings/v8/DateExtension.cpp:
(WebCore::DateExtension::setAllowSleep):
* bindings/v8/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::addListener):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::callFunctionEvenIfScriptDisabled):
(WebCore):
(WebCore::ScriptController::collectGarbage):
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::callDebuggerMethod):
(WebCore):
(WebCore::ScriptDebugServer::pauseOnExceptionsState):
(WebCore::ScriptDebugServer::setPauseOnExceptionsState):
(WebCore::ScriptDebugServer::stepIntoStatement):
(WebCore::ScriptDebugServer::stepOverStatement):
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::setScriptSource):
(WebCore::ScriptDebugServer::currentCallFrame):
(WebCore::ScriptDebugServer::handleV8DebugEvent):
(WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
* bindings/v8/ScriptDebugServer.h:
(ScriptDebugServer):
* bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
* bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
* bindings/v8/V8Binding.h:
(V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::internalScriptRecursionLevel):
(WebCore::V8BindingPerIsolateData::incrementInternalScriptRecursionLevel):
(WebCore::V8BindingPerIsolateData::decrementInternalScriptRecursionLevel):
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8NPObject.cpp:
* bindings/v8/V8RecursionScope.h:
(WebCore):
(WebCore::V8RecursionScope::recursionLevel):
(V8RecursionScope):
(WebCore::V8RecursionScope::properlyUsed):
(MicrotaskSuppression):
(WebCore::V8RecursionScope::MicrotaskSuppression::MicrotaskSuppression):
(WebCore::V8RecursionScope::MicrotaskSuppression::~MicrotaskSuppression):
* bindings/v8/WorkerContextExecutionProxy.cpp:
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::WrapInShadowObject):
* bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createInjectedScript):
* bindings/v8/custom/V8ScriptProfileCustom.cpp:
* bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebFrame.h:
(v8):
(WebFrame):
* src/WebFrameImpl.cpp:
(WebKit):
(WebKit::WebFrameImpl::callFunctionEvenIfScriptDisabled):
* src/WebFrameImpl.h:
(WebFrameImpl):
* src/WebKit.cpp:
(WebKit):
(WebKit::assertV8RecursionScope):
(WebKit::initialize):
(WebKit::shutdown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMakes sure m_showingByDefault is set to false when TextTrack.mode is set from JS.
annacc@chromium.org [Wed, 4 Apr 2012 00:04:21 +0000 (00:04 +0000)]
Makes sure m_showingByDefault is set to false when TextTrack.mode is set from JS.
https://bugs.webkit.org/show_bug.cgi?id=79791

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-mode.html

* html/track/TextTrack.cpp:
(WebCore::TextTrack::setMode): setMode should always setShowingByDefault to false.

LayoutTests:

* media/track/track-mode-expected.txt: Added.
* media/track/track-mode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoManual submission for bug 82942.
jpu@apple.com [Tue, 3 Apr 2012 23:38:38 +0000 (23:38 +0000)]
Manual submission for bug 82942.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. This patch adds an ugly, ugly hack to bandaid over the
abarth@webkit.org [Tue, 3 Apr 2012 23:26:28 +0000 (23:26 +0000)]
Unreviewed. This patch adds an ugly, ugly hack to bandaid over the
Windows component build. See comments in the code for details.

Source/Platform:

* chromium/public/WebMediaStreamSourcesRequest.h:
(WebMediaStreamSourcesRequest):

Source/WebCore:

* platform/chromium/support/WebMediaStreamSourcesRequest.cpp:
(WebKit::WebMediaStreamSourcesRequest::dummy):
(WebKit):

Source/WebKit/chromium:

* src/WebKit.cpp:
(WebKit::shutdown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun the same test steps on test only bots as on build-and-test bots
tony@chromium.org [Tue, 3 Apr 2012 23:25:10 +0000 (23:25 +0000)]
run the same test steps on test only bots as on build-and-test bots
https://bugs.webkit.org/show_bug.cgi?id=83090

Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(TestFactory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r113087.
dglazkov@chromium.org [Tue, 3 Apr 2012 23:04:21 +0000 (23:04 +0000)]
Unreviewed, rolling out r113087.
http://trac.webkit.org/changeset/113087
https://bugs.webkit.org/show_bug.cgi?id=83068

Breaks Windows builds in other unpredictable ways.

* WebKit.gyp: Removed the hack.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a Media watchlist.
fischman@chromium.org [Tue, 3 Apr 2012 23:04:11 +0000 (23:04 +0000)]
Add a Media watchlist.
https://bugs.webkit.org/show_bug.cgi?id=83071

Reviewed by David Levin.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix large leak in WebKitTestRunner
simon.fraser@apple.com [Tue, 3 Apr 2012 22:58:47 +0000 (22:58 +0000)]
Fix large leak in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=83084

Reviewed by Beth Dakin.

Fix a leak of the bimap backing store created when doing pixel and
ref tests. This leak was causing serious thrash on the test bots.

We don't need to allocate memory for CGBitmapContextCreate(); if we
pass NULL, it will allocate and manage its own backing store.

* WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::createCGContextFromImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Remove #if !USE(TILED_BACKING_STORE) from WebFrameLoaderClient::transitionT...
commit-queue@webkit.org [Tue, 3 Apr 2012 22:54:07 +0000 (22:54 +0000)]
[Qt][WK2] Remove #if !USE(TILED_BACKING_STORE) from WebFrameLoaderClient::transitionToCommittedForNewPage()
https://bugs.webkit.org/show_bug.cgi?id=83070

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-03
Reviewed by Andreas Kling.

It is preventing m_frameHasCustomRepresentation to be set properly and not in sync with
WebFrameLoaderClient::transitionToCommittedFromCachedFrame()

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in SelectorChecker::checkOneSelector.
inferno@chromium.org [Tue, 3 Apr 2012 22:51:44 +0000 (22:51 +0000)]
Crash in SelectorChecker::checkOneSelector.
https://bugs.webkit.org/show_bug.cgi?id=83040

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/css/css-set-selector-text-crash.html

Removing the early bail when we detect that our selector text
hasn't changed, and we don't notify the styleSelectorChanged.
In fact, when we adopt the new selector list, the old one will
get destroyed and the styleSelectorChanged call needs to be made.

* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):

LayoutTests:

* fast/css/css-set-selector-text-crash-expected.txt: Added.
* fast/css/css-set-selector-text-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agopresentationAttributeCacheMaximumSize is set too low
jchaffraix@webkit.org [Tue, 3 Apr 2012 22:39:13 +0000 (22:39 +0000)]
presentationAttributeCacheMaximumSize is set too low
https://bugs.webkit.org/show_bug.cgi?id=82816

Reviewed by Antti Koivisto.

Performance change, no side effects anticipated.

Prior to r106740, the presentation attribute style cache used to grow unbounded. As part of r110316,
a different version of the cache was introduced with a maximum size of 128. This size gave a 75% hit rate.

However this is bad as the previous cache had a 85% hit rate** and each miss propagate down to the matched
properties cache as we use pointer comparisons.

This change bumps the size to 4096. This size was chosen to bring us back to the previous hit rate while
being a power of 2 (it is the HashMap maximum size). The steep increase is due to the combinational compexity
of the new cache model: we need to match all our attributes' name, value and tag name to get a hit vs
one attribute name, value and a category in the previous cache. To avoid blowing up the memory, we introduced
a timer to clear the cache if the hit rate is too low.

The measured hit rate is actually better now - in the 90% range on most page cyclers. This ups the matched
properties hit rate by 1 percent point on presentation attributes.

** This is not a true apple-to-apple comparison as the cache model was changed.

* dom/StyledElement.cpp:
(PresentationAttributeCacheCleaner):
(WebCore::PresentationAttributeCacheCleaner::PresentationAttributeCacheCleaner):
(WebCore::PresentationAttributeCacheCleaner::didHitPresentationAttributeCache):
(WebCore::PresentationAttributeCacheCleaner::cleanCache):
(WebCore):
(WebCore::presentationAttributeCacheCleaner):
(WebCore::StyledElement::updateAttributeStyle):
Added the logic to clean the presentation attribute cache if we drop below 100 hits per minutes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement new flex property and deprecate flex function
tony@chromium.org [Tue, 3 Apr 2012 22:34:03 +0000 (22:34 +0000)]
Implement new flex property and deprecate flex function
https://bugs.webkit.org/show_bug.cgi?id=82128

Reviewed by Ojan Vafai.

Source/WebCore:

No new tests. Tests were updated to use the new syntax and they should
all pass.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredFlexLengthForChild): Grab the
preferred size and if it's auto, fall back to width or height.
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::positiveFlexForChild): Use the value from the flex property.
(WebCore::RenderFlexibleBox::negativeFlexForChild): Use the value from the flex property.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
* rendering/RenderFlexibleBox.h:

LayoutTests:

Update tests to use the -webkit-flex: propery instead of the function.
In most cases this was just a simple find & replace, but in a few cases
we had to clear the flex value.

* css3/flexbox/auto-height-dynamic.html:
* css3/flexbox/child-overflow.html:
* css3/flexbox/columns-auto-size.html:
* css3/flexbox/cross-axis-scrollbar.html:
* css3/flexbox/flex-algorithm-min-max.html:
* css3/flexbox/flex-algorithm-with-margins.html:
* css3/flexbox/flex-algorithm.html:
* css3/flexbox/flex-align-column.html:
* css3/flexbox/flex-align-max.html:
* css3/flexbox/flex-align-percent-height.html:
* css3/flexbox/flex-align-stretch.html:
* css3/flexbox/flex-align-vertical-writing-mode.html:
* css3/flexbox/flex-align.html:
* css3/flexbox/flex-flow-border.html:
* css3/flexbox/flex-flow-margins-auto-size-expected.txt: This test had expected failures that needed to be updated.
* css3/flexbox/flex-flow-margins-auto-size.html:
* css3/flexbox/flex-flow-margins.html:
* css3/flexbox/flex-flow-overflow.html:
* css3/flexbox/flex-flow-padding.html:
* css3/flexbox/flex-flow.html:
* css3/flexbox/flex-no-flex.html:
* css3/flexbox/flex-order.html:
* css3/flexbox/flex-pack.html:
* css3/flexbox/line-wrapping.html:
* css3/flexbox/multiline-align.html:
* css3/flexbox/multiline-line-pack-horizontal-column.html:
* css3/flexbox/multiline-reverse-wrap-baseline.html:
* css3/flexbox/multiline-reverse-wrap-overflow.html:
* css3/flexbox/multiline.html:
* css3/flexbox/orthogonal-flex-directions.html:
* css3/flexbox/position-absolute-child.html:
* css3/flexbox/repaint-rtl-column.html:
* css3/flexbox/repaint.html:
* css3/flexbox/writing-modes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSearch result page scrolls up before the correct page opens from google search
andersca@apple.com [Tue, 3 Apr 2012 22:26:21 +0000 (22:26 +0000)]
Search result page scrolls up before the correct page opens from google search
https://bugs.webkit.org/show_bug.cgi?id=81280
<rdar://problem/10973263>

Reviewed by Sam Weinig.

Make the requested scroll position part of the ScrollingTreeState so any changes being made
are in sync with other important changes such as the scroll layer or contents size.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
Use coordinatesScrollingForFrameView instead of checking if the frame is the main frame.

(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
Call ScrollingTreeState::setRequestedScrollPosition.

(WebCore::ScrollingCoordinator::setScrollLayer):
Reset the requested scroll position.

* page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::setRequestedScrollPosition):
Keep track of the scroll position.

* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
Update the scroll position if it's changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Switch touchpad fling curve physics to absolute (not scaled) curve.
wjmaclean@chromium.org [Tue, 3 Apr 2012 22:02:58 +0000 (22:02 +0000)]
[chromium] Switch touchpad fling curve physics to absolute (not scaled) curve.
https://bugs.webkit.org/show_bug.cgi?id=83061

Reviewed by James Robinson.

Source/WebCore:

Revised existing unit tests.

Use an absolute curve for touchpad fling. Here we identify the location on the curve corresponding
to the initial fling velocity, and "jump in" at that point. Avoids issues around time/magnitude
scaling present in previous implementation, and gives better feel to fling animation.

* platform/TouchpadFlingPlatformGestureCurve.cpp:
(WebCore):
(WebCore::TouchpadFlingPlatformGestureCurve::create):
(WebCore::position):
(WebCore::velocity):
(WebCore::TouchpadFlingPlatformGestureCurve::TouchpadFlingPlatformGestureCurve):
(WebCore::TouchpadFlingPlatformGestureCurve::apply):
* platform/TouchpadFlingPlatformGestureCurve.h:
(TouchpadFlingPlatformGestureCurve):

Source/WebKit/chromium:

* tests/PlatformGestureCurveTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother build fix after r113067. Close the zipfile after extracting all files so...
rniwa@webkit.org [Tue, 3 Apr 2012 22:01:05 +0000 (22:01 +0000)]
Another build fix after r113067. Close the zipfile after extracting all files so that we can remove it.

* BuildSlaveSupport/built-product-archive:
(unzipArchive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttp/tests/media/video-cancel-load.html is flaky on linux
fischman@chromium.org [Tue, 3 Apr 2012 21:52:11 +0000 (21:52 +0000)]
http/tests/media/video-cancel-load.html is flaky on linux
https://bugs.webkit.org/show_bug.cgi?id=82508

Unreviewed, removing no-longer-needed expectation.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement WebGLShaderPrecisionFormat
zmo@google.com [Tue, 3 Apr 2012 21:48:37 +0000 (21:48 +0000)]
Implement WebGLShaderPrecisionFormat
https://bugs.webkit.org/show_bug.cgi?id=75925

Reviewed by Kenneth Russell.

Source/Platform:

* chromium/public/WebGraphicsContext3D.h: Add getShaderPrecisionFormat().
(WebGraphicsContext3D):

Source/WebCore:

Test: fast/canvas/webgl/shader-precision-format.html

* CMakeLists.txt: Add new source files webglshaderprecisionformat.h/idl
* DerivedSources.make: Ditto.
* DerivedSources.pri: Ditto.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* html/canvas/WebGLRenderingContext.cpp: Add getShaderPrecisionFormat.
(WebCore):
(WebCore::WebGLRenderingContext::getShaderPrecisionFormat):
* html/canvas/WebGLRenderingContext.h: Ditto.
(WebCore):
(WebGLRenderingContext):
* html/canvas/WebGLRenderingContext.idl: Ditto.
* html/canvas/WebGLShaderPrecisionFormat.h: Added.
(WebCore):
(WebGLShaderPrecisionFormat):
(WebCore::WebGLShaderPrecisionFormat::create):
(WebCore::WebGLShaderPrecisionFormat::rangeMin):
(WebCore::WebGLShaderPrecisionFormat::rangeMax):
(WebCore::WebGLShaderPrecisionFormat::precision):
(WebCore::WebGLShaderPrecisionFormat::WebGLShaderPrecisionFormat):
* html/canvas/WebGLShaderPrecisionFormat.idl: Added.
* page/DOMWindow.idl: Expose new type WebGLShaderPrecisionFormat for instanceof.
* platform/graphics/GraphicsContext3D.h: Add getShaderPrecisionFormat().
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Ditto.
(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
(WebCore):
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp: Ditto.
(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
(WebCore):
* platform/graphics/qt/GraphicsContext3DQt.cpp: Ditto.
(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
(WebCore):

Source/WebKit/chromium:

* src/GraphicsContext3DChromium.cpp: Add getShaderPrecisionFormat().
(WebCore):
* src/GraphicsContext3DPrivate.h: Ditto.
(GraphicsContext3DPrivate):
* tests/FakeWebGraphicsContext3D.h: Ditto.
(FakeWebGraphicsContext3D):

LayoutTests:

* fast/canvas/webgl/instanceof-test-expected.txt: Add new WebGLShaderPrecisionFormat failure.
* fast/canvas/webgl/instanceof-test.html:
* fast/canvas/webgl/shader-precision-format-expected.txt: Added.
* fast/canvas/webgl/shader-precision-format.html: Added.
* fast/dom/Window/script-tests/window-property-descriptors.js: Add new type WebGLShaderPrecisionFormat.
* fast/dom/Window/window-properties.html: Ditto.
* fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
(constructorNamesForWindow):
* fast/dom/script-tests/prototype-inheritance.js: Ditto.
* fast/js/script-tests/global-constructors.js: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Frame flattening: Do not restart layout from parent frame, when the...
commit-queue@webkit.org [Tue, 3 Apr 2012 21:35:08 +0000 (21:35 +0000)]
Source/WebCore: Frame flattening: Do not restart layout from parent frame, when the parent is clean.
https://bugs.webkit.org/show_bug.cgi?id=81114

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-03
Reviewed by Antti Koivisto.

When frame flattening is on, child frames try to mark the ancestors dirty
to be able to restart layout from the main frame. Child frames mark the
anchestors in FrameView::scheduleRelayout(). Marking fails when scheduling is disabled,
for example when the iframe's <head> has blocking resource and the <body> has not
been injected into the document.
When marking ancestor fails, child frame layout needs to continue normally.
It is expected to have layouts, when scheduling is enabled.

Test: http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html

* page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::isInChildFrameWithFrameFlattening):
(WebCore):
(WebCore::FrameView::doLayoutWithFrameFlattening):
* page/FrameView.h:
(FrameView):

LayoutTests: Add test case for 3 level nested iframes with frame flattening on.
https://bugs.webkit.org/show_bug.cgi?id=81114

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-03
Reviewed by Antti Koivisto.

* http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource-expected.txt: Added.
* http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html: Added.
* http/tests/misc/resources/3rd-level-iframe-with-blocking-resource.php: Added.
* http/tests/misc/resources/nested-iframe-loading-another-iframe.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAvoid virtual method calls in the GraphicsLayer destructor
simon.fraser@apple.com [Tue, 3 Apr 2012 21:30:27 +0000 (21:30 +0000)]
Avoid virtual method calls in the GraphicsLayer destructor
https://bugs.webkit.org/show_bug.cgi?id=83067

Reviewed by James Robinson.

Code cleanup to avoid calling virtual methods in the GraphicsLayer
destructor. Factor teardown code into a willBeDestroyed() method
that is called from the most dervied class. willBeDestroyed()
calls have to be chained. Fix the various ports' GraphicsLayer
implementations.

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore):
(WebCore::GraphicsLayer::willBeDestroyed):
* platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::~GraphicsLayerBlackBerry):
(WebCore):
(WebCore::GraphicsLayerBlackBerry::willBeDestroyed):
* platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
(GraphicsLayerBlackBerry):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::~GraphicsLayerCA):
(WebCore):
(WebCore::GraphicsLayerCA::willBeDestroyed):
* platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
* platform/graphics/efl/GraphicsLayerEfl.cpp:
(WebCore::GraphicsLayerEfl::~GraphicsLayerEfl):
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQt::~GraphicsLayerQt):
(WebCore):
(WebCore::GraphicsLayerQt::willBeDestroyed):
* platform/graphics/qt/GraphicsLayerQt.h:
(GraphicsLayerQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[skia] Switch to Skia's implementation of the feMorphology filter.
commit-queue@webkit.org [Tue, 3 Apr 2012 21:29:16 +0000 (21:29 +0000)]
[skia] Switch to Skia's implementation of the feMorphology filter.
https://bugs.webkit.org/show_bug.cgi?id=82085

Unreviewed Chromium expectations rebaseline.

Patch by Florin Malita <fmalita@google.com> on 2012-04-03

* platform/chromium-linux/svg/filters/filterRes-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/filterRes-expected.png: Removed.
* platform/chromium-mac/svg/filters/filterRes-expected.png: Added.
* platform/chromium-win/svg/filters/filterRes-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHaving a drop handler prevents navigation on drop even if event is not cancelled
dcheng@chromium.org [Tue, 3 Apr 2012 21:21:46 +0000 (21:21 +0000)]
Having a drop handler prevents navigation on drop even if event is not cancelled
https://bugs.webkit.org/show_bug.cgi?id=79172

Reviewed by Ryosuke Niwa.

Source/WebCore:

Only early return if the drop handler prevents the default action.
http://trac.webkit.org/changeset/105396 introduced this issue when fixing some other aspects
of DnD handling.

Test: fast/events/drop-handler-should-not-stop-navigate.html

* page/DragController.cpp:
(WebCore::DragController::performDrag):
(WebCore::DragController::concludeEditDrag): Remove the assert. By definition, we want to
    allow default actions to run now if they weren't explicitly canceled.

LayoutTests:

* fast/events/drag-dataTransferItemList.html: Fix drop handler to prevent default.
* fast/events/drop-handler-should-not-stop-navigate-expected.txt: Added.
* fast/events/drop-handler-should-not-stop-navigate.html: Added.
* http/tests/security/clipboard/clipboard-file-access.html: Change dragover to drop handler
    to prevent bubbled events from causing navigation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agodisable incremental linking for debug of webkit
dpranke@chromium.org [Tue, 3 Apr 2012 21:17:59 +0000 (21:17 +0000)]
disable incremental linking for debug of webkit
https://bugs.webkit.org/show_bug.cgi?id=83068

Reviewed by Adam Barth.

Now that we need to export symbols from webkit.dll that are
defined in webcore_platform, we have to enable ULDI in order for
incremental linking to work (which is used in debug mode).

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[v8] Fix memory leak in V8LazyEventListener
arv@chromium.org [Tue, 3 Apr 2012 20:59:10 +0000 (20:59 +0000)]
[v8] Fix memory leak in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=83057

Reviewed by Ojan Vafai.

Source/WebCore:

This also brings the V8 and JSC implementation closer. The timing when we first lookup
the form element is now same in JSC and V8 (but different from Mozilla).

This also clears the strings once the code has been parsed and the function created.

Tests: fast/dom/inline-event-attributes-moved.html
       fast/dom/inline-event-attributes-release.html

* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::V8LazyEventListener):
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8LazyEventListener.h:
(WebCore::V8LazyEventListener::create):
(V8LazyEventListener):

LayoutTests:

* fast/dom/inline-event-attributes-moved-expected.txt: Added.
* fast/dom/inline-event-attributes-moved.html: Added.
* fast/dom/inline-event-attributes-release-expected.txt: Added.
* fast/dom/inline-event-attributes-release.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore rebaselines after WK79568
commit-queue@webkit.org [Tue, 3 Apr 2012 20:56:17 +0000 (20:56 +0000)]
More rebaselines after WK79568
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed test expectations update.

Patch by Philip Rogers <pdr@google.com> on 2012-04-03

* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Removed.
* platform/chromium-linux/svg/css/group-with-shadow-expected.png: Removed.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
* platform/chromium-mac-leopard/svg/css/group-with-shadow-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
* platform/chromium-win-vista/svg/css/group-with-shadow-expected.png: Removed.
* platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
* platform/chromium-win/svg/css/group-with-shadow-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGive more human friendly error message when builders fail to load or have stale data.
ojan@chromium.org [Tue, 3 Apr 2012 20:53:41 +0000 (20:53 +0000)]
Give more human friendly error message when builders fail to load or have stale data.
https://bugs.webkit.org/show_bug.cgi?id=83058

Reviewed by Eric Seidel.

* TestResultServer/static-dashboards/dashboard_base.js:
(addError):
(addBuilderLoadErrors):
(handleLocationChange):
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntegrate IETC CSS : borders and backgrounds tests
tomz@codeaurora.org [Tue, 3 Apr 2012 20:50:45 +0000 (20:50 +0000)]
Integrate IETC CSS : borders and backgrounds tests
https://bugs.webkit.org/show_bug.cgi?id=82734

Unreviewed test expectation updates

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-03

* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
* platform/chromium-win-xp/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFrequent crashes in JSC::parse in a worker thread when running regression tests
msaboff@apple.com [Tue, 3 Apr 2012 20:40:36 +0000 (20:40 +0000)]
Frequent crashes in JSC::parse in a worker thread when running regression tests
https://bugs.webkit.org/show_bug.cgi?id=82660

Reviewed by Geoffrey Garen.

Source/WebCore:

Initialize m_script to empty string.  Therefore if there isn't any script payload,
the worker thread will see an empty string, not a null string.

Re-enabling fast/workers/empty-worker-nocrash.html and
fast/workers/shared-worker-constructor.html tests as part of this patch.

* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::WorkerScriptLoader):

LayoutTests:

Re-enable fast/workers/empty-worker-nocrash.html and
fast/workers/shared-worker-constructor.html with corresponding fix.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Enable sparkline FPS counter in threaded compositing mode
commit-queue@webkit.org [Tue, 3 Apr 2012 20:36:32 +0000 (20:36 +0000)]
[chromium] Enable sparkline FPS counter in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=82959

Patch by James Robinson <jamesr@chromium.org> on 2012-04-03
Reviewed by Adrienne Walker.

This enables rendering the FPS counter sparkline when in threaded compositing mode. We don't currently have a
way to draw text from the thread (since we can't interact with WebCore::Font objects from a non-main thread),
but having a sparkline is still useful for judging framerate stability.

There are no tests for the HUD since it's a developer-facing feature and not user-facing.

* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore):
(WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::initializeFonts):
(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):
(WebCore::CCHeadsUpDisplay::drawPlatformLayerTree):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(CCHeadsUpDisplay):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAgain, a build fix after r113067. Don't call r113067 twice on the configuration build...
rniwa@webkit.org [Tue, 3 Apr 2012 20:32:40 +0000 (20:32 +0000)]
Again, a build fix after r113067. Don't call r113067 twice on the configuration build directory.

* BuildSlaveSupport/built-product-archive:
(extractBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix incorrect comment in CCDamageTrackerTest
shawnsingh@chromium.org [Tue, 3 Apr 2012 20:16:05 +0000 (20:16 +0000)]
[chromium] Fix incorrect comment in CCDamageTrackerTest
https://bugs.webkit.org/show_bug.cgi?id=82118

Reviewed by Adrienne Walker.

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoYet another build fix after r113067. Don't trigger Chromium testers right away
rniwa@webkit.org [Tue, 3 Apr 2012 20:15:00 +0000 (20:15 +0000)]
Yet another build fix after r113067. Don't trigger Chromium testers right away
since they're now triggered by builders.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS 2.1 failure: at-import-009.htm fails
robert@webkit.org [Tue, 3 Apr 2012 20:14:18 +0000 (20:14 +0000)]
CSS 2.1 failure: at-import-009.htm fails
https://bugs.webkit.org/show_bug.cgi?id=82921

Source/WebCore:

Reviewed by Antti Koivisto.

This fixes at-import-009.htm only, the other tests already passed.

Tests: css2.1/20110323/at-import-001.htm
       css2.1/20110323/at-import-002.htm
       css2.1/20110323/at-import-003.htm
       css2.1/20110323/at-import-004.htm
       css2.1/20110323/at-import-005.htm
       css2.1/20110323/at-import-006.htm
       css2.1/20110323/at-import-007.htm
       css2.1/20110323/at-import-009.htm
       css2.1/20110323/at-import-010.htm
       css2.1/20110323/at-import-011.htm

* css/CSSGrammar.y: ignore empty '@media;' and '@charset;' declarations

LayoutTests:

Add the at-import-* tests from the CSS 2.1 suite. Skip at-import-008.htm
as it relies on a print media type to work.

Reviewed by Antti Koivisto.

* css2.1/20110323/at-import-001-expected.html: Added.
* css2.1/20110323/at-import-001.htm: Added.
* css2.1/20110323/at-import-002-expected.html: Added.
* css2.1/20110323/at-import-002.htm: Added.
* css2.1/20110323/at-import-003-expected.html: Added.
* css2.1/20110323/at-import-003.htm: Added.
* css2.1/20110323/at-import-004-expected.html: Added.
* css2.1/20110323/at-import-004.htm: Added.
* css2.1/20110323/at-import-005-expected.html: Added.
* css2.1/20110323/at-import-005.htm: Added.
* css2.1/20110323/at-import-006-expected.html: Added.
* css2.1/20110323/at-import-006.htm: Added.
* css2.1/20110323/at-import-007-expected.html: Added.
* css2.1/20110323/at-import-007.htm: Added.
* css2.1/20110323/at-import-009-expected.html: Added.
* css2.1/20110323/at-import-009.htm: Added.
* css2.1/20110323/at-import-010-expected.html: Added.
* css2.1/20110323/at-import-010.htm: Added.
* css2.1/20110323/at-import-011-expected.html: Added.
* css2.1/20110323/at-import-011.htm: Added.
* css2.1/20110323/support/at-import-001.css: Added.
* css2.1/20110323/support/at-import-002.css: Added.
* css2.1/20110323/support/at-import-004.css: Added.
* css2.1/20110323/support/at-import-005.css: Added.
* css2.1/20110323/support/at-import-006.css: Added.
* css2.1/20110323/support/at-import-007.css: Added.
* css2.1/20110323/support/import-green.css: Added.
* css2.1/20110323/support/import-red.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother build fix after r113067 for Mac port.
rniwa@webkit.org [Tue, 3 Apr 2012 20:05:06 +0000 (20:05 +0000)]
Another build fix after r113067 for Mac port.
It turned out that archiving the entire build directory doesn't work.

* BuildSlaveSupport/built-product-archive:
(createZipManually):
(createZip):
(archiveBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNext...
commit-queue@webkit.org [Tue, 3 Apr 2012 20:02:29 +0000 (20:02 +0000)]
[BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
https://bugs.webkit.org/show_bug.cgi?id=82643

Source/WebKit/blackberry:

Enhance BlackBerry::WebKit::WebPage::findNextString()

This patch adds support for toggling case sensitivity,
search wrapping, and whether or not to highlight all matches
in addition to the next found match.

I refactored and renamed the new setActiveMatchAndMarker() method
to move the active match from one range to another. This was
required because in the case of a non wrapped search we do not
want to adjust the m_activeMatch if another match is not found.

Internal Review by Andy Chen.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-03
Reviewed by Rob Buis.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::findNextString):
* Api/WebPage.h:
* WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::setActiveMatchAndMarker):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
* WebKitSupport/InPageSearchManager.h:
(InPageSearchManager):

Tools:

Update LayoutTestController to accomodate the new find API.
It now provides caseSensitive functionality to DRT.

Internal Review by Andy Chen.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-03
Reviewed by Rob Buis.

* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::findString):

LayoutTests:

Update findString-markers to also test caseSensitive.
All findString tests used to be case insensitive before.

Internal Review by Andy Chen.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-03
Reviewed by Rob Buis.

* platform/blackberry/editing/text-iterator/findString-markers-expected.txt:
* platform/blackberry/editing/text-iterator/findString-markers.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
rniwa@webkit.org [Tue, 3 Apr 2012 19:31:38 +0000 (19:31 +0000)]
Another build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
because download-built-product creates the build directory as needed.

This step fails on Chromium Windows due to -p option not supported by Windows' native mkdir.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(TestFactory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix after r113067. Don't delete the build directory.
rniwa@webkit.org [Tue, 3 Apr 2012 19:26:56 +0000 (19:26 +0000)]
Build fix after r113067. Don't delete the build directory.

* BuildSlaveSupport/built-product-archive:
(extractBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] remove dead function declarations in RenderSurfacechromium
shawnsingh@chromium.org [Tue, 3 Apr 2012 19:24:31 +0000 (19:24 +0000)]
[chromium] remove dead function declarations in RenderSurfacechromium
https://bugs.webkit.org/show_bug.cgi?id=82086

Reviewed by James Robinson.

No tests needed, no change in behavior.

* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate fast/regions expectations to match what's happening on
ojan@chromium.org [Tue, 3 Apr 2012 19:21:09 +0000 (19:21 +0000)]
Update fast/regions expectations to match what's happening on
the chromium bots.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLoad all builder lists from the buildbot json
ojan@chromium.org [Tue, 3 Apr 2012 19:08:48 +0000 (19:08 +0000)]
Load all builder lists from the buildbot json
https://bugs.webkit.org/show_bug.cgi?id=82998

Reviewed by Adam Barth.

Also, remove an unnecessary list of test types. Now we don't hard-code
builder names anywhere and we only have a single hard-coded list of
test types.

* TestResultServer/static-dashboards/builders.js:
(BuilderMaster.prototype.logPath):
(BuilderMaster.prototype.builderJsonPath):
(requestBuilderList.xhr.onload):
(requestBuilderList.xhr.onerror):
(isChromiumDepsFyiGpuTestRunner):
(isChromiumTipOfTreeGpuTestRunner):
(isChromiumDepsGTestRunner):
(isChromiumDepsCrosGTestRunner):
(isChromiumTipOfTreeGTestRunner):
(onBuilderListLoad):
(loadBuildersList):
* TestResultServer/static-dashboards/dashboard_base.js:
(parseCrossDashboardParameters):
(currentBuilderGroupCategory):
* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testHtmlForTestsWithExpectationsButNoFailures):
(testGenerateChromiumTipOfTreeGpuBuildersFromBuilderList):
(testGenerateChromiumDepsGTestBuildersFromBuilderList):
(testGenerateChromiumDepsCrosGTestBuildersFromBuilderList):
(testGenerateChromiumTipOfTreeGTestBuildersFromBuilderList):
* TestResultServer/static-dashboards/timeline_explorer.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium testers should extract builds instead of building on their own
rniwa@webkit.org [Tue, 3 Apr 2012 18:58:21 +0000 (18:58 +0000)]
Chromium testers should extract builds instead of building on their own
https://bugs.webkit.org/show_bug.cgi?id=82996

Reviewed by Tony Chang.

Make Chromium builders triggger Chromium testers and make testers download and extract builds
from the buildbot master instead of building binaries on their own.

Add download-built-product to wrap curl used in the download-built-product step since Windows
does not provide "curl" natively.

* BuildSlaveSupport/build.webkit.org-config/config.json: Add new triggerables for Chromium testers and make
Chromium builders trigger them. Also change the type of Chromium testers from NewBuildAndTest to Test.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(DownloadBuiltProduct): Call download-built-product instead of curl.
* BuildSlaveSupport/built-product-archive:
(createZip): Don't zip the parent configuration build directory like "release" and "debug". While Mac port
needs this behavior for compatibility reasons, Chromium Mac port doesn't want this behavior.
(archiveBuiltProduct): Zip the configuration build directory on Mac port.
(unzipArchive): Extracted. Use ditto on Mac, unzip on linux and cygwin, and zipfile package on Windows.
(extractBuiltProduct): Refactor the code to use removeDirectoryIfExists and unzipArchive. Support Chromium.
* BuildSlaveSupport/download-built-product: Added to wrap curl which isn't available on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
mrobinson@webkit.org [Tue, 3 Apr 2012 18:54:54 +0000 (18:54 +0000)]
[GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
https://bugs.webkit.org/show_bug.cgi?id=82473

Reviewed by Philippe Normand.

Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
was ever run.

* gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first
check if the user has ever run update-gtk-libs and, if so, then use jhbuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother attempt to fix the Windows build. This uses WebSecurityOrigin
abarth@webkit.org [Tue, 3 Apr 2012 18:26:34 +0000 (18:26 +0000)]
Another attempt to fix the Windows build.  This uses WebSecurityOrigin
has a value type but doesn't include the header.

* public/WebUserMediaRequest.h:
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAttempt to fix the Windows component build by including these headers
abarth@webkit.org [Tue, 3 Apr 2012 18:09:13 +0000 (18:09 +0000)]
Attempt to fix the Windows component build by including these headers
rather than forward declaring these objects.

* chromium/public/WebMediaStreamSourcesRequest.h:
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed. Follow up to inspector's r113032: change provisional method signature...
pfeldman@chromium.org [Tue, 3 Apr 2012 17:57:06 +0000 (17:57 +0000)]
Not reviewed. Follow up to inspector's r113032: change provisional method signature a bit.

* public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::save):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename GraphicsContext::drawLineForTextChecking() to GraphicsContext::drawLineForDocu...
jpu@apple.com [Tue, 3 Apr 2012 17:42:45 +0000 (17:42 +0000)]
Rename GraphicsContext::drawLineForTextChecking() to GraphicsContext::drawLineForDocumentMarker()
https://bugs.webkit.org/show_bug.cgi?id=82946

Reviewed by Enrica Casucci.

On OS X, we draw similar underline on dictated text that has alternative text. We rename
this function, so that we can reuse it for dictation underline.

No new tests, since there's no change of functionality.

* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* rendering/InlineTextBox.cpp:
(WebCore::lineStyleForMarkerType):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test media/video-src-source.html is flaky
fischman@chromium.org [Tue, 3 Apr 2012 17:39:13 +0000 (17:39 +0000)]
Layout Test media/video-src-source.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=82227

De-race the test by registering the listener before the event can fire.
Reviewed by Eric Carlson.

* media/video-src-source.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] media/video-delay-load-event.html is flaky on all platforms
fischman@chromium.org [Tue, 3 Apr 2012 17:34:05 +0000 (17:34 +0000)]
[Chromium] media/video-delay-load-event.html is flaky on all platforms
https://bugs.webkit.org/show_bug.cgi?id=64003

Explicitly request a .load() on the <video> element before expecting changes to its <source>
to be reflected, per the note in section 4.8.8 of the spec saying:
    Dynamically modifying a source element [...] when the element is already
    inserted [...] will have no effect. To change what is playing [...] call
    the load() method on the media element [...]

Reviewed by Eric Carlson.

* media/video-delay-load-event.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoESC key in full screen does not result in webkitFullScreenChange event.
jer.noble@apple.com [Tue, 3 Apr 2012 17:33:50 +0000 (17:33 +0000)]
ESC key in full screen does not result in webkitFullScreenChange event.
https://bugs.webkit.org/show_bug.cgi?id=82755
<rdar://problem/11093513>

Reviewed by Eric Carlson.

Source/WebCore:

* WebCore.exp.in: Export the WebCore::Document::webkitCancelFullScreen() symbol.

Source/WebKit/mac:

Instead of exiting full screen directly, ask the document to initiate exiting full screen. This ensures
that the entire full screen element stack is cleared and that webkitFullScreenChange events are sent
out correctly.

* WebView/WebFullScreenController.mm:
(-[WebFullScreenController cancelOperation:]):
(-[WebFullScreenController requestExitFullScreen]):

Source/WebKit2:

Instead of exiting full screen directly, ask the document to initiate exiting full screen. This ensures
that the entire full screen element stack is cleared and that webkitFullScreenChange events are sent
out correctly.

Because the WebProcess may be stalled or hung, add a watchdog timer which will force an exit of full
screen if the WebProcess does not respond in a timely manner (defaults to 1s).

Add a new method, requestExitFullScreen, which calls through to the WebProcess and Document:
* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::requestExitFullScreen):
* UIProcess/WebFullScreenManagerProxy.h:
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::requestExitFullScreen):
* WebProcess/FullScreen/WebFullScreenManager.h:
* WebProcess/FullScreen/WebFullScreenManager.messages.in:

Request that the document exits full screen when the ESC key is pressed:
* UIProcess/mac/WKFullScreenWindowController.h:
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController cancelOperation:]):
(-[WKFullScreenWindowController exitFullScreen]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, skip 2 flaky crash inspector tests on GTK.
philn@webkit.org [Tue, 3 Apr 2012 17:31:59 +0000 (17:31 +0000)]
Unreviewed, skip 2 flaky crash inspector tests on GTK.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExpectations update after 82734
tomz@codeaurora.org [Tue, 3 Apr 2012 17:21:24 +0000 (17:21 +0000)]
Expectations update after 82734
https://bugs.webkit.org/show_bug.cgi?id=82734

Unreviewed expectations update.

* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] DRT support for setInteractiveFormValidationEnabled
commit-queue@webkit.org [Tue, 3 Apr 2012 17:14:36 +0000 (17:14 +0000)]
[EFL] DRT support for setInteractiveFormValidationEnabled
https://bugs.webkit.org/show_bug.cgi?id=82050

Source/WebKit/efl:

Add a setting setInteractiveFormValidationEnabled to EFL's
DumpRenderTreeSupport.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-03
Reviewed by Antonio Gomes.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setInteractiveFormValidationEnabled):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Enable interactive form validation and unskip tests from the
skip list.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-03
Reviewed by Antonio Gomes.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

LayoutTests:

Unskip interactive form validation tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-03
Reviewed by Antonio Gomes.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r80439): Crash in StylePropertySet::borderSpacingValue
rniwa@webkit.org [Tue, 3 Apr 2012 16:52:28 +0000 (16:52 +0000)]
REGRESSION(r80439): Crash in StylePropertySet::borderSpacingValue
https://bugs.webkit.org/show_bug.cgi?id=83000

Reviewed by Andreas Kling.

Source/WebCore:

Fixed the crash by exiting early in StylePropertySet::borderSpacingValue when
the vertical value is set.

Test: fast/css/border-spacing-without-vertical-value.html

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::borderSpacingValue):

LayoutTests:

Add a regression for obtaining the value of border-spacing without specifying
-webkit-horizontal-vertical.

* fast/css/border-spacing-without-vertical-value-expected.txt: Added.
* fast/css/border-spacing-without-vertical-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Add click count and modifiers to the factory method of mouse event.
commit-queue@webkit.org [Tue, 3 Apr 2012 16:49:09 +0000 (16:49 +0000)]
[Chromium] Add click count and modifiers to the factory method of mouse event.
https://bugs.webkit.org/show_bug.cgi?id=82502

Modify WebInputEventFactory::mouseEvent() to take click count
and modifiers from input parameters. Sample use cases of these
are double click, triple click, Ctrl+click, etc.

Patch by Bolin Hsu <bhsu@google.com> on 2012-04-03
Reviewed by Eric Seidel.

* public/android/WebInputEventFactory.h:
* src/android/WebInputEventFactory.cpp:
(WebKit::WebInputEventFactory::mouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayoutTests/.gitattributes cleanup
tony@chromium.org [Tue, 3 Apr 2012 16:41:05 +0000 (16:41 +0000)]
LayoutTests/.gitattributes cleanup
https://bugs.webkit.org/show_bug.cgi?id=82975

Reviewed by Hajime Morita.

* .gitattributes: Set svn:mime-type for .gif files and remove files
that no longer exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed ASSERT fix on Chromium bots (in debug).
alexis.menard@openbossa.org [Tue, 3 Apr 2012 16:23:49 +0000 (16:23 +0000)]
Unreviewed ASSERT fix on Chromium bots (in debug).

It appears that http://trac.webkit.org/changeset/113031 caused ASSERT in CSSParser::parseFillProperty.
I added the ASSERT to fix the compilation about values not handled in the switch. I supposed the callers
were only property ids handled in the switch case. It wasn't the case, so I'm restoring the old behavior
while keeping the code to compile (it still need a deeper investigation but let fix the bots quickly).

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, another test-webkitpy fix-up after r113037.
philn@webkit.org [Tue, 3 Apr 2012 16:00:48 +0000 (16:00 +0000)]
Unreviewed, another test-webkitpy fix-up after r113037.

* Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Adapt mock
crash dump depending on current environment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExpectations update after 65072
schenney@chromium.org [Tue, 3 Apr 2012 15:55:10 +0000 (15:55 +0000)]
Expectations update after 65072
https://bugs.webkit.org/show_bug.cgi?id=65072

Unreviewed Chromium expectations update.

* platform/chromium-linux/svg/text/ems-display-none-expected.png: Added.
* platform/chromium-linux/svg/text/exs-display-none-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/text/ems-display-none-expected.txt: Added.
* platform/chromium-mac/svg/text/ems-display-none-expected.png: Added.
* platform/chromium-mac/svg/text/exs-display-none-expected.png: Added.
* platform/chromium-win/svg/text/ems-display-none-expected.png: Added.
* platform/chromium-win/svg/text/ems-display-none-expected.txt: Added.
* platform/chromium-win/svg/text/exs-display-none-expected.png: Added.
* platform/chromium-win/svg/text/exs-display-none-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Part 3] We should use CSSPropertyID rather than integers when manipulating CSS prope...
alexis.menard@openbossa.org [Tue, 3 Apr 2012 15:46:20 +0000 (15:46 +0000)]
[Part 3] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83032

Reviewed by Kentaro Hara.

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
functions manipulating property ids, as we ensure that the value passed will be an
existing value. This patch clean up some remaining part of code.

No new tests : There should be no behavior change in this patch.

* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(CSSPropertyInfo):
(WebCore::cssPropertyIDForJSCSSPropertyName):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(CSSPropertyInfo):
(WebCore::cssPropertyInfo):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getPositionOffsetValue):
(WebCore::counterToCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValidPrimitive):
Remove the parameter's name from the h file as it doesn't follow the style and also because the
name was simply wrong we don't expect a propId here but an indentifier. Make it clear in the
cpp file too.
* css/CSSParser.h:
(CSSParser):
* page/animation/AnimationBase.cpp:
(WebCore::addPropertyWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] ASSERT(!(outputBytes.size() % sizeof(UChar))) in PluginProcessProxyQt.cpp
kbalazs@webkit.org [Tue, 3 Apr 2012 15:45:02 +0000 (15:45 +0000)]
[Qt][WK2] ASSERT(!(outputBytes.size() % sizeof(UChar))) in PluginProcessProxyQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=83034

Reviewed by Zoltan Herczeg.

Don't allow the plugin to pollute the standard output.
Reinvent StdOutDevNullRedirector which was removed in
r112889 for this purpose.

* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(StdoutDevNullRedirector):
(WebKit):
(WebKit::StdoutDevNullRedirector::StdoutDevNullRedirector):
(WebKit::StdoutDevNullRedirector::~StdoutDevNullRedirector):
(WebKit::NetscapePluginModule::scanPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, test-webkitpy build fix after r113037.
philn@webkit.org [Tue, 3 Apr 2012 15:37:16 +0000 (15:37 +0000)]
Unreviewed, test-webkitpy build fix after r113037.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._get_crash_log):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove unused references to TimelineCalculator
caseq@chromium.org [Tue, 3 Apr 2012 15:33:43 +0000 (15:33 +0000)]
Web Inspector: remove unused references to TimelineCalculator
https://bugs.webkit.org/show_bug.cgi?id=83025

Reviewed by Yury Semikhatsky.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelineRecordListRow.prototype.update):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntegrate IETC CSS : borders and backgrounds tests
tomz@codeaurora.org [Tue, 3 Apr 2012 15:33:27 +0000 (15:33 +0000)]
Integrate IETC CSS : borders and backgrounds tests
https://bugs.webkit.org/show_bug.cgi?id=82734

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-03
Reviewed by Adam Barth.

Adding 57 pixel tests for IETC backgrounds and borders. Modified chromium
tests expectations, will pull the MISSING FAIL lines when we get good
expected results from the bots. Also renaming 'ahem.ttf' to 'Ahem.ttf' to deal with
case-insensitive filesystem issue.

* ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background-color-border-box.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background-size-002.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background_color_padding_box.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background_position_three_four_values.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-clip-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-style-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-style-002.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-style-003.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-style-004.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-style-005.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004.htm: Added.
* ietestcenter/css3/bordersbackgrounds/box-shadow-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/box-shadow-002.htm: Added.
* ietestcenter/css3/bordersbackgrounds/box-shadow-003.htm: Added.
* ietestcenter/css3/bordersbackgrounds/box-shadow-004.htm: Added.
* ietestcenter/css3/bordersbackgrounds/color-behind-images.htm: Added.
* ietestcenter/css3/bordersbackgrounds/none-as-image-layer.htm: Added.
* ietestcenter/css3/bordersbackgrounds/order-of-images.htm: Added.
* ietestcenter/css3/support/Ahem.ttf: Renamed from LayoutTests/ietestcenter/css3/support/ahem.ttf.
* ietestcenter/css3/support/orange_color.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] crash log reports support
philn@webkit.org [Tue, 3 Apr 2012 15:23:06 +0000 (15:23 +0000)]
[GTK] crash log reports support
https://bugs.webkit.org/show_bug.cgi?id=81659

Reviewed by Martin Robinson.

Removed the daemontools crashmon/xvfb scripts and implemented the crash
log reporting in the NRWT Gtk port. To get proper crash logs one
needs to set the core pattern like this:
echo "/path/to/cores/core-pid_%p-_-process_%e" > /proc/sys/kernel/core_pattern
Then enable coredumps with "ulimit -c unlimited" and set the WEBKIT_CORE_DUMPS_DIRECTORY
environment variable.

* BuildSlaveSupport/gtk/README:
* BuildSlaveSupport/gtk/crashmon/crashmon: Removed.
* BuildSlaveSupport/gtk/crashmon/log/run: Removed.
* BuildSlaveSupport/gtk/crashmon/run: Removed.
* BuildSlaveSupport/gtk/daemontools-buildbot.conf:
* BuildSlaveSupport/gtk/xvfb/log/run: Removed.
* BuildSlaveSupport/gtk/xvfb/run: Removed.
* Scripts/new-run-webkit-tests:
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver.stop):
(GtkPort.show_results_html_file):
(GtkPort):
(GtkPort._get_gdb_output):
(GtkPort._get_crash_log):
(GtkPort._get_crash_log.match_filename):
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
(GtkPortTest):
(test_show_results_html_file):
(assertLinesEqual):
(_mock_gdb_output):
(test_get_crash_log):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore unreviewed mac rebaselines
schenney@chromium.org [Tue, 3 Apr 2012 15:22:02 +0000 (15:22 +0000)]
More unreviewed mac rebaselines
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed test expectations update.

Patch by Philip Rogers <pdr@google.com> on 2012-04-03

* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/text/text-text-05-t-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] svg/zoom/page/zoom-svg-through-object-with-auto-size.html is flaky on 32-bits...
philn@webkit.org [Tue, 3 Apr 2012 15:16:14 +0000 (15:16 +0000)]
[GTK] svg/zoom/page/zoom-svg-through-object-with-auto-size.html is flaky on 32-bits Release
https://bugs.webkit.org/show_bug.cgi?id=68523

Unreviewed, unskip tests passing locally, they aren't flaky
anymore, from the test runs I performed locally.

* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCall incrementStatsCounter directly
commit-queue@webkit.org [Tue, 3 Apr 2012 15:03:29 +0000 (15:03 +0000)]
Call incrementStatsCounter directly
https://bugs.webkit.org/show_bug.cgi?id=83023

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-03
Reviewed by Kentaro Hara.

Source/WebCore:

* bindings/v8/V8Proxy.h:
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::WebFrameImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Canvas2DLayerChromium::updateCompositorResources should flush after copying
commit-queue@webkit.org [Tue, 3 Apr 2012 14:48:33 +0000 (14:48 +0000)]
[chromium] Canvas2DLayerChromium::updateCompositorResources should flush after copying
https://bugs.webkit.org/show_bug.cgi?id=83013

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-03
Reviewed by Stephen White.

Source/WebCore:

We need to flush the GPU command queue after copying the canvas back
buffer into the front buffer. Otherwise the copy might be delayed to a
point where new contents have already been drawn into the back buffer,
leading to flickering.

Added test to Canvas2DLayerChromiumTest.

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):

Source/WebKit/chromium:

* tests/Canvas2DLayerChromiumTest.cpp: Make sure context is flushed after copying.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [chromium] add provisional save method into the frontend client.
pfeldman@chromium.org [Tue, 3 Apr 2012 14:29:32 +0000 (14:29 +0000)]
Web Inspector: [chromium] add provisional save method into the frontend client.
https://bugs.webkit.org/show_bug.cgi?id=83022

Reviewed by Yury Semikhatsky.

* public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::save):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Part 2] We should use CSSPropertyID rather than integers when manipulating CSS prope...
alexis.menard@openbossa.org [Tue, 3 Apr 2012 14:18:19 +0000 (14:18 +0000)]
[Part 2] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=82977

Reviewed by Andreas Kling.

Source/WebCore:

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
functions manipulating property ids, as we ensure that the value passed will be an
existing value. Almost everything has been changed with the exception of the Animation related
classes which can be done in a following patch.

No new tests : There should be no behavior change in this patch.

* WebCore.exp.in:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::cssText):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::logUnimplementedPropertyID):
(WebCore::CSSComputedStyleDeclaration::getPropertyValue):
(WebCore::CSSComputedStyleDeclaration::item):
* css/CSSComputedStyleDeclaration.h:
(CSSComputedStyleDeclaration):
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::isColorPropertyID):
(WebCore::parseColorValue):
(WebCore::isSimpleLengthPropertyID):
(WebCore::parseSimpleLengthValue):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::parseKeywordValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseShorthand):
(WebCore::CSSParser::parse4Values):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSize):
(WebCore::CSSParser::parseQuotes):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseClipShape):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::BorderImageParseContext::commitBorderImageProperty):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseCounter):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::parseRegionThread):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parsePerspectiveOrigin):
* css/CSSParser.h:
(CSSParser):
(WebCore::ShorthandScope::ShorthandScope):
* css/CSSProperty.cpp:
(WebCore::resolveToPhysicalProperty):
(WebCore::CSSProperty::resolveDirectionAwareProperty):
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSProperty.h:
(WebCore::CSSProperty::CSSProperty):
(CSSProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyCSSValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::removeEquivalentProperties):
* css/StylePropertySet.h:
(StylePropertySet):
* css/StylePropertyShorthand.cpp:
(WebCore::shorthandForProperty):
* css/StylePropertyShorthand.h:
(WebCore):
* dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::addPropertyToAttributeStyle):
* dom/StyledElement.h:
(StyledElement):
(WebCore::StyledElement::addPropertyToAttributeStyle):
* editing/EditingStyle.cpp:
(HTMLElementEquivalent):
(WebCore::EditingStyle::EditingStyle):
(WebCore::EditingStyle::setProperty):
* editing/EditingStyle.h:
(WebCore::EditingStyle::create):
(EditingStyle):
* editing/Editor.cpp:
(WebCore::Editor::selectionStartHasStyle):
(WebCore::Editor::selectionHasStyle):
* editing/Editor.h:
(Editor):
* editing/EditorCommand.cpp:
(WebCore::executeApplyStyle):
(WebCore::executeToggleStyleInList):
(WebCore::executeToggleStyle):
(WebCore::executeApplyParagraphStyle):
(WebCore::stateStyle):
* editing/markup.cpp:
(WebCore):
(WebCore::propertyMissingOrEqualToNone):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::addHTMLLengthToStyle):
(WebCore::HTMLElement::addHTMLColorToStyle):
* html/HTMLElement.h:
(HTMLElement):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::styleWithProperties):
* page/animation/AnimationBase.cpp:
(WebCore::addShorthandProperties):
* svg/SVGFontFaceElement.cpp:
(WebCore::cssPropertyIdForSVGAttributeName):
(WebCore::SVGFontFaceElement::parseAttribute):
* svg/SVGStyledElement.cpp:
(WebCore::mapAttributeToCSSProperty):
(WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
(WebCore::SVGStyledElement::collectStyleForAttribute):
(WebCore::SVGStyledElement::svgAttributeChanged):
(WebCore::SVGStyledElement::getPresentationAttribute):
* svg/SVGStyledElement.h:
(WebCore):
(SVGStyledElement):

Source/WebKit/qt:

Update the code to use CSSPropertyID rather than an integer.

* Api/qwebelement.cpp:
(QWebElement::setStyleProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert RenderTheme paint and layout functions to ints
leviw@chromium.org [Tue, 3 Apr 2012 13:55:52 +0000 (13:55 +0000)]
Revert RenderTheme paint and layout functions to ints
https://bugs.webkit.org/show_bug.cgi?id=82196

Reviewed by Julien Chaffraix.

When dealing with object that are rendered outside of WebCore, we do all necessary pixel snapping
before passing coordinates to the external code. RenderTheme encompasses a set of objects whose
rendering is influenced by the platform. This change reverts the interface between this platform
code and WebCore to be integers.

Some platforms, such as Mac, use sub-pixel units for layout and rendering, but it's still not
desirable to pass sub-pixel values to these API's, because ultimately we'll render these objects
at whole-pixel values to avoid anti-aliasing.

Marking touched overridden virtual functions as OVERRIDE. There are many more to update.

No new tests. No change in behavior.

* platform/graphics/FractionalLayoutRect.h:
(WebCore::FractionalLayoutRect::pixelSnappedLocation): Convenience function.
(WebCore::FractionalLayoutRect::pixelSnappedSize): Ditto.
(FractionalLayoutRect):
* platform/graphics/IntRect.h:
(WebCore::IntRect::pixelSnappedLocation): Temporary mirrors to the functions of the same name on
FractionalLayoutRect.
(WebCore::IntRect::pixelSnappedSize): Ditto.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations): Adding a local pixel snapped paint rect to avoid
repeated pixel snapping.
* rendering/RenderBox.h:
(WebCore::RenderBox::absoluteContentBox): Reverting to integers since this represents on-screen
coordinates
(WebCore::RenderBox::pixelSnappedSize): Convenience method.
* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): This static function is only called
from RenderTheme platform code. Changing it to operate on pixel snapped values since we don't want
to pipe LayoutUnits through that code.
* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::computeLogicalWidth): Changing to feed pixel snapped values into the platform
code to properly determine the resulting meter size.
(WebCore::RenderMeter::computeLogicalHeight): Ditto.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
(WebCore::RenderTheme::adjustRepaintRect):
(WebCore::RenderTheme::meterSizeForBounds):
* rendering/RenderTheme.h:
(RenderTheme):
(WebCore::RenderTheme::paintCapsLockIndicator):
* rendering/RenderThemeChromiumMac.h:
(RenderThemeChromiumMac):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::convertToPaintingRect):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
* rendering/RenderThemeChromiumSkia.h:
* rendering/RenderThemeMac.h:
(RenderThemeMac):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::inflateRect):
(WebCore::RenderThemeMac::convertToPaintingRect):
(WebCore::RenderThemeMac::setControlSize):
(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::meterSizeForBounds):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton):
* rendering/RenderThemeWin.h:
(RenderThemeWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agochromium: fast/dom/error-to-string-stack-overflow.html is failing after v8 roll to...
commit-queue@webkit.org [Tue, 3 Apr 2012 13:39:59 +0000 (13:39 +0000)]
chromium: fast/dom/error-to-string-stack-overflow.html is failing after v8 roll to 3.10.0.2
https://bugs.webkit.org/show_bug.cgi?id=82993

Adjust test expectation to include the line number of the exception.

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-04-03
Reviewed by Kentaro Hara.

* platform/chromium-linux/fast/dom/error-to-string-stack-overflow-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable and connect the WebInspectorServer with WebKit2 pages.
jocelyn.turcotte@nokia.com [Tue, 3 Apr 2012 13:24:56 +0000 (13:24 +0000)]
Enable and connect the WebInspectorServer with WebKit2 pages.
https://bugs.webkit.org/show_bug.cgi?id=73094

Reviewed by Simon Hausmann.

Source/WebKit2:

Pages are registered/unregistered as they are created/destroyed, if they have
developer extras enabled. The server is run on the UI process and communicates
with the web process through IPC for each message between the inspector
controller and the remote frontend.

Includes the server spawning logic for the Qt port, the server is
started through an environment variable specifying the interface and
port to bind the server to, by default on 127.0.0.1.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::invalidate):
(WebKit):
(WebKit::WebInspectorProxy::enableRemoteInspection):
(WebKit::WebInspectorProxy::remoteFrontendConnected):
(WebKit::WebInspectorProxy::remoteFrontendDisconnected):
(WebKit::WebInspectorProxy::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspectorProxy::sendMessageToRemoteFrontend):
* UIProcess/WebInspectorProxy.h:
(WebInspectorProxy):
* UIProcess/WebInspectorProxy.messages.in:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::preferencesDidChange):
* UIProcess/qt/QtWebContext.cpp:
(WebKit::initInspectorServer):
(WebKit):
(WebKit::globalInitialization):
(WebKit::QtWebContext::create):
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::sendMessageToFrontend):
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::WebInspector):
(WebKit):
(WebKit::WebInspector::sendMessageToRemoteFrontend):
(WebKit::WebInspector::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspector::remoteFrontendConnected):
(WebKit::WebInspector::remoteFrontendDisconnected):
* WebProcess/WebPage/WebInspector.h:
(WebInspector):
(WebKit::WebInspector::hasRemoteFrontendConnected):
* WebProcess/WebPage/WebInspector.messages.in:

Tools:

Enable developer extras on pages in MiniBrowser for Qt.

* MiniBrowser/qt/qml/BrowserWindow.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebInspectorServer for WebKit2.
jocelyn.turcotte@nokia.com [Tue, 3 Apr 2012 13:24:32 +0000 (13:24 +0000)]
WebInspectorServer for WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=73855

Reviewed by Simon Hausmann.

The server uses WebSocket for communication with the remote client and
normal HTTP requests are handled to optionally send the frontend on the
wire. Those decision are handled per platform and Qt currently maps:

  - "/" to a static listing page.
  - "/pagelist.json" to the page list for the listing page or tools.
  - anything else, for example "/inspector.js" to the file with the
    same name in the dynamic libraries built resources.
    Invalid files should return a 404.

* Target.pri:
* UIProcess/InspectorServer/WebInspectorServer.cpp: Added.
(WebKit):
(WebKit::pageIdFromRequestPath):
(WebKit::WebInspectorServer::server):
(WebKit::WebInspectorServer::WebInspectorServer):
(WebKit::WebInspectorServer::~WebInspectorServer):
(WebKit::WebInspectorServer::registerPage):
(WebKit::WebInspectorServer::unregisterPage):
(WebKit::WebInspectorServer::sendMessageOverConnection):
(WebKit::WebInspectorServer::didReceiveUnrecognizedHTTPRequest):
(WebKit::WebInspectorServer::didReceiveWebSocketUpgradeHTTPRequest):
(WebKit::WebInspectorServer::didEstablishWebSocketConnection):
(WebKit::WebInspectorServer::didReceiveWebSocketMessage):
(WebKit::WebInspectorServer::didCloseWebSocketConnection):
(WebKit::WebInspectorServer::closeConnection):
* UIProcess/InspectorServer/WebInspectorServer.h: Added.
(WebKit):
(WebInspectorServer):
* UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp: Added.
(WebKit):
(WebKit::WebInspectorServer::platformResourceForPath):
(WebKit::WebInspectorServer::buildPageList):
* WebKit2.qrc: Added.
* qt/Resources/inspectorPageIndex.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a Generic WebSocket Server.
jocelyn.turcotte@nokia.com [Tue, 3 Apr 2012 13:24:11 +0000 (13:24 +0000)]
Add a Generic WebSocket Server.
https://bugs.webkit.org/show_bug.cgi?id=73093

Reviewed by Simon Hausmann.

Source/WebCore:

Allow SocketStreamHandle for the Qt port to take an existing QTcpSocket in its constructor.

* platform/network/qt/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::create):
(SocketStreamHandle):
* platform/network/qt/SocketStreamHandlePrivate.h:
(SocketStreamHandlePrivate):
* platform/network/qt/SocketStreamHandleQt.cpp:
(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore):
(WebCore::SocketStreamHandlePrivate::initConnections):
(WebCore::SocketStreamHandlePrivate::close):
(WebCore::SocketStreamHandle::SocketStreamHandle):

Source/WebKit2:

The Inspector Server will be a WebSocket Server that also responds to
non-WebSocket-Upgrade HTTP Requests. This is a generic WebSocket server
that passes on what it doesn't know on to its client for extended
functionality. This code is wrapped in a new ENABLE(INSPECTOR_SERVER) flag.

There are no tests yet for a built-in WebSocket server.
This will be covered by API level tests in a later patch.

* Target.pri:

  WebSocketServer is a simple server. Calling listen, or close,
  multiple times is safe. Subclassing is expected.

* UIProcess/InspectorServer/WebSocketServer.cpp: Added.
(WebKit):
(WebKit::WebSocketServer::WebSocketServer):
(WebKit::WebSocketServer::~WebSocketServer):
(WebKit::WebSocketServer::listen):
(WebKit::WebSocketServer::close):
(WebKit::WebSocketServer::didAcceptConnection):
(WebKit::WebSocketServer::didCloseWebSocketServerConnection):
* UIProcess/InspectorServer/WebSocketServer.h: Added.
(WebKit):
(WebCore):
(WebSocketServer):
* UIProcess/InspectorServer/WebSocketServerClient.h: Added.
(WebCore):
(WebKit):
(WebSocketServerClient):
(WebKit::WebSocketServerClient::~WebSocketServerClient):
(WebKit::WebSocketServerClient::didReceiveUnrecognizedHTTPRequest):
(WebKit::WebSocketServerClient::didReceiveWebSocketUpgradeHTTPRequest):
(WebKit::WebSocketServerClient::didEstablishWebSocketConnection):
(WebKit::WebSocketServerClient::didReceiveWebSocketMessage):
(WebKit::WebSocketServerClient::didCloseWebSocketConnection):

  Each WebSocketConnection:

   - Passes unknown HTTP Requests to the server's client.
   - Handles WebSocket Upgrade Requests.
     - First ask the client if it is okay.
     - Later notify the client about a success.
   - Once upgraded the connection parses and passes WebSocket
     frames to the client.

* UIProcess/InspectorServer/WebSocketServerConnection.cpp: Added.
(WebKit):
(WebKit::WebSocketServerConnection::WebSocketServerConnection):
(WebKit::WebSocketServerConnection::~WebSocketServerConnection):
(WebKit::WebSocketServerConnection::shutdownNow):
(WebKit::WebSocketServerConnection::shutdownAfterSendOrNow): meant to shutdown after an HTTP response. Ensure all platforms work as expected.
(WebKit::WebSocketServerConnection::sendWebSocketMessage): send a text message (WebSocket message) over the connection.
(WebKit::WebSocketServerConnection::sendHTTPResponseHeader):
(WebKit::WebSocketServerConnection::sendRawData): send raw data (HTTP message) over the connection.
(WebKit::WebSocketServerConnection::didCloseSocketStream): handle socket closing scenarios.
(WebKit::WebSocketServerConnection::didReceiveSocketStreamData): parse the incoming data in HTTP / WebSocket modes.
(WebKit::WebSocketServerConnection::didFailSocketStream): log errors.
(WebKit::WebSocketServerConnection::readHTTPMessage): when starting, a web socket connection reads an HTTP message.
(WebKit::WebSocketServerConnection::upgradeToWebSocketServerConnection):
(WebKit::WebSocketServerConnection::readWebSocketFrames): parse our buffer for as many frames as possible.
(WebKit::WebSocketServerConnection::readWebSocketFrame): parse an individual frame.
* UIProcess/InspectorServer/WebSocketServerConnection.h: Added.
(WebCore):
(WebKit):
(WebSocketServerConnection):
(WebKit::WebSocketServerConnection::identifier):
(WebKit::WebSocketServerConnection::setIdentifier):

  Qt specific implementation.

* UIProcess/InspectorServer/qt/WebSocketServerQt.cpp: Added.
(WebKit):
(WebKit::WebSocketServer::platformInitialize):
(WebKit::WebSocketServer::platformListen):
(WebKit::WebSocketServer::platformClose):
(WebKit::QtTcpServerHandler::QtTcpServerHandler):
(WebKit::QtTcpServerHandler::handleNewConnection):
(WebKit::QtTcpServerHandler::listen):
(WebKit::QtTcpServerHandler::close):
* UIProcess/InspectorServer/qt/WebSocketServerQt.h: Added.
(WebKit):
(QtTcpServerHandler):

* WebKit2.pri:
* config.h: Add ENABLE(INSPECTOR_SERVER) for WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExpose reusable WebSocket code for WebSocketServer.
jocelyn.turcotte@nokia.com [Tue, 3 Apr 2012 13:23:46 +0000 (13:23 +0000)]
Expose reusable WebSocket code for WebSocketServer.
https://bugs.webkit.org/show_bug.cgi?id=73852

Reviewed by Kent Tamura.

Keep the majority the web socket handshake HTTP request and response logic
inside WebSocketHandshake and expose it through WebSocketFrame to make it
available for the web socket server implementation.

This also re-add the masking code that was removed in r111829 since it is
needed for the server implementation.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/websockets/WebSocketChannel.cpp:
(WebCore):
(WebCore::WebSocketChannel::processFrame): now using WebSocketChannel::parseFrame. Extracted the !frame.masked check.
(WebCore::WebSocketChannel::sendFrame):
* Modules/websockets/WebSocketChannel.h:
(WebSocketChannel):
* Modules/websockets/WebSocketFrame.cpp: Added.
(WebCore):
(WebCore::WebSocketFrame::needsExtendedLengthField):
(WebCore::WebSocketFrame::parseFrame): moved from WebSocketChannel::parseFrame.
(WebCore::appendMaskedFramePayload):
(WebCore::WebSocketFrame::makeFrameData): moved from makeFrameData in WebSocketChannel.cpp.
(WebCore::WebSocketFrame::WebSocketFrame): moved from the header.
* Modules/websockets/WebSocketFrame.h:
(WebSocketFrame):
* Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::getExpectedWebSocketAccept): expose this object-static function.
* Modules/websockets/WebSocketHandshake.h:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113025 268f45cc-cd09-0410-ab3c-d52691b4dbfc