WebKit-https.git
10 years ago2011-01-28 Pratik Solanki <psolanki@apple.com>
psolanki@apple.com [Fri, 28 Jan 2011 20:27:22 +0000 (20:27 +0000)]
2011-01-28  Pratik Solanki  <psolanki@apple.com>

        Reviewed by David Kilzer.

        Space not necessary for undefined feature
        https://bugs.webkit.org/show_bug.cgi?id=53317

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 28 Jan 2011 20:26:04 +0000 (20:26 +0000)]
2011-01-28  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaselines.

        Check in the same result as fast/dom/window-domurl-crash-expected.txt because Windows port
        intentionally added a failing result in http://trac.webkit.org/changeset/76953.

        The Windows port's bug is tracked by https://bugs.webkit.org/show_bug.cgi?id=53310.

        * platform/chromium-win/fast/dom/window-domurl-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Fri, 28 Jan 2011 20:21:07 +0000 (20:21 +0000)]
2011-01-28  Michael Saboff  <msaboff@apple.com>

        Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
        https://bugs.webkit.org/show_bug.cgi?id=53271

        Reapplying this this change.  No change from prior patch in
        JavaScriptCore.

        Added new isValid() methods to check if a contained object in
        a WeakGCMap is valid when using an unchecked iterator.

        * runtime/WeakGCMap.h:
        (JSC::WeakGCMap::isValid):
2011-01-28  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
        https://bugs.webkit.org/show_bug.cgi?id=53271

        Reapplying this patch with the change that the second ASSERT in
        RootObject::removeRuntimeObject was changed to use
        .uncheckedGet() instead of the failing .get().  The object in question
        could be in the process of being GC'ed.  The get() call will not return
        such an object while the uncheckedGet() call will return the (unsafe)
        object.  This is the behavior we want.

        Precautionary change.
        Changed RootObject to use WeakGCMap instead of HashSet.
        Found will looking for another issue, but can't produce a test case
        that is problematic.  THerefore there aren't any new tests.

        * bridge/runtime_root.cpp:
        (JSC::Bindings::RootObject::invalidate):
        (JSC::Bindings::RootObject::addRuntimeObject):
        (JSC::Bindings::RootObject::removeRuntimeObject):
        * bridge/runtime_root.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNotify CACFLayerTreeHost when the context is flushed
aroben@apple.com [Fri, 28 Jan 2011 20:16:58 +0000 (20:16 +0000)]
Notify CACFLayerTreeHost when the context is flushed

LegacyCACFLayerTreeHost was keeping this a secret, which meant that WebCore's animation
timers were never starting.

Fixes <http://webkit.org/b/53302> [Windows 7 Release Tests] changesets 76853, 76856, and
76858 broke ~36 animations, compositing, and transitions tests

Reviewed by Sam Weinig.

Source/WebCore:

* platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
(WebCore::LegacyCACFLayerTreeHost::contextDidChange): Call up to the base class after we
start our render timer.

LayoutTests:

Unskip compositing-related tests that are now fixed

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange BinarySemaphore to wrap an auto-reset Win32 event on Windows
aroben@apple.com [Fri, 28 Jan 2011 20:16:02 +0000 (20:16 +0000)]
Change BinarySemaphore to wrap an auto-reset Win32 event on Windows

Fixes <http://webkit.org/b/53208> <rdar://problem/8922490>.

Reviewed by Dave Hyatt.

Source/WebKit2:

* Platform/CoreIPC/BinarySemaphore.cpp: Wrap this implementation in #if !PLATFORM(WIN).

* Platform/CoreIPC/BinarySemaphore.h: Make the Windows implementation have a single HANDLE
member that holds the event.

* Platform/CoreIPC/win/BinarySemaphoreWin.cpp: Copied from Source/WebKit2/Platform/CoreIPC/BinarySemaphore.cpp.
(CoreIPC::BinarySemaphore::BinarySemaphore): Create our event.
(CoreIPC::BinarySemaphore::~BinarySemaphore): Destory our event.
(CoreIPC::BinarySemaphore::signal): Signal the event.
(CoreIPC::BinarySemaphore::wait): Convert the absolute time to a wait interval, then wait
for the event to be signaled or for the interval to elapse.

* win/WebKit2.vcproj: Added BinarySemaphoreWin.cpp. Also let VS have its way with the file.

Source/JavaScriptCore:

Extract code to convert a WTF absolute time to a Win32 wait interval into a separate
function

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export the new function.

* wtf/ThreadingPrimitives.h: Declare the new function.

* wtf/ThreadingWin.cpp:
(WTF::ThreadCondition::timedWait): Moved code to convert the absolute time to a wait
interval from here...
(WTF::absoluteTimeToWaitTimeoutInterval): ...to here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove dead code that tried to map from CSS values to parser values
antti@apple.com [Fri, 28 Jan 2011 20:15:28 +0000 (20:15 +0000)]
Remove dead code that tried to map from CSS values to parser values
https://bugs.webkit.org/show_bug.cgi?id=53318

Reviewed by Dan Bernstein.

* css/CSSFunctionValue.cpp:
* css/CSSFunctionValue.h:
* css/CSSPrimitiveValue.cpp:
* css/CSSPrimitiveValue.h:
* css/CSSValue.h:
* css/CSSValueList.cpp:
* css/CSSValueList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Windows 7 Release Tests] fast/text/justify-ideograph-complex/simple/vertical.html...
jberlin@webkit.org [Fri, 28 Jan 2011 20:14:58 +0000 (20:14 +0000)]
[Windows 7 Release Tests] fast/text/justify-ideograph-complex/simple/vertical.html failing since introduction in r76743.
https://bugs.webkit.org/show_bug.cgi?id=53321

Unreviewed, checking in failing expected results to get the Windows 7 Release Tests bots green.

* platform/win/fast/text/justify-ideograph-complex-expected.txt: Added.
* platform/win/fast/text/justify-ideograph-simple-expected.txt: Added.
* platform/win/fast/text/justify-ideograph-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 28 Jan 2011 20:11:34 +0000 (20:11 +0000)]
2011-01-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Remove now-passing test from expectations.

        * platform/chromium/test_expectations.txt: Expectation of failure removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 28 Jan 2011 20:08:10 +0000 (20:08 +0000)]
2011-01-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Update expectations for prototype-inheritance to match platform/mac.

        * platform/chromium/fast/dom/prototype-inheritance-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Fri, 28 Jan 2011 19:48:51 +0000 (19:48 +0000)]
2011-01-27  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Anders Carlsson.

        WebKit2: Page flashes just before accelerated compositing animation
        https://bugs.webkit.org/show_bug.cgi?id=53274

        When switching out of compositing mode, the new ChunkedUpdateDrawingAreaProxy
        is getting created with the current page size. When the setSize() call is
        subsequently made, the sizeDidChange() call is not made (which does the initial
        render of the page) because the old size and new size are the same. The solution
        is to skip the setting of the size in the ctor and let it go through a size
        change sequence.

        * UIProcess/DrawingAreaProxy.cpp:
        (WebKit::DrawingAreaProxy::DrawingAreaProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome drag and drop tests fail since r76824
enrica@apple.com [Fri, 28 Jan 2011 19:46:19 +0000 (19:46 +0000)]
Some drag and drop tests fail since r76824
https://bugs.webkit.org/show_bug.cgi?id=53304

Reviewed by Adam Roben.

Source/WebCore:

There were '||' instead of '&&' in the checks for valid
clipboard content.

* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::getData):
(WebCore::ClipboardWin::types):
(WebCore::ClipboardWin::files):

LayoutTests:

Removing platform-specific tests after fixing the cause of the failure.

* platform/win/editing/pasteboard/get-data-text-plain-paste-expected.txt: Removed.
* platform/win/editing/pasteboard/onpaste-text-html-expected.txt: Removed.
* platform/win/fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Removed.
* platform/win/fast/events/ondrop-text-html-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 28 Jan 2011 19:29:02 +0000 (19:29 +0000)]
2011-01-28  Martin Robinson  <mrobinson@igalia.com>

        [GTK] AudioProcessingEvent.h and JSJavaScriptAudioNode.h: No such file or directory
        https://bugs.webkit.org/show_bug.cgi?id=52889

        Build fix for WebAudio. Include WebAudio source files on the source
        list when WebAudio is enabled.

        * GNUmakefile.am: Include missing source files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove the Windows-specific failing results for media/audio-data-url.html, since...
jberlin@webkit.org [Fri, 28 Jan 2011 19:18:47 +0000 (19:18 +0000)]
Remove the Windows-specific failing results for media/audio-data-url.html, since it appears
to be passing on the bots now. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51518

* platform/win/media/audio-data-url-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Chang Shu <chang.shu@nokia.com>
chang.shu@nokia.com [Fri, 28 Jan 2011 19:16:18 +0000 (19:16 +0000)]
2011-01-28  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Andreas Kling.

        Unskipp auth.html after fix.
        https://bugs.webkit.org/show_bug.cgi?id=36688

        * platform/qt/Skipped:
2011-01-28  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Andreas Kling.

        Reset NetworkAccessManager to clean up credentials from previous tests.
        This change causes no performance overhead either.
        https://bugs.webkit.org/show_bug.cgi?id=36688

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        (WebCore::DumpRenderTree::open):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 28 Jan 2011 19:06:46 +0000 (19:06 +0000)]
2011-01-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Added newly-failing tests to expectations, will be fixing them shortly.
        https://bugs.webkit.org/show_bug.cgi?id=53314

        * platform/chromium/test_expectations.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd basic rubber banding support
weinig@apple.com [Fri, 28 Jan 2011 19:05:43 +0000 (19:05 +0000)]
Add basic rubber banding support
<rdar://problem/8219429>
https://bugs.webkit.org/show_bug.cgi?id=53277

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

* wtf/Platform.h: Add ENABLE for rubber banding.

Source/WebCore:

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
Pass gesture events to the FrameView.

* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleGestureEvent):
* platform/ScrollAnimator.h:
Add stubbed out implementation.

* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::handleGestureEvent):
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::constrainsScrollingToContentEdge):
(WebCore::ScrollableArea::setConstrainsScrollingToContentEdge):
Move constrains scrolling bit to ScrollableArea from ScrollView.

(WebCore::ScrollableArea::contentsSize):
(WebCore::ScrollableArea::overhangAmount):
Add additional virtual functions for information needed by the animator.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
(WebCore::elasticDeltaForTimeDelta):
(WebCore::elasticDeltaForReboundDelta):
(WebCore::reboundDeltaForElasticDelta):
(WebCore::scrollWheelMultiplier):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::handleGestureEvent):
(WebCore::ScrollAnimatorMac::pinnedInDirection):
(WebCore::ScrollAnimatorMac::allowsVerticalStretching):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::endScrollGesture):
(WebCore::ScrollAnimatorMac::snapRubberBand):
(WebCore::roundTowardZero):
(WebCore::roundToDevicePixelTowardZero):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Implement basic rubber banding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdding tests broken on Windows 7 Release in 76853,76856,76858 to the Skipped list...
jberlin@webkit.org [Fri, 28 Jan 2011 19:05:35 +0000 (19:05 +0000)]
Adding tests broken on Windows 7 Release in 76853,76856,76858 to the Skipped list to get the
Windows 7 Release Bot green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53302

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChanging unicode-bidi doesn’t force layout
mitz@apple.com [Fri, 28 Jan 2011 18:46:38 +0000 (18:46 +0000)]
Changing unicode-bidi doesn’t force layout
https://bugs.webkit.org/show_bug.cgi?id=53311

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/dynamic/unicode-bidi.html

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff): Return a layout difference if unicode-bidi values differ.

LayoutTests:

* fast/dynamic/unicode-bidi-expected.checksum: Added.
* fast/dynamic/unicode-bidi-expected.png: Added.
* fast/dynamic/unicode-bidi-expected.txt: Added.
* fast/dynamic/unicode-bidi.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows expected (failing) results to get the bots green. Unreviewed.
jberlin@webkit.org [Fri, 28 Jan 2011 18:44:04 +0000 (18:44 +0000)]
Add Windows expected (failing) results to get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53310

* platform/win/fast/dom/window-domurl-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCheck in Windows-specific expected results to get the bots green. Unreviewed.
jberlin@webkit.org [Fri, 28 Jan 2011 18:16:22 +0000 (18:16 +0000)]
Check in Windows-specific expected results to get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53307

* platform/win/fast/multicol: Added.
* platform/win/fast/multicol/vertical-rl: Added.
* platform/win/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
* platform/win/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 28 Jan 2011 17:52:58 +0000 (17:52 +0000)]
2011-01-27  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        Change HTMLInputElement-derived parts of media element shadow DOM to use shadowPseudoId.
        https://bugs.webkit.org/show_bug.cgi?id=53122

        This is the first step in converting HTMLMediaElement to the new shadow DOM.

        Should not regress any existing tests. No observable change in behavior.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::pseudoId): Removed now-unnecessary hard-coded pseudo-element selectors.
        (WebCore::nameToPseudoTypeMap): Ditto.
        (WebCore::CSSSelector::extractPseudoType): Ditto.
        * css/CSSSelector.h: Ditto.
        * css/mediaControls.css: Added proper initial values, now that elements use the proper selector pipeline.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlInputElement::MediaControlInputElement): Removed the switch statement,
            which is now replaced with virtual shadowPseudoId on each corresponding class.
        (WebCore::MediaControlInputElement::styleForElement): Changed to use element pipeline.
        (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Changed to set
            display type in constructor.
        (WebCore::MediaControlMuteButtonElement::create): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlMuteButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement): Added
            to disambiguate from the MediaControlMuteButtonElement.
        (WebCore::MediaControlVolumeSliderMuteButtonElement::create): Added.
        (WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlPlayButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement): Added.
        (WebCore::MediaControlSeekForwardButtonElement::create): Added.
        (WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement): Added.
        (WebCore::MediaControlSeekBackButtonElement::create): Added.
        (WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Added.
        (WebCore::MediaControlRewindButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlTimelineElement::shadowPseudoId): Added.
        (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Added.
        (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Added.
        * rendering/MediaControlElements.h:
        (WebCore::MediaControlSeekForwardButtonElement::isForwardButton): Added.
        (WebCore::MediaControlSeekBackButtonElement::isForwardButton): Added.
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::createMuteButton): Changed to use new constructor.
        (WebCore::RenderMedia::createSeekBackButton): Ditto.
        (WebCore::RenderMedia::createSeekForwardButton): Ditto.
        (WebCore::RenderMedia::createVolumeSliderMuteButton): Ditto.
        * rendering/style/RenderStyleConstants.h: Removed constants that are no longer used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 28 Jan 2011 17:11:08 +0000 (17:11 +0000)]
2011-01-27  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Carlson.

        Split MediaControls out of RenderMedia.
        https://bugs.webkit.org/show_bug.cgi?id=53252

        Near-mechanical moving of stuff, no change in behavior, thus no new tests.

        * Android.mk: Added MediaControls to build system.
        * CMakeLists.txt: Ditto.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::defaultEventHandler): Changed to forward events to MediaControls.
        * html/shadow/MediaControls.cpp: Copied all controls-related methods from
            Source/WebCore/rendering/RenderMedia.cpp, pulled them into their own class called MediaControls.
        * html/shadow/MediaControls.h: Ditto from Source/WebCore/rendering/RenderMedia.h.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlTimelineElement::defaultEventHandler): Changed to use MediaControls.
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::RenderMedia): Moved relevant constructor initializers out to MediaControls.
        (WebCore::RenderMedia::destroy): Changed to use MediaControls.
        (WebCore::RenderMedia::styleDidChange): Ditto.
        (WebCore::RenderMedia::layout): Ditto.
        (WebCore::RenderMedia::updateFromElement): Ditto.
        * rendering/RenderMedia.h: Updated defs accordingly and removed player() accessor, which
            is only used by sub-class RenderVideo.
        (WebCore::RenderMedia::controls): Added.
        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::~RenderVideo): Changed to access MediaPlayer* directly from mediaElement().
        (WebCore::RenderVideo::calculateIntrinsicSize): Ditto.
        (WebCore::RenderVideo::paintReplaced): Ditto.
        (WebCore::RenderVideo::updatePlayer): Ditto.
        (WebCore::RenderVideo::supportsAcceleratedRendering): Ditto.
        (WebCore::RenderVideo::acceleratedRenderingStateChanged): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 28 Jan 2011 17:05:12 +0000 (17:05 +0000)]
2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76942.
        http://trac.webkit.org/changeset/76942
        https://bugs.webkit.org/show_bug.cgi?id=53301

        Unskipped tests keep failing on GTK release bots (Requested by
        svillar on #webkit).

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows expected (failing) results to get the bots green. Unreviewed.
jberlin@webkit.org [Fri, 28 Jan 2011 17:01:14 +0000 (17:01 +0000)]
Add Windows expected (failing) results to get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53304

* platform/win/editing/pasteboard/get-data-text-plain-paste-expected.txt: Added.
* platform/win/editing/pasteboard/onpaste-text-html-expected.txt: Added.
* platform/win/fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Added.
* platform/win/fast/events/ondrop-text-html-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 28 Jan 2011 16:56:37 +0000 (16:56 +0000)]
2011-01-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: allow remote debugging with front-end
        served from the cloud.
        https://bugs.webkit.org/show_bug.cgi?id=53303

        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Aparna Nandyal <aparna.nand@wipro.com>
commit-queue@webkit.org [Fri, 28 Jan 2011 16:33:03 +0000 (16:33 +0000)]
2011-01-28  Aparna Nandyal  <aparna.nand@wipro.com>

        Reviewed by Andreas Kling.

        Setting value of m_PressedPos to make scrolling smooth

        Page scroll popup menu "Scroll here" option not working when cliking above scroll slider/handler.
        https://bugs.webkit.org/show_bug.cgi?id=51349

        The value of m_PressedPos was getting set before moveThumb() call
        in all other scenarios except when "Scroll Here" option is used.
        Hence scrolling with this option was not as expected even in cases
        where scrolling was happening. The thumb would move in unexpected
        direction. m_PressedPos is now set to pressed position so delta is
        calculated.
        Unable to write a test case as the test needs to click on "Scroll
        Here" option of context sensitive menu and QTest is unable to do it.
        Besides no new functionality introduced.

        * platform/qt/ScrollbarQt.cpp:
        (WebCore::Scrollbar::contextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 28 Jan 2011 16:06:07 +0000 (16:06 +0000)]
2011-01-28  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] add JSON schema for extensions API
        https://bugs.webkit.org/show_bug.cgi?id=53236

        * inspector/front-end/ExtensionAPISchema.json: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 28 Jan 2011 15:51:09 +0000 (15:51 +0000)]
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Remove _LENGTH enumerants
        https://bugs.webkit.org/show_bug.cgi?id=53259

        * html/canvas/WebGLRenderingContext.cpp: Remove queries for *LENGTH.
        (WebCore::WebGLRenderingContext::getProgramParameter):
        (WebCore::WebGLRenderingContext::getShaderParameter):
        * html/canvas/WebGLRenderingContext.idl: Remove *LENGTH.
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Remove _LENGTH enumerants
        https://bugs.webkit.org/show_bug.cgi?id=53259

        * fast/canvas/webgl/constants.html:
        * fast/canvas/webgl/gl-getshadersource-expected.txt:
        * fast/canvas/webgl/gl-getshadersource.html:
        * fast/canvas/webgl/gl-object-get-calls-expected.txt:
        * fast/canvas/webgl/gl-object-get-calls.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 28 Jan 2011 15:48:00 +0000 (15:48 +0000)]
2011-01-28  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: syntax highlight inline JS and CSS in HTML resources
        https://bugs.webkit.org/show_bug.cgi?id=30831

        * inspector/front-end/SourceHTMLTokenizer.js:
        (WebInspector.SourceHTMLTokenizer):
        (WebInspector.SourceHTMLTokenizer.prototype.set line):
        (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
        * inspector/front-end/SourceHTMLTokenizer.re2js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 28 Jan 2011 15:12:27 +0000 (15:12 +0000)]
2011-01-28  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Unskipped some tests. They're not failing anymore.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 28 Jan 2011 15:07:09 +0000 (15:07 +0000)]
2011-01-28  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [STYLES] Up/Down-suggestion breaks an existing keyword
        https://bugs.webkit.org/show_bug.cgi?id=53295

        Select the current word suffix before switching to the next suggestion.

        * inspector/front-end/StylesSidebarPane.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 28 Jan 2011 14:34:37 +0000 (14:34 +0000)]
2011-01-28  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Fix compilation warning
        https://bugs.webkit.org/show_bug.cgi?id=53292

        * webkit/webkitwebframe.cpp:
        (draw_page_callback): Cast the pageCount from size_t to int, it
        should be safe considering page_nr is the number of pages,
        0-based.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 28 Jan 2011 14:19:13 +0000 (14:19 +0000)]
2011-01-28  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Fix dist compilation for the release
        https://bugs.webkit.org/show_bug.cgi?id=53290

        * GNUmakefile.am: Added inspector files to the extra dist.

2011-01-28  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Fix dist compilation for the release
        https://bugs.webkit.org/show_bug.cgi?id=53290

        * GNUmakefile.am: Remove a file that is not in the repository
        anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Fri, 28 Jan 2011 13:16:31 +0000 (13:16 +0000)]
2011-01-28  Andreas Kling  <kling@webkit.org>

        Rubber-stamped by Simon Hausmann.

        [Qt][WK2] Combine QWKPage::engine{Connected,Disconnected} into one signal.

        Having two signals for this is redundant, combine them into
        QWKPage::engineConnectionChanged(bool connected).

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::didRelaunchProcess):
        (QWKPagePrivate::processDidCrash):
        * UIProcess/API/qt/qwkpage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add Zoom Text Only action to MiniBrowser
zoltan@webkit.org [Fri, 28 Jan 2011 13:06:31 +0000 (13:06 +0000)]
[Qt] Add Zoom Text Only action to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=53297

Reviewed by Andreas Kling.

Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::zoomIn):
(BrowserWindow::zoomOut):
(BrowserWindow::resetZoom):
(BrowserWindow::toggleZoomTextOnly):
(BrowserWindow::applyZoom):
* MiniBrowser/qt/BrowserWindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Fri, 28 Jan 2011 12:46:50 +0000 (12:46 +0000)]
2011-01-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Andreas Kling.

        Const-correct HTMLSelectElement and WebSelectElement
        https://bugs.webkit.org/show_bug.cgi?id=53293

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::value): const.
        * html/HTMLSelectElement.h:
2011-01-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Andreas Kling.

        Const-correct HTMLSelectElement and WebSelectElement
        https://bugs.webkit.org/show_bug.cgi?id=53293

        * public/WebSelectElement.h:
        * src/WebSelectElement.cpp:
        (WebKit::WebSelectElement::value): const.
        (WebKit::WebSelectElement::listItems): const.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 28 Jan 2011 12:45:21 +0000 (12:45 +0000)]
2011-01-27  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fix debugger-scripts.html (broken by r76587).
        https://bugs.webkit.org/show_bug.cgi?id=53112

        * inspector/debugger-scripts-expected.txt:
        * inspector/debugger-scripts.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 28 Jan 2011 11:25:47 +0000 (11:25 +0000)]
2011-01-28  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Adding media/video-controls-rendering.html to the Skipped list of tests.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 28 Jan 2011 10:14:13 +0000 (10:14 +0000)]
2011-01-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add webkit-patch roll-chromium-deps
        https://bugs.webkit.org/show_bug.cgi?id=53288

        This command updates the Source/WebKit/chromium/DEPS file with the
        last-known good revision of Chromium (or a revision specified on the
        command line).  I'd eventually like to turn this into a SheriffBot
        command, but this is the first step.

        This patch somewhat sprawled because I needed to move a bunch of code
        out of ChangeLog that should never have been there in the first place.
        Also, I had to fix a bug in MockUser in order to test the new command.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/checkout/changelog_unittest.py:
        * Scripts/webkitpy/common/checkout/deps.py: Added.
        * Scripts/webkitpy/common/config/urls.py:
        * Scripts/webkitpy/tool/commands/__init__.py:
        * Scripts/webkitpy/tool/commands/download_unittest.py:
        * Scripts/webkitpy/tool/commands/roll.py: Added.
        * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/__init__.py:
        * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
        * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
        * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
        * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
        * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
        * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r76893.
ossy@webkit.org [Fri, 28 Jan 2011 09:10:11 +0000 (09:10 +0000)]
Unreviewed, rolling out r76893.
http://trac.webkit.org/changeset/76893
https://bugs.webkit.org/show_bug.cgi?id=53287

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-28
It made some tests crash on GTK and Qt debug bots (Requested
by Ossy on #webkit).

Source/JavaScriptCore:

* runtime/WeakGCMap.h:

Source/WebCore:

* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::addRuntimeObject):
(JSC::Bindings::RootObject::removeRuntimeObject):
* bridge/runtime_root.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-28 Commit Queue <commit-queue@webkit.org>
commit-queue@webkit.org [Fri, 28 Jan 2011 08:33:51 +0000 (08:33 +0000)]
2010-01-28  Commit Queue  <commit-queue@webkit.org>

        Unreviewed.  Test commit for commit-queue@webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-28 Commit Queue <commit-queue@webkit.org>
commit-queue@webkit.org [Fri, 28 Jan 2011 08:05:52 +0000 (08:05 +0000)]
2010-01-28  Commit Queue  <commit-queue@webkit.org>

        Unreviewed.  Test commit for commit-queue@webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 28 Jan 2011 07:49:51 +0000 (07:49 +0000)]
2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Maciej Stachowiak.

        Build fix for Mac Intel Debug after r76916
        https://bugs.webkit.org/show_bug.cgi?id=53284

        Fix macro redefinition by guarding the redefined macros.

        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 28 Jan 2011 07:25:26 +0000 (07:25 +0000)]
2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix for Mac Intel Debug after r76916.

        Fix macro redefinition by guarding the redefined macros.

        Check if the macro is already defined before defininig it.
        c++config.h has the same macros with the same values.

        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 28 Jan 2011 07:14:40 +0000 (07:14 +0000)]
2011-01-27  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectation update.

        * platform/chromium/test_expectations.txt: More media test crashes due to crbug.com/71087.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 28 Jan 2011 06:42:23 +0000 (06:42 +0000)]
2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Adam Barth.

        Update the expected results for test-webkitpy after r76916.

        Include "config.h" in the expected results as well.

        * Scripts/webkit2/messages_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 28 Jan 2011 06:34:36 +0000 (06:34 +0000)]
2011-01-27  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Skip some tests that fail due to missing DRT API
        https://bugs.webkit.org/show_bug.cgi?id=53283

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 28 Jan 2011 06:09:54 +0000 (06:09 +0000)]
2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed buildfix for SnowLeopard Intel Debug.

        Fix macro redefinition by not including config.h.

        Revert previous change in WebPageProxyCF.cpp.

        * UIProcess/cf/WebPageProxyCF.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Greg Coletta <greg.coletta@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 28 Jan 2011 05:37:44 +0000 (05:37 +0000)]
2011-01-27  Greg Coletta  <greg.coletta@nokia.com>

        Reviewed by Laszlo Gombos.

        Get rid of prefix header dependency for WebKit2 build system
        https://bugs.webkit.org/show_bug.cgi?id=50174

        Change the style checker so that it enforces config.h include for
        WebKit2.

        * Scripts/webkitpy/style/checker.py:

2011-01-27  Greg Coletta  <greg.coletta@nokia.com>

        Reviewed by Laszlo Gombos.

        Get rid of prefix header dependency for WebKit2 build system
        https://bugs.webkit.org/show_bug.cgi?id=50174

        Guard EmptyProtocalDefinitions.h to make sure it's not included twice.

        * platform/mac/EmptyProtocolDefinitions.h:

2011-01-27  Greg Coletta  <greg.coletta@nokia.com>

        Reviewed by Laszlo Gombos.

        Get rid of prefix header dependency for WebKit2 build system.
        https://bugs.webkit.org/show_bug.cgi?id=50174

        Add config.h include explicitelly.

        * Platform/CoreIPC/ArgumentDecoder.cpp:
        * Platform/CoreIPC/ArgumentEncoder.cpp:
        * Platform/CoreIPC/Attachment.cpp:
        * Platform/CoreIPC/BinarySemaphore.cpp:
        * Platform/CoreIPC/Connection.cpp:
        * Platform/CoreIPC/DataReference.cpp:
        * Platform/CoreIPC/gtk/ConnectionGtk.cpp:
        * Platform/CoreIPC/mac/ConnectionMac.cpp:
        * Platform/CoreIPC/qt/ConnectionQt.cpp:
        * Platform/CoreIPC/win/ConnectionWin.cpp:
        * Platform/Logging.cpp:
        * Platform/Module.cpp:
        * Platform/Region.cpp:
        * Platform/RunLoop.cpp:
        * Platform/WorkQueue.cpp:
        * Platform/cg/CGUtilities.cpp:
        * Platform/gtk/RunLoopGtk.cpp:
        * Platform/gtk/SharedMemoryGtk.cpp:
        * Platform/gtk/WorkQueueGtk.cpp:
        * Platform/mac/MachUtilities.cpp:
        * Platform/mac/SharedMemoryMac.cpp:
        * Platform/mac/WorkQueueMac.cpp:
        * Platform/qt/MappedMemoryPool.cpp:
        * Platform/qt/ModuleQt.cpp:
        * Platform/qt/RunLoopQt.cpp:
        * Platform/qt/WorkQueueQt.cpp:
        * Platform/win/ModuleWin.cpp:
        * Platform/win/RunLoopWin.cpp:
        * Platform/win/SharedMemoryWin.cpp:
        * Platform/win/WorkQueueWin.cpp:
        * PluginProcess/PluginControllerProxy.cpp:
        * PluginProcess/PluginProcess.cpp:
        * PluginProcess/WebProcessConnection.cpp:
        * Scripts/webkit2/messages.py:
        * Shared/API/c/WKArray.cpp:
        * Shared/API/c/WKCertificateInfo.cpp:
        * Shared/API/c/WKContextMenuItem.cpp:
        * Shared/API/c/WKData.cpp:
        * Shared/API/c/WKDictionary.cpp:
        * Shared/API/c/WKError.cpp:
        * Shared/API/c/WKImage.cpp:
        * Shared/API/c/WKMutableArray.cpp:
        * Shared/API/c/WKMutableDictionary.cpp:
        * Shared/API/c/WKNumber.cpp:
        * Shared/API/c/WKSecurityOrigin.cpp:
        * Shared/API/c/WKSerializedScriptValue.cpp:
        * Shared/API/c/WKString.cpp:
        * Shared/API/c/WKType.cpp:
        * Shared/API/c/WKURL.cpp:
        * Shared/API/c/WKURLRequest.cpp:
        * Shared/API/c/WKURLResponse.cpp:
        * Shared/API/c/WKUserContentURLPattern.cpp:
        * Shared/API/c/cf/WKStringCF.cpp:
        * Shared/API/c/cf/WKURLCF.cpp:
        * Shared/API/c/cf/WKURLRequestCF.cpp:
        * Shared/API/c/cf/WKURLResponseCF.cpp:
        * Shared/API/c/cg/WKImageCG.cpp:
        * Shared/API/c/win/WKCertificateInfoWin.cpp:
        * Shared/ChildProcess.cpp:
        * Shared/ImmutableArray.cpp:
        * Shared/ImmutableDictionary.cpp:
        * Shared/MutableArray.cpp:
        * Shared/MutableDictionary.cpp:
        * Shared/OriginAndDatabases.cpp:
        * Shared/PlatformPopupMenuData.cpp:
        * Shared/Plugins/NPIdentifierData.cpp:
        * Shared/Plugins/NPObjectMessageReceiver.cpp:
        * Shared/Plugins/NPObjectProxy.cpp:
        * Shared/Plugins/NPRemoteObjectMap.cpp:
        * Shared/Plugins/NPVariantData.cpp:
        * Shared/Plugins/Netscape/NetscapePluginModule.cpp:
        * Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:
        * Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
        * Shared/Plugins/PluginProcessCreationParameters.cpp:
        * Shared/PrintInfo.cpp:
        * Shared/SessionState.cpp:
        * Shared/ShareableBitmap.cpp:
        * Shared/UpdateInfo.cpp:
        * Shared/VisitedLinkTable.cpp:
        * Shared/WebBackForwardListItem.cpp:
        * Shared/WebContextMenuItem.cpp:
        * Shared/WebContextMenuItemData.cpp:
        * Shared/WebError.cpp:
        * Shared/WebEvent.cpp:
        * Shared/WebEventConversion.cpp:
        * Shared/WebGeolocationPosition.cpp:
        * Shared/WebImage.cpp:
        * Shared/WebKeyboardEvent.cpp:
        * Shared/WebMemorySampler.cpp:
        * Shared/WebMouseEvent.cpp:
        * Shared/WebOpenPanelParameters.cpp:
        * Shared/WebPageCreationParameters.cpp:
        * Shared/WebPageGroupData.cpp:
        * Shared/WebPlatformTouchPoint.cpp:
        * Shared/WebPopupItem.cpp:
        * Shared/WebPreferencesStore.cpp:
        * Shared/WebProcessCreationParameters.cpp:
        * Shared/WebTouchEvent.cpp:
        * Shared/WebURLRequest.cpp:
        * Shared/WebURLResponse.cpp:
        * Shared/WebWheelEvent.cpp:
        * Shared/cairo/ShareableBitmapCairo.cpp:
        * Shared/cf/ArgumentCodersCF.cpp:
        * Shared/cg/ShareableBitmapCG.cpp:
        * Shared/gtk/ShareableBitmapGtk.cpp:
        * Shared/gtk/WebCoreArgumentCodersGtk.cpp:
        * Shared/mac/CommandLineMac.cpp:
        * Shared/mac/UpdateChunk.cpp:
        * Shared/qt/CleanupHandler.cpp:
        * Shared/qt/NativeWebKeyboardEventQt.cpp:
        * Shared/qt/ShareableBitmapQt.cpp:
        * Shared/qt/UpdateChunk.cpp:
        * Shared/qt/WebCoreArgumentCodersQt.cpp:
        * Shared/qt/WebEventFactoryQt.cpp:
        * Shared/qt/WebURLRequestQt.cpp:
        * Shared/qt/WebURLResponseQt.cpp:
        * Shared/win/CommandLineWin.cpp:
        * Shared/win/NativeWebKeyboardEventWin.cpp:
        * Shared/win/PlatformCertificateInfo.cpp:
        * Shared/win/UpdateChunk.cpp:
        * Shared/win/WebCoreArgumentCodersWin.cpp:
        * Shared/win/WebEventFactory.cpp:
        * Shared/win/WebURLRequestWin.cpp:
        * Shared/win/WebURLResponseWin.cpp:
        * UIProcess/API/C/WKAuthenticationChallenge.cpp:
        * UIProcess/API/C/WKAuthenticationDecisionListener.cpp:
        * UIProcess/API/C/WKBackForwardList.cpp:
        * UIProcess/API/C/WKBackForwardListItem.cpp:
        * UIProcess/API/C/WKContext.cpp:
        * UIProcess/API/C/WKCredential.cpp:
        * UIProcess/API/C/WKDatabaseManager.cpp:
        * UIProcess/API/C/WKDownload.cpp:
        * UIProcess/API/C/WKFormSubmissionListener.cpp:
        * UIProcess/API/C/WKFrame.cpp:
        * UIProcess/API/C/WKFramePolicyListener.cpp:
        * UIProcess/API/C/WKGeolocationManager.cpp:
        * UIProcess/API/C/WKGeolocationPermissionRequest.cpp:
        * UIProcess/API/C/WKGeolocationPosition.cpp:
        * UIProcess/API/C/WKInspector.cpp:
        * UIProcess/API/C/WKNavigationData.cpp:
        * UIProcess/API/C/WKOpenPanelParameters.cpp:
        * UIProcess/API/C/WKOpenPanelResultListener.cpp:
        * UIProcess/API/C/WKPage.cpp:
        * UIProcess/API/C/WKPageGroup.cpp:
        * UIProcess/API/C/WKPreferences.cpp:
        * UIProcess/API/C/WKProtectionSpace.cpp:
        * UIProcess/API/C/win/WKContextWin.cpp:
        * UIProcess/API/C/win/WKView.cpp:
        * UIProcess/API/C/win/WKViewPrivate.cpp:
        * UIProcess/API/cpp/qt/WKStringQt.cpp:
        * UIProcess/API/cpp/qt/WKURLQt.cpp:
        * UIProcess/API/qt/ClientImpl.cpp:
        * UIProcess/API/qt/qgraphicswkview.cpp:
        * UIProcess/API/qt/qwkcontext.cpp:
        * UIProcess/API/qt/qwkpage.cpp:
        * UIProcess/API/qt/qwkpreferences.cpp:
        * UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
        * UIProcess/Authentication/AuthenticationDecisionListener.cpp:
        * UIProcess/Authentication/WebCredential.cpp:
        * UIProcess/Authentication/WebProtectionSpace.cpp:
        * UIProcess/BackingStore.cpp:
        * UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
        * UIProcess/Downloads/DownloadProxy.cpp:
        * UIProcess/DrawingAreaProxy.cpp:
        * UIProcess/DrawingAreaProxyImpl.cpp:
        * UIProcess/FindIndicator.cpp:
        * UIProcess/GeolocationPermissionRequestManagerProxy.cpp:
        * UIProcess/GeolocationPermissionRequestProxy.cpp:
        * UIProcess/Launcher/ProcessLauncher.cpp:
        * UIProcess/Launcher/ThreadLauncher.cpp:
        * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
        * UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
        * UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
        * UIProcess/Launcher/qt/ThreadLauncherQt.cpp:
        * UIProcess/Launcher/win/ProcessLauncherWin.cpp:
        * UIProcess/Launcher/win/ThreadLauncherWin.cpp:
        * UIProcess/LayerBackedDrawingAreaProxy.cpp:
        * UIProcess/Plugins/PluginInfoStore.cpp:
        * UIProcess/Plugins/PluginProcessManager.cpp:
        * UIProcess/Plugins/PluginProcessProxy.cpp:
        * UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
        * UIProcess/Plugins/qt/PluginInfoStoreQt.cpp:
        * UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
        * UIProcess/ResponsivenessTimer.cpp:
        * UIProcess/TiledDrawingAreaProxy.cpp:
        * UIProcess/VisitedLinkProvider.cpp:
        * UIProcess/WebBackForwardList.cpp:
        * UIProcess/WebContext.cpp:
        * UIProcess/WebContextInjectedBundleClient.cpp:
        * UIProcess/WebContextMenuProxy.cpp:
        * UIProcess/WebDatabaseManagerProxy.cpp:
        * UIProcess/WebDatabaseManagerProxyClient.cpp:
        * UIProcess/WebDownloadClient.cpp:
        * UIProcess/WebEditCommandProxy.cpp:
        * UIProcess/WebFindClient.cpp:
        * UIProcess/WebFormClient.cpp:
        * UIProcess/WebFormSubmissionListenerProxy.cpp:
        * UIProcess/WebFrameListenerProxy.cpp:
        * UIProcess/WebFramePolicyListenerProxy.cpp:
        * UIProcess/WebFrameProxy.cpp:
        * UIProcess/WebGeolocationManagerProxy.cpp:
        * UIProcess/WebGeolocationProvider.cpp:
        * UIProcess/WebHistoryClient.cpp:
        * UIProcess/WebInspectorProxy.cpp:
        * UIProcess/WebLoaderClient.cpp:
        * UIProcess/WebNavigationData.cpp:
        * UIProcess/WebOpenPanelResultListenerProxy.cpp:
        * UIProcess/WebPageContextMenuClient.cpp:
        * UIProcess/WebPageGroup.cpp:
        * UIProcess/WebPageProxy.cpp:
        * UIProcess/WebPolicyClient.cpp:
        * UIProcess/WebPreferences.cpp:
        * UIProcess/WebProcessManager.cpp:
        * UIProcess/WebProcessProxy.cpp:
        * UIProcess/WebResourceLoadClient.cpp:
        * UIProcess/WebUIClient.cpp:
        * UIProcess/cf/WebBackForwardListCF.cpp:
        * UIProcess/cf/WebPageProxyCF.cpp:
        * UIProcess/cf/WebPreferencesCF.cpp:
        * UIProcess/gtk/TextCheckerGtk.cpp:
        * UIProcess/gtk/WebInspectorGtk.cpp:
        * UIProcess/gtk/WebPageProxyGtk.cpp:
        * UIProcess/gtk/WebPreferencesGtk.cpp:
        * UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:
        * UIProcess/qt/TextCheckerQt.cpp:
        * UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
        * UIProcess/qt/TiledDrawingAreaTileQt.cpp:
        * UIProcess/qt/WebContextMenuProxyQt.cpp:
        * UIProcess/qt/WebContextQt.cpp:
        * UIProcess/qt/WebInspectorProxyQt.cpp:
        * UIProcess/qt/WebPageProxyQt.cpp:
        * UIProcess/qt/WebPopupMenuProxyQt.cpp:
        * UIProcess/qt/WebPreferencesQt.cpp:
        * UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp:
        * UIProcess/win/LayerBackedDrawingAreaProxyWin.cpp:
        * UIProcess/win/TextCheckerWin.cpp:
        * UIProcess/win/WebContextMenuProxyWin.cpp:
        * UIProcess/win/WebContextWin.cpp:
        * UIProcess/win/WebInspectorProxyWin.cpp:
        * UIProcess/win/WebPageProxyWin.cpp:
        * UIProcess/win/WebPopupMenuProxyWin.cpp:
        * UIProcess/win/WebView.cpp:
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/Authentication/AuthenticationManager.cpp:
        * WebProcess/Downloads/Download.cpp:
        * WebProcess/Downloads/DownloadManager.cpp:
        * WebProcess/Downloads/cf/DownloadCFNet.cpp:
        * WebProcess/Downloads/curl/DownloadCurl.cpp:
        * WebProcess/Downloads/qt/DownloadQt.cpp:
        * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
        * WebProcess/Geolocation/WebGeolocationManager.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundlePageGroup.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:
        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
        * WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        * WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:
        * WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:
        * WebProcess/InjectedBundle/InjectedBundleClient.cpp:
        * WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
        * WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
        * WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
        * WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
        * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
        * WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
        * WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:
        * WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
        * WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
        * WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:
        * WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
        * WebProcess/Plugins/Netscape/JSNPMethod.cpp:
        * WebProcess/Plugins/Netscape/JSNPObject.cpp:
        * WebProcess/Plugins/Netscape/NPJSObject.cpp:
        * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
        * WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
        * WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
        * WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
        * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
        * WebProcess/Plugins/Plugin.cpp:
        * WebProcess/Plugins/PluginProcessConnection.cpp:
        * WebProcess/Plugins/PluginProcessConnectionManager.cpp:
        * WebProcess/Plugins/PluginProxy.cpp:
        * WebProcess/Plugins/PluginView.cpp:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
        * WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
        * WebProcess/WebCoreSupport/WebDragClient.cpp:
        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        * WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
        * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
        * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
        * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
        * WebProcess/WebCoreSupport/WebPopupMenu.cpp:
        * WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:
        * WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
        * WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
        * WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
        * WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:
        * WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
        * WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp:
        * WebProcess/WebCoreSupport/win/WebContextMenuClientWin.cpp:
        * WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
        * WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
        * WebProcess/WebKitMain.cpp:
        * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
        * WebProcess/WebPage/DecoderAdapter.cpp:
        * WebProcess/WebPage/DrawingArea.cpp:
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        * WebProcess/WebPage/EncoderAdapter.cpp:
        * WebProcess/WebPage/FindController.cpp:
        * WebProcess/WebPage/LayerBackedDrawingArea.cpp:
        * WebProcess/WebPage/PageOverlay.cpp:
        * WebProcess/WebPage/TiledDrawingArea.cpp:
        * WebProcess/WebPage/WebBackForwardListProxy.cpp:
        * WebProcess/WebPage/WebContextMenu.cpp:
        * WebProcess/WebPage/WebEditCommand.cpp:
        * WebProcess/WebPage/WebFrame.cpp:
        * WebProcess/WebPage/WebInspector.cpp:
        * WebProcess/WebPage/WebOpenPanelResultListener.cpp:
        * WebProcess/WebPage/WebPage.cpp:
        * WebProcess/WebPage/WebPageGroupProxy.cpp:
        * WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
        * WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp:
        * WebProcess/WebPage/qt/ChunkedUpdateDrawingAreaQt.cpp:
        * WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp:
        * WebProcess/WebPage/qt/WebInspectorQt.cpp:
        * WebProcess/WebPage/qt/WebPageQt.cpp:
        * WebProcess/WebPage/win/ChunkedUpdateDrawingAreaWin.cpp:
        * WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp:
        * WebProcess/WebPage/win/WebInspectorWin.cpp:
        * WebProcess/WebPage/win/WebPageWin.cpp:
        * WebProcess/WebProcess.cpp:
        * WebProcess/gtk/WebProcessGtk.cpp:
        * WebProcess/gtk/WebProcessMainGtk.cpp:
        * WebProcess/qt/WebProcessMainQt.cpp:
        * WebProcess/qt/WebProcessQt.cpp:
        * WebProcess/win/WebProcessMainWin.cpp:
        * WebProcess/win/WebProcessWin.cpp:
        * config.h: Copied from Source/WebKit2/WebKit2Prefix.h.
        * win/WebKit2Common.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 28 Jan 2011 05:30:10 +0000 (05:30 +0000)]
2011-01-27  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dan Bernstein.

        Recalc table sections if needed before calculating the first line
        box baseline.
        https://bugs.webkit.org/show_bug.cgi?id=53265

        When we try to calculate the baseline position of a table cell,
        we recurse through all the child sibling boxes (when children are
        non inline) and add their first linebox baseline values. If one of
        the children is a table with pending section recalc, we will access
        wrong table section values. We recalc table sections if it is needed.

        Test: fast/table/recalc-section-first-body-crash-main.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::firstLineBoxBaseline):
2011-01-27  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dan Bernstein.

        Tests that we do not crash when calculating the first line box
        baseline for the table.
        https://bugs.webkit.org/show_bug.cgi?id=53265

        * fast/table/recalc-section-first-body-crash-main-expected.txt: Added.
        * fast/table/recalc-section-first-body-crash-main.html: Added.
        * fast/table/resources/recalc-section-first-body-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 28 Jan 2011 04:26:02 +0000 (04:26 +0000)]
2011-01-27  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        [chromium] Add CRASH calls to further debug tiled compositor memcpy crash.
        https://bugs.webkit.org/show_bug.cgi?id=52379

        Test: LayoutTests/compositing (to verify these weren't triggered)

        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::invalidateRect):
        (WebCore::LayerTilerChromium::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 28 Jan 2011 04:14:43 +0000 (04:14 +0000)]
2011-01-27  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [STYLES] Cancelled suggestion of a property name results in a visual artifact
        https://bugs.webkit.org/show_bug.cgi?id=53242

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 28 Jan 2011 03:42:56 +0000 (03:42 +0000)]
2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76891.
        http://trac.webkit.org/changeset/76891
        https://bugs.webkit.org/show_bug.cgi?id=53280

        Makes every layout test crash (Requested by othermaciej on
        #webkit).

        * page/EventHandler.cpp:
        * page/EventHandler.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::styleDidChange):
2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76891.
        http://trac.webkit.org/changeset/76891
        https://bugs.webkit.org/show_bug.cgi?id=53280

        Makes every layout test crash (Requested by othermaciej on
        #webkit).

        * Misc/WebIconDatabase.mm:
        (-[ThreadEnabler threadEnablingSelector:]):
        (importToWebCoreFormat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 28 Jan 2011 03:30:24 +0000 (03:30 +0000)]
2011-01-27  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed, rolling out r76839.
        http://trac.webkit.org/changeset/76839
        https://bugs.webkit.org/show_bug.cgi?id=49744

        broke pixel tests

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::localCaretRect):
2011-01-27  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed, rolling out r76839.
        http://trac.webkit.org/changeset/76839
        https://bugs.webkit.org/show_bug.cgi?id=49744

        broke pixel tests

        * editing/selection/caret-painting-after-paste-undo-rtl.html: Removed.
        * editing/selection/caret-painting-after-paste-undo.html: Removed.
        * platform/mac/editing/deleting/5408255-expected.png:
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Removed.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Removed.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Removed.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Removed.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Removed.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 28 Jan 2011 03:09:48 +0000 (03:09 +0000)]
2011-01-27  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        execCommand("Paste") doesn't work in WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=52785

        Unskip paste tests, except the ones that still fail.

        * platform/mac-wk2/Skipped:
2011-01-27  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        execCommand("Paste") doesn't work in WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=52785

        Thread through the new JavaScriptCanAccessClipboard setting.

        * Shared/WebPreferencesStore.h:
        * UIProcess/API/C/WKPreferences.cpp:
        (WKPreferencesSetJavaScriptCanAccessClipboard):
        (WKPreferencesGetJavaScriptCanAccessClipboard):
        * UIProcess/API/C/WKPreferences.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::updatePreferences):
2011-01-27  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        execCommand("Paste") doesn't work in WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=52785

        Enable both of the settings needed to allow paste.

        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::resetStateToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Emil A Eklund <eae@chromium.org>
commit-queue@webkit.org [Fri, 28 Jan 2011 02:41:33 +0000 (02:41 +0000)]
2011-01-27  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        contentEditable formatBlock crashes on divs with contenteditable="false"
        https://bugs.webkit.org/show_bug.cgi?id=53263

        Add test for executing a formatBlock command on a selection containing an
        element with contenteditable=false.

        * editing/execCommand/format-block-contenteditable-false-expected.txt: Added.
        * editing/execCommand/format-block-contenteditable-false.html: Added.
2011-01-27  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        contentEditable formatBlock crashes on divs with contenteditable="false"
        https://bugs.webkit.org/show_bug.cgi?id=53263

        Check if editableRootForPosition returns null for position.

        Test: editing/execCommand/format-block-contenteditable-false.html

        * editing/FormatBlockCommand.cpp:
        (WebCore::FormatBlockCommand::formatRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 28 Jan 2011 02:26:02 +0000 (02:26 +0000)]
2011-01-27  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Remove RenderMedia members that aren't used.
        https://bugs.webkit.org/show_bug.cgi?id=53245

        Refactoring, no change in behavior, so no new tests.

        * rendering/RenderMedia.h: Removed unused member variables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 28 Jan 2011 02:20:47 +0000 (02:20 +0000)]
2011-01-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add WTFString method to compare equality with Vector<UChar>
        https://bugs.webkit.org/show_bug.cgi?id=53266

        I'm planning to use this method in the new XSS filter implementation,
        but it seems generally useful.

        * wtf/text/StringImpl.h:
        (WTF::equalIgnoringNullity):
        * wtf/text/WTFString.h:
        (WTF::equalIgnoringNullity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Fri, 28 Jan 2011 02:18:02 +0000 (02:18 +0000)]
2011-01-27  Michael Saboff  <msaboff@apple.com>

        Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
        https://bugs.webkit.org/show_bug.cgi?id=53271

        Added new isValid() methods to check if a contained object in
        a WeakGCMap is valid when using an unchecked iterator.

        * runtime/WeakGCMap.h:
        (JSC::WeakGCMap::isValid):
2011-01-27  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
        https://bugs.webkit.org/show_bug.cgi?id=53271

        Precautionary change.
        Changed RootObject to use WeakGCMap instead of HashSet.
        Found will looking for another issue, but can't produce a test case
        that is problematic.  THerefore there aren't any new tests.

        * bridge/runtime_root.cpp:
        (JSC::Bindings::RootObject::invalidate):
        (JSC::Bindings::RootObject::addRuntimeObject):
        (JSC::Bindings::RootObject::removeRuntimeObject):
        * bridge/runtime_root.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Kenneth Russell <kbr@google.com>
kbr@google.com [Fri, 28 Jan 2011 02:15:13 +0000 (02:15 +0000)]
2011-01-27  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Rename Typed Array slice() to subset()
        https://bugs.webkit.org/show_bug.cgi?id=53273

        * bindings/js/JSArrayBufferViewHelper.h:
        (WebCore::constructArrayBufferView):
        * bindings/v8/custom/V8ArrayBufferViewCustom.h:
        (WebCore::constructWebGLArray):
        * html/canvas/Float32Array.cpp:
        (WebCore::Float32Array::subset):
        * html/canvas/Float32Array.h:
        * html/canvas/Float32Array.idl:
        * html/canvas/Int16Array.cpp:
        (WebCore::Int16Array::subset):
        * html/canvas/Int16Array.h:
        * html/canvas/Int16Array.idl:
        * html/canvas/Int32Array.cpp:
        (WebCore::Int32Array::subset):
        * html/canvas/Int32Array.h:
        * html/canvas/Int32Array.idl:
        * html/canvas/Int8Array.cpp:
        (WebCore::Int8Array::subset):
        * html/canvas/Int8Array.h:
        * html/canvas/Int8Array.idl:
        * html/canvas/TypedArrayBase.h:
        (WebCore::TypedArrayBase::subsetImpl):
        * html/canvas/Uint16Array.cpp:
        (WebCore::Uint16Array::subset):
        * html/canvas/Uint16Array.h:
        * html/canvas/Uint16Array.idl:
        * html/canvas/Uint32Array.cpp:
        (WebCore::Uint32Array::subset):
        * html/canvas/Uint32Array.h:
        * html/canvas/Uint32Array.idl:
        * html/canvas/Uint8Array.cpp:
        (WebCore::Uint8Array::subset):
        * html/canvas/Uint8Array.h:
        * html/canvas/Uint8Array.idl:
2011-01-27  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Rename Typed Array slice() to subset()
        https://bugs.webkit.org/show_bug.cgi?id=53273

        * fast/canvas/webgl/array-setters.html:
        * fast/canvas/webgl/array-unit-tests-expected.txt:
        * fast/canvas/webgl/array-unit-tests.html:
        * fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
        * fast/canvas/webgl/draw-elements-out-of-bounds.html:
        * fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
        * fast/canvas/webgl/webgl-array-invalid-ranges.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 28 Jan 2011 02:12:39 +0000 (02:12 +0000)]
2011-01-27  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Changing cursor style has no effect until the mouse moves
        https://bugs.webkit.org/show_bug.cgi?id=14344
        rdar://problem/7563712

        No tests added because we don't have infrastructure for testing actual cursor
        changes (as opposed to cursor style computation) at this time. We might add it later.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::dispatchFakeMouseMoveEventSoon): Added.
        * page/EventHandler.h: Ditto.

        * rendering/RenderObject.cpp:
        (WebCore::areNonIdenticalCursorListsEqual): Added.
        (WebCore::areCursorsEqual): Added.
        (WebCore::RenderObject::styleDidChange): Call dispatchFakeMouseMoveEventSoon if
        cursor styles changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Finnur Thorarinsson <finnur.webkit@gmail.com>
commit-queue@webkit.org [Fri, 28 Jan 2011 02:03:58 +0000 (02:03 +0000)]
2011-01-27  Finnur Thorarinsson  <finnur.webkit@gmail.com>

        Reviewed by Ojan Vafai.

        This addresses a regression introduced by r75784, as described in:
        https://bugs.webkit.org/show_bug.cgi?id=53176

        The problem is that originalEndContainer and originalEndOffset was
        meant to capture the end of the document, but was being assigned after
        a call to searchRange->setStart() (when scoping is restarted), which can
        result in the Range being collapsed to start (thereby assigning the
        wrong value to the Container/Offset pair).

        This code is never triggered by layout tests, but I'm adding a regressiono
        test on the Chromium side for this.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::scopeStringMatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Leo Yang <leo.yang@torchmobile.com.cn>
commit-queue@webkit.org [Fri, 28 Jan 2011 01:51:51 +0000 (01:51 +0000)]
2011-01-27  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Dirk Schulze.

        SVG Use Cycle is not detected
        https://bugs.webkit.org/show_bug.cgi?id=52544

        Test for indirect <use> recursion. This test passes if
        no crash occurs.

        * svg/custom/recursive-use2-expected.txt: Added.
        * svg/custom/recursive-use2.svg: Added.
2011-01-27  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Dirk Schulze.

        SVG Use Cycle is not detected
        https://bugs.webkit.org/show_bug.cgi?id=52544

        We should check if SVGUseElement::buildInstanceTree finds problem
        for every child node. If it finds problem for any children we must
        return immediately because otherwise the foundProblem variable may
        be rewritten to false.

        Test: svg/custom/recursive-use2.svg

        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::buildInstanceTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 28 Jan 2011 01:29:16 +0000 (01:29 +0000)]
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Define GC3D types to match GL types and use them in WebGraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=51947

        * public/WebGraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 28 Jan 2011 01:26:12 +0000 (01:26 +0000)]
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        texSubImage2D's format/type needs to match the internalformat/type from the previous texImage2D call
        https://bugs.webkit.org/show_bug.cgi?id=53054

        * fast/canvas/webgl/tex-sub-image-2d-bad-args-expected.txt: Added.
        * fast/canvas/webgl/tex-sub-image-2d-bad-args.html: Added.
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        texSubImage2D's format/type needs to match the internalformat/type from the previous texImage2D call
        https://bugs.webkit.org/show_bug.cgi?id=53054

        Test: fast/canvas/webgl/tex-sub-image-2d-bad-args.html

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::texSubImage2DBase): Check format/type match.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Yi Shen <yi.4.shen@nokia.com>, Tor Arne Vestbø <tor.arne.vestbo@nokia...
commit-queue@webkit.org [Fri, 28 Jan 2011 01:23:22 +0000 (01:23 +0000)]
2011-01-27  Yi Shen  <yi.4.shen@nokia.com>, Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Add fullscreen media control button for html video
        https://bugs.webkit.org/show_bug.cgi?id=51543

        Implement media control fullscreen button for QtWebKit html5 video.

        * css/mediaControlsQt.css:
        (video::-webkit-media-controls-fullscreen-button):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::paintMediaFullscreenButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Fri, 28 Jan 2011 01:22:16 +0000 (01:22 +0000)]
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Remove FrameLoader::url() and update callers to use
        Document::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        Refactor, no new tests.

        * WebCore.exp.in:
        * dom/Document.cpp:
        (WebCore::Document::processHttpEquiv):
        (WebCore::Document::removePendingSheet):
        * history/CachedFrame.cpp:
        (WebCore::CachedFrameBase::CachedFrameBase):
        * history/PageCache.cpp:
        (WebCore::logCanCacheFrameDecision):
        (WebCore::PageCache::canCachePageContainingThisFrame):
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::isURLAllowed):
        * html/HTMLPlugInImageElement.cpp:
        (WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL):
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::inspectedURL):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::buildObjectForFrame):
        * loader/DocumentWriter.cpp:
        (WebCore::DocumentWriter::replaceDocument):
        (WebCore::DocumentWriter::deprecatedFrameEncoding):
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/HistoryController.cpp:
        (WebCore::HistoryController::updateForStandardLoad):
        (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
        (WebCore::HistoryController::updateForSameDocumentNavigation):
        * loader/NavigationScheduler.cpp:
        (WebCore::ScheduledHistoryNavigation::fire):
        (WebCore::NavigationScheduler::scheduleLocationChange):
        (WebCore::NavigationScheduler::scheduleRefresh):
        * page/FrameView.cpp:
        (WebCore::FrameView::updateControlTints):
        * page/Location.cpp:
        (WebCore::Location::url):
        (WebCore::Location::setProtocol):
        (WebCore::Location::setHost):
        (WebCore::Location::setHostname):
        (WebCore::Location::setPort):
        (WebCore::Location::setPathname):
        (WebCore::Location::setSearch):
        (WebCore::Location::setHash):
        (WebCore::Location::reload):
        * page/Page.cpp:
        (WebCore::Page::goToItem):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * ewk/ewk_frame.cpp:
        (ewk_frame_uri_changed):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_icon_uri):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
        (WebCore::FrameLoaderClientHaiku::dispatchDidFinishDocumentLoad):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * WebView/WebView.mm:
        (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * Api/qwebframe.cpp:
        (QWebFrame::url):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * WebFrame.cpp:
        (WebFrame::url):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::dispatchDidFinishDocumentLoad):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
        (WebKit::WebFrameLoaderClient::dispatchDidPushStateWithinPage):
        (WebKit::WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
        (WebKit::WebFrameLoaderClient::dispatchDidPopStateWithinPage):
        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::url):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix scrollbars in Safari's Downloads window and Bookmarks view by implementing two...
aroben@apple.com [Fri, 28 Jan 2011 01:19:27 +0000 (01:19 +0000)]
Fix scrollbars in Safari's Downloads window and Bookmarks view by implementing two needed functions from ScrollableArea.

Patch by Sam Weinig <sam@webkit.org> on 2011-01-27
Reviewed by Adam Roben.

* WebScrollBar.cpp:
(WebScrollBar::horizontalScrollbar): Return the WebCore::Scrollbar if
we are a horizontal scrollbar.
(WebScrollBar::verticalScrollbar): Return the WebCore::Scrollbar if we
are a vertical scrollbar.
* WebScrollBar.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 28 Jan 2011 01:07:31 +0000 (01:07 +0000)]
2011-01-27  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed rebaselines for Chromium Mac and Windows.

        [chromium] fast/repaint/select-option-background-color.html fails on Windows and Mac
        https://bugs.webkit.org/show_bug.cgi?id=53260

        * platform/chromium-mac/fast/repaint/select-option-background-color-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/select-option-background-color-expected.png: Added.
        * platform/chromium-win/fast/repaint/select-option-background-color-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/select-option-background-color-expected.png: Added.
        * platform/chromium-win/fast/repaint/select-option-background-color-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Fri, 28 Jan 2011 00:58:02 +0000 (00:58 +0000)]
2011-01-27  Stephen White  <senorblanco@chromium.org>

        Reviewed by Darin Adler.

        Fix performance regression in ImageQualityController::objectDestroyed().
        https://bugs.webkit.org/show_bug.cgi?id=52645

        In r72282, I inadvertently introduced this regression by using a
        linear search through the hash map on object destruction.  This was
        because the hash key consisted of both object pointer and layer id,
        but on object destruction we only know the object pointer, requiring
        a search to find all the layers.
        By replacing the hash map with two nested hash maps, where the outer key
        is the object and the inner key is the layer, we can find all the
        relevant data for an object in one hash lookup.

        * rendering/RenderBoxModelObject.cpp:
        Replace the (object,layer)->size HashMap with object->layer and
        layer->size HashMaps.
        (WebCore::ImageQualityController::isEmpty):
        Implement isEmpty() for the outer HashMap.
        (WebCore::ImageQualityController::removeLayer):
        When a layer is removed, remove it from the inner hash map.
        (WebCore::ImageQualityController::set):
        Implement set():  if the inner map exists, set the layer->size tuple
        directly.  If not, create a new inner map, set the tuple, and insert
        it in the outer map.
        (WebCore::ImageQualityController::objectDestroyed):
        Look up the object in the outer map only.
        (WebCore::ImageQualityController::highQualityRepaintTimerFired):
        Cosmetic changes for the renamed now-outer hash map.
        (WebCore::ImageQualityController::shouldPaintAtLowQuality):
        Do both outer and inner hash map lookups.  Call set() to add/update
        entries to the hash maps.  keyDestroyed() is now removeLayer().
        (WebCore::imageQualityController):
        Make the ImageQualityController a file-static global, so it can be
        created and destroyed on the fly.
        (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
        If there is no ImageQualityController, don't call objectDestroyed().
        If it's empty, delete it.
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintIntoRect):
        Also pass the Image* as the (void*) layer, since 0 is not a valid
        HashMap key.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 28 Jan 2011 00:50:34 +0000 (00:50 +0000)]
2011-01-27  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Tiled compositor crashes if compositing turned off mid-paint
        https://bugs.webkit.org/show_bug.cgi?id=53198

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::drawLayers):
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::update):
        (WebCore::LayerTilerChromium::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 28 Jan 2011 00:49:36 +0000 (00:49 +0000)]
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Unreviewed, roll webkit chromium rev from 72673 to 72894.
        Also, added gmock section in DEPS to pull down gmock.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Alexey Marinichev <amarinichev@chromium.org>
commit-queue@webkit.org [Fri, 28 Jan 2011 00:36:18 +0000 (00:36 +0000)]
2011-01-27  Alexey Marinichev  <amarinichev@chromium.org>

        Reviewed by Kenneth Russell.

        Add a callback to WebGraphicsContext3D that is called when a context is lost
        https://bugs.webkit.org/show_bug.cgi?id=53153

        * public/WebGraphicsContext3D.h:
        (WebKit::WebGraphicsContext3D::setContextLostCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Jacob Dinu <dinu.jacob@nokia.com>
commit-queue@webkit.org [Fri, 28 Jan 2011 00:21:55 +0000 (00:21 +0000)]
2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
        https://bugs.webkit.org/show_bug.cgi?id=48440

        Preserve user input when toggling use of QGraphicsView

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::initializeView):
        (LauncherWindow::loadFinished):
        * QtTestBrowser/launcherwindow.h:
        * QtTestBrowser/mainwindow.cpp:
        (MainWindow::addressUrl):
        * QtTestBrowser/mainwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Carol Szabo <carol.szabo@nokia.com>
carol.szabo@nokia.com [Fri, 28 Jan 2011 00:14:16 +0000 (00:14 +0000)]
2011-01-27  Carol Szabo <carol.szabo@nokia.com>

        Reviewed by David Hyatt.

        A corrupted counter tree is created when renderers are added to the
        tree bypassing RenderObject::addChild
        https://bugs.webkit.org/show_bug.cgi?id=51270

        No new tests. This patch reimplements the fix for bugs 43812 and
        51637 and hence all tests are already there as part of the original
        fixes for those bugs.

        * rendering/RenderCounter.cpp:
        (WebCore::findPlaceForCounter):
        Removed old workaround as this patch hopefully fixes the real
        problem.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::addChild):
        Removed call to counter updater as it was moved to a lower level.
        (WebCore::RenderObject::destroy):
        Moved attached counter nodes destruction to after the node is
        removed from the tree.
        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::removeChildNode):
        (WebCore::RenderObjectChildList::appendChildNode):
        (WebCore::RenderObjectChildList::insertChildNode):
        Added notifications to the Counter system such that the
        CounterForest reflects the changes to the RendererTree.
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::destroy):
        Applied the same changes as for RenderObject::destroy()
        since RenderObject::destroy() is not called from here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd WKCACFViewLayerTreeHost
aroben@apple.com [Thu, 27 Jan 2011 23:40:41 +0000 (23:40 +0000)]
Add WKCACFViewLayerTreeHost

This is a class that derives from CACFLayerTreeHost and uses a WKCACFView to render.

Fixes <http://webkit.org/b/53251> <rdar://problem/8925496> CACFLayerTreeHost should use
WKCACFView for rendering

* WebCore.vcproj/WebCore.vcproj: Added WKCACFViewLayerTreeHost.{cpp,h}.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Make the test window have a
non-zero size. WKCACFView will always say it can't render if you pass it a 0-sized window,
so we need a non-empty window to perform a valid test.
(WebCore::CACFLayerTreeHost::create): First try to create a WKCACFViewLayerTreeHost, then
fall back to a LegacyCACFLayerTreeHost.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Moved code to react to the
context flush from here...
(WebCore::CACFLayerTreeHost::contextDidChange): ...to here. Derived classes are required to
call this function whenever changes are flushed to the context.

* platform/graphics/ca/win/CACFLayerTreeHost.h: Added contextDidChange.

* platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
(WebCore::LegacyCACFLayerTreeHost::createRenderer):
(WebCore::LegacyCACFLayerTreeHost::resize):
Changed to use flushContext instead of flushing the context manually so that we will always
notify the base class when the context gets flushed.

(WebCore::LegacyCACFLayerTreeHost::flushContext): Added a call to contextDidChange so the
base class will know what happened. Moved code to schedule a render from here...
(WebCore::LegacyCACFLayerTreeHost::contextDidChange): ...to here.

* platform/graphics/ca/win/LegacyCACFLayerTreeHost.h: Added contextDidChange.

* platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Added.
(WebCore::WKCACFViewLayerTreeHost::create): If WebKitQuartzCoreAdditions, which provides
WKCACFView, isn't present, bail. Otherwise allocate and return a new host.
(WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost): Initialize members.
(WebCore::WKCACFViewLayerTreeHost::updateViewIfNeeded): Update the view if we previously
marked that we needed to do so, and flush the context if our layer's bounds have changed.
(WebCore::WKCACFViewLayerTreeHost::contextDidChangeCallback): Call through to
contextDidChange.
(WebCore::WKCACFViewLayerTreeHost::contextDidChange): Tell the WKCACFView to start rendering
(if we didn't already), then call up to the base class.
(WebCore::WKCACFViewLayerTreeHost::initializeContext): Set the context's user data, the
view's layer, and hook up our "context did change" callback.
(WebCore::WKCACFViewLayerTreeHost::resize): Mark that the view needs to be updated the next
time we paint.
(WebCore::WKCACFViewLayerTreeHost::createRenderer): Update our view and return whether it is
able to render or not.
(WebCore::WKCACFViewLayerTreeHost::destroyRenderer): Clear out all the info we passed down
to the view.
(WebCore::WKCACFViewLayerTreeHost::lastCommitTime): Call through to the view.
(WebCore::WKCACFViewLayerTreeHost::flushContext): Ditto.
(WebCore::WKCACFViewLayerTreeHost::paint): Update the view so it will draw at the right
size, then call up to the base class.
(WebCore::WKCACFViewLayerTreeHost::render): Invalidate the view using the passed-in dirty
rects, then ask it to draw.

* platform/graphics/ca/win/WKCACFViewLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/ca/win/LegacyCACFLayerTreeHost.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove LegacyCACFLayerTreeHost into its own files
aroben@apple.com [Thu, 27 Jan 2011 23:39:50 +0000 (23:39 +0000)]
Move LegacyCACFLayerTreeHost into its own files

More preparation for <http://webkit.org/b/53251> <rdar://problem/8925496> CACFLayerTreeHost

Reviewed by Simon Fraser.

* WebCore.vcproj/WebCore.vcproj: Added LegacyCACFLayerTreeHost.{cpp,h}.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp: Moved code from here to new files.

* platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp: Added.
* platform/graphics/ca/win/LegacyCACFLayerTreeHost.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 27 Jan 2011 23:33:35 +0000 (23:33 +0000)]
2011-01-27  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed, fixed upstream Chromium build

        r76844 should have rolled back Chromium DEPS to 72673, not 72637.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 27 Jan 2011 23:29:51 +0000 (23:29 +0000)]
2011-01-27  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r76824.

        * platform/wince/DragDataWinCE.cpp:
        (WebCore::DragData::dragDataMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSplit CACFLayerTreeHost into base and derived classes
aroben@apple.com [Thu, 27 Jan 2011 23:26:27 +0000 (23:26 +0000)]
Split CACFLayerTreeHost into base and derived classes

The derived class, LegacyCACFLayerTreeHost, contains all the D3D-related code. A later patch
will add a new derived class that replaces the D3D code with a different rendering API.

For now, LegacyCACFLayerTreeHost lives in CACFLayerTreeHost.cpp. This keeps the diff a
little smaller. A later patch will move it to its own source files.

Preparation for <http://webkit.org/b/53251> <rdar://problem/8925496> CACFLayerTreeHost
should use WKCACFView for rendering

Reviewed by Simon Fraser.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Clear the window before
destroying the host, as that is now the API contract that clients must fulfill.
(WebCore::LegacyCACFLayerTreeHost::create): Added. Simple creator.
(WebCore::CACFLayerTreeHost::create): Now instantiates a LegacyCACFLayerTreeHost. Calls the
new initialize function to perform initialization that has to happen after the vtable has
been set up.

(WebCore::LegacyCACFLayerTreeHost::LegacyCACFLayerTreeHost):
(WebCore::CACFLayerTreeHost::CACFLayerTreeHost):
(WebCore::LegacyCACFLayerTreeHost::initializeContext):
(WebCore::CACFLayerTreeHost::initialize):
Moved some initialization code from the CACFLayerTreeHost constructor into these new
functions.

(WebCore::LegacyCACFLayerTreeHost::~LegacyCACFLayerTreeHost): Added. Moved code here from
~CACFLayerTreeHost.
(WebCore::CACFLayerTreeHost::~CACFLayerTreeHost): Rather than clearing the window at this
point (which would be too late, since we won't be able to call into the derived class's
virtual functions), just assert that it has already been cleared (or was never set in the
first place).
(WebCore::LegacyCACFLayerTreeHost::createRenderer): Renamed from
CACFLayerTreeHost::createRenderer, and changed to use getters instead of accessing
CACFLayerTreeHost's data members directly.

(WebCore::LegacyCACFLayerTreeHost::destroyRenderer):
(WebCore::CACFLayerTreeHost::destroyRenderer):
Moved some code to the new LegacyCACFLayerTreeHost function.

(WebCore::LegacyCACFLayerTreeHost::resize):
(WebCore::LegacyCACFLayerTreeHost::renderTimerFired):
Moved these functions to LegacyCACFLayerTreeHost.

(WebCore::LegacyCACFLayerTreeHost::paint):
(WebCore::CACFLayerTreeHost::paint):
Moved some code to the new LegacyCACFLayerTreeHost function.

(WebCore::LegacyCACFLayerTreeHost::render):
(WebCore::LegacyCACFLayerTreeHost::renderSoon):
Moved these functions to LegacyCACFLayerTreeHost.

(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Moved code to flush the context
from here...
(WebCore::LegacyCACFLayerTreeHost::flushContext): ...to this new function.

(WebCore::LegacyCACFLayerTreeHost::lastCommitTime): Moved code to get the last commit time
to this new function...
(WebCore::CACFLayerTreeHost::notifyAnimationsStarted): ...from here.

(WebCore::LegacyCACFLayerTreeHost::initD3DGeometry):
(WebCore::LegacyCACFLayerTreeHost::resetDevice):
Moved these functions to LegacyCACFLayerTreeHost.

* platform/graphics/ca/win/CACFLayerTreeHost.h: Made some functions virtual, removed some
members that have moved to LegacyCACFLayerTreeHost, added some getters used by
LegacyCACFLayerTreeHost.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove CACFLayerTreeHostClient to its own header file
aroben@apple.com [Thu, 27 Jan 2011 23:25:22 +0000 (23:25 +0000)]
Move CACFLayerTreeHostClient to its own header file

Rubber-stamped by Steve Falkenburg.

Source/WebCore:

* WebCore.vcproj/WebCore.vcproj: Added CACFLayerTreeHostClient.h. Also let VS have its way
with the file.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp: Added new #include.

* platform/graphics/ca/win/CACFLayerTreeHost.h: Removed CACFLayerTreeHostClient.

* platform/graphics/ca/win/CACFLayerTreeHostClient.h: Added.

* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: Moved some #includes here
from the header file.

* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: Replaced broader #includes
with more specific ones, plus a forward-declaration.

Source/WebKit/win:

Trim down #includes in WebView.h

* WebView.cpp: Moved some #includes here from the header file.

* WebView.h: Replaced some broader #includes with more specific ones, plus a
forward-declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 27 Jan 2011 23:20:56 +0000 (23:20 +0000)]
2011-01-27  Dirk Schulze  <krit@webkit.org>

        Unreviewed rebaseline.

        SVG animation of Paths with segments of different coordinate modes on begin and end
        https://bugs.webkit.org/show_bug.cgi?id=52984

        Rebaseline for SL. HTML were created by make-script-test-wrappers now.
        Skip added tests on WebKit2 because of missing eventSender.

        * platform/mac-wk2/Skipped:
        * svg/animations/animate-path-nested-transforms-expected.txt:
        * svg/animations/animate-text-nested-transforms-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Thu, 27 Jan 2011 23:03:04 +0000 (23:03 +0000)]
2011-01-27  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Simplify small caps logic in complex text on linux
        https://bugs.webkit.org/show_bug.cgi?id=53207

        Test: fast/text/atsui-multiple-renderers.html
              fast/text/atsui-small-caps-punctuation-size.html

        * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
        (WebCore::ComplexTextController::nextScriptRun): Remove redundant logic. Case changes in a text run imply FontData changes.
        (WebCore::ComplexTextController::setupFontForScriptRun): Update comment to reflect above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 27 Jan 2011 22:59:34 +0000 (22:59 +0000)]
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Unreviewed, roll back webkit chromium rev to 72637.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 27 Jan 2011 22:50:53 +0000 (22:50 +0000)]
2011-01-27  Adam Barth  <abarth@webkit.org>

        In which I attempt to fix the EFL build.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 27 Jan 2011 22:43:05 +0000 (22:43 +0000)]
2011-01-27  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium rebaseline for fast/text/text-letter-spacing.html
        with changes matching the mac ones done by r76739.

        * platform/chromium-win/fast/text/text-letter-spacing-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 27 Jan 2011 22:38:38 +0000 (22:38 +0000)]
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Unreviewed.

        Roll Webkit Chromium rev from 72637 to 72868.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Thu, 27 Jan 2011 22:38:10 +0000 (22:38 +0000)]
2011-01-25  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Darin Adler.

        Updating the expected result for 5408255 and adding tests for caret positioning at the
        beginning and end of RenderBoxes.

        Undo moves caret to invalid position
        https://bugs.webkit.org/show_bug.cgi?id=49744

        * editing/selection/caret-painting-after-paste-undo-rtl.html: Added.
        * editing/selection/caret-painting-after-paste-undo.html: Added.
        * platform/mac/editing/deleting/5408255-expected.png:
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Added.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Added.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Added.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Added.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Added.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Added.
2011-01-25  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Darin Adler.

        Adding border and padding to the calculation of the local caret rect for RenderBoxes.
        Corrected for mistake in r76625

        Undo moves caret to invalid position
        https://bugs.webkit.org/show_bug.cgi?id=49744

        Tests: editing/selection/caret-painting-after-paste-undo-rtl.html
               editing/selection/caret-painting-after-paste-undo.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::localCaretRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 27 Jan 2011 22:30:52 +0000 (22:30 +0000)]
2011-01-27  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaseline and text expectation update.

        * platform/chromium-linux/fast/repaint/select-option-background-color-expected.checksum: Added.
        * platform/chromium-linux/fast/repaint/select-option-background-color-expected.png: Added.
        * platform/chromium-linux/fast/repaint/select-option-background-color-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 27 Jan 2011 22:13:08 +0000 (22:13 +0000)]
2011-01-27  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed rebaseline of fast/inline/continuation-outlines-with-layers.html
        afte r76726.

        * platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
        * platform/chromium-win/fast/inline/continuation-outlines-with-layers-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
rniwa@webkit.org [Thu, 27 Jan 2011 22:02:02 +0000 (22:02 +0000)]
2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76825.
        http://trac.webkit.org/changeset/76825
        https://bugs.webkit.org/show_bug.cgi?id=53256

        "caused crashes on GTK and chromium" (Requested by rniwa on
        #webkit).

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::ImageQualityController::keyDestroyed):
        (WebCore::ImageQualityController::objectDestroyed):
        (WebCore::ImageQualityController::highQualityRepaintTimerFired):
        (WebCore::ImageQualityController::shouldPaintAtLowQuality):
        (WebCore::imageQualityController):
        (WebCore::RenderBoxModelObject::~RenderBoxModelObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 27 Jan 2011 21:52:56 +0000 (21:52 +0000)]
2011-01-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Generalize the mechanism view-source uses to remember the source for an HTMLToken
        https://bugs.webkit.org/show_bug.cgi?id=53200

        Currently view-source tracks the source associated with each HTMLToken.
        We want to re-use this mechanism for the new XSS auditor.  This patch
        moves this code into its own class so it can be shared between the
        view-source parser and the general HTML parser.  This patch also add
        support for tracking the source of tokens that span document.write
        boundaries.

        No functional change.  This code change is somewhat tested by our
        view-source layout tests.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
            - Fun with updating build files.
        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::pumpTokenizer):
            - Teach HTMLDocumentParser to track the source for HTMLTokens.
              Currently, this information isn't used, but it will be shortly.
              I ran the HTML parser benchmark and this change didn't have a
              measurable effect.
        * html/parser/HTMLDocumentParser.h:
            - Composite in the HTMLSourceTracker.
        * html/parser/HTMLSourceTracker.cpp: Added.
        (WebCore::HTMLSourceTracker::HTMLSourceTracker):
        (WebCore::HTMLSourceTracker::start):
        (WebCore::HTMLSourceTracker::end):
            - This function should eventualy be folded into HTMLTokenizer.
        (WebCore::HTMLSourceTracker::sourceForToken):
        * html/parser/HTMLSourceTracker.h: Added.
        * html/parser/HTMLToken.h:
            - Now HTMLTokens always have a start index of zero.  To do the job
              of the old start index, this patch introduces the notion of a
              baseOffset.  Unlike the start index (which was used as the base
              offset for all the other indicies), the baseOffset can change
              over the lifetime of the token.  We need the flexibility to
              change the offset for tokens that span document.write boundaries.
              Values are now normalized to zero-offset when stored.
        (WebCore::HTMLToken::clear):
        (WebCore::HTMLToken::setBaseOffset):
        (WebCore::HTMLToken::end):
        (WebCore::HTMLToken::beginAttributeName):
        (WebCore::HTMLToken::endAttributeName):
        (WebCore::HTMLToken::beginAttributeValue):
        (WebCore::HTMLToken::endAttributeValue):
        * html/parser/HTMLViewSourceParser.cpp:
            - Updates the HTMLViewSourceParser to use the new
              HTMLSourceTracker.
        (WebCore::HTMLViewSourceParser::pumpTokenizer):
        (WebCore::HTMLViewSourceParser::append):
        (WebCore::HTMLViewSourceParser::sourceForToken):
            - This function now just calls through to HTMLSourceTracker.
        * html/parser/HTMLViewSourceParser.h:
        * platform/text/SegmentedString.cpp:
        (WebCore::SegmentedString::currentColumn):
        (WebCore::SegmentedString::setCurrentPosition):
        * platform/text/SegmentedString.h:
        (WebCore::SegmentedString::numberOfCharactersConsumed):
            - We need to handle the general case now.  The "slow" version
              doesn't turn out to be any slower in practice anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 27 Jan 2011 21:45:10 +0000 (21:45 +0000)]
2011-01-27  Robert Hogan  <robert@webkit.org>

        Rubber-stamped by Andreas Kling.

        [Qt] Style Fix: correct indentation in FrameLoadeClientQt:createPlugin

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 27 Jan 2011 21:35:37 +0000 (21:35 +0000)]
2011-01-27  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Encode/Decode hasPreciseScrollingDeltas bit in WebWheelEvent
        https://bugs.webkit.org/show_bug.cgi?id=53254

        * Shared/WebWheelEvent.cpp:
        (WebKit::WebWheelEvent::WebWheelEvent):
        Initialize m_phase and m_hasPreciseScrollingDeltas.

        (WebKit::WebWheelEvent::encode):
        (WebKit::WebWheelEvent::decode):
        Add missing coding for m_hasPreciseScrollingDeltas.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix all the builds.
weinig@apple.com [Thu, 27 Jan 2011 21:32:55 +0000 (21:32 +0000)]
Fix all the builds.

* platform/ScrollView.cpp:
(WebCore::ScrollView::paintOverhangAreas): Add parameters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd ability to do an unconstrained scroll on a ScrollView
weinig@apple.com [Thu, 27 Jan 2011 21:23:06 +0000 (21:23 +0000)]
Add ability to do an unconstrained scroll on a ScrollView
https://bugs.webkit.org/show_bug.cgi?id=53249

Reviewed by Dave Hyatt.

* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
Initialize m_constrainsScrollingToContentEdge to true.

(WebCore::ScrollView::setScrollOffset):
Only constrain the offset if the m_constrainsScrollingToContentEdge is set.

(WebCore::ScrollView::updateScrollbars):
Simplify expression converting an IntSize to an IntPoint.

(WebCore::ScrollView::paint):
Paint the overhang if there is any.

(WebCore::ScrollView::calculateOverhangAreasForPainting):
Calculate the overhang in viewport coordinates for painting.

* platform/ScrollView.h:
(WebCore::ScrollView::constrainsScrollingToContentEdge):
(WebCore::ScrollView::setConstrainsScrollingToContentEdge):
Add bit to control whether the scroll position should be constrained
to the content edge when set.

* platform/ScrollbarThemeComposite.cpp:
(WebCore::usedTotalSize):
(WebCore::ScrollbarThemeComposite::thumbPosition):
(WebCore::ScrollbarThemeComposite::thumbLength):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
Improve calculations of thumb size and position to take overhang into account.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 27 Jan 2011 21:03:14 +0000 (21:03 +0000)]
2011-01-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG animation of Paths with segments of different coordinate modes on begin and end
        https://bugs.webkit.org/show_bug.cgi?id=52984

        Added tests to check the correct behavior on path animations, where the coordinate modes
        of the start path differs from the one on the end path.

        * svg/animations/animate-path-animation-Cc-Ss-expected.txt: Added.
        * svg/animations/animate-path-animation-Cc-Ss.html: Added.
        * svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt: Added.
        * svg/animations/animate-path-animation-Ll-Vv-Hh.html: Added.
        * svg/animations/animate-path-animation-Qq-Tt-expected.txt: Added.
        * svg/animations/animate-path-animation-Qq-Tt.html: Added.
        * svg/animations/animate-path-animation-cC-sS-inverse-expected.txt: Added.
        * svg/animations/animate-path-animation-cC-sS-inverse.html: Added.
        * svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt: Added.
        * svg/animations/animate-path-animation-lL-vV-hH-inverse.html: Added.
        * svg/animations/animate-path-animation-qQ-tT-inverse-expected.txt: Added.
        * svg/animations/animate-path-animation-qQ-tT-inverse.html: Added.
        * svg/animations/animate-path-nested-transforms.html: Cleanup.
        * svg/animations/animate-text-nested-transforms.html: Cleanup.
        * svg/animations/resources/SVGAnimationTestCase.js:
        (shouldBeCloseEnough): For debug output of values with tolerance level.
        (startTest):
        (sampleAnimation):
        * svg/animations/script-tests/animate-path-animation-Cc-Ss.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (sample4):
        (executeTest):
        * svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (sample4):
        (executeTest):
        * svg/animations/script-tests/animate-path-animation-Qq-Tt.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (sample4):
        (executeTest):
        * svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (sample4):
        (executeTest):
        * svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (sample4):
        (executeTest):
        * svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (sample4):
        (executeTest):
2011-01-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG animation of Paths with segments of different coordinate modes on begin and end
        https://bugs.webkit.org/show_bug.cgi?id=52984

        At the moment we just support SVG path animations, if the number of segments on the given start path
        is the same as the number of segments on the given end path. But a segment on a given position must be identical
        on both paths as well. Not only the segment type, also the coordinate mode of the segments must be identical.
        If MoveToRel is on the second position on the start path a MoveToRel must be on the second position
        of the end path too. According to the SVG spec, at least the coordinate mode can differ. Means, if we have MoveToRel
        in the start path, we can use MoveToAbs on the same position in the end path.

        This patch fixes the blending code to follow the spec here. It was necessary to track the current position of
        both paths, transform coordinates to the same coordinate mode and transform the resulting animation coordinate back
        to the coordinate mode of either the start or the end path. Which mode is taken depends on the progress of the
        animation.

        Tests: svg/animations/animate-path-animation-Cc-Ss.html
               svg/animations/animate-path-animation-Ll-Vv-Hh.html
               svg/animations/animate-path-animation-Qq-Tt.html
               svg/animations/animate-path-animation-cC-sS-inverse.html
               svg/animations/animate-path-animation-lL-vV-hH-inverse.html
               svg/animations/animate-path-animation-qQ-tT-inverse.html

        * svg/SVGPathBlender.cpp:
        (WebCore::blendFloatPoint):
        (WebCore::blendAnimatedFloat):
        (WebCore::SVGPathBlender::blendAnimatedDimensionalFloat):
        (WebCore::SVGPathBlender::blendAnimatedFloatPoint):
        (WebCore::SVGPathBlender::blendMoveToSegment):
        (WebCore::SVGPathBlender::blendLineToSegment):
        (WebCore::SVGPathBlender::blendLineToHorizontalSegment):
        (WebCore::SVGPathBlender::blendLineToVerticalSegment):
        (WebCore::SVGPathBlender::blendCurveToCubicSegment):
        (WebCore::SVGPathBlender::blendCurveToCubicSmoothSegment):
        (WebCore::SVGPathBlender::blendCurveToQuadraticSegment):
        (WebCore::SVGPathBlender::blendCurveToQuadraticSmoothSegment):
        (WebCore::SVGPathBlender::blendArcToSegment):
        (WebCore::coordinateModeOfCommand):
        (WebCore::isSegmentEqual):
        (WebCore::SVGPathBlender::blendAnimatedPath):
        (WebCore::SVGPathBlender::cleanup):
        * svg/SVGPathBlender.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 27 Jan 2011 20:53:59 +0000 (20:53 +0000)]
2011-01-27  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        new-run-webkit-tests: turn off pixel tests correctly by default
        for webkit-based ports. r70013 (bug 47510) used
        port.set_option_default() to attempt to set default values, but
        that didn't work correctly. I have removed set_option_default
        for now since it was only being used in two places and in three
        useless unit tests. There is a separate bug open to fix the
        option parsing (48095), so this workaround is fine for now.

        https://bugs.webkit.org/show_bug.cgi?id=53217

        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Cris Neckar <cdn@chromium.org>
jschuh@chromium.org [Thu, 27 Jan 2011 20:47:46 +0000 (20:47 +0000)]
2011-01-27  Cris Neckar  <cdn@chromium.org>

        Reviewed by Dimitri Glazkov.

        Clear the parent on a css keyframe's m_style when removing it from the stylesheet.
        https://bugs.webkit.org/show_bug.cgi?id=52320

        Test: fast/css/css-keyframe-style-crash.html

        * css/CSSRuleList.cpp:
        (WebCore::CSSRuleList::deleteRule):
        * css/WebKitCSSKeyframesRule.cpp:
        (WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
2011-01-27  Cris Neckar  <cdn@chromium.org>

        Reviewed by Dimitri Glazkov.

        Test for crash when accessing a keyframe's style rule.
        https://bugs.webkit.org/show_bug.cgi?id=52320

        * fast/css/css-keyframe-style-crash-expected.txt: Added.
        * fast/css/css-keyframe-style-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 27 Jan 2011 20:28:12 +0000 (20:28 +0000)]
2011-01-27  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium text expectation update.

        * platform/chromium/test_expectations.txt: Apparently, video-size.html crashes on Linux due to crbug.com/71087.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76827 268f45cc-cd09-0410-ab3c-d52691b4dbfc