WebKit-https.git
11 years ago2009-05-05 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 6 May 2009 00:54:24 +0000 (00:54 +0000)]
2009-05-05  Darin Adler  <darin@apple.com>

        Try to fix Windows build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Added
        bytecompiler to the list of directories where the headers get copied.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Wed, 6 May 2009 00:51:02 +0000 (00:51 +0000)]
Reviewed by Kevin Ollivier.

Full Keyboard shortcut support.
Implement wxBrowser Cut/Copy/Paste menu items.

https://bugs.webkit.org/show_bug.cgi?id=24797

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 6 May 2009 00:39:40 +0000 (00:39 +0000)]
2009-05-05  Darin Adler  <darin@apple.com>

        Try to fix Windows build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

        Try to fix Mac build.

        * JavaScriptCore.xcodeproj/project.pbxproj: Made SegmentedVector.h private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 6 May 2009 00:19:48 +0000 (00:19 +0000)]
2009-05-05  Darin Adler  <darin@apple.com>

        Try to fix Mac build.

        * JavaScriptCore.xcodeproj/project.pbxproj: Made Lexer.h private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoI didn't realize that the video-zoom-controls.html test will only succeed when run...
cmarrin@apple.com [Tue, 5 May 2009 23:22:22 +0000 (23:22 +0000)]
I didn't realize that the video-zoom-controls.html test will only succeed when run with Safari 4 shell. So disabling again

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix for Windows, add missing include.
kevino@webkit.org [Tue, 5 May 2009 23:16:08 +0000 (23:16 +0000)]
wx build fix for Windows, add missing include.

https://bugs.webkit.org/show_bug.cgi?id=24798

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Tue, 5 May 2009 23:11:34 +0000 (23:11 +0000)]
Reviewed by Kevin Ollivier.

Have wxWebkit make use of gcc(4 and greater) hidden visibility feature

https://bugs.webkit.org/show_bug.cgi?id=24345

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 5 May 2009 23:09:52 +0000 (23:09 +0000)]
2009-05-05  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 25569: make ParserRefCounted use conventional reference counting
        https://bugs.webkit.org/show_bug.cgi?id=25569

        SunSpider speedup of about 1.6%.

        * JavaScriptCore.exp: Updated.

        * parser/Nodes.cpp:
        (JSC::NodeReleaser::releaseAllNodes): ALWAYS_INLINE.
        (JSC::NodeReleaser::adopt): Ditto.
        (JSC::ParserRefCounted::ParserRefCounted): Removed most of the code.
        Add the object to a Vector<RefPtr> that gets cleared after parsing.
        (JSC::ParserRefCounted::~ParserRefCounted): Removed most of the code.

        * parser/Nodes.h: Made ParserRefCounted inherit from RefCounted and
        made inline versions of the constructor and destructor. Made the
        Node constructor inline.

        * parser/Parser.cpp:
        (JSC::Parser::parse): Call globalData->parserObjects.shrink(0) after
        parsing, where it used to call ParserRefCounted::deleteNewObjects.

        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData): Eliminated code to manage the
        newParserObjects and parserObjectExtraRefCounts.
        (JSC::JSGlobalData::~JSGlobalData): Ditto.

        * runtime/JSGlobalData.h: Replaced the HashSet and HashCountedSet
        with a Vector.

        * wtf/PassRefPtr.h:
        (WTF::PassRefPtr::~PassRefPtr): The most common thing to do with a
        PassRefPtr in hot code is to pass it and then destroy it once it's
        set to zero. Help the optimizer by telling it that's true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 25574: AXImageMap children links don't respond properly to accessibilityHitTest:
cfleizach@apple.com [Tue, 5 May 2009 23:04:04 +0000 (23:04 +0000)]
Bug 25574: AXImageMap children links don't respond properly to accessibilityHitTest:
https://bugs.webkit.org/show_bug.cgi?id=25574

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Tue, 5 May 2009 22:34:46 +0000 (22:34 +0000)]
2009-05-06  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha.

        http://bugs.webkit.org/show_bug.cgi?id=17066
        [GTK] Improve frameloader signals

        Update GtkLauncher to use the new load-status and progress properties
        instead of the previous loading signals.

        * GtkLauncher/main.c:
        (update_title):
        (notify_load_status_cb):
        (notify_progress_cb):
        (create_browser):
        (create_window):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Tue, 5 May 2009 22:34:33 +0000 (22:34 +0000)]
2009-05-06  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha.

        http://bugs.webkit.org/show_bug.cgi?id=17066
        [GTK] Improve frameloader signals

        Implement load-status and progress properties on the view, as well as
        load-status on the frame. This supersedes the different load signals
        load-progress-changed, load-committed, load-done, load-started and
        load-finished which are not only misnamed but broken by design.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::notifyStatus):
        (WebKit::FrameLoaderClient::postProgressStartedNotification):
        (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification):
        (WebKit::FrameLoaderClient::dispatchDidFinishLoad):
        (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad):
        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:
        * webkit/webkitwebframe.h:
        * webkit/webkitwebview.cpp:
        * webkit/webkitwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
kmccullough@apple.com [Tue, 5 May 2009 22:32:29 +0000 (22:32 +0000)]
WebCore:

2009-05-05  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6552129> Select a quote line and paste elsewhere, you
        get that line and an extra quoted blank line
        <rdar://problem/6609308> Triple-click a quoted header line, copy, paste
        onto an empty line makes an extra quoted line

        - When pasting a blockquote with a newline, make sure we put the newline
        outside of the blockquote so that it is not quoted.

        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):

LayoutTests:

2009-05-05  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6552129> Select a quote line and paste elsewhere, you
        get that line and an extra quoted blank line
        <rdar://problem/6609308> Triple-click a quoted header line, copy, paste
        onto an empty line makes an extra quoted line

        - Testing different scenarios where we paste quoted text into a non-quoted area and we
        do not want a trailing newline to be quoted.

        * editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Added.
        * editing/pasteboard/paste-blockquote-before-blockquote.html: Added.
        * editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Added.
        * editing/pasteboard/paste-double-nested-blockquote-before-blockquote.html: Added.
        * editing/pasteboard/resources/paste-blockquote-before-blockquote.js: Added.
        (copyAndPasteNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReenabled media test after fixing <rdar://problem/6825079>
cmarrin@apple.com [Tue, 5 May 2009 22:04:42 +0000 (22:04 +0000)]
Reenabled media test after fixing <rdar://problem/6825079>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Xan Lopez <xlopez@igalia.com> and Gustavo Noronha Silva <gustavo.noronh...
kov@webkit.org [Tue, 5 May 2009 22:00:14 +0000 (22:00 +0000)]
2009-05-05  Xan Lopez  <xlopez@igalia.com> and Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Oliver Hunt.

        Disable the NativeFunctionWrapper for all non-Mac ports for now,
        as it is also crashing on Linux/x86.

        * runtime/NativeFunctionWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Tue, 5 May 2009 21:41:50 +0000 (21:41 +0000)]
Reviewed by Kevin Ollivier.

STATE_CHANGED event is now named LOAD

https://bugs.webkit.org/show_bug.cgi?id=25549

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Tue, 5 May 2009 20:16:25 +0000 (20:16 +0000)]
2009-05-05  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        Call moz_gtk_shutdown on RenderThemeGtk destruction.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::~RenderThemeGtk):
        * platform/gtk/RenderThemeGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 5 May 2009 19:57:51 +0000 (19:57 +0000)]
2009-05-05  Darin Adler  <darin@apple.com>

        Reviewed by Steve Falkenburg.

        <rdar://problem/6858340> REGRESSION: can't drag local HTML files into Safari because CFURLCreateWithFileSystemPath inserts "localhost"

        * platform/win/ClipboardUtilitiesWin.cpp: (WebCore::urlFromPath): Remove localhost.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Tue, 5 May 2009 19:19:23 +0000 (19:19 +0000)]
2009-05-05  Peter Kasting  <pkasting@google.com>

        Reviewed by Brady Eidson.

        Safety-check m_documentLoader before dereferencing.  While it seems
        unlikely this could fail (as Safari 3 shipped without this),
        technically almost any call can change or reset m_documentLoader.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::receivedFirstData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix build.
sfalken@apple.com [Tue, 5 May 2009 19:05:01 +0000 (19:05 +0000)]
    Fix build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - Tiger build fix
mitz@apple.com [Tue, 5 May 2009 18:16:19 +0000 (18:16 +0000)]
    - Tiger build fix

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::toCSSIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd Bugzilla links
mitz@apple.com [Tue, 5 May 2009 17:47:06 +0000 (17:47 +0000)]
Add Bugzilla links

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Tue, 5 May 2009 17:46:03 +0000 (17:46 +0000)]
2009-05-05  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25303
        No need to ref the internal buffer inside the Skia ImageDecoder.

        * platform/image-decoders/skia/ImageDecoder.h:
        (WebCore::RGBA32Buffer::RGBA32Buffer):
        (WebCore::RGBA32Buffer::operator=):
        (WebCore::RGBA32Buffer::clear):
        (WebCore::RGBA32Buffer::copyBitmapData):
        (WebCore::RGBA32Buffer::bitmap):
        (WebCore::RGBA32Buffer::setSize):
        (WebCore::RGBA32Buffer::width):
        (WebCore::RGBA32Buffer::height):
        (WebCore::RGBA32Buffer::hasAlpha):
        (WebCore::RGBA32Buffer::setStatus):
        (WebCore::RGBA32Buffer::setHasAlpha):
        (WebCore::RGBA32Buffer::setRGBA):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Tue, 5 May 2009 17:33:10 +0000 (17:33 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix <rdar://problem/5760774> Replying to a Mail message that contains
          fixed width text can change the size of the text

        Covered by existing tests: editing/pasteboard/5027857.html
                                   editing/pasteboard/paste-pre-002.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
        Added. If the font-size is keyword-based, returns the keyword value
        instead of the pixel size.
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): If
        font-family is a generic family, return the generic family instead of
        the the internal string -webkit-[serif|sans-serif|cursive|fantasy
        |monospace].
        (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
        For the font-size property, prefer a keyword value over a pixel size.
        * css/CSSComputedStyleDeclaration.h:
        * editing/ApplyStyleCommand.cpp:
        (WebCore::StyleChange::currentlyHasStyle): For the font-size property,
        call getFontSizeCSSValuePreferringKeyword().
        * platform/graphics/FontDescription.h:
        (WebCore::FontDescription::keywordSize): Changed the return type to
        unsigned.
        (WebCore::FontDescription::setKeywordSize): Changed the parameter type
        to unsigned.
        (WebCore::FontDescription::m_keywordSize): Changed the type of this
        4-bit field to unsigned, because it takes values as high as 8.

LayoutTests:

        Reviewed by Darin Adler.

        - updated results for <rdar://problem/5760774> Replying to a Mail
          message that contains fixed width text can change the size of the text

        * editing/execCommand/19089-expected.txt:
        * editing/execCommand/5770834-1-expected.txt:
        * platform/mac/editing/deleting/delete-br-011-expected.txt:
        * platform/mac/editing/deleting/delete-select-all-001-expected.txt:
        * platform/mac/editing/execCommand/remove-formatting-2-expected.txt:
        * platform/mac/editing/pasteboard/5027857-expected.checksum:
        * platform/mac/editing/pasteboard/5027857-expected.png:
        * platform/mac/editing/pasteboard/5027857-expected.txt:
        * platform/mac/editing/pasteboard/paste-pre-002-expected.checksum:
        * platform/mac/editing/pasteboard/paste-pre-002-expected.png:
        * platform/mac/editing/pasteboard/paste-pre-002-expected.txt:
        * platform/mac/editing/style/block-style-004-expected.txt:
        * platform/mac/editing/style/block-style-005-expected.txt:
        * platform/mac/editing/style/block-style-006-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix http/tests/misc/DOMContentLoaded-event.html
oliver@apple.com [Tue, 5 May 2009 16:41:42 +0000 (16:41 +0000)]
Fix http/tests/misc/DOMContentLoaded-event.html

Reviewed by Maciej Stachowiak

The native call performance improvement removed a few places where we
unintentionally performed a toThisObject conversion.  This patch updates
the bindings codegen to not rely on this bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[GTK] Implement WebCore::directoryName
zecke@webkit.org [Tue, 5 May 2009 16:39:51 +0000 (16:39 +0000)]
[GTK] Implement WebCore::directoryName

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 5 May 2009 16:21:21 +0000 (16:21 +0000)]
2009-05-05  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        Fix memory leaks.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::checkSpellingOfString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Don't use pdevenv when building with VC++ Express
aroben@apple.com [Tue, 5 May 2009 15:58:38 +0000 (15:58 +0000)]
    Don't use pdevenv when building with VC++ Express

        Fixes Bug 25308: REGRESSION (r42182): Build fails after following
        build instructions on webkit.org fail when using VC++ Express
        <https://bugs.webkit.org/show_bug.cgi?id=25308>

        Reviewed by Eric Seidel.

        * Scripts/webkitdirs.pm:
        (setupCygwinEnv): When Visual Studio is installed, set $vcBuildPath to
        point to pdevenv. When VC++ Express is installed, set $vcBuildPath to
        point to VC++ Express, as before.
        (buildVisualStudioProject): Use $vcBuildPath to build instead of
        hard-coding pdevenv.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adam Roben.
eric@webkit.org [Tue, 5 May 2009 15:49:53 +0000 (15:49 +0000)]
    Reviewed by Adam Roben.

        Add test case to cover V8 crasher (which JSC does not share).
        https://bugs.webkit.org/show_bug.cgi?id=25550

        * svg/custom/polyline-points-crash-expected.txt: Added.
        * svg/custom/polyline-points-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adam Roben.
eric@webkit.org [Tue, 5 May 2009 15:41:41 +0000 (15:41 +0000)]
    Reviewed by Adam Roben.

        Fix mappedAttributes() access without NULL check
        https://bugs.webkit.org/show_bug.cgi?id=25553

        SVGStyledElement::getPresentationAttribute was using mappedAttributes()
        without checking for NULL.

        HTMLInputElement::setInputType also doesn't NULL check, but I was not
        able to get it to crash with a test case so I just added an ASSERT.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::getPresentationAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Tue, 5 May 2009 15:20:23 +0000 (15:20 +0000)]
2009-05-05  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Various improvements to the class documentation, including a simple snippet for QWebElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake windows work again
oliver@apple.com [Tue, 5 May 2009 13:50:20 +0000 (13:50 +0000)]
Make windows work again

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Maciej Stachowiak.
eric@webkit.org [Tue, 5 May 2009 13:48:18 +0000 (13:48 +0000)]
    Reviewed by Maciej Stachowiak.

        Add a testcase using SVG in HTML with CSS transforms
        https://bugs.webkit.org/show_bug.cgi?id=23112

        We currently fail the <text> section of this test but pass the path and image sections.

        * platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.checksum: Added.
        * platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
        * platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.txt: Added.
        * svg/transforms/animated-path-inside-transformed-html.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[GTK] Implement WebCore::imageTitle
zecke@webkit.org [Tue, 5 May 2009 13:45:36 +0000 (13:45 +0000)]
[GTK] Implement WebCore::imageTitle

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows debug build fix
oliver@apple.com [Tue, 5 May 2009 13:25:46 +0000 (13:25 +0000)]
Windows debug build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoHopefully the last of the build fixes
oliver@apple.com [Tue, 5 May 2009 12:44:29 +0000 (12:44 +0000)]
Hopefully the last of the build fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build failure caused by other build fix
oliver@apple.com [Tue, 5 May 2009 12:31:13 +0000 (12:31 +0000)]
Fix build failure caused by other build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoYet more windows build fixes.
oliver@apple.com [Tue, 5 May 2009 12:28:09 +0000 (12:28 +0000)]
Yet more windows build fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMore windows build fixes.
oliver@apple.com [Tue, 5 May 2009 12:22:33 +0000 (12:22 +0000)]
More windows build fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMore build fixes
oliver@apple.com [Tue, 5 May 2009 12:16:41 +0000 (12:16 +0000)]
More build fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuildfix: Now include JSFunction.h basically everywhere we include PrototypeFunction.h
oliver@apple.com [Tue, 5 May 2009 12:11:29 +0000 (12:11 +0000)]
Buildfix: Now include JSFunction.h basically everywhere we include PrototypeFunction.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fixes
oliver@apple.com [Tue, 5 May 2009 12:05:08 +0000 (12:05 +0000)]
Build fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMore build fixes
oliver@apple.com [Tue, 5 May 2009 12:02:37 +0000 (12:02 +0000)]
More build fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix
oliver@apple.com [Tue, 5 May 2009 11:58:03 +0000 (11:58 +0000)]
Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix
oliver@apple.com [Tue, 5 May 2009 11:52:53 +0000 (11:52 +0000)]
Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd missing file
oliver@apple.com [Tue, 5 May 2009 11:42:09 +0000 (11:42 +0000)]
Add missing file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 25559: Improve native function call performance
oliver@apple.com [Tue, 5 May 2009 11:34:23 +0000 (11:34 +0000)]
Bug 25559: Improve native function call performance
<https://bugs.webkit.org/show_bug.cgi?id=25559>

Reviewed by Gavin Barraclough

In order to cache calls to native functions we now make the standard
prototype functions use a small assembly thunk that converts the JS
calling convention into the native calling convention.  As this is
only beneficial in the JIT we use the NativeFunctionWrapper typedef
to alternate between PrototypeFunction and JSFunction to keep the
code sane.  This change from PrototypeFunction to NativeFunctionWrapper
is the bulk of this patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Tue, 5 May 2009 10:23:39 +0000 (10:23 +0000)]
2009-05-05  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        Make convertValueToQVariant more robust against null JSValues.

        Don't require the caller to do the null check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago No review, just a revert.
eric@webkit.org [Tue, 5 May 2009 09:10:06 +0000 (09:10 +0000)]
    No review, just a revert.

        Roll out http://trac.webkit.org/changeset/43213 as it caused 4 tests to crash.

        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::mapLocalToContainer):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::mapLocalToContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Tue, 5 May 2009 08:59:42 +0000 (08:59 +0000)]
2009-05-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Rubber-stamped by Simon Hausmann.

        Mention --qt as an option in the build-webkit help

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Tue, 5 May 2009 08:58:17 +0000 (08:58 +0000)]
2009-05-05  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        For convenience, let the sampling flags tool clear multiple flags at once.

        * jsc.cpp:
        (GlobalObject::GlobalObject):
        (functionSetSamplingFlags):
        (functionClearSamplingFlags):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Dave Hyatt.
ap@webkit.org [Tue, 5 May 2009 08:52:32 +0000 (08:52 +0000)]
    Reviewed by Dave Hyatt.

        <rdar://problem/6576889> REGRESSION (r35185): Cannot watch Flash movies on omg.yahoo.com

        The problem was caused by missing <head> element - we used to create it when moving a
        misplaced <style> element, but we now handle those in place. Other browsers always create
        a <head> element.

        There is no guarantee that a <head> element always exists - first, it can be removed with
        removeChild or innerHTML, and also, we don't currently create it for frameset documents, or
        for manually created ones (e.g. ImageDocument).

        Test: fast/parser/head-element-for-yahoo-player.html

WebKit:
        * dom/Document.cpp: (WebCore::Document::implicitClose): Create a <head> element for about:blank.
        A removed comment talked about rdar://3758785, but that problem doesn't re-occur even if this
        code is removed completely.

        * html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::checkDTD): No longer allow <script>
        elements as children of <html>. This isn't directly related to this bug, but it was easier
        to fix both at once (IE and Firefox both don't allow such mispositioned <script> elements).

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError): Move <script> to <head> if <body> hasn't been created yet.
        Create a <head> it a <body> is created implicitly to contain some other element.
        (WebCore::HTMLParser::bodyCreateErrorCheck): Ensure that a <head> exists when <body> is
        explicitly present in source.
        (WebCore::HTMLParser::createHead): Do the work even if <html> element hasn't been created yet.

LayoutTests:
        * fast/parser/head-element-for-yahoo-player-expected.txt: Added.
        * fast/parser/head-element-for-yahoo-player.html: Added.
        Test the regression case (a misplaced <style> that used to create <head> implicitly).

        * editing/selection/select-all-005.html: Use a new index when selecting the body.

        * fast/dom/Document/document-write-doctype-expected.txt:
        * fast/dom/Document/resources/document-write-doctype.js:
        Removed checks for "Gecko quirk" of implicitly adding HEAD - that not a quirk, but standard
        behavior per HTML5.

        * editing/execCommand/create-list-1-expected.txt:
        * platform/mac/editing/deleting/4845371-expected.txt:
        * platform/mac/editing/deleting/4866671-expected.txt:
        * platform/mac/editing/deleting/4875189-expected.txt:
        * platform/mac/editing/deleting/5026848-1-expected.txt:
        * platform/mac/editing/deleting/5026848-2-expected.txt:
        * platform/mac/editing/deleting/5026848-3-expected.txt:
        * platform/mac/editing/deleting/5032066-expected.txt:
        * platform/mac/editing/deleting/5091898-expected.txt:
        * platform/mac/editing/deleting/5099303-expected.txt:
        * platform/mac/editing/deleting/5115601-expected.txt:
        * platform/mac/editing/deleting/5126166-expected.txt:
        * platform/mac/editing/deleting/5156801-2-expected.txt:
        * platform/mac/editing/deleting/5168598-expected.txt:
        * platform/mac/editing/deleting/5272440-expected.txt:
        * platform/mac/editing/deleting/5300379-expected.txt:
        * platform/mac/editing/deleting/5390681-expected.txt:
        * platform/mac/editing/deleting/5408255-expected.txt:
        * platform/mac/editing/deleting/5433862-2-expected.txt:
        * platform/mac/editing/deleting/5483370-expected.txt:
        * platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
        * platform/mac/editing/deleting/delete-block-table-expected.txt:
        * platform/mac/editing/deleting/delete-hr-expected.txt:
        * platform/mac/editing/deleting/delete-mixed-editable-content-001-expected.txt:
        * platform/mac/editing/deleting/delete-to-select-table-expected.txt:
        * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
        * platform/mac/editing/deleting/merge-endOfParagraph-expected.txt:
        * platform/mac/editing/deleting/merge-no-br-expected.txt:
        * platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
        * platform/mac/editing/execCommand/4641880-1-expected.txt:
        * platform/mac/editing/execCommand/4641880-2-expected.txt:
        * platform/mac/editing/execCommand/4747450-expected.txt:
        * platform/mac/editing/execCommand/4786404-1-expected.txt:
        * platform/mac/editing/execCommand/4786404-2-expected.txt:
        * platform/mac/editing/execCommand/4916402-expected.txt:
        * platform/mac/editing/execCommand/4916541-expected.txt:
        * platform/mac/editing/execCommand/4916583-expected.txt:
        * platform/mac/editing/execCommand/4920488-expected.txt:
        * platform/mac/editing/execCommand/4920742-1-expected.txt:
        * platform/mac/editing/execCommand/4924441-expected.txt:
        * platform/mac/editing/execCommand/5049671-expected.txt:
        * platform/mac/editing/execCommand/5080333-1-expected.txt:
        * platform/mac/editing/execCommand/5080333-2-expected.txt:
        * platform/mac/editing/execCommand/5119244-expected.txt:
        * platform/mac/editing/execCommand/5120591-expected.txt:
        * platform/mac/editing/execCommand/5136770-expected.txt:
        * platform/mac/editing/execCommand/5142012-1-expected.txt:
        * platform/mac/editing/execCommand/5142012-2-expected.txt:
        * platform/mac/editing/execCommand/5142012-3-expected.txt:
        * platform/mac/editing/execCommand/5144139-1-expected.txt:
        * platform/mac/editing/execCommand/5164796-expected.txt:
        * platform/mac/editing/execCommand/5207369-expected.txt:
        * platform/mac/editing/execCommand/5210032-expected.txt:
        * platform/mac/editing/execCommand/5432254-1-expected.txt:
        * platform/mac/editing/execCommand/5432254-2-expected.txt:
        * platform/mac/editing/execCommand/5481523-expected.txt:
        * platform/mac/editing/execCommand/5482524-expected.txt:
        * platform/mac/editing/execCommand/5569741-expected.txt:
        * platform/mac/editing/execCommand/5573879-expected.txt:
        * platform/mac/editing/execCommand/5700414-1-expected.txt:
        * platform/mac/editing/execCommand/5700414-2-expected.txt:
        * platform/mac/editing/execCommand/insert-list-empty-div-expected.txt:
        * platform/mac/editing/input/5576619-expected.txt:
        * platform/mac/editing/inserting/12882-expected.txt:
        * platform/mac/editing/inserting/4840662-expected.txt:
        * platform/mac/editing/inserting/4875189-1-expected.txt:
        * platform/mac/editing/inserting/4875189-2-expected.txt:
        * platform/mac/editing/inserting/4959067-expected.txt:
        * platform/mac/editing/inserting/4960120-1-expected.txt:
        * platform/mac/editing/inserting/4960120-2-expected.txt:
        * platform/mac/editing/inserting/5002441-expected.txt:
        * platform/mac/editing/inserting/5058163-2-expected.txt:
        * platform/mac/editing/inserting/5156401-2-expected.txt:
        * platform/mac/editing/inserting/5549929-2-expected.txt:
        * platform/mac/editing/inserting/5549929-3-expected.txt:
        * platform/mac/editing/inserting/5607069-2-expected.txt:
        * platform/mac/editing/inserting/5607069-3-expected.txt:
        * platform/mac/editing/inserting/editable-html-element-expected.txt:
        * platform/mac/editing/inserting/editable-inline-element-expected.txt:
        * platform/mac/editing/inserting/edited-whitespace-1-expected.txt:
        * platform/mac/editing/inserting/editing-empty-divs-expected.txt:
        * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
        * platform/mac/editing/pasteboard/4806874-expected.txt:
        * platform/mac/editing/pasteboard/4861080-expected.txt:
        * platform/mac/editing/pasteboard/4944770-1-expected.txt:
        * platform/mac/editing/pasteboard/4944770-2-expected.txt:
        * platform/mac/editing/pasteboard/4947130-expected.txt:
        * platform/mac/editing/pasteboard/4989774-expected.txt:
        * platform/mac/editing/pasteboard/5027857-expected.txt:
        * platform/mac/editing/pasteboard/5032095-expected.txt:
        * platform/mac/editing/pasteboard/5065605-expected.txt:
        * platform/mac/editing/pasteboard/5071074-2-expected.txt:
        * platform/mac/editing/pasteboard/5071074-expected.txt:
        * platform/mac/editing/pasteboard/5075944-2-expected.txt:
        * platform/mac/editing/pasteboard/5075944-3-expected.txt:
        * platform/mac/editing/pasteboard/5075944-expected.txt:
        * platform/mac/editing/pasteboard/5134759-expected.txt:
        * platform/mac/editing/pasteboard/5156401-1-expected.txt:
        * platform/mac/editing/pasteboard/5247341-expected.txt:
        * platform/mac/editing/pasteboard/5387578-expected.txt:
        * platform/mac/editing/pasteboard/5478250-expected.txt:
        * platform/mac/editing/pasteboard/5483567-expected.txt:
        * platform/mac/editing/pasteboard/5601583-1-expected.txt:
        * platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt:
        * platform/mac/editing/pasteboard/input-field-1-expected.txt:
        * platform/mac/editing/pasteboard/merge-after-delete-1-expected.txt:
        * platform/mac/editing/pasteboard/merge-after-delete-2-expected.txt:
        * platform/mac/editing/pasteboard/merge-after-delete-expected.txt:
        * platform/mac/editing/pasteboard/merge-start-blockquote-expected.txt:
        * platform/mac/editing/pasteboard/paste-unrendered-select-expected.txt:
        * platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.txt:
        * platform/mac/editing/pasteboard/select-element-1-expected.txt:
        * platform/mac/editing/selection/13804-expected.txt:
        * platform/mac/editing/selection/14971-expected.txt:
        * platform/mac/editing/selection/4397952-expected.txt:
        * platform/mac/editing/selection/4818145-expected.txt:
        * platform/mac/editing/selection/4866671-expected.txt:
        * platform/mac/editing/selection/4889598-expected.txt:
        * platform/mac/editing/selection/4895428-1-expected.txt:
        * platform/mac/editing/selection/4895428-2-expected.txt:
        * platform/mac/editing/selection/4895428-3-expected.txt:
        * platform/mac/editing/selection/4895428-4-expected.txt:
        * platform/mac/editing/selection/4932260-1-expected.txt:
        * platform/mac/editing/selection/4932260-2-expected.txt:
        * platform/mac/editing/selection/4932260-3-expected.txt:
        * platform/mac/editing/selection/4947387-expected.txt:
        * platform/mac/editing/selection/4960116-expected.txt:
        * platform/mac/editing/selection/4975120-expected.txt:
        * platform/mac/editing/selection/4983858-expected.txt:
        * platform/mac/editing/selection/5007143-2-expected.txt:
        * platform/mac/editing/selection/5007143-expected.txt:
        * platform/mac/editing/selection/5057506-2-expected.txt:
        * platform/mac/editing/selection/5057506-expected.txt:
        * platform/mac/editing/selection/5076323-1-expected.txt:
        * platform/mac/editing/selection/5076323-2-expected.txt:
        * platform/mac/editing/selection/5076323-3-expected.txt:
        * platform/mac/editing/selection/5081257-1-expected.txt:
        * platform/mac/editing/selection/5081257-2-expected.txt:
        * platform/mac/editing/selection/5099303-expected.txt:
        * platform/mac/editing/selection/5109817-expected.txt:
        * platform/mac/editing/selection/5136696-expected.txt:
        * platform/mac/editing/selection/5195166-1-expected.txt:
        * platform/mac/editing/selection/5195166-2-expected.txt:
        * platform/mac/editing/selection/5234383-1-expected.txt:
        * platform/mac/editing/selection/5234383-2-expected.txt:
        * platform/mac/editing/selection/5240265-expected.txt:
        * platform/mac/editing/selection/5333725-expected.txt:
        * platform/mac/editing/selection/5354455-1-expected.txt:
        * platform/mac/editing/selection/addRange-expected.txt:
        * platform/mac/editing/selection/caret-before-select-expected.txt:
        * platform/mac/editing/selection/contains-boundaries-expected.txt:
        * platform/mac/editing/selection/drag-select-1-expected.txt:
        * platform/mac/editing/selection/editable-html-element-expected.txt:
        * platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt:
        * platform/mac/editing/selection/inline-closest-leaf-child-expected.txt:
        * platform/mac/editing/selection/mixed-editability-6-expected.txt:
        * platform/mac/editing/selection/mixed-editability-7-expected.txt:
        * platform/mac/editing/selection/move-by-sentence-linebreak-expected.txt:
        * platform/mac/editing/selection/select-all-005-expected.txt:
        * platform/mac/editing/selection/table-caret-1-expected.txt:
        * platform/mac/editing/selection/table-caret-2-expected.txt:
        * platform/mac/editing/selection/table-caret-3-expected.txt:
        * platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
        * platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
        * platform/mac/editing/style/4916887-expected.txt:
        * platform/mac/editing/style/5017613-1-expected.txt:
        * platform/mac/editing/style/5017613-2-expected.txt:
        * platform/mac/editing/style/5046875-1-expected.txt:
        * platform/mac/editing/style/5046875-2-expected.txt:
        * platform/mac/editing/style/5065910-expected.txt:
        * platform/mac/editing/style/5084241-expected.txt:
        * platform/mac/editing/style/5091898-expected.txt:
        * platform/mac/editing/style/5228141-expected.txt:
        * platform/mac/editing/style/5279521-expected.txt:
        * platform/mac/editing/style/font-family-with-space-expected.txt:
        * platform/mac/editing/style/fontsize-1-expected.txt:
        * platform/mac/editing/style/highlight-expected.txt:
        * platform/mac/editing/style/non-inheritable-styles-expected.txt:
        * platform/mac/editing/undo/5378473-expected.txt:
        * platform/mac/fast/block/float/relative-painted-twice-expected.txt:
        * platform/mac/fast/dom/delete-contents-expected.txt:
        * platform/mac/fast/events/context-no-deselect-expected.txt:
        * platform/mac/fast/events/label-focus-expected.txt:
        * platform/mac/fast/forms/input-appearance-focus-expected.txt:
        * platform/mac/fast/forms/input-text-click-inside-expected.txt:
        * platform/mac/fast/forms/input-text-click-outside-expected.txt:
        * platform/mac/fast/forms/input-text-double-click-expected.txt:
        * platform/mac/fast/forms/input-text-drag-down-expected.txt:
        * platform/mac/fast/forms/input-text-option-delete-expected.txt:
        * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
        * platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
        * platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
        * platform/mac/fast/forms/textfield-overflow-expected.txt:
        * platform/mac/fast/inline/25277-2-expected.txt:
        * platform/mac/fast/inline/25277-expected.txt:
        * platform/mac/fast/lists/drag-into-marker-expected.txt:
        * platform/mac/fast/overflow/overflow-focus-ring-expected.txt:
        * platform/mac/fast/repaint/4776765-expected.txt:
        * platform/mac/fast/repaint/selection-after-delete-expected.txt:
        * platform/mac/fast/repaint/selection-after-remove-expected.txt:
        * platform/qt/editing/deleting/4845371-expected.txt:
        * platform/qt/editing/deleting/4866671-expected.txt:
        * platform/qt/editing/deleting/4875189-expected.txt:
        * platform/qt/editing/deleting/5026848-1-expected.txt:
        * platform/qt/editing/deleting/5026848-2-expected.txt:
        * platform/qt/editing/deleting/5026848-3-expected.txt:
        * platform/qt/editing/deleting/5032066-expected.txt:
        * platform/qt/editing/deleting/5091898-expected.txt:
        * platform/qt/editing/deleting/5099303-expected.txt:
        * platform/qt/editing/deleting/5115601-expected.txt:
        * platform/qt/editing/deleting/5126166-expected.txt:
        * platform/qt/editing/deleting/5144139-2-expected.txt:
        * platform/qt/editing/deleting/5156801-2-expected.txt:
        * platform/qt/editing/deleting/5168598-expected.txt:
        * platform/qt/editing/deleting/5272440-expected.txt:
        * platform/qt/editing/deleting/5300379-expected.txt:
        * platform/qt/editing/deleting/5390681-expected.txt:
        * platform/qt/editing/deleting/5408255-expected.txt:
        * platform/qt/editing/deleting/delete-at-start-or-end-expected.txt:
        * platform/qt/editing/deleting/delete-block-table-expected.txt:
        * platform/qt/editing/deleting/delete-hr-expected.txt:
        * platform/qt/editing/deleting/delete-link-1-expected.txt:
        * platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.txt:
        * platform/qt/editing/deleting/delete-to-select-table-expected.txt:
        * platform/qt/editing/deleting/deletionUI-single-instance-expected.txt:
        * platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
        * platform/qt/editing/deleting/merge-no-br-expected.txt:
        * platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
        * platform/qt/editing/execCommand/4641880-1-expected.txt:
        * platform/qt/editing/execCommand/4641880-2-expected.txt:
        * platform/qt/editing/execCommand/4747450-expected.txt:
        * platform/qt/editing/execCommand/4786404-1-expected.txt:
        * platform/qt/editing/execCommand/4786404-2-expected.txt:
        * platform/qt/editing/execCommand/4916402-expected.txt:
        * platform/qt/editing/execCommand/4916541-expected.txt:
        * platform/qt/editing/execCommand/4916583-expected.txt:
        * platform/qt/editing/execCommand/4920488-expected.txt:
        * platform/qt/editing/execCommand/4920742-1-expected.txt:
        * platform/qt/editing/execCommand/4924441-expected.txt:
        * platform/qt/editing/execCommand/5049671-expected.txt:
        * platform/qt/editing/execCommand/5062376-expected.txt:
        * platform/qt/editing/execCommand/5080333-1-expected.txt:
        * platform/qt/editing/execCommand/5080333-2-expected.txt:
        * platform/qt/editing/execCommand/5119244-expected.txt:
        * platform/qt/editing/execCommand/5120591-expected.txt:
        * platform/qt/editing/execCommand/5136770-expected.txt:
        * platform/qt/editing/execCommand/5142012-1-expected.txt:
        * platform/qt/editing/execCommand/5142012-2-expected.txt:
        * platform/qt/editing/execCommand/5142012-3-expected.txt:
        * platform/qt/editing/execCommand/5144139-1-expected.txt:
        * platform/qt/editing/execCommand/5164796-expected.txt:
        * platform/qt/editing/execCommand/5207369-expected.txt:
        * platform/qt/editing/execCommand/5210032-expected.txt:
        * platform/qt/editing/execCommand/5432254-1-expected.txt:
        * platform/qt/editing/execCommand/5432254-2-expected.txt:
        * platform/qt/editing/execCommand/insert-list-empty-div-expected.txt:
        * platform/qt/editing/inserting/12882-expected.txt:
        * platform/qt/editing/inserting/4840662-expected.txt:
        * platform/qt/editing/inserting/4875189-1-expected.txt:
        * platform/qt/editing/inserting/4875189-2-expected.txt:
        * platform/qt/editing/inserting/4959067-expected.txt:
        * platform/qt/editing/inserting/4960120-1-expected.txt:
        * platform/qt/editing/inserting/4960120-2-expected.txt:
        * platform/qt/editing/inserting/5002441-expected.txt:
        * platform/qt/editing/inserting/5058163-2-expected.txt:
        * platform/qt/editing/inserting/5156401-2-expected.txt:
        * platform/qt/editing/inserting/editable-html-element-expected.txt:
        * platform/qt/editing/inserting/editable-inline-element-expected.txt:
        * platform/qt/editing/inserting/edited-whitespace-1-expected.txt:
        * platform/qt/editing/inserting/editing-empty-divs-expected.txt:
        * platform/qt/editing/inserting/insert-before-link-1-expected.txt:
        * platform/qt/editing/pasteboard/4806874-expected.txt:
        * platform/qt/editing/pasteboard/4840662-expected.txt:
        * platform/qt/editing/pasteboard/4944770-1-expected.txt:
        * platform/qt/editing/pasteboard/4989774-expected.txt:
        * platform/qt/editing/pasteboard/5027857-expected.txt:
        * platform/qt/editing/pasteboard/5032095-expected.txt:
        * platform/qt/editing/pasteboard/5065605-expected.txt:
        * platform/qt/editing/pasteboard/5071074-2-expected.txt:
        * platform/qt/editing/pasteboard/5071074-expected.txt:
        * platform/qt/editing/pasteboard/5075944-2-expected.txt:
        * platform/qt/editing/pasteboard/5075944-3-expected.txt:
        * platform/qt/editing/pasteboard/5075944-expected.txt:
        * platform/qt/editing/pasteboard/5134759-expected.txt:
        * platform/qt/editing/pasteboard/5156401-1-expected.txt:
        * platform/qt/editing/pasteboard/5245519-expected.txt:
        * platform/qt/editing/pasteboard/5247341-expected.txt:
        * platform/qt/editing/pasteboard/5387578-expected.txt:
        * platform/qt/editing/pasteboard/5478250-expected.txt:
        * platform/qt/editing/pasteboard/5483567-expected.txt:
        * platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt:
        * platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
        * platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
        * platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
        * platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
        * platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt:
        * platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt:
        * platform/qt/editing/selection/13804-expected.txt:
        * platform/qt/editing/selection/4397952-expected.txt:
        * platform/qt/editing/selection/4818145-expected.txt:
        * platform/qt/editing/selection/4866671-expected.txt:
        * platform/qt/editing/selection/4889598-expected.txt:
        * platform/qt/editing/selection/4895428-2-expected.txt:
        * platform/qt/editing/selection/4895428-3-expected.txt:
        * platform/qt/editing/selection/4932260-1-expected.txt:
        * platform/qt/editing/selection/4932260-2-expected.txt:
        * platform/qt/editing/selection/4932260-3-expected.txt:
        * platform/qt/editing/selection/4960116-expected.txt:
        * platform/qt/editing/selection/4983858-expected.txt:
        * platform/qt/editing/selection/5007143-2-expected.txt:
        * platform/qt/editing/selection/5007143-expected.txt:
        * platform/qt/editing/selection/5076323-1-expected.txt:
        * platform/qt/editing/selection/5076323-2-expected.txt:
        * platform/qt/editing/selection/5076323-3-expected.txt:
        * platform/qt/editing/selection/5081257-1-expected.txt:
        * platform/qt/editing/selection/5081257-2-expected.txt:
        * platform/qt/editing/selection/5099303-expected.txt:
        * platform/qt/editing/selection/5136696-expected.txt:
        * platform/qt/editing/selection/5195166-1-expected.txt:
        * platform/qt/editing/selection/5195166-2-expected.txt:
        * platform/qt/editing/selection/5234383-1-expected.txt:
        * platform/qt/editing/selection/5234383-2-expected.txt:
        * platform/qt/editing/selection/5240265-expected.txt:
        * platform/qt/editing/selection/addRange-expected.txt:
        * platform/qt/editing/selection/caret-before-select-expected.txt:
        * platform/qt/editing/selection/editable-html-element-expected.txt:
        * platform/qt/editing/selection/mixed-editability-6-expected.txt:
        * platform/qt/editing/selection/mixed-editability-7-expected.txt:
        * platform/qt/editing/selection/move-by-sentence-linebreak-expected.txt:
        * platform/qt/editing/selection/select-all-005-expected.txt:
        * platform/qt/editing/selection/table-caret-1-expected.txt:
        * platform/qt/editing/selection/table-caret-2-expected.txt:
        * platform/qt/editing/selection/table-caret-3-expected.txt:
        * platform/qt/editing/style/4916887-expected.txt:
        * platform/qt/editing/style/5017613-1-expected.txt:
        * platform/qt/editing/style/5017613-2-expected.txt:
        * platform/qt/editing/style/5046875-1-expected.txt:
        * platform/qt/editing/style/5046875-2-expected.txt:
        * platform/qt/editing/style/5065910-expected.txt:
        * platform/qt/editing/style/5084241-expected.txt:
        * platform/qt/editing/style/5228141-expected.txt:
        * platform/qt/editing/style/5279521-expected.txt:
        * platform/qt/editing/style/font-family-with-space-expected.txt:
        * platform/qt/editing/style/fontsize-1-expected.txt:
        * platform/qt/editing/style/highlight-expected.txt:
        * platform/qt/editing/style/non-inheritable-styles-expected.txt:
        * platform/qt/editing/undo/5378473-expected.txt:
        * platform/qt/fast/dom/delete-contents-expected.txt:
        * platform/qt/fast/events/label-focus-expected.txt:
        * platform/qt/fast/forms/input-appearance-focus-expected.txt:
        * platform/qt/fast/forms/input-maxlength-2-expected.txt:
        * platform/qt/fast/forms/input-text-click-inside-expected.txt:
        * platform/qt/fast/forms/input-text-option-delete-expected.txt:
        * platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
        * platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt:
        * platform/qt/fast/forms/textfield-overflow-expected.txt:
        * platform/qt/fast/overflow/overflow-focus-ring-expected.txt:
        * platform/qt/fast/repaint/4776765-expected.txt:
        * platform/qt/fast/repaint/selection-after-delete-expected.txt:
        * platform/qt/fast/repaint/selection-after-remove-expected.txt:
        * platform/win/editing/deleting/5168598-expected.txt:
        * platform/win/editing/inserting/4960120-1-expected.txt:
        * platform/win/editing/inserting/5607069-2-expected.txt:
        * platform/win/editing/inserting/5607069-3-expected.txt:
        * platform/win/editing/inserting/typing-tab-designmode-forms-expected.txt:
        * platform/win/editing/pasteboard/4806874-expected.txt:
        * platform/win/editing/selection/4895428-3-expected.txt:
        * platform/win/editing/selection/5136696-expected.txt:
        * platform/win/editing/selection/drag-select-1-expected.txt:
        * platform/win/fast/events/context-no-deselect-expected.txt:
        * platform/win/fast/events/label-focus-expected.txt:
        * platform/win/fast/forms/input-appearance-focus-expected.txt:
        * platform/win/fast/forms/input-text-click-inside-expected.txt:
        * platform/win/fast/forms/input-text-click-outside-expected.txt:
        * platform/win/fast/forms/input-text-double-click-expected.txt:
        * platform/win/fast/forms/input-text-drag-down-expected.txt:
        * platform/win/fast/forms/input-text-option-delete-expected.txt:
        * platform/win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
        * platform/win/fast/forms/input-text-self-emptying-click-expected.txt:
        * platform/win/fast/forms/textfield-drag-into-disabled-expected.txt:
        * platform/win/fast/forms/textfield-overflow-expected.txt:
        Updated BODY element index in test output (for some tests, it increased because of the
        implicitly added <head>, and for others, it decreased because mispositoned <script> is being
        moved into <head>).

        * webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive:
        * webarchive/archive-empty-frame-dom-expected.webarchive:
        Updated to include the implicitly added <head> elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-04 Jakub Wieczorek <faw217@gmail.com>
hausmann@webkit.org [Tue, 5 May 2009 08:24:13 +0000 (08:24 +0000)]
2009-05-04  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        As Qtish implementation of MIMETypeRegistry::getMIMETypeForExtension()
        returns the application/octet-stream mimetype when it can't associate
        extension with any mimetype, it can happen that the application/octet-stream
        mimetype will hit the list of supported image formats. For instance,
        it is possible when QImageReader or QImageWriter support an extension
        that is not in the extensions map.

        Make sure that this mimetype is not treated as displayable image type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Tue, 5 May 2009 08:15:56 +0000 (08:15 +0000)]
    Reviewed by Simon Fraser.

        ASSERT(useTransforms) in SVG mapLocalToContainer implementations
        https://bugs.webkit.org/show_bug.cgi?id=25532

        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::mapLocalToContainer):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::mapLocalToContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Tue, 5 May 2009 08:15:39 +0000 (08:15 +0000)]
    Reviewed by Simon Fraser.

        Remove m_absoluteBounds hack from RenderSVGText
        https://bugs.webkit.org/show_bug.cgi?id=25532

        No functional changes (SVGs inside CSS transformed HTML should theoretically repaint better)

        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::layout):
        * rendering/RenderSVGText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Tue, 5 May 2009 08:15:20 +0000 (08:15 +0000)]
    Reviewed by Simon Fraser.

        Remove the vestigial calculateLocalTransform()
        https://bugs.webkit.org/show_bug.cgi?id=25532

        RenderSVGContainer is now the only render which needs this
        function, but it no longer returns the unused bool.

        calculateLocalTransform() previously was called by the DOM before
        transform updates were part of layout().

        * rendering/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::layout):
        * rendering/RenderForeignObject.h:
        (WebCore::RenderForeignObject::localTransform):
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::layout):
        * rendering/RenderPath.h:
        * rendering/RenderSVGContainer.cpp:
        * rendering/RenderSVGContainer.h:
        (WebCore::RenderSVGContainer::calculateLocalTransform):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::layout):
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::layout):
        * rendering/RenderSVGText.h:
        * rendering/RenderSVGTransformableContainer.cpp:
        (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
        * rendering/RenderSVGTransformableContainer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Tue, 5 May 2009 08:14:44 +0000 (08:14 +0000)]
    Reviewed by Simon Fraser.

        Move more code into SVGRenderBase
        https://bugs.webkit.org/show_bug.cgi?id=25532

        clippedOverflowRectForRepaint, computeRectForRepaint and mapLocalToContainer
        are now all shared via SVGRenderBase.

        RenderForeignObject should also be sharing this code, but I've left it
        alone for now, as changing that would likely cause test changes.

        No test changes.  It's possible that transformed <svg:image> elements will
        now show up with better metrics in the inspector.

        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
        (WebCore::RenderSVGImage::computeRectForRepaint):
        (WebCore::RenderSVGImage::mapLocalToContainer):
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
        (WebCore::RenderSVGModelObject::computeRectForRepaint):
        (WebCore::RenderSVGModelObject::mapLocalToContainer):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
        (WebCore::RenderSVGText::computeRectForRepaint):
        (WebCore::RenderSVGText::mapLocalToContainer):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::clippedOverflowRectForRepaint):
        (WebCore::SVGRenderBase::computeRectForRepaint):
        (WebCore::SVGRenderBase::mapLocalToContainer):
        * rendering/SVGRenderSupport.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Tue, 5 May 2009 08:14:20 +0000 (08:14 +0000)]
    Reviewed by Simon Fraser.

        Add SVGRenderBase to share logic between SVG renderers
        https://bugs.webkit.org/show_bug.cgi?id=25532

        I've added an SVGRenderBase base class which is shared by
        all of the SVG renders now.  This patch is just moving code
        there are no functional changes in this patch.

        Currently I've left these functions in SVGRenderSupport.h
        In a later patch I will rename SVGRenderSupport.* to SVGRenderBase.*

        clampImageBufferSizeToViewport now takes a FrameView* which makes some code easier to read.

        * rendering/RenderSVGBlock.h:
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGModelObject.h:
        * rendering/RenderSVGRoot.h:
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::prepareToRenderSVGContent):
        (WebCore::SVGRenderBase::finishRenderSVGContent):
        (WebCore::clampImageBufferSizeToViewport):
        (WebCore::SVGRenderBase::computeContainerBoundingBox):
        (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
        (WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback):
        (WebCore::SVGRootInlineBox::paint):
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::buildPattern):
        * svg/graphics/SVGPaintServerGradient.cpp:
        (WebCore::createMaskAndSwapContextForTextGradient):
        (WebCore::clipToTextMask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Tue, 5 May 2009 07:18:49 +0000 (07:18 +0000)]
2009-05-05  Simon Hausmann  <simon.hausmann@nokia.com>

        Unreviewed SVG build fix.

        Include MappedAttribute.h after r43187.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-04 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 5 May 2009 05:37:50 +0000 (05:37 +0000)]
2009-05-04  Maciej Stachowiak  <mjs@apple.com>

        Rubber stamped by Gavin.

        - inline Vector::resize for a ~1.5% speedup on string-tagcloud

        * wtf/Vector.h:
        (WTF::Vector::resize): Inline

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-04 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Tue, 5 May 2009 04:45:35 +0000 (04:45 +0000)]
2009-05-04  Holger Hans Peter Freyther  <zecke@selfish.org>

        Disabling accessibility/canvas.html due the lack of a
        an AccessibilityController implementation in DRT.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-04 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 5 May 2009 01:18:52 +0000 (01:18 +0000)]
2009-05-04  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam 'The Belly' Weinig

        <rdar://problem/6828894> - Facebook photo uploader applet broken on Leopard only

        In r41568 we started adding a default codebase attribute to <applet> tags if they didn't specify one
        themselves.  Leopard's Java plug-in mishandles this case and fails to load code for the applet.

        The spirit of r41568 can be maintained by removing the "default codebase" piece and only performing
        the canLoad() check if a codebase was actually set on the applet tag.

        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::createRenderer): Don't create a default codebase attribute.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::createJavaAppletWidget): Only perform the canLoad() check if the codebase was set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix
aroben@apple.com [Tue, 5 May 2009 01:00:00 +0000 (01:00 +0000)]
    Windows build fix

        * html/HTMLCollection.h:
        * html/HTMLFormElement.h:
        Declare CollectionCache as a struct, not a class, to match its
        definition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 25557: REGRESSION: Canvas elements are ignored instead of being exposed as AXImage
cfleizach@apple.com [Tue, 5 May 2009 00:39:02 +0000 (00:39 +0000)]
Bug 25557: REGRESSION: Canvas elements are ignored instead of being exposed as AXImage
https://bugs.webkit.org/show_bug.cgi?id=25557

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-04 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 5 May 2009 00:25:38 +0000 (00:25 +0000)]
2009-05-04  Brady Eidson  <beidson@apple.com>

        Fix an ancient Changelog entry where Sam Weinig flat out lied and confused my exploration of a bug.

        * ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-04 Kai Brüning <kai@granus.net>
eric@webkit.org [Tue, 5 May 2009 00:20:55 +0000 (00:20 +0000)]
2009-05-04  Kai Brüning  <kai@granus.net>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24883
        24883: Bad success test in parseXMLDocumentFragment in XMLTokenizerLibxml2.cpp

        Fixed test whether all the chunk has been processed to correctly count utf8 bytes.

        Test: fast/innerHTML/innerHTML-nbsp.xhtml

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::parseXMLDocumentFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-04 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 4 May 2009 20:11:54 +0000 (20:11 +0000)]
2009-05-04  Darin Adler  <darin@apple.com>

        * platform/gtk/Skipped: Disable a test that's timing out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-04 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 4 May 2009 20:08:42 +0000 (20:08 +0000)]
2009-05-04  Darin Adler  <darin@apple.com>

        First try at fixing the Windows build.

        * DOMHTMLClasses.cpp: Added include of HTMLCollection.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 4 May 2009 19:38:41 +0000 (19:38 +0000)]
2009-05-04  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Disabling new tests, as they are failing because of font
        configuration mismatch between my machine and the bot.

        * platform/gtk/Skipped:
        * platform/gtk/editing/spelling/spellcheck-attribute-expected.txt: Removed.
        * platform/gtk/svg/text/foreignObject-repaint-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 4 May 2009 19:13:57 +0000 (19:13 +0000)]
2009-05-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Fix <rdar://problem/6797644>.

        Make sure to send a reply even when an instance proxy can't be found.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEvaluate):
        (WKPCInvoke):
        (WKPCInvokeDefault):
        (WKPCGetProperty):
        (WKPCHasProperty):
        (WKPCHasMethod):
        (WKPCEnumerate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLayoutTests:
kov@webkit.org [Mon, 4 May 2009 18:12:57 +0000 (18:12 +0000)]
LayoutTests:

2009-05-04  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Alexey Proskuryakov.

        Add results for two new tests, for the GTK+ port.

        * platform/gtk/editing/spelling/spellcheck-attribute-expected.txt: Added.
        * platform/gtk/svg/text/foreignObject-repaint-expected.txt: Added.

WebKitTools:

2009-05-04  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Alexey Proskuryakov.

        Enable spell-checking in DumpRenderTree.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Mon, 4 May 2009 18:00:34 +0000 (18:00 +0000)]
WebCore:

2009-05-04  Darin Adler  <darin@apple.com>

        Reviewed by Eric Seidel.

        Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
        and NamedMappedAttrMap.h include of MappedAttribute.h
        https://bugs.webkit.org/show_bug.cgi?id=24924

        Make compiles faster, and debugging info smaller.

        * GNUmakefile.am: Added new source files.
        * WebCore.pro: Ditto.
        * WebCore.scons: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.

        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::toJS): Updated for new collection type names.

        * dom/Document.cpp:
        (WebCore::Document::createAttribute): Added. No longer inline.
        (WebCore::Document::images): Updated for new collection type names.
        (WebCore::Document::applets): Ditto.
        (WebCore::Document::embeds): Ditto.
        (WebCore::Document::plugins): Ditto.
        (WebCore::Document::objects): Ditto.
        (WebCore::Document::scripts): Ditto.
        (WebCore::Document::links): Ditto.
        (WebCore::Document::forms): Ditto.
        (WebCore::Document::anchors): Ditto.
        (WebCore::Document::all): Ditto.
        (WebCore::Document::windowNamedItems): Ditto.
        (WebCore::Document::documentNamedItems): Ditto.
        (WebCore::Document::nameCollectionInfo): Ditto.

        * dom/Document.h: Changed around includes and forward declarations.
        Updated for changes to collection types.

        * dom/NamedMappedAttrMap.h: Removed include of MappedAttribute.h.

        * html/CollectionCache.cpp: Copied from WebCore/html/HTMLCollection.cpp.
        Contains the class that used to be HTMLCollection::CollectionInfo.
        * html/CollectionCache.h: Copied from WebCore/html/HTMLCollection.h.
        Ditto.

        * html/CollectionType.h: Copied from WebCore/html/HTMLCollection.h.
        Has the enum that used to be HTMLCollection::Type.

        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::HTMLCollection): Update for collection type change.
        (WebCore::HTMLCollection::create): Ditto.
        (WebCore::HTMLCollection::resetCollectionInfo): Ditto.
        (WebCore::HTMLCollection::itemAfter): Ditto.
        * html/HTMLCollection.h: Ditto.

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::children): Updated for new collection type names.
        * html/HTMLFormCollection.cpp:
        (WebCore::HTMLFormCollection::formCollectionInfo): Ditto.
        (WebCore::HTMLFormCollection::HTMLFormCollection): Ditto.
        * html/HTMLFormCollection.h: Ditto.
        * html/HTMLFormElement.h: Ditto.
        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::areas): Ditto.
        * html/HTMLNameCollection.cpp:
        (WebCore::HTMLNameCollection::HTMLNameCollection): Ditto.
        * html/HTMLNameCollection.h:
        (WebCore::HTMLNameCollection::create): Ditto.
        * html/HTMLSelectElement.h:
        (WebCore::HTMLSelectElement::collectionInfo): Ditto.
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::tBodies):Ditto.
        * html/HTMLTableRowElement.cpp:
        (WebCore::HTMLTableRowElement::cells):Ditto.
        * html/HTMLTableRowsCollection.cpp:
        (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): Ditto.
        * html/HTMLTableSectionElement.cpp:
        (WebCore::HTMLTableSectionElement::rows): Ditto.

        * bindings/js/JSDOMWindowBase.cpp: Added newly-needed includes.
        * bindings/js/JSHTMLFrameSetElementCustom.cpp: Ditto.
        * css/CSSStyleSelector.cpp: Ditto.
        * dom/Element.cpp: Ditto.
        * dom/InputElement.cpp: Ditto.
        * dom/NamedAttrMap.cpp: Ditto.
        * dom/NamedMappedAttrMap.cpp: Ditto.
        * dom/Node.cpp: Ditto.
        * dom/StyledElement.cpp: Ditto.
        * dom/StyledElement.h: Ditto.
        * editing/ApplyStyleCommand.cpp: Ditto.
        * editing/DeleteSelectionCommand.cpp: Ditto.
        * editing/Editor.cpp: Ditto.
        * editing/EditorCommand.cpp: Ditto.
        * editing/InsertParagraphSeparatorCommand.cpp: Ditto.
        * editing/ReplaceSelectionCommand.cpp: Ditto.
        * editing/markup.cpp: Ditto.
        * html/CanvasRenderingContext2D.cpp: Ditto.
        * html/HTMLAnchorElement.cpp: Ditto.
        * html/HTMLAppletElement.cpp: Ditto.
        * html/HTMLAreaElement.cpp: Ditto.
        * html/HTMLBRElement.cpp: Ditto.
        * html/HTMLBaseElement.cpp: Ditto.
        * html/HTMLBodyElement.cpp: Ditto.
        * html/HTMLButtonElement.cpp: Ditto.
        * html/HTMLCanvasElement.cpp: Ditto.
        * html/HTMLDivElement.cpp: Ditto.
        * html/HTMLEmbedElement.cpp: Ditto.
        * html/HTMLFontElement.cpp: Ditto.
        * html/HTMLFormControlElement.cpp: Ditto.
        * html/HTMLFormElement.cpp: Ditto.
        * html/HTMLFrameElement.cpp: Ditto.
        * html/HTMLFrameElementBase.cpp: Ditto.
        * html/HTMLFrameSetElement.cpp: Ditto.
        * html/HTMLHRElement.cpp: Ditto.
        * html/HTMLIFrameElement.cpp: Ditto.
        * html/HTMLImageElement.cpp: Ditto.
        * html/HTMLInputElement.cpp: Ditto.
        * html/HTMLIsIndexElement.cpp: Ditto.
        * html/HTMLKeygenElement.cpp: Ditto.
        * html/HTMLLIElement.cpp: Ditto.
        * html/HTMLLinkElement.cpp: Ditto.
        * html/HTMLMarqueeElement.cpp: Ditto.
        * html/HTMLMetaElement.cpp: Ditto.
        * html/HTMLOListElement.cpp: Ditto.
        * html/HTMLObjectElement.cpp: Ditto.
        * html/HTMLOptionElement.cpp: Ditto.
        * html/HTMLParagraphElement.cpp: Ditto.
        * html/HTMLParamElement.cpp: Ditto.
        * html/HTMLPlugInElement.cpp: Ditto.
        * html/HTMLPreElement.cpp: Ditto.
        * html/HTMLScriptElement.cpp: Ditto.
        * html/HTMLSelectElement.cpp: Ditto.
        * html/HTMLStyleElement.cpp: Ditto.
        * html/HTMLTableCaptionElement.cpp: Ditto.
        * html/HTMLTableCellElement.cpp: Ditto.
        * html/HTMLTableColElement.cpp: Ditto.
        * html/HTMLTablePartElement.cpp: Ditto.
        * html/HTMLTextAreaElement.cpp: Ditto.
        * html/HTMLTokenizer.cpp: Ditto.
        * html/HTMLUListElement.cpp: Ditto.
        * html/HTMLVideoElement.cpp: Ditto.
        * html/HTMLViewSourceDocument.cpp: Ditto.
        * loader/ImageDocument.cpp: Ditto.
        * page/Frame.cpp: Ditto.
        * rendering/RenderTreeAsText.cpp: Ditto.
        * svg/SVGAElement.cpp: Ditto.
        * svg/SVGAnimateMotionElement.cpp: Ditto.
        * svg/SVGAnimateTransformElement.cpp: Ditto.
        * svg/SVGAnimationElement.cpp: Ditto.
        * svg/SVGCircleElement.cpp: Ditto.
        * svg/SVGClipPathElement.cpp: Ditto.
        * svg/SVGCursorElement.cpp: Ditto.
        * svg/SVGElement.cpp: Ditto.
        * svg/SVGEllipseElement.cpp: Ditto.
        * svg/SVGExternalResourcesRequired.cpp: Ditto.
        * svg/SVGFitToViewBox.cpp: Ditto.
        * svg/SVGFontFaceElement.cpp: Ditto.
        * svg/SVGFontFaceUriElement.cpp: Ditto.
        * svg/SVGForeignObjectElement.cpp: Ditto.
        * svg/SVGGlyphElement.cpp: Ditto.
        * svg/SVGGradientElement.cpp: Ditto.
        * svg/SVGImageElement.cpp: Ditto.
        * svg/SVGLangSpace.cpp: Ditto.
        * svg/SVGLineElement.cpp: Ditto.
        * svg/SVGLinearGradientElement.cpp: Ditto.
        * svg/SVGMarkerElement.cpp: Ditto.
        * svg/SVGMaskElement.cpp: Ditto.
        * svg/SVGPathElement.cpp: Ditto.
        * svg/SVGPatternElement.cpp: Ditto.
        * svg/SVGPolyElement.cpp: Ditto.
        * svg/SVGRadialGradientElement.cpp: Ditto.
        * svg/SVGRectElement.cpp: Ditto.
        * svg/SVGSVGElement.cpp: Ditto.
        * svg/SVGScriptElement.cpp: Ditto.
        * svg/SVGStopElement.cpp: Ditto.
        * svg/SVGStyleElement.cpp: Ditto.
        * svg/SVGStyledElement.cpp: Ditto.
        * svg/SVGStyledTransformableElement.cpp: Ditto.
        * svg/SVGTests.cpp: Ditto.
        * svg/SVGTextContentElement.cpp: Ditto.
        * svg/SVGTextElement.cpp: Ditto.
        * svg/SVGTextPathElement.cpp: Ditto.
        * svg/SVGTextPositioningElement.cpp: Ditto.
        * svg/SVGURIReference.cpp: Ditto.
        * svg/SVGUseElement.cpp: Ditto.
        * svg/SVGViewElement.cpp: Ditto.
        * svg/animation/SVGSMILElement.cpp: Ditto.
        * xml/XPathStep.cpp: Ditto.

WebKit/mac:

2009-05-04  Darin Adler  <darin@apple.com>

        Reviewed by Eric Seidel.

        Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
        and NamedMappedAttrMap.h include of MappedAttribute.h
        https://bugs.webkit.org/show_bug.cgi?id=24924

        * WebView/WebFrame.mm: Added include of CSSMutableStyleDeclaration.h
        and ScriptValue.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoInitial DRT implementation for wx.
kevino@webkit.org [Mon, 4 May 2009 17:57:55 +0000 (17:57 +0000)]
Initial DRT implementation for wx.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-04 Pavel Feldman <pfeldman@chromium.org>
pkasting@chromium.org [Mon, 4 May 2009 17:50:42 +0000 (17:50 +0000)]
2009-05-04  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Do not instantiate hidden WebInspector panels. Otherwise they are hitting unimplemented InspectorController methods.
        https://bugs.webkit.org/show_bug.cgi?id=25520

        * inspector/front-end/inspector.js:
        (WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-04 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 4 May 2009 17:02:38 +0000 (17:02 +0000)]
2009-05-04  Darin Adler  <darin@apple.com>

        Reviewed by Adam Roben.

        * media/video-size-intrinsic-scale-expected.txt: Changed to match test.
        * media/video-size-intrinsic-scale.html: Removed doubled "Movie" word.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-04 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 4 May 2009 16:20:11 +0000 (16:20 +0000)]
2009-05-04  Brady Eidson <beidson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6839881> With "Mail Contents of This Page" in Safari images don't appear in the Tiger Mail compose window

        DocumentLoader::subresource() is the implementation for the WebKit API [WebDataSource subresourceForURL:] and has
        particularly sticky behavior.

        If the DocumentLoader represents a WebArchive, this method should return ArchiveResources from that archive.  However, we
        prefer CachedResources over ArchiveResources because they might represent fresher data than what was originally loaded
        from the WebArchive.

        In some instances, CachedResources are created and associated with the DocumentLoader but not immediately run through the
        loading delegate machinery.  This was always a possibility, but the Preload Scanner made this significantly more likely.

        When this happens and someone asks the WebDataSource for a subresource, it would prefer the CachedResource over an
        ArchiveResource it has even if the CachedResource hasn't been loaded yet.  The CachedResource has nil data, so no
        WebResource is returned, and the client thinks the subresource doesn't exist even though it does.

        This broke Tiger Mail and probably various other WebKit applications but has a fairly straightforward fix.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource): If there is a CachedResource but it hasn't been loaded yet, fallback to the
          ArchiveResource.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-04 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 4 May 2009 15:56:17 +0000 (15:56 +0000)]
2009-05-04  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=25545
        Bug 25545: HTMLMediaElement: display anamorphic video correctly

        Tell QuickTime to use clean aperture mode so movies with non-square pixels are sized
        and displayed correctly.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovie): Ask QuickTime to use clean aperture mode.
        * platform/graphics/win/QTMovieWin.cpp:
        (QTMovieWin::load): Ditto. Add ASSERT to ensure that static movie property array isn't
        filled beyond capacity.

2009-05-04  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=25545
        Bug 25545: HTMLMediaElement: display anamorphic video correctly

        Added 720x576i PAL anamorphic movie, extended video-size-intrinsic-scale
        test to check that it is sized correctly.

        * media/content/720x576i-anamorphic.mov: Added.
        * media/video-size-intrinsic-scale-expected.txt:
        * media/video-size-intrinsic-scale.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix <https://bugs.webkit.org/show_bug.cgi?id=25332>.
mrowe@apple.com [Mon, 4 May 2009 15:38:57 +0000 (15:38 +0000)]
Fix <https://bugs.webkit.org/show_bug.cgi?id=25332>.
Bug 25332: Plug-in inserted in to DOM of PluginDocument fails to load

Reviewed by Darin Adler.

Only the first plug-in in a PluginDocument can use the main resource data.  For all
subsequent plug-ins, such as the plug-in that ClickToFlash inserts when swapping itself
out for the real Flash plug-in, we need to load the resource data in the same manner
as for other embedded plug-ins.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-04 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 4 May 2009 15:25:20 +0000 (15:25 +0000)]
2009-05-04  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Ariya Hidayat.

        Update the qrc file for the Web Inspector in the Qt build
        with missing files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by George Staikos.
eric@webkit.org [Mon, 4 May 2009 07:17:43 +0000 (07:17 +0000)]
    Reviewed by George Staikos.

        Move absoluteRects and absoluteQuads into RenderSVGInline and remove absoluteTransform() usage
        https://bugs.webkit.org/show_bug.cgi?id=25532

        * rendering/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::absoluteRects):
        (WebCore::RenderSVGInline::absoluteQuads):
        * rendering/RenderSVGInline.h:
        * rendering/RenderSVGTSpan.cpp:
        * rendering/RenderSVGTSpan.h:
        * rendering/RenderSVGTextPath.cpp:
        * rendering/RenderSVGTextPath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by George Staikos.
eric@webkit.org [Mon, 4 May 2009 07:17:15 +0000 (07:17 +0000)]
    Reviewed by George Staikos.

        Move RenderSVGText off of localToAbsolute()
        https://bugs.webkit.org/show_bug.cgi?id=25532

        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::absoluteRects):
        (WebCore::RenderSVGText::absoluteQuads):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by George Staikos.
eric@webkit.org [Mon, 4 May 2009 07:16:47 +0000 (07:16 +0000)]
    Reviewed by George Staikos.

        Remove broken absoluteTransform() code from RenderSVGInlineText
        https://bugs.webkit.org/show_bug.cgi?id=25532

        This improved SVG text focus rings.
        This also improved SVG.getScreenCTM() results.

        SVGSVGElement::getScreenCTM was passing "true" for the second argument in
        localToAbsolute, which is "fixed" it meant to pass "true" for the
        third argument (useTransforms).  That change alone caused no layout test changes, however
        before I fixed this, it was hitting ASSERT(!fixed) in RenderSVGRoot::mapLocalToContainer

        mapLocalToContainer implementations really should be shared,
        but I'll do that in a later patch.

        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::styleDidChange):
        (WebCore::RenderSVGInlineText::absoluteQuads):
        (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
        (WebCore::RenderSVGInlineText::computeRepaintQuadForRange):
        * rendering/RenderSVGInlineText.h:
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::mapLocalToContainer):
        * rendering/RenderSVGRoot.h:
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::mapLocalToContainer):
        * rendering/RenderSVGText.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::getScreenCTM):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by George Staikos.
eric@webkit.org [Mon, 4 May 2009 07:15:54 +0000 (07:15 +0000)]
    Reviewed by George Staikos.

        Remove dead code from RenderPath
        https://bugs.webkit.org/show_bug.cgi?id=25532

        * rendering/RenderPath.cpp:
        * rendering/RenderPath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by George Staikos.
eric@webkit.org [Mon, 4 May 2009 07:15:31 +0000 (07:15 +0000)]
    Reviewed by George Staikos.

        Share layout code between RenderSVGViewportContainer and RenderSVGContainer
        https://bugs.webkit.org/show_bug.cgi?id=25532

        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::layout):
        * rendering/RenderSVGContainer.h:
        (WebCore::RenderSVGContainer::calcViewport):
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::applyViewportClip):
        * rendering/RenderSVGViewportContainer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by George Staikos.
eric@webkit.org [Mon, 4 May 2009 07:15:02 +0000 (07:15 +0000)]
    Reviewed by George Staikos.

        Remove redundant disableLayoutState() calls
        https://bugs.webkit.org/show_bug.cgi?id=25532

        * rendering/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::layout):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::layout):
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by George Staikos.
eric@webkit.org [Mon, 4 May 2009 07:14:29 +0000 (07:14 +0000)]
    Reviewed by George Staikos.

        Simplify RenderForeignObject::paint and fix a repaint bug.
        Paint now calls applyTransformToPaintInfo which correctly transforms the damage rect.
        https://bugs.webkit.org/show_bug.cgi?id=16939

        * rendering/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago No review, just adding missing results.
eric@webkit.org [Mon, 4 May 2009 06:39:13 +0000 (06:39 +0000)]
    No review, just adding missing results.

        Add Win results for editing/spelling/spellcheck-attribute
        Pixel results are still missing, but I have no easy way
        to add them, and the bots aren't generating them currently.

        * platform/win/editing/spelling/spellcheck-attribute-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix.
sfalken@apple.com [Mon, 4 May 2009 06:36:08 +0000 (06:36 +0000)]
    Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-03 Hironori Bono <hbono@chromium.org>
eric@webkit.org [Mon, 4 May 2009 06:05:47 +0000 (06:05 +0000)]
2009-05-03  Hironori Bono  <hbono@chromium.org>

        Reviewed by Eric Seidel.

        Test: editing/spelling/spellcheck-attribute.html

        Bug 14552: Add a way to disable spell checking for specific element
        https://bugs.webkit.org/show_bug.cgi?id=14552

        For compatibility with Firefox, this code ascends the DOM tree when an element does
        not have its "spellcheck" attribute.

        * editing/Editor.cpp:
        (WebCore::markMisspellingsOrBadGrammar): Retrieve the value of the "spellcheck"
        attribute of an element before calling a spell checker or a grammar checker.
        * html/HTMLAttributeNames.in: Add a "spellcheck" attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-03 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Mon, 4 May 2009 02:00:58 +0000 (02:00 +0000)]
2009-05-03  Gustavo Noronha Silva  <gns@gnome.org>

        Three more failing tests caused by the disabling of the others.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-03 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Mon, 4 May 2009 01:38:14 +0000 (01:38 +0000)]
2009-05-03  Gustavo Noronha Silva  <gns@gnome.org>

        Disable more tests that fail on the bot, and those which fail when
        we disable some. Hopefully this finishes our massage to the
        skipped list and we can go back to working on fixing tests now.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the 64-bit build.
mrowe@apple.com [Mon, 4 May 2009 00:42:18 +0000 (00:42 +0000)]
Fix the 64-bit build.

* API/APICast.h:
(toJS):
(toRef):
* runtime/JSNumberCell.cpp:
(JSC::jsAPIMangledNumber):
* runtime/JSNumberCell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
eric@webkit.org [Sun, 3 May 2009 23:25:21 +0000 (23:25 +0000)]
    Reviewed by Sam Weinig.

        Dump more metrics from svgsvgelement-ctm test.
        (And break up the first SVG into two SVGs for easier reading of the metrics)

        * svg/custom/svgsvgelement-ctm-expected.txt:
        * svg/custom/svgsvgelement-ctm.xhtml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-03 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sun, 3 May 2009 21:44:15 +0000 (21:44 +0000)]
2009-05-03  Gustavo Noronha Silva  <gns@gnome.org>

        Some tests are still failing on the bot, despite working
        locally. Disabling for now.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-03 Zan Dobersek <zandobersek@gmail.com>
kov@webkit.org [Sun, 3 May 2009 21:32:08 +0000 (21:32 +0000)]
2009-05-03  Zan Dobersek  <zandobersek@gmail.com>

         Reviewed by Gustavo Noronha.

         Enable more tests that succeed and style up the list a bit.

         * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
weinig@apple.com [Sun, 3 May 2009 21:02:04 +0000 (21:02 +0000)]
JavaScriptCore:

2009-05-02  Sam Weinig  <sam@webkit.org>

        Roll JSC API number marshaling back in one last time (I hope).

WebCore:

2009-05-03  Sam Weinig  <sam@webkit.org>

        Roll JSC API number marshaling back in one last time (I hope).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 3 May 2009 20:59:11 +0000 (20:59 +0000)]
2009-05-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Don't pass an exception parameter if we don't care about the value.

        * DumpRenderTree/win/EventSender.cpp:
        (keyDownCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
weinig@apple.com [Sun, 3 May 2009 19:56:13 +0000 (19:56 +0000)]
JavaScriptCore:

2009-05-03  Sam Weinig  <sam@webkit.org>

        Roll JSC API number marshaling back out. It still breaks windows.

WebCore:

2009-05-03  Sam Weinig  <sam@webkit.org>

        Roll JSC API number marshaling back out. It still breaks windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
weinig@apple.com [Sun, 3 May 2009 19:27:42 +0000 (19:27 +0000)]
JavaScriptCore:

2009-05-02  Sam Weinig  <sam@webkit.org>

        Roll JSC API number marshaling back in.

WebCore:

2009-05-02  Sam Weinig  <sam@webkit.org>

        Roll JSC API number marshaling back in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-02 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 3 May 2009 16:49:35 +0000 (16:49 +0000)]
2009-05-02  Darin Adler  <darin@apple.com>

        Reviewed by Maciej Stachowiak.

        Bug 25519: streamline lexer by handling BOMs differently
        https://bugs.webkit.org/show_bug.cgi?id=25519

        Roughly 1% faster SunSpider.

        * parser/Grammar.y: Tweak formatting a bit.

        * parser/Lexer.cpp:
        (JSC::Lexer::Lexer): Remove unnnecessary initialization of data members
        that are set up by setCode.
        (JSC::Lexer::currentOffset): Added. Used where the old code would look at
        m_currentOffset.
        (JSC::Lexer::shift1): Replaces the old shift function. No longer does anything
        to handle BOM characters.
        (JSC::Lexer::shift2): Ditto.
        (JSC::Lexer::shift3): Ditto.
        (JSC::Lexer::shift4): Ditto.
        (JSC::Lexer::setCode): Updated for name change from yylineno to m_line.
        Removed now-unused m_eatNextIdentifier, m_stackToken, and m_restrKeyword.
        Replaced m_skipLF and m_skipCR with m_skipLineEnd. Replaced the old
        m_length with m_codeEnd and m_currentOffset with m_codeStart. Added code
        to scan for a BOM character and call copyCodeWithoutBOMs() if we find any.
        (JSC::Lexer::copyCodeWithoutBOMs): Added.
        (JSC::Lexer::nextLine): Updated for name change from yylineno to m_line.
        (JSC::Lexer::makeIdentifier): Moved up higher in the file.
        (JSC::Lexer::matchPunctuator): Moved up higher in the file and changed to
        use a switch statement instead of just if statements.
        (JSC::Lexer::isLineTerminator): Moved up higher in the file and changed to
        have fewer branches.
        (JSC::Lexer::lastTokenWasRestrKeyword): Added. This replaces the old
        m_restrKeyword boolean.
        (JSC::Lexer::isIdentStart): Moved up higher in the file. Changed to use
        fewer branches in the ASCII but not identifier case.
        (JSC::Lexer::isIdentPart): Ditto.
        (JSC::Lexer::singleEscape): Moved up higher in the file.
        (JSC::Lexer::convertOctal): Moved up higher in the file.
        (JSC::Lexer::convertHex): Moved up higher in the file. Changed to use
        toASCIIHexValue instead of rolling our own here.
        (JSC::Lexer::convertUnicode): Ditto.
        (JSC::Lexer::record8): Moved up higher in the file.
        (JSC::Lexer::record16): Moved up higher in the file.
        (JSC::Lexer::lex): Changed type of stringType to int. Replaced m_skipLF
        and m_skipCR with m_skipLineEnd, which requires fewer branches in the
        main lexer loop. Use currentOffset instead of m_currentOffset. Removed
        unneeded m_stackToken. Use isASCIIDigit instead of isDecimalDigit.
        Split out the two cases for InIdentifierOrKeyword and InIdentifier.
        Added special case tight loops for identifiers and other simple states.
        Removed a branch from the code that sets m_atLineStart to false using goto.
        Streamlined the number-handling code so we don't check for the same types
        twice for non-numeric cases and don't add a null to m_buffer8 when it's
        not being used. Removed m_eatNextIdentifier, which wasn't working anyway,
        and m_restrKeyword, which is redundant with m_lastToken. Set the
        m_delimited flag without using a branch.
        (JSC::Lexer::scanRegExp): Tweaked style a bit.
        (JSC::Lexer::clear): Clear m_codeWithoutBOMs so we don't use memory after
        parsing. Clear out UString objects in the more conventional way.
        (JSC::Lexer::sourceCode): Made this no-longer inline since it has more
        work to do in the case where we stripped BOMs.

        * parser/Lexer.h: Renamed yylineno to m_lineNumber. Removed convertHex
        function, which is the same as toASCIIHexValue. Removed isHexDigit
        function, which is the same as isASCIIHedDigit. Replaced shift with four
        separate shift functions. Removed isWhiteSpace function that passes
        m_current, instead just passing m_current explicitly. Removed isOctalDigit,
        which is the same as isASCIIOctalDigit. Eliminated unused arguments from
        matchPunctuator. Added copyCoodeWithoutBOMs and currentOffset. Moved the
        makeIdentifier function out of the header. Added lastTokenWasRestrKeyword
        function. Added new constants for m_skipLineEnd. Removed unused yycolumn,
        m_restrKeyword, m_skipLF, m_skipCR, m_eatNextIdentifier, m_stackToken,
        m_position, m_length, m_currentOffset, m_nextOffset1, m_nextOffset2,
        m_nextOffset3. Added m_skipLineEnd, m_codeStart, m_codeEnd, and
        m_codeWithoutBOMs.

        * parser/SourceProvider.h: Added hasBOMs function. In the future this can
        be used to tell the lexer about strings known not to have BOMs.

        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncUnescape): Changed to use isASCIIHexDigit.

        * wtf/ASCIICType.h: Added using statements to match the design of the
        other WTF headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix windows build (when doing a clean build)
adachan@apple.com [Sun, 3 May 2009 04:17:04 +0000 (04:17 +0000)]
    Fix windows build (when doing a clean build)

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43155 268f45cc-cd09-0410-ab3c-d52691b4dbfc