WebKit-https.git
7 years agonrwt isn't rejecting unrecognized expectations
dpranke@chromium.org [Tue, 11 Dec 2012 20:54:14 +0000 (20:54 +0000)]
nrwt isn't rejecting unrecognized expectations
https://bugs.webkit.org/show_bug.cgi?id=104701

Reviewed by Ojan Vafai.

Tools:

NRWT is silently ignoring unrecognized expectations like "Text"
and "Audio" (largely because I haven't fully removed support for
the old syntax and keywords and restructured the code to do the
proper checking). Temporarily change the tokenizer to reject
unrecognized expectations until I can make those changes.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._tokenize_line):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(ExpectationSyntaxTests.test_unknown_expectation):
(TestExpectationSerializationTests.disabled_test_string_whitespace_stripping):

LayoutTests:

Remove a few lines referring to non-existent files, and
change a few "Fail" and "Text" expectations to "Failure" now
that "Fail" and "Text" will be correctly rejected.

* platform/mac/TestExpectations
* platform/qt/TestExpectations
* platform/gtk/TestExpectations
* platform/win/TestExpectations

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInitialize new web processes with list of auto-start origins for plug-ins
jonlee@apple.com [Tue, 11 Dec 2012 20:49:58 +0000 (20:49 +0000)]
Initialize new web processes with list of auto-start origins for plug-ins
https://bugs.webkit.org/show_bug.cgi?id=103219
<rdar://problem/12747219>

Reviewed by Anders Carlsson.

Serialize the set of hashes into a vector as a parameter in web process creation.

* Shared/WebProcessCreationParameters.h: Add a parameter for the origin hashes.

* Shared/WebProcessCreationParameters.cpp: Encode/decode that parameter.
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

* UIProcess/Plugins/PlugInAutoStartProvider.cpp:
(WebKit::PlugInAutoStartProvider::autoStartOriginsCopy): Return a vector copy with contents from the
hash set.
* UIProcess/Plugins/PlugInAutoStartProvider.h:
(PlugInAutoStartProvider):

* UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess): Populate the parameter with the contents of the set.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Add the items in the vector to the web process' copy of the set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r133492): Heap-use-after-free in WebCore::Element::normalizeAttributes
akling@apple.com [Tue, 11 Dec 2012 20:46:56 +0000 (20:46 +0000)]
REGRESSION(r133492): Heap-use-after-free in WebCore::Element::normalizeAttributes
<http://webkit.org/b/104488>

Reviewed by Antti Koivisto.

Source/WebCore:

Don't cache the AttrNodeList* in a local when iterating over an Element's Attr nodes since
that pointer may go stale if JS runs in response to a DOMSubtreeModified event below Node::normalize().

Test: fast/dom/normalize-attributes-mutation-event-crash.html

* dom/Element.cpp:
(WebCore::Element::normalizeAttributes):

LayoutTests:

* fast/dom/normalize-attributes-mutation-event-crash-expected.txt: Added.
* fast/dom/normalize-attributes-mutation-event-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdating these test results after http://trac.webkit.org/changeset/137006
bdakin@apple.com [Tue, 11 Dec 2012 20:35:12 +0000 (20:35 +0000)]
Updating these test results after trac.webkit.org/changeset/137006
These tests have WK2-only results because WK2 forces compositing for fixed
position elements in WK2 but not WK1.

* platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
* platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix bogus test expectations
adamk@chromium.org [Tue, 11 Dec 2012 20:06:57 +0000 (20:06 +0000)]
Fix bogus test expectations

Unreviewed.

There were a bunch of uses of "Text" when they should have said "Failure".

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix a typo in my previous commit that is causing test failures.
mrobinson@webkit.org [Tue, 11 Dec 2012 19:02:06 +0000 (19:02 +0000)]
Fix a typo in my previous commit that is causing test failures.

Reviewed by Gustavo Noronha Silva.

There was an extra bit of statement appended after the end of a conditional. Somehow
this compiled and caused test failures.

* DumpRenderTree/gtk/EventSender.cpp:
(continuousMouseScrollByCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Soup network logs are frequently interrupted by other logging messages
commit-queue@webkit.org [Tue, 11 Dec 2012 18:58:19 +0000 (18:58 +0000)]
[GTK] Soup network logs are frequently interrupted by other logging messages
https://bugs.webkit.org/show_bug.cgi?id=104668

Patch by Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> on 2012-12-11
Reviewed by Martin Robinson.

Set an external soup log printer that uses the WebKit logging
infrastructure so that log messages are properly synchronized.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::soupLogPrinter):
(WebCore):
(WebCore::ensureSessionIsInitialized):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSwitch to new PseudoElement based :before and :after
dpranke@chromium.org [Tue, 11 Dec 2012 18:53:19 +0000 (18:53 +0000)]
Switch to new PseudoElement based :before and :after
https://bugs.webkit.org/show_bug.cgi?id=104462

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-11
Reviewed by Antti Koivisto.

Source/WebCore:

Switch to the new PseudoElement based generated content implementation
that moves :before and :after into the DOM. This also switches to using
the ComposedShadowTreeWalker for determining the siblings of PseudoElement's
making the new generated content implementation support adding :before
and :after into <input> elements.

Tests: fast/css-generated-content/block-inside-inline.html
       fast/css-generated-content/box-orient.html

* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::pseudoAwareNextSibling):
(WebCore):
(WebCore::ComposedShadowTreeWalker::pseudoAwarePreviousSibling):
(WebCore::ComposedShadowTreeWalker::traverseParent):
* dom/ComposedShadowTreeWalker.h:
(ComposedShadowTreeWalker):
* dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::recalcStyle):
* dom/Node.cpp:
* dom/Node.h:
(Node):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
* dom/Position.cpp:
(WebCore::Position::Position):
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
* editing/visible_units.cpp:
(WebCore::logicallyPreviousBox):
(WebCore::logicallyNextBox):
(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::childShouldCreateRenderer):
* page/DragController.cpp:
(WebCore::DragController::draggableNode):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::createReplacementRunIn):
(WebCore::RenderBlock::isSelectionRoot):
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderButton.cpp:
* rendering/RenderButton.h:
(RenderButton):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::splitInlines):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateMarkerLocation):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createVisiblePosition):
* rendering/RenderObject.h:
(WebCore::RenderObject::nonPseudoNode):
(RenderObject):
(WebCore::RenderObject::clearNode):
(WebCore::RenderObject::generatingNode):
* rendering/RenderObjectChildList.cpp:
* rendering/RenderObjectChildList.h:
(RenderObjectChildList):
* rendering/RenderRubyText.cpp:
* rendering/RenderRubyText.h:
(RenderRubyText):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
* rendering/RenderTableRow.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::destroy):

LayoutTests:

Add test for block generated content inside inlines which is now supported
properly, and also for using box-orient and reordering.

before-content-continuation.html's expectations change because we now
support block content properly.

I skipped fast/css-generated-content/table-row-group-to-inline.html
which needs a rebaseline after this this lands. Unfortunately the test
output is still wrong because we leave an anonymous RenderTable in the
tree, but that bug has always been there.

I also skipped fast/css/empty-generated-content.html which needs rebaselines
as we no longer create extra anonymous blocks, though the reason is not clear
to me.

* fast/css-generated-content/before-content-continuation-chain-expected.txt:
* fast/css-generated-content/block-inside-inline-expected.html: Added.
* fast/css-generated-content/block-inside-inline.html: Added.
* fast/css-generated-content/box-orient-expected.html: Added.
* fast/css-generated-content/box-orient.html: Added.
* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove deprecated WebGraphicsContext3D entry points
commit-queue@webkit.org [Tue, 11 Dec 2012 18:46:09 +0000 (18:46 +0000)]
[chromium] Remove deprecated WebGraphicsContext3D entry points
https://bugs.webkit.org/show_bug.cgi?id=104603

Patch by James Robinson <jamesr@chromium.org> on 2012-12-11
Reviewed by Darin Fisher.

* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Clean up unused defaultViewportArguments in RenderThemeBlackBerry.cpp
zhajiang@rim.com [Tue, 11 Dec 2012 18:45:39 +0000 (18:45 +0000)]
[BlackBerry] Clean up unused defaultViewportArguments in RenderThemeBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=104683

Reviewed by Rob Buis.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::determineFullScreenMultiplier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRoute main resource loads through the memory cache.
japhet@chromium.org [Tue, 11 Dec 2012 18:28:26 +0000 (18:28 +0000)]
Route main resource loads through the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=49246

Reviewed by Antti Koivisto.

Source/WebCore:

Note that this patch doesn't actually enable caching of main resources. That will be done in a later patch.
The MainResourceLoader actually has an underlying SubresourceLoader (with the cache layer between them).
In several places, the MainResourceLoader's SubresourceLoader is treated as special.

No new tests, as this is primarily a refactor. A couple of expected results changed slightly.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setRequest):
(WebCore::DocumentLoader::subresource):
(WebCore::DocumentLoader::addSubresourceLoader): Because the SubresourceLoader underlying the main resource
    needs special handling in certain cases, track it separately from the real SubresourceLoaders.
(WebCore::DocumentLoader::removeSubresourceLoader):
(WebCore::DocumentLoader::startLoadingMainResource):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::cancel):
(WebCore::MainResourceLoader::clearResource):
(WebCore):
(WebCore::MainResourceLoader::frameLoader):
(WebCore::MainResourceLoader::request):
(WebCore::MainResourceLoader::continueAfterNavigationPolicy):
(WebCore::MainResourceLoader::resourceData):
(WebCore::MainResourceLoader::redirectReceived):
(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::continueAfterContentPolicy):
(WebCore::MainResourceLoader::responseReceived):
(WebCore::MainResourceLoader::dataReceived):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::notifyFinished):
(WebCore::MainResourceLoader::reportMemoryUsage):
(WebCore::MainResourceLoader::handleSubstituteDataLoadNow):
(WebCore::MainResourceLoader::load):
(WebCore::MainResourceLoader::setDefersLoading):
(WebCore::MainResourceLoader::defersLoading):
(WebCore::MainResourceLoader::setShouldBufferData):
(WebCore::MainResourceLoader::loader):
(WebCore::MainResourceLoader::identifier):
* loader/MainResourceLoader.h:
(MainResourceLoader):
(WebCore::MainResourceLoader::documentLoader):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequest):
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::defersLoading):
(WebCore::ResourceLoader::cancelled):
* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::maybeLoadFallbackForMainResponse):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForMainError):
* loader/mac/DocumentLoaderMac.cpp:
(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):

LayoutTests:

* http/tests/inspector/resource-parameters.html: The main resource's url will exclude the fragment identifier here.
* http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: The error code for loads cancelled
    by an embedder's willSendRequest() will show as standard load cancellations rather than as a content policy
    failure. This was an odd quirk of how MainResourceLoader::willSendRequest() was implemented (namely, doing a
    content policy check on ResourceRequests with empty urls).
* platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: See previous.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate MediaSource to allow append() calls in "ended" state.
acolwell@chromium.org [Tue, 11 Dec 2012 18:23:46 +0000 (18:23 +0000)]
Update MediaSource to allow append() calls in "ended" state.
https://bugs.webkit.org/show_bug.cgi?id=104581

Reviewed by Eric Carlson.

Source/WebCore:

Updated append and setTimestampOffset to allow appending in the "ended" readyState. An append() call
in the "ended" state now triggers a transition to the "open" state and allows the append to succeed.

Tests: http/tests/media/media-source/video-media-source-append-in-ended-state.html
       http/tests/media/media-source/video-media-source-append-with-offset-in-ended-state.html
       http/tests/media/media-source/video-media-source-zero-byte-append-in-ended-state.html

* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::append):
(WebCore::MediaSource::setTimestampOffset):

LayoutTests:

- Removed old test case that verified appending in "ended" state failed.
- Added 3 new test cases that verify append behavior in the "ended" state.

* http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt:
* http/tests/media/media-source/video-media-source-add-and-remove-buffers.html:
* http/tests/media/media-source/video-media-source-append-in-ended-state-expected.txt: Added.
* http/tests/media/media-source/video-media-source-append-in-ended-state.html: Added.
* http/tests/media/media-source/video-media-source-append-with-offset-in-ended-state-expected.txt: Added.
* http/tests/media/media-source/video-media-source-append-with-offset-in-ended-state.html: Added.
* http/tests/media/media-source/video-media-source-zero-byte-append-in-ended-state-expected.txt: Added.
* http/tests/media/media-source/video-media-source-zero-byte-append-in-ended-state.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r121789): Text not wrapping in presence of floating objects
robert@webkit.org [Tue, 11 Dec 2012 18:14:16 +0000 (18:14 +0000)]
REGRESSION(r121789): Text not wrapping in presence of floating objects
https://bugs.webkit.org/show_bug.cgi?id=101803

Reviewed by David Hyatt.

Source/WebCore:

When determining if a line needs to offset to avoid any floats use RenderBlock::lineHeight()
to estimate the height of the line. If the container has floats stacked up with different widths
that straddle the line, using a height of zero will make the first line think it has
more width available than it actually does and it will end up extruding from its container.

The logic for finding the offset of inline blocks and images needs to use a similar heuristic.
So nextLineBreak() now updates the available width if it encounters a replaced element (e.g. inline block,
image) at the start of a line, using the height of the element to decide which floats to avoid.
RenderBlock::computeInlineDirectionPositionsForLine() does the same thing when laying out the line.

Tests: fast/block/float/floats-offset-image-quirk-lineheight.html
       fast/block/float/floats-offset-image-quirk.html
       fast/block/float/floats-offset-image-strict-lineheight.html
       fast/block/float/floats-offset-image-strict.html
       fast/block/float/floats-offset-inline-block-quirk-lineheight.html
       fast/block/float/floats-offset-inline-block-strict-lineheight.html
       fast/block/float/floats-offset-linebox-contain-block.html
       fast/block/float/floats-offset-linebox-contain-inline.html
       fast/block/float/floats-wrap-inside-inline-006.html
       fast/block/float/floats-wrap-inside-inline-007.html

* rendering/RenderBlockLineLayout.cpp:
(LineWidth):
(WebCore::logicalHeightForLine):
    This method needs to cope with the quirk where an image alone on a line will get its descent stripped away so
    ignore the height of the line and use the height of the image in that case.
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::updateLogicalInlinePositions):
(WebCore):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::computeInlineDirectionPositionsForSegment):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

* fast/block/float/floats-offset-image-quirk-expected.html: Added.
* fast/block/float/floats-offset-image-quirk-lineheight-expected.html: Added.
* fast/block/float/floats-offset-image-quirk-lineheight.html: Added.
* fast/block/float/floats-offset-image-quirk.html: Added.
* fast/block/float/floats-offset-image-strict-expected.html: Added.
* fast/block/float/floats-offset-image-strict-lineheight-expected.html: Added.
* fast/block/float/floats-offset-image-strict-lineheight.html: Added.
* fast/block/float/floats-offset-image-strict.html: Added.
* fast/block/float/floats-offset-inline-block-quirk-lineheight-expected.html: Added.
* fast/block/float/floats-offset-inline-block-quirk-lineheight.html: Added.
* fast/block/float/floats-offset-inline-block-strict-lineheight-expected.html: Added.
* fast/block/float/floats-offset-inline-block-strict-lineheight.html: Added.
* fast/block/float/floats-offset-linebox-contain-block-expected.html: Added.
* fast/block/float/floats-offset-linebox-contain-block.html: Added.
* fast/block/float/floats-offset-linebox-contain-inline-expected.html: Added.
* fast/block/float/floats-offset-linebox-contain-inline.html: Added.
* fast/block/float/floats-wrap-inside-inline-006-expected.html: Added.
* fast/block/float/floats-wrap-inside-inline-006.html: Added.
* fast/block/float/floats-wrap-inside-inline-007-expected.html: Added.
* fast/block/float/floats-wrap-inside-inline-007.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] IndexedDB: Memory leak in IDBCallbacksProxy::onSuccess(PassRefPtr<IDBDatab...
jsbell@chromium.org [Tue, 11 Dec 2012 18:13:17 +0000 (18:13 +0000)]
[Chromium] IndexedDB: Memory leak in IDBCallbacksProxy::onSuccess(PassRefPtr<IDBDatabaseBackendInterface>)
https://bugs.webkit.org/show_bug.cgi?id=104615

Reviewed by Tony Chang.

Ensure passed pointer is treated with ownership semantics.

* src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Install GObject DOM bindings headers in its own directory
commit-queue@webkit.org [Tue, 11 Dec 2012 17:58:03 +0000 (17:58 +0000)]
[GTK] Install GObject DOM bindings headers in its own directory
https://bugs.webkit.org/show_bug.cgi?id=104663

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2012-12-11
Reviewed by Gustavo Noronha Silva.

.:

* GNUmakefile.am: Add GENSOURCES_WEBKITDOM and
webkitgtk_gdom_built_h_api variables.

Source/WebCore:

Move the headers from webkit to webkitdom directory.

* bindings/gobject/GNUmakefile.am:
* bindings/gobject/WebKitDOMBinding.h:
* bindings/gobject/WebKitDOMCustom.h:
* bindings/gobject/WebKitDOMEventTarget.h:
* bindings/gobject/WebKitDOMEventTargetPrivate.h:
* bindings/gobject/WebKitDOMObject.h:
* bindings/scripts/CodeGeneratorGObject.pm:
(Generate):
(WriteData):
* bindings/scripts/gobject-generate-headers.pl:
* bindings/scripts/test/GObject/WebKitDOMFloat64Array.h:
* bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
* bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
* bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestException.h:
* bindings/scripts/test/GObject/WebKitDOMTestExceptionPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h:
* bindings/scripts/test/GObject/WebKitDOMTestNamedConstructorPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestNode.h:
* bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.h:
* bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:

Source/WebKit/gtk:

* GNUmakefile.am: Add webkitdom.h.
* webkit/webkitdom.h: Compatibility header just including the new
one.
* webkit/webkitwebframe.cpp: Update includes.
* webkit/webkitwebframe.h: Ditto.
* webkit/webkitwebinspector.cpp: Ditto.
* webkit/webkitwebinspector.h: Ditto.
* webkit/webkitwebview.cpp: Ditto.
* webkit/webkitwebview.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoreIPC: ArgumentEncoder should have an inline buffer.
akling@apple.com [Tue, 11 Dec 2012 17:41:27 +0000 (17:41 +0000)]
CoreIPC: ArgumentEncoder should have an inline buffer.
<http://webkit.org/b/104622>

Reviewed by Anders Carlsson.

Add a 4K inline buffer to CoreIPC::ArgumentEncoder to avoid malloc/free churn.
It was dominating the transient allocations graph in Instruments.

* Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::ArgumentEncoder):
(CoreIPC::ArgumentEncoder::grow):
* Platform/CoreIPC/ArgumentEncoder.h:
(CoreIPC::ArgumentEncoder::buffer):
(ArgumentEncoder):
(CoreIPC::ArgumentEncoder::usesInlineBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Clean up unused interfaces in PlatformSupport
pilgrim@chromium.org [Tue, 11 Dec 2012 17:38:28 +0000 (17:38 +0000)]
[Chromium] Clean up unused interfaces in PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=104674

Reviewed by Darin Fisher.

Source/WebCore:

Part of a refactoring series. See tracking bug 82948. Also, there
were some function declarations that were supposed to be removed
as part of bug 102699 but got left out of the final patch.

* platform/chromium/PlatformSupport.h:
(WebCore):
(PlatformSupport):

Source/WebKit/chromium:

Part of a refactoring series. See tracking bug 82948.

* public/platform/WebKitPlatformSupport.h:
* src/PlatformSupport.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Update GraphicsLayerClutter
commit-queue@webkit.org [Tue, 11 Dec 2012 17:34:15 +0000 (17:34 +0000)]
[GTK] Update GraphicsLayerClutter
https://bugs.webkit.org/show_bug.cgi?id=92045

Patch by Joone Hur  <joone.hur@intel.com>, Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-12-11
Reviewed by Gustavo Noronha Silva.

Add more methods to GraphicsLayerClutter in order to run CSS 3D transforms
by using GraphicsLayerActor.

No new tests. This will be covered by pixel tests for Qt and GTK+ accelerated
compositing and 3D transforms.

* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore):
(WebCore::GraphicsLayerClutter::GraphicsLayerClutter):
(WebCore::idleDestroy):
(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::setName):
(WebCore::GraphicsLayerClutter::platformLayer): Returns the platform layer(ClutterAcotr).
(WebCore::GraphicsLayerClutter::setNeedsDisplay): Update the display.
(WebCore::GraphicsLayerClutter::setNeedsDisplayInRect): Update part of the Display.
(WebCore::GraphicsLayerClutter::setAnchorPoint):
(WebCore::GraphicsLayerClutter::setPosition):
(WebCore::GraphicsLayerClutter::setSize):
(WebCore::GraphicsLayerClutter::setTransform):
(WebCore::GraphicsLayerClutter::setDrawsContent):
(WebCore::GraphicsLayerClutter::setParent):
(WebCore::GraphicsLayerClutter::setChildren):
(WebCore::GraphicsLayerClutter::addChild):
(WebCore::GraphicsLayerClutter::addChildAtIndex):
(WebCore::GraphicsLayerClutter::addChildBelow):
(WebCore::GraphicsLayerClutter::addChildAbove):
(WebCore::GraphicsLayerClutter::replaceChild):
(WebCore::GraphicsLayerClutter::removeFromParent):
(WebCore::GraphicsLayerClutter::platformClutterLayerPaintContents):
(WebCore::GraphicsLayerClutter::platformClutterLayerAnimationStarted):
(WebCore::GraphicsLayerClutter::repaintLayerDirtyRects):
(WebCore::GraphicsLayerClutter::computePositionRelativeToBase):
(WebCore::GraphicsLayerClutter::flushCompositingState): Synchronize the corresponding Actors with the current
compositing states of this GraphicsLayer and its child layers.
(WebCore::GraphicsLayerClutter::recursiveCommitChanges):
(WebCore::GraphicsLayerClutter::flushCompositingStateForThisLayerOnly): Commit batched changes non-recursively.
(WebCore::GraphicsLayerClutter::commitLayerChangesAfterSublayers): Reset layer changes after we recurse on children.
(WebCore::GraphicsLayerClutter::noteSublayersChanged):
(WebCore::GraphicsLayerClutter::noteLayerPropertyChanged):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers): Commit layer changes before we recurse on children.
(WebCore::GraphicsLayerClutter::updateGeometry): Updated the position and size of the Actor.
(WebCore::GraphicsLayerClutter::updateSublayerList): Updated the list of child Actors.
(WebCore::GraphicsLayerClutter::updateLayerNames):
(WebCore::GraphicsLayerClutter::updateTransform):
(WebCore::GraphicsLayerClutter::updateLayerDrawsContent):
(WebCore::GraphicsLayerClutter::layerForSuperlayer):
* platform/graphics/clutter/GraphicsLayerClutter.h:
(WebCore):
(WebCore::GraphicsLayerClutter::primaryLayer):
(GraphicsLayerClutter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Spurious stderr output from the event sender
mrobinson@webkit.org [Tue, 11 Dec 2012 17:16:01 +0000 (17:16 +0000)]
[GTK] Spurious stderr output from the event sender
https://bugs.webkit.org/show_bug.cgi?id=104678

Reviewed by Gustavo Noronha Silva.

Eliminate some spurious stderr output from the EventSender by using an early return
instead of an assertion that prints a warning to the console.

* DumpRenderTree/gtk/EventSender.cpp:
(continuousMouseScrollByCallback): We don't support continuous scroll events that
move by page, but we should just fail silently instead of printing an error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert incorrect build fix.
jberlin@webkit.org [Tue, 11 Dec 2012 17:15:36 +0000 (17:15 +0000)]
Revert incorrect build fix.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAttempt to rebaseline move-by-line-001, which has become less flaky.
adamk@chromium.org [Tue, 11 Dec 2012 17:04:39 +0000 (17:04 +0000)]
Attempt to rebaseline move-by-line-001, which has become less flaky.

Unreviewed gardening.

* platform/chromium-mac-lion/editing/selection/move-by-line-001-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png: Removed.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Update http/tests/multipart results now that we have soup multipart support
commit-queue@webkit.org [Tue, 11 Dec 2012 16:45:24 +0000 (16:45 +0000)]
[EFL] Update http/tests/multipart results now that we have soup multipart support
https://bugs.webkit.org/show_bug.cgi?id=104671

Unreviewed gardening: r137150 added soup multipart support and updated
soup. This makes a few tests green. Also, multipart-wait-before-boundary.html
is a duplicate result with wk2 TestExpectations.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-11

* platform/efl/TestExpectations:
* platform/efl/http/tests/multipart/invalid-image-data-standalone-expected.png: Added.
* platform/efl/http/tests/multipart/invalid-image-data-standalone-expected.txt: Added.
* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the Mac build after r137261
jberlin@webkit.org [Tue, 11 Dec 2012 16:43:26 +0000 (16:43 +0000)]
Fix the Mac build after r137261

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Fixing tests after removing default media stream sport
commit-queue@webkit.org [Tue, 11 Dec 2012 16:27:59 +0000 (16:27 +0000)]
[GTK] Fixing tests after removing default media stream sport
https://bugs.webkit.org/show_bug.cgi?id=104658

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2012-12-11
Reviewed by Philippe Normand.

Updated test expections for fast/js/global-constructors.

* platform/gtk/fast/js/global-constructors-expected.txt: Updated
expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add GraphicsLayerActor
commit-queue@webkit.org [Tue, 11 Dec 2012 16:20:11 +0000 (16:20 +0000)]
[GTK] Add GraphicsLayerActor
https://bugs.webkit.org/show_bug.cgi?id=91940

Source/WebCore:

Patch by Joone Hur  <joone.hur@intel.com>, Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-12-11
Reviewed by Gustavo Noronha Silva.

GraphicsLayerActor, which is a new ClutterActor, represents a node in the GPU-renderable layer tree
when accelerated compositing is enabled with Clutter as acceleration backend.
This patch allows to support basic features of CSS 3D Transforms.

No new tests. This will be covered by pixel tests for Qt and GTK+ accelerated
compositing and 3D transforms.

* GNUmakefile.list.am:
* platform/graphics/clutter/GraphicsLayerActor.cpp: Added.
(_GraphicsLayerActorPrivate):
(graphics_layer_actor_class_init): GObject configuration of a new Clutter Actor.
(graphics_layer_actor_init): Initialization of the private data of this actor.
(graphicsLayerActorSetProperty): GObject property setter.
(graphicsLayerActorGetProperty): GObject property getter.
(graphicsLayerActorDispose): Called to drop all references to other objects.
(graphicsLayerActorAllocate):  Called to set the coordinates of an actor.
(graphicsLayerActorApplyTransform): Applying the transformation to an actor before painting it.
(graphicsLayerActorPaint): Called to paint the actor.
(graphicsLayerActorDraw): Called each time a ClutterCairoTexture has been invalidated.
(graphicsLayerActorAdded): Called each time an actor has been added to container.
(graphicsLayerActorRemoved): Called each time an actor is removed from container.
(graphicsLayerActorNew): Create a specific layer type of GraphicsLayerActor object.
(graphicsLayerActorNewWithClient): Create a specific layer type of GraphicsLayerActor object with
its PlatformClutterClientLayer.
(graphicsLayerActorSetClient): Added setter to set the PlatformClutterClientLayer.
(graphicsLayerActorGetClient): Added getter to get the PlatformClutterClientLayer.
(graphicsLayerActorRemoveAll): Remove all child actors.
(graphicsLayerUpdateTexture): Create a ClutterCairoTexture.
(graphicsLayerActorGetSurface): Added setter to set a cairo_surface_t.
(graphicsLayerActorSetSurface): Added getter to get the cairo_surface_t.
(graphicsLayerActorInvalidateRectangle):
(graphicsLayerActorSetTransform): Set a CoglMatrix to apply matrix transform.
(graphicsLayerActorSetAnchorPoint):
(graphicsLayerActorGetAnchorPoint):
(graphicsLayerActorSetScrollPosition):
(graphicsLayerActorGetnChildren):
(graphicsLayerActorReplaceSublayer):
(graphicsLayerActorInsertSublayer):
(graphicsLayerActorSetSublayers):
(graphicsLayerActorGetLayerType):
(graphicsLayerActorSetLayerType):
(graphicsLayerActorSetTranslateX):
(graphicsLayerActorGetTranslateX):
(graphicsLayerActorSetTranslateY):
(graphicsLayerActorGetTranslateY):
(graphicsLayerActorSetDrawsContent): Added setter to paint content inside a layer.
(graphicsLayerActorGetDrawsContent): Added getter to get the value of the drawsContent.
* platform/graphics/clutter/GraphicsLayerActor.h: Added.
(_GraphicsLayerActor):
(_GraphicsLayerActorClass):
* platform/graphics/clutter/GraphicsLayerClutter.h:
(WebCore):

Tools:

Patch by Joone Hur <joone.hur@intel.com> on 2012-12-11
Reviewed by Gustavo Noronha Silva.

Add GraphicsLayerActor to the list of classes that contain GObjects
in the style checker script so that it does not complain about GObject
coding style.

* Scripts/webkitpy/style/checker.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: ConsoleTypes should not expose MessageType - it should be private...
mkwst@chromium.org [Tue, 11 Dec 2012 16:10:06 +0000 (16:10 +0000)]
Web Inspector: ConsoleTypes should not expose MessageType - it should be private to inspector.
https://bugs.webkit.org/show_bug.cgi?id=66371

Reviewed by Pavel Feldman.

Source/WebCore:

We can simplify console message generation a bit, as nothing outside the
Console object itself will generate messages of any type other than
LogMessageType. This patch refactors the externally-facing API endpoints
on ScriptExecutionContext and Console to drop the MessageType parameter,
moves the MessageType enum into a new InspectorConsoleTypes.h header,
and updates all the call sites (and ChromeClients) to drop the parameter
from their interfaces.

As a temporary bandage for ports using this interface, this patch
includes aliases for the new methods that retain the old interface.
I'll remove them in a future patch.

Here, we only refactor an internal interface. No tests should break.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
    We added a new file! OMG!
* Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):
* Modules/webdatabase/AbstractDatabase.cpp:
(WebCore::AbstractDatabase::logErrorMessage):
* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::setBinaryType):
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::didFailSocketStream):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
* bindings/v8/custom/V8CustomXPathNSResolver.cpp:
(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
* css/MediaList.cpp:
(WebCore::addResolutionWarningMessageToConsole):
* dom/Document.cpp:
(WebCore::Document::logExceptionToConsole):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::addMessage):
* dom/Document.h:
(Document):
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::notifyFinished):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::performTask):
(WebCore::ScriptExecutionContext::addConsoleMessage):
* dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::create):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):
* dom/ViewportArguments.cpp:
(WebCore::reportViewportWarning):
* fileapi/WebKitBlobBuilder.cpp:
(WebCore::BlobBuilder::append):
* html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseAttribute):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::canLoadUrl):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::getImageData):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
* inspector/ConsoleAPITypes.h: Added.
(WebCore):
* inspector/ConsoleMessage.h:
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore):
* inspector/InspectorInstrumentation.h:
* inspector/InspectorProfilerAgent.cpp:
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::addMessageToConsole):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportLocalLoadFailed):
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::notifyFinished):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveResponse):
* loader/MixedContentChecker.cpp:
(WebCore::MixedContentChecker::logWarning):
* loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::corsPolicyPreventedLoad):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::abort):
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::didFail):
(WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::printAccessDeniedMessage):
* page/ChromeClient.h:
(ChromeClient):
    Drop LogMessageType from everywhere.
* page/Console.cpp:
(WebCore::Console::addMessage):
(WebCore::internalAddMessage):
(WebCore::Console::error):
(WebCore::Console::log):
(WebCore::Console::warn):
(WebCore::Console::dir):
(WebCore::Console::dirxml):
(WebCore::Console::clear):
(WebCore::Console::trace):
(WebCore::Console::assertCondition):
* page/Console.h:
(Console):
    Create a new internalAddMessage that's used for the various
    Console message types. Everything else routes through
    ::addMessage.
* page/ConsoleTypes.h:
    Drop MessageTypes from this file, add it to ConsoleAPIType.h
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::logToConsole):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):
(WebCore::DOMWindow::printErrorMessage):
* page/EventSource.cpp:
(WebCore::EventSource::didReceiveResponse):
* svg/SVGDocumentExtensions.cpp:
(WebCore::reportMessage):
* workers/DefaultSharedWorkerRepository.cpp:
(SharedWorkerProxy):
(WebCore::postConsoleMessageTask):
(WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
* workers/SharedWorkerContext.cpp:
(WebCore::SharedWorkerContext::logExceptionToConsole):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::addMessage):
(WebCore::WorkerContext::addMessageToWorkerConsole):
* workers/WorkerContext.h:
(WorkerContext):
* workers/WorkerMessagingProxy.cpp:
(WebCore::postConsoleMessageTask):
(WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
* workers/WorkerMessagingProxy.h:
(WorkerMessagingProxy):
* workers/WorkerReportingProxy.h:
(WorkerReportingProxy):
* xml/XMLHttpRequest.cpp:
(WebCore::logConsoleError):
(WebCore::XMLHttpRequest::send):
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::XSLTProcessor::parseErrorFunc):
* xml/XSLTProcessorQt.cpp:
(WebCore::XSLTMessageHandler::handleMessage):
    Drop LogMessageType from everywhere.

Source/WebKit/blackberry:

Drops WebCore::MessageType from the addMessageToConsole method.

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::addMessageToConsole):
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):

Source/WebKit/chromium:

Drops WebCore::MessageType from the addMessageToConsole method, and all
the ancilliary places it touches.

Aliases postConsoleMessageToWorkerObject with the old interface in
order to maintain back-compat. Will remove it in a future patch once
Chromium is updated.

* public/WebSharedWorkerClient.h:
(WebSharedWorkerClient):
(WebKit::WebSharedWorkerClient::postConsoleMessageToWorkerObject):
* src/ChromeClientImpl.cpp:
* src/ChromeClientImpl.h:
(ChromeClientImpl):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::addMessageToConsole):
* src/WebPagePopupImpl.cpp:
* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postConsoleMessageTask):
* src/WebSharedWorkerImpl.h:
(WebSharedWorkerImpl):
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject):
* src/WebWorkerClientImpl.h:
(WebWorkerClientImpl):

Source/WebKit/efl:

Drops WebCore::MessageType from the addMessageToConsole method.

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::addMessageToConsole):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):

Source/WebKit/gtk:

Drops WebCore::MessageType from the addMessageToConsole method.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::addMessageToConsole):
* WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):

Source/WebKit/mac:

Drops WebCore::MessageType from the addMessageToConsole method.

* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::addMessageToConsole):

Source/WebKit/qt:

Drops WebCore::MessageType from the addMessageToConsole method.

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::addMessageToConsole):
* WebCoreSupport/ChromeClientQt.h:
(ChromeClientQt):

Source/WebKit/win:

Drops WebCore::MessageType from the addMessageToConsole method.

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::addMessageToConsole):
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):

Source/WebKit/wince:

Drops WebCore::MessageType from the addMessageToConsole method.

* WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::addMessageToConsole):
* WebCoreSupport/ChromeClientWinCE.h:
(ChromeClientWinCE):

Source/WebKit2:

Drops WebCore::MessageLevel from the addMessageToConsole method.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::addMessageToConsole):
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed, rolling out r137313 and r137316 because they broke the system-sqlite...
hausmann@webkit.org [Tue, 11 Dec 2012 16:06:11 +0000 (16:06 +0000)]
[Qt] Unreviewed, rolling out r137313 and r137316 because they broke the system-sqlite build.

* WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Qt build fix: Don't error out if SQLITE3SRCDIR isn't set but
hausmann@webkit.org [Tue, 11 Dec 2012 15:57:34 +0000 (15:57 +0000)]
Unreviewed Qt build fix: Don't error out if SQLITE3SRCDIR isn't set but
we have a system sqlite to use.

* WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Call createLocalStorageNamespace through Platform.h
pilgrim@chromium.org [Tue, 11 Dec 2012 15:50:09 +0000 (15:50 +0000)]
[Chromium] Call createLocalStorageNamespace through Platform.h
https://bugs.webkit.org/show_bug.cgi?id=104675

Reviewed by Kentaro Hara.

Some #include cleanup missing from bug 85766. Part of a
refactoring series; see tracking bug 82948.

* src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespace::localStorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] remove hack which avoids unused .obj directories all over the place
hausmann@webkit.org [Tue, 11 Dec 2012 15:46:16 +0000 (15:46 +0000)]
[Qt] remove hack which avoids unused .obj directories all over the place

Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com> on 2012-12-11
Reviewed by Simon Hausmann.

The feature is subject to upstreaming in Qt itself in
https://codereview.qt-project.org/#change,42011

* qmake/mkspecs/features/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] make qtbase source requirement explicit
hausmann@webkit.org [Tue, 11 Dec 2012 15:33:41 +0000 (15:33 +0000)]
[Qt] make qtbase source requirement explicit

Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com> on 2012-12-11
Reviewed by Simon Hausmann.

getting rid of QT.<module>.sources references, as they don't go well
with real modularization.

* WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] move SQLITE3SRCDIR assignment to only use site
hausmann@webkit.org [Tue, 11 Dec 2012 15:30:11 +0000 (15:30 +0000)]
[Qt] move SQLITE3SRCDIR assignment to only use site

Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com> on 2012-12-11
Reviewed by Simon Hausmann.

Target.pri includes WebCore.pri the almost first thing, so that is
covered as well.

Source/WebCore:

* WebCore.pri:

Tools:

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] delete dead include paths
hausmann@webkit.org [Tue, 11 Dec 2012 15:26:23 +0000 (15:26 +0000)]
[Qt] delete dead include paths

Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com> on 2012-12-11
Reviewed by Simon Hausmann.

followup to https://bugs.webkit.org/show_bug.cgi?id=93446

Source/JavaScriptCore:

* JavaScriptCore.pri:

Tools:

* DumpRenderTree/qt/DumpRenderTree.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Implement some missing FrameLoaderClient message in DRT
mrobinson@webkit.org [Tue, 11 Dec 2012 15:21:18 +0000 (15:21 +0000)]
[GTK] Implement some missing FrameLoaderClient message in DRT
https://bugs.webkit.org/show_bug.cgi?id=104444

Reviewed by Gustavo Noronha Silva.

Source/WebKit/gtk:

When in DumpRenderTree mode allow the DRT to install a FrameLoaderEvent callback
for events that we do not expose in the API. This will allow us to share more
results with WebKit2.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setFrameLoadEventCallback): Added.
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
* WebCoreSupport/FrameLoaderClientGtk.cpp: Use the new callback to deliver
events to DRT.

Tools:

Install a FrameLoadEvent callback that prints the necessary output for some
missing FrameLoader events.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(frameLoadEventCallback): Added.
(createWebView): Install the FrameLoader event callback.

LayoutTests:

Unskip a test which is now passing.

* platform/gtk/TestExpectations: Unskip a newly passing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Timeline: rename "Parse" to "Parse HTML".
commit-queue@webkit.org [Tue, 11 Dec 2012 15:18:44 +0000 (15:18 +0000)]
Web Inspector: Timeline: rename "Parse" to "Parse HTML".
https://bugs.webkit.org/show_bug.cgi?id=104639

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-11
Reviewed by Yury Semikhatsky.

"Parse" sounds ambiguous, it could mean JSON.parse() or Date.parse().
"Parse HTML" is a much more clear record description.

* inspector/front-end/TimelinePresentationModel.js: Fix text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
senorblanco@chromium.org [Tue, 11 Dec 2012 15:16:32 +0000 (15:16 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] change setup of QMAKE_MOC
hausmann@webkit.org [Tue, 11 Dec 2012 15:14:13 +0000 (15:14 +0000)]
[Qt] change setup of QMAKE_MOC

Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com> on 2012-12-11
Reviewed by Simon Hausmann.

don't load(moc) explicitly - turns out that this breaks
debug_and_release builds (the feature does not like being loaded before
default_post has been loaded).
so instead just do a minimal call to find the moc executable.

as it's in fact only two files which need it, so de-centralize this call
for the sake of saving some cpu cycles spent in qmake.

Source/WebCore:

* DerivedSources.pri:

Tools:

* WebKitTestRunner/InjectedBundle/DerivedSources.pri:
* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix the linking of debug builds on Mac with force_static_libs_as_shared
jocelyn.turcotte@digia.com [Tue, 11 Dec 2012 14:38:21 +0000 (14:38 +0000)]
[Qt] Fix the linking of debug builds on Mac with force_static_libs_as_shared
https://bugs.webkit.org/show_bug.cgi?id=104559

Reviewed by Tor Arne Vestbø.

"contains(libraries, $$TARGET): return(true)" fails for intermediate libraries since
at this point TARGET may contain the "_debug" suffix.

Fix it by moving the TARGET adjustment later in the file.

* qmake/mkspecs/features/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Increase the timeout of the API unit tests
thiago.santos@intel.com [Tue, 11 Dec 2012 14:21:47 +0000 (14:21 +0000)]
[EFL] Increase the timeout of the API unit tests
https://bugs.webkit.org/show_bug.cgi?id=104666

Reviewed by Kenneth Rohde Christiansen.

Palliative fix until we find out why the tests are taking so long.

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][EFL][WK2] Resizing the window doesn't always result in right content position
kenneth@webkit.org [Tue, 11 Dec 2012 14:11:41 +0000 (14:11 +0000)]
[Qt][EFL][WK2] Resizing the window doesn't always result in right content position
https://bugs.webkit.org/show_bug.cgi?id=104416

Reviewed by Simon Hausmann.

Make sure the client is notified about position and scale changed done by us.
Rename the m_*IsLocked to m_pending*Change as that makes the code more obvious.

Patch verified with both Qt and EFL.

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::didRenderFrame): Notify client and pixel align.
(WebKit::PageViewportController::didChangeContentsVisibility):
(WebKit::PageViewportController::didChangeViewportAttributes):
(WebKit::PageViewportController::applyScaleAfterRenderingContents):
(WebKit::PageViewportController::applyPositionAfterRenderingContents):
* UIProcess/PageViewportController.h:
(PageViewportController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r136948): inspector/styles/import-pseudoclass-crash.html hits an assertion
apavlov@chromium.org [Tue, 11 Dec 2012 14:06:01 +0000 (14:06 +0000)]
REGRESSION(r136948): inspector/styles/import-pseudoclass-crash.html hits an assertion
https://bugs.webkit.org/show_bug.cgi?id=104473

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Avoid building full CSSOM wrappers up front during rule matching.
Instead, move this code down to the point where these wrappers are actually needed.

* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willMatchRule):
(WebCore::InspectorCSSAgent::willProcessRule):
* inspector/InspectorCSSAgent.h:
(WebCore):
(InspectorCSSAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
(WebCore::InspectorInstrumentation::willProcessRuleImpl):

LayoutTests:

* platform/chromium/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKit tests for the Qt API should include tests of CMake config files
hausmann@webkit.org [Tue, 11 Dec 2012 14:03:09 +0000 (14:03 +0000)]
WebKit tests for the Qt API should include tests of CMake config files
https://bugs.webkit.org/show_bug.cgi?id=104003

Patch by Stephen Kelly <stephen.kelly@kdab.com> on 2012-12-11
Reviewed by Simon Hausmann.

The Qt WebKit CI system is not going to run this test, but it can
be run locally and to test packages.

.:

* Source/tests.pri:

Source/WebKit/qt:

* tests/cmake/CMakeLists.txt: Added.
* tests/cmake/cmake.pro: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] Avoid linking to GStreamer video libraries if only using ENABLE_AUDIO
commit-queue@webkit.org [Tue, 11 Dec 2012 13:59:09 +0000 (13:59 +0000)]
[GStreamer] Avoid linking to GStreamer video libraries if only using ENABLE_AUDIO
https://bugs.webkit.org/show_bug.cgi?id=104590

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-12-11
Reviewed by Philippe Normand.

Make getVideoSizeAndFormatFromCaps() only available when ENABLE_VIDEO is set.

No new tests, no change in behavior.

* platform/graphics/gstreamer/GStreamerVersioning.cpp:
* platform/graphics/gstreamer/GStreamerVersioning.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Coverity] [GTK] Remove some redundant null checks in DumpRenderTree
mrobinson@webkit.org [Tue, 11 Dec 2012 13:53:14 +0000 (13:53 +0000)]
[Coverity] [GTK] Remove some redundant null checks in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=104570

Reviewed by Daniel Bates.

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::elementDoesAutoCompleteForElementWithId): Remove a redundant null check.

Tools:

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(descriptionSuitableForTestResult): Remove a redundant null check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnskip some tests that are now passing with the switch to the Harfbuzz backend.
mrobinson@webkit.org [Tue, 11 Dec 2012 13:39:07 +0000 (13:39 +0000)]
Unskip some tests that are now passing with the switch to the Harfbuzz backend.

* platform/gtk/TestExpectations: Unskip some recently passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Mac] Fix transparency for WebGL content.
zeno.albisser@digia.com [Tue, 11 Dec 2012 13:37:34 +0000 (13:37 +0000)]
[Qt][Mac] Fix transparency for WebGL content.
https://bugs.webkit.org/show_bug.cgi?id=104659

When drawing a texture to the TextureMapper the flag SupportsBlending
must be passed in order to allow for transparent webgl content.
We are doing this for GLX already, but the flag was still missing
in GraphicsSurfaceMac.

Reviewed by Kenneth Rohde Christiansen.

* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Support third-party cookie policy for Qt clients
allan.jensen@digia.com [Tue, 11 Dec 2012 13:32:23 +0000 (13:32 +0000)]
[Qt] Support third-party cookie policy for Qt clients
https://bugs.webkit.org/show_bug.cgi?id=45455

Unreviewed fixup.

window.location is not set for http tests in platform, so use a reset function
that doesn't rely on it.

* platform/qt/http/tests/cookies/strict-third-party-cookie-blocking.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused GErrors
commit-queue@webkit.org [Tue, 11 Dec 2012 13:12:57 +0000 (13:12 +0000)]
Remove unused GErrors
https://bugs.webkit.org/show_bug.cgi?id=104657

Patch by Alberto Garcia <agarcia@igalia.com> on 2012-12-11
Reviewed by Martin Robinson.

Replace unused GErrors with null pointers.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeFonts):
* DumpRenderTree/gtk/EditingCallbacks.cpp:
(dumpRange):
* WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::inititializeFontConfigSetting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Duplicate emulated touch events in iframe
apavlov@chromium.org [Tue, 11 Dec 2012 13:00:53 +0000 (13:00 +0000)]
Web Inspector: Duplicate emulated touch events in iframe
https://bugs.webkit.org/show_bug.cgi?id=104653

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Synthetic touch events should be dispatched only on the frame containing its target, not on its ancestor frames,
up to the top frame.

* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
  Do not dispatch a synthetic touch event on the current frame if its target is in a subframe.

LayoutTests:

The test incorrectly expected two synthetic touchend events from an iframe,
while only one touchstart and one touchend should be dispatched.

* fast/events/touch/emulated-touch-iframe-expected.txt:
* fast/events/touch/emulated-touch-iframe.html:
* fast/events/touch/resources/emulated-touch-iframe2.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WebGL] Regression(r137211) WebGL is broken with NVIDIA Drivers.
commit-queue@webkit.org [Tue, 11 Dec 2012 12:54:59 +0000 (12:54 +0000)]
[EFL][WebGL] Regression(r137211) WebGL is broken with NVIDIA Drivers.
https://bugs.webkit.org/show_bug.cgi?id=104652.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-11
Reviewed by Kenneth Rohde Christiansen.

Reverting some of the changes from r137211, as it causes regressions
on NVIDIA drivers.

* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(GraphicsContext3DPrivate::copyToGraphicsSurface):
* platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::updateContents):
* platform/graphics/opengl/GLPlatformSurface.h:
(GLPlatformSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CoordinatedGraphics] Use unsigned integers for UpdateAtlas IDs
christophe.dumez@intel.com [Tue, 11 Dec 2012 12:53:55 +0000 (12:53 +0000)]
[CoordinatedGraphics] Use unsigned integers for UpdateAtlas IDs
https://bugs.webkit.org/show_bug.cgi?id=104654

Reviewed by Kenneth Rohde Christiansen.

UpdateAtlas currently uses *signed* integer type for its identifier.
Due to the way we generate those IDs, it is safer to use *unsigned*
integers. This is because the generated ID will overflow at some
point and the C and C++ language standards say that overflow of a
signed value is undefined behaviour.

This patch switches to unsigned integer type for UpdateAtlas IDs
since unsigned integers are guaranteed to wrap around on overflow.

* Shared/SurfaceUpdateInfo.h:
(SurfaceUpdateInfo):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::createUpdateAtlas):
(WebKit::LayerTreeCoordinatorProxy::removeUpdateAtlas):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::beginContentUpdate):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h:
(CoordinatedTileClient):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::createUpdateAtlas):
(WebKit::LayerTreeCoordinator::removeUpdateAtlas):
(WebKit::LayerTreeCoordinator::beginContentUpdate):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::~UpdateAtlas):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:
(UpdateAtlasClient):
(UpdateAtlas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: follow up to r136974: do not process shortcuts while editing
pfeldman@chromium.org [Tue, 11 Dec 2012 12:45:14 +0000 (12:45 +0000)]
Web Inspector: follow up to r136974: do not process shortcuts while editing
https://bugs.webkit.org/show_bug.cgi?id=104440

Reviewed by Alexander Pavlov.

Currently, typing H while editing node results in corresponding shortcut processing.

* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype.handleShortcut):
(WebInspector.ElementsTreeElement.prototype.onenter):
(WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
(WebInspector.ElementsTreeElement.prototype.dispose):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
(WebInspector.ElementsTreeElement.prototype._editingCancelled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Inspector] Add command for dispatching mouse events.
commit-queue@webkit.org [Tue, 11 Dec 2012 12:27:40 +0000 (12:27 +0000)]
[Inspector] Add command for dispatching mouse events.
https://bugs.webkit.org/show_bug.cgi?id=104074

Patch by Ken Kania <kkania@chromium.org> on 2012-12-11
Reviewed by Yury Semikhatsky.

Platform mouse event coordinates are relative to the containing window,
but the inspector command assumes they follow standard web coordinates,
where the origin is at the top left of the page and y increases as you
go down. We convert the coordinates to the window before constructing
the event. This also fixes the fact that some platforms have flipped
coordinate systems.
Also, update dispatchKeyEvent test to follow simpler dispatchMouseEvent
test.

Source/WebCore:

Test: inspector-protocol/input/dispatchMouseEvent.html

* inspector/Inspector.json:
* inspector/InspectorInputAgent.cpp:
(WebCore::InspectorInputAgent::dispatchMouseEvent):
(WebCore):
* inspector/InspectorInputAgent.h:
(InspectorInputAgent):

LayoutTests:

* inspector-protocol/input/dispatchKeyEvent.html:
* inspector-protocol/input/dispatchMouseEvent-expected.txt: Added.
* inspector-protocol/input/dispatchMouseEvent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip new failing tests.
ossy@webkit.org [Tue, 11 Dec 2012 12:24:02 +0000 (12:24 +0000)]
[Qt] Unreviewed gardening, skip new failing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening
noel.gordon@gmail.com [Tue, 11 Dec 2012 12:19:35 +0000 (12:19 +0000)]
[chromium] Unreviewed gardening

fast/repaint/body-background-image.html
fast/text/font-initial.html

* platform/chromium/TestExpectations: These tests are passing on WIN.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: follow up to r137283: reduce inspector toolbar spacing 1px.
pfeldman@chromium.org [Tue, 11 Dec 2012 12:15:53 +0000 (12:15 +0000)]
Not reviewed: follow up to r137283: reduce inspector toolbar spacing 1px.

* inspector/front-end/inspector.css:
(body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable):
(body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable.toggled-on):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement add64 for SH4 assembler to fix build after r136601
commit-queue@webkit.org [Tue, 11 Dec 2012 12:15:35 +0000 (12:15 +0000)]
Implement add64 for SH4 assembler to fix build after r136601
https://bugs.webkit.org/show_bug.cgi?id=104377

Patch by Julien BRIANCEAU <jbrianceau@nds.com> on 2012-12-11
Reviewed by Zoltan Herczeg.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::add64):
(MacroAssemblerSH4):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Bump the jhbuild libsoup version to fix an authentication issue
mrobinson@webkit.org [Tue, 11 Dec 2012 12:10:06 +0000 (12:10 +0000)]
[GTK] Bump the jhbuild libsoup version to fix an authentication issue
https://bugs.webkit.org/show_bug.cgi?id=104448

Reviewed by Gustavo Noronha Silva.

Tools:

Bump the libsoup version to one from the git repository. This requires updating
GLib as well which in turn requires adjusting the CFLAGS we pass when compiling
the scanobj step of the gtkdoc generation.

* gtk/generate-gtkdoc:
* gtk/jhbuild.modules:

LayoutTests:

* platform/gtk/TestExpectations: Unskip some tests which are now passing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
thiago.santos@intel.com [Tue, 11 Dec 2012 12:05:43 +0000 (12:05 +0000)]
[EFL] Unreviewed gardening.

Added more shadow tests to the list of flaky tests.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactoring: Rename Element::shouldMatchReadOnlySelector and shouldMatchReadWriteSelector
tkent@chromium.org [Tue, 11 Dec 2012 12:01:48 +0000 (12:01 +0000)]
Refactoring: Rename Element::shouldMatchReadOnlySelector and shouldMatchReadWriteSelector
https://bugs.webkit.org/show_bug.cgi?id=104651

Reviewed by Kentaro Hara.

':read-only' and ':read-write' are pseudo classes. They are not
selectors in the context of these functions.  This patch rename them so
that they contain 'pseudo class,' and make them match to an existing
function, matchesFocusPseudoClass.

No new tests. This shouldn't make behavior changes.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
* dom/Element.cpp:
(WebCore::Element::recalcStyle):
(WebCore::Element::matchesReadOnlyPseudoClass):
(WebCore::Element::matchesReadWritePseudoClass):
* dom/Element.h:
(Element):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::matchesReadOnlyPseudoClass):
(WebCore::HTMLInputElement::matchesReadWritePseudoClass):
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::matchesReadOnlyPseudoClass):
(WebCore::HTMLTextAreaElement::matchesReadWritePseudoClass):
* html/HTMLTextAreaElement.h:
(HTMLTextAreaElement):
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::matchesReadOnlyPseudoClass):
(WebCore::SliderThumbElement::matchesReadWritePseudoClass):
* html/shadow/SliderThumbElement.h:
(SliderThumbElement):
* html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::matchesReadOnlyPseudoClass):
(WebCore::SpinButtonElement::matchesReadWritePseudoClass):
* html/shadow/SpinButtonElement.h:
(SpinButtonElement):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isReadOnlyControl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: add more horizontal spacing for toolbar items in docked to bottom...
pfeldman@chromium.org [Tue, 11 Dec 2012 12:00:05 +0000 (12:00 +0000)]
Web Inspector: add more horizontal spacing for toolbar items in docked to bottom mode
https://bugs.webkit.org/show_bug.cgi?id=104655

Reviewed by Alexander Pavlov.

Drive-by increase height to 26px.

* inspector/front-end/inspector.css:
(#toolbar):
(body:not(.show-toolbar-icons) .toolbar-item):
(body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable):
(body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable.toggled-on):
(body.show-toolbar-icons.dock-to-bottom .toolbar-item.toggleable):
(#toolbar-dropdown-arrow):
(#main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed functionality fix for the GTK port.
zandobersek@gmail.com [Tue, 11 Dec 2012 11:45:04 +0000 (11:45 +0000)]
Unreviewed functionality fix for the GTK port.

Enable the MicroData feature support for the GTK port in the FeatureList module.
This feature listing now again affects which features are enabled and which disabled
on the development builds of the GTK port.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse histogram enumeration in Calendar Picker so we can get stats on UI usage
keishi@webkit.org [Tue, 11 Dec 2012 11:36:44 +0000 (11:36 +0000)]
Use histogram enumeration in Calendar Picker so we can get stats on UI usage
https://bugs.webkit.org/show_bug.cgi?id=104646

Reviewed by Kent Tamura.

Use histogram support to get stats on the calendar picker so we can improve the UI.

No new tests.

* Resources/pagepopups/calendarPicker.js:
(CalendarPicker):
(CalendarPicker.prototype.recordAction): Records action to histogram.
(CalendarPicker.prototype.handleToday): Record action.
(CalendarPicker.prototype.handleClear): Ditto.
(YearMonthController.prototype._showPopup): Ditto.
(YearMonthController.prototype._handleYearMonthChange): Ditto.
(YearMonthController.prototype._handleButtonClick): Ditto.
(DaysTable.prototype._handleDayClick): Ditto.
* page/PagePopupController.cpp:
(WebCore::PagePopupController::histogramEnumeration):
(WebCore):
* page/PagePopupController.h:
(PagePopupController):
* page/PagePopupController.idl: Added histogramEnumeration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Support third-party cookie policy for Qt clients
allan.jensen@digia.com [Tue, 11 Dec 2012 11:30:49 +0000 (11:30 +0000)]
[Qt] Support third-party cookie policy for Qt clients
https://bugs.webkit.org/show_bug.cgi?id=45455

Reviewed by Csaba Osztrogonác.

Fix regressed test. The test is now run from it own dir, not the platform independent dir.

* platform/qt/TestExpectations:
* platform/qt/http/tests/cookies/strict-third-party-cookie-blocking.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] MiniBrowser is not built
commit-queue@webkit.org [Tue, 11 Dec 2012 11:10:56 +0000 (11:10 +0000)]
[EFL][WK2] MiniBrowser is not built
https://bugs.webkit.org/show_bug.cgi?id=104629

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-12-11
Reviewed by Gyuyoung Kim.

As we are finding an elementary package in Tools/MiniBrowser/efl/CMakeList.txt since r137203,
we need to check if the package is found in the same place not in the Tools/CMakeList.txt.

* CMakeLists.txt:
* MiniBrowser/efl/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Create a ewk view object with new context for API tests
commit-queue@webkit.org [Tue, 11 Dec 2012 11:08:11 +0000 (11:08 +0000)]
[EFL][WK2] Create a ewk view object with new context for API tests
https://bugs.webkit.org/show_bug.cgi?id=103692

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-12-11
Reviewed by Gyuyoung Kim.

Bug 103229 fixes the issue which PageGroupID increased even though
the EwkView was created with default context. If the Bug 103229 is
resolved, the EwkViews with same context will have same setting preferences.

Currently, WebKit2/EFL API test is creating the ewk view object
with the default context so the setting values set previously may
influence the following tests. So this patch created a ewk view object
with a new context instead of default one.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIsActiveFlag, IsHoverFlag, InActiveChainFlag can be unified.
morrita@google.com [Tue, 11 Dec 2012 10:36:24 +0000 (10:36 +0000)]
IsActiveFlag, IsHoverFlag, InActiveChainFlag can be unified.
https://bugs.webkit.org/show_bug.cgi?id=103697

Reviewed by Ryosuke Niwa.

To save two more NodeFlags bits, this patch inroduces
UserActionElementSet to get IsLinkFlag, IsHoverFlag,
InActiveChainFlag together. These three old flags are replaced by
UserActionElementSet::ElementFlags and UserActionElementSet
collection which tracks elements which are flagged with one of
a ElementFlags.

When marking an element as active for example, WebKit sets
UserActionElementSet::IsActiveFlag to the element and store it
into corresponding element set of the document. This set maintains
marked elements and corresponding flags for each elements.

UserActionElementSet can be seen as a yet another rare data for
these flags. However, the following characteristics of these flags
make adding a new data structure on Document an attractive
alternative:

- UserActionElementSet is maintained for each Document instead of a
  global collecton. This fits element lifetime better.

- The number of elements which have these flags is generally
  small, and a group of elements for each flag is largely overlapped
  due to its nature. This property keeps the set small, and lets
  flag retrieval efficient. On majority of the elements, all these
  flags are false thus the check is done by just checking
  IsInUserActionFlag.

As a bonus, isFocused flag, which was on NodeRareData, is also moved to this model.

No new tests, covered by existing test.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/Document.cpp:
(WebCore::Document::removedLastRef):
(WebCore::Document::updateHoverActiveState):
* dom/Document.h:
(WebCore::Document::userActionElements): Added.
(Document):
* dom/Node.cpp:
(WebCore::Node::detach):
* dom/Node.h:
(WebCore):
(WebCore::Node::isUserActionElement): Added.
(WebCore::Node::setUserActionElement): Added.
(Node):
(WebCore::Node::active): Switched to UserActionElementSet.
(WebCore::Node::inActiveChain): Switched to UserActionElementSet.
(WebCore::Node::hovered): Switched to UserActionElementSet.
(WebCore::Node::focused): Switched to UserActionElementSet.
(WebCore::Node::setFocus): Switched to UserActionElementSet.
(WebCore::Node::setActive): Switched to UserActionElementSet.
(WebCore::Node::setHovered): Switched to UserActionElementSet.
* dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(NodeRareData):
* dom/UserActionElementSet.cpp: Added.
(WebCore):
(WebCore::UserActionElementSet::instanceFor):
(WebCore::UserActionElementSet::UserActionElementSet):
(WebCore::UserActionElementSet::~UserActionElementSet):
(WebCore::UserActionElementSet::didDetach):
(WebCore::UserActionElementSet::documentDidRemoveLastRef):
(WebCore::UserActionElementSet::hasFlags):
(WebCore::UserActionElementSet::setFlags):
(WebCore::UserActionElementSet::clearFlags):
* dom/UserActionElementSet.h: Added.
(WebCore):
(UserActionElementSet):
(WebCore::UserActionElementSet::create):
(WebCore::UserActionElementSet::isFocused):
(WebCore::UserActionElementSet::setFocused):
(WebCore::UserActionElementSet::isActive):
(WebCore::UserActionElementSet::setActive):
(WebCore::UserActionElementSet::isInActiveChain):
(WebCore::UserActionElementSet::setInActiveChain):
(WebCore::UserActionElementSet::isHovered):
(WebCore::UserActionElementSet::setHovered):
(WebCore::UserActionElementSet::setFlags):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r137266.
caseq@chromium.org [Tue, 11 Dec 2012 10:31:17 +0000 (10:31 +0000)]
Unreviewed, rolling out r137266.
http://trac.webkit.org/changeset/137266
https://bugs.webkit.org/show_bug.cgi?id=104071

New test fails on WebKit Win7 and chromium mac

* inspector/profiler/cpu-profiler-profiling-without-inspector-expected.txt:
* inspector/profiler/cpu-profiler-profiling-without-inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoINPUT_MULTIPLE_FIELDS_UI: Disable focus navigation by right/left keys in RTL locales
tkent@chromium.org [Tue, 11 Dec 2012 10:20:05 +0000 (10:20 +0000)]
INPUT_MULTIPLE_FIELDS_UI: Disable focus navigation by right/left keys in RTL locales
https://bugs.webkit.org/show_bug.cgi?id=104644

Reviewed by Hajime Morita.

Source/WebCore:

Pressing the left key should focus on the field at the left of the
current focused field, and pressing the right key should focus on the
field at the right of the current focused field. This works well in LTR
locales.
In RTL locale, the current code doesn't work. We disable this behavior
for RTL locales for now. This issue will be handled in Bug 104650.

No new tests. Update some *-multiple-fields tests for new behavior.

* html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):
If this sub-field is in an RTL locale, we don't change focus.
(WebCore::DateTimeFieldElement::localeForOwner):
Moved from DateTimeNumericFieldElement.
* html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement): Remove isRTL, add localeForOwner.
* html/shadow/DateTimeNumericFieldElement.cpp: Remove localeForOwner.
* html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement): Ditto.

LayoutTests:

* fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt:
* fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt:
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html:
* fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
* fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html:
* fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt:
* fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-12-11 Pavel Podivilov <podivilov@google.com>
podivilov@chromium.org [Tue, 11 Dec 2012 10:06:11 +0000 (10:06 +0000)]
2012-12-11  Pavel Podivilov  <podivilov@google.com>

        [Chromium] Unreviewed, remove "platform/blackberry [ WontFix ]" from test expectations
        to make lint happy.

        * platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 11 Dec 2012 10:02:41 +0000 (10:02 +0000)]
Unreviewed GTK gardening.

Unskip a few test, adding expectations that (should) reflect the actual failure of each test.
Also remove the expectations for the Animation API test. Support for that feature, along with
the test, was removed just recently.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-12-11 Pavel Podivilov <podivilov@google.com>
podivilov@chromium.org [Tue, 11 Dec 2012 09:59:40 +0000 (09:59 +0000)]
2012-12-11  Pavel Podivilov  <podivilov@google.com>

        Remove pango files deleted at r137263 form WebCore.gypi.

        Unreviewed, gardening.

        * WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][jhbuild] Switch to GStreamer 1.0 build
philn@webkit.org [Tue, 11 Dec 2012 09:42:32 +0000 (09:42 +0000)]
[GTK][jhbuild] Switch to GStreamer 1.0 build
https://bugs.webkit.org/show_bug.cgi?id=91727

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2012-12-11
Reviewed by Philippe Normand.

Switch build-webkit --gtk to GStreamer 1.0 support and build the
necessary GStreamer git modules from JHBuild.

.:

* configure.ac: Removed GStreamer unstable API flag, made
GStreamer 1.0 default instead of 0.10 and made required version
1.0.3. In case no GStreamer version is specified, it falls back to
0.10. In case no video or web-audio are requested, GStreamer
and Farstream checks are not performed.

Tools:

* gtk/jhbuild.modules: Added GStreamer 1.0.3 build support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Feature enabling/disabling should be possible through build-webkit
zandobersek@gmail.com [Tue, 11 Dec 2012 09:37:28 +0000 (09:37 +0000)]
[GTK] Feature enabling/disabling should be possible through build-webkit
https://bugs.webkit.org/show_bug.cgi?id=99271

Reviewed by Gustavo Noronha Silva.

.:

The autogen.sh script now calls the Tools/gtk/override-feature-defines script
before calling autoreconf. This ensures that Source/WebCore/GNUmakefile.features.am
is present and properly modified if the build-webkit script intends to override
any feature.

The Source/WebCore/GNUmakefile.features.am file is added to the ignored files list
so it doesn't pop out as a new, untracked file.

* .gitignore:
* autogen.sh:

Source/WebCore:

Move the contents of GNUmakefile.features.am into GNUmakefile.features.am.in.
The former is then copied from the latter but then appropriately modified if
the build-webkit script overrides any of the default feature defines.

No new tests - no new testable functionality.

* GNUmakefile.features.am.in: Renamed from Source/WebCore/GNUmakefile.features.am.

Tools:

Refactor the code in webkitdirs.pm that builds an autotools project to generate
autogen.sh arguments, make arguments and installation prefix from the passed-in
parameters rather than generating all of that in build-webkit. The autogen.sh
arguments now contain only enable/disable flags for options that are actually
configurable in configure.ac, the flag value actually reflecting whether the feature
is enabled or disabled in the feature list.

Other features are overridable through modifying the GNUmakefile.features.am file.
All these features are now stored in the build directory and upon change trigger
a rerun of the autogen.sh script, pretty much like the autogen.sh arguments do.

The override-feature-defines script is called by autogen.sh, before GNUmakefile.in is
generated when calling autoreconf. Its task is to copy the GNUmakefile.features.am.in
into GNUmakefile.features.am and modify it if there's a text file in the build directory
that contains all the feature defines the build-webkit script has written. If the build
is not done through build-webkit (and there's no file in build directory listing all the
feature defines) the script does not advance further from copying.

This approach is taken to overcome the rigidness of the automake system as it's impossible
to effectively generate and use GNUmakefile.features.am or even GNUmakefile.features file
after the autoreconf command execution in autogen.sh.

* Scripts/build-jsc:
(buildMyProject):
* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary):
(mustReRunAutogen):
(buildAutotoolsProject):
(buildGtkProject):
* Scripts/webkitperl/FeatureList.pm: Update the features that are currently enabled in
Source/WebCore/GNUmakefile.features.am.in but aren't in the feature list.
* Scripts/webkitpy/style/checker.py: Source/WebCore/GNUmakefile.features.am.in is recognized
as a text file and tabulation errors are reported. Skip the file to suppress them.
* gtk/override-feature-defines: Added.
(copy_feature_defines_makefile):
(adjust_feature_defines_makefile):
(adjust_feature_defines_makefile.override_feature_define):
(override_feature_defines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening
zandobersek@gmail.com [Tue, 11 Dec 2012 09:29:20 +0000 (09:29 +0000)]
Unreviewed GTK gardening

Adding failure expectations for tests that regressed in r137198 and in r137159-r137161 range.
Removing failure expectations for the SVG viewspec tests that now pass.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[QT][EFL][WK2] Move the GraphicsSurfaceGLX.cpp to common place
commit-queue@webkit.org [Tue, 11 Dec 2012 09:29:07 +0000 (09:29 +0000)]
[QT][EFL][WK2] Move the GraphicsSurfaceGLX.cpp to common place
https://bugs.webkit.org/show_bug.cgi?id=104433

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-12-11
Reviewed by Kenneth Rohde Christiansen.

QT and EFL are commonly using the GraphicsSurfaceGLX.cpp and
it looks better to move this file to /glx directory.

* PlatformEfl.cmake:
* Target.pri:
* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp.
(WebCore):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(WebCore::OffScreenRootWindow::getXWindow):
(WebCore::OffScreenRootWindow::display):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::textureIsYInverted):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::glxPixmap):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::resolveGLMethods):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromTexture):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformSize):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Evaluate private browsing mode's effect on console messages.
mkwst@chromium.org [Tue, 11 Dec 2012 09:17:59 +0000 (09:17 +0000)]
Web Inspector: Evaluate private browsing mode's effect on console messages.
https://bugs.webkit.org/show_bug.cgi?id=104383

Reviewed by Pavel Feldman.

Source/WebCore:

Two sets of console messages are currently gated on private browsing
mode being inactive. This patch centralizes the private browsing checks
in order to apply them equally to all console messages, and changes the
granularity at which they act.

The current checks block the console messages entirely. This patch
blocks only notifications to ChromeClient and ensures that messages
won't be passed to printf where they might end up in system logs.
Notifications to InspectorInstrumentation seem safe; so far as I can
tell, there's no compelling reason to prevent console-based debugging
in private browsing mode. This patch excludes those calls from the
private browsing check.

Test: inspector/console/clients-ignored-in-privatebrowsing.html

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::printAccessDeniedMessage):
    Drop the private browsing check.
* page/Console.cpp:
(WebCore::Console::addMessage):
    Add private browsing checks to the two ::addMessage variants that
    do real work. Ensure that calls to printf and notifications to
    ChromeClients are gated on these checks, but always allow
    notifications to InspectorInstrumentation.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::printErrorMessage):
    Drop the private browsing check.

LayoutTests:

* inspector/console/clients-ignored-in-privatebrowsing-expected.txt: Added.
* inspector/console/clients-ignored-in-privatebrowsing.html: Added.
* platform/chromium/TestExpectations:
    Skip this test on Chromium, as that port doesn't use PrivateBrowsing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: better coverage for inspector/profiler/cpu-profiler-profiling-without...
caseq@chromium.org [Tue, 11 Dec 2012 09:15:43 +0000 (09:15 +0000)]
Web Inspector: better coverage for inspector/profiler/cpu-profiler-profiling-without-inspector.html
https://bugs.webkit.org/show_bug.cgi?id=104071

Reviewed by Pavel Feldman.

Extended test by spinning several function for a total of 400ms to provide coverage for sampling profiler.

* inspector/profiler/cpu-profiler-profiling-without-inspector-expected.txt:
* inspector/profiler/cpu-profiler-profiling-without-inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Soup] Fix spelling of "initiating" in API.
danw@gnome.org [Tue, 11 Dec 2012 09:11:24 +0000 (09:11 +0000)]
[Soup] Fix spelling of "initiating" in API.

Reviewed by Martin Robinson.

Source/WebCore:

No new tests (just internal renaming).

* platform/network/ResourceHandle.h:
(ResourceHandle):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore):
(WebCore::setSoupRequestInitiatingPageIDFromNetworkingContext):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::getSoupRequestInitiatingPageID):

Source/WebKit2:

* WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestManager::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions] Clean-up style for 2 regions expected results files
mihnea@adobe.com [Tue, 11 Dec 2012 09:09:33 +0000 (09:09 +0000)]
[CSSRegions] Clean-up style for 2 regions expected results files
https://bugs.webkit.org/show_bug.cgi?id=104572

Reviewed by Tony Chang.

Remove Win line endings, remove unnecessary spaces and close all html tags.

* fast/regions/positioned-objects-block-static-spanning-regions-expected.html:
* fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Remove the Pango backend
mrobinson@webkit.org [Tue, 11 Dec 2012 09:05:54 +0000 (09:05 +0000)]
[GTK] Remove the Pango backend
https://bugs.webkit.org/show_bug.cgi?id=104569

Reviewed by Daniel Bates.

.:

Always look for Freetype and Harfbuzz. We still depend on Pango for a few
things, so we cannot yet eliminate our dependency on Pango.

* configure.ac: Always look for FreeType/Harfbuzz.

Source/WebCore:

Remove the Pango backend entirely. The EFL build has no support for it and it's
not really maintained enough for the GTK+ port, now that HarfbuzzNG shapes complex
text when Freetype is the active text rendering backend.

No new tests. This does not change behavior.

* GNUmakefile.am: Remove Pango backend options and move Freetype options to the common list.
* GNUmakefile.list.am: Ditto.
* platform/graphics/FontPlatformData.h:
* platform/graphics/pango/FontCachePango.cpp: Removed.
* platform/graphics/pango/FontCustomPlatformDataPango.cpp: Removed.
* platform/graphics/pango/FontPango.cpp: Removed.
* platform/graphics/pango/FontPlatformData.h: Removed.
* platform/graphics/pango/FontPlatformDataPango.cpp: Removed.
* platform/graphics/pango/GlyphPageTreeNodePango.cpp: Removed.
* platform/graphics/pango/PangoUtilities.cpp: Removed.
* platform/graphics/pango/PangoUtilities.h: Removed.
* platform/graphics/pango/SimpleFontDataPango.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [WebGL] prevent GC from collecting WebGLObject instances currently...
aandrey@chromium.org [Tue, 11 Dec 2012 08:58:03 +0000 (08:58 +0000)]
Web Inspector: [WebGL] prevent GC from collecting WebGLObject instances currently bound to the context state
https://bugs.webkit.org/show_bug.cgi?id=104119

Reviewed by Pavel Feldman.

This is to prevent GC from collecting resources bound to a context (WebGL or 2D).
Otherwise, for example in WebGL, subsequent calls to gl.getParameter() may return a recently created
instance that is no longer bound to a Resource object (thus, no history to replay it later).

* inspector/InjectedScriptCanvasModuleSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMemory instrumentation: make sure each edge is reported only once
yurys@chromium.org [Tue, 11 Dec 2012 08:32:58 +0000 (08:32 +0000)]
Memory instrumentation: make sure each edge is reported only once
https://bugs.webkit.org/show_bug.cgi?id=104630

Reviewed by Pavel Feldman.

Source/JavaScriptCore:

Changed exported symbols for MemoryInstrumentation.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Source/WTF:

Make sure that outgoing edges are reported only once if we come to the same
object twice: first by an address of a base class and then by a real address
of the object.

* wtf/MemoryInstrumentation.cpp:
(WTF::MemoryInstrumentation::MemoryInstrumentation):
(WTF::MemoryInstrumentation::reportLinkToBuffer):
(WTF::MemoryInstrumentation::InstrumentedPointerBase::InstrumentedPointerBase):
(WTF::MemoryInstrumentation::InstrumentedPointerBase::process):
(WTF::MemoryClassInfo::init):
(WTF::MemoryClassInfo::addRawBuffer):
(WTF::MemoryClassInfo::addPrivateBuffer):
* wtf/MemoryInstrumentation.h:
(InstrumentedPointerBase):
(MemoryInstrumentation):
(InstrumentedPointer):
(WTF::MemoryClassInfo::MemoryClassInfo):
(WTF::MemoryClassInfo::addMember):
(MemoryClassInfo):
(WTF::::InstrumentedPointer):
(WTF::::callReportMemoryUsage):
* wtf/MemoryObjectInfo.h:
(WTF::MemoryObjectInfo::MemoryObjectInfo):
(WTF::MemoryObjectInfo::firstVisit):
(WTF::MemoryObjectInfo::className):
(WTF::MemoryObjectInfo::name):
(WTF::MemoryObjectInfo::setAlreadyVisited):
(MemoryObjectInfo):

Tools:

Test that outgoing edges are reported only once if we come to the same
object twice: first by an address of a base class and then by a real address
of the object.

* TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix after r137243.
zandobersek@gmail.com [Tue, 11 Dec 2012 08:05:47 +0000 (08:05 +0000)]
Unreviewed build fix after r137243.

* bindings/gobject/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening
christophe.dumez@intel.com [Tue, 11 Dec 2012 07:49:12 +0000 (07:49 +0000)]
[chromium] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=84432

fast/filesystem/op-restricted-names.html
fast/filesystem/op-restricted-unicode.html
fast/filesystem/read-directory.html
fast/filesystem/simple-readonly-file-object.html

Patch by Noel Gordon <noel.gordon@gmail.com> on 2012-12-10

* platform/chromium/TestExpectations: These have been passing on WIN for over a month.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove WebCompositorFrame(Ack) as these classes are not needed now that...
danakj@chromium.org [Tue, 11 Dec 2012 07:46:32 +0000 (07:46 +0000)]
[chromium] Remove WebCompositorFrame(Ack) as these classes are not needed now that they are passed through cc::OutputSurface.
https://bugs.webkit.org/show_bug.cgi?id=104635

Reviewed by James Robinson.

These have been supplanted by cc::CompositorFrame(Ack) which do not
need to inherit from them.

* chromium/public/WebCompositorFrame.h: Removed.
* chromium/public/WebCompositorFrameAck.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening
noel.gordon@gmail.com [Tue, 11 Dec 2012 07:46:20 +0000 (07:46 +0000)]
[chromium] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=84432

fast/filesystem/op-restricted-names.html
fast/filesystem/op-restricted-unicode.html
fast/filesystem/read-directory.html
fast/filesystem/simple-readonly-file-object.html

* platform/chromium/TestExpectations: These have been passing on WIN for over a month.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove WebCompositorOutputSurface implementations from DRT
danakj@chromium.org [Tue, 11 Dec 2012 07:45:17 +0000 (07:45 +0000)]
[chromium] Remove WebCompositorOutputSurface implementations from DRT
https://bugs.webkit.org/show_bug.cgi?id=104046

Reviewed by Darin Fisher.

Source/Platform:

Remove now-unused definitions for these classes. The cc::OutputSurface
and its related classes have replaced these, with the
WebCompositorOutputSurface class as an empty base class.

* Platform.gypi:
* chromium/public/WebCompositorOutputSurface.h:
(WebKit):
* chromium/public/WebCompositorOutputSurfaceClient.h: Removed.
* chromium/public/WebCompositorSoftwareOutputDevice.h: Removed.

Source/WebKit/chromium:

Use WebCompositorSupport to create an OutputSurface.

* WebKit.gypi:
* src/WebViewImpl.cpp:
(WebKit):
* tests/Canvas2DLayerBridgeTest.cpp:
* tests/FakeWebCompositorOutputSurface.h: Removed.
* tests/WebLayerTreeViewTestCommon.h:

Tools:

The classes are now provided through WebCompositorSupport.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createOutputSurface):
* DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Removed.
* DumpRenderTree/chromium/WebViewHostOutputSurface.h: Removed.
* DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp: Removed.
* DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Add a user default to limit the number of web processes
ap@apple.com [Tue, 11 Dec 2012 07:33:01 +0000 (07:33 +0000)]
[WK2] Add a user default to limit the number of web processes
https://bugs.webkit.org/show_bug.cgi?id=104606

Reviewed by Sam Weinig.

When the limit is reached, we'll reuse an existing process with fewest pages.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Initialize m_webProcessCountLimit.
(WebKit::WebContext::platformInitialize): Added a hook for reading the preference,
empty implementation on most platforms.
(WebKit::WebContext::createNewWebProcess): Changed to return a raw pointer. The new
process is put into a vector anyway, so there is no ownership transfer.
(WebKit::WebContext::warmInitialProcess): Don't create a new process if that would
exceed the limit.
(WebKit::WebContext::createNewWebProcessRespectingProcessCountLimit): Added a new
function that wither creates a new process, or picks an existing one.
(WebKit::WebContext::createWebPage): Call the above new function instead of
unconditionally creating a process.

* UIProcess/WebContext.h: createNewWebProcess is no private. All clients should
respect the process count limit.

* UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reattachToWebProcess):
Respect the process count limit.

* UIProcess/mac/WebContextMac.mm:
(WebKit::registerUserDefaultsIfNeeded): Register the new default.
(WebKit::WebContext::platformInitialize): Read the default into a WebContext
member variable.
(WebKit::WebContext::platformInitializeWebProcess): Moved registerUserDefaultsIfNeeded()
from here to platformInitialize(), as that's a better place for it. Also added a
FIXME for an unrelated issue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Tue, 11 Dec 2012 07:31:17 +0000 (07:31 +0000)]
Unreviewed EFL gardening.

Rebaseline fast/js/global-constructors.html after r137243.

* platform/efl/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening
noel.gordon@gmail.com [Tue, 11 Dec 2012 07:20:52 +0000 (07:20 +0000)]
[chromium] Unreviewed gardening

Mark platform/chromium/virtual/deferred/fast/images/pdf-as-image-landscape.html WontFix.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening: rebase fast/repaint/body-background-image.html on...
noel.gordon@gmail.com [Tue, 11 Dec 2012 07:02:55 +0000 (07:02 +0000)]
[chromium] Unreviewed gardening: rebase fast/repaint/body-background-image.html on linux

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening: rebase fast/text/font-initial.html on linux
noel.gordon@gmail.com [Tue, 11 Dec 2012 06:57:46 +0000 (06:57 +0000)]
[chromium] Unreviewed gardening: rebase fast/text/font-initial.html on linux

* platform/chromium-linux/fast/text/font-initial-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r137006): CSS clip on solid color composited div broken
commit-queue@webkit.org [Tue, 11 Dec 2012 06:44:15 +0000 (06:44 +0000)]
REGRESSION (r137006): CSS clip on solid color composited div broken
https://bugs.webkit.org/show_bug.cgi?id=104604

Patch by No'am Rosenthal <noam@webkit.org> on 2012-12-10
Reviewed by Simon Fraser.

Source/WebCore:

Disable direct compositing of background color for clipping layers.

Test: compositing/geometry/clip-inside.html

* rendering/RenderLayerBacking.cpp:
(WebCore::supportsDirectBoxDecorationsComposition):
    Never allow direct background composition if there is a clip.

LayoutTests:

Added a new test (by Simon Fraser) to make sure background color doesn't break clipping.

* compositing/geometry/clip-inside-expected.txt: Added.
* compositing/geometry/clip-inside.html: Added.
* compositing/geometry/clip-expected:
        New result.

* platform/chromium/compositing/geometry/clip-inside-expected.txt
        Adjust Chromium expected result for new test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening after http://trac.webkit.org/changeset/137243
noel.gordon@gmail.com [Tue, 11 Dec 2012 06:07:15 +0000 (06:07 +0000)]
[chromium] Unreviewed gardening after trac.webkit.org/changeset/137243

* platform/chromium/TestExpectations: Remove animations test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: REGRESSION (r137215): WebKit stretches and shrinks a part of screen...
simon.fraser@apple.com [Tue, 11 Dec 2012 05:54:06 +0000 (05:54 +0000)]
Source/WebCore: REGRESSION (r137215): WebKit stretches and shrinks a part of screen on scroll
https://bugs.webkit.org/show_bug.cgi?id=104626

Reviewed by Beth Dakin.

r137215 removed a compositing layer repaint on size changes. However, there
are cases where the compositing code constrains layer size by clipping
with the viewport and a clipping ancestor. When that happens, we must
invalidate the layer on a size change to avoid showing stretched or
shrunken content.

Test: compositing/repaint/clipped-layer-size-change.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):

LayoutTests: REGRESSION(r137215): WebKit stretches and shrinks a part of screen on scroll
https://bugs.webkit.org/show_bug.cgi?id=104626

Reviewed by Beth Dakin.

Testcase that scrolls an overflow area containing a compositing layer.

* compositing/repaint/clipped-layer-size-change-expected.html: Added.
* compositing/repaint/clipped-layer-size-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't OSR exit just because a string is a rope
fpizlo@apple.com [Tue, 11 Dec 2012 05:22:49 +0000 (05:22 +0000)]
Don't OSR exit just because a string is a rope
https://bugs.webkit.org/show_bug.cgi?id=104621

Reviewed by Michael Saboff.

Slight SunSpider speed-up at around the 0.7% level. This patch does the obvious
thing of calling a slow path to resolve ropes rather than OSR exiting if the
string is a rope.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::getIndexedPropertyStorageMayTriggerGC):
(ArrayMode):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::putStructureStoreElimination):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERTION failed in Windows: css3/css3-modsel-33.html
commit-queue@webkit.org [Tue, 11 Dec 2012 05:17:49 +0000 (05:17 +0000)]
ASSERTION failed in Windows: css3/css3-modsel-33.html
https://bugs.webkit.org/show_bug.cgi?id=104472

Patch by Xueqing Huang <huangxueqing@baidu.com> on 2012-12-10
Reviewed by Tim Horton.

In WebFrameLoaderClient::dispatchDidLayout, milestones maybe
DidFirstLayout & DidFirstVisualNonEmptyLayout, we should
use seperate COMPtrs for the two cases rather than reuse one.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange Tab's affiliation in ChangeLog on recent patch.
dino@apple.com [Tue, 11 Dec 2012 04:44:19 +0000 (04:44 +0000)]
Change Tab's affiliation in ChangeLog on recent patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] fast/dom/HTMLMeterElement/meter-boundary-values.html is flaky
noel.gordon@gmail.com [Tue, 11 Dec 2012 04:31:59 +0000 (04:31 +0000)]
[chromium] fast/dom/HTMLMeterElement/meter-boundary-values.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=104625

Unreviewed HTMLMeterElement/meter-boundary-values.html rebaselines.

* platform/chromium-mac-lion/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
* platform/efl-wk1/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Renamed from LayoutTests/platform/efl/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137244 268f45cc-cd09-0410-ab3c-d52691b4dbfc