12 years agoFix fast/forms/form-post-urlencoded.html.
hausmann@webkit.org [Fri, 18 Jan 2008 10:53:45 +0000 (10:53 +0000)]
Fix fast/forms/form-post-urlencoded.html.

Post requests on files don't really make sense, but for
fast/forms/form-post-urlencoded.html we still need to retrieve the file,
which means we map it to a Get instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Fri, 18 Jan 2008 10:37:50 +0000 (10:37 +0000)]
Simon Hausmann <hausmann@webkit.org>

Make QNetworkReplyHandler::abort() more robust against multiple invocations.

During DRT runs I see cancel() being called on the same handle multiple times. Guard
against this a bit better by setting m_reply to 0 after we called abort() on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Fri, 18 Jan 2008 10:37:33 +0000 (10:37 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Ask the WebCore::IconDatabase only if our URL is not empty. Otherwise
  we will see a crash in a HashSet.
* It is crashing there because the StringImpl of an empty String is 0.
* We avoid this crash by checking for isEmpty() in WebKit as there is no
  use to ask the iconDatabase for an empty string. We will fallback to the

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Fri, 18 Jan 2008 10:37:18 +0000 (10:37 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* httpBody() can return 0 and other ports (cf/mac) check for this condition
* Looking at the cf/mac implementation we might need to call setHTTPBody somewhere
  as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPrasanth Ullattil <prasanth.ullattil@trolltech.com>
hausmann@webkit.org [Fri, 18 Jan 2008 09:46:07 +0000 (09:46 +0000)]
Prasanth Ullattil <prasanth.ullattil@trolltech.com>

Fix compilation in Win64(3): Due to the size of size_t cast the return value explicitly to double() to make sure the right Value() constructor is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPrasanth Ullattil <prasanth.ullattil@trolltech.com>
hausmann@webkit.org [Fri, 18 Jan 2008 09:45:52 +0000 (09:45 +0000)]
Prasanth Ullattil <prasanth.ullattil@trolltech.com>

Fix compilation on Win64(2): Implemented currentThreadStackBase on X86-64 on Windows

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPrasanth Ullattil <prasanth.ullattil@trolltech.com>
hausmann@webkit.org [Fri, 18 Jan 2008 09:45:09 +0000 (09:45 +0000)]
Prasanth Ullattil <prasanth.ullattil@trolltech.com>

Fix compilation on Win64(1): Define WTF_PLATFORM_X86_64 correctly on Win64.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Remove our windowClipRect reimplementation and instead have our own
hausmann@webkit.org [Fri, 18 Jan 2008 09:37:14 +0000 (09:37 +0000)]
* Remove our windowClipRect reimplementation and instead have our own
  Widget::invalidate implementation that is invalidating
  IntRect(0, 0, width(), height()) without trying to clip it (in contrast
  to Widget::invalidateRect)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Change the coordinate transformation in the PlatformMouseEvent handlers
hausmann@webkit.org [Fri, 18 Jan 2008 09:36:57 +0000 (09:36 +0000)]
* Change the coordinate transformation in the PlatformMouseEvent handlers
* We want to convert from coordinates of the containing window to our local
  position on the scrollbar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Make the qDebug more usable. Do not have an additional newline and print
hausmann@webkit.org [Fri, 18 Jan 2008 09:36:42 +0000 (09:36 +0000)]
* Make the qDebug more usable. Do not have an additional newline and print
  the untranslated coordinates as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Dead code, remove it
hausmann@webkit.org [Fri, 18 Jan 2008 09:36:27 +0000 (09:36 +0000)]
* Dead code, remove it

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Coding-Style fixes.
hausmann@webkit.org [Fri, 18 Jan 2008 09:36:11 +0000 (09:36 +0000)]
* Coding-Style fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Coding-Style fix
hausmann@webkit.org [Fri, 18 Jan 2008 09:35:50 +0000 (09:35 +0000)]
* Coding-Style fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ggaren@apple.com [Fri, 18 Jan 2008 04:05:21 +0000 (04:05 +0000)]
    Reviewed by Darin Adler.

        Fixed: lots of WebCore leaks reported when quitting Safari

        If we're quitting with a GC still scheduled, do the GC before quitting.
        That way, WebCore's leak counters won't count objects that were
        scheduled for GC.

        * bindings/js/GCController.cpp:
        * bindings/js/GCController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-01-17 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 18 Jan 2008 03:29:28 +0000 (03:29 +0000)]
2008-01-17  Alp Toker  <alp@atoker.com>

        Reviewed by Oliver Hunt.

        gdk_screen_get_font_options() returns NULL if no default options are
        set so we always have to NULL check to avoid crashes later on since
        Cairo doesn't accept NULL font options.

        * platform/graphics/gtk/FontPlatformDataGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adele.
antti@apple.com [Fri, 18 Jan 2008 01:58:09 +0000 (01:58 +0000)]
    Reviewed by Adele.

        Windows fix for <rdar://problem/5605682>
        Disallow streaming protocols for media elements
        and <rdar://problem/5668711>
        Limit the container and codec types that the <video> tag supports

        - Disable unsupported QuickTime tracks types.
        - Disallow streaming protocols (for now).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit/win:
sfalken@apple.com [Fri, 18 Jan 2008 01:14:33 +0000 (01:14 +0000)]

        Build fix.

        * WebKit.vcproj/WebKit.make:


        Build fix.

        * Drosera/DroseraWin.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-01-17 Stephanie <slewis@apple.com>
slewis@apple.com [Fri, 18 Jan 2008 01:14:17 +0000 (01:14 +0000)]
2008-01-17  Stephanie  <slewis@apple.com>


        Move some new failing tests to the skipped list

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added Vista crash logging information.
sfalken@apple.com [Fri, 18 Jan 2008 00:34:45 +0000 (00:34 +0000)]
    Added Vista crash logging information.

        Reviewed by Adam.

        * quality/crashlogs.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSupport smart copy and paste during drag and drop
oliver@apple.com [Fri, 18 Jan 2008 00:21:42 +0000 (00:21 +0000)]
Support smart copy and paste during drag and drop

Reviewed by Alice

In order for the drag and drop tests in Windows DRT to pass
we need to support smart cut and paste operations during
drag and drop on windows.

There is no layout test as drag and drop is still unsupported
on windows.  Once supported smart drag/drop is tested by existing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin
sullivan@apple.com [Fri, 18 Jan 2008 00:10:52 +0000 (00:10 +0000)]
    Reviewed by Darin

        - fixed <rdar://problem/5692068> -1 WebFrameView world leaks reported after closing view source window

        * WebView/WebFrameView.mm:
        (-[WebFrameView initWithCoder:]):
        override to bump the global WebFrameView count

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * Scripts/run-webkit-tests: Fixed a bug number.
darin@apple.com [Thu, 17 Jan 2008 23:58:45 +0000 (23:58 +0000)]
    * Scripts/run-webkit-tests: Fixed a bug number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5692940> Crash when attempting to get text properties in SVG with...
oliver@apple.com [Thu, 17 Jan 2008 21:33:13 +0000 (21:33 +0000)]
<rdar://problem/5692940> Crash when attempting to get text properties in SVG with no renderer

Reviewed by Anders

We use the element renderer to calculate the text element bounds,
however there was no check against the possibility of the text dimension
properties being requested on a element with no renderer (eg. unattached,
display: none).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver.
andersca@apple.com [Thu, 17 Jan 2008 21:05:33 +0000 (21:05 +0000)]
    Reviewed by Oliver.

        CrashTracer: [USER] 1302 crashes in Safari at com.apple.WebCore: WTF::Vector<char, 0ul>::reserveCapacity + 78

        When loading full-frame plug-ins, disable buffering data for the main resource loader. Otherwise, this can cause us
        to crash when loading large files such as movies in the browser. We already do this for embedded plug-ins.

        * WebCore.base.exp:
        * loader/DocumentLoader.h:
        New accessor method.

        * loader/PluginDocument.cpp:
        Disable buffering for the main resource loader.

        * loader/ResourceLoader.cpp:
        * loader/ResourceLoader.h:
        Have this free the buffer when disabling buffering.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Windows build.
antti@apple.com [Thu, 17 Jan 2008 20:45:08 +0000 (20:45 +0000)]
    Fix Windows build.

        * kjs/regexp_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago More Qt/GTK+ build fixing.
aroben@apple.com [Thu, 17 Jan 2008 20:39:39 +0000 (20:39 +0000)]
    More Qt/GTK+ build fixing.

        * platform/gtk/ScrollViewGtk.cpp:
        * platform/qt/ScrollViewQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Thu, 17 Jan 2008 20:06:06 +0000 (20:06 +0000)]
    Reviewed by Darin.

        <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html fails when run after

        Test: fast/dom/Window/window-property-shadowing_.html

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Clear the frame name, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
ap@webkit.org [Thu, 17 Jan 2008 19:50:17 +0000 (19:50 +0000)]
    Reviewed by Adam Roben.

        run-webkit-tests complains about missing FindSafari.exe

        * Scripts/webkitdirs.pm: Append _debug as appropriate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
weinig@apple.com [Thu, 17 Jan 2008 19:27:33 +0000 (19:27 +0000)]
    Reviewed by Darin.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=16901
        Convert remaining JS function objects to use the new PrototypeFunction class

        - Moves Boolean, Function, RegExp, Number, Object and Global functions to their
          own static function implementations so that they can be used with the
          PrototypeFunction class.  SunSpider says this is 1.003x as fast.

        * kjs/JSGlobalObject.cpp:
        * kjs/array_object.h:
        * kjs/bool_object.cpp:
        * kjs/bool_object.h:
        * kjs/error_object.cpp:
        * kjs/error_object.h:
        * kjs/function.cpp:
        * kjs/function.h:
        * kjs/function_object.cpp:
        * kjs/function_object.h:
        * kjs/number_object.cpp:
        * kjs/number_object.h:
        * kjs/object_object.cpp:
        * kjs/object_object.h:
        * kjs/regexp_object.cpp:
        * kjs/regexp_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoName the test for a recent bug fix.
mitz@apple.com [Thu, 17 Jan 2008 19:23:54 +0000 (19:23 +0000)]
Name the test for a recent bug fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Qt/GTK+ build fix.
aroben@apple.com [Thu, 17 Jan 2008 19:06:55 +0000 (19:06 +0000)]
    Qt/GTK+ build fix.

        * platform/gtk/ScrollViewGtk.cpp:
        * platform/qt/ScrollViewQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Thu, 17 Jan 2008 18:55:06 +0000 (18:55 +0000)]
    Reviewed by Dave Hyatt.

        - make more test pass on Windows by using @font-face to force font
          fallback to match Mac OS X.

        * editing/deleting/5144139-2.html:
        * fast/encoding/invalid-UTF-8.html:
        * fast/events/updateLayoutForHitTest.html:
        * fast/forms/select-visual-hebrew.html:
        * fast/forms/select-writing-direction-natural.html:
        * fast/forms/visual-hebrew-text-field.html:
        * fast/text/in-rendered-text-rtl.html:
        * fast/text/international/bidi-L2-run-reordering.html:
        * fast/text/international/bidi-LDB-2-CSS.html:
        * fast/text/international/bidi-LDB-2-HTML.html:
        * fast/text/international/bidi-LDB-2-formatting-characters.html:
        * fast/text/international/bidi-european-terminators.html:
        * fast/text/international/bidi-ignored-for-first-child-inline.html:
        * fast/text/international/bidi-innertext.html:
        * fast/text/international/bidi-listbox-atsui.html:
        * fast/text/international/bidi-listbox.html:
        * fast/text/international/bidi-menulist.html:
        * fast/text/international/bidi-override.html:
        * fast/text/international/resources: Added.
        * fast/text/international/resources/Mac-compatible-font-fallback.css: Added.
        * fast/text/international/rtl-caret.html:
        * platform/mac/editing/deleting/5144139-2-expected.txt:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * platform/win/Skipped: Added another failure.
aroben@apple.com [Thu, 17 Jan 2008 17:46:24 +0000 (17:46 +0000)]
    * platform/win/Skipped: Added another failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Trigger activation changes at the right time by listening for WM_NCACTIVATE
aroben@apple.com [Thu, 17 Jan 2008 17:46:02 +0000 (17:46 +0000)]
     Trigger activation changes at the right time by listening for WM_NCACTIVATE

         This is the final part of <rdar://5006915> Inactive look for Aqua

         WebView now listens to messages sent to its top-level parent window.
         When the top-level parent receives a WM_NCACTIVATE message, WebView
         recalculates whether it is contained within the current active window.

         Reviewed by Darin.

         * Interfaces/IWebViewPrivate.idl:
         (IWebViewPrivate::windowAncestryDidChange): Added. WebKit clients
         should call this when they change the parent window chain of a
         * WebView.cpp:
         (WebView::WebView): Initialize new member.
         (findTopLevelParent): Added.
             - Separated activation handling from focus handling, now that
               activation handling is taken care of by updateActiveState
             - Compare top-level parents in our WM_KILLFOCUS handler so that we
               really know if focus is staying inside our top-level window.
             - Update our active state on WM_WINDOWPOSCHANGED.
             - Added a WM_TIMER handler.
         (WebView::initWithFrame): Call windowAncestryDidChange after setting
         up our HWND as a child of the host window.
         (WebView::windowReceivedMessage): Added. Update our active state when
         our top-level parent receives a WM_NCACTIVATE message.
         (WebView::updateActiveStateSoon): Added.
         (WebView::setHostWindow): Call windowAncestryDidChange after changing
         the host window.
         (WebView::updateActiveState): We are active if our top-level parent is
         the same as the top-level parent of the active window.
         (WebView::windowAncestryDidChange): Added. Recalculates our top-level
         parent and registers as a listener for the new top-level parent's
         * WebView.h: Made WebView and WindowMessageListener so that it can
         utilize WindowMessageBroadcaster to listen to its top-level parent's

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate scroll bars/form controls when FocusController::isActive changes
aroben@apple.com [Thu, 17 Jan 2008 17:45:31 +0000 (17:45 +0000)]
Update scroll bars/form controls when FocusController::isActive changes


        Update scroll bars/form controls when FocusController::isActive changes

        Part of <rdar://5006915> Inactive look for Aqua controls

        Reviewed by Darin.

        All tests pass.

        * page/FocusController.cpp:
        (WebCore::FocusController::setActive): Update control tints when the
        active state changes.
        * page/FrameView.cpp:
        (WebCore::FrameView::updateControlTints): On Windows, we have to ask
        ScrollView to paint so that the outermost scroll bars will paint. On
        Mac, the outermost scroll bars are taken care of by NSScroller.
        * platform/PopupMenu.h: Updated for ScrollBarClient changes.
        * platform/ScrollBar.h: Added a new ScrollBarClient method.
        * platform/win/PlatformScrollBarSafari.cpp:
        (WebCore::PlatformScrollbar::paint): Invalidate when updating control
        tints so that we can paint with the new tint later.
        (WebCore::PlatformScrollbar::paintButton): Pass the active state down
        to SafariTheme.
        (WebCore::PlatformScrollbar::paintTrack): Ditto.
        (WebCore::PlatformScrollbar::paintThumb): Ditto.
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::ScrollViewPrivate::isActive): Added.
        (WebCore::ScrollView::paint): Pass paint calls on down if we're
        updating control tints so the scroll bars can invalidate.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::isActive): Added.
        * rendering/RenderLayer.h:
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::isActive): Added.
        * rendering/RenderListBox.h:
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::isActive): Added.
        * rendering/RenderTheme.h:
        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::determineState): Pass the active state
        down to SafariTheme.


        Updated for ScrollBarClient changes

        Reviewed by Darin.

        * WebScrollBar.h:
        (WebScrollBar::isActive): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMove focused/active state from Frame to SelectionController/FocusController
aroben@apple.com [Thu, 17 Jan 2008 17:44:35 +0000 (17:44 +0000)]
Move focused/active state from Frame to SelectionController/FocusController


        Move focused/active state from Frame to SelectionController/FocusController

        This is the first part of <rdar://5006915> Inactive look for Aqua

        The following methods were moved/renamed:
            - Frame::setIsActive -> FocusController::setActive
            - Frame::isActive -> SelectionController::isActiveAndFocused
            - Frame::setWindowHasFocus -> SelectionController::setFocused

        Active state is now correctly a Page-level concept.

        The Mac parts of this patch were written by Darin.

        Reviewed by Darin.

        All tests pass.

        * WebCore.base.exp: Updated for method renames.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::checkOneSelector): Ditto.
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::SelectionController): Initialize new
        (WebCore::SelectionController::focusedOrActiveStateChanged): New
        private method. Most of this code came from Frame::setIsActive.
        (WebCore::SelectionController::pageActivationChanged): Added.
        (WebCore::SelectionController::setFocused): Added. Replaces
        (WebCore::SelectionController::isFocusedAndActive): Added. Replaces
        * editing/SelectionController.h:
        * page/FocusController.cpp:
        (WebCore::FocusController::FocusController): Initialize new member.
        (WebCore::FocusController::setFocusedFrame): Changed to just call
        SelectionController::setFocused, since active state has doesn't change
        when the focused frame changes.
        (WebCore::FocusController::setActive): Added. Replaces
        * page/FocusController.h:
        (WebCore::FocusController::isActive): Added.
        * page/Frame.cpp:
        (WebCore::Frame::setDocument): Updated for method renames.
        (WebCore::Frame::setFocusedNodeIfNeeded): Ditto.
        (WebCore::Frame::updateSecureKeyboardEntryIfActive): Ditto.
        (WebCore::FramePrivate::FramePrivate): Removed initialization of
        removed members.
        * page/Frame.h:
        * page/FramePrivate.h:
        * page/mac/WebCoreFrameBridge.h: Removed -selectionColor.
        * page/mac/WebCoreFrameBridge.mm: Ditto.
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintItemForeground): Updated for method
        (WebCore::RenderListBox::paintItemBackground): Ditto.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::selectionBackgroundColor): Ditto.
        (WebCore::RenderObject::selectionForegroundColor): Ditto.
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::capsLockStateMayHaveChanged): Ditto.
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::isFocused): Ditto.


        Updated for renames/removal of WebCore methods.

        Reviewed by Darin.

        * Plugins/WebPluginController.mm:
        (-[WebPluginController webPlugInContainerSelectionColor]): Changed to
        ask isFocusedAndActive directly, instead of going through the frame
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _updateActiveState]): Updated for method renames.


        Updated for changes to WebCore methods

        Focus and active state are now handled (somewhat) separately. Future
        patches will further separate these concepts.

        Reviewed by Darin.

        * WebView.cpp:
        (WebViewWndProc): Updated for method renames.
        (WebView::updateActiveState): Only change the active state here. Focus
        is handled inside WM_SETFOCUS and WM_KILLFOCUS message handlers.


        Updated for WebCore method renames.

        Reviewed by Darin.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Re-add DEBUG_WEBKIT_HAS_SUFFIX.
sfalken@apple.com [Thu, 17 Jan 2008 16:20:25 +0000 (16:20 +0000)]

        Rubber-stamped by Jon Honeycutt.

        * DumpRenderTree/win/DumpRenderTree.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Make the nice 'safari' feature work on our port. When viewing a single image, clicking
hausmann@webkit.org [Thu, 17 Jan 2008 15:54:45 +0000 (15:54 +0000)]
* Make the nice 'safari' feature work on our port. When viewing a single image, clicking
  on the image will zoom it.
* It seems like our platform can only determine the size of the image once it is completely
  loaded. Call m_doc->imageChanged on the last chunk of data as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMinor documentation fixes
hausmann@webkit.org [Thu, 17 Jan 2008 15:53:05 +0000 (15:53 +0000)]
Minor documentation fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix form elements not focusing correctly after the qt widget lost its focus.
hausmann@webkit.org [Thu, 17 Jan 2008 15:51:13 +0000 (15:51 +0000)]
Fix form elements not focusing correctly after the qt widget lost its focus.

When receiving a focus out event notify the focus controller. Otherwise its
m_focusedFrame variable remains unchanged and setFocusedFrame on a focusIn
event shortcuts and doesn't call setActive(true).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLots of updates to the documentation.
hausmann@webkit.org [Thu, 17 Jan 2008 15:44:53 +0000 (15:44 +0000)]
Lots of updates to the documentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded a urlChanged signals to QWebFrame and QWebView.
hausmann@webkit.org [Thu, 17 Jan 2008 14:06:12 +0000 (14:06 +0000)]
Added a urlChanged signals to QWebFrame and QWebView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed docs and sanity checks in QWebSettings::setIconDatabaseEnabled
hausmann@webkit.org [Thu, 17 Jan 2008 14:05:19 +0000 (14:05 +0000)]
Fixed docs and sanity checks in QWebSettings::setIconDatabaseEnabled

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded QWebView::createWindow() which is forwarded from QWebPage::createWindow() for...
hausmann@webkit.org [Thu, 17 Jan 2008 14:04:35 +0000 (14:04 +0000)]
Added QWebView::createWindow() which is forwarded from QWebPage::createWindow() for convenience.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSet the library version of QtWebKit to the Qt version.
hausmann@webkit.org [Thu, 17 Jan 2008 14:03:51 +0000 (14:03 +0000)]
Set the library version of QtWebKit to the Qt version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoadd a 0 pointer check.
hausmann@webkit.org [Thu, 17 Jan 2008 14:03:08 +0000 (14:03 +0000)]
add a 0 pointer check.

Fixes a crash in the demo web browser.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix QWebFrame::title().
hausmann@webkit.org [Thu, 17 Jan 2008 13:03:37 +0000 (13:03 +0000)]
Fix QWebFrame::title().

For the titleChanged() signal we use the documentloader's title. For the property we have to use the same
instead of Document::title() as the latter is not trimmed and not suited for a window caption.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRe-enable gzip compression as accepted encoding, now that the bug is fixed in Qt...
hausmann@webkit.org [Thu, 17 Jan 2008 13:01:35 +0000 (13:01 +0000)]
Re-enable gzip compression as accepted encoding, now that the bug is fixed in Qt 4.4's network module.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-01-17 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Thu, 17 Jan 2008 12:07:32 +0000 (12:07 +0000)]
2008-01-17  Simon Hausmann  <hausmann@webkit.org>

        Another Windows build fix, setCookies accidentially had a const
        Document pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-01-17 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Thu, 17 Jan 2008 11:48:18 +0000 (11:48 +0000)]
2008-01-17  Simon Hausmann  <hausmann@webkit.org>

        MSVC Windows build fix. Forward declaring Document in CookieJar.h
        seems not enough for MSVC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttp://bugs.webkit.org/show_bug.cgi?id=16589
hausmann@webkit.org [Thu, 17 Jan 2008 11:37:37 +0000 (11:37 +0000)]

Add a document parameter to WebCore::cookies, setCookies and cookiesEnabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows build fix.
hausmann@webkit.org [Thu, 17 Jan 2008 10:45:21 +0000 (10:45 +0000)]
Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix linking on MinGW and at least one MSVC platform by having gmtimeQt in the correct...
hausmann@webkit.org [Thu, 17 Jan 2008 10:04:41 +0000 (10:04 +0000)]
Fix linking on MinGW and at least one MSVC platform by having gmtimeQt in the correct namespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDon't link QtWebKit against libQtXml when building against Qt 4.4.
hausmann@webkit.org [Thu, 17 Jan 2008 10:01:39 +0000 (10:01 +0000)]
Don't link QtWebKit against libQtXml when building against Qt 4.4.

This is not necessary anymore since QXmlStream has been moved into QtCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFollow QWidget::keyPressEvent advice and call parents.
hausmann@webkit.org [Thu, 17 Jan 2008 09:49:47 +0000 (09:49 +0000)]
Follow QWidget::keyPressEvent advice and call parents.

Without this, Back does not work in Qtopia, for example.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix compilation on arm
hausmann@webkit.org [Thu, 17 Jan 2008 09:49:18 +0000 (09:49 +0000)]
Fix compilation on arm

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix compilation against Qt 4.3 after the recent KURL <> QUrl conversion fixes.
hausmann@webkit.org [Thu, 17 Jan 2008 09:48:47 +0000 (09:48 +0000)]
Fix compilation against Qt 4.3 after the recent KURL <> QUrl conversion fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix compilation against Qt 4.4 without files that are specific for the Qt 4.3 build.
hausmann@webkit.org [Thu, 17 Jan 2008 09:48:16 +0000 (09:48 +0000)]
Fix compilation against Qt 4.4 without files that are specific for the Qt 4.3 build.

Signed-off-by: Holger
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes compilation with MinGW.
hausmann@webkit.org [Thu, 17 Jan 2008 09:46:55 +0000 (09:46 +0000)]
Fixes compilation with MinGW.

Neither localtime_r nor localtime_s are available on MingW, so instead of
calling back to the thread-unsafe localtime use QDateTime instead.

Signed-off-by: Simon Hausmann <hausmann@webkit.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes compilation with QT_NO_DRAGANDDROP
hausmann@webkit.org [Thu, 17 Jan 2008 09:44:23 +0000 (09:44 +0000)]
Fixes compilation with QT_NO_DRAGANDDROP

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix compilation
hausmann@webkit.org [Thu, 17 Jan 2008 09:16:26 +0000 (09:16 +0000)]
Fix compilation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 17 Jan 2008 09:04:20 +0000 (09:04 +0000)]

        Reviewed by Dave Hyatt.

        - fix determinePitch for segmented fonts

        Covered by and existing test.

        * platform/graphics/FontFallbackList.cpp:
        (WebCore::FontFallbackList::determinePitch): If the primary font is
        segmented, treat as fixed pitch only if it has only one segment
        and that segment is fixed-pitch.


        Reviewed by Dave Hyatt.

        - update results for fixing determinePitch for segmented fonts

        * platform/mac/fast/css/font-face-implicit-local-font-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add preprocessor define accidently dropped in my unification,
sfalken@apple.com [Thu, 17 Jan 2008 08:27:19 +0000 (08:27 +0000)]
    Add preprocessor define accidently dropped in my unification,
        and required by some builds.  Fixes an issue that caused both
        debug and release DLLs to be loaded.

        Rubber-stamped by Jon Honeycutt.

        * win/tools/vsprops/debug_internal.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Thu, 17 Jan 2008 06:20:16 +0000 (06:20 +0000)]

        Fix for http://bugs.webkit.org/show_bug.cgi?id=16611

        Make sure vertical-align length values are offset from their parents rather than being absolute to the

        Reviewed by olliej

        Added fast/css/vertical-align-lengths.html

        * rendering/RenderObject.cpp:


       Fix for http://bugs.webkit.org/show_bug.cgi?id=16611

       Reviewed by olliej

        * ChangeLog:
        * fast/css/vertical-align-lengths.html: Added.
        * platform/mac/fast/css/vertical-align-lengths-expected.checksum: Added.
        * platform/mac/fast/css/vertical-align-lengths-expected.png: Added.
        * platform/mac/fast/css/vertical-align-lengths-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 17 Jan 2008 06:13:21 +0000 (06:13 +0000)]

        Reviewed by Dave Hyatt.

        - fix for @font-face rules with unicode-range: always use a local font where not
          explicitly overlaid.

        Test: fast/css/font-face-implicit-local-font.html

        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule): Changed to insert an implicit
        @font-face rule with the local font the matches the family and description before
        any explicit @font-face rules that overlay specific ranges of the same font.
        * css/CSSSegmentedFontFace.h:
        (WebCore::CSSSegmentedFontFace::numRanges): Addded.


        Reviewed by Dave Hyatt.

        - add test for @font-face rules with unicode-range: always use a local
          font where not explicitly overlaid.

        * fast/css/font-face-implicit-local-font.html: Added.
        * platform/mac-leopard/fast/css/font-face-implicit-local-font-expected.checksum: Added.
        * platform/mac-leopard/fast/css/font-face-implicit-local-font-expected.png: Added.
        * platform/mac/fast/css/font-face-implicit-local-font-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago <rdar://problem/5097419> Cursor flickers when over window resizer
sfalken@apple.com [Thu, 17 Jan 2008 02:53:13 +0000 (02:53 +0000)]
    <rdar://problem/5097419> Cursor flickers when over window resizer

        Reviewed by Sam.

        * WebView.cpp:
        (WebViewWndProc): Don't set the resize cursor when over the non-border resize area.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-01-16 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 17 Jan 2008 02:27:31 +0000 (02:27 +0000)]
2008-01-16  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        [GTK] API: Should this entry point be called go_back rather than go_backward?

        Obsolete 'backward' terminology in API in favour of 'back'. Introduce
        step-based back/forward functions.

        Document more functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Tiger build.
antti@apple.com [Thu, 17 Jan 2008 01:11:25 +0000 (01:11 +0000)]
    Fix Tiger build.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add tests for unsupported types to Windows skip list for now.
antti@apple.com [Thu, 17 Jan 2008 00:45:03 +0000 (00:45 +0000)]
    Add tests for unsupported types to Windows skip list for now.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
antti@apple.com [Thu, 17 Jan 2008 00:34:50 +0000 (00:34 +0000)]

        Reviewed by Adele.

        OS X fix for <rdar://problem/5605682>
        Disallow streaming protocols for media elements
        and <rdar://problem/5668711>
        Limit the container and codec types that the <video> tag supports

        - Disable unsupported QuickTime tracks types.
        - Disallow streaming protocols (for now).
        - Set QTMovie QTMoviePreventExternalURLLinksAttribute and QTSecurityPolicyNoCrossSiteAttribute
          to limit QuickTime's access to external resources.

        Windows patch coming up.

        Tests: media/broken-video.html

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:


        Reviewed by Adele.

        Tests for <rdar://problem/5605682>
        Disallow streaming protocols for media elements
        and <rdar://problem/5668711>
        Limit the container and codec types that the <video> tag supports

        - test that rtsp: protocol is disabled (for now).
        - test that QuickTime files with unsupported track types are handled correctly
        - test that broken video file produces an error

        * media/broken-video-expected.txt: Added.
        * media/broken-video.html: Added.
        * media/content/garbage.mp4: Added.
        * media/content/unsupported_track.mov: Added.
        * media/unsupported-rtsp-expected.txt: Added.
        * media/unsupported-rtsp.html: Added.
        * media/unsupported-tracks-expected.txt: Added.
        * media/unsupported-tracks.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-01-16 Rodney Dawes <dobey@wayofthemonkey.com>
alp@webkit.org [Thu, 17 Jan 2008 00:15:49 +0000 (00:15 +0000)]
2008-01-16  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Alp Toker.

        Add shared plugins directory to INCLUDE path

        Add the plugins directory to INCLUDEPATH

        * GNUmakefile.am:
        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Use recommended security-related compiler settings.
sfalken@apple.com [Wed, 16 Jan 2008 23:59:42 +0000 (23:59 +0000)]
    Use recommended security-related compiler settings.

        Reviewed by Adam.

        * win/tools/vsprops/common.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
ggaren@apple.com [Wed, 16 Jan 2008 23:54:28 +0000 (23:54 +0000)]
    Reviewed by Sam Weinig.

        Added a debug counter for SQL transactions. This helped me debug an SQL

        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        * bindings/js/JSCustomSQLTransactionCallback.h:

        * bindings/js/kjs_window.cpp: Removed a silly comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam and Dan
sullivan@apple.com [Wed, 16 Jan 2008 23:36:44 +0000 (23:36 +0000)]
    Reviewed by Adam and Dan

        - cleaned up some existing logging

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView setNeedsDisplay:]):
        add method name to log, use "YES" and "NO" instead of (int)flag
        (-[WebHTMLView setNeedsLayout:]):
        (-[WebHTMLView setNeedsToApplyStyles:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
mjs@apple.com [Wed, 16 Jan 2008 23:16:53 +0000 (23:16 +0000)]

        Reviewed by Maciej & Darin.

        Fixes Bug 16868: Gmail crash
          and Bug 16871: Crash when loading apple.com/startpage



        Adds ActivationImp tear-off for cross-window eval() and fixes an
        existing garbage collection issue exposed by the ActivationImp tear-off
        patch (r29425) that can occur when an ExecState's m_callingExec is
        different than its m_savedExec.

        * kjs/ExecState.cpp:
        * kjs/function.cpp:


        Reviewed by Maciej.

        Added a test that checks whether ActivationImp tear-off occurs before
        a cross-window eval(). Relevant to

        Bug 16868: Gmail crash


        * fast/js/window-eval-tearoff-expected.txt: Added.
        * fast/js/window-eval-tearoff.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver.
weinig@apple.com [Wed, 16 Jan 2008 22:31:17 +0000 (22:31 +0000)]
    Reviewed by Oliver.

        Clean up MathObjectImp, it needed a little scrubbing.

        * kjs/math_object.cpp:
        * kjs/math_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Update layout tests after fix for <rdar://problem/5681647>.
hyatt@apple.com [Wed, 16 Jan 2008 22:13:24 +0000 (22:13 +0000)]
    Update layout tests after fix for <rdar://problem/5681647>.

        * platform/mac/tables/mozilla/bugs/bug101674-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug2973-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug57828-2-expected.txt:
        * platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Wed, 16 Jan 2008 21:56:43 +0000 (21:56 +0000)]

        Fix for http://bugs.webkit.org/show_bug.cgi?id=14846, cell padding can't be changed dynamically.

        Reviewed by Eric Seidel

        Added fast/table/dynamic-cellpadding.html

        * html/HTMLTableElement.cpp:
        * rendering/RenderTable.cpp:
        * rendering/RenderTable.h:


        Reviewed by Eric Seidel


        * fast/table/dynamic-cellpadding.html: Added.
        * platform/mac/fast/table/dynamic-cellpadding-expected.checksum: Added.
        * platform/mac/fast/table/dynamic-cellpadding-expected.png: Added.
        * platform/mac/fast/table/dynamic-cellpadding-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoffrey Garen.
weinig@apple.com [Wed, 16 Jan 2008 21:53:11 +0000 (21:53 +0000)]
    Reviewed by Geoffrey Garen.

        Rename Lexer variable bol to atLineStart.

        * kjs/lexer.cpp:
        * kjs/lexer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoffrey Garen and Anders Carlsson.
weinig@apple.com [Wed, 16 Jan 2008 21:50:19 +0000 (21:50 +0000)]
    Reviewed by Geoffrey Garen and Anders Carlsson.

        Remove uses of KJS_PURE_ECMA as we don't ever build with it defined,
        and we have many features that are not included in the ECMA spec.

        * kjs/lexer.cpp:
        * kjs/lexer.h:
        * kjs/string_object.cpp:
        * kjs/string_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix for <rdar://problem/5681647> Item pages on http://www.stendmarsofa.com...
hyatt@apple.com [Wed, 16 Jan 2008 21:27:30 +0000 (21:27 +0000)]
    Fix for <rdar://problem/5681647> Item pages on stendmarsofa.com/ hang Safari

        This regression was caused by an attempt to implement a WinIE quirk in RenderBlock::calcInlinePrefWidths.
        The original patch introduced pathological O(n^2) behavior into this function even when the quirk didn't need
        to apply.  In addition the quirk was only partially implemented (the full quirk did not care what was adjacent
        to images and also needed bidi.cpp patched, since the quirk applies both when computing pref widths and when
        laying out).

        This new patch rewrites the quirk to be complete.  The original test case attached to the bug that tested a variety
        of image/text combinations now fully matches WinIE.

        Reviewed by Beth

        Added fast/table/unbreakable-images-quirk.html

        * rendering/RenderBlock.cpp:
        * rendering/bidi.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoI don't know what happened here. It did not commit with my checkin.
hyatt@apple.com [Wed, 16 Jan 2008 21:24:21 +0000 (21:24 +0000)]
I don't know what happened here. It did not commit with my checkin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix after r29488
aroben@apple.com [Wed, 16 Jan 2008 21:22:46 +0000 (21:22 +0000)]
    Windows build fix after r29488

        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
        Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
        expects to find the plugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Beth.
hyatt@apple.com [Wed, 16 Jan 2008 21:20:53 +0000 (21:20 +0000)]
    Reviewed by Beth.

        <rdar://problem/5681647> Item pages on http://www.stendmarsofa.com/ hang Safari

        * fast/table/unbreakable-images-quirk.html: Added.
        * platform/mac/fast/table/unbreakable-images-quirk-expected.checksum: Added.
        * platform/mac/fast/table/unbreakable-images-quirk-expected.png: Added.
        * platform/mac/fast/table/unbreakable-images-quirk-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-01-16 Rodney Dawes <dobey@wayofthemonkey.com>
jhoneycutt@apple.com [Wed, 16 Jan 2008 21:13:56 +0000 (21:13 +0000)]
2008-01-16  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Jon Honeycutt

        Move isPluginBlacklisted to PluginPackageWin.cpp, to avoid
        a circular dependency on PluginDatabaseWin
        Remove the getFileVersion method, and just check the versions directly
        in isPluginBlacklisted, as it was the only caller


        * plugins/win/PluginDatabaseWin.cpp:
        * plugins/win/PluginDatabaseWin.h:
        * plugins/win/PluginPackageWin.cpp:
        * plugins/win/PluginPackageWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
mitz@apple.com [Wed, 16 Jan 2008 17:14:44 +0000 (17:14 +0000)]
    Reviewed by Adam Roben.

        - copied Windows expected results for
          svg/hixie/viewbox/preserveAspectRatio/001.xml from Tiger

        * platform/win/svg: Added.
        * platform/win/svg/hixie: Added.
        * platform/win/svg/hixie/viewbox: Added.
        * platform/win/svg/hixie/viewbox/preserveAspectRatio: Added.
        * platform/win/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttp://bugs.webkit.org/show_bug.cgi?id=16732
alp@webkit.org [Wed, 16 Jan 2008 12:07:47 +0000 (12:07 +0000)]
Update svn:ignore properties for autotools build

Reviewed by Alp Toker.

Ignore files placed in the source tree by the autotools build (these
files are generated even during an out-of-tree build).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemoved a whole bunch of notImplemented() warnings.
hausmann@webkit.org [Wed, 16 Jan 2008 10:34:23 +0000 (10:34 +0000)]
Removed a whole bunch of notImplemented() warnings.

I don't want to hide the real warnings in lots of things that
I am by now pretty certain we won't need.

Signed-off-by: Simon Hausmann <simon.hausmann@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Set the cursor on the containingWindow() instead of the
hausmann@webkit.org [Wed, 16 Jan 2008 10:18:45 +0000 (10:18 +0000)]
* Set the cursor on the containingWindow() instead of the
* This should be safe even with plugins as the cursor is set
  on the mouse events.

Signed-Off-By: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix crash when bringing up the context menu on maps.google.com.
hausmann@webkit.org [Wed, 16 Jan 2008 10:18:31 +0000 (10:18 +0000)]
Fix crash when bringing up the context menu on maps.google.com.

If the website provides its own context menu then we don't have a ContextMenu pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDon't crash when receiving all sorts of events on a default constructed QWebView...
hausmann@webkit.org [Wed, 16 Jan 2008 10:18:18 +0000 (10:18 +0000)]
Don't crash when receiving all sorts of events on a default constructed QWebView without a page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImprove the sqlite3 dependency when building WebKit inside Qt.
hausmann@webkit.org [Wed, 16 Jan 2008 10:18:04 +0000 (10:18 +0000)]
Improve the sqlite3 dependency when building WebKit inside Qt.

Build sqlite3 into QtWebKit if a system sqlite3 development package
can't be found.

Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImplement GraphicsContext::clipOut and fix transparency layers.
hausmann@webkit.org [Wed, 16 Jan 2008 10:17:51 +0000 (10:17 +0000)]
Implement GraphicsContext::clipOut and fix transparency layers.

Transparency layers where broken in two ways: It always used the
complete device rect as the size of the layer pixmap and the pixmaps
where not correctly initialized to transparent.

This fixes the worst drawing errors in the Inspector and makes drawing it
10 times faster.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMade the url property read-write.
hausmann@webkit.org [Wed, 16 Jan 2008 10:17:35 +0000 (10:17 +0000)]
Made the url property read-write.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDon't crash when showing a default initialized QWebView that has no page/frame yet.
hausmann@webkit.org [Wed, 16 Jan 2008 10:17:22 +0000 (10:17 +0000)]
Don't crash when showing a default initialized QWebView that has no page/frame yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTrivially implement the themed search field by mapping it to a text field
hausmann@webkit.org [Wed, 16 Jan 2008 10:17:07 +0000 (10:17 +0000)]
Trivially implement the themed search field by mapping it to a text field

Also add a bunch of notImplemented warnings for other places where we don't
have an implementatin in RenderTheme.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoChange hoveringOverLink implementation to have less issues.
hausmann@webkit.org [Wed, 16 Jan 2008 09:56:20 +0000 (09:56 +0000)]
Change hoveringOverLink implementation to have less issues.

* Currently we only compare a pointer. In the worst case we
  could delete the Element we have pointed to and a new one
  gets the same address. But even if that doesn't happen the
  WebCore::Element is mutable and JavaScript could change the
  URL, Title or Content. So we have to compare all these three
* This does not seem to be a performance impact.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Follow the EventHandlerWin.cpp and always return true in the handlers.
hausmann@webkit.org [Wed, 16 Jan 2008 09:55:50 +0000 (09:55 +0000)]
* Follow the EventHandlerWin.cpp and always return true in the handlers.
* Match the windows implementation more closely as well.
* This is fixing "selection" bugs with the Web Inspector

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Move the hoverElement from QWebFrame to QWebPage. As it is
hausmann@webkit.org [Wed, 16 Jan 2008 09:55:21 +0000 (09:55 +0000)]
* Move the hoverElement from QWebFrame to QWebPage. As it is
  only used there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoEventHandler changes/fixes in QWebPage:
hausmann@webkit.org [Wed, 16 Jan 2008 09:54:32 +0000 (09:54 +0000)]
EventHandler changes/fixes in QWebPage:
        Send the event always to the mainFrame of the QWebPage.

    -contextMenuEvent, key{Press,Release}Event:
        Send the event to the focused frame.

This is following the Windows port and fixes a issue with the
Web Inspector where we were sending the events to a wrong frame.

It is guaranteed that the mainFrame will always have an eventHandler
and frameView set. There is no need to check for this in QWebPage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29517 268f45cc-cd09-0410-ab3c-d52691b4dbfc