WebKit-https.git
9 years ago2011-07-01 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Fri, 1 Jul 2011 18:33:25 +0000 (18:33 +0000)]
2011-07-01  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch positionForPoint to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63774

        Switching positionForPoint functions to new layout unit abstraction.

        No new tests, no functionality changes.

        * rendering/RenderBR.cpp:
        (WebCore::RenderBR::positionForPoint):
        * rendering/RenderBR.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionForPoint):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::positionForPoint):
        * rendering/RenderBox.h:
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::positionForPoint):
        * rendering/RenderFileUploadControl.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::positionForPoint):
        * rendering/RenderInline.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::positionForPoint):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::positionForPoint):
        * rendering/RenderReplaced.h:
        * rendering/RenderText.cpp:
        (WebCore::RenderText::positionForPoint):
        * rendering/RenderText.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlInnerBlock::positionForPoint):
        * rendering/RenderTextControlSingleLine.h:
        * rendering/svg/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::positionForPoint):
        * rendering/svg/RenderSVGInlineText.h:
        * rendering/svg/RenderSVGText.cpp:
        (WebCore::RenderSVGText::positionForPoint):
        * rendering/svg/RenderSVGText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Fri, 1 Jul 2011 18:30:08 +0000 (18:30 +0000)]
2011-07-01  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Darin Fisher.

        Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium
        https://bugs.webkit.org/show_bug.cgi?id=63783

        * features.gypi:

2011-07-01  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Darin Fisher.

        Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium
        https://bugs.webkit.org/show_bug.cgi?id=63783

        * WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 1 Jul 2011 18:19:50 +0000 (18:19 +0000)]
2011-07-01  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Daniel Bates.

        [CMake] Don't compile unused bindings
        https://bugs.webkit.org/show_bug.cgi?id=63741

        * UseJSC.cmake: Added IF (ENABLE_XXX) around files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=63819
barraclough@apple.com [Fri, 1 Jul 2011 18:19:17 +0000 (18:19 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=63819
Escaping of forwardslashes in strings incorrect if multiple exist.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

The bug is in the parameters passed to a substring - should be
start & length, but we're passing start & end indices!

* runtime/RegExpObject.cpp:
(JSC::regExpObjectSource):

LayoutTests:

Add tests with multiple forward slashes.

* fast/regex/script-tests/toString.js:
* fast/regex/toString-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Jul 2011 18:14:37 +0000 (18:14 +0000)]
2011-07-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        ReportCrash destabilizes new-run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=63795

        ReportCrash chews up too many system resources that it destablizes
        tests run concurrently.  This patch causes us to spin down all the
        worker processes when ReportCrash is running.

        Also, this patch causes the master process to tell the user we're
        waiting for the crash reporter rather than having that be the worker's
        job.  This stops the user from getting spammed with too many "waiting
        for crash reporter" messages and also cleans up some minor UI issues
        with the meter.

        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
        * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/server_process.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 1 Jul 2011 17:57:37 +0000 (17:57 +0000)]
2011-07-01  Tony Chang  <tony@chromium.org>

        Fix the chromium build.  sql is a new top level directory.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 1 Jul 2011 17:36:17 +0000 (17:36 +0000)]
2011-07-01  Ryosuke Niwa  <rniwa@webkit.org>

        Rolled DEPS.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 1 Jul 2011 17:29:09 +0000 (17:29 +0000)]
2011-07-01  Mihai Parparita  <mihaip@chromium.org>

        Add failing test expectations for Chromium media tests on Windows 7 and
        Vista.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Fri, 1 Jul 2011 16:56:42 +0000 (16:56 +0000)]
2011-07-01  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Andreas Kling.

        [Qt][WK2] Clean up skipped list
        https://bugs.webkit.org/show_bug.cgi?id=61644

        * platform/qt-wk2/Skipped: Remove everything that we skip via the common wk2 list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Adam Roben <aroben@apple.com>
aroben@apple.com [Fri, 1 Jul 2011 16:56:33 +0000 (16:56 +0000)]
2011-07-01  Adam Roben  <aroben@apple.com>

        Roll out r90194
        http://trac.webkit.org/changeset/90194
        https://bugs.webkit.org/show_bug.cgi?id=63778

        Fixes <http://webkit.org/b/63812> REGRESSION (r90194): Multiple tests intermittently failing
        assertions in WriteBarrierBase<JSC::Structure>::get

        * runtime/JSCell.h:
        (JSC::JSCell::JSCell::~JSCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Joone Hur <joone.hur@collabora.co.uk>
joone.hur@collabora.co.uk [Fri, 1 Jul 2011 16:56:20 +0000 (16:56 +0000)]
2011-07-01  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Add DeviceOrientation feature
        https://bugs.webkit.org/show_bug.cgi?id=63720

        Add configure option to enable/disable DeviceOrientation feature.

        * configure.ac:
2011-07-01  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Add DeviceOrientation feature
        https://bugs.webkit.org/show_bug.cgi?id=63720

        Add DeviceMotionClientGtk.cpp and DeviceOrientationClientGtk.cpp to WebKitGtk+ build.

        * GNUmakefile.am: Add DeviceMotionClientGtk.cpp, DeviceOrientationClientGtk.cpp.
2011-07-01  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Add DeviceOrientation feature
        https://bugs.webkit.org/show_bug.cgi?id=63720

        Add empty implementation of DeviceMotionClient and DeviceOrientationClient callback methods.

        * GNUmakefile.am:
        * WebCoreSupport/DeviceMotionClientGtk.cpp: Added.
        (WebCore::DeviceMotionClientGtk::DeviceMotionClientGtk):
        (WebCore::DeviceMotionClientGtk::~DeviceMotionClientGtk):
        (WebCore::DeviceMotionClientGtk::deviceMotionControllerDestroyed):
        (WebCore::DeviceMotionClientGtk::setController):
        (WebCore::DeviceMotionClientGtk::startUpdating):
        (WebCore::DeviceMotionClientGtk::stopUpdating):
        (WebCore::DeviceMotionClientGtk::currentDeviceMotion):
        * WebCoreSupport/DeviceMotionClientGtk.h: Added.
        * WebCoreSupport/DeviceOrientationClientGtk.cpp: Added.
        (WebCore::DeviceOrientationClientGtk::DeviceOrientationClientGtk):
        (WebCore::DeviceOrientationClientGtk::~DeviceOrientationClientGtk):
        (WebCore::DeviceOrientationClientGtk::deviceOrientationControllerDestroyed):
        (WebCore::DeviceOrientationClientGtk::setController):
        (WebCore::DeviceOrientationClientGtk::startUpdating):
        (WebCore::DeviceOrientationClientGtk::stopUpdating):
        (WebCore::DeviceOrientationClientGtk::lastOrientation):
        * WebCoreSupport/DeviceOrientationClientGtk.h: Added.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach webkitpy about the new format of our ChangeLog template
aroben@apple.com [Fri, 1 Jul 2011 16:54:26 +0000 (16:54 +0000)]
Teach webkitpy about the new format of our ChangeLog template

r90229 moved the "Need a short description and bug URL" line to the top of the ChangeLog
template. But webkitpy didn't know this, so the various rollout-related commands were
leaving that line in the ChangeLog.

Fixes <http://webkit.org/b/63815> REGRESSION (r90229): webkit-patch rollout and sheriffbot
rollout are broken

Reviewed by Dan Bates.

* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog.update_with_unreviewed_message): Changed to look for the "Need a short
description and bug URL" line instead of the "Reviewed by" line as the first line of the
ChangeLog template.

* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(ChangeLogTest): Updated _new_entry_boilerplate to match what prepare-ChangeLog now
generates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: DidFinishLoadForFrame is never called on iframes when loads are
bweinstein@apple.com [Fri, 1 Jul 2011 16:51:24 +0000 (16:51 +0000)]
WebKit2: DidFinishLoadForFrame is never called on iframes when loads are
cancelled by willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=63753

Reviewed by Darin Adler.

Source/WebKit2:

When deciding a policy for a null request, call the callback that was passed
to WebKit2 and say that we used the loader.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

LayoutTests:

Unskip WebKit2 tests that now pass.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 1 Jul 2011 16:33:46 +0000 (16:33 +0000)]
2011-06-30  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Add optimised paths for a few maths functions
        https://bugs.webkit.org/show_bug.cgi?id=63757

        Relanding as a Mac only patch.

        This adds specialised thunks for Math.abs, Math.round, Math.ceil,
        Math.floor, Math.log, and Math.exp as they are apparently more
        important in real web content than we thought, which is somewhat
        mind-boggling.  On average doubles the performance of the common
        cases (eg. actually passing numbers in).  They're not as efficient
        as they could be, but this way gives them the most portability.

        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::supportsDoubleBitops):
        (JSC::MacroAssemblerARM::andnotDouble):
        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::supportsDoubleBitops):
        (JSC::MacroAssemblerARMv7::andnotDouble):
        * assembler/MacroAssemblerMIPS.h:
        (JSC::MacroAssemblerMIPS::andnotDouble):
        (JSC::MacroAssemblerMIPS::supportsDoubleBitops):
        * assembler/MacroAssemblerSH4.h:
        (JSC::MacroAssemblerSH4::supportsDoubleBitops):
        (JSC::MacroAssemblerSH4::andnotDouble):
        * assembler/MacroAssemblerX86.h:
        (JSC::MacroAssemblerX86::supportsDoubleBitops):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::andnotDouble):
        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::supportsDoubleBitops):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::andnpd_rr):
        * create_hash_table:
        * jit/SpecializedThunkJIT.h:
        (JSC::SpecializedThunkJIT::finalize):
        (JSC::SpecializedThunkJIT::callDoubleToDouble):
        * jit/ThunkGenerators.cpp:
        (JSC::floorThunkGenerator):
        (JSC::ceilThunkGenerator):
        (JSC::roundThunkGenerator):
        (JSC::expThunkGenerator):
        (JSC::logThunkGenerator):
        (JSC::absThunkGenerator):
        * jit/ThunkGenerators.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip one asserting and one timing-out test on Windows
aroben@apple.com [Fri, 1 Jul 2011 16:22:09 +0000 (16:22 +0000)]
Skip one asserting and one timing-out test on Windows

Failures are tracked by <http://webkit.org/b/63806> and <http://webkit.org/b/63807>.

* platform/win/Skipped: Added
http/tests/cache/history-only-cached-subresource-loads-max-age-https.html and
fast/loader/create-frame-in-DOMContentLoaded.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLand Windows expected failure results for fast/events/panScroll-click-hyperlink.html
aroben@apple.com [Fri, 1 Jul 2011 16:21:59 +0000 (16:21 +0000)]
Land Windows expected failure results for fast/events/panScroll-click-hyperlink.html

The failure is tracked by <http://webkit.org/b/63809>.

* platform/win/fast/events/panScroll-click-hyperlink-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLand new expected (failure?) results for an accessibility test on Windows
aroben@apple.com [Fri, 1 Jul 2011 16:21:49 +0000 (16:21 +0000)]
Land new expected (failure?) results for an accessibility test on Windows

The failure is tracked by <http://webkit.org/b/63811>.

* platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate expected results after r90159
aroben@apple.com [Fri, 1 Jul 2011 16:21:39 +0000 (16:21 +0000)]
Update expected results after r90159

Fixes <http://webkit.org/b/63810> REGRESSION (r90159): fast/events/window-onerror5.html
failing

* fast/events/window-onerror5-expected.txt: Updated for progression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/63814> Fix clang build error in JITOpcodes32_64.cpp
ddkilzer@apple.com [Fri, 1 Jul 2011 16:18:48 +0000 (16:18 +0000)]
<webkit.org/b/63814> Fix clang build error in JITOpcodes32_64.cpp

Fixes the following build error in clang:

    JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36:{741:9-741:35}: error: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Werror,-Wparentheses,3]
         map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
             ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
    JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36: note: place parentheses around the '+' expression to silence this warning [3]
         map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
                                        ^
             (                         )
    fix-it:"JavaScriptCore/jit/JITOpcodes32_64.cpp":{741:9-741:9}:"("
    fix-it:"JavaScriptCore/jit/JITOpcodes32_64.cpp":{741:35-741:35}:")"
    JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36:{741:28-741:94}: note: place parentheses around the '?:' expression to evaluate it first [3]
         map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
                                ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 error generated.

* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve_global): Add parenthesis to make the
tertiary expression evaluate first.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Fri, 1 Jul 2011 16:17:44 +0000 (16:17 +0000)]
2011-07-01  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Andreas Kling.

        [X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
        https://bugs.webkit.org/show_bug.cgi?id=63239

        * platform/qt-wk2/Skipped:
2011-07-01  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Andreas Kling.

        [X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
        https://bugs.webkit.org/show_bug.cgi?id=63239

        * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
        Revert the return value of NPP_HandleEvent because the plugin function
        returns with 0 if it handled the event.
        (WebKit::NetscapePlugin::platformHandleMouseEvent):
        (WebKit::NetscapePlugin::platformHandleWheelEvent):
        (WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
        (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
        (WebKit::NetscapePlugin::platformHandleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake TestFailures stop loading old builds once we've explained all current failures
aroben@apple.com [Fri, 1 Jul 2011 15:55:37 +0000 (15:55 +0000)]
Make TestFailures stop loading old builds once we've explained all current failures

We used to do this, but some refactoring in r90165 broke this logic.

Fixes <http://webkit.org/b/63808> REGRESSION (r90165): TestFailures page always loads all
builds back to the beginning of time

Reviewed by Dan Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
(LayoutTestHistoryAnalyzer.prototype.start): Stop fetching old builds once we're told that
all current failures have been explained.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocommit-log-editor reorders ChangeLog entries in unexpected ways
aroben@apple.com [Fri, 1 Jul 2011 15:21:02 +0000 (15:21 +0000)]
commit-log-editor reorders ChangeLog entries in unexpected ways
https://bugs.webkit.org/show_bug.cgi?id=63804

Reviewed by Darin Adler.

commit-log-editor was changed in r46899 to move the bug title and URL to the top of the
commit message in order to make git-based tools, which expect the first line of the commit
message to be a summary of the change, to work better. But this reordering of the ChangeLog
entry was unpredictable and unexpected.

I changed prepare-ChangeLog to put the bug title and URL at the top of the ChangeLog entry
so that commit-log-editor doesn't have to move them. Then I changed commit-log-editor not to
try to move them.

* Scripts/commit-log-editor: Partially reverted r46899. We no longer save the "Reviewed by"
line and try to move it down below the bug title and URL. The order of the text in the
ChangeLog is now preserved, except that we insert a "Patch by" line just above the "Reviewed
by" line in cases where the committer and author are not the same person.

* Scripts/prepare-ChangeLog: Moved the "Reviewed by" line down below the bug title and URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Mihnea Ovidenie <mihnea@adobe.com>
commit-queue@webkit.org [Fri, 1 Jul 2011 14:51:31 +0000 (14:51 +0000)]
2011-07-01  Mihnea Ovidenie  <mihnea@adobe.com>

        Reviewed by Adam Roben.

        [CSSRegions] Add build slave
        https://bugs.webkit.org/show_bug.cgi?id=62372

        * BuildSlaveSupport/build.webkit.org-config/config.json:
        Add an entry for a release build of Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Jade Han <jade.han@nokia.com>
commit-queue@webkit.org [Fri, 1 Jul 2011 14:29:12 +0000 (14:29 +0000)]
2011-07-01  Jade Han  <jade.han@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt][Symbian] Update .def file for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=61200

        Add newly introduced symbols to fix the Symbian build.

        * symbian/eabi/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Alice Boxhall <aboxhall@chromium.org>
commit-queue@webkit.org [Fri, 1 Jul 2011 14:18:41 +0000 (14:18 +0000)]
2011-07-01  Alice Boxhall  <aboxhall@chromium.org>

        Reviewed by Adam Roben.

        accessibility/aria-labelledby-overrides-aria-label.html failing on Windows since it was added
        https://bugs.webkit.org/show_bug.cgi?id=63191

        * accessibility/aria-labelledby-overrides-aria-label-expected.txt: Removed.
        * accessibility/aria-labelledby-overrides-aria-label.html:
        * platform/mac/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
        * platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Kentaro Hara <haraken@google.com>
commit-queue@webkit.org [Fri, 1 Jul 2011 13:58:18 +0000 (13:58 +0000)]
2011-07-01  Kentaro Hara  <haraken@google.com>

        Reviewed by Kent Tamura.

        Disallow clicking an [X] button in 'search' input forms when 'disabled' attribute or 'readonly' attribute is set.
        https://bugs.webkit.org/show_bug.cgi?id=63709

        Added a test that checks whether the content in 'search' input forms with 'disabled' attribute
        or 'readonly' attribute is cleared or not, when an [X] button is clicked.

        * fast/forms/search-disabled-readonly-expected.txt: Added.
        * fast/forms/search-disabled-readonly.html: Added.
2011-07-01  Kentaro Hara  <haraken@google.com>

        Reviewed by Kent Tamura.

        Disallow clicking an [X] button in 'search' input forms when 'disabled' attribute or 'readonly' attribute is set.
        https://bugs.webkit.org/show_bug.cgi?id=63709

        Ignore a cancel button event on a 'search' input form if 'disabled' attribute or
        'readonly' attribute is set to the input form.

        Test: fast/forms/search-disabled-readonly.html

        * html/shadow/TextControlInnerElements.cpp:
        (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed due to fixing of a broken world.
mrowe@apple.com [Fri, 1 Jul 2011 13:25:03 +0000 (13:25 +0000)]
Unreviewed due to fixing of a broken world.

REGRESSION (r90163): WebKit2 bot is failing 100% of the tests.

r90163 bumped the version of the WKBundlePageLoaderClient passed in by WebKitTestRunner from 0 to 1.
This made it run in to the ad-hoc client version checking implemented directly in WKBundlePageSetPageLoaderClient,
resulting in no client being set. After r90162 the ad-hoc checking is not necessary as the APIClient
template takes care of the relevant version checks.

* Shared/APIClient.h:
(WebKit::APIClient::initialize): Fix a bug I noticed along the way: don't attempt to copy anything if
the client version is newer than what we support. This matches the behavior of the ad-hoc version checking.
* UIProcess/API/C/WKContext.cpp:
(WKContextSetInjectedBundleClient): Drop the ad-hoc version checking.
(WKContextSetHistoryClient): Ditto.
(WKContextSetDownloadClient): Ditto.
* UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerSetClient): Ditto.
* UIProcess/API/C/WKGeolocationManager.cpp:
(WKGeolocationManagerSetProvider): Ditto.
* UIProcess/API/C/WKIconDatabase.cpp:
(WKIconDatabaseSetIconDatabaseClient): Ditto.
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageContextMenuClient): Ditto.
(WKPageSetPageFindClient): Ditto.
(WKPageSetPageFormClient): Ditto.
(WKPageSetPageLoaderClient): Ditto.
(WKPageSetPagePolicyClient): Ditto.
(WKPageSetPageResourceLoadClient): Ditto.
(WKPageSetPageUIClient): Ditto.
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetClient): Ditto.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetContextMenuClient): Ditto.
(WKBundlePageSetEditorClient): Ditto.
(WKBundlePageSetFormClient): Ditto.
(WKBundlePageSetPageLoaderClient): Ditto.
(WKBundlePageSetResourceLoadClient): Ditto.
(WKBundlePageSetPolicyClient): Ditto.
(WKBundlePageSetUIClient): Ditto.
(WKBundlePageSetFullScreenClient): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Andy Estes <aestes@apple.com>
aestes@apple.com [Fri, 1 Jul 2011 12:51:24 +0000 (12:51 +0000)]
2011-07-01  Andy Estes  <aestes@apple.com>

        Reviewed by Mark Rowe.

        Simplify MailQuirksUserScript.js
        https://bugs.webkit.org/show_bug.cgi?id=63800

        MailQuirksUserScript.js is injected into WebViews in Mail.app on
        Leopard to resolve an incompatibility between it and the HTML5 parser.
        It did so by taking all nodes in the document between <html> and <body>
        and moving them to be children of <body>. This maintains Mail.app's
        assumption that document.firstChild.firstChild == document.body.

        While this script fixed a specific issue with the Signature panel in
        Mail.app, it caused regressions in other WebViews. Since the issue with
        the Signature panel is with the empty <head> node implicitly created by
        the parser, we can simplify this script by removing this implicit
        <head> in the case it has no attributes and no children. This fixes the
        Signature panel without affecting other WebViews that have non-trivial
        <head> nodes.

        * Misc/MailQuirksUserScript.js: If <head> exists but has no attributes
        and no children, remove it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 1 Jul 2011 11:29:59 +0000 (11:29 +0000)]
2011-06-30  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Chromium] Fix heap snapshots in a remote debugging session from Safari.
        https://bugs.webkit.org/show_bug.cgi?id=63703

        * inspector/front-end/HeapSnapshotWorker.js:
        (.Function.prototype.bind.return.bound):
        (.Function.prototype.bind):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 1 Jul 2011 10:38:06 +0000 (10:38 +0000)]
2011-06-30  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Create sunspider-1.0 directory in preparation for fixing a bunch of bugs
        https://bugs.webkit.org/show_bug.cgi?id=63782

        * make-hosted: Learn about the new directory.
        * tests/sunspider-1.0: Copied from PerformanceTests/SunSpider/tests/sunspider-0.9.1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 1 Jul 2011 09:03:17 +0000 (09:03 +0000)]
2011-07-01  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update text expectation for Vista.

        * platform/chromium-win-vista/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 1 Jul 2011 08:51:28 +0000 (08:51 +0000)]
2011-07-01  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimatedLengthListAnimator does not take additive="sum" into accout
        https://bugs.webkit.org/show_bug.cgi?id=63705

        Added support for additive animations to SVGAnimatedLengthListAnimator. Don't clear the animatedList if not
        necessary.

        SVGLength unit gets animated as well now. We used to take the unit of 'from' all the time.

        Tests: svg/animations/svglength-animation-unitType.html
               svg/animations/svglengthlist-animation-5.html

        * svg/SVGAnimatedLength.cpp:
        (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue): Code clean-up and support for unit animation.
        * svg/SVGAnimatedLengthList.cpp: Add support for additive animations.
        (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
        * svg/SVGLength.cpp:
        (WebCore::SVGLength::SVGLength):
        (WebCore::SVGLength::setValue): New setValue that gets the LengthType and UnitType as argument for supporting animations of units as well.
        * svg/SVGLength.h:
2011-07-01  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimatedLengthListAnimator does not take additive="sum" into accout
        https://bugs.webkit.org/show_bug.cgi?id=63705

        Tests additive animations for SVGLengthLists as well as unit animations on SVGLength.

        * svg/animations/script-tests/svglength-animation-unitType.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglengthlist-animation-5.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/svglength-animation-unitType-expected.txt: Added.
        * svg/animations/svglength-animation-unitType.html: Added.
        * svg/animations/svglengthlist-animation-5-expected.txt: Added.
        * svg/animations/svglengthlist-animation-5.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 1 Jul 2011 08:37:49 +0000 (08:37 +0000)]
2011-07-01  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimatedType should support SVGAnimatedInteger animation
        https://bugs.webkit.org/show_bug.cgi?id=63789

        Test animation of SVGAnimatedInteger. Added the test to the wk2 skip list.

        * platform/mac-wk2/Skipped:
        * svg/animations/script-tests/svginteger-animation-1.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/svginteger-animation-1-expected.txt: Added.
        * svg/animations/svginteger-animation-1.html: Added.
2011-07-01  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimatedType should support SVGAnimatedInteger animation
        https://bugs.webkit.org/show_bug.cgi?id=63789

        Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
        This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedInteger.

        SVGAnimatedInteger is used for some attributes of SVG filter effects. The animation of those attributes work after this patch.

        Test: svg/animations/svginteger-animation-1.html

        * CMakeLists.txt: Added file to build system.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * svg/SVGAllInOne.cpp: Ditto.
        * svg/SVGAnimateElement.cpp: Make use of AnimatedInteger.
        (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::calculateFromAndByValues):
        (WebCore::SVGAnimateElement::resetToBaseValue):
        (WebCore::SVGAnimateElement::applyResultsToTarget):
        (WebCore::SVGAnimateElement::calculateDistance):
        * svg/SVGAnimatedInteger.cpp: Added. The new animator for SVGAnimatedInteger.
        (WebCore::SVGAnimatedIntegerAnimator::SVGAnimatedIntegerAnimator):
        (WebCore::SVGAnimatedIntegerAnimator::constructFromString):
        (WebCore::SVGAnimatedIntegerAnimator::calculateFromAndToValues):
        (WebCore::SVGAnimatedIntegerAnimator::calculateFromAndByValues):
        (WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue):
        (WebCore::SVGAnimatedIntegerAnimator::calculateDistance):
        * svg/SVGAnimatedInteger.h:
        (WebCore::SVGAnimatedIntegerAnimator::~SVGAnimatedIntegerAnimator):
        * svg/SVGAnimatedType.cpp: Added handler for AnimatedInteger.
        (WebCore::SVGAnimatedType::~SVGAnimatedType):
        (WebCore::SVGAnimatedType::createInteger):
        (WebCore::SVGAnimatedType::integer):
        (WebCore::SVGAnimatedType::valueAsString):
        (WebCore::SVGAnimatedType::setValueAsString):
        * svg/SVGAnimatedType.h:
        * svg/SVGAnimatorFactory.h:
        (WebCore::SVGAnimatorFactory::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 1 Jul 2011 07:52:20 +0000 (07:52 +0000)]
2011-07-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r90213.
        http://trac.webkit.org/changeset/90213
        https://bugs.webkit.org/show_bug.cgi?id=63792

        The SL bot has an errant HTTP server holding port 8080
        (Requested by abarth on #webkit).

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 1 Jul 2011 07:50:49 +0000 (07:50 +0000)]
2011-07-01  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix WebKit2 GTK build after r90163.

        * MiniBrowser/gtk/WebBundle/WebBundleMain.c:
        (didCreatePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 1 Jul 2011 07:47:55 +0000 (07:47 +0000)]
2011-07-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r90177 and r90179.
        http://trac.webkit.org/changeset/90177
        http://trac.webkit.org/changeset/90179
        https://bugs.webkit.org/show_bug.cgi?id=63790

        It caused crashes on Qt in debug mode (Requested by Ossy on
        #webkit).

        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::rshift32):
        (JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
        (JSC::MacroAssemblerARM::sqrtDouble):
        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
        (JSC::MacroAssemblerARMv7::sqrtDouble):
        * assembler/MacroAssemblerMIPS.h:
        (JSC::MacroAssemblerMIPS::sqrtDouble):
        (JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
        * assembler/MacroAssemblerSH4.h:
        (JSC::MacroAssemblerSH4::sqrtDouble):
        * assembler/MacroAssemblerX86.h:
        * assembler/MacroAssemblerX86Common.h:
        * assembler/MacroAssemblerX86_64.h:
        * assembler/X86Assembler.h:
        * create_hash_table:
        * jit/JSInterfaceJIT.h:
        (JSC::JSInterfaceJIT::emitLoadDouble):
        * jit/SpecializedThunkJIT.h:
        (JSC::SpecializedThunkJIT::finalize):
        * jit/ThunkGenerators.cpp:
        * jit/ThunkGenerators.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Jul 2011 07:39:34 +0000 (07:39 +0000)]
2011-07-01  Adam Barth  <abarth@webkit.org>

        Exit faster when we get a keyboard interrupt.  Previously, we'd open
        Safari if you ^C NRWT after it found a failure.

        * Scripts/webkitpy/layout_tests/layout_package/manager.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Fri, 1 Jul 2011 07:31:36 +0000 (07:31 +0000)]
2011-07-01  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Switch Snow Leopard over to new-run-webkit-tests (except for wk2)
        https://bugs.webkit.org/show_bug.cgi?id=63786

        We're down to one bug blocking the "move to NRWT" bug:
        https://bugs.webkit.org/show_bug.cgi?id=34984
        so we're trying transitioning Snow Leopard to NRWT as an experiment.

        If we run into any blocking issues we'll of course roll this back out
        (or anyone reading this should feel encouraged to).

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 1 Jul 2011 07:28:11 +0000 (07:28 +0000)]
2011-07-01  Kent Tamura  <tkent@chromium.org>

        [Chromium] More test expectation update for r90089

        Need to update a Windows XP expectation because the corresponding
        chromium-win expectation was updated.

        * platform/chromium-win-xp/fast/forms/search-styled-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 1 Jul 2011 07:13:43 +0000 (07:13 +0000)]
2011-07-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r90192.
        http://trac.webkit.org/changeset/90192
        https://bugs.webkit.org/show_bug.cgi?id=63788

        Appears to have caused NRWT on Chromium WebKit Vista to hang
        (Requested by abarth on #webkit).

        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 1 Jul 2011 07:01:32 +0000 (07:01 +0000)]
2011-06-30  Kent Tamura  <tkent@chromium.org>

        [Mac][Chromium] Update test expectations for r90089

        The placeholder position changes are expected because we respect
        paddings for text fields.

        * platform/chromium-linux/fast/forms/placeholder-position-expected.png:
        * platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
        * platform/chromium-win/fast/forms/placeholder-position-expected.png:
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/forms/placeholder-position-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Eugene Klyuchnikov <eustas.bug@gmail.com>
commit-queue@webkit.org [Fri, 1 Jul 2011 06:50:14 +0000 (06:50 +0000)]
2011-06-30  Eugene Klyuchnikov  <eustas.bug@gmail.com>

        Reviewed by Pavel Feldman.

        WebInspector: Performance / memory allocation issue in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded
        https://bugs.webkit.org/show_bug.cgi?id=40447

        * inspector/editor/text-editor-model-replace-tabs-expected.txt: Added.
        * inspector/editor/text-editor-model-replace-tabs.html: Added.
2011-06-30  Eugene Klyuchnikov  <eustas.bug@gmail.com>

        Reviewed by Pavel Feldman.

        WebInspector: Performance / memory allocation issue in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded
        https://bugs.webkit.org/show_bug.cgi?id=40447

        Test: inspector/editor/text-editor-model-replace-tabs.html

        * inspector/front-end/TextEditorModel.js:
        (WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded): avoid looped production of tail substrings

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 1 Jul 2011 06:36:07 +0000 (06:36 +0000)]
2011-06-30  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update test expectations.

        * platform/chromium-mac-leopard/fast/forms/preserveFormDuringResidualStyle-expected.png: Added.
        * platform/chromium-mac-leopard/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
        * platform/chromium-win-xp/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Jul 2011 06:34:47 +0000 (06:34 +0000)]
2011-06-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove the concept of "being wedged" from new-run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=63767

        Worker processes shouldn't ever become wedged.  My understanding is
        that this code was originally motivated by the old threading-based
        design but no longer servers any purpose.

        Note: If we actually have a problem with the test harness getting
        stuck, buildbot will kill us.

        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Fri, 1 Jul 2011 06:06:59 +0000 (06:06 +0000)]
2011-06-30  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Hajime Morita.

        [Chromium] Remove WebBindings::makeNode.
        https://bugs.webkit.org/show_bug.cgi?id=63613

        Dead code elimination. No change in behaviour, so no new tests.

        * public/WebBindings.h:
        * src/WebBindings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Jul 2011 05:47:29 +0000 (05:47 +0000)]
2011-06-30  Adam Barth  <abarth@webkit.org>

        The win32 implementation of fork is sad about forking test-webkitpy.
        Hopefully this will heal the bot.

        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 1 Jul 2011 05:44:59 +0000 (05:44 +0000)]
2011-06-30  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update expectation files for r90089.

        * platform/chromium-linux/fast/css/input-search-padding-expected.png:
        * platform/chromium-linux/fast/css/input-search-padding-expected.txt:
        * platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
        * platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
        * platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
        * platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
        * platform/chromium-linux/fast/forms/placeholder-set-value-expected.png: Added.
        * platform/chromium-linux/fast/forms/search-display-none-cancel-button-expected.png:
        * platform/chromium-linux/fast/forms/search-styled-expected.txt:
        * platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png:
        * platform/chromium-linux/fast/forms/searchfield-heights-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/searchfield-heights-expected.txt.
        * platform/chromium-linux/fast/repaint/search-field-cancel-expected.png:
        * platform/chromium-linux/fast/replaced/width100percent-searchfield-expected.png:
        * platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
        * platform/chromium-linux/platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
        * platform/chromium-linux/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
        * platform/chromium-linux/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Added.
        * platform/chromium-mac-leopard/fast/forms/search-vertical-alignment-expected.png: Added.
        * platform/chromium-mac/fast/css/input-search-padding-expected.png: Removed.
        * platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
        * platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
        * platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
        * platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
        * platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png: Added.
        * platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
        * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
        * platform/chromium-win-vista/fast/forms/search-styled-expected.txt: Removed.
        * platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
        * platform/chromium-win/fast/css/input-search-padding-expected.png:
        * platform/chromium-win/fast/css/input-search-padding-expected.txt:
        * platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
        * platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
        * platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
        * platform/chromium-win/fast/forms/control-restrict-line-height-expected.txt:
        * platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
        * platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
        * platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.txt:
        * platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
        * platform/chromium-win/fast/forms/placeholder-position-expected.txt:
        * platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
        * platform/chromium-win/fast/forms/placeholder-set-value-expected.txt:
        * platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
        * platform/chromium-win/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/chromium-win/fast/forms/search-rtl-expected.txt:
        * platform/chromium-win/fast/forms/search-styled-expected.png:
        * platform/chromium-win/fast/forms/search-styled-expected.txt:
        * platform/chromium-win/fast/forms/search-vertical-alignment-expected.png:
        * platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
        * platform/chromium-win/fast/forms/searchfield-heights-expected.png: Added.
        * platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
        * platform/chromium-win/fast/repaint/search-field-cancel-expected.png:
        * platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
        * platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
        * platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
        * platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
        * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
        * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
        * platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
        * platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
        * platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/replaced/width100percent-searchfield-expected.png.
        * platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 1 Jul 2011 05:07:33 +0000 (05:07 +0000)]
2011-06-30  Kent Tamura  <tkent@chromium.org>

        [Chromium-Mac] Update test expectation files.

        * platform/chromium-mac-leopard/fast/forms/input-appearance-range-expected.png:
        * platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.png: Removed.
        * platform/chromium-mac/fast/forms/basic-buttons-expected.png: Added.
        * platform/chromium-mac/fast/forms/button-sizes-expected.png: Added.
        * platform/chromium-mac/fast/forms/file-input-direction-expected.png:
        * platform/chromium-mac/fast/forms/file-input-direction-expected.txt:
        * platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png: Added.
        * platform/chromium-mac/fast/forms/input-appearance-range-expected.png:
        * platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.png:
        * platform/chromium-mac/fast/forms/slider-padding-expected.png: Removed.
        * platform/chromium-mac/fast/forms/slider-thumb-shared-style-expected.png: Removed.
        * platform/chromium-mac/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
        * platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 1 Jul 2011 03:54:58 +0000 (03:54 +0000)]
2011-06-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Input type="range" slider thumb is rendered upside down on Mac OS X.
        https://bugs.webkit.org/show_bug.cgi?id=63697

        * platform/chromium/test_expectations.txt: Some tests need new expectation images.
2011-06-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Input type="range" slider thumb is rendered upside down on Mac OS X.
        https://bugs.webkit.org/show_bug.cgi?id=63697

        http://trac.webkit.org/changeset/86261 added a thumb flipping code
        for Mac-WebKit2. Chromium also needs it.

        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintSliderThumb): Always flip vertically on Chromium.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 1 Jul 2011 03:31:51 +0000 (03:31 +0000)]
2011-06-30  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Update new-run-webkit-tests now that the wk2 shared skipped list has moved
        https://bugs.webkit.org/show_bug.cgi?id=63780

        The shared list was moved from mac-wk2 to wk2 as part of
        http://trac.webkit.org/changeset/90125.

        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Kenichi Ishibashi <bashi@chromium.org>
bashi@chromium.org [Fri, 1 Jul 2011 03:28:38 +0000 (03:28 +0000)]
2011-06-30  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Simon Fraser.

        [Chromium] -webkit-text-stroke doesn't affect with non-zero width border property
        https://bugs.webkit.org/show_bug.cgi?id=63698

        Added a test which ensures text stroke is rendered with non-zero width border.

        * platform/chromium-linux/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
        * platform/chromium-linux/platform/chromium/fast/text/text-stroke-with-border-expected.txt: Added.
        * platform/chromium-mac/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
        * platform/chromium-mac/platform/chromium/fast/text/text-stroke-with-border-expected.txt: Added.
        * platform/chromium-win/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
        * platform/chromium-win/platform/chromium/fast/text/text-stroke-with-border-expected.txt: Added.
        * platform/chromium/fast/text/text-stroke-with-border.html: Added.
2011-06-30  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Simon Fraser.

        [Chromium] -webkit-text-stroke doesn't affect with non-zero width border property
        https://bugs.webkit.org/show_bug.cgi?id=63698

        Restore the stroke style when it is modified in RenderObject::drawLineForBoxSide() to show text stroke correctly.

        Test: platform/chromium/fast/text/text-stroke-with-border.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawLineForBoxSide): Save/restore the stroke style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Fri, 1 Jul 2011 03:06:48 +0000 (03:06 +0000)]
2011-06-30  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed.

        Rebaselining video-currentTime-set.html for Chromium due to FFmpeg update.

        * platform/chromium-mac/media/video-currentTime-set-expected.txt:
        * platform/chromium-win/media/video-currentTime-set-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 1 Jul 2011 03:06:44 +0000 (03:06 +0000)]
2011-06-30  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        [WebKit2] Consider scale factor when allocating backing store
        https://bugs.webkit.org/show_bug.cgi?id=63766

        This is the first step in considering scale factor. It considers
        scale factor for the primary backing store, not graphics layers,
        and for CG only.

        * Platform/cg/CGUtilities.cpp:
        (WebKit::paintImage): Added a scale factor argument.
        (WebKit::paintBitmapContext): Pass 1 for scale factor.
        * Platform/cg/CGUtilities.h: Updated for above.

        * Shared/ShareableBitmap.h: Added an overload of paint that can handle
        a scale factor.

        * Shared/UpdateInfo.cpp:
        (WebKit::UpdateInfo::encode): Encode scale factor.
        (WebKit::UpdateInfo::decode): Decode scale factor.
        * Shared/UpdateInfo.h: Added scale factor.

        * Shared/cg/ShareableBitmapCG.cpp:
        (WebKit::ShareableBitmap::paint): Added the overload that can handle
        a scale factor.

        * UIProcess/BackingStore.cpp:
        (WebKit::BackingStore::create): Take a scale factor.
        (WebKit::BackingStore::BackingStore): Store the scale factor.
        (WebKit::BackingStore::incorporateUpdate): Consider the scale factor
        when asserting the size is correct.

        * UIProcess/BackingStore.h: Add a scale factor.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): Check the
        scale factor too when deciding whether to reuse a backing store.
        (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Pass in the scale
        factor when creating a backing store.

        * UIProcess/mac/BackingStoreMac.mm:
        (WebKit::BackingStore::incorporateUpdate): Take the scale factor into
        account when painting.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Put the
        scale factor into the UpdateInfo.
        (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Ditto.
        (WebKit::DrawingAreaImpl::display): Take the scale factor into account
        when allocating the bitmap and creating a graphics context for it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Kenichi Ishibashi <bashi@chromium.org>
bashi@chromium.org [Fri, 1 Jul 2011 02:59:43 +0000 (02:59 +0000)]
2011-06-30  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Darin Adler.

        Style Checker should flag removal of "developmentRegion = English;" from project.pbxproj.
        https://bugs.webkit.org/show_bug.cgi?id=62022

        Adds XcodeProjectFileChecker to check removal of "developmentRegion".

        * Scripts/webkitpy/style/checker.py: Added XcodeProjectFileChecker as a checker for *.pbxproj.
        * Scripts/webkitpy/style/checkers/xcodeproj.py: Added.
        * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Fri, 1 Jul 2011 02:55:49 +0000 (02:55 +0000)]
2011-06-30  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Don't use old Hixie75 handshake in pywebsocket handlers
        https://bugs.webkit.org/show_bug.cgi?id=63704

        * http/tests/websocket/tests/bad-handshake-crash_wsh.py:
        Use handshake format of Hixie's protocol draft 76 which we are currently supporting.
        * http/tests/websocket/tests/long-invalid-header_wsh.py:
        Content of web_socket_transfer_data() is completely bogus. It's not necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 1 Jul 2011 02:52:59 +0000 (02:52 +0000)]
2011-06-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Implement WebCore::defaultDetailsSummaryText()
        https://bugs.webkit.org/show_bug.cgi?id=63700

        * platform/chromium/test_expectations.txt: Tests for <details> fail temporarily.
2011-06-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Implement WebCore::defaultDetailsSummaryText()
        https://bugs.webkit.org/show_bug.cgi?id=63700

        * public/WebLocalizedString.h: Add new key.
        * src/LocalizedStrings.cpp: Call query() with the new key.
        (WebCore::defaultDetailsSummaryText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 1 Jul 2011 02:42:18 +0000 (02:42 +0000)]
2011-06-30  Oliver Hunt  <oliver@apple.com>

        Reviewed by Beth Dakin.

        Make GC validation clear cell structure on destruction
        https://bugs.webkit.org/show_bug.cgi?id=63778

        * runtime/JSCell.h:
        (JSC::JSCell::JSCell::~JSCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 1 Jul 2011 02:17:27 +0000 (02:17 +0000)]
2011-06-30  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Gavin Barraclough.

        Added write barrier that was missing from put_by_id_transition
        https://bugs.webkit.org/show_bug.cgi?id=63775

        * dfg/DFGJITCodeGenerator.cpp:
        (JSC::DFG::JITCodeGenerator::writeBarrier): Made this static with a
        MacroAssembler& argument so our patching functions could use it.

        (JSC::DFG::JITCodeGenerator::cachedPutById):
        * dfg/DFGJITCodeGenerator.h:
        * dfg/DFGNonSpeculativeJIT.cpp:
        (JSC::DFG::NonSpeculativeJIT::compile): Updated for signature change.

        * dfg/DFGRepatch.cpp:
        (JSC::DFG::tryCachePutByID): Missing barrier!

        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::SpeculativeJIT::compile): Updated for signature change.

        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::privateCompilePutByIdTransition):
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::privateCompilePutByIdTransition):
        * jit/JSInterfaceJIT.h: Same game here. Removed storePtrWithWriteBarrier
        because its meaning isn't clear -- maybe in the future we'll have a
        clear way to pass all stores through a common function that guarantees
        a write barrier, but that's not the case right now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 1 Jul 2011 02:10:25 +0000 (02:10 +0000)]
2011-06-30  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        nrwt: make sharding tests needing locks less hard-coded
        https://bugs.webkit.org/show_bug.cgi?id=63112

        This change also changes the manager logic so that it will
        drop the server lock as soon as all of the shards requiring
        the lock have completed.

        This change includes some minor namespace/import changes in the
        unit tests, and also makes the Manager a new-style object, which
        it should've been all along.

        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Jul 2011 01:55:08 +0000 (01:55 +0000)]
2011-06-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove threaded mode from new-run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=63771

        This mode is not used and is buggy.  Rather than carry around a bunch
        of unused buggy code, we should rip it out and focus on the
        multiprocess implementation.

        * Scripts/webkitpy/common/system/executive.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/worker.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/server_process.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Fri, 1 Jul 2011 01:33:54 +0000 (01:33 +0000)]
2011-06-30  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed.

        Temporarily disabling WTF_USE_WEBAUDIO_FFMPEG due to FFmpeg update.

        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Filip Pizlo <fpizlo@apple.com>
commit-queue@webkit.org [Fri, 1 Jul 2011 01:04:54 +0000 (01:04 +0000)]
2011-06-30  Filip Pizlo  <fpizlo@apple.com>

        Reviewed by Gavin Barraclough.

        DFG non-speculative JIT does not reuse registers when compiling comparisons.
        https://bugs.webkit.org/show_bug.cgi?id=63565

        * dfg/DFGNonSpeculativeJIT.cpp:
        (JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
        (JSC::DFG::NonSpeculativeJIT::basicArithOp):
        (JSC::DFG::NonSpeculativeJIT::compare):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Gwang Yoon Hwang <ryumiel@company100.net>
commit-queue@webkit.org [Fri, 1 Jul 2011 00:28:06 +0000 (00:28 +0000)]
2011-06-30  Gwang Yoon Hwang  <ryumiel@company100.net>

        Reviewed by Nate Chapin.

        [V8] Add ENABLE(INSPECTOR) guards around v8 custom bindings.
        https://bugs.webkit.org/show_bug.cgi?id=63442

        No new tests needed.

        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 1 Jul 2011 00:10:23 +0000 (00:10 +0000)]
2011-06-30  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Gavin Barraclough.

        Added empty write barrier stubs in all the right places in the DFG JIT
        https://bugs.webkit.org/show_bug.cgi?id=63764

        SunSpider thinks this might be a 0.5% speedup. Meh.

        * dfg/DFGJITCodeGenerator.cpp:
        (JSC::DFG::JITCodeGenerator::writeBarrier): Le stub.

        (JSC::DFG::JITCodeGenerator::cachedPutById): Don't do anything special
        for the case where base == scratch, since we now require base and scratch
        to be not equal, for the sake of the write barrier.

        * dfg/DFGJITCodeGenerator.h: Le stub.

        * dfg/DFGNonSpeculativeJIT.cpp:
        (JSC::DFG::NonSpeculativeJIT::compile): Don't reuse the base register
        as the scratch register, since that's incompatible with the write barrier,
        which needs a distinct base and scratch.

        Do put the global object into a register before loading its var storage,
        since it needs to be in a register for the write barrier to operate on it.

        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::SpeculativeJIT::compile):
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::emitWriteBarrier): Second verse, same as the first.

        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::emit_op_get_scoped_var):
        (JSC::JIT::emit_op_put_scoped_var):
        (JSC::JIT::emit_op_put_global_var): Deployed offsetOfRegisters() to more
        places.

        (JSC::JIT::emitWriteBarrier): Added a teeny tiny ASSERT so this function
        is a little more than meaningless.

        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::emit_op_get_scoped_var):
        (JSC::JIT::emit_op_put_scoped_var):
        (JSC::JIT::emit_op_put_global_var): Deployed offsetOfRegisters() to more
        places.

        (JSC::JIT::emitWriteBarrier): Added a teeny tiny ASSERT so this function
        is a little more than meaningless.

        * runtime/JSVariableObject.h:
        (JSC::JSVariableObject::offsetOfRegisters): Now used by the JIT, since
        we put the global object in a register and only then load its var storage
        by offset.

        (JSC::JIT::emitWriteBarrier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Thu, 30 Jun 2011 23:48:22 +0000 (23:48 +0000)]
2011-06-30  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Remove positionForCoordinates
        https://bugs.webkit.org/show_bug.cgi?id=63765

        Removing positionForCoordinate. We should always use positionForPoint. Also cleaning up
        RenderBox's implementation of positionForPoint.

        No new tests, there should be no functionality changes.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::stringValue): Removing dead, or at least untested, code and
        adding an ASSERT_NOT_REACHED.
        (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::positionForPoint): cleaning up some ugly code.
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::positionForPoint):
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 John Bates <jbates@google.com>
commit-queue@webkit.org [Thu, 30 Jun 2011 23:46:54 +0000 (23:46 +0000)]
2011-06-30  John Bates  <jbates@google.com>

        Reviewed by James Robinson.

        Chromium bug: Compositing on a lost context causes latch deadlocks.
        The cause of deadlock was that a setLatch command is added to the lost
        compositor GL context, and a waitLatch would never complete on a child context.
        This change checks whether the compositor context is in error state before
        doing the compositing.
        https://bugs.webkit.org/show_bug.cgi?id=63681

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::composite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 30 Jun 2011 23:40:32 +0000 (23:40 +0000)]
2011-06-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Clean up output from new-run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=63759

        Printing messages from the child process looks super ugly because of
        the way the pretty-printer works.  Printing a blank line first is a
        hack, but it makes things at least partially sane.

        Also, handle the case where calling sample throws an exception.

        * Scripts/webkitpy/layout_tests/port/server_process.py:
        * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Rafael Brandao <rafael.lobo@openbossa.org>
commit-queue@webkit.org [Thu, 30 Jun 2011 23:30:18 +0000 (23:30 +0000)]
2011-06-30  Rafael Brandao  <rafael.lobo@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] Fix tst_QWebFrame::renderGeometry() API test
        https://bugs.webkit.org/show_bug.cgi?id=63236

        This test required a security origin with granted permission to request local resources.
        By default, only local files can load local resources. So modified baseUrl to be a local file.

        * tests/qwebframe/tst_qwebframe.cpp:
        (tst_QWebFrame::renderGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 30 Jun 2011 23:24:26 +0000 (23:24 +0000)]
2011-06-30  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Improve WebGL object lifetime management in WebGLRenderingContext
        https://bugs.webkit.org/show_bug.cgi?id=63635

        * fast/canvas/webgl/gl-object-get-calls-expected.txt:
        * fast/canvas/webgl/gl-object-get-calls.html: Fix a bug so getFramebufferAtatchmentParameter generates an error if nothing is attached and something other than TYPE is queried.
        * fast/canvas/webgl/object-deletion-behaviour-expected.txt:
        * fast/canvas/webgl/object-deletion-behaviour.html: Ditto.
        * fast/canvas/webgl/program-test.html: Fix the test so the order of shaders returned by getAttachedShaders doesn't matter.
2011-06-30  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Improve WebGL object lifetime management in WebGLRenderingContext
        https://bugs.webkit.org/show_bug.cgi?id=63635

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getAttachedShaders): Use cached objects instead of querying the underlying GL.
        (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Ditto.
        (WebCore::WebGLRenderingContext::detachAndRemoveAllObjects): Multiple loop because objects might be removed from the table within an iteration.
        * html/canvas/WebGLRenderingContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix ARMv6 build
oliver@apple.com [Thu, 30 Jun 2011 23:20:13 +0000 (23:20 +0000)]
Fix ARMv6 build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 Diego Gonzalez <diegohcg@webkit.org>
diegohcg@webkit.org [Thu, 30 Jun 2011 23:09:50 +0000 (23:09 +0000)]
2011-06-27  Diego Gonzalez  <diegohcg@webkit.org>

    Reviewed by Antonio Gomes.

    [Qt] DRT: Provide LayoutTestController::setDefersLoading and ::goBack support
    https://bugs.webkit.org/show_bug.cgi?id=63489

    Unskipped:
        loader/navigation-while-deferring-loads.html

    Source/WebKit/qt:

    * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
    (DumpRenderTreeSupportQt::setDefersLoading):
    (DumpRenderTreeSupportQt::goBack):
    * WebCoreSupport/DumpRenderTreeSupportQt.h:

    Tools:

    * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
    (LayoutTestController::goBack):
    (LayoutTestController::setDefersLoading):
    * DumpRenderTree/qt/LayoutTestControllerQt.h:

    LayoutTests:

    * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 30 Jun 2011 23:08:11 +0000 (23:08 +0000)]
2011-06-30  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Add optimised paths for a few maths functions
        https://bugs.webkit.org/show_bug.cgi?id=63757

        This adds specialised thunks for Math.abs, Math.round, Math.ceil,
        Math.floor, Math.log, and Math.exp as they are apparently more
        important in real web content than we thought, which is somewhat
        mind-boggling.  On average doubles the performance of the common
        cases (eg. actually passing numbers in).  They're not as efficient
        as they could be, but this way gives them the most portability.

        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::supportsDoubleBitops):
        (JSC::MacroAssemblerARM::andnotDouble):
        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::supportsDoubleBitops):
        (JSC::MacroAssemblerARMv7::andnotDouble):
        * assembler/MacroAssemblerMIPS.h:
        (JSC::MacroAssemblerMIPS::andnotDouble):
        (JSC::MacroAssemblerMIPS::supportsDoubleBitops):
        * assembler/MacroAssemblerSH4.h:
        (JSC::MacroAssemblerSH4::supportsDoubleBitops):
        (JSC::MacroAssemblerSH4::andnotDouble):
        * assembler/MacroAssemblerX86.h:
        (JSC::MacroAssemblerX86::supportsDoubleBitops):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::andnotDouble):
        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::supportsDoubleBitops):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::andnpd_rr):
        * create_hash_table:
        * jit/SpecializedThunkJIT.h:
        (JSC::SpecializedThunkJIT::finalize):
        (JSC::SpecializedThunkJIT::callDoubleToDouble):
        * jit/ThunkGenerators.cpp:
        (JSC::floorThunkGenerator):
        (JSC::ceilThunkGenerator):
        (JSC::roundThunkGenerator):
        (JSC::expThunkGenerator):
        (JSC::logThunkGenerator):
        (JSC::absThunkGenerator):
        * jit/ThunkGenerators.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 30 Jun 2011 23:07:15 +0000 (23:07 +0000)]
2011-06-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Dirk Pranke.

        new-run-webkit-tests should stop when I ^C it
        https://bugs.webkit.org/show_bug.cgi?id=63763

        It still doesn't stop fast enough, but at least with this patch it
        doesn't run more tests.

        Also, I tweaked the UI that happens when there's a keyboard interrupt
        to not be amazingly ugly.  There's still a garbage "Te" left on the
        console, but that's a problem for another day.

        * Scripts/webkitpy/layout_tests/layout_package/manager.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Alan Stearns <stearns@adobe.com>
commit-queue@webkit.org [Thu, 30 Jun 2011 23:05:33 +0000 (23:05 +0000)]
2011-06-30  Alan Stearns  <stearns@adobe.com>

        Reviewed by Tony Chang.

        Modify Skipped files so that future css exclusions LayoutTests are
        skipped by default.

        [CSSExclusions] Add test and skip entries
        https://bugs.webkit.org/show_bug.cgi?id=63751

        * fast/exclusions/triangle-exclusion.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Rafael Brandao <rafael.lobo@openbossa.org>
commit-queue@webkit.org [Thu, 30 Jun 2011 22:39:13 +0000 (22:39 +0000)]
2011-06-30  Rafael Brandao  <rafael.lobo@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] build-webkit warning: cannot find file ElementShadowPseudoId.h
        https://bugs.webkit.org/show_bug.cgi?id=63747

        Removed reference to ElementShadowPseudoId.h that no longer exists.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix clang build.
andersca@apple.com [Thu, 30 Jun 2011 22:29:01 +0000 (22:29 +0000)]
Fix clang build.

Remove the complete Widget constructor from the .exp.in file; since Widget is an abstract class,
its complete constructor can never be called and clang has stopped emitting it altogether.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake TestFailures never treat a too-many-failures build as a last-passing build for...
aroben@apple.com [Thu, 30 Jun 2011 22:28:32 +0000 (22:28 +0000)]
Make TestFailures never treat a too-many-failures build as a last-passing build for a test

Fixes <http://webkit.org/b/63758> TestFailures sometimes incorrectly says that a build was
the last passing build for a test, when in fact the test wasn't run due to too many failures
causing old-run-webkit-tests to exit early

Reviewed by Anders Carlsson.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): If there were too many
failures in this build, assume that all the tests failed in the last build would have failed
in this build, too, had they been run. Introduced some new local variables to reduce typing,
and used them throughout.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
(LayoutTestResultsLoader.prototype.start): Fix a regression from r89841 where we wouldn't
correctly remember whether old-run-webkit-tests exited early due to too many failures for
builds older than r89610. Also removed an unused parameter while I was at it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Thu, 30 Jun 2011 22:15:25 +0000 (22:15 +0000)]
2011-06-30  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintingRootRect and RenderObject repaint methods to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63746

        Switching paintingRootRect and RenderObject repaint functions over to the
        new layout unit abstraction.

        No new tests, no functionality changes.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::repaintDuringLayoutIfMoved):
        * rendering/RenderBox.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintingRootRect):
        (WebCore::RenderObject::paint):
        (WebCore::RenderObject::repaintUsingContainer):
        (WebCore::RenderObject::repaintRectangle):
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
        (WebCore::RenderObject::repaintDuringLayoutIfMoved):
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the Windows build.
mrowe@apple.com [Thu, 30 Jun 2011 22:10:32 +0000 (22:10 +0000)]
Fix the Windows build.

* UIProcess/API/C/win/WKTextChecker.h:
* UIProcess/API/C/win/WKView.h:
* UIProcess/win/WebTextCheckerClient.h:
* UIProcess/win/WebUndoClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Cary Clark <caryclark@google.com>
commit-queue@webkit.org [Thu, 30 Jun 2011 22:00:00 +0000 (22:00 +0000)]
2011-06-30  Cary Clark  <caryclark@google.com>

        Reviewed by James Robinson.

        Use Skia if Skia on Mac Chrome is enabled
        https://bugs.webkit.org/show_bug.cgi?id=62999

        * wtf/Platform.h:
        Add switch to use Skia if, externally,
        Skia has been enabled by a gyp define.
2011-06-30  Cary Clark  <caryclark@google.com>

        Reviewed by James Robinson.

        Use Skia if Skia on Mac Chrome is enabled
        https://bugs.webkit.org/show_bug.cgi?id=62999

        No new tests. This does not affect existing
        functionality.

        * WebCore.gyp/WebCore.gyp:
        Include Skia and related files and exclude CG
        and related files when building Chromium for Skia
        on the Mac.

        * loader/cache/CachedFont.cpp:
        Rename CHROME to CHROMIUM.

        * platform/chromium/DragImageRef.h:
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/FloatSize.h:
        * platform/graphics/FontPlatformData.h:
        (WebCore::FontPlatformData::hash):
        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::add):
        (WebCore::GlyphBuffer::expandLastAdvance):
        * platform/graphics/IntPoint.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/IntSize.h:
        * platform/graphics/SimpleFontData.h:
        * platform/graphics/cg/FloatPointCG.cpp:
        * platform/graphics/cg/FloatRectCG.cpp:
        * platform/graphics/cg/FloatSizeCG.cpp:
        * platform/graphics/cg/IntPointCG.cpp:
        * platform/graphics/cg/IntRectCG.cpp:
        * platform/graphics/cg/IntSizeCG.cpp:
        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        (WebCore::createFontCustomPlatformData):
        * platform/graphics/mac/FontCustomPlatformData.h:
        (WebCore::FontCustomPlatformData::FontCustomPlatformData):
        Ditto.
2011-06-30  Cary Clark  <caryclark@google.com>

        Reviewed by James Robinson.

        Use Skia if Skia on Mac Chrome is enabled
        https://bugs.webkit.org/show_bug.cgi?id=62999

        * WebKit.gyp:
        If building for Skia, exclude CG files.
        If not, exclude Skia files.

        * features.gypi:
        Enable Skia on Chromium Mac if so instructed by the gyp define.
        Allow Skia to be hardware accelerated on the Mac.

        * public/WebCommon.h:
        If Skia is defined on the Mac, define it in the WebXXX
        interfaces as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Thu, 30 Jun 2011 21:51:17 +0000 (21:51 +0000)]
2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Update SVG position values on SVG DOM updates
        https://bugs.webkit.org/show_bug.cgi?id=62439

        * svg/custom/crash-textPath-attributes-expected.txt: Added.
        * svg/custom/crash-textPath-attributes.html: Added.
        * svg/custom/resources/crash-textPath-attributes-iframe.svg: Added.
2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Update SVG position values on SVG DOM updates
        https://bugs.webkit.org/show_bug.cgi?id=62439

        Test: svg/custom/crash-textPath-attributes.html

        * rendering/svg/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::destroy): Notify our containing RenderSVGText that it needs
        to update its positioning information.

        * rendering/svg/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::calculateBoundaries): Check the type of the InlineBox
        like the rest of the code (fixes an ASSERT_NOT_REACHED in InlineBox::calculateBoudaries).

        * rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
        (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree): Clear
        our cached layout attributes every time we invalidate them. This avoids keeping stale
        attribute that have a backpointer to a RenderObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake TestFaiulres only load old-results directories as needed
aroben@apple.com [Thu, 30 Jun 2011 21:49:42 +0000 (21:49 +0000)]
Make TestFaiulres only load old-results directories as needed

Fixes <http://webkit.org/b/63752> Tester pages on TestFailures page load very slowly

Reviewed by Anders Carlsson.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getBuildNames): Moved up into the API section of the class. Now just
calls through to _getBuildNamesFromResultsDirectory.
(Builder.prototype.getOldBuildNames): Added. Just calls through to
_getBuildNamesFromResultsDirectory.
(Builder.prototype._getBuildNamesFromResultsDirectory): Renamed from getBuildNames. Now
takes the directory URL as an argument and only fetches that single URL.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
(LayoutTestHistoryAnalyzer.prototype.start): Moved most logic to _analyzeBuilds. First
analyzes builds from Builder.getBuildNames, then from Builder.getOldBuildNames if needed.
(LayoutTestHistoryAnalyzer.prototype._analyzeBuilds): Moved logic here from start. (Most
changes are just indentation.) Now takes a callback to call when we've finished analyzing
all builds in buildNames so that we can try to fetch more build names if needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Sreeram Ramachandran <sreeram@chromium.org>
commit-queue@webkit.org [Thu, 30 Jun 2011 21:46:50 +0000 (21:46 +0000)]
2011-06-30  Sreeram Ramachandran  <sreeram@chromium.org>

        Reviewed by Adam Barth.

        Suppress modal JavaScript/HTML dialogs during unload events
        https://bugs.webkit.org/show_bug.cgi?id=56397

        Adds Chromium-specific test expectations that show alerts in unload
        handlers being replaced by console messages.

        * fast/loader/page-dismissal-modal-dialogs-expected.txt: Added.
        * fast/loader/page-dismissal-modal-dialogs.html: Added.
        * fast/loader/resources/page-dismissal-modal-dialogs-iframe.html: Added.
        * platform/chromium-mac/fast/history/timed-refresh-in-cached-frame-expected.txt:
        * platform/chromium-win/fast/history/timed-refresh-in-cached-frame-expected.txt:
        * platform/chromium/fast/dom/Geolocation/notimer-after-unload-expected.txt: Added.
        * platform/chromium/fast/events/onbeforeunload-focused-iframe-expected.txt: Added.
        * platform/chromium/fast/events/onunload-clears-onbeforeunload-expected.txt: Added.
        * platform/chromium/fast/events/onunload-expected.txt: Added.
        * platform/chromium/fast/events/onunload-not-on-body-expected.txt: Added.
        * platform/chromium/fast/events/onunload-window-property-expected.txt: Added.
        * platform/chromium/fast/events/pageshow-pagehide-on-back-uncached-expected.txt: Added.
        * platform/chromium/fast/history/timed-refresh-in-cached-frame-expected.txt: Added.
        * platform/chromium/fast/loader/frames-with-unload-handlers-in-page-cache-expected.txt: Added.
        * platform/chromium/fast/loader/page-dismissal-modal-dialogs-expected.txt: Added.
        * platform/chromium/fast/loader/recursive-before-unload-crash-expected.txt: Added.
2011-06-30  Sreeram Ramachandran  <sreeram@chromium.org>

        Reviewed by Adam Barth.

        Suppress modal JavaScript/HTML dialogs during unload events
        https://bugs.webkit.org/show_bug.cgi?id=56397

        Allows clients to specify whether to show alerts during unload handlers.
        When checking for whether a page dismissal event is being dispatched,
        it's important to check all frames on the page (otherwise it becomes a
        loophole easily exploited).

        Test: fast/loader/page-dismissal-modal-dialogs.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::stopLoading):
        (WebCore::FrameLoader::loadURL):
        (WebCore::FrameLoader::loadWithDocumentLoader):
        (WebCore::FrameLoader::stopAllLoaders):
        (WebCore::FrameLoader::fireBeforeUnloadEvent):
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::pageDismissalEventBeingDispatched):
        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::requestImage):
        * page/Chrome.cpp:
        (WebCore::canRunModalIfDuringPageDismissal):
        (WebCore::Chrome::canRunModalNow):
        (WebCore::Chrome::runJavaScriptAlert):
        (WebCore::Chrome::runJavaScriptConfirm):
        (WebCore::Chrome::runJavaScriptPrompt):
        * page/Chrome.h:
        * page/ChromeClient.h:
        (WebCore::ChromeClient::shouldRunModalDialogDuringPageDismissal):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::showModalDialog):
2011-06-30  Sreeram Ramachandran  <sreeram@chromium.org>

        Reviewed by Adam Barth.

        Suppress modal JavaScript/HTML dialogs during unload events
        https://bugs.webkit.org/show_bug.cgi?id=56397

        Implementation of the new shouldRunModalDialogDuringPageDismissal() API
        to block alerts during unload handlers. Logs such events to the console
        and updates histograms.

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):
        * src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate MiniBrowser and WebKitTestRunner to use the client version constants.
mrowe@apple.com [Thu, 30 Jun 2011 21:46:39 +0000 (21:46 +0000)]
Update MiniBrowser and WebKitTestRunner to use the client version constants.

Reviewed by Anders Carlsson.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowLoaderClientInit):
(browserWindowUIClientInit):
* MiniBrowser/gtk/WebBundle/WebBundleMain.c:
(didCreatePage):
(WKBundleInitialize):
* MiniBrowser/gtk/main.c:
(createWKContextWithInjectedBundle):
* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(WKBundleInitialize):
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::initialize):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach APIClient to correctly handle multiple versions of a client interface.
mrowe@apple.com [Thu, 30 Jun 2011 21:46:35 +0000 (21:46 +0000)]
Teach APIClient to correctly handle multiple versions of a client interface.

Reviewed by Anders Carlsson.

If a client struct is not the current version then we can't copy it via assignment
since that will read past the end of the smaller, older struct. To deal with this
APIClient needs to be aware of the sizes of the older client version structs so that
it can copy only the appropriate amount of the struct.

* Shared/APIClient.h:
(WebKit::APIClient::initialize): Assign through to our client if the new in client is the
latest version. If an older client version was passed then we zero out our client and memcpy
the appropriate number of bytes in to it. This ensures that any new members in the client
are initialized to 0.
* Shared/APIClientTraits.cpp:
* Shared/APIClientTraits.h: Client interfaces are the size of their struct unless otherwise stated.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h: Bump the version and add comments indicating
which components belong to which versions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake the APIClient template aware of the latest client interface version number.
mrowe@apple.com [Thu, 30 Jun 2011 21:46:31 +0000 (21:46 +0000)]
Make the APIClient template aware of the latest client interface version number.

Reviewed by Anders Carlsson.

This will be used in an upcoming patch.

* Shared/APIClient.h:
* UIProcess/WebContextInjectedBundleClient.h:
* UIProcess/WebCookieManagerProxyClient.h:
* UIProcess/WebDatabaseManagerProxyClient.h:
* UIProcess/WebDownloadClient.h:
* UIProcess/WebFindClient.h:
* UIProcess/WebFormClient.h:
* UIProcess/WebGeolocationProvider.h:
* UIProcess/WebHistoryClient.h:
* UIProcess/WebIconDatabaseClient.h:
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageContextMenuClient.h:
* UIProcess/WebPolicyClient.h:
* UIProcess/WebResourceLoadClient.h:
* UIProcess/WebUIClient.h:
* WebProcess/InjectedBundle/InjectedBundleClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
* WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2 client interfaces should have constant declaring latest version.
mrowe@apple.com [Thu, 30 Jun 2011 21:46:23 +0000 (21:46 +0000)]
WebKit2 client interfaces should have constant declaring latest version.

Reviewed by Anders Carlsson.

* UIProcess/API/C/WKContext.h:
* UIProcess/API/C/WKCookieManager.h:
* UIProcess/API/C/WKDatabaseManager.h:
* UIProcess/API/C/WKGeolocationManager.h:
* UIProcess/API/C/WKIconDatabase.h:
* UIProcess/API/C/WKPage.h:
* WebProcess/InjectedBundle/API/c/WKBundle.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Juan C. Montemayor <jmont@apple.com>
commit-queue@webkit.org [Thu, 30 Jun 2011 21:41:58 +0000 (21:41 +0000)]
2011-06-30  Juan C. Montemayor  <jmont@apple.com>

        Reviewed by Geoffrey Garen.

        Web Inspector fails to display source for eval with syntax error
        https://bugs.webkit.org/show_bug.cgi?id=63583

        Added new LayoutTest to check that the correct line number is added to a
        syntax error inside an eval statement.

        * fast/js/eval-contained-syntax-error-expected.txt: Added.
        * fast/js/eval-contained-syntax-error.html: Added.
        * fast/js/script-tests/eval-contained-syntax-error.js: Added.
        * platform/chromium/fast/js/eval-contained-syntax-error-expected.txt: Added.
2011-06-30  Juan C. Montemayor  <jmont@apple.com>

        Reviewed by Geoffrey Garen.

        Web Inspector fails to display source for eval with syntax error
        https://bugs.webkit.org/show_bug.cgi?id=63583

        Web Inspector now displays a link to an eval statement that contains
        a syntax error.

        * parser/Parser.h:
        (JSC::isEvalNode):
        (JSC::EvalNode):
        (JSC::Parser::parse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 30 Jun 2011 21:37:56 +0000 (21:37 +0000)]
2011-06-30  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium test update after r90148.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Filip Pizlo <fpizlo@apple.com>
commit-queue@webkit.org [Thu, 30 Jun 2011 21:30:57 +0000 (21:30 +0000)]
2011-06-30  Filip Pizlo  <fpizlo@apple.com>

        Reviewed by Gavin Barraclough.

        X86Assembler does not encode byte registers in 64-bit mode correctly.
        https://bugs.webkit.org/show_bug.cgi?id=63665

        * assembler/X86Assembler.h:
        (JSC::X86Assembler::testb_rr):
        (JSC::X86Assembler::X86InstructionFormatter::oneByteOp8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Thu, 30 Jun 2011 20:50:16 +0000 (20:50 +0000)]
2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
        https://bugs.webkit.org/show_bug.cgi?id=63076

        * svg/custom/crash-text-in-textpath-expected.txt: Added.
        * svg/custom/crash-text-in-textpath.svg: Added.
        Original crashing test case.

        * svg/custom/text-node-in-text-invalidated-expected.txt: Added.
        * svg/custom/text-node-in-text-invalidated.svg: Added.
        This test case was not crashing. However it is good to make sure this change
        did not regress that.
2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
        https://bugs.webkit.org/show_bug.cgi?id=63076

        Tests: svg/custom/crash-text-in-textpath.svg
               svg/custom/text-node-in-text-invalidated.svg

        The problem was that we did not call setNeedsPositionUpdate on RenderSVGText. When
        doing our layout, we would not update the attributes on our SVGRenderInlineText as
        we would not lay it out.

        This was caused by childrenChanged being overridden on SVGTextPositioningElement but
        not on SVGTextPathElement.

        As both classes shared the same mother class, it made sense to move the logic here.
        There should be no other side effects as SVGTextPathElement and SVGTextPositioningElement
        are the only classes deriving from SVGTextContentElement.

        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::childrenChanged): Moved this method from SVGTextPositioningElement.
        * svg/SVGTextContentElement.h:
        * svg/SVGTextPositioningElement.cpp:
        (WebCore::SVGTextPositioningElement::svgAttributeChanged): Updated after updatePositioningValuesInRenderer
        removal, replaced by RenderSVGText::locateRenderSVGTextAncestor.
        * svg/SVGTextPositioningElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
andersca@apple.com [Thu, 30 Jun 2011 20:22:22 +0000 (20:22 +0000)]
Build fix.

* UIProcess/win/WebPopupMenuProxyWin.h:
(WebKit::WebPopupMenuProxyWin::enclosingScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 30 Jun 2011 20:17:38 +0000 (20:17 +0000)]
2011-06-30  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed build fix for !ENABLE(DATABASE) after r84789.

        * bindings/js/JSDOMBinding.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIdentify revisions that modified failing tests on TestFailures page
aroben@apple.com [Thu, 30 Jun 2011 20:03:33 +0000 (20:03 +0000)]
Identify revisions that modified failing tests on TestFailures page

Fixes <http://webkit.org/b/63716> TestFailures page should try to infer which commit caused
a failure by looking at commit logs

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
(.existing-bugs-list, .suspect-revisions-list): Made this rule apply to the suspect
revisions list, too.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
(Trac): Initialize our memory cache.
(Trac.prototype.getCommitDataForRevisionRange): Added. Fetches the commit log in RSS form,
then parses out the revision number, Trac's idea of the commit title, and the files modified
by the commit. (To get the modified files, we rely on the commit message including a
prepare-ChangeLog-style file list.)
(Trac.prototype.logURL): Added a new formatAsRSS parameter.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
(removePathExtension): Added. Returns a new string with the last dot and everything after it
removed.
(sorted): Added sortFunction parameter.
(Node.prototype.removeAllChildren): Added. Does what it says.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayBuilder): Updated for change to _domForRegressionRange.
(ViewController.prototype._domForRegressionRange): Changed argument order to match
_domForNewAndExistingBugs. Now takes the list of failing tests and uses it to figure out
which revisions modified the failing tests and displays the suspect revisions in a list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 30 Jun 2011 19:40:43 +0000 (19:40 +0000)]
2011-06-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        More ScrollableArea scaffolding
        https://bugs.webkit.org/show_bug.cgi?id=63678

        Add an enclosingScrollableArea stub.

        * src/WebScrollbarImpl.cpp:
        (WebKit::WebScrollbarImpl::enclosingScrollableArea):
        * src/WebScrollbarImpl.h:
2011-06-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        More ScrollableArea scaffolding
        https://bugs.webkit.org/show_bug.cgi?id=63678

        * WebScrollBar.h:
        (WebScrollBar::enclosingScrollableArea):
        Always return 0, WebScrollbar has no concept of an enclosing scrollable area.
2011-06-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        More ScrollableArea scaffolding
        https://bugs.webkit.org/show_bug.cgi?id=63678

        Add a way to get the enclosing scrollable area for a given scrollable area.
        Also, add ScrollableArea::isPinnedInDirectionOfScrollDelta.

        * page/FrameView.cpp:
        (WebCore::FrameView::enclosingScrollableArea):
        Return 0 for now.

        * page/FrameView.h:
        Add FrameView::enclosingScrollableArea.

        * platform/ScrollableArea.cpp:
        (WebCore::ScrollableArea::isPinnedInDirectionOfScrollDelta):
        Return whether the area is pinned in the direction of the scroll delta.

        * platform/ScrollableArea.h:
        Add new member functions.

        * platform/chromium/FramelessScrollView.cpp:
        (WebCore::FramelessScrollView::enclosingScrollableArea):
        * platform/chromium/FramelessScrollView.h:
        Add stub.

        * platform/win/PopupMenuWin.h:
        (WebCore::PopupMenuWin::enclosingScrollableArea):
        Always return 0.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::enclosingScrollableLayer):
        Add helper function.

        (WebCore::RenderLayer::scrollByRecursively):
        Use the new enclosingScrollableLayer helper function.

        (WebCore::RenderLayer::enclosingScrollableArea):
        Return the enclosing scrollable area.

        * rendering/RenderLayer.h:
        Add new member function.

        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::enclosingScrollableArea):
        Return 0 for now.

        * rendering/RenderListBox.h:
        Add new member function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 30 Jun 2011 19:34:20 +0000 (19:34 +0000)]
2011-06-30  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Rename should_kill_dump_render_tree to driver_needs_restart in preparation for supporting WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=63743

        * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
        * Scripts/webkitpy/layout_tests/layout_package/worker.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 30 Jun 2011 19:31:01 +0000 (19:31 +0000)]
2011-06-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Anders Carlsson.

        [GTK] Crash observed with nspluginwrapper and flash
        https://bugs.webkit.org/show_bug.cgi?id=62249

        Added a test which verifies that WebKit does not crash when InvalidateRect
        is called with a null instance.

        * platform/gtk/plugins/invalidate-rect-with-null-npp-argument-expected.txt: Added.
        * platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html: Added.
2011-06-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Anders Carlsson.

        [GTK] Crash observed with nspluginwrapper and flash
        https://bugs.webkit.org/show_bug.cgi?id=62249

        Test: plugins/invalidate-rect-with-null-npp-argument.html

        * plugins/npapi.cpp:
        (NPN_InvalidateRect): Guard against null instances here.
2011-06-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Anders Carlsson.

        [GTK] Crash observed with nspluginwrapper and flash
        https://bugs.webkit.org/show_bug.cgi?id=62249

        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_InvalidateRect): Guard against null instances here.
2011-06-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Anders Carlsson.

        [GTK] Crash observed with nspluginwrapper and flash
        https://bugs.webkit.org/show_bug.cgi?id=62249

        Added a TestNetscapePlugin test which verifies that WebKit properly
        handles situations where InvalidateRect is called with a null instance.

        * DumpRenderTree/TestNetscapePlugIn/Tests/x11/CallInvalidateRectWithNullNPPArgument.cpp: Added.
        (CallInvalidateRectWithNullNPPArgument::CallInvalidateRectWithNullNPPArgument):
        (CallInvalidateRectWithNullNPPArgument::NPP_New):
        * GNUmakefile.am: Add the new file to sources list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Thu, 30 Jun 2011 19:16:53 +0000 (19:16 +0000)]
2011-06-30  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch availableWidth/Height, logicalLeft/RightOffsetForLine to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63671

        Switch availableWidth/Height, logicalLeft/RightOffsetForLine functions over to the
        new layout unit abstraction.

        No new tests, no functionality changes.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::logicalLeftOffsetForLine):
        (WebCore::RenderBlock::logicalRightOffsetForLine):
        (WebCore::RenderBlock::availableLogicalWidthForLine):
        (WebCore::RenderBlock::availableLogicalWidth):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::logicalRightOffsetForLine):
        (WebCore::RenderBlock::logicalLeftOffsetForLine):
        (WebCore::RenderBlock::startOffsetForLine):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::availableLogicalHeight):
        (WebCore::RenderBox::availableLogicalHeightUsing):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::availableLogicalWidth):
        (WebCore::RenderBox::availableWidth):
        (WebCore::RenderBox::availableHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 30 Jun 2011 19:07:23 +0000 (19:07 +0000)]
2011-06-30  Adam Barth  <abarth@webkit.org>

        Remove useless ASSERT that breaks the build.

        * dom/StyledElement.cpp:
        (WebCore::parseColorStringWithCrazyLegacyRules):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 30 Jun 2011 18:56:27 +0000 (18:56 +0000)]
2011-06-30  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Remove redundant tests in TestFailuresTest
        https://bugs.webkit.org/show_bug.cgi?id=63742

        These tests are all already covered by TestFailuresTest.test_loads.
        I also added the missing "T" from TestFailuresest. :)

        * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90140 268f45cc-cd09-0410-ab3c-d52691b4dbfc