WebKit-https.git
9 years ago2011-04-04 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 4 Apr 2011 10:27:52 +0000 (10:27 +0000)]
2011-04-04  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, fix exception in rebaseline tool.

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-04 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 4 Apr 2011 10:18:55 +0000 (10:18 +0000)]
2011-04-04  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, udpate chromium test expectations after r82786.

        * platform/chromium-linux-x86_64/fast/table/colspanMinWidth-vertical-expected.png: Added.
        * platform/chromium-win-vista/fast/table/colspanMinWidth-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.checksum: Removed.
        * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
        * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-04 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Mon, 4 Apr 2011 10:10:29 +0000 (10:10 +0000)]
2011-04-04  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Followup to an incomplete commit in r82806.

        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createSidebarPane):
        (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl):
        (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setHeight):
        (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
        (WebInspector.injectedExtensionAPI):
        * inspector/front-end/ExtensionPanel.js:
        (WebInspector.ExtensionSidebarPane):
        (WebInspector.ExtensionSidebarPane.prototype.setPage):
        (WebInspector.ExtensionSidebarPane.prototype._setObject):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer):
        (WebInspector.ExtensionServer.prototype.notifyExtensionSidebarUpdated):
        (WebInspector.ExtensionServer.prototype._onCreatePanel):
        (WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
        (WebInspector.ExtensionServer.prototype.createClientIframe):
        (WebInspector.ExtensionServer.prototype._onSetSidebarContent):

2011-04-04  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Followup to an incomplete commit in r82806.

        * inspector/extensions/extensions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-04 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 4 Apr 2011 10:04:38 +0000 (10:04 +0000)]
2011-04-04  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, add chromium test expectations for tests added in r82780.

        * platform/chromium-mac/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Added.
        * platform/chromium-mac/fast/dom/Element/scale-page-client-rects-expected.txt: Added.
        * platform/chromium-mac/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Added.
        * platform/chromium-mac/fast/dom/Range/scale-page-client-rects-expected.txt: Added.
        * platform/chromium-win/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Added.
        * platform/chromium-win/fast/dom/Element/scale-page-client-rects-expected.txt: Added.
        * platform/chromium-win/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Added.
        * platform/chromium-win/fast/dom/Range/scale-page-client-rects-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-04 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 4 Apr 2011 09:54:39 +0000 (09:54 +0000)]
2011-04-04  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, rebaseline chromium tests after r82783.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-04 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 4 Apr 2011 09:44:06 +0000 (09:44 +0000)]
2011-04-04  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Fix Qt minimal build.

        * inspector/InspectorFrontendChannel.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Sergey Vorobyev <sergeyvorobyev@google.com>
yurys@chromium.org [Mon, 4 Apr 2011 09:38:02 +0000 (09:38 +0000)]
2011-04-01  Sergey Vorobyev  <sergeyvorobyev@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Separate sendMessageToFrontend function
        from InspectorClient to individual interface.
        https://bugs.webkit.org/show_bug.cgi?id=57548

        Refactoring - covered with existing inspector tests.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/InspectorClient.h:
        * inspector/InspectorFrontendChannel.h: Added.
        (WebCore::InspectorFrontendChannel::~InspectorFrontendChannel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-04 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Mon, 4 Apr 2011 09:20:45 +0000 (09:20 +0000)]
2011-04-04  Nico Weber  <thakis@chromium.org>

        Reviewed by Eric Seidel.

        Prefer a using directive over qualified names in LocalizedNumberICU.cpp
        https://bugs.webkit.org/show_bug.cgi?id=57742

        Requested by ap in https://bugs.webkit.org/show_bug.cgi?id=57715

        * platform/text/LocalizedNumberICU.cpp:
        (WebCore::createFormatterForCurrentLocale):
        (WebCore::numberFormatter):
        (WebCore::parseLocalizedNumber):
        (WebCore::formatLocalizedNumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-04 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Mon, 4 Apr 2011 09:14:52 +0000 (09:14 +0000)]
2011-04-04  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Breakpoints in the gutter stay static while editing the text
        https://bugs.webkit.org/show_bug.cgi?id=57616

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype._saveViewerState):
        (WebInspector.SourceFrame.prototype._restoreViewerState):
        (WebInspector.SourceFrame.prototype._endEditing):
        (WebInspector.SourceFrame.prototype._lineNumberAfterEditing):
        (WebInspector.SourceFrame.prototype.addBreakpoint):
        (WebInspector.SourceFrame.prototype.removeBreakpoint):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._syncDecorationsForLine):
        (WebInspector):
        (WebInspector.TextEditorChunkedPanel.prototype.removeDecoration):
        (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
        (WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
        (WebInspector.TextEditorMainPanel.prototype._splitChunkOnALine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-04 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 4 Apr 2011 09:03:03 +0000 (09:03 +0000)]
2011-04-04  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: remove obsolete doc generating code from CodeGenerator.
        https://bugs.webkit.org/show_bug.cgi?id=57748

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-04 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Mon, 4 Apr 2011 08:56:33 +0000 (08:56 +0000)]
2011-04-04  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into ExtensionSidebarPane
        https://bugs.webkit.org/show_bug.cgi?id=57622

        Merged WatchExpressionSidebarPane into ExtensionSidebarPane, added setPage(url).
        Fixed wrong getter in schema (scripts -> elements)

        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setObject):
        (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setPage):
        * inspector/front-end/ExtensionAPISchema.json:
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onSetSidebarPage):

2011-04-04  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into ExtensionSidebarPane
        https://bugs.webkit.org/show_bug.cgi?id=57622

        Merged WatchExpressionSidebarPane into ExtensionSidebarPane, added setPage(url).
        Fixed wrong getter in schema (scripts -> elements)

        * inspector/extensions/extensions-api-expected.txt:
        * inspector/extensions/extensions-expected.txt:
        * inspector/extensions/extensions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-04 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Mon, 4 Apr 2011 08:50:50 +0000 (08:50 +0000)]
2011-04-04  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Main loop sources are leaked in RunLoopGtk
        https://bugs.webkit.org/show_bug.cgi?id=57618

        * Platform/RunLoop.h:
        (RunLoop::TimerBase::isRepeating):
        * Platform/gtk/RunLoopGtk.cpp:
        (RunLoop::~RunLoop): Make sure main loop is currently running
        before calling g_main_loop_quit(), RunLoop::stop() might have been
        called.
        (RunLoop::wakeUp): Use an idle source with default priority
        instead of a timeout one with a 0 interval.
        (RunLoop::TimerBase::clearTimerSource): New method to clear the
        timer.
        (RunLoop::TimerBase::destroyNotifyCallback): Destroy notify
        callback called when the source is destroyed to clear the timer.
        (RunLoop::TimerBase::timerFiredCallback): Use the same callback for
        repeating and no repeating timers.
        (RunLoop::TimerBase::start): g_source_attach() increments the
        source reference counter, so use GRefPtr to make sure the source
        is freed.
        (RunLoop::TimerBase::stop): Use clearTimerSource().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-04 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 4 Apr 2011 08:33:47 +0000 (08:33 +0000)]
2011-04-04  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: introduce support of 'optional' flag for command arguments.
        https://bugs.webkit.org/show_bug.cgi?id=57698

        * inspector/protocol/runtime-agent-expected.txt:
        * inspector/protocol/runtime-agent.html:
        * inspector/report-API-errors-expected.txt:
        * inspector/report-API-errors.html:
        * inspector/report-protocol-errors-expected.txt:
2011-04-04  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: introduce support of 'optional' flag for command arguments.
        https://bugs.webkit.org/show_bug.cgi?id=57698

        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.json:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
        (WebCore::InspectorDebuggerAgent::setBreakpoint):
        (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorPageAgent.cpp:
        (WebCore::InspectorPageAgent::reloadPage):
        * inspector/InspectorPageAgent.h:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::getResourceContent):
        * inspector/InspectorResourceAgent.h:
        * inspector/InspectorRuntimeAgent.cpp:
        (WebCore::InspectorRuntimeAgent::evaluate):
        * inspector/InspectorRuntimeAgent.h:
        * inspector/generate-inspector-idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-04 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 4 Apr 2011 08:08:28 +0000 (08:08 +0000)]
2011-04-04  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: InjectedScriptManager should not try to access inspected window in case of workers
        https://bugs.webkit.org/show_bug.cgi?id=57637

        * bindings/js/JSInjectedScriptManager.cpp:
        (WebCore::InjectedScriptManager::injectedScriptFor):
        * bindings/v8/custom/V8InjectedScriptManager.cpp:
        (WebCore::InjectedScriptManager::injectedScriptFor):
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::InjectedScript):
        (WebCore::InjectedScript::canAccessInspectedWindow):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptManager.cpp:
        (WebCore::InjectedScriptManager::createForPage):
        (WebCore::InjectedScriptManager::createForWorker):
        (WebCore::InjectedScriptManager::InjectedScriptManager): access check function is passed as a parameter to the constructor
        and it depends on which type of context we're inspecting(worker or page).
        (WebCore::InjectedScriptManager::canAccessInspectedWorkerContext):
        * inspector/InjectedScriptManager.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-04 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Mon, 4 Apr 2011 07:16:16 +0000 (07:16 +0000)]
2011-04-04  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Eric Seidel.

        V8StringCallback.cpp requires V8Binding.h
        https://bugs.webkit.org/show_bug.cgi?id=57699

        No new tests required because of just adding header file.

        * bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-03 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 4 Apr 2011 06:41:05 +0000 (06:41 +0000)]
2011-04-03  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Adding a test of value sanitization for <input type=text>
        https://bugs.webkit.org/show_bug.cgi?id=57737

        * fast/forms/input-value-sanitization-expected.txt:
        * fast/forms/script-tests/input-value-sanitization.js: Add tests for type=text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-03 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Mon, 4 Apr 2011 05:40:42 +0000 (05:40 +0000)]
2011-04-03  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Eric Seidel.

        [CMAKE] Clean duplicated files in WebCore_Sources
        https://bugs.webkit.org/show_bug.cgi?id=57741

        No new tests, Only duplicated files were removed.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-03 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Mon, 4 Apr 2011 04:13:46 +0000 (04:13 +0000)]
2011-04-03  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Darin Adler.

        Fix 2-space indentation introduced in bug 54706.
        https://bugs.webkit.org/show_bug.cgi?id=57740

        No new tests - whitespace changes only.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        Convert 2-space indentation to 4-space indentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-03 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Mon, 4 Apr 2011 03:09:35 +0000 (03:09 +0000)]
2011-04-03  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Dimitri Glazkov.

        Make CSSStyleApplyProperty non-copyable
        https://bugs.webkit.org/show_bug.cgi?id=57738

        No new functionality added so no new tests required.

        * css/CSSStyleApplyProperty.h:
        Added WTF_MAKE_NONCOPYABLE(CSSStyleApplyProperty) to ensure singleton stays single.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
mitz@apple.com [Mon, 4 Apr 2011 02:21:38 +0000 (02:21 +0000)]
Build fix.

* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
* Shared/DictionaryPopupInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9227839> REGRESSION: Reproducible crash in Snow Leopard when trying...
mitz@apple.com [Mon, 4 Apr 2011 02:13:27 +0000 (02:13 +0000)]
<rdar://problem/9227839> REGRESSION: Reproducible crash in Snow Leopard when trying to show the Dictionary panel or application
https://bugs.webkit.org/show_bug.cgi?id=57739

Reviewed by Maciej Stachowiak.

* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode): Do not encode the options dictionary on Snow Leopard.
(WebKit::DictionaryPopupInfo::decode): Do not decode the options dictionary on Snow Leopard.
* Shared/DictionaryPopupInfo.h: Removed the options member variable on Snow Leopard.
* Shared/Plugins/PluginQuirks.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupForRange): Do not set the options member variable on
Snow Leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/images/extra-image-in-image-document.html crashes when run after embed-image...
mitz@apple.com [Sun, 3 Apr 2011 23:22:58 +0000 (23:22 +0000)]
fast/images/extra-image-in-image-document.html crashes when run after embed-image.html
https://bugs.webkit.org/show_bug.cgi?id=57733

Reviewed by Maciej Stachowiak.

The crash happens because resetting the page scale as part of preparing the WebView for the
next test triggered layout, which in turn caused a plug-in to make a resource request, and
DumpRenderTree's delegate to be dispatched. The delegate doesn't expect to be called between
tests, and it references the layout test controller, which is null.

* page/Frame.cpp:
(WebCore::Frame::scalePage): Avoid an unnecessary layout if the page scale isn't changing. This
is more efficient, and has the side effect of avoiding the crash in DumpRenderTree, although
DumpRenderTree could still crash when after a test with disabled plug-ins and a non-1 page scale.
I think there are currently no such tests, so I am not fixing DumpRenderTree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to make this test more robust.
mitz@apple.com [Sun, 3 Apr 2011 19:17:18 +0000 (19:17 +0000)]
Try to make this test more robust.

* fast/blockflow/broken-ideographic-font.html: Ensure that the font has been loaded before
letting the test finish.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-03 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 3 Apr 2011 12:37:40 +0000 (12:37 +0000)]
2011-04-03  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Teach InlineIterator how to work from any root, not just a RenderBlock
        https://bugs.webkit.org/show_bug.cgi?id=57726

        For implementing bidi-unicode: isolate, we need to be able to run the
        bidi algorithm over a subtree of inlines, not just from a block root.
        This is the first step in making this possible.

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::InlineIterator):
        (WebCore::InlineIterator::root):
        (WebCore::bidiNext):
        (WebCore::bidiFirst):
        (WebCore::InlineIterator::increment):
        (WebCore::InlineBidiResolver::appendRun):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-03 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 3 Apr 2011 08:29:40 +0000 (08:29 +0000)]
2011-04-03  Eric Seidel  <eric@webkit.org>

        Reviewed by Dan Bernstein.

        Split out handling of trailing spaces from layoutInlineChildren
        https://bugs.webkit.org/show_bug.cgi?id=57432

        There is much more we could split out from this function, but this is a start.

        I suspect this is very hot code.  Hopefully the compiler will do the right thing.
        If it doesn't the Chromium PLT bots will tell us.

        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::handleTrailingSpaces):
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sun, 3 Apr 2011 07:54:33 +0000 (07:54 +0000)]
2011-03-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        editing commands shouldn't run when there's no body
        https://bugs.webkit.org/show_bug.cgi?id=56771

        The bug was caused by WebKit's not checking the existence of root editable element
        in enabled* functions. Although isContentEditable returns true whenever we're in design mode,
        we should not run editing commands in a document without a body element editable because
        doing so results in appending a non-body element to the document node.

        Fixed the bug by modifying various enabled* functions to ensure we have a root editable element.
        New behavior tries to match that of Firefox except StyleWithCSS, which Firefox seems to ignore
        when there are no body element. Since StyleWithCSS is a document's state or property, we allow
        execCommand('StyleWithCSS') even in a document without a body element.

        WebKit's and Firefox's behaviors also deviate in insert-image-with-selecting-document.html.
        Whereas WebKit respects selection set by script and ignores execCommand, Firefox modifies
        the selection when document.write("x") is ran and successfully inserts image.

        Thus, empty-document-delete.html and empty-document-justify-right.html both pass on Firefox
        while empty-document-stylewithcss.html and insert-image-with-selecting-document.html both fail.

        Since Internet Explorer does not allow execCommand to run under design mode properly, we could
        not test its behavior.

        Tests: editing/editability/empty-document-delete.html
               editing/editability/empty-document-justify-right.html
               editing/editability/empty-document-stylewithcss.html
               editing/execCommand/insert-image-with-selecting-document.html

        * editing/Editor.cpp:
        (WebCore::Editor::canEdit): Verify that the root editable element exists
        instead of just checking that selection endpoints are editable because
        selection endpoints could be document node without a body element in design mode
        and we don't want to consider such a document editable.
        (WebCore::Editor::canDelete): Ditto.
        * editing/EditorCommand.cpp:
        (WebCore::enabledInEditableText): Ditto.
        (WebCore::enabledInRichlyEditableText): Ditto.
        (WebCore::enabledDelete): Call enabledCut and enabledInEditableText instead
        of duplicating the code in order to fix the same bug.
2011-03-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        editing commands shouldn't run when there's no body
        https://bugs.webkit.org/show_bug.cgi?id=56771

        Added tests to ensure WebKit does not crash when attempted to execute editing commands
        in an empty document. Also added a test to ensure WebKit does not crash when InsertImage
        is executed with selection endpoints being document. WebKit should ignore such attempts
        and should not crash.

        * editing/editability/empty-document-delete-expected.txt: Added.
        * editing/editability/empty-document-delete.html: Added.
        * editing/editability/empty-document-justify-right-expected.txt: Added.
        * editing/editability/empty-document-justify-right.html: Added.
        * editing/editability/empty-document-stylewithcss-expected.txt: Added.
        * editing/editability/empty-document-stylewithcss.html: Added.
        * editing/execCommand/insert-image-with-selecting-document-expected.txt: Added.
        * editing/execCommand/insert-image-with-selecting-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated results showing a progression after r82787. The current time display
mitz@apple.com [Sun, 3 Apr 2011 06:30:06 +0000 (06:30 +0000)]
Updated results showing a progression after r82787. The current time display
is now correctly collapsed because the timeline container is not wide enough.

* platform/gtk/media/video-zoom-controls-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated platform-specific results after r82787.
mitz@apple.com [Sun, 3 Apr 2011 06:22:02 +0000 (06:22 +0000)]
Updated platform-specific results after r82787.

* platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r82786): Media controls render incorrectly on GTK and Qt
mitz@apple.com [Sun, 3 Apr 2011 05:40:51 +0000 (05:40 +0000)]
REGRESSION (r82786): Media controls render incorrectly on GTK and Qt
https://bugs.webkit.org/show_bug.cgi?id=57719

Reviewed by Maciej Stachowiak.

r82786 exposed an incorrect assumption inRenderMediaControlTimeDisplay::layout()
that the timeline container is the parent of the time display. This is not true
with the GTK media style, where the current time display is an inline box, and
thus wrapped in an anonymous flexible box. The code was incorrectly considering
the width of the anonymous box and deciding to hide the time display. Prior to
r82786, this mistake was corrected by the call to computeLogicalWidth() in line layout.

* rendering/MediaControlElements.cpp:
(WebCore::RenderMediaControlTimeDisplay::layout): Changed to skip past anonymous ancestors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-02 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Sun, 3 Apr 2011 04:55:07 +0000 (04:55 +0000)]
2011-04-02  Nico Weber  <thakis@chromium.org>

        Reviewed by Adam Barth.

        Explicitly use icu namespace for ports building with U_USING_ICU_NAMESPACE=0

        By default, ICU includes |using namespace icu;| in its header files
        for backwards compatibility. Clients can define
        U_USING_ICU_NAMESPACE=0 to tell ICU to not do this. Prefixing all ICU
        classes with |icu::| makes this file compile no matter what
        U_USING_ICU_NAMESPACE is set to.

        https://bugs.webkit.org/show_bug.cgi?id=57715

        * platform/text/LocalizedNumberICU.cpp:
        (WebCore::createFormatterForCurrentLocale):
        (WebCore::numberFormatter):
        (WebCore::parseLocalizedNumber):
        (WebCore::formatLocalizedNumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove an unnecessary extra computeLogicalWidth() from line layout
mitz@apple.com [Sun, 3 Apr 2011 01:47:22 +0000 (01:47 +0000)]
Remove an unnecessary extra computeLogicalWidth() from line layout
https://bugs.webkit.org/show_bug.cgi?id=57711

Reviewed by Dave Hyatt.

Source/WebCore:

Changes in behavior (MathML progression) covered by existing layout tests.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
call to computeLogicalWidth(). Because of <http://webkit.org/b/57700>, this
actually prevents MathML rows from reverting to an incorrect width.

LayoutTests:

These updated expected results show progressions in MathML tests.
fast/table/colspanMinWidth-vertical results changed to show that text controls
still do not handle vertical writing modes correctly.

* platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.checksum:
* platform/mac/mathml/presentation/fractions-expected.png:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/roots-expected.checksum:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.checksum:
* platform/mac/mathml/presentation/row-alignment-expected.png:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.checksum:
* platform/mac/mathml/presentation/subsup-expected.png:
* platform/mac/mathml/presentation/subsup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated platform-specific results after r82873.
mitz@apple.com [Sun, 3 Apr 2011 01:43:47 +0000 (01:43 +0000)]
Updated platform-specific results after r82873.

* platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-1-expected.txt:
* platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-10-expected.txt:
* platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-2-expected.txt:
* platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-3-expected.txt:
* platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-4-expected.txt:
* platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-5-expected.txt:
* platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-6-expected.txt:
* platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-7-expected.txt:
* platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-8-expected.txt:
* platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-9-expected.txt:
* platform/gtk/fast/html/details-no-summary1-expected.txt:
* platform/gtk/fast/html/details-no-summary2-expected.txt:
* platform/gtk/fast/html/details-no-summary3-expected.txt:
* platform/gtk/fast/html/details-no-summary4-expected.txt:
* platform/gtk/fast/html/details-open-javascript-expected.txt:
* platform/gtk/fast/html/details-open1-expected.txt:
* platform/gtk/fast/html/details-open2-expected.txt:
* platform/gtk/fast/html/details-open3-expected.txt:
* platform/gtk/fast/html/details-open4-expected.txt:
* platform/gtk/fast/html/details-open5-expected.txt:
* platform/gtk/fast/html/details-open6-expected.txt:
* platform/gtk/fast/html/details-position-expected.txt:
* platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-1-expected.txt:
* platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-2-expected.txt:
* platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-3-expected.txt:
* platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-4-expected.txt:
* platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-5-expected.txt:
* platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-6-expected.txt:
* platform/gtk/fast/html/details-writing-mode-expected.txt:
* platform/qt/fast/html/details-add-summary-1-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-1-expected.txt:
* platform/qt/fast/html/details-add-summary-10-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-10-expected.txt:
* platform/qt/fast/html/details-add-summary-2-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-2-expected.txt:
* platform/qt/fast/html/details-add-summary-3-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-3-expected.txt:
* platform/qt/fast/html/details-add-summary-4-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-4-expected.txt:
* platform/qt/fast/html/details-add-summary-5-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-5-expected.txt:
* platform/qt/fast/html/details-add-summary-6-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-6-expected.txt:
* platform/qt/fast/html/details-add-summary-7-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-7-expected.txt:
* platform/qt/fast/html/details-add-summary-8-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-8-expected.txt:
* platform/qt/fast/html/details-add-summary-9-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-9-expected.txt:
* platform/qt/fast/html/details-no-summary1-expected.txt:
* platform/qt/fast/html/details-no-summary2-expected.txt:
* platform/qt/fast/html/details-no-summary3-expected.txt:
* platform/qt/fast/html/details-no-summary4-expected.txt:
* platform/qt/fast/html/details-open-javascript-expected.txt:
* platform/qt/fast/html/details-open1-expected.txt:
* platform/qt/fast/html/details-open2-expected.txt:
* platform/qt/fast/html/details-open3-expected.txt:
* platform/qt/fast/html/details-open4-expected.txt:
* platform/qt/fast/html/details-open5-expected.txt:
* platform/qt/fast/html/details-open6-expected.txt:
* platform/qt/fast/html/details-position-expected.txt:
* platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-1-expected.txt:
* platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-2-expected.txt:
* platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-3-expected.txt:
* platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-4-expected.txt:
* platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-5-expected.txt:
* platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-6-expected.txt:
* platform/qt/fast/html/details-writing-mode-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFor Dan!
bdakin@apple.com [Sun, 3 Apr 2011 00:47:44 +0000 (00:47 +0000)]
For Dan!
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):

Rubber-stamped by Geoff Garen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<details> marker loses its margin
mitz@apple.com [Sun, 3 Apr 2011 00:34:42 +0000 (00:34 +0000)]
<details> marker loses its margin
https://bugs.webkit.org/show_bug.cgi?id=57713

Reviewed by Beth Dakin.

Source/WebCore:

* rendering/RenderDetails.cpp:
(WebCore::RenderDetails::computePreferredLogicalWidths): Override to update
the marker location.
* rendering/RenderDetails.h:
(WebCore::RenderDetails::renderName): Made private.
(WebCore::RenderDetails::isDetails): Ditto.
* rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::computePreferredLogicalWidths): Set the margins
in the style, like RenderListMarker does.
(WebCore::RenderDetailsMarker::layout): Set the margins from the style.

LayoutTests:

* platform/mac/fast/html/details-add-summary-1-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-1-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-1-expected.checksum:
* platform/mac/fast/html/details-add-summary-1-expected.png:
* platform/mac/fast/html/details-add-summary-1-expected.txt:
* platform/mac/fast/html/details-add-summary-10-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-10-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-10-expected.checksum:
* platform/mac/fast/html/details-add-summary-10-expected.png:
* platform/mac/fast/html/details-add-summary-10-expected.txt:
* platform/mac/fast/html/details-add-summary-2-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-2-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-2-expected.checksum:
* platform/mac/fast/html/details-add-summary-2-expected.png:
* platform/mac/fast/html/details-add-summary-2-expected.txt:
* platform/mac/fast/html/details-add-summary-3-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-3-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-3-expected.checksum:
* platform/mac/fast/html/details-add-summary-3-expected.png:
* platform/mac/fast/html/details-add-summary-3-expected.txt:
* platform/mac/fast/html/details-add-summary-4-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-4-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-4-expected.checksum:
* platform/mac/fast/html/details-add-summary-4-expected.png:
* platform/mac/fast/html/details-add-summary-4-expected.txt:
* platform/mac/fast/html/details-add-summary-5-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-5-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-5-expected.checksum:
* platform/mac/fast/html/details-add-summary-5-expected.png:
* platform/mac/fast/html/details-add-summary-5-expected.txt:
* platform/mac/fast/html/details-add-summary-6-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-6-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-6-expected.checksum:
* platform/mac/fast/html/details-add-summary-6-expected.png:
* platform/mac/fast/html/details-add-summary-6-expected.txt:
* platform/mac/fast/html/details-add-summary-7-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-7-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-7-expected.checksum:
* platform/mac/fast/html/details-add-summary-7-expected.png:
* platform/mac/fast/html/details-add-summary-7-expected.txt:
* platform/mac/fast/html/details-add-summary-8-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-8-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-8-expected.checksum:
* platform/mac/fast/html/details-add-summary-8-expected.png:
* platform/mac/fast/html/details-add-summary-8-expected.txt:
* platform/mac/fast/html/details-add-summary-9-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-9-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-9-expected.checksum:
* platform/mac/fast/html/details-add-summary-9-expected.png:
* platform/mac/fast/html/details-add-summary-9-expected.txt:
* platform/mac/fast/html/details-no-summary1-expected.checksum:
* platform/mac/fast/html/details-no-summary1-expected.png:
* platform/mac/fast/html/details-no-summary1-expected.txt:
* platform/mac/fast/html/details-no-summary2-expected.checksum:
* platform/mac/fast/html/details-no-summary2-expected.png:
* platform/mac/fast/html/details-no-summary2-expected.txt:
* platform/mac/fast/html/details-no-summary3-expected.checksum:
* platform/mac/fast/html/details-no-summary3-expected.png:
* platform/mac/fast/html/details-no-summary3-expected.txt:
* platform/mac/fast/html/details-no-summary4-expected.checksum:
* platform/mac/fast/html/details-no-summary4-expected.png:
* platform/mac/fast/html/details-no-summary4-expected.txt:
* platform/mac/fast/html/details-open-javascript-expected.checksum:
* platform/mac/fast/html/details-open-javascript-expected.png:
* platform/mac/fast/html/details-open-javascript-expected.txt:
* platform/mac/fast/html/details-open1-expected.checksum:
* platform/mac/fast/html/details-open1-expected.png:
* platform/mac/fast/html/details-open1-expected.txt:
* platform/mac/fast/html/details-open2-expected.checksum:
* platform/mac/fast/html/details-open2-expected.png:
* platform/mac/fast/html/details-open2-expected.txt:
* platform/mac/fast/html/details-open3-expected.checksum:
* platform/mac/fast/html/details-open3-expected.png:
* platform/mac/fast/html/details-open3-expected.txt:
* platform/mac/fast/html/details-open4-expected.checksum:
* platform/mac/fast/html/details-open4-expected.png:
* platform/mac/fast/html/details-open4-expected.txt:
* platform/mac/fast/html/details-open5-expected.checksum:
* platform/mac/fast/html/details-open5-expected.png:
* platform/mac/fast/html/details-open5-expected.txt:
* platform/mac/fast/html/details-open6-expected.checksum:
* platform/mac/fast/html/details-open6-expected.png:
* platform/mac/fast/html/details-open6-expected.txt:
* platform/mac/fast/html/details-position-expected.checksum:
* platform/mac/fast/html/details-position-expected.png:
* platform/mac/fast/html/details-position-expected.txt:
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.checksum:
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.png:
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-1-expected.checksum:
* platform/mac/fast/html/details-remove-summary-1-expected.png:
* platform/mac/fast/html/details-remove-summary-1-expected.txt:
* platform/mac/fast/html/details-remove-summary-2-and-click-expected.checksum:
* platform/mac/fast/html/details-remove-summary-2-and-click-expected.png:
* platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-2-expected.checksum:
* platform/mac/fast/html/details-remove-summary-2-expected.png:
* platform/mac/fast/html/details-remove-summary-2-expected.txt:
* platform/mac/fast/html/details-remove-summary-3-and-click-expected.checksum:
* platform/mac/fast/html/details-remove-summary-3-and-click-expected.png:
* platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-3-expected.checksum:
* platform/mac/fast/html/details-remove-summary-3-expected.png:
* platform/mac/fast/html/details-remove-summary-3-expected.txt:
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.checksum:
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.png:
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-4-expected.checksum:
* platform/mac/fast/html/details-remove-summary-4-expected.png:
* platform/mac/fast/html/details-remove-summary-4-expected.txt:
* platform/mac/fast/html/details-remove-summary-5-and-click-expected.checksum:
* platform/mac/fast/html/details-remove-summary-5-and-click-expected.png:
* platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-5-expected.checksum:
* platform/mac/fast/html/details-remove-summary-5-expected.png:
* platform/mac/fast/html/details-remove-summary-5-expected.txt:
* platform/mac/fast/html/details-remove-summary-6-and-click-expected.checksum:
* platform/mac/fast/html/details-remove-summary-6-and-click-expected.png:
* platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-6-expected.checksum:
* platform/mac/fast/html/details-remove-summary-6-expected.png:
* platform/mac/fast/html/details-remove-summary-6-expected.txt:
* platform/mac/fast/html/details-writing-mode-expected.checksum:
* platform/mac/fast/html/details-writing-mode-expected.png:
* platform/mac/fast/html/details-writing-mode-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed to reset the scale, much like zoom.
bdakin@apple.com [Sun, 3 Apr 2011 00:19:41 +0000 (00:19 +0000)]
Need to reset the scale, much like zoom.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):

Rubber-stamped by Geoff Garen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-02 Andy Estes <aestes@apple.com>
aestes@apple.com [Sun, 3 Apr 2011 00:01:42 +0000 (00:01 +0000)]
2011-04-02  Andy Estes  <aestes@apple.com>

        Reviewed by Oliver Hunt.

        REGRESSION (r69237): Black border around map elements while using an image map on Mac platform
        https://bugs.webkit.org/show_bug.cgi?id=52518

        Test: fast/images/imagemap-focus-ring-zero-outline-width.html

        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintAreaElementFocusRing): Return early if outlineWidth is 0.
2011-04-02  Andy Estes  <aestes@apple.com>

        Reviewed by Oliver Hunt.

        REGRESSION (r69237): Black border around map elements while using an image map on Mac platform
        https://bugs.webkit.org/show_bug.cgi?id=52518

        * fast/images/imagemap-focus-ring-zero-outline-width.html: Added.
        * platform/mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.checksum: Added.
        * platform/mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
        * platform/mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=57605
bdakin@apple.com [Sat, 2 Apr 2011 23:46:28 +0000 (23:46 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57605
Frame::pageScaleFactor() should not affect getBoundingClientRect() or
getClientRects()
-and corresponding-
<rdar://problem/9194541>

Source/WebKit2:

Patch by Sam Weinig <sam@webkit.org> on 2011-04-02
Reviewed by Beth Dakin.

Add DRT support for the scaleWebView SPI.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetScaleAtOrigin):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Tools:

Patch by Sam Weinig <sam@webkit.org> on 2011-04-02
Reviewed by Beth Dakin.

Add DRT support for the scaleWebView SPI.
* DumpRenderTree/mac/EventSendingController.mm:
(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):
(-[EventSendingController scalePageBy:atX:andY:]):
* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::scalePageBy):
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::reset):

LayoutTests:

Reviewed by Sam Weinig.

* fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Added.
* fast/dom/Element/scale-page-bounding-client-rect.html: Added.
* fast/dom/Element/scale-page-client-rects-expected.txt: Added.
* fast/dom/Element/scale-page-client-rects.html: Added.
* fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Added.
* fast/dom/Range/scale-page-bounding-client-rect.html: Added.
* fast/dom/Range/scale-page-client-rects-expected.txt: Added.
* fast/dom/Range/scale-page-client-rects.html: Added.
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-02 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 2 Apr 2011 23:19:51 +0000 (23:19 +0000)]
2011-04-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        "Search in Spotlight" broken in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=57712

        Proxy spotlight searching to the UIProcess.

        * UIProcess/WebPageProxy.messages.in:
        Add new message. Re-organize messages to put all mac specific ones together.

        * UIProcess/WebPageProxy.h:
        * UIProcess/mac/WebPageProxyMac.mm:
        (WebKit::WebPageProxy::speak):
        (WebKit::WebPageProxy::searchWithSpotlight):
        Moved code to trigger spotlight here. Use WTF::String -> NSString conversion function
        instead of relying on the built in conversion since it doesn't always work in the UIProcess.

        * WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
        (WebKit::WebContextMenuClient::searchWithSpotlight):
        Post message to the UIProcess to do the searching.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=57605
bdakin@apple.com [Sat, 2 Apr 2011 22:36:50 +0000 (22:36 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57605
Frame::pageScaleFactor() should not affect getBoundingClientRect() or
getClientRects()
-and corresponding-
<rdar://problem/9194541>

Reviewed by Sam Weinig.

New functions adjust*ForPageScale() are analogous to adjust*ForAbsoluteZoom().
* dom/Element.cpp:
(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):
* dom/Range.cpp:
(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):
(WebCore::Range::getBorderAndTextQuads):
* rendering/RenderObject.h:
(WebCore::adjustFloatPointForPageScale):
(WebCore::adjustFloatQuadForPageScale):
(WebCore::adjustFloatRectForPageScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReverted r82775 due to changes in <details> test results, which are
mitz@apple.com [Sat, 2 Apr 2011 22:21:19 +0000 (22:21 +0000)]
Reverted r82775 due to changes in <details> test results, which are
likely progressions.

Source/WebCore:

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a

LayoutTests:

* platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.checksum:
* platform/mac/mathml/presentation/fractions-expected.png:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/roots-expected.checksum:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.checksum:
* platform/mac/mathml/presentation/row-alignment-expected.png:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.checksum:
* platform/mac/mathml/presentation/subsup-expected.png:
* platform/mac/mathml/presentation/subsup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-02 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Sat, 2 Apr 2011 22:00:19 +0000 (22:00 +0000)]
2011-04-02  Jeff Miller  <jeffm@apple.com>

        Reviewed by Dan Bernstein.

        WebKit2: Specify the certificate store in WKBundleSetClientCertificate()
        https://bugs.webkit.org/show_bug.cgi?id=57707

        Include the name of the system certificate store that the client certificate came from in WKBundleSetClientCertificate().

        The PCCERT_CONTEXT for the client certificate we create from the message from the UI process doesn't contain enough information to actually use it in a request, we need to get the real certificate from the certificate store (which is typically the "MY" store).

        * WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.cpp:
        (WKBundleSetClientCertificate): Add certificateSystemStoreName to parameters.
        * WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.h: Add certificateSystemStoreName to WKBundleSetClientCertificate() parameters.
        * WebProcess/InjectedBundle/InjectedBundle.h: Add certificateSystemStoreName to setClientCertificate() parameters.
        * WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
        (WebKit::InjectedBundle::setClientCertificate): Read the real certificate from the certificate store.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove an unnecessary extra computeLogicalWidth() from line layout
mitz@apple.com [Sat, 2 Apr 2011 21:37:11 +0000 (21:37 +0000)]
Remove an unnecessary extra computeLogicalWidth() from line layout
https://bugs.webkit.org/show_bug.cgi?id=57711

Reviewed by Dave Hyatt.

Source/WebCore:

Changes in behavior (MathML progression) covered by existing layout tests.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
call to computeLogicalWidth(). Because of <http://webkit.org/b/57700>, this
actually prevents MathML rows from reverting to an incorrect width.

LayoutTests:

These updated expected results show progressions in MathML tests.
fast/table/colspanMinWidth-vertical results changed to show that text controls
still do not handle vertical writing modes correctly.

* platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.checksum:
* platform/mac/mathml/presentation/fractions-expected.png:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/roots-expected.checksum:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.checksum:
* platform/mac/mathml/presentation/row-alignment-expected.png:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.checksum:
* platform/mac/mathml/presentation/subsup-expected.png:
* platform/mac/mathml/presentation/subsup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-02 Dominic Cooney <dominicc@google.com>
commit-queue@webkit.org [Sat, 2 Apr 2011 20:56:11 +0000 (20:56 +0000)]
2011-04-02  Dominic Cooney  <dominicc@google.com>

        Reviewed by Martin Robinson.

        Add layoutTestController.shadowRoot to GTK DumpRenderTree.
        https://bugs.webkit.org/show_bug.cgi?id=57551

        * platform/gtk/Skipped: unskip test that accesses shadowRoot
2011-04-02  Dominic Cooney  <dominicc@google.com>

        Reviewed by Martin Robinson.

        Add layoutTestController.shadowRoot to GTK DumpRenderTree.
        https://bugs.webkit.org/show_bug.cgi?id=57551

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::shadowRoot):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-04-02  Dominic Cooney  <dominicc@google.com>

        Reviewed by Martin Robinson.

        Add layoutTestController.shadowRoot to GTK DumpRenderTree.
        https://bugs.webkit.org/show_bug.cgi?id=57551

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::shadowRoot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-02 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 2 Apr 2011 20:30:01 +0000 (20:30 +0000)]
2011-04-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Implement WKBundleFrameHasHorizontalScrollbar/WKBundleFrameHasVerticalScrollbar
        <rdar://problem/9225772>
        https://bugs.webkit.org/show_bug.cgi?id=57709

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameHasHorizontalScrollbar):
        (WKBundleFrameHasVerticalScrollbar):
        * WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::hasHorizontalScrollbar):
        (WebKit::WebFrame::hasVerticalScrollbar):
        * WebProcess/WebPage/WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-02 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Sat, 2 Apr 2011 19:22:07 +0000 (19:22 +0000)]
2011-04-02  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Martin Robinson.

        [GTK] Fix leaked pointer in FontGtk.cpp
        https://bugs.webkit.org/show_bug.cgi?id=57307

        Fix a memory leak.

        No new functionality, so no new tests.

        * platform/graphics/gtk/FontGtk.cpp:
        (WebCore::utf16ToUtf8): Rename utf16_to_utf8 and fix indentation.
        (WebCore::convertUniCharToUTF8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-02 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 2 Apr 2011 12:15:35 +0000 (12:15 +0000)]
2011-04-02  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Remove AbstractStep._run_script and move script names to ports.py
        https://bugs.webkit.org/show_bug.cgi?id=57704

        Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.

        * Scripts/webkitpy/common/config/ports.py:
        * Scripts/webkitpy/tool/commands/download_unittest.py:
        * Scripts/webkitpy/tool/commands/roll_unittest.py:
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        * Scripts/webkitpy/tool/steps/abstractstep.py:
        * Scripts/webkitpy/tool/steps/checkstyle.py:
        * Scripts/webkitpy/tool/steps/preparechangelog.py:
        * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
        * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-02 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 2 Apr 2011 11:18:57 +0000 (11:18 +0000)]
2011-04-02  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Emulate shebang on Win32
        https://bugs.webkit.org/show_bug.cgi?id=55927

        Scripts on Windows work only if they are called with the explicit interpreter.
        Read the first line of scripts to detect the correct executable.

        * Scripts/webkitpy/common/config/ports.py:
        * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
        * Scripts/webkitpy/common/system/executive_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-02 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Sat, 2 Apr 2011 07:48:27 +0000 (07:48 +0000)]
2011-04-02  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: we should be able to have in and out arguments of a command with same name.
        https://bugs.webkit.org/show_bug.cgi?id=57701

        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Anantanarayanan G Iyengar <ananta@chromium.org>
commit-queue@webkit.org [Sat, 2 Apr 2011 06:52:44 +0000 (06:52 +0000)]
2011-04-01  Anantanarayanan G Iyengar  <ananta@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=57693
        Skipped the windowless_plugin_paint_test.html layout test on Webkit Windows.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Sat, 2 Apr 2011 06:02:09 +0000 (06:02 +0000)]
2011-04-01  Ilya Tikhonovsky  <loislo@chromium.org>

        Not reviewed trivial change.

        Web Inspector: The page agent should be enabled even if JAVASCRIPT_DEBUGGER is off.
        Followup change for r82281.
        https://bugs.webkit.org/show_bug.cgi?id=57327

        * inspector/InspectorPageAgent.cpp:
        * inspector/InspectorPageAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 2 Apr 2011 05:20:53 +0000 (05:20 +0000)]
2011-04-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        apos entities shouldn't show up in ChangeLogs when using webkit-patch
        https://bugs.webkit.org/show_bug.cgi?id=57692

        Previously, we were using BeautifulSoup to process XML from
        bugs.webkit.org, but that's incorrect.  We should be using
        BeautifulStoneSoup to process the XML.  We were getting the &apos;
        entity wrong because &apos; is an XML entity but not an HTML entity.

        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 2 Apr 2011 03:44:20 +0000 (03:44 +0000)]
2011-04-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Skip the test landed in r82758, since WebKitTestRunner doesn't implement
        displayInvalidatedRegion.

        * platform/mac-wk2/Skipped: Skipped the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Sat, 2 Apr 2011 03:32:19 +0000 (03:32 +0000)]
2011-04-01  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        Cached Resource Overhead Space Usage and Accounting Inaccurate
        https://bugs.webkit.org/show_bug.cgi?id=57488

        Fixed windows test failures.
        Changed the fixed overhead value for ResourceResponse to 3800 bytes.
        Modified ResourceResponse::platformLazyInit() to handle "base" level
        attributes or all attributes.  The base attributes, like URL, status
        code, mime type and a few header fields (mostly cache related) are
        suitable for most resources.  This reduces the per resource memory
        needs by over 1K bytes per resource thus saving memory in the cache.
        Collectively, these two changes bring the overhead memory calculation
        in line with reality.

        No new tests added due to existing tests cover areas of change and
        there is no functional change.  The change is limited to reducing
        memory usage along existing paths.

        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::canUseCacheValidator):
        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::adopt):
        (WebCore::ResourceResponseBase::isHTTP):
        (WebCore::ResourceResponseBase::url):
        (WebCore::ResourceResponseBase::setURL):
        (WebCore::ResourceResponseBase::mimeType):
        (WebCore::ResourceResponseBase::setMimeType):
        (WebCore::ResourceResponseBase::expectedContentLength):
        (WebCore::ResourceResponseBase::setExpectedContentLength):
        (WebCore::ResourceResponseBase::textEncodingName):
        (WebCore::ResourceResponseBase::setTextEncodingName):
        (WebCore::ResourceResponseBase::suggestedFilename):
        (WebCore::ResourceResponseBase::setSuggestedFilename):
        (WebCore::ResourceResponseBase::httpStatusCode):
        (WebCore::ResourceResponseBase::setHTTPStatusCode):
        (WebCore::ResourceResponseBase::httpStatusText):
        (WebCore::ResourceResponseBase::setHTTPStatusText):
        (WebCore::ResourceResponseBase::httpHeaderField):
        (WebCore::ResourceResponseBase::setHTTPHeaderField):
        (WebCore::ResourceResponseBase::httpHeaderFields):
        (WebCore::ResourceResponseBase::parseCacheControlDirectives):
        (WebCore::ResourceResponseBase::hasCacheValidatorFields):
        (WebCore::ResourceResponseBase::date):
        (WebCore::ResourceResponseBase::age):
        (WebCore::ResourceResponseBase::expires):
        (WebCore::ResourceResponseBase::lastModified):
        (WebCore::ResourceResponseBase::isAttachment):
        (WebCore::ResourceResponseBase::setLastModifiedDate):
        (WebCore::ResourceResponseBase::lastModifiedDate):
        (WebCore::ResourceResponseBase::wasCached):
        (WebCore::ResourceResponseBase::connectionReused):
        (WebCore::ResourceResponseBase::setConnectionReused):
        (WebCore::ResourceResponseBase::connectionID):
        (WebCore::ResourceResponseBase::setConnectionID):
        (WebCore::ResourceResponseBase::resourceLoadTiming):
        (WebCore::ResourceResponseBase::setResourceLoadTiming):
        (WebCore::ResourceResponseBase::resourceLoadInfo):
        (WebCore::ResourceResponseBase::setResourceLoadInfo):
        (WebCore::ResourceResponseBase::lazyInit):
        * platform/network/ResourceResponseBase.h:
        (WebCore::ResourceResponseBase::platformLazyInit):
        * platform/network/cf/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        (WebCore::ResourceResponse::memoryUsage):
        * platform/network/cf/ResourceResponseCFNet.cpp:
        (WebCore::ResourceResponse::platformLazyInit):
        * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::platformLazyInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Jon Lee <jonlee@apple.com>
commit-queue@webkit.org [Sat, 2 Apr 2011 02:43:24 +0000 (02:43 +0000)]
2011-04-01  Jon Lee  <jonlee@apple.com>

        Reviewed by Darin Adler.

        WebKit2: Type-to-select doesn't work in open <select> menu (53023)
        https://bugs.webkit.org/show_bug.cgi?id=53023
        <rdar://problem/8907678>

        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in: adding new setPopupMenuSelectedIndex message for windows platform
        * UIProcess/win/WebPageProxyWin.cpp:
        (WebKit::WebPageProxy::setPopupMenuSelectedIndex):
        * UIProcess/win/WebPopupMenuProxyWin.h: moving setFocusedIndex() into public method
        * WebProcess/WebCoreSupport/WebPopupMenu.cpp:
        (WebKit::WebPopupMenu::updateFromElement): send message back to UIProcess to update the selected element

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 2 Apr 2011 02:43:07 +0000 (02:43 +0000)]
2011-04-01  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Skipping fast/workers/dedicated-worker-lifecycle instead of
        treating it as SLOW. It appears to be downright flaky.

        https://bugs.webkit.org/show_bug.cgi?id=57678

        * platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 2 Apr 2011 02:42:31 +0000 (02:42 +0000)]
2011-04-01  Adam Barth  <abarth@webkit.org>

        This test fails by timing out.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofix bug number
dpranke@chromium.org [Sat, 2 Apr 2011 02:23:17 +0000 (02:23 +0000)]
fix bug number

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 2 Apr 2011 02:18:28 +0000 (02:18 +0000)]
2011-04-01  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Suppress some flaky bidi- and editing-related test failures on
        SL Mac NRWT runs. See:

        https://bugs.webkit.org/show_bug.cgi?id=57662

        * platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Anantanarayanan G Iyengar <ananta@chromium.org>
commit-queue@webkit.org [Sat, 2 Apr 2011 02:03:23 +0000 (02:03 +0000)]
2011-04-01  Anantanarayanan G Iyengar  <ananta@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=45855
        Windowless plugins added dynamically to the DOM should receive paint events.
        This is done by ensuring that the plugin widget is marked for painting when
        it is added. Added a layout test which verifies that a dynamically added plugin
        receives a paint event. This test has to be skipped on chromium mac/linux and
        on gtk and qt as it relies on support for the displayInvalidatedRegion function
        in the LayoutTestController

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * plugins/windowless_plugin_paint_test-expected.txt: Added.
        * plugins/windowless_plugin_paint_test.html: Added.
2011-04-01  Anantanarayanan G Iyengar  <ananta@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=45855
        Windowless plugins added dynamically to the DOM should receive paint events.
        This is done by ensuring that the plugin widget is marked for painting when
        it is added.

        Test: plugins/windowless_plugin_paint_test.html

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::setWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sat, 2 Apr 2011 01:45:45 +0000 (01:45 +0000)]
2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82721.
        http://trac.webkit.org/changeset/82721
        https://bugs.webkit.org/show_bug.cgi?id=57687

        This patch introduced assertion failures on the GTK+ bots.
        (Requested by mrobinson on #webkit).

        * platform/gtk/Skipped:
2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82721.
        http://trac.webkit.org/changeset/82721
        https://bugs.webkit.org/show_bug.cgi?id=57687

        This patch introduced assertion failures on the GTK+ bots.
        (Requested by mrobinson on #webkit).

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82721.
        http://trac.webkit.org/changeset/82721
        https://bugs.webkit.org/show_bug.cgi?id=57687

        This patch introduced assertion failures on the GTK+ bots.
        (Requested by mrobinson on #webkit).

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::shadowRoot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed buildfix.
ossy@webkit.org [Sat, 2 Apr 2011 01:43:31 +0000 (01:43 +0000)]
Unreviewed buildfix.

[Qt][WK2] Build Webkit2 using "-2" option on Qt
https://bugs.webkit.org/show_bug.cgi?id=55074

* Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
(The isWK2() function removes it from @ARGV, but not from @options.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Keith Kyzivat <keith.kyzivat@nokia.com>
commit-queue@webkit.org [Sat, 2 Apr 2011 01:40:56 +0000 (01:40 +0000)]
2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>

        Reviewed by Csaba Osztrogonác.

        [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
        https://bugs.webkit.org/show_bug.cgi?id=57666

        * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 2 Apr 2011 01:23:15 +0000 (01:23 +0000)]
2011-04-01  Adam Barth  <abarth@webkit.org>

        Attempt to fix the Chromium build using the great and powerful git.
        This patch should be the remaining part of reverting Jeremy's ill-fated
        refactoring.

        * src/IDBDatabaseProxy.cpp:
        (WebCore::IDBDatabaseProxy::create):
        (WebCore::IDBDatabaseProxy::IDBDatabaseProxy):
        (WebCore::IDBDatabaseProxy::~IDBDatabaseProxy):
        (WebCore::IDBDatabaseProxy::name):
        (WebCore::IDBDatabaseProxy::version):
        (WebCore::IDBDatabaseProxy::objectStoreNames):
        (WebCore::IDBDatabaseProxy::createObjectStore):
        (WebCore::IDBDatabaseProxy::deleteObjectStore):
        (WebCore::IDBDatabaseProxy::setVersion):
        (WebCore::IDBDatabaseProxy::transaction):
        (WebCore::IDBDatabaseProxy::close):
        (WebCore::IDBDatabaseProxy::open):
        * src/IDBDatabaseProxy.h:
        * src/IDBObjectStoreProxy.cpp:
        (WebCore::IDBObjectStoreProxy::create):
        (WebCore::IDBObjectStoreProxy::IDBObjectStoreProxy):
        (WebCore::IDBObjectStoreProxy::~IDBObjectStoreProxy):
        (WebCore::IDBObjectStoreProxy::name):
        (WebCore::IDBObjectStoreProxy::keyPath):
        (WebCore::IDBObjectStoreProxy::indexNames):
        (WebCore::IDBObjectStoreProxy::get):
        (WebCore::IDBObjectStoreProxy::put):
        (WebCore::IDBObjectStoreProxy::deleteFunction):
        (WebCore::IDBObjectStoreProxy::clear):
        (WebCore::IDBObjectStoreProxy::createIndex):
        (WebCore::IDBObjectStoreProxy::index):
        (WebCore::IDBObjectStoreProxy::deleteIndex):
        (WebCore::IDBObjectStoreProxy::openCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 2 Apr 2011 00:55:22 +0000 (00:55 +0000)]
2011-04-01  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        new-run-webkit-tests: fix feature detection, skipped platform lists on mac

        We apparently never implemented the code to skip tests based on
        what was compiled into DRT. Also, change the logic used to skip
        platform directories to match what old-run-webkit-tests does:
        skip every test not in a directory in the baseline search path.

        https://bugs.webkit.org/show_bug.cgi?id=57662

        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
mrowe@apple.com [Sat, 2 Apr 2011 00:40:02 +0000 (00:40 +0000)]
<webkit.org/b/56730> new-run-webkit-tests fails on Lion seed

Reviewed by Jon Honeycutt.

Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.

* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Mike Reed <reed@google.com>
commit-queue@webkit.org [Sat, 2 Apr 2011 00:36:18 +0000 (00:36 +0000)]
2011-04-01  Mike Reed  <reed@google.com>

        Reviewed by James Robinson.

        always use native font rendering on skia_gpu
        fixes a crash when SKIA_GPU is enabled, as we can't call getTopPlatformDevice()
        https://bugs.webkit.org/show_bug.cgi?id=57663

        No new tests. existing rendering tests will exercise this

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 2 Apr 2011 00:35:59 +0000 (00:35 +0000)]
2011-04-01  Adam Barth  <abarth@webkit.org>

        Move these files back to their old locations.  I'm not sure why the
        rollout didn't move them properly.

        * src/IDBDatabaseBackendProxy.cpp: Removed.
        * src/IDBDatabaseBackendProxy.h: Removed.
        * src/IDBDatabaseProxy.cpp: Copied from Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp.
        * src/IDBDatabaseProxy.h: Copied from Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h.
        * src/IDBObjectStoreBackendProxy.cpp: Removed.
        * src/IDBObjectStoreProxy.cpp: Copied from Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler.
ap@apple.com [Sat, 2 Apr 2011 00:27:29 +0000 (00:27 +0000)]
    Reviewed by Darin Adler.

        REGRESSION: Assertion failure when executing a complex custom key binding
        https://bugs.webkit.org/show_bug.cgi?id=57681

        Also completes the fix for
        <rdar://problem/9063782> WebKit2: Text fields in Safari don't honor custom key bindings

        * UIProcess/API/mac/WKView.mm: (-[WKView hasMarkedText]): There is no need to execute saved
        commands when they can't possibly change the result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Sat, 2 Apr 2011 00:09:38 +0000 (00:09 +0000)]
2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82738.
        http://trac.webkit.org/changeset/82738
        https://bugs.webkit.org/show_bug.cgi?id=57684

        Broke storage/indexeddb/objectstore-autoincrement.html and
        InjectIDBKey (Requested by abarth|gardening on #webkit).

        * WebKit.gyp:
        * src/IDBCallbacksProxy.cpp:
        (WebCore::IDBCallbacksProxy::create):
        (WebCore::IDBCallbacksProxy::IDBCallbacksProxy):
        (WebCore::IDBCallbacksProxy::onError):
        (WebCore::IDBCallbacksProxy::onSuccess):
        * src/IDBCallbacksProxy.h:
        * src/IDBCursorBackendProxy.cpp:
        (WebCore::IDBCursorBackendProxy::create):
        (WebCore::IDBCursorBackendProxy::IDBCursorBackendProxy):
        * src/IDBCursorBackendProxy.h:
        * src/IDBDatabaseCallbacksProxy.cpp:
        (WebCore::IDBDatabaseCallbacksProxy::create):
        (WebCore::IDBDatabaseCallbacksProxy::IDBDatabaseCallbacksProxy):
        * src/IDBDatabaseCallbacksProxy.h:
        * src/IDBDatabaseProxy.cpp: Renamed from Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp.
        (WebCore::IDBDatabaseProxy::create):
        (WebCore::IDBDatabaseProxy::IDBDatabaseProxy):
        (WebCore::IDBDatabaseProxy::~IDBDatabaseProxy):
        (WebCore::IDBDatabaseProxy::name):
        (WebCore::IDBDatabaseProxy::version):
        (WebCore::IDBDatabaseProxy::objectStoreNames):
        (WebCore::IDBDatabaseProxy::createObjectStore):
        (WebCore::IDBDatabaseProxy::deleteObjectStore):
        (WebCore::IDBDatabaseProxy::setVersion):
        (WebCore::IDBDatabaseProxy::transaction):
        (WebCore::IDBDatabaseProxy::close):
        (WebCore::IDBDatabaseProxy::open):
        * src/IDBDatabaseProxy.h: Renamed from Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h.
        * src/IDBFactoryBackendProxy.cpp:
        (WebCore::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
        (WebCore::IDBFactoryBackendProxy::open):
        * src/IDBFactoryBackendProxy.h:
        * src/IDBIndexBackendProxy.cpp:
        (WebCore::IDBIndexBackendProxy::create):
        (WebCore::IDBIndexBackendProxy::IDBIndexBackendProxy):
        * src/IDBIndexBackendProxy.h:
        * src/IDBObjectStoreBackendProxy.h: Removed.
        * src/IDBObjectStoreProxy.cpp: Renamed from Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.cpp.
        (WebCore::IDBObjectStoreProxy::create):
        (WebCore::IDBObjectStoreProxy::IDBObjectStoreProxy):
        (WebCore::IDBObjectStoreProxy::~IDBObjectStoreProxy):
        (WebCore::IDBObjectStoreProxy::name):
        (WebCore::IDBObjectStoreProxy::keyPath):
        (WebCore::IDBObjectStoreProxy::indexNames):
        (WebCore::IDBObjectStoreProxy::get):
        (WebCore::IDBObjectStoreProxy::put):
        (WebCore::IDBObjectStoreProxy::deleteFunction):
        (WebCore::IDBObjectStoreProxy::clear):
        (WebCore::IDBObjectStoreProxy::createIndex):
        (WebCore::IDBObjectStoreProxy::index):
        (WebCore::IDBObjectStoreProxy::deleteIndex):
        (WebCore::IDBObjectStoreProxy::openCursor):
        * src/IDBObjectStoreProxy.h: Added.
        * src/IDBTransactionBackendProxy.cpp:
        (WebCore::IDBTransactionBackendProxy::create):
        (WebCore::IDBTransactionBackendProxy::IDBTransactionBackendProxy):
        (WebCore::IDBTransactionBackendProxy::objectStore):
        * src/IDBTransactionBackendProxy.h:
        (WebCore::IDBTransactionBackendProxy::getWebIDBTransaction):
        * src/IDBTransactionCallbacksProxy.cpp:
        (WebCore::IDBTransactionCallbacksProxy::create):
        (WebCore::IDBTransactionCallbacksProxy::IDBTransactionCallbacksProxy):
        * src/IDBTransactionCallbacksProxy.h:
        * src/WebIDBCallbacksImpl.cpp:
        (WebCore::WebIDBCallbacksImpl::onError):
        (WebCore::WebIDBCallbacksImpl::onSuccess):
        * src/WebIDBCallbacksImpl.h:
        * src/WebIDBCursorImpl.cpp:
        * src/WebIDBCursorImpl.h:
        * src/WebIDBDatabaseCallbacksImpl.cpp:
        (WebCore::WebIDBDatabaseCallbacksImpl::onVersionChange):
        * src/WebIDBDatabaseCallbacksImpl.h:
        * src/WebIDBDatabaseError.cpp:
        * src/WebIDBDatabaseImpl.cpp:
        * src/WebIDBDatabaseImpl.h:
        * src/WebIDBFactoryImpl.cpp:
        (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
        * src/WebIDBFactoryImpl.h:
        * src/WebIDBIndexImpl.cpp:
        * src/WebIDBIndexImpl.h:
        * src/WebIDBKey.cpp:
        (WebKit::WebIDBKey::createFromValueAndKeyPath):
        (WebKit::WebIDBKey::injectIDBKeyIntoSerializedValue):
        * src/WebIDBKeyPath.cpp:
        (WebKit::WebIDBKeyPath::operator const WTF::Vector<WebCore::IDBKeyPathElement, 0>&):
        * src/WebIDBKeyRange.cpp:
        * src/WebIDBObjectStoreImpl.cpp:
        * src/WebIDBObjectStoreImpl.h:
        * src/WebIDBTransactionCallbacksImpl.cpp:
        * src/WebIDBTransactionCallbacksImpl.h:
        * src/WebIDBTransactionImpl.cpp:
        * src/WebIDBTransactionImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Fri, 1 Apr 2011 23:59:08 +0000 (23:59 +0000)]
2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82712, r82729, and r82746.
        http://trac.webkit.org/changeset/82712
        http://trac.webkit.org/changeset/82729
        http://trac.webkit.org/changeset/82746
        https://bugs.webkit.org/show_bug.cgi?id=57682

        fast/frames/frame-programmatic-noresize.html is failing on
        Windows bots. Will look into this offline. (Requested by dydx
        on #webkit).

        * html/HTMLFrameElement.cpp:
        (WebCore::HTMLFrameElement::HTMLFrameElement):
        (WebCore::HTMLFrameElement::attach):
        (WebCore::HTMLFrameElement::parseMappedAttribute):
        * html/HTMLFrameElement.h:
        (WebCore::HTMLFrameElement::noResize):
        * rendering/RenderFrame.cpp:
        * rendering/RenderFrame.h:
        * rendering/RenderFrameSet.cpp:
        * rendering/RenderFrameSet.h:
2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82712, r82729, and r82746.
        http://trac.webkit.org/changeset/82712
        http://trac.webkit.org/changeset/82729
        http://trac.webkit.org/changeset/82746
        https://bugs.webkit.org/show_bug.cgi?id=57682

        fast/frames/frame-programmatic-noresize.html is failing on
        Windows bots. Will look into this offline. (Requested by dydx
        on #webkit).

        * fast/frames/frame-inherit-noresize-from-frameset-expected.txt: Removed.
        * fast/frames/frame-inherit-noresize-from-frameset.html: Removed.
        * fast/frames/frame-programmatic-noresize-expected.txt: Removed.
        * fast/frames/frame-programmatic-noresize.html: Removed.
        * fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Removed.
        * fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html: Removed.
        * fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Removed.
        * fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html: Removed.
        * fast/frames/resources/frame-programmatic-resize.js: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Apr 2011 23:40:58 +0000 (23:40 +0000)]
2011-04-01  Adam Barth  <abarth@webkit.org>

        Mark failing test as failing.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Fri, 1 Apr 2011 23:38:52 +0000 (23:38 +0000)]
2011-04-01  Chang Shu  <cshu@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][WK2] Build Webkit2 using "-2" option on Qt
        https://bugs.webkit.org/show_bug.cgi?id=55074

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash when calling WebPageProxy::setMemoryCacheClientCallsEnabled with an invalid...
bweinstein@apple.com [Fri, 1 Apr 2011 23:33:26 +0000 (23:33 +0000)]
Crash when calling WebPageProxy::setMemoryCacheClientCallsEnabled with an invalid Web Process
https://bugs.webkit.org/show_bug.cgi?id=57680
<rdar://problem/9202909>

Reviewed by Anders Carlsson.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled): Add an isValid check before sending
    the message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 1 Apr 2011 23:33:05 +0000 (23:33 +0000)]
2011-04-01  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed, rolling out r82708.
        http://trac.webkit.org/changeset/82708
        https://bugs.webkit.org/show_bug.cgi?id=53644

        This tests fails consistently when run along with other tests

        * platform/gtk/Skipped:
        * platform/gtk/editing/deleting/5408255-expected.checksum:
        * platform/gtk/editing/deleting/5408255-expected.png:
        * platform/gtk/editing/deleting/5408255-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
mrowe@apple.com [Fri, 1 Apr 2011 23:19:39 +0000 (23:19 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Apr 2011 23:19:11 +0000 (23:19 +0000)]
2011-04-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Tony Chang.

        Valgrind error in _ZN7WebCore8Document11updateTitleERKNS_19StringWithDirectionE
        https://bugs.webkit.org/show_bug.cgi?id=57656

        We should initialize memory when constructing objects.

        * platform/text/StringWithDirection.h:
        (WebCore::StringWithDirection::StringWithDirection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 1 Apr 2011 23:12:42 +0000 (23:12 +0000)]
2011-04-01  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Update mac new-run-webkit-tests expectations with SLOW tests.

        * platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-30 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 1 Apr 2011 23:12:07 +0000 (23:12 +0000)]
2011-03-30  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Clean up IndexedDB WebKit API
        https://bugs.webkit.org/show_bug.cgi?id=57507

        Rename the backend proxy files that didn't have Backend in their name.
        Everything in WebKit should be in the WebKit namespace.
        Put everything behind the feature flag so we're consistient.
        Put the feature flag #if above includes.

        * WebKit.gyp:
        * src/IDBCallbacksProxy.cpp:
        (WebKit::IDBCallbacksProxy::create):
        (WebKit::IDBCallbacksProxy::IDBCallbacksProxy):
        (WebKit::IDBCallbacksProxy::onError):
        (WebKit::IDBCallbacksProxy::onSuccess):
        * src/IDBCallbacksProxy.h:
        * src/IDBCursorBackendProxy.cpp:
        (WebKit::IDBCursorBackendProxy::create):
        (WebKit::IDBCursorBackendProxy::IDBCursorBackendProxy):
        * src/IDBCursorBackendProxy.h:
        * src/IDBDatabaseBackendProxy.cpp:
        (WebKit::IDBDatabaseBackendProxy::create):
        (WebKit::IDBDatabaseBackendProxy::IDBDatabaseBackendProxy):
        (WebKit::IDBDatabaseBackendProxy::~IDBDatabaseBackendProxy):
        (WebKit::IDBDatabaseBackendProxy::name):
        (WebKit::IDBDatabaseBackendProxy::version):
        (WebKit::IDBDatabaseBackendProxy::objectStoreNames):
        (WebKit::IDBDatabaseBackendProxy::createObjectStore):
        (WebKit::IDBDatabaseBackendProxy::deleteObjectStore):
        (WebKit::IDBDatabaseBackendProxy::setVersion):
        (WebKit::IDBDatabaseBackendProxy::transaction):
        (WebKit::IDBDatabaseBackendProxy::close):
        (WebKit::IDBDatabaseBackendProxy::open):
        * src/IDBDatabaseCallbacksProxy.cpp:
        (WebKit::IDBDatabaseCallbacksProxy::create):
        (WebKit::IDBDatabaseCallbacksProxy::IDBDatabaseCallbacksProxy):
        * src/IDBDatabaseCallbacksProxy.h:
        * src/IDBFactoryBackendProxy.cpp:
        (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
        (WebKit::IDBFactoryBackendProxy::open):
        * src/IDBFactoryBackendProxy.h:
        * src/IDBIndexBackendProxy.cpp:
        (WebKit::IDBIndexBackendProxy::create):
        (WebKit::IDBIndexBackendProxy::IDBIndexBackendProxy):
        * src/IDBIndexBackendProxy.h:
        * src/IDBObjectStoreBackendProxy.cpp:
        (WebKit::IDBObjectStoreBackendProxy::create):
        (WebKit::IDBObjectStoreBackendProxy::IDBObjectStoreBackendProxy):
        (WebKit::IDBObjectStoreBackendProxy::~IDBObjectStoreBackendProxy):
        (WebKit::IDBObjectStoreBackendProxy::name):
        (WebKit::IDBObjectStoreBackendProxy::keyPath):
        (WebKit::IDBObjectStoreBackendProxy::indexNames):
        (WebKit::IDBObjectStoreBackendProxy::get):
        (WebKit::IDBObjectStoreBackendProxy::put):
        (WebKit::IDBObjectStoreBackendProxy::deleteFunction):
        (WebKit::IDBObjectStoreBackendProxy::clear):
        (WebKit::IDBObjectStoreBackendProxy::createIndex):
        (WebKit::IDBObjectStoreBackendProxy::index):
        (WebKit::IDBObjectStoreBackendProxy::deleteIndex):
        (WebKit::IDBObjectStoreBackendProxy::openCursor):
        * src/IDBObjectStoreBackendProxy.h: Added.
        * src/IDBObjectStoreProxy.h: Removed.
        * src/IDBTransactionBackendProxy.cpp:
        (WebKit::IDBTransactionBackendProxy::create):
        (WebKit::IDBTransactionBackendProxy::IDBTransactionBackendProxy):
        (WebKit::IDBTransactionBackendProxy::objectStore):
        * src/IDBTransactionBackendProxy.h:
        (WebKit::IDBTransactionBackendProxy::getWebIDBTransaction):
        * src/IDBTransactionCallbacksProxy.cpp:
        (WebKit::IDBTransactionCallbacksProxy::create):
        (WebKit::IDBTransactionCallbacksProxy::IDBTransactionCallbacksProxy):
        * src/IDBTransactionCallbacksProxy.h:
        * src/WebIDBCallbacksImpl.cpp:
        (WebKit::WebIDBCallbacksImpl::onError):
        (WebKit::WebIDBCallbacksImpl::onSuccess):
        * src/WebIDBCallbacksImpl.h:
        * src/WebIDBCursorImpl.cpp:
        * src/WebIDBCursorImpl.h:
        * src/WebIDBDatabaseCallbacksImpl.cpp:
        (WebKit::WebIDBDatabaseCallbacksImpl::onVersionChange):
        * src/WebIDBDatabaseCallbacksImpl.h:
        * src/WebIDBDatabaseError.cpp:
        * src/WebIDBDatabaseImpl.cpp:
        * src/WebIDBDatabaseImpl.h:
        * src/WebIDBFactoryImpl.cpp:
        (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
        * src/WebIDBFactoryImpl.h:
        * src/WebIDBIndexImpl.cpp:
        * src/WebIDBIndexImpl.h:
        * src/WebIDBKey.cpp:
        (WebKit::WebIDBKey::createFromValueAndKeyPath):
        (WebKit::WebIDBKey::injectIDBKeyIntoSerializedValue):
        * src/WebIDBKeyPath.cpp:
        (WebKit::WebIDBKeyPath::operator const WTF::Vector<IDBKeyPathElement, 0>&):
        * src/WebIDBKeyRange.cpp:
        * src/WebIDBObjectStoreImpl.cpp:
        * src/WebIDBObjectStoreImpl.h:
        * src/WebIDBTransactionCallbacksImpl.cpp:
        * src/WebIDBTransactionCallbacksImpl.h:
        * src/WebIDBTransactionImpl.cpp:
        * src/WebIDBTransactionImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-31 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 1 Apr 2011 23:07:36 +0000 (23:07 +0000)]
2011-03-31  Jer Noble  <jer.noble@apple.com>

        Reviewed by Dan Bernstein.

        WebKit2: Save as PDF in Safari provides Untitled as default file name
        https://bugs.webkit.org/show_bug.cgi?id=57529

        Set the NSPrintOperation's jobTitle to the printing frame's title.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView printOperationWithPrintInfo:forFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 1 Apr 2011 23:05:42 +0000 (23:05 +0000)]
2011-04-01  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: remove spurious port version override in webkit.py
        base.py provides a default implementation so this is just
        breaking things.

        https://bugs.webkit.org/show_bug.cgi?id=57667

        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Apr 2011 23:02:03 +0000 (23:02 +0000)]
2011-04-01  Adam Barth  <abarth@webkit.org>

        Skip platform/mac/plugins/convert-point.html because it relies on code
        that only exists in the test plugin for Apple's Mac port.  We generally
        ignore most of the tests in platform/mac, although we do run them to
        detect crashes.  In this case, however, the test does crash, but it
        crashes in the test plug-in, which doesn't matter to us.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Csaba Osztrogonác <ossy@webkit.org>
ossy@webkit.org [Fri, 1 Apr 2011 22:57:43 +0000 (22:57 +0000)]
2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Adam Roben.

        Make view results on waterfall direct link to results.html
        https://bugs.webkit.org/show_bug.cgi?id=57671

        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
        * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 1 Apr 2011 22:53:02 +0000 (22:53 +0000)]
2011-04-01  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        WebKit2: Link from PDF opens in a new tab instead of in the same tab
        https://bugs.webkit.org/show_bug.cgi?id=57528

        * WebCore.exp.in: Export MouseEvent::create().
2011-04-01  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        WebKit2: Link from PDF opens in a new tab instead of in the same tab
        https://bugs.webkit.org/show_bug.cgi?id=57528

        Notify the WebProcess that a link has been clicked so that the normal policy
        lookup can occur.

        * Shared/WebEvent.cpp:
        (WebKit::WebEvent::WebEvent): Initialize ivars in the default constructor.
        * Shared/WebEvent.h: Add WebEvent::NoType to Type enum.
        * Shared/WebMouseEvent.cpp:
        (WebKit::WebMouseEvent::WebMouseEvent): Ditto.
        * UIProcess/API/mac/PDFViewController.mm:
        (-[WKPDFView PDFViewWillClickOnLink:withURL:]): Handle the delegate
            function and override the PDFView default behavior.
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveEvent): Handle the new WebEvent::NoType enum.
        (WebKit::WebPageProxy::linkClicked): Added.  Send event through to WebPage.
        * UIProcess/WebPageProxy.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::linkClicked): Added.  Call loadFrameRequest().
        * WebProcess/WebPage/WebPage.h:
        * WebProcess/WebPage/WebPage.messages.in: Added LinkClicked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix windows build.
weinig@apple.com [Fri, 1 Apr 2011 22:50:44 +0000 (22:50 +0000)]
Fix windows build.

* TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
(TestWebKitAPI::flushMessages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unnecessary static keyword.
weinig@apple.com [Fri, 1 Apr 2011 22:39:42 +0000 (22:39 +0000)]
Remove unnecessary static keyword.

Reviewed by Adam "Keyword Slasher" Roben.

* UIProcess/API/cpp/WKRetainPtr.h:
(WebKit::adoptWK):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 1 Apr 2011 22:35:39 +0000 (22:35 +0000)]
2011-04-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Roben.

        Add adoptWK to WKRetainPtr.h
        https://bugs.webkit.org/show_bug.cgi?id=57670

        * UIProcess/API/cpp/WKRetainPtr.h:
        (WebKit::adoptWK):
        Add shared implementation of adoptWK. Previously both WebKitTestRunner
        and TestWebKitAPI had separate versions of it.
2011-04-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Roben.

        Add adoptWK to WKRetainPtr.h
        https://bugs.webkit.org/show_bug.cgi?id=57670

        * TestWebKitAPI/PlatformUtilities.h:
        * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
        * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
        * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
        * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
        * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
        * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
        * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
        * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
        (TestWebKitAPI::createSessionStateContainingFormData):
        * WebKitTestRunner/StringFunctions.h:
        Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Apr 2011 22:29:51 +0000 (22:29 +0000)]
2011-04-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Test assigning false to noResize instead of undefined
        https://bugs.webkit.org/show_bug.cgi?id=57668

        Apparently the V8 bindings have a bug when assigning undefined to a
        boolean attribute.  I've filed
        https://bugs.webkit.org/show_bug.cgi?id=57669 about that issue, which
        I'll address in another patch (obviously with a test).  In the
        meantime, this patch changes this test to test "false" instead of
        "undefined".

        * fast/frames/frame-programmatic-noresize-expected.txt:
        * fast/frames/frame-programmatic-noresize.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 John Bauman <jbauman@chromium.org>
commit-queue@webkit.org [Fri, 1 Apr 2011 22:28:11 +0000 (22:28 +0000)]
2011-04-01  John Bauman  <jbauman@chromium.org>

        Reviewed by Kenneth Russell.

        Avoid decoding images twice in texImage2D
        https://bugs.webkit.org/show_bug.cgi?id=51498

        Make sure to redecode the image only if it's not opaque and texImage2D
        wouldn't premultiply it anyway.

        * platform/graphics/BitmapImage.h:
        * platform/graphics/cg/GraphicsContext3DCG.cpp:
        (WebCore::GraphicsContext3D::getImageData):
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
weinig@apple.com [Fri, 1 Apr 2011 22:19:07 +0000 (22:19 +0000)]
Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.

Reviewed by Adam Roben.

* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::shadowRoot):
Make judicious use of adoptWK().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove bogus ChangeLog entry.
andersca@apple.com [Fri, 1 Apr 2011 22:12:18 +0000 (22:12 +0000)]
Remove bogus ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
weinig@apple.com [Fri, 1 Apr 2011 22:11:13 +0000 (22:11 +0000)]
Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.

Reviewed by Timothy Hatcher.

* Scripts/extract-localizable-strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 1 Apr 2011 21:55:22 +0000 (21:55 +0000)]
2011-04-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Shockwave plug-in doesn't accept mouse events
        https://bugs.webkit.org/show_bug.cgi?id=57653
        <rdar://problem/8483273>

        Fix an unrelated bug found by the added test.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
        Make sure to always set destX and destY.
2011-04-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Shockwave plug-in doesn't accept mouse events
        https://bugs.webkit.org/show_bug.cgi?id=57653
        <rdar://problem/8483273>

        Add a missing break.

        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
        (WebKit::NetscapePlugin::convertPoint):
2011-04-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Shockwave plug-in doesn't accept mouse events
        https://bugs.webkit.org/show_bug.cgi?id=57653
        <rdar://problem/8483273>

        Add test.

        * platform/mac/plugins/convert-point-expected.txt: Added.
        * platform/mac/plugins/convert-point.html: Added.
2011-02-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Repro crash with Sony Google TV ad at Gizmodo
        https://bugs.webkit.org/show_bug.cgi?id=54150
        <rdar://problem/8782346>

        Add a new plug-in test that runs JavaScript that destroys the plug-in from within its NPN_DestroyStream callback.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Added.
        (EvaluateJSDestroyingPluginFromDestroyStream::EvaluateJSDestroyingPluginFromDestroyStream):
        (EvaluateJSDestroyingPluginFromDestroyStream::NPP_Destroy):
        (EvaluateJSDestroyingPluginFromDestroyStream::NPP_DestroyStream):
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WinCairo] Unreviewed build fix.
bfulgham@webkit.org [Fri, 1 Apr 2011 21:42:22 +0000 (21:42 +0000)]
[WinCairo] Unreviewed build fix.

Define DEBUG_ALL for WinCairo debug builds so that the correct
labeled DLLs ("*_debug.dll") are linked for testing runs.

* win/tools/vsprops/debug_wincairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Dominic Cooney <dominicc@google.com>
commit-queue@webkit.org [Fri, 1 Apr 2011 21:36:20 +0000 (21:36 +0000)]
2011-04-01  Dominic Cooney  <dominicc@google.com>

        Reviewed by Martin Robinson.

        Add layoutTestController.shadowRoot to GTK DumpRenderTree.
        https://bugs.webkit.org/show_bug.cgi?id=57551

        * platform/gtk/Skipped: unskip test that accesses shadowRoot
2011-04-01  Dominic Cooney  <dominicc@google.com>

        Reviewed by Martin Robinson.

        Add layoutTestController.shadowRoot to GTK DumpRenderTree.
        https://bugs.webkit.org/show_bug.cgi?id=57551

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::shadowRoot):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-04-01  Dominic Cooney  <dominicc@google.com>

        Reviewed by Martin Robinson.

        Add layoutTestController.shadowRoot to GTK DumpRenderTree.
        https://bugs.webkit.org/show_bug.cgi?id=57551

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::shadowRoot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago 32-bit Mac build fix.
ap@apple.com [Fri, 1 Apr 2011 21:26:44 +0000 (21:26 +0000)]
    32-bit Mac build fix.

        * dom/KeyboardEvent.h: (WebCore::KeypressCommand::KeypressCommand): Use 0U to index a String
        to avoid ambiguity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 1 Apr 2011 21:26:07 +0000 (21:26 +0000)]
2011-04-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        WebKitTestRunner needs layoutTestController.shadowRoot
        https://bugs.webkit.org/show_bug.cgi?id=57661

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::shadowRoot):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
        Implement layoutTestController.shadowRoot for WebKit2.
2011-04-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        WebKitTestRunner needs layoutTestController.shadowRoot
        https://bugs.webkit.org/show_bug.cgi?id=57661

        * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
        (WKBundleNodeHandleGetRenderRect):
        (WKBundleNodeHandleGetElementBounds):
        (WKBundleNodeHandleCopyElementShadowRoot):
        * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
        (WebKit::InjectedBundleNodeHandle::elementShadowRoot):
        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
        Add accessor for the shadowRoot of an element in the bundle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 1 Apr 2011 21:24:52 +0000 (21:24 +0000)]
2011-04-01  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed some complexity from HandleHeap
        https://bugs.webkit.org/show_bug.cgi?id=57650

        Eliminated pointer-tagging flags.

        Tied being weak to having a finalizer (or at least a finalizer sentinel).

        * collector/handles/HandleHeap.cpp:
        (JSC::HandleHeap::clearWeakPointers): Removed the special self-destroying
        flag. It was unused. If we bring it back, we'll probably use a shared
        autodeallocating finalizer instead.

        * collector/handles/HandleHeap.h:
        (JSC::HandleHeap::makeWeak): makeWeak and adding a finalizer are now
        a single, atomic operation -- this makes the relationship between
        finalizers and weak pointers clearer, and impossible to get wrong.

        (JSC::HandleHeap::Node::Node):
        (JSC::HandleHeap::Node::handleHeap): No more flags.

        (JSC::HandleHeap::Node::makeWeak):
        (JSC::HandleHeap::Node::isWeak): Ditto above. We use a special sentienl
        value in the finalizer slot to indicate that a handle is weak but doesn't
        require an external function call for finalization.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler.
ap@apple.com [Fri, 1 Apr 2011 21:11:44 +0000 (21:11 +0000)]
    Reviewed by Darin Adler.

        Make WebKit2 text input handling more like WebKit1
        https://bugs.webkit.org/show_bug.cgi?id=57649

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Fri, 1 Apr 2011 21:08:06 +0000 (21:08 +0000)]
2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82711.
        http://trac.webkit.org/changeset/82711
        https://bugs.webkit.org/show_bug.cgi?id=57657

        Made every test crash on XP and Win7 (Requested by
        abarth|gardening on #webkit).

        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::canUseCacheValidator):
        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::adopt):
        (WebCore::ResourceResponseBase::isHTTP):
        (WebCore::ResourceResponseBase::url):
        (WebCore::ResourceResponseBase::setURL):
        (WebCore::ResourceResponseBase::mimeType):
        (WebCore::ResourceResponseBase::setMimeType):
        (WebCore::ResourceResponseBase::expectedContentLength):
        (WebCore::ResourceResponseBase::setExpectedContentLength):
        (WebCore::ResourceResponseBase::textEncodingName):
        (WebCore::ResourceResponseBase::setTextEncodingName):
        (WebCore::ResourceResponseBase::suggestedFilename):
        (WebCore::ResourceResponseBase::setSuggestedFilename):
        (WebCore::ResourceResponseBase::httpStatusCode):
        (WebCore::ResourceResponseBase::setHTTPStatusCode):
        (WebCore::ResourceResponseBase::httpStatusText):
        (WebCore::ResourceResponseBase::setHTTPStatusText):
        (WebCore::ResourceResponseBase::httpHeaderField):
        (WebCore::ResourceResponseBase::setHTTPHeaderField):
        (WebCore::ResourceResponseBase::httpHeaderFields):
        (WebCore::ResourceResponseBase::parseCacheControlDirectives):
        (WebCore::ResourceResponseBase::date):
        (WebCore::ResourceResponseBase::age):
        (WebCore::ResourceResponseBase::expires):
        (WebCore::ResourceResponseBase::lastModified):
        (WebCore::ResourceResponseBase::isAttachment):
        (WebCore::ResourceResponseBase::setLastModifiedDate):
        (WebCore::ResourceResponseBase::lastModifiedDate):
        (WebCore::ResourceResponseBase::wasCached):
        (WebCore::ResourceResponseBase::connectionReused):
        (WebCore::ResourceResponseBase::setConnectionReused):
        (WebCore::ResourceResponseBase::connectionID):
        (WebCore::ResourceResponseBase::setConnectionID):
        (WebCore::ResourceResponseBase::resourceLoadTiming):
        (WebCore::ResourceResponseBase::setResourceLoadTiming):
        (WebCore::ResourceResponseBase::resourceLoadInfo):
        (WebCore::ResourceResponseBase::setResourceLoadInfo):
        (WebCore::ResourceResponseBase::lazyInit):
        * platform/network/ResourceResponseBase.h:
        (WebCore::ResourceResponseBase::platformLazyInit):
        * platform/network/cf/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        (WebCore::ResourceResponse::memoryUsage):
        * platform/network/cf/ResourceResponseCFNet.cpp:
        (WebCore::ResourceResponse::platformLazyInit):
        * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::platformLazyInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-01 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Fri, 1 Apr 2011 20:59:35 +0000 (20:59 +0000)]
2011-04-01  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Behavior of isAccelerated() for a IOSurface-backed canvas should be consistent with accelerated status of its ImageBuffer
        https://bugs.webkit.org/show_bug.cgi?id=57651

        No new tests. This patch does not affect outward behavior.

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::isAccelerated):
        * platform/graphics/ImageBuffer.h:
        (WebCore::ImageBuffer::isAccelerated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82715 268f45cc-cd09-0410-ab3c-d52691b4dbfc