WebKit-https.git
8 years agominidom configurations should be based on ToolExecutable.xcconfig
ddkilzer@apple.com [Thu, 29 Mar 2012 03:00:19 +0000 (03:00 +0000)]
minidom configurations should be based on ToolExecutable.xcconfig
<http://webkit.org/b/82513>

Reviewed by Mark Rowe.

Note that this patch changes minidom from being installed in
/usr/local/bin to JavaScriptCore.framework/Resources.

* Configurations/ToolExecutable.xcconfig: Add semi-colon.
* JavaScriptCore.xcodeproj/project.pbxproj: Base minidom
configurations on ToolExecutable.xcconfig.  Remove redundant
PRODUCT_NAME and SKIP_INSTALL variables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove ScriptExecutionContext from NavigatorBattery.idl
gyuyoung.kim@samsung.com [Thu, 29 Mar 2012 02:57:04 +0000 (02:57 +0000)]
Remove ScriptExecutionContext from NavigatorBattery.idl
https://bugs.webkit.org/show_bug.cgi?id=82556

Reviewed by Adam Barth.

As Bug 73528 comment #71, NavigatorBattery.idl doesn't need to have ScriptExecutionContext.
Document can be used instead of ScriptExecutionContext.

Tests: batterystatus/add-listener-from-callback.html
       batterystatus/basic-all-types-of-events.html
       batterystatus/basic-operation.html
       batterystatus/event-after-navigation.html
       batterystatus/multiple-frames.html
       batterystatus/updates.html
       batterystatus/window-property.html

* Modules/battery/BatteryManager.cpp:
(WebCore::BatteryManager::create):
(WebCore::BatteryManager::BatteryManager):
* Modules/battery/BatteryManager.h:
(BatteryManager):
* Modules/battery/NavigatorBattery.cpp:
(WebCore::NavigatorBattery::webkitBattery):
* Modules/battery/NavigatorBattery.h:
(NavigatorBattery):
* Modules/battery/NavigatorBattery.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry]Missing cookies from HTTP response header in Network tab of Web Inspector.
commit-queue@webkit.org [Thu, 29 Mar 2012 02:32:50 +0000 (02:32 +0000)]
[BlackBerry]Missing cookies from HTTP response header in Network tab of Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=82041

We shouldn't overwrite cookies of response if there are more than one
header of Set-Cookie.

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-28
Reviewed by Rob Buis.

Test: http/tests/cookies/resources/setArraycookies.php

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyHeaderReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJPEGImageDecoder: Set frame alpha state before marking a frame complete
noel.gordon@gmail.com [Thu, 29 Mar 2012 02:18:18 +0000 (02:18 +0000)]
JPEGImageDecoder: Set frame alpha state before marking a frame complete
https://bugs.webkit.org/show_bug.cgi?id=82428

Reviewed by Kenneth Russell.

r109779 changed JPEG alpha channel handling by marking a JPEG image frame
as having no alpha _after_ setting the image status frame-complete, which
prevents the application of image color profiles in some WebGL cases.

No new tests. The application of the color profile is not guaranteed for
images used as textures in WebGL. Refer to http://wkb.ug/76498.

* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::jpegComplete): Set the image frame alpha state
before marking the image frame status as frame-complete.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix rounding in RenderInline::paintOutlineForLine
eae@chromium.org [Thu, 29 Mar 2012 02:11:40 +0000 (02:11 +0000)]
Fix rounding in RenderInline::paintOutlineForLine
https://bugs.webkit.org/show_bug.cgi?id=82540

Reviewed by Eric Seidel.

No new tests, no change in functionality.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine):
Change paintOutlineForLine to pixel snap the left and right edges of the
lines instead of adding the offset to an already rounded number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a crash and an assertion when recovering from a web process crash
andersca@apple.com [Thu, 29 Mar 2012 01:50:06 +0000 (01:50 +0000)]
Fix a crash and an assertion when recovering from a web process crash
https://bugs.webkit.org/show_bug.cgi?id=82559
<rdar://problem/10902574>

Reviewed by Mark Rowe.

* UIProcess/API/mac/WKView.mm:
(-[WKView _processDidCrash]):
If we're currently in accelerated compositing mode, exit.

(-[WKView updateLayer]):
Guard against a null drawing area.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: don't expose IDBDatabaseError to script
dgrogan@chromium.org [Thu, 29 Mar 2012 01:46:06 +0000 (01:46 +0000)]
IndexedDB: don't expose IDBDatabaseError to script
https://bugs.webkit.org/show_bug.cgi?id=82280

Source/WebCore:

It's not used anywhere and firefox doesn't expose it.

Reviewed by Tony Chang.

Test: storage/indexeddb/removed.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Modules/indexeddb/DOMWindowIndexedDatabase.idl:
* Modules/indexeddb/IDBDatabaseError.idl: Removed.
* Modules/indexeddb/WorkerContextIndexedDatabase.idl:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Add layout test that ensures IDBDatabaseError is gone.

Also change shouldBeTrue to shouldBeTrueQuiet in the boilerplate idb
layout test preamble to remove a bunch of clutter from the
-expected.txt files.

Reviewed by Tony Chang.

* storage/indexeddb/basics-expected.txt:
* storage/indexeddb/basics-shared-workers-expected.txt:
* storage/indexeddb/basics-workers-expected.txt:
... every indexeddb -expected.txt:
Remove output from check for IDBDatabaseError.
* storage/indexeddb/removed-expected.txt: Added.
* storage/indexeddb/removed.html: Added.
* storage/indexeddb/request-event-propagation-expected.txt:
* storage/indexeddb/resources/removed.js: Added.
(test):
* storage/indexeddb/resources/shared.js:
(removeVendorPrefixes): Stop checking for existence of
window.IDBDatabaseError.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRespects font fallback list during webfonts are loading
bashi@chromium.org [Thu, 29 Mar 2012 01:41:03 +0000 (01:41 +0000)]
Respects font fallback list during webfonts are loading
https://bugs.webkit.org/show_bug.cgi?id=76684

Reviewed by Dimitri Glazkov.

Source/WebCore:

For layout, use the rest of the fallback list while webfonts are loading.
If the webfont is loading, it will be given an invalid Unicode Range so that
font selection mechansim doesn't use the webfont for layout.

Test: http/tests/webfont/fallback-font-while-loading.html

* css/CSSSegmentedFontFace.cpp:
(WebCore::appendFontDataWithInvalidUnicodeRangeIfLoading): Added.
(WebCore):
(WebCore::CSSSegmentedFontFace::getFontData):

LayoutTests:

Add a test that checks fallback fonts are used for layout while
webfonts are loading.

* http/tests/webfont/fallback-font-while-loading-expected.txt: Added.
* http/tests/webfont/fallback-font-while-loading.html: Added.
* http/tests/webfont/getahem.cgi: Added.
* http/tests/webfont/resources/Ahem.ttf: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebSocket]Reserved bits test case should cover both extension and no-extension scenarios
commit-queue@webkit.org [Thu, 29 Mar 2012 01:32:28 +0000 (01:32 +0000)]
[WebSocket]Reserved bits test case should cover both extension and no-extension scenarios
https://bugs.webkit.org/show_bug.cgi?id=82100

Patch by Li Yin <li.yin@intel.com> on 2012-03-28
Reviewed by Kent Tamura.

The current reserved bits test case only support extension case,
Improve test case to cover both no-extension and extension scenarios.

* http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
* http/tests/websocket/tests/hybi/reserved-bits.html:
* http/tests/websocket/tests/hybi/reserved-bits_wsh.py:
(web_socket_do_extra_handshake):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate Localizable.strings.
mrowe@apple.com [Thu, 29 Mar 2012 01:29:30 +0000 (01:29 +0000)]
Update Localizable.strings.

* English.lproj/Localizable.strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix --no-saved-state.
mrowe@apple.com [Thu, 29 Mar 2012 01:29:16 +0000 (01:29 +0000)]
Fix --no-saved-state.

Ignore the flag before Lion, rather than making it specific to Lion.

Rubber-stamped by Dan Bernstein.

* Scripts/webkitdirs.pm:
(argumentsForRunAndDebugMacWebKitApp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAssociatedURLLoader does not support Cross Origin Redirects when using
bbudge@chromium.org [Thu, 29 Mar 2012 01:14:05 +0000 (01:14 +0000)]
AssociatedURLLoader does not support Cross Origin Redirects when using
Access Control.
https://bugs.webkit.org/show_bug.cgi?id=82354

AssociatedURLLoader's internal adapter now overrides didFailRedirectCheck,
which cancels the load, causing didFail to notify the client that the
load failed. AssociatedURLLoaderTest adds test cases for CORS requests
that receive redirects and pass or fail the redirect access check.

Reviewed by Adam Barth.

* src/AssociatedURLLoader.cpp:
(AssociatedURLLoader::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didFailRedirectCheck):
(WebKit):
* tests/AssociatedURLLoaderTest.cpp:
(WebKit):
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Removed particular rendering for the volume slider and used
commit-queue@webkit.org [Thu, 29 Mar 2012 01:07:20 +0000 (01:07 +0000)]
Source/WebCore: Removed particular rendering for the volume slider and used
css positioning instead (simpler and less prone to errors when
changes occur).
https://bugs.webkit.org/show_bug.cgi?id=82150

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-28
Reviewed by Eric Carlson.

Test: media/video-controls-rendering-toggle-display-none.html

* css/mediaControls.css: Updated css to correctly render controls.
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
* css/mediaControlsChromium.css: Updated css to correctly render controls.
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
* html/shadow/MediaControlElements.cpp: Removed particular renderer.
(WebCore):
* html/shadow/MediaControlElements.h: Removed particular renderer.
(MediaControlVolumeSliderContainerElement):
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::create): Added an anonymous div container
for the mute button and volume slider (to be displayed on top of each other)

LayoutTests: Added relevant test to support video controls display:none toggling.
https://bugs.webkit.org/show_bug.cgi?id=82150

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-28
Reviewed by Eric Carlson.

* media/video-controls-rendering-toggle-display-none.html: Added.
* platform/chromium-linux/media/video-controls-rendering-toggle-display-none-expected.png: Added.
* platform/chromium-linux/media/video-controls-rendering-toggle-display-none-expected.txt: Added.
* platform/chromium/test_expectations.txt: Updated expectations, more rebaselining is needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r110064.
slewis@apple.com [Thu, 29 Mar 2012 01:02:28 +0000 (01:02 +0000)]
Unreviewed, rolling out r110064.
http://trac.webkit.org/changeset/110064
https://bugs.webkit.org/show_bug.cgi?id=82537

The patch leaks the DOM when audio elements are used
(Requested by sundiamonde on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-28

Source/WebCore:

* bindings/js/JSNodeCustom.cpp:
(WebCore::isReachableFromDOM):

LayoutTests:

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Win] Some Blob tests crash in CFNetwork in advanceCurrentStream(FormStreamFields*)
ap@apple.com [Thu, 29 Mar 2012 00:58:42 +0000 (00:58 +0000)]
[Win] Some Blob tests crash in CFNetwork in advanceCurrentStream(FormStreamFields*)
https://bugs.webkit.org/show_bug.cgi?id=82386
<rdar://problem/11121501>

Reviewed by Brady Eidson.

Covered by existing tests.

* platform/network/cf/FormDataStreamCFNet.cpp:
* platform/network/cf/FormDataStreamCFNet.h:
Moved low level implementation from FormDataStreamMac, and exposed an additional function
to implement Foundation-based API on top of this.

* platform/network/mac/FormDataStreamMac.h:
* platform/network/mac/FormDataStreamMac.mm:
Rely on toll-free bridging and implementation details to make this work without duplicating
code.
Note that httpBodyFromStream is confusing - I don't see how it can work when sending serialized
requests across process boundary. We probably only get away with this because we don't attempt
to send requests to UI process once they already have streams associated with them.

* WebCore.vcproj/WebCore.vcproj: Added missing platform/cf files.

* platform/cf/FileSystemCF.cpp: Fixed include style.

* platform/win/FileSystemWin.cpp: (WebCore::fileSystemRepresentation): Ifdef out a broken
implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fix tiled layer assert for huge layers
enne@google.com [Thu, 29 Mar 2012 00:56:16 +0000 (00:56 +0000)]
[chromium] Fix tiled layer assert for huge layers
https://bugs.webkit.org/show_bug.cgi?id=82486

Reviewed by James Robinson.

Source/WebCore:

Test: TiledLayerChromiumTest.hugeLayerUpdateCrash

TilingData::numTiles() is calculated as the product of two ints and so
can potentially overflow, causing numTiles() to be incorrect. To avoid
calling code accidentally falling into this trap, remove this function
and all code that uses tile index from TilingData.  This requires
fixing up a bunch of callers of TilingData and CCLayerTilingData.

Additionally, TilingData::numTiles() has long been a confusing
function name in some contexts, so rename to bool hasEmptyBounds().

Also, remove TilingData::intersectDrawQuad because there are no
clients of that function.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::reserveTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):
* platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::tileRect):
* platform/graphics/chromium/cc/CCLayerTilingData.h:
(WebCore::CCLayerTilingData::hasEmptyBounds):
(WebCore::CCLayerTilingData::tileBounds):
(WebCore::CCLayerTilingData::isEmpty):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::appendQuads):
* platform/graphics/gpu/Texture.cpp:
(WebCore::Texture::create):
(WebCore::Texture::updateSubRect):
* platform/graphics/gpu/TilingData.cpp:
(WebCore::TilingData::tileBounds):
(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::tileBoundsNormalized):
* platform/graphics/gpu/TilingData.h:
(WebCore::TilingData::hasEmptyBounds):
(TilingData):
(WebCore::TilingData::assertTile):

Source/WebKit/chromium:

Add test for updating a huge layer that would assert prior to this
code. Fix up TilingData tests to use a testing class that provides a
safe version of numTiles().

* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
(WTF):
* tests/TilingDataTest.cpp:
(TestTiling):
(WebCore::TestTiling::TestTiling):
(WebCore::TestTiling::numTiles):
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoediting/spelling/spellcheck-async-mutation.html is flakey.
enrica@apple.com [Thu, 29 Mar 2012 00:54:26 +0000 (00:54 +0000)]
editing/spelling/spellcheck-async-mutation.html is flakey.
https://bugs.webkit.org/show_bug.cgi?id=82555

Mark this test as flakey in test_expectations.

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoved editing/pasteboard/drop-text-without-selection.html from test_expectations
enrica@apple.com [Thu, 29 Mar 2012 00:36:50 +0000 (00:36 +0000)]
Removed editing/pasteboard/drop-text-without-selection.html from test_expectations
since it now passes consistently.

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded compositing/rtl/rtl-fixed-overflow-scrolled.html to the Mac skipped list, becau...
enrica@apple.com [Thu, 29 Mar 2012 00:31:38 +0000 (00:31 +0000)]
Added compositing/rtl/rtl-fixed-overflow-scrolled.html to the Mac skipped list, because of
<https://bugs.webkit.org/show_bug.cgi?id=82554> compositing/rtl/rtl-fixed-overflow-scrolled.html fails on
Lion and SnowLeopard.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd dtharp to contributors list
commit-queue@webkit.org [Thu, 29 Mar 2012 00:29:39 +0000 (00:29 +0000)]
Add dtharp to contributors list
https://bugs.webkit.org/show_bug.cgi?id=82545

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-28
Reviewed by Adam Barth.

Adding dtharp as Contributor.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline this test after the nodes were removed in r112299.
simon.fraser@apple.com [Thu, 29 Mar 2012 00:24:11 +0000 (00:24 +0000)]
Rebaseline this test after the nodes were removed in r112299.

* platform/mac/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange FilterOperations::getOutsets to use integers
eae@chromium.org [Wed, 28 Mar 2012 23:57:16 +0000 (23:57 +0000)]
Change FilterOperations::getOutsets to use integers
https://bugs.webkit.org/show_bug.cgi?id=82535

Reviewed by Eric Seidel.

FilterOperations::getOutsets calculates the outsets using integers and
the values are guranteed to be set to full-pixel values. By changing the
function signature we communicate this fact better and avoid unnecessary
type conversions in some cases.

No new tests.

* platform/graphics/filters/FilterOperations.cpp:
(WebCore::FilterOperations::getOutsets):
* platform/graphics/filters/FilterOperations.h:
(FilterOperations):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::addVisualEffectOverflow):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::computeRectForRepaint):
* rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove dispatchDidLoadMainResource callback, since no
japhet@chromium.org [Wed, 28 Mar 2012 23:55:31 +0000 (23:55 +0000)]
Remove dispatchDidLoadMainResource callback, since no
port implements it.
https://bugs.webkit.org/show_bug.cgi?id=82539

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests, just deleting dead code.

* loader/EmptyClients.h:
(EmptyFrameLoaderClient):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedLoading):
(WebCore::FrameLoader::mainReceivedCompleteError):
* loader/FrameLoaderClient.h:
(FrameLoaderClient):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::didCancel):

Source/WebKit/blackberry:

* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):

Source/WebKit/chromium:

* src/FrameLoaderClientImpl.cpp:
(WebKit):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):

Source/WebKit/efl:

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore):
* WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):

Source/WebKit/gtk:

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit):
* WebCoreSupport/FrameLoaderClientGtk.h:
(FrameLoaderClient):

Source/WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebKit.order:

Source/WebKit/qt:

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore):
* WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):

Source/WebKit/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):

Source/WebKit/wince:

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit):
* WebCoreSupport/FrameLoaderClientWinCE.h:
(FrameLoaderClientWinCE):

Source/WebKit/wx:

* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore):
* WebKitSupport/FrameLoaderClientWx.h:
(FrameLoaderClientWx):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: editing/pasteboard/dataTransfer-setData-getData.html fails on Mac platforms.
enrica@apple.com [Wed, 28 Mar 2012 23:43:19 +0000 (23:43 +0000)]
REGRESSION: editing/pasteboard/dataTransfer-setData-getData.html fails on Mac platforms.
https://bugs.webkit.org/show_bug.cgi?id=82497
<rdar://problem/11140334>

Reviewed by Brady Eidson.

The revision causing this regression fixed the way data is written to the pasteboard for NSURLPboardType.
This change fixes the way data is read from the pasteboard for the same pasteboard type.

No new tests. Fixes the existing one that fails.

* platform/mac/ClipboardMac.mm:
(WebCore::absoluteURLsFromPasteboard):
* platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::stringForType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSL bot is hitting SHOULD NEVER BE REACHED in WebCore::valueForLength() on many tests
commit-queue@webkit.org [Wed, 28 Mar 2012 23:41:42 +0000 (23:41 +0000)]
SL bot is hitting SHOULD NEVER BE REACHED in WebCore::valueForLength() on many tests
https://bugs.webkit.org/show_bug.cgi?id=82390

Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-28
Reviewed by Simon Fraser.

This is an attempt to fix the MAC SL/Lion Bot issue as this issue is not reproducible locally.
The assertion happened when length type is Undefined in valueForLength() function but the assertion for Undefined length type
in RenderBox::computeLogicalWidthInRegionUsing which calls the above said function did not get hit.

This patch passes Length structure as const reference to Length calculation functions which avoids the call to the copy-constructor.
And it ensures that the Length structure is not getting modified during copy-construction.

* css/LengthFunctions.cpp:
(WebCore::minimumValueForLength):
(WebCore::valueForLength):
(WebCore::floatValueForLength):
* css/LengthFunctions.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agobuild-webkit : the word "pass" is spelled incorrectly as "passs"
commit-queue@webkit.org [Wed, 28 Mar 2012 23:26:32 +0000 (23:26 +0000)]
build-webkit : the word "pass" is spelled incorrectly as "passs"
https://bugs.webkit.org/show_bug.cgi?id=82532

Patch by Stuart Eichert <stuart.eichert@palm.com> on 2012-03-28
Reviewed by Julien Chaffraix.

Corrected spelling of the word "pass" in build-webkit.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLion tweaks.
dpranke@chromium.org [Wed, 28 Mar 2012 23:17:03 +0000 (23:17 +0000)]
Lion tweaks.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocompositing/tiling/crash-reparent-tiled-layer.html is flakey
simon.fraser@apple.com [Wed, 28 Mar 2012 23:08:13 +0000 (23:08 +0000)]
compositing/tiling/crash-reparent-tiled-layer.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=82546

Mark this test as flakey in test_expectations

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRoll chromium from 129300 to 129509.
dpranke@chromium.org [Wed, 28 Mar 2012 23:06:52 +0000 (23:06 +0000)]
Roll chromium from 129300 to 129509.

Unreviewed, DEPS change.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore Chromium rebaselines from the expected failures tab in garden-o-matic.
ojan@chromium.org [Wed, 28 Mar 2012 23:05:26 +0000 (23:05 +0000)]
More Chromium rebaselines from the expected failures tab in garden-o-matic.
They all looked like straightforward text-rendering, form-control rendering or anti-aliasing issues,
except for some where the new results were clearly just more correct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove some more tests from test_expectations.txt, since the pixel test pass.
simon.fraser@apple.com [Wed, 28 Mar 2012 22:56:23 +0000 (22:56 +0000)]
Remove some more tests from test_expectations.txt, since the pixel test pass.

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove some tests that now pass pixel tests from the list of failures.
simon.fraser@apple.com [Wed, 28 Mar 2012 22:48:31 +0000 (22:48 +0000)]
Remove some tests that now pass pixel tests from the list of failures.

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix - some compiles generating NORETURN related warnings.
barraclough@apple.com [Wed, 28 Mar 2012 22:43:04 +0000 (22:43 +0000)]
Build fix - some compiles generating NORETURN related warnings.

* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::setSubpatternStart):
(JSC::Yarr::YarrGenerator::setSubpatternEnd):
(JSC::Yarr::YarrGenerator::clearSubpatternStart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonew-run-webkit-tests doesn't log correctly after retrying failures
dpranke@chromium.org [Wed, 28 Mar 2012 22:33:48 +0000 (22:33 +0000)]
new-run-webkit-tests doesn't log correctly after retrying failures
https://bugs.webkit.org/show_bug.cgi?id=82541

Unreviewed, build fix.

r112189 introduced a regression where we would accidentally
delete the log handler after we retried any failing tests - that
meant that any log messages around uploading the results got
dropped.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMassive lag opening a link in a new background tab
andersca@apple.com [Wed, 28 Mar 2012 22:32:20 +0000 (22:32 +0000)]
Massive lag opening a link in a new background tab
https://bugs.webkit.org/show_bug.cgi?id=82542
<rdar://problem/11004502>

Reviewed by Sam Weinig.

Defer waiting for the web process to update the page size until we're actually going to display the layer.
This matches what we do in the non-tiled code path.

* UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
(-[WKView updateLayer]):
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::waitForPossibleGeometryUpdate):
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
(TiledCoreAnimationDrawingAreaProxy):
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::sizeDidChange):
(WebKit):
(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForPossibleGeometryUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[wx] Unreviewed. Build fix, move WTF back into JSCore target
kevino@webkit.org [Wed, 28 Mar 2012 22:24:14 +0000 (22:24 +0000)]
[wx] Unreviewed. Build fix, move WTF back into JSCore target
until issues with JSCore not linking in all WTF symbols are resolved.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoYarr: if we're not using the output array, don't populate it!
barraclough@apple.com [Wed, 28 Mar 2012 22:20:52 +0000 (22:20 +0000)]
Yarr: if we're not using the output array, don't populate it!
https://bugs.webkit.org/show_bug.cgi?id=82519

Reviewed by Sam Weinig.

* runtime/RegExp.cpp:
(JSC):
    - Missed review comment! - didn't fully remove RegExpRepresentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoYarr: if we're not using the output array, don't populate it!
barraclough@apple.com [Wed, 28 Mar 2012 22:18:20 +0000 (22:18 +0000)]
Yarr: if we're not using the output array, don't populate it!
https://bugs.webkit.org/show_bug.cgi?id=82519

Reviewed by Sam Weinig.

../JavaScriptCore:

Add a new variant of the match method to RegExp that returns a MatchResult,
and modify YarrJIT to be able to compile code that doesn't use an output vector.

This is a 3% progression on v8-regexp.

* JavaScriptCore.xcodeproj/project.pbxproj:
    - Moved MatchResult into its own header.
* assembler/AbstractMacroAssembler.h:
    - Added missing include.
* runtime/MatchResult.h: Added.
(MatchResult::MatchResult):
(MatchResult):
(MatchResult::failed):
(MatchResult::operator bool):
(MatchResult::empty):
    - Moved MatchResult into its own header.
* runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::compileIfNecessary):
(JSC::RegExp::match):
    - Changed due to execute & representation changes.
(JSC::RegExp::compileMatchOnly):
(JSC::RegExp::compileIfNecessaryMatchOnly):
    - Added helper to compile MatchOnly code.
(JSC::RegExp::invalidateCode):
(JSC::RegExp::matchCompareWithInterpreter):
(JSC::RegExp::printTraceData):
    - Changed due representation changes.
* runtime/RegExp.h:
(RegExp):
(JSC::RegExp::hasCode):
    - Made YarrCodeBlock a member.
* runtime/RegExpConstructor.h:
(RegExpConstructor):
(JSC::RegExpConstructor::performMatch):
    - Added no-ovector form.
* runtime/RegExpMatchesArray.cpp:
(JSC::RegExpMatchesArray::reifyAllProperties):
    - Match now takes a reference to ovector, not a pointer.
* runtime/RegExpObject.h:
(JSC):
    - Moved MatchResult into its own header.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncSplit):
    - Match now takes a reference to ovector, not a pointer.
* testRegExp.cpp:
(testOneRegExp):
    - Match now takes a reference to ovector, not a pointer.
* yarr/YarrJIT.cpp:
(Yarr):
(YarrGenerator):
(JSC::Yarr::YarrGenerator::initCallFrame):
(JSC::Yarr::YarrGenerator::removeCallFrame):
(JSC::Yarr::YarrGenerator::setSubpatternStart):
(JSC::Yarr::YarrGenerator::setSubpatternEnd):
(JSC::Yarr::YarrGenerator::clearSubpatternStart):
(JSC::Yarr::YarrGenerator::setMatchStart):
(JSC::Yarr::YarrGenerator::getMatchStart):
    - Added helper functions to intermediate access to output.
(JSC::Yarr::YarrGenerator::generateDotStarEnclosure):
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):
(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::compile):
    - Changed to use the new helpers, only generate subpatterns if IncludeSubpatterns.
(JSC::Yarr::jitCompile):
    - Needs to template of MatchOnly or IncludeSubpatterns.
* yarr/YarrJIT.h:
(YarrCodeBlock):
(JSC::Yarr::YarrCodeBlock::set8BitCode):
(JSC::Yarr::YarrCodeBlock::set16BitCode):
(JSC::Yarr::YarrCodeBlock::has8BitCodeMatchOnly):
(JSC::Yarr::YarrCodeBlock::has16BitCodeMatchOnly):
(JSC::Yarr::YarrCodeBlock::set8BitCodeMatchOnly):
(JSC::Yarr::YarrCodeBlock::set16BitCodeMatchOnly):
(JSC::Yarr::YarrCodeBlock::execute):
(JSC::Yarr::YarrCodeBlock::clear):
    - Added a second set of CodeRefs, so that we can compile RexExps with/without subpattern matching.

../WebCore:

* ForwardingHeaders/runtime/MatchResult.h: Added.
* ForwardingHeaders/yarr/YarrJIT.h: Added.
    - Added forwarding headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=81685
hyatt@apple.com [Wed, 28 Mar 2012 22:15:31 +0000 (22:15 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=81685

[New Multicolumn] Add RenderMultiColumnFlowThread to hold the flow thread contents of a multi-column block.
It derives from RenderFlowThread.

Refactor RenderFlowThread to split out the stuff related to explicit naming into a subclass, RenderNamedFlowThread.
This allows RenderFlowThread to be a simple base class that involves maintaining the regions themselves.

Reviewed by Julien Chaffraix.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
* dom/NodeRenderingContext.cpp:
* dom/NodeRenderingContext.h:
(WebCore):
(WebCore::NodeRenderingContext::parentFlowRenderer):
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::WebKitNamedFlow):
* dom/WebKitNamedFlow.h:
(WebCore):
(WebCore::WebKitNamedFlow::create):
(WebKitNamedFlow):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseAnonymousBoxChild):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
* rendering/RenderFlowThread.h:
(WebCore):
* rendering/RenderMultiColumnFlowThread.cpp: Added.
(WebCore):
(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
(WebCore::RenderMultiColumnFlowThread::renderName):
* rendering/RenderMultiColumnFlowThread.h: Added.
(WebCore):
(RenderMultiColumnFlowThread):
* rendering/RenderNamedFlowThread.cpp: Added.
(WebCore):
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::renderName):
(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::addFlowChild):
(WebCore::RenderNamedFlowThread::removeFlowChild):
(WebCore::RenderNamedFlowThread::dependsOn):
(WebCore::compareRenderRegions):
(WebCore::RenderNamedFlowThread::addRegionToThread):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::checkInvalidRegions):
(WebCore::RenderNamedFlowThread::addDependencyOnFlowThread):
(WebCore::RenderNamedFlowThread::removeDependencyOnFlowThread):
(WebCore::RenderNamedFlowThread::pushDependencies):
(WebCore::RenderNamedFlowThread::ensureNamedFlow):
* rendering/RenderNamedFlowThread.h: Added.
(WebCore):
(RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::name):
(WebCore::RenderNamedFlowThread::hasChildren):
(WebCore::RenderNamedFlowThread::hasChild):
(WebCore::RenderNamedFlowThread::isRenderNamedFlowThread):
(WebCore::toRenderNamedFlowThread):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderNamedFlowThread):
* rendering/RenderObjectChildList.cpp:
(WebCore::renderNamedFlowThreadContainer):
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::attachRegion):
* rendering/RenderRegion.h:
(WebCore):
(WebCore::RenderRegion::parentNamedFlowThread):
(RenderRegion):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderNamedFlowThreads):
(WebCore::writeLayers):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::styleDidChange):
(WebCore::RenderView::ensureRenderFlowThreadWithName):
(WebCore::RenderView::layoutRenderNamedFlowThreads):
* rendering/RenderView.h:
(WebCore):
(RenderView):
(WebCore::RenderView::hasRenderNamedFlowThreads):
(WebCore::RenderView::isRenderNamedFlowThreadOrderDirty):
(WebCore::RenderView::setIsRenderNamedFlowThreadOrderDirty):
(WebCore::RenderView::renderNamedFlowThreadList):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=81685

[New Multicolumn] Add RenderMultiColumnFlowThread to hold the flow thread contents of a multi-column block.
It derives from RenderFlowThread.

Change layout test results to reflect the name change from RenderFlowThread to
RenderNamedFlowThread. Other platforms should update results accordingly.

Reviewed by Julien Chaffraix.

* fast/repaint/inline-relative-positioned-expected.txt:
* fast/repaint/overflow-clip-subtree-layout-expected.txt:
* fast/repaint/subtree-root-clip-2-expected.txt:
* fast/repaint/subtree-root-clip-3-expected.txt:
* fast/repaint/subtree-root-clip-expected.txt:
* platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt:
* platform/mac/fast/regions/flow-content-basic-expected.txt:
* platform/mac/fast/regions/flow-content-basic-vertical-expected.txt:
* platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt:
* platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
* platform/mac/fast/regions/overflow-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
* platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt:
* platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt:
* platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt:
* platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.txt:
* platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt:
* platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt:
* platform/mac/fast/regions/region-overflow-break-expected.txt:
* platform/mac/fast/regions/region-style-block-background-color-expected.txt:
* platform/mac/fast/regions/region-style-block-background-color2-expected.txt:
* platform/mac/fast/regions/region-style-image-background-color-expected.txt:
* platform/mac/fast/regions/region-style-inline-background-color-expected.txt:
* platform/mac/fast/regions/render-region-custom-style-mark-expected.txt:
* platform/mac/fast/regions/text-region-split-small-pagination-expected.txt:
* platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
* platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.txt:
* platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:
* platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt:
* platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt:
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt:
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
* platform/mac/fast/repaint/region-painting-invalidation-expected.txt:
* platform/mac/fast/repaint/region-painting-via-layout-expected.txt:
* platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
* platform/qt/fast/repaint/region-painting-invalidation-expected.txt:
* platform/qt/fast/repaint/region-painting-via-layout-expected.txt:
* platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unnecessary rounding in RenderLayerBacking
eae@chromium.org [Wed, 28 Mar 2012 22:09:28 +0000 (22:09 +0000)]
Remove unnecessary rounding in RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=82529

Reviewed by Eric Seidel.

Remove rounding that is no longer required now that borderBoxRect returns
an IntRect.

No new tests.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r112432.
enne@google.com [Wed, 28 Mar 2012 22:07:25 +0000 (22:07 +0000)]
Unreviewed, rolling out r112432.
http://trac.webkit.org/changeset/112432
https://bugs.webkit.org/show_bug.cgi?id=82536

Causes ccs3 layout test asserts (Requested by enne on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-28

Source/WebCore:

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::reserveTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):
* platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::tileRect):
* platform/graphics/chromium/cc/CCLayerTilingData.h:
(WebCore::CCLayerTilingData::numTiles):
(WebCore::CCLayerTilingData::tileBounds):
(WebCore::CCLayerTilingData::isEmpty):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::appendQuads):
* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::platformApplySoftware):
* platform/graphics/gpu/Texture.cpp:
(WebCore::Texture::create):
(WebCore::Texture::updateSubRect):
* platform/graphics/gpu/TilingData.cpp:
(WebCore::TilingData::tileBounds):
(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::tileBoundsNormalized):
(WebCore::TilingData::intersectDrawQuad):
(WebCore):
* platform/graphics/gpu/TilingData.h:
(WebCore::TilingData::numTiles):
(WebCore::TilingData::tileIndex):
(WebCore::TilingData::tileXIndex):
(WebCore::TilingData::tileYIndex):
(TilingData):
(WebCore::TilingData::assertTile):

Source/WebKit/chromium:

* tests/TiledLayerChromiumTest.cpp:
* tests/TilingDataTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Merge ChromiumDataObject and DataTransferItemListChromium.
dcheng@chromium.org [Wed, 28 Mar 2012 22:03:41 +0000 (22:03 +0000)]
[chromium] Merge ChromiumDataObject and DataTransferItemListChromium.
https://bugs.webkit.org/show_bug.cgi?id=82407

Reviewed by Tony Chang.

Source/WebCore:

Since ChromiumDataObject is just a very thin wrapper for DataTransferItemListChromium now,
combine the two and remove a layer of indirection.

No functionality change, should be covered by existing tests.

* WebCore.gypi:
* platform/chromium/ChromiumDataObject.cpp: Replacing DataTransferItemListChromium.
(WebCore::ChromiumDataObject::createFromPasteboard):
(WebCore::ChromiumDataObject::create):
(WebCore::ChromiumDataObject::length):
(WebCore):
(WebCore::ChromiumDataObject::item):
(WebCore::ChromiumDataObject::deleteItem):
(WebCore::ChromiumDataObject::clearAll):
(WebCore::ChromiumDataObject::add):
(WebCore::ChromiumDataObject::clearData):
(WebCore::ChromiumDataObject::clearAllExceptFiles):
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::setData):
(WebCore::ChromiumDataObject::urlAndTitle):
(WebCore::ChromiumDataObject::setURLAndTitle):
(WebCore::ChromiumDataObject::htmlAndBaseURL):
(WebCore::ChromiumDataObject::setHTMLAndBaseURL):
(WebCore::ChromiumDataObject::containsFilenames):
(WebCore::ChromiumDataObject::filenames):
(WebCore::ChromiumDataObject::addFilename):
(WebCore::ChromiumDataObject::addSharedBuffer):
(WebCore::ChromiumDataObject::ChromiumDataObject):
(WebCore::ChromiumDataObject::findStringItem):
(WebCore::ChromiumDataObject::internalAddStringItem):
(WebCore::ChromiumDataObject::internalAddFileItem):
* platform/chromium/ChromiumDataObject.h:
(WebCore):
(ChromiumDataObject):
* platform/chromium/ChromiumDataObjectItem.cpp: Renamed from Source/WebCore/platform/chromium/DataTransferItemChromium.cpp.
(WebCore):
(WebCore::ChromiumDataObjectItem::createFromString):
(WebCore::ChromiumDataObjectItem::createFromFile):
(WebCore::ChromiumDataObjectItem::createFromURL):
(WebCore::ChromiumDataObjectItem::createFromHTML):
(WebCore::ChromiumDataObjectItem::createFromSharedBuffer):
(WebCore::ChromiumDataObjectItem::createFromPasteboard):
(WebCore::ChromiumDataObjectItem::ChromiumDataObjectItem):
(WebCore::ChromiumDataObjectItem::getAsString):
(WebCore::ChromiumDataObjectItem::getAsFile):
(WebCore::ChromiumDataObjectItem::internalGetAsString):
(WebCore::ChromiumDataObjectItem::isFilename):
* platform/chromium/ChromiumDataObjectItem.h: Renamed from Source/WebCore/platform/chromium/DataTransferItemChromium.h.
(WebCore):
(ChromiumDataObjectItem):
(WebCore::ChromiumDataObjectItem::kind):
(WebCore::ChromiumDataObjectItem::type):
(WebCore::ChromiumDataObjectItem::sharedBuffer):
(WebCore::ChromiumDataObjectItem::title):
(WebCore::ChromiumDataObjectItem::baseURL):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::files):
(WebCore::ClipboardChromium::hasData):
(WebCore::ClipboardChromium::items):
* platform/chromium/DataTransferItemListChromium.cpp: Removed.
* platform/chromium/DataTransferItemListChromium.h: Removed.

Source/WebKit/chromium:

* src/WebDragData.cpp:
(WebKit::WebDragData::items):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline
jam@chromium.org [Wed, 28 Mar 2012 22:00:27 +0000 (22:00 +0000)]
Unreviewed rebaseline

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Scheduler should not tell FrameRateController to begin a frame when we...
nduca@chromium.org [Wed, 28 Mar 2012 21:45:07 +0000 (21:45 +0000)]
[chromium] Scheduler should not tell FrameRateController to begin a frame when we dont swap
https://bugs.webkit.org/show_bug.cgi?id=82516

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::swapBuffers):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::swapBuffers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::processScheduledActions):
* platform/graphics/chromium/cc/CCScheduler.h:
(WebCore::CCScheduledActionDrawAndSwapResult::CCScheduledActionDrawAndSwapResult):
(CCScheduledActionDrawAndSwapResult):
(WebCore):
(CCSchedulerClient):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapIfPossible):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapForced):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* tests/CCSchedulerTest.cpp:
(WebKitTests::FakeCCSchedulerClient::reset):
(WebKitTests::FakeCCSchedulerClient::hasAction):
(FakeCCSchedulerClient):
(WebKitTests::FakeCCSchedulerClient::scheduledActionDrawAndSwapIfPossible):
(WebKitTests::FakeCCSchedulerClient::scheduledActionDrawAndSwapForced):
(WebKitTests::FakeCCSchedulerClient::setDrawWillHappen):
(WebKitTests::FakeCCSchedulerClient::setSwapWillHappenIfDrawHappens):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionDrawAndSwapIfPossible):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionDrawAndSwapForced):
(SchedulerClientThatSetNeedsDrawInsideDraw):
(WebKitTests::TEST):
(WebKitTests::SchedulerClientThatSetNeedsCommitInsideDraw::scheduledActionDrawAndSwapIfPossible):
(WebKitTests::SchedulerClientThatSetNeedsCommitInsideDraw::scheduledActionDrawAndSwapForced):
(SchedulerClientThatSetNeedsCommitInsideDraw):
(WebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFileWriter has two race conditions
ericu@chromium.org [Wed, 28 Mar 2012 21:43:10 +0000 (21:43 +0000)]
FileWriter has two race conditions
https://bugs.webkit.org/show_bug.cgi?id=81861

Reviewed by David Levin.

Should make current tests less flaky.

* Modules/filesystem/FileWriter.h:
* Modules/filesystem/FileWriter.cpp:
Track the in-flight operation, whether it be an abort/write/truncate.
Whether an abort comes back as didWrite, didTruncate, or didFail, handle
it appropriately.  Before this fix, the Chromium implementation would
assert in two cases:

If the user calls abort, then write, then abort before the backend
catches up, we'd send both aborts to the backend, even though it hadn't
received the write yet.  Chromium's backend asserts if there's an abort
with no write in progress.  We now record that we've sent an abort and
are waiting for the response.

If the user calls abort while a write/truncate is just finishing, on the
Chromium worker implementation, the completion message could be
thread-hopping back to WebCore at the
WorkerAsyncFileWriterCallbacksBridge while the abort is thread-hopping
in the other direction.  Again, this leads to an abort call to the
backend with no write in progress, and an assert.  We're now robust to
completions coming back when we're expecting an abort, and
https://chromiumcodereview.appspot.com/9764018/ will make the backend
robust to extra abort calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDeleting a paragraph of text should not add elements for typing style
rniwa@webkit.org [Wed, 28 Mar 2012 21:41:34 +0000 (21:41 +0000)]
Deleting a paragraph of text should not add elements for typing style
https://bugs.webkit.org/show_bug.cgi?id=82401

Reviewed by Enrica Casucci.

Source/WebCore:

This behavior was explicitly supported by DeleteSelectionCommand but it doesn't match TextEdit or Firefox.
We're changing our behavior to match TextEdit and Firefox in this patch.

The behavior is tested by an existing test, which was renamed to deleting-text-rests-typing-style.html in this patch.

Test: editing/execCommand/deleting-text-rests-typing-style.html

* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):

LayoutTests:

Rebaselined the tests per behavior changes. Also renamed 19653-3.html to deleting-text-rests-typing-style.html
which tests this behavioral change.

* editing/deleting/delete-and-cleanup-expected.txt:
* editing/deleting/delete-and-cleanup.html: Elements added for typing styles have been removed.
* editing/deleting/delete-br-012-expected.txt: Ditto.
* editing/deleting/delete-select-all-001-expected.txt: Ditto.
* editing/execCommand/19653-3-expected.txt: Removed.
* editing/execCommand/19653-3.html: Removed.
* editing/execCommand/apply-style-text-decoration-crash-expected.txt:
* editing/execCommand/delete-image-in-anchor-expected.txt: Ditto.
* editing/execCommand/deleting-text-rests-typing-style-expected.txt: Copied from LayoutTests/editing/execCommand/19653-3-expected.txt.
* editing/execCommand/deleting-text-rests-typing-style.html: Copied from LayoutTests/editing/execCommand/19653-3.html.
* editing/inserting/5994480-2-expected.txt:
* editing/inserting/5994480-2.html: Ditto; converted this test to a dump-as-markup test for clarity.
* editing/pasteboard/paste-text-with-style-2-expected.txt: Elements added for typing styles have been removed.
* editing/style/block-style-005-expected.txt:  Ditto.
* editing/pasteboard/select-element-1-expected.txt: Editing delegate dump changed but the final result remains intact.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agodownload-built-product build step should detect 404 errors
simon.fraser@apple.com [Wed, 28 Mar 2012 21:33:16 +0000 (21:33 +0000)]
download-built-product build step should detect 404 errors
https://bugs.webkit.org/show_bug.cgi?id=82491

Reviewed by Ryosuke Niwa.

Pass --fail to curl so that it reports 404 errors.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(DownloadBuiltProduct): Pass --fail to curl so that it reports errors.
* BuildSlaveSupport/built-product-archive:
(extractBuiltProduct): Remove trailing whitespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoflakiness dashboard should only keep the last 500 runs
dpranke@chromium.org [Wed, 28 Mar 2012 21:29:07 +0000 (21:29 +0000)]
flakiness dashboard should only keep the last 500 runs
https://bugs.webkit.org/show_bug.cgi?id=82530

Reviewed by Ojan Vafai.

If a bot has an overly large amount of failing tests, then
storing 750 runs' worth takes a lot of memory and CPU time to
process and we end up getting killed by AppEngine; this cases
data corruption and confusion down the road when we have to
retry the upload of the data and the tests show up as multiple
runs.

* TestResultServer/model/jsonresults.py:
(JsonResults.update_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore Chromium rebaselines from the expected failures tab in garden-o-matic.
ojan@chromium.org [Wed, 28 Mar 2012 21:26:56 +0000 (21:26 +0000)]
More Chromium rebaselines from the expected failures tab in garden-o-matic.
They all looked like straightforward text-rendering or anti-aliasing issues,
except for some where the new results were clearly just more correct.

* fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Copied from LayoutTests/platform/efl/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png.
* platform/chromium-linux/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
* platform/chromium-linux/fast/dynamic/containing-block-change-expected.png: Added.
* platform/chromium-linux/fast/dynamic/first-letter-display-change-expected.png: Added.
* platform/chromium-linux/fast/dynamic/window-resize-scrollbars-test-expected.png:
* platform/chromium-linux/fast/events/updateLayoutForHitTest-expected.png: Renamed from LayoutTests/platform/efl/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png.
* platform/chromium-linux/fast/events/updateLayoutForHitTest-expected.txt: Added.
* platform/chromium-mac-leopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
* platform/chromium-mac-leopard/fast/dom/getElementsByClassName/011-expected.txt: Added.
* platform/chromium-mac-leopard/fast/dynamic/containing-block-change-expected.png: Added.
* platform/chromium-mac-leopard/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
* platform/chromium-mac-leopard/fast/events/updateLayoutForHitTest-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/52776-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/52776-expected.txt:
* platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dynamic/containing-block-change-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png:
* platform/chromium-mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png:
* platform/chromium-mac-snowleopard/fast/events/reveal-link-when-focused-expected.png:
* platform/chromium-mac-snowleopard/fast/events/updateLayoutForHitTest-expected.png: Added.
* platform/chromium-mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
* platform/chromium-mac/fast/dynamic/containing-block-change-expected.png: Added.
* platform/chromium-mac/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
* platform/chromium-mac/fast/dynamic/window-resize-scrollbars-test-expected.txt: Added.
* platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png: Added.
* platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.txt: Added.
* platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png: Added.
* platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.txt: Added.
* platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png: Added.
* platform/chromium-mac/fast/events/updateLayoutForHitTest-expected.png: Added.
* platform/chromium-mac/fast/events/updateLayoutForHitTest-expected.txt: Added.
* platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
* platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
* platform/chromium-win/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Renamed from LayoutTests/platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png.
* platform/chromium-win/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
* platform/chromium-win/fast/dynamic/containing-block-change-expected.png: Added.
* platform/chromium-win/fast/dynamic/containing-block-change-expected.txt: Added.
* platform/chromium-win/fast/dynamic/first-letter-display-change-expected.png: Added.
* platform/chromium-win/fast/dynamic/window-resize-scrollbars-test-expected.png:
* platform/chromium-win/fast/dynamic/window-resize-scrollbars-test-expected.txt:
* platform/chromium/fast/dom/Window/get-set-properties-expected.txt:
* platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Copied from LayoutTests/fast/dom/Window/window-property-descriptors-expected.txt.
* platform/chromium/fast/dom/Window/window-property-shadowing-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/dom/Window/window-property-descriptors-expected.txt: Renamed from LayoutTests/fast/dom/Window/window-property-descriptors-expected.txt.
* platform/mac/fast/dynamic/first-letter-display-change-expected.txt: Renamed from LayoutTests/fast/dynamic/first-letter-display-change-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoextract-built-product build step should fail if unzipping fails
rniwa@webkit.org [Wed, 28 Mar 2012 21:21:50 +0000 (21:21 +0000)]
extract-built-product build step should fail if unzipping fails
https://bugs.webkit.org/show_bug.cgi?id=82493

Reviewed by Simon Fraser.

Forward non-zero exit code from subprocesses so that the master can detect any failures
and bail out early.

* BuildSlaveSupport/built-product-archive:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add tracing events around CCLayerTreeHostImpl visibility.
commit-queue@webkit.org [Wed, 28 Mar 2012 21:18:20 +0000 (21:18 +0000)]
[chromium] Add tracing events around CCLayerTreeHostImpl visibility.
https://bugs.webkit.org/show_bug.cgi?id=82501

Patch by Michal Mocny <mmocny@google.com> on 2012-03-28
Reviewed by James Robinson.

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIncorrect foreignObject hit test results when overlapping other SVG elements
commit-queue@webkit.org [Wed, 28 Mar 2012 21:00:37 +0000 (21:00 +0000)]
Incorrect foreignObject hit test results when overlapping other SVG elements
https://bugs.webkit.org/show_bug.cgi?id=82059

Patch by Florin Malita <fmalita@google.com> on 2012-03-28
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/hittest/foreign-object-background.svg

Foreign content needs to be hit-tested atomically due to the (pseudo)
stacking context established by FOs.

* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
Hit test all phases on FO HitTestForeground.

LayoutTests:

* svg/hittest/foreign-object-background-expected.txt: Added.
* svg/hittest/foreign-object-background.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agotest-webkitpy should support files, directories, and packages as command line args
dpranke@chromium.org [Wed, 28 Mar 2012 20:59:06 +0000 (20:59 +0000)]
test-webkitpy should support files, directories, and packages as command line args
https://bugs.webkit.org/show_bug.cgi?id=76765

Reviewed by Adam Barth.

This patch adds support for specifying files, directories, and
packages to test-webkitpy along with the already existing
support for modules, test classes, and individual test names.

Also, fix a bug in filesystem_mock where we wouldn't normalize a
path containing a reference to the current directory properly,
for example, '/foo/./bar.py'.

* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.normpath):
* Scripts/webkitpy/test/main.py:
(Tester._configure_logging):
(Tester._run_tests):
* Scripts/webkitpy/test/test_finder.py:
(TestDirectoryTree.find_modules):
(TestDirectoryTree.subpath):
(TestFinder.is_dotted_name):
(TestFinder.find_names):
(TestFinder):
(TestFinder._find_names_for_arg):
(TestFinder._find_in_trees):
(TestFinder._default_names):
* Scripts/webkitpy/test/test_finder_unittest.py:
(TestFinderTest.setUp):
(TestFinderTest.tearDown):
(TestFinderTest.check_names):
(TestFinderTest.test_default_names):
(TestFinderTest):
(TestFinderTest.test_paths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] layer->clipRect() is not initialized for layers that create a renderSurface.
shawnsingh@chromium.org [Wed, 28 Mar 2012 20:42:19 +0000 (20:42 +0000)]
[chromium] layer->clipRect() is not initialized for layers that create a renderSurface.
https://bugs.webkit.org/show_bug.cgi?id=74147

Reviewed by Adrienne Walker.

Source/WebCore:

Added 3 additional unit tests; Modified existing unit tests and layout tests.

The layer's clipRect and usesLayerClipping information was not
being initialized for layers that created a renderSurface. (It
was, however, being initialized for the renderSurface itself.)
This patch adds a unit test that reproduces that this is an error,
other unit tests to tightly test the value of clipRect being
initialized, and adds the logic to properly initialize the
clipRect.

Before this patch, this bug was causing flashing on tab-switch on
the apple iphone page. Even worse, with partial swap enabled, the
layers would simply disappear, because the first frame the
clipRect is uninitialized and the layer is not drawn, and the
second frame onwards, the damage tracker correctly things nothing
is damaged, so it doesn't draw that layer again until other damage
causes it to be redrawn.

* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

Added 3 more unit tests. One reproduces the clipRect problem in an
integrated manner, the other two directly test that clipRects are
properly initialized.

* tests/CCLayerTreeHostCommonTest.cpp:
(WebCore::TEST):
(WebCore):
* tests/CCLayerTreeTestCommon.h:
(WebKitTests):

LayoutTests:

* platform/chromium/test_expectations.txt: marked test as needing rebaselining

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix inspector tests when running in internal builds.
simon.fraser@apple.com [Wed, 28 Mar 2012 20:41:15 +0000 (20:41 +0000)]
Fix inspector tests when running in internal builds.

<rdar://problem/11050694>

Reviewed by Tim Hatcher.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago"Sticky" or slow scrolling on some sites
andersca@apple.com [Wed, 28 Mar 2012 20:36:39 +0000 (20:36 +0000)]
"Sticky" or slow scrolling on some sites
https://bugs.webkit.org/show_bug.cgi?id=82512
<rdar://problem/11000372>

Reviewed by Andreas Kling.

When we're in the slow mode and have to update the scroll layer position on the main thread,
get it from the scrolling thread so we'll be in sync with the scrolling tree when the main thread is busy.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::mainFrameScrollPosition):
(WebCore):
(WebCore::ScrollingTree::updateMainFrameScrollPositionAndScrollLayerPosition):
* page/scrolling/ScrollingTree.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update worker-multi-port-expected.txt.
jam@chromium.org [Wed, 28 Mar 2012 20:29:38 +0000 (20:29 +0000)]
[chromium] Update worker-multi-port-expected.txt.

https://bugs.webkit.org/show_bug.cgi?id=82499

Reviewed by James Robinson.

* platform/chromium-win/fast/workers/worker-multi-port-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fix tiled layer assert for huge layers
enne@google.com [Wed, 28 Mar 2012 20:20:23 +0000 (20:20 +0000)]
[chromium] Fix tiled layer assert for huge layers
https://bugs.webkit.org/show_bug.cgi?id=82486

Reviewed by James Robinson.

Source/WebCore:

Test: TiledLayerChromiumTest.hugeLayerUpdateCrash

TilingData::numTiles() is calculated as the product of two ints and so
can potentially overflow, causing numTiles() to be incorrect. To avoid
calling code accidentally falling into this trap, remove this function
and all code that uses tile index from TilingData.  This requires
fixing up a bunch of callers of TilingData and CCLayerTilingData.

Additionally, TilingData::numTiles() has long been a confusing
function name in some contexts, so rename to bool hasEmptyBounds().

Also, remove TilingData::intersectDrawQuad because there are no
clients of that function.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::reserveTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):
* platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::tileRect):
* platform/graphics/chromium/cc/CCLayerTilingData.h:
(WebCore::CCLayerTilingData::hasEmptyBounds):
(WebCore::CCLayerTilingData::tileBounds):
(WebCore::CCLayerTilingData::isEmpty):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::appendQuads):
* platform/graphics/gpu/Texture.cpp:
(WebCore::Texture::create):
(WebCore::Texture::updateSubRect):
* platform/graphics/gpu/TilingData.cpp:
(WebCore::TilingData::tileBounds):
(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::tileBoundsNormalized):
* platform/graphics/gpu/TilingData.h:
(WebCore::TilingData::hasEmptyBounds):
(TilingData):
(WebCore::TilingData::assertTile):

Source/WebKit/chromium:

Add test for updating a huge layer that would assert prior to this
code. Fix up TilingData tests to use a testing class that provides a
safe version of numTiles().

* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
(WTF):
* tests/TilingDataTest.cpp:
(TestTiling):
(WebCore::TestTiling::TestTiling):
(WebCore::TestTiling::numTiles):
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse xcrun to find nm and ranlib on OS X builds
ddkilzer@apple.com [Wed, 28 Mar 2012 20:13:27 +0000 (20:13 +0000)]
Use xcrun to find nm and ranlib on OS X builds
<http://webkit.org/b/82466>

Reviewed by Dan Bernstein.

* Scripts/build-webkit: Use xcrun to find ranlib.
* Scripts/webkitdirs.pm:
(determineNmPath): Added.  Use xcrun to find nm on OS X.
(nmPath): Added.
* Scripts/webkitperl/features.pm:
(libraryContainsSymbol): Use nmPath().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore flaky tests.
dpranke@chromium.org [Wed, 28 Mar 2012 19:56:07 +0000 (19:56 +0000)]
More flaky tests.

Unreviewed, expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: CodeGeneratorInspector.py: switch Runtime, Network and DOM domains...
vsevik@chromium.org [Wed, 28 Mar 2012 19:44:57 +0000 (19:44 +0000)]
Web Inspector: CodeGeneratorInspector.py: switch Runtime, Network and DOM domains to typed API
https://bugs.webkit.org/show_bug.cgi?id=81558

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-28
Reviewed by Pavel Feldman.

Client code is switched to typed API (all InspectorObject and InspectorArray types are
replaced with generated types from TypeBuilder according to Inspector.json).

Missing array of int specialization is added. Code generator now has a check against
misspelled (non-existing) domain names.

* inspector/CodeGeneratorInspector.py:
(Generator.go): check against misspelled domain names added.
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::wrapNode):
(WebCore::InjectedScript::wrapSerializedObject):
(WebCore::InjectedScript::makeEvalCall):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::pushNodePathToFrontend):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getAttributes):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
(WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
(WebCore::InspectorDOMAgent::loadEventFired):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::styleAttributeInvalidated):
(WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::resourceTypeJson):
(WebCore::InspectorPageAgent::cachedResourceTypeJson):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
* inspector/InspectorPageAgent.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForResourceRequest):
(WebCore::buildObjectForResourceResponse):
(WebCore::buildObjectForCachedResource):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::buildInitiatorObject):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
* inspector/InspectorResourceAgent.h:
(InspectorResourceAgent):
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):
* inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):
* inspector/InspectorValues.h:
(InspectorArray):
(WebCore::InspectorArray::pushInt):
(WebCore):
* inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::buildInspectorObject):
* inspector/ScriptCallFrame.h:
(ScriptCallFrame):
* inspector/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::buildInspectorArray):
* inspector/ScriptCallStack.h:
(ScriptCallStack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosetNeedsLayout(true, false) is super confusing to read and should use an enum instead
eric@webkit.org [Wed, 28 Mar 2012 19:25:02 +0000 (19:25 +0000)]
setNeedsLayout(true, false) is super confusing to read and should use an enum instead
https://bugs.webkit.org/show_bug.cgi?id=82369

Reviewed by Julien Chaffraix.

I replaced all uses of the markParents bool with a MarkingBehavior
enum (which has two values: MarkContainingBlockChain and MarkOnlyThis).
I'm not sure the naming is perfect (as it's not clear to me if markParents is
used to mean the same thing in these 3 functions), but hopefully this code is more
clear.  I welcome further suggested adjustment from layout experts.

* page/FrameView.cpp:
(WebCore::FrameView::scheduleRelayout):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::removePositionedObjects):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::adjustBlockChildForPagination):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::positionNewFloatOnLine):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionLineBox):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::gatherFlexChildrenInfo):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setPreferredLogicalWidthsDirty):
* rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::layoutSpecialExcludedChild):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::layoutSpecialExcludedChild):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::layout):
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::layout):
* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::layout):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/82419> Web Inspector: Create -[DOMNode inspect] from IDL
commit-queue@webkit.org [Wed, 28 Mar 2012 19:22:07 +0000 (19:22 +0000)]
<webkit.org/b/82419> Web Inspector: Create -[DOMNode inspect] from IDL

Source/WebCore:

Instead of manually creating the method in DOM.mm we can specify it in
Node.idl and autogenerate part of the interface.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-28
Reviewed by Timothy Hatcher.

* bindings/objc/DOM.mm:
* bindings/objc/DOMPrivate.h:
Move the call to InspectorController::inspect from here ...

* dom/Node.h:
* dom/Node.idl: IDL only in an ObjC block.
* dom/Node.cpp:
(WebCore::Node::inspect):
... to here.

* WebCore.xcodeproj/project.pbxproj:
Add the new generated file so we can Copy it in the build phase.

Source/WebKit/mac:

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-28
Reviewed by Timothy Hatcher.

* MigrateHeaders.make: Copy DOMNodePrivate.h to PrivateHeaders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd history navigation to garden-o-matic
ojan@chromium.org [Wed, 28 Mar 2012 19:19:36 +0000 (19:19 +0000)]
Add history navigation to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=82495

Reviewed by Dimitri Glazkov.

Also, maintain scroll offsets when returning to a tab. This makes addressing
expected failures considerably easier when dealing with below-the-fold tests.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
-Store the scrollTop before switching to a new tab and restore the appropriate scrollTop after
switching.
-Modify window.location with the tabName in the hash. Can't use pushState because this is served
from a file URL and Chrome puts each different file URL in it's own origin.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
Remove the href so that clicking on the accordion item does not modify window.location.hash.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] MediaStream API (JSEP): Introducing WebPeerConnection00Handler
tommyw@google.com [Wed, 28 Mar 2012 18:44:06 +0000 (18:44 +0000)]
[chromium] MediaStream API (JSEP): Introducing WebPeerConnection00Handler
https://bugs.webkit.org/show_bug.cgi?id=82450

Reviewed by Adam Barth.

Source/WebCore:

This change removes the default PeerConnection00Handler.cpp from the Chromium build.

A major overhaul of the existing layout tests is forthcoming.

* WebCore.gypi:
* platform/mediastream/PeerConnection00Handler.h:
(WebCore):
(PeerConnection00Handler):

Source/WebKit/chromium:

Last patch to enable the PeerConnection00 functionality in Chromium introduces
WebPeerConnection00Handler and WebPeerConnection00HandlerClient, together with the necessary plumbing.

* WebKit.gyp:
* bridge/PeerConnection00Handler.cpp: Added.
(WebCore):
(WebCore::PeerConnection00Handler::create):
(WebCore::PeerConnection00Handler::PeerConnection00Handler):
(WebCore::PeerConnection00Handler::~PeerConnection00Handler):
(WebCore::PeerConnection00Handler::createOffer):
(WebCore::PeerConnection00Handler::createAnswer):
(WebCore::PeerConnection00Handler::setLocalDescription):
(WebCore::PeerConnection00Handler::setRemoteDescription):
(WebCore::PeerConnection00Handler::localDescription):
(WebCore::PeerConnection00Handler::remoteDescription):
(WebCore::PeerConnection00Handler::startIce):
(WebCore::PeerConnection00Handler::processIceMessage):
(WebCore::PeerConnection00Handler::addStream):
(WebCore::PeerConnection00Handler::removeStream):
(WebCore::PeerConnection00Handler::stop):
* bridge/PeerConnection00HandlerInternal.cpp: Added.
(WebCore):
(WebCore::PeerConnection00HandlerInternal::PeerConnection00HandlerInternal):
(WebCore::PeerConnection00HandlerInternal::~PeerConnection00HandlerInternal):
(WebCore::PeerConnection00HandlerInternal::createOffer):
(WebCore::PeerConnection00HandlerInternal::createAnswer):
(WebCore::PeerConnection00HandlerInternal::setLocalDescription):
(WebCore::PeerConnection00HandlerInternal::setRemoteDescription):
(WebCore::PeerConnection00HandlerInternal::localDescription):
(WebCore::PeerConnection00HandlerInternal::remoteDescription):
(WebCore::PeerConnection00HandlerInternal::startIce):
(WebCore::PeerConnection00HandlerInternal::processIceMessage):
(WebCore::PeerConnection00HandlerInternal::addStream):
(WebCore::PeerConnection00HandlerInternal::removeStream):
(WebCore::PeerConnection00HandlerInternal::stop):
(WebCore::PeerConnection00HandlerInternal::didGenerateICECandidate):
(WebCore::PeerConnection00HandlerInternal::didChangeReadyState):
(WebCore::PeerConnection00HandlerInternal::didChangeICEState):
(WebCore::PeerConnection00HandlerInternal::didAddRemoteStream):
(WebCore::PeerConnection00HandlerInternal::didRemoveRemoteStream):
* bridge/PeerConnection00HandlerInternal.h: Copied from Source/WebCore/platform/mediastream/PeerConnection00Handler.h.
(WebKit):
(WebCore):
(PeerConnection00HandlerInternal):
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::createPeerConnection00Handler):
* public/platform/WebPeerConnection00Handler.h: Added.
(WebKit):
(WebPeerConnection00Handler):
(WebKit::WebPeerConnection00Handler::~WebPeerConnection00Handler):
* public/platform/WebPeerConnection00HandlerClient.h: Added.
(WebKit):
(WebPeerConnection00HandlerClient):
(WebKit::WebPeerConnection00HandlerClient::~WebPeerConnection00HandlerClient):
* src/AssertMatchingEnums.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[REGRESSION] Web Inspector: column caption delimiters are misaligned in DataGrid
robert@webkit.org [Wed, 28 Mar 2012 18:32:28 +0000 (18:32 +0000)]
[REGRESSION] Web Inspector: column caption delimiters are misaligned in DataGrid
https://bugs.webkit.org/show_bug.cgi?id=82193

Reviewed by Yury Semikhatsky.

Since r111742 column width in fixed layout tables is set to the width of the cell plus its left padding plus its right padding
plus half its left border plus half its right border in the collapsing border model. The layout of the panel
headers in the inspector depended on pre-r111742 behaviour, so ended up misaligned with the content below. To cater for the
new method of calculating column width enforce a fixed width for the corner column by removing padding and borders (except collapsed
borders from adjacent cells) and specify the expected width (15px) minus the expected width of the collapsed borders (1px).

* inspector/front-end/dataGrid.css:
(.data-grid th.corner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIncrease code sharing between CSSProperty and CSSPropertyLonghand.
alexis.menard@openbossa.org [Wed, 28 Mar 2012 18:29:54 +0000 (18:29 +0000)]
Increase code sharing between CSSProperty and CSSPropertyLonghand.
https://bugs.webkit.org/show_bug.cgi?id=82479

Reviewed by Antti Koivisto.

Use longhands declarations from CSSPropertyLonghand in CSSProperty to avoid
code duplication.

No new tests : refactoring only, we shouldn't have any behavior difference.

* css/CSSProperty.cpp:
(WebCore::resolveToPhysicalProperty):
(WebCore::borderDirections):
(WebCore):
(WebCore::CSSProperty::resolveDirectionAwareProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Compositor visibility setting must be updated even if not actively compositing
commit-queue@webkit.org [Wed, 28 Mar 2012 18:24:01 +0000 (18:24 +0000)]
[chromium] Compositor visibility setting must be updated even if not actively compositing
https://bugs.webkit.org/show_bug.cgi?id=82406

Patch by James Robinson <jamesr@chromium.org> on 2012-03-28
Reviewed by Adrienne Walker.

Propagate the visibility bit to the WebLayerTreeView even when compositing is inactive.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setVisibilityState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Implement snippets renaming in scripts navigator.
vsevik@chromium.org [Wed, 28 Mar 2012 18:23:00 +0000 (18:23 +0000)]
Web Inspector: Implement snippets renaming in scripts navigator.
https://bugs.webkit.org/show_bug.cgi?id=82477

Reviewed by Pavel Feldman.

Snippets renaming is implemented as editing of snippet name in scripts navigator.

* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._handleRenameSnippet):
(WebInspector.ScriptsNavigator.prototype._fileRenamed):
(WebInspector.ScriptsNavigator.prototype.rename.commitHandler):
(WebInspector.ScriptsNavigator.prototype.rename.cancelHandler):
(WebInspector.ScriptsNavigator.prototype.rename.afterEditing):
(WebInspector.BaseNavigatorTreeElement.prototype.set titleText):
* inspector/front-end/scriptsPanel.css:
(#scripts-navigator-tabbed-pane .navigator .base-navigator-tree-element-title.editing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r109826): Can't type into Flash text fields
andersca@apple.com [Wed, 28 Mar 2012 18:20:59 +0000 (18:20 +0000)]
REGRESSION (r109826): Can't type into Flash text fields
https://bugs.webkit.org/show_bug.cgi?id=82488
<rdar://problem/11022004>

Reviewed by Sam Weinig.

This was caused by the fix in r109826. Revert that change and fix the original bug by notifying the UI process
that the plug-in lost focus when it's destroyed. This will correctly reset the text input state (merely setting
the text input state to PluginComplexTextInputDisabled doesn't reset the state correctly).

* UIProcess/API/mac/WKView.mm:
(-[WKView _setPluginComplexTextInputState:]):
(-[WKView _handlePluginComplexTextInputKeyDown:]):
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::~PluginView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Add context menu for snippets control.
vsevik@chromium.org [Wed, 28 Mar 2012 18:13:47 +0000 (18:13 +0000)]
Web Inspector: Add context menu for snippets control.
https://bugs.webkit.org/show_bug.cgi?id=82475

Reviewed by Pavel Feldman.

This is a preliminary implementation of snippets control using context menu.
We might want to add a more discoverable one before taking snippets out of experiments.

* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsNavigator.prototype._createSnippetsTree):
(WebInspector.ScriptsNavigator.prototype._handleSnippetContextMenuEvent):
(WebInspector.ScriptsNavigator.prototype._showSnippetContextMenu):
(WebInspector.ScriptsNavigator.prototype._handleEvaluateSnippet):
(WebInspector.ScriptsNavigator.prototype._handleRenameSnippet):
(WebInspector.ScriptsNavigator.prototype._handleRemoveSnippet):
(WebInspector.ScriptsNavigator.prototype._handleCreateSnippet):
(WebInspector.NavigatorScriptTreeElement.prototype.get navigator):
(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):
(WebInspector.NavigatorScriptTreeElement.prototype._handleContextMenuEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: ScriptsNavigator should save scroll position when switching tabs.
vsevik@chromium.org [Wed, 28 Mar 2012 18:08:04 +0000 (18:08 +0000)]
Web Inspector: ScriptsNavigator should save scroll position when switching tabs.
https://bugs.webkit.org/show_bug.cgi?id=82472

Reviewed by Pavel Feldman.

WebInspector.View provides save/restore scroll position capabilities.
This patch makes them used in ScriptsNavigator.

* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype._createSnippetsTree):
* inspector/front-end/scriptsPanel.css:
(#scripts-navigator-tabbed-pane .tabbed-pane-content):
(#scripts-navigator-tabbed-pane .navigator-container):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, skipping 3 tests timing out after the libsoup upgrade
sergio@webkit.org [Wed, 28 Mar 2012 18:00:57 +0000 (18:00 +0000)]
Unreviewed, skipping 3 tests timing out after the libsoup upgrade
to 2.37.92.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Enable Viewport define by default
fsamuel@chromium.org [Wed, 28 Mar 2012 17:55:04 +0000 (17:55 +0000)]
[Chromium] Enable Viewport define by default
https://bugs.webkit.org/show_bug.cgi?id=79514

Reviewed by Darin Fisher.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: only update Timeline overview when really needed
caseq@chromium.org [Wed, 28 Mar 2012 17:17:02 +0000 (17:17 +0000)]
Web Inspector: only update Timeline overview when really needed
https://bugs.webkit.org/show_bug.cgi?id=81909

Reviewed by Pavel Feldman.

Switch timeline overview to using raw records, thus removing dependency on instance members of
TimelinePresentationModel. This requires moving record styles/categories to static getters.

* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel):
(WebInspector.TimelineModel.startTime):
(WebInspector.TimelineModel.endTime):
(WebInspector.TimelineModel.duration):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype.reset):
(WebInspector.TimelineModel.prototype.minimumRecordTime):
(WebInspector.TimelineModel.prototype.maximumRecordTime):
(WebInspector.TimelineModel.prototype._updateBoundaries):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._setVerticalOverview):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype._updateCategoryStrips.markPercentagesForRecord):
(WebInspector.TimelineOverviewPane.prototype._updateCategoryStrips):
(WebInspector.TimelineOverviewPane.prototype.windowStartTime):
(WebInspector.TimelineOverviewPane.prototype.windowEndTime):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineOverviewPane.prototype.setShowShortEvents):
(WebInspector.TimelineOverviewPane.prototype._scheduleRefresh):
(WebInspector.TimelineOverviewCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineOverviewCalculator.prototype.setWindow):
(WebInspector.TimelineOverviewCalculator.prototype.reset):
(WebInspector.HeapGraph):
(WebInspector.HeapGraph.prototype.update):
(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineVerticalOverview.prototype.reset):
(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype.wasShown):
(WebInspector.TimelineVerticalOverview.prototype.willHide):
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrameStatistics):
(WebInspector.TimelineVerticalOverview.prototype._aggregateRecords):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes):
(WebInspector.TimelineVerticalOverview.prototype._onRecordAdded):
(WebInspector.TimelineAggregatedRecord):
(WebInspector.TimelineAggregatedRecord.prototype._aggregateStatistics):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked):
(WebInspector.TimelinePanel.prototype._resetPanel):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelineCalculator):
(WebInspector.TimelineCalculator.prototype.formatTime):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.categories):
(WebInspector.TimelinePresentationModel.recordStyle):
(WebInspector.TimelinePresentationModel.categoryForRecord):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype.addRecord):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] generate-gtk-doc doesn't cope with custom build directory
philn@webkit.org [Wed, 28 Mar 2012 16:33:03 +0000 (16:33 +0000)]
[GTK] generate-gtk-doc doesn't cope with custom build directory
https://bugs.webkit.org/show_bug.cgi?id=82448

Reviewed by Martin Robinson.

Pass the product directory in generate-gtkdoc arguments from
build-webkit.

* Scripts/webkitdirs.pm:
(buildAutotoolsProject):
* gtk/common.py:
(get_build_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Plumb through GraphicsLayer::contentsOpaque() to LayerTiler
commit-queue@webkit.org [Wed, 28 Mar 2012 16:03:29 +0000 (16:03 +0000)]
[BlackBerry] Plumb through GraphicsLayer::contentsOpaque() to LayerTiler
https://bugs.webkit.org/show_bug.cgi?id=82457

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-28
Reviewed by Rob Buis.

The LayerTiler already knows not to turn on GL_BLEND for opaque layers.
However, it only ever sets the opaque flag for image layers and color
layers, never for content layers.

This was no big deal, because contentsOpaque() is currently false for
all layers except the root layer, which we always drew using the
BlackBerry::WebKit::BackingStore anyway.

When we start using RenderLayerBacking::m_usingTiledCacheLayer=true on
the root layer in situations where the BackingStore is unavailable, we
can speed up rendering of the root layer by honouring the opaque flag.

Fixed by plumbing through the GraphicsLayer::contentsOpaque() flag all
the way to LayerTiler and on to Texture.

* platform/graphics/blackberry/LayerData.h:
(WebCore::LayerData::LayerData):
(WebCore::LayerData::isOpaque):
(LayerData):
* platform/graphics/blackberry/LayerTile.cpp:
(WebCore::LayerTile::updateContents):
* platform/graphics/blackberry/LayerTile.h:
(LayerTile):
* platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::performTileJob):
* platform/graphics/blackberry/LayerTiler.h:
(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::updateContents):
* platform/graphics/blackberry/LayerWebKitThread.h:
(WebCore::LayerWebKitThread::setOpaque):
* platform/graphics/blackberry/Texture.h:
(Texture):
* platform/graphics/blackberry/TextureCacheCompositingThread.cpp:
(WebCore::TextureCacheCompositingThread::updateContents):
* platform/graphics/blackberry/TextureCacheCompositingThread.h:
(TextureCacheCompositingThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
carlosgc@webkit.org [Wed, 28 Mar 2012 15:53:47 +0000 (15:53 +0000)]
[GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=82341

Reviewed by Martin Robinson.

Add --skipped=skip|ignore|only command line option.

* Scripts/run-gtk-tests:
(TestRunner._test_cases_to_skip): Return the list of test cases
to skip for the given test depending on the skipped action.
(TestRunner._should_run_test): Decide whether to run the test or
not depending on the skipped action.
(TestRunner.run_tests): Only show the list of skipped tests when
skipped action is 'skip'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed: updated chromium test expectations.
pfeldman@chromium.org [Wed, 28 Mar 2012 15:49:13 +0000 (15:49 +0000)]
Not reviewed: updated chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
carlosgc@webkit.org [Wed, 28 Mar 2012 15:47:15 +0000 (15:47 +0000)]
[GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
https://bugs.webkit.org/show_bug.cgi?id=82333

Reviewed by Martin Robinson.

* Scripts/run-gtk-tests:
(TestRunner.SkippedTest): Add SkippedTest class to store more
information about skipped tests.
(TestRunner._setup_testing_environment): Use SkippedTest to add
TestWebKitAccessibility to the skipped list.
(TestRunner._find_skipped_test): Return the SkippedTest object for
a given test path.
(TestRunner._test_cases_to_skip): Returns the list of test cases
that should be skipped for a given test path.
(TestRunner._should_run_test): Helper funtion to decide whether
the given test path should be run or not. Tests in the skipped
list that don't have a list of failing test cases are not run at
all. Tests in the skipped list that contain a list of test cases
are run with gtester -s to skip the individual test cases.
(TestRunner._run_test): Helper funtion to run a given test.
(TestRunner.run_tests): Build the list of tests to run based on
_should_run_test() and use helper function _run_test() to run
every test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: nuke HeapGraph.setSize(), do it automagically on update
caseq@chromium.org [Wed, 28 Mar 2012 15:36:03 +0000 (15:36 +0000)]
Web Inspector: nuke HeapGraph.setSize(), do it automagically on update
https://bugs.webkit.org/show_bug.cgi?id=82471

Reviewed by Yury Semikhatsky.

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.HeapGraph.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: dispatch console-message-added and console-messages-cleared events...
podivilov@chromium.org [Wed, 28 Mar 2012 15:20:06 +0000 (15:20 +0000)]
Web Inspector: dispatch console-message-added and console-messages-cleared events on UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=82463

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Those events are related to specific UISourceCode. See bug 82224 for more details.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.UISourceCodeImpl):
(WebInspector.UISourceCodeImpl.prototype.consoleMessages):
(WebInspector.UISourceCodeImpl.prototype.consoleMessageAdded):
(WebInspector.UISourceCodeImpl.prototype.consoleMessagesCleared):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageAdded):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessagesCleared):
(WebInspector.JavaScriptSourceFrame.prototype._onTextViewerContentLoaded):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.breakpoints):
(WebInspector.UISourceCode.prototype.consoleMessages):

LayoutTests:

* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Implement PlatformStrategies
carlosgc@webkit.org [Wed, 28 Mar 2012 15:13:51 +0000 (15:13 +0000)]
[GTK] Implement PlatformStrategies
https://bugs.webkit.org/show_bug.cgi?id=82454

Reviewed by Xan Lopez.

Source/WebCore:

* GNUmakefile.list.am: Remove PluginDataGtk.cpp. The same
functionality is now implemented using platform strategies.
* plugins/gtk/PluginDataGtk.cpp: Removed.

Source/WebKit/gtk:

* GNUmakefile.am: Add new files to compilation.
* WebCoreSupport/PlatformStrategiesGtk.cpp: Added.
(PlatformStrategiesGtk::initialize): Initialize platform
strategies.
(PlatformStrategiesGtk::PlatformStrategiesGtk):
(PlatformStrategiesGtk::createCookiesStrategy): Return this.
(PlatformStrategiesGtk::createPluginStrategy): Ditto.
(PlatformStrategiesGtk::createVisitedLinkStrategy): Ditto.
(PlatformStrategiesGtk::createPasteboardStrategy): Return 0, since
PasteboardStrategy is only used by mac code for now.
(PlatformStrategiesGtk::notifyCookiesChanged):
(PlatformStrategiesGtk::refreshPlugins): Refresh the plugin
database.
(PlatformStrategiesGtk::getPluginInfo): Initialize plugins and
populate the given vector with plugins information.
(PlatformStrategiesGtk::isLinkVisited): Return whether the given
hash is a visited link of the page group.
(PlatformStrategiesGtk::addVisitedLink): Add the given hash to the
page group visited links.
* WebCoreSupport/PlatformStrategiesGtk.h: Added.
* webkit/webkitglobals.cpp:
(webkitInit): Initialize PlatformStrategiesGtk.

Source/WTF:

* wtf/Platform.h: Define WTF_USE_PLATFORM_STRATEGIES for GTK+
platform too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Regression] TabIndex is not correctly restored after editing.
vsevik@chromium.org [Wed, 28 Mar 2012 15:07:04 +0000 (15:07 +0000)]
Web Inspector: [Regression] TabIndex is not correctly restored after editing.
https://bugs.webkit.org/show_bug.cgi?id=82464

Reviewed by Pavel Feldman.

This fixes incorrect usage of isNaN that returns false for null value.
Drive-by javascript compilation fix.

* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.addScript): compilation fix.
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeChanged): compilation fix.
* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript): compilation fix.
* inspector/front-end/UIUtils.js:
(WebInspector.startEditing.cleanUpAfterEditing): incorrect usage of isNaN fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAn extra line break is inserted when pasting into a font element.
yi.4.shen@nokia.com [Wed, 28 Mar 2012 15:00:42 +0000 (15:00 +0000)]
An extra line break is inserted when pasting into a font element.
https://bugs.webkit.org/show_bug.cgi?id=71207

Reviewed by Ryosuke Niwa.

Fix an editing bug where inserting text into a font element would
create an extra div element in the dom tree. The
WebCore::positionAvoidingPrecedingNodes() tries to set the correct
destination position by checking the next visible position, however,
it causes the position moves into the child element in somecase.
Instead, we should only check the position in parent after node.

Source/WebCore:

Test: editing/inserting/insert-text-into-font.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::positionAvoidingPrecedingNodes):

LayoutTests:

* editing/inserting/insert-text-into-font-expected.txt: Added.
* editing/inserting/insert-text-into-font.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Regions] Add region styling tests for interaction between region styling and...
commit-queue@webkit.org [Wed, 28 Mar 2012 14:56:51 +0000 (14:56 +0000)]
[CSS Regions] Add region styling tests for interaction between region styling and scoped styles
https://bugs.webkit.org/show_bug.cgi?id=82340

Patch by Mihai Balan <mibalan@adobe.com> on 2012-03-28
Reviewed by Antti Koivisto.

Adding tests for style interaction between region styling snd scoped style elements. Currently skipped,
since scoped style elements are not enabled by default.

* fast/regions/style-scoped-in-flow-expected.html: Added.
* fast/regions/style-scoped-in-flow-override-container-style-expected.html: Added.
* fast/regions/style-scoped-in-flow-override-container-style.html: Added.
* fast/regions/style-scoped-in-flow-override-region-styling-expected.html: Added.
* fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html: Added.
* fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions.html: Added.
* fast/regions/style-scoped-in-flow-override-region-styling.html: Added.
* fast/regions/style-scoped-in-flow.html: Added.
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared...
ossy@webkit.org [Wed, 28 Mar 2012 14:54:03 +0000 (14:54 +0000)]
[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

Reviewed by Simon Hausmann.

Use SSE2 floating point math on 32 bit instead of the default
387 to make layout test result same on 32 and on 64 bit builds.

* qmake/mkspecs/features/unix/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Soup] DNS prefetching spams resolver, shoots self in the foot
sergio@webkit.org [Wed, 28 Mar 2012 14:45:45 +0000 (14:45 +0000)]
[Soup] DNS prefetching spams resolver, shoots self in the foot
https://bugs.webkit.org/show_bug.cgi?id=41630

Reviewed by Martin Robinson.

.:

Bump libsoup and glib dependencies.

* Source/cmake/OptionsEfl.cmake:
* configure.ac:

Source/WebCore:

Added generic DNSResolveQueue class to throttle DNS
prefetches. It's an abstract refactoring of CFNET's
DNSResolveQueue. Platform specific methods implemented for soup
and CFNET backends.

No new tests required as we're just refactoring existing code to
be used by two different ports.

* CMakeLists.txt: added new file.
* GNUmakefile.list.am: ditto.
* WebCore.vcproj/WebCore.vcproj: ditto.
* WebCore.xcodeproj/project.pbxproj: ditto.
* platform/network/DNSResolveQueue.cpp: Added.
(WebCore):
(WebCore::DNSResolveQueue::add): adds a new host to be prefetched.
(WebCore::DNSResolveQueue::fired): by using a delay we coalesce
several prefetch requests and try to resolve them all here.
* platform/network/DNSResolveQueue.h: Added.
(WebCore):
(DNSResolveQueue): class that implements DNS prefetch
throttling using a template pattern.
(WebCore::DNSResolveQueue::shared):
(WebCore::DNSResolveQueue::decrementRequestCount):
* platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::DNSResolveQueue::platformResolve):
* platform/network/soup/DNSSoup.cpp:
(WebCore):
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::resolvedCallback):
(WebCore::DNSResolveQueue::platformResolve):
(WebCore::prefetchDNS):

Tools:

Bump libsoup and glib dependencies.

* efl/jhbuild.modules:
* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowindow.scrollBy() scrolls incorrectly when zoomed in/out
commit-queue@webkit.org [Wed, 28 Mar 2012 14:37:56 +0000 (14:37 +0000)]
window.scrollBy() scrolls incorrectly when zoomed in/out
https://bugs.webkit.org/show_bug.cgi?id=45228

Patch by Eugene Girard <girard@chromium.org> on 2012-03-28
Reviewed by Simon Fraser.

scrollBy now uses layout (not CSS) units. (As scrollTo does.)

Source/WebCore:

Test: fast/dom/zoom-scroll-page-test.html

* page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollBy):

LayoutTests:

* fast/dom/zoom-scroll-page-test-expected.txt: Added.
* fast/dom/zoom-scroll-page-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNull dereference in SVGTextElement::animatedLocalTransform()
schenney@chromium.org [Wed, 28 Mar 2012 14:28:02 +0000 (14:28 +0000)]
Null dereference in SVGTextElement::animatedLocalTransform()
https://bugs.webkit.org/show_bug.cgi?id=82375

Reviewed by Nikolas Zimmermann.

Source/WebCore:

A poorly structured SVG file with a text element inside an
animatedTransform element leaves the text element placed outside of
the SVG root and it has no renderer(). Later attempts to use the
renderer in animatedLocalTransform fail.

Test: svg/custom/get-text-element-transform-crash.html

* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::animatedLocalTransform): Added a check for null renderer, and do not check
for style transform if there is no renderer.

LayoutTests:

* svg/custom/get-text-element-transform-crash-expected.txt: Added.
* svg/custom/get-text-element-transform-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Respect NOCONFIGURE option in autogen.sh
xan@webkit.org [Wed, 28 Mar 2012 14:19:14 +0000 (14:19 +0000)]
[GTK] Respect NOCONFIGURE option in autogen.sh
https://bugs.webkit.org/show_bug.cgi?id=82447

Reviewed by Philippe Normand.

Make autogen.sh follow the new build-api for GNOME, see
http://people.gnome.org/~walters/docs/build-api.txt

* autogen.sh: respect the NOCONFIGURE environment flag, per the
new GNOME build-api.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Disable introspection for jhbuild modules
kov@webkit.org [Wed, 28 Mar 2012 14:11:49 +0000 (14:11 +0000)]
[GTK] Disable introspection for jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=82395

Reviewed by Philippe Normand.

* efl/jhbuild.modules: add --disable-introspection to all modules
that support it
* gtk/jhbuild.modules: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable animVal support for SVGAnimatedPreserveAspectRatio
zimmermann@webkit.org [Wed, 28 Mar 2012 13:14:20 +0000 (13:14 +0000)]
Enable animVal support for SVGAnimatedPreserveAspectRatio
https://bugs.webkit.org/show_bug.cgi?id=82326

Reviewed by Zoltan Herczeg.

Source/WebCore:

Enable animVal support for SVGAnimatedPreserveAspectRatio. Very simple now that everything is prepared.
All we have to do is add startAnimValAnimation/etc. methods to SVGAnimatedPreserveAspectRatioAnimator.

Modernize SVGPreserveAspectRatio, align parsing this object from String, with the other SVG DOM primitives,
who supply a "void parse(const String&)" method, for this task.

Extended existing tests to cover this.

* svg/SVGAnimatedPreserveAspectRatio.cpp:
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::constructFromString):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::animValWillChange):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::animValDidChange):
* svg/SVGAnimatedPreserveAspectRatio.h:
(SVGAnimatedPreserveAspectRatioAnimator):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::parseAttribute):
* svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseAttribute):
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::parseAttribute):
* svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::parse):
(WebCore):
* svg/SVGPreserveAspectRatio.h:
(SVGPreserveAspectRatio):
* svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::setPreserveAspectRatioString):
(WebCore::SVGViewSpec::parseViewSpec):

LayoutTests:

Extend SVGAnimatedPreserveAspectRatio tests to cover animVal support.

* svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js:
(sample1):
(sample2):
(sample3):
* svg/animations/svgPreserveAspectRatio-animation-1-expected.txt:
* svg/dom/preserve-aspect-ratio-parser-expected.txt:
* svg/dom/preserve-aspect-ratio-parser.html: Parsing errors now yield to 'unknown' pAR values, as desired.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [v8] inspection of CanvasPixelArray is slow.
pfeldman@chromium.org [Wed, 28 Mar 2012 13:05:59 +0000 (13:05 +0000)]
Web Inspector: [v8] inspection of CanvasPixelArray is slow.
https://bugs.webkit.org/show_bug.cgi?id=82455

Reviewed by Vsevolod Vlasov.

Added CanvasPixelArray to the list of classes that we consider
arrays.

* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::typeCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSelectively retrieve text content around a given position.
leandrogracia@chromium.org [Wed, 28 Mar 2012 13:02:55 +0000 (13:02 +0000)]
Selectively retrieve text content around a given position.
https://bugs.webkit.org/show_bug.cgi?id=78361

Reviewed by Ryosuke Niwa.

Tests: a new layout test will be introduced once the required WebKit API code is ready.

Introduce the DOMTextContentWalker class to selectively retrieve content
around a given VisiblePosition into a string in such a way that a text
Range can be extracted later from a pair of the string's positions.

A new boolean called m_shouldStop is also introduced in the TextIterator to force
it advancing under certain conditions. Although this is usually done by setting
m_positionNode to zero, it can't be applied in this case since by doing so the
iterator's range is lost.

* WebCore.gypi:
* editing/SurroundingText.cpp: Added.
(WebCore):
(WebCore::SurroundingText::SurroundingText):
(WebCore::SurroundingText::rangeFromContentOffsets):
(WebCore::SurroundingText::content):
(WebCore::SurroundingText::positionOffsetInContent):
* editing/SurroundingText.h: Added.
(WebCore):
(SurroundingText):
* editing/TextIterator.cpp:
(WebCore::TextIterator::TextIterator):
(WebCore::TextIterator::advance):
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::advance):
* editing/TextIterator.h:
(WebCore::TextIterator::atEnd):
(TextIterator):
(WebCore::SimplifiedBackwardsTextIterator::atEnd):
(SimplifiedBackwardsTextIterator):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::enclosingFormControlElement):
(WebCore):
* html/HTMLFormControlElement.h:
(HTMLFormControlElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed, fix API tests after adding full platforms. (r111658)
ossy@webkit.org [Wed, 28 Mar 2012 13:02:08 +0000 (13:02 +0000)]
[Qt] Unreviewed, fix API tests after adding full platforms. (r111658)

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(BuildAndTestFactory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeed up updates of existing CSS properties from JS.
alexis.menard@openbossa.org [Wed, 28 Mar 2012 12:40:31 +0000 (12:40 +0000)]
Speed up updates of existing CSS properties from JS.
https://bugs.webkit.org/show_bug.cgi?id=82235

Reviewed by Andreas Kling.

Source/WebCore:

Improve the way we handle updating an existing CSS property by replacing its value
by the new one rather than removing the old value and then adding the new one. This
speed up by 35% PerformanceTests/CSS/CSSPropertyUpdateValue.html.

No new tests : Updating existing tests that were relying on the order of the properties
after modification. Each updated property is not appended to the list of properties of the
style therefore the cssText value is slightly different. It matches Firefox behavior but not
Opera.

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::addParsedProperty):

LayoutTests:

Updated expectations after behavior change on how we handle updates of
CSS properties from JS. We match now Firefox where the cssText keeps the
order of the properties (but modify its value) whereas before we were appending
the new value at the end of the list of properties.

* editing/pasteboard/data-transfer-items-expected.txt:
* editing/pasteboard/onpaste-text-html-expected.txt:
* fast/dom/css-set-property-exception-expected.txt:
* fast/events/ondrop-text-html-expected.txt:
* fast/mutation/observe-attributes-expected.txt:
* fast/mutation/observe-attributes.html:
* inspector/styles/styles-new-API-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed typo fix after r112383.
ossy@webkit.org [Wed, 28 Mar 2012 12:39:40 +0000 (12:39 +0000)]
[Qt] Unreviewed typo fix after r112383.

* Scripts/run-qtwebkit-tests:
(Main.check_crash_occurences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Use WebCore::PlatformMouseEvent::globalPosition() instead of WebCore...
leo.yang@torchmobile.com.cn [Wed, 28 Mar 2012 12:31:20 +0000 (12:31 +0000)]
[BlackBerry] Use WebCore::PlatformMouseEvent::globalPosition() instead of WebCore::PlatformMouseEvent::globalPos() in WebPage.cpp
https://bugs.webkit.org/show_bug.cgi?id=82420

Reviewed by Rob Buis.

In PlatformMouseEvent.h the blackberry porting added globalPos() (but not upstreamed yet)
for PlatformMouseEvent, but this method is same as globalPosition() that is available for
every porting. We should use globalPosition().

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::updateCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Remove PlatformMouseEvent::setClickCount for BlackBerry
leo.yang@torchmobile.com.cn [Wed, 28 Mar 2012 12:26:03 +0000 (12:26 +0000)]
[BlackBerry] Remove PlatformMouseEvent::setClickCount for BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=82422

Reviewed by Rob Buis.

PlatformMouseEvent::setClickCount() is never used by BlackBerry.
The declaration was added in PlatformMouseEvent.h internally for
BlackBerry porting, but it has not been upstreamed yet.

* platform/blackberry/PlatformMouseEventBlackBerry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112384 268f45cc-cd09-0410-ab3c-d52691b4dbfc