WebKit-https.git
5 months agoFix testbmalloc build
commit-queue@webkit.org [Wed, 13 Mar 2019 18:09:00 +0000 (18:09 +0000)]
Fix testbmalloc build
https://bugs.webkit.org/show_bug.cgi?id=195660

Patch by Sam Weinig <sam@webkit.org> on 2019-03-13
Reviewed by Geoffrey Garen.

* bmalloc.xcodeproj/project.pbxproj:
Link Foundation in when building testbmalloc. Since bmalloc requires Foundation, and is a static
library, all clients of bmalloc are required to link it themselves.

* bmalloc/IsoPageInlines.h:
* bmalloc/StdLibExtras.h: Added.
(bmalloc::bitwise_cast):
Add bitwise_cast implementation, and use it in IsoPageInlines.h. It is a layering violation
to expect the one from WTF to be available, as seems to have been the case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoTake UnboundedNetworking assertion when a file upload is in progress.
beidson@apple.com [Wed, 13 Mar 2019 17:57:57 +0000 (17:57 +0000)]
Take UnboundedNetworking assertion when a file upload is in progress.
https://bugs.webkit.org/show_bug.cgi?id=195497

Reviewed by Geoff Garen.

Source/WebCore:

* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::hasUpload const):
* platform/network/ResourceRequestBase.h:

Source/WebKit:

This patch implements whole bunch of bookkeeping in both the Networking and UI processes.

The TLDR of that bookkeeping is:
- Whenever any uploads are in progress, take an assertion for both Networking and UI processes.
- Whenever a particular WebProcess has an upload in progress, take an assertion for it.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::setProcessIdentifier):
(WebKit::NetworkConnectionToWebProcess::setConnectionHasUploads):
(WebKit::NetworkConnectionToWebProcess::clearConnectionHasUploads):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:

* NetworkProcess/NetworkResourceLoadMap.cpp: Added.
(WebKit::NetworkResourceLoadMap::add):
(WebKit::NetworkResourceLoadMap::remove):
(WebKit::NetworkResourceLoadMap::get const):
* NetworkProcess/NetworkResourceLoadMap.h: Added.
(WebKit::NetworkResourceLoadMap::NetworkResourceLoadMap):
(WebKit::NetworkResourceLoadMap::isEmpty const):
(WebKit::NetworkResourceLoadMap::contains const):
(WebKit::NetworkResourceLoadMap::begin):
(WebKit::NetworkResourceLoadMap::values):

* NetworkProcess/NetworkSession.cpp:

       * Scripts/webkit/messages.py:

* Sources.txt:

* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::takeUploadAssertion):
(WebKit::NetworkProcessProxy::clearUploadAssertion):
* UIProcess/Network/NetworkProcessProxy.h:

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setWebProcessHasUploads):
(WebKit::WebProcessPool::clearWebProcessHasUploads):
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessPool.messages.in:

       * WebKit.xcodeproj/project.pbxproj:

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureNetworkProcessConnection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoVersioning.
kocsen_chung@apple.com [Wed, 13 Mar 2019 17:53:24 +0000 (17:53 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoUse new RegistrableDomain type in PSON code
cdumez@apple.com [Wed, 13 Mar 2019 17:48:47 +0000 (17:48 +0000)]
Use new RegistrableDomain type in PSON code
https://bugs.webkit.org/show_bug.cgi?id=195634

Reviewed by Youenn Fablet.

Use new RegistrableDomain type in PSON code instead of more error-prone String type.

* UIProcess/SuspendedPageProxy.cpp:
(WebKit::SuspendedPageProxy::SuspendedPageProxy):
* UIProcess/SuspendedPageProxy.h:
* UIProcess/WebProcessCache.cpp:
(WebKit::WebProcessCache::canCacheProcess const):
(WebKit::WebProcessCache::addProcessIfPossible):
(WebKit::WebProcessCache::takeProcess):
(WebKit::WebProcessCache::clearAllProcessesForSession):
* UIProcess/WebProcessCache.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::addProcessToOriginCacheSet):
(WebKit::WebProcessPool::removeProcessFromOriginCacheSet):
(WebKit::WebProcessPool::processForNavigationInternal):
(WebKit::WebProcessPool::findReusableSuspendedPageProcess):
(WebKit::WebProcessPool::didCollectPrewarmInformation):
(WebKit::WebProcessPool::tryPrewarmWithDomainInformation):
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::canBeAddedToWebProcessCache const):
(WebKit::WebProcessProxy::maybeShutDown):
(WebKit::WebProcessProxy::didCollectPrewarmInformation):
(WebKit::WebProcessProxy::didStartProvisionalLoadForMainFrame):
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::registrableDomain const):
* UIProcess/WebProcessProxy.messages.in:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::sendPrewarmInformation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agohttp/tests/websocket/tests/hybi/handshake-ok-with-legacy-sec-websocket-response-heade...
sroberts@apple.com [Wed, 13 Mar 2019 17:25:23 +0000 (17:25 +0000)]
http/tests/websocket/tests/hybi/handshake-ok-with-legacy-sec-websocket-response-headers.html is a flaky failure on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=173041

Unreviewed test gardening.

* platform/mac/TestExpectations: Marking as flaky until a fix lands

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoEnable libwebrtc logging control through WebCore
youenn@apple.com [Wed, 13 Mar 2019 17:14:18 +0000 (17:14 +0000)]
Enable libwebrtc logging control through WebCore
https://bugs.webkit.org/show_bug.cgi?id=195658

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

Add a callback to get access to libwebrtc log messages.

* Configurations/libwebrtc.iOS.exp:
* Configurations/libwebrtc.iOSsim.exp:
* Configurations/libwebrtc.mac.exp:
* Source/webrtc/rtc_base/logging.cc:
* Source/webrtc/rtc_base/logging.h:

Source/WebCore:

Add support for WebCore logging of libwebrtc messages.
This is controlled by WebRTC log channel state and level.
In case of private browsing mode, any logging is disabled.
This will stay for the lifetime of the process.
No change of behavior.

* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::create):
* platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::doReleaseLogging):
(WebCore::setLogging):
(WebCore::computeLogLevel):
(WebCore::initializePeerConnectionFactoryAndThreads):
(WebCore::LibWebRTCProvider::setEnableLogging):
* platform/mediastream/libwebrtc/LibWebRTCProvider.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[ews-app] Remove unused patch view
aakash_jain@apple.com [Wed, 13 Mar 2019 17:11:27 +0000 (17:11 +0000)]
[ews-app] Remove unused patch view
https://bugs.webkit.org/show_bug.cgi?id=195669

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/urls.py:
* BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[ews-app] Use Buildbot result code variables
aakash_jain@apple.com [Wed, 13 Mar 2019 17:03:42 +0000 (17:03 +0000)]
[ews-app] Use Buildbot result code variables
https://bugs.webkit.org/show_bug.cgi?id=195668

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/ews-app/ews/common/buildbot.py:
(Buildbot): Added Buildbot result code variables.
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble): Used Buildbot result code variables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[GStreamer][WebRTC] Do not sync encoder on the clock
commit-queue@webkit.org [Wed, 13 Mar 2019 16:08:15 +0000 (16:08 +0000)]
[GStreamer][WebRTC] Do not sync encoder on the clock
https://bugs.webkit.org/show_bug.cgi?id=195673

we should encode as fast as possible and totally ignore timestamp while
doing so.

Patch by Thibault Saunier <tsaunier@igalia.com> on 2019-03-13
Reviewed by Philippe Normand.

* platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::InitEncode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[Flatpak] Expand submodule recursively
commit-queue@webkit.org [Wed, 13 Mar 2019 15:33:01 +0000 (15:33 +0000)]
[Flatpak] Expand submodule recursively
https://bugs.webkit.org/show_bug.cgi?id=195672

Building WPE with flatpak was impossible without that as it was raising an exception.
Also update wpebackend-fdo to match what is built in jhbuild

Patch by Thibault Saunier <tsaunier@igalia.com> on 2019-03-13
Reviewed by Philippe Normand.

* flatpak/flatpakutils.py:
(expand_submodules_recurse):
(expand_manifest):
* flatpak/org.webkit.WPEModules.yaml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[GStreamer][WebRTC]: Use codec setting video height/width as fallback
commit-queue@webkit.org [Wed, 13 Mar 2019 15:28:08 +0000 (15:28 +0000)]
[GStreamer][WebRTC]: Use codec setting video height/width as fallback
https://bugs.webkit.org/show_bug.cgi?id=195675

Patch by Thibault Saunier <tsaunier@igalia.com> on 2019-03-13
Reviewed by Philippe Normand.

In some cases the frame height and width is not set (not sure why/ in
what conditions but it happens) so make sure to get the information from
the VideoCodec when configuring the encoder.

* platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:
(WebCore::GStreamerVideoDecoder::GStreamerVideoDecoder):
(WebCore::GStreamerVideoDecoder::GetCapsForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[ews-app] status bubble should be hidden for certain builds
aakash_jain@apple.com [Wed, 13 Mar 2019 11:27:08 +0000 (11:27 +0000)]
[ews-app] status bubble should be hidden for certain builds
https://bugs.webkit.org/show_bug.cgi?id=194597

Reviewed by Dewei Zhu.

* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble):
(StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
because the patch didn't have relevant changes.
(StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
in production yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[CoordinatedGraphics] Null dereference in CoordinatedGraphicsLayer::setCoordinatorInc...
magomez@igalia.com [Wed, 13 Mar 2019 08:55:01 +0000 (08:55 +0000)]
[CoordinatedGraphics] Null dereference in CoordinatedGraphicsLayer::setCoordinatorIncludingSubLayersIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=195615

Reviewed by Carlos Garcia Campos.

Exit early if we don't receive a valid coordinator.

* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setCoordinatorIncludingSubLayersIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[l10n] Updated Italian translation of WebKitGTK+
carlosgc@webkit.org [Wed, 13 Mar 2019 08:39:28 +0000 (08:39 +0000)]
[l10n] Updated Italian translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=195620

Patch by Milo Casagrande <milo@milo.name> on 2019-03-13
Rubber-stamped by Carlos Garcia Campos.

* it.po:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[Win][PlayStation] Remove WebCore::standardUserAgentForURL
Hironori.Fujii@sony.com [Wed, 13 Mar 2019 07:48:12 +0000 (07:48 +0000)]
[Win][PlayStation] Remove WebCore::standardUserAgentForURL
https://bugs.webkit.org/show_bug.cgi?id=195662

Reviewed by Ryosuke Niwa.

Source/WebCore:

WebCore::standardUserAgentForURL is just a stub in Windows port.

No new tests because there is no behavior change.

* platform/win/UserAgentWin.cpp:
(WebCore::standardUserAgentForURL): Deleted.
* platform/playstation/UserAgentPlayStation.cpp:
(WebCore::standardUserAgentForURL): Deleted.

Source/WebKit:

* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::platformUserAgent const): Return an empty string as well as mac/ios ports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[Win] Fix a slew of simple clang-cl warnings.
ross.kirsling@sony.com [Wed, 13 Mar 2019 04:24:47 +0000 (04:24 +0000)]
[Win] Fix a slew of simple clang-cl warnings.
https://bugs.webkit.org/show_bug.cgi?id=195652

Reviewed by Don Olmstead.

Source/WebCore:

* page/AutoscrollController.cpp:
(WebCore::AutoscrollController::handleMouseReleaseEvent): -Wswitch
* platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::willSetupSslCtx):
(WebCore::CurlHandle::appendRequestHeaders): -Wunused-variable
* platform/network/curl/CurlFormDataStream.cpp:
(WebCore::CurlFormDataStream::computeContentLength): -Wunused-variable
* platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::CurlRequest): -Wreorder
(WebCore::CurlRequest::setupTransfer): -Wunused-variable
* platform/network/curl/CurlSSLVerifier.cpp:
(WebCore::CurlSSLVerifier::CurlSSLVerifier):
* platform/network/curl/CurlSSLVerifier.h: -Wunused-private-field
* platform/win/LoggingWin.cpp:
(WebCore::logLevelString): -Wwritable-strings
* rendering/RenderThemeWin.cpp: -Wunused-const-variable (x2)
(WebCore::RenderThemeWin::getThemeData): -Wswitch

Source/WebCore/PAL:

* pal/win/LoggingWin.cpp:
(PAL::logLevelString): -Wwritable-strings

Source/WebKit:

* NetworkProcess/curl/NetworkDataTaskCurl.cpp:
(WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse): -Wswitch
* Platform/IPC/win/ConnectionWin.cpp:
(IPC::Connection::readEventHandler): -Wunused-variable
* Platform/win/LoggingWin.cpp:
(WebKit::logLevelString): -Wwritable-strings
* UIProcess/Launcher/win/ProcessLauncherWin.cpp:
(WebKit::ProcessLauncher::launchProcess): -Wunused-variable

Source/WebKitLegacy/win:

* Interfaces/AccessibleComparable.idl: -Wmissing-braces
* Plugins/PluginDatabaseWin.cpp: -Wunused-function
(WebCore::addJavaPluginDirectory): Deleted.
* WebCoreSupport/AcceleratedCompositingContext.cpp:
(AcceleratedCompositingContext::AcceleratedCompositingContext): -Wreorder
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorUndoCommand::WebEditorUndoCommand): -Wreorder
(undoNameForEditAction): -Wswitch
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::WebFrameLoaderClient): -Wswitch
(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): -Wunused-variable
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::WebInspectorFrontendClient): -Wreorder
* WebCoreSupport/WebInspectorClient.h: -Winconsistent-missing-override
* WebError.cpp:
(WebError::WebError): -Wreorder
* WebFrame.cpp:
(WebFrame::stringByEvaluatingJavaScriptInScriptWorld): -Wlogical-op-parentheses
* WebHistory.cpp: -Wunused-function (x5)
(areEqualOrClose): Deleted.
(addDayToSystemTime): Deleted.
(getDayBoundaries): Deleted.
(beginningOfDay): Deleted.
(dateKey): Deleted.
* WebNotificationCenter.cpp:
(WebNotificationCenter::removeObserver): -Wunused-variable
* WebView.cpp: -Wunused-function, -Wreorder
(WebView::addVisitedLinks): -Wunused-variable

Tools:

* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[JSC] OSR entry should respect abstract values in addition to flush formats
ysuzuki@apple.com [Wed, 13 Mar 2019 02:34:28 +0000 (02:34 +0000)]
[JSC] OSR entry should respect abstract values in addition to flush formats
https://bugs.webkit.org/show_bug.cgi?id=195653

Reviewed by Mark Lam.

JSTests:

* stress/osr-entry-locals-none.js: Added.

Source/JavaScriptCore:

Let's consider the following graph.

Block #0
    ...
    27:< 2:loc13> JSConstant(JS|UseAsOther, StringIdent, Strong:String (atomic) (identifier): , StructureID: 42679, bc#10, ExitValid)
    ...
    28:< 2:loc13> ArithPow(DoubleRep:@437<Double>, Int32:@27, Double|UseAsOther, BytecodeDouble, Exits, bc#10, ExitValid)
    29:<!0:->     MovHint(DoubleRep:@28<Double>, MustGen, loc7, W:SideState, ClobbersExit, bc#10, ExitValid)
    30:< 1:->     SetLocal(DoubleRep:@28<Double>, loc7(M<Double>/FlushedDouble), machine:loc6, W:Stack(-8), bc#10, exit: bc#14, ExitValid)  predicting BytecodeDouble
    ...
    73:<!0:->     Jump(MustGen, T:#1, W:SideState, bc#71, ExitValid)

Block #1 (bc#71): (OSR target) pred, #0
    ...
   102:<!2:loc15> GetLocal(Check:Untyped:@400, Double|MustGen|PureInt, BytecodeDouble, loc7(M<Double>/FlushedDouble), machine:loc6, R:Stack(-8), bc#120, ExitValid)  predicting BytecodeDouble
    ...

CFA at @28 says it is invalid since there are type contradiction (Int32:@27 v.s. StringIdent). So, of course, we do not propagate #0's type information to #1 since we become invalid state.
However, #1 is still reachable since it is an OSR target. Since #0 was only the predecessor of #1, loc7's type information becomes None at the head of #1.
Since loc7's AbstractValue is None, @102 GetLocal emits breakpoint. It is OK as long as OSR entry fails because AbstractValue validation requires the given value is None type.

The issue here is that we skipped AbstractValue validation when we have FlushFormat information. Since loc7 has FlushedDouble format, DFG OSR entry code does not validate it against AbstractValue,
which is None. Then, we hit the breakpoint emitted by @102.

This patch performs AbstractValue validation against values even if we have FlushFormat. We should correctly configure AbstractValue for OSR entry's locals too to avoid unnecessary OSR entry
failures in the future but anyway validating locals with AbstractValue is correct behavior here since DFGSpeculativeJIT relies on that.

* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoMove the code for determining the need for touch bar quirks to Quirks class
rniwa@webkit.org [Wed, 13 Mar 2019 02:31:40 +0000 (02:31 +0000)]
Move the code for determining the need for touch bar quirks to Quirks class
https://bugs.webkit.org/show_bug.cgi?id=195654

Reviewed by Brent Fulgham.

Source/WebCore:

Moved the code to determine whether the touch bar quirks are needed or not from WebKit2.

* WebCore.xcodeproj/project.pbxproj:
* page/Quirks.cpp:
(WebCore::Quirks::isTouchBarUpdateSupressedForHiddenContentEditable const):
(WebCore::Quirks::isNeverRichlyEditableForTouchBar const):
* page/Quirks.h:

Source/WebKit:

Moved the code to determine whether touch bar quirks are needed or not to WebCore.

Also renamed HiddenContentEditableQuirk to IsTouchBarUpdateSupressedForHiddenContentEditable
and PlainTextQuirk to NeverRichlyEditableForTouchBar.

* UIProcess/Cocoa/WebViewImpl.h:
(WebKit::WebViewImpl::isRichlyEditableForTouchBar): Renamed.
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::updateTouchBar):
(WebKit::WebViewImpl::candidateListTouchBarItem const):
(WebKit::WebViewImpl::isRichlyEditableForTouchBar const): Renamed from isRichlyEditable.
(WebKit::WebViewImpl::textTouchBar const):
(WebKit::WebViewImpl::updateTextTouchBar):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setIsTouchBarUpdateSupressedForHiddenContentEditable): Renamed from
setNeedsHiddenContentEditableQuirk.
(WebKit::WebPageProxy::setIsNeverRichlyEditableForTouchBar): Renamed from setNeedsPlainTextQuirk.
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::isTouchBarUpdateSupressedForHiddenContentEditable const): Renamed from
needsHiddenContentEditableQuirk.
(WebKit::WebPageProxy::isNeverRichlyEditableForTouchBar const): Renamed from needsPlainTextQuirk.
* UIProcess/WebPageProxy.messages.in: Renamed the IPC messages.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::needsHiddenContentEditableQuirk): Deleted. Moved to WebCore.
(WebKit::needsPlainTextQuirk): Deleted. Moved to WebCore.
(WebKit::WebPage::didStartPageTransition):
(WebKit::WebPage::didChangeSelection):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
justin_fan@apple.com [Wed, 13 Mar 2019 01:33:11 +0000 (01:33 +0000)]
[Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
https://bugs.webkit.org/show_bug.cgi?id=195518
<rdar://problem/46322356>

Reviewed by Myles C. Maxfield.

Source/WebCore:

Upgrade the implementation of GPURenderPipelineDescriptor and GPURenderPipeline and match the updated Web GPU API.
Add stubs for GPUColorStateDescriptor so attachment format can be provided by GPURenderPipelineDescriptor.

All affected Web GPU tests updated to cover existing behavior.

Update file names and symbols:
* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h:

Updates to GPURenderPipeline, GPURenderPipelineDescriptor, and its components:
* Modules/webgpu/GPUColorStateDescriptor.idl: Added. Provide the expected texture format of the render pipeline's color attachments.
* Modules/webgpu/GPUInputStateDescriptor.idl: Renamed from Source/WebCore/Modules/webgpu/WebGPUInputStateDescriptor.idl.
* Modules/webgpu/GPUTextureFormat.idl: Update the existing values to match the new style.
* Modules/webgpu/GPUVertexAttributeDescriptor.idl: Renamed from Source/WebCore/Modules/webgpu/WebGPUVertexAttributeDescriptor.idl.
* Modules/webgpu/GPUVertexInputDescriptor.idl: Renamed from Source/WebCore/Modules/webgpu/WebGPUVertexInputDescriptor.idl.
* Modules/webgpu/WebGPUDevice.cpp:
(WebCore::WebGPUDevice::createPipelineLayout const): Remove unnecessary comment.
(WebCore::WebGPUDevice::createRenderPipeline const): Descriptor validation and conversion moved into WebGPURenderPipelineDescriptor.
(WebCore::validateAndConvertPipelineStage): Deleted.
* Modules/webgpu/WebGPUDevice.h: create* functions should not return nullable.
* Modules/webgpu/WebGPUIndexFormat.h: Removed. Moved into GPUInputStateDescriptor.idl.
* Modules/webgpu/WebGPUInputStateDescriptor.h: Removed.
* Modules/webgpu/WebGPUInputStepMode.idl: Removed. Moved into GPUVertexInputDescriptor.idl.
* Modules/webgpu/WebGPUPipelineLayout.h:
(WebCore::WebGPUPipelineLayout::pipelineLayout): Getters should return raw references.
* Modules/webgpu/WebGPUPipelineStageDescriptor.h: Now shares a common base with GPUPipelineStageDescriptor.
* Modules/webgpu/WebGPURenderPipeline.cpp:
(WebCore::WebGPURenderPipeline::create):
(WebCore::WebGPURenderPipeline::WebGPURenderPipeline):
* Modules/webgpu/WebGPURenderPipeline.h:  Now internally nullable.
(WebCore::WebGPURenderPipeline::renderPipeline const):
(WebCore::WebGPURenderPipeline::renderPipeline): Deleted.
* Modules/webgpu/WebGPURenderPipelineDescriptor.cpp:
(WebCore::WebGPUPipelineStageDescriptor::asGPUPipelineStageDescriptor const): Validate and convert a WebGPUPipelineStageDescriptor to GPU version.
(WebCore::WebGPURenderPipelineDescriptor::asGPURenderPipelineDescriptor const): Ditto for WebGPURenderPipelineDescriptor.
* Modules/webgpu/WebGPURenderPipelineDescriptor.h: Now shares a base class and some instance variables with GPURenderPipelineDescriptor.
* Modules/webgpu/WebGPURenderPipelineDescriptor.idl: Update GPUPrimitiveTopology for new style and add colorStates.
* Modules/webgpu/WebGPUShaderModule.idl: Small pilot to test using InterfaceName to easily rename DOM-facing interfaces.
* Modules/webgpu/WebGPUVertexAttributeDescriptor.h: Removed.
* Modules/webgpu/WebGPUVertexFormat.idl: Removed. Moved and updated in GPUVertexAttributeDescriptor.idl.
* Modules/webgpu/WebGPUVertexInputDescriptor.h: Removed.
* platform/graphics/gpu/GPUInputStateDescriptor.h:
* platform/graphics/gpu/GPUPipelineStageDescriptor.h:
(WebCore::GPUPipelineStageDescriptor::GPUPipelineStageDescriptor):
* platform/graphics/gpu/GPURenderPipelineDescriptor.h: Add shared base class for Web/GPURenderPipelineDescriptor.
(WebCore::GPURenderPipelineDescriptor::GPURenderPipelineDescriptor):
* platform/graphics/gpu/GPUTextureFormat.h:
* platform/graphics/gpu/GPUVertexAttributeDescriptor.h:
* platform/graphics/gpu/GPUVertexInputDescriptor.h:
* platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:
(WebCore::setFunctionsForPipelineDescriptor): Make fragment required since descriptor validation fails if fragment function is not found right now.
(WebCore::mtlVertexFormatForGPUVertexFormat): Renamed from validateAndConvertVertexFormatToMTLVertexFormat.
(WebCore::mtlStepFunctionForGPUInputStepMode): Renamed from validateAndConvertStepModeToMTLStepFunction
(WebCore::trySetInputStateForPipelineDescriptor):
(WebCore::trySetColorStatesForColorAttachmentArray):
(WebCore::tryCreateMtlRenderPipelineState):
(WebCore::GPURenderPipeline::create):
(WebCore::validateAndConvertVertexFormatToMTLVertexFormat): Deleted.
(WebCore::validateAndConvertStepModeToMTLStepFunction): Deleted.
* platform/graphics/gpu/cocoa/GPUUtilsMetal.mm:
(WebCore::platformTextureFormatForGPUTextureFormat):
* platform/graphics/gpu/GPUColorStateDescriptor.h: Added.

Misc:
* Modules/webgpu/WebGPUProgrammablePassEncoder.cpp:
(WebCore::WebGPUProgrammablePassEncoder::setPipeline):
* Modules/webgpu/WebGPUProgrammablePassEncoder.h:
* platform/graphics/gpu/GPUProgrammablePassEncoder.h:
* platform/graphics/gpu/GPURenderPassEncoder.h:
* platform/graphics/gpu/GPURenderPipeline.h:
(WebCore::GPURenderPipeline::primitiveTopology const):
* platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:
(WebCore::GPURenderPassEncoder::setPipeline):
(WebCore::primitiveTypeForGPUPrimitiveTopology):

Tools:

* DumpRenderTree/DerivedSources-input.xcfilelist:
* DumpRenderTree/DerivedSources-output.xcfilelist:

LayoutTests:

Update all tests with new enum styles and re-namings, and specify the format of the color attachment.

* webgpu/blit-commands.html:
* webgpu/buffer-command-buffer-races.html:
* webgpu/buffer-resource-triangles.html:
* webgpu/depth-enabled-triangle-strip.html:
* webgpu/js/webgpu-functions.js:
(createBasicSwapChain):
(createBasicDepthTexture):
* webgpu/render-pipelines-expected.txt:
* webgpu/render-pipelines.html: Remove error cases, as createRenderPipeline no longer returns a null value on failure.
* webgpu/shader-modules.html:
* webgpu/texture-triangle-strip.html:
* webgpu/textures-textureviews.html:
* webgpu/vertex-buffer-triangle-strip.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoREGRESSION (iOS 12.2): Webpage using CoffeeScript crashes
msaboff@apple.com [Wed, 13 Mar 2019 01:26:29 +0000 (01:26 +0000)]
REGRESSION (iOS 12.2): Webpage using CoffeeScript crashes
https://bugs.webkit.org/show_bug.cgi?id=195613

Reviewed by Mark Lam.

JSTests:

New regression test.

* stress/regexp-backref-inbounds.js: Added.
(testRegExp):

Source/JavaScriptCore:

The bug here is in Yarr JIT backreference matching code.  We are incorrectly
using a checkedOffset / inputPosition correction when checking for the available
length left in a string.  It is improper to do these corrections as a backreference's
match length is based on what was matched in the referenced capture group and not
part of the checkedOffset and inputPosition computed when we compiled the RegExp.
In some cases, the resulting incorrect calculation would allow us to go past
the subject string's length.  Removed these adjustments.

After writing tests for the first bug, found another bug where the non-greedy
backreference backtracking code didn't do an "are we at the end of the input?" check.
This caused an infinite loop as we'd jump from the backtracking code back to
try matching one more backreference, fail and then backtrack.

* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generateBackReference):
(JSC::Yarr::YarrGenerator::backtrackBackReference):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoAdd WebFrameProxy::loadData
jiewen_tan@apple.com [Wed, 13 Mar 2019 00:36:02 +0000 (00:36 +0000)]
Add WebFrameProxy::loadData
https://bugs.webkit.org/show_bug.cgi?id=195647
<rdar://problem/48826856>

Reviewed by Youenn Fablet.

This patch adds WebFrameProxy::loadData which is a simplified version of WebPageProxy::loadData that
loads substitute data to an iframe. This is needed by the Load Optimizer.

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::loadData):
* UIProcess/WebFrameProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadDataInFrame):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoRemove a site specific hack for AppleConnect plugin
rniwa@webkit.org [Wed, 13 Mar 2019 00:15:52 +0000 (00:15 +0000)]
Remove a site specific hack for AppleConnect plugin
https://bugs.webkit.org/show_bug.cgi?id=195643

Reviewed by Simon Fraser.

r66437 added a workaround for AppleConnect plugin.

Remove this code since Safari doesn't even use WebKitLegacy anymore,
and other WebKit clients support AppleConnect plugins.

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[ContentChangeObserver] Reset state when touchStart does not turn into click.
zalan@apple.com [Wed, 13 Mar 2019 00:12:15 +0000 (00:12 +0000)]
[ContentChangeObserver] Reset state when touchStart does not turn into click.
https://bugs.webkit.org/show_bug.cgi?id=195603
<rdar://problem/48796582>

Reviewed by Simon Fraser.

Add reset() function to assert and reset the current state.

* page/ios/ContentChangeObserver.cpp:
(WebCore::ContentChangeObserver::willNotProceedWithClick):
(WebCore::ContentChangeObserver::adjustObservedState):
* page/ios/ContentChangeObserver.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[iOS] Input view sometimes flickers when blurring and refocusing an element
wenson_hsieh@apple.com [Tue, 12 Mar 2019 23:51:57 +0000 (23:51 +0000)]
[iOS] Input view sometimes flickers when blurring and refocusing an element
https://bugs.webkit.org/show_bug.cgi?id=195639
<rdar://problem/48735337>

Reviewed by Tim Horton.

Source/WebKit:

On iOS, if a focused element is blurred and immediately refocused in the scope of user interaction, we will end
up reloading interaction state (input views, autocorrection contexts, etc.) in the UI process. On certain well-
trafficked websites, this results in the input view and input accessory view flickering (or more egregiously,
scrolling to re-reveal the focused element) when changing selection.

To fix the issue, this patch refactors some focus management logic to suppress sending focused element updates
to the UI process in the case where the same element is being blurred and immediately refocused. To do this, we
track the most recently blurred element and bail when the recently blurred element is identical to the newly
focused element. See below for more detail.

Test: fast/forms/ios/keyboard-stability-when-refocusing-element.html

* UIProcess/WebPageProxy.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
(-[WKContentView _elementDidBlur]):

Update the web process' notion of whether an input view is showing. Importantly, this accounts for decisions
made by _WKUIDelegate. See below for more details.

(isAssistableInputType): Deleted.

Removed this helper function; this was only used in one place as a sanity check that the focused element's type
is not none, right before attempting to show an input view. Instead, we can just check the focused element's
type directly against InputType::None in the if statement of the early return.

* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::setIsShowingInputViewForFocusedElement):

Add a hook to notify the web process when an input view is showing or not (see below for more detail).

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didStartPageTransition):
(WebKit::WebPage::elementDidRefocus):
(WebKit::WebPage::shouldDispatchUpdateAfterFocusingElement const):

Add a helper to determine whether we notify the UI process about a newly focused element. On macOS, this is true
only when the new focused element is neither the currently focused element, nor the focused element that was
just blurred. On iOS, we have an additional constraint that when the input view is not showing, we still need to
notify the UI process, since the UI process might want to begin showing the keyboard for an element that has
only been programmatically focused, for which we aren't currently showing the input view.

(WebKit::WebPage::elementDidFocus):
(WebKit::WebPage::elementDidBlur):

Replace a couple of existing member variables in WebPage used for focus management:
-   Replace m_hasPendingBlurNotification with m_recentlyBlurredElement, a RefPtr to the Element that is being
    blurred. Behavior here is the same as before (i.e. having a pending blur notification is equivalent to
    having recently blurred a focused element). However, this allows us to check newly focused elements against
    the recently blurred element in WebPage::elementDidFocus().
-   Replace m_isFocusingElementDueToUserInteraction with m_isShowingInputViewForFocusedElement. The flag
    m_isFocusingElementDueToUserInteraction was originally added to fix <webkit.org/b/146735>, by ensuring that
    we don't send redundant ElementDidFocus (formerly, StartAssistingNode) messages to the UI process even when
    the keyboard is already up. In these simpler times, user interaction when focusing an element was equivalent
    to showing an input view for the focused element. However, in today's world, there are a variety of reasons
    why we might or might not show an input view for a given element (including, but not limited to activity
    state changes and decisions made by _WKInputDelegate). As such, it doesn't make sense to continue relying on
    m_isFocusingElementDueToUserInteraction in this early return. Instead, have the UI process propagate a
    message back to the web process, to let it know whether there is a keyboard showing, and use this flag
    instead.

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::setIsShowingInputViewForFocusedElement):

LayoutTests:

Add a test to ensure that the form control interaction doesn't stop and start again when blurring and focusing
an editable element.

* fast/forms/ios/keyboard-stability-when-refocusing-element-expected.txt: Added.
* fast/forms/ios/keyboard-stability-when-refocusing-element.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoUnreviewed, rolling out r242825.
commit-queue@webkit.org [Tue, 12 Mar 2019 22:49:34 +0000 (22:49 +0000)]
Unreviewed, rolling out r242825.
https://bugs.webkit.org/show_bug.cgi?id=195648

"Broke webkitpy tests with my change to
lldb_dump_class_layout.py" (Requested by rmorisset on
#webkit).

Reverted changeset:

"Alter Tools/Scripts/dump-class-layout to be able to dump all
classes with suspicious padding"
https://bugs.webkit.org/show_bug.cgi?id=195573
https://trac.webkit.org/changeset/242825

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoExpose document attributes and body background color through HTMLConverter.
timothy@apple.com [Tue, 12 Mar 2019 22:42:49 +0000 (22:42 +0000)]
Expose document attributes and body background color through HTMLConverter.
https://bugs.webkit.org/show_bug.cgi?id=195636
rdar://problem/45055697

Reviewed by Tim Horton.

Source/WebCore:

* editing/cocoa/HTMLConverter.h:
* editing/cocoa/HTMLConverter.mm:
(HTMLConverter::convert):
(WebCore::attributedStringFromRange):
(WebCore::attributedStringFromSelection):
(WebCore::attributedStringBetweenStartAndEnd):

Source/WebCore/PAL:

* pal/spi/cocoa/NSAttributedStringSPI.h:
(NSBackgroundColorDocumentAttribute): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoCompositing layer that renders two positioned elements should not hit test
antti@apple.com [Tue, 12 Mar 2019 22:35:36 +0000 (22:35 +0000)]
Compositing layer that renders two positioned elements should not hit test
https://bugs.webkit.org/show_bug.cgi?id=195371
<rdar://problem/48649586>

Reviewed by Simon Fraser.

Followup to fix the test case (fast/scrolling/ios/overflow-scroll-overlap-2.html)

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setEventRegion):

Revert a last minute change (that was done to fix a Mac displaylist test).

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):

Compute the region on iOS only for now (it is not used on other platforms).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoWeb Inspector: Sources: allow image collections to be filtered by type
drousso@apple.com [Tue, 12 Mar 2019 21:47:38 +0000 (21:47 +0000)]
Web Inspector: Sources: allow image collections to be filtered by type
https://bugs.webkit.org/show_bug.cgi?id=195630

Reviewed by Matt Baker.

* UserInterface/Views/ResourceCollectionContentView.js:
(WI.ResourceCollectionContentView):
(WI.ResourceCollectionContentView.prototype.get navigationItems): Added.
(WI.ResourceCollectionContentView.prototype.contentViewAdded):
(WI.ResourceCollectionContentView.prototype.contentViewRemoved): Added.
(WI.ResourceCollectionContentView.prototype._updateImageTypeScopeBar): Added.
(WI.ResourceCollectionContentView.prototype._handleImageTypeSelectionChanged): Added.
* UserInterface/Views/ResourceCollectionContentView.css: Asdded.
(.resource-collection-image-type-scope-bar.default-item-selected):

* UserInterface/Views/CollectionContentView.css:
(.content-view.collection > .content-view[hidden]): Added.

* UserInterface/Views/ScopeBarItem.js:
(WI.ScopeBarItem.prototype.set hidden):
* UserInterface/Views/MultipleScopeBarItem.js:
(WI.MultipleScopeBarItem.prototype.set scopeBarItems):
(WI.MultipleScopeBarItem.prototype.set selectedScopeBarItem):
(WI.MultipleScopeBarItem.prototype.get _visibleScopeBarItems): Added.
(WI.MultipleScopeBarItem.prototype._selectElementSelectionChanged):
(WI.MultipleScopeBarItem.prototype._handleItemHiddenChanged): Added.
Dispatch an event when an item is hidden so that any owner `WI.MultipleScopeBarItem` can
rerender it's <select> without that item.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Main.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoUnreviewed, rolling out r242747.
commit-queue@webkit.org [Tue, 12 Mar 2019 21:03:08 +0000 (21:03 +0000)]
Unreviewed, rolling out r242747.
https://bugs.webkit.org/show_bug.cgi?id=195641

Performance measurement is difficult in this period, rolling
out it and rolling in later to isolate it from the other
sensitive patches (Requested by yusukesuzuki on #webkit).

Reverted changeset:

"[JSC] Make StaticStringImpl & StaticSymbolImpl actually
static"
https://bugs.webkit.org/show_bug.cgi?id=194212
https://trac.webkit.org/changeset/242747

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[ews-build] Show status bubbles while the patch is waiting in queue
aakash_jain@apple.com [Tue, 12 Mar 2019 20:58:12 +0000 (20:58 +0000)]
[ews-build] Show status bubbles while the patch is waiting in queue
https://bugs.webkit.org/show_bug.cgi?id=195618

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are
enabled in initial deployment.
(StatusBubble._build_bubble): Display bubble even when build hasn't started.
(StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
(StatusBubble.get_builds_for_queue): Get all builds for a given queue.
(StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
(StatusBubble._build_bubbles_for_patch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[WebGL] WebGLBuffer can be too large
dino@apple.com [Tue, 12 Mar 2019 20:57:43 +0000 (20:57 +0000)]
[WebGL] WebGLBuffer can be too large
https://bugs.webkit.org/show_bug.cgi?id=195068
<rdar://problem/48414289>

Reviewed by Antoine Quint.

Source/WebCore:

When creating an element array buffer, make sure to
test against the maximum size of an ArrayBuffer, rather
than just assume it can be created.

Test: fast/canvas/webgl/largeBuffer.html

* html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::associateBufferDataImpl):

LayoutTests:

* fast/canvas/webgl/largeBuffer-expected.txt: Added.
* fast/canvas/webgl/largeBuffer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoAlter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious...
rmorisset@apple.com [Tue, 12 Mar 2019 20:55:49 +0000 (20:55 +0000)]
Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
https://bugs.webkit.org/show_bug.cgi?id=195573

Reviewed by Simon Fraser.

Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.

* Scripts/dump-class-layout:
(main):
* lldb/lldb_dump_class_layout.py:
(ClassLayout.__init__):
(ClassLayout._compute_padding_recursive):
(LLDBDebuggerInstance.dump_layout_for_classname):
(LLDBDebuggerInstance):
(LLDBDebuggerInstance.dump_all_wasteful_layouts):
(LLDBDebuggerInstance.layout_for_classname): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoMore attempts at build fixing.
timothy_horton@apple.com [Tue, 12 Mar 2019 20:40:51 +0000 (20:40 +0000)]
More attempts at build fixing.

* UIProcess/ios/WKActionSheetAssistant.mm:
Yet more.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoDevice Orientation access permission should be denied unless explicitly granted by...
cdumez@apple.com [Tue, 12 Mar 2019 20:32:37 +0000 (20:32 +0000)]
Device Orientation access permission should be denied unless explicitly granted by the client
https://bugs.webkit.org/show_bug.cgi?id=195625

Reviewed by Youenn Fablet.

Source/WebKit:

Device Orientation access permission should be denied unless explicitly granted by the client.
Previously, it was granted by default.

* UIProcess/API/APIUIClient.h:
(API::UIClient::shouldAllowDeviceOrientationAndMotionAccess):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::shouldAllowDeviceOrientationAndMotionAccess):

Tools:

add API test coverage.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
(-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
(-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
(-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
(runDeviceOrientationTest):
(TEST):
* TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoWeb Inspector: Keyboard shortcut for settings tab too greedy on non-US keyboards
nvasilyev@apple.com [Tue, 12 Mar 2019 20:10:32 +0000 (20:10 +0000)]
Web Inspector: Keyboard shortcut for settings tab too greedy on non-US keyboards
https://bugs.webkit.org/show_bug.cgi?id=192947
<rdar://problem/46886779>

Reviewed by Devin Rousso.

* UserInterface/Base/Main.js:
(WI._showSettingsTab):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoWeb Inspector: Elements: provide node context menu items for event listeners sorted...
drousso@apple.com [Tue, 12 Mar 2019 20:05:52 +0000 (20:05 +0000)]
Web Inspector: Elements: provide node context menu items for event listeners sorted by node
https://bugs.webkit.org/show_bug.cgi?id=195633

Reviewed by Matt Baker.

* UserInterface/Base/DOMUtilities.js:
(WI.linkifyNodeReferenceElement):
(WI.bindInteractionsForNodeToElement): Added.
Split logic for adding event listeners into a separate function so it can be used on
existing DOM without modifying it.

* UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
(WI.DOMNodeDetailsSidebarPanel.prototype._refreshEventListeners.generateGroupsByNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoFlaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
jer.noble@apple.com [Tue, 12 Mar 2019 19:37:38 +0000 (19:37 +0000)]
Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
https://bugs.webkit.org/show_bug.cgi?id=195137
<rdar://problem/48810307>

Reviewed by Eric Carlson.

* TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoLayout Test imported/w3c/web-platform-tests/IndexedDB/fire-*-event-exception.html...
sihui_liu@apple.com [Tue, 12 Mar 2019 19:36:47 +0000 (19:36 +0000)]
Layout Test imported/w3c/web-platform-tests/IndexedDB/fire-*-event-exception.html are failing
https://bugs.webkit.org/show_bug.cgi?id=195581

LayoutTests/imported/w3c:

Updated test expectations to PASS.

Reviewed by Brady Eidson.

* web-platform-tests/IndexedDB/fire-error-event-exception-expected.txt:
* web-platform-tests/IndexedDB/fire-success-event-exception-expected.txt:
* web-platform-tests/IndexedDB/fire-upgradeneeded-event-exception-expected.txt:

Source/WebCore:

Reviewed by Brady Eidson.

Uncaught exceptions should be handled after IDBRequest dispatches events so that IDBTransaction would stay
active during event dispatch.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):
* Modules/indexeddb/IDBRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[ews-build] Change urls from uat to production
aakash_jain@apple.com [Tue, 12 Mar 2019 19:34:56 +0000 (19:34 +0000)]
[ews-build] Change urls from uat to production
https://bugs.webkit.org/show_bug.cgi?id=195566

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/config.py:
* BuildSlaveSupport/ews-build/events.py:
* BuildSlaveSupport/ews-build/steps.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[ews-build] change max_builds for local-worker to 1
aakash_jain@apple.com [Tue, 12 Mar 2019 19:32:22 +0000 (19:32 +0000)]
[ews-build] change max_builds for local-worker to 1
https://bugs.webkit.org/show_bug.cgi?id=195568

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/loadConfig.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoLayout Test imported/w3c/web-platform-tests/IndexedDB/transaction-abort-request-error...
sihui_liu@apple.com [Tue, 12 Mar 2019 19:28:40 +0000 (19:28 +0000)]
Layout Test imported/w3c/web-platform-tests/IndexedDB/transaction-abort-request-error.html is failing
https://bugs.webkit.org/show_bug.cgi?id=195570

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Updated test expectation to PASS.

* web-platform-tests/IndexedDB/transaction-abort-request-error-expected.txt:

Source/WebCore:

IDBRequest result should be undefined if it is never set.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[iOS] Enable asynchronous frame scrolling by default
antti@apple.com [Tue, 12 Mar 2019 19:18:51 +0000 (19:18 +0000)]
[iOS] Enable asynchronous frame scrolling by default
https://bugs.webkit.org/show_bug.cgi?id=195622
<rdar://problem/48658028>

Reviewed by Simon Fraser

* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoUnreviewed, fix a typo in TestExpecations.
ryanhaddad@apple.com [Tue, 12 Mar 2019 19:16:47 +0000 (19:16 +0000)]
Unreviewed, fix a typo in TestExpecations.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoA lot more classes have padding that can be reduced by reordering their fields
rmorisset@apple.com [Tue, 12 Mar 2019 19:07:04 +0000 (19:07 +0000)]
A lot more classes have padding that can be reduced by reordering their fields
https://bugs.webkit.org/show_bug.cgi?id=195579

Reviewed by Mark Lam.

Source/bmalloc:

* bmalloc/Heap.h:
* bmalloc/Scavenger.h:

Source/JavaScriptCore:

* assembler/LinkBuffer.h:
* dfg/DFGArrayifySlowPathGenerator.h:
(JSC::DFG::ArrayifySlowPathGenerator::ArrayifySlowPathGenerator):
* dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
(JSC::DFG::CallArrayAllocatorSlowPathGenerator::CallArrayAllocatorSlowPathGenerator):
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):
* dfg/DFGGraph.h:
* dfg/DFGNode.h:
(JSC::DFG::SwitchData::SwitchData):
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
* dfg/DFGPlan.h:
* dfg/DFGSlowPathGenerator.h:
(JSC::DFG::CallSlowPathGenerator::CallSlowPathGenerator):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* dfg/DFGSpeculativeJIT.h:
* domjit/DOMJITSignature.h:
(JSC::DOMJIT::Signature::Signature):
(JSC::DOMJIT::Signature::effect):
(JSC::DOMJIT::Signature::argumentCount): Deleted.
* heap/MarkingConstraintSolver.h:
* heap/SlotVisitor.h:
* jit/CallFrameShuffleData.h:
* jit/JITDivGenerator.h:
* jit/SpillRegistersMode.h:
* parser/Nodes.h:
* profiler/ProfilerOSRExit.cpp:
(JSC::Profiler::OSRExit::OSRExit):
* profiler/ProfilerOSRExit.h:
* runtime/ArrayBufferView.h:
* runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::SamplingProfiler):
* runtime/SamplingProfiler.h:
* runtime/TypeSet.cpp:
(JSC::StructureShape::StructureShape):
* runtime/TypeSet.h:
* runtime/Watchdog.h:

Source/WTF:

* wtf/CrossThreadQueue.h:
* wtf/Logger.h:
* wtf/MemoryPressureHandler.h:
* wtf/MetaAllocator.h:
* wtf/Threading.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoWeb Inspector: DOM Debugger: remove left padding when the last DOM breakpoint is...
drousso@apple.com [Tue, 12 Mar 2019 19:03:01 +0000 (19:03 +0000)]
Web Inspector: DOM Debugger: remove left padding when the last DOM breakpoint is removed
https://bugs.webkit.org/show_bug.cgi?id=195522

Reviewed by Matt Baker.

* UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView.prototype._updateBreakpointStatus):
* UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype.get hasBreakpoint): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoThe HasIndexedProperty node does GC.
mark.lam@apple.com [Tue, 12 Mar 2019 19:02:22 +0000 (19:02 +0000)]
The HasIndexedProperty node does GC.
https://bugs.webkit.org/show_bug.cgi?id=195559
<rdar://problem/48767923>

Reviewed by Yusuke Suzuki.

JSTests:

* stress/HasIndexedProperty-does-gc.js: Added.

Source/JavaScriptCore:

HasIndexedProperty can call the slow path operationHasIndexedPropertyByInt(),
which can eventually call JSString::getIndex(), which can resolve a rope.

* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoWeb Inspector: Canvas: export recording as HTML
drousso@apple.com [Tue, 12 Mar 2019 18:59:29 +0000 (18:59 +0000)]
Web Inspector: Canvas: export recording as HTML
https://bugs.webkit.org/show_bug.cgi?id=195311
<rdar://problem/48588673>

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

* UserInterface/Models/Recording.js:
(WI.Recording.prototype.async swizzle):
(WI.Recording.prototype.toHTML): Added.
(WI.Recording.prototype.toHTML.escapeHTML): Added.
(WI.Recording.prototype.toHTML.processObject): Added.
(WI.Recording.prototype.toHTML.processValue): Added.

* UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView):
(WI.RecordingContentView.prototype._exportRecording):
(WI.RecordingContentView.prototype._exportReduction): Added.
(WI.RecordingContentView.prototype._updateExportButton): Added.
(WI.RecordingContentView.prototype._handleExportNavigationItemClicked): Added.
(WI.RecordingContentView.prototype._handleRecordingProcessedAction):

* UserInterface/Views/CanvasOverviewContentView.js:
(WI.CanvasOverviewContentView):
* UserInterface/Views/HeapAllocationsTimelineView.js:
(WI.HeapAllocationsTimelineView):
* UserInterface/Views/HeapSnapshotContentView.js:
(WI.HeapSnapshotContentView):
Drive-by: s/`toolTip`/`tooltip`.
* Localizations/en.lproj/localizedStrings.js:

LayoutTests:

* inspector/canvas/recording-html-2d.html: Added.
* inspector/canvas/recording-html-2d-expected.txt: Added.
* inspector/canvas/recording-2d-expected.txt: Added.
* inspector/canvas/resources/recording-utilities.js:
(TestPage.registerInitializer.log):
(TestPage.registerInitializer.window.startRecording):

* platform/ios-wk1/TestExpectations:
* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoWeb Inspector: Audit: there should be a centralized place for reusable code
drousso@apple.com [Tue, 12 Mar 2019 18:56:28 +0000 (18:56 +0000)]
Web Inspector: Audit: there should be a centralized place for reusable code
https://bugs.webkit.org/show_bug.cgi?id=195265
<rdar://problem/47040673>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

* inspector/protocol/Audit.json:
Increment version.

Source/WebInspectorUI:

* UserInterface/Controllers/AuditManager.js:
(WI.AuditManager.prototype.async start):
(WI.AuditManager.prototype._topLevelTestForTest): Added.
(WI.AuditManager.prototype._topLevelTestForTest.walk): Added.

* UserInterface/Models/AuditTestBase.js:
(WI.AuditTestBase):
(WI.AuditTestBase.prototype.async setup): Added.
(WI.AuditTestBase.toJSON):

* UserInterface/Models/AuditTestCase.js:
(WI.AuditTestCase.async.fromPayload):
(WI.AuditTestCase.prototype.async run.async parseResponse):
Allow additional data to be passed back to the result's `data` for testing.

* UserInterface/Models/AuditTestGroup.js:
(WI.AuditTestGroup.async.fromPayload):

LayoutTests:

* inspector/audit/manager-start-setup.html: Added.
* inspector/audit/manager-start-setup-expected.txt: Added.
* inspector/model/auditTestCase.html:
* inspector/model/auditTestCase-expected.txt:
* inspector/model/auditTestGroup.html:
* inspector/model/auditTestGroup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[iOS] Block access to backboardd service
pvollan@apple.com [Tue, 12 Mar 2019 18:51:13 +0000 (18:51 +0000)]
[iOS] Block access to backboardd service
https://bugs.webkit.org/show_bug.cgi?id=195484

Reviewed by Brent Fulgham.

This patch is addressing blocking the backboardd service "com.apple.backboard.hid.services". Getting the
backlight level in the WebContent process will initiate a connection with this service. To be able to
block the service, the backlight level is queried in the UI process and sent to the WebContent process
when the WebContent process is started, and when the backlight level is changed. On the WebContent side,
the method getting the backlight level is swizzled to return the value sent from the UI process.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::displayBrightness):
(WebKit::WebProcessPool::backlightLevelDidChangeCallback):
(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
* UIProcess/WebProcessPool.h:
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::currentBacklightLevel):
(WebKit::WebProcess::backlightLevelDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoFix the build after 242801
timothy_horton@apple.com [Tue, 12 Mar 2019 18:25:34 +0000 (18:25 +0000)]
Fix the build after 242801

* UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant _elementActionForDDAction:]):
More.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoFix the build after 242801
timothy_horton@apple.com [Tue, 12 Mar 2019 18:23:54 +0000 (18:23 +0000)]
Fix the build after 242801

* UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant _elementActionForDDAction:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoRename originsMatch in originSerializationsMatch
youenn@apple.com [Tue, 12 Mar 2019 18:08:17 +0000 (18:08 +0000)]
Rename originsMatch in originSerializationsMatch
https://bugs.webkit.org/show_bug.cgi?id=195572

Reviewed by Jiewen Tan.

In addition to renaming, make use of SecurityOrigin::isSameOriginAs
where it makes more sense than to compare origin serialization.
The main difference is that isSameOriginAs will return false for two different unique origins
while originsSerializationsMatch will not.

* Modules/credentialmanagement/CredentialsContainer.cpp:
(WebCore::CredentialsContainer::doesHaveSameOriginAsItsAncestors):
* Modules/mediastream/RTCController.cpp:
(WebCore::matchDocumentOrigin):
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::certificatesFromConfiguration):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::shouldOpenExternalURLsPolicyToPropagate const):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::shouldUpdateCachedResourceWithCurrentRequest):
* page/SecurityOrigin.cpp:
(WebCore::serializedOriginsMatch):
(WebCore::originsMatch): Deleted.
* page/SecurityOrigin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[iOS] Sandbox must allow mach lookup required to compress video
eric.carlson@apple.com [Tue, 12 Mar 2019 17:47:32 +0000 (17:47 +0000)]
[iOS] Sandbox must allow mach lookup required to compress video
https://bugs.webkit.org/show_bug.cgi?id=195627
<rdar://problem/48811072>

Reviewed by Youenn Fablet.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoblocksInPreOrder and blocksInPostOrder should reserve the right capacity for their...
rmorisset@apple.com [Tue, 12 Mar 2019 17:42:42 +0000 (17:42 +0000)]
blocksInPreOrder and blocksInPostOrder should reserve the right capacity for their result vector
https://bugs.webkit.org/show_bug.cgi?id=195595

Reviewed by Saam Barati.

Also change BlockList from being Vector<BasicBlock*, 5> to Vector<BasicBlock*>

* dfg/DFGBasicBlock.h:
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::blocksInPreOrder):
(JSC::DFG::Graph::blocksInPostOrder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoCheck whether to launch a default action instead of action sheet
commit-queue@webkit.org [Tue, 12 Mar 2019 17:41:59 +0000 (17:41 +0000)]
Check whether to launch a default action instead of action sheet
https://bugs.webkit.org/show_bug.cgi?id=195225
<rdar://problem/47715544>

Patch by Jennifer Moore <jennifer.moore@apple.com> on 2019-03-12
Source/WebCore/PAL:

Reviewed by Daniel Bates.

Add new SPI declarations.

* pal/spi/ios/DataDetectorsUISPI.h:

Source/WebKit:

Reviewed by Daniel Bates and Tim Horton.

Notify DataDetectors at the start of a touch on a link, and check whether to immediately
launch the default action instead of an action sheet.

* UIProcess/ios/WKActionSheetAssistant.h:
* UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant interactionDidStart]):
(-[WKActionSheetAssistant _createSheetWithElementActions:defaultTitle:showLinkTitle:]):
(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant showLinkSheet]):
(-[WKActionSheetAssistant showDataDetectorsSheet]):
(-[WKActionSheetAssistant _createSheetWithElementActions:showLinkTitle:]): Deleted.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _webTouchEventsRecognized:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[iOS] Add test to ensure that a web page can prevent the default for Command + A
dbates@webkit.org [Tue, 12 Mar 2019 17:23:00 +0000 (17:23 +0000)]
[iOS] Add test to ensure that a web page can prevent the default for Command + A
https://bugs.webkit.org/show_bug.cgi?id=192425

Reviewed by Wenson Hsieh.

Skip the test until we have the UIKit fix for <rdar://problem/46430796>.

* fast/events/ios/key-command-select-all-prevent-default.html: Added.
* platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoFix the build
timothy_horton@apple.com [Tue, 12 Mar 2019 17:22:55 +0000 (17:22 +0000)]
Fix the build

* TestRunnerShared/spi/PencilKitTestSPI.h:
* TestWebKitAPI/ios/PencilKitTestSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[Synthetic Click] Dispatch mouseout soon after mouseup
zalan@apple.com [Tue, 12 Mar 2019 17:15:52 +0000 (17:15 +0000)]
[Synthetic Click] Dispatch mouseout soon after mouseup
https://bugs.webkit.org/show_bug.cgi?id=195575
<rdar://problem/47093049>

Reviewed by Simon Fraser.

Source/WebCore:

Let's fire a mouseout event when a click is submitted as the result of a tap. It helps to dismiss content which would otherwise require you to move the mouse (cases like control bar on youtube.com).

Test: fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html

* page/EventHandler.h:
* page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::dispatchFakeMouseOut):

Source/WebKit:

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::completeSyntheticClick):

LayoutTests:

* fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click-expected.txt: Added.
* fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoIn CachedFrame's constructor, release-assert that DOMWindow still has a frame after...
rniwa@webkit.org [Tue, 12 Mar 2019 16:50:46 +0000 (16:50 +0000)]
In CachedFrame's constructor, release-assert that DOMWindow still has a frame after page-caching subframes
https://bugs.webkit.org/show_bug.cgi?id=195609

Reviewed by Chris Dumez.

r242677 added release assertions to DOMWindow::suspendForPageCache. But when the first release assert in
that function is hit, we still can't tell whether active DOM objects are detaching frames, or if creating
CachedFrame's on one of subframes is causing the frame to go way.

Add a release assertion immediately after creating CachedFrame on subframes to detect this case.

* history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[ContentChangeObserver] Stop content change observation when the touch event turns...
zalan@apple.com [Tue, 12 Mar 2019 16:40:31 +0000 (16:40 +0000)]
[ContentChangeObserver] Stop content change observation when the touch event turns into long press
https://bugs.webkit.org/show_bug.cgi?id=195601
<rdar://problem/48796324>

Reviewed by Wenson Hsieh.

Source/WebCore:

Cancel the ongoing content observation (started at touchStart) when the touch event does not turn into a tap gesture.

Not testable because any subsequent tap would reset the state anyway (though it might be measurable through some code triggering heavy content change).

* page/ios/ContentChangeObserver.cpp:
(WebCore::ContentChangeObserver::didRecognizeLongPress):
(WebCore::ContentChangeObserver::willNotProceedWithClick):
* page/ios/ContentChangeObserver.h:

Source/WebKit:

Add didRecognizeLongPress() message to be able to cancel content observation (started at touchStart).

* UIProcess/WebPageProxy.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _longPressRecognized:]):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didRecognizeLongPress):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::didRecognizeLongPress):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[Mac] Ensure Apple Pay is unavailable when PassKit.framework is missing
aestes@apple.com [Tue, 12 Mar 2019 15:07:13 +0000 (15:07 +0000)]
[Mac] Ensure Apple Pay is unavailable when PassKit.framework is missing
https://bugs.webkit.org/show_bug.cgi?id=195583
<rdar://problem/48420224>

Reviewed by Daniel Bates.

PassKit.framework is optionally soft-linked on Mac because it is missing from the Recovery
Partition. We need to check if the framework is available before calling into it.

* Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::WebPaymentCoordinatorProxy::platformCanMakePayments):
(WebKit::WebPaymentCoordinatorProxy::platformCanMakePaymentsWithActiveCard):
(WebKit::WebPaymentCoordinatorProxy::platformOpenPaymentSetup):
(WebKit::WebPaymentCoordinatorProxy::platformAvailablePaymentNetworks):
* Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:
(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoCompositing layer that renders two positioned elements should not hit test
antti@apple.com [Tue, 12 Mar 2019 14:45:31 +0000 (14:45 +0000)]
Compositing layer that renders two positioned elements should not hit test
https://bugs.webkit.org/show_bug.cgi?id=195371
<rdar://problem/48649586>

Reviewed by Simon Fraser.

Source/WebCore:

Compute and pass an event region for layers if it differs from layer bounds.

This patch fixes various block overflow and layer expansion cases. It does not handle
overflowing line boxes yet (it adds tests for those too).

Test: fast/scrolling/ios/overflow-scroll-overlap-2.html

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::setEventRegion):
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::eventRegion):
* platform/graphics/Region.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setEventRegion):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateEventRegion):

Pass the region via the main platform layer of the graphics layer.

* platform/graphics/ca/GraphicsLayerCA.h:
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
* rendering/PaintInfo.h:
* rendering/PaintPhase.h:

Add EventRegion paint phase that computes the region instead of painting anything.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintForegroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):

Invoke EventRegion paint phase.

* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):

Request event region when pointing a layer.

Source/WebKit:

* Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
(WebKit::RemoteLayerTreePropertyApplier::applyProperties):
* Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
* Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode const):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):

Pass event region to UI process.

* UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h:
(WebKit::RemoteLayerTreeNode::layerID const):
(WebKit::RemoteLayerTreeNode::eventRegion const):
* UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:
(WebKit::RemoteLayerTreeNode::RemoteLayerTreeNode):
(WebKit::RemoteLayerTreeNode::~RemoteLayerTreeNode):
(WebKit::RemoteLayerTreeNode::setEventRegion):

Maintain event region in RemoteLayerTreeNodes.

(WebKit::RemoteLayerTreeNode::initializeLayer):
(WebKit::RemoteLayerTreeNode::layerID):
(WebKit::RemoteLayerTreeNode::forCALayer):

Move layerID to RemoteLayerTreeNode and store RemoteLayerTreeNode pointer to CALayers instead.
This makes it easy to find the matching RemoteLayerTreeNode from a layer, globally.

(WebKit::RemoteLayerTreeNode::setLayerID): Deleted.
* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
(WebKit::collectDescendantViewsAtPoint):

If we have event region, use it for hit testing.

(-[UIView _web_findDescendantViewAtPoint:withEvent:]):
(collectDescendantViewsAtPoint): Deleted.
* WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::eventRegion const):
(WebKit::PlatformCALayerRemote::setEventRegion):
* WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:

LayoutTests:

* fast/scrolling/ios/overflow-scroll-overlap-2-expected.txt: Added.
* fast/scrolling/ios/overflow-scroll-overlap-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[GStreamer][v4l2] Synchronous video texture flushing support
philn@webkit.org [Tue, 12 Mar 2019 14:17:06 +0000 (14:17 +0000)]
[GStreamer][v4l2] Synchronous video texture flushing support
https://bugs.webkit.org/show_bug.cgi?id=195453

Reviewed by Xabier Rodriguez-Calvar.

The v4l2 video decoder currently requires that downstream users of
the graphics resources complete any pending draw call and release
resources before returning from the DRAIN query.

To accomplish this the player monitors the pipeline and whenever a
v4l2 decoder is added, synchronous video texture flushing support
is enabled. Additionally and for all decoder configurations, a
flush is performed before disposing of the player.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::playbinDeepElementAddedCallback):
Monitor elements added to the decodebin bin.
(WebCore::MediaPlayerPrivateGStreamer::decodebinElementAdded): Set
a flag if a v4l2 decoder was added in decodebin.
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Connect
to the deep-element-added signal so as to monitor pipeline
topology updates.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
Flush video texture before disposing of the player.
(WebCore::MediaPlayerPrivateGStreamerBase::flushCurrentBuffer):
Synchronously flush if the pipeline contains a v4l2 decoder.
(WebCore::MediaPlayerPrivateGStreamerBase::createGLAppSink): Monitor push events only.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
* platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:
(WebCore::TextureMapperPlatformLayerProxy::pushNextBuffer): New
boolean flag used mostly to trigger synchronous flush conditions.
(WebCore::TextureMapperPlatformLayerProxy::dropCurrentBufferWhilePreservingTexture):
Optionally drop the current buffer in a synchronous manner. By
default the method keeps operating asynchronously.
* platform/graphics/texmap/TextureMapperPlatformLayerProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoMove the remaining code to decide whether site specific quirks are needed to Quirks...
rniwa@webkit.org [Tue, 12 Mar 2019 11:38:49 +0000 (11:38 +0000)]
Move the remaining code to decide whether site specific quirks are needed to Quirks class
https://bugs.webkit.org/show_bug.cgi?id=195610

Reviewed by Antti Koivisto.

Moved the remaining code scattered across WebCore to decide whether a site specific quirk
is needed or not to Quirks class introduced in r236818.

* Modules/fetch/FetchRequest.cpp:
(WebCore::needsSignalQuirk): Deleted.
(WebCore::processInvalidSignal):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::needsMouseFocusableQuirk const):
* html/HTMLMediaElement.cpp:
(WebCore::needsAutoplayPlayPauseEventsQuirk): Deleted.
(WebCore::HTMLMediaElement::dispatchPlayPauseEventsIfNeedsQuirks):
(WebCore::needsSeekingSupportQuirk): Deleted.
(WebCore::HTMLMediaElement::supportsSeeking const):
* html/MediaElementSession.cpp:
(WebCore::needsArbitraryUserGestureAutoplayQuirk): Deleted.
(WebCore::needsPerDocumentAutoplayBehaviorQuirk): Deleted.
(WebCore::MediaElementSession::playbackPermitted const):
* page/Quirks.cpp:
(WebCore::allowedAutoplayQuirks): Added.
(WebCore::Quirks::needsQuirks const): Added.
(WebCore::Quirks::shouldIgnoreInvalidSignal const): Added.
(WebCore::Quirks::needsFormControlToBeMouseFocusable const): Added.
(WebCore::Quirks::needsAutoplayPlayPauseEvents const): Added.
(WebCore::Quirks::needsSeekingSupportDisabled const): Addd.
(WebCore::Quirks::needsPerDocumentAutoplayBehavior const): Added.
(WebCore::Quirks::shouldAutoplayForArbitraryUserGesture const): Added.
(WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const): Added.
(WebCore::Quirks::hasWebSQLSupportQuirk const): Fixed the coding style.
* page/Quirks.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[Media][MSE] Don't emit timeUpdate after play() if currentTime hasn't changed
eocanha@igalia.com [Tue, 12 Mar 2019 11:09:45 +0000 (11:09 +0000)]
[Media][MSE] Don't emit timeUpdate after play() if currentTime hasn't changed
https://bugs.webkit.org/show_bug.cgi?id=195454

Reviewed by Jer Noble.

Source/WebCore:

This change fixes YouTube 2019 MSE Conformance Tests "26. SFRPausedAccuracy"
and "27. HFRPausedAccuracy".

The first timeUpdate event after play() is omitted, because currentTime
doesn't actually change in that scenario.

Tests 26 and 27 measure the time drift (real time vs. media time) on playback
and start counting since the first timeUpdate event. In WebKit, that event
happens at play(), before the pipeline has completed the transition to playing.
Therefore, the real time inherits this startup delay and the test thinks that
the player has drifted.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::playInternal): Don't emit a timeUpdated event unless currentTime has changed.

LayoutTests:

This patch removes expectations for the first timeUpdate event after
play(), because currentTime doesn't actually change in that scenario
and the spec[1] states that a timeupdate event is fired if "The current
playback position changed as part of normal playback or in an
especially interesting way, for example discontinuously."

[1] https://www.w3.org/TR/html52/semantics-embedded-content.html#eventdef-media-timeupdate

* media/video-paused-0-rate.html: Don't require the timeUpdate event when currentTime=0 to pass the test.
* media/video-play-pause-events-expected.txt: Ditto, and changed test description.
* media/video-play-pause-events.html: Changed test description to reflect the new behaviour.
* media/video-play-pause-exception-expected.txt: Don't require the timeUpdate event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[EME][GStreamer] Speculative build fix
eocanha@igalia.com [Tue, 12 Mar 2019 10:59:30 +0000 (10:59 +0000)]
[EME][GStreamer] Speculative build fix
https://bugs.webkit.org/show_bug.cgi?id=195614

Unreviewed speculative WPE build fix after r242776.

* platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.h: Added missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[GStreamer] remove legacy GStreamer version checks
philn@webkit.org [Tue, 12 Mar 2019 10:25:03 +0000 (10:25 +0000)]
[GStreamer] remove legacy GStreamer version checks
https://bugs.webkit.org/show_bug.cgi?id=195552

Reviewed by Xabier Rodriguez-Calvar.

We require GStreamer 1.8.x so version checks below that make
little sense. Also checks for odd minor version numbers make sense
only for the latest GStreamer git development version.

* platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::initializeGStreamerAndRegisterWebKitElements):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::ensureGstGLContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[WPE][GTK] Load events may occur in unexpected order when JS redirects page before...
carlosgc@webkit.org [Tue, 12 Mar 2019 08:30:43 +0000 (08:30 +0000)]
[WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
https://bugs.webkit.org/show_bug.cgi?id=194131

Source/WebKit:

Reviewed by Michael Catanzaro.

Ensure we emit the load-failed and load-changed with finished event when there's still an ongoing load when a
new provisional load strarts. Previous load fails with cancelled error.

* UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewWillStartLoad): Call webkitWebViewLoadFailed() if current page load state is not finished.
* UIProcess/API/glib/WebKitWebViewPrivate.h:
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::didStartProvisionalLoadForMainFrame): Call webkitWebViewWillStartLoad().
* UIProcess/API/wpe/APIViewClient.h:
(API::ViewClient::willStartLoad): Add willStartLoad() to API::ViewClient
* UIProcess/API/wpe/PageClientImpl.cpp:
(WebKit::PageClientImpl::didStartProvisionalLoadForMainFrame): Call WPEView::willStartLoad().
* UIProcess/API/wpe/PageClientImpl.h:
* UIProcess/API/wpe/WPEView.cpp:
(WKWPE::View::willStartLoad): Call API::ViewClient::willStartLoad().
* UIProcess/API/wpe/WPEView.h:
* UIProcess/PageLoadState.h:
(WebKit::PageLoadState::isProvisional const):
(WebKit::PageLoadState::isCommitted const):
(WebKit::PageLoadState::isFinished const):

Tools:

Patch by Michael Catanzaro <mcatanzaro@igalia.com> on 2019-03-12
Reviewed by Michael Catanzaro.

* TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
(uriChanged):
(testUnfinishedSubresourceLoad):
(serverCallback):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[EME] generateRequest was not using the sanitized init data
calvaris@igalia.com [Tue, 12 Mar 2019 08:29:07 +0000 (08:29 +0000)]
[EME] generateRequest was not using the sanitized init data
https://bugs.webkit.org/show_bug.cgi?id=195555

Reviewed by Jer Noble.

* Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::generateRequest): Use sanitized init
data instead of the original one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoImplement further CORS restrictions
commit-queue@webkit.org [Tue, 12 Mar 2019 08:13:26 +0000 (08:13 +0000)]
Implement further CORS restrictions
https://bugs.webkit.org/show_bug.cgi?id=188644

Patch by Rob Buis <rbuis@igalia.com> on 2019-03-12
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update improved test results.

* web-platform-tests/fetch/api/cors/cors-preflight-not-cors-safelisted.any-expected.txt:
* web-platform-tests/fetch/api/cors/cors-preflight-not-cors-safelisted.any.worker-expected.txt:
* web-platform-tests/fetch/api/headers/headers-no-cors.window-expected.txt:

Source/WebCore:

Verify that header value length is not greater than 128 [1]. Also implement
Step 5 of [2] to append values to existing header value when calling
Headers.append.

Tests: fetch/api/cors/cors-preflight-not-cors-safelisted.any.html
       fetch/api/cors/cors-preflight-not-cors-safelisted.any.worker.html
       fetch/api/headers/headers-no-cors.window.html

[1] https://fetch.spec.whatwg.org/#cors-safelisted-request-header
[2] https://fetch.spec.whatwg.org/#concept-headers-append

* Modules/fetch/FetchHeaders.cpp:
(WebCore::canWriteHeader):
(WebCore::appendToHeaderMap):
(WebCore::FetchHeaders::remove):
(WebCore::FetchHeaders::set):
(WebCore::FetchHeaders::filterAndFill):
* platform/network/HTTPParsers.cpp:
(WebCore::isCrossOriginSafeRequestHeader): verify that header length is not greater than 128

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoWeb Inspector: Timelines - Improve handling of past recordings (readonly)
commit-queue@webkit.org [Tue, 12 Mar 2019 07:10:58 +0000 (07:10 +0000)]
Web Inspector: Timelines - Improve handling of past recordings (readonly)
https://bugs.webkit.org/show_bug.cgi?id=195594

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2019-03-12
Reviewed by Devin Rousso.

* UserInterface/Views/TimelineRecordingContentView.js:
(WI.TimelineRecordingContentView.prototype._clearTimeline):
Don't allow clearing of a readonly recording.

* UserInterface/Views/TimelineTabContentView.js:
(WI.TimelineTabContentView.prototype._toggleRecordingOnSpacebar):
Don't do anything when viewing a readonly recording.

(WI.TimelineTabContentView.prototype._recordButtonClicked):
Start a new recording if viewing a readonly recording.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoRemove OS X Server QuickTime plugin quirks
rniwa@webkit.org [Tue, 12 Mar 2019 06:58:20 +0000 (06:58 +0000)]
Remove OS X Server QuickTime plugin quirks
https://bugs.webkit.org/show_bug.cgi?id=195607

Reviewed by Brent Fulgham.

r87244 added a site specific quirk for Mac OS X Sever wiki pages.
However, the issue has since been resolved as of OS X Mountain Lion,
of which Apple has ended the support in September 2015.

Because the latest versions of Safari no longer supports non-Flash plugins,
the only scenario in which this quirk comes into play is when a third party app
which embeds WKWebView or WebKitLegacy loaded web pages on a OS X Server
running OS X Mountain Lion or earlier.

Given these observations, it's probably safe to remove this quirk from WebKit.

* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::hasFallbackContent const):
(WebCore::HTMLObjectElement::hasValidClassId):
(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk): Deleted.
* html/HTMLObjectElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoUnreviewed speculative WPE build fix after r195586.
ross.kirsling@sony.com [Tue, 12 Mar 2019 06:44:27 +0000 (06:44 +0000)]
Unreviewed speculative WPE build fix after r195586.

* platform/encryptedmedia/CDMInstance.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoRemove MediaWiki site specific quirks
rniwa@webkit.org [Tue, 12 Mar 2019 06:09:58 +0000 (06:09 +0000)]
Remove MediaWiki site specific quirks
https://bugs.webkit.org/show_bug.cgi?id=195597

Reviewed by Simon Fraser.

r47383 added a site specific quirk for the KHTML workaround in MediaWiki.

Blink since removed this workaround:
https://github.com/chromium/chromium/commit/ecf84fc9c1a51c8ede7adfd0b0cba446d9a8caa0

Given Chrome has been shipping without this quirk for six years, it's safe to assume
this site specific quirk is no longer neeed for Web compatibility.

* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
* css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
* css/parser/CSSParserContext.h:
(WebCore::CSSParserContextHash::hash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoRemove OpenCube QuickMenu quirks from navigator.appVersion
rniwa@webkit.org [Tue, 12 Mar 2019 06:07:14 +0000 (06:07 +0000)]
Remove OpenCube QuickMenu quirks from navigator.appVersion
https://bugs.webkit.org/show_bug.cgi?id=195600

Reviewed by Simon Fraser.

Remove the site specific quirk added in r35050 for OpenCube QuickMenu library for nwa.com

Blink removed this code back in 2013. The fact Chrome has been shipping successfully without
this quirk for six years is a good evidence that it's no longer needed for the Web compatibility.

* page/Navigator.cpp:
(WebCore::Navigator::appVersion const):
(WebCore::shouldHideFourDot): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoWTF::Expected should use std::addressof instead of operator&
commit-queue@webkit.org [Tue, 12 Mar 2019 06:04:22 +0000 (06:04 +0000)]
WTF::Expected should use std::addressof instead of operator&
https://bugs.webkit.org/show_bug.cgi?id=195604

Patch by Alex Christensen <achristensen@webkit.org> on 2019-03-11
Reviewed by Myles Maxfield.

Source/WTF:

The latter was causing problems with types that do tricky things with constructors and operator&,
specifically UniqueRef but I made a reduced test case.  When it used operator&, it would get the contained
type and call the constructor that takes a contained type instead of the move constructor.

* wtf/Expected.h:
(std::experimental::fundamentals_v3::__expected_detail::base::base):
(std::experimental::fundamentals_v3::expected::swap):

Tools:

* TestWebKitAPI/Tests/WTF/Expected.cpp:
(TestWebKitAPI::Unique::Unique):
(TestWebKitAPI::Unique::operator&):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoUnreviewed, rolling out r242763.
ryanhaddad@apple.com [Tue, 12 Mar 2019 05:50:21 +0000 (05:50 +0000)]
Unreviewed, rolling out r242763.

Causes layout test crashes on iOS simulator

Reverted changeset:

"[Synthetic Click] Dispatch mouseout soon after mouseup"
https://bugs.webkit.org/show_bug.cgi?id=195575
https://trac.webkit.org/changeset/242763

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoAdd Optional to Forward.h.
ross.kirsling@sony.com [Tue, 12 Mar 2019 05:27:44 +0000 (05:27 +0000)]
Add Optional to Forward.h.
https://bugs.webkit.org/show_bug.cgi?id=195586

Reviewed by Darin Adler.

Source/JavaScriptCore:

* b3/B3Common.cpp:
* b3/B3Common.h:
* debugger/DebuggerParseData.cpp:
* debugger/DebuggerParseData.h:
* heap/HeapSnapshot.cpp:
* heap/HeapSnapshot.h:
* jit/PCToCodeOriginMap.cpp:
* jit/PCToCodeOriginMap.h:
* runtime/AbstractModuleRecord.cpp:
* runtime/AbstractModuleRecord.h:
* wasm/WasmInstance.h:
* wasm/WasmModuleParser.h:
* wasm/WasmSectionParser.cpp:
* wasm/WasmSectionParser.h:
* wasm/WasmStreamingParser.cpp:
* wasm/WasmStreamingParser.h:
* yarr/YarrFlags.cpp:
* yarr/YarrFlags.h:
* yarr/YarrUnicodeProperties.cpp:
* yarr/YarrUnicodeProperties.h:
Remove unnecessary includes from headers.

Source/WebCore:

* Modules/encryptedmedia/MediaKeyStatusMap.cpp:
* Modules/encryptedmedia/MediaKeyStatusMap.h:
* Modules/webauthn/apdu/ApduCommand.cpp:
* Modules/webauthn/apdu/ApduCommand.h:
* Modules/webauthn/apdu/ApduResponse.cpp:
* Modules/webauthn/apdu/ApduResponse.h:
* Modules/webauthn/fido/FidoHidMessage.cpp:
* Modules/webauthn/fido/FidoHidMessage.h:
* Modules/webauthn/fido/U2fCommandConstructor.cpp:
* Modules/webauthn/fido/U2fCommandConstructor.h:
* Modules/webdatabase/SQLTransaction.cpp:
* Modules/webdatabase/SQLTransaction.h:
* Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.cpp:
* Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.h:
* Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h:
* Modules/webgpu/WHLSL/WHLSLPrepare.cpp:
* Modules/webgpu/WHLSL/WHLSLPrepare.h:
* Modules/webgpu/WebGPU.cpp:
* Modules/webgpu/WebGPU.h:
* Modules/webgpu/WebGPUCommandBuffer.cpp:
* Modules/webgpu/WebGPUCommandBuffer.h:
* animation/WebAnimation.cpp:
* animation/WebAnimation.h:
* crypto/gcrypt/GCryptUtilities.cpp:
* crypto/gcrypt/GCryptUtilities.h:
* css/CSSStyleDeclaration.cpp:
* css/CSSStyleDeclaration.h:
* dom/TextDecoder.cpp:
* dom/TextDecoder.h:
* dom/UserGestureIndicator.cpp:
* dom/UserGestureIndicator.h:
* editing/ChangeListTypeCommand.cpp:
* editing/ChangeListTypeCommand.h:
* editing/EditingStyle.cpp:
* editing/EditingStyle.h:
* html/DOMFormData.cpp:
* html/DOMFormData.h:
* html/HTMLAllCollection.cpp:
* html/HTMLAllCollection.h:
* html/HTMLAnchorElement.cpp:
* html/HTMLAnchorElement.h:
* html/ImageBitmap.cpp:
* html/ImageBitmap.h:
* html/canvas/Path2D.h:
* html/canvas/WebMetalEnums.cpp:
* html/canvas/WebMetalEnums.h:
* html/parser/HTMLParserIdioms.cpp:
* html/parser/HTMLParserIdioms.h:
* loader/ResourceCryptographicDigest.cpp:
* loader/ResourceCryptographicDigest.h:
* mathml/MathMLOperatorDictionary.cpp:
* mathml/MathMLOperatorDictionary.h:
* page/PerformanceEntry.cpp:
* page/PerformanceEntry.h:
* page/ResourceUsageData.h:
* platform/ReferrerPolicy.cpp:
* platform/ReferrerPolicy.h:
* platform/Theme.cpp:
* platform/Theme.h:
* platform/encryptedmedia/CDMInstance.h:
* platform/graphics/gpu/GPUDevice.cpp:
* platform/graphics/gpu/GPUDevice.h:
* platform/graphics/transforms/AffineTransform.cpp:
* platform/graphics/transforms/AffineTransform.h:
* platform/graphics/transforms/TransformState.cpp:
* platform/graphics/transforms/TransformState.h:
* platform/graphics/transforms/TransformationMatrix.cpp:
* platform/graphics/transforms/TransformationMatrix.h:
* platform/graphics/win/ImageDecoderDirect2D.cpp:
* platform/graphics/win/ImageDecoderDirect2D.h:
* platform/mediacapabilities/AudioConfiguration.h:
* platform/network/CacheValidation.cpp:
* platform/network/CacheValidation.h:
* platform/network/DataURLDecoder.cpp:
* platform/network/DataURLDecoder.h:
* platform/network/HTTPParsers.cpp:
* platform/network/HTTPParsers.h:
* platform/network/curl/CookieJarDB.cpp:
* platform/network/curl/CookieJarDB.h:
* platform/win/SearchPopupMenuDB.cpp:
* platform/win/SearchPopupMenuDB.h:
* rendering/ImageQualityController.cpp:
* rendering/ImageQualityController.h:
* svg/SVGToOTFFontConversion.cpp:
* svg/SVGToOTFFontConversion.h:
Remove unnecessary includes from headers.

Source/WebCore/PAL:

* pal/crypto/tasn1/Utilities.cpp:
* pal/crypto/tasn1/Utilities.h:
Remove unnecessary includes from headers.

Source/WebKit:

* Shared/RTCNetwork.cpp:
* Shared/RTCNetwork.h:
* Shared/RTCPacketOptions.cpp:
* Shared/RTCPacketOptions.h:
* UIProcess/API/APIWebsitePolicies.h:
* UIProcess/WebStorage/LocalStorageDatabaseTracker.h:
Remove unnecessary includes from headers.

Source/WTF:

* wtf/Forward.h:
Add forward declaration for Optional.

* wtf/CPUTime.h:
* wtf/Expected.h:
* wtf/MainThread.h:
* wtf/MemoryFootprint.h:
* wtf/URLHelpers.cpp:
* wtf/URLHelpers.h:
* wtf/cocoa/CPUTimeCocoa.cpp:
* wtf/fuchsia/CPUTimeFuchsia.cpp:
* wtf/unix/CPUTimeUnix.cpp:
* wtf/win/CPUTimeWin.cpp:
Remove unnecessary includes from headers.

Tools:

* TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
* TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
Remove unnecessary includes from headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoUnreviewed, rolling out r242745 and r242756.
commit-queue@webkit.org [Tue, 12 Mar 2019 05:23:43 +0000 (05:23 +0000)]
Unreviewed, rolling out r242745 and r242756.
https://bugs.webkit.org/show_bug.cgi?id=195606

Breaks internal builds (Requested by ryanhaddad on #webkit).

Reverted changesets:

"[iOS] Block access to backboardd service"
https://bugs.webkit.org/show_bug.cgi?id=195484
https://trac.webkit.org/changeset/242745

"Unreviewed build fix after r242745."
https://trac.webkit.org/changeset/242756

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoUnreviewed test gardening, rebaseline tests after r242757.
ryanhaddad@apple.com [Tue, 12 Mar 2019 05:18:34 +0000 (05:18 +0000)]
Unreviewed test gardening, rebaseline tests after r242757.

* http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt:
* http/tests/security/anchor-download-block-crossorigin-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoAdd testing API to hit-test and scroll overflow scrollers
simon.fraser@apple.com [Tue, 12 Mar 2019 04:59:35 +0000 (04:59 +0000)]
Add testing API to hit-test and scroll overflow scrollers
https://bugs.webkit.org/show_bug.cgi?id=195278

Reviewed by Antti Koivisto.

Tools:

Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.

Tests: scrollingcoordinator/ios/scroll-element-at-point.html

* DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
* TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
* TestRunnerShared/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::enclosingScrollViewIncludingSelf):
(WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):

LayoutTests:

The test loads a scaled page with accelerated overflow:scroll, and hit-tests
near the top-left and bottom-right corners to test the point conversion logic.

* scrollingcoordinator/ios/scroll-element-at-point-expected.txt: Added.
* scrollingcoordinator/ios/scroll-element-at-point.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoWeb Inspector: REGRESSION: Network Cookies Table does not load
commit-queue@webkit.org [Tue, 12 Mar 2019 04:56:41 +0000 (04:56 +0000)]
Web Inspector: REGRESSION: Network Cookies Table does not load
https://bugs.webkit.org/show_bug.cgi?id=195599

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2019-03-11
Reviewed by Devin Rousso.

* UserInterface/Views/ResourceCookiesContentView.js:
(WI.ResourceCookiesContentView.prototype.tableIndexForRepresentedObject):
(WI.ResourceCookiesContentView.prototype.tableRepresentedObjectForIndex):
Include needed delegate methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[CoordinatedGraphics] ASSERTION FAILED: !m_state.isSuspended
Hironori.Fujii@sony.com [Tue, 12 Mar 2019 04:12:32 +0000 (04:12 +0000)]
[CoordinatedGraphics] ASSERTION FAILED: !m_state.isSuspended
https://bugs.webkit.org/show_bug.cgi?id=195550

Reviewed by Carlos Garcia Campos.

CompositingRunLoop::suspend() locks a mutex and stops the update
timer. But, the timer can be fired after the lock was acquired and
before the timer is stopped.

* Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:
(WebKit::CompositingRunLoop::updateTimerFired): Removed the
assertion. Return early if m_state.isSuspended.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoREGRESSION(r236281): YouTube Movies fail with "video format" error
jer.noble@apple.com [Tue, 12 Mar 2019 03:49:45 +0000 (03:49 +0000)]
REGRESSION(r236281): YouTube Movies fail with "video format" error
https://bugs.webkit.org/show_bug.cgi?id=195598
<rdar://problem/48782842>

Reviewed by Jon Lee.

Partially revert r236281 for YouTube.com.

* page/Quirks.cpp:
(WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[macOS] Remove the Kerberos rules from the WebContent sandbox
pvollan@apple.com [Tue, 12 Mar 2019 03:24:27 +0000 (03:24 +0000)]
[macOS] Remove the Kerberos rules from the WebContent sandbox
https://bugs.webkit.org/show_bug.cgi?id=195464
<rdar://problem/35369230>

Reviewed by Brent Fulgham.

Kerberos auth is done in the UIProcess or NetworkProcess now.

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoWeb Inspector: use -webkit-{margin,padding}-{start,end} instead of [dir={ltr/rtl...
drousso@apple.com [Tue, 12 Mar 2019 03:22:29 +0000 (03:22 +0000)]
Web Inspector: use -webkit-{margin,padding}-{start,end} instead of [dir={ltr/rtl}] rules
https://bugs.webkit.org/show_bug.cgi?id=195569
<rdar://problem/48778727>

Reviewed by Matt Baker.

* UserInterface/Debug/UncaughtExceptionReporter.css:
* UserInterface/Views/BoxModelDetailsSectionRow.css:
* UserInterface/Views/BreakpointActionView.css:
* UserInterface/Views/BreakpointPopoverController.css:
* UserInterface/Views/CPUTimelineView.css:
* UserInterface/Views/CallFrameTreeElement.css:
* UserInterface/Views/CallFrameView.css:
* UserInterface/Views/DOMTreeContentView.css:
* UserInterface/Views/DOMTreeOutline.css:
* UserInterface/Views/DashboardContainerView.css:
* UserInterface/Views/DataGrid.css:
* UserInterface/Views/DebuggerDashboardView.css:
* UserInterface/Views/DebuggerSidebarPanel.css:
* UserInterface/Views/DefaultDashboardView.css:
* UserInterface/Views/DetailsSection.css:
* UserInterface/Views/FilterBar.css:
* UserInterface/Views/FindBanner.css:
* UserInterface/Views/FontResourceContentView.css:
* UserInterface/Views/GeneralStyleDetailsSidebarPanel.css:
* UserInterface/Views/HierarchicalPathComponent.css:
* UserInterface/Views/LayerTreeDetailsSidebarPanel.css:
* UserInterface/Views/Main.css:
* UserInterface/Views/NetworkTableContentView.css:
* UserInterface/Views/OpenResourceDialog.css:
* UserInterface/Views/RecordingActionTreeElement.css:
* UserInterface/Views/ScopeRadioButtonNavigationItem.css:
* UserInterface/Views/SettingsTabContentView.css:
* UserInterface/Views/ThreadTreeElement.css:
* UserInterface/Views/Toolbar.css:
* UserInterface/Views/TreeOutline.css:
* UserInterface/Views/TypeTreeElement.css:
* UserInterface/Views/TypeTreeView.css:
* UserInterface/Views/URLBreakpointPopover.css:
* UserInterface/Views/WebSocketContentView.css:

* UserInterface/Views/RecordingActionTreeElement.js:
(WI.RecordingActionTreeElement.static _getClassNames):
Replace class `.action` with `.recording-action` for better uniqueness/clarity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[iOS] Add entitlement to enable use of graphics endpoint with limited capabilities
pvollan@apple.com [Tue, 12 Mar 2019 03:21:12 +0000 (03:21 +0000)]
[iOS] Add entitlement to enable use of graphics endpoint with limited capabilities
https://bugs.webkit.org/show_bug.cgi?id=195582
<rdar://problem/36082379>

Reviewed by Brent Fulgham.

This is a QuartzCore endpoint with a minimal set of capabilities.

* Configurations/WebContent-iOS.entitlements:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[Web GPU] BindGroups/Argument buffers: Move MTLBuffer creation from and GPUBindGroup...
justin_fan@apple.com [Tue, 12 Mar 2019 03:19:10 +0000 (03:19 +0000)]
[Web GPU] BindGroups/Argument buffers: Move MTLBuffer creation from and GPUBindGroup validation to GPUDevice.createBindGroup
https://bugs.webkit.org/show_bug.cgi?id=195519
<rdar://problem/48781297>

Reviewed by Myles C. Maxfield.

Metal's Argument Buffers should not be tied directly to GPUBindGroupLayout; rather, create the MTLBuffer
in GPUBindGroup creation process.
Move GPUBindGroup validation out of setBindGroup and to GPUBindGroup creation for performance.

Covered by existing tests. No behavior change.

* Modules/webgpu/WebGPUDevice.cpp:
(WebCore::WebGPUDevice::createBindGroup const):
* Sources.txt:
* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/gpu/GPUBindGroup.cpp: Removed.
* platform/graphics/gpu/GPUBindGroup.h:
(WebCore::GPUBindGroup::vertexArgsBuffer): A buffer that arguments will be encoded into during setBindGroup.
(WebCore::GPUBindGroup::fragmentArgsBuffer): Ditto.
(WebCore::GPUBindGroup::boundBuffers const): A list of resources that are bound by this GPUBindGroup.
(WebCore::GPUBindGroup::boundTextures const): Ditto.
(WebCore::GPUBindGroup::layout const): Deleted.
(WebCore::GPUBindGroup::bindings const): Deleted.
* platform/graphics/gpu/GPUBindGroupLayout.h: No longer creating and retaining MTLBuffers.
(WebCore::GPUBindGroupLayout::vertexEncoder const):
(WebCore::GPUBindGroupLayout::fragmentEncoder const):
(WebCore::GPUBindGroupLayout::computeEncoder const):
(WebCore::GPUBindGroupLayout::ArgumentEncoderBuffer::isValid const): Deleted.
(WebCore::GPUBindGroupLayout::vertexArguments const): Deleted.
(WebCore::GPUBindGroupLayout::fragmentArguments const): Deleted.
(WebCore::GPUBindGroupLayout::computeArguments const): Deleted.
* platform/graphics/gpu/GPUProgrammablePassEncoder.h:
* platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm:
(WebCore::tryCreateMtlArgumentEncoder):
(WebCore::GPUBindGroupLayout::tryCreate):
(WebCore::GPUBindGroupLayout::GPUBindGroupLayout):
(WebCore::tryCreateArgumentEncoderAndBuffer): Deleted.
* platform/graphics/gpu/cocoa/GPUBindGroupMetal.mm: Added.
(WebCore::tryCreateArgumentBuffer): Create and associate the MTLBuffer that backs the MTLArgumentEncoder.
(WebCore::tryGetResourceAsBufferBinding): Validate a GPUBindingResource.
(WebCore::trySetBufferOnEncoder): Encodes a GPUBufferBinding's MTLBuffer on a MTLArgumentEncoder.
(WebCore::tryGetResourceAsSampler): Ditto, for GPUSamplers.
(WebCore::trySetSamplerOnEncoder):
(WebCore::tryGetResourceAsTexture): Ditto, for GPUTextures.
(WebCore::trySetTextureOnEncoder):
(WebCore::GPUBindGroup::tryCreate): Most setBindGroup validation moved here.
(WebCore::GPUBindGroup::GPUBindGroup): Retains the resource references needed for setBindGroup.
* platform/graphics/gpu/cocoa/GPUProgrammablePassEncoderMetal.mm:
(WebCore::GPUProgrammablePassEncoder::setBindGroup): Most validation moved to GPUBindGroup::tryCreate().
(WebCore::GPUProgrammablePassEncoder::setResourceAsBufferOnEncoder): Deleted.
(WebCore::GPUProgrammablePassEncoder::setResourceAsSamplerOnEncoder): Deleted.
(WebCore::GPUProgrammablePassEncoder::setResourceAsTextureOnEncoder): Deleted.
* platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:
(WebCore::GPURenderPassEncoder::useResource):
(WebCore::GPURenderPassEncoder::setVertexBuffer):
(WebCore::GPURenderPassEncoder::setFragmentBuffer):

Misc:
* platform/graphics/gpu/GPUCommandBuffer.cpp/h: Move missing includes to header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoWeb Inspector: DOMDebugger: protocol error on first open
drousso@apple.com [Tue, 12 Mar 2019 02:54:07 +0000 (02:54 +0000)]
Web Inspector: DOMDebugger: protocol error on first open
https://bugs.webkit.org/show_bug.cgi?id=195248
<rdar://problem/48538465>

Unreviewed followup of r242743 to fix test inspector/dom-debugger/dom-breakpoints.html.

* UserInterface/Controllers/DOMDebuggerManager.js:
(WI.DOMDebuggerManager.prototype.addDOMBreakpoint):
(WI.DOMDebuggerManager.prototype._resolveDOMBreakpoint):
Still attempt to resolve the DOM breakpoint if it already has a `domNodeIdentifier` so that
it will get added to the node's frame's DOM breakpoint map. Without this, some breakpoints
might get "missed" when calling `WI.domDebuggerManager.removeDOMBreakpointsForNode`.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoMove NetworkProcess/Classifier/ResourceLoadStatisticsStoreCocoa.mm functionality...
wilander@apple.com [Tue, 12 Mar 2019 02:16:41 +0000 (02:16 +0000)]
Move NetworkProcess/Classifier/ResourceLoadStatisticsStoreCocoa.mm functionality into UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
https://bugs.webkit.org/show_bug.cgi?id=195117
<rdar://problem/48448715>

Reviewed by Brent Fulgham.

Reading of user defaults on Cocoa platforms should be done in the UI process and
forwarded to Resource Load Statistics in the network process through the
WebKit::NetworkSessionCreationParameters struct.

This patch does away with some old user defaults we don't use anymore. It also
changes the developer-facing default name to ITPManualPrevalentResource.

* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore):
    Removed the call to the old registerUserDefaultsIfNeeded().
* NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
(WebKit::ResourceLoadStatisticsMemoryStore::ResourceLoadStatisticsMemoryStore):
    Removed the call to the old registerUserDefaultsIfNeeded().
* NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
    Removed the declaration of the old registerUserDefaultsIfNeeded().
* NetworkProcess/Classifier/ResourceLoadStatisticsStoreCocoa.mm: Removed.
* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
    Added an enum class EnableResourceLoadStatisticsDebugMode.
* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::setResourceLoadStatisticsEnabled):
* NetworkProcess/NetworkSession.h:
* NetworkProcess/NetworkSessionCreationParameters.cpp:
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):
* NetworkProcess/NetworkSessionCreationParameters.h:
   The struct now has two new fields:
   - enableResourceLoadStatisticsDebugMode
   - resourceLoadStatisticsManualPrevalentResource
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
    Forwarding of the parameters.
* SourcesCocoa.txt:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
    Forwarding of the parameters.
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):
    This is where user defaults for Resource Load Statistics are now read.
* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[Synthetic Click] Dispatch mouseout soon after mouseup
zalan@apple.com [Tue, 12 Mar 2019 01:58:17 +0000 (01:58 +0000)]
[Synthetic Click] Dispatch mouseout soon after mouseup
https://bugs.webkit.org/show_bug.cgi?id=195575
<rdar://problem/47093049>

Reviewed by Simon Fraser.

Source/WebCore:

Let's fire a mouseout event when a click is submitted as the result of a tap. It helps to dismiss content which would otherwise require you to move the mouse (cases like control bar on youtube.com).

Test: fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html

* page/EventHandler.h:
* page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::dispatchFakeMouseOut):

Source/WebKit:

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::completeSyntheticClick):

LayoutTests:

* fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click-expected.txt: Added.
* fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoAPI test WebKit.RequestTextInputContext fails on iOS
timothy_horton@apple.com [Tue, 12 Mar 2019 01:53:58 +0000 (01:53 +0000)]
API test WebKit.RequestTextInputContext fails on iOS
https://bugs.webkit.org/show_bug.cgi?id=195585

Reviewed by Wenson Hsieh and Simon Fraser.

Source/WebKit:

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _convertRectFromRootViewCoordinates:]):
(-[WKWebView _convertRectToRootViewCoordinates:]):
(-[WKWebView _requestTextInputContextsInRect:completionHandler:]):
(-[WKWebView _focusTextInputContext:completionHandler:]):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::elementRectInRootViewCoordinates):
(WebKit::WebPage::textInputContextsInRect):
(WebKit::elementRectInWindowCoordinates): Deleted.
Text input context SPI should be in terms of WKWebView coordinates,
for consistency's sake. This is a bit irritating; WebPage(Proxy) continue
to operate in "root view" coordinates, which means different things
depending on if delegatesScrolling is true or not. So, WKWebView does
the conversion, re-creating objects as needed.

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
(applyStyle):
(TEST):
Add a viewport, so that the coordinates match up on iOS.
Scroll by moving the UIScrollView's contentOffset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoREGRESSION: (r242181) API test DragAndDropTests.ExternalSourcePlainTextToIFrame is...
youenn@apple.com [Tue, 12 Mar 2019 01:08:18 +0000 (01:08 +0000)]
REGRESSION: (r242181) API test DragAndDropTests.ExternalSourcePlainTextToIFrame is Timing out
https://bugs.webkit.org/show_bug.cgi?id=195362

Reviewed by Alexey Proskuryakov.

Covered by API test no longer crashing.

* page/SecurityOrigin.cpp:
(WebCore::originsMatch):
String representation should only match if originsMatch returns true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoOptimizing loads when creating new pages
jiewen_tan@apple.com [Tue, 12 Mar 2019 00:57:53 +0000 (00:57 +0000)]
Optimizing loads when creating new pages
https://bugs.webkit.org/show_bug.cgi?id=195516
<rdar://problem/48738086>

Reviewed by Darin Adler.

This patch adds hooks in WebPageProxy::createNewPage to optimize loads, and moves the creationParameters
of API::NavigationAction from UI clients to WebPageProxy::createNewPage. Also, we now pass the whole
API::NavigationAction to the load optimizer instead of the request within.

* UIProcess/API/APINavigationAction.h:
* UIProcess/API/APIUIClient.h:
(API::UIClient::createNewPage):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/API/glib/WebKitUIClient.cpp:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::tryOptimizingLoad):
(WebKit::tryInterceptNavigation):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::createNewPage):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::tryOptimizingLoad):
(WebKit::WebPageProxy::createNewPage):
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[Web GPU] Update GPUSwapChainDescriptor, GPUSwapChain and implement GPUCanvasContext
justin_fan@apple.com [Tue, 12 Mar 2019 00:46:41 +0000 (00:46 +0000)]
[Web GPU] Update GPUSwapChainDescriptor, GPUSwapChain and implement GPUCanvasContext
https://bugs.webkit.org/show_bug.cgi?id=194406
<rdar://problem/47892466>

Reviewed by Myles C. Maxfield.

Source/JavaScriptCore:

Added WebGPU to inspector context types.

* inspector/protocol/Canvas.json:
* inspector/scripts/codegen/generator.py:

Source/WebCore:

GPUSwapChain no longer inherits from GPUBasedRenderingContext, and is now created from a GPUDevice.
WebGPURenderingContext is now GPUCanvasContext and delegates functionality to the GPUSwapChain, if it exists.
GPUQueue now implicitly presents the GPUSwapChain's current drawable at the task boundary, if one exists.
Creating a new GPUSwapChain with the same GPUCanvasContext invalidates the previous one and its drawable and pipeline attachments.
Calling GPUSwapChain::getCurrentTexture returns the same drawable within one task cycle.
Some mentions of "WebGPU" have been renamed to "Web GPU" and "gpu".

All Web GPU tests updated to match.

Add new files and symbols.
* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h:

Rename some mentions of "webgpu" to "gpu".
* Modules/webgpu/DOMWindowWebGPU.cpp:
(WebCore::DOMWindowWebGPU::gpu):
(WebCore::DOMWindowWebGPU::gpu const):
* Modules/webgpu/DOMWindowWebGPU.h:
* Modules/webgpu/DOMWindowWebGPU.idl:

Replace WebGPURenderingContext with GPUCanvasContext.
* Modules/webgpu/GPUCanvasContext.cpp: Renamed from Source/WebCore/Modules/webgpu/WebGPURenderingContext.cpp.
(WebCore::GPUCanvasContext::create):
(WebCore::GPUCanvasContext::GPUCanvasContext):
(WebCore::GPUCanvasContext::replaceSwapChain):
(WebCore::GPUCanvasContext::platformLayer const):
(WebCore::GPUCanvasContext::reshape):
(WebCore::GPUCanvasContext::markLayerComposited):
* Modules/webgpu/GPUCanvasContext.h: Renamed from Source/WebCore/Modules/webgpu/WebGPURenderingContext.h.
* Modules/webgpu/GPUCanvasContext.idl: Renamed from Source/WebCore/Modules/webgpu/WebGPURenderingContext.idl.
* dom/Document.cpp:
(WebCore::Document::getCSSCanvasContext):
* dom/Document.h:
* dom/Document.idl:
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::isWebGPUType):
(WebCore::HTMLCanvasElement::createContextWebGPU):
(WebCore::HTMLCanvasElement::getContextWebGPU):
* html/HTMLCanvasElement.h:
* html/HTMLCanvasElement.idl:
* inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::buildObjectForCanvas):
* inspector/agents/InspectorCanvasAgent.cpp:
(WebCore::contextAsScriptValue):

Update WebGPUSwapChain.
* Modules/webgpu/GPUTextureDescriptor.idl:
* Modules/webgpu/GPUTextureFormat.idl: Add the other two texture formats supported by CAMetalLayer.
* Modules/webgpu/WebGPUDevice.cpp: Implement createSwapChain.
(WebCore::WebGPUDevice::createSwapChain const):
(WebCore::WebGPUDevice::getQueue const):
(WebCore::WebGPUDevice::getQueue): Deleted.
* Modules/webgpu/WebGPUDevice.h:
* Modules/webgpu/WebGPUDevice.idl:
* Modules/webgpu/WebGPUSwapChain.cpp:
(WebCore::WebGPUSwapChain::create):
(WebCore::WebGPUSwapChain::WebGPUSwapChain):
(WebCore::WebGPUSwapChain::getCurrentTexture): Renamed from getNextTexture. Only returns the next drawable if the last was presented.
(WebCore::WebGPUSwapChain::destroy): Invalidate this GPUSwapChain and its textures and views.
(WebCore::WebGPUSwapChain::configure): Deleted.
(WebCore::WebGPUSwapChain::getNextTexture): Deleted.
(WebCore::WebGPUSwapChain::present): Deleted.
(WebCore::WebGPUSwapChain::reshape): Deleted.
(WebCore::WebGPUSwapChain::markLayerComposited): Deleted.
* Modules/webgpu/WebGPUSwapChain.h: Now a device-based object rather than a rendering context.
(WebCore::WebGPUSwapChain::swapChain const):
(WebCore::WebGPUSwapChain::WebGPUSwapChain): Deleted.
* Modules/webgpu/WebGPUSwapChain.idl:
* Modules/webgpu/WebGPUSwapChainDescriptor.h: Added.
* platform/graphics/gpu/GPUDevice.cpp: Implement tryCreateSwapChain.
(WebCore::GPUDevice::tryCreateSwapChain const):
(WebCore::GPUDevice::getQueue const):
(WebCore::GPUDevice::getQueue): Deleted.
* platform/graphics/gpu/GPUDevice.h: Retain a reference to the current GPUSwapChain, if one exists.
(WebCore::GPUDevice::swapChain const):
* platform/graphics/gpu/GPUQueue.h:
* platform/graphics/gpu/GPUSwapChain.h:
(WebCore::GPUSwapChain::destroy):
* platform/graphics/gpu/GPUSwapChainDescriptor.h: Added.
* platform/graphics/gpu/GPUTextureFormat.h: Add the other two texture formats supported by CAMetalLayer.
* platform/graphics/gpu/cocoa/GPUBufferMetal.mm:
(WebCore::GPUBuffer::commandBufferCommitted):
* platform/graphics/gpu/cocoa/GPUQueueMetal.mm:
(WebCore::GPUQueue::tryCreate): Renamed from create to better fit functionality. Now retain a reference to the GPUDevice.
(WebCore::GPUQueue::GPUQueue):
(WebCore::GPUQueue::submit): Now checks state of all resources before marking them as committed or committing any resource.
        In addition, schedules the current drawable to be presented after all commands have been submitted during this task cycle.
* platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:
(WebCore::useAttachments): Ensure that the command buffer is aware of any texture resources used as attachments.
(WebCore::GPURenderPassEncoder::tryCreate):
* platform/graphics/gpu/cocoa/GPUSwapChainMetal.mm:
(WebCore::tryGetSupportedPixelFormat): Supported texture formats are the intersection of Web GPU's texture formats and CAMetalLayer's.
(WebCore::setLayerShape):
(WebCore::tryCreateSwapLayer): Create and configure the CAMetalLayer backing the swap chain.
(WebCore::GPUSwapChain::tryCreate):
(WebCore::GPUSwapChain::GPUSwapChain):
(WebCore::GPUSwapChain::tryGetCurrentTexture): Renamed from getNextTexture. Only returns a texture if the last one was presented.
(WebCore::GPUSwapChain::present):
(WebCore::GPUSwapChain::reshape):
(WebCore::GPUSwapChain::takeDrawable): Swaps out the current drawable so that it can be presented. The GPUSwapChain thus releases its reference to it.
(WebCore::GPUSwapChain::create): Deleted.
(WebCore::GPUSwapChain::setDevice): Deleted.
(WebCore::GPUSwapChain::setFormat): Deleted.
(WebCore::GPUSwapChain::getNextTexture): Deleted.
* platform/graphics/gpu/cocoa/GPUUtilsMetal.mm:
(WebCore::platformTextureFormatForGPUTextureFormat):

Misc:
* Modules/webgpu/WebGPUProgrammablePassEncoder.cpp: Missing include.

Source/WebInspectorUI:

Name updates for Web GPU renaming in inspector.

* UserInterface/Models/Canvas.js:
(WI.Canvas.displayNameForContextType):

LayoutTests:

Update all tests for new WebGPUSwapChain and GPUCanvasContext, and window object name change from 'webgpu' to 'gpu'.
In addition, all tests have been updated to WPT style.

* webgpu/adapter-options.html:
* webgpu/buffer-command-buffer-races.html:
* webgpu/buffer-resource-triangles.html:
* webgpu/command-buffers-expected.txt:
* webgpu/command-buffers.html:
* webgpu/depth-enabled-triangle-strip.html:
* webgpu/js/basic-webgpu-functions.js: Removed. No longer needed.
* webgpu/js/webgpu-functions.js:
(async.getBasicDevice):
(createBasicSwapChain): Renamed from createBasicContext.
(beginBasicRenderPass):
(createBasicContext): Deleted.
(createBasicDepthStateDescriptor): Deleted.
* webgpu/queue-creation.html:
* webgpu/render-command-encoding-expected.txt:
* webgpu/render-command-encoding.html:
* webgpu/render-passes-expected.txt: Removed.
* webgpu/render-passes.html: Removed for redundancy with other tests.
* webgpu/shader-modules-expected.txt:
* webgpu/shader-modules.html:
* webgpu/simple-triangle-strip.html:
* webgpu/texture-triangle-strip.html:
* webgpu/textures-textureviews.html:
* webgpu/vertex-buffer-triangle-strip.html:
* webgpu/webgpu-basics-expected.txt: Removed.
* webgpu/webgpu-basics.html: Removed for redundancy with other tests.
* webgpu/webgpu-enabled-expected.txt:
* webgpu/webgpu-enabled.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[iOS WK2] REGRESSION (r242687): Programmatic scroll of overflow scroll results in...
simon.fraser@apple.com [Tue, 12 Mar 2019 00:11:23 +0000 (00:11 +0000)]
[iOS WK2] REGRESSION (r242687): Programmatic scroll of overflow scroll results in bad rendering
https://bugs.webkit.org/show_bug.cgi?id=195584

Unreviewed test gardening. Mark compositing/ios/overflow-scroll-update-overlap.html as failing
since I want to unskip and land a fix with additional tests.

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months ago[iOS] Implement a faster click detection that intercepts double-tap-to-zoom if possible
dino@apple.com [Mon, 11 Mar 2019 23:43:04 +0000 (23:43 +0000)]
[iOS] Implement a faster click detection that intercepts double-tap-to-zoom if possible
https://bugs.webkit.org/show_bug.cgi?id=195473
<rdar://problem/48718396>

Reviewed by Wenson Hsieh (with some help from Dan Bates).

Source/WebKit:

Adds a new algorithm, behind a flag FasterClicksEnabled, that can trigger a click
event without waiting to see if a double tap will occur. It does this by examining
the amount of zoom that would be triggered if it was a double tap, and if that value
doesn't exceed a set threshold, commits to the click event instead.

This is implemented by having the Web Process respond to the potential click with
some geometry information. If the UI Process receives the information before the
second tap in a double tap, it can decide to trigger a click.

* Shared/WebPreferences.yaml: New internal feature so this can be toggled in
    a UI for testing.

* SourcesCocoa.txt: Renamed WKSyntheticTapGestureRecognizer.
* WebKit.xcodeproj/project.pbxproj: Ditto.

* UIProcess/ios/WKSyntheticTapGestureRecognizer.h:
* UIProcess/ios/WKSyntheticTapGestureRecognizer.m:
(-[WKSyntheticTapGestureRecognizer setGestureIdentifiedTarget:action:]):
(-[WKSyntheticTapGestureRecognizer setGestureFailedTarget:action:]):
(-[WKSyntheticTapGestureRecognizer setResetTarget:action:]):
(-[WKSyntheticTapGestureRecognizer setState:]):
(-[WKSyntheticTapGestureRecognizer reset]):  Renamed WKSyntheticClickTapGestureRecognizer to
    WKSyntheticTapGestureRecognizer, changed the signature of the main function to be a bit
    more clear about what it does, and added a gesture failed target.

* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initialScaleFactor]):
(-[WKWebView _contentZoomScale]):
(-[WKWebView _targetContentZoomScaleForRect:currentScale:fitEntireRect:minimumScale:maximumScale:]):
    Exposed the initial content scale, the current scale and added a declaration that
    was missing from the .h.

* UIProcess/WebPageProxy.messages.in: Add a new message,
    HandleSmartMagnificationInformationForPotentialTap, to
    communicate the geometry of the clicked node to the UI Process.

* UIProcess/PageClient.h: Pure virtual function for the geometry message response.
* UIProcess/WebPageProxy.h: Ditto.

* UIProcess/ios/PageClientImplIOS.h: Calls into the WKContentView.
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::handleSmartMagnificationInformationForPotentialTap):

* UIProcess/ios/SmartMagnificationController.h:
* UIProcess/ios/SmartMagnificationController.mm:
(WebKit::SmartMagnificationController::calculatePotentialZoomParameters): A new method that
    asks the WKContentView to work out what the zoom factor will be for a potential double
    tap at a location.
(WebKit::SmartMagnificationController::smartMagnificationTargetRectAndZoomScales): New implementation
    of this function to avoid multiple out-arguments.

* UIProcess/ios/WKContentView.h:
* UIProcess/ios/WKContentView.mm:
(-[WKContentView _initialScaleFactor]):
(-[WKContentView _contentZoomScale]):
(-[WKContentView _targetContentZoomScaleForRect:currentScale:fitEntireRect:minimumScale:maximumScale:]):
    Exposed the initial content scale, the current scale and the target zoom scale. These
    all just call into the WKWebView implementation.

* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _createAndConfigureDoubleTapGestureRecognizer]): Use a WKSyntheticTapGestureRecognizer instead
    of a generic one, so we can capture the failure.
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _handleSmartMagnificationInformationForPotentialTap:origin:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:]):
    New method that responds to the incoming Web Process message, and decides if any
    potential zoom would be "significant".
(-[WKContentView _singleTapIdentified:]):
(-[WKContentView _doubleTapDidFail:]):
(-[WKContentView _didCompleteSyntheticClick]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _doubleTapRecognized:]):
    Add some release logging.
(-[WKContentView _singleTapCommited:]): Deleted.

* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::potentialTapAtPosition):
(WebKit::WebPageProxy::handleSmartMagnificationInformationForPotentialTap):
* WebProcess/WebPage/ViewGestureGeometryCollector.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
    Removed an unused parameter from the existing message.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::potentialTapAtPosition): Calculates the geometry of the element
if requested, and sends it to the UIProcess.

LayoutTests:

Implement a test (iPad only) that sets up a page with zoomable content
but not quite at a significant scale, meaning we should dispatch a click
event rather than Double Tap To Zoom.

In order to do this, a humanSpeedDoubleTapAt() method was added to
UIHelper that sleeps a bit between taps, otherwise the double tap
gesture is recognized before the Web Process has had a chance to
evaluate the potential click.

* fast/events/ios/ipad/fast-click-double-tap-sends-click-on-insignificant-zoom-expected.txt: Added.
* fast/events/ios/ipad/fast-click-double-tap-sends-click-on-insignificant-zoom.html: Added.
* platform/ios/TestExpectations:
* platform/ipad/TestExpectations:
* resources/ui-helper.js:
(window.UIHelper.humanSpeedDoubleTapAt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoUnreviewed build fix after r242745.
pvollan@apple.com [Mon, 11 Mar 2019 23:36:14 +0000 (23:36 +0000)]
Unreviewed build fix after r242745.

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoAssert in WebPageProxy::suspendCurrentPageIfPossible()
cdumez@apple.com [Mon, 11 Mar 2019 23:31:23 +0000 (23:31 +0000)]
Assert in WebPageProxy::suspendCurrentPageIfPossible()
https://bugs.webkit.org/show_bug.cgi?id=195506
<rdar://problem/48733477>

Reviewed by Alex Christensen.

Source/WebKit:

The crash was caused by the top-hit preloading logic in MobileSafari which creates a new Web view that is *related*
to the previous one, restores the session state onto it and then triggers a load in this new Web view.

Initially, the 2 Web views use the same process as they are related. However, if the new load's URL is cross-site
with regards to the first view's URL, then we decide to process swap in the new view. This process swap makes
sense from a security standpoint. However, when we commit the load in the new process and call
suspendCurrentPageIfPossible() we end up in an unexpected state because we have a fromItem (due to the session
state having been restored on the new view) but we haven't committed any load yet in this new view.

To address the issue, suspendCurrentPageIfPossible() now returns early and does not attempt to suspend anything
if we have not committed any load yet.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::suspendCurrentPageIfPossible):
Do not attempt to suspend to current page if we have not committed any provisional load yet.

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 months agoAdding myself to contributors.json
sroberts@apple.com [Mon, 11 Mar 2019 23:30:38 +0000 (23:30 +0000)]
Adding myself to contributors.json

Unreviewed, addming myself to contributors.json .

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242754 268f45cc-cd09-0410-ab3c-d52691b4dbfc