WebKit-https.git
10 years ago[Chromium] Unreviewed update of test expectations.
dimich@chromium.org [Tue, 2 Nov 2010 21:13:33 +0000 (21:13 +0000)]
[Chromium] Unreviewed update of test expectations.
Move the expected file higher up so it's used for all chromium flavors.

* platform/chromium/security/block-test-no-port-expected.txt: Renamed from LayoutTests/platform/chromium-mac/security/block-test-no-port-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Jenn Braithwaite <jennb@chromium.org>
commit-queue@webkit.org [Tue, 2 Nov 2010 21:05:12 +0000 (21:05 +0000)]
2010-11-02  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Andreas Kling.

        fast/frames/iframe-reparenting-new-page.html output is ordered wrong
        https://bugs.webkit.org/show_bug.cgi?id=48807

        * fast/frames/iframe-reparenting-new-page-expected.txt:
        * fast/frames/script-tests/iframe-reparenting-new-page.js:
        (finish):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8346191> and https://bugs.webkit.org/show_bug.cgi?id=48868
beidson@apple.com [Tue, 2 Nov 2010 21:02:23 +0000 (21:02 +0000)]
<rdar://problem/8346191> and https://bugs.webkit.org/show_bug.cgi?id=48868
Implement IMutableWebRequest::setTimeoutInterval

Reviewed by Anders Carlsson.

* WebMutableURLRequest.cpp:
(WebMutableURLRequest::setTimeoutInterval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-28 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 2 Nov 2010 21:01:45 +0000 (21:01 +0000)]
2010-10-28  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Update getUniform for bvec[234] to return boolean[] rather than Uint8Array
        https://bugs.webkit.org/show_bug.cgi?id=47568

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getUniform):
2010-10-28  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Update getUniform for bvec[234] to return boolean[] rather than Uint8Array
        https://bugs.webkit.org/show_bug.cgi?id=47568

        * fast/canvas/webgl/gl-object-get-calls-expected.txt:
        * fast/canvas/webgl/gl-object-get-calls.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Chris Rogers <crogers@google.com>
crogers@google.com [Tue, 2 Nov 2010 20:53:33 +0000 (20:53 +0000)]
2010-11-02  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add RealtimeAnalyserNode files
        https://bugs.webkit.org/show_bug.cgi?id=48798

        No new tests since audio API is not yet implemented.

        * webaudio/RealtimeAnalyserNode.cpp: Added.
        (WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode):
        (WebCore::RealtimeAnalyserNode::~RealtimeAnalyserNode):
        (WebCore::RealtimeAnalyserNode::process):
        (WebCore::RealtimeAnalyserNode::pullInputs):
        (WebCore::RealtimeAnalyserNode::reset):
        * webaudio/RealtimeAnalyserNode.h: Added.
        (WebCore::RealtimeAnalyserNode::create):
        (WebCore::RealtimeAnalyserNode::fftSize):
        (WebCore::RealtimeAnalyserNode::setFftSize):
        (WebCore::RealtimeAnalyserNode::frequencyBinCount):
        (WebCore::RealtimeAnalyserNode::setMinDecibels):
        (WebCore::RealtimeAnalyserNode::minDecibels):
        (WebCore::RealtimeAnalyserNode::setMaxDecibels):
        (WebCore::RealtimeAnalyserNode::maxDecibels):
        (WebCore::RealtimeAnalyserNode::setSmoothingTimeConstant):
        (WebCore::RealtimeAnalyserNode::smoothingTimeConstant):
        (WebCore::RealtimeAnalyserNode::getFloatFrequencyData):
        (WebCore::RealtimeAnalyserNode::getByteFrequencyData):
        (WebCore::RealtimeAnalyserNode::getByteTimeDomainData):
        * webaudio/RealtimeAnalyserNode.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 2 Nov 2010 20:48:40 +0000 (20:48 +0000)]
2010-11-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r71152.
        http://trac.webkit.org/changeset/71152
        https://bugs.webkit.org/show_bug.cgi?id=48866

        Causes lots and lots of crashes (Requested by jamesr_ on
        #webkit).

        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageReader::JPEGImageReader):
        (WebCore::JPEGImageReader::decode):
        (WebCore::JPEGImageDecoder::outputScanlines):
        * platform/image-decoders/jpeg/JPEGImageDecoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Tue, 2 Nov 2010 20:47:18 +0000 (20:47 +0000)]
2010-11-02  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        When animations are paused, play-state can cause them to be unpaused.
        https://bugs.webkit.org/show_bug.cgi?id=46525

        I Changed updatePlayState() to only unpause when both play-state is
        "running" and not suspended. Likewise I pause animation when either
        play-state is "paused" or suspended.

        Test: animations/play-state-suspend.html

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::updatePlayState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Benjamin Kalman <kalman@google.com>
commit-queue@webkit.org [Tue, 2 Nov 2010 20:42:48 +0000 (20:42 +0000)]
2010-11-02  Benjamin Kalman  <kalman@google.com>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=48794

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Strip the "LayoutTests/" prefix from test argument paths.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Timothy Hatcher.
ap@apple.com [Tue, 2 Nov 2010 20:34:16 +0000 (20:34 +0000)]
    Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=48813
        <rdar://problem/8602552> REGRESSION (r63622): DNS prefetching for <link> tags doesn't work
        in non-HTTP documents

        Cannot test DNS prefetching.

        * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): We should be looking at
        preferences, not at whether this document has prefetching enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Tue, 2 Nov 2010 20:30:33 +0000 (20:30 +0000)]
2010-11-02  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Kent Tamura.

        Expose the sendChangeEvent parameter in WebInputElement::setValue() API,
        primarily so that chromium form autofill can fire the onChange event.
        https://bugs.webkit.org/show_bug.cgi?id=48177

        * public/WebInputElement.h:
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::setValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unreviewed update of test expectations.
dimich@chromium.org [Tue, 2 Nov 2010 20:28:18 +0000 (20:28 +0000)]
[Chromium] Unreviewed update of test expectations.
Intentional error result to narrow down a regression caused by http://codereview.chromium.org/3976004

* platform/chromium-mac/security/block-test-no-port-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd some support for remote and local NPObjects to NPRemoteObjectMap
andersca@apple.com [Tue, 2 Nov 2010 20:24:26 +0000 (20:24 +0000)]
Add some support for remote and local NPObjects to NPRemoteObjectMap
https://bugs.webkit.org/show_bug.cgi?id=48864

Reviewed by Adam Roben.

* Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
If the NPVariant contains an NPObject that isn't an NPObjectProxy, register it
and return its ID.

(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):
If the NPVariantData contains a remote object, create an NPObjectProxy and return it.

* Shared/Plugins/NPVariantData.cpp:
(WebKit::NPVariantData::NPVariantData):
Initialize m_localNPObjectIDValue and m_remoteNPObjectIDValue.

(WebKit::NPVariantData::makeLocalNPObjectID):
Create an NPVariantData that contains a local NPObject ID.

(WebKit::NPVariantData::encode):
Handle local and remote NPObject IDs.

(WebKit::NPVariantData::decode):
Decode local and remote NPObject IDs and "swap them" so an encoded remote NPObject ID is
decoded as a local NPObjectID (and vice versa).

* Shared/Plugins/NPVariantData.h:
(WebKit::NPVariantData::localNPObjectIDValue):
(WebKit::NPVariantData::remoteNPObjectIDValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix after r71127
aroben@apple.com [Tue, 2 Nov 2010 19:52:09 +0000 (19:52 +0000)]
Windows build fix after r71127

MSVC isn't smart enough to figure out that the definition of the global
nullptr variable isn't needed, so we provide one for it.

Fixes <http://webkit.org/b/48862> Windows build is broken due to
undefined symbol nullptr

Reviewed by Anders Carlsson.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export nullptr.

* JavaScriptCore.vcproj/WTF/WTF.vcproj: Added NullPtr.cpp and let VS
resort the files.

* wtf/NullPtr.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 2 Nov 2010 19:51:39 +0000 (19:51 +0000)]
2010-11-02  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: Web Inspector: follow up to r71139. Fixed Mac monospace
        height style.

        * inspector/front-end/PropertiesSection.js:
        (WebInspector.PropertiesSection):
        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 2 Nov 2010 19:45:33 +0000 (19:45 +0000)]
2010-11-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        JPEG decoders should understand color profiles
        https://bugs.webkit.org/show_bug.cgi?id=48819

        This patch is currently a no-op because no one defines USE(ICCJPEG).
        We'll enable this for Chromium Mac once we have ICCJPEG landed in
        Chromium's third_party directory.

        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::readColorProfile):
        (WebCore::JPEGImageReader::JPEGImageReader):
        (WebCore::JPEGImageReader::decode):
        (WebCore::JPEGImageDecoder::outputScanlines):
        * platform/image-decoders/jpeg/JPEGImageDecoder.h:
        (WebCore::JPEGImageDecoder::setColorProfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 2 Nov 2010 19:39:30 +0000 (19:39 +0000)]
2010-11-02  James Robinson  <jamesr@chromium.org>

        Update pixel baselines for Snow Leopard for tests in fast/text/*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Tue, 2 Nov 2010 19:37:01 +0000 (19:37 +0000)]
2010-11-02  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Simon Fraser.

        Marks selectionStart() and selectionEnd() as const.
        https://bugs.webkit.org/show_bug.cgi?id=48786

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLTextFormControlElement::selectionStart):
        (WebCore::HTMLTextFormControlElement::selectionEnd):
        * html/HTMLFormControlElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Chris Rogers <crogers@google.com>
crogers@google.com [Tue, 2 Nov 2010 19:29:51 +0000 (19:29 +0000)]
2010-11-02  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Fix license for audio files
        https://bugs.webkit.org/show_bug.cgi?id=48859

        * webaudio/AudioChannelSplitter.cpp:
        * webaudio/AudioChannelSplitter.h:
        * webaudio/AudioDestinationNode.cpp:
        * webaudio/AudioDestinationNode.h:
        * webaudio/AudioGainNode.cpp:
        * webaudio/AudioGainNode.h:
        * webaudio/AudioPannerNode.cpp:
        * webaudio/AudioPannerNode.h:
        * webaudio/AudioPannerNode.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 2 Nov 2010 19:20:37 +0000 (19:20 +0000)]
2010-11-02  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        Remove special handling of HashTableDeletedValue in PlatformRefPtr and manually manage memory that cannot be controlled by HashTraits
        https://bugs.webkit.org/show_bug.cgi?id=48841

        Remove special handling of HashTableDeletedValue in PlatformRefPtr.
        This is better handled on a case-by-case basis, when HashTraits
        cannot account for it.

        * wtf/PlatformRefPtr.h:
        (WTF::PlatformRefPtr::~PlatformRefPtr):
        (WTF::PlatformRefPtr::clear):
        (WTF::::operator):
2010-11-02  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        Remove special handling of HashTableDeletedValue in PlatformRefPtr and manually manage memory that cannot be controlled by HashTraits
        https://bugs.webkit.org/show_bug.cgi?id=48841

        Switch to manually managing the memory in FontPlatformDataFreeType. This
        is necessary because smart pointers do not know how to deal with a pointer
        value of -1 (HashTableDeletedValue) and HashTraits can only manage the type
        contained in the HashMap.

        No new tests as this should not change functionality.

        * platform/graphics/cairo/FontPlatformDataFreeType.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::operator=):
        (WebCore::FontPlatformData::~FontPlatformData):
        (WebCore::FontPlatformData::operator==):
        (WebCore::FontPlatformData::initializeWithFontFace):
        * platform/graphics/cairo/FontPlatformDataFreeType.h:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::scaledFont):
        (WebCore::FontPlatformData::hash):
        (WebCore::FontPlatformData::isHashTableDeletedValue):
        (WebCore::FontPlatformData::hashTableDeletedFontValue):
        * platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp:
        (WebCore::GlyphPage::fill):
        * platform/graphics/cairo/SimpleFontDataCairo.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::containsCharacters):
        (WebCore::SimpleFontData::platformWidthForGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 2 Nov 2010 19:15:19 +0000 (19:15 +0000)]
2010-11-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        querySelectorAll('body>:last-child') does not work unless HTML file ends with 'new-line'.
        https://bugs.webkit.org/show_bug.cgi?id=47166

        We need to pop all the open elements when we end the document in the
        AfterAfterBody state.

        Test: fast/parser/pop-all-after-after-body.html

        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processEndOfFile):
2010-11-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        querySelectorAll('body>:last-child') does not work unless HTML file ends with 'new-line'.
        https://bugs.webkit.org/show_bug.cgi?id=47166

        Test that :last-child works when we end the document in the
        AfterAfterBody state.

        * fast/parser/pop-all-after-after-body-expected.txt: Added.
        * fast/parser/pop-all-after-after-body.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip webkitpy.layout_tests.run_webkit_tests_unittest.MainTest on Cygwin Python 2.5.x
aroben@apple.com [Tue, 2 Nov 2010 19:08:40 +0000 (19:08 +0000)]
Skip webkitpy.layout_tests.run_webkit_tests_unittest.MainTest on Cygwin Python 2.5.x

It is known to hang on that version of Python. See
<http://webkit.org/b/48614>.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Use
skip_if to skip MainTest on Cygwin Python 2.5.x.

* Scripts/webkitpy/test/skip.py: Added.
(skip_if): If the passed-in condition is false, find all the test_*
methods of the given class and replace them with a function that just
logs that we're skipping these tests. This is loosely based on the
unittest.skip_if decorator added in Python 3.1.
(_skipped_method): Returns a function that just logs that the tests are
being skipped. This is used in place of the actual test_* functions.

* Scripts/webkitpy/test/skip_unittest.py: Added.
(SkipTest.setUp): Create a logger for ourselves and give it a handler
that logs to a private stream.
(SkipTest.tearDown): Reset the logger.
(SkipTest.create_fixture_class): Returns a class that we use to test
skip_if. It has a single test_* method, test_foo, that just calls
through to a callback.
(SkipTest.foo_callback): Record that test_foo was called.
(SkipTest.test_skip_if_false): Pass skip_if a False condition and test
that test_foo does get called.
(SkipTest.test_skip_if_true): Pass skip_if a True condition and test
that test_foo does not get called and the appropriate message gets
logged.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 2 Nov 2010 19:07:32 +0000 (19:07 +0000)]
2010-11-02  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Cleanup createGlobalImageFileDescriptor in ClipboardWin
        https://bugs.webkit.org/show_bug.cgi?id=48189

        * platform/win/ClipboardWin.cpp:
        (WebCore::ClipboardWin::writeURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 2 Nov 2010 19:00:41 +0000 (19:00 +0000)]
2010-11-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: display frame names in the resources panel.
        https://bugs.webkit.org/show_bug.cgi?id=48839

        * inspector/Inspector.idl:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::frameId):
        (WebCore::buildObjectForDocumentLoader):
        (WebCore::buildObjectForFrame):
        (WebCore::buildObjectForFrameTree):
        (WebCore::InspectorResourceAgent::didCommitLoad):
        (WebCore::InspectorResourceAgent::frameDetachedFromParent):
        (WebCore::InspectorResourceAgent::frameForId):
        (WebCore::InspectorResourceAgent::resourceContent):
        * inspector/InspectorResourceAgent.h:
        * inspector/front-end/ResourceManager.js:
        (WebInspector.ResourceManager.prototype.didCommitLoadForFrame):
        (WebInspector.ResourceManager.prototype._processCachedResources):
        (WebInspector.ResourceManager.prototype._addFramesRecursively):
        (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame):
        (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel.prototype.addOrUpdateFrame):
        (WebInspector.BaseStorageTreeElement.prototype.get titleText):
        (WebInspector.FrameTreeElement):
        (WebInspector.FrameTreeElement.prototype.onattach):
        (WebInspector.FrameTreeElement.prototype.get nameForSorting):
        (WebInspector.FrameTreeElement.prototype.setTitles):
        (WebInspector.FrameTreeElement.prototype.set hovered):
        * inspector/front-end/inspector.css:
        (li.selected .base-storage-tree-element-subtitle):
        (.base-storage-tree-element-subtitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 2 Nov 2010 18:50:48 +0000 (18:50 +0000)]
2010-11-02  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Follow up to r71139: removing unused images.
        https://bugs.webkit.org/show_bug.cgi?id=48827

        * WebCore.gypi:
        * inspector/front-end/Images/grayConnectorPoint.png: Removed.
        * inspector/front-end/Images/whiteConnectorPoint.png: Removed.
        * inspector/front-end/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 2 Nov 2010 18:48:29 +0000 (18:48 +0000)]
2010-11-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        webkit-patch should tell check-webkit-style which files were changed so
        check-webkit-style doesn't have to stat the whole working copy again
        https://bugs.webkit.org/show_bug.cgi?id=48792

        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/checkstyle.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAttempt to fix a GCC release only warning.
andersca@apple.com [Tue, 2 Nov 2010 18:40:13 +0000 (18:40 +0000)]
Attempt to fix a GCC release only warning.

* Shared/Plugins/NPVariantData.cpp:
(WebKit::NPVariantData::NPVariantData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInvalidate the NPRemoteObjectMap
andersca@apple.com [Tue, 2 Nov 2010 18:39:05 +0000 (18:39 +0000)]
Invalidate the NPRemoteObjectMap
https://bugs.webkit.org/show_bug.cgi?id=48856

Reviewed by John Sullivan.

* Shared/Plugins/NPObjectMessageReceiver.cpp:
(WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
Remove FIXME. The NPRemoteObjectMap always outlives the NPObjectMessageReceiver.

* Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::~NPObjectProxy):
Call npObjectProxyDestroyed here.

(WebKit::NPObjectProxy::invalidate):
Null out m_npRemoteObjectMap.

* Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::~NPRemoteObjectMap):
Add assertions.

(WebKit::NPRemoteObjectMap::createNPObjectProxy):
Keep track of the NPObjectProxy by adding it to the m_npObjectProxies set.

(WebKit::NPRemoteObjectMap::npObjectProxyDestroyed):
Remove the NPObjectProxy from the m_npObjectProxies set.

(WebKit::NPRemoteObjectMap::invalidate):
Delete all NPObjectMessageReceivers. Iterate over all NPObjectProxy objects and invalidate them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 2 Nov 2010 18:31:44 +0000 (18:31 +0000)]
2010-11-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: make properties and event listeners look consistent with the styles section.
        https://bugs.webkit.org/show_bug.cgi?id=48827

        * inspector/front-end/EventListenersSidebarPane.js:
        * inspector/front-end/PropertiesSection.js:
        (WebInspector.PropertiesSection):
        * inspector/front-end/PropertiesSidebarPane.js:
        (WebInspector.PropertiesSidebarPane.prototype.update.callback):
        (WebInspector.PropertiesSidebarPane.prototype.update):
        * inspector/front-end/inspector.css:
        (.events-pane .section:not(:nth-of-type(1))):
        (.event-bar:first-child):
        (.section .header):
        (.section .header::before):
        (.section.expanded .header::before):
        (.section .header .title, .event-bar .header .title):
        (.section .header .subtitle, .event-bar .header .subtitle):
        (.section.expanded .properties, .event-bar.expanded .event-properties):
        (.properties-tree):
        (.event-bar):
        (.event-bars .event-bar .header):
        (.event-bars .event-bar .header .title):
        (.event-bars .event-bar .header::before):

2010-11-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: make properties and event listeners look consistent with the styles section.
        https://bugs.webkit.org/show_bug.cgi?id=48827

        * src/js/devTools.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unused methods and member variables from AutoTableLayout.
mitz@apple.com [Tue, 2 Nov 2010 18:20:25 +0000 (18:20 +0000)]
Remove unused methods and member variables from AutoTableLayout.

Reviewed by Anders Carlsson.

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::AutoTableLayout): Removed initialization of m_percentagesDirty
and m_totalPercent.
(WebCore::AutoTableLayout::fullRecalc): Removed setting of m_percentagesDirty.
(WebCore::AutoTableLayout::calcPercentages): Removed.
* rendering/AutoTableLayout.h: Removed totalPercent(), m_percentagesDirty, and m_totalPercent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Robert Kroeger <rjkroege@chromium.org>
commit-queue@webkit.org [Tue, 2 Nov 2010 18:15:52 +0000 (18:15 +0000)]
2010-11-02  Robert Kroeger  <rjkroege@chromium.org>

        Reviewed by James Robinson.

        [Chromium/DRT] Make EventSendingController honour leapForward for touch events.
        https://bugs.webkit.org/show_bug.cgi?id=48777

        * DumpRenderTree/chromium/EventSender.cpp:
        (EventSender::sendCurrentTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 2 Nov 2010 18:12:18 +0000 (18:12 +0000)]
2010-11-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: clear / hide timing information for cached resources.
        https://bugs.webkit.org/show_bug.cgi?id=48848

        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype.set cached):
        (WebInspector.Resource.prototype.get timing):
        (WebInspector.Resource.prototype.set timing):
        * inspector/front-end/ResourceManager.js:
        (WebInspector.ResourceManager.prototype.markResourceAsCached):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebProcessManager informed about crashes too late (pages may have already tried to...
mthole@apple.com [Tue, 2 Nov 2010 18:11:46 +0000 (18:11 +0000)]
WebProcessManager informed about crashes too late (pages may have already tried to load a new URL)
https://bugs.webkit.org/show_bug.cgi?id=48853

Reviewed by Anders Carlsson.

This also fixes: <rdar://problem/8610451> Webkit2: Crash in WebKit!WebKit::WebProcessProxy::sendMessage opening google.com page

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::~WebProcessProxy):
Removed invalid assertion that is hit when the WebProcess dies unexpectedly.
(WebKit::WebProcessProxy::didClose):
Reordered so that the individual pages are informed that the processDidCrash() after the shared
WebProcessManager has been. This allows the pages to properly trigger a new process to be launched.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 2 Nov 2010 18:10:11 +0000 (18:10 +0000)]
2010-11-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: improve network's 'preview close' usability.
        https://bugs.webkit.org/show_bug.cgi?id=48846

        * inspector/front-end/networkPanel.css:
        (#network-close-button:hover):
        (#network-close-button:active):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 2 Nov 2010 18:08:27 +0000 (18:08 +0000)]
2010-11-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Image heights are displayed as 0.
        https://bugs.webkit.org/show_bug.cgi?id=40817

        * inspector/front-end/ImageView.js:
        (WebInspector.ImageView.prototype.contentTabSelected):
        (WebInspector.ImageView.prototype.contentTabSelected.onImageLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHandle boolean values in NPVariant and NPVariantData
andersca@apple.com [Tue, 2 Nov 2010 18:01:17 +0000 (18:01 +0000)]
Handle boolean values in NPVariant and NPVariantData
https://bugs.webkit.org/show_bug.cgi?id=48852

Reviewed by John Sullivan.

* Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):
* Shared/Plugins/NPVariantData.cpp:
(WebKit::NPVariantData::makeBool):
(WebKit::NPVariantData::encode):
(WebKit::NPVariantData::decode):
* Shared/Plugins/NPVariantData.h:
(WebKit::NPVariantData::boolValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=48814
adele@apple.com [Tue, 2 Nov 2010 17:59:04 +0000 (17:59 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=48814
<rdar://problem/8546143> Attempting to redo typing in apple.com/startpage search field causes infinite recursion in TextControlInnerTextElement::defaultEventHandler

Reviewed by Kent Tamura.

Test: editing/undo/redo-after-detach.html

* rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerTextElement::defaultEventHandler):
A TextControlInnerTextElement will almost always have a shadowAncestorNode, the HTMLInputElement.  In this case,
after the renderer was destroyed, this shadow node was kept alive by the EditCommand, even though its not hooked up
anymore to the shadow DOM.  EditCommands can sometimes operate on stale selections and are expected to fail silently.
So here we prevent the infinite loop during event dispatch, and the rest of the redo operation will fail silently.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=48814
<rdar://problem/8546143> Attempting to redo typing in apple.com/startpage search field causes infinite recursion in TextControlInnerTextElement::defaultEventHandler

Reviewed by Kent Tamura.

* editing/undo/redo-after-detach-expected.txt: Added.
* editing/undo/redo-after-detach.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Repeated cmd-key presses lead to unusable UI state
enrica@apple.com [Tue, 2 Nov 2010 17:55:38 +0000 (17:55 +0000)]
WebKit2: Repeated cmd-key presses lead to unusable UI state
https://bugs.webkit.org/show_bug.cgi?id=48811
<rdar://problem/8611924>

Reviewed by Alexey Proskuryakov.

Given the asynchronous nature of every interaction with the WebProcess,
we could re-send a keyDown event to AppKit that maps to an
action that is currently disabled and therefore will not trigger an action
but a call to the keyDown method of the NSView. We need to detect this
situation to avoid an infinite loop.

* UIProcess/API/mac/WKView.mm:
(-[WKView performKeyEquivalent:]): Delay the release of the last processed event
to the moment we receive another event.
(-[WKView keyDown:]): Added early return in case the event is one we have re-sent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAssertion hit in WebProcessProxy::~WebProcessProxy()
andersca@apple.com [Tue, 2 Nov 2010 17:51:16 +0000 (17:51 +0000)]
Assertion hit in WebProcessProxy::~WebProcessProxy()
https://bugs.webkit.org/show_bug.cgi?id=48849
<rdar://problem/8617676>

Reviewed by John Sullivan.

It is perfectly valid for the page map to contain pages if the web process proxy
goes away, this can happen if the process crashes for example.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::~WebProcessProxy):
Remove the assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Christian Sejersen <christian.webkit@gmail.com>
commit-queue@webkit.org [Tue, 2 Nov 2010 17:35:11 +0000 (17:35 +0000)]
2010-11-02  Christian Sejersen  <christian.webkit@gmail.com>

        Reviewed by Andreas Kling.

        The previous patch only took into account arm targets. This one
        now checks whether the build is done inside Scratchbox.
        https://bugs.webkit.org/show_bug.cgi?id=47895

        * DerivedSources.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore NPRuntime work
andersca@apple.com [Tue, 2 Nov 2010 17:26:02 +0000 (17:26 +0000)]
More NPRuntime work
https://bugs.webkit.org/show_bug.cgi?id=48847

Reviewed by Adam Roben.

* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::~WebProcessConnection):
Add assertions.

(WebKit::WebProcessConnection::removePluginControllerProxy):
If we have no more plug-in controller proxies, invalidate the remote object map.

* Shared/Plugins/NPIdentifierData.cpp:
(WebKit::NPIdentifierData::createNPIdentifier):
Create an NPIdentifier from the given NPIdentifierData.

* Shared/Plugins/NPObjectMessageReceiver.cpp:
(WebKit::NPObjectMessageReceiver::create):
(WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
This now takes the NPRemoteObjectMap as well as the npObjectID of the object.

(WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
Unregister the object.

(WebKit::NPObjectMessageReceiver::deallocate):
Delete the object.

(WebKit::NPObjectMessageReceiver::getProperty):
Ask the NPObject for the property and convert it back to an NPVariantData.

* Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::~NPObjectProxy):
Send a Deallocate message to the corresponding message receiver on the other side.

(WebKit::NPObjectProxy::getProperty):
Convert the NPVariantData back to an NPVariant and return it.

* Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::registerNPObject):
Pass the NPRemoteObjectMap and the npObjectID to NPObjectMessageReceiver::create.

(WebKit::NPRemoteObjectMap::unregisterNPObject):
Remove the given object from the map of registered objects.

(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
Given an NPVariant, create an NPVariantData. Only supports void and double types right now.

(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):
Given an NPVariantData, create an NPVariant. Only supports void and double types right now.

(WebKit::NPRemoteObjectMap::invalidate):
Add stub.

* Shared/Plugins/NPVariantData.cpp:
(WebKit::NPVariantData::NPVariantData):
Set the type to void by default.

(WebKit::NPVariantData::makeVoid):
Return a void NPVariantData.

(WebKit::NPVariantData::makeDouble):
Return an NPVariantData that contains a double value.

(WebKit::NPVariantData::encode):
Encode the NPVariantData.

(WebKit::NPVariantData::decode):
Decode the NPVariantData.

* Shared/Plugins/NPVariantData.h:
(WebKit::NPVariantData::type):
Return the type of the NPVariantData.

(WebKit::NPVariantData::doubleValue):
Return the double value of the NPVariantData.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didClose):
Use nullptr instead of 0.

* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::~PluginProcessConnection):
Assert that the connection and the remote object map are both null.

(WebKit::PluginProcessConnection::removePluginProxy):
If this was the last plug-in proxy, invalidate the remote object map.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shutdown):
Use nullptr instead of 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip another test that fails in WebKit2
aroben@apple.com [Tue, 2 Nov 2010 17:25:59 +0000 (17:25 +0000)]
Skip another test that fails in WebKit2

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Tue, 2 Nov 2010 17:19:58 +0000 (17:19 +0000)]
2010-11-02  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Adam Roben.

        Make RenderStyle::playState() return typed value and cleanup naming in Animation code
        https://bugs.webkit.org/show_bug.cgi?id=48844

        playState() function was returning unsigned value, but there is a EAnimPlayState
        enum type which has the legal playState values. This type is now used everywhere.
        I also changed the naming of the m_isSuspended to m_suspended to match the style
        elsewhere in the code.

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::updatePlayState):
        * page/animation/AnimationBase.h:
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::clear):
        (WebCore::AnimationControllerPrivate::updateAnimationTimer):
        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::updateKeyframeAnimations):
        (WebCore::CompositeAnimation::suspendAnimations):
        (WebCore::CompositeAnimation::resumeAnimations):
        * page/animation/CompositeAnimation.h:
        (WebCore::CompositeAnimation::suspended):
        (WebCore::CompositeAnimation::CompositeAnimation):
        * platform/animation/Animation.h:
        (WebCore::Animation::playState):
        (WebCore::Animation::setPlayState):
        (WebCore::Animation::initialAnimationPlayState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate Windows results after r71043
aroben@apple.com [Tue, 2 Nov 2010 17:08:41 +0000 (17:08 +0000)]
Update Windows results after r71043

* platform/win/fast/blockflow/border-vertical-lr-expected.checksum:
* platform/win/fast/blockflow/border-vertical-lr-expected.png:
* platform/win/fast/blockflow/border-vertical-lr-expected.txt:
* platform/win/fast/blockflow/japanese-lr-text-expected.checksum:
* platform/win/fast/blockflow/japanese-lr-text-expected.png:
* platform/win/fast/blockflow/japanese-lr-text-expected.txt:
* platform/win/fast/blockflow/japanese-rl-text-expected.checksum:
* platform/win/fast/blockflow/japanese-rl-text-expected.png:
* platform/win/fast/blockflow/japanese-rl-text-expected.txt:
* platform/win/fast/text/international/vertical-text-glyph-test-expected.checksum:
* platform/win/fast/text/international/vertical-text-glyph-test-expected.png:
* platform/win/fast/text/international/vertical-text-glyph-test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 2 Nov 2010 16:44:27 +0000 (16:44 +0000)]
2010-11-01  Zhenyao Mo  <zmo@google.com>

        Reviewed by Andreas Kling.

        vertexAttribPointer should generate INVALID_VALUE if the stride exceeds 255
        https://bugs.webkit.org/show_bug.cgi?id=48677

        Test: fast/canvas/webgl/gl-vertexattribpointer.html

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::vertexAttribPointer): Generate INVALID_VALUE if stride > 255.
2010-11-01  Zhenyao Mo  <zmo@google.com>

        Reviewed by Andreas Kling.

        vertexAttribPointer should generate INVALID_VALUE if the stride exceeds 255
        https://bugs.webkit.org/show_bug.cgi?id=48677

        * fast/canvas/webgl/gl-vertexattribpointer-expected.txt: Added.
        * fast/canvas/webgl/gl-vertexattribpointer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed Qt buildfix.
kbalazs@webkit.org [Tue, 2 Nov 2010 16:39:47 +0000 (16:39 +0000)]
Unreviewed Qt buildfix.

* DerivedSources.pro: Add WebInspector to the list of
message recievers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 2 Nov 2010 16:06:23 +0000 (16:06 +0000)]
2010-11-02  Stephen White  <senorblanco@chromium.org>

        Unreviewed; test expectations fix.

        [Chromium] Update chromium-gpu test_expectations to reflect the
        test results from the FYI bots.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 2 Nov 2010 16:04:29 +0000 (16:04 +0000)]
2010-11-02  Daniel Bates  <dbates@rim.com>

        Reviewed by Martin Robinson.

        Set frame name before appending it to the frame tree in the Apple Windows,
        GTK, and EFL ports
        https://bugs.webkit.org/show_bug.cgi?id=48806

        Make the frame creation process in the GTK-port consistent with the
        Mac, Qt, and Haiku ports. In particular, set the name of the new
        frame before it's appended to the frame tree.

        At this time we cannot test this change since it is being masked by
        HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
        We'll be able to test this once we fix bug #6751.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::createFrame):
2010-11-02  Daniel Bates  <dbates@rim.com>

        Reviewed by Martin Robinson.

        Set frame name before appending it to the frame tree in the Apple Windows,
        GTK, and EFL ports
        https://bugs.webkit.org/show_bug.cgi?id=48806

        Make the frame creation process in the Apple Windows-port consistent
        with the Mac, Qt, and Haiku ports. In particular, set the name of
        the new frame before it's appended to the frame tree.

        At this time we cannot test this change since it is being masked by
        HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
        We'll be able to test this once we fix bug #6751.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::createFrame):
2010-11-02  Daniel Bates  <dbates@rim.com>

        Reviewed by Martin Robinson.

        Set frame name before appending it to the frame tree in the Apple Windows,
        GTK, and EFL ports
        https://bugs.webkit.org/show_bug.cgi?id=48806

        Make the frame creation process in the EFL-port consistent with the
        Mac, Qt, and Haiku ports. In particular, set the name of the new
        frame before it's appended to the frame tree.

        At this time we cannot test this change since it is being masked by
        HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
        We'll be able to test this once we fix bug #6751.

        * ewk/ewk_frame.cpp:
        (ewk_frame_child_add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 2 Nov 2010 15:52:36 +0000 (15:52 +0000)]
2010-11-01  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [Soup] Random crashes in http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html
        https://bugs.webkit.org/show_bug.cgi?id=48805

        Track active WebSocket handles via a sequential id. This ensures
        that when a handle is reallocated into a recently used segment of
        memory, it doesn't trigger a false positive in the code which ensures
        the original handle is active.

        No new tests. This test should stop crashing on the bots, proving the fix.

        * platform/network/soup/SocketStreamHandle.h:
        (WebCore::SocketStreamHandle::id): Added an m_id member and accessor
        to SocketStreamHandle.
        * platform/network/soup/SocketStreamHandleSoup.cpp:
        (WebCore::getHandleFromId): Updated to work with HashMap of handle ids to
        SocketStreamHandle*.
        (WebCore::deactivateHandle): Ditto.
        (WebCore::activateHandle): Ditto.
        (WebCore::SocketStreamHandle::SocketStreamHandle): Ditto.
        (WebCore::SocketStreamHandle::connected): Ditto.
        (WebCore::SocketStreamHandle::readBytes): Ditto.
        (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Ditto.
        (WebCore::connectedCallback): Ditto.
        (WebCore::readReadyCallback): Ditto.
        (WebCore::writeReadyCallback): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] SharedMemory is broken
kbalazs@webkit.org [Tue, 2 Nov 2010 15:47:49 +0000 (15:47 +0000)]
[Qt][WK2] SharedMemory is broken
https://bugs.webkit.org/show_bug.cgi?id=48520

Reviewed by Andreas Kling.

Implement SharedMemory with QSharedMemory to correctly handle
ownership and to avoid extra allocation for page size requests.
* Platform/SharedMemory.h:
* Platform/qt/SharedMemoryQt.cpp:
(WebKit::SharedMemory::Handle::Handle):
(WebKit::SharedMemory::Handle::isNull):
(WebKit::SharedMemory::Handle::encode):
(WebKit::SharedMemory::Handle::decode):
(WebKit::createUniqueKey):
(WebKit::SharedMemory::create):
(WebKit::accessMode):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::SharedMemory::createHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed trivial fix.
ossy@webkit.org [Tue, 2 Nov 2010 15:37:50 +0000 (15:37 +0000)]
Unreviewed trivial fix.

* WebCore.pro: Remove inspector/InspectorResource.h after r71035.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOnly track resource identifiers in DRT when dumpResourceLoadCallbacks is on
aroben@apple.com [Tue, 2 Nov 2010 15:36:52 +0000 (15:36 +0000)]
Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on

This reverts Windows to our pre-r71097 behavior. That patch made us
track all resource identifiers, including the main resource, so the
main resource's URL started appearing in test output instead of
"<unknown>". Arguably having the main resource's URL is better, but all
other platforms print "<unknown>" and we want to match.

Fixes <http://webkit.org/b/48837> <rdar://problem/8620351> REGRESSION
(r71097): Many http tests failing on Windows

Reviewed by Anders Carlsson.

* DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::identifierForInitialRequest): Don't add the
identifier to the URL map if we're not supposed to dump resource load
callbacks.
(ResourceLoadDelegate::removeIdentifierForRequest): Always remove the
identifier from the URL map even if we're already "done". There's no
point in keeping out-of-date identifiers around.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd WKInspector public APIs.
timothy@apple.com [Tue, 2 Nov 2010 15:22:46 +0000 (15:22 +0000)]
Add WKInspector public APIs.

https://webkit.org/b/48718

Reviewed by Pavel Feldman.

* DerivedSources.make: Added WebInspector to MESSAGE_RECEIVERS section.
* UIProcess/API/C/WKInspector.cpp:
(WKInspectorIsVisible): Added.
(WKInspectorShow): Added.
(WKInspectorClose): Added.
(WKInspectorShowConsole): Added.
(WKInspectorIsAttached): Added.
(WKInspectorAttach): Added.
(WKInspectorDetach): Added.
(WKInspectorIsDebuggingJavaScript): Added.
(WKInspectorToggleJavaScriptDebugging): Added.
(WKInspectorIsProfilingJavaScript): Added.
(WKInspectorToggleJavaScriptProfiling): Added.
(WKInspectorIsProfilingPage): Added.
(WKInspectorTogglePageProfiling): Added.
* UIProcess/API/C/WKInspector.h: Added new functions.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy): Initialize new booleans.
(WebKit::WebInspectorProxy::invalidate): Reset new booleans.
(WebKit::WebInspectorProxy::show): Added.
(WebKit::WebInspectorProxy::close): Added.
(WebKit::WebInspectorProxy::showConsole): Added.
(WebKit::WebInspectorProxy::attach): Added.
(WebKit::WebInspectorProxy::detach): Added.
(WebKit::WebInspectorProxy::toggleJavaScriptDebugging): Added.
(WebKit::WebInspectorProxy::toggleJavaScriptProfiling): Added.
(WebKit::WebInspectorProxy::togglePageProfiling): Added.
* UIProcess/WebInspectorProxy.h:
(WebKit::WebInspectorProxy::isVisible): Added.
(WebKit::WebInspectorProxy::isAttached): Added.
(WebKit::WebInspectorProxy::isDebuggingJavaScript): Added.
(WebKit::WebInspectorProxy::isProfilingJavaScript): Added.
(WebKit::WebInspectorProxy::isProfilingPage): Added.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Invalidate the WebInspectorProxy.
(WebKit::WebPageProxy::inspector): Return 0 if closed or invalid.
* WebKit2.pro: Added new files.
* WebKit2.xcodeproj/project.pbxproj: Added new Files.
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::show): Added.
(WebKit::WebInspector::close): Added.
(WebKit::WebInspector::showConsole): Added.
(WebKit::WebInspector::startJavaScriptDebugging): Added.
(WebKit::WebInspector::stopJavaScriptDebugging): Added.
(WebKit::WebInspector::startJavaScriptProfiling): Added.
(WebKit::WebInspector::stopJavaScriptProfiling): Added.
(WebKit::WebInspector::startPageProfiling): Added.
(WebKit::WebInspector::stopPageProfiling): Added.
* WebProcess/WebPage/WebInspector.h:
(WebKit::WebInspector::page): Added.
* WebProcess/WebPage/WebInspector.messages.in: Added.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close): Destroy the WebInspector.
(WebKit::WebPage::inspector): Return 0 if closed.
(WebKit::WebPage::didReceiveMessage): Send the message to the WebInspector
if the message class is MessageClassWebInspector.
* win/WebKit2.vcproj: Added new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake WebInspectorFrontendClient inherit from InspectorFrontendClientLocal.
timothy@apple.com [Tue, 2 Nov 2010 15:22:12 +0000 (15:22 +0000)]
Make WebInspectorFrontendClient inherit from InspectorFrontendClientLocal.

We can do this since the Web Inspector WebPage will share the same process
with the inspected WebPage.

https://webkit.org/b/48652

Reviewed by Pavel Feldman.

* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
Call the InspectorFrontendClientLocal constructor.
(WebKit::WebInspectorFrontendClient::attachWindow): Added.
(WebKit::WebInspectorFrontendClient::detachWindow): Added.
(WebKit::WebInspectorFrontendClient::setAttachedWindowHeight): Added.
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 2 Nov 2010 14:32:44 +0000 (14:32 +0000)]
2010-11-02  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: make xhr breakpoints editable
        https://bugs.webkit.org/show_bug.cgi?id=48830

        * inspector/front-end/BreakpointManager.js:
        (WebInspector.Breakpoint.prototype.set sourceText):
        (WebInspector.Breakpoint.prototype.click):
        (WebInspector.Breakpoint.prototype.populateLabelElement):
        (WebInspector.XHRBreakpoint.prototype.populateEditElement):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.BreakpointsSidebarPane.prototype.addBreakpointItem):
        (WebInspector.BreakpointsSidebarPane.prototype._breakpointItemClicked):
        (WebInspector.BreakpointsSidebarPane.prototype._contextMenuEventFired):
        (WebInspector.BreakpointsSidebarPane.prototype._addListElement):
        (WebInspector.BreakpointsSidebarPane.prototype._removeListElement):
        (WebInspector.XHRBreakpointsSidebarPane.addButtonClicked):
        (WebInspector.XHRBreakpointsSidebarPane):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._breakpointItemClicked):
        (WebInspector.BreakpointItem):
        (WebInspector.BreakpointItem.prototype.get element):
        (WebInspector.BreakpointItem.prototype.click):
        (WebInspector.BreakpointItem.prototype.populateEditElement):
        (WebInspector.BreakpointItem.prototype.remove):
        (WebInspector.BreakpointItem.prototype._hitStateChanged):
        (WebInspector.BreakpointItem.prototype._labelChanged):
        (WebInspector.BreakpointItem.prototype._createLabelElement):
        * inspector/front-end/inspector.js:
        (WebInspector.createJSBreakpointsSidebarPane.breakpointAdded):
        (WebInspector.createJSBreakpointsSidebarPane):
        (WebInspector.createDOMBreakpointsSidebarPane.breakpointAdded):
        (WebInspector.createDOMBreakpointsSidebarPane):
        (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded):
        (WebInspector.createXHRBreakpointsSidebarPane):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 2 Nov 2010 13:54:56 +0000 (13:54 +0000)]
2010-11-02  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: fix for breakpoints not restored on live edit bug
        https://bugs.webkit.org/show_bug.cgi?id=48833

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.debuggerPaused):
        * inspector/front-end/inspector.js:
        (WebInspector.pausedScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 2 Nov 2010 13:35:38 +0000 (13:35 +0000)]
2010-11-02  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] Rule addition/selector editing result in unusable rules
        https://bugs.webkit.org/show_bug.cgi?id=48826

        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype.setRuleSelector):
        (WebInspector.CSSStyleModel.prototype.addRule):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
        (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Don't include Objective-C sources in SOURCES
vestbo@webkit.org [Tue, 2 Nov 2010 12:08:12 +0000 (12:08 +0000)]
[Qt] Don't include Objective-C sources in SOURCES

Reviewed by Andreas Kling.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 2 Nov 2010 10:43:42 +0000 (10:43 +0000)]
2010-11-02  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: persist native breakpoints in localStorage
        https://bugs.webkit.org/show_bug.cgi?id=48711

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::disconnectFrontend):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::clearNativeBreakpoints):
        * inspector/InspectorController.h:
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager):
        (WebInspector.DOMBreakpoint):
        (WebInspector.EventListenerBreakpoint):
        (WebInspector.EventListenerBreakpoint.eventNameForUI):
        (WebInspector.EventListenerBreakpoint.prototype._uiEventName):
        (WebInspector.XHRBreakpoint):
        (WebInspector.XHRBreakpoint.prototype.populateStatusMessageElement):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
        (WebInspector.BreakpointsSidebarPane.prototype._breakpointHit):
        (WebInspector.BreakpointItem.prototype._hitStateChanged):
        (WebInspector.EventListenerBreakpointsSidebarPane):
        * inspector/front-end/ConsoleView.js:
        * inspector/front-end/EventListenersSidebarPane.js:
        * inspector/front-end/NetworkPanel.js:
        * inspector/front-end/Panel.js:
        * inspector/front-end/ResourceView.js:
        * inspector/front-end/ScriptsPanel.js:
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):
        (WebInspector.Settings.prototype.inspectedURLChanged):
        (WebInspector.Settings.prototype._formatProjectKey):
        * inspector/front-end/StoragePanel.js:
        * inspector/front-end/StylesSidebarPane.js:
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        * inspector/front-end/inspector.css:
        (.pane .breakpoint-hit):
        * inspector/front-end/inspector.js:
        (WebInspector.set currentPanel):
        (WebInspector.doLoadedDone.onPopulateScriptObjects):
        (WebInspector.doLoadedDone):
        (WebInspector.reset):
        (WebInspector.inspectedURLChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 2 Nov 2010 10:31:45 +0000 (10:31 +0000)]
2010-11-01  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: use mimeType from cached resource
        in case response data contains none.
        https://bugs.webkit.org/show_bug.cgi?id=48773

        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::didReceiveResponse):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype._createTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 2 Nov 2010 10:29:02 +0000 (10:29 +0000)]
2010-11-01  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] expose API to create properties watch sidebar panes
        https://bugs.webkit.org/show_bug.cgi?id=48761

        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI.PanelImpl.prototype.createSidebarPane):
        (WebInspector.injectedExtensionAPI.PanelImpl.prototype.createWatchExpressionSidebarPane.callbackWrapper):
        (WebInspector.injectedExtensionAPI.PanelImpl.prototype.createWatchExpressionSidebarPane):
        (WebInspector.injectedExtensionAPI):
        (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl):
        (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setExpression):
        (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setObject):
        * inspector/front-end/ExtensionPanel.js: Added ExtensionWatchSidebarPane
        (WebInspector.ExtensionWatchSidebarPane):
        (WebInspector.ExtensionWatchSidebarPane.prototype.setObject):
        (WebInspector.ExtensionWatchSidebarPane.prototype.setExpression):
        (WebInspector.ExtensionWatchSidebarPane.prototype._onEvaluate):
        (WebInspector.ExtensionWatchSidebarPane.prototype._setObject):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer):
        (WebInspector.ExtensionServer.prototype.notifyExtensionWatchSidebarUpdated):
        (WebInspector.ExtensionServer.prototype._onCreateSidebar):
        (WebInspector.ExtensionServer.prototype._onCreateWatchExpressionSidebarPane):
        (WebInspector.ExtensionServer.prototype._createSidebar):
        (WebInspector.ExtensionServer.prototype._onSetWatchSidebarContent):
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor.):
        * inspector/front-end/RemoteObject.js: Added a wrapper for local JSON object to simulate RemoteObject interface.
        (WebInspector.RemoteObject.fromLocalObject):
        (WebInspector.LocalJSONObject):
        (WebInspector.LocalJSONObject.prototype.get description):
        (WebInspector.LocalJSONObject.prototype.get type):
        (WebInspector.LocalJSONObject.prototype.get hasChildren):
        (WebInspector.LocalJSONObject.prototype.getOwnProperties):
        (WebInspector.LocalJSONObject.prototype.getProperties):
        (WebInspector.LocalJSONObject.prototype.isError):

2010-11-01  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] expose API to create properties watch sidebar panes
        https://bugs.webkit.org/show_bug.cgi?id=48761

        * inspector/extensions-api-expected.txt:
        * inspector/extensions-events-expected.txt:
        * inspector/extensions-expected.txt:
        * inspector/extensions-test.js: Added generic way to dispatch messages to front-end and receive callbacks.
        (initialize_ExtensionsTest.InspectorTest.dispatchOnMessage):
        (initialize_ExtensionsTest.InspectorTest.dumpSidebarContent):
        * inspector/extensions.html:
        * inspector/resources/extension-main.js:
        (dispatchOnFrontend.callbackWrapper):
        (dispatchOnFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 2 Nov 2010 10:20:37 +0000 (10:20 +0000)]
2010-11-02  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, unskip passing media test on the GTK+ port.

        * platform/gtk/Skipped: Unskip media/video-canvas-alpha.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Tue, 2 Nov 2010 10:11:36 +0000 (10:11 +0000)]
2010-11-02  Ryuan Choi  <ryuan.choi@samsung.com>

        Unreviewed build fix for EFL build with libcurl

        [EFL] remove multiple definition with libcurl
        https://bugs.webkit.org/show_bug.cgi?id=48499

        Add macro to isolate setCookieStoragePrivateBrowsingEnabled from EFL
        build because it was duplicated.

        * platform/network/curl/CookieJarCurl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 2 Nov 2010 09:57:52 +0000 (09:57 +0000)]
2010-11-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: highlight frame on hover in resources panel.
        https://bugs.webkit.org/show_bug.cgi?id=48760

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::highlightFrame):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::hideFrameHighlight):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel):
        (WebInspector.StoragePanel.prototype.showView):
        (WebInspector.StoragePanel.prototype._onmousemove):
        (WebInspector.StoragePanel.prototype._onmouseout):
        (WebInspector.FrameTreeElement.prototype.onselect):
        (WebInspector.FrameTreeElement.prototype.ondeselect):
        (WebInspector.FrameTreeElement.prototype.set displayName):
        (WebInspector.FrameTreeElement.prototype.set hovered):
        * inspector/front-end/inspector.css:
        (.storage.panel .sidebar li.selected .selection):
        (.storage.panel .sidebar :focus li.selected .selection):
        (body.inactive .storage.panel .sidebar li.selected .selection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-02 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 2 Nov 2010 08:35:42 +0000 (08:35 +0000)]
2010-11-02  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        Convert SVGPreserveAspectRatio to the new SVGPropertyTearOff concept
        https://bugs.webkit.org/show_bug.cgi?id=48822

        Convert the next type to use the SVGPropertyTearOffConcept. Just SVGAnimatedTransformList/SVGTransform/SVGStringList are missing.

        Tests: svg/dom/SVGAnimatedPreserveAspectRatio.html
               svg/dom/SVGPreserveAspectRatio.html

        * GNUmakefile.am: Add SVGAnimatedPreserveAspectRatio.h to build.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedPreserveAspectRatio as new style animated type.
        * bindings/scripts/CodeGeneratorJS.pm: Remove special SVGPreserveAspectRatio handling.
        * bindings/scripts/CodeGeneratorObjC.pm: Always include the type wrapped by SVGPropertyTearOff<> - this was missing before, and now become visible as missing include.
        * bindings/scripts/CodeGeneratorV8.pm: Remove special SVGPreserveAspectRatio handling.
        * svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGPreserveAspectRatio handling.
        * svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
        * svg/SVGAnimatedPreserveAspectRatio.h: Added.
        * svg/SVGFEImageElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_PROPERTY_NEW/ where SVGPreserveAspectRatio is used.
        * svg/SVGFitToViewBox.cpp:
        (WebCore::SVGFitToViewBox::viewBoxToViewTransform): SVGPreserveAspectRatio::getCTM doesn't need x/y parameters, they were not used anywhere, remove them.
        * svg/SVGFitToViewBox.h: Replace includes by class forwards.
        * svg/SVGImageElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_PROPERTY_NEW/ where SVGPreserveAspectRatio is used.
        * svg/SVGLocatable.cpp: Add SVGNames.h include, to allow Qt to build (thanks ews!).
        * svg/SVGMarkerElement.h: Ditto.
        * svg/SVGPatternElement.h: Ditto.
        * svg/SVGPreserveAspectRatio.cpp: Modernize code, add error handling for align/meetOrSlice covered by the new tests.
        (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
        (WebCore::SVGPreserveAspectRatio::setAlign):
        (WebCore::SVGPreserveAspectRatio::setMeetOrSlice):
        (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
        (WebCore::SVGPreserveAspectRatio::transformRect):
        (WebCore::SVGPreserveAspectRatio::getCTM):
        (WebCore::SVGPreserveAspectRatio::valueAsString):
        * svg/SVGPreserveAspectRatio.h: Reindented header.
        (WebCore::SVGPreserveAspectRatio::align): Inlined.
        (WebCore::SVGPreserveAspectRatio::meetOrSlice): Inlined.
        * svg/SVGPreserveAspectRatio.idl: Enable StrictTypeChecking for the align/meetOrSlice properties.
        * svg/SVGSVGElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_PROPERTY_NEW/ where SVGPreserveAspectRatio is used.
        * svg/SVGStyledTransformableElement.h: Add SVGAnimatedPropertyMacros.h include, needed by efl to build (thanks ews!).
        * svg/SVGSymbolElement.h: Ditto.
        * svg/SVGViewElement.h: Ditto.
        * svg/SVGViewSpec.h: Ditto.

2010-11-02  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        Convert SVGPreserveAspectRatio to the new SVGPropertyTearOff concept
        https://bugs.webkit.org/show_bug.cgi?id=48822

        * svg/dom/SVGAnimatedPreserveAspectRatio-expected.txt: Added.
        * svg/dom/SVGAnimatedPreserveAspectRatio.html: Added.
        * svg/dom/SVGPreserveAspectRatio-expected.txt: Added.
        * svg/dom/SVGPreserveAspectRatio.html: Added.
        * svg/dom/script-tests/SVGAnimatedPreserveAspectRatio.js: Added.
        * svg/dom/script-tests/SVGPreserveAspectRatio.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 2 Nov 2010 06:34:26 +0000 (06:34 +0000)]
2010-11-01  MORITA Hajime <morrita@google.com>

        Unreviewed, added skip entries for platforms where spellchecking
        is not supported.

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 2 Nov 2010 05:30:42 +0000 (05:30 +0000)]
2010-11-01  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        @spellcheck attribute at the child of contentEditable node is ignored.
        https://bugs.webkit.org/show_bug.cgi?id=48418

        * editing/spelling/script-tests/spelling-attribute-at-child.js: Added.
        * editing/spelling/spelling-attribute-at-child-expected.txt: Added.
        * editing/spelling/spelling-attribute-at-child.html: Added.
2010-11-01  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        @spellcheck attribute at the child of contentEditable node is ignored.
        https://bugs.webkit.org/show_bug.cgi?id=48418

        Changed to check spellcheck availability against a node under the
        selection (caret) instead of the focus. For shadow elements, the
        check now refers its host node.  Note that the original code didn't
        care shadows because focus is never set on them.

        Test: editing/spelling/spelling-attribute-at-child.html

        * dom/Element.h:
        * editing/Editor.cpp:
        (WebCore::Editor::markMisspellingsOrBadGrammar):
        (WebCore::Editor::isSpellCheckingEnabledFor):
        (WebCore::Editor::isSpellCheckingEnabledInFocusedNode): Now just calling isSpellCheckingEnabledFor()
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
        * editing/Editor.h:
        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):
        * rendering/TextControlInnerElements.cpp:
        (WebCore::TextControlInnerElement::isSpellCheckingEnabled): Added.
        * rendering/TextControlInnerElements.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 2 Nov 2010 05:09:47 +0000 (05:09 +0000)]
2010-11-01  Adam Barth  <abarth@webkit.org>

        Update expected results for PNG ICC profile.

        * platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.checksum:
        * platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.png: Removed.
        * platform/chromium-mac/fast/borders/svg-as-border-image-expected.checksum:
        * platform/chromium-mac/fast/borders/svg-as-border-image-expected.png: Removed.
        * platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum:
        * platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png: Removed.
        * platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.checksum: Removed.
        * platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png: Removed.
        * platform/chromium-mac/fast/reflections/reflection-masks-expected.checksum: Removed.
        * platform/chromium-mac/fast/reflections/reflection-masks-expected.png: Removed.
        * platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.checksum: Removed.
        * platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum:
        * platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png:
        * platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.checksum:
        * platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.checksum:
        * platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png: Removed.
        * platform/chromium-mac/svg/custom/createImageElement-expected.checksum:
        * platform/chromium-mac/svg/custom/createImageElement-expected.png:
        * platform/chromium-mac/svg/custom/focus-ring-expected.checksum:
        * platform/chromium-mac/svg/custom/focus-ring-expected.png: Removed.
        * platform/chromium-mac/svg/custom/group-opacity-expected.checksum:
        * platform/chromium-mac/svg/custom/group-opacity-expected.png: Removed.
        * platform/chromium-mac/svg/custom/image-parent-translation-expected.checksum:
        * platform/chromium-mac/svg/custom/image-parent-translation-expected.png:
        * platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum:
        * platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
        * platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.checksum:
        * platform/chromium-mac/svg/custom/js-update-image-and-display-expected.checksum:
        * platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png:
        * platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.checksum:
        * platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png:
        * platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.checksum:
        * platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png:
        * platform/chromium-mac/svg/custom/js-update-image-expected.checksum:
        * platform/chromium-mac/svg/custom/js-update-image-expected.png:
        * platform/chromium-mac/svg/custom/pointer-events-image-expected.checksum:
        * platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
        * platform/chromium-mac/svg/custom/text-image-opacity-expected.checksum:
        * platform/chromium-mac/svg/custom/text-image-opacity-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 2 Nov 2010 04:34:34 +0000 (04:34 +0000)]
2010-11-01  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Daniel Bates.

        [GTK] PopupMenuGtk has a very confusing if-else block
        https://bugs.webkit.org/show_bug.cgi?id=48816

        Small code cleanup for PopupMenuGtk.

        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenuGtk::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 2 Nov 2010 04:15:53 +0000 (04:15 +0000)]
2010-11-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [Chromium] Add ICC support for PNG on Mac
        https://bugs.webkit.org/show_bug.cgi?id=48170

        This just pipes the ICC profile from libpng to CoreGraphics.  This
        patch would have been a lot prettier on Snow Leopard, but we have to
        use a somewhat ugly API to get this to work on Leopard.

        This is covered by about infinite tests.

        * platform/image-decoders/ImageDecoder.cpp:
        (WebCore::RGBA32Buffer::setColorProfile):
        * platform/image-decoders/ImageDecoder.h:
        * platform/image-decoders/cg/ImageDecoderCG.cpp:
        (WebCore::RGBA32Buffer::asNewNativeImage):
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::headerAvailable):
        (WebCore::PNGImageDecoder::rowAvailable):
        * platform/image-decoders/qt/RGBA32BufferQt.cpp:
        (WebCore::RGBA32Buffer::setColorProfile):
        * platform/image-decoders/skia/ImageDecoderSkia.cpp:
        (WebCore::RGBA32Buffer::setColorProfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Jenn Braithwaite <jennb@chromium.org>
commit-queue@webkit.org [Tue, 2 Nov 2010 02:42:26 +0000 (02:42 +0000)]
2010-11-01  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Adam Roben.

        Windows: Update resource tracking when moving a frame between documents
        https://bugs.webkit.org/show_bug.cgi?id=48364

        * Interfaces/IWebResourceLoadDelegatePrivate2.idl:Added
        Added removeIdentifierForRequest.
        * Interfaces/WebKit.idl:
        Added IWebResourceLoadDelegatePrivate2.idl.
        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::transferLoadingResourceFromPage):
2010-11-01  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Adam Roben.

        Windows: Update resource tracking when moving a frame between documents
        https://bugs.webkit.org/show_bug.cgi?id=48364

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (createWebViewAndOffscreenWindow):
        (main):
        Give each WebView its own ResourceLoadDelegate instance in order to
        make assertions about resource ids on a particular WebView.
        * DumpRenderTree/win/ResourceLoadDelegate.cpp:
        (ResourceLoadDelegate::identifierForInitialRequest):
        Always add id to the map.
        (ResourceLoadDelegate::removeIdentifierForRequest):
        Added.
        (ResourceLoadDelegate::willSendRequest):
        (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
        (ResourceLoadDelegate::didReceiveResponse):
        (ResourceLoadDelegate::didFinishLoadingFromDataSource):
        (ResourceLoadDelegate::didFailLoadingWithError):
        (ResourceLoadDelegate::descriptionSuitableForTestResult):
        Replace static descriptionSuitableForTestResult with static member function to access identifier map.
        * DumpRenderTree/win/ResourceLoadDelegate.h:
        (ResourceLoadDelegate::urlMap):
        Moved within class so that each WebView has its own id map.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
commit-queue@webkit.org [Tue, 2 Nov 2010 02:20:35 +0000 (02:20 +0000)]
2010-11-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Andreas Kling.

        [Qt][Symbian] QtTestBrowser runs out of memory with most of javascript benchmarks.
        https://bugs.webkit.org/show_bug.cgi?id=48730

        Increase the maximum heap size on Symbian to 256 MB.

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unreviewed update of test expectations.
dimich@chromium.org [Tue, 2 Nov 2010 02:10:46 +0000 (02:10 +0000)]
[Chromium] Unreviewed update of test expectations.
Snap chromium checksum for the newly added baseline (added in http://trac.webkit.org/changeset/71088)

* platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Chang Shu <chang.shu@nokia.com>
chang.shu@nokia.com [Tue, 2 Nov 2010 01:56:45 +0000 (01:56 +0000)]
2010-11-01  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        Leave SelectElement key handling without setting event default
        handled when the selection reaches the boundary so focus can
        move to neighbor nodes in spatial navigation.
        https://bugs.webkit.org/show_bug.cgi?id=48145

        * fast/events/spatial-navigation/snav-multiple-select-expected.txt:
        * fast/events/spatial-navigation/snav-multiple-select.html:
2010-11-01  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        Leave SelectElement key handling without setting event default
        handled when the selection reaches the boundary so focus can
        move to neighbor nodes in spatial navigation.
        https://bugs.webkit.org/show_bug.cgi?id=48145

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::listBoxDefaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unreviewed update of test expectations.
dimich@chromium.org [Tue, 2 Nov 2010 01:54:55 +0000 (01:54 +0000)]
[Chromium] Unreviewed update of test expectations.
Did I run --lint-test-files last time? Probably not.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unreviewed update of test expectations.
dimich@chromium.org [Tue, 2 Nov 2010 01:44:46 +0000 (01:44 +0000)]
[Chromium] Unreviewed update of test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 2 Nov 2010 01:40:12 +0000 (01:40 +0000)]
2010-11-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r71080.
        http://trac.webkit.org/changeset/71080
        https://bugs.webkit.org/show_bug.cgi?id=48815

        This change caused many crashes on the debug bot. (Requested
        by mrobinson on #webkit).

        * platform/network/soup/SocketStreamHandle.h:
        * platform/network/soup/SocketStreamHandleSoup.cpp:
        (WebCore::isActiveHandle):
        (WebCore::deactivateHandle):
        (WebCore::SocketStreamHandle::SocketStreamHandle):
        (WebCore::SocketStreamHandle::connected):
        (WebCore::SocketStreamHandle::readBytes):
        (WebCore::SocketStreamHandle::beginWaitingForSocketWritability):
        (WebCore::connectedCallback):
        (WebCore::readReadyCallback):
        (WebCore::writeReadyCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Jennifer Braithwaite <jennb@google.com>
commit-queue@webkit.org [Tue, 2 Nov 2010 01:36:43 +0000 (01:36 +0000)]
2010-11-01  Jennifer Braithwaite  <jennb@google.com>

        Reviewed by Martin Robinson.

        GTK: Update resource tracking when moving a frame between documents
        https://bugs.webkit.org/show_bug.cgi?id=48362

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::transferLoadingResourceFromPage):
        Assign resource id to current web view and remove from former web view.
        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_remove_resource):
        Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Juha Savolainen <juha.savolainen@weego.fi>
commit-queue@webkit.org [Tue, 2 Nov 2010 01:15:18 +0000 (01:15 +0000)]
2010-11-01  Juha Savolainen  <juha.savolainen@weego.fi>

        Reviewed by Kenneth Rohde Christiansen.

        Initial implementation of QWKHistoryItem.
        https://bugs.webkit.org/show_bug.cgi?id=48620

        The QWkHistoryItem represents one item in the history of QWKPage.

        * UIProcess/API/qt/qwkhistory.cpp:
        (QWKHistoryItemPrivate::QWKHistoryItemPrivate):
        (QWKHistoryItem::QWKHistoryItem):
        (QWKHistoryItem::~QWKHistoryItem):
        (QWKHistoryItem::title): The page title
        (QWKHistoryItem::url): The URL of the page.
        (QWKHistoryItem::originalUrl): The URL used to access the page.
        * UIProcess/API/qt/qwkhistory.h:
        * UIProcess/API/qt/qwkhistory_p.h:
        * WebKit2.pro: Added WKBackForwardListItem.h and WKBackForwardListItem.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 2 Nov 2010 00:55:43 +0000 (00:55 +0000)]
2010-11-01  Mihai Parparita  <mihaip@chromium.org>

        Update the pixel expectations for css/ for the Mac port.

        For the tests that currently fail on Snow Leopard with --pixel-tests
        --tolerance 0, this moves the current pixel results to mac-leopard and
        adds new Snow Leopard-specific results to platform/mac.

        List of files omitted due to length but composed entirely of moves from
        platform/mac to platform/mac-leopard and newly added files in
        platform/mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unreviewed update of test expectations.
dimich@chromium.org [Tue, 2 Nov 2010 00:47:56 +0000 (00:47 +0000)]
[Chromium] Unreviewed update of test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix layout tests.
hyatt@apple.com [Tue, 2 Nov 2010 00:39:44 +0000 (00:39 +0000)]
Fix layout tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix layout tests.
hyatt@apple.com [Tue, 2 Nov 2010 00:38:49 +0000 (00:38 +0000)]
Fix layout tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 2 Nov 2010 00:31:10 +0000 (00:31 +0000)]
2010-11-01  Mihai Parparita  <mihaip@chromium.org>

        Update the pixel expectations for editing/ for the Mac port.

        For the tests that currently fail on Snow Leopard with --pixel-tests
        --tolerance 0, this moves the current pixel results to mac-leopard and
        adds new Snow Leopard-specific results to platform/mac.

        List of files omitted due to length but composed entirely of moves from
        platform/mac to platform/mac-leopard and newly added files in
        platform/mac.

        Some tests had differences due to spell correction underlining, those
        were skipped since it's not clear what the correct dictionary state is.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 2 Nov 2010 00:17:14 +0000 (00:17 +0000)]
2010-11-01  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Dimitri Glazkov.

        remove debug code from run_webkit_tests.py
        https://bugs.webkit.org/show_bug.cgi?id=48800

        Remove temporary debug code and make --master-name required
        if --test-results-server is set now that all clients set
        --master-name.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unreviewed update of test expectations.
dimich@chromium.org [Tue, 2 Nov 2010 00:17:01 +0000 (00:17 +0000)]
[Chromium] Unreviewed update of test expectations.
Temporarily disable new test added by http://trac.webkit.org/changeset/71066
Need to convert it to dumpAsText().

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake NPRemoteObjectMap a ref counted object
andersca@apple.com [Tue, 2 Nov 2010 00:12:48 +0000 (00:12 +0000)]
Make NPRemoteObjectMap a ref counted object
https://bugs.webkit.org/show_bug.cgi?id=48808

Reviewed by Oliver Hunt.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::windowScriptNPObject):
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::WebProcessConnection):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
* PluginProcess/WebProcessConnection.h:
(WebKit::WebProcessConnection::npRemoteObjectMap):
* Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::create):
(WebKit::NPRemoteObjectMap::~NPRemoteObjectMap):
(WebKit::NPRemoteObjectMap::createNPObjectProxy):
* Shared/Plugins/NPRemoteObjectMap.h:
* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::PluginProcessConnection):
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
* WebProcess/Plugins/PluginProcessConnection.h:
(WebKit::PluginProcessConnection::npRemoteObjectMap):
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::getWindowScriptNPObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 2 Nov 2010 00:09:19 +0000 (00:09 +0000)]
2010-11-01  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [Soup] Random crashes in http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html
        https://bugs.webkit.org/show_bug.cgi?id=48805

        Track active WebSocket handles via a sequential id. This ensures
        that when a handle is reallocated into a recently used segment of
        memory, it doesn't trigger a false positive in the code which ensures
        the original handle is active.

        No new tests. This test should stop crashing on the bots, proving the fix.

        * platform/network/soup/SocketStreamHandle.h:
        (WebCore::SocketStreamHandle::id): Added an m_id member and accessor
        to SocketStreamHandle.
        * platform/network/soup/SocketStreamHandleSoup.cpp:
        (WebCore::getHandleFromId): Updated to work with HashMap of handle ids to
        SocketStreamHandle*.
        (WebCore::deactivateHandle): Ditto.
        (WebCore::activateHandle): Ditto.
        (WebCore::SocketStreamHandle::SocketStreamHandle): Ditto.
        (WebCore::SocketStreamHandle::connected): Ditto.
        (WebCore::SocketStreamHandle::readBytes): Ditto.
        (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Ditto.
        (WebCore::connectedCallback): Ditto.
        (WebCore::readReadyCallback): Ditto.
        (WebCore::writeReadyCallback): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 2 Nov 2010 00:05:20 +0000 (00:05 +0000)]
2010-11-01  Kent Tamura  <tkent@chromium.org>

        Unreviewed. Run sort-Xcode-project-file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 2 Nov 2010 00:05:16 +0000 (00:05 +0000)]
2010-11-01  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        add plugin event logging for linux
        https://bugs.webkit.org/show_bug.cgi?id=48779

        This is taken from Chromium's fork of the layout test plugin:
        http://git.chromium.org/gitweb/?p=chromium.git/.git;a=blob;f=webkit/tools/npapi_layout_test_plugin/main.cpp;h=3ebdada2f049b3624756438cff852364f86a2ede;hb=HEAD#l348

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (handleEventX11):
        (NPP_HandleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 2 Nov 2010 00:00:54 +0000 (00:00 +0000)]
2010-11-01  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Compile TestNetscapePlugin on chromium win
        https://bugs.webkit.org/show_bug.cgi?id=48802

        It creates npTestNetscapePlugin.dll in the build directory, so
        it's not yet loaded by DRT or test_shell.

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove duplicate ChangeLog entry.
andersca@apple.com [Tue, 2 Nov 2010 00:00:17 +0000 (00:00 +0000)]
Remove duplicate ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRespond to NP_GetProperty by sending a GetProperty message
andersca@apple.com [Mon, 1 Nov 2010 23:58:05 +0000 (23:58 +0000)]
Respond to NP_GetProperty by sending a GetProperty message
https://bugs.webkit.org/show_bug.cgi?id=48797

Reviewed by John Sullivan.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add new sync message overload.

* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveSyncMessage):
If the message class is MessageClassNPObjectMessageReceiver, pass it to the NPRemoteObjectMap.

* Shared/Plugins/NPIdentifierData.cpp:
* Shared/Plugins/NPIdentifierData.h:
Add NPIdentifierData, a CoreIPC representation of an NPIdentifier.

* Shared/Plugins/NPObjectMessageReceiver.cpp:
(WebKit::NPObjectMessageReceiver::getProperty):
Add stub.

* Shared/Plugins/NPObjectMessageReceiver.messages.in:
Add GetProperty.

* Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::create):
(WebKit::NPObjectProxy::NPObjectProxy):
(WebKit::NPObjectProxy::initialize):
NPObjectProxy now takes an NPRemoteObjectMap in its create function.

(WebKit::NPObjectProxy::getProperty):
Send a GetProperty message.

(WebKit::NPObjectProxy::NP_GetProperty):
Call getProperty.

* Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::createNPObjectProxy):
Pass the NPRemoteObjectMap.

(WebKit::NPRemoteObjectMap::didReceiveSyncMessage):
Find the right message receiver and dispatch the message to it.

* Shared/Plugins/NPVariantData.cpp:
* Shared/Plugins/NPVariantData.h:
Add NPVariantData, which will be a CoreIPC representation of an NPVariant.

* WebKit2.xcodeproj/project.pbxproj:
Add new files.

* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
If the message class is MessageClassNPObjectMessageReceiver, pass it to the NPRemoteObjectMap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 1 Nov 2010 23:41:51 +0000 (23:41 +0000)]
2010-11-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Assertion failure in FrameView::layout when clicking on a YouTube video on youtube.com front page
        https://bugs.webkit.org/show_bug.cgi?id=44287

        When removing subframes, it's possible for layout() to get called on a FrameView
        for a Frame that has been removed from the frame tree. This can happen if the parent
        document happens to do a layout() while RenderView still has a reference to the widget
        for the removed frame; updateWidgetPosition() will try to force a layout() on the
        subframe.

        Fix by checking that the FrameView's Frame still has a reference to the page before
        calling layout() on the subframe.

        Test: fast/frames/layout-after-destruction.html

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::updateWidgetPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Mon, 1 Nov 2010 23:36:25 +0000 (23:36 +0000)]
2010-11-01  Mihai Parparita  <mihaip@chromium.org>

        Update the pixel expectations for fast/dom, fast/dynamic, fast/encoding, fast/events, and fast/gradients for the Mac port.

        For the tests that currently fail on Snow Leopard with --pixel-tests
        --tolerance 0, this moves the current pixel results to mac-leopard and
        adds new Snow Leopard-specific results to platform/mac.

        List of files omitted due to length but composed entirely of moves from
        platform/mac to platform/mac-leopard and newly added files in
        platform/mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Mon, 1 Nov 2010 23:30:42 +0000 (23:30 +0000)]
2010-11-01  Mihai Parparita  <mihaip@chromium.org>

        Update the pixel expectations for fast/dom, fast/dynamic, fast/encoding, fast/events, and fast/gradients for the Mac port.

        For the tests that currently fail on Snow Leopard with --pixel-tests
        --tolerance 0, this moves the current pixel results to mac-leopard and
        adds new Snow Leopard-specific results to platform/mac.

        List of files omitted due to length but composed entirely of moves from
        platform/mac to platform/mac-leopard and newly added files in
        platform/mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Sheriff Bot <webkit.review.bot@gmail.com>
dimich@chromium.org [Mon, 1 Nov 2010 23:25:50 +0000 (23:25 +0000)]
2010-11-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r71065.
        http://trac.webkit.org/changeset/71065
        https://bugs.webkit.org/show_bug.cgi?id=48801

        Seem to breake a lot of tests on Chromium bots (Requested by
        dimich on #webkit).

        * platform/image-decoders/ImageDecoder.cpp:
        * platform/image-decoders/ImageDecoder.h:
        * platform/image-decoders/cg/ImageDecoderCG.cpp:
        (WebCore::RGBA32Buffer::asNewNativeImage):
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::headerAvailable):
        (WebCore::PNGImageDecoder::rowAvailable):
        * platform/image-decoders/qt/RGBA32BufferQt.cpp:
        * platform/image-decoders/skia/ImageDecoderSkia.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 1 Nov 2010 23:23:00 +0000 (23:23 +0000)]
2010-11-01  James Robinson  <jamesr@chromium.org>

        Update chromium baselines for a few tests.

        * platform/chromium-linux/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
        * platform/chromium-linux/fast/repaint/iframe-scroll-repaint-expected.png: Added.
        * platform/chromium-linux/svg/custom/resource-invalidate-on-target-update-expected.checksum: Added.
        * platform/chromium-linux/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
        * platform/chromium-mac/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/iframe-scroll-repaint-expected.png: Added.
        * platform/chromium-mac/svg/custom/resource-invalidate-on-target-update-expected.checksum: Removed.
        * platform/chromium-mac/svg/custom/resource-invalidate-on-target-update-expected.png: Removed.
        * platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.png: Added.
        * platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.txt: Added.
        * platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.checksum:
        * platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd ArgumentCoder specialization for WTF::CString
andersca@apple.com [Mon, 1 Nov 2010 23:12:55 +0000 (23:12 +0000)]
Add ArgumentCoder specialization for WTF::CString
https://bugs.webkit.org/show_bug.cgi?id=48796

Reviewed by Sam Weinig.

* Platform/CoreIPC/ArgumentCoders.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 1 Nov 2010 23:01:05 +0000 (23:01 +0000)]
2010-11-01  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by James Robinson.

        new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default
        https://bugs.webkit.org/show_bug.cgi?id=48790

        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix SVG bustage.
hyatt@apple.com [Mon, 1 Nov 2010 22:43:15 +0000 (22:43 +0000)]
Fix SVG bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71067 268f45cc-cd09-0410-ab3c-d52691b4dbfc