WebKit-https.git
7 years ago[Qt] Simplify storage and reduce size of QtConnectionObject
commit-queue@webkit.org [Mon, 13 Aug 2012 20:33:18 +0000 (20:33 +0000)]
[Qt] Simplify storage and reduce size of QtConnectionObject
https://bugs.webkit.org/show_bug.cgi?id=93868

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.

The connection object is a child of the sender QObject, so we can use parent()
whenever we need the sender instead of keeping an extra QObject pointer. Also
QtConnectionObject kept a RefPtr to the Instance, but actually only needed the
root object, so we can store a pointer to that instead.

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtConnectionObject::QtConnectionObject):
(JSC::Bindings::QtConnectionObject::~QtConnectionObject):
(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::QtConnectionObject::match):
* bridge/qt/qt_runtime.h:
(QtConnectionObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Update API for spell checking suggestions again.
mifenton@rim.com [Mon, 13 Aug 2012 20:23:38 +0000 (20:23 +0000)]
[BlackBerry] Update API for spell checking suggestions again.
https://bugs.webkit.org/show_bug.cgi?id=93877

Reviewed by Antonio Gomes.

PR 163283.

Update the spell checking options request API
to include the caret positions.

Reviewed internally by Nima Ghanavatian.

* Api/WebPageClient.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
(WebKit):
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
* WebKitSupport/InputHandler.h:
(Platform):
(InputHandler):
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
* WebKitSupport/TouchEventHandler.h:
(TouchEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMedia(Stream|Element)AudioSourceNode should be guarded by the WEB_AUDIO condition...
zandobersek@gmail.com [Mon, 13 Aug 2012 20:17:57 +0000 (20:17 +0000)]
Media(Stream|Element)AudioSourceNode should be guarded by the WEB_AUDIO condition as well
https://bugs.webkit.org/show_bug.cgi?id=93864

Reviewed by Eric Carlson.

Add the WEB_AUDIO to the Conditional attribute in MediaElementAudioSourceNode
IDL file and the ENABLE(WEB_AUDIO) compilation guard to the header files for both
MediaStreamAudioSourceNode and MediaElementAudioSourceNode.

No new tests - no new functionality.

* Modules/webaudio/MediaElementAudioSourceNode.h:
* Modules/webaudio/MediaStreamAudioSourceNode.h:
* Modules/webaudio/MediaStreamAudioSourceNode.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Clean up exception handling
hausmann@webkit.org [Mon, 13 Aug 2012 20:12:52 +0000 (20:12 +0000)]
[Qt] Clean up exception handling
https://bugs.webkit.org/show_bug.cgi?id=93880

Reviewed by Kenneth Rohde Christiansen.

The JSC C API uses a JSValueRef* exception parameter to indicate to the
caller that an exception was thrown. Naturally the caller must store
that ValueRef on the stack in order to get seen and marked by the
garbage collector, otherwise the callee would have to use
JSValueProtect on it.

This patch fixes one such case where in fact the exception pointer was passed as zero to the
callee and thus ignored. The patch also removes an unused exception parameter.

* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
* bridge/qt/qt_runtime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove commitEditing from the text editor delegate.
pfeldman@chromium.org [Mon, 13 Aug 2012 20:05:13 +0000 (20:05 +0000)]
Web Inspector: remove commitEditing from the text editor delegate.
https://bugs.webkit.org/show_bug.cgi?id=93858

Reviewed by Vsevolod Vlasov.

This should be up to the source frame.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._registerShortcuts):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.scrollChanged):
(WebInspector.SourceFrame.prototype._handleKeyDown):
(WebInspector.SourceFrame.prototype._commitEditing):
* inspector/front-end/TextEditor.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r125430.
commit-queue@webkit.org [Mon, 13 Aug 2012 19:49:40 +0000 (19:49 +0000)]
Unreviewed, rolling out r125430.
http://trac.webkit.org/changeset/125430
https://bugs.webkit.org/show_bug.cgi?id=93881

Caused css2.1/t1604-c541-word-sp-00-b-a.html to regress on Mac
builds (Requested by mwenge on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-13

Source/WebCore:

* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance):
* platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:
(WebCore::HarfBuzzShaperBase::isWordEnd):
* platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
(HarfBuzzShaperBase):
(WebCore::HarfBuzzShaperBase::isCodepointSpace):
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
* rendering/RenderText.cpp:
(WebCore::RenderText::widthFromCache):

LayoutTests:

* css2.1/20110323/c541-word-sp-001-expected.html: Removed.
* css2.1/20110323/c541-word-sp-001.htm: Removed.
* css2.1/20110323/word-spacing-characters-002-expected.html: Removed.
* css2.1/20110323/word-spacing-characters-002.htm: Removed.
* css2.1/20110323/word-spacing-characters-003-expected.html: Removed.
* css2.1/20110323/word-spacing-characters-003.htm: Removed.
* css2.1/20110323/word-spacing-remove-space-001-expected.html: Removed.
* css2.1/20110323/word-spacing-remove-space-001.htm: Removed.
* css2.1/20110323/word-spacing-remove-space-002-expected.html: Removed.
* css2.1/20110323/word-spacing-remove-space-002.htm: Removed.
* css2.1/20110323/word-spacing-remove-space-003-expected.html: Removed.
* css2.1/20110323/word-spacing-remove-space-003.htm: Removed.
* css2.1/20110323/word-spacing-remove-space-004-expected.html: Removed.
* css2.1/20110323/word-spacing-remove-space-004.htm: Removed.
* css2.1/20110323/word-spacing-remove-space-005-expected.html: Removed.
* css2.1/20110323/word-spacing-remove-space-005.htm: Removed.
* css2.1/20110323/word-spacing-remove-space-006-expected.html: Removed.
* css2.1/20110323/word-spacing-remove-space-006.htm: Removed.
* css2.1/t1604-c541-word-sp-01-b-a.html: Added.
* fast/css/word-spacing-characters-complex-text-expected.html: Removed.
* fast/css/word-spacing-characters-complex-text.html: Removed.
* fast/css/word-spacing-characters-expected.html: Removed.
* fast/css/word-spacing-characters.html: Removed.
* fast/css/word-spacing-linebreak-expected.html: Removed.
* fast/css/word-spacing-linebreak.html: Removed.
* platform/chromium-linux/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
* platform/chromium-linux/fast/css/word-space-extra-expected.png:
* platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
* platform/chromium-mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
* platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
* platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
* platform/chromium-win/fast/css/word-space-extra-expected.txt:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
* platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
* platform/gtk/TestExpectations:
* platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
* platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
* platform/mac/TestExpectations:
* platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
* platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
* platform/qt/TestExpectations:
* platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
* platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFrameLoader::receivedMainResourceError doesn't handle GET cancellations well.
commit-queue@webkit.org [Mon, 13 Aug 2012 19:30:15 +0000 (19:30 +0000)]
FrameLoader::receivedMainResourceError doesn't handle GET cancellations well.
https://bugs.webkit.org/show_bug.cgi?id=93850

Patch by Mike West <mkwst@chromium.org> on 2012-08-13
Reviewed by Adam Barth.

'FrameLoader::cancel' should reset the loader's state, and it mostly
does. In the case of a GET form submission, however, the submitted form
URL that's stored doesn't match the URL that's requested (query string).
This leads to the loader getting a bit confused about what's going on,
and not clearing the stored form submission URL.

This patch moves to storing the form submission's actual request URL
as opposed to the form action URL.

None of the current tests should break, and when issue 93777 lands, it
won't be broken either.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
    Switched to using 'FormSubmission::requestURL', as that matches the
    URL that's actually requested during a form submission via GET.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Hardware accelerated scrolling of <select> content
tonikitoo@webkit.org [Mon, 13 Aug 2012 19:25:12 +0000 (19:25 +0000)]
[BlackBerry] Hardware accelerated scrolling of <select> content
https://bugs.webkit.org/show_bug.cgi?id=93856

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

Internally reviewed by Matthew Staikos.

* Resources/blackberry/selectControlBlackBerry.css: add -webkit-overflow-scrolling: touch (EOM).
(.select-area):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Rounding error somewhere when translating CompositingLayer 's for in...
tonikitoo@webkit.org [Mon, 13 Aug 2012 19:24:17 +0000 (19:24 +0000)]
[BlackBerry] Rounding error somewhere when translating CompositingLayer 's for in-region scrolling
https://bugs.webkit.org/show_bug.cgi?id=93848
PR #190986

Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>

Patch adds a WebKit thread setScrollPosition-like API to InRegionScroller.
It fixes a mismatch we had of setting a layer's scroll positing directly via
::setScrollPosition on the UI thread, but dispatching a coalesceable
scrollBy(delta) message to WebKit thread.

* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScroller::setScrollPositionCompositingThread):
Changed the API name to match other thread specific methods naming.
(WebKit):
(BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
Added a setScrollPosition-like method to InRegionScroller public API. Used
together with its UI-thread counterpart, it can fix some rounding
errors we have due to mixing ::setScrollPosition and ::scrollBy methods.
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
Method renamed. See reasons above.
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
Calls fowards the call to ::setLayerScrollPosition (below).
(BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
Sets the scroll position of a given RenderLayer.
* Api/InRegionScroller.h:
(InRegionScroller):
* Api/InRegionScroller_p.h:
(WebCore):
(InRegionScrollerPrivate):
* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
Cache the RenderLayer object associated to a given scrollable area
instead of its LayerCompositingThread. This way we can use it for
scrolling from both Compositing/UI and WebKit threads.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Assertion in RenderObject::offsetFromAncestorContainer
allan.jensen@nokia.com [Mon, 13 Aug 2012 19:24:13 +0000 (19:24 +0000)]
[Qt] Assertion in RenderObject::offsetFromAncestorContainer
https://bugs.webkit.org/show_bug.cgi?id=93845

Reviewed by Kenneth Rohde Christiansen.

Do not attempt to clip using layers that are not containers of the renderer.

* page/GestureTapHighlighter.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Cairo] canvas/philip/tests/2d.drawImage.self.2.html test failing on ports using...
commit-queue@webkit.org [Mon, 13 Aug 2012 19:09:41 +0000 (19:09 +0000)]
[Cairo] canvas/philip/tests/2d.drawImage.self.2.html test failing on ports using Cairo
https://bugs.webkit.org/show_bug.cgi?id=93244

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Similar to Skia's and Qt's ImageBuffer implementation we need to make sure that buffers
for images are copied when the destination canvas is identical to the
image buffer's context. This happens mostly in JS calls to canvas' drawImage method.
For now fixing the drawImage case, drawPattern case is handled in bug 93854.

No new tests, covered by canvas/philip/tests/2d.drawImage.self.2.html

* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::draw): Making sure buffer is copied when source and destination contexts are identical.

LayoutTests:

Unskipping canvas/philip/tests/2d.drawImage.self.2.html for GTK and EFL now that it's working.

* platform/efl/Skipped:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] new test css3/flexbox/line-wrapping.html failing
commit-queue@webkit.org [Mon, 13 Aug 2012 19:07:15 +0000 (19:07 +0000)]
[Qt] new test css3/flexbox/line-wrapping.html failing
https://bugs.webkit.org/show_bug.cgi?id=72490

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.

Gardening. Unskip now passing test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS 2.1 failure: Word-spacing affects each space and non-breaking space
robert@webkit.org [Mon, 13 Aug 2012 18:55:13 +0000 (18:55 +0000)]
CSS 2.1 failure: Word-spacing affects each space and non-breaking space
https://bugs.webkit.org/show_bug.cgi?id=89826

Reviewed by Eric Seidel.

Source/WebCore:

Add word spacing to consecutive spaces in a run per http://www.w3.org/TR/CSS21/text.html#spacing-props.

Test: fast/css/word-spacing-characters.html
      fast/css/word-spacing-characters-complex-text.html
      fast/css/word-spacing-characters-linebreak.html
      css2.1/20110323/word-spacing-characters-002.htm
      css2.1/20110323/word-spacing-characters-003.htm
      css2.1/20110323/word-spacing-remove-space-001.htm
      css2.1/20110323/word-spacing-remove-space-002.htm
      css2.1/20110323/word-spacing-remove-space-003.htm
      css2.1/20110323/word-spacing-remove-space-004.htm
      css2.1/20110323/word-spacing-remove-space-005.htm
      css2.1/20110323/word-spacing-remove-space-006.htm
      css2.1/20110323/c541-word-sp-001.htm

* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance): All spaces (ordinary space or &nbsp;) get word-spacing added, even
  if they are consecutive.
* platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:
(WebCore::HarfBuzzShaperBase::isWordEnd): ditto, but for the complex text case on Chromium. Had to use
  m_run rather than m_normalizedBuffer here as m_normalizedBuffer turns tabs into spaces! Unlike the simple
  text path, '\n' gets word-spacing - I observed this from fast/text/atsui-spacing-features.html but can't
  find it specified anywhere.
* platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
(WebCore::HarfBuzzShaperBase::isCodepointSpace):
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): ditto, but for the complext text case on Mac.
   The change to this file is speculative, I don't have a Mac build.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Tested by word-spacing-linebreak.html
* rendering/RenderText.cpp:
(WebCore::RenderText::widthFromCache): This code-path is not covered by any existing layout tests!
  I've tried to come up with a test to hit it but have failed.

LayoutTests:

* css2.1/20110323/c541-word-sp-001-expected.html: Added.
* css2.1/20110323/c541-word-sp-001.htm: Added.
  Replaces t1604-c541-word-sp-01-b-a.html below.
* css2.1/20110323/word-spacing-characters-002-expected.html: Added.
* css2.1/20110323/word-spacing-characters-002.htm: Added.
* css2.1/20110323/word-spacing-characters-003-expected.html: Added.
* css2.1/20110323/word-spacing-characters-003.htm: Added.
  These passed already.
* css2.1/20110323/word-spacing-remove-space-001-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-001.htm: Added.
* css2.1/20110323/word-spacing-remove-space-002-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-002.htm: Added.
* css2.1/20110323/word-spacing-remove-space-003-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-003.htm: Added.
* css2.1/20110323/word-spacing-remove-space-004-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-004.htm: Added.
* css2.1/20110323/word-spacing-remove-space-005-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-005.htm: Added.
* css2.1/20110323/word-spacing-remove-space-006-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-006.htm: Added.
  These 6 tests are fixed by this patch.
* css2.1/t1604-c541-word-sp-01-b-a.html: Removed.
  Per http://lists.w3.org/Archives/Public/public-css-testsuite/2010Jan/0029.html t1604-c541-word-sp-01-b-a.htm is
  now invalid and has been replaced by c541-word-sp-001.htm above.
* fast/css/word-spacing-characters-complex-text-expected.html: Added.
* fast/css/word-spacing-characters-complex-text.html: Added.
  This is a complex text version of word-spacing-characters-001.htm
* fast/css/word-spacing-characters-expected.html: Added.
* fast/css/word-spacing-characters.html: Added.
  The original test (word-spacing-characters-001.htm) has two spaces between the non-breaking spaces in the second last case.
  This causes WebKit to split the text into two-runs and drop the second of the two spaces. This entire test can be replaced
  with word-spacing-characters-001.htm from the css test suite when https://bugs.webkit.org/show_bug.cgi?id=89827 is fixed.
* fast/css/word-spacing-linebreak-expected.html: Added.
* fast/css/word-spacing-linebreak.html: Added.
* platform/chromium-linux/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/chromium-linux/fast/css/word-space-extra-expected.png:
* platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/chromium-mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
* platform/chromium-win/fast/css/word-space-extra-expected.txt:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
* platform/gtk/TestExpectations:
* platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
* platform/mac/TestExpectations:
* platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
* platform/qt/TestExpectations:
* platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove webkitMediaSourceURL from HTMLMediaElement.idl
annacc@chromium.org [Mon, 13 Aug 2012 18:45:12 +0000 (18:45 +0000)]
Remove webkitMediaSourceURL from HTMLMediaElement.idl
https://bugs.webkit.org/show_bug.cgi?id=93619

Reviewed by Adam Barth.

The webkitMediaSourceURL attribute is no longer needed now that we use
createObjectURL() to generate a media source URL.

Source/WebCore:

Test: update http/test/media/media-source/media-source.js

* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:

LayoutTests:

* http/tests/media/media-source/media-source.js:
(MediaSourceTest.setSrcToMediaSourceTestURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Port meta method/signal/slot handling in run-time bridge to use JSC C API
hausmann@webkit.org [Mon, 13 Aug 2012 17:53:33 +0000 (17:53 +0000)]
[Qt] Port meta method/signal/slot handling in run-time bridge to use JSC C API
https://bugs.webkit.org/show_bug.cgi?id=93476

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Based on patch by No'am Rosenthal and lots of good suggestions by Caio Marcelo.

Ported the code that mapped invokable methods (and signals/slots) as
well as the code that provides the connect() and disconnect() functions
over to use the JSC C API. In the process one behavioural change was
implemented: Previously meta methods were actually function objects
that through Function.prototype allowed calling via
object.method.call(object). Through the use of plain JS objects that is
not possible anymore.

If we tried to continue to use function objects (JSObjectMakeFunction)
then we would loose the ability to store the private pointer. An
alternative approach would be to use a regular object and install the
Function prototype (Function.prototype), but unfortunately we cannot do
that without loosing the common prototype for signals and slots.

* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::~QtInstance):
(JSC::Bindings::QtInstance::newRuntimeObject):
* bridge/qt/qt_instance.h:
(Bindings):
(QtInstance):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::connect):
(JSC::Bindings::QtRuntimeMethod::disconnect):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):
(Bindings):
(JSC::Bindings::QtConnectionObject::~QtConnectionObject):
* bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMethod::name):
(QtRuntimeMethod):
(QtConnectionObject):

Source/WebKit/qt:

Changed semantics of some test expectations. Similarly to r125032 when generating
error exceptions for connect/disconnect, we cannot generate explicit type error
exceptions but only generic errors. Another change is that the meta-method wrapper
doesn't support the call() through Function.prototype anymore. See WebCore changelog
for details.

* tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::connectAndDisconnect):
(tst_QObjectBridge::objectDeleted):
(tst_QObjectBridge::introspectQtMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix nits in the find-in-page match rects API
leandrogracia@chromium.org [Mon, 13 Aug 2012 17:42:55 +0000 (17:42 +0000)]
[Chromium] Fix nits in the find-in-page match rects API
https://bugs.webkit.org/show_bug.cgi?id=93817

Reviewed by Adam Barth.

This patch fixes a few pending nits from 93111.

Source/WebCore:

Tests: existing WebKit unit test WebFrameTest.FindInPageMatchRects

* dom/Range.cpp:
(WebCore::Range::transformFriendlyBoundingBox): add call to updateLayoutIgnorePendingStylesheets.

Source/WebKit/chromium:

* src/FindInPageCoordinates.cpp: replace a pointer by a reference in an output argument.
(WebKit::toNormalizedRect):
(WebKit::findInPageRectFromAbsoluteRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: get rid of beforeTextChanged
pfeldman@chromium.org [Mon, 13 Aug 2012 16:49:49 +0000 (16:49 +0000)]
Web Inspector: get rid of beforeTextChanged
https://bugs.webkit.org/show_bug.cgi?id=93851

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Merged beforeTextChanged and afterTextChanged into a single
onTextChanged event.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.editRange):
(WebInspector.CodeMirrorTextEditor.prototype._onChange):
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._enterInternalTextChangeMode):
(WebInspector.DefaultTextEditor.prototype._exitInternalTextChangeMode):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.onTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointsBeforeEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.onTextChanged):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.onTextChanged):
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditorDelegate.prototype.onTextChanged):
* inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype.onTextChanged):

LayoutTests:

* http/tests/inspector/live-edit-test.js:
(initialize_LiveEditTest.InspectorTest.replaceInSource):
(initialize_LiveEditTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[css] Remove "default" switch case from CSS primitive value mappings
commit-queue@webkit.org [Mon, 13 Aug 2012 16:47:53 +0000 (16:47 +0000)]
[css] Remove "default" switch case from CSS primitive value mappings
https://bugs.webkit.org/show_bug.cgi?id=93781

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-08-13
Reviewed by Alexey Proskuryakov.

Removing the "default" switch case allows compile-time early warning check,
specially useful for newly added or removed enumeration values.

* css/CSSPrimitiveValueMappings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCap the number of SourceBuffers that may be added to a MediaSource.
annacc@chromium.org [Mon, 13 Aug 2012 16:45:50 +0000 (16:45 +0000)]
Cap the number of SourceBuffers that may be added to a MediaSource.
https://bugs.webkit.org/show_bug.cgi?id=93406

Reviewed by Eric Carlson.

Make sure that no more SourceBuffer objects are added to a MediaSource
than can fit into the sourceBuffers SourceBufferList (internally stored
as a Vector). Also, make sure that new SourceBuffers are added with a
unique id even if the variable we are using to generate id wraps around.

No new tests.  It would not be realistic to add so many SourceBuffers to
test the id variable wrapping.  Existing tests should not be affected.

* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::addSourceBuffer): Obtain a unique id before creating
    a new SourceBuffer.
* Modules/mediasource/MediaSource.h:
* Modules/mediasource/SourceBufferList.cpp:
(WebCore::SourceBufferList::SourceBufferList):
(WebCore::SourceBufferList::generateUniqueId): Search for and generate a
    unique id.
(WebCore):
(WebCore::SourceBufferList::contains): Check if a SourceBuffer with a
    given id already exists in this SourceBufferList.
* Modules/mediasource/SourceBufferList.h:
(SourceBufferList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Update TestExpectations to make bot green
commit-queue@webkit.org [Mon, 13 Aug 2012 16:41:34 +0000 (16:41 +0000)]
[EFL][WK2] Update TestExpectations to make bot green
https://bugs.webkit.org/show_bug.cgi?id=93852

Unreviewed EFL gardening. Update wk2-efl TestExpectations
to make the bot green.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-13

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix apk generation for the Android platform
peter@chromium.org [Mon, 13 Aug 2012 16:40:45 +0000 (16:40 +0000)]
[Chromium] Fix apk generation for the Android platform
https://bugs.webkit.org/show_bug.cgi?id=93841

Reviewed by Dimitri Glazkov.

APK generation was broken as the configuration file assumed compilation
would only occur in the Chromium tree. Pass the path to Chromium's source
base directory as a property to ant.

Source/WebKit/chromium:

* WebKitUnitTests.gyp:

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SOUP][WK2] Missing LocalTerminationDisabler in WebCookieManager::setCookiePersistent...
commit-queue@webkit.org [Mon, 13 Aug 2012 16:36:43 +0000 (16:36 +0000)]
[SOUP][WK2] Missing LocalTerminationDisabler in WebCookieManager::setCookiePersistentStorage()
https://bugs.webkit.org/show_bug.cgi?id=93837

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-13
Reviewed by Carlos Garcia Campos.

Add missing WebCore::LocalTerminationDisabler in
WebCookieManager::setCookiePersistentStorage() to
temporarily disable process termination.

* WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:
(WebKit::WebCookieManager::setCookiePersistentStorage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Mon, 13 Aug 2012 15:50:37 +0000 (15:50 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: when status bar is too narrow, cut panel status bar, not main status...
caseq@chromium.org [Mon, 13 Aug 2012 14:54:09 +0000 (14:54 +0000)]
Web Inspector: when status bar is too narrow, cut panel status bar, not main status bar items
https://bugs.webkit.org/show_bug.cgi?id=93814

Reviewed by Pavel Feldman.

- set shrink factor of bottom-status-bar-container to 1;
- set bottom-status-bar-container's width to 0 to workaround for flex-basis being ignored;

* inspector/front-end/inspector.css:
(#bottom-status-bar-container):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback
commit-queue@webkit.org [Mon, 13 Aug 2012 14:19:51 +0000 (14:19 +0000)]
[WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback
https://bugs.webkit.org/show_bug.cgi?id=93825

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-13
Reviewed by Antonio Gomes.

Corrected from didFinishLoadForResource() invoke to didFailLoadForResource() invoke.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFailLoadForResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening, updating test expectation for
zandobersek@gmail.com [Mon, 13 Aug 2012 13:43:41 +0000 (13:43 +0000)]
Unreviewed GTK gardening, updating test expectation for
canvas/philip/tests/2d.drawImage.self.2.html to note that
bug #93244 tracks the regression.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip a failing test.
ossy@webkit.org [Mon, 13 Aug 2012 13:31:00 +0000 (13:31 +0000)]
[Qt] Unreviewed gardening, skip a failing test.

* platform/qt/Skipped:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: add memory instrumentation for Attribute
yurys@chromium.org [Mon, 13 Aug 2012 13:24:17 +0000 (13:24 +0000)]
Web Inspector: add memory instrumentation for Attribute
https://bugs.webkit.org/show_bug.cgi?id=93827

Reviewed by Pavel Feldman.

Attribute's name and value footprint is counted as part of the DOM
component.

* dom/Attribute.h:
(WebCore::Attribute::reportMemoryUsage):
(Attribute):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Mon, 13 Aug 2012 13:19:22 +0000 (13:19 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-13

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Polish search/replace toolbar buttons style.
vsevik@chromium.org [Mon, 13 Aug 2012 12:58:50 +0000 (12:58 +0000)]
Web Inspector: Polish search/replace toolbar buttons style.
https://bugs.webkit.org/show_bug.cgi?id=93826

Reviewed by Pavel Feldman.

* inspector/front-end/inspector.css:
(.toolbar-search button):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] fast/box-sizing/box-sizing.html needs new baseline after r124347
commit-queue@webkit.org [Mon, 13 Aug 2012 12:35:50 +0000 (12:35 +0000)]
[EFL] fast/box-sizing/box-sizing.html needs new baseline after r124347
https://bugs.webkit.org/show_bug.cgi?id=93823

Unreviewed EFL gardening.

Provide new baseline for fast/box-sizing/box-sizing.html,
needed after r124347.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-13

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/fast/box-sizing/box-sizing-expected.png:
* platform/efl/fast/box-sizing/box-sizing-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add gprof.prf to build WebKit with gprof enabled
commit-queue@webkit.org [Mon, 13 Aug 2012 12:07:36 +0000 (12:07 +0000)]
[Qt] Add gprof.prf to build WebKit with gprof enabled
https://bugs.webkit.org/show_bug.cgi?id=90283

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-08-13
Reviewed by Eric Seidel.

Source/WebCore:

No behavior change, so no new tests.

* WebCore.pri:
-ffunction-sections conflicts with -pg option, so don't use
-ffunction-sections option when gprof is enabled.

Source/WebKit/qt:

* tests/MIMESniffing/MIMESniffing.pro:
Don't build MIMESniffing.cpp because MIMESniffing test links
WebKitQt statically when gprof is enabled.

Tools:

* qmake/mkspecs/features/functions.prf:
gprof does not support profiling a shared library.
To profile WebKit, applications must link QtWebKit statically.

* qmake/mkspecs/features/gprof.prf: Added.
Add -pg option to both QMAKE_CXXFLAGS and QMAKE_LFLAGS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix after r125408, removing another usage of SVG_FEATURES.
zandobersek@gmail.com [Mon, 13 Aug 2012 12:00:56 +0000 (12:00 +0000)]
Unreviewed build fix after r125408, removing another usage of SVG_FEATURES.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Skip inspector tests that hit assertion in WebCore::SuspendableTimer:...
commit-queue@webkit.org [Mon, 13 Aug 2012 11:54:19 +0000 (11:54 +0000)]
[EFL][WK2] Skip inspector tests that hit assertion in WebCore::SuspendableTimer::resume()
https://bugs.webkit.org/show_bug.cgi?id=93815

Unreviewed EFL gardening.

Update TestExpectations for several flaky Web Inspector
test cases.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-13

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] Remove SVG_FEATURES and HTML_FEATURES from Source/WebCore/GNUmakefile.am
zandobersek@gmail.com [Mon, 13 Aug 2012 11:42:39 +0000 (11:42 +0000)]
[Gtk] Remove SVG_FEATURES and HTML_FEATURES from Source/WebCore/GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=90693

Reviewed by Philippe Normand.

.:

Remove exportation of SVG_FLAGS and HTML_FLAGS as Automake conditionals
as they are not required anymore.

* configure.ac:

Source/WebCore:

Remove SVG_FEATURES and HTML_FEATURES variables. They can be replaced by the
FEATURE_DEFINES variable wherever they are used.

No new tests - no new functionality.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Default signal handler for WebKitWebView::should-show-delete-interface-for...
commit-queue@webkit.org [Mon, 13 Aug 2012 10:35:48 +0000 (10:35 +0000)]
[GTK] Default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides default result
https://bugs.webkit.org/show_bug.cgi?id=93600

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-08-13
Reviewed by Xan Lopez.

Instead of using the default editing signal handler for ::should-show-delete-interface-for-element,
do not use a default signal handler. This means that the result of the signal defaults to FALSE,
which is the expected value to ensure that the delete interface is not shown.

* webkit/webkitwebview.cpp:
(webkit_web_view_class_init): Do not install a default signal handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Mon, 13 Aug 2012 10:16:09 +0000 (10:16 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Wrong TestExpectations for 2 webintents tests
commit-queue@webkit.org [Mon, 13 Aug 2012 10:15:40 +0000 (10:15 +0000)]
[EFL][WK2] Wrong TestExpectations for 2 webintents tests
https://bugs.webkit.org/show_bug.cgi?id=93811

Unreviewed EFL gardening.

Update expected state for the following webintents tests
to make the tree green:
webintents/web-intents-invoke-port.html
webintents/web-intents-obj-constructor.html

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-13

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip new failing/crashing tests.
ossy@webkit.org [Mon, 13 Aug 2012 10:01:44 +0000 (10:01 +0000)]
[Qt] Unreviewed gardening, skip new failing/crashing tests.

* platform/qt/Skipped:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Implementation of atk_editable_text_insert_text ignores 'length' parameter
mario@webkit.org [Mon, 13 Aug 2012 09:42:39 +0000 (09:42 +0000)]
[GTK] Implementation of atk_editable_text_insert_text ignores 'length' parameter
https://bugs.webkit.org/show_bug.cgi?id=93804

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Use the 'length' parameter to insert a substring of the full
string passed to this method from AtkEditableText interface.

* accessibility/gtk/WebKitAccessibleInterfaceEditableText.cpp:
(webkitAccessibleEditableTextInsertText): Don't ignore 'length'.

Source/WebKit/gtk:

Update unit tests to also check inserting a partial string.

* tests/testatk.c:
(testWebkitAtkTextChangedNotifications): Update test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Feature Request - Adding mouse gesture for editing attribute values...
commit-queue@webkit.org [Mon, 13 Aug 2012 09:33:09 +0000 (09:33 +0000)]
Web Inspector: Feature Request - Adding mouse gesture for editing attribute values in elements/css panel
https://bugs.webkit.org/show_bug.cgi?id=93581

Patch by Sam D <dsam2912@gmail.com> on 2012-08-13
Reviewed by Alexander Pavlov.

Added functionality to modify valuesAdding support for updating number values in attributes in element
panel/ css panel using mouse gestures as well.

No new tests.

* inspector/front-end/StylesSidebarPane.js:
handling mousewheel event
* inspector/front-end/TextPrompt.js:
adding mouse event listener
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.prototype.onMouseWheel):
* inspector/front-end/UIUtils.js:
handling mouse event gesture and updating number based on mouse wheel
scroll direction as well.
(WebInspector._valueModificationDirection):
(WebInspector._modifiedHexValue):
(WebInspector._modifiedFloatNumber):
(WebInspector.handleElementValueModifications):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[TestNetscapePlugin][X11] Additional key up event handler routine is required
commit-queue@webkit.org [Mon, 13 Aug 2012 09:29:30 +0000 (09:29 +0000)]
[TestNetscapePlugin][X11] Additional key up event handler routine is required
https://bugs.webkit.org/show_bug.cgi?id=91357

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-13
Reviewed by Eric Seidel.

Fixed key up event handler routine to pass http/tests/plugins/plugin-document-
has-focus.html on X11 architecture. The test can not be done without this patch.
All other ports implemented it already.

* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventX11): Modified key up event handler for X11

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix make distcheck.
carlosgc@webkit.org [Mon, 13 Aug 2012 09:28:25 +0000 (09:28 +0000)]
Unreviewed. Fix make distcheck.

* GNUmakefile.list.am: Add missing header file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Protocol] Force elements pseudo state via a separate InspectorCSSAgen...
apavlov@chromium.org [Mon, 13 Aug 2012 09:06:15 +0000 (09:06 +0000)]
Web Inspector: [Protocol] Force elements pseudo state via a separate InspectorCSSAgent method
https://bugs.webkit.org/show_bug.cgi?id=93721

Reviewed by Pavel Feldman.

Source/WebCore:

Introduce InspectorCSSAgent::forcePseudoState() to modify the element's forced pseudo state.

* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getMatchedStylesAsync):
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleModel.prototype.forcePseudoState):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._setPseudoClassForNodeId):
* inspector/front-end/MetricsSidebarPane.js:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):

LayoutTests:

* http/tests/inspector/modify-cross-domain-rule.html:
* inspector/styles/get-set-stylesheet-text.html:
* inspector/styles/styles-formatting.html:
* inspector/styles/styles-new-API.html:
* inspector/styles/styles-new-API-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Replace Skipped list by TestExpectations
commit-queue@webkit.org [Mon, 13 Aug 2012 08:26:15 +0000 (08:26 +0000)]
[EFL][WK2] Replace Skipped list by TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=93796

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.

Tools:

Enable cascaded TestExpectations for EFL port so
that we can use TestExpectations in WK2-EFL.

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._search_paths):
(EflPort):
(EflPort.expectations_files):

LayoutTests:

Replace efl-wk2 Skipped file by TestExpectations now
that we support cascaded TestExpectations in EFL
port.

* platform/efl-wk2/Skipped: Removed.
* platform/efl-wk2/TestExpectations: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCannot select the AuthorShadowDOM inner element of an img element
shinyak@chromium.org [Mon, 13 Aug 2012 08:22:24 +0000 (08:22 +0000)]
Cannot select the AuthorShadowDOM inner element of an img element
https://bugs.webkit.org/show_bug.cgi?id=91591

Reviewed by Dimitri Glazkov.

Source/WebCore:

Since HTMLImageElement::canStartSelection always returns false, we cannot start selection
from any children (including shadow dom) of an img element. When the img element has a shadow dom,
we should be able to start selection.

Test: fast/dom/shadow/select-image-with-shadow.html

* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::canStartSelection):
(WebCore):
* html/HTMLImageElement.h:
(HTMLImageElement):
* html/shadow/ImageInnerElement.h:
(WebCore::ImageInnerElement::canStartSelection): Since ImageInnerElement is really an image,
this should return always false to obey the exising behavior.
(ImageInnerElement):

LayoutTests:

* fast/dom/shadow/select-image-with-shadow-expected.txt: Added.
* fast/dom/shadow/select-image-with-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r125153): It broke the 'Unexpected no expected results' case
ossy@webkit.org [Mon, 13 Aug 2012 08:11:43 +0000 (08:11 +0000)]
REGRESSION(r125153): It broke the 'Unexpected no expected results' case
https://bugs.webkit.org/show_bug.cgi?id=93789

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2012-08-13
Reviewed by Csaba Osztrogonác.

Fix the regex, so the text won't be a capturing group.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests._parseNewRunWebKitTestsOutput):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening. Add expectations for flaky tests.
yutak@chromium.org [Mon, 13 Aug 2012 07:52:13 +0000 (07:52 +0000)]
[Chromium] Unreviewed gardening. Add expectations for flaky tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r124723-r124741): 5 inspector/debugger tests failing on Apple Lion Debug...
commit-queue@webkit.org [Mon, 13 Aug 2012 07:19:14 +0000 (07:19 +0000)]
REGRESSION (r124723-r124741): 5 inspector/debugger tests failing on Apple Lion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93387

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-13
Reviewed by Pavel Feldman.

Now the front-end has problem when setting the positon of breakpoint, so remove the comparing
of "column" to make the behavior back to the time as JSC cannot provide "column" info.
Refer to https://bugs.webkit.org/show_bug.cgi?id=93473.

No new test case for this bug.

* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::hasBreakpoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r125392.
commit-queue@webkit.org [Mon, 13 Aug 2012 06:55:49 +0000 (06:55 +0000)]
Unreviewed, rolling out r125392.
http://trac.webkit.org/changeset/125392
https://bugs.webkit.org/show_bug.cgi?id=93797

Simple rebaseline won't work. Need further investigation.
(Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-12

* inspector/console/console-format-collections-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: rebaselined inspector/console/console-format-collections.html after...
pfeldman@chromium.org [Mon, 13 Aug 2012 06:48:20 +0000 (06:48 +0000)]
Not reviewed: rebaselined inspector/console/console-format-collections.html after r125284.
https://bugs.webkit.org/show_bug.cgi?id=93748

* inspector/console/console-format-collections-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport creating File object from FileSystem URL for files in FileSystem API
kinuko@chromium.org [Mon, 13 Aug 2012 06:21:28 +0000 (06:21 +0000)]
Support creating File object from FileSystem URL for files in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=93706

Reviewed by Darin Fisher.

Source/Platform:

* chromium/public/WebBlobData.h:
* chromium/public/WebHTTPBody.h:
(WebHTTPBody):

Source/WebCore:

Current File code assumes the existence of local file (i.e. requires a platform local file path) but for FileSystem
files it may not be always the case. For example some implementation may want to use in-memory filesystem to realize
sandboxed filesystem, or others may have the filesystem in remote servers.

This patch adds basic support for making File object constructible not only from a file path but from a FileSystem URL.
Since File can be appended to FormData or included in another Blob this patch also extends BlobData and FormData to support URL.

FileChooser and Drag-and-drop changes are not included in this patch.

No new tests: will add tests when we implement the platform side changes to wire this change.

* Modules/filesystem/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::createFile):
* Modules/filesystem/DOMFileSystemSync.cpp:
(WebCore::DOMFileSystemSync::createFile):
* fileapi/Blob.cpp:
(WebCore::Blob::sliceInternal):
* fileapi/File.cpp:
(WebCore::createBlobDataForFileSystemURL): Added.
(WebCore::File::File):
* fileapi/File.h:
(WebCore::File::createForFileSystemFile):
(WebCore::File::fileSystemURL): Added.
* fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::append):
* platform/chromium/support/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendURL): Added.
(WebKit::WebHTTPBody::appendURLRange): Added.
(WebKit::WebHTTPBody::appendBlob):
* platform/network/BlobData.cpp:
(WebCore::BlobData::appendURL):
* platform/network/BlobData.h:
(BlobDataItem):
(WebCore::BlobDataItem::BlobDataItem):
* platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::appendStorageItems):
(WebCore::BlobRegistryImpl::registerBlobURL):
* platform/network/FormData.cpp:
(WebCore::FormData::deepCopy):
(WebCore::FormData::appendURL): Added.
(WebCore::FormData::appendURLRange): Added.
(WebCore::FormData::appendKeyValuePairItems):
* platform/network/FormData.h:
(WebCore::FormDataElement::FormDataElement):
(FormDataElement):
(WebCore::operator==):

Source/WebKit/chromium:

* src/WebBlobData.cpp:
(WebKit::WebBlobData::itemAt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, added a proxy address to contributors_who_are_not_committers.
morrita@google.com [Mon, 13 Aug 2012 05:21:54 +0000 (05:21 +0000)]
Unreviewed, added a proxy address to contributors_who_are_not_committers.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/11442485> off-screen or inactive pages can change the mouse pointer
mitz@apple.com [Mon, 13 Aug 2012 04:36:01 +0000 (04:36 +0000)]
<rdar://problem/11442485> off-screen or inactive pages can change the mouse pointer

Reviewed by Adele Peterson.

* page/EventHandler.cpp:
(WebCore::EventHandler::fakeMouseMoveEventTimerFired): Added a check that the page is
on-screen and active before dispatching the fake mouse event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] use MediaPlayer::userAgent() in MediaPlayerPrivateBlackBerry to avoid...
commit-queue@webkit.org [Mon, 13 Aug 2012 04:35:39 +0000 (04:35 +0000)]
[BlackBerry] use MediaPlayer::userAgent() in MediaPlayerPrivateBlackBerry to avoid layering violation
https://bugs.webkit.org/show_bug.cgi?id=93588

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-08-12
Reviewed by Antonio Gomes.

Removed helper function MediaPlayerPrivate::userAgent() which has
introduced abstraction layering violation and replaced with
MediaPlayer::userAgent().

No new tests since there's no functional change.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed. Update TestExpectations so it matches the recent results.
yutak@chromium.org [Mon, 13 Aug 2012 04:23:57 +0000 (04:23 +0000)]
[Chromium] Unreviewed. Update TestExpectations so it matches the recent results.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRecord metrics to measure the usage of WebKitBlobBuilder to eventually deprecate it
kinuko@chromium.org [Mon, 13 Aug 2012 04:16:54 +0000 (04:16 +0000)]
Record metrics to measure the usage of WebKitBlobBuilder to eventually deprecate it
https://bugs.webkit.org/show_bug.cgi?id=90535

Reviewed by Eric Seidel.

No new tests as this has no functional changes.

* bindings/js/JSBlobCustom.cpp:
(WebCore::JSBlobConstructor::constructJSBlob):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):
* fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::getBlob):
* fileapi/WebKitBlobBuilder.h:
(WebKitBlobBuilder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix Chromium's Android build.
yutak@chromium.org [Mon, 13 Aug 2012 03:55:06 +0000 (03:55 +0000)]
Unreviewed. Fix Chromium's Android build.

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::find): Needs parentheses for a function call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unnecessary null checks from pseudoStyleForElement and adjustRenderStyle
ojan@chromium.org [Mon, 13 Aug 2012 00:14:23 +0000 (00:14 +0000)]
Remove unnecessary null checks from pseudoStyleForElement and adjustRenderStyle
https://bugs.webkit.org/show_bug.cgi?id=93730

Reviewed by Tony Chang.

All the callers of both methods make sure to pass in a non-null parentStyle.

No change in behavior.

* css/StyleResolver.cpp:
* css/StyleResolver.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip new tests without expected results.
ossy@webkit.org [Sun, 12 Aug 2012 23:13:26 +0000 (23:13 +0000)]
[Qt] Unreviewed gardening, skip new tests without expected results.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Tap highlight flashes checkerboard after pinch zoom
commit-queue@webkit.org [Sun, 12 Aug 2012 23:01:20 +0000 (23:01 +0000)]
[BlackBerry] Tap highlight flashes checkerboard after pinch zoom
https://bugs.webkit.org/show_bug.cgi?id=93601

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-12
Reviewed by Antonio Gomes.

Since the tap highlight is usually rather small, we can reimplement
GraphicsLayerClient::contentsVisible() to always return true in order
to keep all AC layer tiles cached all the time.

PR 189895

* WebKitSupport/DefaultTapHighlight.cpp:
(BlackBerry::WebKit::DefaultTapHighlight::contentsVisible):
(WebKit):
* WebKitSupport/DefaultTapHighlight.h:
(DefaultTapHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Tap highlight sometimes doesn't disappear
commit-queue@webkit.org [Sun, 12 Aug 2012 22:59:27 +0000 (22:59 +0000)]
[BlackBerry] Tap highlight sometimes doesn't disappear
https://bugs.webkit.org/show_bug.cgi?id=93711

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-12
Reviewed by Antonio Gomes.

The WebOverlayOverride implementation just changes properties of a
LayerCompositingThread directly, which means the changes will
immediately be overwritten on the next commit. Therefore, when the tap
highlight implementation adds a fade out animation, that animation will
instantly be removed again if a commit happens for any reason.

The reason is I totally botched the implementation of
WebOverlayOverride, it's not wrapping WebCore::LayerOverride at all,
instead for some reason it's manipulating the LayerCompositingThread
directly.

Fixed by actually mapping WebOverlayOverride calls to the corresponding
WebCore::LayerOverride method, and scheduling a compositing run to make
the change visible and kick off animations.

Reviewed internally by Sean Wang.

PR 188453

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivate::override):
* Api/WebOverlayOverride.cpp:
(BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):
(BlackBerry::WebKit::WebOverlayOverride::~WebOverlayOverride):
(BlackBerry::WebKit::WebOverlayOverride::setPosition):
(BlackBerry::WebKit::WebOverlayOverride::setAnchorPoint):
(BlackBerry::WebKit::WebOverlayOverride::setSize):
(BlackBerry::WebKit::WebOverlayOverride::setTransform):
(BlackBerry::WebKit::WebOverlayOverride::setOpacity):
(BlackBerry::WebKit::WebOverlayOverride::addAnimation):
(BlackBerry::WebKit::WebOverlayOverride::removeAnimation):
* Api/WebOverlayOverride.h:
* Api/WebOverlay_p.h:
(WebOverlayPrivate):
(WebOverlayPrivateWebKitThread):
(WebOverlayPrivateCompositingThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agotable cell.cellIndex should return -1 if there is no parent table
commit-queue@webkit.org [Sun, 12 Aug 2012 18:14:30 +0000 (18:14 +0000)]
table cell.cellIndex should return -1 if there is no parent table
https://bugs.webkit.org/show_bug.cgi?id=93738

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-08-12
Reviewed by Eric Seidel.

Source/WebCore:

According to the HTML5 spec the cellIndex of a table cell(td/th) whose parent is not a table row
must be -1. Currently we are returning zero. This patch fixes this behavior.

Test: fast/table/cellIndex-of-cell-with-different-parents.html

* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::cellIndex):
  If the parent of the cell is not a table row, -1 is returned. Otherwise a value greater
  than or equal to zero is return.

* rendering/RenderTableCell.h:
(RenderTableCell):
 Removed dead code and made minor webkit style related fix.

LayoutTests:

* fast/table/cellIndex-of-cell-with-different-parents-expected.txt: Added.
* fast/table/cellIndex-of-cell-with-different-parents.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Implement the find-in-page match rects API
leandrogracia@chromium.org [Sun, 12 Aug 2012 18:05:19 +0000 (18:05 +0000)]
[Chromium] Implement the find-in-page match rects API
https://bugs.webkit.org/show_bug.cgi?id=93111

Reviewed by Adam Barth.

Source/WebCore:

Introduce the find-in-page coordinate system. This system tries to solve
the unintuitive tickmark results presented in pages with multiple frames
and scrolled contents where the find results might not be in the visible
area of a frame, which might lead to tickmarks below the container frame.

To achieve this, this coordinate system goes up the render tree
normalizing the coordinates by the actual contents size of its container.
This leads to tickmarks scaled to the visible size of their frame
independently of its scroll. This coordinate system supports also CSS
scroll:overflow, transforms and the different positions.

Also add an auxiliary method to Range in order to provide a transform
friendly way to retrieve the absolute coordinates of the enclosing
bounding box without the adjustment operations that the existing
enclosingRect method does.

Tested by WebFrameTest WebKit unit test.

* dom/Range.cpp:
(WebCore::Range::transformFriendlyBoundingBox): add a transform-friendly equivalent of boundingBox.
(WebCore):
* dom/Range.h: move boundingBox to the group of non-transform-friendly methods.
(Range):

Source/WebKit/chromium:

Implement the funcionality of the find-in-page match rects API in WebFrame.
These methods keep a cache of the match rects in a special coordinate system
(find-in-page coordinates) and update them on size changes. They also allow
to recover the match closest to a given point, therefore enabling to move
to find matches when tapping on their corresponding tickmarks.

* WebKit.gyp: add FindInPageCoordinates.h / cpp.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::contentsSizeChanged): propagate didChangeContentsSize to WebFrameImpl.
* src/FindInPageCoordinates.cpp: Added.
(WebKit):
(WebKit::toNormalizedRect): auxiliary internal function.
(WebKit::findInPageRectFromAbsoluteRect): main coordinate conversion function.
(WebKit::findInPageRectFromRange): convenience conversion function for Ranges.
* src/FindInPageCoordinates.h: Added.
(WebCore):
(WebKit):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::FindMatch::FindMatch): find matches cache constructor.
(WebKit):
(WebKit::WebFrameImpl::find): clear match cache when appropriate and zoom into results on the Android port.
(WebKit::WebFrameImpl::stopFinding): clear matches cache.
(WebKit::WebFrameImpl::scopeStringMatches): add new results to the matches cache.
(WebKit::WebFrameImpl::increaseMatchCount): update the matches cache version.
(WebKit::WebFrameImpl::resetMatchCount): update the matches cache version.
(WebKit::WebFrameImpl::findMatchMarkersVersion): new API providing the matches cache version.
(WebKit::WebFrameImpl::clearFindMatchesCache): internal utility method to reset the matches cache.
(WebKit::WebFrameImpl::isActiveMatchFrameValid): internal utility method to check if the local frame is still in the frame tree.
(WebKit::WebFrameImpl::updateFindMatchRects): internal utility method to update the match result rects if required.
(WebKit::WebFrameImpl::activeFindMatchRect): new API providing the active find match rect in find-in-page coordinates.
(WebKit::WebFrameImpl::findMatchRects): new API returning the valid match rects in find-in-page coordinates.
(WebKit::WebFrameImpl::appendFindMatchRects): internal utility method to concatenate the match results of multiple frames.
(WebKit::WebFrameImpl::selectNearestFindMatch): new API selecting the find match closer to a point in find-in-page coordinates.
(WebKit::WebFrameImpl::nearestFindMatch): internal utility method to find the nearest find match to a point in a frame.
(WebKit::WebFrameImpl::selectFindMatch): internal utility method to select a match in the cache.
(WebKit::WebFrameImpl::WebFrameImpl): initialization of new variables.
(WebKit::WebFrameImpl::didChangeContentsSize): invalidate the cached match rect coordinates on frame content size changes.
* src/WebFrameImpl.h:
(WebCore):
(WebFrameImpl):
(WebKit::WebFrameImpl::activeMatchFrame): remove unrequired const.
(WebKit::WebFrameImpl::activeMatch): expose the range of the active match to allow testing.
(FindMatch): cache structure for find matches.
* tests/WebFrameTest.cpp: new test case for find-in-page match rects.
* tests/data/find_in_page.html: Added. Test case layout.
* tests/data/find_in_page_frame.html: Added. Test case layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStop Y-flipping CROS/ARM video textures
fischman@chromium.org [Sun, 12 Aug 2012 17:40:25 +0000 (17:40 +0000)]
Stop Y-flipping CROS/ARM video textures
https://bugs.webkit.org/show_bug.cgi?id=93769

Reviewed by Eric Seidel.

No new tests; there's no cros/arm bot yet, sadly.

* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads): drop the single-platform Y-flipping in prep for the platform doing the flip natively.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make it possible to build without QtTest/QtPrintSupport
commit-queue@webkit.org [Sun, 12 Aug 2012 16:52:54 +0000 (16:52 +0000)]
[Qt] Make it possible to build without QtTest/QtPrintSupport
https://bugs.webkit.org/show_bug.cgi?id=93492

Patch by Loïc Yhuel <loic.yhuel@softathome.com> on 2012-08-12
Reviewed by Tor Arne Vestbø.

.:

* Source/QtWebKit.pro: Disable tests if no testlib

Source/WebKit:

* WebKit1.pri: Optional printsupport

Source/WebKit/qt:

* Api/qwebframe.cpp:
(QWebFrame::print): Does nothing if no printsupport
* Api/qwebview.cpp:
(QWebView::print): Does nothing if no printsupport

Tools:

* DumpRenderTree/qt/DumpRenderTree.pro: Optional printsupport
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore):
(WebCore::DumpRenderTree::dryRunPrint): Does nothing if no printsupport
* QtTestBrowser/QtTestBrowser.pro: Optional printsupport
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome): No print menu if no printsupport
(LauncherWindow::print): Does nothing if no printsupport
* QtTestBrowser/launcherwindow.h:
* Tools.pro: Disable DRT/WTR if QtTest not present
* qmake/mkspecs/features/default_pre.prf: printsupport no more mandatory
* qmake/mkspecs/features/features.prf: Qt module availability tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSSRegions: Crash when using style in region for removed element.
mihnea@adobe.com [Sun, 12 Aug 2012 15:57:25 +0000 (15:57 +0000)]
CSSRegions: Crash when using style in region for removed element.
https://bugs.webkit.org/show_bug.cgi?id=93276

Reviewed by Abhishek Arya.

Source/WebCore:

When a RenderInline object from within a render flow thread is split, the cloned
hierarchy built during the split process does not have the inRenderFlowThread bit
set properly. If the cloned hierarchy is flowed into a region with region style rules,
we compute the style in region also for objects that do not have inRenderFlowThread bit
set and we store the computed style in region for caching purposes. But we only remove
an object style in region information if that object has the inRenderFlowThread bit set.
Under these circumstances, it is possible to remove a object with cached style in region
and without inRenderFlowThread bit set from the render tree and leave the associated cached
information un-removed. Such information will be accesses during the next paint phase of
the region, thus resulting a crash.

The fix is to modify RenderBlock::clone() and RenderInline::clone() functions to also copy the inRenderFlowThread bit
from the source into the clone, therefore the cloned hierarchies will have the inRenderFlowThread
bit set properly.

Test: fast/regions/removed-element-style-in-region-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clone): Replace former static RenderInline::cloneInline with member RenderInline::clone.
(WebCore::RenderInline::splitInlines):
* rendering/RenderInline.h:
(RenderInline):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setObjectStyleInRegion):
Added an assert to make sure that when we are computing style in region, we are doing for objects
with inRenderFlowThread set. Also, bail out early in this case to prevent further crashes.

LayoutTests:

Added test reproducing the problem.

* fast/regions/removed-element-style-in-region-crash-expected.txt: Added.
* fast/regions/removed-element-style-in-region-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Skip webintents/web-intents-obj-constructor.html test
commit-queue@webkit.org [Sun, 12 Aug 2012 15:46:42 +0000 (15:46 +0000)]
[EFL][WK2] Skip webintents/web-intents-obj-constructor.html test
https://bugs.webkit.org/show_bug.cgi?id=93778

Unreviewed EFL gardening.

Skip webintents/web-intents-obj-constructor.html for
WebKit2 EFL until WTR can print information about the
MessagePorts in a Web Intent (Bug 89072).

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-12

* platform/efl-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSet the access qualifier of two methods to query frame specific info of BitmapImage...
commit-queue@webkit.org [Sun, 12 Aug 2012 12:12:56 +0000 (12:12 +0000)]
Set the access qualifier of two methods to query frame specific info of BitmapImage to protected.
https://bugs.webkit.org/show_bug.cgi?id=90505

Patch by Huang Dongsung <luxtella@company100.net> on 2012-08-12
Reviewed by Eric Seidel.

Following 4 methods are protected.
  size_t frameCount();
  NativeImagePtr frameAtIndex(size_t);
  bool frameIsCompleteAtIndex(size_t);
  float frameDurationAtIndex(size_t);

So, 2 methds also should be protected because the frame info is only specific of
BitmapImage.
  bool frameHasAlphaAtIndex(size_t);
  ImageOrientation frameOrientationAtIndex(size_t);

On the other hand, this patch amended GraphicsContext3DCG.
- static_cast<BitmapImage*>(image)->frameHasAlphaAtIndex(0)
+ image->currentFrameHasAlpha()

This patch does not affect PNG, JPEG, BMP, and WEBP because those images
have only 0 indexed frame.
Thus, GIF, and ICO are affected. However, an above query to get Alpha
is for the image that is created by image->nativeImageForCurrentFrame(), so it
is proper to use image->currentFrameHasAlpha() instead of
image->frameHasAlphaAtIndex(0).

No new tests, because it is hard to test. We need an animated GIF that
one frame has alpha and another frame does not have alpha. However, I
cannot find the animated GIF file that suffices the requirement.

* platform/graphics/BitmapImage.h:
(BitmapImage):
* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDoesn't build with ENABLE_JIT=0
allan.jensen@nokia.com [Sun, 12 Aug 2012 11:47:34 +0000 (11:47 +0000)]
Doesn't build with ENABLE_JIT=0
https://bugs.webkit.org/show_bug.cgi?id=85042

Reviewed by Eric Seidel.

Include headers without which CallFrame.h does not build, and
fix gcc warning about comparing unsigned int with 0.

* dfg/DFGDriver.cpp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::isOpcode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomaster.cfg unittest cleanup: Show DeprecationWarnings with python >= 2.7 too
ossy@webkit.org [Sun, 12 Aug 2012 11:38:12 +0000 (11:38 +0000)]
cfg unittest cleanup: Show DeprecationWarnings with python >= 2.7 too
https://bugs.webkit.org/show_bug.cgi?id=90161

Reviewed by Eric Seidel.

* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkit fails IETC namespaces/prefix-007.xml
commit-queue@webkit.org [Sun, 12 Aug 2012 11:38:09 +0000 (11:38 +0000)]
webkit fails IETC namespaces/prefix-007.xml
https://bugs.webkit.org/show_bug.cgi?id=86137

Patch by Takashi Sakamoto <tasak@google.com> on 2012-08-12
Reviewed by Eric Seidel.

Source/WebCore:

If a namespace prefix or default namespace is declared more than once
only the last declaration shall be used.

parseAddNamespace doesn't check return value of WTF::HashMap<>::add.
If the return value's isNewEntry is true, the new entry is added with
the specified value. However, if isNewEntry is false, it is required
to update the store value.

No new tests. ietestcenter/css3/namespaces/prefix-007.xml and
ietestcenter/css3/namespaces/prefix-010.xml covers this change.

* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parserAddNamespace):
Modified to check m_namespaces.add's return value.
If the result says not a new entry, updated the value stored in
m_namespaces by using iterator in the result.

LayoutTests:

* platform/chromium/TestExpectations:
Enabled the layout tests, ietestcenter/css3/namespaces/prefix-007.xml
and ietestcenter/css3/namespaces/prefix-010.xml.
* platform/win/ietestcenter/css3/namespaces/prefix-007-expected.txt: Removed.
* platform/win/ietestcenter/css3/namespaces/prefix-010-expected.txt: Removed.
Removed old expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build with recent clang.
commit-queue@webkit.org [Sun, 12 Aug 2012 11:29:29 +0000 (11:29 +0000)]
Fix build with recent clang.
https://bugs.webkit.org/show_bug.cgi?id=90701

Patch by Nuno Lopes <nlopes@apple.com> on 2012-08-12
Reviewed by Eric Seidel.

* Shared/CommandLine.h:
(CommandLine):
* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::NotificationPermissionRequestManager):
* WebProcess/Notifications/NotificationPermissionRequestManager.h:
(NotificationPermissionRequestManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][UT] Delete shutdown method.
commit-queue@webkit.org [Sun, 12 Aug 2012 11:26:04 +0000 (11:26 +0000)]
[EFL][UT] Delete shutdown method.
https://bugs.webkit.org/show_bug.cgi?id=90785

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-08-12
Reviewed by Eric Seidel.

EWKTestBase class already has a shutdownAll method that can be used instead of shutdown.

* tests/UnitTestUtils/EWKTestBase.cpp:
* tests/UnitTestUtils/EWKTestBase.h:
(EWKTestBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove CSS's propertyNameStrings[] to from the header to the cpp file
benjamin@webkit.org [Sun, 12 Aug 2012 10:39:20 +0000 (10:39 +0000)]
Move CSS's propertyNameStrings[] to from the header to the cpp file
https://bugs.webkit.org/show_bug.cgi?id=93771

Reviewed by Eric Seidel.

The names of propertyNameStrings[] should never be accessed directly. The function getPropertyName()
return the correct string of propertyNameStrings.

To ensure the values are not accessed by mistake, move them from the header to the implementation.

* css/makeprop.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSSComputedStyleDeclaration::cssText() should use StringBuilder
benjamin@webkit.org [Sun, 12 Aug 2012 10:37:15 +0000 (10:37 +0000)]
CSSComputedStyleDeclaration::cssText() should use StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=93776

Reviewed by Eric Seidel.

String::append() is fairly inefficient when used to create a long string by appending a lot of small
pieces. StringBuilder is more approriate for the kind of operations done by CSSComputedStyleDeclaration::cssText().

This changes makes CSSComputedStyleDeclaration::cssText() about 6 times faster.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::cssText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed trivial build fix: Newer Qt versions don't implicitly include qwindow...
hausmann@webkit.org [Sun, 12 Aug 2012 07:18:47 +0000 (07:18 +0000)]
[Qt] Unreviewed trivial build fix: Newer Qt versions don't implicitly include qwindowsysteminterface.h
through the QTestLib headers anymore.

* DumpRenderTree/qt/EventSenderQt.cpp:
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/EventSenderProxyQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the build.
weinig@apple.com [Sun, 12 Aug 2012 06:10:31 +0000 (06:10 +0000)]
Fix the build.

* Platform/CoreIPC/Connection.h:
Add missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Get rid of ProcessModelSharedSecondaryThread
weinig@apple.com [Sun, 12 Aug 2012 06:09:16 +0000 (06:09 +0000)]
[WK2] Get rid of ProcessModelSharedSecondaryThread
https://bugs.webkit.org/show_bug.cgi?id=93652

Reviewed by Dan Bernstein.

The threaded model for WebKit2 has been broken a long time and its continued existence in
the code only serves to confuse. It's time to say good bye to it.

* UIProcess/API/C/WKContext.cpp:
* UIProcess/API/C/WKContextPrivate.h:
Remove WKContextGetSharedThreadContext().

* UIProcess/ProcessModel.h:
Remove ProcessModelSharedSecondaryThread from the ProcessModel enum.

* UIProcess/WebContext.cpp:
* UIProcess/WebContext.h:
Remove WebContext::sharedThreadContext().

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::connect):
(WebKit::WebProcessProxy::isLaunching):
* UIProcess/WebProcessProxy.h:
Remove the ThreadLauncher member and stop deriving from ThreadLauncher::Client.

* UIProcess/Launcher/ThreadLauncher.cpp: Removed.
* UIProcess/Launcher/ThreadLauncher.h: Removed.
* UIProcess/Launcher/efl/ThreadLauncherEfl.cpp: Removed.
* UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp: Removed.
* UIProcess/Launcher/mac/ThreadLauncherMac.mm: Removed.
* UIProcess/Launcher/qt/ThreadLauncherQt.cpp: Removed.
* UIProcess/Launcher/win/ThreadLauncherWin.cpp: Removed.
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* CMakeLists.txt:
* GNUmakefile.list.am:
* PlatformEfl.cmake:
* Target.pri:
Remove ThreadLauncher files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove ability to run MiniBrowser in threaded mode, it hasn't worked for a long time
weinig@apple.com [Sun, 12 Aug 2012 05:56:33 +0000 (05:56 +0000)]
Remove ability to run MiniBrowser in threaded mode, it hasn't worked for a long time
https://bugs.webkit.org/show_bug.cgi?id=93774

Reviewed by Dan Bernstein.

Remove support for opening windows using the shared thread WKContextRef. WKContextGetSharedThreadContext()
is going away, due to not working for a long time, and the first step is removing all the callers.

While here, remove the BrowserStatisticsWindow, which was not providing interesting information.

* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/mac/AppDelegate.h:
* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
* MiniBrowser/mac/BrowserStatisticsWindow.xib: Removed.
* MiniBrowser/mac/BrowserStatisticsWindowController.h: Removed.
* MiniBrowser/mac/BrowserStatisticsWindowController.m: Removed.
* MiniBrowser/mac/MainMenu.xib:
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable XPC Service based WebProcess with runtime flag
weinig@apple.com [Sun, 12 Aug 2012 05:29:41 +0000 (05:29 +0000)]
Enable XPC Service based WebProcess with runtime flag
https://bugs.webkit.org/show_bug.cgi?id=93773

Reviewed by Dan Bernstein.

Source/WebKit2:

Use the XPC Service for WebProcess code path if WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS
is set in the environment.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::launchXPCService):
Fix issue that was causing this code not to compile. This was not caught before since
the code was not being built.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connect):
Switch from hard coding always using the XPC Service code path if
HAVE(XPC) was true, to doing it conditionally on an environment variable.

Source/WTF:

* wtf/Platform.h:
Define HAVE_XPC on 10.7 and later.

Tools:

Convert --use-web-process-xpc-service passed to run-safari (and similar scripts)
to setting WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS=YES in the environment and setting
up __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_INSERT_LIBRARIES variables. NOTE: using
the XPC service is not the default code path.

* Scripts/webkitdirs.pm:
(shouldUseXPCServiceForWebProcess):
(determineShouldUseXPCServiceForWebProcess):
Add functions to extract --use-web-process-xpc-service from ARGV and set a
global variable.

(printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
Add help text for --use-web-process-xpc-service.

(runMacWebKitApp):
Set the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable and DYLD
if --use-web-process-xpc-service was passed on the command line.

(execMacWebKitAppForDebugging):
Set the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable and DYLD
if --use-web-process-xpc-service was passed on the command line. Also, bail
if both --use-web-process-xpc-service and --target-web-process are passed on
the command line, as we don't currently support using both.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake it possible to run the WebProcess as an XPC service
weinig@apple.com [Sun, 12 Aug 2012 00:00:40 +0000 (00:00 +0000)]
Make it possible to run the WebProcess as an XPC service
https://bugs.webkit.org/show_bug.cgi?id=92814

Reviewed by Anders Carlsson.

In this initial implementation, we are only using the XPC service
to launch the WebProcess, and then using the xpc_connection to send
over a mach_port to the WebProcess which is then used for creating
the CoreIPC connection.  In the future, we will switch to using the
xpc_connection for all messaging.

When the XPC service is enabled (it is compiled out by default for now), both
the XPC service and the old spawned process are runtime choosable.  This allows
the connect to pre-existing process workflow to continue to work.

There are a few additional caveats of this initial implementation:
    - It is only set up for the WebProcess (not for the PluginProcess)
    - The WebProcess shim does not work.
    - It requires a new environment variable to be set when launching
      to find the right service to launch (__XPC_DYLD_FRAMEWORK_PATH).

* Configurations/WebKit2Service.xcconfig: Added.
Add new configuration file for the service.

* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::Identifier::Identifier):
(CoreIPC::Connection::identifierIsNull):
Added to encapsulate the concept of a null identifier, now that it
is not possible to just compare to null.

* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::platformInitialize):
Change Connection::Identifier on the Mac to be a struct instead of
a typedef to a mach_port. This allows for the Connection to get both
the listening port and a reference to the xpc_connection (if it
compiled in). For now, all we do is retain the xpc_connection when it
is given to us, and release on Connection invalidation.

* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::createWebProcessConnection):
* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
Use the Connection::Identifier constructor.

* UIProcess/Launcher/ProcessLauncher.h:
(LaunchOptions):
Add a UseXPC option to the LaunchOptions so we can dynamically choose whether to use it.

(ProcessLauncher):
Make processTypeAsString public to allow better factoring in the implementation file
using static functions.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
Factor out the different launching options into helper functions. Always start by
trying to connect to a pre-existing process.

(WebKit::launchXPCService):
Create a new xpc_connection to our service, and give it a unique instance UUID.
Then, send a bootstrap message with a mach_port and wait for a reply to complete
the launch procedure.

(WebKit::tryPreexistingProcess):
Move the code to connect to a preexisting process to its own helper function.

(WebKit::ProcessLauncher::launchProcess):
Clean up a bit, calling the helper functions and adding call to launch the XPC service
if it is enabled.

* UIProcess/Launcher/mac/ThreadLauncherMac.mm:
(WebKit::webThreadBody):
(WebKit::ThreadLauncher::createWebThread):
Switch to using the constructor version of Identifier.

* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::PluginProcessProxy):
Don't try to use the XPC service for plugins yet.

(WebKit::PluginProcessProxy::didFinishLaunching):
Use Connection::identifierIsNull instead of explicit null check.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connect):
If XPC is compiled in (it currently is not) enable it by default.

* WebKit2.xcodeproj/project.pbxproj:
Add the new files and targets.

* WebKit2Service: Added.
* WebKit2Service/Info.plist: Added.
Add the paper work needed for an XPC service. Importantly, set up the XPC
service to be an Application service type, use NSApplicationMain as its run
loop, and allow for multiple instantiations. Also make sure the service acts
like the WebProcess binary by making it a LSUIElement, enabling LSFileQuarantine,
and setting the principle class to NSApplication.

* WebKit2Service/MainMacService.mm: Added.
(WebKit2ServiceEventHandler):
(main):
The initialization of the XPC service is quite a bit different than the
WebProcess version, since we don't get passed parameters in argv. Instead,
we initiate the XPC service via xpc_main, and wait for the bootstrap message
we sent in ProcessLauncherMac.mm. When we receive that message we can load
WebKit2 framework and initialize the WebProcess normally (we also get the mach_port
for the CoreIPC connection in that bootstrap message).

* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMainXPC):
Add a variant of WebProcessMain that is used for the XPC service case, where we don't
have command line arguments and don't need to talk to the mach bootstrap server.

(WebKit::WebProcessMain):
* mac/MainMac.cpp: Removed.
* mac/MainMacProcess.cpp: Copied from Source/WebKit2/mac/MainMac.cpp.
Rename MainMac to MainMacProcess to signify that it is different from the XPC
service main.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDo the DecimalNumber to String conversion on 8 bits
benjamin@webkit.org [Sat, 11 Aug 2012 21:17:27 +0000 (21:17 +0000)]
Do the DecimalNumber to String conversion on 8 bits
https://bugs.webkit.org/show_bug.cgi?id=93683

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-11
Reviewed by Andreas Kling.

Source/WebCore:

Numbers converted to string for CSS are unlikely to ever be concatenated with a 16bits string.
This patch change the conversion to be done to 8bits string in order to reduce memory allocations.

* css/CSSPrimitiveValue.cpp:
(WebCore::formatNumber):
* inspector/InspectorValues.cpp:
(WebCore::InspectorBasicValue::writeJSON):
* platform/graphics/Color.cpp:
(WebCore::Color::serialized): Instead of allocating a static WTF::String, we can simply append the
string literal to the output vector.

Source/WTF:

Modify DecimalNumber to do the conversion to string on LChar instead of UChar.

* wtf/DecimalNumber.cpp:
(WTF::DecimalNumber::toStringDecimal):
(WTF::DecimalNumber::toStringExponential):
* wtf/DecimalNumber.h:
(DecimalNumber):
* wtf/dtoa.h:
* wtf/text/StringBuffer.h:
(WTF::StringBuffer::operator[]): StringBuffer::operator[] was incorrectly typed to UChar, making
the method impossible to instanciate with LChar.
* wtf/text/WTFString.h:
(String):
(WTF::String::adopt): String::adopt() is modified to work with both LChar and UChar. StringImpl
already support that.
(WTF::appendNumber): Add support for any type that can instanciate the template.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebCore::findAtomicString(PropertyName) always convert the name to 16bits
benjamin@webkit.org [Sat, 11 Aug 2012 21:12:27 +0000 (21:12 +0000)]
WebCore::findAtomicString(PropertyName) always convert the name to 16bits
https://bugs.webkit.org/show_bug.cgi?id=93685

Reviewed by Geoffrey Garen.

Source/WebCore:

* bindings/js/JSDOMBinding.cpp:
(WebCore::findAtomicString):
Use the new AtomicString::find() to avoid calling StringImpl::characters().

Source/WTF:

Previously, WebCore::findAtomicString() was causing a conversion for the 8bit property name
to a 16bits due to the call to StringImpl::character16().

This patch fixes the issue by adding support for both 8bits and 16bits string in AtomicString::find().

* wtf/text/AtomicString.cpp:
(HashAndCharacters):
(WTF::HashAndCharactersTranslator::hash):
(WTF::HashAndCharactersTranslator::equal):
(WTF::HashAndCharactersTranslator::translate):
Use a template to make the struct and the translator independant of the CharacterType.

(WTF::AtomicString::add):
(WTF::findString):
(WTF::AtomicString::find): Change the API to take a StringImpl*. AtomicString can use
it efficiently to find the right string.
* wtf/text/AtomicString.h:
(AtomicString):
* wtf/text/StringImpl.h:
(StringImpl): Adapt the friends translator to support the template.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove QtSenderStack now we do not support __qt_sender__ anymore in Qt bridge
caio.oliveira@openbossa.org [Sat, 11 Aug 2012 20:01:53 +0000 (20:01 +0000)]
[Qt] Remove QtSenderStack now we do not support __qt_sender__ anymore in Qt bridge
https://bugs.webkit.org/show_bug.cgi?id=93767

Reviewed by Kenneth Rohde Christiansen.

Dead code after patch of bug 93649.

* bridge/qt/qt_instance.h:
(QtInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebarchive/ignore-noscript-if-scripting.html expected results should use .webarchive...
jonlee@apple.com [Sat, 11 Aug 2012 19:41:42 +0000 (19:41 +0000)]
webarchive/ignore-noscript-if-scripting.html expected results should use .webarchive extension
https://bugs.webkit.org/show_bug.cgi?id=93736
<rdar://problem/12077654>

Reviewed by Eric Seidel.

Because the test uses dumpDOMAsWebArchive(), the expected results extension should be .webarchive instead of .txt.
* webarchive/ignore-noscript-if-scripting-enabled-expected.webarchive: Renamed from LayoutTests/webarchive/ignore-noscript-if-scripting-enabled-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed.
inferno@chromium.org [Sat, 11 Aug 2012 16:07:22 +0000 (16:07 +0000)]
Unreviewed.

Removing newly added assert in r125351 since it is exposing
legitimate layout bugs in few tests. We will re-add the assert
after fixing those bugs. Failures are tracked in webkit bug 93766.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFromTrackedRendererMaps):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add support for HTML5 state object history API in FrameLoaderClientQt
pierre.rossi@gmail.com [Sat, 11 Aug 2012 13:26:27 +0000 (13:26 +0000)]
[Qt] Add support for HTML5 state object history API in FrameLoaderClientQt
https://bugs.webkit.org/show_bug.cgi?id=93648

Reviewed by Kenneth Rohde Christiansen.

Add support for push/replace/pop by implementing dispatchDidNavigateWithinPage.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidNavigateWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidPushStateWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidReplaceStateWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidPopStateWithinPage):
* WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame):
(tst_QWebFrame::setUrlUsingStateObject): Added. Tests that the urlChanged signal is fired.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Track block's positioned objects like percent-height descendants
leviw@chromium.org [Sat, 11 Aug 2012 10:44:53 +0000 (10:44 +0000)]
Source/WebCore: Track block's positioned objects like percent-height descendants
https://bugs.webkit.org/show_bug.cgi?id=89848

Reviewed by Abhishek Arya.

The previous method for tracking a RenderBlock's out-of-flow positioned descendants was error prone,
subject to becoming inconsistent, and in the case of removePositionedObjects, inefficient. This patch
extracts the algorithm used for percent height descendants and re-uses it for positioned objects. This same
method could further be re-used for floats.

This change removes the m_positionedObjects pointer, which brings RenderBlock's size down (yay!).

Test: fast/block/positioning/relayout-nested-positioned-elements-crash-2.html

* rendering/RenderBlock.cpp:
(SameSizeAsRenderBlock):
(WebCore):
(WebCore::removeBlockFromDescendantAndContainerMaps):
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::addOverflowFromPositionedObjects):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::markPositionedObjectsForLayout):
(WebCore::clipOutPositionedObjects):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertIntoTrackedRendererMaps):
(WebCore::RenderBlock::removeFromTrackedRendererMaps):
(WebCore::RenderBlock::positionedObjects):
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):
(WebCore::RenderBlock::removePositionedObjects):
(WebCore::RenderBlock::addPercentHeightDescendant):
(WebCore::RenderBlock::removePercentHeightDescendant):
(WebCore::RenderBlock::percentHeightDescendants):
(WebCore::RenderBlock::checkPositionedObjectsNeedLayout):
* rendering/RenderBlock.h:
(WebCore):
(RenderBlock):
(WebCore::RenderBlock::hasPositionedObjects):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::moveChildTo): Changing the fixme to reflect the assumption that the caller
has taken care of updating the positioned renderer maps is a decision not a bug. The ASSERT should help
assure this.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
* rendering/RenderView.cpp:
(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):

LayoutTests: Track block's positioned objects like percent-height children
https://bugs.webkit.org/show_bug.cgi?id=89848

Reviewed by Abhishek Arya.

Adding another test to confirm that RenderBlock's positioned children lists don't become
inconsistent.

* fast/block/positioning/relayout-nested-positioned-elements-crash-2-expected.txt: Added.
* fast/block/positioning/relayout-nested-positioned-elements-crash-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Bump harfbuzz dependency to v0.9.2
gyuyoung.kim@samsung.com [Sat, 11 Aug 2012 09:37:22 +0000 (09:37 +0000)]
[EFL] Bump harfbuzz dependency to v0.9.2
https://bugs.webkit.org/show_bug.cgi?id=93762

Reviewed by Eric Seidel.

EFL port has used harfbuzz 0.9.0 ver. However, the 0.9.2 version was released on 10th Aug 2012.
In addition, 0.9.0 ver. was disappeared. So, EFL port needs to use 0.9.2 ver. from now on.

* efl/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebGL] Add support for EXT_robustness
commit-queue@webkit.org [Sat, 11 Aug 2012 02:45:06 +0000 (02:45 +0000)]
[WebGL] Add support for EXT_robustness
https://bugs.webkit.org/show_bug.cgi?id=93379

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-08-10
Reviewed by George Staikos.

Source/WebCore:

Take advantage of EXT robustness in WebKit.

This commit makes WebKit use readnPixelsEXT, getnUniformfvEXT and
getnUniformivEXT instead of readPixels, getUniformfv and getUniformiv
when possible, and sets up the reset notification behaviour for
GLES platforms.

The reset behaviour has not yet been implemented in the BlackBerry
compositing thread, so for now on BlackBerry we just abort when
the context has been reset. This prevents undefined behaviour, but
can be improved in the future.

No new tests are needed because no new functionality is introduced.
Support for ARB robustness reset notification behaviour is already
in WebKit, and EXT robustness' reset notifcation behaviour is the
same. readnPixelsEXT replaces WebKit's existing mechanisms of
preventing buffer overflows.

RIM PR# 147510
Internally reviewed by Arvid Nilsson.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::setupFlags):
(WebCore::WebGLRenderingContext::getUniform):
(WebCore::WebGLRenderingContext::readPixels):
* html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
* platform/chromium/support/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::readnPixelsEXT):
(WebCore):
(WebCore::Extensions3DChromium::getnUniformfvEXT):
(WebCore::Extensions3DChromium::getnUniformivEXT):
* platform/graphics/Extensions3D.h:
* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::setContextLostCallback):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::makeContextCurrent):
* platform/graphics/blackberry/LayerRenderer.h:
(LayerRenderer):
* platform/graphics/chromium/Extensions3DChromium.h:
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::readnPixelsEXT):
(WebCore):
(WebCore::Extensions3DOpenGLCommon::getnUniformfvEXT):
(WebCore::Extensions3DOpenGLCommon::getnUniformivEXT):
* platform/graphics/opengl/Extensions3DOpenGLCommon.h:
(Extensions3DOpenGLCommon):
* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::getGraphicsResetStatusARB):
(WebCore):
(WebCore::Extensions3DOpenGLES::setEXTContextLostCallback):
(WebCore::Extensions3DOpenGLES::readnPixelsEXT):
(WebCore::Extensions3DOpenGLES::getnUniformfvEXT):
(WebCore::Extensions3DOpenGLES::getnUniformivEXT):
(WebCore::Extensions3DOpenGLES::supportsExtension):
* platform/graphics/opengl/Extensions3DOpenGLES.h:
(Extensions3DOpenGLES):

Source/WebKit:

RIM PR# 147510
Internally reviewed by Arvid Nilsson.

* CMakeLists.txt: Build system adaptation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMicrodata: item with itemprop attribute should not include the item itself in the...
arko@motorola.com [Sat, 11 Aug 2012 02:33:14 +0000 (02:33 +0000)]
Microdata: item with itemprop attribute should not include the item itself in the HTMLPropertiesCollection.
https://bugs.webkit.org/show_bug.cgi?id=93717

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/dom/MicroData/item-with-itemprop-attr.html
       fast/dom/MicroData/item-with-itemref-pointing-to-itself.html

* dom/PropertyNodeList.cpp:
(WebCore::PropertyNodeList::nodeMatches): Do not process the testElement if it is the owner node.
* html/HTMLPropertiesCollection.cpp:
(WebCore::nextNodeWithProperty): Traverse the next node only if previous node is microdata item
i.e, ownerNode or previous element does not have itemscope attribute specified.
(WebCore::HTMLPropertiesCollection::virtualItemAfter): Try to find the next property if current
is ownerNode.

LayoutTests:

Added test to ensure that item with itemprop attribute should not include
itself in its HTMLPropetiesCollection.

* fast/dom/MicroData/item-with-itemprop-attr-expected.txt: Added.
* fast/dom/MicroData/item-with-itemprop-attr.html: Added.
* fast/dom/MicroData/item-with-itemref-pointing-to-itself-expected.txt: Added.
* fast/dom/MicroData/item-with-itemref-pointing-to-itself.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test: plugins/nested-plugin-objects.html passes but causes subsequent test...
commit-queue@webkit.org [Sat, 11 Aug 2012 02:20:32 +0000 (02:20 +0000)]
Layout Test: plugins/nested-plugin-objects.html passes but causes subsequent test to fail on Windows.
https://bugs.webkit.org/show_bug.cgi?id=93741

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-10
Reviewed by Tim Horton.

plugins/nested-plugin-objects.html passes but causes subsequent test to fail on Windows.
plugins/netscape-dom-access-and-reload.html fails as a result.
Or if I skip that test, then plugins/netscape-dom-access.html fails (the next test in the list).

* platform/win/Skipped:
Added plugins/nested-plugin-objects.html to skip list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry][EFL][GTK][WIN][WX] Remove ScriptControllerXXX.cpp to reduce duplication
ryuan.choi@samsung.com [Sat, 11 Aug 2012 02:02:51 +0000 (02:02 +0000)]
[BlackBerry][EFL][GTK][WIN][WX] Remove ScriptControllerXXX.cpp to reduce duplication
https://bugs.webkit.org/show_bug.cgi?id=61424

Reviewed by Rob Buis.

ScriptControllerBlackBerry, ScriptControllerEfl, ScriptControllerGtk,
ScriptControllerWin and ScriptControllerWx are almost same.
In order to reduce duplication, this patch moves codes to ScriptController
and removes them.

No behavior change. Just a refactoring.

* GNUmakefile.list.am:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
* PlatformWinCE.cmake:
* WebCore.gypi:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/ScriptController.cpp:
(WebCore):
(WebCore::ScriptController::createScriptInstanceForWidget):
Moved from ScriptControllerXXX.cpp
* bindings/js/ScriptControllerBlackBerry.cpp: Removed.
* bindings/js/ScriptControllerEfl.cpp: Removed.
* bindings/js/ScriptControllerGtk.cpp: Removed.
* bindings/js/ScriptControllerWin.cpp: Removed.
* bindings/js/ScriptControllerWx.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayoutTest: fast/forms/basic-selects.html rebaselined.
commit-queue@webkit.org [Sat, 11 Aug 2012 01:55:12 +0000 (01:55 +0000)]
LayoutTest: fast/forms/basic-selects.html rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=93751

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-10
Reviewed by Tim Horton.

As per https://bugs.webkit.org/show_bug.cgi?id=92833,
this test needs to be rebaselined for other platforms.
Rebaselining for Windows.

* platform/win/fast/forms/basic-selects-expected.txt:
Rebaselining.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderQuote corrupts doubly linked list on insertion before head of list
commit-queue@webkit.org [Sat, 11 Aug 2012 01:49:14 +0000 (01:49 +0000)]
RenderQuote corrupts doubly linked list on insertion before head of list
https://bugs.webkit.org/show_bug.cgi?id=93750

Patch by Elliott Sprehn <esprehn@gmail.com> on 2012-08-10
Reviewed by Abhishek Arya.

Source/WebCore:

Fix bug where moving a RenderQuote instance before the first one in
the document would not update the m_previous pointer of the original
first RenderQuote to point back at the new one.

Test: fast/css-generated-content/quote-crash-93750.html

* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::attachQuote):

LayoutTests:

Test for moving around RenderQuote nodes before each other in an
existing document to catch corruption in the linked list of RenderQuote.

* fast/css-generated-content/quote-crash-93750-expected.txt: Added.
* fast/css-generated-content/quote-crash-93750.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r124416): fast/forms/basic-selects.html failing on Lion Debug Tests
dino@apple.com [Sat, 11 Aug 2012 01:45:46 +0000 (01:45 +0000)]
REGRESSION (r124416): fast/forms/basic-selects.html failing on Lion Debug Tests
https://bugs.webkit.org/show_bug.cgi?id=93538

Unreviewed gardening. Rebaseline of this test for Mac ports, and
remove expected failure.

* platform/mac/TestExpectations:
* platform/mac/fast/forms/basic-selects-expected.png:
* platform/mac/fast/forms/basic-selects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Missing platform expectations for this test. Results
dino@apple.com [Sat, 11 Aug 2012 01:33:47 +0000 (01:33 +0000)]
Unreviewed gardening. Missing platform expectations for this test. Results
are identical to chromium-mac at present.

* platform/mac/svg/repaint/text-mask-update-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago(r125185) http/tests/images/jpg-img-partial-load.html timeout on Lion
dino@apple.com [Sat, 11 Aug 2012 00:59:56 +0000 (00:59 +0000)]
(r125185) http/tests/images/jpg-img-partial-load.html timeout on Lion
https://bugs.webkit.org/show_bug.cgi?id=93636

Unreviewed test expectation update for Mac.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove forwarding headers for compositor-related WebKit API and update...
jamesr@google.com [Sat, 11 Aug 2012 00:55:17 +0000 (00:55 +0000)]
[chromium] Remove forwarding headers for compositor-related WebKit API and update includes
https://bugs.webkit.org/show_bug.cgi?id=93669

Reviewed by Adam Barth.

Source/Platform:

Removes a no-longer-necessary transitional define.

* chromium/public/WebCompositor.h:

Source/WebCore:

Updates all includes for compositor-related headers to refer consistently to the Platform API location.

* platform/chromium/support/WebCompositorImpl.h:

Source/WebKit/chromium:

This updates all includes for compositor-related headers to refer consistently to the Platform API location and
removes the now-unneeded forwarding headers in the client API location. I also updated and resorted other
platform API includes in modified header blocks.

* WebKit.gyp:
* public/WebCompositor.h: Removed.
* public/platform/WebContentLayer.h: Removed.
* public/platform/WebContentLayerClient.h: Removed.
* public/platform/WebExternalTextureLayer.h: Removed.
* public/platform/WebLayer.h: Removed.
* public/platform/WebLayerTreeView.h: Removed.
* public/platform/WebLayerTreeViewClient.h: Removed.
* public/platform/WebSolidColorLayer.h: Removed.
* src/WebCompositorInputHandlerImpl.h:
* src/WebContentLayerImpl.cpp:
* src/WebLayer.cpp:
* src/WebLayerTreeView.cpp:
* src/WebLayerTreeViewImpl.cpp:
* src/WebLayerTreeViewImpl.h:
* src/WebSolidColorLayer.cpp:
* src/WebViewImpl.h:
* tests/Canvas2DLayerBridgeTest.cpp:
* tests/GraphicsLayerChromiumTest.cpp:
* tests/TextureLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125339 268f45cc-cd09-0410-ab3c-d52691b4dbfc