mrowe@apple.com [Fri, 11 Jan 2008 08:04:21 +0000 (08:04 +0000)]
Attempt to fix the GTK+ and Qt builds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 11 Jan 2008 07:50:44 +0000 (07:50 +0000)]
Not reviewed, build fix.
- more build fixing
* WebDatabaseManager.cpp:
* WebSecurityOrigin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29393
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 11 Jan 2008 07:30:41 +0000 (07:30 +0000)]
Not reviewed, build fix.
- try to fix build
* WebDatabaseManager.cpp:
(WebDatabaseManager::databasesWithOrigin):
* WebSecurityOrigin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Fri, 11 Jan 2008 05:29:08 +0000 (05:29 +0000)]
wx build fix. Don't build dftables any longer since it's now a Perl script.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 11 Jan 2008 05:12:34 +0000 (05:12 +0000)]
Add FIXME for replacing YYPARSE_PARAM with %parse-param to CSSGrammar.y
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 11 Jan 2008 04:42:35 +0000 (04:42 +0000)]
Reviewed by Adele.
No functional changes, only code cleanup.
* css/MediaQueryEvaluator.cpp:
(WebCore::compareValue): renamed from cmpvalue
(WebCore::colorMediaFeatureEval):
(WebCore::device_aspect_ratioMediaFeatureEval):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::gridMediaFeatureEval):
(WebCore::device_heightMediaFeatureEval):
(WebCore::device_widthMediaFeatureEval):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 11 Jan 2008 04:19:48 +0000 (04:19 +0000)]
Reviewed by Anders Carlsson.
- fix a crash when calling alert() from a repeating timer
On non-Mac platforms, the PageGroupLoadDeferrer pauses DOM timers during
alert() and other similar functions, which deletes the actual
DOMWindowTimer objects and replaces them with new objects when resuming.
* bindings/js/kjs_window.cpp:
(KJS::Window::timerFired): Re-fetch the timer object from the map in
case it has been deleted or replaced.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 11 Jan 2008 03:51:00 +0000 (03:51 +0000)]
Not reviewed. Build fix.
- Attempt to fix mac build.
* Storage/WebDatabaseManager.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 11 Jan 2008 03:36:14 +0000 (03:36 +0000)]
WebCore:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
* GNUmakefile.am:
* WebCore.base.exp:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::postMessage):
* dom/Document.cpp:
(WebCore::Document::domain):
* page/Chrome.cpp:
(WebCore::Chrome::requestQuotaIncreaseForNewDatabase):
(WebCore::Chrome::requestQuotaIncreaseForDatabaseOperation):
* page/Chrome.h:
* page/ChromeClient.h:
* platform/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::copy):
(WebCore::SecurityOrigin::createFromIdentifier):
(WebCore::SecurityOrigin::stringIdentifier):
* platform/SecurityOrigin.h:
(WebCore::SecurityOrigin::host):
(WebCore::SecurityOrigin::protocol):
(WebCore::SecurityOrigin::port):
(WebCore::SecurityOrigin::equal):
* platform/SecurityOriginData.cpp: Removed.
* platform/SecurityOriginData.h: Removed.
* storage/Database.cpp:
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::securityOriginCopy):
* storage/Database.h:
* storage/DatabaseTracker.cpp:
(WebCore::SecurityOriginHash::hash):
(WebCore::SecurityOriginHash::equal):
(WebCore::SecurityOriginTraits::deletedValue):
(WebCore::SecurityOriginTraits::emptyValue):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForOrigin):
(WebCore::DatabaseTracker::hasEntryForDatabase):
(WebCore::DatabaseTracker::establishEntryForOrigin):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::detailsForNameAndOrigin):
(WebCore::DatabaseTracker::setDatabaseDetails):
(WebCore::DatabaseTracker::usageForDatabase):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::quotaForOrigin):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::addDatabase):
(WebCore::DatabaseTracker::deleteAllDatabases):
(WebCore::DatabaseTracker::deleteDatabasesWithOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):
(WebCore::notificationQueue):
(WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged):
(WebCore::DatabaseTracker::notifyDatabasesChanged):
* storage/DatabaseTracker.h:
* storage/DatabaseTrackerClient.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::runStatements):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
(WebCore::SQLTransaction::postflightAndCommit):
(WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
* svg/graphics/SVGImageEmptyClients.h:
(WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForNewDatabase):
(WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForDatabaseOperation):
WebKit/gtk:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::requestQuotaIncreaseForNewDatabase):
(WebKit::ChromeClient::requestQuotaIncreaseForDatabaseOperation):
* WebCoreSupport/ChromeClientGtk.h:
WebKit/mac:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
* Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager origins]):
(-[WebDatabaseManager databasesWithOrigin:]):
(-[WebDatabaseManager detailsForDatabase:withOrigin:]):
(-[WebDatabaseManager deleteDatabasesWithOrigin:]):
(-[WebDatabaseManager deleteDatabase:withOrigin:]):
* Storage/WebDatabaseTrackerClient.h:
* Storage/WebDatabaseTrackerClient.mm:
(WebDatabaseTrackerClient::dispatchDidModifyOrigin):
(WebDatabaseTrackerClient::dispatchDidModifyDatabase):
* Storage/WebSecurityOrigin.mm:
(-[WebSecurityOrigin initWithProtocol:domain:port:]):
(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin port]):
(-[WebSecurityOrigin usage]):
(-[WebSecurityOrigin quota]):
(-[WebSecurityOrigin setQuota:]):
(-[WebSecurityOrigin isEqual:]):
(-[WebSecurityOrigin dealloc]):
(-[WebSecurityOrigin finalize]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
(-[WebSecurityOrigin _core]):
* Storage/WebSecurityOriginInternal.h:
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::requestQuotaIncreaseForNewDatabase):
(WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
WebKit/qt:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::requestQuotaIncreaseForNewDatabase):
(WebCore::ChromeClientQt::requestQuotaIncreaseForDatabaseOperation):
* WebCoreSupport/ChromeClientQt.h:
WebKit/win:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
* WebChromeClient.cpp:
(WebChromeClient::requestQuotaIncreaseForNewDatabase):
(WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
* WebChromeClient.h:
* WebDatabaseManager.cpp:
(WebDatabaseManager::origins):
(WebDatabaseManager::databasesWithOrigin):
(WebDatabaseManager::detailsForDatabaseWithOrigin):
(WebDatabaseManager::deleteDatabasesWithOrigin):
(WebDatabaseManager::deleteDatabaseWithOrigin):
(WebDatabaseManager::dispatchDidModifyOrigin):
(WebDatabaseManager::dispatchDidModifyDatabase):
* WebDatabaseManager.h:
* WebSecurityOrigin.cpp:
(WebSecurityOrigin::createInstance):
(WebSecurityOrigin::WebSecurityOrigin):
(WebSecurityOrigin::protocol):
(WebSecurityOrigin::domain):
(WebSecurityOrigin::port):
(WebSecurityOrigin::usage):
(WebSecurityOrigin::quota):
(WebSecurityOrigin::setQuota):
* WebSecurityOrigin.h:
WebKit/wx:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
* WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::requestQuotaIncreaseForNewDatabase):
(WebCore::ChromeClientWx::requestQuotaIncreaseForDatabaseOperation):
* WebKitSupport/ChromeClientWx.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Fri, 11 Jan 2008 02:48:06 +0000 (02:48 +0000)]
2008-01-10 Stephanie <slewis@apple.com>
RS=Oliver.
Move svg/batik/text/smallfonts.svg to the right skip list.
* platform/mac-tiger/Skipped:
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 11 Jan 2008 02:09:55 +0000 (02:09 +0000)]
Reviewed by Sam.
Use the correct frame loader load method. Using the old method would not cause a
new window to be open if the frame navigation was not allowed.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::performRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 11 Jan 2008 00:55:03 +0000 (00:55 +0000)]
2008-01-10 Alp Toker <alp@atoker.com>
SVG font build fix for GTK+/autotools.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 11 Jan 2008 00:41:44 +0000 (00:41 +0000)]
BUILD FIX: Make dftables executable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 11 Jan 2008 00:35:14 +0000 (00:35 +0000)]
JavaScriptCore:
dftables should be rewritten as a script
<http://bugs.webkit.org/show_bug.cgi?id=16818>
<rdar://problem/5681463>
Reviewed by Darin.
Rewrote the dftables utility in Perl. Attempted to switch all
build systems to call the script directly instead of building
a binary first. Only the Xcode build was able to be tested.
* DerivedSources.make: Added pcre directory to VPATH and changed
to invoke dftables directly.
* GNUmakefile.am: Removed build information and changed to invoke
dftables directly.
* JavaScriptCore.vcproj/JavaScriptCore.sln: Removed reference to
dftables project.
* JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Ditto.
* JavaScriptCore.vcproj/dftables: Removed.
* JavaScriptCore.vcproj/dftables/dftables.vcproj: Removed.
* JavaScriptCore.xcodeproj/project.pbxproj: Removed dftables target.
* jscore.bkl: Removed dftables executable definition.
* pcre/dftables: Copied from JavaScriptCore/pcre/dftables.cpp.
* pcre/dftables.cpp: Removed.
* pcre/dftables.pro: Removed.
* pcre/pcre.pri: Removed references to dftables.cpp and changed to
invoke dftables directly.
WebKit/win:
dftables should be rewritten as a script
<http://bugs.webkit.org/show_bug.cgi?id=16818>
<rdar://problem/5681463>
Reviewed by Darin.
* WebKit.vcproj/WebKit.sln: Removed reference to dftables project.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 11 Jan 2008 00:23:13 +0000 (00:23 +0000)]
WebCore:
Reviewed by Sam Weinig and Anders Carlsson.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/5657355>
This patch makes two changes:
1) Java calls FrameLoader::load in a slightly different way than
JavaScript, which previously let a malicious web site bypass the
shouldAllowNavigation check. This patch adds that check to that
code path.
2) FrameLoader now wraps calls to m_frame->tree()->find(name) with
findFrameForNavigation, which calls shouldAllowNavigation. This
treats disallowed frame navigations as if the named frame did not
exist, resulting in a popup window when appropriate.
Tests: http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html
http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html
* WebCore.base.exp:
* bindings/js/kjs_window.cpp:
(KJS::WindowProtoFuncOpen::callAsFunction):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::createWindow):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::post):
(WebCore::FrameLoader::findFrameForNavigation):
* loader/FrameLoader.h:
WebKit/mac:
Reviewed by Anders Carlsson.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/5657355>
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView loadPluginRequest:]): call findFrameForNavigation
to ensure the shouldAllowNavigation check is made.
WebKitTools:
Reviewed by Anders Carlsson.
Make DRT track open windows instead of allocated windows so that
we can avoid ASSERTION due to late deallocs out of our control.
* DumpRenderTree/mac/DumpRenderTree.mm:
(dumpBackForwardListForAllWindows):
(runTest):
* DumpRenderTree/mac/DumpRenderTreeMac.h:
* DumpRenderTree/mac/DumpRenderTreeWindow.h:
* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
(+[DumpRenderTreeWindow openWindows]):
(-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
(-[DumpRenderTreeWindow close]):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::windowCount):
LayoutTests:
Reviewed by Anders Carlsson.
Tests for http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/5657355>
* http/tests/security/frameNavigation/resources/frame-with-link-to-navigate.html: Added.
* http/tests/security/frameNavigation/resources/frame-with-plugin-to-navigate.html: Added.
* http/tests/security/frameNavigation/resources/navigation-happened.html: Added.
* http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Added.
* http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html: Added.
* http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt: Added.
* http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html: Added.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29380
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Fri, 11 Jan 2008 00:10:05 +0000 (00:10 +0000)]
Written by Hyatt, reviewed by me
- fixed <rdar://problem/5654297> Mail crashes occurs at WebCore::FontFallbackList::fontDataAt() when attempting to display
a <video> element that uses controls attribute
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
force the render style to inherit from the media element's style; Hyatt filed 5682383 to cover cleaning
up this architecture, but this one-line fix will prevent the crash in the meantime
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 11 Jan 2008 00:02:16 +0000 (00:02 +0000)]
Whoops, did not mean to commit that.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 11 Jan 2008 00:00:57 +0000 (00:00 +0000)]
Fix fast/forms/input-radio-checked-tab.html
Meta key is not the same as Alt key on windows.
Reviewed by Darin.
* platform/win/KeyEventWin.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 10 Jan 2008 23:11:54 +0000 (23:11 +0000)]
Meta key is not the same as Alt key on windows.
Reviewed by Darin.
* DumpRenderTree/win/EventSender.cpp:
(keyDownCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 10 Jan 2008 23:11:27 +0000 (23:11 +0000)]
Fix fast/forms/input-radio-checked-tab.html
Meta key is not the same as Alt key on windows.
Reviewed by Darin.
* platform/win/KeyEventWin.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 10 Jan 2008 22:17:26 +0000 (22:17 +0000)]
* platform/win/Skipped: Removed a test that was fixed in r26826.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 10 Jan 2008 22:14:14 +0000 (22:14 +0000)]
* platform/win/Skipped: Removed a test that was fixed in r28372.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 10 Jan 2008 21:51:40 +0000 (21:51 +0000)]
Reviewed by John Sullivan.
<rdar://problem/5455889>
REGRESSION: BumperCar crashes when attempting to load a long invalid URL
Make sure to call FrameLoader::receivedMainResourceError before calling
FrameLoader::didFailToLoad. The call to receivedMainResourceError takes care of
clearing out the provisional document loader so that we won't call the didFail
ResourceLoadDelegate method twice. This also makes us call the FrameLoadDelegate method
didFailPrivisionalLoad before calling the ResourceLoadDelegate method, which Safari 2.0 does.
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::receivedError):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29372
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 10 Jan 2008 21:48:18 +0000 (21:48 +0000)]
Reviewed by Adele.
Fix <rdar://problem/5658048>
After <video> has finished playing, dragging the scroller on different location of controller starts to play movie
- Move to paused state if the playback had ended and the controller is used to seek to earlier time
- Pause video playback during drag so the knob does not constantly try to escape from the mouse pointer
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::updateMediaPlayer):
(WebCore::HTMLMediaElement::setPausedInternal):
* html/HTMLMediaElement.h:
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlTimelineElement::defaultEventHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Thu, 10 Jan 2008 21:33:19 +0000 (21:33 +0000)]
Reviewed by Adam Roben.
<rdar://problem/5667003> fast/dom/xmlhttprequest-html-response-encoding.html is failing
* xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Do not disable sniffing for file://
requests, as CFNetwork doesn't perform extension to MIME type mapping then.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29370
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 10 Jan 2008 21:23:34 +0000 (21:23 +0000)]
Fix many bugs by giving Windows one FrameView per page load
WebCore:
Fixes to allow multiple FrameViews on Windows
Reviewed by Hyatt.
* page/FrameView.cpp:
(WebCore::FrameView::FrameView): Added a new constructor that takes an
IntSize to specify the FrameView's initial size.
(WebCore::FrameView::scheduleRelayout): Added an assertion that our
Document is not in the page cache.
* page/FrameView.h:
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::~Widget): Add a warm, fuzzy ASSERT.
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::~Widget): Ditto.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget): Make sure to remove any existing
Widget from the Widget hierarchy before deleting it. One instance
where this is needed is when setWidget is called during FrameView
creation on Windows.
WebKit/win:
Fix many bugs by giving Windows one FrameView per page load
Bugs include:
<rdar://5659200>
Windows back/forward cache causes crashes in the layout tests
<rdar://5659355>
<http://bugs.webkit.org/show_bug.cgi?id=16808>
REGRESSION: PLT broken on Windows due to back/forward cache
<rdar://5663654>
<http://bugs.webkit.org/show_bug.cgi?id=16607>
Random crashes in FrameView::scheduleRelayout while surfing
Thinkgeek
On Windows until now we've only had one FrameView per Frame. Once the
back/forward cache was turned on this started causing assertions to
fail and crashes to occur due to a single FrameView being both in the
back/forward cache (possibly multiple times!) and used by a live
document. We now create a new FrameView for each page load, just as
Mac does.
This has the side-effect of plugging some of the world leaks seen at
the end of the PLT.
Reviewed by Hyatt.
* WebFrame.cpp:
(WebFrame::initWithWebFrameView): Don't create the FrameView right
away -- it'll be created when the load is committed.
(WebFrame::transitionToCommittedFromCachedPage): Match the Mac by no
longer calling resetMultipleFormSubmissionProtection here.
(WebFrame::transitionToCommittedForNewPage): Ported code from
-[WebCoreFrameBridge
createFrameViewWithNSView:marginWidth:marginHeight:],
-[WebCoreFrameBridge installInFrame:], and moved code here from
WebFrame::initWithWebFrameView and WebView::initWithFrame. WebCore
takes care of resetMultipleFormSubmissionProtection, just like it does
on the Mac.
* WebView.cpp:
(WebView::initWithFrame): Moved FrameView initialization code to
WebFrame::transitionToCommittedForNewPage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 10 Jan 2008 21:10:31 +0000 (21:10 +0000)]
2008-01-10 Alp Toker <alp@atoker.com>
Include math.h to get ceilf(). Part of the SVG font GTK+ build fix.
* svg/SVGFontFaceElement.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justin.garcia@apple.com [Thu, 10 Jan 2008 20:40:34 +0000 (20:40 +0000)]
Reviewed by Alice Liu.
<rdar://problem/5658603> Crash in InsertNodeBefore::doUnapply() on Undo in Yahoo Mail
<rdar://problem/5658709> Crash in RenderView::setSelection on Undo in Yahoo Mail
Make sure we have an updated layout before we perform any editing work.
* editing/EditCommand.cpp:
(WebCore::EditCommand::apply):
(WebCore::EditCommand::unapply):
(WebCore::EditCommand::reapply):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 10 Jan 2008 20:29:39 +0000 (20:29 +0000)]
2008-01-10 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Back out r29206 which was causing regressions in curl http job
cancellation.
* platform/network/curl/ResourceHandleManager.cpp
(ResourceHandleManager::cancel):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Thu, 10 Jan 2008 19:33:44 +0000 (19:33 +0000)]
WebCore:
Reviewed by Darin, Sam, and Adam.
- <rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
- link in gmail message displays JavaScript alert falsely complaining
about pop-up blocking
- When trying to open a new window, we now see if the user gesture
occurred in the global dynamic object instead of the frame since that is
the only place an event can occur.
* bindings/js/kjs_window.cpp: - Check the dynamic global object instead
of the frame.
(KJS::allowPopUp):
(KJS::showModalDialog):
(KJS::WindowProtoFuncOpen::callAsFunction):
WebKitTools:
Reviewed by Darin, Sam and Adam.
-<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
link in gmail message displays JavaScript alert falsely complaining
about pop-up blocking.
- Added the ability to enable the pop-up blocker via the
LayoutTestController.
* DumpRenderTree/LayoutTestController.cpp:
(setPopupBlockingEnabledCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting):
(resetWebViewToConsistentStateBeforeTesting):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setPopupBlockingEnabled):
LayoutTests:
Reviewed by Darin, Sam, and Adam.
-<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
link in gmail message displays JavaScript alert falsely complaining
about pop-up blocking
- When trying to open a new window, we now see if the user gesture
occurred in the global dynamic object instead of the frame since that is
the only place an event can occur.
* fast/events/open-window-from-another-frame-expected.txt: Added.
* fast/events/open-window-from-another-frame.html: Added.
* fast/events/resources/open-window-from-another-frame-otherFrame.html: Added.
* fast/events/resources/window-opened.html: Added.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 10 Jan 2008 19:29:32 +0000 (19:29 +0000)]
Fix for bug 16247, visibility:hidden not honored when hit testing inline replaced elements.
Reviewed by adele
Added fast/css/visibility-hit-test.html test case.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::nodeAtPoint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29364
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 10 Jan 2008 19:28:14 +0000 (19:28 +0000)]
Add new layout test for visibility bug.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 10 Jan 2008 17:39:03 +0000 (17:39 +0000)]
JavaScriptCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=16782
<rdar://problem/5675331> REGRESSION(r29266): Reproducible crash in fast/replaced/image-map.html
The crash resulted from a native object (DumpRenderTree's
EventSender) causing its wrapper to be invalidated (by clicking a
link that replaced the document in the window) and consequently
deallocated. The fix is to use RefPtrs to protect the native object
from deletion by self-invalidation.
* bindings/runtime_method.cpp:
(RuntimeMethod::callAsFunction):
* bindings/runtime_object.cpp:
(RuntimeObjectImp::fallbackObjectGetter):
(RuntimeObjectImp::fieldGetter):
(RuntimeObjectImp::methodGetter):
(RuntimeObjectImp::put):
(RuntimeObjectImp::defaultValue):
(RuntimeObjectImp::callAsFunction):
LayoutTests:
Reviewed by Darin Adler.
- re-enable crashing test after fixing http://bugs.webkit.org/show_bug.cgi?id=16782
<rdar://problem/5675331> REGRESSION(r29266): Reproducible crash in fast/replaced/image-map.html
* fast/replaced/image-map-expected.txt: Updated results for the new
behavior, which is to replace the document with the success message.
* fast/replaced/image-map.html: Copied from LayoutTests/fast/replaced/image-map.html-disabled.
* fast/replaced/image-map.html-disabled: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29362
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:47:59 +0000 (16:47 +0000)]
document QWebHistory
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29361
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:47:42 +0000 (16:47 +0000)]
Make the reset() functions not do anything on the default QWebSettings object.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29360
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:47:24 +0000 (16:47 +0000)]
rename QWebPageHistory to QWebHistory.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29359
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:39:06 +0000 (16:39 +0000)]
Documentation for QWebSettings
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29358
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:38:51 +0000 (16:38 +0000)]
Document QWebHistoryInterface.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29357
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:38:33 +0000 (16:38 +0000)]
Documentation for QWebFrame.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29356
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:19:55 +0000 (16:19 +0000)]
fix the drawing errors that where introduced due to refactoring.
Correctly clip to the rectangle we want to draw in ScrollView::paint().
Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:19:23 +0000 (16:19 +0000)]
Added a whole bunch of docs for QWebPage and fixed some minor doc glitches in QWebView.
Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29354
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:19:04 +0000 (16:19 +0000)]
Temporarily disable gzip decompression in qhttp due to a bug.
Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 15:28:59 +0000 (15:28 +0000)]
http://bugs.webkit.org/show_bug.cgi?id=16588
Added a (last) Frame argument to ResourceHandle::loadResourceSynchronously.
This allows implementing the synchronous loading correctly for the Qt port where the networking
backend is bound to the page.
Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29352
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 10 Jan 2008 15:22:07 +0000 (15:22 +0000)]
Reviewed by John Sullivan.
- make more tests pass on Windows by forcing font fallback to match
Mac OS X.
* fast/css/beforeSelectorOnCodeElement.html:
* fast/css/rtl-ordering.html:
* fast/css/text-security.html:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 10 Jan 2008 08:49:42 +0000 (08:49 +0000)]
wx build fix for changes in r29328
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Thu, 10 Jan 2008 03:48:41 +0000 (03:48 +0000)]
Reviewed by Sam.
- refactor SecurityOrigin in preparation for merging with SecurityOriginData
* platform/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::create):
(WebCore::SecurityOrigin::createForFrame):
* platform/SecurityOrigin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29349
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 10 Jan 2008 03:03:11 +0000 (03:03 +0000)]
WebCore:
Tabs with ctrl, meta, or altgraph modifier key down should not advance focus.
Reviewed by Darin.
Test: fast/forms/tabs-with-modifiers.html
* page/EventHandler.cpp:
(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::defaultTabEventHandler): bail if ctrl, meta, or altgraph key is down.
Clean up the code a bit.
* page/EventHandler.h:
* page/FocusController.cpp: Remove the advanceFocus() that takes in a KeyboardEvent. It was
only called in EventHandler::defaultTabEventHandler() but we have cleaned up the code there and
no longer needs it.
* page/FocusController.h:
LayoutTests:
Tests tabbing with different combinations of modifiers keys, where some
should advance focus and some should not.
Reviewed by Darin.
* fast/forms/tabs-with-modifiers-expected.txt: Added.
* fast/forms/tabs-with-modifiers.html: Copied from fast/forms/focus2.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 10 Jan 2008 02:57:42 +0000 (02:57 +0000)]
Fix crash that could happen if the key we are passing to the HashMap is 0 in WebView::interpretKeyEvent().
Reviewed by Darin.
* WebView.cpp:
(WebView::interpretKeyEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Thu, 10 Jan 2008 02:51:41 +0000 (02:51 +0000)]
Reviewed by Darin.
- add some more renames, adjust some
* Scripts/do-webcore-rename:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29346
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 10 Jan 2008 01:41:13 +0000 (01:41 +0000)]
Reviewed by Mitz.
Fix http://bugs.webkit.org/show_bug.cgi?id=16376
<rdar://problem/5665206>
<video> element fails to play frames when navigating back to page (16376)
Don't make MediaPlayer visible when it is actually in page cache.
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updatePlayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29345
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 10 Jan 2008 01:38:51 +0000 (01:38 +0000)]
Reviewed by Darin.
<rdar://problem/5532361>
CrashTracer: 9840 crashes in Safari at com.apple.JavaScriptCore: KJS::Bindings::CInstance::~CInstance [in-charge deleting] + 35
Clear the frame's plugin root objects so that they don't outlive the plugin bundle.
* page/Frame.cpp:
(WebCore::Frame::pageDestroyed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29344
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 10 Jan 2008 01:37:32 +0000 (01:37 +0000)]
Reviewed by Darin Adler.
- move a WebKit test which was inadvertently added to a test suite
directory into a custom test directory and change it to give the same
results on Windows.
* css1/text_properties/text-transCapitalize.html: Removed.
* fast/text/capitalize-boundaries.html: Copied from LayoutTests/css1/text_properties/text-transCapitalize.html,
updated the Bugzilla URL and added @font-face rules to make Windows
results match Mac OS X.
* platform/mac/css1/text_properties/text-transCapitalize-expected.checksum: Removed.
* platform/mac/css1/text_properties/text-transCapitalize-expected.png: Removed.
* platform/mac/css1/text_properties/text-transCapitalize-expected.txt: Removed.
* platform/mac/fast/text/capitalize-boundaries-expected.checksum: Copied from LayoutTests/platform/mac/css1/text_properties/text-transCapitalize-expected.checksum.
* platform/mac/fast/text/capitalize-boundaries-expected.png: Copied from LayoutTests/platform/mac/css1/text_properties/text-transCapitalize-expected.png.
* platform/mac/fast/text/capitalize-boundaries-expected.txt: Copied from LayoutTests/platform/mac/css1/text_properties/text-transCapitalize-expected.txt.
* platform/qt/css1/text_properties/text-transCapitalize-expected.txt: Removed.
* platform/win/Skipped: Removed css1/text_properties/text-transCapitalize.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Wed, 9 Jan 2008 23:02:07 +0000 (23:02 +0000)]
Reviewed by Adam Roben and Anders Carlsson
- fixed <rdar://problem/5469398> Repro assertion failure in context menu code due to
missing-but-expected Reload item
* platform/ContextMenu.cpp:
(WebCore::ContextMenu::populate):
use isLoadingInAPISense when deciding whether to include Stop or Reload in context
menu, to match the WebKit API
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 9 Jan 2008 20:26:47 +0000 (20:26 +0000)]
2008-01-09 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16802
[GTK] Missing gtk properties
Add missing properties to WebKitViewFrame and WebKitWebView.
* WebView/webkitprivate.h: add some useful defines for param specs
* WebView/webkitwebframe.cpp:
(webkit_web_frame_get_property): added
(webkit_web_frame_class_init): add name, title and uri read-only properties
* WebView/webkitwebview.cpp:
(webkit_web_view_get_property): add editable property read
(webkit_web_view_set_property): added for editable property write
(webkit_web_view_class_init): add read-write editable property
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 9 Jan 2008 20:13:07 +0000 (20:13 +0000)]
Reviewed by Adam Roben.
<rdar://problem/5673716> fast/loader/opaque-base-url.html is failing
<rdar://problem/5670275> fast/loader/onunload-form-submit-crash.html is failing
<rdar://problem/5667277> fast/loader/onunload-form-submit-crash-2.html is failing
* fast/loader/meta-refresh-vs-open.html: Changed to be more DRT-friendly.
* platform/win/Skipped: Removed tests that were victims of the above.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 9 Jan 2008 20:10:33 +0000 (20:10 +0000)]
Reviewed by Adam Roben.
Fix fast/encoding/frame-default-enc.html, which is failing on buildbot.
Internal frame names for this test are changing for no apparent reason (see r25269).
Make the test independent of the names.
* fast/encoding/frame-default-enc-expected.txt:
* fast/encoding/frame-default-enc.html:
* fast/encoding/resources/frame-default-enc-frame.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 9 Jan 2008 18:03:06 +0000 (18:03 +0000)]
Fix Windows debug build for opensource developers.
* WebCore.vcproj/QTMovieWin.vcproj: Use the correct library suffix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 9 Jan 2008 18:01:20 +0000 (18:01 +0000)]
Update some test results
Reviewed by Anders.
* fast/dom/Window/window-properties-expected.txt: Updated after
r29328.
* platform/win/media/audio-controls-rendering-expected.txt:
Regenerated results with the correct fonts.
* platform/win/media/video-aspect-ratio-expected.txt: Ditto.
* platform/win/media/video-controls-rendering-expected.txt: Ditto.
* platform/win/media/video-transformed-expected.txt: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 9 Jan 2008 09:23:16 +0000 (09:23 +0000)]
Reworked by Eric, Reviewed by Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=9454
Add support for :lang inheritance and xml:lang support.
Tests: fast/selectors/lang-inheritance.html
fast/selectors/lang-inheritance2.html
fast/selectors/lang-vs-xml-lang.html
fast/selectors/lang-vs-xml-lang-xhtml.xhtml
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement): Do not share style between elements with
different LANG-attribute.
(WebCore::CSSStyleSelector::checkOneSelector): Change :lang() to recursively check the LANG attribute
for all the elements parents and the content-language of the document.
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv): Parse MIME Content-Language
* dom/Document.h:
(WebCore::Document::contentLanguage):
(WebCore::Document::setContentLanguage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 9 Jan 2008 04:49:23 +0000 (04:49 +0000)]
Reviewed by Brady.
Bug 16678: Unreproducible crash in KJS::JSObject::inherits() after using Web Inspector
http://bugs.webkit.org/show_bug.cgi?id=16678
Add a NULL check for controller before calling JSObjectSetPrivate.
* page/InspectorController.cpp:
(WebCore::InspectorController::~InspectorController):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 9 Jan 2008 04:45:32 +0000 (04:45 +0000)]
2008-01-08 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=15610
[GTK] Text rendering using Pango
Use Pango to render Complex path text.
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::utf16_to_utf8):
(WebCore::convertUniCharToUTF8):
(WebCore::setPangoAttributes):
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 9 Jan 2008 04:35:32 +0000 (04:35 +0000)]
Reviewed by Darin Adler.
<rdar://problem/5665860> With the web inspector displayed, a crash occurs
at WebCore::Frame::document() when navigating back to previous page
This fixes the crash, but the inspector was totally broken with back/forward.
So this also fixes back/forward navigation so the right main resource shows
up in the inspector.
* page/InspectorController.cpp:
(WebCore::addSourceToFrame): Add some null checks for the frame when
getting the textEncoding. This was the crash.
(WebCore::InspectorController::addScriptResource): Create a script object
only if needed, and always add it by calling addResource.
(WebCore::InspectorController::didCommitLoad): Check if the loader is
loading from the page cache, and clear m_mainResource. If the load is
normal, then call addAndUpdateScriptResource with the main resource.
(WebCore::InspectorController::identifierForInitialRequest): If the load
is from the page cache and the resource is the main resource call
addAndUpdateScriptResource since didCommitLoad did not do it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 9 Jan 2008 04:15:09 +0000 (04:15 +0000)]
2008-01-08 Alp Toker <alp@atoker.com>
Back out VIDEO by default in the GTK+ qmake build. The build bot
doesn't have the necessary libraries installed.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 9 Jan 2008 03:41:13 +0000 (03:41 +0000)]
2008-01-08 Alp Toker <alp@atoker.com>
Win build fix for breakage introduced in r29328.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 9 Jan 2008 03:37:45 +0000 (03:37 +0000)]
2008-01-08 Alp Toker <alp@atoker.com>
Rubber-stamped by Mark Rowe.
Enable VIDEO by default in the GTK+ qmake build.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 9 Jan 2008 03:13:14 +0000 (03:13 +0000)]
2008-01-08 Alp Toker <alp@atoker.com>
GTK+ VIDEO build fix for breakage introduced in r29328.
Issue noticed by Ori_B.
* GNUmakefile.am:
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 9 Jan 2008 01:41:16 +0000 (01:41 +0000)]
WebCore:
Reviewed by Darin.
HTMLAudioElement needs generated constructor. Otherwise video instanceof HTMLAudioElement is true which is
bit strange.
Renamed custom constructor JSHTMLAudioElementConstructor to JSAudioConstructor to avoid name clashes.
Test: media/constructors.html
* ChangeLog:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSAudioConstructor.cpp: Copied from WebCore/bindings/js/JSHTMLAudioElementConstructor.cpp.
(WebCore::JSAudioConstructor::JSAudioConstructor):
(WebCore::JSAudioConstructor::implementsConstruct):
(WebCore::JSAudioConstructor::construct):
* bindings/js/JSAudioConstructor.h: Copied from WebCore/bindings/js/JSHTMLAudioElementConstructor.h.
* bindings/js/JSHTMLAudioElementConstructor.cpp: Removed.
* bindings/js/JSHTMLAudioElementConstructor.h: Removed.
* bindings/js/kjs_window.cpp:
(KJS::Window::getValueProperty):
* html/HTMLAudioElement.idl:
LayoutTests:
Reviewed by Darin.
Test that media element constructors behave consistently.
* media/constructors-expected.txt: Added.
* media/constructors.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 9 Jan 2008 00:45:11 +0000 (00:45 +0000)]
Reviewed by Mitz.
Don't add the applet widget to the view, that's done later by RenderApplet.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::createJavaAppletWidget):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 9 Jan 2008 00:35:46 +0000 (00:35 +0000)]
* fast/replaced/image-map.html: Disabled this until bug 16782 is
fixed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 9 Jan 2008 00:35:21 +0000 (00:35 +0000)]
Fix fast/dom/Window/window-properties.html on Windows
WebCore:
* bindings/scripts/CodeGeneratorJS.pm: Touch this so the bindings will
rebuild on Windows now that the media elements are enabled.
LayoutTests:
Fix fast/dom/Window/window-properties.html on Windows
Windows now has the same results as other platforms.
* platform/win/fast/dom/Window/window-properties-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 9 Jan 2008 00:17:19 +0000 (00:17 +0000)]
- remove a test from the skipped list
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 9 Jan 2008 00:12:57 +0000 (00:12 +0000)]
WebCore:
Reviewed by Weinig.
Add security check for Audio constructor.
* bindings/js/kjs_window.cpp:
(KJS::Window::getValueProperty):
LayoutTests:
Reviewed by Weinig.
Test cross-frame access to media properties.
* http/tests/security/cross-frame-access-get-expected.txt:
* http/tests/security/cross-frame-access-get.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 8 Jan 2008 23:51:28 +0000 (23:51 +0000)]
Reviewed by Adam Roben.
<rdar://problem/5676515> List of scripts and images missing when opening Web Inspector from new window (16567)
InspectorController::didLoadResourceFromMemoryCache was not being called for
resources that loaded from the memory cache that the FrameLoader's client
has already been notified about. This fix always calls the InspectorController
when loading a memory cached resource. No test possible for the Web Inspector.
* loader/DocLoader.cpp:
(WebCore::DocLoader::checkCacheObjectStatus): Moved most of the logic to
FrameLoader::loadedResourceFromMemoryCache so the InspectorController can always be notified.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::didTellClientAboutLoad): Renamed from didTellBridgeAboutLoad.
(WebCore::FrameLoader::haveToldClientAboutLoad): Renamed from haveToldBridgeAboutLoad.
(WebCore::FrameLoader::loadResourceSynchronously): Call the renamed didTellClientAboutLoad.
(WebCore::FrameLoader::loadedResourceFromMemoryCache): Only takes a CachedResource now.
Always call InspectorController. If the resource's sendResourceLoadCallbacks is false or
didTellClientAboutLoad is true, do an early return. Otherwise call the client and call
didTellClientAboutLoad.
(WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Removed, work now done
in FrameLoader::loadedResourceFromMemoryCache.
* loader/FrameLoader.h: Renamed {didTell,haveTold}BridgeAboutLoad to {didTell,haveTold}ClientAboutLoad.
Made loadedResourceFromMemoryCache only take a CachedResource. Renamed m_urlsBridgeKnowsAbout to
m_urlsClientKnowsAbout.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::load): Call the renamed didTellClientAboutLoad.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Tue, 8 Jan 2008 22:11:09 +0000 (22:11 +0000)]
Rubber stamped by Darin.
Enable media tests on Windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 8 Jan 2008 21:47:52 +0000 (21:47 +0000)]
Rubber-stamped by Sam Weinig.
- prefix all member variables in CSSStyleSelector with m_
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::init):
(WebCore::CSSStyleSelector::setEncodedURL):
(WebCore::CSSStyleSelector::loadDefaultStyle):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::initElementAndPseudoState):
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::updateFont):
(WebCore::CSSStyleSelector::cacheBorderAndBackground):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::checkOneSelector):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapBackgroundImage):
(WebCore::CSSStyleSelector::mapBackgroundSize):
(WebCore::CSSStyleSelector::mapBackgroundXPosition):
(WebCore::CSSStyleSelector::mapBackgroundYPosition):
(WebCore::CSSStyleSelector::checkForTextSizeAdjust):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::):
(WebCore::CSSRuleData::CSSRuleData):
(WebCore::CSSRuleDataList::CSSRuleDataList):
(WebCore::CSSRuleDataList::append):
* css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
* rendering/RenderStyle.cpp:
(WebCore::RenderStyle::isStyleAvailable):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Tue, 8 Jan 2008 21:43:04 +0000 (21:43 +0000)]
Removed unnecessary files from Copy Bundle Resources build phase.
Reviewed by Sam.
* WebCore.xcodeproj/project.pbxproj: Files removed from build phase:
DOMCoreException.idl
EventException.idl
MessageEvent.idl
SVGAElement.idl
SVGAngle.idl
SVGAnimateColorElement.idl
SVGAnimateElement.idl
SVGAnimateTransformElement.idl
SVGAnimatedAngle.idl
SVGAnimatedBoolean.idl
SVGAnimatedEnumeration.idl
SVGAnimatedInteger.idl
SVGAnimatedLength.idl
SVGAnimatedLengthList.idl
SVGAnimatedNumber.idl
SVGAnimatedNumberList.idl
SVGAnimatedPathData.idl
SVGAnimatedPoints.idl
SVGAnimatedPreserveAspectRatio.idl
SVGAnimatedRect.idl
SVGAnimatedString.idl
SVGAnimatedTransformList.idl
SVGAnimationElement.idl
SVGCSSPropertyNames.in
SVGCSSValueKeywords.in
SVGCircleElement.idl
SVGClipPathElement.idl
SVGColor.idl
SVGComponentTransferFunctionElement.idl
SVGCursorElement.idl
SVGDefinitionSrcElement.idl
SVGDefsElement.idl
SVGDescElement.idl
SVGDocument.idl
SVGElement.idl
SVGElementInstance.idl
SVGElementInstanceList.idl
SVGEllipseElement.idl
SVGException.idl
SVGExternalResourcesRequired.idl
SVGFEBlendElement.idl
SVGFEColorMatrixElement.idl
SVGFEComponentTransferElement.idl
SVGFECompositeElement.idl
SVGFEDiffuseLightingElement.idl
SVGFEDisplacementMapElement.idl
SVGFEDistantLightElement.idl
SVGFEFloodElement.idl
SVGFEFuncAElement.idl
SVGFEFuncBElement.idl
SVGFEFuncGElement.idl
SVGFEFuncRElement.idl
SVGFEGaussianBlurElement.idl
SVGFEImageElement.idl
SVGFEMergeElement.idl
SVGFEMergeNodeElement.idl
SVGFEOffsetElement.idl
SVGFEPointLightElement.idl
SVGFESpecularLightingElement.idl
SVGFESpotLightElement.idl
SVGFETileElement.idl
SVGFETurbulenceElement.idl
SVGFilterElement.idl
SVGFilterPrimitiveStandardAttributes.idl
SVGFitToViewBox.idl
SVGFontElement.idl
SVGFontFaceElement.idl
SVGFontFaceFormatElement.idl
SVGFontFaceNameElement.idl
SVGFontFaceSrcElement.idl
SVGFontFaceUriElement.idl
SVGForeignObjectElement.idl
SVGGElement.idl
SVGGlyphElement.idl
SVGGradientElement.idl
SVGImageElement.idl
SVGLangSpace.idl
SVGLength.idl
SVGLengthList.idl
SVGLineElement.idl
SVGLinearGradientElement.idl
SVGLocatable.idl
SVGMarkerElement.idl
SVGMaskElement.idl
SVGMatrix.idl
SVGMetadataElement.idl
SVGMissingGlyphElement.idl
SVGNumber.idl
SVGNumberList.idl
SVGPaint.idl
SVGPathElement.idl
SVGPathSeg.idl
SVGPathSegArcAbs.idl
SVGPathSegArcRel.idl
SVGPathSegClosePath.idl
SVGPathSegCurvetoCubicAbs.idl
SVGPathSegCurvetoCubicRel.idl
SVGPathSegCurvetoCubicSmoothAbs.idl
SVGPathSegCurvetoCubicSmoothRel.idl
SVGPathSegCurvetoQuadraticAbs.idl
SVGPathSegCurvetoQuadraticRel.idl
SVGPathSegCurvetoQuadraticSmoothAbs.idl
SVGPathSegCurvetoQuadraticSmoothRel.idl
SVGPathSegLinetoAbs.idl
SVGPathSegLinetoHorizontalAbs.idl
SVGPathSegLinetoHorizontalRel.idl
SVGPathSegLinetoRel.idl
SVGPathSegLinetoVerticalAbs.idl
SVGPathSegLinetoVerticalRel.idl
SVGPathSegList.idl
SVGPathSegMovetoAbs.idl
SVGPathSegMovetoRel.idl
SVGPatternElement.idl
SVGPoint.idl
SVGPointList.idl
SVGPolygonElement.idl
SVGPolylineElement.idl
SVGPreserveAspectRatio.idl
SVGRadialGradientElement.idl
SVGRect.idl
SVGRectElement.idl
SVGRenderingIntent.idl
SVGSVGElement.idl
SVGScriptElement.idl
SVGSetElement.idl
SVGStopElement.idl
SVGStringList.idl
SVGStylable.idl
SVGStyleElement.idl
SVGSwitchElement.idl
SVGSymbolElement.idl
SVGTRefElement.idl
SVGTSpanElement.idl
SVGTests.idl
SVGTextContentElement.idl
SVGTextElement.idl
SVGTextPathElement.idl
SVGTextPositioningElement.idl
SVGTitleElement.idl
SVGTransform.idl
SVGTransformList.idl
SVGTransformable.idl
SVGURIReference.idl
SVGUnitTypes.idl
SVGUseElement.idl
SVGViewElement.idl
SVGViewSpec.idl
SVGZoomAndPan.idl
SVGZoomEvent.idl
XMLHttpRequestException.idl
XPathException.idl
character-sets.txt
mac-encodings.txt
make-charset-table.pl
svgattrs.in
svgtags.in
xlinkattrs.in
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 8 Jan 2008 21:34:52 +0000 (21:34 +0000)]
2008-01-08 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Support copying the selected URL to the clipboard.
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeURL): implemented
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Tue, 8 Jan 2008 21:27:13 +0000 (21:27 +0000)]
Renamed CharacterData::m_str to m_data
Rubber-stamped by Adam again.
No test cases added since there is no change in behavior.
* dom/CDATASection.cpp:
* dom/CharacterData.cpp:
(WebCore::CharacterData::CharacterData):
(WebCore::CharacterData::setData):
(WebCore::CharacterData::substringData):
(WebCore::CharacterData::appendData):
(WebCore::CharacterData::insertData):
(WebCore::CharacterData::deleteData):
(WebCore::CharacterData::replaceData):
(WebCore::CharacterData::nodeValue):
(WebCore::CharacterData::containsOnlyWhitespace):
(WebCore::CharacterData::dispatchModifiedEvent):
(WebCore::CharacterData::checkCharDataOperation):
(WebCore::CharacterData::dump):
* dom/CharacterData.h:
* dom/Comment.cpp:
* dom/Text.cpp:
(WebCore::Text::splitText):
(WebCore::Text::createRenderer):
(WebCore::Text::recalcStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 8 Jan 2008 20:52:38 +0000 (20:52 +0000)]
Fix a couple of compiler warnings.
Reviewed by Mitz.
* platform/win/ThreadingWin.cpp:
* platform/win/UniscribeController.cpp: Remove unused function.
(WebCore::UniscribeController::advance): Fix bogus warning about un-initialized variable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Tue, 8 Jan 2008 20:50:58 +0000 (20:50 +0000)]
WebCore:
Reviewed by Darin.
Fix for <rdar://problem/5674667> fast/forms/slider-mouse-events.html is broken by media control checkin 29257
* rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler):
After fixing a bug in EventHandler to make sure events always go to the capturing node, this bug was exposed.
MouseMove and MouseUp events were going to the thumb element, but not to the slider input element.
This change makes the input element the capturing node, and then the input element forwards the mouse events to the thumb element.
I also added a missing call to setDefaultHandled for the mousemove event.
LayoutTests:
Reviewed by Darin.
Updated test for:
<rdar://problem/5674667> fast/forms/slider-mouse-events.html is broken by media control checkin 29257
* fast/forms/slider-mouse-events-expected.txt:
* fast/forms/slider-mouse-events.html: Now tests mousemove events too.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Tue, 8 Jan 2008 20:27:38 +0000 (20:27 +0000)]
Reviewed by Adam.
* rendering/RenderThemeSafari.cpp: Use the SafariTheme version number to decide whether or not to
paint the media controls in RenderThemeSafari.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 8 Jan 2008 20:25:45 +0000 (20:25 +0000)]
Fix <rdar://problem/5652740> Crash occurs at WebCore::Widget::getView() after dragging file into window that contains web page ( econocraft.com/flood_arch.htm )
Reviewed by Adele and John.
We hit this crash if the page reloads between DragController::dragUpdated
and DragController::performDrag, meaning that m_document starts pointing to
a now viewless document. This is picked up by an assertion in performDrag
which I have now replaced with an assignment given that the assertion is
invalid -- it is possible for m_document to be changed between dragUpdated
performDrag
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Tue, 8 Jan 2008 19:55:17 +0000 (19:55 +0000)]
Fixing spaces in ChangeLog.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Tue, 8 Jan 2008 19:52:24 +0000 (19:52 +0000)]
Reviewed by Darin.
<rdar://problem/5659812> CrashTracer: 462 crashes in Safari at com.apple.WebCore:
WebCore::Node::setChanged + 96
Test: fast/dom/cssTarget-crash.html
* dom/Node.cpp: (WebCore::Node::removedFromDocument):
Check to see if the node being removed is currently set as the Document's cssTarget.
Ê Ê Ê Ê If it is, clear the cssTarget to prevent a hanging reference to it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 8 Jan 2008 19:42:44 +0000 (19:42 +0000)]
* svg/svgtags.in: Touch this again for the sake of the Windows bots.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 8 Jan 2008 19:40:13 +0000 (19:40 +0000)]
Reviewed by Adam Roben.
Use JSRetainPtr in the Web Inspector everywhere we own a JSStringRef.
Also added some #pragma marks to help find places in the file.
* page/InspectorController.cpp:
(WebCore::callSimpleFunction): Use JSRetainPtr<JSStringRef>.
And return the result of JSObjectCallAsFunction.
(WebCore::search): Use JSRetainPtr<JSStringRef>.
(WebCore::databaseTableNames): Ditto.
(WebCore::localizedStrings): Ditto.
(WebCore::InspectorController::~InspectorController): Ditto.
(WebCore::InspectorController::focusNode): Ditto.
(WebCore::InspectorController::windowScriptObjectAvailable): Ditto.
(WebCore::InspectorController::scriptObjectReady): Ditto.
(WebCore::addHeaders): Ditto.
(WebCore::InspectorController::addScriptResource): Ditto.
(WebCore::InspectorController::removeScriptResource): Ditto.
(WebCore::InspectorController::updateScriptResourceRequest): Ditto.
(WebCore::InspectorController::updateScriptResourceResponse): Ditto.
(WebCore::InspectorController::updateScriptResource): Ditto.
(WebCore::InspectorController::addDatabaseScriptResource): Ditto.
(WebCore::InspectorController::removeDatabaseScriptResource): Ditto.
(WebCore::InspectorController::addScriptConsoleMessage): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 8 Jan 2008 19:14:52 +0000 (19:14 +0000)]
Rubber-stamped by Sam Weinig.
- rename FontDataBaseClass.{cpp,h} back to FontData.{cpp,h}
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* editing/Editor.cpp:
* platform/graphics/FontData.cpp: Copied from WebCore/platform/graphics/FontDataBaseClass.cpp.
* platform/graphics/FontData.h: Copied from WebCore/platform/graphics/FontDataBaseClass.h.
* platform/graphics/FontDataBaseClass.cpp: Removed.
* platform/graphics/FontDataBaseClass.h: Removed.
* platform/graphics/SegmentedFontData.h:
* platform/graphics/SimpleFontData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 8 Jan 2008 18:51:44 +0000 (18:51 +0000)]
Fix build.
* DOMCoreClasses.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 8 Jan 2008 18:32:18 +0000 (18:32 +0000)]
Reviewed by Mitz.
<rdar://problem/5667286>
plugins/createScriptableObject-before-start.html is failing due to denied cross-frame access
Use our own test plug-in instead of the Flash plug-in. The Flash plug-in tries to get the URL of the top frame
which will cause a security exception.
* platform/win/Skipped:
* plugins/createScriptableObject-before-start.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 8 Jan 2008 17:56:30 +0000 (17:56 +0000)]
Fix a Wx build error.
* platform/graphics/wx/GlyphMapWx.cpp:
(WebCore::GlyphPage::fill):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 8 Jan 2008 17:48:44 +0000 (17:48 +0000)]
Fix a Qt build error.
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::containsCharacters):
(WebCore::SimpleFontData::fontDataForCharacter):
(WebCore::SimpleFontData::isSegmented):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 8 Jan 2008 17:43:23 +0000 (17:43 +0000)]
Windows build fix.
Touch config.h to force a rebuild (apparently changing preprocessor
definitions in the .vcproj doesn't force a rebuild).
* config.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 8 Jan 2008 17:31:11 +0000 (17:31 +0000)]
Fix a Wx build failure.
* webcore-wx.bkl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 8 Jan 2008 17:27:28 +0000 (17:27 +0000)]
Fix a Qt build failure.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Tue, 8 Jan 2008 17:21:43 +0000 (17:21 +0000)]
Reviewed by Adam Roben
- fixed <rdar://problem/5671668> REGRESSION (r28711-r28730): With caret in an empty form field,
Delete menu item is enabled but shouldn't be
The enabled logic was incorrect for the Delete menu item. To fix this, I added an EditorCommandSource
parameter to the enabled functions so that they can have parallel logic to the execute functions.
* editing/EditorCommand.cpp:
added EditorCommandSource parameter to isEnabled function prototype
(WebCore::enabled):
added unused EditorCommandSource parameter to these isEnabled functions:
(WebCore::enabledAnySelection):
(WebCore::enabledAnySelectionAndMark):
(WebCore::enableCaretInEditableText):
(WebCore::enabledCopy):
(WebCore::enabledCut):
(WebCore::enabledDelete):
new function, uses logic previously used by Delete command for DOM sources; uses logic in enabledCut
for menu source
added unused EditorCommandSource parameter to these isEnabled functions:
(WebCore::enabledInEditableText):
(WebCore::enabledInRichlyEditableText):
(WebCore::enabledPaste):
(WebCore::enabledRangeInEditableText):
(WebCore::enabledRangeInRichlyEditableText):
(WebCore::enabledRedo):
(WebCore::enabledUndo):
(WebCore::CommandEntry::):
wire up new enabledDelete function as delete function for Delete command
(WebCore::Editor::Command::isEnabled):
pass EditorCommandSource parameter to isEnabled function
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 8 Jan 2008 17:10:43 +0000 (17:10 +0000)]
Visual C++ Express build fix
* WebCore.vcproj/QTMovieWin.vcproj: Explicitly link against user32.lib
and advapi32.lib. VS implicitly links against these, VC++ Express
doesn't.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 8 Jan 2008 16:45:26 +0000 (16:45 +0000)]
- add bug number
* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 8 Jan 2008 15:34:06 +0000 (15:34 +0000)]
Try to fix the Qt build.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 8 Jan 2008 15:07:02 +0000 (15:07 +0000)]
Not reviewed. Try to fix Qt builds after Timothy's inspector changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 8 Jan 2008 13:31:39 +0000 (13:31 +0000)]
Reviewed by Mark.
- remove duplicate definition of getElementById from HTMLDocument IDL (and ObjC bindings)
* bindings/objc/PublicDOMInterfaces.h:
* html/HTMLDocument.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc