WebKit-https.git
8 years ago2011-05-11 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 11 May 2011 17:41:35 +0000 (17:41 +0000)]
2011-05-11  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Video track sometimes fails to draw.
        https://bugs.webkit.org/show_bug.cgi?id=60635
        <rdar://problem/9281951>

        No new tests, covered by existing pixel tests.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::loadResource): Set display mode to "Unknown" to force a
            recalculation, and media engine notification, the next time the state machine runs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWinCE build fixes for strict PassOwnPtr
aroben@apple.com [Wed, 11 May 2011 17:31:08 +0000 (17:31 +0000)]
WinCE build fixes for strict PassOwnPtr

Source/JavaScriptCore:

* wtf/unicode/CollatorDefault.cpp:
(WTF::Collator::userDefault): Use adoptPtr.

Source/WebCore:

* platform/graphics/wince/SharedBitmap.cpp:
(WebCore::SharedBitmap::createHandle):
(WebCore::SharedBitmap::clipBitmap):
Use nullptr instead of 0.

* platform/graphics/wince/SimpleFontDataWinCE.cpp: Keep LOOSE_PASS_OWN_PTR turned on for
this file until SimpleFontData::scaledFontData is dealt with on all platforms.

* platform/text/wince/TextCodecWinCE.cpp:
(WebCore::newTextCodecWinCE): Use adoptPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-11 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Wed, 11 May 2011 16:59:08 +0000 (16:59 +0000)]
2011-05-11  Chang Shu  <cshu@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
        https://bugs.webkit.org/show_bug.cgi?id=60477

        Unskip passed tests.

        * platform/qt/Skipped:
2011-05-11  Chang Shu  <cshu@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
        https://bugs.webkit.org/show_bug.cgi?id=60477

        PlatformKeyboardEvent.m_text should be set to "\t" instead of leaving as null.
        The value is checked at EventHandler.cpp:2527 (r86166).

        Function keyTextForKeyEvent is partially implemented and can be enhanced in
        a need-base.

        * platform/qt/PlatformKeyboardEventQt.cpp:
        (WebCore::keyTextForKeyEvent):
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse case-insensitive comparisons when checking plugin filenames on Windows
aroben@apple.com [Wed, 11 May 2011 16:56:20 +0000 (16:56 +0000)]
Use case-insensitive comparisons when checking plugin filenames on Windows

Windows paths are nearly always case-insensitive.

I couldn't think of a good way to test this.

Fixes <http://webkit.org/b/60633> WebKit1 loads Windows Presentation Foundation plugin, but
should not

Reviewed by Steve Falkenburg.

* plugins/win/PluginPackageWin.cpp:
(WebCore::PluginPackage::isPluginBlacklisted): Use equalIgnoringCase instead of == when
checking plugin filenames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed fix after r86228.
ossy@webkit.org [Wed, 11 May 2011 16:45:45 +0000 (16:45 +0000)]
Unreviewed fix after r86228.

* platform/qt-mac/Skipped: Add failing editing tets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<https://bugs.webkit.org/show_bug.cgi?id=60631>
sullivan@apple.com [Wed, 11 May 2011 16:45:04 +0000 (16:45 +0000)]
<https://bugs.webkit.org/show_bug.cgi?id=60631>
<rdar://problem/9420520>

Reviewed by Darin Adler.

WebKit2 doesn't clear the pendingAPIRequestURL on in-page anchor navigation [60631]

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
Call clearPendingAPIRequestURL().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[MIPS] Fix compilation of the MIPS JIT
zecke@webkit.org [Wed, 11 May 2011 16:42:43 +0000 (16:42 +0000)]
[MIPS] Fix compilation of the MIPS JIT

Include the MIPSAssembler.h first to indirectly include
AssemblerBuffer.h before the AbstractMacroAssembler.h. This
order is used for the ARM and X86 MacroAssembler*.h.

* assembler/MacroAssemblerMIPS.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-11 Anton Muhin <antonnm@chromium.org>
antonm@chromium.org [Wed, 11 May 2011 16:40:29 +0000 (16:40 +0000)]
2011-05-11  Anton Muhin  <antonnm@chromium.org>

        Unreviewed.

        Chromium suppressions.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTurn on strict PassOwnPtr on Windows
aroben@apple.com [Wed, 11 May 2011 16:16:01 +0000 (16:16 +0000)]
Turn on strict PassOwnPtr on Windows

Fixes <http://webkit.org/b/60632> Windows should build with strict PassOwnPtr enabled

Reviewed by Adam Barth.

Source/JavaScriptCore:

* wtf/PassOwnPtr.h:

Source/WebCore:

* platform/graphics/win/SimpleFontDataWin.cpp: Keep LOOSE_PASS_OWN_PTR turned on for this
file until SimpleFontData::scaledFontData is dealt with on all platforms.

Source/WebKit2:

* WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp:
(WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Use nullptr instead of 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed update after r86230.
ossy@webkit.org [Wed, 11 May 2011 16:06:51 +0000 (16:06 +0000)]
Unreviewed update after r86230.

* platform/qt-arm/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
* platform/qt-mac/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-11 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Wed, 11 May 2011 16:05:26 +0000 (16:05 +0000)]
2011-05-11  Chang Shu  <cshu@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Some skipped editing tests actually work and just need rebaseline.
        https://bugs.webkit.org/show_bug.cgi?id=60469

        Unskip some editing tests that actually work.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-11 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Wed, 11 May 2011 15:24:32 +0000 (15:24 +0000)]
2011-05-11  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Geoffrey Garen.

        Tests for: XPathResult should keep its node set's JS wrappers alive
        https://bugs.webkit.org/show_bug.cgi?id=34231

        * fast/xpath/xpath-result-eventlistener-crash-expected.txt: Added.
        * fast/xpath/xpath-result-eventlistener-crash.html: Added.
        Test that an event listener registered on an XPATH result snapshots' node does
        not crash. This case was already fixed prior to this change. However it is better
        to keep it as a regression test.

        * fast/xpath/xpath-snapshot-result-should-mark-its-nodeset-expected.txt: Added.
        * fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html: Added.
        Test that an XPath snapshot result keeps its node wrapper alive.

        * fast/xpath/xpath-iterator-result-should-mark-its-nodeset-expected.txt: Added.
        * fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html: Added.
        Test that an XPath iterator result keeps its node wrapper alive.

        * fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset-expected.txt: Added.
        * fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset.html: Added.
        Test that other XPath result that holds nodes keeps their wrapper alive.
2011-05-11  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Geoffrey Garen.

        XPathResult should keep its node set's JS wrappers alive
        https://bugs.webkit.org/show_bug.cgi?id=34231

        The change added a custom mark function for JSC. V8 was already properly
        marking the nodes so no change were done on the V8 side.

        Tests: fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html
               fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset.html
               fast/xpath/xpath-result-eventlistener-crash.html
               fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html

        * Android.jscbindings.mk:
        * GNUmakefile.list.am:
        * UseJSC.cmake:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        Added the new file to our build systems.

        * bindings/js/JSXPathResultCustom.cpp: Added.
        (WebCore::JSXPathResult::markChildren): Added code to mark the
        XPathResult snapshot's nodes.
        * xml/XPathResult.h:
        (WebCore::XPathResult::value): Exposed this getter so that we can
        mark our XPathValue.
        * xml/XPathResult.idl: Told the IDL parser that we now need
        a custom mark function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKitTestRunner needs layoutTestController.originsWithLocalStorage.
jberlin@webkit.org [Wed, 11 May 2011 15:12:27 +0000 (15:12 +0000)]
WebKitTestRunner needs layoutTestController.originsWithLocalStorage.

Add two more storage tracker tests (added in r86205) to the mac-wk2 Skipped list to get the
bots green.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-04 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 11 May 2011 15:08:40 +0000 (15:08 +0000)]
2011-05-04  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk+] deadlock in gstreamer video player when exiting fullscreen
        https://bugs.webkit.org/show_bug.cgi?id=58548

        Block data flow towards the pipeline branch to remove to avoid
        potential deadlocks during the PAUSED->READY transitions of the
        elements to remove.

        * platform/graphics/gstreamer/GStreamerGWorld.cpp:
        (WebCore::GStreamerGWorld::exitFullscreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
jberlin@webkit.org [Wed, 11 May 2011 14:48:36 +0000 (14:48 +0000)]
[WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
about the usage for both the origin overall and the database in question.
https://bugs.webkit.org/show_bug.cgi?id=60573

Reviewed by Darin Adler.

Source/WebKit2:

Add the currentOriginUsage parameter.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::exceededDatabaseQuota):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::exceededDatabaseQuota):
* UIProcess/WebUIClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::exceededDatabaseQuota):

Tools:

* WebKitTestRunner/TestController.cpp:
(WTR::exceededDatabaseQuota):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Expected results for 2d-transforms new test
ossy@webkit.org [Wed, 11 May 2011 14:39:34 +0000 (14:39 +0000)]
[Qt] Expected results for 2d-transforms new test
https://bugs.webkit.org/show_bug.cgi?id=60565

Patch by Srinivasulu Chereddy <srinivasulu.chereddy@nokia.com> on 2011-05-11
Reviewed by Csaba Osztrogonác.

Added expected results for 1 new 2d-transforms test.

* platform/qt/transforms/2d/compound-transforms-vs-containers-expected.png: Added.
* platform/qt/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
* platform/qt/Skipped: Unskip now passing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 11 May 2011 14:23:03 +0000 (14:23 +0000)]
2011-05-10  Stephen White  <senorblanco@chromium.org>

        Reviewed by David Levin.

        Adding myself as a reviewer.
        https://bugs.webkit.org/show_bug.cgi?id=60587

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Wed, 11 May 2011 14:04:51 +0000 (14:04 +0000)]
2011-05-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Remove fixed_layout structure in ewk_view
        https://bugs.webkit.org/show_bug.cgi?id=60615

        Remove unnecessary fixed_layout structure. The ewk_view_fixed_layout_size_set/get()
        use WebCore's functions directly.

        * ewk/ewk_view.cpp:
        (ewk_view_fixed_layout_size_set):
        (ewk_view_fixed_layout_size_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-11 Tomasz Morawski <t.morawski@samsung.com>
demarchi@webkit.org [Wed, 11 May 2011 12:19:47 +0000 (12:19 +0000)]
2011-05-11  Tomasz Morawski  <t.morawski@samsung.com>

        Rubber-stamped by Daniel Bates.

        Added missing DATABASE macro
        https://bugs.webkit.org/show_bug.cgi?id=60437

        * ewk/ewk_settings.cpp:
        (ewk_settings_web_database_default_quota_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 11 May 2011 11:30:37 +0000 (11:30 +0000)]
2011-05-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Csaba Osztrogonác.

        queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
        https://bugs.webkit.org/show_bug.cgi?id=60614

        AppEngine has a result limit of 1000.  We hit that when trying
        to find out how many patches the style-queue (and other queues)
        have passed in the last 30 days.  So lets display 1000+ instead
        of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)

        I also made the status pages show "never" instead of just "ago" when we
        haven't seen a pass or boot message in the last 1000 messages.

        * QueueStatusServer/handlers/queuestatus.py:
        * QueueStatusServer/templates/queuestatus.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-11 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 11 May 2011 09:45:39 +0000 (09:45 +0000)]
2011-05-11  Kent Tamura  <tkent@chromium.org>

        The tests added by r86224 don't work on WebKit2/mac.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-11 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 11 May 2011 09:11:36 +0000 (09:11 +0000)]
2011-05-11  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        The position of validation message bubble is wrong for non text fields.
        https://bugs.webkit.org/show_bug.cgi?id=60341

        * fast/forms/resources/common.js: Added. Helper functions for fast/forms.
        * fast/forms/validation-message-on-checkbox-expected.txt: Added.
        * fast/forms/validation-message-on-checkbox.html: Added.
        * fast/forms/validation-message-on-listbox-expected.txt: Added.
        * fast/forms/validation-message-on-listbox.html: Added.
        * fast/forms/validation-message-on-menulist-expected.txt: Added.
        * fast/forms/validation-message-on-menulist.html: Added.
        * fast/forms/validation-message-on-radio-expected.txt: Added.
        * fast/forms/validation-message-on-radio.html: Added.
        * fast/forms/validation-message-on-textarea-expected.txt: Added.
        * fast/forms/validation-message-on-textarea.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/fast/forms/validation-message-appearance-expected.png: Updated.
        * platform/mac/fast/forms/validation-message-appearance-expected.txt: Updated.
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-05-11  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        The position of validation message bubble is wrong for non text fields.
        https://bugs.webkit.org/show_bug.cgi?id=60341

        Tests: fast/forms/validation-message-on-checkbox.html
               fast/forms/validation-message-on-listbox.html
               fast/forms/validation-message-on-menulist.html
               fast/forms/validation-message-on-radio.html
               fast/forms/validation-message-on-textarea.html

        * css/html.css:
        (::-webkit-validation-bubble-message):
          Add white-space:normal in order not to inherit white-space:pre for <select>.
        * html/ValidationMessage.cpp:
        (WebCore::adjustBubblePosition):
          Adjust the bubble position.
          - The top of the bubble should be same as the bottom of the target control.
          - The left of the bubble should be same as the left of the target control.
            But If the left+32 is larger than the center of the target control,
            left+32 should be at the center of the target control.
            But the left position should not be less than 0.
        (WebCore::ValidationMessage::buildBubbleTree): Call adjustBubblePosition().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 11 May 2011 08:32:13 +0000 (08:32 +0000)]
2011-05-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        sheriffbot shouldn't spam bugs when it can't figure out who to blame
        https://bugs.webkit.org/show_bug.cgi?id=60613

        This patch limits the number of bugs sheriffbot will spam to three.
        Ideally, we'd come up with some smarter huerstics, but hopefully this
        will cut down on the bugmail spam for slow bots.

        * Scripts/webkitpy/tool/commands/sheriffbot.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-11 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Wed, 11 May 2011 07:11:18 +0000 (07:11 +0000)]
2011-05-11  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Convert RenderFlexibleBox to use IntPoint/IntSize instead of x,y/w,h pairs
        https://bugs.webkit.org/show_bug.cgi?id=60592

        Refactoring, covered by existing tests.

        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock):
        (WebCore::RenderFlexibleBox::layoutHorizontalBox):
        (WebCore::RenderFlexibleBox::layoutVerticalBox):
        (WebCore::RenderFlexibleBox::placeChild):
        * rendering/RenderFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 11 May 2011 06:41:31 +0000 (06:41 +0000)]
2011-05-10  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: test that browser doesn't crash if alert() arguments conversion throws to an exception
        https://bugs.webkit.org/show_bug.cgi?id=60541

        * inspector/console/alert-toString-exception-expected.txt: Added.
        * inspector/console/alert-toString-exception.html: Added.
        * platform/chromium/inspector/console/alert-toString-exception-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
slewis@apple.com [Wed, 11 May 2011 06:41:23 +0000 (06:41 +0000)]
Unreviewed.

Revert accidental JavaScriptCore change in http://trac.webkit.org/changeset/86130

* Configurations/JavaScriptCore.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 11 May 2011 06:12:42 +0000 (06:12 +0000)]
2011-05-10  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        [Chromium] Fix a bug of WebFrameImpl::forms()
        https://bugs.webkit.org/show_bug.cgi?id=60606

        If document()->forms() contained non-HTML element, the second for
        loop didn't stop.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::forms): Simplify the function by wtf::Vector().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 11 May 2011 06:07:37 +0000 (06:07 +0000)]
2011-05-10  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed buildfix for strict OwnPtr patch.

        * src/PlatformBridge.cpp:
        (WebCore::PlatformBridge::loadPlatformAudioResource):
        (WebCore::PlatformBridge::decodeAudioFileData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 11 May 2011 06:03:27 +0000 (06:03 +0000)]
2011-05-10  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed buildfix for strict OwnPtr.

        * platform/audio/AudioBus.cpp:
        (WebCore::AudioBus::createBufferFromRange):
        (WebCore::AudioBus::createBySampleRateConverting):
        (WebCore::AudioBus::createByMixingToMono):
        * platform/audio/HRTFElevation.cpp:
        (WebCore::HRTFElevation::createForSubject):
        (WebCore::HRTFElevation::createByInterpolatingSlices):
        * platform/audio/Panner.cpp:
        (WebCore::Panner::create):
        * platform/audio/Reverb.cpp:
        (WebCore::Reverb::initialize):
        * platform/audio/chromium/AudioBusChromium.cpp:
        (WebCore::AudioBus::loadPlatformResource):
        (WebCore::createBusFromInMemoryAudioFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 11 May 2011 05:56:14 +0000 (05:56 +0000)]
2011-05-10  Adam Barth  <abarth@webkit.org>

        Build fix for font data madness.  I've had to whitelist this on several
        ports.  They need to all be fixed at once.

        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 11 May 2011 05:35:51 +0000 (05:35 +0000)]
2011-05-10  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Chromium rebaselines.

        * platform/chromium-gpu-linux/media/video-transformed-expected.png:
        * platform/chromium-gpu-mac/media/video-transformed-expected.png:
        * platform/chromium-gpu-win/media/video-transformed-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBUILD FIX for !ENABLE(TEXT_CARET) after r86039
ddkilzer@apple.com [Wed, 11 May 2011 05:34:27 +0000 (05:34 +0000)]
BUILD FIX for !ENABLE(TEXT_CARET) after r86039

* editing/FrameSelection.cpp:
(WebCore::DragCaretController::paintDragCaret): Added
UNUSED_PARAM(frame) for !ENABLE(TEXT_CARET).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 11 May 2011 05:32:00 +0000 (05:32 +0000)]
2011-05-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        EWS bots should be robust against test-webkitpy hangs
        https://bugs.webkit.org/show_bug.cgi?id=60579

        Added a killAfterTimeout subroutine, which takes a child_pid
        and timeout, and will setup a watchdog process to kill that child
        after the timeout.  killAfterTimeout will waitpid on the child.

        * EWSTools/start-queue.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 11 May 2011 05:21:20 +0000 (05:21 +0000)]
2011-05-10  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Enable strict PassOwnPtr on Chromium
        https://bugs.webkit.org/show_bug.cgi?id=60502

        Other platforms to follow.

        * wtf/PassOwnPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 11 May 2011 04:59:48 +0000 (04:59 +0000)]
2011-05-10  MORITA Hajime  <morrita@google.com>

        Unreviewed, moved myself to the reviewers list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 11 May 2011 02:29:51 +0000 (02:29 +0000)]
2011-05-10  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Fixed up some #include dependencies so the WriteBarrier class can actually call Heap::writeBarrier
        https://bugs.webkit.org/show_bug.cgi?id=60532

        * GNUmakefile.list.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.xcodeproj/project.pbxproj: Build!

        * heap/Handle.h: Moved HandleTypes to its own header because that's the
        WebKit style, and it was necessary to resolve a circular dependency
        between Handle.h and WriteBarrier.h.

        * heap/Heap.h:
        (JSC::Heap::writeBarrier): Added an inline no-op writeBarrier(), to
        verify that all the code is in the right place.

        * heap/MarkStack.h: Moved WriteBarrier operations to WriteBarrier.h to
        resolve a circular dependency.

        * runtime/ArgList.h:
        * runtime/JSCell.h: #include WriteBarrier.h since we don't get it for
        free anymore.

        * runtime/PropertyMapHashTable.h:
        (JSC::PropertyTable::PropertyTable): Call the real writeBarrier()
        function, now that it exists.

        * runtime/SmallStrings.h: Removed a stray #include to resolve a circular
        dependency.

        * runtime/WriteBarrier.h:
        (JSC::WriteBarrierBase::set):
        (JSC::MarkStack::append):
        (JSC::MarkStack::appendValues): Updated to match the changes above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 11 May 2011 02:28:52 +0000 (02:28 +0000)]
2011-05-10  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Clean up setLayerRenderer() calls in LayerRendererChromium
        https://bugs.webkit.org/show_bug.cgi?id=60524

        This refactors the way LayerRendererChromium calls setLayerRenderer on its layers in a few ways to clean things
        up:

        *) Move the pre-paint call to setLayerRenderer from updatePropertiesAndRenderSurfaces() to paintLayerContents().
            updatePropertiesAndRenderSurfaces() does too much and the layer renderer pointer only has to be up to date to do
            the actual paint. Longer term we won't need to call this at all in order to call paint and this call will just
            go away.
        *) Tweaks updateCompositorResourcesRecursive() to be slightly shorter and less error-prone.
        *) Explicitly set the LayerRendererChromium for each layer in the tree when transfering the root layer (used
            during lost context).  LayerChromium::setLayerRenderer checks if the new LayerRendererChromium is different
            by comparing the pointer value to the old one.  This check will be incorrect if there are multiple lost
            contexts between a setLayerRenderer() call and a new LayerRendererChromium happens to be allocated at the
            same address as the old one.  An explicit call to setLayerRenderer() for every layer in the tree fixes this
            since when this function is called the new and old LayerRendererChromium are still live and so they cannot
            live at the same address.

        The first two changes are purely refactors and do not change behavior.  The third issue can't be tested via a
        layout test directly as we don't have a way to induce a lost context on the compositor in a layout test.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::paintLayerContents):
        (WebCore::LayerRendererChromium::clearLayerRendererRecursive):
        (WebCore::LayerRendererChromium::transferRootLayer):
        (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
        (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive):
        * platform/graphics/chromium/LayerRendererChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix
oliver@apple.com [Wed, 11 May 2011 02:18:06 +0000 (02:18 +0000)]
Build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 11 May 2011 02:11:56 +0000 (02:11 +0000)]
2011-05-10  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Assertion failure in JSC::Structure::typeInfo when reloading weather.com video page
        https://bugs.webkit.org/show_bug.cgi?id=60580

        The plugin object map was incorrect trying to implement a weak map itself using
        destructors.  Switch to a WeakGCMap and the problem is fixed.

        * WebProcess/Plugins/Netscape/JSNPObject.cpp:
        (WebKit::JSNPObject::~JSNPObject):
        * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
        (WebKit::NPRuntimeObjectMap::getOrCreateJSObject):
        (WebKit::NPRuntimeObjectMap::invalidate):
        * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Anton D'Auria <adauria@apple.com>
commit-queue@webkit.org [Wed, 11 May 2011 01:53:30 +0000 (01:53 +0000)]
2011-05-10  Anton D'Auria  <adauria@apple.com>

        Reviewed by David Levin.

        StorageTracker should report actual local storage usage on disk
        https://bugs.webkit.org/show_bug.cgi?id=60558

        * storage/domstorage/localstorage/storagetracker/storage-tracker-6-create-expected.txt: Added.
        * storage/domstorage/localstorage/storagetracker/storage-tracker-6-create.html: Added.
        * storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage-expected.txt: Added.
        * storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage.html: Added.
2011-05-10  Anton D'Auria  <adauria@apple.com>

        Reviewed by David Levin.

        StorageTracker should report actual local storage usage on disk
        https://bugs.webkit.org/show_bug.cgi?id=60558

        Tests: storage/domstorage/localstorage/storagetracker/storage-tracker-6-create.html
               storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage.html

        Use SQLiteFileSystem::getDatabaseFileSize to get actual usage by
        an origin's local storage db. Factored out code that retrieves
        path of local storage db.

        * WebCore.exp.in: Sorted alphabetically StorageTracker's mangled
        function names.
        * storage/StorageTracker.cpp:
        (WebCore::StorageTracker::syncDeleteOrigin): Uses helper function
        to get path of origin's db
        (WebCore::StorageTracker::databasePathForOrigin): New helper function.
        that gets the path of an origin's local storage db from StorageTracker.
        (WebCore::StorageTracker::diskUsageForOrigin): New API.
        * storage/StorageTracker.h:
2011-05-10  Anton D'Auria  <adauria@apple.com>

        Reviewed by David Levin.

        Add ApplicationCache API to get disk usage per origin
        https://bugs.webkit.org/show_bug.cgi?id=57127

        Added Mac port API.

        * WebCoreSupport/WebApplicationCache.h:
        * WebCoreSupport/WebApplicationCache.mm:
        (+[WebApplicationCache diskUsageForOrigin:]):
2011-05-10  Anton D'Auria  <adauria@apple.com>

        Reviewed by David Levin.

        StorageTracker should report actual local storage usage on disk
        https://bugs.webkit.org/show_bug.cgi?id=60558

        * DumpRenderTree/LayoutTestController.cpp:
        (localStorageDiskUsageForOriginCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::localStorageDiskUsageForOrigin):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::localStorageDiskUsageForOrigin):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::localStorageDiskUsageForOrigin):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::localStorageDiskUsageForOrigin):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::localStorageDiskUsageForOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Anton D'Auria <adauria@apple.com>
commit-queue@webkit.org [Wed, 11 May 2011 01:47:03 +0000 (01:47 +0000)]
2011-05-10  Anton D'Auria  <adauria@apple.com>

        Reviewed by Alexey Proskuryakov.

        Add ApplicationCache API to get disk usage per origin
        https://bugs.webkit.org/show_bug.cgi?id=57127

        * http/tests/appcache/origin-usage-expected.txt: Added.
        * http/tests/appcache/origin-usage.html: Added.
        * http/tests/appcache/resources/origin-usage-iframe-1.html: Added.
        * http/tests/appcache/resources/origin-usage-iframe-1.manifest: Added.
        * http/tests/appcache/resources/origin-usage-iframe-2.html: Added.
        * http/tests/appcache/resources/origin-usage-iframe-2.manifest: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt/Skipped:
2011-05-10  Anton D'Auria  <adauria@apple.com>

        Reviewed by Alexey Proskuryakov.

        Add ApplicationCache API to get disk usage per origin
        https://bugs.webkit.org/show_bug.cgi?id=57127

        ApplicationCacheStorage already provides an API to get per-origin
        disk usage. This should be exposed through WebCore::ApplicationCache
        to not be dependent on storage implementation.

        Test: http/tests/appcache/origin-usage.html

        * WebCore.exp.in:
        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::diskUsageForOrigin):
        * loader/appcache/ApplicationCache.h:
2011-05-10  Anton D'Auria  <adauria@apple.com>

        Reviewed by Alexey Proskuryakov.

        Add ApplicationCache API to get disk usage per origin
        https://bugs.webkit.org/show_bug.cgi?id=57127

        Added Mac port API.

        * WebCoreSupport/WebApplicationCache.h:
        * WebCoreSupport/WebApplicationCache.mm:
        (+[WebApplicationCache diskUsageForOrigin:]):
2011-05-10  Anton D'Auria  <adauria@apple.com>

        Reviewed by Alexey Proskuryakov.

        Add ApplicationCache API to get disk usage per origin
        https://bugs.webkit.org/show_bug.cgi?id=57127

        Added test that loads two frames with ~15Kb image, checks usage,
        deletes app cache, verifies usage is 0.

        * DumpRenderTree/LayoutTestController.cpp:
        (applicationCacheDiskUsageForOriginCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::applicationCacheDiskUsageForOrigin):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
        (LayoutTestController::applicationCacheDiskUsageForOrigin):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::applicationCacheDiskUsageForOrigin):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
        (LayoutTestController::applicationCacheDiskUsageForOrigin):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
        (LayoutTestController::applicationCacheDiskUsageForOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Wed, 11 May 2011 01:44:01 +0000 (01:44 +0000)]
2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Unreviewed, adding Rafael Antognolli as a committer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 11 May 2011 01:34:44 +0000 (01:34 +0000)]
2011-05-10  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Add some aggressive GC validation to debug builds.
        https://bugs.webkit.org/show_bug.cgi?id=60601

        When assertions are enabled we now do some validity checking
        of objects being added to the mark stack.

        * bytecode/Instruction.h:
        (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::PolymorphicStubInfo):
        (JSC::PolymorphicAccessStructureList::visitAggregate):
        * heap/MarkStack.cpp:
        (JSC::MarkStack::validateSet):
        (JSC::MarkStack::validateValue):
        * heap/MarkStack.h:
        (JSC::MarkStack::appendValues):
        (JSC::MarkStack::append):
        (JSC::MarkStack::internalAppend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Chris Evans <cevans@chromium.org>
commit-queue@webkit.org [Wed, 11 May 2011 01:24:16 +0000 (01:24 +0000)]
2011-05-10  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Add WebCore::Setting to block displaying and/or running insecure content on secure pages
        https://bugs.webkit.org/show_bug.cgi?id=58378

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::setAllowDisplayOfInsecureContent):
        (LayoutTestController::setAllowRunningOfInsecureContent):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::reset):
        (WebPreferences::applyTo):
        * DumpRenderTree/chromium/WebPreferences.h:
        Add plumbing for new settings to Chromium DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoProtect self in [WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]
psolanki@apple.com [Wed, 11 May 2011 00:46:02 +0000 (00:46 +0000)]
Protect self in [WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]
https://bugs.webkit.org/show_bug.cgi?id=60594
<rdar://problem/9203259>

Reviewed by Alexey Proskuryakov.

No tests since we don't have any bots testing CFNETWORK_DATA_ARRAY_CALLBACK.

* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]): The didReceiveData()
callback on client can result in the load being cancelled. This results in the delegate
(self) being freed.  Protect self during the loop so we can check for m_handle and safely
return without crashing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Chris Guillory <chris.guillory@google.com>
commit-queue@webkit.org [Wed, 11 May 2011 00:33:47 +0000 (00:33 +0000)]
2011-05-10  Chris Guillory  <chris.guillory@google.com>

        Reviewed by James Robinson.

        [ChromiumWin] Font::drawComplexText calls EndPlatformPaint without calling BeginPlatformPaint.
        https://bugs.webkit.org/show_bug.cgi?id=59848

        To test this I plan to make the non-printing device (BitmapPlatformDevice) fail
        when EndPlatformPaint doesn't matchup with BeginPlatformPaint.
        http://codereview.chromium.org/6949012/

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::Font::drawComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoYet more quarantine related sandbox denial when downloading files
weinig@apple.com [Wed, 11 May 2011 00:19:07 +0000 (00:19 +0000)]
Yet more quarantine related sandbox denial when downloading files
<rdar://problem/9397494>

Reviewed by Dan Bernstein.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 11 May 2011 00:10:26 +0000 (00:10 +0000)]
2011-05-10  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86195.
        http://trac.webkit.org/changeset/86195
        https://bugs.webkit.org/show_bug.cgi?id=60597

        LayerOffset is a really bad name (Requested by smfr on
        #webkit).

        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/FrameView.cpp:
        (WebCore::FrameView::paintScrollCorner):
        * platform/graphics/LayerOffset.h: Removed.
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintCustomHighlight):
        * rendering/InlineTextBox.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintCustomHighlight):
        * rendering/RenderBox.h:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintReplaced):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintScrollCorner):
        (WebCore::RenderLayer::paintResizer):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/RenderObject.h:
        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::paintPart):
        * rendering/RenderScrollbarPart.cpp:
        (WebCore::RenderScrollbarPart::paintIntoRect):
        * rendering/RenderScrollbarPart.h:
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paintObject):
        (WebCore::RenderTable::paintMask):
        * rendering/RenderTable.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::paintCustomHighlight):
        (WebCore::RootInlineBox::paint):
        * rendering/RootInlineBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Wed, 11 May 2011 00:06:35 +0000 (00:06 +0000)]
2011-05-10  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Convert x,y and width,height pairs to IntPoint and IntSize for RenderLayer
        https://bugs.webkit.org/show_bug.cgi?id=60409

        Convert RenderLayer to use IntPoint for x,y pairs and IntSize for offsets and sizes.

        Refactoring, covered by existing tests.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer):
        (WebCore::RenderLayer::updateLayerPositions):
        (WebCore::RenderLayer::updateLayerPosition):
        (WebCore::RenderLayer::scrollTo):
        (WebCore::RenderLayer::visibleHeight):
        (WebCore::RenderLayer::visibleWidth):
        (WebCore::RenderLayer::scrollWidth):
        (WebCore::RenderLayer::scrollHeight):
        (WebCore::RenderLayer::computeScrollDimensions):
        (WebCore::RenderLayer::updateScrollInfoAfterLayout):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::x):
        (WebCore::RenderLayer::y):
        (WebCore::RenderLayer::setLocation):
        (WebCore::RenderLayer::width):
        (WebCore::RenderLayer::height):
        (WebCore::RenderLayer::size):
        (WebCore::RenderLayer::setWidth):
        (WebCore::RenderLayer::setHeight):
        (WebCore::RenderLayer::scrolledContentOffset):
        (WebCore::RenderLayer::scrollXOffset):
        (WebCore::RenderLayer::scrollYOffset):
        (WebCore::RenderLayer::scrollOffset):
        (WebCore::RenderLayer::scrollToXOffset):
        (WebCore::RenderLayer::scrollToYOffset):
        (WebCore::RenderLayer::relativePositionOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 10 May 2011 23:45:03 +0000 (23:45 +0000)]
2011-05-10  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Create LayerOffset class
        https://bugs.webkit.org/show_bug.cgi?id=60490

        Adding a LayerOffset class that will replace existing usage of tx/ty.
        LayerOffset is necessary since these values are commonly used as both
        a size and a point. Updating paintIntoRect to use this new class.

        No new tests since this doesn't change any behavior.

        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/FrameView.cpp:
        (WebCore::FrameView::paintScrollCorner):
        * platform/graphics/LayerOffset.h: Added.
        (WebCore::LayerOffset::LayerOffset):
        (WebCore::LayerOffset::x):
        (WebCore::LayerOffset::y):
        (WebCore::LayerOffset::setX):
        (WebCore::LayerOffset::setY):
        (WebCore::LayerOffset::toSize):
        (WebCore::LayerOffset::toPoint):
        (WebCore::operator+=):
        (WebCore::operator-=):
        (WebCore::operator+):
        (WebCore::operator-):
        (WebCore::operator==):
        (WebCore::operator!=):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintScrollCorner):
        (WebCore::RenderLayer::paintResizer):
        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::paintPart):
        * rendering/RenderScrollbarPart.cpp:
        (WebCore::RenderScrollbarPart::paintIntoRect):
        * rendering/RenderScrollbarPart.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 10 May 2011 23:32:17 +0000 (23:32 +0000)]
2011-05-10  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Make member variables of CaretBase private
        https://bugs.webkit.org/show_bug.cgi?id=60454

        Moved m_absCaretBounds, m_absoluteCaretRepaintBounds, m_absCaretBoundsDirty, and m_caretPaint back
        from CaretBase to FrameSelection because they are only used in FrameSelection, and made the rest
        of member variables in CaretBase private.

        * editing/FrameSelection.cpp:
        (WebCore::CaretBase::CaretBase): Takes CaretVisibility as an argument.
        (WebCore::DragCaretController::DragCaretController):
        (WebCore::FrameSelection::FrameSelection): Initializes m_absCaretBoundsDirty and m_caretPaint
        now that they are part of FrameSelection again.
        (WebCore::DragCaretController::setCaretPosition):
        (WebCore::FrameSelection::setSelection):
        (WebCore::CaretBase::clearCaretRect): Extracted from updateCaretRect.
        (WebCore::CaretBase::updateCaretRect): No longer clears caret; all call sites (namely setCaretPosition
        and localCaretRect) that used to call updateCaretRect now need to call clearCaretRect or updateCaretRect
        based on some conditions.
        (WebCore::FrameSelection::localCaretRect):
        (WebCore::CaretBase::caretRepaintRect):
        (WebCore::FrameSelection::recomputeCaretRect):
        (WebCore::FrameSelection::paintCaret): Only calls CaretBase::paintCaret if m_caretPaint is true.
        (WebCore::CaretBase::paintCaret): Removed an early exit for when m_caretPaint is false since m_caretPaint
        has been moved from CaretBase to FrameSelection.
        (WebCore::FrameSelection::focusedOrActiveStateChanged):
        (WebCore::FrameSelection::updateAppearance):
        (WebCore::FrameSelection::setCaretVisibility): Takes CaretVisibility instead of bool.
        (WebCore::FrameSelection::caretBlinkTimerFired):
        * editing/FrameSelection.h:
        (WebCore::CaretBase::fastLocalCaretRect): Added; replaces localCaretRectForPainting.
        (WebCore::CaretBase::shouldUpdateCaretRect): Added.
        (WebCore::CaretBase::setCaretRectNeedsUpdate): Added.
        (WebCore::CaretBase::setCaretVisibility): Added.
        (WebCore::CaretBase::caretIsVisible): Added.
        (WebCore::FrameSelection::setCaretRectNeedsUpdate): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Tue, 10 May 2011 23:28:37 +0000 (23:28 +0000)]
2011-05-10  Adam Klein  <adamk@chromium.org>

        Reviewed by David Levin.

        LayoutTest demonstrating that filesystem: URLs are not cached in WebKit
        https://bugs.webkit.org/show_bug.cgi?id=58854

        Regression test for http://crbug.com/79539.

        * http/tests/filesystem/no-cache-filesystem-url-expected.txt: Added.
        * http/tests/filesystem/no-cache-filesystem-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded my name to the reviewers list and removed my name from
enrica@apple.com [Tue, 10 May 2011 23:24:00 +0000 (23:24 +0000)]
Added my name to the reviewers list and removed my name from
to committer-only list.

Reviewed by Beth Dakin.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded myself as commiter.
jpu@apple.com [Tue, 10 May 2011 23:01:46 +0000 (23:01 +0000)]
Added myself as commiter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 10 May 2011 22:57:50 +0000 (22:57 +0000)]
2011-05-10  James Robinson  <jamesr@chromium.org>

        Reviewed by Nate Chapin.

        [chromium] Use parent/child terms for compositor tree structures consistently instead of superlayer/sublayer
        https://bugs.webkit.org/show_bug.cgi?id=60588

        GraphicsLayer uses parent/child terminology for tree structure, as does CCLayerImpl.  LayerChromium was using
        superlayer/sublayer terms, inherited from this code's branching from the platform/graphics/win/CACF code.  The
        mixed terminology is confusing and parent/child is more common, so this unifies everything to use parent/child.

        No new tests, refactor only.

        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::setChildren):
        (WebCore::GraphicsLayerChromium::addChild):
        (WebCore::GraphicsLayerChromium::addChildAtIndex):
        (WebCore::GraphicsLayerChromium::addChildBelow):
        (WebCore::GraphicsLayerChromium::addChildAbove):
        (WebCore::GraphicsLayerChromium::replaceChild):
        (WebCore::GraphicsLayerChromium::removeFromParent):
        (WebCore::GraphicsLayerChromium::setContentsToImage):
        (WebCore::GraphicsLayerChromium::setContentsToCanvas):
        (WebCore::GraphicsLayerChromium::setContentsToMedia):
        (WebCore::GraphicsLayerChromium::hostLayerForChildren):
        (WebCore::GraphicsLayerChromium::layerForParent):
        (WebCore::GraphicsLayerChromium::updateChildList):
        (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
        (WebCore::GraphicsLayerChromium::setupContentsLayer):
        * platform/graphics/chromium/GraphicsLayerChromium.h:
        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::LayerChromium):
        (WebCore::LayerChromium::~LayerChromium):
        (WebCore::LayerChromium::addChild):
        (WebCore::LayerChromium::insertChild):
        (WebCore::LayerChromium::removeFromParent):
        (WebCore::LayerChromium::removeChild):
        (WebCore::LayerChromium::replaceChild):
        (WebCore::LayerChromium::indexOfChild):
        (WebCore::LayerChromium::rootLayer):
        (WebCore::LayerChromium::removeAllChildren):
        (WebCore::LayerChromium::setChildren):
        (WebCore::LayerChromium::parent):
        (WebCore::LayerChromium::dumpLayer):
        * platform/graphics/chromium/LayerChromium.h:
        (WebCore::LayerChromium::children):
        (WebCore::LayerChromium::setParent):
        (WebCore::LayerChromium::numChildren):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
        (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive):
        (WebCore::LayerRendererChromium::dumpRenderSurfaces):
        * platform/graphics/chromium/cc/CCLayerImpl.cpp:
        (WebCore::CCLayerImpl::parent):
        (WebCore::CCLayerImpl::descendantsDrawsContent):
        * platform/graphics/chromium/cc/CCLayerImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 10 May 2011 22:45:29 +0000 (22:45 +0000)]
2011-05-10  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Darin Adler.

        Switch RenderBoxModelObject::paintNinePieceImage to use IntRect instead of four ints
        https://bugs.webkit.org/show_bug.cgi?id=60586

        Switch paintNinePieceImage to take an IntRect instead of four ints representing an IntRect!

        No new tests as this is simply refactoring.

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintMask):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintMaskImages):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintNinePieceImage):
        (WebCore::RenderBoxModelObject::paintBorder):
        * rendering/RenderBoxModelObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 10 May 2011 22:44:36 +0000 (22:44 +0000)]
2011-05-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        WebKit2: Coalesced wheel events should be saved to hand back to the client on unhandled return
        https://bugs.webkit.org/show_bug.cgi?id=60584

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::handleWheelEvent):
        (WebKit::canCoalesce):
        (WebKit::coalesce):
        (WebKit::coalescedWheelEvent):
        (WebKit::WebPageProxy::didReceiveEvent):
        (WebKit::WebPageProxy::processDidCrash):
        Reworks coalescing/merging code to happen on didReceiveEvent rather than in
        handleWheelEvent. This means we now store the pending events in a queue, and
        pull them out when we can.

        * UIProcess/WebPageProxy.h:
        Change single event containers to contain all pending/merged/coalesced events
        and remove unused flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-09 Jeremy Noble <jer.noble@apple.com>
jer.noble@apple.com [Tue, 10 May 2011 22:43:29 +0000 (22:43 +0000)]
2011-05-09  Jeremy Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        WebKit2: Cancelling full screen before animation completes leads to full screen window staying up.
        https://bugs.webkit.org/show_bug.cgi?id=60531

        Remove the (unused) _isAnimating ivar and replace it with two ivars: _isEnteringFullScreen and
        _isExitingFullScreen.  These will ensure each is only called once per full screen request, and
        that if one exit/enter request interrupts another, that the required functions are called in
        order.

        * UIProcess/mac/WKFullScreenWindowController.h:
        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController enterFullScreen:]): Removed _isAnimating.
        (-[WKFullScreenWindowController exitFullScreen]): Ditto.
        (-[WKFullScreenWindowController beganEnterFullScreenAnimation]): Gate on _isEnteringFullScreen. Check _isExitingFullScreen
            and call [self finishedExitFullScreenAnimation:] if necessary.
        (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Gate on _isEnteringFullScreen.
        (-[WKFullScreenWindowController beganExitFullScreenAnimation]): Gate on _isExitingFullScreen. Check _isEnteringFullScreen
            and call [self finishedEnterFullScreenAnimation:] if necessary.
        (-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Gate on _isExitingFullScreen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-05 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Tue, 10 May 2011 22:38:52 +0000 (22:38 +0000)]
2011-05-05  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Removing the full screen element via parent.innerHTML="" does not result in a webkitfullscreenchange event.
        https://bugs.webkit.org/show_bug.cgi?id=60278

        * fullscreen/full-screen-remove-children-expected.txt: Added.
        * fullscreen/full-screen-remove-children.html: Added.
        * fullscreen/full-screen-test.js: Fixed an exception when running in Safari.
2011-05-05  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Removing the full screen element via parent.innerHTML="" does not result in a webkitfullscreenchange event.
        https://bugs.webkit.org/show_bug.cgi?id=60278

        Handle the removal of a full screen element from within Node::willRemove() instead
        of Document::nodeWillBeRemoved().  The new function Document::fullScreenElementWillBeRemoved() will
        be called by Node::willRemove() to handle those changes which used to occur in nodeWillBeRemoved().

        Test: fullscreen/full-screen-remove-children.html

        * dom/Document.cpp:
        (WebCore::Document::nodeWillBeRemoved): Removed the code checking for the full screen element.
        (WebCore::Document::fullScreenElementWillBeRemoved): Added, moved from nodeWillBeRemoved.
        * dom/Document.h:
        * dom/Node.cpp:
        (WebCore::Node::willRemove): Check to see if this is the current full screen element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=60582
bdakin@apple.com [Tue, 10 May 2011 22:37:15 +0000 (22:37 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60582
Crash switching overlay/non-overlay scrollbar preference still possible
-and corresponding-
<rdar://problem/9323983>

Reviewed by Darin Adler.

Source/WebCore:

This patch prevents any work from being done on pages that are in the page cache
when the preference is switched.

When the Document is going into or coming out of the page cache, have the
FrameView inactivate or activate the Page's ScrollAnimators as appropriate.
* dom/Document.cpp:
(WebCore::Document::setInPageCache):

Iterate through the Page's ScrollableAreas setting the active state of the
ScrollAnimators.
* page/FrameView.cpp:
(WebCore::FrameView::setAnimatorsAreActive):
* page/FrameView.h:

ScrollAnimator has a new bit -- m_isActive. Right now m_isActive is always true
unless the ScrollAnimator belongs to a ScrollableArea that is in the page cache.
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::ScrollAnimator):
* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::setIsActive):
(WebCore::ScrollAnimator::isActive):

ScrollAnimatorMac has a new bit -- m_needsScrollerStyleUpdate. This is set to true
when a ScrollAnimator is inactive and has received the
updateScrollerStyleForNewRecommendedScrollerStyle delegate notification. It
prevents any work from being done for this delegate until the ScrollAnimator
becomes active again.
* platform/mac/ScrollAnimatorMac.h:
(WebCore::ScrollAnimatorMac::setNeedsScrollerStyleUpdate):
(WebCore::ScrollAnimatorMac::needsScrollerStyleUpdate):

This delegate method has been re-factored into ScrollAnimatorMac::
updateScrollerStyle(). This way the meat of the function can be called by both the
delegate and ScrollAnimatorMac::setIsActive()
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):

This override of ScrollAnimator::setIsActive() calls the base class, and then calls updateScrollerStyle() if needsScrollerStyleUpdate() is set to true.
(WebCore::ScrollAnimatorMac::setIsActive):

This is mostly the same as the old delegate method. Key differences are that if
the ScrollAnimator is inactive, we now setNeedsScrollerStyleUpdate(true) and
return early. We also only call scrollableArea()->scrollbarStyleChanged() if
needsScrollerStyleUpdate() is false since in the true case when we are restoring
from the page cache, this would be duplicated work.
(WebCore::ScrollAnimatorMac::updateScrollerStyle):

New WKSystemInterface function is needed to retrieve the scrollbar style.
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Tue, 10 May 2011 22:15:09 +0000 (22:15 +0000)]
2011-05-10  Jeff Miller  <jeffm@apple.com>

        Reviewed by Anders Carlsson.

        WebKit2: Windows clients need to know if the page overlay is installed
        https://bugs.webkit.org/show_bug.cgi?id=60562
        <rdar://problem/8940164>

        Until we move all the UI for find on page into WebKit on Windows (specifically, drawing the find bouncy),
        WebKit clients need to know whether WebKit is drawing the page overlay or not.  Keep track of this in
        the WebPageProxy in the UI process and provide a WebKit2 API to retrieve this information.

        * UIProcess/API/C/win/WKView.cpp:
        (WKViewIsPageOverlayInstalled): Added.
        * UIProcess/API/C/win/WKView.h: Added WKViewIsPageOverlayInstalled().

        * UIProcess/PageClient.h: Added didInstallOrUninstallPageOverlay().
        * UIProcess/WebPageProxy.h: Added didInstallOrUninstallPageOverlay().
        * UIProcess/WebPageProxy.messages.in: Added DidInstallOrUninstallPageOverlay.
        * UIProcess/win/WebPageProxyWin.cpp:
        (WebKit::WebPageProxy::didInstallOrUninstallPageOverlay): Added.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::WebView): Initialize m_pageOverlayInstalled.
        (WebKit::WebView::didInstallOrUninstallPageOverlay): Added.
        * UIProcess/win/WebView.h: Added didInstallOrUninstallPageOverlay() and m_pageOverlayInstalled.
        (WebKit::WebView::pageOverlayInstalled): Added.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::installPageOverlay): Send message to UI process to tell it the page overlay is installed.
        (WebKit::WebPage::uninstallPageOverlay): Send message to UI process to tell it the page overlay is uninstalled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 10 May 2011 21:53:32 +0000 (21:53 +0000)]
2011-05-10  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Enable strict PassOwnPtr on Chromium
        https://bugs.webkit.org/show_bug.cgi?id=60502

        Technically there are a few bits in here that weren't reviewed by Dave,
        but close enough for government work.  This patch all fixes  the
        remaining strict PassOwnPtr violations on Chromium Linux.

        * platform/graphics/chromium/PlatformCanvas.cpp:
        (WebCore::PlatformCanvas::resize):
        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::ImageBuffer):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIn my patch to fix https://bugs.webkit.org/show_bug.cgi?id=60572 I committed without...
beidson@apple.com [Tue, 10 May 2011 21:19:36 +0000 (21:19 +0000)]
In my patch to fix https://bugs.webkit.org/show_bug.cgi?id=60572 I committed without having saved ChangeLog and code comments that are critical to explain the bug and the code change.

Whoops!  Here they are.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9343191> and https://bugs.webkit.org/show_bug.cgi?id=60572
beidson@apple.com [Tue, 10 May 2011 20:26:09 +0000 (20:26 +0000)]
<rdar://problem/9343191> and https://bugs.webkit.org/show_bug.cgi?id=60572

Reviewed by Alice Liu.

No new tests - There's no way to reproduce the truly bizarre things Canon does in their app
that would reasonably fit in to our testing infrastructure.

Add a timer to Settings and instead of calling setLoadsImagesAutomaticallyInAllFrames right
away when this pref changes, call it on a 0-delay:
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::loadsImagesAutomaticallyTimerFired):
* page/Settings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 10 May 2011 19:37:32 +0000 (19:37 +0000)]
2011-05-10  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK][WebKit2] GTK+ 2.x widget rendering fails after r85480
        https://bugs.webkit.org/show_bug.cgi?id=59990

        No new tests. This is covered by existing pixel tests.

        * platform/gtk/GtkVersioning.c:
        (getGdkDrawableSize): Added this helper method.
        * platform/gtk/GtkVersioning.h: Added helper method declaration.
        * platform/gtk/WidgetRenderingContext.cpp:
        (WebCore::WidgetRenderingContext::WidgetRenderingContext): Call into the helper if
        there is actually a GdkDrawable. If not, disable the sanity check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 10 May 2011 19:33:39 +0000 (19:33 +0000)]
2011-05-10  Martin Robinson  <mrobinson@igalia.com>

        Fix the GTK+ WebKit2 build. Add a CredentialsStorage stub for libsoup.

        * GNUmakefile.list.am: Add stub to source list.
        * platform/network/soup/CredentialStorageSoup.cpp: Added.
        (WebCore::CredentialStorage::getFromPersistentStorage):  Added stub.
        (WebCore::CredentialStorage::get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9354979> REGRESSION (r83070-r83126): This conversation takes 10 secon...
hyatt@apple.com [Tue, 10 May 2011 19:24:42 +0000 (19:24 +0000)]
<rdar://problem/9354979> REGRESSION (r83070-r83126): This conversation takes 10 seconds to load and makes mail unresponsive

Reviewed by Dan Bernstein.

Second attempts at a fix for this bug.  Instead of removing the dirtying (which turned out to be needed in a few cases),
make dirtyLinesFromChangedChild mark a child as needing layout when it has to recur to the parent.  Because the method already
aborts the recursion if selfNeedsLayout() is set on the parent, this has the effect of stopping the O(n^2) pathological
behavior, since you can use the selfNeedsLayout() bit to understand that you've dirtied the lines already.

* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 10 May 2011 18:57:22 +0000 (18:57 +0000)]
2011-05-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Remove incorrect ASSERTs from CoreIPC::Connection::processIncomingSyncReply
        https://bugs.webkit.org/show_bug.cgi?id=60567
        <rdar://problem/9377845>

        It is possible to receive an incoming sync reply that is for a request we don't know about.
        This could happen if the sync message send timed out for example.

        * Platform/CoreIPC/Connection.cpp:
        (CoreIPC::Connection::processIncomingSyncReply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-05 Brent Fulgham <bfulgham@webkit.org> and Martin Robinson <mrobinson...
mrobinson@webkit.org [Tue, 10 May 2011 18:32:09 +0000 (18:32 +0000)]
2011-05-05  Brent Fulgham  <bfulgham@webkit.org> and Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Anders Carlsson.

        [Cairo][WebKit2] Add an implementation of ShareableBitmap for Cairo
        https://bugs.webkit.org/show_bug.cgi?id=60293

        No new tests. This is covered by current pixel tests.

        * platform/graphics/cairo/CairoUtilities.cpp:
        (WebCore::copyCairoImageSurface): Abstract the code from WebCore::ImageBuffer::copyImage
        into this helper which creates a deep copy of a Cairo image surface.
        * platform/graphics/cairo/CairoUtilities.h: Added declaration.
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (WebCore::ImageBuffer::copyImage): Use the new helper.
        * platform/graphics/cairo/ImageCairo.cpp: Abstract some of this logic
        into the new drawSurfaceToContext method on PlatformContextCairo.
        (WebCore::BitmapImage::draw):
        * platform/graphics/cairo/PlatformContextCairo.cpp:
        (WebCore::drawPatternToCairoContext): Added.
        (WebCore::PlatformContextCairo::drawSurfaceToContext): Added.
        * platform/graphics/cairo/PlatformContextCairo.h: Added declarations.
2011-05-05  Brent Fulgham  <bfulgham@webkit.org> and Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Anders Carlsson.

        [Cairo][WebKit2] Add an implementation of ShareableBitmap for Cairo
        https://bugs.webkit.org/show_bug.cgi?id=60293

        * GNUmakefile.am: Remove ShareableBitmapGtk in favor of ShareableBitmapCairo.
        * Shared/ShareableBitmap.h: Added a couple Cairo-specific declarations.
        * Shared/cairo/ShareableBitmapCairo.cpp:
        (WebKit::ShareableBitmap::createGraphicsContext): Added.
        (WebKit::ShareableBitmap::paint): Added.
        (WebKit::ShareableBitmap::createCairoSurface): Added.
        (WebKit::ShareableBitmap::releaseSurfaceData): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAttempt to fix Qt build.
andersca@apple.com [Tue, 10 May 2011 18:28:19 +0000 (18:28 +0000)]
Attempt to fix Qt build.

* platform/network/qt/CredentialStorageQt.cpp:
(WebCore::CredentialStorage::get):
Add stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Kenichi Ishibashi <bashi@chromium.org>
tony@chromium.org [Tue, 10 May 2011 18:12:35 +0000 (18:12 +0000)]
2011-05-10  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Tony Chang.

        REGRESSION(r85013): platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=60079

        Update the expected results.

        * platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Added.
        * platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
        * platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png:
        * platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
        * platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html:
        * platform/chromium-linux/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Removed.
        * platform/chromium/test_expectations.txt:
2011-05-10  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Tony Chang.

        REGRESSION(r85013): platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=60079

        Set resultingNumPoints = 0 so that harfbuzz uses the design coordinate
        value pair.

        * platform/graphics/chromium/HarfbuzzSkia.cpp:
        (WebCore::getOutlinePoint): Just return HB_Err_Ok with resultingNumPoints = 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Kenji Imasaki <imasaki@chromium.org>
imasaki@chromium.org [Tue, 10 May 2011 18:04:24 +0000 (18:04 +0000)]
2011-05-10  Kenji Imasaki  <imasaki@chromium.org>

        Reviewed by David Levin.

        [Chromium] Add rebaselines for video-layer-crash.
        https://bugs.webkit.org/show_bug.cgi?id=60548

        Chromium bug is http://crbug.com/60744. Expected images need to be
        updated because they are incorrect. The cause of this image change
        cannot be easily determined at present because the test has been
        broken for so long.

        * platform/chromium-gpu-linux/media/video-layer-crash-expected.png: Added.
        * platform/chromium-gpu-mac/media/video-layer-crash-expected.png: Added.
        * platform/chromium-gpu-win/media/video-layer-crash-expected.png: Added.
        * platform/chromium-linux/media/video-layer-crash-expected.png:
        * platform/chromium-win/media/video-layer-crash-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 10 May 2011 18:04:00 +0000 (18:04 +0000)]
2011-05-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Extra sign in required to view video on MobileMe Gallery album
        https://bugs.webkit.org/show_bug.cgi?id=60560
        <rdar://problem/9338693>

        Add symbols required by WebKit2.

        * WebCore.exp.in:
2011-05-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Extra sign in required to view video on MobileMe Gallery album
        https://bugs.webkit.org/show_bug.cgi?id=60560

        Implement NPN_GetAuthenticationInfo.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::getAuthenticationInfo):
        Send a GetAuthenticationInfo message to the web process.

        * PluginProcess/PluginControllerProxy.h:
        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::initializeProtectionSpace):
        Initialize a WebCore::ProtectionSpace object from NPAPI parameters.

        (WebKit::NPN_GetAuthenticationInfo):
        Make a ProtectionSpace object and then call NetscapePlugin::getAuthenticationInfo.
        Finally, copy the username/password and pass them back to the plug-in.

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::getAuthenticationInfo):
        Call the plug-in controller.

        * WebProcess/Plugins/PluginController.h:
        Add getAuthenticationInfo pure virtual member function.

        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::getAuthenticationInfo):
        Call the real plug-in controller's getAuthenticationInfo member function.

        * WebProcess/Plugins/PluginProxy.messages.in:
        Add GetAuthenticationInfo message.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::getAuthenticationInfo):
        Try to get the authentication info from the credential storage. Failing that,
        get it from the persistent credential storage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 10 May 2011 17:46:39 +0000 (17:46 +0000)]
2011-05-10  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Styles sidebar is not updated upon changes in the Resources panel.
        https://bugs.webkit.org/show_bug.cgi?id=60320

        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Tue, 10 May 2011 17:36:41 +0000 (17:36 +0000)]
2011-05-10  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        Convert editing/inserting/typing-tab-designmode-forms.html to dumpAsText
        https://bugs.webkit.org/show_bug.cgi?id=60554

        * editing/inserting/typing-tab-designmode-forms-expected.txt: Added.
        * editing/inserting/typing-tab-designmode-forms.html:
        * platform/chromium-linux/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
        * platform/chromium-mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
        * platform/chromium-win/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
        * platform/chromium-win/editing/inserting/typing-tab-designmode-forms-expected.txt: Removed.
        * platform/gtk/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
        * platform/gtk/editing/inserting/typing-tab-designmode-forms-expected.txt: Removed.
        * platform/mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
        * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
        * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 David Levin <levin@chromium.org>
levin@chromium.org [Tue, 10 May 2011 17:28:08 +0000 (17:28 +0000)]
2011-05-10  David Levin  <levin@chromium.org>

        Reviewed by Shinichiro Hamaji.

        check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
        https://bugs.webkit.org/show_bug.cgi?id=60466

        * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
        * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
          that property was removed.
        * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
          filtering for errors.
        * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
          verify that the line filtering is turned off.
        * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
          and remove the unused file_path parameter.
        * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
          line filtering is turned off (and fix test_no_error).
        * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
          of errors based on the lines changed in the patch.
        * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
          the filtering.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-06 Brett Wilson <brettw@chromium.org>
brettw@chromium.org [Tue, 10 May 2011 17:26:25 +0000 (17:26 +0000)]
2011-05-06  Brett Wilson  <brettw@chromium.org>

        Reviewed by Adam Barth.

        Use a File object to store the downloaded file reference rather than
        just the path. This keeps the file and permissions in scope (using the
        already-existing blob system) so the browser won't delete the file
        when the load is complete. Instead, the file will be cleaned up when
        the request objects are deleted.
        https://bugs.webkit.org/show_bug.cgi?id=60281

        * platform/network/chromium/ResourceResponse.cpp:
        (WebCore::ResourceResponse::doPlatformCopyData):
        (WebCore::ResourceResponse::doPlatformAdopt):
        * platform/network/chromium/ResourceResponse.h:
        (WebCore::ResourceResponse::downloadedFile):
        (WebCore::ResourceResponse::setDownloadedFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 10 May 2011 17:08:10 +0000 (17:08 +0000)]
2011-05-10  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Files that load quickly sometimes won't play.
        https://bugs.webkit.org/show_bug.cgi?id=60556
        <rdar://problem/9330567>

        No new tests, this failure is very difficult to reproduce on some machines. The fix was
        verified manually.

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
        (WebCore::MediaPlayerPrivateAVFoundation::playabilityKnown): Move the call to updateStates
            to dispatchNotification so it is more obvious which state changes call it.
        (WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Correct logging typo.
        (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Move updateStates call to
            dispatchNotification.
        (WebCore::MediaPlayerPrivateAVFoundation::rateChanged): Ditto.
        (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Ditto.
        (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Call updateStates after
            processing "size changed" notification so we detect all state changes. Consolidate
            calls to updateStates here.

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Name the video layer in
            a debug build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse FontSmoothingLevelWindows by default on Windows
aroben@apple.com [Tue, 10 May 2011 16:46:16 +0000 (16:46 +0000)]
Use FontSmoothingLevelWindows by default on Windows

Fixes <http://webkit.org/b/60557> REGRESSION (r86077): Web Inspector uses CG font rendering
in WebKit2 on Windows

Reviewed by Darin Adler.

* Shared/WebPreferencesStore.h: Added and deployed a new DEFAULT_WEBKIT_FONT_SMOOTHING_LEVEL
macro to let Windows have a different default font smoothing level from other platforms.

* UIProcess/API/C/WKPreferencesPrivate.h: Updated the comment about the default font
smoothing level.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 10 May 2011 16:40:35 +0000 (16:40 +0000)]
2011-05-10  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Simon Fraser.

        Add containsFloats call to hasOverhangingFloats.
        https://bugs.webkit.org/show_bug.cgi?id=60537

        Test: fast/block/float/no-overhanging-float-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::repaintOverhangingFloats):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::hasOverhangingFloats):
2011-05-10  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Simon Fraser.

        Tests that we do not crash due to wrong result from
        hasOverhangingFloats.
        https://bugs.webkit.org/show_bug.cgi?id=60537

        * fast/block/float/no-overhanging-float-crash-expected.txt: Added.
        * fast/block/float/no-overhanging-float-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 10 May 2011 16:22:40 +0000 (16:22 +0000)]
2011-05-10  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Chromium] Drop obsolete test code for the Profiles panel.
        https://bugs.webkit.org/show_bug.cgi?id=60471

        * src/js/Tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
ademar.reis@openbossa.org [Tue, 10 May 2011 16:22:15 +0000 (16:22 +0000)]
2011-05-10  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Increment QtWebKit trunk version to 4.10.0
        https://bugs.webkit.org/show_bug.cgi?id=60549

        QtWebKit-2.2 (branched) will be 4.9.0, so we need to
        increase the trunk version by 1.

        * qt_webkit_version.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate some plugin tests to work with WebKit2's asynchronous windowed plugin position...
aroben@apple.com [Tue, 10 May 2011 15:50:40 +0000 (15:50 +0000)]
Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows

Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
platform/win/plugins/window-geometry-initialized-before-set-window.html and
platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
(WebKit2 Tests)

Reviewed by Anders Carlsson.

Tools:

* DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
(NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
WindowedPluginTest::testHarnessWindow function.

* DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
(WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
created for.

* DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
(WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
WindowedPluginTest, and initialized new members.
(WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
(WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
then clean up and tell the test harness we're done.
(WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
(WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
window becomes visible.
(WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
if it was hidden at the start of the test.
(WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
This should cause our window to become visible and our window region to get set. When we get
a WM_WINDOWPOSCHANGED message, we can finally finish the test.
(WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
(WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
"startTest".
(WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.

* DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
(WindowedPluginTest::testHarnessWindow):
* DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.

LayoutTests:

* platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt: Updated
for new test output that doesn't claim anything about the window's position.

* platform/win/plugins/window-region-is-set-to-clip-rect.html: Hide the plugin initially,
and tell the plugin when the load event has fired.

* platform/win-wk2/platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt: Removed.
* platform/win-wk2/platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ossy@webkit.org [Tue, 10 May 2011 15:48:32 +0000 (15:48 +0000)]
Unreviewed.

* platform/qt-arm/Skipped: Add fast/workers/wrapper-map-gc.html, because it crashes intermittently.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ossy@webkit.org [Tue, 10 May 2011 15:43:57 +0000 (15:43 +0000)]
Unreviewed.

* platform/qt-arm/Skipped: Add fast/dom/Geolocation/window-close-crash.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
ademar.reis@openbossa.org [Tue, 10 May 2011 15:32:44 +0000 (15:32 +0000)]
2011-05-10  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] tst_QWebPage creates temporary files in the current working dir
        https://bugs.webkit.org/show_bug.cgi?id=60497

        tst_QWebPage was using QDir::currentPath when creating temporary dirs
        and leaving them after the test was run. I basically borrowed the fix
        from tst_QDeclarativeWebView.

        * tests/qwebpage/tst_qwebpage.cpp:
        (removeRecursive):
        (tst_QWebPage::tmpDirPath):
        (tst_QWebPage::cleanupFiles):
        (tst_QWebPage::database):
        (tst_QWebPage::multiplePageGroupsAndLocalStorage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Tue, 10 May 2011 15:25:02 +0000 (15:25 +0000)]
2011-05-10  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Antonio Gomes.

        Warning fix on PluginPackage.cpp.
        https://bugs.webkit.org/show_bug.cgi?id=60371

        Warning fix on conversion from time_t to unsigned on Linux with GCC 4.6.0.
        Let's use a struct rather than an array so we can pass everything to StringHasher.

        * plugins/PluginPackage.cpp:
        (WebCore::PluginPackage::hash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Tue, 10 May 2011 14:56:11 +0000 (14:56 +0000)]
2011-05-10  Andreas Kling  <andreas.kling@nokia.com>

        Rubber-stamped by Csaba Osztrogonác.

        [Qt] Disable HAVE_QRAWFONT until Qt API stabilizes.
        https://bugs.webkit.org/show_bug.cgi?id=60551

        * WebCore.pro: Disable the line that enables HAVE_QRAWFONT
        if the feature is found. Added a comment about why.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Tue, 10 May 2011 14:39:43 +0000 (14:39 +0000)]
2011-05-10  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Fix video-play-stall-before-metadata.

        A stalled event won't be sent until no progress has happened for 3
        seconds. Make sure that the connection is still open for at least that long.
        https://bugs.webkit.org/show_bug.cgi?id=60306

        * http/tests/media/video-load-and-stall.cgi:
        * http/tests/media/video-play-stall-before-meta-data.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOne more unreviewed typo fix after r86148. :(
ossy@webkit.org [Tue, 10 May 2011 13:56:11 +0000 (13:56 +0000)]
One more unreviewed typo fix after r86148. :(

* platform/qt-4.8/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed typo fix after r86148.
ossy@webkit.org [Tue, 10 May 2011 13:51:54 +0000 (13:51 +0000)]
Unreviewed typo fix after r86148.

* platform/qt-4.8/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt]http/tests/security/xss-DENIED-xsl-document.xml fails with Qt 4.8
ossy@webkit.org [Tue, 10 May 2011 13:48:20 +0000 (13:48 +0000)]
[Qt]http/tests/security/xss-DENIED-xsl-document.xml fails with Qt 4.8
http://trac.webkit.org/changeset/86143

[Qt]http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html fails with Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=60176

* platform/qt-4.8/Skipped:
 - Add http/tests/security/xss-DENIED-xsl-document.xml
 - Add http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 10 May 2011 13:22:27 +0000 (13:22 +0000)]
2011-05-10  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Sam Weinig.

        Web Inspector: inspector/console/console-shadow-dom-access.html crashes on mac debug
        https://bugs.webkit.org/show_bug.cgi?id=60266

        * bindings/objc/DOM.mm:
        (kitClass): return DOMNode class for shadow root node

2011-05-10  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Sam Weinig.

        Web Inspector: inspector/console/console-shadow-dom-access.html crashes on mac debug
        https://bugs.webkit.org/show_bug.cgi?id=60266

        * platform/mac/Skipped: removed suppression of console-shadow-dom-access.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] eventSender.keyDown is unimplemented
ossy@webkit.org [Tue, 10 May 2011 12:55:58 +0000 (12:55 +0000)]
[WK2] eventSender.keyDown is unimplemented

Move fast/forms/radio-group-keyboard-change-event.html from qt-wk2/Skipped to
mac-wk2/Skipped, because it isn't Qt specific bug, but general WK2 specific one.

* platform/mac-wk2/Skipped:
* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ossy@webkit.org [Tue, 10 May 2011 12:42:32 +0000 (12:42 +0000)]
Unreviewed.

[Qt][Mac] Add platform specific expected result for plugins/plugin-javascript-access.html,
which is same as the platform independent one, but differs from the general Qt specific.

* platform/qt-mac/plugins: Added.
* platform/qt-mac/plugins/plugin-javascript-access-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Ben Murdoch <benm@google.com>
benm@google.com [Tue, 10 May 2011 12:33:41 +0000 (12:33 +0000)]
2011-05-10  Ben Murdoch  <benm@google.com>

        Reviewed by Steve Block.

        Fix build in WebCore/xml/XSLTProcessorLibxslt.cpp
        https://bugs.webkit.org/show_bug.cgi?id=60478

        No new tests), build fix only.

        * xml/XSLTProcessorLibxslt.cpp: Add CString.h include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ossy@webkit.org [Tue, 10 May 2011 12:30:44 +0000 (12:30 +0000)]
Unreviewed.

[Qt] fast/events/backspace-nagivates-back fails on Qt bots (Mac and Linux)
https://bugs.webkit.org/show_bug.cgi?id=60311

It is a general Qt related bug, so we should add it to qt/Skipped instead of all Skipped list.

* platform/qt-arm/Skipped: Remove fast/events/backspace-navigates-back.html.
* platform/qt-linux/Skipped: Remove fast/events/backspace-navigates-back.html.
* platform/qt-mac/Skipped: Remove fast/events/backspace-navigates-back.html.
* platform/qt/Skipped: Add fast/events/backspace-navigates-back.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ossy@webkit.org [Tue, 10 May 2011 12:14:55 +0000 (12:14 +0000)]
Unreviewed.

Move plugins/plugin-javascript-access-expected.txt from qt-linux platform
to qt, because it should be used by qt-4.8, qt-arm Linux platforms too.

* platform/qt-linux/plugins: Removed.
* platform/qt-linux/plugins/plugin-javascript-access-expected.txt: Removed.
* platform/qt/plugins/plugin-javascript-access-expected.txt: Copied from LayoutTests/platform/qt-linux/plugins/plugin-javascript-access-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Add new qt-4.8 platform for layout testing
ossy@webkit.org [Tue, 10 May 2011 11:56:44 +0000 (11:56 +0000)]
[Qt] Add new qt-4.8 platform for layout testing
https://bugs.webkit.org/show_bug.cgi?id=60544

Reviewed by Kenneth Rohde Christiansen.

Tools:

* Scripts/old-run-webkit-tests:
* Scripts/webkitdirs.pm:

LayoutTests:

* platform/qt-4.8/Skipped: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-10 Keith Kyzivat <keith.kyzivat@nokia.com>
commit-queue@webkit.org [Tue, 10 May 2011 11:24:43 +0000 (11:24 +0000)]
2011-05-10  Keith Kyzivat  <keith.kyzivat@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QtRawFont support should check based on feature, not version
        https://bugs.webkit.org/show_bug.cgi?id=60513

        Build fix - no tests added.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86140 268f45cc-cd09-0410-ab3c-d52691b4dbfc