ojan@chromium.org [Fri, 9 Mar 2012 23:27:27 +0000 (23:27 +0000)]
More Chromium-Lion rebaselines.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 9 Mar 2012 23:25:22 +0000 (23:25 +0000)]
WebKit compiled by gcc (Xcode 3.2.6) hangs while running DOM/Accessors.html
https://bugs.webkit.org/show_bug.cgi?id=80080
Reviewed by Filip Pizlo.
* bytecode/SamplingTool.cpp:
(JSC::SamplingRegion::Locker::Locker):
(JSC::SamplingRegion::Locker::~Locker):
* bytecode/SamplingTool.h:
(JSC::SamplingRegion::exchangeCurrent):
* wtf/Atomics.h:
(WTF):
(WTF::weakCompareAndSwap):
(WTF::weakCompareAndSwapUIntPtr):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Fri, 9 Mar 2012 23:11:47 +0000 (23:11 +0000)]
Implement selectedOptions attribute of <select>.
https://bugs.webkit.org/show_bug.cgi?id=80631
Reviewed by Benjamin Poulain.
Source/WebCore:
Add a new collection as a member of HTMLSelectElement which is
used to store the selected elements. Extend HTMLCollection to
support the new collection type needed by this feature.
Reference : http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#dom-select-selectedoptions
Test: fast/dom/select-selectedOptions.html
* html/CollectionType.h:
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectedOptions):
(WebCore):
* html/HTMLSelectElement.h:
(HTMLSelectElement):
* html/HTMLSelectElement.idl:
LayoutTests:
New tests to cover the feature.
* fast/dom/select-selectedOptions-expected.txt: Added.
* fast/dom/select-selectedOptions.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 9 Mar 2012 23:04:04 +0000 (23:04 +0000)]
[chromium] ScrollbarLayerChromium/CCScrollbarLayerImpl for CC-side scrollbar painting
https://bugs.webkit.org/show_bug.cgi?id=78872
Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-03-09
Reviewed by James Robinson.
Source/WebCore:
New test ScrollbarLayerChromiumTest.resolveScrollLayerPointer
* WebCore.gypi:
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::scrollLayerForFrameView):
(WebCore::scrollbarLayerDidChange):
(WebCore):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::invalidateScrollbar):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::hasContentsLayer):
* platform/graphics/chromium/LayerChromium.h:
(WebCore):
(WebCore::LayerChromium::toScrollbarLayerChromium):
(LayerChromium):
* platform/graphics/chromium/ScrollbarLayerChromium.cpp: Added.
(WebCore):
(WebCore::ScrollbarLayerChromium::createCCLayerImpl):
(WebCore::ScrollbarLayerChromium::create):
(WebCore::ScrollbarLayerChromium::ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/ScrollbarLayerChromium.h: Added.
(WebCore):
(ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::scrollLayerId):
(WebCore::ScrollbarLayerChromium::toScrollbarLayerChromium):
* platform/graphics/chromium/TreeSynchronizer.cpp:
(WebCore::TreeSynchronizer::synchronizeTrees):
(WebCore::TreeSynchronizer::collectExistingCCLayerImplRecursive):
(WebCore::TreeSynchronizer::reuseOrCreateCCLayerImpl):
(WebCore::TreeSynchronizer::synchronizeTreeRecursive):
(WebCore::TreeSynchronizer::updateScrollbarLayerPointersRecursive):
(WebCore):
* platform/graphics/chromium/TreeSynchronizer.h:
(TreeSynchronizer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp: Added.
(WebCore):
(WebCore::CCScrollbarLayerImpl::create):
(WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl):
(WebCore::CCScrollbarLayerImpl::willDraw):
(WebCore::CCScrollbarLayerImpl::appendQuads):
(WebCore::CCScrollbarLayerImpl::didDraw):
(WebCore::CCScrollbarLayerImpl::paint):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::x):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::y):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::width):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::height):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::size):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::location):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::parent):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::root):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::setFrameRect):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::frameRect):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::invalidate):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::invalidateRect):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::scrollbarOverlayStyle):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::getTickmarks):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isScrollableAreaActive):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isScrollViewScrollbar):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::convertFromContainingWindow):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isCustomScrollbar):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::orientation):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::value):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::currentPos):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::visibleSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::totalSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::maximum):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::controlSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::lineStep):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::pageStep):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::pressedPart):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::hoveredPart):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::styleChanged):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::enabled):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::setEnabled):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h: Added.
(WebCore):
(CCScrollbarLayerImpl):
(WebCore::CCScrollbarLayerImpl::setScrollbarOverlayStyle):
(WebCore::CCScrollbarLayerImpl::setTickmarks):
(WebCore::CCScrollbarLayerImpl::setIsScrollableAreaActive):
(WebCore::CCScrollbarLayerImpl::setIsScrollViewScrollbar):
(WebCore::CCScrollbarLayerImpl::setOrientation):
(WebCore::CCScrollbarLayerImpl::setControlSize):
(WebCore::CCScrollbarLayerImpl::setPressedPart):
(WebCore::CCScrollbarLayerImpl::setHoveredPart):
(WebCore::CCScrollbarLayerImpl::setEnabled):
(WebCore::CCScrollbarLayerImpl::scrollLayer):
(WebCore::CCScrollbarLayerImpl::setScrollLayer):
(CCScrollbar):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::CCScrollbar):
Source/WebKit/chromium:
* WebKit.gypi:
* tests/ScrollbarLayerChromiumTest.cpp: Added.
(WebCore):
(MockScrollbar):
(WebCore::MockScrollbar::x):
(WebCore::MockScrollbar::y):
(WebCore::MockScrollbar::width):
(WebCore::MockScrollbar::height):
(WebCore::MockScrollbar::size):
(WebCore::MockScrollbar::location):
(WebCore::MockScrollbar::parent):
(WebCore::MockScrollbar::root):
(WebCore::MockScrollbar::setFrameRect):
(WebCore::MockScrollbar::frameRect):
(WebCore::MockScrollbar::invalidate):
(WebCore::MockScrollbar::invalidateRect):
(WebCore::MockScrollbar::scrollbarOverlayStyle):
(WebCore::MockScrollbar::getTickmarks):
(WebCore::MockScrollbar::isScrollableAreaActive):
(WebCore::MockScrollbar::isScrollViewScrollbar):
(WebCore::MockScrollbar::convertFromContainingWindow):
(WebCore::MockScrollbar::isCustomScrollbar):
(WebCore::MockScrollbar::orientation):
(WebCore::MockScrollbar::value):
(WebCore::MockScrollbar::currentPos):
(WebCore::MockScrollbar::visibleSize):
(WebCore::MockScrollbar::totalSize):
(WebCore::MockScrollbar::maximum):
(WebCore::MockScrollbar::controlSize):
(WebCore::MockScrollbar::lineStep):
(WebCore::MockScrollbar::pageStep):
(WebCore::MockScrollbar::pressedPart):
(WebCore::MockScrollbar::hoveredPart):
(WebCore::MockScrollbar::styleChanged):
(WebCore::MockScrollbar::enabled):
(WebCore::MockScrollbar::setEnabled):
(WebCore::MockScrollbar::MockScrollbar):
(WebCore::MockScrollbar::~MockScrollbar):
(WebCore::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Fri, 9 Mar 2012 22:58:05 +0000 (22:58 +0000)]
Split the extra logical height distribution logic out of RenderTableSection::layoutRows
https://bugs.webkit.org/show_bug.cgi?id=80671
Reviewed by Adrienne Walker.
Refactoring only, no change in behavior expected.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
Split the logic from here...
(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToAutoRows):
(WebCore::RenderTableSection::distributeRemainingExtraLogicalHeight):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToRows):
... to those functions. Cleaned up the variable naming while at it and
made them follow the same signature as this may be useful to fix another
bug I have.
* rendering/RenderTableSection.h:
(RenderTableSection):
Added the previous 4 new functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Fri, 9 Mar 2012 22:52:26 +0000 (22:52 +0000)]
Remove unused file FrameBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80731
Reviewed by Antonio Gomes.
This is not needed anymore since there is an implementation elsewhere.
* PlatformBlackBerry.cmake:
* page/blackberry/FrameBlackBerry.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 9 Mar 2012 22:43:30 +0000 (22:43 +0000)]
Unreviewed, rolling out r110309.
http://trac.webkit.org/changeset/110309
https://bugs.webkit.org/show_bug.cgi?id=80732
Seems to have caused a number of SVG crashes (thorton will
investigate further) (Requested by abarth|gardener on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-09
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::deferredRepaintTimerFired):
* page/FrameView.h:
(FrameView):
* rendering/RenderView.cpp:
(WebCore::RenderView::shouldRepaint):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
* svg/graphics/SVGImage.h:
* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redrawTimerFired):
* svg/graphics/SVGImageCache.h:
(SVGImageCache):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 22:36:10 +0000 (22:36 +0000)]
Crash due to inserting letter into div with first-letter
https://bugs.webkit.org/show_bug.cgi?id=78534
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-03-09
Reviewed by David Hyatt.
Source/WebCore:
This fixes an issue in RenderTextFragment with setTextInternal
getting called with different intents. While most calls to it
are intended to change the underlying DOM node string, it can
also be called as a result of styleDidChange just for transforms
on the substring text fragment. This adds a mechanism for internal
callers to specify if the internal text is being updated without
a DOM node text change.
* rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::styleDidChange)
(WebCore::RenderTextFragment::setTextInternal)
* rendering/RenderTextFragment.h:
(WebCore::RenderTextFragment)
LayoutTests:
Test case to exercise the crashing condition in bug 78534. It inserts
a character in a first-letter div to induce an invalid RenderTextFragment
state.
* editing/inserting/insert-character-in-first-letter-crash-expected.txt: Added
* editing/inserting/insert-character-in-first-letter-crash.html: Added
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 9 Mar 2012 22:31:55 +0000 (22:31 +0000)]
REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN
https://bugs.webkit.org/show_bug.cgi?id=49989
Reviewed by Oliver Hunt.
Patch originally by chris reiss <christopher.reiss@nokia.com>,
allow the year to appear before the timezone in date strings.
Source/JavaScriptCore:
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
LayoutTests:
* fast/js/date-parse-test-expected.txt:
* fast/js/script-tests/date-parse-test.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Fri, 9 Mar 2012 22:24:17 +0000 (22:24 +0000)]
Fix uninitialized variable in DynamicsCompressor
https://bugs.webkit.org/show_bug.cgi?id=80724
Reviewed by James Robinson.
* platform/audio/DynamicsCompressor.cpp:
(WebCore::DynamicsCompressor::DynamicsCompressor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 9 Mar 2012 22:04:25 +0000 (22:04 +0000)]
Move some results from mac-future to mac. mac-future should not exist.
See https://bugs.webkit.org/show_bug.cgi?id=80717 for how these got there
in the first place.
* platform/mac-future/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-anchor-no-markup-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Removed.
* platform/mac-future/svg/W3C-I18N/tspan-direction-rtl-expected.png: Removed.
* platform/mac-future/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Removed.
* platform/mac-future/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Removed.
* platform/mac-future/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Removed.
* platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
* platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
* platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
* platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
* platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
* platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
* platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
* platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
* platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
* platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
* platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
* platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
* platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/mac-future/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Fri, 9 Mar 2012 21:50:24 +0000 (21:50 +0000)]
[V8] Undo text position adjustment for attribute event handlers
https://bugs.webkit.org/show_bug.cgi?id=80725
Reviewed by Adam Barth.
No new tests. Needs rebaseline.
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 9 Mar 2012 21:34:44 +0000 (21:34 +0000)]
Ensure that the WTF headers are copied at installhdrs time.
Reviewed by Dan Bernstein and Jessie Berlin.
* Configurations/JavaScriptCore.xcconfig: Set INSTALLHDRS_SCRIPT_PHASE = YES
so that our script phases are invoked at installhdrs time. The only one that
does any useful work at that time is the one that installs WTF headers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tsepez@chromium.org [Fri, 9 Mar 2012 21:34:04 +0000 (21:34 +0000)]
Hold cached images with a CachedResourceHandle rather than a raw pointer for CSSCrossfadeValue
https://bugs.webkit.org/show_bug.cgi?id=80186
Reviewed by Simon Fraser.
Source/WebCore:
Test: http/tests/css/cross-fade-reload.html
* css/CSSCrossfadeValue.h:
(CSSCrossfadeValue):
LayoutTests:
* http/tests/css/cross-fade-reload-expected.txt: Added.
* http/tests/css/cross-fade-reload.html: Added.
* http/tests/css/resources/abe.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 9 Mar 2012 21:32:04 +0000 (21:32 +0000)]
[chromium] Expose the shared graphics context on WebView so callers can allocate resources on the main thread for the compositor to use
https://bugs.webkit.org/show_bug.cgi?id=80670
Reviewed by Stephen White.
This exposes a context on WebView that is in the compositor's share group and can be used directly from the main
thread. This is useful for content that needs to allocate resources for the compositor to use, but cannot
directly use the compositor's context either because it cannot access the correct thread or because it needs to
initialize in situations where we cannot initialize a compositor (view) context - for instance before the native
window is created.
* public/WebView.h:
(WebView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::sharedGraphicsContext3D):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 9 Mar 2012 21:14:59 +0000 (21:14 +0000)]
Crash when splitting an anonymous block in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=80432
Reviewed by David Hyatt.
Source/WebCore:
Calculating currChild->nextSibling() is risky after destroying :after content
because it can blow away currChild if it is a left over empty anonymous block.
We need to calculate next sibling upfront, using the same trick, we do in
RenderBlock::addChildIgnoringAnonymousColumnBlock to reset beforeChild (check
out the line before splitFlow call).
Test: fast/multicol/anonymous-block-split-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::splitBlocks):
LayoutTests:
* fast/multicol/anonymous-block-split-crash-expected.txt: Added.
* fast/multicol/anonymous-block-split-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 9 Mar 2012 21:12:56 +0000 (21:12 +0000)]
Crash due to accessing removed parent lineboxes when clearing selection.
https://bugs.webkit.org/show_bug.cgi?id=79264
Reviewed by Dave Hyatt.
Source/WebCore:
Test: editing/selection/first-letter-selection-crash.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::setSelectionState):
1. No need of checking if we are being set to same selection state.
Now tested by setSelectionStateIfNeeded. Rename 's' with 'state' and
'cb' with 'containingBlock'.
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::setSelectionState):
1. Add check to canUpdateSelectionOnRootLineBoxes to make sure our
root line boxes are still valid before setting them.
2. No need of calling setSelectionState on containing block since our base
class call to RenderBox::setSelectionState covers it. Added a comment to indicate that.
3. Use m_inlineBoxWrapper variable directly to simplify the ifs.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::canUpdateSelectionOnRootLineBoxes):
(WebCore): helper function to tell if we can update selection information
on our root line boxes. This returns false if our containing block is pending layout.
* rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::setSelectionStateIfNeeded):
(WebCore): helper to set selection state only if it is different from our
current selection state.
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::setSelectionState):
1. Rename 's' to 'state', 'line' to 'root' and use m_inlineBoxWrapper directly
to simplify ifs.
2. Add check to canUpdateSelectionOnRootLineBoxes to make sure our
root line boxes are still valid before setting them.
* rendering/RenderText.cpp:
(WebCore::RenderText::setSelectionState):
1. Add check to canUpdateSelectionOnRootLineBoxes to make sure our
root line boxes are still valid before setting them.
2. Rename 'cb' to 'containingBlock', 'line' to 'root', move InlineTextBox
declaration to local.
* rendering/RenderView.cpp:
(WebCore::RenderView::setSelection): Replace all calls to setSelectionState
with setSelectionStateIfNeeded.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setSelectionState):
1. No need of checking if we are being set to same selection state.
Now tested by setSelectionStateIfNeeded.
LayoutTests:
* editing/selection/first-letter-selection-crash-expected.txt: Added.
* editing/selection/first-letter-selection-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Fri, 9 Mar 2012 21:04:26 +0000 (21:04 +0000)]
Move TransformationMatrix and TransformState to LayoutUnits.
https://bugs.webkit.org/show_bug.cgi?id=80632
Reviewed by Simon Fraser.
When we move layout to sub-pixel precision, we want to preserve that precision through
transformations. This change readies TransformState and TransformationMatrix to make
use of this additional precision in accumulating transforms, and in returning rects that
preserve it.
No new tests. No change in behavior.
* platform/graphics/transforms/TransformState.cpp:
(WebCore::TransformState::move): Changed to pass along LayoutUnits to the contained
TransformationMatrix. The values of the LayoutUnits will be implicitly converted to
floats to be applied.
* platform/graphics/transforms/TransformState.h:
(WebCore::TransformState::move): Ditto.
(TransformState):
* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::clampEdgeValue): Limiting edges to the maximum LayoutUnit value to prevent
overflow..
(WebCore::TransformationMatrix::clampedBoundsOfProjectedQuad): Same as above, but also
returning a LayoutRect which preserves additional precision than the previous IntRect.
(WebCore::TransformationMatrix::mapRect): Adding a version of this method that operates
specifically on FractionalLayoutRects.
(WebCore):
* platform/graphics/transforms/TransformationMatrix.h:
(WebCore):
(TransformationMatrix):
* rendering/LayoutTypes.h:
(WebCore::clampToLayoutUnit):
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 9 Mar 2012 20:53:17 +0000 (20:53 +0000)]
Remove a bogus assertion. This condition is no longer true for non-document tree scopes.
* dom/TreeScope.cpp:
(WebCore::TreeScope::activeElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 9 Mar 2012 20:34:16 +0000 (20:34 +0000)]
Cleanup incDOMTreeVersion callers
https://bugs.webkit.org/show_bug.cgi?id=80452
Reviewed by Andreas Kling.
Unify various calls to incDOMTreeVersion and namely remove the call inside dispatchSubtreeModifiedEvent.
There should be no behavioral change and therefore there is no new test.
* dom/CharacterData.cpp:
(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::setDataAndUpdate):
* dom/ContainerNode.cpp:
(WebCore::willRemoveChild):
(WebCore::willRemoveChildren):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::childrenChanged):
(WebCore::notifyChildInserted):
* dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::willModifyAttribute):
* dom/Node.cpp:
(WebCore::Node::dispatchSubtreeModifiedEvent):
* html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::childrenChanged):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::childrenChanged):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::childrenChanged):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::childrenChanged):
* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::childrenChanged):
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::childrenChanged):
* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::childrenChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 9 Mar 2012 20:29:09 +0000 (20:29 +0000)]
Build fix for !ENABLE(FILTERS) after r110285.
* rendering/svg/SVGRenderingContext.h:
(WebCore::SVGRenderingContext::SVGRenderingContext):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Fri, 9 Mar 2012 20:27:53 +0000 (20:27 +0000)]
Bash scripts should support LF endings only
https://bugs.webkit.org/show_bug.cgi?id=79509
Actually commit the changes that should have been landed in <http://trac.webkit.org/changeset/110306>.
For some reason, webkit-patch land only committed the changes to the ChangeLog files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 20:22:55 +0000 (20:22 +0000)]
[chromium] Use opaque paints in CCOcclusionTracker
https://bugs.webkit.org/show_bug.cgi?id=80173
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-09
Reviewed by Adrienne Walker.
Source/WebCore:
Use tracked opaque paints in the tiles when tracking occlusion in
CCOcclusionTracker. Moves the Tile::m_opaqueRect up to the super-
class in CCLayerTilingData rather than having it declared in both
TiledLayerChromium and CCTiledLayerImpl. This lets the CCLayerTilingData
class compute the opaque region for its tiles, sharing code between the
two tiled layer implementations.
Use of this feature is guarded behind a runtime flag and turned off for
paint culling. We will enable it in the future once we're comfortable
with the paint culling.
Unit test: CCOcclusionTrackerTest.opaqueContentsRegionEmpty
CCOcclusionTrackerTest.opaqueContentsRegionNonEmpty
TiledLayerChromiumTest.opaqueContentsRegion
All existing CCOcclusionTrackerTest.* duplicated with opaque painted
rects.
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::opaqueContentsRegion):
(LayerChromium):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(UpdatableTile):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::addSelfToOccludedScreenSpace):
(WebCore::TiledLayerChromium::opaqueContentsRegion):
(WebCore):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::opaqueContentsRegion):
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::opaqueRegionInLayerRect):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTilingData.h:
(WebCore):
(Tile):
(WebCore::CCLayerTilingData::Tile::opaqueRect):
(WebCore::CCLayerTilingData::Tile::setOpaqueRect):
(CCLayerTilingData):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::CCOcclusionTrackerBase):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::setUsePaintTracking):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(DrawableTile):
(WebCore::CCTiledLayerImpl::opaqueContentsRegion):
(WebCore):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
Source/WebKit/chromium:
* tests/CCOcclusionTrackerTest.cpp:
(WebCore::LayerChromiumWithForcedDrawsContent::opaqueContentsRegion):
(LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::setOpaquePaintRect):
(WebCore::setLayerPropertiesForTesting):
(WebCore):
(WebCore::layerAddedToOccludedRegion):
(WebCore::layerAddedToOccludedRegionWithRotation):
(WebCore::layerAddedToOccludedRegionWithTranslation):
(WebCore::layerAddedToOccludedRegionWithRotatedSurface):
(WebCore::layerAddedToOccludedRegionWithSurfaceAlreadyOnStack):
(WebCore::layerAddedToOccludedRegionWithRotatedOffAxisSurface):
(WebCore::layerAddedToOccludedRegionWithMultipleOpaqueLayers):
(WebCore::surfaceOcclusionWithOverlappingSiblingSurfaces):
(WebCore::surfaceOcclusionInScreenSpace):
(WebCore::surfaceOcclusionInScreenSpaceDifferentTransforms):
(WebCore::occlusionInteractionWithFilters):
(WebCore::layerScissorRectOverTile):
(WebCore::screenScissorRectOverTile):
(WebCore::layerScissorRectOverCulledTile):
(WebCore::screenScissorRectOverCulledTile):
(WebCore::layerScissorRectOverPartialTiles):
(WebCore::screenScissorRectOverPartialTiles):
(WebCore::layerScissorRectOverNoTiles):
(WebCore::screenScissorRectOverNoTiles):
(WebCore::layerScissorRectForLayerOffOrigin):
(WebCore::damageRectOverTile):
(WebCore::damageRectOverCulledTile):
(WebCore::damageRectOverPartialTiles):
(WebCore::damageRectOverNoTiles):
(WebCore::TEST):
* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
(WTF):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 9 Mar 2012 20:16:02 +0000 (20:16 +0000)]
Presentation attribute cache
https://bugs.webkit.org/show_bug.cgi?id=80707
Reviewed by Andreas Kling.
It is common for the same presentation attribute values repeat. We should introduce a cache that uses
presentation attribute names and values as key. This will help to avoid repeated parsing of the
same attribute values, reduce memory consumption and speed up the style resolve.
This patch introduces a simple and small (128 entries) global cache. In general web browsing it seems
to give sharing rate of >75% (an average presentation attribute property set is shared between >4 elements).
* dom/StyledElement.cpp:
(WebCore::PresentationAttributeCacheKey::PresentationAttributeCacheKey):
(PresentationAttributeCacheKey):
(WebCore):
(WebCore::operator!=):
(PresentationAttributeCacheEntry):
(WebCore::presentationAttributeCache):
(WebCore::attributeNameSort):
(WebCore::StyledElement::makePresentationAttributeCacheKey):
(WebCore::computePresentationAttributeCacheHash):
(WebCore::StyledElement::updateAttributeStyle):
* dom/StyledElement.h:
(WebCore):
(StyledElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Fri, 9 Mar 2012 20:12:35 +0000 (20:12 +0000)]
[V8] Fix object scope for inline event attribute handlers
https://bugs.webkit.org/show_bug.cgi?id=80329
Reviewed by Ojan Vafai.
Source/WebCore:
We now create the funciton inside the with-statements with the current scope objects.
This is important for a few reasons:
- We need to use the real objects and not just lookup the JS properties because these might have been overridden.
- We need to use the node, form and document at the time of the preparation and not at the time of calling.
- We need to ensure that event/evt is bound closer than a property with the same name in the object environment
created by the with-statements.
Tests: fast/dom/inline-event-attributes-lookup-removed-form.html
fast/dom/inline-event-attributes-lookup-removed.html
fast/dom/inline-event-attributes-lookup.html
* bindings/v8/ScriptEventListener.cpp:
(WebCore::eventParameterName):
(WebCore):
(WebCore::createAttributeEventListener):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::V8LazyEventListener):
(WebCore):
(WebCore::toObjectWrapper):
(WebCore::V8LazyEventListener::callListenerFunction):
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8LazyEventListener.h:
(WebCore):
(WebCore::V8LazyEventListener::create):
(V8LazyEventListener):
LayoutTests:
* fast/dom/inline-event-attributes-lookup-expected.txt: Added.
* fast/dom/inline-event-attributes-lookup-removed-expected.txt: Added.
* fast/dom/inline-event-attributes-lookup-removed-form-expected.txt: Added.
* fast/dom/inline-event-attributes-lookup-removed-form.html: Added.
* fast/dom/inline-event-attributes-lookup-removed.html: Added.
* fast/dom/inline-event-attributes-lookup.html: Added.
* fast/forms/lazy-event-listener-scope-chain-expected.txt:
* fast/forms/lazy-event-listener-scope-chain.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Fri, 9 Mar 2012 20:07:11 +0000 (20:07 +0000)]
Crash in WebCore::SVGUseElement::instanceForShadowTreeElement
https://bugs.webkit.org/show_bug.cgi?id=80406
Reviewed by Nikolas Zimmermann.
Code assumes that an object that is an SVG Element and in a shadow
tree must be in an SVG use shadow tree, and casts the shadow host with
a static_cast. It may be that an SVG element appears in a non-use
shadow tree, in which case bad things happen. While it appears that
the current code prevents such a situation from arising (checks are
made within the shadow tree code to prevent it) there are also
indications that the situation may change.
No new tests. I believe that the problem here cannot currently be
reproduced. That is, other code prevents SVG elements from appearing
in non-svg shadow trees.
* dom/EventDispatcher.cpp:
(WebCore::eventTargetRespectingSVGTargetRules):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::title):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 9 Mar 2012 20:06:05 +0000 (20:06 +0000)]
2012-03-09 Ojan Vafai <ojan@chromium.org (:ojan) (r)>
Add image/png svn:mime-type to all png images that currently lack
an svn:mime-type. Correctly this time.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 9 Mar 2012 20:00:22 +0000 (20:00 +0000)]
Add image/png svn:mime-type to all png images that currently lack
and svn:mime-type.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Fri, 9 Mar 2012 19:41:56 +0000 (19:41 +0000)]
Add support for ENABLE(LEGACY_NOTIFICATIONS)
https://bugs.webkit.org/show_bug.cgi?id=80497
Reviewed by Adam Barth.
.:
Prep for b80472: Update API for Web Notifications
* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:
* Source/cmakeconfig.h.cmake:
* configure.ac:
Source/JavaScriptCore:
Prep for b80472: Update API for Web Notifications
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Prep for b80472: Update API for Web Notifications
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
Source/WebKit/chromium:
Prep for b80472: Update API for Web Notifications
* features.gypi:
Source/WebKit/mac:
Prep for b80472: Update API for Web Notifications
* Configurations/FeatureDefines.xcconfig:
Source/WebKit/qt:
Prep for b80472: Update API for Web Notifications
* examples/platformplugin/platformplugin.pro:
Source/WebKit2:
Prep for b80472: Update API for Web Notifications
* Configurations/FeatureDefines.xcconfig:
Tools:
Prep for b80472: Update API for Web Notifications
* Scripts/build-webkit:
* qmake/mkspecs/features/features.prf:
WebKitLibraries:
Prep for b80472: Update API for Web Notifications
* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 19:38:21 +0000 (19:38 +0000)]
ShadowRoot should implement activeElement.
https://bugs.webkit.org/show_bug.cgi?id=79886
Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-03-09
Reviewed by Ryosuke Niwa.
Source/WebCore:
Implement the activeElement attribute for ShadowRoot to return the
currently focused element in the shadow DOM subtree.
Test: fast/dom/shadow/shadow-root-activeElement.html
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::activeElement):
(WebCore):
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/ShadowRoot.idl:
* dom/TreeScope.cpp:
(WebCore::TreeScope::adoptIfNeeded):
(WebCore):
(WebCore::focusedFrameOwnerElement):
(WebCore::TreeScope::activeElement):
* dom/TreeScope.h:
(TreeScope):
* html/HTMLDocument.cpp:
(WebCore):
(WebCore::HTMLDocument::activeElement):
LayoutTests:
Added test case for activeElement attribute of ShadowRoot.
* fast/dom/shadow/shadow-root-activeElement-expected.txt: Added.
* fast/dom/shadow/shadow-root-activeElement.html: Added.
* platform/mac/Skipped: Added test case in Skipped as ShadowRoot is supported by Chromium only.
* platform/qt/Skipped: ditto.
* platform/win/Skipped: ditto.
* platform/wincairo/Skipped: ditto.
* platform/wk2/Skipped: ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Fri, 9 Mar 2012 19:21:53 +0000 (19:21 +0000)]
Infinite repaint loop with SVGImageCache and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/
10651634>
Reviewed by Nikolas Zimmermann.
Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.
Completely disable repaint during relayout inside SVGImage::drawSVGToImageBuffer,
preventing deferred repaint timers from being started during that process.
No new tests, as the problem only occurs in a nonstandard configuration.
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):
* svg/graphics/SVGImage.h:
(WebCore):
* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):
* svg/graphics/SVGImageCache.h:
(SVGImageCache):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 19:16:12 +0000 (19:16 +0000)]
Source/WebCore: The method TextTrackCue::getCueAsHTML() should return different
fragments on different calls.
https://bugs.webkit.org/show_bug.cgi?id=80701
Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-09
Reviewed by Eric Carlson.
Test: media/track/track-cue-mutable-fragment.html
* html/track/TextTrackCue.cpp: Removed setCueHTML(), since it is sufficient
to create apply the DOM rules only when the fragment is first requested.
(WebCore::TextTrackCue::getCueAsHTML): Changed the method such that a
a clone of the cached document fragment is returned.
* html/track/TextTrackCue.h: Removed setCueHTML() as the document fragment
of the cue should be created only within the class, from the cue text.
(TextTrackCue):
* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::createNewCue): removed usage of setCueHTML()
LayoutTests: Added relevant layout tests to verify that the fragment can be appended
multiple times to the DOM and modified correctly.
https://bugs.webkit.org/show_bug.cgi?id=80701
Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-09
Reviewed by Eric Carlson.
* media/track/captions-webvtt/captions-html.vtt: Added. This file could
be used later for more complex html / css rendering tests.
* media/track/track-cue-mutable-fragment-expected.txt: Added.
* media/track/track-cue-mutable-fragment.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Fri, 9 Mar 2012 19:13:00 +0000 (19:13 +0000)]
Crash in SVGTextLayoutAttributesBuilder::fillCharacterDataMap
https://bugs.webkit.org/show_bug.cgi?id=78949
<rdar://problem/
10889440>
Reviewed by Nikolas Zimmermann.
Invalidate the text positioning cache when the children of an SVGAElement change,
so that we regenerate the list the next time it's needed instead of using stale values.
Test: svg/text/text-positioning-remove-child-crash.svg
* rendering/svg/SVGAElement.cpp:
(WebCore::SVGAElement::childrenChanged):
Add a test ensuring that we don't crash when removing a child of <a> inside a <text> block.
* svg/text/text-positioning-remove-child-crash-expected.txt: Added.
* svg/text/text-positioning-remove-child-crash.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Fri, 9 Mar 2012 19:09:11 +0000 (19:09 +0000)]
Bash scripts should support LF endings only
https://bugs.webkit.org/show_bug.cgi?id=79509
Patch by Ashod Nakashian <ashodnakashian@yahoo.com> on 2012-03-09
Reviewed by David Kilzer.
Source/JavaScriptCore:
* gyp/generate-derived-sources.sh: Added property svn:eol-style.
* gyp/run-if-exists.sh: Added property svn:eol-style.
* gyp/update-info-plist.sh: Added property svn:eol-style.
Source/ThirdParty:
* gtest/xcode/Samples/FrameworkSample/runtests.sh: Added property svn:executable.
* gtest/xcode/Scripts/runtests.sh: Added property svn:executable.
Source/ThirdParty/ANGLE:
* src/compiler/generate_parser.sh: Added property svn:eol-style.
Source/WebCore:
* WebCore.gyp/mac/adjust_visibility.sh: Added property svn:eol-style.
* WebCore.vcproj/build-generated-files.sh: Added property svn:executable.
* WebCore.vcproj/migrate-scripts.sh: Added property svn:executable.
* gyp/copy-forwarding-and-icu-headers.sh: Added property svn:eol-style.
* gyp/copy-inspector-resources.sh: Added property svn:eol-style.
* gyp/generate-derived-sources.sh: Added property svn:eol-style.
* gyp/generate-webcore-export-file-generator.sh: Added property svn:eol-style.
* gyp/run-if-exists.sh: Added property svn:eol-style.
* gyp/streamline-inspector-source.sh: Added property svn:eol-style.
* gyp/update-info-plist.sh: Added property svn:eol-style.
Source/WebKit2:
* win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
Tools:
* EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
* EWSTools/start-queue.sh: Added property svn:eol-style.
* Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
* WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
* iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
* iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
WebKitLibraries:
* win/tools/scripts/feature-defines.sh: Modified property svn:eol-style.
Websites/bugs.webkit.org:
* contrib/yp_nomail.sh: Added property svn:executable.
LayoutTests:
* platform/mac/fast/loader/resources/mimeTypeExamples/example-sh.sh: Added property svn:executable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Fri, 9 Mar 2012 19:05:40 +0000 (19:05 +0000)]
CSSParser: Use Vector for intermediate property storage.
<http://webkit.org/b/80653>
Reviewed by Antti Koivisto.
Remove the custom memory management for intermediate CSSProperties in CSSParser
and replace it by a Vector<CSSProperty, 256>.
This avoids heap allocations and removes a bunch of unnecessary complexity.
Remove WTF_MAKE_FAST_ALLOCATED from CSSProperty since they are only created on
the stack now.
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::~CSSParser):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::rollbackLastProperties):
(WebCore::CSSParser::clearProperties):
(WebCore::CSSParser::parse4Values):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createMarginAtRule):
(WebCore::CSSParser::startDeclarationsForMarginBox):
(WebCore::CSSParser::endDeclarationsForMarginBox):
(WebCore::CSSParser::deleteFontFaceOnlyValues):
(WebCore::CSSParser::createKeyframeRule):
* css/CSSParser.h:
(WebCore::CSSParser::hasProperties):
(CSSParser):
* css/CSSProperty.h:
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::addParsedProperties):
* css/StylePropertySet.h:
(WebCore::StylePropertySet::create):
(StylePropertySet):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 9 Mar 2012 18:02:46 +0000 (18:02 +0000)]
Note that fast/events/input-image-scrolled-x-y.html is flaky.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Fri, 9 Mar 2012 17:59:30 +0000 (17:59 +0000)]
REGRESSION (r109022): Files dragged onto input controls cannot be read due to sandbox violation.
https://bugs.webkit.org/show_bug.cgi?id=80203
<rdar://problem/
10976643>
Reviewed by Alexey Proskuryakov.
This patch reverts a small part fo r109022, leaving access to
NSPasteboard in the WebProcess when retrieving pathnames for
files being dragged. This avoid the sandbox violation until we
implement a mechanism to provide a sandbox extension to the WebProcess.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::getPathnamesForType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 9 Mar 2012 17:56:42 +0000 (17:56 +0000)]
Windows debug build fix.
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlind):
Fix unreachable code warnings (which we treat as errors).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Fri, 9 Mar 2012 17:36:21 +0000 (17:36 +0000)]
2012-03-09 Nate Chapin <japhet@chromium.org>
CachedRawResource breaks when trying to load
a resource with an empty response body from cache.
Reviewed by Alexey Proskuryakov.
Test: http/tests/cache/zero-length-xhr.html
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::didAddClient): Don't exit early
if m_data is empty, we may still need to notifyFinished().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 17:30:45 +0000 (17:30 +0000)]
[BlackBerry] Upstream classes that handle layer tiling
https://bugs.webkit.org/show_bug.cgi?id=79875
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-09
Reviewed by Rob Buis.
Initial upstreaming, no new tests.
* platform/graphics/blackberry/LayerTile.cpp: Added.
(WebCore):
(WebCore::LayerTile::LayerTile):
(WebCore::LayerTile::~LayerTile):
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::setContentsToColor):
(WebCore::LayerTile::updateContents):
(WebCore::LayerTile::discardContents):
(WebCore::LayerTile::setVisible):
(WebCore::LayerTile::setTexture):
* platform/graphics/blackberry/LayerTile.h: Added.
(WebCore):
(LayerTileData):
(WebCore::LayerTileData::LayerTileData):
(WebCore::LayerTileData::isVisible):
(LayerTile):
(WebCore::LayerTile::texture):
(WebCore::LayerTile::isVisible):
(WebCore::LayerTile::isDirty):
(WebCore::LayerTile::hasTexture):
(WebCore::LayerTile::setContentsDirty):
* platform/graphics/blackberry/LayerTileIndex.h: Added.
(WebCore):
(TileIndex):
(WebCore::TileIndex::TileIndex):
(WebCore::TileIndex::~TileIndex):
(WebCore::TileIndex::i):
(WebCore::TileIndex::j):
(WebCore::TileIndex::setIndex):
(WebCore::operator==):
(WebCore::operator!=):
(WTF):
* platform/graphics/blackberry/LayerTiler.cpp: Added.
(WebCore):
(WebCore::transformPoint):
(WebCore::defaultTileSize):
(WebCore::LayerTiler::LayerTiler):
(WebCore::LayerTiler::~LayerTiler):
(WebCore::LayerTiler::layerWebKitThreadDestroyed):
(WebCore::LayerTiler::layerCompositingThreadDestroyed):
(WebCore::LayerTiler::setNeedsDisplay):
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::shouldPerformRenderJob):
(WebCore::LayerTiler::addTextureJob):
(WebCore::LayerTiler::clearTextureJobs):
(WebCore::LayerTiler::commitPendingTextureUploads):
(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTextures):
(WebCore::LayerTiler::drawMissingTextures):
(WebCore::LayerTiler::drawTexturesInternal):
(WebCore::LayerTiler::addRenderJob):
(WebCore::LayerTiler::removeRenderJob):
(WebCore::LayerTiler::deleteTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::updateTileSize):
(WebCore::LayerTiler::disableTiling):
(WebCore::LayerTiler::shouldPrefillTile):
(WebCore::LayerTiler::indexOfTile):
(WebCore::LayerTiler::originOfTile):
(WebCore::LayerTiler::rectForTile):
(WebCore::LayerTiler::hasDirtyTiles):
(WebCore::LayerTiler::bindContentsTexture):
* platform/graphics/blackberry/LayerTiler.h: Added.
(WebCore):
(LayerTiler):
(WebCore::LayerTiler::create):
(WebCore::LayerTiler::layer):
(WebCore::LayerTiler::hasMissingTextures):
(WebCore::LayerTiler::TextureJob::TextureJob):
(TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::setContentsToColor):
(WebCore::LayerTiler::TextureJob::updateContents):
(WebCore::LayerTiler::TextureJob::discardContents):
(WebCore::LayerTiler::TextureJob::resizeContents):
(WebCore::LayerTiler::TextureJob::dirtyContents):
(WebCore::LayerTiler::TextureJob::isNull):
(WebCore::LayerTiler::tileSize):
(WebCore::LayerTiler::removeUpdateContentsJobs):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 16:49:02 +0000 (16:49 +0000)]
[chromium] Ensure we use the correct time when notifying animation started
https://bugs.webkit.org/show_bug.cgi?id=79537
Patch by Ian Vollick <vollick@chromium.org> on 2012-03-09
Reviewed by James Robinson
Source/WebCore:
Tested in CCLayerTreeHostTestAddAnimation
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setAnimationEvent):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
* platform/graphics/chromium/cc/CCAnimationEvents.cpp:
(WebCore::CCAnimationStartedEvent::create):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):
* platform/graphics/chromium/cc/CCAnimationEvents.h:
(CCAnimationEvent):
(CCAnimationStartedEvent):
* platform/graphics/chromium/cc/CCInputHandler.h:
(CCInputHandler):
* platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:
(WebCore::CCLayerAnimationControllerImpl::animate):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationControllerImpl::resolveConflicts):
(WebCore::CCLayerAnimationControllerImpl::tickAnimations):
* platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:
(CCLayerAnimationControllerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setAnimationEvents):
(WebCore::CCLayerTreeHost::setAnimationEventsRecursive):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::animate):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::animateLayersRecursive):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
(WebCore::CCLayerTreeHostImpl::animateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImplClient):
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCPageScaleAnimation.cpp:
(WebCore::CCPageScaleAnimation::create):
(WebCore::CCPageScaleAnimation::CCPageScaleAnimation):
(WebCore::CCPageScaleAnimation::zoomTo):
(WebCore::CCPageScaleAnimation::zoomWithAnchor):
(WebCore::CCPageScaleAnimation::scrollOffsetAtTime):
(WebCore::CCPageScaleAnimation::pageScaleAtTime):
(WebCore::CCPageScaleAnimation::isAnimationCompleteAtTime):
(WebCore::CCPageScaleAnimation::progressRatioForTime):
* platform/graphics/chromium/cc/CCPageScaleAnimation.h:
(CCPageScaleAnimation):
(WebCore::CCPageScaleAnimation::startTime):
(WebCore::CCPageScaleAnimation::duration):
(WebCore::CCPageScaleAnimation::endTime):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::startPageScaleAnimation):
(WebCore::CCSingleThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::startPageScaleAnimation):
(WebCore::CCThreadProxy::requestStartPageScaleAnimationOnImplThread):
(WebCore::CCThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::setAnimationEvents):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::willDraw):
* src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::CCLayerTreeHostImplTest::postAnimationEventsToMainThreadOnImplThread):
(WebKit::TEST_F):
* tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::animateLayers):
(WTF::TestHooks::updateAnimations):
(WTF::MockLayerTreeHostImpl::animateLayers):
(WTF::MockLayerTreeHostClient::updateAnimations):
(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationStarted):
(CCLayerTreeHostTestAddAnimation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Fri, 9 Mar 2012 15:45:48 +0000 (15:45 +0000)]
[chromium] Unreviewed gardening.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 9 Mar 2012 15:25:35 +0000 (15:25 +0000)]
[Qt] Unreviewed gardening.
* platform/qt/Skipped: Skip flaky svg tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 15:22:15 +0000 (15:22 +0000)]
[BUILD] use detected python to run generate-gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=80695
Patch by Ionut Biru <ibiru@archlinux.org> on 2012-03-09
Reviewed by Gustavo Noronha Silva.
* GNUmakefile.am: Use $(PYTHON) instead of plain `python`
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 9 Mar 2012 15:13:17 +0000 (15:13 +0000)]
[Qt] Unreviewed gardening.
* platform/qt/Skipped:
* platform/qt/editing/selection/3690703-2-expected.png:
* platform/qt/editing/selection/3690703-2-expected.txt:
* platform/qt/editing/selection/3690703-expected.png:
* platform/qt/editing/selection/3690703-expected.txt:
* platform/qt/editing/selection/3690719-expected.png:
* platform/qt/editing/selection/3690719-expected.txt:
* platform/qt/fast/css/text-overflow-input-expected.txt: Added.
* platform/qt/fast/forms/basic-inputs-expected.png: Added.
* platform/qt/fast/forms/basic-inputs-expected.txt:
* platform/qt/fast/replaced/replaced-breaking-expected.png:
* platform/qt/fast/replaced/replaced-breaking-expected.txt:
* platform/qt/fast/text/textIteratorNilRenderer-expected.png:
* platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
* platform/qt/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/qt/tables/mozilla/bugs/bug1188-expected.png:
* platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
* platform/qt/tables/mozilla/bugs/bug18359-expected.png:
* platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2479-4-expected.png:
* platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/qt/tables/mozilla/bugs/bug28928-expected.png:
* platform/qt/tables/mozilla/bugs/bug28928-expected.txt:
* platform/qt/tables/mozilla/bugs/bug4382-expected.png:
* platform/qt/tables/mozilla/bugs/bug4382-expected.txt:
* platform/qt/tables/mozilla/bugs/bug44505-expected.png:
* platform/qt/tables/mozilla/bugs/bug44505-expected.txt:
* platform/qt/tables/mozilla/bugs/bug4527-expected.png:
* platform/qt/tables/mozilla/bugs/bug4527-expected.txt:
* platform/qt/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/qt/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/qt/tables/mozilla/bugs/bug51037-expected.png:
* platform/qt/tables/mozilla/bugs/bug51037-expected.txt:
* platform/qt/tables/mozilla/bugs/bug7342-expected.png:
* platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
* platform/qt/tables/mozilla/dom/tableDom-expected.png:
* platform/qt/tables/mozilla/dom/tableDom-expected.txt:
* platform/qt/tables/mozilla/other/move_row-expected.png:
* platform/qt/tables/mozilla/other/move_row-expected.txt:
* platform/qt/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 15:08:37 +0000 (15:08 +0000)]
Layout test for window.devicePixelRatio
https://bugs.webkit.org/show_bug.cgi?id=80292
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-09
Reviewed by Philippe Normand.
Update the skipped list for ports where fast/viewport/viewport-133.html is failing.
* platform/efl/Skipped:
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 9 Mar 2012 14:25:30 +0000 (14:25 +0000)]
[Qt] Rebaseline some tests on qt platfrom
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-09
Reviewed by Csaba Osztrogonác.
* platform/qt/ [...]: Update expected files.
* platform/qt/test_expectations.txt: Unskip now passing tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 9 Mar 2012 13:59:04 +0000 (13:59 +0000)]
2012-03-09 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Rebaseline some Mac results that needed rebaselining - using Lion, and a Generic RGB Color profile.
Had to manually switch to this, until this is done automatically, see bug 80571.
Re-add several results that got deleted or moved to mac-future. I guess this is garden-o-matic
misusage? Not sure, anyhow, there are clearly a dozen of missing SVG pixel tests before this patch.
Reviewed by NOBODY (OOPS!).
* platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
* platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
* platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
* platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
* platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
* platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
* platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
* platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
* platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
* platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
* platform/mac/svg/batik/filters/feTile-expected.png:
* platform/mac/svg/batik/filters/filterRegions-expected.png:
* platform/mac/svg/batik/masking/maskRegions-expected.png: Added.
* platform/mac/svg/batik/text/textEffect-expected.png:
* platform/mac/svg/batik/text/textEffect3-expected.png:
* platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
* platform/mac/svg/carto.net/scrollbar-expected.png: Added.
* platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
* platform/mac/svg/css/path-gradient-stroke-shadow-expected.png:
* platform/mac/svg/css/rect-gradient-stroke-shadow-expected.png:
* platform/mac/svg/custom/convolution-crash-expected.png:
* platform/mac/svg/custom/empty-merge-expected.png:
* platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
* platform/mac/svg/custom/feDisplacementMap-01-expected.png:
* platform/mac/svg/custom/grayscale-gradient-mask-2-expected.png:
* platform/mac/svg/custom/image-with-transform-clip-filter-expected.png:
* platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/mac/svg/custom/non-opaque-filters-expected.png:
* platform/mac/svg/custom/recursive-filter-expected.png:
* platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
* platform/mac/svg/custom/root-container-opacity-clip-viewBox-expected.png:
* platform/mac/svg/custom/text-filter-expected.png:
* platform/mac/svg/custom/use-disappears-after-style-update-expected.png:
* platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.png: Added.
* platform/mac/svg/custom/visibility-override-filter-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png:
* platform/mac/svg/filters/big-sized-filter-2-expected.png:
* platform/mac/svg/filters/big-sized-filter-expected.png:
* platform/mac/svg/filters/feColorMatrix-default-type-expected.png:
* platform/mac/svg/filters/feColorMatrix-offset-expected.png:
* platform/mac/svg/filters/feColorMatrix-values-expected.png:
* platform/mac/svg/filters/feComposite-expected.png:
* platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.png:
* platform/mac/svg/filters/feDisplacementMap-expected.png:
* platform/mac/svg/filters/feDropShadow-expected.png:
* platform/mac/svg/filters/feGaussianBlur-expected.png:
* platform/mac/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
* platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
* platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
* platform/mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
* platform/mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
* platform/mac/svg/filters/feImage-late-indirect-update-expected.png:
* platform/mac/svg/filters/feImage-multiple-targets-id-change-expected.png:
* platform/mac/svg/filters/feImage-position-expected.png:
* platform/mac/svg/filters/feImage-preserveAspectratio-expected.png:
* platform/mac/svg/filters/feImage-subregions-expected.png:
* platform/mac/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
* platform/mac/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
* platform/mac/svg/filters/feImage-target-add-to-document-expected.png:
* platform/mac/svg/filters/feImage-target-attribute-change-expected.png:
* platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
* platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
* platform/mac/svg/filters/feImage-target-changes-id-expected.png:
* platform/mac/svg/filters/feImage-target-id-change-expected.png:
* platform/mac/svg/filters/feImage-target-inline-style-change-expected.png:
* platform/mac/svg/filters/feImage-target-property-change-expected.png:
* platform/mac/svg/filters/feImage-target-reappend-to-document-expected.png:
* platform/mac/svg/filters/feImage-target-remove-from-document-expected.png:
* platform/mac/svg/filters/feImage-target-style-change-expected.png:
* platform/mac/svg/filters/feLighting-crash-expected.png:
* platform/mac/svg/filters/feMerge-expected.png:
* platform/mac/svg/filters/feOffset-expected.png:
* platform/mac/svg/filters/feTile-expected.png:
* platform/mac/svg/filters/filter-clip-expected.png:
* platform/mac/svg/filters/filter-on-tspan-expected.png:
* platform/mac/svg/filters/filter-placement-issue-expected.png:
* platform/mac/svg/filters/filter-refresh-expected.png:
* platform/mac/svg/filters/filter-rounding-issues-expected.png:
* platform/mac/svg/filters/filter-source-position-expected.png:
* platform/mac/svg/filters/filter-width-update-expected.png:
* platform/mac/svg/filters/filterRes-expected.png:
* platform/mac/svg/filters/filterRes1-expected.png:
* platform/mac/svg/filters/filterRes2-expected.png:
* platform/mac/svg/filters/filterRes3-expected.png:
* platform/mac/svg/filters/filteredImage-expected.png:
* platform/mac/svg/filters/parent-children-with-same-filter-expected.png:
* platform/mac/svg/filters/shadow-on-filter-expected.png:
* platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/mac/svg/filters/subRegion-in-userSpace-expected.png:
* platform/mac/svg/filters/subRegion-one-effect-expected.png:
* platform/mac/svg/filters/subRegion-two-effects-expected.png:
* platform/mac/svg/hixie/mixed/003-expected.png:
* platform/mac/svg/hixie/mixed/003-expected.txt:
* platform/mac/svg/repaint/filter-child-repaint-expected.png:
* platform/mac/svg/repaint/filter-repaint-expected.png:
* platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:
* platform/mac/test_expectations.txt:
* svg/filters/animate-fill-expected.png:
* svg/filters/feColorMatrix-saturate-expected.png:
* svg/filters/feImage-reference-invalidation-expected.png:
* svg/filters/feImage-reference-svg-primitive-expected.png:
* svg/foreignObject/filter-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110292
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 9 Mar 2012 13:13:44 +0000 (13:13 +0000)]
[Qt] Fix compilation without QtQuick1
https://bugs.webkit.org/show_bug.cgi?id=80503
Qt 4.8 API test fix after r110050.
Reviewed by Zoltan Herczeg.
* declarative/public.pri: Add load(features) to ensure HAVE_QQUICK1=1 is set.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
charles.wei@torchmobile.com.cn [Fri, 9 Mar 2012 13:11:28 +0000 (13:11 +0000)]
[BlackBerry] Web Notification not working after rebase
https://bugs.webkit.org/show_bug.cgi?id=80690
Reviewed by George Staikos.
1. NotificationPresenterImpl should be in namespace WebCore
2. Need to connect NotificationPresenterImpl to webcore the new way:
WebCore::provideNotification(Page*, NotificationPresenter*)
3. Remove the old way of connecting the Notification:
ChromeClientBlackBerry::notificationPresenter()
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore):
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
* WebCoreSupport/NotificationPresenterImpl.cpp:
* WebCoreSupport/NotificationPresenterImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 12:45:19 +0000 (12:45 +0000)]
Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2012-03-09
Reviewed by Zoltan Herczeg.
[Qt] Fix the SH4 build after r109834
https://bugs.webkit.org/show_bug.cgi?id=80492
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchAdd32):
(JSC::MacroAssemblerSH4::branchSub32):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 9 Mar 2012 12:16:26 +0000 (12:16 +0000)]
[Qt] Disable WebGL performance tests temporarily.
https://bugs.webkit.org/show_bug.cgi?id=80503
Rubber-stamped by Simon Hausmann.
* Source/tests.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wingo@igalia.com [Fri, 9 Mar 2012 12:06:48 +0000 (12:06 +0000)]
Refactor code feature analysis in the parser
https://bugs.webkit.org/show_bug.cgi?id=79112
Reviewed by Geoffrey Garen.
This commit refactors the parser to more uniformly propagate flag
bits down and up the parse process, as the parser descends and
returns into nested blocks. Some flags get passed town to
subscopes, some apply to specific scopes only, and some get
unioned up after parsing subscopes.
The goal is to eventually be very precise with scoping
information, once we have block scopes: one block scope might use
`eval', which would require the emission of a symbol table within
that block and containing blocks, whereas another block in the
same function might not, allowing us to not emit a symbol table.
* parser/Nodes.h:
(JSC::ScopeFlags): Rename from CodeFeatures.
(JSC::ScopeNode::addScopeFlags):
(JSC::ScopeNode::scopeFlags): New accessors for m_scopeFlags.
(JSC::ScopeNode::isStrictMode):
(JSC::ScopeNode::usesEval):
(JSC::ScopeNode::usesArguments):
(JSC::ScopeNode::setUsesArguments):
(JSC::ScopeNode::usesThis):
(JSC::ScopeNode::needsActivationForMoreThanVariables):
(JSC::ScopeNode::needsActivation): Refactor these accessors to
operate on the m_scopeFlags member.
(JSC::ScopeNode::source):
(JSC::ScopeNode::sourceURL):
(JSC::ScopeNode::sourceID): Shuffle these definitions around; no
semantic change.
(JSC::ScopeNode::ScopeNode)
(JSC::ProgramNode::ProgramNode)
(JSC::EvalNode::EvalNode)
(JSC::FunctionBodyNode::FunctionBodyNode): Have these constructors
take a ScopeFlags as an argument, instead of a bool inStrictContext.
* parser/Nodes.cpp:
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create): Adapt constructors to change.
* parser/ASTBuilder.h:
(JSC::ASTBuilder::ASTBuilder):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::addVar):
(JSC::ASTBuilder::Scope::Scope):
(Scope):
(ASTBuilder):
(JSC::ASTBuilder::makeFunctionCallNode): Don't track scope
features here. Instead rely on the base Parser mechanism to track
features.
* parser/NodeInfo.h (NodeInfo, NodeDeclarationInfo): "ScopeFlags".
* parser/Parser.h:
(JSC::Scope::Scope): Manage scope through flags, not
bit-booleans. This lets us uniformly propagate them up and down.
(JSC::Scope::declareWrite):
(JSC::Scope::declareParameter):
(JSC::Scope::useVariable):
(JSC::Scope::collectFreeVariables):
(JSC::Scope::getCapturedVariables):
(JSC::Scope::saveFunctionInfo):
(JSC::Scope::restoreFunctionInfo):
(JSC::Parser::pushScope): Adapt to use scope flags and their
accessors instead of bit-booleans.
* parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseInner):
(JSC::::didFinishParsing):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseWithStatement):
(JSC::::parseTryStatement):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parsePrimaryExpression): Hoist some of the flag handling
out of the "context" (ASTBuilder or SyntaxChecker) and to here.
Does not seem to have a performance impact.
* parser/SourceProviderCacheItem.h (SourceProviderCacheItem):
Cache the scopeflags.
* parser/SyntaxChecker.h: Remove evalCount() decl.
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
* runtime/Executable.h:
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::needsActivation):
(JSC::ScriptExecutable::isStrictMode):
(JSC::ScriptExecutable::recordParse):
(ScriptExecutable): ScopeFlags, not features.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 9 Mar 2012 12:03:57 +0000 (12:03 +0000)]
[Qt] Unreviewed gardening.
* platform/qt/Skipped: Skip new tests without expected files, need investigation.
* platform/qt/http/tests/navigation/javascriptlink-frames-expected.png: Updated.
* platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Fri, 9 Mar 2012 12:02:50 +0000 (12:02 +0000)]
Add SVGRenderingContext and move there the context related code from SVGRenderSupport
https://bugs.webkit.org/show_bug.cgi?id=80413
Reviewed by Nikolas Zimmermann.
This is the first step of refactoring the rendering context for SVG. The
previous context was stateless before, which means the cleanup phase
needed to do a lot of checks to revert the initialization part and
was unaware of failed inititalization. Future code can also add
new local variables to the context.
This patch add a new SVGRenderingContext class, and moves there the context
initialization / cleanup code from SVGRenderSupport. All build systems were
updated.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/svg/RenderSVGAllInOne.cpp:
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::paint):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::paint):
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paint):
* rendering/svg/SVGRenderSupport.cpp:
* rendering/svg/SVGRenderSupport.h:
* rendering/svg/SVGRenderingContext.cpp: Added.
(WebCore):
(WebCore::isRenderingMaskImage):
(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
* rendering/svg/SVGRenderingContext.h: Added.
(WebCore):
(SVGRenderingContext):
(WebCore::SVGRenderingContext::SVGRenderingContext):
(WebCore::SVGRenderingContext::isRenderingPrepared):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 9 Mar 2012 11:45:42 +0000 (11:45 +0000)]
[Qt] Gardening, skip 3 failing tests.
Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-03-09
Reviewed by Csaba Osztrogonác.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 9 Mar 2012 11:16:35 +0000 (11:16 +0000)]
Unreviewed, rolling out r110191, r110202, and r110279.
http://trac.webkit.org/changeset/110191
http://trac.webkit.org/changeset/110202
http://trac.webkit.org/changeset/110279
https://bugs.webkit.org/show_bug.cgi?id=80694
They broke !ENABLE(INSPECTOR) builds (Requested by Ossy on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-09
.:
* Source/autotools/symbols.filter:
Source/WebCore:
* WebCore.exp.in:
* testing/Internals.cpp:
* testing/Internals.h:
(WebCore):
(Internals):
* testing/Internals.idl:
Source/WebKit/chromium:
* features.gypi:
Source/WebKit2:
* win/WebKit2.def:
* win/WebKit2CFLite.def:
LayoutTests:
* inspector/elements/highlight-node-expected.txt: Removed.
* inspector/elements/highlight-node.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nduca@chromium.org [Fri, 9 Mar 2012 11:13:43 +0000 (11:13 +0000)]
Make check-webkit-style complain about "no new tests" lines in changelogs
https://bugs.webkit.org/show_bug.cgi?id=80582
Reviewed by David Levin.
* Scripts/webkitpy/style/checkers/changelog.py:
(ChangeLogChecker.check_entry):
* Scripts/webkitpy/style/checkers/changelog_unittest.py:
(ChangeLogCheckerTest.test_no_new_tests):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Fri, 9 Mar 2012 10:56:31 +0000 (10:56 +0000)]
Speech JavaScript API: add SpeechGrammar and SpeechGrammarList
https://bugs.webkit.org/show_bug.cgi?id=80417
Reviewed by Adam Barth.
Source/WebCore:
Implement SpeechGrammar and SpeechGrammarList.
(Spec: http://speech-javascript-api-spec.googlecode.com/git/speechapi.html)
Test: fast/speech/scripted/speechgrammar-basics.html
* Modules/speech/DOMWindowSpeech.idl:
* Modules/speech/SpeechGrammar.cpp:
(WebCore):
(WebCore::SpeechGrammar::create):
(WebCore::SpeechGrammar::SpeechGrammar):
* Modules/speech/SpeechGrammar.h:
(WebCore):
(SpeechGrammar):
(WebCore::SpeechGrammar::src):
(WebCore::SpeechGrammar::setSrc):
(WebCore::SpeechGrammar::weight):
(WebCore::SpeechGrammar::setWeight):
* Modules/speech/SpeechGrammar.idl:
* Modules/speech/SpeechGrammarList.cpp:
(WebCore):
(WebCore::SpeechGrammarList::create):
(WebCore::SpeechGrammarList::item):
(WebCore::SpeechGrammarList::addFromUri):
(WebCore::SpeechGrammarList::addFromString):
(WebCore::SpeechGrammarList::SpeechGrammarList):
* Modules/speech/SpeechGrammarList.h:
(WebCore):
(SpeechGrammarList):
(WebCore::SpeechGrammarList::length):
* Modules/speech/SpeechGrammarList.idl:
* WebCore.gypi:
LayoutTests:
Add a test for SpeechGrammar and SpeechGrammarList.
* fast/speech/scripted/speechgrammar-basics-expected.txt: Added.
* fast/speech/scripted/speechgrammar-basics.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 9 Mar 2012 10:39:09 +0000 (10:39 +0000)]
Unreviewed, rolling out r110269.
http://trac.webkit.org/changeset/110269
https://bugs.webkit.org/show_bug.cgi?id=80688
It made inspector/elements/highlight-node.html fail everywhere
(Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-09
* testing/Internals.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 9 Mar 2012 09:55:30 +0000 (09:55 +0000)]
[chromium] Unreviewed, build fix after r110191
* features.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 9 Mar 2012 09:51:56 +0000 (09:51 +0000)]
Web Inspector: [Styles] Click in the first line of rule while editing property starts a new property
https://bugs.webkit.org/show_bug.cgi?id=80507
Reviewed by Vsevolod Vlasov.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._checkWillCancelEditing):
(WebInspector.StylePropertiesSection.prototype._handleSelectorContainerClick):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):
(WebInspector.StylePropertyTreeElement.prototype.onattach):
(WebInspector.StylePropertyTreeElement.prototype):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 9 Mar 2012 09:33:51 +0000 (09:33 +0000)]
<rdar://problem/
11012024> Fix the build by working around <rdar://problem/
10710970>.
* platform/mac/RunLoopMac.mm:
(WebCore::RunLoop::stop):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 9 Mar 2012 09:27:39 +0000 (09:27 +0000)]
[Qt] Gardening, skip two failing tests and a timeouting one.
Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-03-09
Reviewed by Csaba Osztrogonác.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 09:01:42 +0000 (09:01 +0000)]
FileInputType doesn't support (save|restore)FormControlState
https://bugs.webkit.org/show_bug.cgi?id=80145
Patch by Marja Hölttä <marja@google.com> on 2012-03-09
Reviewed by Kent Tamura.
Source/WebCore:
This enables saving and restoring the state of file upload elements in
unsubmitted forms.
Test: fast/forms/file/recover-file-input-in-unposted-form.html
* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::restoreFormControlState): non-const
* html/BaseCheckableInputType.h:
(BaseCheckableInputType): restoreFormControlState non-const
* html/FileInputType.cpp:
(WebCore::FileInputType::saveFormControlState): save chosen files
(WebCore):
(WebCore::FileInputType::restoreFormControlState): restore chosen files
* html/FileInputType.h:
(FileInputType): overwrite (save|restore)FormControlState
* html/HiddenInputType.cpp:
(WebCore::HiddenInputType::restoreFormControlState): non-const
* html/HiddenInputType.h:
(HiddenInputType): restoreFormControlState non-const
* html/InputType.cpp:
(WebCore::InputType::restoreFormControlState): non-const
* html/InputType.h:
(InputType): restoreFormControlState non-const
* html/PasswordInputType.cpp:
(WebCore::PasswordInputType::restoreFormControlState): non-const
* html/PasswordInputType.h:
(PasswordInputType): restoreFormControlState non-const
LayoutTests:
Tests for saving and restoring the state of file upload elements in unsubmitted forms.
* fast/forms/file/recover-file-input-in-unposted-form-expected.txt: Added.
* fast/forms/file/recover-file-input-in-unposted-form.html: Added.
* platform/wk2/Skipped: The added test needs eventSender.beginDragWithFiles.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
toyoshim@chromium.org [Fri, 9 Mar 2012 08:48:16 +0000 (08:48 +0000)]
[WebSocket] Add a layout test where server force to disable all extensions
https://bugs.webkit.org/show_bug.cgi?id=80650
Reviewed by Kent Tamura.
* http/tests/websocket/tests/hybi/echo-with-no-extension-expected.txt: Added.
* http/tests/websocket/tests/hybi/echo-with-no-extension.html: Check if extension property is always empty string.
* http/tests/websocket/tests/hybi/echo-with-no-extension_wsh.py: Added a handler which disable all extensions.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
* http/tests/websocket/tests/hybi/extensions-expected.txt: Updated.
* http/tests/websocket/tests/hybi/extensions.html: Added the case after connection is established.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 9 Mar 2012 08:42:21 +0000 (08:42 +0000)]
Unreviewed, rolling out r110250.
http://trac.webkit.org/changeset/110250
https://bugs.webkit.org/show_bug.cgi?id=80682
It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
qt-linux at all. (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-09
* Scripts/old-run-webkit-tests:
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort):
(QtPort.determine_full_port_name):
(QtPort.baseline_search_path):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest.test_baseline_search_path):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 9 Mar 2012 07:39:50 +0000 (07:39 +0000)]
[Qt] Use Qt's module system for install rules and depending on QtWebKit
Instead of rolling our own install rules we now use the same approach as
every other Qt module, by loading qt_module.prf and qt_module_config.prf.
This ensures that we follow the same semantics as the rest of Qt on
what sort of config options are enabled by default (create_cmake eg.).
It also allows us to use QT += webkit instead of the workaround we had
with CONFIG += qtwebkit.
We do however force Qt to always treat our build as a non-developer build,
so the libraries will end up in the WebKit lib directory instead of the
qtbase directory (as with a normal developer-build). This allows us to
keep the webkit-build self-contained. If Qt is a developer build we still
copy the module file manually to Qt, so that you don't have to install
WebKit to make it available.
For non-developer builds of Qt, it is still possible to use the built
WebKit libraries without having to install them, by having the variable
QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
https://bugs.webkit.org/show_bug.cgi?id=80590
Reviewed by Simon Hausmann.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 07:33:56 +0000 (07:33 +0000)]
Base the access to CSSStyleDeclaration on the CSSPropertyID instead of the PropertyName
https://bugs.webkit.org/show_bug.cgi?id=80461
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-08
Reviewed by Geoffrey Garen.
Previously, the acces to CSS Style properties was done through a NamedGetter. This caused
the (slow) mapping between CSSPropertyName and CSSPropertyID to be done twice for every acess:
1) canGetItemsForName() prior to the definition of the slot.
2) nameGetter() called from the slot with CSSPropertyName to get the actual value.
This patch changes the access to be based on CSSPropertyID. The slot is defined with the
CSSPropertyID as the customIndex, and the value can be accessed directly when the slot is
called.
To handle the differences create by hadPixelOrPosPrefix, two nearly identical callback are defined,
one for hadPixelOrPosPrefix, the other for !hadPixelOrPosPrefix.
The performance gain is about 19% when accessing CSS properties.
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::getPropertyValueFallback):
(WebCore::cssPropertyGetterPixelOrPosPrefix):
(WebCore):
(WebCore::cssPropertyGetterPixelOrPosPrefixCallback):
(WebCore::cssPropertyGetter):
(WebCore::cssPropertyGetterCallback):
(WebCore::JSCSSStyleDeclaration::getOwnPropertySlotDelegate):
(WebCore::JSCSSStyleDeclaration::getOwnPropertyDescriptorDelegate):
* css/CSSStyleDeclaration.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 07:33:49 +0000 (07:33 +0000)]
[Texmap][EFL] Implementation of AcceleratedCompositingContext for EFL port
https://bugs.webkit.org/show_bug.cgi?id=80266
Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-03-08
Reviewed by Noam Rosenthal.
This patch adds EFL's implementation of AcceleratedCompositingContext to WebCoreSupport.
* WebCoreSupport/AcceleratedCompositingContextEfl.cpp: Added.
(WebCore):
(WebCore::AcceleratedCompositingContext::create):
(WebCore::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebCore::AcceleratedCompositingContext::~AcceleratedCompositingContext):
(WebCore::AcceleratedCompositingContext::initialize):
(WebCore::AcceleratedCompositingContext::syncLayersNow):
(WebCore::AcceleratedCompositingContext::renderLayers):
(WebCore::AcceleratedCompositingContext::attachRootGraphicsLayer):
(WebCore::AcceleratedCompositingContext::context):
* WebCoreSupport/AcceleratedCompositingContextEfl.h: Added.
(WebCore):
(AcceleratedCompositingContext):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 9 Mar 2012 07:30:51 +0000 (07:30 +0000)]
[Qt] Fix Qt minimal build
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Fri, 9 Mar 2012 07:21:50 +0000 (07:21 +0000)]
Build fix for MSVC after r110266
Unreviewed. A #ifdef for MSVC was left over in r110266.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-08
* runtime/RegExpObject.h:
(RegExpObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 07:16:05 +0000 (07:16 +0000)]
[chromium] Remove dead CoreGraphics code from chromium compositor implementation
https://bugs.webkit.org/show_bug.cgi?id=80470
Patch by James Robinson <jamesr@chromium.org> on 2012-03-08
Reviewed by Adam Barth.
We haven't supported CoreGraphics as a raster backend in chromium for a few months and do not plan to do so, so
it's time to remove the USE(CG) #ifdefs from our compositor and just rely on USE(SKIA) being set. This also
slightly simplifies how PlatformCanvas works.
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/ImageLayerChromium.h:
* platform/graphics/chromium/LayerChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/PlatformCanvas.cpp:
(WebCore::PlatformCanvas::createBackingCanvas):
(WebCore::PlatformCanvas::AutoLocker::AutoLocker):
(WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
(WebCore):
(WebCore::PlatformCanvas::AutoLocker::pixels):
(WebCore::PlatformCanvas::Painter::Painter):
* platform/graphics/chromium/PlatformCanvas.h:
(WebCore):
(AutoLocker):
(Painter):
(PlatformCanvas):
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Fri, 9 Mar 2012 06:49:55 +0000 (06:49 +0000)]
Allocate the RegExpObject's data with the Cell
https://bugs.webkit.org/show_bug.cgi?id=80654
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-08
Reviewed by Gavin Barraclough.
This patch removes the creation of RegExpObject's data to avoid the overhead
create by the allocation and destruction.
We RegExp are created repeatedly, this provides some performance improvment.
The PeaceKeeper test stringDetectBrowser improves by 10%.
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::visitChildren):
(JSC::RegExpObject::getOwnPropertyDescriptor):
(JSC::RegExpObject::defineOwnProperty):
(JSC::RegExpObject::match):
* runtime/RegExpObject.h:
(JSC::RegExpObject::setRegExp):
(JSC::RegExpObject::regExp):
(JSC::RegExpObject::setLastIndex):
(JSC::RegExpObject::getLastIndex):
(RegExpObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
igor.o@sisa.samsung.com [Fri, 9 Mar 2012 06:20:39 +0000 (06:20 +0000)]
Unreviewed. Update my email.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 9 Mar 2012 06:19:43 +0000 (06:19 +0000)]
Source/JavaScriptCore: Separate WTF parts of JavaScriptCoreGenerated into WTFGenerated for Windows build
https://bugs.webkit.org/show_bug.cgi?id=80657
Preparation for WTF separation from JavaScriptCore.
The "Generated" vcproj files on Windows are necessary so Visual Studio can calculate correct
dependencies for generated files.
This also removes the PGO build targets from the WTF code, since we can't build instrumentation/optimization
versions of the WTF code independent of the JavaScriptCore code.
Reviewed by Jessie Berlin.
* JavaScriptCore.vcproj/JavaScriptCore.sln: Add WTFGenerated, update dependent projects.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Removed WTF specific parts.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Removed WTF specific parts.
* JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Removed WTF specific parts.
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Removed WTF specific parts.
* JavaScriptCore.vcproj/JavaScriptCore/work-around-vs-dependency-tracking-bugs.py: Removed.
* JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Add WTFGenerated, update dependent projects.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Remove PGO targets from WTF.
* JavaScriptCore.vcproj/WTF/WTFGenerated.make: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
* JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj.
* JavaScriptCore.vcproj/WTF/WTFGeneratedCommon.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops.
* JavaScriptCore.vcproj/WTF/WTFGeneratedDebug.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebug.vsprops.
* JavaScriptCore.vcproj/WTF/WTFGeneratedDebugAll.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugAll.vsprops.
* JavaScriptCore.vcproj/WTF/WTFGeneratedDebugCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugCairoCFLite.vsprops.
* JavaScriptCore.vcproj/WTF/WTFGeneratedProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedProduction.vsprops.
* JavaScriptCore.vcproj/WTF/WTFGeneratedRelease.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedRelease.vsprops.
* JavaScriptCore.vcproj/WTF/WTFGeneratedReleaseCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleaseCairoCFLite.vsprops.
* JavaScriptCore.vcproj/WTF/WTFReleasePGO.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/build-generated-files.sh: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh.
* JavaScriptCore.vcproj/WTF/copy-files.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd.
* JavaScriptCore.vcproj/WTF/work-around-vs-dependency-tracking-bugs.py: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/work-around-vs-dependency-tracking-bugs.py.
Source/WebKit/win: Separate WTF parts of JavaScriptCoreGenerated into WTFGenerated for Windows build
https://bugs.webkit.org/show_bug.cgi?id=80657
Preparation for WTF separation from JavaScriptCore.
The "Generated" vcproj files on Windows are necessary so Visual Studio can calculate correct
dependencies for generated files.
Reviewed by Jessie Berlin.
* WebKit.vcproj/WebKit.sln: Add WTFGenerated, update dependent projects.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 9 Mar 2012 06:08:03 +0000 (06:08 +0000)]
Get rid of itemTypeAttributeChanged
https://bugs.webkit.org/show_bug.cgi?id=80666
Reviewed by Adam Barth.
This function is unnecessay as we can invalidate m_microDataItemListCaches
in invalidateCachesThatDependOnAttributes as done for other node lists.
* dom/Node.cpp:
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
* dom/Node.h:
* dom/NodeRareData.h:
(NodeListsNodeData):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 9 Mar 2012 05:55:07 +0000 (05:55 +0000)]
Unreviewed, rolling out r108616.
http://trac.webkit.org/changeset/108616
https://bugs.webkit.org/show_bug.cgi?id=80676
breaks animation on Safari welcome page (Requested by smfr on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-08
* page/animation/AnimationController.cpp:
(WebCore::AnimationController::updateAnimations):
* page/animation/AnimationControllerPrivate.h:
(AnimationControllerPrivate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Fri, 9 Mar 2012 05:52:17 +0000 (05:52 +0000)]
Fix the build of WebKit with WTFURL following the removal of ForwardingHeaders/wtf
https://bugs.webkit.org/show_bug.cgi?id=80652
Reviewed by Eric Seidel.
Source/JavaScriptCore:
Fix the header, URLSegments.h is not part of the API.
* wtf/url/api/ParsedURL.h:
Source/WebCore:
The fowarding headers have been removed, we must now use the full path to the header.
* platform/KURLWTFURLImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Fri, 9 Mar 2012 05:00:41 +0000 (05:00 +0000)]
Change calcRadiiFor to IntSize
https://bugs.webkit.org/show_bug.cgi?id=80655
Reviewed by Simon Fraser.
Borders and RoundedRect are both represented with pixel precision. As
such it doesn't make sense for calcRadiiFor to use subpixel units, it
just adds unnecessary type conversions.
No new tests, no new functionality.
* rendering/style/RenderStyle.cpp:
(WebCore::calcRadiiFor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Fri, 9 Mar 2012 04:43:57 +0000 (04:43 +0000)]
[chromium] Encapsulate mask layer settings in LayerChromium
https://bugs.webkit.org/show_bug.cgi?id=80646
Reviewed by James Robinson.
If a WebLayer sets a mask layer, the setIsMask flag will not get set
properly and the mask layer will not turn off tiling. This was only
being set through GraphicsLayerChromium. Move this flag into
LayerChromium so that it always gets set.
Test: LayoutTests/compositing/
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setMaskLayer):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setMaskLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wangxianzhu@chromium.org [Fri, 9 Mar 2012 04:28:32 +0000 (04:28 +0000)]
Recent changes to chromium.py etc. broke chromium_android.py
https://bugs.webkit.org/show_bug.cgi?id=80623
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._start):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 9 Mar 2012 04:27:12 +0000 (04:27 +0000)]
margins on flex-align: baseline are double counted
https://bugs.webkit.org/show_bug.cgi?id=80645
Reviewed by Ojan Vafai.
Source/WebCore:
Fix a bug where we're counting the margins on baseline aligned
children twice. Also add some test cases to make sure we handle
wrap-reverse baseline alignment properly.
Tests: css3/flexbox/multiline-reverse-wrap-baseline-expected.html
css3/flexbox/multiline-reverse-wrap-baseline.html
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
LayoutTests:
* css3/flexbox/multiline-reverse-wrap-baseline-expected.html: Added.
* css3/flexbox/multiline-reverse-wrap-baseline.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wangxianzhu@chromium.org [Fri, 9 Mar 2012 04:07:43 +0000 (04:07 +0000)]
[Chromium] Exception running reftest with --no-pixel-tests
https://bugs.webkit.org/show_bug.cgi?id=80642
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.__init__):
(ChromiumDriver._wrapper_options):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nduca@chromium.org [Fri, 9 Mar 2012 03:52:25 +0000 (03:52 +0000)]
[chromium] Pass setVisibility to CCLayerTreeHostImpl regardless of LRC initialization status
https://bugs.webkit.org/show_bug.cgi?id=80584
Reviewed by James Robinson.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Fri, 9 Mar 2012 03:43:49 +0000 (03:43 +0000)]
[Qt][WK2] Allow transparent WebViews
https://bugs.webkit.org/show_bug.cgi?id=80608
Reviewed by Tor Arne Vestbø.
Added support for transparentBackground in QQuickWebViewExperimental.
This uses the existing drawsTransparentBackground property in WebKit2.
Also, changed LayerTreeHostQt to set the contentsOpaque flag when the root layer changes,
otherwise the change doesn't take effect.
A new API test was added.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::setTransparentBackground):
(QQuickWebViewPrivate::transparentBackground):
(QQuickWebViewExperimental::transparentBackground):
(QQuickWebViewExperimental::setTransparentBackground):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView):
(tst_QQuickWebView::transparentWebViews):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::setRootCompositingLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 9 Mar 2012 03:35:43 +0000 (03:35 +0000)]
rename flexbox tests to describe what is actually being tested
https://bugs.webkit.org/show_bug.cgi?id=80636
Reviewed by Ojan Vafai.
* css3/flexbox/flex-algorithm-expected.txt: Renamed from LayoutTests/css3/flexbox/001-expected.txt.
* css3/flexbox/flex-algorithm-min-max-expected.txt: Renamed from LayoutTests/css3/flexbox/003-expected.txt.
* css3/flexbox/flex-algorithm-min-max.html: Renamed from LayoutTests/css3/flexbox/003.html.
* css3/flexbox/flex-algorithm-with-margins-expected.txt: Renamed from LayoutTests/css3/flexbox/002-expected.txt.
* css3/flexbox/flex-algorithm-with-margins.html: Renamed from LayoutTests/css3/flexbox/002.html.
* css3/flexbox/flex-algorithm.html: Renamed from LayoutTests/css3/flexbox/001.html.
* css3/flexbox/flex-pack-expected.txt: Renamed from LayoutTests/css3/flexbox/004-expected.txt.
* css3/flexbox/flex-pack.html: Renamed from LayoutTests/css3/flexbox/004.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 03:25:37 +0000 (03:25 +0000)]
[chromium] Ensure that the cc thread animation framework continues to tick when the tab is backgrounded
https://bugs.webkit.org/show_bug.cgi?id=77668
Patch by Ian Vollick <vollick@chromium.org> on 2012-03-08
Reviewed by James Robinson.
Source/WebCore:
Tested in CCLayerTreeHostTestTickAnimationWhileBackgrounded
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(CCLayerTreeHostImplTimeSourceAdapter):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::create):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::~CCLayerTreeHostImplTimeSourceAdapter):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::onTimerTick):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::setActive):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::CCLayerTreeHostImplTimeSourceAdapter):
(WebCore):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::animateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore):
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCProxy.cpp:
(WebCore::CCProxy::currentThread):
(WebCore):
(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::setCurrentThreadIsImplThread):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
Source/WebKit/chromium:
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::postAddInstantAnimationToMainThread):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::dispatchAddInstantAnimation):
(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::beginTest):
(WTF):
(CCLayerTreeHostTestTickAnimationWhileBackgrounded):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::CCLayerTreeHostTestTickAnimationWhileBackgrounded):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::beginTest):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::afterTest):
(WTF::TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Fri, 9 Mar 2012 03:21:02 +0000 (03:21 +0000)]
[chromium] Only build NEON files if target_arch=="arm"
https://bugs.webkit.org/show_bug.cgi?id=80626
Currently, webcore_arm_neon will compile a bunch of files
whose contents are completely ifdef'd away on non-arm, and
then bundle all the generated empty .o files into a useless
libwebcore_arm_neon.a. Don't do this.
Reviewed by Tony Chang.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 03:07:22 +0000 (03:07 +0000)]
[NRWT] Fix --platform=qt-5.0 --new-baseline combo
https://bugs.webkit.org/show_bug.cgi?id=72489
Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-03-08
Reviewed by Dirk Pranke.
NRWT: The default platform name for Qt combined with --webkit-test-runner is now
"qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
--platform will override the platform name and then we'll use it.
ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
override it in the end.
* Scripts/old-run-webkit-tests:
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort):
(QtPort.determine_full_port_name):
(QtPort.baseline_search_path):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest.test_baseline_search_path):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 03:05:31 +0000 (03:05 +0000)]
[BlackBerry] Fix warning in PlatformTouchEventBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80621
Fixes a warning seen when control reaches the end of a
non-void function. Return TouchCancel in the 'default' case.
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-08
Reviewed by Rob Buis.
* platform/blackberry/PlatformTouchEventBlackBerry.cpp:
(WebCore::touchEventType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Fri, 9 Mar 2012 02:53:23 +0000 (02:53 +0000)]
GTK+ build fix. Only try to get the backing from the layer in when
ACCELERATED_COMPOSITING is enabled.
Rubber-stamped by Ryosuke Niwa.
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::screenRectOfContents):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 02:50:07 +0000 (02:50 +0000)]
[chromium] Using wrong scissor rect for draw culling
https://bugs.webkit.org/show_bug.cgi?id=80624
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-08
Reviewed by Adrienne Walker.
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Fri, 9 Mar 2012 02:33:03 +0000 (02:33 +0000)]
Unreviewed, update chromium test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 02:30:14 +0000 (02:30 +0000)]
[chromium] Force the Canvas2D GPU texture cache to 0 bytes for backgrounded tabs.
https://bugs.webkit.org/show_bug.cgi?id=79948
Patch by Jeff Timanus <twiz@chromium.org> on 2012-03-08
Reviewed by Stephen White.
* src/GraphicsContext3DChromium.cpp:
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::setVisibilityCHROMIUM):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 9 Mar 2012 02:25:51 +0000 (02:25 +0000)]
Fix some Leopard tests that broke with r110229.
* platform/chromium-mac-leopard/fast/table/cell-coalescing-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/floating-th-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/thai-baht-space-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/text/wbr-pre-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/whitespace/001-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/whitespace/019-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/whitespace/023-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/whitespace/028-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/whitespace/029-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/whitespace/pre-newline-box-test-expected.png: Added.
* platform/chromium-mac-leopard/fast/writing-mode/border-vertical-lr-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/xsl/xslt-enc-cyr-expected.png: Added.
* platform/chromium-mac-leopard/fast/xsl/xslt-enc-expected.png: Added.
* platform/chromium-mac-leopard/fast/xsl/xslt-enc16-expected.png: Added.
* platform/chromium-mac-leopard/fast/xsl/xslt-enc16to16-expected.png: Added.
* platform/chromium-mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.png: Added.
* platform/chromium-mac-leopard/fast/xsl/xslt_unicode-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Fri, 9 Mar 2012 02:24:36 +0000 (02:24 +0000)]
REGRESSION (r105396): Dragging an iWork document into icloud.com opens it in the Mac app instead of uploading it to icloud.com
https://bugs.webkit.org/show_bug.cgi?id=79443
Reviewed by Ryosuke Niwa.
Source/WebCore:
icloud.com registers a drop event handler that sets display:none on the
file input element receiving the drop. After dispatching the drop event,
DragController hit tests the position under the mouse to see if it is a
file input element in need of receiving files. Since the file input
element has lost its renderer, it cannot be found by hit testing, so
the dropped file is never attached to the file input element, no change
event fires, and no upload commences. We want these things to happen
even if the element is no longer visible.
Since we already keep track of the file input element under the mouse
via m_fileInputElementUnderMouse, this additional hit test is
unnecessary. Use m_fileInputElementUnderMouse in concludeEditDrag()
when dropping files.
Test: fast/events/file-input-hidden-in-ondrop.html
* page/DragController.cpp:
(WebCore::DragController::concludeEditDrag): Use
m_fileInputElementUnderMouse instead of the element returned by hit
testing. Assert that m_fileInputElementUnderMouse equals the hit tested
element unless m_fileInputElementUnderMouse doesn't have a renderer.
LayoutTests:
* fast/events/file-input-hidden-in-ondrop-expected.txt: Added.
* fast/events/file-input-hidden-in-ondrop.html: Added.
* platform/wk2/Skipped: WebKitTestRunner doesn't support
EventSender.beginDragWithFiles().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 02:19:38 +0000 (02:19 +0000)]
[chromium] Replace completelyContains with Region::contains()
https://bugs.webkit.org/show_bug.cgi?id=80617
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-08
Reviewed by James Robinson.
* tests/CCLayerTestCommon.cpp:
(CCLayerTestCommon):
(CCLayerTestCommon::verifyQuadsExactlyCoverRect):
* tests/CCLayerTestCommon.h:
(CCLayerTestCommon):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 9 Mar 2012 01:53:41 +0000 (01:53 +0000)]
Moar Chromium Lion rebaselines.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Mar 2012 01:27:31 +0000 (01:27 +0000)]
[chromium] more comprehensive tests for gesture scrolling
https://bugs.webkit.org/show_bug.cgi?id=80201
Prior to landing some changes to EventHandler::handleGestureEvent, add
some tests to ensure that the behaviour of handleGestureEvent and
handleWheelEvent don't regress.
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-08
Reviewed by Dimitri Glazkov.
* fast/events/touch/gesture/resources/gesture-helpers.js: Added: utility functions.
(recordWheel):
(recordScroll):
(exitIfNecessary):
(checkTestDependencies):
(checkScrollOffset):
* fast/events/touch/gesture/resources/scroll-inside-iframe.html: Added.
* fast/events/touch/gesture/touch-gesture-scroll-div-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-scroll-div.html: Added.
* fast/events/touch/gesture/touch-gesture-scroll-iframe-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-scroll-iframe.html: Added.
* fast/events/touch/gesture/touch-gesture-scroll-page-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-scroll-page.html: Added.
* fast/events/touch/gesture/touch-gesture-scroll-shy-target-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-scroll-shy-target.html: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-div-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-iframe-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-page-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-shy-target-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc