WebKit-https.git
12 months ago[macOS] Color wells should appear pressed when presenting a color picker
akeerthi@apple.com [Sun, 12 Aug 2018 20:19:25 +0000 (20:19 +0000)]
[macOS] Color wells should appear pressed when presenting a color picker
https://bugs.webkit.org/show_bug.cgi?id=188477

Reviewed by Tim Horton.

Source/WebCore:

Currently, when clicking on a color well, the color well loses its pressed
appearance once the mouse is lifted. Because of this behavior, the color well
does not appear to be active when the color picker is displayed.

Added the color-well -webkit-appearance value to control the drawing of the color
well separate from other buttons. Also added a new ControlState, named
PresentingState. A control can be in this state whenever it is presenting some
attached view. In the case of the color well this is the color picker. The
Information as to whether a form control is in the presenting state comes from
isPresentingAttachedView() in HTMLInputElement.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSProperties.json:
* css/CSSValueKeywords.in:
* css/html.css:
(input[type="color"]::-webkit-color-swatch):
* html/ColorInputType.cpp:
(WebCore::ColorInputType::isPresentingAttachedView const):
(WebCore::ColorInputType::elementDidBlur):
(WebCore::ColorInputType::didEndChooser):
* html/ColorInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isPresentingAttachedView const):
* html/HTMLInputElement.h:
* html/InputType.cpp:
(WebCore::InputType::isPresentingAttachedView const):
* html/InputType.h:
* platform/ControlStates.h:
* platform/ThemeTypes.h:
* platform/mac/ThemeMac.mm:
(WebCore::updateStates):
(WebCore::setUpButtonCell):
(WebCore::paintColorWell):
(WebCore::ThemeMac::minimumControlSize const):
(WebCore::ThemeMac::controlBorder const):
(WebCore::ThemeMac::paint):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::isControlStyled const):
(WebCore::RenderTheme::extractControlStatesForRenderer const):
(WebCore::RenderTheme::isPresenting const):
* rendering/RenderTheme.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect):

Source/WebInspectorUI:

Add keyword completion for 'color-well'.

* UserInterface/External/CodeMirror/css.js:
* UserInterface/Models/CSSKeywordCompletions.js:

Source/WebKit:

In order for the color well to accurately reflect the state of the picker, it is
necessary to ensure that the picker is destroyed at the appropriate time.

Added windowWillClose and didClosePopover delegate methods to destroy the picker
it has been closed. Also added a call to WebColorPicker::endPicker in
WebColorPickerMac's implementation of endPicker to ensure that the object is
destroyed. Removed redundant calls to endPicker in the WebPageProxy.

The hitTest method was overridden in WKPopoverColorWell to ensure that AppKit's
view does not block our drawn color well from receiving click events.

* UIProcess/WebColorPicker.cpp:
(WebKit::WebColorPicker::endPicker):
* UIProcess/WebColorPicker.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::endColorPicker):
(WebKit::WebPageProxy::didEndColorPicker):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::closeOverlayedViews):
* UIProcess/mac/WebColorPickerMac.mm:
(WebKit::WebColorPickerMac::~WebColorPickerMac):
(WebKit::WebColorPickerMac::endPicker):
(-[WKPopoverColorWell popoverDidClose:]):
(-[WKPopoverColorWell hitTest:]):
(-[WKColorPopoverMac setAndShowPicker:withColor:suggestions:]):
(-[WKColorPopoverMac invalidate]):
(-[WKColorPopoverMac windowWillClose:]):
(-[WKColorPopoverMac didClosePopover]):

LayoutTests:

Rebaseline tests to match new color-well appearance.

* platform/mac/fast/forms/color/input-appearance-color-expected.png:
* platform/mac/fast/forms/color/input-appearance-color-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoDisable JIT on IA-32 without SSE2
commit-queue@webkit.org [Sun, 12 Aug 2018 16:36:51 +0000 (16:36 +0000)]
Disable JIT on IA-32 without SSE2
https://bugs.webkit.org/show_bug.cgi?id=188476

Patch by Karo Gyoker <karogyoker2+webkit@gmail.com> on 2018-08-12
Reviewed by Michael Catanzaro.

Including missing header (MacroAssembler.h) in case of other
operating systems than Windows too.

* runtime/Options.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[LFC] Float prev/next sibling should prevent top/bottom margin collapsing with parent.
zalan@apple.com [Sun, 12 Aug 2018 15:46:44 +0000 (15:46 +0000)]
[LFC] Float prev/next sibling should prevent top/bottom margin collapsing with parent.
https://bugs.webkit.org/show_bug.cgi?id=188487

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/block/block-only/floating-and-next-previous-inflow-with-margin.html

* layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::isMarginTopCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::isMarginBottomCollapsedWithParent):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

* fast/block/block-only/floating-and-next-previous-inflow-with-margin-expected.txt: Added.
* fast/block/block-only/floating-and-next-previous-inflow-with-margin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[ews-build] Separate queues for Builders and Testers - iOS
aakash_jain@apple.com [Sun, 12 Aug 2018 04:13:52 +0000 (04:13 +0000)]
[ews-build] Separate queues for Builders and Testers - iOS
https://bugs.webkit.org/show_bug.cgi?id=188396

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/config.json: Splitted iOS queues into builders and testers.
Also added ews121 and ews122 to match with current EWS configuration.
* BuildSlaveSupport/ews-build/factories.py:
(TestsFactory): Base classes for various Test factories.
(TestsFactory.getProduct): Download and extract the archive.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoDisable JIT on IA-32 without SSE2
commit-queue@webkit.org [Sat, 11 Aug 2018 21:04:12 +0000 (21:04 +0000)]
Disable JIT on IA-32 without SSE2
https://bugs.webkit.org/show_bug.cgi?id=188476

Patch by Karo Gyoker <karogyoker2+webkit@gmail.com> on 2018-08-11
Reviewed by Yusuke Suzuki.

On IA-32 CPUs without SSE2 most of the webpages cannot load
if the JIT is turned on.

* runtime/Options.cpp:
(JSC::recomputeDependentOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[l10n] [pt_BR] Updated Brazilian Portuguese translation
mcatanzaro@igalia.com [Sat, 11 Aug 2018 14:04:37 +0000 (14:04 +0000)]
[l10n] [pt_BR] Updated Brazilian Portuguese translation
https://bugs.webkit.org/show_bug.cgi?id=188482

Patch by Rafael Fontenelle <rafaelff@gnome.org> on 2018-08-11
Rubber-stamped by Michael Catanzaro.

* pt_BR.po:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoUse OptionSet for various RenderLayer flags
antti@apple.com [Sat, 11 Aug 2018 06:47:30 +0000 (06:47 +0000)]
Use OptionSet for various RenderLayer flags
https://bugs.webkit.org/show_bug.cgi?id=188472
<rdar://problem/43153059>

Followup, fix some mistakes.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::~RenderLayerBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[Cocoa] WebKit::PlatformPopupMenuData should use member initialization
ddkilzer@apple.com [Sat, 11 Aug 2018 02:55:23 +0000 (02:55 +0000)]
[Cocoa] WebKit::PlatformPopupMenuData should use member initialization
<https://webkit.org/b/188478>
<rdar://problem/43154363>

Reviewed by Joseph Pecoraro.

* Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::PlatformPopupMenuData): Delete
implementation.  This constructor caused the warning by never
initializing its member variables.
* Shared/PlatformPopupMenuData.h:
(WebKit::PlatformPopupMenuData::PlatformPopupMenuData):
- Use default constructor.
(WebKit::PlatformPopupMenuData::shouldPopOver):
(WebKit::PlatformPopupMenuData::hideArrows):
(WebKit::PlatformPopupMenuData::menuSize):
- Add struct member initialization.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoWeb Inspector: console.log fires getters for deep properties
commit-queue@webkit.org [Sat, 11 Aug 2018 02:43:47 +0000 (02:43 +0000)]
Web Inspector: console.log fires getters for deep properties
https://bugs.webkit.org/show_bug.cgi?id=187542
<rdar://problem/42873158>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2018-08-10
Reviewed by Saam Barati.

Source/JavaScriptCore:

* inspector/InjectedScriptSource.js:
(RemoteObject.prototype._isPreviewableObject):
Avoid getters/setters when checking for simple properties to preview.
Here we avoid invoking `object[property]` if it could be a user getter.

LayoutTests:

* inspector/injected-script/avoid-getter-invocation-expected.txt: Added.
* inspector/injected-script/avoid-getter-invocation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoLayoutTest inspector/worker/debugger-pause.html is a flaky failure
commit-queue@webkit.org [Sat, 11 Aug 2018 02:21:10 +0000 (02:21 +0000)]
LayoutTest inspector/worker/debugger-pause.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=164833
<rdar://problem/29295404>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2018-08-10
Reviewed by Brian Burg.

* inspector/worker/debugger-pause.html:
Add a microtask turn to ensure the workerTarget's mainResource is setup.
There were times it might not get setup, but a single turn appears
reliable enough.

* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
This test always passes for me in Release and Debug. Reset expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[macOS] Multiple third party apps crash due to the thread safety check in TimerBase...
rniwa@webkit.org [Sat, 11 Aug 2018 02:01:24 +0000 (02:01 +0000)]
[macOS] Multiple third party apps crash due to the thread safety check in TimerBase::setNextFireTime
https://bugs.webkit.org/show_bug.cgi?id=188480

Reviewed by Simon Fraser.

Source/WebCore:

Suppress the release assert in WebKit1 on macOS (isInWebProcess is always true in non-Cocoa platforms).

In the future, we should consider throwing Objective-C exceptions when third party apps call WebKit1
or WebKit2 APIs in non-main threads.

* platform/Timer.cpp:
(WebCore::shouldSuppressThreadSafetyCheck): Extracted out of ~TimerBase and setNextFireTime.
(WebCore::TimerBase::~TimerBase):
(WebCore::TimerBase::setNextFireTime):

Source/WTF:

Added the SDK version for macOS Mojave.

* wtf/spi/darwin/dyldSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoSlicing an ArrayBuffer with a long number returns an ArrayBuffer with byteLength...
keith_miller@apple.com [Fri, 10 Aug 2018 23:31:50 +0000 (23:31 +0000)]
Slicing an ArrayBuffer with a long number returns an ArrayBuffer with byteLength zero
https://bugs.webkit.org/show_bug.cgi?id=185127

Reviewed by Saam Barati.

JSTests:

Rebaseline the expectations.

* test262/expectations.yaml:

Source/JavaScriptCore:

Previously, we would truncate the indicies passed to slice to an
int. This meant that the value was not getting properly clamped
later.

This patch also removes a non-spec compliant check that slice was
passed at least one argument.

* runtime/ArrayBuffer.cpp:
(JSC::ArrayBuffer::clampValue):
(JSC::ArrayBuffer::clampIndex const):
(JSC::ArrayBuffer::slice const):
* runtime/ArrayBuffer.h:
(JSC::ArrayBuffer::clampValue): Deleted.
(JSC::ArrayBuffer::clampIndex const): Deleted.
* runtime/JSArrayBufferPrototype.cpp:
(JSC::arrayBufferProtoFuncSlice):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoCrash under NetworkResourceLoader::convertToDownload()
cdumez@apple.com [Fri, 10 Aug 2018 23:03:25 +0000 (23:03 +0000)]
Crash under NetworkResourceLoader::convertToDownload()
https://bugs.webkit.org/show_bug.cgi?id=188479
<rdar://problem/42201724>

Reviewed by Alex Christensen.

Source/WebKit:

In NetworkResourceLoader::convertToDownload(), if m_networkLoad is null then we're trying
to convert a load that came from the disk cache. Since we do not currently support converting
such a load, cancel the current load and start a fresh download.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::convertToDownload):

LayoutTests:

Add layout test coverage which reproduces the crash by:
1. Loading a cacheable plugin while plugins are enabled so that the plugin goes into the disk cache
2. Load the plugin again with plugins disabled so that we try to convert the load to a download

* http/tests/download/convert-cached-load-to-download-expected.txt: Added.
* http/tests/download/convert-cached-load-to-download.html: Added.
* http/tests/plugins/resources/mock-plugin-cacheable.pl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoCleanup: Remove unnecessary code to resume animations from CachedFrameBase::restore()
dbates@webkit.org [Fri, 10 Aug 2018 21:53:06 +0000 (21:53 +0000)]
Cleanup: Remove unnecessary code to resume animations from CachedFrameBase::restore()
https://bugs.webkit.org/show_bug.cgi?id=188459

Reviewed by Chris Dumez.

It is unnessary for CachedFrameBase::restore() to explicitly resume animations on the
document as it calls Document::resume(), which already does this.

No functionality changed. So, no new tests.

* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agowebkit-patch setup-git-clone should set Git core editor to commit-log-editor
dbates@webkit.org [Fri, 10 Aug 2018 21:48:41 +0000 (21:48 +0000)]
webkit-patch setup-git-clone should set Git core editor to commit-log-editor
https://bugs.webkit.org/show_bug.cgi?id=188473

Reviewed by Ryosuke Niwa.

Have "webkit-patch setup-git-clone" set the Git core editor to "perl Tools/Scripts/commit-log-editor --regenerate-log"
so that the Git commit message is generated from the ChangeLog for developers that manually
generate their ChangeLog using prepare-ChangeLog.

* Scripts/webkitpy/tool/commands/setupgitclone.py:
(SetupGitClone.execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[WinCairo] More unreviewed gardening.
ross.kirsling@sony.com [Fri, 10 Aug 2018 20:29:43 +0000 (20:29 +0000)]
[WinCairo] More unreviewed gardening.

* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoUse OptionSet for various RenderLayer flags
antti@apple.com [Fri, 10 Aug 2018 19:51:44 +0000 (19:51 +0000)]
Use OptionSet for various RenderLayer flags
https://bugs.webkit.org/show_bug.cgi?id=188472

Reviewed by Simon Fraser.

Source/WebCore:

Typesafe flags.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
* page/FrameView.cpp:
(WebCore::updateLayerPositionFlags):
(WebCore::FrameView::paintContents):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterLayout):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::paint):
(WebCore::paintForFixedRootBackground):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContentsAndReflection):
(WebCore::RenderLayer::filterPainter const):
(WebCore::RenderLayer::hasFilterThatIsPainting const):
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintLayerContents):
(RenderLayer::paintLayerByApplyingTransform):
(RenderLayer::paintList):
(RenderLayer::updatePaintingInfoForFragments):
(RenderLayer::paintTransformedLayerIntoFragments):
(RenderLayer::calculateClipRects const):
(WebCore::RenderLayer::paintLayerByApplyingTransform): Deleted.
(WebCore::RenderLayer::paintList): Deleted.
(WebCore::RenderLayer::enclosingPaginationLayerInSubtree const): Deleted.
(WebCore::RenderLayer::collectFragments): Deleted.
(WebCore::RenderLayer::updatePaintingInfoForFragments): Deleted.
(WebCore::RenderLayer::paintTransformedLayerIntoFragments): Deleted.
(WebCore::RenderLayer::paintBackgroundForFragments): Deleted.
(WebCore::RenderLayer::paintForegroundForFragments): Deleted.
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase): Deleted.
(WebCore::RenderLayer::paintOutlineForFragments): Deleted.
(WebCore::RenderLayer::paintMaskForFragments): Deleted.
(WebCore::RenderLayer::paintChildClippingMaskForFragments): Deleted.
(WebCore::RenderLayer::paintOverflowControlsForFragments): Deleted.
(WebCore::RenderLayer::hitTest): Deleted.
(WebCore::RenderLayer::enclosingElement const): Deleted.
(WebCore::RenderLayer::enclosingFragmentedFlowAncestor const): Deleted.
(WebCore::computeZOffset): Deleted.
(WebCore::RenderLayer::createLocalTransformState const): Deleted.
(WebCore::isHitCandidate): Deleted.
(WebCore::RenderLayer::hitTestLayer): Deleted.
(WebCore::RenderLayer::hitTestContentsForFragments const): Deleted.
(WebCore::RenderLayer::hitTestResizerInFragments const): Deleted.
(WebCore::RenderLayer::hitTestTransformedLayerInFragments): Deleted.
(WebCore::RenderLayer::hitTestLayerByApplyingTransform): Deleted.
(WebCore::RenderLayer::hitTestContents const): Deleted.
(WebCore::RenderLayer::hitTestList): Deleted.
(WebCore::RenderLayer::updateClipRects): Deleted.
(WebCore::RenderLayer::clipRects const): Deleted.
(WebCore::RenderLayer::calculateClipRects const): Deleted.
(WebCore::showLayerTree): Deleted.
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
(WebCore::RenderLayerBacking::paintIntoLayer):
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
* rendering/RenderLayerCompositor.h:
* rendering/RenderReplica.cpp:
(WebCore::RenderReplica::paint):

Source/WTF:

* wtf/MathExtras.h:
(hasOneBitSet):
(hasZeroOrOneBitsSet):
(hasTwoOrMoreBitsSet):

Make constexpr.

* wtf/OptionSet.h:
(WTF::OptionSet::OptionSet):

Always use constexpr, no need for separate debug versions with C++14.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[LayoutTests] Suppress warning messages generated by the test scripts.
Basuke.Suzuki@sony.com [Fri, 10 Aug 2018 19:35:00 +0000 (19:35 +0000)]
[LayoutTests] Suppress warning messages generated by the test scripts.
https://bugs.webkit.org/show_bug.cgi?id=188455

Reviewed by Fujii Hironori.

The messages such as warnings shouldn't be out on error log if that can be avoidable.

* http/tests/cookies/resources/cookie-utility.php:
* http/tests/xmlhttprequest/resources/access-control-allow-lists.php:
* http/tests/xmlhttprequest/resources/access-control-basic-get-fail-non-simple.cgi:
* http/tests/xmlhttprequest/resources/post-echo.cgi:
* http/tests/xmlhttprequest/web-apps/004-test.cgi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoCrashTracer: com.apple.WebKit.Storage at WebCore::IDBServer::UniqueIDBDatabase::sched...
sihui_liu@apple.com [Fri, 10 Aug 2018 19:05:45 +0000 (19:05 +0000)]
CrashTracer: com.apple.WebKit.Storage at WebCore::IDBServer::UniqueIDBDatabase::scheduleShutdownForClose
https://bugs.webkit.org/show_bug.cgi?id=188461
<rdar://problem/33555052>

Reviewed by Chris Dumez.

When we try to schedule shutdown for database, we should cancel the timer so no
scheduleShutdownForClose will be running after this.

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::scheduleShutdownForClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoUnreviewed, rolling out r234749.
tsavell@apple.com [Fri, 10 Aug 2018 18:56:39 +0000 (18:56 +0000)]
Unreviewed, rolling out r234749.

Caused all perf tests to fail in Sierra

Reverted changeset:

"[webkitpy][Win] LayoutTests: test names should be Unix style,
separated by slash not backslash"
https://bugs.webkit.org/show_bug.cgi?id=187973
https://trac.webkit.org/changeset/234749

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoAdd ability to ignore process prewarming for launch time benchmark
commit-queue@webkit.org [Fri, 10 Aug 2018 18:23:50 +0000 (18:23 +0000)]
Add ability to ignore process prewarming for launch time benchmark
https://bugs.webkit.org/show_bug.cgi?id=188462

Patch by Ben Richards <benton_richards@apple.com> on 2018-08-10
Reviewed by Ryosuke Niwa.

Added a flag to the new tab benchmark that will open a blank tab before the tab to be measured in order to ignore process prewarming.

* LaunchTime/launch_time.py:
(DefaultLaunchTimeHandler):
(DefaultLaunchTimeHandler.on_receive_stop_time): Deleted.
(DefaultLaunchTimeHandler.on_receive_stop_signal):
(DefaultLaunchTimeHandler.do_HEAD):
(DefaultLaunchTimeHandler.do_GET):
(DefaultLaunchTimeHandler.do_POST):
(LaunchTimeBenchmark):
(LaunchTimeBenchmark._standard_deviation): Fixed divide by zero bug when '-n' is set to 1
(LaunchTimeBenchmark.open_tab): Added option to open a blank tab
(LaunchTimeBenchmark.run):
* LaunchTime/new_tab.py:
(NewTabBenchmark.initialize):
(NewTabBenchmark.run_iteration):
(NewTabBenchmark.will_parse_arguments):
(NewTabBenchmark.did_parse_arguments):
(NewTabBenchmark.ResponseHandler.Handler.get_test_page):
(NewTabBenchmark.ResponseHandler.Handler.on_receive_stop_time): Deleted.
(NewTabBenchmark.ResponseHandler.Handler.on_receive_stop_signal):
(NewTabBenchmark):
* LaunchTime/startup.py:
(StartupBenchmark.ResponseHandler.Handler.get_test_page):
(StartupBenchmark.ResponseHandler.Handler.on_receive_stop_time): Deleted.
(StartupBenchmark.ResponseHandler.Handler.on_receive_stop_signal):
(StartupBenchmark):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoDate.UTC should not return NaN with only Year param
yusukesuzuki@slowstart.org [Fri, 10 Aug 2018 17:42:32 +0000 (17:42 +0000)]
Date.UTC should not return NaN with only Year param
https://bugs.webkit.org/show_bug.cgi?id=188378

Reviewed by Keith Miller.

JSTests:

* ChakraCore.yaml:
* ChakraCore/test/Date/dateutc.baseline-jsc: Added.
* stress/date-utc-optional.js: Added.
(shouldBe):
* test262/expectations.yaml:

Source/JavaScriptCore:

Date.UTC requires one argument for |year|. But the other ones are optional.
This patch fix this handling.

* runtime/DateConstructor.cpp:
(JSC::millisecondsFromComponents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoOnce <object> is hidden, its content won't be displayed again if its URL has fragment...
dbates@webkit.org [Fri, 10 Aug 2018 17:39:53 +0000 (17:39 +0000)]
Once <object> is hidden, its content won't be displayed again if its URL has fragment identifier ("#").
https://bugs.webkit.org/show_bug.cgi?id=187990

Reviewed by Simon Fraser.

Source/WebCore:

Fixes an issue where an HTML object element that behaves like an iframe and references a resource
whose URL contains a fragment would not be repainted when its CSS display property changes.

Rendering of an <object> that behaves like an iframe is handled by a widget (FrameView). When
the CSS display property for an <object> is set to "none" we detach the widget from its renderer
as part of destroying the render tree for the <object>. Subsequently changing the CSS display
to a non-"none"/"contents" value will create a new renderer for <object> R. For an <object> that
behaves like an iframe, we navigate to the resource associated with the <object> reusing the
existing Frame F object created when we first displayed the <object>. Unlike the case where
the URL of the resource does not contain a fragment, navigating to a fragment in the same document
uses a different code path that does not re-associate the FrameView of F with R before it scrolls
the view; => the FrameView of F is not in the view hierarchy. Therefore we do not paint anything
for the content of the <object> and hence the scroll is not observable. Instead we need to ensure
that the FrameView of F installed in the view hierarchy when navigating to an anchor in the same
document.

As a side benefit of this fix we now also repaint an <object> that is programmatically navigated
to a different anchor in the same document.

Tests: fast/repaint/object-as-iframe-hide-and-show-document-at-anchor.html
       fast/repaint/object-as-iframe-navigate-to-same-document-anchor-repaint.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadInSameDocument):

LayoutTests:

Add tests to ensure that we repaint an <object>, whose resource URL contains a fragment, when
its CSS display property changes as well as when its navigated to a different anchor in the same
document.

* fast/repaint/object-as-iframe-hide-and-show-document-at-anchor-expected.txt: Added.
* fast/repaint/object-as-iframe-hide-and-show-document-at-anchor.html: Added.
* fast/repaint/object-as-iframe-navigate-to-same-document-anchor-repaint-expected.txt: Added.
* fast/repaint/object-as-iframe-navigate-to-same-document-anchor-repaint.html: Added.
* fast/repaint/resources/red-square-on-top-of-green-square.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[IntersectionObserver] Implement rootMargin parsing
ajuma@chromium.org [Fri, 10 Aug 2018 17:08:44 +0000 (17:08 +0000)]
[IntersectionObserver] Implement rootMargin parsing
https://bugs.webkit.org/show_bug.cgi?id=188469

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update expectations for newly passing test cases.

* web-platform-tests/intersection-observer/observer-attributes-expected.txt:
* web-platform-tests/intersection-observer/observer-exceptions-expected.txt:

Source/WebCore:

Parse IntersectionObserver's rootMargin argument and throw an exception if it's invalid.
Change the stored rootMargin from a String to a LengthBox so that future patches can
use this value in intersection logic.

Tested by: imported/w3c/web-platform-tests/intersection-observer/observer-attributes.html
           imported/w3c/web-platform-tests/intersection-observer/observer-exceptions.html
           intersection-observer/intersection-observer-interface.html

* page/IntersectionObserver.cpp:
(WebCore::parseRootMargin):
(WebCore::IntersectionObserver::create):
(WebCore::IntersectionObserver::IntersectionObserver):
(WebCore::IntersectionObserver::rootMargin const):
* page/IntersectionObserver.h:
(WebCore::IntersectionObserver::create): Deleted.
(WebCore::IntersectionObserver::rootMargin const): Deleted.
* page/IntersectionObserver.idl:

LayoutTests:

* intersection-observer/intersection-observer-interface-expected.txt:
* intersection-observer/intersection-observer-interface.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoIncorrect log message in NetworkSession when creating NetworkDataTask
sihui_liu@apple.com [Fri, 10 Aug 2018 16:45:57 +0000 (16:45 +0000)]
Incorrect log message in NetworkSession when creating NetworkDataTask
https://bugs.webkit.org/show_bug.cgi?id=188463

Reviewed by Chris Dumez.

* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoTimeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and TestWebKitAP...
david_fenton@apple.com [Fri, 10 Aug 2018 16:31:51 +0000 (16:31 +0000)]
Timeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and TestWebKitAPI.PreferredAudioBufferSize.WebAudio.
https://bugs.webkit.org/show_bug.cgi?id=188470.

Unreviewed test gardening, disabling the tests.

* TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoUnreviewed, rolling out r234750.
tsavell@apple.com [Fri, 10 Aug 2018 16:26:13 +0000 (16:26 +0000)]
Unreviewed, rolling out r234750.

Caused 185 perf test failures.

Reverted changeset:

"Add ability to ignore process prewarming for launch time
benchmark"
https://bugs.webkit.org/show_bug.cgi?id=188462
https://trac.webkit.org/changeset/234750

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoEliminate remaining instances of "ElCapitan" from LayoutTests / Tools
commit-queue@webkit.org [Fri, 10 Aug 2018 16:10:45 +0000 (16:10 +0000)]
Eliminate remaining instances of "ElCapitan" from LayoutTests / Tools
https://bugs.webkit.org/show_bug.cgi?id=188458

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2018-08-10
Reviewed by Alex Christensen.

Tools:

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
* TestResultServer/static-dashboards/flakiness_dashboard.js:

LayoutTests:

* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[GTK][WPE] WebDriver: do not use default browser arguments when browser binary has...
carlosgc@webkit.org [Fri, 10 Aug 2018 08:17:06 +0000 (08:17 +0000)]
[GTK][WPE] WebDriver: do not use default browser arguments when browser binary has been provided
https://bugs.webkit.org/show_bug.cgi?id=188465

Reviewed by Žan Doberšek.

We only want to use --automation when no options or no browser binary is provided, because we fallback to
MiniBrowser and we know it needs --automation flag.

* glib/SessionHostGlib.cpp:
(WebDriver::SessionHost::launchBrowser): Handle the case of browser arguments being std::nullopt.
* gtk/WebDriverServiceGtk.cpp:
(WebDriver::WebDriverService::platformParseCapabilities const): Initialize browser arguments to std:nullopt if
browser binary was provided.
* wpe/WebDriverServiceWPE.cpp:
(WebDriver::WebDriverService::platformParseCapabilities const): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[WinCairo] Unreviewed layout test gardening.
ross.kirsling@sony.com [Fri, 10 Aug 2018 07:57:00 +0000 (07:57 +0000)]
[WinCairo] Unreviewed layout test gardening.

* platform/wincairo/TestExpectations:
* platform/wincairo/editing/selection/5057506-expected.png: Added.
* platform/wincairo/editing/selection/caret-ltr-right-expected.txt:
* platform/wincairo/editing/selection/caret-rtl-right-expected.txt:
* platform/wincairo/editing/selection/doubleclick-crash-expected.txt: Added.
* platform/wincairo/editing/selection/editable-links-expected.txt: Added.
* platform/wincairo/editing/selection/extend-by-character-006-expected.txt: Added.
* platform/wincairo/editing/selection/extend-by-sentence-001-expected.txt: Added.
* platform/wincairo/editing/selection/extend-by-word-001-expected.txt: Added.
* platform/wincairo/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
* platform/wincairo/editing/selection/extend-inside-transforms-forward-expected.txt: Added.
* platform/wincairo/editing/selection/extend-selection-bidi-expected.txt: Added.
* platform/wincairo/editing/selection/focus-body-expected.txt: Added.
* platform/wincairo/editing/selection/move-by-line-001-expected.txt: Added.
* platform/wincairo/editing/selection/move-by-word-001-expected.txt: Added.
* platform/wincairo/editing/selection/select-all-001-expected.txt: Added.
* platform/wincairo/editing/selection/select-all-002-expected.txt: Added.
* platform/wincairo/editing/selection/select-all-003-expected.txt: Added.
* platform/wincairo/editing/selection/select-all-004-expected.txt: Added.
* platform/wincairo/editing/selection/unrendered-001-expected.txt: Added.
* platform/wincairo/editing/selection/unrendered-002-expected.txt: Added.
* platform/wincairo/editing/selection/unrendered-003-expected.txt: Added.
* platform/wincairo/editing/selection/unrendered-004-expected.txt: Added.
* platform/wincairo/editing/selection/unrendered-005-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[LayoutTests] Test case which committed on r175053 was wrong.
Basuke.Suzuki@sony.com [Fri, 10 Aug 2018 05:13:47 +0000 (05:13 +0000)]
[LayoutTests] Test case which committed on r175053 was wrong.
https://bugs.webkit.org/show_bug.cgi?id=188454

Reviewed by Fujii Hironori.

It was originally committed on https://bugs.webkit.org/show_bug.cgi?id=136938 and has kept unchanged,
but the test case uses non-existing redirect.php scripts which was removed a few months before than
this bug. Also result was compared to wrong values.

* http/tests/xmlhttprequest/cross-origin-redirect-responseURL-expected.txt:
* http/tests/xmlhttprequest/cross-origin-redirect-responseURL.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoAdd ability to ignore process prewarming for launch time benchmark
commit-queue@webkit.org [Fri, 10 Aug 2018 04:53:42 +0000 (04:53 +0000)]
Add ability to ignore process prewarming for launch time benchmark
https://bugs.webkit.org/show_bug.cgi?id=188462

Patch by Ben Richards <benton_richards@apple.com> on 2018-08-09
Reviewed by Ryosuke Niwa.

Added a flag to the new tab benchmark that will open a blank tab before the tab to be measured in order to ignore process prewarming.

* LaunchTime/launch_time.py:
(DefaultLaunchTimeHandler):
(DefaultLaunchTimeHandler.on_receive_stop_time): Deleted.
(DefaultLaunchTimeHandler.on_receive_stop_signal):
(DefaultLaunchTimeHandler.do_HEAD):
(DefaultLaunchTimeHandler.do_GET):
(DefaultLaunchTimeHandler.do_POST):
(LaunchTimeBenchmark):
(LaunchTimeBenchmark._standard_deviation): Fixed divide by zero bug when '-n' is set to 1
(LaunchTimeBenchmark.open_tab): Added option to open a blank tab
(LaunchTimeBenchmark.run):
* LaunchTime/new_tab.py:
(NewTabBenchmark.initialize):
(NewTabBenchmark.run_iteration):
(NewTabBenchmark.will_parse_arguments):
(NewTabBenchmark.did_parse_arguments):
(NewTabBenchmark.ResponseHandler.Handler.get_test_page):
(NewTabBenchmark.ResponseHandler.Handler.on_receive_stop_time): Deleted.
(NewTabBenchmark.ResponseHandler.Handler.on_receive_stop_signal):
(NewTabBenchmark):
* LaunchTime/startup.py:
(StartupBenchmark.ResponseHandler.Handler.get_test_page):
(StartupBenchmark.ResponseHandler.Handler.on_receive_stop_time): Deleted.
(StartupBenchmark.ResponseHandler.Handler.on_receive_stop_signal):
(StartupBenchmark):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[webkitpy][Win] LayoutTests: test names should be Unix style, separated by slash...
Hironori.Fujii@sony.com [Fri, 10 Aug 2018 02:13:32 +0000 (02:13 +0000)]
[webkitpy][Win] LayoutTests: test names should be Unix style, separated by slash not backslash
https://bugs.webkit.org/show_bug.cgi?id=187973

Reviewed by Alex Christensen.

In LayoutTests, test names have been canonicalized in Unix style
since Bug 63597, for example 'fast/css/001.html'. But, Bug 179219,
Bug 179572, Bug 180660 and Bug 181814 have changed to use
os.path.seq instead of slash if Windows Python is used.

Revert parts of those changes. Change relative_test_filename to
return a slash sperated test name as well as chromium_win.py used
to do.

This change fixes all 41 test-webkitpy failures in WinCairo port.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._parse_line): Do not convert a test name by using normpath.
* Scripts/webkitpy/port/base.py:
(Port.normalize_test_name): Use TEST_PATH_SEPARATOR instead of os.path.sep.
(Port.relative_test_filename): Replace self.host.filesystem.sep with self.TEST_PATH_SEPARATOR.
(Port.abspath_for_test): Split test_name with TEST_PATH_SEPARATOR.
* Scripts/webkitpy/port/driver.py:
(Driver): Use '/' instead of os.sep.
* Scripts/webkitpy/port/win.py:
(WinCairoPort): Do not override TEST_PATH_SEPARATOR.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[WHLSL] Add individual test durations to output
commit-queue@webkit.org [Fri, 10 Aug 2018 01:18:06 +0000 (01:18 +0000)]
[WHLSL] Add individual test durations to output
https://bugs.webkit.org/show_bug.cgi?id=188448

Patch by Thomas Denney <tdenney@apple.com> on 2018-08-09
Reviewed by Myles C. Maxfield.

* WebGPUShadingLanguageRI/Test.js: Add timing output.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoWe should cache the compiled sandbox profile in a data vault
commit-queue@webkit.org [Fri, 10 Aug 2018 00:28:58 +0000 (00:28 +0000)]
We should cache the compiled sandbox profile in a data vault
https://bugs.webkit.org/show_bug.cgi?id=184991

Patch by Ben Richards <benton_richards@apple.com> on 2018-08-09
Reviewed by Ryosuke Niwa.

Source/WebCore:

Added functionality to FileHandle so that it can lock a file while open.
Added a function to FileSystem to delete non empty directories.

* platform/FileHandle.cpp:
(WebCore::FileHandle::FileHandle):
(WebCore::FileHandle::open):
(WebCore::FileHandle::close):
* platform/FileHandle.h:
* platform/FileSystem.h:
* platform/cocoa/FileSystemCocoa.mm:
(WebCore::FileSystem::deleteNonEmptyDirectory):

Source/WebKit:

This patch changes a few things (note: data vaults and sandbox entitlements are only used in internal builds):
(1) Instead of compiling a sandbox every time a process is launched, processes now look for a cached sandbox
    in a process specific data vault on macOS platforms. (ChildProcessMac.mm)
(2) If a valid cached sandbox is not found, a process will create the data vault (or ensure that it exists),
    compile a sandbox, and cache it.
(3) In order to create process specific data vaults, each process now has their own <process name>-OSX-sandbox.entitlements
    file which contains an entitlement with a process specific "storage class" which ensures that each process
    can only ever access its own data vault. (See the article on confluence "Data Vaults and Restricted Files" for more info)
(4) The sandbox entitlements file for the Network, WebContent and Plugin services are loaded dynamically
    through Scripts/<process name>-process-entitlements.sh which is triggered in a new build phase for each service.
    The Storage process sandbox entitlements are loaded directly in Configurations/StorageService.xcconfig.
    The reason that the sandbox entitlements are applied dynamically is so that these sandbox entitlements
    are only applied when WK_USE_RESTRICTED_ENTITLEMENTS is YES. This means that open source builds will still work.

* Configurations/Network-OSX-sandbox.entitlements: Added.
* Configurations/Storage-OSX-sandbox.entitlements: Added.
* Configurations/StorageService.xcconfig:
* Configurations/WebContent-OSX-sandbox.entitlements: Added.
* Configurations/WebKit.xcconfig:
* NetworkProcess/NetworkProcess.h:
* PluginProcess/PluginProcess.h:
* Scripts/process-network-sandbox-entitlements.sh: Added.
* Scripts/process-webcontent-sandbox-entitlements.sh: Added.
* Shared/ChildProcess.h:
* Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
* Shared/SandboxInitializationParameters.h:
(WebKit::SandboxInitializationParameters::setOverrideSandboxProfilePath):
(WebKit::SandboxInitializationParameters::overrideSandboxProfilePath const):
(WebKit::SandboxInitializationParameters::setSandboxProfile):
(WebKit::SandboxInitializationParameters::sandboxProfile const):
(): Deleted.
* Shared/mac/ChildProcessMac.mm:
(WebKit::SandboxProfileDeleter::operator()):
(WebKit::SandboxParametersDeleter::operator()):
(WebKit::SandboxInfo::SandboxInfo):
(WebKit::fileContents):
(WebKit::processStorageClass):
(WebKit::setAndSerializeSandboxParameters):
(WebKit::sandboxDataVaultParentDirectory):
(WebKit::sandboxDirectory):
(WebKit::sandboxFilePath):
(WebKit::ensureSandboxCacheDirectory):
(WebKit::writeSandboxDataToCacheFile):
(WebKit::compileAndCacheSandboxProfile):
(WebKit::tryApplyCachedSandbox):
(WebKit::webKit2Bundle):
(WebKit::sandboxProfilePath):
(WebKit::compileAndApplySandboxSlowCase):
(WebKit::applySandbox):
(WebKit::initializeSandboxParameters):
(WebKit::ChildProcess::initializeSandbox):
* Shared/mac/SandboxInitialiationParametersMac.mm:
(WebKit::SandboxInitializationParameters::SandboxInitializationParameters):
* StorageProcess/StorageProcess.h:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/WebProcess.h:

Source/WTF:

Added trace points for sandbox initialization and exposed functions needed for sandbox caching

* wtf/SystemTracing.h:
* wtf/spi/darwin/SandboxSPI.h:

Tools:

Added trace points for sandbox initialization

* Tracing/SystemTracePoints.plist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoRemove ElCapitan specific layout test expectations
commit-queue@webkit.org [Fri, 10 Aug 2018 00:20:39 +0000 (00:20 +0000)]
Remove ElCapitan specific layout test expectations
https://bugs.webkit.org/show_bug.cgi?id=188457

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2018-08-09
Reviewed by Alex Christensen.

* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[Curl] Test gardening
Basuke.Suzuki@sony.com [Fri, 10 Aug 2018 00:18:52 +0000 (00:18 +0000)]
[Curl] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=188456

Unreviewed test gardening.

Unskip http/xmlhttprequest.

* platform/wincairo/TestExpectations:
* platform/wincairo/http/tests/local/file-url-sent-as-referer-expected.png: Added.
* platform/wincairo/http/tests/multipart/invalid-image-data-expected.png: Added.
* platform/wincairo/http/tests/multipart/invalid-image-data-standalone-expected.png: Added.
* platform/wincairo/http/tests/uri/css-href-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoInputType should not interact with an HTMLInputElement is no longer associated with
cdumez@apple.com [Thu, 9 Aug 2018 23:56:42 +0000 (23:56 +0000)]
InputType should not interact with an HTMLInputElement is no longer associated with
https://bugs.webkit.org/show_bug.cgi?id=188410

Reviewed by Ryosuke Niwa.

Clear InputType::m_element when the InputType is no longer associated with the HTMLInputElement
because the element changed type. We were already dealing with the InputType no longer being
associated with an element because the element died by using a WeakPtr. However, it is conceptually
better (more correct) to also clear this pointer if the element is still alive but associated with
another InputType.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
* html/InputType.h:
(WebCore::InputType::detachFromElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoVideo playback is using more power
jer.noble@apple.com [Thu, 9 Aug 2018 23:49:11 +0000 (23:49 +0000)]
Video playback is using more power
https://bugs.webkit.org/show_bug.cgi?id=188452
Source/WebCore:

<rdar://problem/42298937>

Reviewed by Eric Carlson.

Test: TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm

When the meaning of PlatformMediaSession::Video changed to "video-only", we failed to update
MediaSessionManagerCocoa::updateSessionState() to use the new PlatformMediaSession::VideoAudio
enum, so Video-only sessions were getting the higher audio buffer size (where it's not needed)
and Video-and-Audio sessions were getting the default value.

To enable testing, add a preferredAudioBufferSize property to Internals. Also, the getter for
AudioSession::preferredBufferSize was using the wrong CoreAudio property address, and was
always returning 0.

* platform/audio/AudioSession.h:
* platform/audio/cocoa/MediaSessionManagerCocoa.cpp:
(MediaSessionManagerCocoa::updateSessionState):
* platform/audio/mac/AudioSessionMac.cpp:
(WebCore::AudioSession::preferredBufferSize const):
* testing/Internals.cpp:
(WebCore::Internals::preferredAudioBufferSize const):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit:

Reviewed by Eric Carlson.

* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setLowPowerVideoAudioBufferSizeEnabled:]):
(-[WKPreferences _lowPowerVideoAudioBufferSizeEnabled]):

Tools:

<rdar://problem/42298937>

Reviewed by Eric Carlson.

* TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
(PreferredAudioBufferSize::createView):
(PreferredAudioBufferSize::preferredAudioBufferSize const):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoREGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
tsavell@apple.com [Thu, 9 Aug 2018 23:30:39 +0000 (23:30 +0000)]
REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=188357

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoFix URLSchemeHandler.SyncXHR API test after r234735.
achristensen@apple.com [Thu, 9 Aug 2018 23:07:24 +0000 (23:07 +0000)]
Fix URLSchemeHandler.SyncXHR API test after r234735.
https://bugs.webkit.org/show_bug.cgi?id=188358

* UIProcess/WebURLSchemeTask.cpp:
(WebKit::WebURLSchemeTask::didReceiveData):
Return after appending data for synchronous loads.  We used to send unused messages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoREGRESSION(234640) Loading stalls in environments without SafariSafeBrowsing framework
achristensen@apple.com [Thu, 9 Aug 2018 22:37:52 +0000 (22:37 +0000)]
REGRESSION(234640) Loading stalls in environments without SafariSafeBrowsing framework
https://bugs.webkit.org/show_bug.cgi?id=188453
<rdar://problem/43102553>

Source/WebKit:

Reviewed by Chris Dumez.

* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::beginSafeBrowsingCheck):

Tools:

Reviewed by Chris Dumez

* TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(TEST):
(+[NullLookupContext sharedLookupContext]):
(TestWebKitAPI::TEST): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoWeb Inspector: Dark Mode: SourceCodeTextEditor error/warning text widget is too light
nvasilyev@apple.com [Thu, 9 Aug 2018 21:47:00 +0000 (21:47 +0000)]
Web Inspector: Dark Mode: SourceCodeTextEditor error/warning text widget is too light
https://bugs.webkit.org/show_bug.cgi?id=188126
<rdar://problem/42674963>

Reviewed by Matt Baker.

* UserInterface/Views/DarkMode.css:
(@media (prefers-dark-interface)):
(.source-code.text-editor > .CodeMirror .issue-widget.warning,): Added.
(.source-code.text-editor > .CodeMirror .issue-widget.error,): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoWKURLSchemeHandler crashes when sent errors with sync XHR
commit-queue@webkit.org [Thu, 9 Aug 2018 21:43:48 +0000 (21:43 +0000)]
WKURLSchemeHandler crashes when sent errors with sync XHR
https://bugs.webkit.org/show_bug.cgi?id=188358

Patch by Alex Christensen <achristensen@webkit.org> on 2018-08-09
Reviewed by Chris Dumez.

Source/WebKit:

* UIProcess/WebURLSchemeTask.cpp:
(WebKit::WebURLSchemeTask::didReceiveData):
(WebKit::WebURLSchemeTask::didComplete):
* UIProcess/WebURLSchemeTask.h:

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
(-[SyncErrorScheme webView:startURLSchemeTask:]):
(-[SyncErrorScheme webView:stopURLSchemeTask:]):
(-[SyncErrorScheme webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoREGRESSION(r234652): fast/scrolling/rtl-scrollbars-animation-property.html is failing
pvollan@apple.com [Thu, 9 Aug 2018 20:43:26 +0000 (20:43 +0000)]
REGRESSION(r234652): fast/scrolling/rtl-scrollbars-animation-property.html is failing
https://bugs.webkit.org/show_bug.cgi?id=188397

Reviewed by Tim Horton.

After r234652, [NSScroller preferredScrollerStyle] is called in the UI process, and we need to set the same
user defaults related to scrollbars in the UI process as we do in the WebProcess.

* WebKitTestRunner/mac/main.mm:
(setDefaultsToConsistentValuesForTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agomemoryFootprint should return size_t not optional<size_t>
sbarati@apple.com [Thu, 9 Aug 2018 20:13:27 +0000 (20:13 +0000)]
memoryFootprint should return size_t not optional<size_t>
https://bugs.webkit.org/show_bug.cgi?id=188444

Reviewed by Simon Fraser.

Source/WebCore:

* page/cocoa/ResourceUsageOverlayCocoa.mm:
(WebCore::ResourceUsageOverlay::platformDraw):

Source/WTF:

We're now going to return zero instead of returning nullopt on failure.
There was a lot of code dancing around memoryFootprint failing for no
good reason.

Users of this API were previously doing this on failure:
- Treating it as zero (this was the most common user).
- Crashing.
- Bailing out early and not changing our memory pressure state. This change
has the effect that instead of not changing our memory pressure state on
failure, we will go back to thinking we're not under memory pressure. Since
we relied on this API not failing to do anything useful (like kill the process
or release memory), this won't change our behavior here in a meaningful way.

* wtf/MemoryFootprint.h:
* wtf/MemoryPressureHandler.cpp:
(WTF::MemoryPressureHandler::currentMemoryUsagePolicy):
(WTF::MemoryPressureHandler::shrinkOrDie):
(WTF::MemoryPressureHandler::measurementTimerFired):
* wtf/cocoa/MemoryFootprintCocoa.cpp:
(WTF::memoryFootprint):
* wtf/linux/MemoryFootprintLinux.cpp:
(WTF::memoryFootprint):
* wtf/linux/MemoryPressureHandlerLinux.cpp:
(WTF::MemoryPressureHandler::ReliefLogger::platformMemoryUsage):
* wtf/win/MemoryFootprintWin.cpp:
(WTF::memoryFootprint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoUpdate IDL for IntersectionObserverEntry and IntersectionObserverEntryInit
ajuma@chromium.org [Thu, 9 Aug 2018 19:36:38 +0000 (19:36 +0000)]
Update IDL for IntersectionObserverEntry and IntersectionObserverEntryInit
https://bugs.webkit.org/show_bug.cgi?id=188445

Reviewed by Simon Fraser.

Source/WebCore:

Update IntersectionObserverEntry by making rootBounds nullable, and adding an
isIntersecting attribute. Make the same changes to IntersectionObserverEntryInit,
and also add an intersectionRatio attribute.

Tested by intersection-observer/intersection-observer-entry-interface.html

* page/IntersectionObserverEntry.cpp:
(WebCore::IntersectionObserverEntry::IntersectionObserverEntry):
* page/IntersectionObserverEntry.h:
(WebCore::IntersectionObserverEntry::isIntersecting const):
* page/IntersectionObserverEntry.idl:

LayoutTests:

* intersection-observer/intersection-observer-entry-interface-expected.txt:
* intersection-observer/intersection-observer-entry-interface.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[iOS WK2] Rename and refactor DataInteractionTests and DataInteractionSimulator
wenson_hsieh@apple.com [Thu, 9 Aug 2018 19:02:21 +0000 (19:02 +0000)]
[iOS WK2] Rename and refactor DataInteractionTests and DataInteractionSimulator
https://bugs.webkit.org/show_bug.cgi?id=188439

Reviewed by Andy Estes and Megan Gardner.

Refactor DataInteractionSimulator (currently used for drag and drop testing on iOS) so that it exists across
macOS and iOS, and rename it to DragAndDropSimulator. Additionally, rename DataInteractionTests to
DragAndDropTests.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm.
(testIconImage):
(testZIPArchive):
(-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
(-[TestWKWebView editorContainsImageElement]):
(-[TestWKWebView editorValue]):
(makeCGRectValue):
(checkCGRectIsEqualToCGRectWithLogging):
(checkSelectionRectsWithLogging):
(checkRichTextTypePrecedesPlainTextType):
(checkFirstTypeIsPresentAndSecondTypeIsMissing):
(checkTypeIdentifierIsRegisteredAtIndex):
(checkEstimatedSize):
(checkSuggestedNameAndEstimatedSize):
(checkStringArraysAreEqual):
(checkDragCaretRectIsContainedInRect):
(checkJSONWithLogging):
(testIconImageData):
(runTestWithTemporaryTextFile):
(runTestWithTemporaryFolder):
(TestWebKitAPI::TEST):
(TestWebKitAPI::setUpTestWebViewForDataTransferItems):
(TestWebKitAPI::testDragAndDropOntoTargetElements):
(TestWebKitAPI::testIconImageData):
* TestWebKitAPI/cocoa/DragAndDropSimulator.h: Renamed from Tools/TestWebKitAPI/ios/DataInteractionSimulator.h.
* TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm: Renamed from Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm.
(-[WKWebView dropInteractionDelegate]):
(-[WKWebView dragInteractionDelegate]):
(-[WKWebView dropInteraction]):
(-[WKWebView dragInteraction]):
(-[MockDragDropSession initWithItems:location:window:allowMove:]):
(-[MockDragDropSession allowsMoveOperation]):
(-[MockDragDropSession isRestrictedToDraggingApplication]):
(-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
(-[MockDragDropSession canLoadObjectsOfClass:]):
(-[MockDragDropSession canLoadObjectsOfClasses:]):
(-[MockDragDropSession items]):
(-[MockDragDropSession setItems:]):
(-[MockDragDropSession addItems:]):
(-[MockDragDropSession locationInView:]):
(-[MockDropSession initWithProviders:location:window:allowMove:]):
(-[MockDropSession isLocal]):
(-[MockDropSession progress]):
(-[MockDropSession setProgressIndicatorStyle:]):
(-[MockDropSession progressIndicatorStyle]):
(-[MockDropSession operationMask]):
(-[MockDropSession localDragSession]):
(-[MockDropSession hasItemsConformingToTypeIdentifier:]):
(-[MockDropSession canCreateItemsOfClass:]):
(-[MockDropSession loadObjectsOfClass:completion:]):
(-[MockDragSession initWithWindow:allowMove:]):
(-[MockDragSession localOperationMask]):
(-[MockDragSession externalOperationMask]):
(-[MockDragSession session]):
(-[MockDragSession localContext]):
(-[MockDragSession setLocalContext:]):
(dragAndDropEventNames):
(-[DragAndDropSimulatorApplication _cancelAllTouches]):
(-[DragAndDropSimulator initWithWebView:]):
(-[DragAndDropSimulator dealloc]):
(-[DragAndDropSimulator _resetSimulatedState]):
(-[DragAndDropSimulator observedEventNames]):
(-[DragAndDropSimulator simulateAllTouchesCanceled:]):
(-[DragAndDropSimulator runFrom:to:]):
(-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
(-[DragAndDropSimulator finalSelectionRects]):
(-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
(-[DragAndDropSimulator _enqueuePendingAdditionalItemRequestLocations]):
(-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
(-[DragAndDropSimulator _advanceProgress]):
(-[DragAndDropSimulator _currentLocation]):
(-[DragAndDropSimulator _scheduleAdvanceProgress]):
(-[DragAndDropSimulator sourceItemProviders]):
(-[DragAndDropSimulator externalItemProviders]):
(-[DragAndDropSimulator setExternalItemProviders:]):
(-[DragAndDropSimulator phase]):
(-[DragAndDropSimulator liftPreviews]):
(-[DragAndDropSimulator lastKnownDragCaretRect]):
(-[DragAndDropSimulator waitForInputSession]):
(-[DragAndDropSimulator insertedAttachments]):
(-[DragAndDropSimulator removedAttachments]):
(-[DragAndDropSimulator endDataTransfer]):
(-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
(-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
(-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
(-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
(-[DragAndDropSimulator _webView:willPerformDropWithSession:]):
(-[DragAndDropSimulator _webView:didInsertAttachment:]):
(-[DragAndDropSimulator _webView:didRemoveAttachment:]):
(-[DragAndDropSimulator _webView:focusShouldStartInputSession:]):
(-[DragAndDropSimulator _webView:didStartInputSession:]):
* TestWebKitAPI/ios/UIKitSPI.h:
* TestWebKitAPI/mac/DragAndDropSimulatorMac.mm: Added.
(-[DragAndDropSimulator initWithWebView:]):
(-[DragAndDropSimulator dealloc]):
(-[DragAndDropSimulator runFrom:to:]):
(-[DragAndDropSimulator insertedAttachments]):
(-[DragAndDropSimulator removedAttachments]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoREGRESSION (r232083): WKWebView loses first-party cookies on iOS
cdumez@apple.com [Thu, 9 Aug 2018 18:48:14 +0000 (18:48 +0000)]
REGRESSION (r232083): WKWebView loses first-party cookies on iOS
https://bugs.webkit.org/show_bug.cgi?id=188443
<rdar://problem/42991584>

Patch by Sihui Liu <sihui_liu@apple.com> on 2018-08-09
Reviewed by Chris Dumez.

Source/WebKit:

Revert the change to set sharedCookieStorage for iOS as it is breaking Kayak.

* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
* NetworkProcess/NetworkProcessCreationParameters.h:
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):

Tools:

Skip WebKit.WKHTTPCookieStoreWithoutProcessPool on iOS.

* TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoArray.prototype.sort should call @toLength instead of ">>> 0"
keith_miller@apple.com [Thu, 9 Aug 2018 18:02:05 +0000 (18:02 +0000)]
Array.prototype.sort should call @toLength instead of ">>> 0"
https://bugs.webkit.org/show_bug.cgi?id=188430

Reviewed by Saam Barati.

JSTests:

* test262/expectations.yaml:

Source/JavaScriptCore:

Also add a new function to $vm that will fetch a private
property. This can be useful for running builtin helper functions.

* builtins/ArrayPrototype.js:
(sort):
* tools/JSDollarVM.cpp:
(JSC::functionGetPrivateProperty):
(JSC::JSDollarVM::finishCreation):

LayoutTests:

Remove invalid conformance test expectations. Array.prototype.sort calls toLength, which
does not truncate integers.

* sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T1.html:
* sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T2.html:
* sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T3.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoUnreviewed follow-up fix for r234720.
ross.kirsling@sony.com [Thu, 9 Aug 2018 17:24:39 +0000 (17:24 +0000)]
Unreviewed follow-up fix for r234720.

* Scripts/webkitpy/bindings/main.py:
(BindingsTests.close_and_remove):
(BindingsTests.main):
Return to the original approach, since this seems to be the simplest cross-platform solution.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoDisplayRefreshMonitorMac should hold a weak pointer to WebPage.
pvollan@apple.com [Thu, 9 Aug 2018 15:49:13 +0000 (15:49 +0000)]
DisplayRefreshMonitorMac should hold a weak pointer to WebPage.
https://bugs.webkit.org/show_bug.cgi?id=186683

Reviewed by Brent Fulgham.

Instead of DisplayRefreshMonitorMac having a RefPtr to WebPage, it should have a weak pointer.
Having a RefPtr could in theory create reference cycles. This potential problem has not been
observed in practice, but it is safer to use a weak pointer.

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/DrawingAreaMac.cpp:
(WebKit::DisplayRefreshMonitorMac::DisplayRefreshMonitorMac):
(WebKit::DisplayRefreshMonitorMac::~DisplayRefreshMonitorMac):
(WebKit::DisplayRefreshMonitorMac::requestRefreshCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoUnreviewed GTK+ gardening after r234720.
magomez@igalia.com [Thu, 9 Aug 2018 14:01:51 +0000 (14:01 +0000)]
Unreviewed GTK+ gardening after r234720.

* platform/gtk/TestExpectations:
* platform/gtk/http/tests/inspector/network/xhr-response-body-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoImport WPTs for IntersectionObserver
ajuma@chromium.org [Thu, 9 Aug 2018 13:36:51 +0000 (13:36 +0000)]
Import WPTs for IntersectionObserver
https://bugs.webkit.org/show_bug.cgi?id=188416

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

* resources/import-expectations.json:
* web-platform-tests/intersection-observer/META.yml: Added.
* web-platform-tests/intersection-observer/bounding-box-expected.txt: Added.
* web-platform-tests/intersection-observer/bounding-box.html: Added.
* web-platform-tests/intersection-observer/client-rect-expected.txt: Added.
* web-platform-tests/intersection-observer/client-rect.html: Added.
* web-platform-tests/intersection-observer/containing-block-expected.txt: Added.
* web-platform-tests/intersection-observer/containing-block.html: Added.
* web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt: Added.
* web-platform-tests/intersection-observer/cross-origin-iframe.html: Added.
* web-platform-tests/intersection-observer/disconnect-expected.txt: Added.
* web-platform-tests/intersection-observer/disconnect.html: Added.
* web-platform-tests/intersection-observer/display-none-expected.txt: Added.
* web-platform-tests/intersection-observer/display-none.html: Added.
* web-platform-tests/intersection-observer/edge-inclusive-intersection-expected.txt: Added.
* web-platform-tests/intersection-observer/edge-inclusive-intersection.html: Added.
* web-platform-tests/intersection-observer/idlharness.window-expected.txt: Added.
* web-platform-tests/intersection-observer/idlharness.window.html: Added.
* web-platform-tests/intersection-observer/idlharness.window.js: Added.
(idl_array.self.observer.new.IntersectionObserver):
* web-platform-tests/intersection-observer/iframe-no-root-expected.txt: Added.
* web-platform-tests/intersection-observer/iframe-no-root.html: Added.
* web-platform-tests/intersection-observer/inline-client-rect-expected.txt: Added.
* web-platform-tests/intersection-observer/inline-client-rect.html: Added.
* web-platform-tests/intersection-observer/isIntersecting-change-events-expected.txt: Added.
* web-platform-tests/intersection-observer/isIntersecting-change-events.html: Added.
* web-platform-tests/intersection-observer/multiple-targets-expected.txt: Added.
* web-platform-tests/intersection-observer/multiple-targets.html: Added.
* web-platform-tests/intersection-observer/multiple-thresholds-expected.txt: Added.
* web-platform-tests/intersection-observer/multiple-thresholds.html: Added.
* web-platform-tests/intersection-observer/observer-attributes-expected.txt: Added.
* web-platform-tests/intersection-observer/observer-attributes.html: Added.
* web-platform-tests/intersection-observer/observer-exceptions-expected.txt: Added.
* web-platform-tests/intersection-observer/observer-exceptions.html: Added.
* web-platform-tests/intersection-observer/observer-in-iframe.html: Added.
* web-platform-tests/intersection-observer/observer-without-js-reference-expected.txt: Added.
* web-platform-tests/intersection-observer/observer-without-js-reference.html: Added.
* web-platform-tests/intersection-observer/remove-element-expected.txt: Added.
* web-platform-tests/intersection-observer/remove-element.html: Added.
* web-platform-tests/intersection-observer/resources/cross-origin-subframe.html: Added.
* web-platform-tests/intersection-observer/resources/iframe-no-root-subframe.html: Added.
* web-platform-tests/intersection-observer/resources/intersection-observer-test-utils.js: Added.
(waitForNotification):
(runTestCycle):
(contentBounds):
(borderBoxBounds):
(clientBounds):
(rectArea):
(checkRect):
(checkLastEntry):
(checkJsonEntry):
(checkJsonEntries):
* web-platform-tests/intersection-observer/resources/observer-in-iframe-subframe.html: Added.
* web-platform-tests/intersection-observer/resources/timestamp-subframe.html: Added.
* web-platform-tests/intersection-observer/resources/w3c-import.log: Added.
* web-platform-tests/intersection-observer/root-margin-expected.txt: Added.
* web-platform-tests/intersection-observer/root-margin.html: Added.
* web-platform-tests/intersection-observer/same-document-no-root-expected.txt: Added.
* web-platform-tests/intersection-observer/same-document-no-root.html: Added.
* web-platform-tests/intersection-observer/same-document-root-expected.txt: Added.
* web-platform-tests/intersection-observer/same-document-root.html: Added.
* web-platform-tests/intersection-observer/same-document-zero-size-target-expected.txt: Added.
* web-platform-tests/intersection-observer/same-document-zero-size-target.html: Added.
* web-platform-tests/intersection-observer/shadow-content-expected.txt: Added.
* web-platform-tests/intersection-observer/shadow-content.html: Added.
* web-platform-tests/intersection-observer/text-target-expected.txt: Added.
* web-platform-tests/intersection-observer/text-target.html: Added.
* web-platform-tests/intersection-observer/timestamp-expected.txt: Added.
* web-platform-tests/intersection-observer/timestamp.html: Added.
* web-platform-tests/intersection-observer/unclipped-root-expected.txt: Added.
* web-platform-tests/intersection-observer/unclipped-root.html: Added.
* web-platform-tests/intersection-observer/w3c-import.log: Added.
* web-platform-tests/intersection-observer/zero-area-element-hidden-expected.txt: Added.
* web-platform-tests/intersection-observer/zero-area-element-hidden.html: Added.
* web-platform-tests/intersection-observer/zero-area-element-visible-expected.txt: Added.
* web-platform-tests/intersection-observer/zero-area-element-visible.html: Added.

Source/WebKit:

Make IntersectionObserver an experimental feature, so that it is enabled in
WebKitTestRunner.

* Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

* WebView/WebPreferencesPrivate.h:

Tools:

Enable IntersectionObserver in DumpRenderTree.

* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
(setWebPreferencesForTestOptions):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoUnreviewed GTK+ and WPE gardening. Add a reftest failure expectation.
zandobersek@gmail.com [Thu, 9 Aug 2018 12:00:35 +0000 (12:00 +0000)]
Unreviewed GTK+ and WPE gardening. Add a reftest failure expectation.
Update a WPT EME test baseline for the WPE port.

* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.https-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoFix copyright headers on new ISO parsing class
cturner@igalia.com [Thu, 9 Aug 2018 11:50:49 +0000 (11:50 +0000)]
Fix copyright headers on new ISO parsing class
https://bugs.webkit.org/show_bug.cgi?id=188432

Unreviewed fix.

This was left off from a previous bug by mistake, retrospectively
adding the correct copyright headers.

No tests required.

* platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.cpp:
* platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agorun-bindings-tests is not Win32-compatible
ross.kirsling@sony.com [Thu, 9 Aug 2018 05:42:42 +0000 (05:42 +0000)]
run-bindings-tests is not Win32-compatible
https://bugs.webkit.org/show_bug.cgi?id=188424

Reviewed by Fujii Hironori.

Source/WebCore:

* bindings/scripts/preprocessor.pm:
(applyPreprocessor):
Ensure that we fall back to cl.exe if CC env var is not set on Windows.

Tools:

* Scripts/webkitpy/bindings/main.py:
(BindingsTests.main):
Stop leaking file descriptors.
(See https://www.logilab.org/blogentry/17873 for details, though the solution here is even simpler.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoYet more crashes in MobileSafari under -[WKFormInputSession setSuggestions:]
timothy_horton@apple.com [Thu, 9 Aug 2018 04:36:34 +0000 (04:36 +0000)]
Yet more crashes in MobileSafari under -[WKFormInputSession setSuggestions:]
https://bugs.webkit.org/show_bug.cgi?id=188427
<rdar://problem/43064672>

Reviewed by Wenson Hsieh.

Speculatively fix more crashes seen under setSuggestions.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKFormInputSession isValid]):
(-[WKFormInputSession setSuggestions:]):
(-[WKFormInputSession invalidate]):
Belt-and-suspenders fix: use WeakObjCPtr for WKFormInputSession's WKContentView reference.

(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
Invalidate the WKFormInputSession before replacing it; we theorize that
there is a path in which we get here without having previously called stopAssistingNode.
Most of the code is OK with this, but this leaves WKFormInputSession
with a raw reference to WKContentView which can later become stale.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoREGRESSION (r228260): Events handled by input method invoke default event handler
rniwa@webkit.org [Thu, 9 Aug 2018 04:32:39 +0000 (04:32 +0000)]
REGRESSION (r228260): Events handled by input method invoke default event handler
https://bugs.webkit.org/show_bug.cgi?id=188370

Reviewed by Wenson Hsieh.

Source/WebCore:

The bug was caused by the default event handler being invoked for the "virtual" keydown events
generated for input methods. Namely, when Japanese or Chinese input methods swallows TAB key,
WebKit should not invoke the default event handler and move the focus during input composition.

Fixed the bug by adding a new boolean on Event indicating whether the default event handler
should be invoked, and restoring the behavior prior to r228260 for these virtual keydown events.

Test: editing/input/press-tab-during-ime-composition.html

* dom/Event.h:
(WebCore::Event::isDefaultEventHandlerIgnored const): Added.
(WebCore::Event::setIsDefaultEventHandlerIgnored): Added.
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent): Don't invoke the default event handler if
isDefaultEventHandlerIgnored is set.
* page/EventHandler.cpp:
(WebCore::EventHandler::internalKeyEvent): Set isDefaultEventHandlerIgnored. This restores WebKit's
behavior prior to r228260.

LayoutTests:

Added a regression test. Due to the lack of adequate support of textInputController in WebKitTestRunner,
the test is only enabled in WebKit1. The WTR fix is tracked by https://webkit.org/b/188428.

* editing/input/press-tab-during-ime-composition-expected.txt: Added.
* editing/input/press-tab-during-ime-composition.html: Added.
* platform/ios/TestExpectations:
* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoPrevent collectScreenProperties from crashing Base System
commit-queue@webkit.org [Thu, 9 Aug 2018 03:53:18 +0000 (03:53 +0000)]
Prevent collectScreenProperties from crashing Base System
https://bugs.webkit.org/show_bug.cgi?id=188429
<rdar://problem/43075662>

Patch by Justin Fan <justin_fan@apple.com> on 2018-08-08
Reviewed by Simon Fraser.

Adding some error-checking and early returns to further prevent calling CGLDescribeRenderer with invalid parameters.

Existing WebGL tests should cover; no expected change in behavior. Crash happened primarily on Base System.

* platform/mac/PlatformScreenMac.mm:
(WebCore::gpuIDForDisplayMask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoArray.prototype.sort should throw TypeError if param is a not callable object
keith_miller@apple.com [Thu, 9 Aug 2018 03:13:20 +0000 (03:13 +0000)]
Array.prototype.sort should throw TypeError if param is a not callable object
https://bugs.webkit.org/show_bug.cgi?id=188382

Reviewed by Saam Barati.

JSTests:

* test262/expectations.yaml:

Source/JavaScriptCore:

Improve spec compatability by checking if the Array.prototype.sort comparator is a function
before doing anything else.

Also, refactor the various helper functions to use let instead of var.

* builtins/ArrayPrototype.js:
(sort.stringComparator):
(sort.compactSparse):
(sort.compactSlow):
(sort.compact):
(sort.merge):
(sort.mergeSort):
(sort.bucketSort):
(sort.comparatorSort):
(sort.stringSort):
(sort):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[Curl] Surface additional NetworkLoadMetrics
don.olmstead@sony.com [Thu, 9 Aug 2018 01:12:05 +0000 (01:12 +0000)]
[Curl] Surface additional NetworkLoadMetrics
https://bugs.webkit.org/show_bug.cgi?id=188391

Reviewed by Joseph Pecoraro.

Source/WebCore:

* platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::getNetworkLoadMetrics):

Source/WebKit:

* NetworkProcess/curl/NetworkDataTaskCurl.cpp:
(WebKit::NetworkDataTaskCurl::curlDidReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoFix possible null dereference in WebBackForwardList::restoreFromState
commit-queue@webkit.org [Wed, 8 Aug 2018 22:58:21 +0000 (22:58 +0000)]
Fix possible null dereference in WebBackForwardList::restoreFromState
https://bugs.webkit.org/show_bug.cgi?id=188418
<rdar://problem/42531726>

Patch by Alex Christensen <achristensen@webkit.org> on 2018-08-08
Reviewed by Chris Dumez.

Source/WebKit:

* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::restoreFromState):
Null-check m_page like we do everywhere else in this file because it can be set to null when closing the page.

Tools:

* TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoYarr JIT should include annotations with dumpDisassembly=true
msaboff@apple.com [Wed, 8 Aug 2018 22:42:30 +0000 (22:42 +0000)]
Yarr JIT should include annotations with dumpDisassembly=true
https://bugs.webkit.org/show_bug.cgi?id=188415

Reviewed by Yusuke Suzuki.

Created a YarrDisassembler class that handles annotations similar to the baseline JIT.
Given that the Yarr creates matching code bu going through the YarrPattern ops forward and
then the backtracking code through the YarrPattern ops in reverse order, the disassembler
needs to do the same think.

Restructured some of the logging code in YarrPattern to eliminate redundent code and factor
out simple methods for what was needed by the YarrDisassembler.

Here is abbreviated sample output after this change.

Generated JIT code for 8-bit regular expression /ab*c/:
    Code at [0x469561c03720, 0x469561c03840):
        0x469561c03720: push %rbp
        0x469561c03721: mov %rsp, %rbp
        ...
        0x469561c03762: sub $0x40, %rsp
     == Matching ==
   0:OpBodyAlternativeBegin minimum size 2
        0x469561c03766: add $0x2, %esi
        0x469561c03769: cmp %edx, %esi
        0x469561c0376b: ja 0x469561c037fa
   1:OpTerm TypePatternCharacter 'a'
        0x469561c03771: movzx -0x2(%rdi,%rsi), %eax
        0x469561c03776: cmp $0x61, %eax
        0x469561c03779: jnz 0x469561c037e9
   2:OpTerm TypePatternCharacter 'b' {0,...} greedy
        0x469561c0377f: xor %r9d, %r9d
        0x469561c03782: cmp %edx, %esi
        0x469561c03784: jz 0x469561c037a2
        ...
        0x469561c0379d: jmp 0x469561c03782
        0x469561c037a2: mov %r9, 0x8(%rsp)
   3:OpTerm TypePatternCharacter 'c'
        0x469561c037a7: movzx -0x1(%rdi,%rsi), %eax
        0x469561c037ac: cmp $0x63, %eax
        0x469561c037af: jnz 0x469561c037d1
   4:OpBodyAlternativeEnd
        0x469561c037b5: add $0x40, %rsp
        ...
        0x469561c037cf: pop %rbp
        0x469561c037d0: ret
     == Backtracking ==
   4:OpBodyAlternativeEnd
   3:OpTerm TypePatternCharacter 'c'
   2:OpTerm TypePatternCharacter 'b' {0,...} greedy
        0x469561c037d1: mov 0x8(%rsp), %r9
        ...
        0x469561c037e4: jmp 0x469561c037a2
   1:OpTerm TypePatternCharacter 'a'
   0:OpBodyAlternativeBegin minimum size 2
        0x469561c037e9: mov %rsi, %rax
        ...
        0x469561c0382f: pop %rbp
        0x469561c03830: ret

* JavaScriptCore.xcodeproj/project.pbxproj:
* Sources.txt:
* runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::compileMatchOnly):
* yarr/YarrDisassembler.cpp: Added.
(JSC::Yarr::YarrDisassembler::indentString):
(JSC::Yarr::YarrDisassembler::YarrDisassembler):
(JSC::Yarr::YarrDisassembler::~YarrDisassembler):
(JSC::Yarr::YarrDisassembler::dump):
(JSC::Yarr::YarrDisassembler::dumpHeader):
(JSC::Yarr::YarrDisassembler::dumpVectorForInstructions):
(JSC::Yarr::YarrDisassembler::dumpForInstructions):
(JSC::Yarr::YarrDisassembler::dumpDisassembly):
* yarr/YarrDisassembler.h: Added.
(JSC::Yarr::YarrJITInfo::~YarrJITInfo):
(JSC::Yarr::YarrDisassembler::setStartOfCode):
(JSC::Yarr::YarrDisassembler::setForGenerate):
(JSC::Yarr::YarrDisassembler::setForBacktrack):
(JSC::Yarr::YarrDisassembler::setEndOfGenerate):
(JSC::Yarr::YarrDisassembler::setEndOfBacktrack):
(JSC::Yarr::YarrDisassembler::setEndOfCode):
(JSC::Yarr::YarrDisassembler::indentString):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::compile):
(JSC::Yarr::jitCompile):
* yarr/YarrJIT.h:
* yarr/YarrPattern.cpp:
(JSC::Yarr::dumpCharacterClass):
(JSC::Yarr::PatternTerm::dump):
(JSC::Yarr::YarrPattern::dumpPatternString):
(JSC::Yarr::YarrPattern::dumpPattern):
* yarr/YarrPattern.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[Curl] Test gardening
Basuke.Suzuki@sony.com [Wed, 8 Aug 2018 22:18:28 +0000 (22:18 +0000)]
[Curl] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=188420

Unreviewed test gardening.

Fix test result after r234607 landed. Part 1 for http/tests

* platform/wincairo/TestExpectations:
* platform/wincairo/http/tests/local/file-url-sent-as-referer-expected.txt:
* platform/wincairo/http/tests/multipart/invalid-image-data-expected.txt:
* platform/wincairo/http/tests/multipart/invalid-image-data-standalone-expected.txt:
* platform/wincairo/http/tests/uri/css-href-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agorun-builtins-generator-tests does not correctly handle CRLFs from stderr
ross.kirsling@sony.com [Wed, 8 Aug 2018 21:54:50 +0000 (21:54 +0000)]
run-builtins-generator-tests does not correctly handle CRLFs from stderr
https://bugs.webkit.org/show_bug.cgi?id=188392

Reviewed by Fujii Hironori.

Background:
file.write converts LF to os.linesep, so if the input string contains CRLF, we end up writing CRCRLF to the file.

* Scripts/webkitpy/common/system/executive.py:
(Executive.run_command):
Normalize CRLF to LF in decoded stdout/stderr data, so that we don't return consumers a platform-specific string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[Nicosia] Add the Nicosia-specific PlatformLayer type alias
don.olmstead@sony.com [Wed, 8 Aug 2018 20:54:05 +0000 (20:54 +0000)]
[Nicosia] Add the Nicosia-specific PlatformLayer type alias
https://bugs.webkit.org/show_bug.cgi?id=188405
<rdar://problem/43039520>

Unreviewed build fix.

* platform/graphics/texmap/GraphicsContext3DTextureMapper.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoUnreviewed, add myself to committers list.
akeerthi@apple.com [Wed, 8 Aug 2018 20:34:20 +0000 (20:34 +0000)]
Unreviewed, add myself to committers list.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoUnreviewed, rolling out r234314, r234320, and r234321.
commit-queue@webkit.org [Wed, 8 Aug 2018 19:07:41 +0000 (19:07 +0000)]
Unreviewed, rolling out r234314, r234320, and r234321.
https://bugs.webkit.org/show_bug.cgi?id=188414

Caused email sign in issue (Requested by ryanhaddad on
#webkit).

Reverted changesets:

"Remove unused WKNavigationDelegatePrivate
decidePolicyForNavigationAction SPI"
https://bugs.webkit.org/show_bug.cgi?id=188077
https://trac.webkit.org/changeset/234314

"Fix API tests after r234314"
https://bugs.webkit.org/show_bug.cgi?id=188077
https://trac.webkit.org/changeset/234320

"Fix API tests after r234314"
https://bugs.webkit.org/show_bug.cgi?id=188077
https://trac.webkit.org/changeset/234321

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoAdd a WebKit2 logging channel for ActivityState
simon.fraser@apple.com [Wed, 8 Aug 2018 19:06:43 +0000 (19:06 +0000)]
Add a WebKit2 logging channel for ActivityState
https://bugs.webkit.org/show_bug.cgi?id=188411

Reviewed by Tim Horton.
Source/WebCore:

Add logging for ActivityState changes and the entrypoints that affect ActivityState.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* page/ActivityState.cpp: Added.
(WebCore::activityStateFlagsToString):
* page/ActivityState.h:

Source/WebKit:

Add logging for ActivityState changes and the entrypoints that affect ActivityState.

* Platform/Logging.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::windowDidOrderOffScreen):
(WebKit::WebViewImpl::windowDidOrderOnScreen):
(WebKit::WebViewImpl::windowDidChangeOcclusionState):
(WebKit::WebViewImpl::viewDidMoveToWindow):
(WebKit::WebViewImpl::viewDidHide):
(WebKit::WebViewImpl::viewDidUnhide):
(WebKit::WebViewImpl::activeSpaceDidChange):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::activityStateDidChange):
(WebKit::WebPageProxy::dispatchActivityStateChange):
* UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::isViewVisible):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setActivityState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoAdd LogArgument template for PlatformMediaSession::RemoteControlCommandType
eric.carlson@apple.com [Wed, 8 Aug 2018 18:10:59 +0000 (18:10 +0000)]
Add LogArgument template for PlatformMediaSession::RemoteControlCommandType
https://bugs.webkit.org/show_bug.cgi?id=188314

Reviewed by Alex Christensen.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::didReceiveRemoteControlCommand): Don't coerce to int for logging.

* platform/audio/PlatformMediaSession.cpp:
(WebCore::convertEnumerationToString): New.
(WebCore::PlatformMediaSession::didReceiveRemoteControlCommand): Log command.
* platform/audio/PlatformMediaSession.h:
(WTF::LogArgument<WebCore::PlatformMediaSession::RemoteControlCommandType>::toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoWeb Inspector: XHR content sometimes shows as error even though load succeeded
joepeck@webkit.org [Wed, 8 Aug 2018 17:59:56 +0000 (17:59 +0000)]
Web Inspector: XHR content sometimes shows as error even though load succeeded
https://bugs.webkit.org/show_bug.cgi?id=188385
<rdar://problem/42646160>

Source/WebCore:

Reviewed by Devin Rousso.

* inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::didReceiveData):
Avoid a double hash lookup in the common case.
Allow synchronous XHR to have text data appended in the normal case.
Allow synchronous XHR to set base64 encoded data right here for non-text data.

* inspector/NetworkResourcesData.h:
(WebCore::NetworkResourcesData::ResourceData::hasBufferedData const):
Getter to see if data is buffered or not for this resource.

* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::maybeAddResourceData):
Return the updated ResourceData to avoid clients having to do a lookup.

LayoutTests:

Reviewed by Devin Rousso.

* http/tests/inspector/network/xhr-response-body-expected.txt:
* http/tests/inspector/network/xhr-response-body.html:
Extend this test to include synchronous XHR for text and non-text resources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoVersioning.
kocsen_chung@apple.com [Wed, 8 Aug 2018 17:29:21 +0000 (17:29 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoAdjusting test expectations for imported/blink/fast/text/international-iteration...
tsavell@apple.com [Wed, 8 Aug 2018 16:43:09 +0000 (16:43 +0000)]
Adjusting test expectations for imported/blink/fast/text/international-iteration-simple-text.html
https://bugs.webkit.org/show_bug.cgi?id=179853

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:
* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[GTK] Unreviewed test gardening
Ms2ger@igalia.com [Wed, 8 Aug 2018 16:30:05 +0000 (16:30 +0000)]
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=188409

Unreviewed test gardening.

* platform/gtk/TestExpectations: Remove expectations for now-passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@234693 268f45cc-cd09-0410...
jbedard@apple.com [Wed, 8 Aug 2018 16:20:04 +0000 (16:20 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoAssertion failed in Webcore::Process::setIdentifier()
sihui_liu@apple.com [Wed, 8 Aug 2018 15:54:45 +0000 (15:54 +0000)]
Assertion failed in Webcore::Process::setIdentifier()
https://bugs.webkit.org/show_bug.cgi?id=188404
<rdar://problem/43029137>

Reviewed by Chris Dumez.

App using both WebKit1 and WebKit may crash in WebKit initialization.

* platform/Process.cpp:
(WebCore::Process::setIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky failure
wenson_hsieh@apple.com [Wed, 8 Aug 2018 15:06:38 +0000 (15:06 +0000)]
[iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=188401
<rdar://problem/32542300>

Reviewed by Ryosuke Niwa.

Tools:

When run individually, fast/events/ios/contenteditable-autocapitalize.html passes consistently; however, when
run right after another layout test that finishes while the keyboard is shown, this test sometimes fails. This
is because each of the three steps of this test ends when UIScriptController's `didHideKeyboardCallback` is
invoked, and if the keyboard only begins to dismiss after the previous test completes, we have a race. When the
keyboard finishes dismissing after the UI script is evaluated, it will trigger UI script completion early and
skip over one of the steps in the layout test, resulting in a text diff failure.

To fix this, add a mechanism in WebKitTestRunner to wait until the keyboard is dismissed (with a short timeout)
as a part of resetting test controller state, before moving on to the next layout test.

* WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView didStartFormControlInteraction]):
(-[TestRunnerWKWebView didEndFormControlInteraction]):

Use these hooks to keep track of whether the previous test is presenting any form input UI.

(-[TestRunnerWKWebView isInteractingWithFormControl]):
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::handleKeyboardWillHideNotification):
(WTR::handleKeyboardDidHideNotification):
(WTR::TestController::platformInitialize):
(WTR::TestController::platformDestroy):

Register during initialization (and unregister during teardown) for keyboard hiding notifications, to keep track
of when the keyboard dismissal animation ends.

(WTR::TestController::platformResetStateToConsistentValues):

Make a couple of tweaks here: (1) if form input UI is being shown, tell the web view to resign first responder,
which causes the field to lose focus. (2) If necessary, wait for the current keyboard dismissal animation to
finish. This includes any keyboard dismissal animations triggered as a result of step (1).

LayoutTests:

Minor tweaks to make this test a bit easier to follow. Use async-await for each step of the test, and pass in
the current autocapitalization type to `runTestWithAutocapitalizeType` rather than the next type. See Tools
ChangeLog for more details.

* fast/events/ios/contenteditable-autocapitalize.html:
* platform/ios/TestExpectations:

Remove the failing test expecation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[libwebrtc] SafeSetError() in peerconnection.cc contains use-after-move of webrtc...
ddkilzer@apple.com [Wed, 8 Aug 2018 12:07:33 +0000 (12:07 +0000)]
[libwebrtc] SafeSetError() in peerconnection.cc contains use-after-move of webrtc::RTCError variable
<https://webkit.org/b/188337>
<rdar://problem/42882908>

Reviewed by Eric Carlson.

* Source/webrtc/pc/peerconnection.cc:
(webrtc::SafeSetError): Make static since it's not used outside
this translation unit.
(webrtc::SafeSetError): Ditto.  Change first argument to
webrtc::RTCError&& to prevent unnecessary copying of std::move()
argument.  Fix bug by saving value of `error.ok()` before moving
to `*error_out`.
* WebKit/0013-Fix-SafeSetError-use-after-move.patch: Add patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoAdd CENC sanitization
cturner@igalia.com [Wed, 8 Aug 2018 10:45:13 +0000 (10:45 +0000)]
Add CENC sanitization
https://bugs.webkit.org/show_bug.cgi?id=188376

Reviewed by Xabier Rodriguez-Calvar.

LayoutTests/imported/w3c:

* web-platform-tests/encrypted-media/scripts/generate-request-disallowed-input.js:
(runTest): Fixed an incorrect test failure message, added more
invalid init data tests to check the new box parsing methods in
WebCore.

Source/WebCore:

This patch adds support for sanitizing the CENC initialization
data, to ensure there are no obviously bogus values in the
untrusted input from generateRequest, see
https://www.w3.org/TR/encrypted-media/#dom-mediakeysession-generaterequest
for more details on sanitization.

Tested by imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.https.html

* Modules/encryptedmedia/InitDataRegistry.cpp: The diff looks a
bit wonky because I had to reorder extractKeyIDsCenc to come
before sanitizeCenc.
(WebCore::extractKeyIDsCenc): Added implementation, a nullopt
return value here indicates the parsing found an error in the box
values.
(WebCore::sanitizeCenc): Added implementation, if the box can be
parsed, return a copy of the buffer as before, otherwise an error
value.
* Sources.txt: Add the new PSSH box type.
* platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.cpp:
Added, parsing methods come from ISO/IEC 23001-7-2016 Section
8.1.1.
(WebCore::ISOProtectionSystemSpecificHeaderBox::parse): Ditto.
* platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.h: Ditto.
(WebCore::ISOProtectionSystemSpecificHeaderBox::boxTypeName): Ditto.
(WebCore::ISOProtectionSystemSpecificHeaderBox::systemID const): Ditto.
(WebCore::ISOProtectionSystemSpecificHeaderBox::keyIDs const):
Ditto.
(WebCore::ISOProtectionSystemSpecificHeaderBox::data const): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[Nicosia] Add the Nicosia-specific PlatformLayer type alias
zandobersek@gmail.com [Wed, 8 Aug 2018 09:31:08 +0000 (09:31 +0000)]
[Nicosia] Add the Nicosia-specific PlatformLayer type alias
https://bugs.webkit.org/show_bug.cgi?id=188405

Reviewed by Carlos Garcia Campos.

Add a Nicosia-specific PlatformLayer type alias that points to the
Nicosia::PlatformLayer type. This is guarded by the USE(NICOSIA) macro,
which guards additional code in this patch but will be added to other
Nicosia-specific classes later.

To keep things buildable when USE(NICOSIA) is defined, additional
changes are made to classes that operate with platform layers.
Cairo-specific ImageBuffer implementation and the related
ImageBufferData class are modified to work with a Nicosia::ContentLayer
object. This object is using the TextureMapper-specific Impl class which
internally keeps a TextureMapperPlatformLayerProxy object. This way
we can reuse existing code that also works with an object of this type,
only difference is where the proxy object is kept. Main difference is in
the ImageBuffer::platformLayer() method, where pointer to the
Nicosia::ContentLayer object is returned when USE(NICOSIA) is enabled.

Similar approach is taked for the MediaPlayerPrivateGStreamerBase class.
When USE(NICOSIA) is enabled, a Nicosia::ContentLayer object is
constructed, and with the TextureMapper-specific Impl we again operate
on the TextureMapperPlatformLayerProxy object like before, so all of
the proxy-specific code is bundled into helper lambdas that operate on
the given proxy object. In the platformLayer() method, we again return
pointer to the Nicosia::ContentLayer object when USE(NICOSIA) is on.

For the GraphicsContext3D integration, we have to provide a separate
class that replicates most of the functionality currently present in the
TextureMapperGC3DPlatformLayer class. Main difference is that in the new
Nicosia::GC3DLayer class, a Nicosia::ContentLayer object is spawned with
the TextureMapper-specific Impl. The proxy object held by that Impl is
then again used to push new buffers into the rendering pipeline. As
before, pointer to the Nicosia::ContentLayer is returned in the
GraphicsContext3D::platformLayer() object.

Integration of the GraphicsContext3D class into Nicosia layering needs
further work in the future. Target should be providing a class that is
not specific to the TextureMapper layer. Additionally, when USE(NICOSIA)
is enabled, we remove the TextureMapperGC3DPlatformLayer class from
compilation since it depends on a PlatformLayer type alias to the
TextureMapperPlatformLayerProxyProvider class.

This patch also doesn't address the abundance of macros that this code
now uses. While USE(NICOSIA) is introduced, we have to work around
four additional macros in this code: USE(TEXTURE_MAPPER),
USE(TEXTURE_MAPPER_GL), USE(COORDINATED_GRAPHICS) and
USE(COORDINATED_GRAPHICS_THREADED). In a lot of places these are used
interchangeably, but they should be merged and simplified in use. I hope
to approach this once the USE(NICOSIA) functionality lands and is turned
on for ports that currently build with USE(COORDINATED_GRAPHICS).

* platform/TextureMapper.cmake:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/PlatformLayer.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBufferData::~ImageBufferData):
(WebCore::ImageBufferData::swapBuffersIfNeeded):
(WebCore::ImageBuffer::platformLayer const):
* platform/graphics/cairo/ImageBufferDataCairo.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::platformLayer const):
(WebCore::MediaPlayerPrivateGStreamerBase::swapBuffersIfNeeded):
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::flushCurrentBuffer):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
* platform/graphics/nicosia/texmap/NicosiaGC3DLayer.cpp: Added.
(Nicosia::GC3DLayer::GC3DLayer):
(Nicosia::GC3DLayer::~GC3DLayer):
(Nicosia::GC3DLayer::makeContextCurrent):
(Nicosia::GC3DLayer::platformContext):
(Nicosia::GC3DLayer::swapBuffersIfNeeded):
* platform/graphics/nicosia/texmap/NicosiaGC3DLayer.h: Added.
(Nicosia::GC3DLayer::contentLayer const):
* platform/graphics/texmap/GraphicsContext3DTextureMapper.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer const):
* platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp:
* platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h:
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setContentsToPlatformLayer):
(WebCore::CoordinatedGraphicsLayer::syncPlatformLayer):
(WebCore::CoordinatedGraphicsLayer::updatePlatformLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[css-grid] Update behavior of percentage row tracks and gutters
rego@igalia.com [Wed, 8 Aug 2018 09:14:35 +0000 (09:14 +0000)]
[css-grid] Update behavior of percentage row tracks and gutters
https://bugs.webkit.org/show_bug.cgi?id=188403

Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

Import tests from WPT related to this issue.

* web-platform-tests/css/css-grid/alignment/grid-content-alignment-second-pass-001-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-content-alignment-second-pass-001.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-content-alignment-second-pass-002-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-content-alignment-second-pass-002.html: Added.
* web-platform-tests/css/css-grid/alignment/w3c-import.log:
* web-platform-tests/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-001-expected.txt: Added.
* web-platform-tests/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-001.html: Added.
* web-platform-tests/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002-expected.txt: Added.
* web-platform-tests/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002.html: Added.
* web-platform-tests/css/css-grid/grid-definition/w3c-import.log:
* web-platform-tests/css/css-grid/grid-layout-properties.html: Update test to reflect the new behavior.

Source/WebCore:

The CSSWG decided to change how percentage row tracks and gutters
in a grid container with indefinite height are resolved.

The CSSWG issues are:
- https://github.com/w3c/csswg-drafts/issues/1921
- https://github.com/w3c/csswg-drafts/issues/509

So far they were resolved as "auto", like it happens with
percentage heights in regular blocks. But now they're going to behave
similar to what happens in the columns axis, they would be ignored
to compute the intrinsic height.
This causes that we need to repeat the track sizing algorithm
when we have a grid container with indefinite height
that has some percentage rows using the intrinsic height
calculated on the first pass. Then the percentages will be resolved
against the intrinsic height.

Tests: imported/w3c/web-platform-tests/css/css-grid/alignment/grid-content-alignment-second-pass-001.html
       imported/w3c/web-platform-tests/css/css-grid/alignment/grid-content-alignment-second-pass-002.html
       imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-001.html
       imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002.html

* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::gridTrackSize const):
(WebCore::GridTrackSizingAlgorithm::initializeTrackSizes):
(WebCore::GridTrackSizingAlgorithm::setup):
(WebCore::GridTrackSizingAlgorithm::reset):
* rendering/GridTrackSizingAlgorithm.h:
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::availableSpaceForGutters const):
(WebCore::RenderGrid::repeatTracksSizingIfNeeded):
(WebCore::RenderGrid::layoutBlock):

LayoutTests:

Update tests as needed according to the new behavior.

* TestExpectations: Two grid gutters tests from WPT css-align suite are passing now.
* fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
* fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
* fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
* fast/css-grid-layout/grid-columns-rows-get-set.html:
* fast/css-grid-layout/grid-gutters-as-percentage-expected.txt:
* fast/css-grid-layout/grid-gutters-as-percentage.html:
* fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows-expected.txt:
* fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html:
* fast/css-grid-layout/named-grid-line-get-set-expected.txt:
* fast/css-grid-layout/named-grid-line-get-set.html:
* fast/css-grid-layout/nested-grid-expected.html:
* fast/css-grid-layout/percent-track-breadths-regarding-container-size.html:
* fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
* fast/css-grid-layout/resources/grid-columns-rows-get-set.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoResourceUsageOverlay should use physical footprint for its "Footprint" label
sbarati@apple.com [Wed, 8 Aug 2018 04:41:29 +0000 (04:41 +0000)]
ResourceUsageOverlay should use physical footprint for its "Footprint" label
https://bugs.webkit.org/show_bug.cgi?id=188395

Reviewed by Simon Fraser.

Let's use physical footprint on Cocoa for the number we say is "footprint".
Before, we were just using the number of dirty pages multiplies by
page size. This number was an upper bound on footprint since it
doesn't take into account compressed memory.

* page/cocoa/ResourceUsageOverlayCocoa.mm:
(WebCore::ResourceUsageOverlay::platformDraw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months ago[Cocoa] More tweaks and refactoring to prepare for ARC
darin@apple.com [Wed, 8 Aug 2018 02:39:12 +0000 (02:39 +0000)]
[Cocoa] More tweaks and refactoring to prepare for ARC
https://bugs.webkit.org/show_bug.cgi?id=188245

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

* API/JSValue.mm: Use __unsafe_unretained.
(JSContainerConvertor::convert): Use auto for compatibility with the above.
* API/JSWrapperMap.mm:
(allocateConstructorForCustomClass): Use CFTypeRef instead of Protocol *.
(-[JSWrapperMap initWithGlobalContextRef:]): Use __unsafe_unretained.

* heap/Heap.cpp: Updated include for rename: FoundationSPI.h -> objcSPI.h.

Source/WebCore:

* bridge/objc/objc_instance.mm: Updated include for rename: FoundationSPI.h -> objcSPI.h.
* platform/ios/wak/WebCoreThread.mm: Ditto.

Source/WebKit:

* Platform/cocoa/WKCrashReporter.mm:
(WebKit::setCrashLogMessage): Refactor into a separate function for clarity.
(WebKit::setCrashReportApplicationSpecificInformation): Use a bridging cast.

* Shared/mac/PasteboardTypes.mm:
(WebKit::PasteboardTypes::forEditing): Use a bridging cast.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::convertToNPNNString): Added. Uses CFStringRef rather than NSString so we can
manually manage the autoreleasing.
(WebKit::initializeKeyboardEvent): Use convertToNPNNString.
(WebKit::NetscapePlugin::sendComplexTextInput): Ditto.

* WebProcess/Plugins/PDF/PDFPlugin.mm: Use __unsafe_unretained explicitly
for a parent pointer. We could consider moving to __weak after switching to ARC.

Source/WebKitLegacy/mac:

* Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.

* Carbon/CarbonWindowFrame.m:
(-[CarbonWindowFrame dealloc]): Deleted. It was empty.

* DOM/DOM.mm:
(-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
(-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
garbage collection so this method isn't useful.

* DOM/DOMXPath.mm:
(-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
Objective-C garbage collection so this method isn't useful.

* History/WebHistory.mm:
(-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.

* Misc/WebElementDictionary.mm:
(addLookupKey): Use a bridging cast.
(cacheValueForKey): Ditto.
(-[WebElementDictionary _fillCache]): Ditto.
(-[WebElementDictionary objectForKey:]): Ditto.

* Misc/WebKitNSStringExtras.mm:
(-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
(-[NSString _web_widthWithFont:]): Ditto.
(-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.

* Misc/WebLocalizableStrings.mm:
(WebLocalizedString): Use a bridging cast.

* Misc/WebNSDataExtras.mm:
(-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
and use CFBridgingRelease instead of calling autorelease directly.
(-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
of a mix of CFString and NSString. Also simplified logic a bit, and cut down
on the amount of explicit release and autorelease.

* Misc/WebNSDictionaryExtras.h: Deleted unused methods.
* Misc/WebNSDictionaryExtras.m:
(-[NSDictionary _webkit_intForKey:]): Deleted.
(-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
(-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
(-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
(-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
(-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
(-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.

* Misc/WebStringTruncator.mm:
(fontFromNSFont): Use a bridging cast.

* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
(WebKit::NetscapePluginInstanceProxy::status): Ditto.
(WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
(WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
* Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::getPropertyNames): Ditto.
* Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
* Plugins/WebNetscapePluginEventHandlerCocoa.mm:
(WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
* Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage _initWithPath:]): Ditto.

* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
(-[WebNetscapePluginView status:]): Use a bridging cast.
(-[WebNetscapePluginView popUpContextMenu:]): Ditto.

* Plugins/WebPluginController.mm:
(-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.

* Plugins/WebPluginDatabase.mm:
(checkCandidate): Use explicit __strong for out argument types.

* Plugins/npapi.mm:
(pluginViewForInstance): Use a bridging cast.

* Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
explicit NSNumber and NSDictionary calls.

* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.

* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::handleKeyboardEvent): Added a missing typecast.
(WebEditorClient::handleInputMethodKeydown): Ditto.

* WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.

* WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
as a struct rather than an Objective-C class, since that's how it's defined.

* WebInspector/WebNodeHighlighter.mm: Added missing includes.

* WebView/WebFullScreenController.mm:
(-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
Ditto.
(-[WebHTMLView pasteboard:provideDataForType:]): Ditto.

* WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
go down to the document and then back to the frame.
(-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
(-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
(-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.

* WebView/WebJSPDFDoc.mm:
(jsPDFDocInitialize): Removed some unneeded type casting.
(jsPDFDocFinalize): Ditto.
(jsPDFDocPrint): Use a bridging cast.

* WebView/WebPDFView.mm:
(_applicationInfoForMIMEType): Use bridging casts.

* WebView/WebPreferences.mm:
(-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
instead of methods from WebNSDictionaryExtras.
(-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
(-[WebPreferences _setFloatValue:forKey:]): Ditto.
(-[WebPreferences _setBoolValue:forKey:]): Ditto.
(-[WebPreferences _setLongLongValue:forKey:]): Ditto.
(-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.

* WebView/WebView.mm:
(-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
(-[WebView _addToAllWebViewsSet]): Ditto.
(+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
(-[WebView _windowVisibilityChanged:]): Moved this into the internal category
so it can be called from WebViewData methods.

* WebView/WebViewData.mm: Added an import so we can call an internal WebView
method, _windowVisibilityChanged:.

* WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
called from WebViewData methods.

Source/WTF:

* WTF.xcodeproj/project.pbxproj: Updated for rename: FoundationSPI.h -> objcSPI.h.

* wtf/BlockPtr.h: Added missing include of "StdLibExtras.h".
Also re-sorted includes.

* wtf/HashFunctions.h: Add function for "__unsafe_unretained id".
* wtf/HashTraits.h: Add traits for "__unsafe_unretained id".

* wtf/PlatformMac.cmake: Updated for rename: FoundationSPI.h -> objcSPI.h.

* wtf/WeakObjCPtr.h: Use mutable instead of const_cast, and write a version
that uses __weak explicitly under ARC. Also moved function declarations from
here to objcSPI.h.

* wtf/cocoa/AutodrainedPool.cpp: Updated include for rename: FoundationSPI.h -> objcSPI.h.

* wtf/spi/cocoa/objcSPI.h: Renamed from FoundationSPI.h and added the
additional functions used by WeakObjCPtr.h. Also changed to both include the
internal header and the function definitions when compiling with
USE(APPLE_INTERNAL_SDK), helping us check that function definitions match.

Tools:

* DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Use const void* for a
CFTypeRef instead of void*.

* DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
(createCoreAnimationLayer): Use CFBridgingRetain.

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging casts.
(AccessibilityUIElement::textMarkerRangeForElement): Ditto.
(AccessibilityUIElement::selectedTextMarkerRange): Ditto.
(AccessibilityUIElement::textMarkerRangeLength): Ditto.
(AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Ditto.
(AccessibilityUIElement::indexForTextMarker): Ditto.
(AccessibilityUIElement::textMarkerForIndex): Ditto.
(AccessibilityUIElement::isTextMarkerValid): Ditto.
(AccessibilityUIElement::previousTextMarker): Ditto.
(AccessibilityUIElement::nextTextMarker): Ditto.
(AccessibilityUIElement::stringForTextMarkerRange): Ditto.
(createJSStringRef): Ditto.
(AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
(AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
(AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
(AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
(AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
(AccessibilityUIElement::endTextMarkerForBounds): Ditto.
(AccessibilityUIElement::startTextMarkerForBounds): Ditto.
(AccessibilityUIElement::textMarkerForPoint): Ditto.
(AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
(AccessibilityUIElement::startTextMarker): Ditto.
(AccessibilityUIElement::endTextMarker): Ditto.
(AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
(AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
(AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
(AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
(AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
(AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
(AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
(AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
(AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
(AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
(AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues): Use bridging cast.
(dumpFramesAsText): Ditto.
(dumpBackForwardListForAllWindows): Use a modern for loop instead of
CFArray functions to iterate the array.
(dump): Use bridging cast.
(runTest): Ditto.

* DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
(+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
(toUTI): Return a RetainPtr<CFStringRef>.
(-[LocalPasteboard types]): Use the above and bridging casts.
(-[LocalPasteboard availableTypeFromArray:]): Ditto.
(-[LocalPasteboard setData:forType:]): Ditto.
(-[LocalPasteboard dataForType:]): Ditto.
(-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
instead of CFPropertyList.
(-[LocalPasteboard setString:forType:]): Use NSString method instead of
CFStringCreateExternalRepresentation.

* DumpRenderTree/mac/MockGeolocationProvider.h: Put CFTypeRef in a HashSet
instead of an Objective-C object pointer type.
* DumpRenderTree/mac/MockGeolocationProvider.mm:
(-[MockGeolocationProvider registerWebView:]): Update for above.
(-[MockGeolocationProvider unregisterWebView:]): Ditto.
(-[MockGeolocationProvider timerFired]): Ditto.

* DumpRenderTree/mac/MockWebNotificationProvider.h: Use CFTypeRef in
HashMap and HashSet instead of an Objective-C object pointer type.
* DumpRenderTree/mac/MockWebNotificationProvider.mm:
(-[MockWebNotificationProvider registerWebView:]): Update for above.
(-[MockWebNotificationProvider unregisterWebView:]): Ditto.
(-[MockWebNotificationProvider showNotification:fromWebView:]): Ditto.
(-[MockWebNotificationProvider cancelNotification:]): Ditto.
(-[MockWebNotificationProvider simulateWebNotificationClick:]): Ditto.

* DumpRenderTree/mac/ObjCPlugin.m:
(-[JSObjC retainObject:]): Use CFRetain instead of -[NSObject retain].

* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::addDisallowedURL): Use bridging cast.
(TestRunner::applicationCacheDiskUsageForOrigin): Ditto.
(TestRunner::clearApplicationCacheForOrigin): Ditto.
(originsArrayToJS): Ditto.
(TestRunner::copyDecodedHostName): Ditto.
(TestRunner::copyEncodedHostName): Ditto.
(TestRunner::queueLoad): Ditto.
(TestRunner::setDomainRelaxationForbiddenForURLScheme): Ditto.
(TestRunner::setMockGeolocationPositionUnavailableError): Ditto.
(TestRunner::setUserStyleSheetLocation): Ditto.
(TestRunner::setValueForUser): Ditto.
(TestRunner::overridePreference): Ditto.
(TestRunner::execCommand): Ditto.
(TestRunner::findString): Ditto.
(TestRunner::isCommandEnabled): Ditto.
(TestRunner::addOriginAccessWhitelistEntry): Ditto.
(TestRunner::removeOriginAccessWhitelistEntry): Ditto.
(TestRunner::addUserScript): Ditto.
(TestRunner::addUserStyleSheet): Ditto.
(TestRunner::evaluateInWebInspector): Ditto.
(TestRunner::evaluateScriptInIsolatedWorld): Ditto.
(TestRunner::authenticateSession): Ditto.
(TestRunner::grantWebNotificationPermission): Ditto.
(TestRunner::denyWebNotificationPermission): Ditto.
* TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
(-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Ditto.

* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging cast.
(WTR::AccessibilityUIElement::textMarkerRangeForElement): Ditto.
(WTR::AccessibilityUIElement::previousTextMarker): Ditto.
(WTR::AccessibilityUIElement::nextTextMarker): Ditto.
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
(WTR::AccessibilityUIElement::selectedTextMarkerRange): Ditto.
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
(WTR::AccessibilityUIElement::endTextMarkerForBounds): Ditto.
(WTR::AccessibilityUIElement::startTextMarkerForBounds): Ditto.
(WTR::AccessibilityUIElement::textMarkerForPoint): Ditto.
(WTR::AccessibilityUIElement::textMarkerForIndex): Ditto.
(WTR::AccessibilityUIElement::startTextMarker): Ditto.
(WTR::AccessibilityUIElement::endTextMarker): Ditto.
(WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
(WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
(WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
(WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
(WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
(WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
(WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
(WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
(WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
(WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.

* WebKitTestRunner/PlatformMac.cmake: Added WebKitTestRunnerWindow.h and .mm files.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Ditto.

* WebKitTestRunner/mac/EventSenderProxy.mm: Add include of WebKitTestRunnerWindow.h
so we can use the type and know it inherits from NSWindow.

* WebKitTestRunner/mac/PlatformWebViewMac.mm: Add include of WebKitTestRunnerWindow.h
so we can use the type and know it inherits from NSWindow. Moved WebKitTestRunnerWindow
class into a separate file.
(WTR::PlatformWebView::keyWindow): Call +[WebKitTestRunnerWindow _WTR_keyWindow]
instead of have a second copy of the implementation.

* WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Add include of WebKitTestRunnerWindow.h
so we can use the type and know it inherits from NSWindow. Also removed "using namespace".
(+[WebKitTestRunnerEvent mouseLocation]): Updated for above.

* WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
(+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
(-[LocalPasteboard availableTypeFromArray:]): Use modern for loop.
(-[LocalPasteboard setData:forType:]): Reordered method to be a tiny bit more efficient.
(-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
instead of CFPropertyList.
(-[LocalPasteboard setString:forType:]): Use NSString method instead of
CFStringCreateExternalRepresentation.

* WebKitTestRunner/mac/WebKitTestRunnerWindow.h: Moved declaration of
WebKitTestRunnerWindow here so it can be included by files that need to know
what the type is and that it inherits from NSWindow.

* WebKitTestRunner/mac/WebKitTestRunnerWindow.mm: Added. Moved implementation here.
(+[WebKitTestRunnerWindow _WTR_keyWindow]): Use modern for loop instead of the old,
messier implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agonavigator.sendBeacon does not work in pagehide callbacks
cdumez@apple.com [Wed, 8 Aug 2018 01:41:45 +0000 (01:41 +0000)]
navigator.sendBeacon does not work in pagehide callbacks
https://bugs.webkit.org/show_bug.cgi?id=188329

Reviewed by Alex Christensen.

Source/WebCore:

Add support for sending beacons from pagehide event handlers. We normally do not allow loads because we're
about to enter PageCache. However, in case of Beacon, this is fine since it uses PingLoad and does not
WebCore to do the load.

Test: http/wpt/beacon/sendBeacon-in-pagehide.html

* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- Allow Beacon loads to go through even if the document's pageCacheState is AboutToEnterPageCache (i.e.
we're firing the 'pagehide' event)
- Allow Becon loads to go though even if the FrameLoader's state is provisional (i.e. a load is pending)

LayoutTests:

Add layout test coverage.

* http/wpt/beacon/sendBeacon-in-pagehide-expected.txt: Added.
* http/wpt/beacon/sendBeacon-in-pagehide.html: Added.
* http/wpt/beacon/support/sendBeacon-onpagehide-window.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoAllow href attribute without xlink on SVG elements
commit-queue@webkit.org [Wed, 8 Aug 2018 00:55:51 +0000 (00:55 +0000)]
Allow href attribute without xlink on SVG elements
https://bugs.webkit.org/show_bug.cgi?id=153854

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-08-07
Reviewed by Dean Jackson.

Source/WebCore:

SVG 2 has moved the href attribute from xlink namespace to svg namespace.
Instead of using xlink:href, svg:href should be used or simply use href
if the svg namespace is defined.

See https://www.w3.org/TR/SVG2/linking.html#XLinkRefAttrs.

For backward compatibility, xlink:href will be treated as an alias to href
till it is acceptable to completely remove the support for the deprecated
xlink:href.

Tests: svg/custom/href-svg-namespace-animate.svg
       svg/custom/href-svg-namespace-dynamic.svg
       svg/custom/href-svg-namespace-elements.html
       svg/custom/href-svg-namespace-expected.svg
       svg/custom/href-svg-namespace-static.svg

* dom/Element.cpp:
(WebCore::Element::absoluteLinkURL const):
* dom/Element.h:
(WebCore::Element::getAttribute const): This new template function with
template pack parameter QualifiedNames is added to return the first none
empty attribute value given a set of attributes' names. This should be
useful for deprecated attributes. When we decide to remove the support
for the deprecated attribute, all we need is to remove it as a parameter
to getAttribute(). In this case, the none template function will be called.
* dom/VisitedLinkState.cpp:
(WebCore::linkAttribute):
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterScriptToken):
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::isURLAttribute const):
* svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::hasValidGlyphElements const):
* svg/SVGCursorElement.cpp:
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::rebuildElements):
(WebCore::SVGDocumentExtensions::rebuildAllElementReferencesForTarget):
* svg/SVGElement.cpp:
(WebCore::SVGElement::animatableAttributeForName):
* svg/SVGFEImageElement.cpp:
* svg/SVGFilterElement.cpp:
* svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::srcValue const):
(WebCore::SVGFontFaceUriElement::parseAttribute):
(WebCore::SVGFontFaceUriElement::loadFont):
* svg/SVGForeignObjectElement.cpp:
* svg/SVGGlyphRefElement.cpp:
(WebCore::SVGGlyphRefElement::hasValidGlyphElement const):
* svg/SVGGradientElement.cpp:
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::imageSourceURL const):
* svg/SVGMPathElement.cpp:
* svg/SVGPatternElement.cpp:
* svg/SVGScriptElement.h:
* svg/SVGTRefElement.cpp:
* svg/SVGTextPathElement.cpp:
* svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::registerAttributes):
(WebCore::SVGURIReference::parseAttribute):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::expandUseElementsInShadowTree const):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::isSupportedAttribute):
(WebCore::SVGSMILElement::svgAttributeChanged):
* svg/svgattrs.in:

LayoutTests:

* fast/selectors/any-link-basics-2-expected.txt:
* fast/selectors/any-link-basics-2.html:
Re-baseline this test because it was assuming the bare href should not
work for the SVG <a> element.
* svg/custom/href-svg-namespace-animate-expected.svg: Added.
* svg/custom/href-svg-namespace-animate.svg: Added.
* svg/custom/href-svg-namespace-dynamic-expected.svg: Added.
* svg/custom/href-svg-namespace-dynamic.svg: Added.
* svg/custom/href-svg-namespace-elements-expected.txt: Added.
* svg/custom/href-svg-namespace-elements.html: Added.
* svg/custom/href-svg-namespace-static-expected.svg: Added.
* svg/custom/href-svg-namespace.static-svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agodocument.open and document.write must throw while the HTML parser is synchronously...
rniwa@webkit.org [Tue, 7 Aug 2018 23:54:25 +0000 (23:54 +0000)]
document.open and document.write must throw while the HTML parser is synchronously constructing a custom element
https://bugs.webkit.org/show_bug.cgi?id=187319
<rdar://problem/42843012>

Reviewed by Frédéric Wang.

Source/WebCore:

Make document.open, document.write, document.writeln, and document.close throw InvalidStateError during
a synchronous custom element construction as specified:
https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token
https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#throw-on-dynamic-markup-insertion-counter

Tests: fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html
       fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html

* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::openForBindings): Throw InvalidStateError when m_throwOnDynamicMarkupInsertionCount is non-zero.
(WebCore::Document::closeForBindings): Ditto.
(WebCore::Document::write): Ditto.
(WebCore::Document::writeln): Ditto.
* dom/Document.h: Re-ordered the related instance variables in the order they appear in the spec, and updated spec URLs.
* dom/ThrowOnDynamicMarkupInsertionCountIncrementer.h: Added.
(WebCore::ThrowOnDynamicMarkupInsertionCountIncrementer): Added.
(WebCore::ThrowOnDynamicMarkupInsertionCountIncrementer::ThrowOnDynamicMarkupInsertionCountIncrementer):
(WebCore::ThrowOnDynamicMarkupInsertionCountIncrementer::~ThrowOnDynamicMarkupInsertionCountIncrementer):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): Instantiate ThrowOnDynamicMarkupInsertionCountIncrementer.

LayoutTests:

Added W3C style testharness.js tests. The WPT test added by https://github.com/web-platform-tests/wpt/pull/12037
doesn't test nearly as many edge cases.

* fast/custom-elements/resources/navigation-destination.html: Added.
* fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct-expected.txt: Added.
* fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html: Added.
* fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions-expected.txt: Added.
* fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoUse 1-byte enum class for Document::StandaloneStatus
commit-queue@webkit.org [Tue, 7 Aug 2018 23:46:22 +0000 (23:46 +0000)]
Use 1-byte enum class for Document::StandaloneStatus
https://bugs.webkit.org/show_bug.cgi?id=188352

Patch by Alex Christensen <achristensen@webkit.org> on 2018-08-07
Reviewed by Chris Dumez.

* dom/Document.cpp:
(WebCore::Document::setXMLStandalone):
* dom/Document.h:
(WebCore::Document::xmlStandalone const):
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendXMLDeclaration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agofetch() with subresource integrity crashes on zero length body
commit-queue@webkit.org [Tue, 7 Aug 2018 23:26:48 +0000 (23:26 +0000)]
fetch() with subresource integrity crashes on zero length body
https://bugs.webkit.org/show_bug.cgi?id=184325

Patch by Rob Buis <rbuis@igalia.com> on 2018-08-07
Reviewed by Alex Christensen.

Source/WebCore:

Check that resourceBuffer() is non null before dereferencing.

Tests: http/tests/subresource-integrity/sri-fetch.js
       http/tests/subresource-integrity/sri-fetch-worker.js

* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didFinishLoading):

LayoutTests:

Add a subtest for zero length resources.

* http/tests/subresource-integrity/resources/empty-resource.txt: Added.
* http/tests/subresource-integrity/sri-fetch-expected.txt:
* http/tests/subresource-integrity/sri-fetch-worker-expected.txt:
* http/tests/subresource-integrity/sri-fetch.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoShrink size of PropertyCondition by packing UniquedStringImpl* and Kind
yusukesuzuki@slowstart.org [Tue, 7 Aug 2018 23:21:08 +0000 (23:21 +0000)]
Shrink size of PropertyCondition by packing UniquedStringImpl* and Kind
https://bugs.webkit.org/show_bug.cgi?id=188328

Reviewed by Saam Barati.

Source/JavaScriptCore:

Shrinking the size of PropertyCondition can improve memory consumption by a lot.
For example, cnn.com can show 7000 persistent StructureStubClearingWatchpoint
and 6000 LLIntPrototypeLoadAdaptiveStructureWatchpoint which have PropertyCondition
as a member field.

This patch shrinks the size of PropertyCondition by packing UniquedStringImpl* and
PropertyCondition::Kind into uint64_t data in 64bit architecture. Since our address
are within 48bit, we can put PropertyCondition::Kind in this unused bits.
To make it easy, we add WTF::CompactPointerTuple<PointerType, Type>, which automatically
folds a pointer and 1byte type into 64bit data.

This change shrinks PropertyCondition from 24bytes to 16bytes.

* bytecode/PropertyCondition.cpp:
(JSC::PropertyCondition::dumpInContext const):
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
(JSC::PropertyCondition::validityRequiresImpurePropertyWatchpoint const):
(JSC::PropertyCondition::isStillValid const):
(JSC::PropertyCondition::isWatchableWhenValid const):
* bytecode/PropertyCondition.h:
(JSC::PropertyCondition::PropertyCondition):
(JSC::PropertyCondition::presenceWithoutBarrier):
(JSC::PropertyCondition::absenceWithoutBarrier):
(JSC::PropertyCondition::absenceOfSetEffectWithoutBarrier):
(JSC::PropertyCondition::equivalenceWithoutBarrier):
(JSC::PropertyCondition::hasPrototypeWithoutBarrier):
(JSC::PropertyCondition::operator bool const):
(JSC::PropertyCondition::kind const):
(JSC::PropertyCondition::uid const):
(JSC::PropertyCondition::hasOffset const):
(JSC::PropertyCondition::hasAttributes const):
(JSC::PropertyCondition::hasPrototype const):
(JSC::PropertyCondition::hasRequiredValue const):
(JSC::PropertyCondition::hash const):
(JSC::PropertyCondition::operator== const):
(JSC::PropertyCondition::isHashTableDeletedValue const):
(JSC::PropertyCondition::watchingRequiresReplacementWatchpoint const):

Source/WTF:

This patch adds CompactPointerTuple, which can pack a pointer and 8bit value into 8bytes.
In 32bit architecture, it just has two fields for a pointer and 8bit value. In 64bit architecture,
we use upper 5bits (zeros because of the effective width of virtual address) and lower 3bits (zeros
because of the alignment ensured by static_assert) to pack 8bit value into the pointer data. Since
even the 5-level page tables use 57bit effective address, this strategy works well.

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/CompactPointerTuple.h: Added.
(WTF::CompactPointerTuple::encodeType):
(WTF::CompactPointerTuple::decodeType):
(WTF::CompactPointerTuple::CompactPointerTuple):
(WTF::CompactPointerTuple::pointer const):
(WTF::CompactPointerTuple::setPointer):
(WTF::CompactPointerTuple::type const):
(WTF::CompactPointerTuple::setType):
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoAdd a test for using SafeBrowsing
achristensen@apple.com [Tue, 7 Aug 2018 23:18:10 +0000 (23:18 +0000)]
Add a test for using SafeBrowsing
https://bugs.webkit.org/show_bug.cgi?id=188290

Reviewed by Chris Dumez.

Swizzle out SSBLookupContext to write tests for how WebKit responds when it responds in different ways.
We don't do anything with its results in WebKit yet, but when we do I'll add the expected behavior to this test.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: Added.
(-[SafeBrowsingDelegate webView:didFinishNavigation:]):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoPrevent querying for renderer info for disconnected or uninitialized displays
commit-queue@webkit.org [Tue, 7 Aug 2018 22:17:27 +0000 (22:17 +0000)]
Prevent querying for renderer info for disconnected or uninitialized displays
https://bugs.webkit.org/show_bug.cgi?id=188387
<rdar://problem/42588769>

Patch by Justin Fan <justin_fan@apple.com> on 2018-08-07
Reviewed by Simon Fraser.

Calling CGL functions with a NULL displayMask crashes the process.

No tests; requires multiple displays.

* platform/mac/PlatformScreenMac.mm:
(WebCore::collectScreenProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoUnreviewed, rolling out r234669.
commit-queue@webkit.org [Tue, 7 Aug 2018 21:28:47 +0000 (21:28 +0000)]
Unreviewed, rolling out r234669.
https://bugs.webkit.org/show_bug.cgi?id=188390

Didn't commit the actual change (Requested by rniwa on
#webkit).

Reverted changeset:

"document.open and document.write must throw while the HTML
parser is synchronously constructing a custom element"
https://bugs.webkit.org/show_bug.cgi?id=187319
https://trac.webkit.org/changeset/234669

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agodocument.open and document.write must throw while the HTML parser is synchronously...
rniwa@webkit.org [Tue, 7 Aug 2018 21:13:07 +0000 (21:13 +0000)]
document.open and document.write must throw while the HTML parser is synchronously constructing a custom element
https://bugs.webkit.org/show_bug.cgi?id=187319
<rdar://problem/42843012>

Reviewed by Frédéric Wang.

Source/WebCore:

Make document.open, document.write, document.writeln, and document.close throw InvalidStateError during
a synchronous custom element construction as specified:
https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token
https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#throw-on-dynamic-markup-insertion-counter

Tests: fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html
       fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html

* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::openForBindings): Throw InvalidStateError when m_throwOnDynamicMarkupInsertionCount is non-zero.
(WebCore::Document::closeForBindings): Ditto.
(WebCore::Document::write): Ditto.
(WebCore::Document::writeln): Ditto.
* dom/Document.h: Re-ordered the related instance variables in the order they appear in the spec, and updated spec URLs.
* dom/ThrowOnDynamicMarkupInsertionCountIncrementer.h: Added.
(WebCore::ThrowOnDynamicMarkupInsertionCountIncrementer): Added.
(WebCore::ThrowOnDynamicMarkupInsertionCountIncrementer::ThrowOnDynamicMarkupInsertionCountIncrementer):
(WebCore::ThrowOnDynamicMarkupInsertionCountIncrementer::~ThrowOnDynamicMarkupInsertionCountIncrementer):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): Instantiate ThrowOnDynamicMarkupInsertionCountIncrementer.

LayoutTests:

Added W3C style testharness.js tests. The WPT test added by https://github.com/web-platform-tests/wpt/pull/12037
doesn't test nearly as many edge cases.

* fast/custom-elements/resources/navigation-destination.html: Added.
* fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct-expected.txt: Added.
* fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html: Added.
* fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions-expected.txt: Added.
* fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoAdd SPI for launching WebContent process with pre-linked injected bundle
commit-queue@webkit.org [Tue, 7 Aug 2018 21:04:43 +0000 (21:04 +0000)]
Add SPI for launching WebContent process with pre-linked injected bundle
https://bugs.webkit.org/show_bug.cgi?id=188367

Patch by Ben Richards <benton_richards@apple.com> on 2018-08-07
Reviewed by Ryosuke Niwa.

Added SPI to allow applications to set a "customWebContentServiceBundleIdentifier" which will be launched instead of the default WebContent XPC service.
The "customWebContentServiceBundleIdentifier" should be the bundle identifier for an XPC service that calls [WKProcessPool _webContentProcessXPCMain].
The new XPC service should be hard linked to the application's injected bundle in order to receive the intended performance benefit.

* Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceMain):
(main):
* UIProcess/API/APIProcessPoolConfiguration.h:
* UIProcess/API/C/WKContext.cpp:
(WKContextSetCustomWebContentServiceBundleIdentifier):
* UIProcess/API/C/WKContext.h:
* UIProcess/API/Cocoa/WKProcessPool.mm:
(+[WKProcessPool _webContentProcessXPCMain]):
* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration customWebContentServiceBundleIdentifier]):
(-[_WKProcessPoolConfiguration setCustomWebContentServiceBundleIdentifier:]):
* UIProcess/Launcher/ProcessLauncher.h:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setCustomWebContentServiceBundleIdentifier):
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getLaunchOptions):
* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoStorageManager should stop ref'ing IPC::Connections as this is leak-prone
achristensen@apple.com [Tue, 7 Aug 2018 19:09:16 +0000 (19:09 +0000)]
StorageManager should stop ref'ing IPC::Connections as this is leak-prone
https://bugs.webkit.org/show_bug.cgi?id=188380

Patch by Chris Dumez <cdumez@apple.com> on 2018-08-07
Reviewed by Alex Christensen.

StorageManager should stop ref'ing IPC::Connections as this is leak-prone. Instead, assign a unique identifier
to each IPC::Connection and store this identifier intead of a RefPtr<IPC::Connection>. When the StorageManager
needs an actual IPC::Connection, it can look it up from the identifier.

* Platform/IPC/Connection.cpp:
(IPC::Connection::Connection):
(IPC::Connection::~Connection):
(IPC::Connection::connection):
* Platform/IPC/Connection.h:
(IPC::Connection::uniqueID const):
* UIProcess/WebStorage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::addListener):
(WebKit::StorageManager::StorageArea::removeListener):
(WebKit::StorageManager::StorageArea::hasListener const):
(WebKit::StorageManager::StorageArea::setItem):
(WebKit::StorageManager::StorageArea::removeItem):
(WebKit::StorageManager::StorageArea::clear):
(WebKit::StorageManager::StorageArea::dispatchEvents const):
(WebKit::StorageManager::SessionStorageNamespace::allowedConnection const):
(WebKit::StorageManager::SessionStorageNamespace::setAllowedConnection):
(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnection):
(WebKit::StorageManager::processDidCloseConnection):
(WebKit::StorageManager::createLocalStorageMap):
(WebKit::StorageManager::createTransientLocalStorageMap):
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::destroyStorageMap):
(WebKit::StorageManager::setItem):
(WebKit::StorageManager::removeItem):
(WebKit::StorageManager::clear):
(WebKit::StorageManager::applicationWillTerminate):
(WebKit::StorageManager::findStorageArea const):
* UIProcess/WebStorage/StorageManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoIf there's a Radar in the ChangeLog, webkit-patch upload/create-bug should put the...
lforschler@apple.com [Tue, 7 Aug 2018 18:46:03 +0000 (18:46 +0000)]
If there's a Radar in the ChangeLog, webkit-patch upload/create-bug should put the radar in the bug and set InRadar
https://bugs.webkit.org/show_bug.cgi?id=188235

Reviewed by Daniel Bates, Kocsen Chung, and Aakash Jain.

* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry): Teach the ChangeLog tools how to parse a radar_id
* Scripts/webkitpy/common/checkout/changelog_unittest.py: Test out the new _parse_radar_id functionality
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.add_keyword_to_bug): Add logic to add keywords using the changeform
* Scripts/webkitpy/tool/commands/upload.py:
(Upload): Teach the upload step how to add radar information when creating a new bug.
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/addradar.py: Added.
(AddRadar):
(AddRadar.run): Contains the logic to add the radar information to bugzilla.
* Scripts/webkitpy/tool/steps/createbug.py:
(CreateBug.run): set a "created_new_bug" state when creating a new bugzilla bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoNotReadableError when calling getUserMedia
eric.carlson@apple.com [Tue, 7 Aug 2018 18:33:25 +0000 (18:33 +0000)]
NotReadableError when calling getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=188309
<rdar://problem/42916838>

Reviewed by Brent Fulgham.

* UIProcess/UserMediaProcessManager.cpp:
(WebKit::UserMediaProcessManager::willCreateMediaStream): Deal with audio and video sandbox
extensions being issued at different times. Use new ProcessState methods.
(WebKit::UserMediaProcessManager::endedCaptureSession): Use new ProcessState methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoREGRESSION (r233778): Text selection sometimes cannot be extended in iframes
wenson_hsieh@apple.com [Tue, 7 Aug 2018 18:32:42 +0000 (18:32 +0000)]
REGRESSION (r233778): Text selection sometimes cannot be extended in iframes
https://bugs.webkit.org/show_bug.cgi?id=188374
<rdar://problem/42928657>

Reviewed by Simon Fraser.

Source/WebKit:

rangeForPoint contains logic for converting a selection handle location in root view coordinates to an updated
selection. In doing so, we first convert the selection handle location to content coordinates; however, the call
site to EventHandler::hitTestResultAtPoint still hit-tests using the location in root view coordinates rather
than content coordinates, which means that when the focused frame is a subframe, hit-testing will fail to find
nodes within the subframe under the selection handle. This manifests in behaviors such as snapping to a single
character when selecting text in subframes.

To fix this, we just need to pass in the point in the frame's content coordinates when hit-testing.

Tests:  editing/selection/ios/selection-handles-in-iframe.html
        editing/selection/ios/selection-handles-in-readonly-input.html

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::rangeForPointInRootViewCoordinates):

Make a couple of other minor adjustments:
1.  Take a Frame& instead of a Frame*, since Frame& is assumed to be non-null here.
2.  Rename rangeForPoint to rangeForPointInRootViewCoordinates, as well as the point argument to
    pointInRootViewCoordinates.

(WebKit::WebPage::updateSelectionWithTouches):
(WebKit::rangeForPoint): Deleted.

LayoutTests:

Add 2 new layout tests to cover the original bug that r233778 fixed, as well as the regression in this bug.

* editing/selection/ios/selection-handles-in-iframe-expected.txt: Added.
* editing/selection/ios/selection-handles-in-iframe.html: Added.

Add a test to verify that the user can select text in an iframe by dragging selection handles.

* editing/selection/ios/selection-handles-in-readonly-input-expected.txt: Added.
* editing/selection/ios/selection-handles-in-readonly-input.html: Added.

Add a test to verify that dragging a selection handle outside of a readonly input does not cause the selection
to jump outside of the input and clear out the selection in the input.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 months agoUnreviewed, suppress warnings to fix the build.
ryanhaddad@apple.com [Tue, 7 Aug 2018 18:07:31 +0000 (18:07 +0000)]
Unreviewed, suppress warnings to fix the build.

Source/WebCore:

* crypto/CommonCryptoUtilities.cpp:
(WebCore::getCommonCryptoDigestAlgorithm):

Source/WebCore/PAL:

* pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp:
(PAL::CryptoDigest::create):
(PAL::CryptoDigest::addBytes):
(PAL::CryptoDigest::computeHash):

Source/WTF:

* wtf/SHA1.cpp:
(WTF::SHA1::SHA1):
(WTF::SHA1::addBytes):
(WTF::SHA1::computeHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234659 268f45cc-cd09-0410-ab3c-d52691b4dbfc