slewis@apple.com [Sat, 29 Mar 2008 03:38:01 +0000 (03:38 +0000)]
2008-03-28 Stephanie <slewis@apple.com>
Fix 64bit build
* WebCore.LP64.exp:
* loader/archive/cf/LegacyWebArchiveMac.mm:
(WebCore::createResourceResponseFromMacArchivedData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31429
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Sat, 29 Mar 2008 03:28:11 +0000 (03:28 +0000)]
2008-03-28 Steve Falkenburg <sfalken@apple.com>
Enabled LTCG on files within "page".
Rubber stamped by Oliver.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31427
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 29 Mar 2008 03:07:21 +0000 (03:07 +0000)]
WebCore:
Reviewed by Dave Hyatt.
- fix a percentage background position regression from r31389
Test: fast/backgrounds/background-position-1.html
* rendering/Length.h:
(WebCore::Length::calcValue): Divide by 100.
(WebCore::Length::calcMinValue): Ditto.
LayoutTests:
Reviewed by Dave Hyatt.
- pixel test for a percentage background position regression from r31389
* fast/backgrounds/background-position-1.html: Added.
* platform/mac/fast/backgrounds/background-position-1-expected.checksum: Added.
* platform/mac/fast/backgrounds/background-position-1-expected.png: Added.
* platform/mac/fast/backgrounds/background-position-1-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31426
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 29 Mar 2008 02:21:34 +0000 (02:21 +0000)]
Oops. Back out unintentional change to RenderBlock.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31425
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 29 Mar 2008 02:21:00 +0000 (02:21 +0000)]
2008-03-28 David Hyatt <hyatt@apple.com>
Back out the Ahem font antialiasing hack, since it is now no longer required for LCD antialiased text
to match the reference rendering on Acid 3.
* platform/graphics/SimpleFontData.h:
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionNewFloats):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31424
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 29 Mar 2008 00:51:09 +0000 (00:51 +0000)]
WebKit:
2008-03-28 Brady Eidson <beidson@apple.com>
Rubberstamped by Darin Adler
Remove WebArchiver.h/mm
* WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2008-03-28 Brady Eidson <beidson@apple.com>
Rubberstamped by Darin Adler
Remove WebArchiver.h/mm
* WebView/WebArchiver.h: Removed.
* WebView/WebArchiver.mm: Removed.
* DOM/WebDOMOperations.mm:
* WebCoreSupport/WebDragClient.mm:
* WebCoreSupport/WebEditorClient.mm:
* WebView/WebDataSource.mm:
* WebView/WebHTMLView.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 29 Mar 2008 00:40:15 +0000 (00:40 +0000)]
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::dataForArchivedSelection):
* WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
* WebView/WebArchiver.mm: Ditto
* WebView/WebHTMLView.mm:
(-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Sat, 29 Mar 2008 00:35:45 +0000 (00:35 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 29 Mar 2008 00:18:05 +0000 (00:18 +0000)]
WebCore:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
More Kit->Core WebArchive changes.
Create an archive from the current selection in a frame
* WebCore.base.exp:
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createFromSelection):
* loader/archive/cf/LegacyWebArchive.h:
WebKit/mac:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
More Kit->Core WebArchive changes.
Create an archive from the current selection in a frame
* WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off
easily in a followup
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Sat, 29 Mar 2008 00:14:29 +0000 (00:14 +0000)]
2008-03-28 Kevin McCullough <kmccullough@apple.com>
- Somehow managed to duplicate code :(
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didFinishLoading):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Fri, 28 Mar 2008 23:50:47 +0000 (23:50 +0000)]
2008-03-28 Kevin McCullough <kmccullough@apple.com>
- Missed some changes in previous checkin.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send): Get identifier from synchronous loader.
(WebCore::XMLHttpRequest::didFinishLoading):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Fri, 28 Mar 2008 23:28:56 +0000 (23:28 +0000)]
2008-03-28 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adam.
-<rdar://problem/5712804> XMLHttpRequests do not show response contents, preview images (14313)
-<rdar://problem/5712931> XMLHttpRequests should be shown separately and grouped (14315)
-<rdar://problem/5732836> XMLHttpRequest: Inspector should show network activity/XHR in Console (17233)
- Send the XMLHttpRequest data to the Inspector Controller.
* loader/FrameLoader.cpp: Return the identifier for this resource since we need it in the XHR case.
(WebCore::FrameLoader::loadResourceSynchronously):
* loader/FrameLoader.h: Ditto.
* page/InspectorController.cpp:
(WebCore::XMLHttpRequestResource::XMLHttpRequestResource): We only need the data since the type will
be XHR and the encoding is not used (we decoded earlier).
(WebCore::XMLHttpRequestResource::~XMLHttpRequestResource): Locking is necessary when setting and clearing
the KJS::UString::Rep.
(WebCore::InspectorResource::setXMLHttpRequestProperties):
(WebCore::InspectorResource::sourceString): Return the decoded source.
(WebCore::addSourceToFrame): No longer do the decoding here, it has been encapsulated in the InspectorResource.
(WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
* page/InspectorController.h: Pass a UString instead of copying to a WebCore::String. In case we
never ask for the string's contents this will save us an extra copy.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send): In the synchronous load case we normally do not keep the identifier
but we need it to find the InspectorResource in order to tell it that it was loaded via XHR.
(WebCore::XMLHttpRequest::didFinishLoading): Tell the InspectorController that its resource was loaded
via XHR.
* xml/XMLHttpRequest.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Fri, 28 Mar 2008 23:28:11 +0000 (23:28 +0000)]
2008-03-28 Stephanie Lewis <slewis@apple.com>
Update Windows Skipped list. Bugs filed.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 28 Mar 2008 23:11:32 +0000 (23:11 +0000)]
WebCore:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
WebArchive saga continues - Can now make archives from ranges in WebCore
Again, previous layout test coverage exercised this code
* WebCore.base.exp:
* editing/markup.cpp:
(WebCore::createFullMarkup): Added a "markup from range" variant that copies the previous WebKit implementation
* editing/markup.h:
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* loader/archive/cf/LegacyWebArchive.h:
WebKit/mac:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
WebArchive saga continues - Can now make archives from ranges in WebCore
* DOM/WebDOMOperations.mm:
(-[DOMRange webArchive]):
(-[DOMRange markupString]):
* WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
* WebView/WebArchiver.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Fri, 28 Mar 2008 22:09:41 +0000 (22:09 +0000)]
2008-03-28 Stephanie Lewis <slewis@apple.com>
windows build fix.
* platform/win/MainThreadWin.cpp:
(WebCore::initializeThreadingAndMainThread):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31410
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 28 Mar 2008 21:29:56 +0000 (21:29 +0000)]
WebCore:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
More Kit->Core webarchive code movement
* WebCore.base.exp:
* editing/markup.cpp:
(WebCore::createFullMarkup): Replacement for [DOMNode markupString], creating full markup at this node including
the document type string, which the WebKit implementation did indirectly
* editing/markup.h:
WebKit/mac:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
More Kit->Core webarchive code movement
* DOM/WebDOMOperations.mm:
(-[DOMNode markupString]): Call createFullMarkup() instead
* WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
* WebView/WebFrameInternal.h: Ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31409
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 28 Mar 2008 20:56:41 +0000 (20:56 +0000)]
2008-03-28 Darin Adler <darin@apple.com>
Reviewed by Maciej.
- cut down on copying and refcount churn a little by using references a bit more for
KURL and String
* bindings/js/JSXMLHttpRequest.cpp:
(WebCore::jsXMLHttpRequestPrototypeFunctionOpen): Use const KURL& instead of KURL.
* css/StyleSheet.h:
(WebCore::StyleSheet::href): Return const String& instead of String.
(WebCore::StyleSheet::title): Ditto.
* dom/Document.cpp:
(WebCore::Document::completeURL): Use const KURL* for a local variable instead of
KURL to avoid copying the KURL.
* dom/Element.cpp:
(WebCore::Element::baseURI): Use const KURL& instead of KURL.
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::hostname): Ditto.
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed): Ditto.
* html/HTMLKeygenElement.cpp: Removed unneeded include of KURL.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected): Get rid of temporary
KURL.
* platform/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::createForFrame): Use const KURL& instead of KURL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31405
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 28 Mar 2008 20:21:39 +0000 (20:21 +0000)]
Reviewed by Sam Weinig.
Fix a dtoa thread safety issue.
WebCore can call kjs_strtod without holding JS lock, but we didn't have thread safety
compiled in for dtoa.
This is a 0.5% regression on SunSpider, which Sam Weinig has volunteered to cover with
his recent improvement.
* kjs/dtoa.cpp:
(Bigint::Balloc):
(Bigint::Bfree):
Changed to use fastMalloc/fastDelete - they are much faster than the dtoa custom version was
in the presence of locking (but somewhat slower in single-threaded case).
(Bigint::pow5mult): Got rid of the dreaded double-checked locking anti-pattern (had to
restructure the code to avoid significant performance implications).
(Bigint::lshift): Rewrote to avoid an allocation, if possible.
(Bigint::rv_alloc):
(Bigint::kjs_freedtoa):
(Bigint::kjs_dtoa):
Check for USE(MULTIPLE_THREADS), not dtoa legacy MULTIPLE_THREADS.
* kjs/InitializeThreading.cpp: Added.
(KJS::initializeThreading):
* kjs/InitializeThreading.h: Added.
Initialize threading at KJS level, if enabled.
* kjs/dtoa.h: Expose dtoa mutex for KJS::initializeThreading.
* kjs/testkjs.cpp: (kjsmain): Call initializeThreading.
* JavaScriptCore.exp: Export KJS::initializeThreading.
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCoreSources.bkl:
* JavaScriptCore.xcodeproj/project.pbxproj:
Added InitializeThreading.{h,cpp}.
* wtf/Threading.h: Removed a using directive for WTF::initializeThreading - it is only
to be called from KJS::initializeThreading, and having it in the global namespace is useless.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31404
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 28 Mar 2008 20:02:34 +0000 (20:02 +0000)]
2008-03-28 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Maciej, landed by Brady
Correct build regression (http://bugs.webkit.org/show_bug.cgi?id=18148)
* platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::GraphicsContext::getWindowsContext):
(WebCore::GraphicsContext::releaseWindowsContext):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31403
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 28 Mar 2008 20:01:07 +0000 (20:01 +0000)]
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
* WebView/WebArchiver.h:
* WebView/WebArchiver.mm:
* WebView/WebDataSource.mm:
(-[WebDataSource webArchive]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31402
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 28 Mar 2008 19:57:59 +0000 (19:57 +0000)]
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Remove unused [WebArchiver archiveNode:], made obsolete in r31400
* WebView/WebArchiver.h:
* WebView/WebArchiver.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31401
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 28 Mar 2008 19:47:12 +0000 (19:47 +0000)]
WebCore:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin
"Yet another transitional step" to empty out WebKit-based code for archiving.
With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
entirely within WebCore, and opens the door to saving WebArchives on Windows.
This is another "zero behavior change" patch, and current editing/ and webarchive/ layout tests
covered the relevant code
* WebCore.base.exp:
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* loader/archive/cf/LegacyWebArchive.h:
WebKit/mac:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin
"Yet another transitional step" to empty out WebKit-based code for archiving.
With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
entirely within WebCore, and opens the door to saving WebArchives on Windows.
* DOM/WebDOMOperations.mm:
* WebView/WebArchiver.mm:
(+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 28 Mar 2008 18:26:04 +0000 (18:26 +0000)]
2008-03-28 Jasper Bryant-Greene <jasper@unix.geek.nz>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=18061
PlatformScrollBarGtk attempts to allocate negative width and/or height for widgets
Missing clampNegativeToZero() call meant that we tried to allocate widgets with negative width and/or height.
* platform/gtk/PlatformScrollBarGtk.cpp:
(PlatformScrollbar::geometryChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 28 Mar 2008 17:53:22 +0000 (17:53 +0000)]
JavaScriptCore:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin
Export Unicode/UTF8.h and convertUTF16ToUTF8() for more flexible conversion in WebCore
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
WebCore:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin
Using convertUTF16ToUTF8() from WTF, add a helper function that gives you a UTF8 SharedBuffer
created from a String.
* ForwardingHeaders/wtf/unicode/UTF8.h: Added.
* platform/text/PlatformString.h:
* platform/text/String.cpp:
(WebCore::utf8Buffer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31398
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 28 Mar 2008 17:37:28 +0000 (17:37 +0000)]
2008-03-28 Darin Adler <darin@apple.com>
Reviewed by Adam.
- eliminate a tiny bit of unnecessary refcount churn
* bindings/js/JSEventTargetBase.cpp:
(WebCore::eventNameForPropertyToken): Return const AtomicString&.
* bindings/js/JSEventTargetBase.h:
(WebCore::JSEventTargetBase::getValueProperty): Update for above change.
(WebCore::JSEventTargetBase::putValueProperty): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31397
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 28 Mar 2008 17:03:15 +0000 (17:03 +0000)]
2008-03-28 Darin Adler <darin@apple.com>
Reviewed by Sam.
* fast/encoding/invalid-xml-expected.txt: Update to reflect a true success.
* fast/encoding/resources/invalid-xml.js: Eliminate race condition by not ending
the test until the js-test-post.js script has loaded.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31396
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 28 Mar 2008 16:26:20 +0000 (16:26 +0000)]
Rubber-stamped by Brady.
Enable server-side includes via AddHandler, hopefully making Apache 1.3 happy.
* http/tests/misc/.htaccess:
* http/tests/misc/resources/acid3/.htaccess:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 28 Mar 2008 16:16:11 +0000 (16:16 +0000)]
2008-03-28 Darin Adler <darin@apple.com>
* building/build.html: Add another mention of using the Cygwin shell.
* building/tools.html: Fix a typo on the name Cygwin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 28 Mar 2008 14:15:29 +0000 (14:15 +0000)]
Not reviewed.
Enable mod_include for acid3.html - the previous check-in only had it in resources
subdirectory.
* http/tests/misc/.htaccess: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31393
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 28 Mar 2008 09:44:39 +0000 (09:44 +0000)]
Fix the Qt build.
* rendering/Length.h: Include wtf/MathExtras.h for round().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 28 Mar 2008 09:23:39 +0000 (09:23 +0000)]
Reviewed by mjs.
Add Acid3 test as an http test
http://bugs.webkit.org/show_bug.cgi?id=18176
* http/tests/misc/acid3-expected.checksum: Added.
* http/tests/misc/acid3-expected.png: Added.
* http/tests/misc/acid3-expected.txt: Added.
* http/tests/misc/acid3.html: Added.
* http/tests/misc/resources/acid3/.htaccess: Added.
* http/tests/misc/resources/acid3/empty.css: Added.
* http/tests/misc/resources/acid3/empty.html: Added.
* http/tests/misc/resources/acid3/empty.png: Added.
* http/tests/misc/resources/acid3/empty.txt: Added.
* http/tests/misc/resources/acid3/empty.xml: Added.
* http/tests/misc/resources/acid3/font.svg: Added.
* http/tests/misc/resources/acid3/font.ttf: Added.
* http/tests/misc/resources/acid3/instructions.inc: Added.
* http/tests/misc/resources/acid3/reference.html: Added.
* http/tests/misc/resources/acid3/reference.png: Added.
* http/tests/misc/resources/acid3/support-a.png.404: Added.
* http/tests/misc/resources/acid3/support-b.png: Added.
* http/tests/misc/resources/acid3/support-c.png: Added.
* http/tests/misc/resources/acid3/svg.xml: Added.
* http/tests/misc/resources/acid3/xhtml.1: Added.
* http/tests/misc/resources/acid3/xhtml.2: Added.
* http/tests/misc/resources/acid3/xhtml.3: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 28 Mar 2008 08:54:30 +0000 (08:54 +0000)]
Add layout tests for background position rounding.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 28 Mar 2008 08:53:57 +0000 (08:53 +0000)]
2008-03-28 David Hyatt <hyatt@apple.com>
Fix a bug where background-position truncates instead of rounding when it evaluates to fractional
pixel values. This matches other browsers.
Reviewed by maciej
Added fast/backgrounds/background-position-rounding.html
* rendering/Length.h:
(WebCore::Length::calcValue):
(WebCore::Length::calcMinValue):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calculateBackgroundImageGeometry):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 28 Mar 2008 06:41:17 +0000 (06:41 +0000)]
2008-03-27 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/5826236> Regular expressions with large nested repetition counts can have their
compiled length calculated incorrectly.
* pcre/pcre_compile.cpp:
(multiplyWithOverflowCheck):
(calculateCompiledPatternLength): Check for overflow when dealing with nested repetition counts
and bail with an error rather than returning incorrect results.
2008-03-27 Mark Rowe <mrowe@apple.com>
Reviewed by Adam Roben.
Tests for <rdar://problem/5826236> Regular expressions with large nested repetition counts can have their
compiled length calculated incorrectly.
* fast/js/regexp-overflow-expected.txt:
* fast/js/resources/regexp-overflow.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Fri, 28 Mar 2008 05:49:54 +0000 (05:49 +0000)]
wx build fix. Return a default value for operator == when !USE(WXGC) (not implemented in that case).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 28 Mar 2008 05:42:17 +0000 (05:42 +0000)]
2008-03-27 Maciej Stachowiak <mjs@apple.com>
- fix build
* svg/SVGGlyphMap.h:
(WebCore::GlyphMapNode::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 28 Mar 2008 05:37:37 +0000 (05:37 +0000)]
2008-03-27 Brady Eidson <beidson@apple.com>
Forgot a small requested change before committing
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::mainResource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 28 Mar 2008 05:33:41 +0000 (05:33 +0000)]
WebCore:
2008-03-27 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben
Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
as the push to core-ify WebArchives continues.
This patch also introduces a behavior change. WebCore allows ArchiveResources with null or empty data.
WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.
Since WebResource is API, I decided to leave it be to avoid a behavior change. But internally created resources
(as in "while archiving a page") are accepting of null or empty data.
This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.
* WebCore.base.exp:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::archiveResourceForURL): Make this const
(WebCore::DocumentLoader::mainResource):
(WebCore::DocumentLoader::subresource): Make this const and relocate
(WebCore::DocumentLoader::getSubresources):
* loader/DocumentLoader.h:
WebKit/mac:
2008-03-27 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben
Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
as the push to core-ify WebArchives continues.
This patch also introduces a behavior change. WebCore allows ArchiveResources with null or empty data.
WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.
Since WebResource is API, I decided to leave it be to avoid a behavior change. But internally created resources
(as in "while archiving a page") are accepting of null or empty data.
This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.
* WebView/WebDataSource.mm:
(-[WebDataSource mainResource]): Call DocumentLoader implementation
(-[WebDataSource subresources]): Ditto
* WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
* WebView/WebFrameInternal.h:
LayoutTests:
2008-03-27 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben
Updated results, as we now more consistently archive empty frames/empty resources
* webarchive/archive-empty-frame-source-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 28 Mar 2008 05:25:33 +0000 (05:25 +0000)]
2008-03-27 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- fixed many buildbot leaks in glyph map code
* svg/SVGGlyphMap.h:
(WebCore::GlyphMapNode::create): Use explicit create pattern, to avoid overreffing and therefore leaking
these objects.
(WebCore::SVGGlyphMap::add): Call create instead of using new.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 28 Mar 2008 03:37:09 +0000 (03:37 +0000)]
2008-03-27 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Oliver.
- re-fix Acid3, some code was incorrectly moved when fixing the Qt build
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 28 Mar 2008 01:10:47 +0000 (01:10 +0000)]
2008-03-27 Brady Eidson <beidson@apple.com>
Reviewed by Adam
Change the "init from WebCore resource" version of WebResource to take PassRefPtr
(more efficient)
* WebView/WebResource.mm:
(-[WebResource _initWithCoreResource:]):
* WebView/WebResourceInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 27 Mar 2008 22:14:08 +0000 (22:14 +0000)]
Fix compilation against Qt 4.4 and one missing SVG_FONTS #ifdef.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 27 Mar 2008 21:37:33 +0000 (21:37 +0000)]
Fix the Qt build and the build without ENABLE(SVG_FONTS)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Thu, 27 Mar 2008 10:56:35 +0000 (10:56 +0000)]
Removed whitespace that crept in from r31357.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Thu, 27 Mar 2008 07:12:14 +0000 (07:12 +0000)]
2008-03-26 Timothy Hatcher <timothy@apple.com>
Rename some Inspector files to facilitate the up-coming UI refresh changes.
http://bugs.webkit.org/show_bug.cgi?id=17773
Rubber-stamped by Adam Roben.
* WebCore.vcproj/WebCore.vcproj:
* page/inspector/Console.js: Copied from page/inspector/ConsolePanel.js.
* page/inspector/ConsolePanel.js: Removed.
* page/inspector/DocumentPanel.js: Removed.
* page/inspector/ElementsPanel.js: Copied from page/inspector/DocumentPanel.js.
* page/inspector/FontPanel.js: Removed.
* page/inspector/FontView.js: Copied from page/inspector/FontPanel.js.
* page/inspector/ImagePanel.js: Removed.
* page/inspector/ImageView.js: Copied from page/inspector/ImagePanel.js.
* page/inspector/NetworkPanel.js: Removed.
* page/inspector/ResourcePanel.js: Removed.
* page/inspector/ResourceView.js: Copied from page/inspector/ResourcePanel.js.
* page/inspector/ResourcesPanel.js: Copied from page/inspector/NetworkPanel.js.
* page/inspector/SourcePanel.js: Removed.
* page/inspector/SourceView.js: Copied from page/inspector/SourcePanel.js.
* page/inspector/WebKit.qrc:
* page/inspector/inspector.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31370
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 27 Mar 2008 06:44:56 +0000 (06:44 +0000)]
2008-03-26 Steve Falkenburg <sfalken@apple.com>
Enable LTCG on css, dom files in WebCore
Reviewed by Stephanie.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Thu, 27 Mar 2008 06:24:35 +0000 (06:24 +0000)]
2008-03-26 Stephanie Lewis <slewis@apple.com>
Fix Windows Build
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 27 Mar 2008 06:01:31 +0000 (06:01 +0000)]
Speculative GTK build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 27 Mar 2008 05:16:44 +0000 (05:16 +0000)]
2008-03-26 Brady Eidson <beidson@apple.com>
Build fix - accidentally checked in this change which was work in progress
* DOM/WebDOMOperations.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 27 Mar 2008 04:59:06 +0000 (04:59 +0000)]
Mac build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Thu, 27 Mar 2008 04:36:04 +0000 (04:36 +0000)]
2008-03-26 Maciej Stachowiak <mjs@apple.com>
More screenshots for teh blog.
* blog-files/acid3-full-rendering-pass.png: Added.
* blog-files/acid3-rendering-reference.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31360
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 27 Mar 2008 04:33:45 +0000 (04:33 +0000)]
2008-03-26 Sam Weinig <sam@webkit.org>
Try and fix Gtk+ again.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31359
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 27 Mar 2008 04:13:47 +0000 (04:13 +0000)]
Reviewed by Dave Hyatt.
- fix <rdar://problem/5816522> REGRESSION (r30111-30112): Tahoe web cam website has some text in Chinese or japanese
* html/HTMLParser.cpp:
(WebCore::HTMLParser::insertNode): Added call to beginParsingChildren()
on the new node.
(WebCore::HTMLParser::handleError): Ditto.
(WebCore::HTMLParser::reopenResidualStyleTags): Ditto.
(WebCore::HTMLParser::pushBlock): Removed incorrect call to
beginParsingChildren() on the current node.
* manual-tests/applet-finish-parsing-children.html: Added.
* manual-tests/resources/DrawMessage.class: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31358
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 27 Mar 2008 04:08:17 +0000 (04:08 +0000)]
WebCore:
2008-03-26 Brady Eidson <beidson@apple.com>
Reviewed by Darin
When we create a WebArchive, we walk every node from some starting point, asking each node
along the way "What are your subresource URLs?"
That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
WebCore::Node
* WebCore.base.exp:
* dom/Node.cpp:
(WebCore::Node::getSubresourceURLs):
(WebCore::Node::getSubresourceAttributeStrings): Virtual and empty. Subclasses of Node that have
subresources will override it.
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::getSubresourceAttributeStrings):
* dom/ProcessingInstruction.h:
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::getSubresourceAttributeStrings):
* html/HTMLBodyElement.h:
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::getSubresourceAttributeStrings):
* html/HTMLEmbedElement.h:
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::getSubresourceAttributeStrings):
* html/HTMLImageElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::getSubresourceAttributeStrings):
* html/HTMLInputElement.h:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::getSubresourceAttributeStrings):
* html/HTMLLinkElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::getSubresourceAttributeStrings):
* html/HTMLObjectElement.h:
* html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::getSubresourceAttributeStrings):
* html/HTMLParamElement.h:
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::getSubresourceAttributeStrings):
* html/HTMLScriptElement.h:
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::getSubresourceAttributeStrings):
* html/HTMLTableCellElement.h:
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::getSubresourceAttributeStrings):
* html/HTMLTableElement.h:
* svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::getSubresourceAttributeStrings):
* svg/SVGCursorElement.h:
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::getSubresourceAttributeStrings):
* svg/SVGFEImageElement.h:
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::getSubresourceAttributeStrings):
* svg/SVGImageElement.h:
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::getSubresourceAttributeStrings):
* svg/SVGScriptElement.h:
WebKit/mac:
2008-03-26 Brady Eidson <beidson@apple.com>
Reviewed by Darin
When we create a WebArchive, we walk every node from some starting point, asking each node
along the way "What are your subresource URLs?"
That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
WebCore::Node
* DOM/WebDOMOperations.mm:
(-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
calling into individual WebCore::Node implementations
* DOM/WebDOMOperationsPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31357
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 27 Mar 2008 04:02:07 +0000 (04:02 +0000)]
Reviewed by Dave Hyatt.
- maintain subpixel-antialiasing when drawing text with a simple shadow
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawComplexText): If the shadow has a zero blur radius,
draw the shadow by drawing the text at an offset instead of relying on
Core Graphics shadows.
(WebCore::Font::drawGlyphs): Ditto.
* platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31356
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 27 Mar 2008 03:58:19 +0000 (03:58 +0000)]
WebCore:
2008-03-26 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe
Part of the continued push to move WebArchive-related code down to WebCore, this
moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
* WebCore.base.exp:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::subresource): Create an ArchiveResource from a CachedResource if it exists
Otherwise, fallback to an ArchiveResource from the current Archive if any. Otherwise, return null
* loader/DocumentLoader.h:
* loader/archive/ArchiveResource.cpp:
(WebCore::ArchiveResource::create):
(WebCore::ArchiveResource::ArchiveResource):
* loader/archive/ArchiveResource.h:
WebKit/mac:
2008-03-26 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe
Part of the continued push to move WebArchive-related code down to WebCore, this
moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
* WebView/WebDataSource.mm:
(-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader
* WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
has now been ported down to WebCore
* WebView/WebFrameInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 27 Mar 2008 03:54:46 +0000 (03:54 +0000)]
2008-03-26 Sam Weinig <sam@webkit.org>
Fix Gtk+ build.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31354
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 27 Mar 2008 03:48:29 +0000 (03:48 +0000)]
Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
Rubber-stamped by Brady Eidson.
* Configurations/JavaScriptCore.xcconfig:
* Configurations/WebCore.xcconfig:
* Configurations/WebKit.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Thu, 27 Mar 2008 03:43:30 +0000 (03:43 +0000)]
WebCore:
2008-03-26 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Add necessary files and build commands to vcproj files to
build a Curl-based Windows WebKit. For details, see
http://bugs.webkit.org/show_bug.cgi?id=17985
* WebCore.vcproj/WebCore.vcproj:
WebKit/win:
2008-03-26 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Add necessary files and build commands to vcproj files to
build a Curl-based Windows WebKit. For details, see
http://bugs.webkit.org/show_bug.cgi?id=17985
* WebKit.vcproj/WebKit.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31352
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 27 Mar 2008 03:38:35 +0000 (03:38 +0000)]
Record JS exceptions triggered by the Inspector's use of JSC
We now dump all exceptions returned from JavaScriptCore into the
Inspector's console.
The HANDLE_EXCEPTION macro records the line on which the exception was
returned. It calls a new private handleException method on
InspectorController.
Reviewed by Kevin McCullough.
* page/InspectorController.cpp:
(WebCore::InspectorController::callSimpleFunction): Made this be a
member of InspectorController so that it can call handleException.
(WebCore::addSourceToFrame): Pass the exception pointer on to inner
JSC calls, and check it after those calls return.
(WebCore::getResourceDocumentNode): Ditto.
(WebCore::search): Ditto. Also changed the name/type of an existing
exception variable to ExceptionCode ec.
(WebCore::databaseTableNames): Ditto.
(WebCore::moveByUnrestricted): Ditto.
(WebCore::InspectorController::~InspectorController): Check for and
record exceptions as we call JSC.
(WebCore::InspectorController::focusNode): Ditto.
(WebCore::InspectorController::scriptObjectReady): Ditto.
(WebCore::addHeaders): Added an exception parameter.
(WebCore::scriptObjectForRequest): Ditto.
(WebCore::scriptObjectForResponse): Ditto.
(WebCore::InspectorController::addScriptResource): Check for and
record exceptions as we call JSC.
(WebCore::InspectorController::addAndUpdateScriptResource): Ditto.
(WebCore::InspectorController::removeScriptResource): Ditto. Also
moved the call to setScriptObject to before the JSC calls so that it
will always be called even if we return early if JSC throws an
exception.
(WebCore::InspectorController::updateScriptResourceRequest): Check for
and record exceptions as we call JSC.
(WebCore::InspectorController::updateScriptResourceResponse): Ditto.
(WebCore::InspectorController::updateScriptResource): Ditto.
(WebCore::InspectorController::addDatabaseScriptResource): Ditto.
(WebCore::InspectorController::removeDatabaseScriptResource): Ditto.
Also moved the call to setScriptObject to before the JSC calls so that
it will always be called even if we return early if JSC throws an
exception.
(WebCore::InspectorController::addScriptConsoleMessage): Check for and
record exceptions as we call JSC.
(WebCore::InspectorController::handleException): Added.
* page/InspectorController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 27 Mar 2008 03:35:40 +0000 (03:35 +0000)]
Fix Bug 18060: Assertion failure (JSLock not held) beneath JSCallbackObject<Base>::toString
<http://bugs.webkit.org/show_bug.cgi?id=18060>
Reviewed by Geoff Garen.
Bug fix:
* API/JSCallbackObjectFunctions.h:
(KJS::JSCallbackObject<Base>::toString): Make the DropAllLocks
instance only be in scope while calling convertToType.
Test:
* API/testapi.c:
(MyObject_convertToType): Implement type conversion to string.
* API/testapi.js: Add a test for type conversion to string.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 27 Mar 2008 03:14:08 +0000 (03:14 +0000)]
2008-03-26 Darin Adler <darin@apple.com>
Rubber stamped by Maciej.
- removed a couple log messages in error cases that are handled internally
* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::decode): Removed the LOG_ERROR.
* platform/text/mac/TextCodecMac.cpp:
(WebCore::TextCodecMac::decode): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31349
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 27 Mar 2008 03:11:30 +0000 (03:11 +0000)]
Windows build fix after r31322
* win/include/WebKitSystemInterface/WebKitSystemInterface.h: Updated.
* win/lib/WebKitSystemInterface.lib: Updated.
* win/lib/WebKitSystemInterface_debug.lib: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 27 Mar 2008 02:56:16 +0000 (02:56 +0000)]
2008-03-26 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
* page/Location.idl: Don't enumerate toString.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 27 Mar 2008 02:53:20 +0000 (02:53 +0000)]
2008-03-26 Sam Weinig <sam@webkit.org>
Rubber-stamped by Adam Roben.
Update test result.
* fast/dom/Window/window-special-properties-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31346
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Thu, 27 Mar 2008 02:45:42 +0000 (02:45 +0000)]
2008-03-26 Maciej Stachowiak <mjs@apple.com>
Screenshot for blog post.
* blog-files/acid3-100.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31345
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 27 Mar 2008 02:41:16 +0000 (02:41 +0000)]
Release build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31344
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 27 Mar 2008 02:34:47 +0000 (02:34 +0000)]
Windows build fix
* kjs/array_instance.cpp: Touched this.
* wtf/HashFunctions.h:
(WTF::intHash): Added 8- and 16-bit versions of intHash.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Thu, 27 Mar 2008 02:34:14 +0000 (02:34 +0000)]
WebCore:
2008-03-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Hyatt and Adam.
Coded by me and Darin.
- SVG kerning support (horizontal kerning only for now since we don't do vertical text layout right yet)
Acid3 100/100
* DerivedSources.make:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/Font.cpp:
(WebCore::Font::floatWidth):
(WebCore::Font::isSVGFont):
* platform/graphics/Font.h:
* rendering/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::calculateGlyphWidth):
(WebCore::SVGInlineTextBox::calculateGlyphBoundaries):
* rendering/SVGInlineTextBox.h:
* rendering/SVGRootInlineBox.cpp:
(WebCore::cummulatedWidthOrHeightOfTextChunk):
(WebCore::SVGRootInlineBox::buildLayoutInformation):
(WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
* rendering/SVGRootInlineBox.h:
(WebCore::LastGlyphInfo::LastGlyphInfo):
* svg/SVGFont.cpp:
(WebCore::SVGTextRunWalker::walk):
(WebCore::Font::svgFont):
(WebCore::floatWidthOfSubStringUsingSVGFont):
(WebCore::Font::floatWidthUsingSVGFont):
(WebCore::Font::drawTextUsingSVGFont):
(WebCore::Font::selectionRectForTextUsingSVGFont):
* svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::invalidateGlyphCache):
(WebCore::SVGFontElement::ensureGlyphCache):
(WebCore::parseUnicodeRange):
(WebCore::parseUnicodeRangeList):
(WebCore::stringMatchesUnicodeRange):
(WebCore::matches):
(WebCore::SVGFontElement::getHorizontalKerningPairForStringsAndGlyphs):
* svg/SVGFontElement.h:
* svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::insertedIntoDocument):
(WebCore::SVGGlyphElement::removedFromDocument):
* svg/SVGHKernElement.cpp: Added.
(WebCore::SVGHKernElement::SVGHKernElement):
(WebCore::SVGHKernElement::~SVGHKernElement):
(WebCore::SVGHKernElement::insertedIntoDocument):
(WebCore::SVGHKernElement::removedFromDocument):
(WebCore::SVGHKernElement::buildHorizontalKerningPair):
* svg/SVGHKernElement.h: Added.
(WebCore::SVGHorizontalKerningPair::SVGHorizontalKerningPair):
(WebCore::SVGHKernElement::rendererIsNeeded):
* svg/SVGHKernElement.idl: Added.
* svg/SVGTextContentElement.cpp:
(WebCore::cummulatedCharacterRangeLength):
(WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
* svg/svgtags.in:
LayoutTests:
2008-03-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Hyatt and Adam.
- new test case and test fixes for SVG text kerning
* svg/text/kerning.svg: Added.
* platform/mac/svg/text/kerning-expected.txt: Added.
* platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
* platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 27 Mar 2008 02:21:49 +0000 (02:21 +0000)]
2008-03-26 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Autogenerate JSLocation.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
Add files.
* DerivedSources.make: Add Location, remove JSLocation.lut.h
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBasePrivate::JSDOMWindowBasePrivate):
(WebCore::JSDOMWindowBase::getValueProperty):
(WebCore::JSDOMWindowBase::put):
(WebCore::JSDOMWindowBase::clearHelperObjectProperties):
(WebCore::JSDOMWindowBase::disconnectFrame):
* bindings/js/JSDOMWindowBase.h:
Remove manuel management of the Location object.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::mark): Add marking of JSLocation.
(WebCore::JSDOMWindow::setLocation): Add custom setLocation as we only want to do this when
safe and we need to keep Dashboard quirks.
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::location):
Fetch the location object using the normal toJS route.
* bindings/js/JSLocation.cpp: Removed.
* bindings/js/JSLocation.h: Removed.
* bindings/js/JSLocationCustom.cpp: Added.
(WebCore::JSLocation::customGetOwnPropertySlot):
(WebCore::JSLocation::customPut):
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::customGetPropertyNames):
(WebCore::navigateIfAllowed):
(WebCore::JSLocation::setHref):
(WebCore::JSLocation::setProtocol):
(WebCore::JSLocation::setHost):
(WebCore::JSLocation::setHostname):
(WebCore::JSLocation::setPort):
(WebCore::JSLocation::setPathname):
(WebCore::JSLocation::setSearch):
(WebCore::JSLocation::setHash):
(WebCore::JSLocation::replace):
(WebCore::JSLocation::reload):
(WebCore::JSLocation::assign):
(WebCore::JSLocation::toString):
Setter and Functions need custom implementations as they rely on the dynamic
global object for determining the behavior of the navigation.
* history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):
* history/CachedPage.h:
Removed all the special casing for location as it should be treated like all
the other objects hanging off the window.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::clear):
(WebCore::DOMWindow::location):
* page/DOMWindow.h:
(WebCore::DOMWindow::optionalLocation):
* page/DOMWindow.idl:
Add Location accessor and pointer getter for marking.
* page/Location.cpp: Added.
(WebCore::Location::Location):
(WebCore::Location::disconnectFrame):
(WebCore::Location::url):
(WebCore::Location::href):
(WebCore::Location::protocol):
(WebCore::Location::host):
(WebCore::Location::hostname):
(WebCore::Location::port):
(WebCore::Location::pathname):
(WebCore::Location::search):
(WebCore::Location::hash):
(WebCore::Location::toString):
* page/Location.h: Added.
(WebCore::Location::create):
(WebCore::Location::frame):
* page/Location.idl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 27 Mar 2008 01:53:34 +0000 (01:53 +0000)]
Add layout test results for altGlyph.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 27 Mar 2008 01:53:16 +0000 (01:53 +0000)]
Add layout test for altGlyph.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 27 Mar 2008 01:52:55 +0000 (01:52 +0000)]
2008-03-26 David Hyatt <hyatt@apple.com>
Add support for the rendering and measurement of the <altGlyph> element in SVG. This patch brings
is half of what's needed to reach 100/100 on Acid3 and pass the test. Maciej has coded up the other half. :)
Reviewed by mjs
Added svg/custom/altGlyph.svg
* svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::childShouldCreateRenderer):
(WebCore::SVGAltGlyphElement::glyphElement):
* svg/SVGAltGlyphElement.h:
* svg/SVGFont.cpp:
(WebCore::SVGTextRunWalker::walk):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::insertedIntoDocument):
* svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::insertedIntoDocument):
(WebCore::SVGGlyphElement::removedFromDocument):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 27 Mar 2008 01:43:54 +0000 (01:43 +0000)]
Turn on SVG animation on Windows
JavaScriptCore:
Force JSC headers to be copied by touching a file
* kjs/array_instance.cpp:
(KJS::ArrayInstance::getPropertyNames):
WebCore:
Turn on SVG animation on Windows
Also touched some files to force things to rebuild/regenerate.
* WebCore.vcproj/WebCore.vcproj: Added ENABLE_SVG_ANIMATION.
* WebCore.vcproj/build-generated-files.sh: Ditto.
* bindings/scripts/CodeGenerator.pm: Touched.
* config.h: Touched.
* svg/svgtags.in: Touched.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justin.garcia@apple.com [Thu, 27 Mar 2008 01:10:15 +0000 (01:10 +0000)]
2008-03-26 Justin Garcia <justin.garcia@apple.com>
Reviewed by Harrison.
<rdar://problem/5820749> REGRESSION (Safari 3.1): Mail's plain text reply omits blank line following the attribution
* editing/markup.cpp:
(WebCore::createFragmentFromText): When asked to create a fragment from "Attribution:\n"
with a context from [html, 0] to [html, 0], we'd return "<html>Attribution</html><br>".
Don't enclose paragraphs in clones of the context's enclosing block if that block is the
html or body element. Currently no way to test [DOMHTMLElement createFragmentFromText:].
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 27 Mar 2008 00:58:22 +0000 (00:58 +0000)]
Windows build fix after r31324
Written with Darin.
Added HashTable plumbing to support using wchar_t as a key type.
* wtf/HashFunctions.h:
* wtf/HashTraits.h:
(WTF::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 27 Mar 2008 00:21:17 +0000 (00:21 +0000)]
WebCore:
2008-03-26 Antti Koivisto <antti@apple.com>
Reviewed by Anders.
http://bugs.webkit.org/show_bug.cgi?id=17077
Bug 17077: SVG SMIL animation is currently broken (and turned off) (affects Acid3 tests 75 and 76)
- enable SVG animation support.
- basic implementation of beginElement()/endElement().
Animation definitely will need more work than this, but it is a start!
* Configurations/WebCore.xcconfig:
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::SVGAnimationElement):
(WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
(WebCore::SVGAnimationElement::beginElement):
(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElement):
(WebCore::SVGAnimationElement::endElementAt):
* svg/SVGAnimationElement.h:
WebKitTools:
2008-03-26 Antti Koivisto <antti@apple.com>
Reviewed by Anders.
Enable SVG animation support by default.
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 26 Mar 2008 23:34:36 +0000 (23:34 +0000)]
2008-03-26 Mark Rowe <mrowe@apple.com>
Reviewed by David Hyatt.
Make the Ahem font antialias correctly on Acid3 on Tiger.
* WebCore.Tiger.exp:
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
2008-03-26 Mark Rowe <mrowe@apple.com>
Reviewed by David Hyatt.
Make the Ahem font antialias correctly on Acid3 on Tiger.
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceTiger.a:
2008-03-26 Mark Rowe <mrowe@apple.com>
Reviewed by David Hyatt.
Make the Ahem font antialias correctly on Acid3 on Tiger.
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 26 Mar 2008 23:02:30 +0000 (23:02 +0000)]
Attempt to fix the Qt build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Wed, 26 Mar 2008 22:56:16 +0000 (22:56 +0000)]
2008-03-26 Stephanie Lewis <slewis@apple.com>
Not Reviewed.
Move storage tests to Skipped list since they hang 80% of the time. See <rdar://problem/5787763>.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 26 Mar 2008 20:53:07 +0000 (20:53 +0000)]
2008-03-26 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
- fix http://bugs.webkit.org/show_bug.cgi?id=18104
REGRESSION: LEAK: 2 InlineBox in editing/inserting/12882.html
* rendering/bidi.cpp:
(WebCore::RenderBlock::layoutInlineChildren): When deciding to ditch
old clean lines (due to changed or newly-added floats), keep the
reference to those lines so they can be properly deleted in the end,
and use a separate flag to signal that no matching should be attempted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 26 Mar 2008 20:21:40 +0000 (20:21 +0000)]
Speculative Windows build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Wed, 26 Mar 2008 19:59:32 +0000 (19:59 +0000)]
2008-03-25 Steve Falkenburg <sfalken@apple.com>
Turn on link-time-codegen in html and rendering related files.
Reviewed by Oliver.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Wed, 26 Mar 2008 19:26:26 +0000 (19:26 +0000)]
2008-03-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- JSC part of fix for "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)"
http://bugs.webkit.org/show_bug.cgi?id=18118
* wtf/HashFunctions.h:
(WTF::):
* wtf/HashTraits.h:
(WTF::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Wed, 26 Mar 2008 19:22:01 +0000 (19:22 +0000)]
WebCore:
2008-03-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- fixed "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)"
http://bugs.webkit.org/show_bug.cgi?id=18118
* svg/SVGFont.cpp:
(WebCore::SVGTextRunWalker::walk):
* svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::SVGFontElement):
(WebCore::SVGFontElement::addGlyphToCache):
(WebCore::SVGFontElement::removeGlyphFromCache):
(WebCore::SVGFontElement::ensureGlyphCache):
(WebCore::SVGFontElement::getGlyphIdentifiersForString):
* svg/SVGFontElement.h:
* svg/SVGGlyphElement.h:
(WebCore::SVGGlyphIdentifier::SVGGlyphIdentifier):
* svg/SVGGlyphMap.h: Added. New radix tree based glyph map.
(WebCore::GlyphMapNode::GlyphMapNode):
(WebCore::SVGGlyphMap::SVGGlyphMap):
(WebCore::SVGGlyphMap::add):
(WebCore::SVGGlyphMap::compareGlyphPriority):
(WebCore::SVGGlyphMap::get):
(WebCore::SVGGlyphMap::clear):
LayoutTests:
2008-03-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- test updates for "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)"
http://bugs.webkit.org/show_bug.cgi?id=18118
These test cases were already checking for this exact bug and now
render correctly.
* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 26 Mar 2008 19:12:52 +0000 (19:12 +0000)]
2008-03-26 David Hyatt <hyatt@apple.com>
Fix build bustage on Tiger. Tiger will not have the bug fix.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 26 Mar 2008 19:01:31 +0000 (19:01 +0000)]
2008-03-26 David Hyatt <hyatt@apple.com>
Make the Ahem font antialias correctly on Acid3.
Reviewed by Dan
* platform/graphics/SimpleFontData.h:
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 26 Mar 2008 18:04:29 +0000 (18:04 +0000)]
Fix the Mac build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 26 Mar 2008 17:49:32 +0000 (17:49 +0000)]
Fix Bug 17768: REGRESSION (r30146): Inspector no longer shows elements properties
<http://bugs.webkit.org/show_bug.cgi?id=17768>
We were throwing an exception from Object.describe because of some
undefined variables.
Reviewed by Tim Hatcher.
* page/inspector/utilities.js:
(Object.describe): Reinstate the type1 and type2 variables that were
removed in r30146. They're still used when formatting a function.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 26 Mar 2008 17:44:59 +0000 (17:44 +0000)]
Reviewed by Darin.
Cache C string identifiers by address, not value, assuming that C strings can only
be literals.
1% speedup on Acid3 test 26.
* kjs/identifier.cpp:
(KJS::literalIdentifierTable):
(KJS::Identifier::add):
Added a new table to cache UString::Reps created from C strings by address. Elements are
never removed from this cache, as only predefined identifiers can get there.
* kjs/identifier.h:
(KJS::Identifier::Identifier): Added a warning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 26 Mar 2008 17:29:00 +0000 (17:29 +0000)]
Rubber-stamped by Maciej.
An assertion was failing in function-toString-object-literals.html when parsing 1e-500.
The condition existed before, and got uncovered by turning compiled-out dtoa checks into
ASSERTs.
The assertion was verifying that the caller wasn't constructing a Bigint from 0.
This might have had some reason behind it originally, but I couldn't find any,
and this doesn't look like a reasonable requirement.
* kjs/dtoa.cpp: (d2b): Removed the assertion (two copies in different code paths).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 26 Mar 2008 17:27:59 +0000 (17:27 +0000)]
Reviewed by darin.
Forgot to add braces darin asked for during review.
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::write):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 26 Mar 2008 17:19:07 +0000 (17:19 +0000)]
Reviewed by darin.
Fix, makes us pass Test 70
XML documents should be strict about encoding checks
http://bugs.webkit.org/show_bug.cgi?id=17079
Test: fast/encoding/invalid-xml.html
* WebCore.base.exp:
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::write):
* loader/CachedFont.cpp:
(WebCore::CachedFont::ensureSVGFontData):
* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::TextResourceDecoder):
(WebCore::TextResourceDecoder::decode):
* loader/TextResourceDecoder.h:
* platform/text/TextCodec.h:
(WebCore::TextCodec::decode):
* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::decodeToBuffer):
(WebCore::ErrorCallbackSetter::ErrorCallbackSetter):
(WebCore::ErrorCallbackSetter::~ErrorCallbackSetter):
(WebCore::TextCodecICU::decode):
* platform/text/TextCodecICU.h:
* platform/text/TextCodecLatin1.cpp:
* platform/text/TextCodecLatin1.h:
* platform/text/TextCodecUTF16.cpp:
* platform/text/TextCodecUTF16.h:
* platform/text/TextCodecUserDefined.cpp:
* platform/text/TextCodecUserDefined.h:
* platform/text/TextDecoder.cpp:
(WebCore::TextDecoder::checkForBOM):
* platform/text/TextDecoder.h:
(WebCore::TextDecoder::decode):
* platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::decode):
* platform/text/TextEncoding.h:
(WebCore::TextEncoding::decode):
* platform/text/mac/TextCodecMac.cpp:
(WebCore::TextCodecMac::decode):
* platform/text/mac/TextCodecMac.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 26 Mar 2008 16:59:07 +0000 (16:59 +0000)]
2008-03-26 Antti Koivisto <antti@apple.com>
Reviewed by Adam.
Add ElementTimeControl interface to SVGAnimationElement.
Passes Acid3 test 75.
* DerivedSources.make:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorObjC.pm:
* svg/ElementTimeControl.h: Added.
(WebCore::ElementTimeControl::~ElementTimeControl):
* svg/ElementTimeControl.idl: Added.
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::beginElement):
(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElement):
(WebCore::SVGAnimationElement::endElementAt):
* svg/SVGAnimationElement.h:
* svg/SVGAnimationElement.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Wed, 26 Mar 2008 16:22:09 +0000 (16:22 +0000)]
2008-03-26 Kevin McCullough <kmccullough@apple.com>
- LayoutTest fix. Null check.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 26 Mar 2008 14:33:07 +0000 (14:33 +0000)]
WebCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=17994
REGRESSION (523-525+) View not updated when changing CSS size via JavaScript
- fix http://bugs.webkit.org/show_bug.cgi?id=18063
REGRESSION (r31250): Small bug that just cropped up in WebKit r31275
Tests: fast/repaint/subtree-root-clip.html
fast/repaint/subtree-root-clip-2.html
fast/repaint/subtree-root-clip-3.html
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState): Changed to not set an initial clip.
Since the root is clipping, there is no need to set a clip, and setting
the clip based on the container was wrong because often the root was
not included in the container's overflow rect because it had its own
layer.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::absolutePosition): Removed code that added table
cell's extra top offset only in the slow (recursive) code path.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::absolutePosition): Added code to add the
extra top offset in both code paths.
LayoutTests:
Reviewed by Darin Adler.
- tests for http://bugs.webkit.org/show_bug.cgi?id=17994
REGRESSION (523-525+) View not updated when changing CSS size via JavaScript
- and http://bugs.webkit.org/show_bug.cgi?id=18063
REGRESSION (r31250): Small bug that just cropped up in WebKit r31275
* fast/repaint/subtree-root-clip-2.html: Added.
* fast/repaint/subtree-root-clip-3.html: Added.
* fast/repaint/subtree-root-clip.html: Added.
* platform/mac/fast/repaint/subtree-root-clip-2-expected.checksum: Added.
* platform/mac/fast/repaint/subtree-root-clip-2-expected.png: Added.
* platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Added.
* platform/mac/fast/repaint/subtree-root-clip-3-expected.checksum: Added.
* platform/mac/fast/repaint/subtree-root-clip-3-expected.png: Added.
* platform/mac/fast/repaint/subtree-root-clip-3-expected.txt: Added.
* platform/mac/fast/repaint/subtree-root-clip-expected.checksum: Added.
* platform/mac/fast/repaint/subtree-root-clip-expected.png: Added.
* platform/mac/fast/repaint/subtree-root-clip-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 26 Mar 2008 13:00:01 +0000 (13:00 +0000)]
Fix the Qt build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Wed, 26 Mar 2008 10:18:45 +0000 (10:18 +0000)]
Fixed reviewer in WebCore/ChangeLog and LayoutTests/ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Wed, 26 Mar 2008 10:10:08 +0000 (10:10 +0000)]
WebCore:
2008-03-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Maciej.
- fixed "SVGTextElement.getStartPositionOfChar does not correctly account for multichar glyphs"
http://bugs.webkit.org/show_bug.cgi?id=18046
* platform/graphics/Font.cpp:
(WebCore::Font::floatWidth): Allow expressing a run that has extra "context" characters beyond the end,
and reporting of how many characters were actually consumed, to support multichar glyphs in SVG fonts.
* platform/graphics/Font.h:
* rendering/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::calculateGlyphWidth): Pass along extra chars in argument and chars consumed out
argument.
(WebCore::SVGInlineTextBox::calculateGlyphHeight): Pass along extra chars in argument.
(WebCore::SVGInlineTextBox::calculateGlyphBoundaries): Add boilerplate; may not handle multichar glyphs
right but I don't know what effects this would have.
* rendering/SVGInlineTextBox.h:
* rendering/SVGRootInlineBox.cpp:
(WebCore::cummulatedWidthOrHeightOfTextChunk): Add boilerplate; may not handle multichar glyphs right
but again I am not sure what effect this would have.
(WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox): Account for multichar glyphs - let glyph
selection consider extra chars, and account for the fact that a glyph may have consumed multiple chars.
* rendering/SVGRootInlineBox.h:
* svg/SVGFont.cpp:
(WebCore::SVGTextRunWalker::walk): This is the place where glyph selection happens, so this is where
we accout for multichar glyphs (both looking at extra chars past the end of the run, and reporting how
many chars were consumed).
(WebCore::floatWidthOfSubStringUsingSVGFont): Pass aforementioned info through the layers.
(WebCore::Font::floatWidthUsingSVGFont): ditto
(WebCore::Font::drawTextUsingSVGFont): ditto
(WebCore::Font::selectionRectForTextUsingSVGFont): ditto
* svg/SVGTextContentElement.cpp:
(WebCore::cummulatedCharacterRangeLength): ditto
(WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback): ditto
LayoutTests:
2008-03-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Maciej.
- test case and new results for "SVGTextElement.getStartPositionOfChar does not correctly account for multichar glyphs"
http://bugs.webkit.org/show_bug.cgi?id=18046
* svg/text/multichar-glyph.svg: Added. New test case for both rendering and getStartPositionOfChar
access of multichar glyphs.
* platform/mac/svg/text/multichar-glyph-expected.txt: Added.
The following test results changed, all appear to be improvements.
* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
* platform/mac/svg/text/text-altglyph-01-b-expected.txt:
* platform/mac/svg/text/text-text-06-t-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Wed, 26 Mar 2008 06:46:54 +0000 (06:46 +0000)]
WebCore:
2008-03-25 Beth Dakin <bdakin@apple.com>
Reviewed by Oliver.
Fix for <rdar://problem/5811826> CSSValueList::item() does not
range-check index
Check bounds before accessing the item to avoid a crash.
itemWithoutBoundsCheck() is still inlined and not bounds-checked to
avoid slowing down our internal callers of item().
* css/CSSValueList.cpp:
(WebCore::CSSValueList::item):
* css/CSSValueList.h:
(WebCore::CSSValueList::itemWithoutBoundsCheck):
Call itemWithoutBoundsCheck() to avoid slowing down these internal
callers.
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
* css/CSSStyleSelector.cpp:
(WebCore::applyCounterList):
(WebCore::CSSStyleSelector::applyProperty):
* css/MediaQueryEvaluator.cpp:
(WebCore::parseAspectRatio):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::rebuildFontFace):
* svg/graphics/SVGPaintServer.cpp:
(WebCore::dashArrayFromRenderingStyle):
LayoutTests:
2008-03-25 Beth Dakin <bdakin@apple.com>
Reviewed by Oliver.
Test for <rdar://problem/5811826> CSSValueList::item() does not
range-check index
* fast/css/resources/bikes.bmp: Added.
* fast/css/value-list-out-of-bounds-crash.html: Added.
* platform/mac/fast/css/value-list-out-of-bounds-crash-expected.checksum: Added.
* platform/mac/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
* platform/mac/fast/css/value-list-out-of-bounds-crash-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log